RFR: 5021949: JSplitPane setEnabled(false) shouldn't be partially functional [v3]
Abhishek Kumar
abhiscxk at openjdk.org
Fri Jun 14 10:15:18 UTC 2024
On Fri, 14 Jun 2024 09:28:28 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:
>> Issue is seen in that if we call setEnabled(false) over JSplitPane than it can't be dragged via its divider, But if SplitPane have one touch expandable true than user can click those buttons and change the divider position.
>> So, if splitpane is disabled, then both dragging in divider and one-touch-expandable click should be disabled.
>> Fix is made to override setEnabled and disable one-touch-expandable buttons actions..
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
>
> Omit gtk
Ran the test with suggested fix. Looks good to me.
test/jdk/javax/swing/JSplitPane/TestSplitPaneEnableTest.java line 57:
> 55: UIManager.setLookAndFeel(laf.getClassName());
> 56: } catch (UnsupportedLookAndFeelException ignored) {
> 57: System.out.println("Unsupported LAF: " + laf.getClassName());
May be updated to throw `jtreg.SkippedException`.
-------------
Marked as reviewed by abhiscxk (Committer).
PR Review: https://git.openjdk.org/jdk/pull/19695#pullrequestreview-2118024993
PR Review Comment: https://git.openjdk.org/jdk/pull/19695#discussion_r1639603739
More information about the client-libs-dev
mailing list