RFR: 8155030: The Menu Mnemonics are always displayed for GTK LAF [v6]

Phil Race prr at openjdk.org
Fri Jun 14 21:04:17 UTC 2024


On Fri, 14 Jun 2024 10:07:39 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> In GTK LAF, the menu mnemonics are always displayed which is different from the native behavior. In native application **(tested with gedit**), the menu mnemonics toggle on press of `ALT` key. Menu mnemonics are hidden initially and then toggles between show/hide on `ALT` press. 
>> Proposed fix is to handle the `ALT` key press for GTK LAF and mimic the native behavior. Fix is similar to the `ALT` key processing in  Windows LAF. Automated test case is added to verify the fix and tested in Ubuntu and Oracle linux.
>> 
>> CI testing is green and link attached in JBS.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   condition update

I am adding this comment NOT because I want to see a CSR - I think we should find a non-API fix, but because if I don't add it skara doesn't know that this isn't ready to integrate as it currently is written

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18992#issuecomment-2168757871


More information about the client-libs-dev mailing list