RFR: 8155030: The Menu Mnemonics are always displayed for GTK LAF [v6]
Alisen Chung
achung at openjdk.org
Sat Jun 15 00:26:15 UTC 2024
On Fri, 14 Jun 2024 20:22:42 GMT, Phil Race <prr at openjdk.org> wrote:
>> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
>>
>> condition update
>
> src/java.desktop/share/classes/javax/swing/plaf/synth/SynthGraphicsUtils.java line 785:
>
>> 783: }
>> 784:
>> 785: if (c instanceof Container) {
>
> JComponent extends Container .. so this will traverse everything in the Swing UI.
> Is there any pattern elsewhere in Swing you can use to short-circuit this ?
since this method should be recursing through all of a component's subcomponents, shouldn't there not even be an if check here?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18992#discussion_r1640558484
More information about the client-libs-dev
mailing list