RFR: 6967482: TAB-key does not work in JTables after selecting details-view in JFileChooser [v2]

[Tejesh R]

On Fri, 14 Jun 2024 20:17:29 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review fix - remove null initialization for table
>
> src/java.desktop/share/classes/sun/swing/FilePane.java line 1321:
> 
>> 1319: 
>> 1320:         // TAB/SHIFT-TAB should transfer focus and ENTER should select an item.
>> 1321:         // We don't want them to navigate within the table
> 
> what was the original purpose of this code? it seems like the code was placed here for a reason but maybe it's no longer relevant?

Yes, I hope now it is safe to remove these lines. Since TAB/SHIFT navigation is rejected with this [fix/line](https://github.com/openjdk/jdk/blame/5528ad74902fa4f4ec621d70e7e7d85f4ac1d780/src/java.desktop/share/classes/sun/swing/FilePane.java#L1314) which is further handled in BasicTableUI class ([Here](https://github.com/openjdk/jdk/blame/7b38bfea331437ad99277032de7fce939303abc8/src/java.desktop/share/classes/javax/swing/plaf/basic/BasicTableUI.java#L679)).

> test/jdk/javax/swing/JFileChooser/TABTestONFCExit.java line 54:
> 
>> 52:  */
>> 53: 
>> 54: public class TABTestONFCExit {
> 
> why is the test name capitalized like this?

Since TAB is Key representation, I have capitalized TAB, ON and FC (FileChooser). Hope that should be ok.

> test/jdk/javax/swing/JFileChooser/TABTestONFCExit.java line 55:
> 
>> 53: 
>> 54: public class TABTestONFCExit {
>> 55:     private static JTable table = null;
> 
> does this jtable need to be initialized as null here?

Not mandatory though, can remove.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19725#discussion_r1642307944
PR Review Comment: https://git.openjdk.org/jdk/pull/19725#discussion_r1642310592
PR Review Comment: https://git.openjdk.org/jdk/pull/19725#discussion_r1642311240