RFR: 8334509: Cancelling PageDialog does not return the same PageFormat object [v4]

[Alexey Ivanov]

On Thu, 20 Jun 2024 05:12:28 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> On cancelling PageDialog, same PageFormat object should be returned which stopped working after [JDK-8307160](https://bugs.openjdk.org/browse/JDK-8307160).
>> Fix is made to reinstate "doIt" flag removed in JDK-8307160 so that correct value is returned from PageDialog.show action..
>> An automated printing testcase is created since the issue was caught by manual test and so having another manual test run the risk of not being executed during CI testing..
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Test fix headful

Marked as reviewed by aivanov (Reviewer).

test/jdk/java/awt/print/PrinterJob/PageDialogCancelTest.java line 49:

> 47:             robot.keyPress(KeyEvent.VK_ESCAPE);
> 48:             robot.keyRelease(KeyEvent.VK_ESCAPE);
> 49:             robot.waitForIdle();

I think `waitForIdle` is redundant here: the thread doesn't do anything after pressing `VK_ESCAPE`.

-------------

PR Review: https://git.openjdk.org/jdk/pull/19786#pullrequestreview-2130079193
PR Review Comment: https://git.openjdk.org/jdk/pull/19786#discussion_r1647379108