RFR: 8332103: since-checker - Add missing @ since tags to java.desktop [v2]
Alexey Ivanov
aivanov at openjdk.org
Thu Jun 20 13:25:11 UTC 2024
On Wed, 15 May 2024 03:38:29 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:
>> If you're currently reviewing this PR, thank you!
>> Most fixes here are according to the reports by the since checker tool in #18934 and are pretty simple.
>>
>> To make reviewing easier
>> - `BasicSliderUI` has the constructor `public BasicSliderUI(JSlider b)` for a long time so the default constructor (without parameters) didn't exist until JDK 16
>>
>> For the `package-info` files, it is pretty hard to find source code of JDK 1-5 so I used the `grep` command to find the oldest instance of an `@since` in those packages.
>>
>> I found instances of `@since 1.1` in the other packages but `javax/swing/plaf/synth/package-info.java` might be worth checking as most classes there had no `@since`.
>
> Nizar Benalla has updated the pull request incrementally with one additional commit since the last revision:
>
> Swing was added in JDK 1.2
I verified all the added `@since` declarations, I found no inconsistencies.
The no-arg constructor `BasicSliderUI()` was added in 16, therefore `@since 16` is correct. The constructor will be deprecated and removed by the follow-up bugs.
-------------
Marked as reviewed by aivanov (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/19192#pullrequestreview-2130421950
More information about the client-libs-dev
mailing list