RFR: 8334580: Deprecate no-arg constructor BasicSliderUI() for removal

[Kevin Rushforth]

On Fri, 21 Jun 2024 03:31:50 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> The no-arg constructor BasicSliderUI() was added under [JDK-8250852](https://bugs.openjdk.org/browse/JDK-8250852) by mistake. This constructor should be deprecated for removal in future release

Changes requested by kcr (Author).

src/java.desktop/share/classes/javax/swing/plaf/basic/BasicSliderUI.java line 154:

> 152:      * Constructs a {@code BasicSliderUI}.
> 153:      */
> 154:     @Deprecated(since = "23")

You need to add `forRemoval = true` to deprecate this for removal. Also, we typically add a `@deprecated` javadoc tag in addition to the `@Deprecated` annotation.

-------------

PR Review: https://git.openjdk.org/jdk/pull/19819#pullrequestreview-2132422657
PR Review Comment: https://git.openjdk.org/jdk/pull/19819#discussion_r1648823338