RFR: 8155030: The Menu Mnemonics are always displayed for GTK LAF [v8]

[Abhishek Kumar]

On Fri, 21 Jun 2024 20:14:28 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove access modifier from method declaration
>
> src/java.desktop/share/classes/javax/swing/plaf/synth/SynthGraphicsUtils.java line 751:
> 
>> 749:      * Repaints all the components with the mnemonics in the given window and all its owned windows.
>> 750:      */
>> 751:     static void repaintMnemonicsInWindow(final Window w) {
> 
> The `repaintMnemonicsInWindow` and `repaintMnemonicsInContainer` are exactly the same as methods in `WindowsGraphicsUtils`. And `AquaMnemonicHandler` has yet another copy of the same code.
> 
> Is it possible to move these methods to a utility class that's available for all Look-and-Feels to avoid duplicating code?

I will check and update if it is possible.

>You can still write proper javadocs for members with any visibility, and IDE will show you the description of a method or a field when you hover over its usage anywhere in the code.
You already wrote the javadoc, leave them.
A regular comment won't be shown this way.

Should I revert it back to javadoc style comment ?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18992#discussion_r1650476132
PR Review Comment: https://git.openjdk.org/jdk/pull/18992#discussion_r1650475455