RFR: 8334509: Cancelling PageDialog does not return the same PageFormat object [v5]

Alexey Ivanov aivanov at openjdk.org
Mon Jun 24 14:21:20 UTC 2024


On Fri, 21 Jun 2024 15:51:29 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> On cancelling PageDialog, same PageFormat object should be returned which stopped working after [JDK-8307160](https://bugs.openjdk.org/browse/JDK-8307160).
>> Fix is made to reinstate "doIt" flag removed in JDK-8307160 so that correct value is returned from PageDialog.show action..
>> An automated printing testcase is created since the issue was caught by manual test and so having another manual test run the risk of not being executed during CI testing..
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   ALways return doIt

> /backport openjdk/jdk23u

@prsadhuk You should backport it to 23 which corresponds to `jdk23` branch in `jdk` repo. The command should look like this: `/backport :jdk23` or `/backport jdk jdk23`, see the [`/backport` command](https://wiki.openjdk.org/display/SKARA/Pull+Request+Commands#PullRequestCommands-/backport).

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19786#issuecomment-2186694016


More information about the client-libs-dev mailing list