RFR: 8334495: Use FFM instead of jdk.internal.misc.Unsafe in java.desktop font implementation [v2]

Phil Race prr at openjdk.org
Tue Jun 25 22:06:12 UTC 2024


On Tue, 25 Jun 2024 09:22:45 GMT, Per Minborg <pminborg at openjdk.org> wrote:

>> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8334495
>
> src/java.desktop/share/classes/sun/font/StrikeCache.java line 112:
> 
>> 110:      * references a memory address for a "null" glyph image.
>> 111:      */
>> 112:     static final int nativeAddressSize = (int)ValueLayout.ADDRESS.byteSize();
> 
> Suggestion: NATIVE_ADDRESS_SIZE

This name is already used although previously was not a final field.
I did consider capitalizing but I left it as is to avoid having to rename the uses.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19777#discussion_r1653621116


More information about the client-libs-dev mailing list