RFR: 5021949: JSplitPane setEnabled(false) shouldn't be partially functional [v3]

Prasanta Sadhukhan psadhukhan at openjdk.org
Wed Jun 26 09:00:28 UTC 2024


On Tue, 18 Jun 2024 12:19:39 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Omit gtk
>
> test/jdk/javax/swing/JSplitPane/TestSplitPaneEnableTest.java line 100:
> 
>> 98:                 robot.mouseMove(loc.x, loc.y);
>> 99:                 robot.mousePress(InputEvent.BUTTON1_DOWN_MASK);
>> 100:                 robot.mouseRelease(InputEvent.BUTTON1_DOWN_MASK);
> 
> Isn't it enough to verify the state of the buttons whether they're enabled or not. It should be simpler, it could be done without rendering the frame.

Ok..modified to just check for button state...

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19695#discussion_r1654415363


More information about the client-libs-dev mailing list