From gli at openjdk.org  Fri Mar  1 01:02:52 2024
From: gli at openjdk.org (Guoxiong Li)
Date: Fri, 1 Mar 2024 01:02:52 GMT
Subject: RFR: 8327040: Problemlist ActionListenerCalledTwiceTest.java test
 failing in macos14
In-Reply-To: <gi3j5ekJwfxGnzCPRtXX8lqSEYoHGIhoJ_yz1gY1DtE=.8acbaa71-d7cb-4c62-b4fb-a7ff87170d1c@github.com>
References: <gi3j5ekJwfxGnzCPRtXX8lqSEYoHGIhoJ_yz1gY1DtE=.8acbaa71-d7cb-4c62-b4fb-a7ff87170d1c@github.com>
Message-ID: <T-W186dbVRIr0zrRcYl_TK7juyPHfiljwowwp-GFLOw=.5ee7dfb6-3e15-4afe-8b2a-194421ba140d@github.com>

On Thu, 29 Feb 2024 11:00:33 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> javax/swing/JMenuItem/ActionListenerCalledTwice/ActionListenerCalledTwiceTest.java is failing in macos14 due to apple os upgrade. More information in [JDK-8316151](https://bugs.openjdk.org/browse/JDK-8316151)
> problemlist the test for now..

Looks good.

-------------

Marked as reviewed by gli (Committer).

PR Review: https://git.openjdk.org/jdk/pull/18058#pullrequestreview-1910131981

From psadhukhan at openjdk.org  Fri Mar  1 03:12:54 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Fri, 1 Mar 2024 03:12:54 GMT
Subject: Integrated: 8327040: Problemlist ActionListenerCalledTwiceTest.java
 test failing in macos14
In-Reply-To: <gi3j5ekJwfxGnzCPRtXX8lqSEYoHGIhoJ_yz1gY1DtE=.8acbaa71-d7cb-4c62-b4fb-a7ff87170d1c@github.com>
References: <gi3j5ekJwfxGnzCPRtXX8lqSEYoHGIhoJ_yz1gY1DtE=.8acbaa71-d7cb-4c62-b4fb-a7ff87170d1c@github.com>
Message-ID: <TDArHi2qoESG1ZAAgx1DcAvnYFyKHgsVS0Wd_Cd8iNY=.c11801c3-1de4-4938-8315-1f744ed6e7f5@github.com>

On Thu, 29 Feb 2024 11:00:33 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> javax/swing/JMenuItem/ActionListenerCalledTwice/ActionListenerCalledTwiceTest.java is failing in macos14 due to apple os upgrade. More information in [JDK-8316151](https://bugs.openjdk.org/browse/JDK-8316151)
> problemlist the test for now..

This pull request has now been integrated.

Changeset: 0d354503
Author:    Prasanta Sadhukhan <psadhukhan at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/0d354503620eb7f6da7b1b8aa6143ba18ced8f12
Stats:     1 line in 1 file changed: 1 ins; 0 del; 0 mod

8327040: Problemlist ActionListenerCalledTwiceTest.java test failing in macos14

Reviewed-by: prr, gli

-------------

PR: https://git.openjdk.org/jdk/pull/18058

From psadhukhan at openjdk.org  Fri Mar  1 03:17:46 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Fri, 1 Mar 2024 03:17:46 GMT
Subject: RFR: 8327007: javax/swing/JSpinner/8008657/bug8008657.java fails
In-Reply-To: <e_F-RYcAjzGOzHQL95zVz5z77cSdPDKpnPzuN3ExsNM=.9615c27e-92d5-4a10-8e34-be66ef6883aa@github.com>
References: <e_F-RYcAjzGOzHQL95zVz5z77cSdPDKpnPzuN3ExsNM=.9615c27e-92d5-4a10-8e34-be66ef6883aa@github.com>
Message-ID: <4VfJO0JRZ561Q7HqCiEe7TcB50MQVCjZxiX2h7zDQjk=.c0dc6e35-ce4a-48c9-a321-059929d85469@github.com>

On Thu, 29 Feb 2024 09:34:05 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> Test failed with the exception java.lang.IllegalArgumentException: (start <= value <= end) with no history of failing till date.
> Investigation shows SpinnerDateModel constructor condition is not satisfied because
> It seems it's a leap year problem that is being manifested..
> 
> As per test,
> initDate Thu Feb 29 13:49:08 IST 2024 [ obtained by calendar.getTime();]
> earliestDate Tue Feb 28 13:49:08 IST 2023 [obtained by calendar.add(Calendar.YEAR, -1);]
> latestDate Wed Feb 28 13:49:08 IST 2024 [obtained by calendar.add(Calendar.YEAR, 1);]
> 
> Now, as per SpinnerDateModel constructor
> earliestDate <= initDate condition is satisfied
> but
> latestDate >= initDate is not
> so [start <= value <= end](https://github.com/openjdk/jdk/blob/998d0baab0fd051c38d9fd6021628eb863b80554/src/java.desktop/share/classes/javax/swing/SpinnerDateModel.java#L185) condition fails
> 
> Not sure it anything can be done in Calendar class for this but fix is done in test taking leapyear into account so that we add a day if it's a leapyear when we consecutively do Calendar.add(YEAR, -1) and Calendar.add(YEAR,1) on leapyear date of 29Feb

> Surely this just needs a one line fix
> 
> diff --git a/test/jdk/javax/swing/JSpinner/8008657/bug8008657.java b/test/jdk/javax/swing/JSpinner/8008657/bug8008657.java
> index cbeb0c185bb..49918278e34 100644
> --- a/test/jdk/javax/swing/JSpinner/8008657/bug8008657.java
> +++ b/test/jdk/javax/swing/JSpinner/8008657/bug8008657.java
> @@ -137,6 +137,7 @@ static void createDateSpinner() {
>          calendar.add(Calendar.YEAR, -1);
>          Date earliestDate = calendar.getTime();
>          calendar.add(Calendar.YEAR, 1);
> +        calendar.add(Calendar.DAY_OF_MONTH, 1);
>          Date latestDate = calendar.getTime();
>          SpinnerModel dateModel = new SpinnerDateModel(initDate,
>                  earliestDate,

Yes, I did thought about that but thought should we do it irrespectively of leap year or not, so atlast I thought of doing it for leapyear only so that it doesn't affect anyother scenarios...
But if you want to add 1 day to it irrespectively and cutshort the added code, I can do it too...

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18054#issuecomment-1972396322

From srl at openjdk.org  Fri Mar  1 06:17:11 2024
From: srl at openjdk.org (Steven Loomis)
Date: Fri, 1 Mar 2024 06:17:11 GMT
Subject: RFR: 8195675: Call to insertText with single character from custom
 Input Method ignored
Message-ID: <70yOUGT0N_mI3Pq8UVS-KgUAzZbtRhFniW8U16iVtlk=.7d6edddb-d68b-4b98-aaaf-1e60224dee0b@github.com>

8195675: Call to insertText with single character from custom Input Method ignored

-------------

Commit messages:
 - 8195675: Update AWTView.m
 - 8195675: [MacOS] fix Keyman input methods on mac

Changes: https://git.openjdk.org/jdk/pull/17921/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=17921&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8195675
  Stats: 5 lines in 1 file changed: 3 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/17921.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17921/head:pull/17921

PR: https://git.openjdk.org/jdk/pull/17921

From prr at openjdk.org  Fri Mar  1 07:04:55 2024
From: prr at openjdk.org (Phil Race)
Date: Fri, 1 Mar 2024 07:04:55 GMT
Subject: RFR: 8185862: AWT Assertion Failure in ::GetDIBits(hBMDC, hBM, 0, 
 1, 0, gpBitmapInfo, 0) 'awt_Win32GraphicsDevice.cpp', at line 185 [v7]
In-Reply-To: <OItsk8uTpJR2VK4ZfPHLbVWMloGEGvHxOU9hDN8XnLI=.09789dcd-00a8-49f6-b03c-0e21be5f36d8@github.com>
References: <Cj_htOZE6ImXdNmj43IBiX7rW4Em4ZF-6kx0qIZW-Ho=.d355fedd-7ec8-463d-969b-e2123987d1dd@github.com>
 <OItsk8uTpJR2VK4ZfPHLbVWMloGEGvHxOU9hDN8XnLI=.09789dcd-00a8-49f6-b03c-0e21be5f36d8@github.com>
Message-ID: <wb65B53Gb9q-5XOt7jyGTqltBHGamphoMstGBLOqnJk=.85f7a710-ddc6-499d-91e0-5d64e9da9ca1@github.com>

On Thu, 29 Feb 2024 22:24:14 GMT, Christoph Langer <clanger at openjdk.org> wrote:

>> The assertions reported in the bug were observed spuriously and here and there broke tests in some Windows configurations.
>> For instance [JDK-8266129](https://bugs.openjdk.org/browse/JDK-8266129), [JDK-8269529](https://bugs.openjdk.org/browse/JDK-8269529) or [JDK-8323664](https://bugs.openjdk.org/browse/JDK-8323664) came up due to this.
>> 
>> The problem is that in Windows environments without a valid display, e.g. started by system services or via PowerShell Remoting, one sees a Monitor with name 'Windisc' in `EnumDisplayMonitors`.
>> However, it seems to be some kind of a pseudo device where you can not get a DC via `CreateDC`. This behavior/monitor type doesn't seem to be well documented, though.
>> 
>> I hereby modify the device initialization code to only count/detect monitors where CreateDC returns non-NULL in Devices.cpp. I also add some more checking/error handling to AwtWin32GraphicsDevice::Initialize() for correctness.
>> 
>> Furthermore, I re-enable the test `javax/swing/reliability/HangDuringStaticInitialization.java` for Windows Debug VMs, which reverts the fix from JDK-8269529 that should not be necessary any more.
>
> Christoph Langer has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 11 additional commits since the last revision:
> 
>  - Change implementation of headless determination on Windows
>  - Merge branch 'master' into JDK-8185862
>  - Reflect display detection in java.awt.GraphicsEnvironment::isHeadless()
>  - Merge branch 'master' into JDK-8185862
>  - Get rid of global variables and restore old handling wrt calling ::GetDIBits
>  - Merge branch 'master' into JDK-8185862
>  - Little cleanup
>  - Review Feedback Alexey
>  - Merge branch 'master' into JDK-8185862
>  - Add comments
>  - ... and 1 more: https://git.openjdk.org/jdk/compare/db1cc14f...f43da52f

Does this new version really work for you ??


I'm getting 
Execution failed: `main' threw exception: java.lang.UnsatisfiedLinkError: 'boolean sun.awt.PlatformGraphicsInfo.hasDisplays0()'

eg from
 java\awt\Modal\ModalBlockingTests\UnblockedDialogAppModalTest.java

It is at least 840 tests that fail .. 

Since I do see the method in your change  .. and in my local copy too, I assume I correctly applied your patch 
+Java_sun_awt_PlatformGraphicsInfo_hasDisplays0(JNIEnv *env, jclass thisClass) {

.. so  I wonder if awt.dll is not loaded in time ? It isn't on demand.
It needs an explicit loadLibrary("awt") on all paths that can't rely on something else to do it.
What tests did you run and in what environment ?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17614#issuecomment-1972620307

From clanger at openjdk.org  Fri Mar  1 08:01:08 2024
From: clanger at openjdk.org (Christoph Langer)
Date: Fri, 1 Mar 2024 08:01:08 GMT
Subject: RFR: 8185862: AWT Assertion Failure in ::GetDIBits(hBMDC, hBM, 0, 
 1, 0, gpBitmapInfo, 0) 'awt_Win32GraphicsDevice.cpp', at line 185 [v8]
In-Reply-To: <Cj_htOZE6ImXdNmj43IBiX7rW4Em4ZF-6kx0qIZW-Ho=.d355fedd-7ec8-463d-969b-e2123987d1dd@github.com>
References: <Cj_htOZE6ImXdNmj43IBiX7rW4Em4ZF-6kx0qIZW-Ho=.d355fedd-7ec8-463d-969b-e2123987d1dd@github.com>
Message-ID: <yLFbIvVt-ZuGKMVJvXx19rUxVgG1-ewJwM5SAEzoUvo=.15df7df6-0c62-4c60-837c-33fdf90eab11@github.com>

> The assertions reported in the bug were observed spuriously and here and there broke tests in some Windows configurations.
> For instance [JDK-8266129](https://bugs.openjdk.org/browse/JDK-8266129), [JDK-8269529](https://bugs.openjdk.org/browse/JDK-8269529) or [JDK-8323664](https://bugs.openjdk.org/browse/JDK-8323664) came up due to this.
> 
> The problem is that in Windows environments without a valid display, e.g. started by system services or via PowerShell Remoting, one sees a Monitor with name 'Windisc' in `EnumDisplayMonitors`.
> However, it seems to be some kind of a pseudo device where you can not get a DC via `CreateDC`. This behavior/monitor type doesn't seem to be well documented, though.
> 
> I hereby modify the device initialization code to only count/detect monitors where CreateDC returns non-NULL in Devices.cpp. I also add some more checking/error handling to AwtWin32GraphicsDevice::Initialize() for correctness.
> 
> Furthermore, I re-enable the test `javax/swing/reliability/HangDuringStaticInitialization.java` for Windows Debug VMs, which reverts the fix from JDK-8269529 that should not be necessary any more.

Christoph Langer has updated the pull request incrementally with one additional commit since the last revision:

  load awt.dll before display check

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/17614/files
  - new: https://git.openjdk.org/jdk/pull/17614/files/f43da52f..7a00a647

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=17614&range=07
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17614&range=06-07

  Stats: 17 lines in 1 file changed: 16 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/17614.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17614/head:pull/17614

PR: https://git.openjdk.org/jdk/pull/17614

From clanger at openjdk.org  Fri Mar  1 08:01:10 2024
From: clanger at openjdk.org (Christoph Langer)
Date: Fri, 1 Mar 2024 08:01:10 GMT
Subject: RFR: 8185862: AWT Assertion Failure in ::GetDIBits(hBMDC, hBM, 0, 
 1, 0, gpBitmapInfo, 0) 'awt_Win32GraphicsDevice.cpp', at line 185 [v7]
In-Reply-To: <OItsk8uTpJR2VK4ZfPHLbVWMloGEGvHxOU9hDN8XnLI=.09789dcd-00a8-49f6-b03c-0e21be5f36d8@github.com>
References: <Cj_htOZE6ImXdNmj43IBiX7rW4Em4ZF-6kx0qIZW-Ho=.d355fedd-7ec8-463d-969b-e2123987d1dd@github.com>
 <OItsk8uTpJR2VK4ZfPHLbVWMloGEGvHxOU9hDN8XnLI=.09789dcd-00a8-49f6-b03c-0e21be5f36d8@github.com>
Message-ID: <rFvEdbCEXC91tOYyE53K51aW6yECERLE3ujDsuFvUM8=.1740d854-c387-4eef-9cd5-ba80d23f4115@github.com>

On Thu, 29 Feb 2024 22:24:14 GMT, Christoph Langer <clanger at openjdk.org> wrote:

>> The assertions reported in the bug were observed spuriously and here and there broke tests in some Windows configurations.
>> For instance [JDK-8266129](https://bugs.openjdk.org/browse/JDK-8266129), [JDK-8269529](https://bugs.openjdk.org/browse/JDK-8269529) or [JDK-8323664](https://bugs.openjdk.org/browse/JDK-8323664) came up due to this.
>> 
>> The problem is that in Windows environments without a valid display, e.g. started by system services or via PowerShell Remoting, one sees a Monitor with name 'Windisc' in `EnumDisplayMonitors`.
>> However, it seems to be some kind of a pseudo device where you can not get a DC via `CreateDC`. This behavior/monitor type doesn't seem to be well documented, though.
>> 
>> I hereby modify the device initialization code to only count/detect monitors where CreateDC returns non-NULL in Devices.cpp. I also add some more checking/error handling to AwtWin32GraphicsDevice::Initialize() for correctness.
>> 
>> Furthermore, I re-enable the test `javax/swing/reliability/HangDuringStaticInitialization.java` for Windows Debug VMs, which reverts the fix from JDK-8269529 that should not be necessary any more.
>
> Christoph Langer has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 11 additional commits since the last revision:
> 
>  - Change implementation of headless determination on Windows
>  - Merge branch 'master' into JDK-8185862
>  - Reflect display detection in java.awt.GraphicsEnvironment::isHeadless()
>  - Merge branch 'master' into JDK-8185862
>  - Get rid of global variables and restore old handling wrt calling ::GetDIBits
>  - Merge branch 'master' into JDK-8185862
>  - Little cleanup
>  - Review Feedback Alexey
>  - Merge branch 'master' into JDK-8185862
>  - Add comments
>  - ... and 1 more: https://git.openjdk.org/jdk/compare/0924cb1e...f43da52f

You're right, the awt lib needs to be loaded before checking isHeadless().

I just looked at the crash in test test/jdk/javax/swing/plaf/windows/6921687/bug6921687.java and resolved it. But the test obviously is not concerned about the headless environment so it doesn't stress that code path.

I reproduced the problem with a simple program that just calls GraphicsEnvironment.isHeadless() and fixed it. Please try the headless tests again.

Thanks a lot for your help!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17614#issuecomment-1972696714

From gli at openjdk.org  Fri Mar  1 10:16:42 2024
From: gli at openjdk.org (Guoxiong Li)
Date: Fri, 1 Mar 2024 10:16:42 GMT
Subject: RFR: 8286759: TextComponentPrintable: consequent -> consecutive
 positions
In-Reply-To: <CTbRheJJ9yn-OaBNP3gBAhiEfSCS2K9nOXuyuVal9Ns=.72f8155d-78b0-4ec7-93f5-9457b235a205@github.com>
References: <CTbRheJJ9yn-OaBNP3gBAhiEfSCS2K9nOXuyuVal9Ns=.72f8155d-78b0-4ec7-93f5-9457b235a205@github.com>
Message-ID: <PdphJlM7XjsCiz1pyKr3b2dhSM4ARAFxdNIfwpwtvj0=.e6c77a02-4bd3-43ee-abf7-190924f4c765@github.com>

On Thu, 29 Feb 2024 15:13:16 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> A trivial change in a comment: consequent ? _consecutive_ positions.
> 
> This was found in [a code review](https://github.com/openjdk/jdk/pull/8328#discussion_r872596373) for [JDK-8285306](https://bugs.openjdk.org/browse/JDK-8285306).

Looks good.

-------------

Marked as reviewed by gli (Committer).

PR Review: https://git.openjdk.org/jdk/pull/18067#pullrequestreview-1910785862

From abhiscxk at openjdk.org  Fri Mar  1 10:24:45 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Fri, 1 Mar 2024 10:24:45 GMT
Subject: RFR: 8326458: Menu mnemonic doesn't toggle between show and hide
 in Windows LAF when F10 is pressed. [v2]
In-Reply-To: <9ZScjChjnZVtMVj6kU_bM-f9FHuBGQx9-ttkX-7xuFk=.9d28d2ba-85b2-4159-96ec-d4cd98cc1fd9@github.com>
References: <uv53ohrzj-j8wA3SHr7M0b5V-Ja9HvKGBa2RgWTwoSU=.abf8c336-4b24-479c-af6d-22acb686ed80@github.com>
 <W8mvmh8x1r6-BcK6yA0Hu6A5TVmR_K9PV3F7izPS-B4=.b63757af-e5cd-4b7c-85a4-ff04712bacb5@github.com>
 <QfUgWPilkz4dAyrbtjHReaPgWSONlKGUk7NGZeB691A=.4d6fbcb8-1d95-4849-a683-f3538b11422c@github.com>
 <VaX-h-VG0A9V-CUxCkT_WFH2RZZ6_B-OufZg0q8KdLM=.7e7dc619-603f-42f2-a4e9-34310c3da9f2@github.com>
 <9ZScjChjnZVtMVj6kU_bM-f9FHuBGQx9-ttkX-7xuFk=.9d28d2ba-85b2-4159-96ec-d4cd98cc1fd9@github.com>
Message-ID: <MXiLdraDlYBQPCr9Qgo2YheTPKwolbHpx3Y8K8_PVb0=.0485b062-3513-4d07-ae4e-c0bfa541bbcf@github.com>

On Thu, 29 Feb 2024 11:24:38 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> You could add @modules java.desktop/com.sun.java.swing.plaf.windows to jtreg tags and access the com.sun.java.swing.plaf.windows.WindowsLookAndFeel.isMnemonicHidden method to verify that the mnemonics are shown or hidden based on how many times you (the Robot) pressed F10 key as well as the menu bar is active or not.

How to check for menubar whether it is active or not? Should I check the keyboard focus?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17961#issuecomment-1972919487

From abhiscxk at openjdk.org  Fri Mar  1 10:38:21 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Fri, 1 Mar 2024 10:38:21 GMT
Subject: RFR: 8075917: The regression-swing case failed as the text on
 label is not painted red with the GTK L&F [v4]
In-Reply-To: <iDOTnLkAimOa5kfDerZ09n4wsYiFYYUyBflOTYeUQZ0=.293390bd-bc47-4871-bf4c-d23c191d9426@github.com>
References: <iDOTnLkAimOa5kfDerZ09n4wsYiFYYUyBflOTYeUQZ0=.293390bd-bc47-4871-bf4c-d23c191d9426@github.com>
Message-ID: <Ej-GFWOSzjZzXeFgJ_XRD5amCJEBFnTw3Xwe6R7yWOM=.c9587e9a-7129-4683-8568-c5a56bd4009c@github.com>

> JLabel text is not painted with the LAF defined foreground color in GTK LAF. In GTK LAF the foreground color is retrieved by using native system APIs. Fix is to return the foreground color if it is set by LAF defined property otherwise return the default color by calling native APIs.
> Applet based test has been converted to automatic test and check for all installed LAFs. CI testing is green for test suite and individual test. Link attached in JBS.

Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:

  extended fix for disabled checkbox and radiobutton

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/17763/files
  - new: https://git.openjdk.org/jdk/pull/17763/files/4403e6cc..2ccca3f3

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=17763&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17763&range=02-03

  Stats: 19 lines in 3 files changed: 16 ins; 1 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/17763.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17763/head:pull/17763

PR: https://git.openjdk.org/jdk/pull/17763

From abhiscxk at openjdk.org  Fri Mar  1 10:42:55 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Fri, 1 Mar 2024 10:42:55 GMT
Subject: RFR: 8075917: The regression-swing case failed as the text on
 label is not painted red with the GTK L&F [v4]
In-Reply-To: <Ej-GFWOSzjZzXeFgJ_XRD5amCJEBFnTw3Xwe6R7yWOM=.c9587e9a-7129-4683-8568-c5a56bd4009c@github.com>
References: <iDOTnLkAimOa5kfDerZ09n4wsYiFYYUyBflOTYeUQZ0=.293390bd-bc47-4871-bf4c-d23c191d9426@github.com>
 <Ej-GFWOSzjZzXeFgJ_XRD5amCJEBFnTw3Xwe6R7yWOM=.c9587e9a-7129-4683-8568-c5a56bd4009c@github.com>
Message-ID: <ZhIDU5vYGw3Jx_0TeCJIYeg-lPoTYjGmsgAzqMr3TXg=.82a33d5b-5a46-4fa2-880c-d0c896da97e8@github.com>

On Fri, 1 Mar 2024 10:38:21 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> JLabel text is not painted with the LAF defined foreground color in GTK LAF. In GTK LAF the foreground color is retrieved by using native system APIs. Fix is to return the foreground color if it is set by LAF defined property otherwise return the default color by calling native APIs.
>> Applet based test has been converted to automatic test and check for all installed LAFs. CI testing is green for test suite and individual test. Link attached in JBS.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   extended fix for disabled checkbox and radiobutton

@prsadhuk I have assigned [JDK-8298153](https://bugs.openjdk.org/browse/JDK-8298153) to me and extended the fix for checkbox and radiobutton here. Fix can be verified using the existing test `test/jdk/javax/swing/JRadioButton/4314194/bug4314194.java`.
Removed the test `javax/swing/JRadioButton/4314194/bug4314194.java` from problemlist and tested in CI which is ok.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17763#issuecomment-1972947440

From aivanov at openjdk.org  Fri Mar  1 10:44:43 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Fri, 1 Mar 2024 10:44:43 GMT
Subject: RFR: 8326458: Menu mnemonic doesn't toggle between show and hide
 in Windows LAF when F10 is pressed. [v2]
In-Reply-To: <MXiLdraDlYBQPCr9Qgo2YheTPKwolbHpx3Y8K8_PVb0=.0485b062-3513-4d07-ae4e-c0bfa541bbcf@github.com>
References: <uv53ohrzj-j8wA3SHr7M0b5V-Ja9HvKGBa2RgWTwoSU=.abf8c336-4b24-479c-af6d-22acb686ed80@github.com>
 <W8mvmh8x1r6-BcK6yA0Hu6A5TVmR_K9PV3F7izPS-B4=.b63757af-e5cd-4b7c-85a4-ff04712bacb5@github.com>
 <QfUgWPilkz4dAyrbtjHReaPgWSONlKGUk7NGZeB691A=.4d6fbcb8-1d95-4849-a683-f3538b11422c@github.com>
 <VaX-h-VG0A9V-CUxCkT_WFH2RZZ6_B-OufZg0q8KdLM=.7e7dc619-603f-42f2-a4e9-34310c3da9f2@github.com>
 <9ZScjChjnZVtMVj6kU_bM-f9FHuBGQx9-ttkX-7xuFk=.9d28d2ba-85b2-4159-96ec-d4cd98cc1fd9@github.com>
 <MXiLdraDlYBQPCr9Qgo2YheTPKwolbHpx3Y8K8_PVb0=.0485b062-3513-4d07-ae4e-c0bfa541bbcf@github.com>
Message-ID: <4b2Qpx83gAuZrUoUa25JRTWn9T55lfU1ysvrIyYMbgI=.3401db3e-b7b3-4086-bf72-1d154609b1fe@github.com>

On Fri, 1 Mar 2024 10:22:16 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

> > You could add @modules java.desktop/com.sun.java.swing.plaf.windows to jtreg tags and access the com.sun.java.swing.plaf.windows.WindowsLookAndFeel.isMnemonicHidden method to verify that the mnemonics are shown or hidden based on how many times you (the Robot) pressed F10 key as well as the menu bar is active or not.
> 
> How to check for menubar whether it is active or not? Should I check the keyboard focus?

You have it in the code:


               MenuElement[] selectedPath = msm.getSelectedPath();
               if (selectedPath.length > 0 && (selectedPath[0] instanceof JMenuBar)) {

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17961#issuecomment-1972951361

From abhiscxk at openjdk.org  Fri Mar  1 11:39:09 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Fri, 1 Mar 2024 11:39:09 GMT
Subject: RFR: 8326458: Menu mnemonic doesn't toggle between show and hide
 in Windows LAF when F10 is pressed. [v4]
In-Reply-To: <uv53ohrzj-j8wA3SHr7M0b5V-Ja9HvKGBa2RgWTwoSU=.abf8c336-4b24-479c-af6d-22acb686ed80@github.com>
References: <uv53ohrzj-j8wA3SHr7M0b5V-Ja9HvKGBa2RgWTwoSU=.abf8c336-4b24-479c-af6d-22acb686ed80@github.com>
Message-ID: <NPbekobpwpYTzuF0jzlN276j6ZYSzbD-NOxnijY90XA=.c6b9fcc6-3826-4bee-a8d7-cc80514f29be@github.com>

> Menu mnemonic doesn't toggle between show and hide state when F10 is pressed. Behavior is not similar to windows native application. Fix is to ensure that menu mnemonic state toggles between show and hide.
> 
> Can be verified with SwingSet2 application. 
> CI tests are green with the fix. Link posted in JBS.

Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:

  Test case added

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/17961/files
  - new: https://git.openjdk.org/jdk/pull/17961/files/5a0643f5..3adc468d

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=17961&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17961&range=02-03

  Stats: 136 lines in 2 files changed: 133 ins; 3 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/17961.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17961/head:pull/17961

PR: https://git.openjdk.org/jdk/pull/17961

From abhiscxk at openjdk.org  Fri Mar  1 11:39:09 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Fri, 1 Mar 2024 11:39:09 GMT
Subject: RFR: 8326458: Menu mnemonic doesn't toggle between show and hide
 in Windows LAF when F10 is pressed. [v3]
In-Reply-To: <dJqVoVTuHsVobqEbCNMKBeEdRV-Ph_pN722X1XAg-yk=.d6e3fe81-e6ee-4e3d-a126-f574d15c770c@github.com>
References: <uv53ohrzj-j8wA3SHr7M0b5V-Ja9HvKGBa2RgWTwoSU=.abf8c336-4b24-479c-af6d-22acb686ed80@github.com>
 <dJqVoVTuHsVobqEbCNMKBeEdRV-Ph_pN722X1XAg-yk=.d6e3fe81-e6ee-4e3d-a126-f574d15c770c@github.com>
Message-ID: <3m33F5uJ8mU3M-VjRlWlCkt8__2gUbhlg923a4ZPbKc=.2cbf97e8-3353-4d9e-8d5c-1763b17d4ec5@github.com>

On Thu, 29 Feb 2024 07:48:09 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Menu mnemonic doesn't toggle between show and hide state when F10 is pressed. Behavior is not similar to windows native application. Fix is to ensure that menu mnemonic state toggles between show and hide.
>> 
>> Can be verified with SwingSet2 application. 
>> CI tests are green with the fix. Link posted in JBS.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review comment update

> > > You could add @modules java.desktop/com.sun.java.swing.plaf.windows to jtreg tags and access the com.sun.java.swing.plaf.windows.WindowsLookAndFeel.isMnemonicHidden method to verify that the mnemonics are shown or hidden based on how many times you (the Robot) pressed F10 key as well as the menu bar is active or not.
> > 
> > 
> > How to check for menubar whether it is active or not? Should I check the keyboard focus?
> 
> You have it in the code:
> 
> ```java
>                MenuElement[] selectedPath = msm.getSelectedPath();
>                if (selectedPath.length == 0) {
>                    throw new RuntimeException();
>                }
>                if (selectedPath[0] != menuBar || selectedPath[1] != fileMenu) {
>                    throw new RuntimeException();
>                }
> ```
> 
> where menuBar is the `JMenuBar` that you created in the test and `fileMenu` is the first `JMenu` in the menu bar.

Added the test case.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17961#issuecomment-1973029404

From aivanov at openjdk.org  Fri Mar  1 15:20:53 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Fri, 1 Mar 2024 15:20:53 GMT
Subject: RFR: 8326458: Menu mnemonic doesn't toggle between show and hide
 in Windows LAF when F10 is pressed. [v4]
In-Reply-To: <NPbekobpwpYTzuF0jzlN276j6ZYSzbD-NOxnijY90XA=.c6b9fcc6-3826-4bee-a8d7-cc80514f29be@github.com>
References: <uv53ohrzj-j8wA3SHr7M0b5V-Ja9HvKGBa2RgWTwoSU=.abf8c336-4b24-479c-af6d-22acb686ed80@github.com>
 <NPbekobpwpYTzuF0jzlN276j6ZYSzbD-NOxnijY90XA=.c6b9fcc6-3826-4bee-a8d7-cc80514f29be@github.com>
Message-ID: <9JVE-TH49B-kvVvfCjSKqvdGUwKnTzJXG1JX7QjSERk=.1564aa9c-26ae-4c46-bc66-fe588cfb403a@github.com>

On Fri, 1 Mar 2024 11:39:09 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Menu mnemonic doesn't toggle between show and hide state when F10 is pressed. Behavior is not similar to windows native application. Fix is to ensure that menu mnemonic state toggles between show and hide.
>> 
>> Can be verified with SwingSet2 application. 
>> CI tests are green with the fix. Link posted in JBS.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Test case added

Changes requested by aivanov (Reviewer).

src/java.desktop/windows/classes/com/sun/java/swing/plaf/windows/WindowsMenuBarUI.java line 1:

> 1: /*

Please, update the copyright year.

test/jdk/javax/swing/JMenu/TestMenuMnemonic.java line 1:

> 1: /*

You're modifying `WindowsMenuBarUI`, so the test belongs under `JMenuBar`.

test/jdk/javax/swing/JMenu/TestMenuMnemonic.java line 31:

> 29:  * @modules java.desktop/com.sun.java.swing.plaf.windows
> 30:  * @summary Verifies if menu mnemonics toggle between show or hide
> 31:  *          on F10 press in windows LAF.

?Between? implies ?and? (instead of ?or?).

However, we can drop that part completely as ?toggle? implies it changes from on to off and so on.
Suggestion:

 * @summary Verifies if menu mnemonics toggle on F10 press in Windows LAF

test/jdk/javax/swing/JMenu/TestMenuMnemonic.java line 66:

> 64:             SwingUtilities.invokeAndWait(() -> {
> 65:                 createAndShowUI();
> 66:             });

I'm for using method references:
Suggestion:

            SwingUtilities.invokeAndWait(TestMenuMnemonic::createAndShowUI);

test/jdk/javax/swing/JMenu/TestMenuMnemonic.java line 75:

> 73:                 robot.waitForIdle();
> 74:                 robot.delay(50);
> 75:                 robot.keyRelease(KeyEvent.VK_F10);

You should add `robot.waitForIdle()` to allow the test to process the key release event.

test/jdk/javax/swing/JMenu/TestMenuMnemonic.java line 84:

> 82:                     if (selectedPath.length != 0) {
> 83:                         throw new RuntimeException("Menubar is active even after" +
> 84:                                 " mnemonics are hidden");

Suggestion:

                        throw new RuntimeException("Menubar is active after" +
                                " mnemonics are hidden");


Is the line too long without wrapping?

test/jdk/javax/swing/JMenu/TestMenuMnemonic.java line 89:

> 87:                     mnemonicShowCount++;
> 88:                     if (selectedPath.length == 0 &&
> 89:                         (selectedPath[0] != menuBar || selectedPath[1] != fileMenu)) {

Suggestion:

                    if (selectedPath.length != 2
                        || selectedPath[0] != menuBar
                        || selectedPath[1] != fileMenu) {

You expect the selected path length to be 2 ? if it's not, it's a failure.

test/jdk/javax/swing/JMenu/TestMenuMnemonic.java line 94:

> 92:                     }
> 93:                 }
> 94:             }

Swing is not thread-safe therefore `MenuSelectionManager` as well as `WindowsLookAndFeel.isMnemonicHidden()` are to be called on EDT.

Because of that, you should use `AtomicInteger` and its `getAndIncrement()` method to increase the counter; then use `get()` to get the accumulated value on the main thread to verify.

test/jdk/javax/swing/JMenu/TestMenuMnemonic.java line 96:

> 94:             }
> 95:             robot.waitForIdle();
> 96:             robot.delay(1000);

There's no need for any delays after the for-loop.

test/jdk/javax/swing/JMenu/TestMenuMnemonic.java line 120:

> 118:         editMenu.setMnemonic(KeyEvent.VK_E);
> 119:         item1 = new JMenuItem("Item 1");
> 120:         item2 = new JMenuItem("Item 2");

`editMenu` as well as `item1` and `item2` aren't used outside of this method ? convert them to local variables.

test/jdk/javax/swing/JMenu/TestMenuMnemonic.java line 127:

> 125:         frame.setJMenuBar(menuBar);
> 126:         frame.pack();
> 127:         frame.setSize(250, 200);

Suggestion:

        frame.setSize(250, 200);

You set the size, `pack` is redundant.

-------------

PR Review: https://git.openjdk.org/jdk/pull/17961#pullrequestreview-1911373693
PR Review Comment: https://git.openjdk.org/jdk/pull/17961#discussion_r1509147894
PR Review Comment: https://git.openjdk.org/jdk/pull/17961#discussion_r1509147704
PR Review Comment: https://git.openjdk.org/jdk/pull/17961#discussion_r1509139166
PR Review Comment: https://git.openjdk.org/jdk/pull/17961#discussion_r1509140683
PR Review Comment: https://git.openjdk.org/jdk/pull/17961#discussion_r1509132518
PR Review Comment: https://git.openjdk.org/jdk/pull/17961#discussion_r1509134125
PR Review Comment: https://git.openjdk.org/jdk/pull/17961#discussion_r1509136261
PR Review Comment: https://git.openjdk.org/jdk/pull/17961#discussion_r1509131418
PR Review Comment: https://git.openjdk.org/jdk/pull/17961#discussion_r1509133750
PR Review Comment: https://git.openjdk.org/jdk/pull/17961#discussion_r1509143946
PR Review Comment: https://git.openjdk.org/jdk/pull/17961#discussion_r1509142739

From abhiscxk at openjdk.org  Fri Mar  1 16:05:07 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Fri, 1 Mar 2024 16:05:07 GMT
Subject: RFR: 8326458: Menu mnemonics don't toggle in Windows LAF when F10
 is pressed [v5]
In-Reply-To: <uv53ohrzj-j8wA3SHr7M0b5V-Ja9HvKGBa2RgWTwoSU=.abf8c336-4b24-479c-af6d-22acb686ed80@github.com>
References: <uv53ohrzj-j8wA3SHr7M0b5V-Ja9HvKGBa2RgWTwoSU=.abf8c336-4b24-479c-af6d-22acb686ed80@github.com>
Message-ID: <MBae7-qGN732DvQe3I4orB3EbRoT6vo1PoSoxcVLxtw=.26050b99-0d92-4bb8-9c8f-e8ed5844a931@github.com>

> Menu mnemonic doesn't toggle between show and hide state when F10 is pressed. Behavior is not similar to windows native application. Fix is to ensure that menu mnemonic state toggles between show and hide.
> 
> Can be verified with SwingSet2 application. 
> CI tests are green with the fix. Link posted in JBS.

Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:

  Review comment update

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/17961/files
  - new: https://git.openjdk.org/jdk/pull/17961/files/3adc468d..ec7b1a04

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=17961&range=04
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17961&range=03-04

  Stats: 261 lines in 3 files changed: 127 ins; 133 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/17961.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17961/head:pull/17961

PR: https://git.openjdk.org/jdk/pull/17961

From abhiscxk at openjdk.org  Fri Mar  1 16:05:07 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Fri, 1 Mar 2024 16:05:07 GMT
Subject: RFR: 8326458: Menu mnemonics don't toggle in Windows LAF when F10
 is pressed [v2]
In-Reply-To: <4b2Qpx83gAuZrUoUa25JRTWn9T55lfU1ysvrIyYMbgI=.3401db3e-b7b3-4086-bf72-1d154609b1fe@github.com>
References: <uv53ohrzj-j8wA3SHr7M0b5V-Ja9HvKGBa2RgWTwoSU=.abf8c336-4b24-479c-af6d-22acb686ed80@github.com>
 <W8mvmh8x1r6-BcK6yA0Hu6A5TVmR_K9PV3F7izPS-B4=.b63757af-e5cd-4b7c-85a4-ff04712bacb5@github.com>
 <QfUgWPilkz4dAyrbtjHReaPgWSONlKGUk7NGZeB691A=.4d6fbcb8-1d95-4849-a683-f3538b11422c@github.com>
 <VaX-h-VG0A9V-CUxCkT_WFH2RZZ6_B-OufZg0q8KdLM=.7e7dc619-603f-42f2-a4e9-34310c3da9f2@github.com>
 <9ZScjChjnZVtMVj6kU_bM-f9FHuBGQx9-ttkX-7xuFk=.9d28d2ba-85b2-4159-96ec-d4cd98cc1fd9@github.com>
 <MXiLdraDlYBQPCr9Qgo2YheTPKwolbHpx3Y8K8_PVb0=.0485b062-3513-4d07-ae4e-c0bfa541bbcf@github.com>
 <4b2Qpx83gAuZrUoUa25JRTWn9T55lfU1ysvrIyYMbgI=.3401db3e-b7b3-4086-bf72-1d154609b1fe@github.com>
Message-ID: <BBPKsdy6llpH9GfqT-4aquGjJTU7PxZBvlOQSKeHVws=.dd64a71b-317e-42f8-817e-5105f86dc3ca@github.com>

On Fri, 1 Mar 2024 10:42:31 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>>> You could add @modules java.desktop/com.sun.java.swing.plaf.windows to jtreg tags and access the com.sun.java.swing.plaf.windows.WindowsLookAndFeel.isMnemonicHidden method to verify that the mnemonics are shown or hidden based on how many times you (the Robot) pressed F10 key as well as the menu bar is active or not.
>> 
>> How to check for menubar whether it is active or not? Should I check the keyboard focus?
>
>> > You could add @modules java.desktop/com.sun.java.swing.plaf.windows to jtreg tags and access the com.sun.java.swing.plaf.windows.WindowsLookAndFeel.isMnemonicHidden method to verify that the mnemonics are shown or hidden based on how many times you (the Robot) pressed F10 key as well as the menu bar is active or not.
>> 
>> How to check for menubar whether it is active or not? Should I check the keyboard focus?
> 
> You have it in the code:
> 
> 
>                MenuElement[] selectedPath = msm.getSelectedPath();
>                if (selectedPath.length == 0) {
>                    throw new RuntimeException();
>                }
>                if (selectedPath[0] != menuBar || selectedPath[1] != fileMenu) {
>                    throw new RuntimeException();
>                }
> 
> where menuBar is the `JMenuBar` that you created in the test and `fileMenu` is the first `JMenu` in the menu bar.

@aivanov-jdk Updated based on review comment.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17961#issuecomment-1973443450

From abhiscxk at openjdk.org  Fri Mar  1 16:05:07 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Fri, 1 Mar 2024 16:05:07 GMT
Subject: RFR: 8326458: Menu mnemonics don't toggle in Windows LAF when F10
 is pressed [v4]
In-Reply-To: <9JVE-TH49B-kvVvfCjSKqvdGUwKnTzJXG1JX7QjSERk=.1564aa9c-26ae-4c46-bc66-fe588cfb403a@github.com>
References: <uv53ohrzj-j8wA3SHr7M0b5V-Ja9HvKGBa2RgWTwoSU=.abf8c336-4b24-479c-af6d-22acb686ed80@github.com>
 <NPbekobpwpYTzuF0jzlN276j6ZYSzbD-NOxnijY90XA=.c6b9fcc6-3826-4bee-a8d7-cc80514f29be@github.com>
 <9JVE-TH49B-kvVvfCjSKqvdGUwKnTzJXG1JX7QjSERk=.1564aa9c-26ae-4c46-bc66-fe588cfb403a@github.com>
Message-ID: <eQ99FNOgHaoSyN5m1vQJoFR8RwumSVLSaxbVA0XF7Sw=.62ee594d-0a8c-4966-88f4-615637d36b74@github.com>

On Fri, 1 Mar 2024 15:06:49 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> Is the line too long without wrapping?

It's around 100 columns.. so wrapping looks good to me.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17961#discussion_r1509199308

From duke at openjdk.org  Fri Mar  1 21:42:02 2024
From: duke at openjdk.org (MustavData)
Date: Fri, 1 Mar 2024 21:42:02 GMT
Subject: RFR: 8270269: Desktop.browse method fails if earlier CoInitialize
 call as COINIT_MULTITHREADED [v3]
In-Reply-To: <YWL2OqqOBzIvzozzax3Ua9W-MLtClksVwtCRF_QsRAU=.0fae33c6-bf12-4ee1-a63b-40a686b6d084@github.com>
References: <soWUkMQg0jQeXERvEfDXzVAduTELSBpdRaJoIw3IhMU=.b0587798-f0dc-4ffb-8d5f-f3741ca114e6@github.com>
 <6kleKtEG40OwclwIOss4ttDnXwdGsTicuIfIqTpFDgw=.adcd6f38-aed2-4686-b178-d724ddff5710@github.com>
 <TwMAH8m2Eg7q6VivnU-QnYitNBFg64AacGisey8UJ6Y=.c10232e9-67ca-4348-89ca-b2add882b5ed@github.com>
 <YWL2OqqOBzIvzozzax3Ua9W-MLtClksVwtCRF_QsRAU=.0fae33c6-bf12-4ee1-a63b-40a686b6d084@github.com>
Message-ID: <aOyPo5_0KOr5NhD2CSqTHeSCvqkNs-PX5zZkb-mYtHE=.9baa0c87-aa5a-4902-980b-874ba63e0450@github.com>

On Mon, 29 Jan 2024 20:56:42 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> I am working to verify the initial fix of JDK-8270269 in OpenJDK 23 (beta).  The basic environment is:
>> 
>>     OpenJDK:  "Azul Systems, Inc.", "Zulu23+11-CA", "23-beta+1", "x86_64", ".:git:e278d5994c10+"
>>     OS:  Windows 11, version 22H2, Build 22621.3007, VC++ 2015-2022 Runtime version 14.38.33130.0
>> 
>> The test application is a Java client with the user successfully logged in, following initial launch, against a web application.  Here are the basic tests that need to pass:
>> 
>> 1. Re-authentication after the standard web app timeout of 30 minutes, typically triggered when returning from lunch
>> 2. Re-authentication after numerous hours, typically triggered when returning to work the next morning
>> 
>> Results so far:
>> 
>> 1. Without the initial fix, the Test 1 fails as reported in JDK-8270269
>> 2. With the initial fix, Test 1 succeeds, and Test 2 fails with a `java.io.IOException` thrown upon a failure in `CoInitializeEx()`
>> 
>> Here is the stack trace from the Test 2 failure:
>> 
>> 
>> java.io.IOException: Failed to open https://<web-app-url>. Error message: CoInitializeEx() failed.
>> 	at java.desktop/sun.awt.windows.WDesktopPeer.ShellExecute(WDesktopPeer.java:115)
>> 	at java.desktop/sun.awt.windows.WDesktopPeer.browse(WDesktopPeer.java:101)
>> 	at java.desktop/java.awt.Desktop.browse(Desktop.java:533)
>
> @MustavData, according to the line number, you're using a build without Segey's fix:
> 
> https://github.com/openjdk/jdk/blob/bff7725b4d81c12c0c826933fc2ad4f49a227536/src/java.desktop/windows/classes/sun/awt/windows/WDesktopPeer.java#L114-L117
> 
> In the file with this fix, the line number where the exception is thrown is 119:
> 
> https://github.com/openjdk/jdk/blob/b25ed57b764fc485e4e8ca4118ffb1cc70fdfe7f/src/java.desktop/windows/classes/sun/awt/windows/WDesktopPeer.java#L118-L121

@aivanov-jdk , thanks for the clarification.   I've re-run my tests using a more recent build (see below), and they now work as expected -  as they do with JDK 15 and prior.

OpenJDK:  "Oracle Corporation", "23-ea+11-814", "x86_64", ".:git:cc1e216eb9e4"
OS:  Windows 11, version 22H2, Build 22621.3007, VC++ 2015-2022 Runtime version 14.38.33130.0

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17010#issuecomment-1973960833

From achung at openjdk.org  Fri Mar  1 22:53:03 2024
From: achung at openjdk.org (Alisen Chung)
Date: Fri, 1 Mar 2024 22:53:03 GMT
Subject: RFR: 8280392:
 java/awt/Focus/NonFocusableWindowTest/NonfocusableOwnerTest.java failed with
 "RuntimeException: Test failed."
Message-ID: <o_Z6zlPUisWgc5LIglgOe4zbIjsijJfuG9MtoBveFAU=.2d730b06-211a-485e-8390-6d6f9ae75947@github.com>

Introduce delays in test to stabilize. Test passes 50x after fix.

-------------

Commit messages:
 - added delays to stabilize test

Changes: https://git.openjdk.org/jdk/pull/18091/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18091&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8280392
  Stats: 9 lines in 2 files changed: 8 ins; 1 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18091.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18091/head:pull/18091

PR: https://git.openjdk.org/jdk/pull/18091

From dmarkov at openjdk.org  Sun Mar  3 09:06:02 2024
From: dmarkov at openjdk.org (Dmitry Markov)
Date: Sun, 3 Mar 2024 09:06:02 GMT
Subject: RFR: 8326661: sun/java2d/cmm/ColorConvertOp/ColConvTest.java assumes
 profiles were generated by LCMS
Message-ID: <nFplnFr0UPf-gWrZjoyZhb2pCJ_fjUEieIxTlWesSNs=.7f372d25-5bc5-4fb2-9ecd-8d5e40cc69b8@github.com>

Updated several tests to avoid potential failure with recent LCMS update and non-LCMS generated profile.

-------------

Commit messages:
 - 8326661: sun/java2d/cmm/ColorConvertOp/ColConvTest.java assumes profiles were generated by LCMS

Changes: https://git.openjdk.org/jdk/pull/18097/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18097&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8326661
  Stats: 39 lines in 3 files changed: 0 ins; 30 del; 9 mod
  Patch: https://git.openjdk.org/jdk/pull/18097.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18097/head:pull/18097

PR: https://git.openjdk.org/jdk/pull/18097

From ihse at openjdk.org  Sun Mar  3 15:30:55 2024
From: ihse at openjdk.org (Magnus Ihse Bursie)
Date: Sun, 3 Mar 2024 15:30:55 GMT
Subject: RFR: 8326583: Remove over-generalized DefineNativeToolchain
 solution [v4]
In-Reply-To: <V4syuDAMRYe1BSG2okxw2sdceihpIarwtYI1wIbfxhY=.16d008af-c3df-42fe-a97c-7ac41eaab757@github.com>
References: <lGtsPt-jwk2yeMj9usOUTYfflYDwX8DAhD7RLxWJQ9o=.ae41dd0a-9b28-43a4-9979-84c2f675e531@github.com>
 <V4syuDAMRYe1BSG2okxw2sdceihpIarwtYI1wIbfxhY=.16d008af-c3df-42fe-a97c-7ac41eaab757@github.com>
Message-ID: <eGE-Yo2mIy9CsBP7uNYcaR0IvQKqejcJW0eq8e2xQ08=.1c3808bd-bca4-4fe4-8bd2-ed752296968e@github.com>

On Tue, 27 Feb 2024 11:19:59 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> The idea of setting up general "toolchains" in the native build was good, but it turned out that we really only need a single toolchain, with a single twist: if it should use CC or CPP to link. This is better described by a specific argument to SetupNativeCompilation, LANG := C++ or LANG := C (the default).
>> 
>> There is a single exception to this rule, and that is if we want to compile for the build platform rather than the target platform. (This is only done for adlc) To keep expressing this difference, introduce TARGET_TYPE := BUILD (or TARGET_TYPE := TARGET, the default).
>> 
>> The final odd-case was the hack for building hsdis/bin on mingw. This can be resolved using direct variables to SetupNativeCompilation, instead of first creating a toolchain.
>> 
>> Doing this refactoring will simplify the SetupNativeCompilation code, and make it much clearer if we use the C or C++ linker.
>
> Magnus Ihse Bursie has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits:
> 
>  - Merge branch 'master' into remove-toolchain-define
>  - Rename LANG to LINK_TYPE
>  - Reword "lib" comment to fit in better
>  - Merge branch 'master' into remove-toolchain-define
>  - 8326583: Remove over-generalized DefineNativeToolchain solution

For the record, there is a series of comment posted as Github commit comments. See https://github.com/openjdk/jdk/commit/ac3ce2aa156332fc4e6f33018ff669657ab4b797#commitcomment-139295772.

According to the comments, this PR breaks building hsdis with ccache.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17986#issuecomment-1975197285

From ihse at openjdk.org  Sun Mar  3 15:34:54 2024
From: ihse at openjdk.org (Magnus Ihse Bursie)
Date: Sun, 3 Mar 2024 15:34:54 GMT
Subject: RFR: 8326583: Remove over-generalized DefineNativeToolchain
 solution [v4]
In-Reply-To: <V4syuDAMRYe1BSG2okxw2sdceihpIarwtYI1wIbfxhY=.16d008af-c3df-42fe-a97c-7ac41eaab757@github.com>
References: <lGtsPt-jwk2yeMj9usOUTYfflYDwX8DAhD7RLxWJQ9o=.ae41dd0a-9b28-43a4-9979-84c2f675e531@github.com>
 <V4syuDAMRYe1BSG2okxw2sdceihpIarwtYI1wIbfxhY=.16d008af-c3df-42fe-a97c-7ac41eaab757@github.com>
Message-ID: <537eZ4LFh0sfwSpT_HSyXOy5UZQo2H1B8WcxSjI9Ovs=.9d34407c-c8f0-4460-84f7-edc2891c78de@github.com>

On Tue, 27 Feb 2024 11:19:59 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> The idea of setting up general "toolchains" in the native build was good, but it turned out that we really only need a single toolchain, with a single twist: if it should use CC or CPP to link. This is better described by a specific argument to SetupNativeCompilation, LANG := C++ or LANG := C (the default).
>> 
>> There is a single exception to this rule, and that is if we want to compile for the build platform rather than the target platform. (This is only done for adlc) To keep expressing this difference, introduce TARGET_TYPE := BUILD (or TARGET_TYPE := TARGET, the default).
>> 
>> The final odd-case was the hack for building hsdis/bin on mingw. This can be resolved using direct variables to SetupNativeCompilation, instead of first creating a toolchain.
>> 
>> Doing this refactoring will simplify the SetupNativeCompilation code, and make it much clearer if we use the C or C++ linker.
>
> Magnus Ihse Bursie has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits:
> 
>  - Merge branch 'master' into remove-toolchain-define
>  - Rename LANG to LINK_TYPE
>  - Reword "lib" comment to fit in better
>  - Merge branch 'master' into remove-toolchain-define
>  - 8326583: Remove over-generalized DefineNativeToolchain solution

@claudionieder

> One last comment. I just discovered, that if I remove the --enable-ccache from the configure command, then it works also with this commit. Hopefully this helps for fixing the issue.

So what you really saying is that this breaks when compiling capstone hsdis on macOS/aarch64 when you have ccache enabled?

It seems more reasonable that this could be a ccache error than a hsdis-with-capstone error. Can you build any normal JDK targets with ccache?

(Also, why are you using ccache? It is highly unclear if that really adds any performance improvements)

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17986#issuecomment-1975198444

From mark.yagnatinsky at barclays.com  Sun Mar  3 23:00:46 2024
From: mark.yagnatinsky at barclays.com (mark.yagnatinsky at barclays.com)
Date: Sun, 3 Mar 2024 23:00:46 +0000
Subject: how to get find out the keyboard shortcut for the paste action?
In-Reply-To: <CH3PR12MB7619B0682852C7C836096E84F95C2@CH3PR12MB7619.namprd12.prod.outlook.com>
References: <CH3PR12MB76198C4F8B2300D806EDCCF0F9452@CH3PR12MB7619.namprd12.prod.outlook.com>
 <em455be664-76d1-43e4-ba85-729678b34dc6@76ca4640.com>
 <CH3PR12MB7619B0682852C7C836096E84F95C2@CH3PR12MB7619.namprd12.prod.outlook.com>
Message-ID: <CH3PR12MB76199D23AB541CB4C09118AAF95C2@CH3PR12MB7619.namprd12.prod.outlook.com>

Thanks for the response!  I didn?t expect to get one at this point ?
It does indeed answer my question!
(Though you didn?t quite get the name right: there?s no Ex at the end?
I take it you?ve done some Windows programming at some point)

But now I have a new question?
Is there any way to get the ?usual? letter for a ?common? operation?
For instance, lots of programs support copy and paste.
Is there a way to ask Java ?what is the standard letter for paste? and get back ?V??
Again, one could create a scratch text area and grovel through its input map, but that seems hacky.

This message is for information purposes only. It is not a recommendation, advice, offer or solicitation to buy or sell a product or service, nor an official confirmation of any transaction. It is directed at persons who are professionals and is intended for the recipient(s) only. It is not directed at retail customers. This message is subject to the terms at: https://www.ib.barclays/disclosures/web-and-email-disclaimer.html. 

For important disclosures, please see: https://www.ib.barclays/disclosures/sales-and-trading-disclaimer.html regarding marketing commentary from Barclays Sales and/or Trading desks, who are active market participants; https://www.ib.barclays/disclosures/barclays-global-markets-disclosures.html regarding our standard terms for Barclays Investment Bank where we trade with you in principal-to-principal wholesale markets transactions; and in respect to Barclays Research, including disclosures relating to specific issuers, see: http://publicresearch.barclays.com.
__________________________________________________________________________________ 
If you are incorporated or operating in Australia, read these important disclosures: https://www.ib.barclays/disclosures/important-disclosures-asia-pacific.html.
__________________________________________________________________________________
For more details about how we use personal information, see our privacy notice: https://www.ib.barclays/disclosures/personal-information-use.html. 
__________________________________________________________________________________
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/client-libs-dev/attachments/20240303/518b3574/attachment-0001.htm>

From duke at openjdk.org  Sun Mar  3 23:30:51 2024
From: duke at openjdk.org (Claudio Nieder)
Date: Sun, 3 Mar 2024 23:30:51 GMT
Subject: RFR: 8326583: Remove over-generalized DefineNativeToolchain
 solution [v4]
In-Reply-To: <V4syuDAMRYe1BSG2okxw2sdceihpIarwtYI1wIbfxhY=.16d008af-c3df-42fe-a97c-7ac41eaab757@github.com>
References: <lGtsPt-jwk2yeMj9usOUTYfflYDwX8DAhD7RLxWJQ9o=.ae41dd0a-9b28-43a4-9979-84c2f675e531@github.com>
 <V4syuDAMRYe1BSG2okxw2sdceihpIarwtYI1wIbfxhY=.16d008af-c3df-42fe-a97c-7ac41eaab757@github.com>
Message-ID: <wHcG1NUm5We4Qw1UF-yogB7brRcE3NhdH8TzPBomDgw=.a07db378-a32b-4071-93ac-374d5240e0d0@github.com>

On Tue, 27 Feb 2024 11:19:59 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> The idea of setting up general "toolchains" in the native build was good, but it turned out that we really only need a single toolchain, with a single twist: if it should use CC or CPP to link. This is better described by a specific argument to SetupNativeCompilation, LANG := C++ or LANG := C (the default).
>> 
>> There is a single exception to this rule, and that is if we want to compile for the build platform rather than the target platform. (This is only done for adlc) To keep expressing this difference, introduce TARGET_TYPE := BUILD (or TARGET_TYPE := TARGET, the default).
>> 
>> The final odd-case was the hack for building hsdis/bin on mingw. This can be resolved using direct variables to SetupNativeCompilation, instead of first creating a toolchain.
>> 
>> Doing this refactoring will simplify the SetupNativeCompilation code, and make it much clearer if we use the C or C++ linker.
>
> Magnus Ihse Bursie has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits:
> 
>  - Merge branch 'master' into remove-toolchain-define
>  - Rename LANG to LINK_TYPE
>  - Reword "lib" comment to fit in better
>  - Merge branch 'master' into remove-toolchain-define
>  - 8326583: Remove over-generalized DefineNativeToolchain solution

Indeed hsdis or no hsdis does not matter at all. --enable-ccache is broken with this commit in any case. I executed the much simplified script below, which builds once using this commit and once the parent commit. Seems, that with hsdis enabled HSDIS was just the first thing that needed to be compiled. Now it is failing when "Creating support/modules_libs/java.base/server/libjvm.dylib".

Regarding why I use ccache: I frankly didn't time it to see if there is an advantage. I just read in doc/building.md (lines 1517 ff) "The JDK build supports building with ccache when using gcc or clang. Using ccache can radically speed up compilation of native code if you often rebuild the same sources." so I included it in my personal script to build OpenJDK. But I can easily live without using ccache and personally wouldn't mind if OpenJDK stops supporting ccache. 

Below the content of `build/macosx-aarch64-server-fastdebug/hotspot/variant-server/libjvm/objs/precompiled/precompiled.hpp.pch.cmdline` for this commit ac3ce2aa where you can see the main issue, that the command `/opt/homebrew/bin/ccache /usr/bin/clang` is missing in front of the first compiler option -D__STDC_FORMAT_MACROS. Additionally some environment variables are missing/different.


cd /tmp/ac3ce2aa/jdk && CCACHE_COMPRESS=1 CCACHE_SLOPPINESS=pch_defines -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -D__STDC_CONSTANT_MACROS -D_GNU_SOURCE -pipe -fno-rtti -fno-exceptions -fvisibility=hidden -fno-strict-aliasing -fno-omit-frame-pointer -flimit-debug-info -mno-omit-leaf-frame-pointer -mstack-alignment=16 -std=c++14 -DMAC_OS_X_VERSION_MIN_REQUIRED=110000 -mmacosx-version-min=11.00.00 -DLIBC=default -D_ALLBSD_SOURCE -D_DARWIN_C_SOURCE -D_XOPEN_SOURCE -Wall -Wextra -Wformat=2 -Wpointer-arith -Wsign-compare -Wreorder -Wunused-function -Wundef -Wunused-value -Woverloaded-virtual -fPIC -DVM_LITTLE_ENDIAN -D_LP64=1 -arch arm64 -DASSERT -DCHECK_UNHANDLED_OOPS -DTARGET_ARCH_aarch64 -DINCLUDE_SUFFIX_OS=_bsd -DINCLUDE_SUFFIX_CPU=_aarch64 -DINCLUDE_SUFFIX_COMPILER=_gcc -DTARGET_COMPILER_gcc -DAARCH64 -DHOTSPOT_LIB_ARCH='"aarch64"' -DCOMPILER1 -DCOMPILER2 -DDTRACE_ENABLED -Ibuild/macosx-aarch64-server-fastdebug/hotspot/variant-server/gensrc/adfiles -Isrc/hotspot/share -Isrc/hotspo
 t/os/bsd -Isrc/hotspot/os/posix -Isrc/hotspot/cpu/aarch64 -Isrc/hotspot/os_cpu/bsd_aarch64 -Ibuild/macosx-aarch64-server-fastdebug/hotspot/variant-server/gensrc -Isrc/hotspot/share/precompiled -Isrc/hotspot/share/include -Isrc/hotspot/os/posix/include -Ibuild/macosx-aarch64-server-fastdebug/support/modules_include/java.base -Ibuild/macosx-aarch64-server-fastdebug/support/modules_include/java.base/darwin -Isrc/java.base/share/native/libjimage -arch arm64 -Ibuild/macosx-aarch64-server-fastdebug/hotspot/variant-server/gensrc/adfiles -Isrc/hotspot/share -Isrc/hotspot/os/bsd -Isrc/hotspot/os/posix -Isrc/hotspot/cpu/aarch64 -Isrc/hotspot/os_cpu/bsd_aarch64 -Ibuild/macosx-aarch64-server-fastdebug/hotspot/variant-server/gensrc -g -gdwarf-4 -gdwarf-aranges -Wno-unknown-warning-option -Wno-unused-parameter -Wno-unused -Wno-sometimes-uninitialized -Wno-missing-braces -Wno-delete-non-abstract-non-virtual-dtor -Wno-unknown-pragmas -Wno-tautological-constant-out-of-range-compare -isysroot /Applic
 ations/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.2.sdk -iframework /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.2.sdk/System/Library/Frameworks -O3 -x c++-header -c -MMD -MF build/macosx-aarch64-server-fastdebug/hotspot/variant-server/libjvm/objs/precompiled/precompiled.hpp.pch.d.tmp src/hotspot/share/precompiled/precompiled.hpp -o build/macosx-aarch64-server-fastdebug/hotspot/variant-server/libjvm/objs/precompiled/precompiled.hpp.pch


and here the content of `build/macosx-aarch64-server-fastdebug/hotspot/variant-server/libjvm/objs/precompiled/precompiled.hpp.pch.cmdline` for the parent commit bceaed6d


cd /tmp/bceaed6d/jdk && CCACHE_COMPRESS=1 CCACHE_SLOPPINESS=pch_defines,time_macros CCACHE_BASEDIR=/tmp/bceaed6d/jdk/ /opt/homebrew/bin/ccache /usr/bin/clang -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -D__STDC_CONSTANT_MACROS -D_GNU_SOURCE -pipe -fno-rtti -fno-exceptions -fvisibility=hidden -fno-strict-aliasing -fno-omit-frame-pointer -flimit-debug-info -mno-omit-leaf-frame-pointer -mstack-alignment=16 -std=c++14 -DMAC_OS_X_VERSION_MIN_REQUIRED=110000 -mmacosx-version-min=11.00.00 -DLIBC=default -D_ALLBSD_SOURCE -D_DARWIN_C_SOURCE -D_XOPEN_SOURCE -Wall -Wextra -Wformat=2 -Wpointer-arith -Wsign-compare -Wreorder -Wunused-function -Wundef -Wunused-value -Woverloaded-virtual -fPIC -DVM_LITTLE_ENDIAN -D_LP64=1 -arch arm64 -DASSERT -DCHECK_UNHANDLED_OOPS -DTARGET_ARCH_aarch64 -DINCLUDE_SUFFIX_OS=_bsd -DINCLUDE_SUFFIX_CPU=_aarch64 -DINCLUDE_SUFFIX_COMPILER=_gcc -DTARGET_COMPILER_gcc -DAARCH64 -DHOTSPOT_LIB_ARCH='"aarch64"' -DCOMPILER1 -DCOMPILER2 -DDTRACE_ENABLED -Ibuild/macosx-aarch64-s
 erver-fastdebug/hotspot/variant-server/gensrc/adfiles -Isrc/hotspot/share -Isrc/hotspot/os/bsd -Isrc/hotspot/os/posix -Isrc/hotspot/cpu/aarch64 -Isrc/hotspot/os_cpu/bsd_aarch64 -Ibuild/macosx-aarch64-server-fastdebug/hotspot/variant-server/gensrc -Isrc/hotspot/share/precompiled -Isrc/hotspot/share/include -Isrc/hotspot/os/posix/include -Ibuild/macosx-aarch64-server-fastdebug/support/modules_include/java.base -Ibuild/macosx-aarch64-server-fastdebug/support/modules_include/java.base/darwin -Isrc/java.base/share/native/libjimage -arch arm64 -Ibuild/macosx-aarch64-server-fastdebug/hotspot/variant-server/gensrc/adfiles -Isrc/hotspot/share -Isrc/hotspot/os/bsd -Isrc/hotspot/os/posix -Isrc/hotspot/cpu/aarch64 -Isrc/hotspot/os_cpu/bsd_aarch64 -Ibuild/macosx-aarch64-server-fastdebug/hotspot/variant-server/gensrc -g -gdwarf-4 -gdwarf-aranges -Wno-unknown-warning-option -Wno-unused-parameter -Wno-unused -Wno-sometimes-uninitialized -Wno-missing-braces -Wno-delete-non-abstract-non-virtual-dtor 
 -Wno-unknown-pragmas -Wno-tautological-constant-out-of-range-compare -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.2.sdk -iframework /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.2.sdk/System/Library/Frameworks -O3 -x c++-header -c -MMD -MF build/macosx-aarch64-server-fastdebug/hotspot/variant-server/libjvm/objs/precompiled/precompiled.hpp.pch.d.tmp src/hotspot/share/precompiled/precompiled.hpp -o build/macosx-aarch64-server-fastdebug/hotspot/variant-server/libjvm/objs/precompiled/precompiled.hpp.pch


Script used to test


#!/bin/bash

export LANG=en_US
export LC_ALL=en_US

suspectedCommit=ac3ce2aa
preceedingCommit=bceaed6d

function build() {
 bash ./configure --enable-ccache --disable-warnings-as-errors --with-debug-level=fastdebug
 make clean
 make images
}

cd /tmp
rm -rf $preceedingCommit
mkdir $preceedingCommit
cd $preceedingCommit
git clone "https://github.com/openjdk/jdk.git"
cd jdk
git checkout $preceedingCommit
build

cd /tmp
rm -rf $suspectedCommit
mkdir $suspectedCommit
cd $suspectedCommit
git clone "https://github.com/openjdk/jdk.git"
cd jdk
git checkout $suspectedCommit
build

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17986#issuecomment-1975396416

From duke at openjdk.org  Mon Mar  4 00:02:48 2024
From: duke at openjdk.org (Claudio Nieder)
Date: Mon, 4 Mar 2024 00:02:48 GMT
Subject: RFR: 8326583: Remove over-generalized DefineNativeToolchain
 solution [v4]
In-Reply-To: <V4syuDAMRYe1BSG2okxw2sdceihpIarwtYI1wIbfxhY=.16d008af-c3df-42fe-a97c-7ac41eaab757@github.com>
References: <lGtsPt-jwk2yeMj9usOUTYfflYDwX8DAhD7RLxWJQ9o=.ae41dd0a-9b28-43a4-9979-84c2f675e531@github.com>
 <V4syuDAMRYe1BSG2okxw2sdceihpIarwtYI1wIbfxhY=.16d008af-c3df-42fe-a97c-7ac41eaab757@github.com>
Message-ID: <VVosEvM3nkqv_7fvXj3bkwuqGz5GQq6t-GadFdtX1D4=.d3f7ccf0-9fa3-469d-a504-f1f0dcdc8a81@github.com>

On Tue, 27 Feb 2024 11:19:59 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> The idea of setting up general "toolchains" in the native build was good, but it turned out that we really only need a single toolchain, with a single twist: if it should use CC or CPP to link. This is better described by a specific argument to SetupNativeCompilation, LANG := C++ or LANG := C (the default).
>> 
>> There is a single exception to this rule, and that is if we want to compile for the build platform rather than the target platform. (This is only done for adlc) To keep expressing this difference, introduce TARGET_TYPE := BUILD (or TARGET_TYPE := TARGET, the default).
>> 
>> The final odd-case was the hack for building hsdis/bin on mingw. This can be resolved using direct variables to SetupNativeCompilation, instead of first creating a toolchain.
>> 
>> Doing this refactoring will simplify the SetupNativeCompilation code, and make it much clearer if we use the C or C++ linker.
>
> Magnus Ihse Bursie has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits:
> 
>  - Merge branch 'master' into remove-toolchain-define
>  - Rename LANG to LINK_TYPE
>  - Reword "lib" comment to fit in better
>  - Merge branch 'master' into remove-toolchain-define
>  - 8326583: Remove over-generalized DefineNativeToolchain solution

As a side note, I now did time the effect of ccache using the below script. This is the result without ccache


real	3m42.896s
user	20m49.584s
sys	2m56.578s


this is the result with --enable-ccache

real	4m56.290s
user	26m16.230s
sys	5m50.993s


Thus at least on my MacBook Pro M1 using ccache slows down the compilation!

Script

#!/bin/bash

export LANG=en_US
export LC_ALL=en_US

preceedingCommit=bceaed6d

d1=noCCache
d2=ccache

cd /tmp
rm -rf $d1
mkdir $d1
cd $d1
git clone "https://github.com/openjdk/jdk.git"
cd jdk
git checkout $preceedingCommit
bash ./configure --disable-warnings-as-errors --with-debug-level=fastdebug \
  --enable-hsdis-bundling --with-hsdis=capstone
make clean
time make images 2>&1 | tee /tmp/$d1/time.txt

cd /tmp
rm -rf $d2
mkdir $d2
cd $d2
git clone "https://github.com/openjdk/jdk.git"
cd jdk
git checkout $preceedingCommit
bash ./configure --disable-warnings-as-errors --with-debug-level=fastdebug \
  --enable-ccache --enable-hsdis-bundling --with-hsdis=capstone
make clean
time make images 2>&1 | tee /tmp/$d2/time.txt

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17986#issuecomment-1975406744

From brice.dutheil at gmail.com  Mon Mar  4 04:23:51 2024
From: brice.dutheil at gmail.com (Brice Dutheil)
Date: Mon, 4 Mar 2024 05:23:51 +0100
Subject: how to get find out the keyboard shortcut for the paste action?
In-Reply-To: <CH3PR12MB76199D23AB541CB4C09118AAF95C2@CH3PR12MB7619.namprd12.prod.outlook.com>
References: <CH3PR12MB76198C4F8B2300D806EDCCF0F9452@CH3PR12MB7619.namprd12.prod.outlook.com>
 <em455be664-76d1-43e4-ba85-729678b34dc6@76ca4640.com>
 <CH3PR12MB7619B0682852C7C836096E84F95C2@CH3PR12MB7619.namprd12.prod.outlook.com>
 <CH3PR12MB76199D23AB541CB4C09118AAF95C2@CH3PR12MB7619.namprd12.prod.outlook.com>
Message-ID: <CALTMA7sf2CEe63mpjxrOY2OZHe3c1+xHyt3zdnaSjixMWVpRhw@mail.gmail.com>

Hi, just chiming in,

> (Though you didn?t quite get the name right: there?s no Ex at the end?
The method `getMenuShortcutKeyMaskEx` has been introduced in JDK10

https://docs.oracle.com/en/java/javase/21/docs/api/java.desktop/java/awt/Toolkit.html#getMenuShortcutKeyMaskEx()

> Is there any way to get the ?usual? letter for a ?common? operation?

Isn't it a per application choice, even if OS stock applications use some
default, it's pretty standard to use xcv letters regardless of the OS.
Possibly you could be interested by other letters like z (undo) or y
(redo), but again it seems like an app choice in the end.

Brice


On Mon, Mar 4, 2024 at 00:01 <mark.yagnatinsky at barclays.com> wrote:

> Thanks for the response!  I didn?t expect to get one at this point J
>
> It does indeed answer my question!
>
> (Though you didn?t quite get the name right: there?s no Ex at the end?
>
> I take it you?ve done some Windows programming at some point)
>
>
>
> But now I have a new question?
>
> Is there any way to get the ?usual? letter for a ?common? operation?
>
> For instance, lots of programs support copy and paste.
>
> Is there a way to ask Java ?what is the standard letter for paste? and get
> back ?V??
>
> Again, one could create a scratch text area and grovel through its input
> map, but that seems hacky.
>
> This message is for information purposes only. It is not a recommendation,
> advice, offer or solicitation to buy or sell a product or service, nor an
> official confirmation of any transaction. It is directed at persons who are
> professionals and is intended for the recipient(s) only. It is not directed
> at retail customers. This message is subject to the terms at:
> https://www.ib.barclays/disclosures/web-and-email-disclaimer.html.
>
> For important disclosures, please see:
> https://www.ib.barclays/disclosures/sales-and-trading-disclaimer.html
> regarding marketing commentary from Barclays Sales and/or Trading desks,
> who are active market participants;
> https://www.ib.barclays/disclosures/barclays-global-markets-disclosures.html
> regarding our standard terms for Barclays Investment Bank where we trade
> with you in principal-to-principal wholesale markets transactions; and in
> respect to Barclays Research, including disclosures relating to specific
> issuers, see: http://publicresearch.barclays.com.
> __________________________________________________________________________________
>
> If you are incorporated or operating in Australia, read these important
> disclosures:
> https://www.ib.barclays/disclosures/important-disclosures-asia-pacific.html
> .
>
> __________________________________________________________________________________
> For more details about how we use personal information, see our privacy
> notice: https://www.ib.barclays/disclosures/personal-information-use.html.
>
>
> __________________________________________________________________________________
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/client-libs-dev/attachments/20240304/e3b87b08/attachment-0001.htm>

From mickleness at gmail.com  Mon Mar  4 04:30:23 2024
From: mickleness at gmail.com (Jeremy Wood)
Date: Mon, 04 Mar 2024 04:30:23 +0000
Subject: how to get find out the keyboard shortcut for the paste action?
In-Reply-To: <CH3PR12MB76199D23AB541CB4C09118AAF95C2@CH3PR12MB7619.namprd12.prod.outlook.com>
References: <CH3PR12MB76198C4F8B2300D806EDCCF0F9452@CH3PR12MB7619.namprd12.prod.outlook.com>
 <em455be664-76d1-43e4-ba85-729678b34dc6@76ca4640.com>
 <CH3PR12MB7619B0682852C7C836096E84F95C2@CH3PR12MB7619.namprd12.prod.outlook.com>
 <CH3PR12MB76199D23AB541CB4C09118AAF95C2@CH3PR12MB7619.namprd12.prod.outlook.com>
Message-ID: <emfa5db32b-c08c-4ebc-a061-fc24306fbe93@dcff66fe.com>

 > But now I have a new question?

 > Is there any way to get the ?usual? letter for a ?common? operation?


Hmm. Good question. Not that I know of.

 > Again, one could create a scratch text area and grovel through its 
input map, but that seems hacky.

I agree sifting through the L&F seems hacky.

I don?t think I understand exactly what you?re trying to implement here. 
If you give me a more concrete example: maybe I (or someone on this 
list) can offer a more concrete suggestion?

I?ll add some context in case this speaks to your question.

By default Swing gets this information in places like 
BasicTextUI#getInputMap(), which calls:

InputMap shared =
     (InputMap)DefaultLookup.get(editor, this,
     getPropertyPrefix() + ".focusInputMap?);

The following works on my Mac & Windows machine (I think using JDK 19), 
but I wouldn?t be surprised if it fails in other platforms / L&F?s. It 
feels brittle, but it might (?) have potential:

private KeyStroke getCopyKeyStroke() {
InputMap inputMap = (InputMap) UIManager.getDefaults().get("TextField.focusInputMap");
for (KeyStroke keyStroke : inputMap.keys()) {
Object action = inputMap.get(keyStroke);
if ("copy-to-clipboard".equals(action)) {
return keyStroke;
         }
     }
// this will show all the default keystrokes
//                System.out.println(Arrays.asList(inputMap.allKeys()));

return null;
}
Regards,
  - Jeremy



------ Original Message ------
>From mark.yagnatinsky at barclays.com
To mickleness at gmail.com; client-libs-dev at openjdk.org
Date 3/3/24, 6:00:46?PM
Subject RE: how to get find out the keyboard shortcut for the paste 
action?

>Thanks for the response!  I didn?t expect to get one at this point J
>
>It does indeed answer my question!
>
>(Though you didn?t quite get the name right: there?s no Ex at the end?
>
>I take it you?ve done some Windows programming at some point)
>
>
>
>But now I have a new question?
>
>Is there any way to get the ?usual? letter for a ?common? operation?
>
>For instance, lots of programs support copy and paste.
>
>Is there a way to ask Java ?what is the standard letter for paste? and 
>get back ?V??
>
>Again, one could create a scratch text area and grovel through its 
>input map, but that seems hacky.
>
>This message is for information purposes only. It is not a 
>recommendation, advice, offer or solicitation to buy or sell a product 
>or service, nor an official confirmation of any transaction. It is 
>directed at persons who are professionals and is intended for the 
>recipient(s) only. It is not directed at retail customers. This message 
>is subject to the terms at: 
>https://www.ib.barclays/disclosures/web-and-email-disclaimer.html.
>
>For important disclosures, please see: 
>https://www.ib.barclays/disclosures/sales-and-trading-disclaimer.html 
>regarding marketing commentary from Barclays Sales and/or Trading 
>desks, who are active market participants; 
>https://www.ib.barclays/disclosures/barclays-global-markets-disclosures.html 
>regarding our standard terms for Barclays Investment Bank where we 
>trade with you in principal-to-principal wholesale markets 
>transactions; and in respect to Barclays Research, including 
>disclosures relating to specific issuers, see: 
>http://publicresearch.barclays.com.
>__________________________________________________________________________________
>If you are incorporated or operating in Australia, read these important 
>disclosures: 
>https://www.ib.barclays/disclosures/important-disclosures-asia-pacific.html.
>__________________________________________________________________________________
>For more details about how we use personal information, see our privacy 
>notice: 
>https://www.ib.barclays/disclosures/personal-information-use.html.
>__________________________________________________________________________________
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/client-libs-dev/attachments/20240304/5c178df6/attachment.htm>

From psadhukhan at openjdk.org  Mon Mar  4 05:19:02 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Mon, 4 Mar 2024 05:19:02 GMT
Subject: RFR: 8327007: javax/swing/JSpinner/8008657/bug8008657.java fails
 [v2]
In-Reply-To: <e_F-RYcAjzGOzHQL95zVz5z77cSdPDKpnPzuN3ExsNM=.9615c27e-92d5-4a10-8e34-be66ef6883aa@github.com>
References: <e_F-RYcAjzGOzHQL95zVz5z77cSdPDKpnPzuN3ExsNM=.9615c27e-92d5-4a10-8e34-be66ef6883aa@github.com>
Message-ID: <XwRkHlWrMXl7DdJNguhdqkqDBFwUy-PMgtV92IgOVJY=.d1b1c5e1-aeae-4b96-9f0e-f3e6baeb562e@github.com>

> Test failed with the exception java.lang.IllegalArgumentException: (start <= value <= end) with no history of failing till date.
> Investigation shows SpinnerDateModel constructor condition is not satisfied because
> It seems it's a leap year problem that is being manifested..
> 
> As per test,
> initDate Thu Feb 29 13:49:08 IST 2024 [ obtained by calendar.getTime();]
> earliestDate Tue Feb 28 13:49:08 IST 2023 [obtained by calendar.add(Calendar.YEAR, -1);]
> latestDate Wed Feb 28 13:49:08 IST 2024 [obtained by calendar.add(Calendar.YEAR, 1);]
> 
> Now, as per SpinnerDateModel constructor
> earliestDate <= initDate condition is satisfied
> but
> latestDate >= initDate is not
> so [start <= value <= end](https://github.com/openjdk/jdk/blob/998d0baab0fd051c38d9fd6021628eb863b80554/src/java.desktop/share/classes/javax/swing/SpinnerDateModel.java#L185) condition fails
> 
> Not sure it anything can be done in Calendar class for this but fix is done in test taking leapyear into account so that we add a day if it's a leapyear when we consecutively do Calendar.add(YEAR, -1) and Calendar.add(YEAR,1) on leapyear date of 29Feb

Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:

  Increment DAY_OF_MONTH to circumvent leapyear issue

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18054/files
  - new: https://git.openjdk.org/jdk/pull/18054/files/e285b4c1..20d888dd

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18054&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18054&range=00-01

  Stats: 13 lines in 1 file changed: 0 ins; 11 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/18054.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18054/head:pull/18054

PR: https://git.openjdk.org/jdk/pull/18054

From psadhukhan at openjdk.org  Mon Mar  4 05:19:02 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Mon, 4 Mar 2024 05:19:02 GMT
Subject: RFR: 8327007: javax/swing/JSpinner/8008657/bug8008657.java fails
In-Reply-To: <4VfJO0JRZ561Q7HqCiEe7TcB50MQVCjZxiX2h7zDQjk=.c0dc6e35-ce4a-48c9-a321-059929d85469@github.com>
References: <e_F-RYcAjzGOzHQL95zVz5z77cSdPDKpnPzuN3ExsNM=.9615c27e-92d5-4a10-8e34-be66ef6883aa@github.com>
 <4VfJO0JRZ561Q7HqCiEe7TcB50MQVCjZxiX2h7zDQjk=.c0dc6e35-ce4a-48c9-a321-059929d85469@github.com>
Message-ID: <B9jKCEB6ZvkNh3codC0uFFPIrSi2B6x-Ku673qokeQ4=.198e652a-6398-4985-b7d2-993a12b96462@github.com>

On Fri, 1 Mar 2024 03:15:19 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> Surely this just needs a one line fix
> 
> diff --git a/test/jdk/javax/swing/JSpinner/8008657/bug8008657.java b/test/jdk/javax/swing/JSpinner/8008657/bug8008657.java
> index cbeb0c185bb..49918278e34 100644
> --- a/test/jdk/javax/swing/JSpinner/8008657/bug8008657.java
> +++ b/test/jdk/javax/swing/JSpinner/8008657/bug8008657.java
> @@ -137,6 +137,7 @@ static void createDateSpinner() {
>          calendar.add(Calendar.YEAR, -1);
>          Date earliestDate = calendar.getTime();
>          calendar.add(Calendar.YEAR, 1);
> +        calendar.add(Calendar.DAY_OF_MONTH, 1);
>          Date latestDate = calendar.getTime();
>          SpinnerModel dateModel = new SpinnerDateModel(initDate,
>                  earliestDate,

Done minimal change as suggested...

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18054#issuecomment-1975749204

From rkannathpari at openjdk.org  Mon Mar  4 06:04:07 2024
From: rkannathpari at openjdk.org (Renjith Kannath Pariyangad)
Date: Mon, 4 Mar 2024 06:04:07 GMT
Subject: RFR: 8320676 : Manual printer tests have no Pass/Fail buttons,
 instructions close set 1 [v11]
In-Reply-To: <Afd90FypFvXYNR17jgkxcFj2LlxdLlZ1Bgd7WctdKcU=.2a8b05e0-a476-4598-8524-a22a0f54b8a5@github.com>
References: <Afd90FypFvXYNR17jgkxcFj2LlxdLlZ1Bgd7WctdKcU=.2a8b05e0-a476-4598-8524-a22a0f54b8a5@github.com>
Message-ID: <iWutKW4UpvMw8nEhcHknq1dlyNEtmppek6JdbLUqKDU=.4fa91123-1d3a-43d6-9f9d-c3967425c164@github.com>

> Hi Reviewers,
> 
> Updated manual printer test cases with 'PassFailJFrame', also removed unused variables. Added 'SkippedException' in case of printer missing or not configured.
> 
> Please review and let me know your suggestions.
> 
> Regards,
> Renjith

Renjith Kannath Pariyangad has updated the pull request incrementally with one additional commit since the last revision:

  Suggesions incorporated

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/17607/files
  - new: https://git.openjdk.org/jdk/pull/17607/files/38c4f395..10c2c695

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=17607&range=10
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17607&range=09-10

  Stats: 27 lines in 4 files changed: 2 ins; 11 del; 14 mod
  Patch: https://git.openjdk.org/jdk/pull/17607.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17607/head:pull/17607

PR: https://git.openjdk.org/jdk/pull/17607

From rkannathpari at openjdk.org  Mon Mar  4 06:33:09 2024
From: rkannathpari at openjdk.org (Renjith Kannath Pariyangad)
Date: Mon, 4 Mar 2024 06:33:09 GMT
Subject: RFR: 8324807 : Manual printer tests have no Pass/Fail buttons,
 instructions close set 2 [v10]
In-Reply-To: <UZ9jtQbkj-MoeLoccJnd2_3ciCCy9n-CD5vDv0hVKME=.f67db96d-92e6-46a1-9bb6-4fe77c9a8c4e@github.com>
References: <UZ9jtQbkj-MoeLoccJnd2_3ciCCy9n-CD5vDv0hVKME=.f67db96d-92e6-46a1-9bb6-4fe77c9a8c4e@github.com>
Message-ID: <3EjlqyLzNCZxo6F1YSOs2zRrNxO5QTIQxkuY27Y3Ro4=.f13abdf7-f15f-44fc-9068-15f3ccda0958@github.com>

> Hi Reviewers,
> 
> Updated manual printer test cases with 'PassFailJFrame', also removed unused variables. Added 'SkippedException' in case of printer missing or not configured.
> 
> Please review and let me know your suggestions.
> 
> Regards,
> Renjith

Renjith Kannath Pariyangad has updated the pull request incrementally with one additional commit since the last revision:

  Updated instruction

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/17608/files
  - new: https://git.openjdk.org/jdk/pull/17608/files/d075faab..a9aebeb8

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=17608&range=09
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17608&range=08-09

  Stats: 24 lines in 1 file changed: 8 ins; 12 del; 4 mod
  Patch: https://git.openjdk.org/jdk/pull/17608.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17608/head:pull/17608

PR: https://git.openjdk.org/jdk/pull/17608

From jwaters at openjdk.org  Mon Mar  4 06:44:56 2024
From: jwaters at openjdk.org (Julian Waters)
Date: Mon, 4 Mar 2024 06:44:56 GMT
Subject: RFR: 8326583: Remove over-generalized DefineNativeToolchain
 solution [v4]
In-Reply-To: <V4syuDAMRYe1BSG2okxw2sdceihpIarwtYI1wIbfxhY=.16d008af-c3df-42fe-a97c-7ac41eaab757@github.com>
References: <lGtsPt-jwk2yeMj9usOUTYfflYDwX8DAhD7RLxWJQ9o=.ae41dd0a-9b28-43a4-9979-84c2f675e531@github.com>
 <V4syuDAMRYe1BSG2okxw2sdceihpIarwtYI1wIbfxhY=.16d008af-c3df-42fe-a97c-7ac41eaab757@github.com>
Message-ID: <YuUVUWRQk3AJj53zCQDi-7Op2CIa4Ggocr-9Z3UsKOc=.c71d5357-aada-478f-bc5c-7606de078fba@github.com>

On Tue, 27 Feb 2024 11:19:59 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> The idea of setting up general "toolchains" in the native build was good, but it turned out that we really only need a single toolchain, with a single twist: if it should use CC or CPP to link. This is better described by a specific argument to SetupNativeCompilation, LANG := C++ or LANG := C (the default).
>> 
>> There is a single exception to this rule, and that is if we want to compile for the build platform rather than the target platform. (This is only done for adlc) To keep expressing this difference, introduce TARGET_TYPE := BUILD (or TARGET_TYPE := TARGET, the default).
>> 
>> The final odd-case was the hack for building hsdis/bin on mingw. This can be resolved using direct variables to SetupNativeCompilation, instead of first creating a toolchain.
>> 
>> Doing this refactoring will simplify the SetupNativeCompilation code, and make it much clearer if we use the C or C++ linker.
>
> Magnus Ihse Bursie has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits:
> 
>  - Merge branch 'master' into remove-toolchain-define
>  - Rename LANG to LINK_TYPE
>  - Reword "lib" comment to fit in better
>  - Merge branch 'master' into remove-toolchain-define
>  - 8326583: Remove over-generalized DefineNativeToolchain solution

I'd find it quite sad if we stopped supporting ccache just because it broke after this commit, I know for a fact that quite a few JDK developers do use it (myself included). Regarding the issue itself, I wonder if it's the SetupToolchain changes that has caused this. ccache is collapsed into CC and CXX to my knowledge, which would explain why the ccache cc or ccache c++ command is missing from the command line (substitute cc and c++ for the respective compiler drivers)

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17986#issuecomment-1975838054

From rkannathpari at openjdk.org  Mon Mar  4 06:48:18 2024
From: rkannathpari at openjdk.org (Renjith Kannath Pariyangad)
Date: Mon, 4 Mar 2024 06:48:18 GMT
Subject: RFR: 8324808 : Manual printer tests have no Pass/Fail buttons,
 instructions close set 3 [v9]
In-Reply-To: <BFuAfPibaBpToXKzPNGUKf6pC1DvjrAedYHdtJxtuO8=.d54fcf6c-0727-4a4e-8a94-73a4ebe78af4@github.com>
References: <BFuAfPibaBpToXKzPNGUKf6pC1DvjrAedYHdtJxtuO8=.d54fcf6c-0727-4a4e-8a94-73a4ebe78af4@github.com>
Message-ID: <A877YpZnLzvXlDU70eT128kB9hnPyuE3xxQlw8UrVCs=.01da0d64-66b0-48d6-b1f3-08c48e251ee8@github.com>

> Hi Reviewers,
> 
> Updated manual printer test cases with 'PassFailJFrame', also removed unused variables. Added 'SkippedException' in case of printer missing or not configured.
> 
> Please review and let me know your suggestions.
> 
> Regards,
> Renjith

Renjith Kannath Pariyangad has updated the pull request incrementally with one additional commit since the last revision:

  Suggesions added

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/17609/files
  - new: https://git.openjdk.org/jdk/pull/17609/files/3847671a..b2b8548d

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=17609&range=08
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17609&range=07-08

  Stats: 26 lines in 2 files changed: 4 ins; 3 del; 19 mod
  Patch: https://git.openjdk.org/jdk/pull/17609.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17609/head:pull/17609

PR: https://git.openjdk.org/jdk/pull/17609

From ihse at openjdk.org  Mon Mar  4 11:30:55 2024
From: ihse at openjdk.org (Magnus Ihse Bursie)
Date: Mon, 4 Mar 2024 11:30:55 GMT
Subject: RFR: 8326583: Remove over-generalized DefineNativeToolchain
 solution [v4]
In-Reply-To: <YuUVUWRQk3AJj53zCQDi-7Op2CIa4Ggocr-9Z3UsKOc=.c71d5357-aada-478f-bc5c-7606de078fba@github.com>
References: <lGtsPt-jwk2yeMj9usOUTYfflYDwX8DAhD7RLxWJQ9o=.ae41dd0a-9b28-43a4-9979-84c2f675e531@github.com>
 <V4syuDAMRYe1BSG2okxw2sdceihpIarwtYI1wIbfxhY=.16d008af-c3df-42fe-a97c-7ac41eaab757@github.com>
 <YuUVUWRQk3AJj53zCQDi-7Op2CIa4Ggocr-9Z3UsKOc=.c71d5357-aada-478f-bc5c-7606de078fba@github.com>
Message-ID: <dnMbFCvYXGSs5Ni7dFUa27Kkni32FmnHBe7BbaHF0do=.3acfc35d-b55d-4673-8ab0-22fc97c1aa18@github.com>

On Mon, 4 Mar 2024 06:42:30 GMT, Julian Waters <jwaters at openjdk.org> wrote:

> I wonder if it's the SetupToolchain changes that has caused this. ccache is collapsed into CC and CXX to my knowledge

Yeah, it must have been. Would you like to take a look at it? Otherwise I'll file a bug and fix it. Breaking ccache was an unintended regression, so it needs to be fixed. If we want to drop ccache support it needs to be done explicitly and separately.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17986#issuecomment-1976368808

From jwaters at openjdk.org  Mon Mar  4 11:48:55 2024
From: jwaters at openjdk.org (Julian Waters)
Date: Mon, 4 Mar 2024 11:48:55 GMT
Subject: RFR: 8326583: Remove over-generalized DefineNativeToolchain
 solution [v4]
In-Reply-To: <dnMbFCvYXGSs5Ni7dFUa27Kkni32FmnHBe7BbaHF0do=.3acfc35d-b55d-4673-8ab0-22fc97c1aa18@github.com>
References: <lGtsPt-jwk2yeMj9usOUTYfflYDwX8DAhD7RLxWJQ9o=.ae41dd0a-9b28-43a4-9979-84c2f675e531@github.com>
 <V4syuDAMRYe1BSG2okxw2sdceihpIarwtYI1wIbfxhY=.16d008af-c3df-42fe-a97c-7ac41eaab757@github.com>
 <YuUVUWRQk3AJj53zCQDi-7Op2CIa4Ggocr-9Z3UsKOc=.c71d5357-aada-478f-bc5c-7606de078fba@github.com>
 <dnMbFCvYXGSs5Ni7dFUa27Kkni32FmnHBe7BbaHF0do=.3acfc35d-b55d-4673-8ab0-22fc97c1aa18@github.com>
Message-ID: <Px2zDTrFwz08uSLyS-F-lWBRD6xTqkNL64lGLhWL1VE=.ee8820f4-7210-4c7f-a6f5-d97df426d509@github.com>

On Mon, 4 Mar 2024 11:28:02 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

> > I wonder if it's the SetupToolchain changes that has caused this. ccache is collapsed into CC and CXX to my knowledge
> 
> Yeah, it must have been. Would you like to take a look at it? Otherwise I'll file a bug and fix it. Breaking ccache was an unintended regression, so it needs to be fixed. If we want to drop ccache support it needs to be done explicitly and separately.

No problem! I do hope that dropping ccache support isn't something that's planned though :(

> Additionally some environment variables are missing/different.

Could I trouble you to mention what exactly was different?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17986#issuecomment-1976398726

From duke at openjdk.org  Mon Mar  4 13:00:54 2024
From: duke at openjdk.org (Claudio Nieder)
Date: Mon, 4 Mar 2024 13:00:54 GMT
Subject: RFR: 8326583: Remove over-generalized DefineNativeToolchain
 solution [v4]
In-Reply-To: <Px2zDTrFwz08uSLyS-F-lWBRD6xTqkNL64lGLhWL1VE=.ee8820f4-7210-4c7f-a6f5-d97df426d509@github.com>
References: <lGtsPt-jwk2yeMj9usOUTYfflYDwX8DAhD7RLxWJQ9o=.ae41dd0a-9b28-43a4-9979-84c2f675e531@github.com>
 <V4syuDAMRYe1BSG2okxw2sdceihpIarwtYI1wIbfxhY=.16d008af-c3df-42fe-a97c-7ac41eaab757@github.com>
 <YuUVUWRQk3AJj53zCQDi-7Op2CIa4Ggocr-9Z3UsKOc=.c71d5357-aada-478f-bc5c-7606de078fba@github.com>
 <dnMbFCvYXGSs5Ni7dFUa27Kkni32FmnHBe7BbaHF0do=.3acfc35d-b55d-4673-8ab0-22fc97c1aa18@github.com>
 <Px2zDTrFwz08uSLyS-F-lWBRD6xTqkNL64lGLhWL1VE=.ee8820f4-7210-4c7f-a6f5-d97df426d509@github.com>
Message-ID: <Eux5XyKqCklnUrXp8aGIOqapxVKbIbHoRuXwMbPBYnA=.fc99209e-8e2f-4abf-8bab-eb137b920d61@github.com>

On Mon, 4 Mar 2024 11:45:59 GMT, Julian Waters <jwaters at openjdk.org> wrote:

> Could I trouble you to mention what exactly was different?

No trouble at all. 

`CCACHE_BASEDIR=/tmp/bceaed6d/jdk/`is completely missing. (The directory is where I checked out OpenJDK)

`CCACHE_SLOPPINESS` has the value `pch_defines,time_macros` with the working parent commit but just `pch_defines` with this commit. I.e. `CCACHE_SLOPPINESS=pch_defines,time_macros` vs `CCACHE_SLOPPINESS=pch_defines`.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17986#issuecomment-1976528283

From jwaters at openjdk.org  Mon Mar  4 13:04:55 2024
From: jwaters at openjdk.org (Julian Waters)
Date: Mon, 4 Mar 2024 13:04:55 GMT
Subject: RFR: 8326583: Remove over-generalized DefineNativeToolchain
 solution [v4]
In-Reply-To: <Eux5XyKqCklnUrXp8aGIOqapxVKbIbHoRuXwMbPBYnA=.fc99209e-8e2f-4abf-8bab-eb137b920d61@github.com>
References: <lGtsPt-jwk2yeMj9usOUTYfflYDwX8DAhD7RLxWJQ9o=.ae41dd0a-9b28-43a4-9979-84c2f675e531@github.com>
 <V4syuDAMRYe1BSG2okxw2sdceihpIarwtYI1wIbfxhY=.16d008af-c3df-42fe-a97c-7ac41eaab757@github.com>
 <YuUVUWRQk3AJj53zCQDi-7Op2CIa4Ggocr-9Z3UsKOc=.c71d5357-aada-478f-bc5c-7606de078fba@github.com>
 <dnMbFCvYXGSs5Ni7dFUa27Kkni32FmnHBe7BbaHF0do=.3acfc35d-b55d-4673-8ab0-22fc97c1aa18@github.com>
 <Px2zDTrFwz08uSLyS-F-lWBRD6xTqkNL64lGLhWL1VE=.ee8820f4-7210-4c7f-a6f5-d97df426d509@github.com>
 <Eux5XyKqCklnUrXp8aGIOqapxVKbIbHoRuXwMbPBYnA=.fc99209e-8e2f-4abf-8bab-eb137b920d61@github.com>
Message-ID: <d16NqTj0wxfYX4lHoWKGG0hKkCFjeWV7mdXfkwzET2A=.835286f5-6ed1-48c1-972e-6ec3c6baeaac@github.com>

On Mon, 4 Mar 2024 12:58:28 GMT, Claudio Nieder <duke at openjdk.org> wrote:

> > Could I trouble you to mention what exactly was different?
> 
> No trouble at all.
> 
> `CCACHE_BASEDIR=/tmp/bceaed6d/jdk/`is completely missing. (The directory is where I checked out OpenJDK)
> 
> `CCACHE_SLOPPINESS` has the value `pch_defines,time_macros` with the working parent commit but just `pch_defines` with this commit. I.e. `CCACHE_SLOPPINESS=pch_defines,time_macros` vs `CCACHE_SLOPPINESS=pch_defines`.

Thanks! Seems curious to me, off the top of my head I can't seem to discern why these would change, perhaps it's time for a little investigating

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17986#issuecomment-1976534197

From aivanov at openjdk.org  Mon Mar  4 13:25:46 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Mon, 4 Mar 2024 13:25:46 GMT
Subject: RFR: 8326458: Menu mnemonics don't toggle in Windows LAF when F10
 is pressed [v5]
In-Reply-To: <MBae7-qGN732DvQe3I4orB3EbRoT6vo1PoSoxcVLxtw=.26050b99-0d92-4bb8-9c8f-e8ed5844a931@github.com>
References: <uv53ohrzj-j8wA3SHr7M0b5V-Ja9HvKGBa2RgWTwoSU=.abf8c336-4b24-479c-af6d-22acb686ed80@github.com>
 <MBae7-qGN732DvQe3I4orB3EbRoT6vo1PoSoxcVLxtw=.26050b99-0d92-4bb8-9c8f-e8ed5844a931@github.com>
Message-ID: <B41fro-48wsTA9nnIHT7NdvY6qHZasrfImsc9GB5NZ8=.5222ff3f-ae2a-4fb7-825b-f1443a6840e2@github.com>

On Fri, 1 Mar 2024 16:05:07 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Menu mnemonic doesn't toggle between show and hide state when F10 is pressed. Behavior is not similar to windows native application. Fix is to ensure that menu mnemonic state toggles between show and hide.
>> 
>> Can be verified with SwingSet2 application. 
>> CI tests are green with the fix. Link posted in JBS.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review comment update

Changes requested by aivanov (Reviewer).

src/java.desktop/windows/classes/com/sun/java/swing/plaf/windows/WindowsMenuBarUI.java line 142:

> 140:     @SuppressWarnings("serial") // Superclass is not serializable across versions
> 141:     private static class TakeFocus extends AbstractAction {
> 142:         static boolean mnemonicShowHideFlag = false;

Not used any more.

src/java.desktop/windows/classes/com/sun/java/swing/plaf/windows/WindowsMenuBarUI.java line 143:

> 141:     private static class TakeFocus extends AbstractAction {
> 142:         static boolean mnemonicShowHideFlag = false;
> 143:         public void actionPerformed(ActionEvent e) {

I suggest adding `@Override` annotation.

Most methods in the class have the annotation.

test/jdk/javax/swing/JMenuBar/TestMenuMnemonic.java line 36:

> 34: import java.awt.event.KeyEvent;
> 35: import java.awt.Robot;
> 36: import java.util.concurrent.atomic.AtomicInteger;

Sort imports:
Suggestion:

import java.awt.Robot;
import java.awt.event.KeyEvent;
import java.util.concurrent.atomic.AtomicInteger;

test/jdk/javax/swing/JMenuBar/TestMenuMnemonic.java line 40:

> 38: import javax.swing.JMenu;
> 39: import javax.swing.JMenuItem;
> 40: import javax.swing.JMenuBar;

Sort imports:
Suggestion:

import javax.swing.JMenuBar;
import javax.swing.JMenuItem;

test/jdk/javax/swing/JMenuBar/TestMenuMnemonic.java line 45:

> 43: import javax.swing.SwingUtilities;
> 44: import javax.swing.UIManager;
> 45: import com.sun.java.swing.plaf.windows.WindowsLookAndFeel;

Suggestion:

import javax.swing.UIManager;

import com.sun.java.swing.plaf.windows.WindowsLookAndFeel;


I suggest adding a blank line to separate the standard imported packages from non-standard ones, in this case it's even an implementation-private package.

test/jdk/javax/swing/JMenuBar/TestMenuMnemonic.java line 55:

> 53:     public static void main(String[] args) throws Exception {
> 54:         UIManager.setLookAndFeel("com.sun.java.swing.plaf.windows.WindowsLookAndFeel");
> 55:         int expectedMnemonicShowHideCount = 5;

Make it a constant, for example `EXPECTED`.

test/jdk/javax/swing/JMenuBar/TestMenuMnemonic.java line 66:

> 64:             robot.delay(1000);
> 65: 
> 66:             for (int i = 0; i < 10; i++) {

Suggestion:

            for (int i = 0; i < EXPECTED * 2; i++) {

No magic numbers, after all the number of `EXPECTED` show/hide depends on how many iterations the loop does.

test/jdk/javax/swing/JMenuBar/TestMenuMnemonic.java line 87:

> 85:                         mnemonicShowCount.getAndIncrement();
> 86:                         if (selectedPath.length != 2 &&
> 87:                                 (selectedPath[0] != menuBar || selectedPath[1] != fileMenu)) {

Suggestion:

                        if (selectedPath.length != 2
                            && (selectedPath[0] != menuBar || selectedPath[1] != fileMenu)) {

In all the other places you wrap before the operator; in fact it's what Java Coding Style recommends doing. And this style makes it clear that it's a continuation line, if it starts with an operator.

test/jdk/javax/swing/JMenuBar/TestMenuMnemonic.java line 92:

> 90:                         }
> 91:                     }
> 92:                 });

May I suggest creating a method for verifying the state of mnemonics? Then the `main` will be shorter:


                SwingUtilities.invokeAndWait(TestMenuMnemonic::verifyMnemonicsState);

You'll have to make `mnemonicHideCount` and `mnemonicShowCount` static fields (and `final` please).

-------------

PR Review: https://git.openjdk.org/jdk/pull/17961#pullrequestreview-1914242401
PR Review Comment: https://git.openjdk.org/jdk/pull/17961#discussion_r1511119367
PR Review Comment: https://git.openjdk.org/jdk/pull/17961#discussion_r1511127629
PR Review Comment: https://git.openjdk.org/jdk/pull/17961#discussion_r1511130722
PR Review Comment: https://git.openjdk.org/jdk/pull/17961#discussion_r1511131445
PR Review Comment: https://git.openjdk.org/jdk/pull/17961#discussion_r1511134440
PR Review Comment: https://git.openjdk.org/jdk/pull/17961#discussion_r1511145696
PR Review Comment: https://git.openjdk.org/jdk/pull/17961#discussion_r1511148255
PR Review Comment: https://git.openjdk.org/jdk/pull/17961#discussion_r1511154492
PR Review Comment: https://git.openjdk.org/jdk/pull/17961#discussion_r1511152467

From mkartashev at openjdk.org  Mon Mar  4 14:53:21 2024
From: mkartashev at openjdk.org (Maxim Kartashev)
Date: Mon, 4 Mar 2024 14:53:21 GMT
Subject: RFR: 8326497: Window.toFront() fails for iconified windows on
 Linux [v3]
In-Reply-To: <XmMRoFNpTDQHCZLnmmnNGVjhR2Ib3yw1kWc0v57utUM=.e418325c-7b23-4298-8f75-e81d369b5afc@github.com>
References: <XmMRoFNpTDQHCZLnmmnNGVjhR2Ib3yw1kWc0v57utUM=.e418325c-7b23-4298-8f75-e81d369b5afc@github.com>
Message-ID: <gJ5-SlDm9BhOwbT_BawA0WS557imTXUvLeob3vJ9gbg=.e98c2e06-4852-416c-adbd-1aaf71e00607@github.com>

> XToolkit implements `toFront()` essentially by sending the  `_NET_ACTIVE_WINDOW` message to activate the window. This has no effect when the target window is in the iconified state. So the fix is to cancel that state prior to sending the message.
> 
> The test verifies that the fix works for maximized and undecorated frames as well out of abundance of caution; they do not represent a special case from the `toFront()` standpoint.
> 
> References
> * `_NET_ACTIVE_WINDOW`: https://specifications.freedesktop.org/wm-spec/1.3/ar01s03.html
> * [Inter-Client Communication Conventions Manual, 4.1.4. Changing Window State](https://tronche.com/gui/x/icccm/sec-4.html#s-4.1.4)

Maxim Kartashev has updated the pull request incrementally with one additional commit since the last revision:

  Adapted the test to the realities of macOS

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/17985/files
  - new: https://git.openjdk.org/jdk/pull/17985/files/1b69d068..35cef969

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=17985&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17985&range=01-02

  Stats: 46 lines in 1 file changed: 0 ins; 45 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/17985.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17985/head:pull/17985

PR: https://git.openjdk.org/jdk/pull/17985

From ihse at openjdk.org  Mon Mar  4 15:01:58 2024
From: ihse at openjdk.org (Magnus Ihse Bursie)
Date: Mon, 4 Mar 2024 15:01:58 GMT
Subject: RFR: 8326583: Remove over-generalized DefineNativeToolchain
 solution [v4]
In-Reply-To: <Px2zDTrFwz08uSLyS-F-lWBRD6xTqkNL64lGLhWL1VE=.ee8820f4-7210-4c7f-a6f5-d97df426d509@github.com>
References: <lGtsPt-jwk2yeMj9usOUTYfflYDwX8DAhD7RLxWJQ9o=.ae41dd0a-9b28-43a4-9979-84c2f675e531@github.com>
 <V4syuDAMRYe1BSG2okxw2sdceihpIarwtYI1wIbfxhY=.16d008af-c3df-42fe-a97c-7ac41eaab757@github.com>
 <YuUVUWRQk3AJj53zCQDi-7Op2CIa4Ggocr-9Z3UsKOc=.c71d5357-aada-478f-bc5c-7606de078fba@github.com>
 <dnMbFCvYXGSs5Ni7dFUa27Kkni32FmnHBe7BbaHF0do=.3acfc35d-b55d-4673-8ab0-22fc97c1aa18@github.com>
 <Px2zDTrFwz08uSLyS-F-lWBRD6xTqkNL64lGLhWL1VE=.ee8820f4-7210-4c7f-a6f5-d97df426d509@github.com>
Message-ID: <eiywV-5D-ligXgz8loKKDINf1BpFgJl9X7dKMSfAuu0=.4ad1ab6e-2dd8-43d4-bc52-ee0e16cd7fda@github.com>

On Mon, 4 Mar 2024 11:45:59 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>  I do hope that dropping ccache support isn't something that's planned though :(

Not really. The benefit of dropping it is quite small, and there might be use cases where it helps.

But I think we should perhaps be more explicit in the documentation that it is not obvious that it helps performance, and encourage testing before enabling it. And perhaps even print a warning in configure if you enable it that you need to check that it helps.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17986#issuecomment-1976777022

From aivanov at openjdk.org  Mon Mar  4 15:58:05 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Mon, 4 Mar 2024 15:58:05 GMT
Subject: RFR: 8327137: Add test for ConcurrentModificationException in
 BasicDirectoryModel
Message-ID: <mCqqjrXVWDB2PvpOhKHx-Hr8W6tUz6v4stztGmyAeEg=.1f95da1c-e1a5-40be-be8b-0758729fa9b9@github.com>

I'm adding a regression test for [JDK-8323670](https://bugs.openjdk.org/browse/JDK-8323670) and [JDK-8307091](https://bugs.openjdk.org/browse/JDK-8307091); it's also a regression test for [JDK-8240690](https://bugs.openjdk.org/browse/JDK-8240690).

I referenced this test in PR #17462 in [this comment](https://github.com/openjdk/jdk/pull/17462#issuecomment-1914844026). I fine-tuned the test since that time.

The test doesn't fail all the time without the fix for JDK-8323670, however, it fails sometimes. If you run the test several times, it will likely fail _without the fix_.

For me, the test fails about 10 times from 40 runs in the CI. It fails on macOS more frequently than on Linux.

When the test passes, it usually completes in 5 minutes.

**How the test works**

The test creates a temporary directory in the current directory and creates a number of files in it. (The number of files is controlled by `NUMBER_OF_THREADS` constant). Then the test creates `JFileChooser` in the temporary directory.

The test starts several _scanner_ threads, the number is controlled by `NUMBER_OF_THREADS`, which repeatedly call `fileChooser.rescanCurrentDirectory()`. This results in calling `BasicDirectoryModel.validateFileCache` which starts a background thread ? "Basic L&F File Loading Thread" ? to enumerate the files.

A timer is used to create new files in the directory that the file chooser is using.

After enumerating the files, the File Loading Thread posts an event to EDT. The event updates `fileCache` and fires a `ListDataEvent`.

If the File Loading Thread is iterating over `fileCache` using `Iterator` (when `fileCache.subList` or `fileCache.equals` is running; or a new `Vector` instance is created from a `fileCache` or its sublist) and `fileCache` is being updated on EDT, then `ConcurrentModificationException` is thrown.

On Linux and on _headless_ macOS, `ShellFolder.invoke` is executed in the caller, which makes it easier to reproduce the issue. Because of [JDK-8325179](https://bugs.openjdk.org/browse/JDK-8325179), there are several File Loading Threads, which also helps to reproduce the issue.

On _headful_ macOS, the `BasicDirectoryModel` is not used, so the test does not reproduce the issue.

On Windows, the test does not fail or fails with `OutOfMemoryError`. It is because all the File Loading Threads are serialised on the COM thread, `ShellFolder.invoke` submits the task to the COM thread and waits for it to complete. The chance of updating `fileCache` while another thread is iterating over it is significantly reduced.

Even more, `filechooser.isTraversable(file)` is also executed on the COM thread, which means there's a heavy contention for the COM thread from each File Loading Thread.

-------------

Commit messages:
 - Explicitly run the test in headless mode
 - Rename the class
 - Move the test under jx.s.plaf.basic/BasicDirectoryModel
 - Add comment for fields, explain usage of ThreadGroup
 - Reduce the parameters: files: 50; file limit: 10; timer: 250
 - Merge master
 - The test is for Linux and macOS only
 - Set 'Test Runner' name to the (main) runner
 - Back to initial parameters: 1,000 files, 5 threads, 2,000 repeats
 - Amend the summary of the test
 - ... and 16 more: https://git.openjdk.org/jdk/compare/8f6edd8d...0d6be7a4

Changes: https://git.openjdk.org/jdk/pull/18109/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18109&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8327137
  Stats: 237 lines in 1 file changed: 237 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18109.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18109/head:pull/18109

PR: https://git.openjdk.org/jdk/pull/18109

From aivanov at openjdk.org  Mon Mar  4 16:17:54 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Mon, 4 Mar 2024 16:17:54 GMT
Subject: RFR: 8326661: sun/java2d/cmm/ColorConvertOp/ColConvTest.java
 assumes profiles were generated by LCMS
In-Reply-To: <nFplnFr0UPf-gWrZjoyZhb2pCJ_fjUEieIxTlWesSNs=.7f372d25-5bc5-4fb2-9ecd-8d5e40cc69b8@github.com>
References: <nFplnFr0UPf-gWrZjoyZhb2pCJ_fjUEieIxTlWesSNs=.7f372d25-5bc5-4fb2-9ecd-8d5e40cc69b8@github.com>
Message-ID: <GZUNOwm1iGxyqRPrr9HL-74fAI8iSE64dcF1DLW2dtY=.7d14edd5-6dc4-42d4-b236-dcb74ef77c7b@github.com>

On Sun, 3 Mar 2024 09:01:49 GMT, Dmitry Markov <dmarkov at openjdk.org> wrote:

> Updated several tests to avoid potential failure with recent LCMS update and non-LCMS generated profile.

The fix is to always use the accuracy which is used for the LCMS library, without trying to detect what colour profile is used. Right?

-------------

Marked as reviewed by aivanov (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18097#pullrequestreview-1914734068

From duke at openjdk.org  Mon Mar  4 16:36:57 2024
From: duke at openjdk.org (Claudio Nieder)
Date: Mon, 4 Mar 2024 16:36:57 GMT
Subject: RFR: 8326583: Remove over-generalized DefineNativeToolchain
 solution [v4]
In-Reply-To: <V4syuDAMRYe1BSG2okxw2sdceihpIarwtYI1wIbfxhY=.16d008af-c3df-42fe-a97c-7ac41eaab757@github.com>
References: <lGtsPt-jwk2yeMj9usOUTYfflYDwX8DAhD7RLxWJQ9o=.ae41dd0a-9b28-43a4-9979-84c2f675e531@github.com>
 <V4syuDAMRYe1BSG2okxw2sdceihpIarwtYI1wIbfxhY=.16d008af-c3df-42fe-a97c-7ac41eaab757@github.com>
Message-ID: <vBRE5ItRzRSFWymd8ajaSQHPOX4Lhc_8LFN-nGfcJ0Q=.81ab56fb-41c6-426d-846e-09fab6258f8b@github.com>

On Tue, 27 Feb 2024 11:19:59 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> The idea of setting up general "toolchains" in the native build was good, but it turned out that we really only need a single toolchain, with a single twist: if it should use CC or CPP to link. This is better described by a specific argument to SetupNativeCompilation, LANG := C++ or LANG := C (the default).
>> 
>> There is a single exception to this rule, and that is if we want to compile for the build platform rather than the target platform. (This is only done for adlc) To keep expressing this difference, introduce TARGET_TYPE := BUILD (or TARGET_TYPE := TARGET, the default).
>> 
>> The final odd-case was the hack for building hsdis/bin on mingw. This can be resolved using direct variables to SetupNativeCompilation, instead of first creating a toolchain.
>> 
>> Doing this refactoring will simplify the SetupNativeCompilation code, and make it much clearer if we use the C or C++ linker.
>
> Magnus Ihse Bursie has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits:
> 
>  - Merge branch 'master' into remove-toolchain-define
>  - Rename LANG to LINK_TYPE
>  - Reword "lib" comment to fit in better
>  - Merge branch 'master' into remove-toolchain-define
>  - 8326583: Remove over-generalized DefineNativeToolchain solution

One little side note, I tried now also on a Linux x86 system and saw the same issue, so it is not limited to macOS or aarch64.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17986#issuecomment-1976999445

From prr at openjdk.org  Mon Mar  4 17:04:54 2024
From: prr at openjdk.org (Phil Race)
Date: Mon, 4 Mar 2024 17:04:54 GMT
Subject: RFR: 8195675: Call to insertText with single character from custom
 Input Method ignored
In-Reply-To: <70yOUGT0N_mI3Pq8UVS-KgUAzZbtRhFniW8U16iVtlk=.7d6edddb-d68b-4b98-aaaf-1e60224dee0b@github.com>
References: <70yOUGT0N_mI3Pq8UVS-KgUAzZbtRhFniW8U16iVtlk=.7d6edddb-d68b-4b98-aaaf-1e60224dee0b@github.com>
Message-ID: <u4b11jevNfC8exSXDejpgklF2_HF-1W16mp04vQH1Ts=.878c5bf4-f237-4c05-bb03-5c8db3d16a9a@github.com>

On Tue, 20 Feb 2024 02:08:09 GMT, Steven Loomis <srl at openjdk.org> wrote:

> 8195675: Call to insertText with single character from custom Input Method ignored

Marked as reviewed by prr (Reviewer).

src/java.desktop/macosx/native/libawt_lwawt/awt/AWTView.m line 972:

> 970:         ((utf8Length > 1) && [self isCodePointInUnicodeBlockNeedingIMEvent:codePoint]) ||
> 971:         [(NSString *)kbdLayout containsString:@KEYMAN_LAYOUT]) {
> 972: #ifdef IM_DEBUG

As noted in JBS Kotoeri is obsolete, which is why the reference to it here should be removed as part of this change.

-------------

PR Review: https://git.openjdk.org/jdk/pull/17921#pullrequestreview-1914844169
PR Review Comment: https://git.openjdk.org/jdk/pull/17921#discussion_r1511488212

From prr at openjdk.org  Mon Mar  4 17:56:46 2024
From: prr at openjdk.org (Phil Race)
Date: Mon, 4 Mar 2024 17:56:46 GMT
Subject: RFR: 8185862: AWT Assertion Failure in ::GetDIBits(hBMDC, hBM, 0, 
 1, 0, gpBitmapInfo, 0) 'awt_Win32GraphicsDevice.cpp', at line 185 [v8]
In-Reply-To: <yLFbIvVt-ZuGKMVJvXx19rUxVgG1-ewJwM5SAEzoUvo=.15df7df6-0c62-4c60-837c-33fdf90eab11@github.com>
References: <Cj_htOZE6ImXdNmj43IBiX7rW4Em4ZF-6kx0qIZW-Ho=.d355fedd-7ec8-463d-969b-e2123987d1dd@github.com>
 <yLFbIvVt-ZuGKMVJvXx19rUxVgG1-ewJwM5SAEzoUvo=.15df7df6-0c62-4c60-837c-33fdf90eab11@github.com>
Message-ID: <GNoAgqfYmqBSHp47bTVaxoW-67yti8BEUtKuPxH4hT0=.0f77d043-f820-48c5-b7c5-3d0f49b35865@github.com>

On Fri, 1 Mar 2024 08:01:08 GMT, Christoph Langer <clanger at openjdk.org> wrote:

>> The assertions reported in the bug were observed spuriously and here and there broke tests in some Windows configurations.
>> For instance [JDK-8266129](https://bugs.openjdk.org/browse/JDK-8266129), [JDK-8269529](https://bugs.openjdk.org/browse/JDK-8269529) or [JDK-8323664](https://bugs.openjdk.org/browse/JDK-8323664) came up due to this.
>> 
>> The problem is that in Windows environments without a valid display, e.g. started by system services or via PowerShell Remoting, one sees a Monitor with name 'Windisc' in `EnumDisplayMonitors`.
>> However, it seems to be some kind of a pseudo device where you can not get a DC via `CreateDC`. This behavior/monitor type doesn't seem to be well documented, though.
>> 
>> I hereby modify the device initialization code to only count/detect monitors where CreateDC returns non-NULL in Devices.cpp. I also add some more checking/error handling to AwtWin32GraphicsDevice::Initialize() for correctness.
>> 
>> Furthermore, I re-enable the test `javax/swing/reliability/HangDuringStaticInitialization.java` for Windows Debug VMs, which reverts the fix from JDK-8269529 that should not be necessary any more.
>
> Christoph Langer has updated the pull request incrementally with one additional commit since the last revision:
> 
>   load awt.dll before display check

This now passes all my automated testing.
Have you tested manual apps like SwingSet ? 
I doubt they'll have a problem but it would be good to be 100% sure.

The only thing I notice here is it adds one more place that we duplicate the code to load the AWT native library. Bizarrely Toolkit *and* WToolkit both do it.
The result is not just duplicated code but duplicated (now triplicated) effort at startup.
There might even be a fourth place - NativeLibLoader.
But fixing that might mean being extra careful about not introducing circularities at start up and since the impact should be negligible I think it is out of scope for this fix.

So just let me know about the manual testing.

-------------

PR Review: https://git.openjdk.org/jdk/pull/17614#pullrequestreview-1914948095

From prr at openjdk.org  Mon Mar  4 18:12:55 2024
From: prr at openjdk.org (Phil Race)
Date: Mon, 4 Mar 2024 18:12:55 GMT
Subject: RFR: 8286759: TextComponentPrintable: consequent -> consecutive
 positions
In-Reply-To: <CTbRheJJ9yn-OaBNP3gBAhiEfSCS2K9nOXuyuVal9Ns=.72f8155d-78b0-4ec7-93f5-9457b235a205@github.com>
References: <CTbRheJJ9yn-OaBNP3gBAhiEfSCS2K9nOXuyuVal9Ns=.72f8155d-78b0-4ec7-93f5-9457b235a205@github.com>
Message-ID: <3V52jpktdb-W7pezzS8zWsRhH6tvVAaPcORlb7P-55k=.e5d20f00-8e57-42aa-9467-eb9bc2a9e90c@github.com>

On Thu, 29 Feb 2024 15:13:16 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> A trivial change in a comment: consequent ? _consecutive_ positions.
> 
> This was found in [a code review](https://github.com/openjdk/jdk/pull/8328#discussion_r872596373) for [JDK-8285306](https://bugs.openjdk.org/browse/JDK-8285306).

src/java.desktop/share/classes/sun/swing/text/TextComponentPrintable.java line 785:

> 783:                          * we do not store the same value as previous. in our
> 784:                          * documents it is often for consecutive positions to have
> 785:                          * the same modelToView y and height.

If we are going to fix that, we might as well fix the entire sentence.
In particular I strongly suspect that the author meant "common" not "often".
"often" would only be correct here if used in a phrase like "often the case", but "common" is simpler.
And the usage of "previous" isn't right.
 I'm not sure I get what the commenter means to say here, perhaps "previously" ?

And capitalise "We", and "In" since they begin sentences

    * We do not store the same value as previously.
    * In our documents it is common for consequent positions to have
    * the same modelToView y and height.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18067#discussion_r1511570584

From prr at openjdk.org  Mon Mar  4 19:00:55 2024
From: prr at openjdk.org (Phil Race)
Date: Mon, 4 Mar 2024 19:00:55 GMT
Subject: RFR: 8327007: javax/swing/JSpinner/8008657/bug8008657.java fails
 [v2]
In-Reply-To: <XwRkHlWrMXl7DdJNguhdqkqDBFwUy-PMgtV92IgOVJY=.d1b1c5e1-aeae-4b96-9f0e-f3e6baeb562e@github.com>
References: <e_F-RYcAjzGOzHQL95zVz5z77cSdPDKpnPzuN3ExsNM=.9615c27e-92d5-4a10-8e34-be66ef6883aa@github.com>
 <XwRkHlWrMXl7DdJNguhdqkqDBFwUy-PMgtV92IgOVJY=.d1b1c5e1-aeae-4b96-9f0e-f3e6baeb562e@github.com>
Message-ID: <pSwgWwGegeNFqxst1mAAvzb401nPKtW7Irpc3QKF_Sc=.ba786ed6-e491-47fb-a3d1-ce3d27f02356@github.com>

On Mon, 4 Mar 2024 05:19:02 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Test failed with the exception java.lang.IllegalArgumentException: (start <= value <= end) with no history of failing till date.
>> Investigation shows SpinnerDateModel constructor condition is not satisfied because
>> It seems it's a leap year problem that is being manifested..
>> 
>> As per test,
>> initDate Thu Feb 29 13:49:08 IST 2024 [ obtained by calendar.getTime();]
>> earliestDate Tue Feb 28 13:49:08 IST 2023 [obtained by calendar.add(Calendar.YEAR, -1);]
>> latestDate Wed Feb 28 13:49:08 IST 2024 [obtained by calendar.add(Calendar.YEAR, 1);]
>> 
>> Now, as per SpinnerDateModel constructor
>> earliestDate <= initDate condition is satisfied
>> but
>> latestDate >= initDate is not
>> so [start <= value <= end](https://github.com/openjdk/jdk/blob/998d0baab0fd051c38d9fd6021628eb863b80554/src/java.desktop/share/classes/javax/swing/SpinnerDateModel.java#L185) condition fails
>> 
>> Not sure it anything can be done in Calendar class for this but fix is done in test taking leapyear into account so that we add a day if it's a leapyear when we consecutively do Calendar.add(YEAR, -1) and Calendar.add(YEAR,1) on leapyear date of 29Feb
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Increment DAY_OF_MONTH to circumvent leapyear issue

Marked as reviewed by prr (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18054#pullrequestreview-1915091639

From aivanov at openjdk.org  Mon Mar  4 20:25:01 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Mon, 4 Mar 2024 20:25:01 GMT
Subject: RFR: 8325179: Race in BasicDirectoryModel.validateFileCache
Message-ID: <nOapec57Ql6DHy57oEeWdkUGER8RYdWc2vwmJsqWDYc=.8de81954-d8c2-4937-b426-e61dde05255e@github.com>

Ensure access to the `filesLoader` field of `BasicDirectoryModel` is synchronized.

Without synchronization, a thread checks if `filesLoader` is not null and creates a new `FilesLoader` thread. If the thread is pre-empted between these two operations, another thread or even several threads can see the `null` value and create new `FilesLoader` threads.

The same way, `BasicDirectoryModel.invalidateFileCache` needs to be synchornized to interrupt the current `filesLoader` and assign `null`.

This bug allows reproducing `ConcurrentModificationException` seen in [JDK-8323670](https://bugs.openjdk.org/browse/JDK-8323670) and [JDK-8307091](https://bugs.openjdk.org/browse/JDK-8307091) using the test in PR #18109.

-------------

Commit messages:
 - Remove volatile modifier from DoChangeContents in FilesLoader
 - Remove synchronized modifier from DoChangeContents.run
 - Declare addStart and remStart in DoChangeContents as final
 - Reverse condition in DoChangeContents.run to decrease indentation
 - Remove cancelRunnables
 - Declare newFiles as final
 - Remove redundant fileSystem variable in FilesLoader.run0
 - Create FilesLoader inside synchronized section

Changes: https://git.openjdk.org/jdk/pull/18111/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18111&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8325179
  Stats: 61 lines in 1 file changed: 14 ins; 23 del; 24 mod
  Patch: https://git.openjdk.org/jdk/pull/18111.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18111/head:pull/18111

PR: https://git.openjdk.org/jdk/pull/18111

From aivanov at openjdk.org  Mon Mar  4 20:32:43 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Mon, 4 Mar 2024 20:32:43 GMT
Subject: RFR: 8325179: Race in BasicDirectoryModel.validateFileCache
In-Reply-To: <nOapec57Ql6DHy57oEeWdkUGER8RYdWc2vwmJsqWDYc=.8de81954-d8c2-4937-b426-e61dde05255e@github.com>
References: <nOapec57Ql6DHy57oEeWdkUGER8RYdWc2vwmJsqWDYc=.8de81954-d8c2-4937-b426-e61dde05255e@github.com>
Message-ID: <QWZ04QKldKgPNcd4udTXe3BhUUsf1m1H3S738iRJJVk=.f62e5c7e-7025-4946-bfc0-7a6fe480b5fb@github.com>

On Mon, 4 Mar 2024 20:21:30 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> Ensure access to the `filesLoader` field of `BasicDirectoryModel` is synchronized.
> 
> Without synchronization, a thread checks if `filesLoader` is not null and creates a new `FilesLoader` thread. If the thread is pre-empted between these two operations, another thread or even several threads can see the `null` value and create new `FilesLoader` threads.
> 
> The same way, `BasicDirectoryModel.invalidateFileCache` needs to be synchornized to interrupt the current `filesLoader` and assign `null`.
> 
> This bug allows reproducing `ConcurrentModificationException` seen in [JDK-8323670](https://bugs.openjdk.org/browse/JDK-8323670) and [JDK-8307091](https://bugs.openjdk.org/browse/JDK-8307091) using the test in PR #18109.

This fix also resolves [JDK-8238169](https://bugs.openjdk.org/browse/JDK-8238169) because the `cancelRunnables` method is removed; the `synchronized` modifier from `DoChangeContents.run` is also removed.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18111#issuecomment-1977400767

From mark.yagnatinsky at barclays.com  Mon Mar  4 20:42:18 2024
From: mark.yagnatinsky at barclays.com (mark.yagnatinsky at barclays.com)
Date: Mon, 4 Mar 2024 20:42:18 +0000
Subject: how to get find out the keyboard shortcut for the paste
 action?
In-Reply-To: <emfa5db32b-c08c-4ebc-a061-fc24306fbe93@dcff66fe.com>
References: <CH3PR12MB76198C4F8B2300D806EDCCF0F9452@CH3PR12MB7619.namprd12.prod.outlook.com>
 <em455be664-76d1-43e4-ba85-729678b34dc6@76ca4640.com>
 <CH3PR12MB7619B0682852C7C836096E84F95C2@CH3PR12MB7619.namprd12.prod.outlook.com>
 <CH3PR12MB76199D23AB541CB4C09118AAF95C2@CH3PR12MB7619.namprd12.prod.outlook.com>
 <emfa5db32b-c08c-4ebc-a061-fc24306fbe93@dcff66fe.com>
Message-ID: <CH3PR12MB76196E29050B67CD2888B8AEF9232@CH3PR12MB7619.namprd12.prod.outlook.com>

Thanks!  I don?t have a particularly deep motivation here, other than curiosity.
If you?re wondering how my curiosity got piqued initially, it was something like this:
A while ago, someone at work was adding copy/paste support to some component that didn?t have it.
I noticed that they ?hardcoded? the shortcut ?ctrl C?.
And I thought to myself:
Swing already ?knows? that this is the right keyboard shortcut, in the sense that all components that support copy/paste ?out of the box? use it.
It would be nice if there was some way to ASK it to tell me what it ?knows?.

From: Jeremy Wood <mickleness at gmail.com>
Sent: Sunday, March 3, 2024 11:30 PM
To: Yagnatinsky, Mark : Markets Pre Trade <mark.yagnatinsky at barclays.com>; client-libs-dev at openjdk.org
Subject: Re[2]: how to get find out the keyboard shortcut for the paste action?


CAUTION: This email originated from outside our organisation - mickleness at gmail.com<mailto:mickleness at gmail.com> Do not click on links, open attachments, or respond unless you recognize the sender and can validate the content is safe.
> But now I have a new question?
> Is there any way to get the ?usual? letter for a ?common? operation?

Hmm. Good question. Not that I know of.

> Again, one could create a scratch text area and grovel through its input map, but that seems hacky.

I agree sifting through the L&F seems hacky.

I don?t think I understand exactly what you?re trying to implement here. If you give me a more concrete example: maybe I (or someone on this list) can offer a more concrete suggestion?

I?ll add some context in case this speaks to your question.

By default Swing gets this information in places like BasicTextUI#getInputMap(), which calls:


InputMap shared =
    (InputMap)DefaultLookup.get(editor, this,
    getPropertyPrefix() + ".focusInputMap?);

The following works on my Mac & Windows machine (I think using JDK 19), but I wouldn?t be surprised if it fails in other platforms / L&F?s. It feels brittle, but it might (?) have potential:

private KeyStroke getCopyKeyStroke() {

    InputMap inputMap = (InputMap) UIManager.getDefaults().get("TextField.focusInputMap");
    for (KeyStroke keyStroke : inputMap.keys()) {
        Object action = inputMap.get(keyStroke);
        if ("copy-to-clipboard".equals(action)) {
            return keyStroke;
        }
    }
    // this will show all the default keystrokes
//                System.out.println(Arrays.asList(inputMap.allKeys()));

    return null;
}
Regards,
 - Jeremy



------ Original Message ------
From mark.yagnatinsky at barclays.com<mailto:mark.yagnatinsky at barclays.com>
To mickleness at gmail.com<mailto:mickleness at gmail.com>; client-libs-dev at openjdk.org<mailto:client-libs-dev at openjdk.org>
Date 3/3/24, 6:00:46?PM
Subject RE: how to get find out the keyboard shortcut for the paste action?

Thanks for the response!  I didn?t expect to get one at this point ?
It does indeed answer my question!
(Though you didn?t quite get the name right: there?s no Ex at the end?
I take it you?ve done some Windows programming at some point)

But now I have a new question?
Is there any way to get the ?usual? letter for a ?common? operation?
For instance, lots of programs support copy and paste.
Is there a way to ask Java ?what is the standard letter for paste? and get back ?V??
Again, one could create a scratch text area and grovel through its input map, but that seems hacky.

This message is for information purposes only. It is not a recommendation, advice, offer or solicitation to buy or sell a product or service, nor an official confirmation of any transaction. It is directed at persons who are professionals and is intended for the recipient(s) only. It is not directed at retail customers. This message is subject to the terms at: https://www.ib.barclays/disclosures/web-and-email-disclaimer.html<https://clicktime.symantec.com/15t5z4mRR1xMFCVmtWvPc?h=_ZThFXzMRdPMMViuNihJVxTtPiys_I6w5KRtMVx1Fb4=&u=https://www.ib.barclays/disclosures/web-and-email-disclaimer.html>.

For important disclosures, please see: https://www.ib.barclays/disclosures/sales-and-trading-disclaimer.html<https://clicktime.symantec.com/15t5uEa8xQGkqFfrLxXEz?h=aZV9E8QlHEZXtd0LrGSqdmqft6KqysFQSLGlZwqVa3M=&u=https://www.ib.barclays/disclosures/sales-and-trading-disclaimer.html> regarding marketing commentary from Barclays Sales and/or Trading desks, who are active market participants; https://www.ib.barclays/disclosures/barclays-global-markets-disclosures.html<https://clicktime.symantec.com/15t5ejzHaZDybRC5iHKo8?h=RfNE8pkWUQa8xg2DoVwTtgkk49rIoTtEUzNyxF83j9M=&u=https://www.ib.barclays/disclosures/barclays-global-markets-disclosures.html> regarding our standard terms for Barclays Investment Bank where we trade with you in principal-to-principal wholesale markets transactions; and in respect to Barclays Research, including disclosures relating to specific issuers, see: http://publicresearch.barclays.com<https://clicktime.symantec.com/15t5Zuo17wYPBUNAAiveW?h=-A3ytf21bzyvpw7G-HZH3xdk0z4TW9wQtXUIIHCyj8k=&u=http://publicresearch.barclays.com>.
__________________________________________________________________________________
If you are incorporated or operating in Australia, read these important disclosures: https://www.ib.barclays/disclosures/important-disclosures-asia-pacific.html<https://clicktime.symantec.com/15t5jaBa3Aua1N21Fqiwk?h=LNM_ZzBtmQ4icORcCbaHc_8simHhFf5h1R4P9VgQL4g=&u=https://www.ib.barclays/disclosures/important-disclosures-asia-pacific.html>.
__________________________________________________________________________________
For more details about how we use personal information, see our privacy notice: https://www.ib.barclays/disclosures/personal-information-use.html<https://clicktime.symantec.com/15t5pQNrVnbARJqvoQ86N?h=zaTRORm7ul9DlmzrjTzMBw2RNalvZJOfCr_u6f-IlR0=&u=https://www.ib.barclays/disclosures/personal-information-use.html>.
__________________________________________________________________________________

This message is for information purposes only. It is not a recommendation, advice, offer or solicitation to buy or sell a product or service, nor an official confirmation of any transaction. It is directed at persons who are professionals and is intended for the recipient(s) only. It is not directed at retail customers. This message is subject to the terms at: https://www.ib.barclays/disclosures/web-and-email-disclaimer.html. 

For important disclosures, please see: https://www.ib.barclays/disclosures/sales-and-trading-disclaimer.html regarding marketing commentary from Barclays Sales and/or Trading desks, who are active market participants; https://www.ib.barclays/disclosures/barclays-global-markets-disclosures.html regarding our standard terms for Barclays Investment Bank where we trade with you in principal-to-principal wholesale markets transactions; and in respect to Barclays Research, including disclosures relating to specific issuers, see: http://publicresearch.barclays.com.
__________________________________________________________________________________ 
If you are incorporated or operating in Australia, read these important disclosures: https://www.ib.barclays/disclosures/important-disclosures-asia-pacific.html.
__________________________________________________________________________________
For more details about how we use personal information, see our privacy notice: https://www.ib.barclays/disclosures/personal-information-use.html. 
__________________________________________________________________________________
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/client-libs-dev/attachments/20240304/32be7c90/attachment-0001.htm>

From aivanov at openjdk.org  Mon Mar  4 21:26:42 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Mon, 4 Mar 2024 21:26:42 GMT
Subject: RFR: 8325179: Race in BasicDirectoryModel.validateFileCache
In-Reply-To: <nOapec57Ql6DHy57oEeWdkUGER8RYdWc2vwmJsqWDYc=.8de81954-d8c2-4937-b426-e61dde05255e@github.com>
References: <nOapec57Ql6DHy57oEeWdkUGER8RYdWc2vwmJsqWDYc=.8de81954-d8c2-4937-b426-e61dde05255e@github.com>
Message-ID: <sqp_GwYwHGfX68bBuG0cDI9T2KXNTSmJeRb2LpHCgjc=.0f4218f8-491c-48a2-aec9-677feab1134f@github.com>

On Mon, 4 Mar 2024 20:21:30 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> Ensure access to the `filesLoader` field of `BasicDirectoryModel` is synchronized.
> 
> Without synchronization, a thread checks if `filesLoader` is not null and creates a new `FilesLoader` thread. If the thread is pre-empted between these two operations, another thread or even several threads can see the `null` value and create new `FilesLoader` threads.
> 
> The same way, `BasicDirectoryModel.invalidateFileCache` needs to be synchornized to interrupt the current `filesLoader` and assign `null`.
> 
> This bug allows reproducing `ConcurrentModificationException` seen in [JDK-8323670](https://bugs.openjdk.org/browse/JDK-8323670) and [JDK-8307091](https://bugs.openjdk.org/browse/JDK-8307091) using the test in PR #18109.

@mrserb, could you take a look, please?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18111#issuecomment-1977483135

From serb at openjdk.org  Tue Mar  5 00:50:56 2024
From: serb at openjdk.org (Sergey Bylokhov)
Date: Tue, 5 Mar 2024 00:50:56 GMT
Subject: RFR: 8325179: Race in BasicDirectoryModel.validateFileCache
In-Reply-To: <nOapec57Ql6DHy57oEeWdkUGER8RYdWc2vwmJsqWDYc=.8de81954-d8c2-4937-b426-e61dde05255e@github.com>
References: <nOapec57Ql6DHy57oEeWdkUGER8RYdWc2vwmJsqWDYc=.8de81954-d8c2-4937-b426-e61dde05255e@github.com>
Message-ID: <mRgGz4hgCDyP3rkwMuNfdMCmm5YCsIBDtkgwe8TJc_4=.a1ed1fd7-f8fc-44b9-8599-28dd9774a98a@github.com>

On Mon, 4 Mar 2024 20:21:30 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> Ensure access to the `filesLoader` field of `BasicDirectoryModel` is synchronized.
> 
> Without synchronization, a thread checks if `filesLoader` is not null and creates a new `FilesLoader` thread. If the thread is pre-empted between these two operations, another thread or even several threads can see the `null` value and create new `FilesLoader` threads.
> 
> The same way, `BasicDirectoryModel.invalidateFileCache` needs to be synchornized to interrupt the current `filesLoader` and assign `null`.
> 
> This bug allows reproducing `ConcurrentModificationException` seen in [JDK-8323670](https://bugs.openjdk.org/browse/JDK-8323670) and [JDK-8307091](https://bugs.openjdk.org/browse/JDK-8307091) using the test in PR #18109.

src/java.desktop/share/classes/javax/swing/plaf/basic/BasicDirectoryModel.java line 101:

> 99:      */
> 100:     public synchronized void invalidateFileCache() {
> 101:         if (filesLoader != null) {

This is a public API method, can we minimize the change and use "synchronized (this)" instead?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18111#discussion_r1511986238

From serb at openjdk.org  Tue Mar  5 01:01:49 2024
From: serb at openjdk.org (Sergey Bylokhov)
Date: Tue, 5 Mar 2024 01:01:49 GMT
Subject: RFR: 8326661: sun/java2d/cmm/ColorConvertOp/ColConvTest.java
 assumes profiles were generated by LCMS
In-Reply-To: <nFplnFr0UPf-gWrZjoyZhb2pCJ_fjUEieIxTlWesSNs=.7f372d25-5bc5-4fb2-9ecd-8d5e40cc69b8@github.com>
References: <nFplnFr0UPf-gWrZjoyZhb2pCJ_fjUEieIxTlWesSNs=.7f372d25-5bc5-4fb2-9ecd-8d5e40cc69b8@github.com>
Message-ID: <6aO1JMWfnuzwP6QH4GVnI9YW7nW8XygymJvsjVU0ykY=.cbf6f144-4a45-428e-9ae3-eacd67641e94@github.com>

On Sun, 3 Mar 2024 09:01:49 GMT, Dmitry Markov <dmarkov at openjdk.org> wrote:

> Updated several tests to avoid potential failure with recent LCMS update and non-LCMS generated profile.

test/jdk/sun/java2d/cmm/ColorConvertOp/ColConvCCMTest.java line 63:

> 61:         10.5,       // GRAY
> 62:         215.0,      // PYCC
> 63:         56.0        // CIEXYZ

All this change will delete all information about "old and good" values and start to use lcms thresholds for all profiles? I think it should be the opposite - use the good data for all except lcms(or any other not that good as jdk8 profiles), like we do it now.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18097#discussion_r1511992175

From psadhukhan at openjdk.org  Tue Mar  5 02:37:50 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Tue, 5 Mar 2024 02:37:50 GMT
Subject: Integrated: 8327007: javax/swing/JSpinner/8008657/bug8008657.java
 fails
In-Reply-To: <e_F-RYcAjzGOzHQL95zVz5z77cSdPDKpnPzuN3ExsNM=.9615c27e-92d5-4a10-8e34-be66ef6883aa@github.com>
References: <e_F-RYcAjzGOzHQL95zVz5z77cSdPDKpnPzuN3ExsNM=.9615c27e-92d5-4a10-8e34-be66ef6883aa@github.com>
Message-ID: <6UIakAOIpXUXgYmz2IMoN05gqRhFAPDL9Isp9zeUgbY=.87f728ba-6050-46a9-9cb4-d86e4e8b229e@github.com>

On Thu, 29 Feb 2024 09:34:05 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> Test failed with the exception java.lang.IllegalArgumentException: (start <= value <= end) with no history of failing till date.
> Investigation shows SpinnerDateModel constructor condition is not satisfied because
> It seems it's a leap year problem that is being manifested..
> 
> As per test,
> initDate Thu Feb 29 13:49:08 IST 2024 [ obtained by calendar.getTime();]
> earliestDate Tue Feb 28 13:49:08 IST 2023 [obtained by calendar.add(Calendar.YEAR, -1);]
> latestDate Wed Feb 28 13:49:08 IST 2024 [obtained by calendar.add(Calendar.YEAR, 1);]
> 
> Now, as per SpinnerDateModel constructor
> earliestDate <= initDate condition is satisfied
> but
> latestDate >= initDate is not
> so [start <= value <= end](https://github.com/openjdk/jdk/blob/998d0baab0fd051c38d9fd6021628eb863b80554/src/java.desktop/share/classes/javax/swing/SpinnerDateModel.java#L185) condition fails
> 
> Not sure it anything can be done in Calendar class for this but fix is done in test taking leapyear into account so that we add a day if it's a leapyear when we consecutively do Calendar.add(YEAR, -1) and Calendar.add(YEAR,1) on leapyear date of 29Feb

This pull request has now been integrated.

Changeset: b7540df6
Author:    Prasanta Sadhukhan <psadhukhan at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/b7540df6a4279c63e69d32b9d9834f7a427478d1
Stats:     3 lines in 1 file changed: 1 ins; 1 del; 1 mod

8327007: javax/swing/JSpinner/8008657/bug8008657.java fails

Reviewed-by: prr

-------------

PR: https://git.openjdk.org/jdk/pull/18054

From psadhukhan at openjdk.org  Tue Mar  5 03:07:49 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Tue, 5 Mar 2024 03:07:49 GMT
Subject: RFR: 8075917: The regression-swing case failed as the text on
 label is not painted red with the GTK L&F [v4]
In-Reply-To: <Ej-GFWOSzjZzXeFgJ_XRD5amCJEBFnTw3Xwe6R7yWOM=.c9587e9a-7129-4683-8568-c5a56bd4009c@github.com>
References: <iDOTnLkAimOa5kfDerZ09n4wsYiFYYUyBflOTYeUQZ0=.293390bd-bc47-4871-bf4c-d23c191d9426@github.com>
 <Ej-GFWOSzjZzXeFgJ_XRD5amCJEBFnTw3Xwe6R7yWOM=.c9587e9a-7129-4683-8568-c5a56bd4009c@github.com>
Message-ID: <T5MTSpAet1ikyrM5DAnOx4TgJKsNUejl-sOT_PWsVsE=.37d8098b-4a92-4e5f-9565-1f4e99c28e90@github.com>

On Fri, 1 Mar 2024 10:38:21 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> JLabel text is not painted with the LAF defined foreground color in GTK LAF. In GTK LAF the foreground color is retrieved by using native system APIs. Fix is to return the foreground color if it is set by LAF defined property otherwise return the default color by calling native APIs.
>> Applet based test has been converted to automatic test and check for all installed LAFs. CI testing is green for test suite and individual test. Link attached in JBS.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   extended fix for disabled checkbox and radiobutton

src/java.desktop/share/classes/com/sun/java/swing/plaf/gtk/GTKStyle.java line 205:

> 203:             Color c = (Color) get(context, "RadioButton.disabledText");
> 204:             if (c != null) {
> 205:                 return c;

What about the enabled state text? WIll that not required to be handled? 
Can this be done in a separate method passing in the required Java level property?

test/jdk/javax/swing/JRadioButton/4314194/bug4314194.java line 43:

> 41: import javax.swing.UIManager;
> 42: import javax.swing.UnsupportedLookAndFeelException;
> 43: import javax.swing.plaf.nimbus.NimbusLookAndFeel;

this bug id needs to be added in jtreg tag

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17763#discussion_r1512073988
PR Review Comment: https://git.openjdk.org/jdk/pull/17763#discussion_r1512074176

From serb at openjdk.org  Tue Mar  5 03:51:54 2024
From: serb at openjdk.org (Sergey Bylokhov)
Date: Tue, 5 Mar 2024 03:51:54 GMT
Subject: RFR: 8326661: sun/java2d/cmm/ColorConvertOp/ColConvTest.java
 assumes profiles were generated by LCMS
In-Reply-To: <6aO1JMWfnuzwP6QH4GVnI9YW7nW8XygymJvsjVU0ykY=.cbf6f144-4a45-428e-9ae3-eacd67641e94@github.com>
References: <nFplnFr0UPf-gWrZjoyZhb2pCJ_fjUEieIxTlWesSNs=.7f372d25-5bc5-4fb2-9ecd-8d5e40cc69b8@github.com>
 <6aO1JMWfnuzwP6QH4GVnI9YW7nW8XygymJvsjVU0ykY=.cbf6f144-4a45-428e-9ae3-eacd67641e94@github.com>
Message-ID: <PuQ3oGFIK3A35zfbSDtT3tRfzVmYyqjxgokbG7jfqSY=.d1d26d54-b9d5-4e82-9c8f-769a965a2d44@github.com>

On Tue, 5 Mar 2024 00:58:42 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>> Updated several tests to avoid potential failure with recent LCMS update and non-LCMS generated profile.
>
> test/jdk/sun/java2d/cmm/ColorConvertOp/ColConvCCMTest.java line 63:
> 
>> 61:         10.5,       // GRAY
>> 62:         215.0,      // PYCC
>> 63:         56.0        // CIEXYZ
> 
> All this change will delete all information about "old and good" values and start to use lcms thresholds for all profiles? I think it should be the opposite - use the good data for all except lcms(or any other not that good as jdk8 profiles), like we do it now.

Actually the purpose of these particular tests is validation of the quality of the built-in color profiles.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18097#discussion_r1512099541

From abhiscxk at openjdk.org  Tue Mar  5 04:46:48 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Tue, 5 Mar 2024 04:46:48 GMT
Subject: RFR: 8075917: The regression-swing case failed as the text on
 label is not painted red with the GTK L&F [v4]
In-Reply-To: <T5MTSpAet1ikyrM5DAnOx4TgJKsNUejl-sOT_PWsVsE=.37d8098b-4a92-4e5f-9565-1f4e99c28e90@github.com>
References: <iDOTnLkAimOa5kfDerZ09n4wsYiFYYUyBflOTYeUQZ0=.293390bd-bc47-4871-bf4c-d23c191d9426@github.com>
 <Ej-GFWOSzjZzXeFgJ_XRD5amCJEBFnTw3Xwe6R7yWOM=.c9587e9a-7129-4683-8568-c5a56bd4009c@github.com>
 <T5MTSpAet1ikyrM5DAnOx4TgJKsNUejl-sOT_PWsVsE=.37d8098b-4a92-4e5f-9565-1f4e99c28e90@github.com>
Message-ID: <Obru-IzvCPdNgl-GeymsGMRLK8h1AqOQ0sM-UB2Zs5Q=.1ccc468f-0c9e-4c62-93ac-7d88d6ab9d6a@github.com>

On Tue, 5 Mar 2024 03:04:43 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> What about the enabled state text? WIll that not required to be handled?

If the component is in enabled state and color is set by the user then it needs to handle as well. Since the bug reported was for disabled state, didn't add for enabled as of now.

> Can this be done in a separate method passing in the required Java level property?

Yeah sure. Will check and update.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17763#discussion_r1512125998

From abhiscxk at openjdk.org  Tue Mar  5 05:28:01 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Tue, 5 Mar 2024 05:28:01 GMT
Subject: RFR: 8075917: The regression-swing case failed as the text on
 label is not painted red with the GTK L&F [v5]
In-Reply-To: <iDOTnLkAimOa5kfDerZ09n4wsYiFYYUyBflOTYeUQZ0=.293390bd-bc47-4871-bf4c-d23c191d9426@github.com>
References: <iDOTnLkAimOa5kfDerZ09n4wsYiFYYUyBflOTYeUQZ0=.293390bd-bc47-4871-bf4c-d23c191d9426@github.com>
Message-ID: <5eZ7a0HiqE3hghw3sT0L0Zn4Mi1FFfofz6hLGdLOsoc=.445b16ac-4d91-4538-92ba-a74f17781535@github.com>

> JLabel text is not painted with the LAF defined foreground color in GTK LAF. In GTK LAF the foreground color is retrieved by using native system APIs. Fix is to return the foreground color if it is set by LAF defined property otherwise return the default color by calling native APIs.
> Applet based test has been converted to automatic test and check for all installed LAFs. CI testing is green for test suite and individual test. Link attached in JBS.

Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:

  separate method to get LAF defined color

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/17763/files
  - new: https://git.openjdk.org/jdk/pull/17763/files/2ccca3f3..360e21e8

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=17763&range=04
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17763&range=03-04

  Stats: 22 lines in 2 files changed: 9 ins; 9 del; 4 mod
  Patch: https://git.openjdk.org/jdk/pull/17763.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17763/head:pull/17763

PR: https://git.openjdk.org/jdk/pull/17763

From abhiscxk at openjdk.org  Tue Mar  5 06:08:00 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Tue, 5 Mar 2024 06:08:00 GMT
Subject: RFR: 8326458: Menu mnemonics don't toggle in Windows LAF when F10
 is pressed [v6]
In-Reply-To: <uv53ohrzj-j8wA3SHr7M0b5V-Ja9HvKGBa2RgWTwoSU=.abf8c336-4b24-479c-af6d-22acb686ed80@github.com>
References: <uv53ohrzj-j8wA3SHr7M0b5V-Ja9HvKGBa2RgWTwoSU=.abf8c336-4b24-479c-af6d-22acb686ed80@github.com>
Message-ID: <8u2GCTfCYV7k8cpsayj-zYwBOlYxOwyEzrs_NYKPnPI=.fcc890c2-7bfa-47b5-b6ff-4f451dc9c2db@github.com>

> Menu mnemonic doesn't toggle between show and hide state when F10 is pressed. Behavior is not similar to windows native application. Fix is to ensure that menu mnemonic state toggles between show and hide.
> 
> Can be verified with SwingSet2 application. 
> CI tests are green with the fix. Link posted in JBS.

Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:

  Review comment update

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/17961/files
  - new: https://git.openjdk.org/jdk/pull/17961/files/ec7b1a04..e520b8f0

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=17961&range=05
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17961&range=04-05

  Stats: 55 lines in 2 files changed: 26 ins; 22 del; 7 mod
  Patch: https://git.openjdk.org/jdk/pull/17961.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17961/head:pull/17961

PR: https://git.openjdk.org/jdk/pull/17961

From abhiscxk at openjdk.org  Tue Mar  5 06:57:47 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Tue, 5 Mar 2024 06:57:47 GMT
Subject: RFR: 8075917: The regression-swing case failed as the text on
 label is not painted red with the GTK L&F [v4]
In-Reply-To: <T5MTSpAet1ikyrM5DAnOx4TgJKsNUejl-sOT_PWsVsE=.37d8098b-4a92-4e5f-9565-1f4e99c28e90@github.com>
References: <iDOTnLkAimOa5kfDerZ09n4wsYiFYYUyBflOTYeUQZ0=.293390bd-bc47-4871-bf4c-d23c191d9426@github.com>
 <Ej-GFWOSzjZzXeFgJ_XRD5amCJEBFnTw3Xwe6R7yWOM=.c9587e9a-7129-4683-8568-c5a56bd4009c@github.com>
 <T5MTSpAet1ikyrM5DAnOx4TgJKsNUejl-sOT_PWsVsE=.37d8098b-4a92-4e5f-9565-1f4e99c28e90@github.com>
Message-ID: <eW8pYBn8iitTdrnaBgrNk65u-GBxMr9wH6eVROIhk3Q=.497aede5-ce6f-49a2-9a0e-95e5be3e9e66@github.com>

On Tue, 5 Mar 2024 03:05:04 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   extended fix for disabled checkbox and radiobutton
>
> test/jdk/javax/swing/JRadioButton/4314194/bug4314194.java line 43:
> 
>> 41: import javax.swing.UIManager;
>> 42: import javax.swing.UnsupportedLookAndFeelException;
>> 43: import javax.swing.plaf.nimbus.NimbusLookAndFeel;
> 
> this bug id needs to be added in jtreg tag

Updated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17763#discussion_r1512214682

From psadhukhan at openjdk.org  Tue Mar  5 08:23:50 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Tue, 5 Mar 2024 08:23:50 GMT
Subject: RFR: 8075917: The regression-swing case failed as the text on
 label is not painted red with the GTK L&F [v5]
In-Reply-To: <5eZ7a0HiqE3hghw3sT0L0Zn4Mi1FFfofz6hLGdLOsoc=.445b16ac-4d91-4538-92ba-a74f17781535@github.com>
References: <iDOTnLkAimOa5kfDerZ09n4wsYiFYYUyBflOTYeUQZ0=.293390bd-bc47-4871-bf4c-d23c191d9426@github.com>
 <5eZ7a0HiqE3hghw3sT0L0Zn4Mi1FFfofz6hLGdLOsoc=.445b16ac-4d91-4538-92ba-a74f17781535@github.com>
Message-ID: <dPwYzsPLI8z4TUTMlwXFEKmddbkkjpifAqrM4b2XxeE=.ec943a1a-09b4-48ec-8ad1-bd64b936e2b2@github.com>

On Tue, 5 Mar 2024 05:28:01 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> JLabel text is not painted with the LAF defined foreground color in GTK LAF. In GTK LAF the foreground color is retrieved by using native system APIs. Fix is to return the foreground color if it is set by LAF defined property otherwise return the default color by calling native APIs.
>> Applet based test has been converted to automatic test and check for all installed LAFs. CI testing is green for test suite and individual test. Link attached in JBS.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   separate method to get LAF defined color

Changes requested by psadhukhan (Reviewer).

src/java.desktop/share/classes/com/sun/java/swing/plaf/gtk/GTKStyle.java line 205:

> 203:     private Color getLAFDefinedColor(SynthContext context, int state,
> 204:                                      ColorType type, String propertyName) {
> 205:         Color c = (Color) get(context, propertyName);

I guess these condition checks should also be done inside the method since you are passing the values anyway...
Also, the enabled state are still not handled..If the existing testcase does not catch those, maybe we can add subtests to it..

test/jdk/javax/swing/plaf/basic/BasicHTML/bug4248210.java line 40:

> 38: /*
> 39:  * @test
> 40:  * @bug 4248210 8075917 4314194

4314194 remove from here..

-------------

PR Review: https://git.openjdk.org/jdk/pull/17763#pullrequestreview-1916196212
PR Review Comment: https://git.openjdk.org/jdk/pull/17763#discussion_r1512316161
PR Review Comment: https://git.openjdk.org/jdk/pull/17763#discussion_r1512318090

From psadhukhan at openjdk.org  Tue Mar  5 08:23:51 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Tue, 5 Mar 2024 08:23:51 GMT
Subject: RFR: 8075917: The regression-swing case failed as the text on
 label is not painted red with the GTK L&F [v4]
In-Reply-To: <eW8pYBn8iitTdrnaBgrNk65u-GBxMr9wH6eVROIhk3Q=.497aede5-ce6f-49a2-9a0e-95e5be3e9e66@github.com>
References: <iDOTnLkAimOa5kfDerZ09n4wsYiFYYUyBflOTYeUQZ0=.293390bd-bc47-4871-bf4c-d23c191d9426@github.com>
 <Ej-GFWOSzjZzXeFgJ_XRD5amCJEBFnTw3Xwe6R7yWOM=.c9587e9a-7129-4683-8568-c5a56bd4009c@github.com>
 <T5MTSpAet1ikyrM5DAnOx4TgJKsNUejl-sOT_PWsVsE=.37d8098b-4a92-4e5f-9565-1f4e99c28e90@github.com>
 <eW8pYBn8iitTdrnaBgrNk65u-GBxMr9wH6eVROIhk3Q=.497aede5-ce6f-49a2-9a0e-95e5be3e9e66@github.com>
Message-ID: <_M2jCEbqWHcpKJqX9MNwi915VyOAMngJbQApHcWM-1g=.17320eab-5372-420a-bbaf-3efafae878fe@github.com>

On Tue, 5 Mar 2024 06:54:40 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> test/jdk/javax/swing/JRadioButton/4314194/bug4314194.java line 43:
>> 
>>> 41: import javax.swing.UIManager;
>>> 42: import javax.swing.UnsupportedLookAndFeelException;
>>> 43: import javax.swing.plaf.nimbus.NimbusLookAndFeel;
>> 
>> this bug id needs to be added in jtreg tag
>
> Updated.

No, it's need to be updated in this test 8075917

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17763#discussion_r1512316071

From mkartashev at openjdk.org  Tue Mar  5 08:55:05 2024
From: mkartashev at openjdk.org (Maxim Kartashev)
Date: Tue, 5 Mar 2024 08:55:05 GMT
Subject: RFR: 8326497: Window.toFront() fails for iconified windows on
 Linux [v4]
In-Reply-To: <XmMRoFNpTDQHCZLnmmnNGVjhR2Ib3yw1kWc0v57utUM=.e418325c-7b23-4298-8f75-e81d369b5afc@github.com>
References: <XmMRoFNpTDQHCZLnmmnNGVjhR2Ib3yw1kWc0v57utUM=.e418325c-7b23-4298-8f75-e81d369b5afc@github.com>
Message-ID: <JJQy28NlyHF6Wo7jaj2crSWhxehnfskWL7Z8USY--Zk=.70da9fb4-f201-49be-9298-24674759fb70@github.com>

> XToolkit implements `toFront()` essentially by sending the  `_NET_ACTIVE_WINDOW` message to activate the window. This has no effect when the target window is in the iconified state. So the fix is to cancel that state prior to sending the message.
> 
> The test verifies that the fix works for maximized and undecorated frames as well out of abundance of caution; they do not represent a special case from the `toFront()` standpoint.
> 
> References
> * `_NET_ACTIVE_WINDOW`: https://specifications.freedesktop.org/wm-spec/1.3/ar01s03.html
> * [Inter-Client Communication Conventions Manual, 4.1.4. Changing Window State](https://tronche.com/gui/x/icccm/sec-4.html#s-4.1.4)

Maxim Kartashev has updated the pull request incrementally with one additional commit since the last revision:

  Fixed for Windows also
  
  And made the test not dependent on swing.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/17985/files
  - new: https://git.openjdk.org/jdk/pull/17985/files/35cef969..11060c71

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=17985&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17985&range=02-03

  Stats: 35 lines in 3 files changed: 21 ins; 0 del; 14 mod
  Patch: https://git.openjdk.org/jdk/pull/17985.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17985/head:pull/17985

PR: https://git.openjdk.org/jdk/pull/17985

From aturbanov at openjdk.org  Tue Mar  5 09:24:45 2024
From: aturbanov at openjdk.org (Andrey Turbanov)
Date: Tue, 5 Mar 2024 09:24:45 GMT
Subject: RFR: 8325179: Race in BasicDirectoryModel.validateFileCache
In-Reply-To: <nOapec57Ql6DHy57oEeWdkUGER8RYdWc2vwmJsqWDYc=.8de81954-d8c2-4937-b426-e61dde05255e@github.com>
References: <nOapec57Ql6DHy57oEeWdkUGER8RYdWc2vwmJsqWDYc=.8de81954-d8c2-4937-b426-e61dde05255e@github.com>
Message-ID: <tHMoFqniFtbM5UJGCo16DuLeXqgq3xC3DPY6bZfq8R0=.7a3f2041-44a6-449e-a7c5-ec0140d5599d@github.com>

On Mon, 4 Mar 2024 20:21:30 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> Ensure access to the `filesLoader` field of `BasicDirectoryModel` is synchronized.
> 
> Without synchronization, a thread checks if `filesLoader` is not null and creates a new `FilesLoader` thread. If the thread is pre-empted between these two operations, another thread or even several threads can see the `null` value and create new `FilesLoader` threads.
> 
> The same way, `BasicDirectoryModel.invalidateFileCache` needs to be synchornized to interrupt the current `filesLoader` and assign `null`.
> 
> This bug allows reproducing `ConcurrentModificationException` seen in [JDK-8323670](https://bugs.openjdk.org/browse/JDK-8323670) and [JDK-8307091](https://bugs.openjdk.org/browse/JDK-8307091) using the test in PR #18109.

src/java.desktop/share/classes/javax/swing/plaf/basic/BasicDirectoryModel.java line 539:

> 537:             int remSize = (remFiles == null) ? 0 : remFiles.size();
> 538:             int addSize = (addFiles == null) ? 0 : addFiles.size();
> 539:             synchronized(fileCache) {

Suggestion:

            synchronized (fileCache) {

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18111#discussion_r1512452216

From mkartashev at openjdk.org  Tue Mar  5 09:26:46 2024
From: mkartashev at openjdk.org (Maxim Kartashev)
Date: Tue, 5 Mar 2024 09:26:46 GMT
Subject: RFR: 8326497: Window.toFront() fails for iconified windows on
 Linux
In-Reply-To: <l3mxqAviT6e_UnVafBEI9QfvL-Ht2h-s6QS97SHZJXw=.e0a29c32-1329-4b50-a394-7b97cdf9e281@github.com>
References: <XmMRoFNpTDQHCZLnmmnNGVjhR2Ib3yw1kWc0v57utUM=.e418325c-7b23-4298-8f75-e81d369b5afc@github.com>
 <l3mxqAviT6e_UnVafBEI9QfvL-Ht2h-s6QS97SHZJXw=.e0a29c32-1329-4b50-a394-7b97cdf9e281@github.com>
Message-ID: <0iMlKhF6SPkJPnPpnk6vQbXhxjuImgDoc3VdH_NMvK0=.d6498650-b51c-4839-b48d-30c31ae48533@github.com>

On Fri, 23 Feb 2024 21:51:30 GMT, Phil Race <prr at openjdk.org> wrote:

>> XToolkit implements `toFront()` essentially by sending the  `_NET_ACTIVE_WINDOW` message to activate the window. This has no effect when the target window is in the iconified state. So the fix is to cancel that state prior to sending the message.
>> 
>> The test verifies that the fix works for maximized and undecorated frames as well out of abundance of caution; they do not represent a special case from the `toFront()` standpoint.
>> 
>> References
>> * `_NET_ACTIVE_WINDOW`: https://specifications.freedesktop.org/wm-spec/1.3/ar01s03.html
>> * [Inter-Client Communication Conventions Manual, 4.1.4. Changing Window State](https://tronche.com/gui/x/icccm/sec-4.html#s-4.1.4)
>
> Looks reasonable to me. I'm a bit surprised this hasn't come up before.
> 
> On Mac I see that we already do this properly, I presume this is also the case on Windows, so the test will pass on all platforms ?
> 
> I think we should submit a test job ...

@prrace The fix was extended to Windows as well. MacOS works as it is except that the test needed some tweaking to allow for slower iconify/de-iconify effects.

Please, have a look at the updated version.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17985#issuecomment-1978306651

From aturbanov at openjdk.org  Tue Mar  5 09:27:47 2024
From: aturbanov at openjdk.org (Andrey Turbanov)
Date: Tue, 5 Mar 2024 09:27:47 GMT
Subject: RFR: 8325179: Race in BasicDirectoryModel.validateFileCache
In-Reply-To: <nOapec57Ql6DHy57oEeWdkUGER8RYdWc2vwmJsqWDYc=.8de81954-d8c2-4937-b426-e61dde05255e@github.com>
References: <nOapec57Ql6DHy57oEeWdkUGER8RYdWc2vwmJsqWDYc=.8de81954-d8c2-4937-b426-e61dde05255e@github.com>
Message-ID: <QYenoZmWe-JSTMeM40IUu5ePxB_qtfYgLetH2u_skpE=.0c441729-2fc4-41dd-a427-44d9fdb7c9e4@github.com>

On Mon, 4 Mar 2024 20:21:30 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> Ensure access to the `filesLoader` field of `BasicDirectoryModel` is synchronized.
> 
> Without synchronization, a thread checks if `filesLoader` is not null and creates a new `FilesLoader` thread. If the thread is pre-empted between these two operations, another thread or even several threads can see the `null` value and create new `FilesLoader` threads.
> 
> The same way, `BasicDirectoryModel.invalidateFileCache` needs to be synchornized to interrupt the current `filesLoader` and assign `null`.
> 
> This bug allows reproducing `ConcurrentModificationException` seen in [JDK-8323670](https://bugs.openjdk.org/browse/JDK-8323670) and [JDK-8307091](https://bugs.openjdk.org/browse/JDK-8307091) using the test in PR #18109.

src/java.desktop/share/classes/javax/swing/plaf/basic/BasicDirectoryModel.java line 281:

> 279:         private final Thread loadThread;
> 280: 
> 281:         private DoChangeContents runnable;

Can be converted to local variable now

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18111#discussion_r1512458776

From tr at openjdk.org  Tue Mar  5 09:33:45 2024
From: tr at openjdk.org (Tejesh R)
Date: Tue, 5 Mar 2024 09:33:45 GMT
Subject: RFR: 8326497: Window.toFront() fails for iconified windows on
 Linux [v4]
In-Reply-To: <JJQy28NlyHF6Wo7jaj2crSWhxehnfskWL7Z8USY--Zk=.70da9fb4-f201-49be-9298-24674759fb70@github.com>
References: <XmMRoFNpTDQHCZLnmmnNGVjhR2Ib3yw1kWc0v57utUM=.e418325c-7b23-4298-8f75-e81d369b5afc@github.com>
 <JJQy28NlyHF6Wo7jaj2crSWhxehnfskWL7Z8USY--Zk=.70da9fb4-f201-49be-9298-24674759fb70@github.com>
Message-ID: <LZ0V6I_Sj7P30XNZNX2NeGp8-lKWKhFcMlHOPJTI85o=.5f5b9d91-78e0-4c4e-816d-9787e5e1e449@github.com>

On Tue, 5 Mar 2024 08:55:05 GMT, Maxim Kartashev <mkartashev at openjdk.org> wrote:

>> XToolkit implements `toFront()` essentially by sending the  `_NET_ACTIVE_WINDOW` message to activate the window. This has no effect when the target window is in the iconified state. So the fix is to cancel that state prior to sending the message.
>> 
>> The test verifies that the fix works for maximized and undecorated frames as well out of abundance of caution; they do not represent a special case from the `toFront()` standpoint.
>> 
>> References
>> * `_NET_ACTIVE_WINDOW`: https://specifications.freedesktop.org/wm-spec/1.3/ar01s03.html
>> * [Inter-Client Communication Conventions Manual, 4.1.4. Changing Window State](https://tronche.com/gui/x/icccm/sec-4.html#s-4.1.4)
>
> Maxim Kartashev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fixed for Windows also
>   
>   And made the test not dependent on swing.

test/jdk/java/awt/Frame/Iconify/IconifiedToFront.java line 100:

> 98: 
> 99:     private static void pause() {
> 100:         robot.delay(PAUSE_MS);

Adding `robot.waitForIdle(); ` after delay would be better.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17985#discussion_r1512475560

From mkartashev at openjdk.org  Tue Mar  5 10:16:58 2024
From: mkartashev at openjdk.org (Maxim Kartashev)
Date: Tue, 5 Mar 2024 10:16:58 GMT
Subject: RFR: 8326497: Window.toFront() fails for iconified windows on
 Linux [v5]
In-Reply-To: <XmMRoFNpTDQHCZLnmmnNGVjhR2Ib3yw1kWc0v57utUM=.e418325c-7b23-4298-8f75-e81d369b5afc@github.com>
References: <XmMRoFNpTDQHCZLnmmnNGVjhR2Ib3yw1kWc0v57utUM=.e418325c-7b23-4298-8f75-e81d369b5afc@github.com>
Message-ID: <4ZzIgJ3GvtcPQdKqBZ5J49WcKrfNgUjxff02pRSd7fI=.f2e73f77-4aac-4c29-8831-04aaf9d81d23@github.com>

> XToolkit implements `toFront()` essentially by sending the  `_NET_ACTIVE_WINDOW` message to activate the window. This has no effect when the target window is in the iconified state. So the fix is to cancel that state prior to sending the message.
> 
> The test verifies that the fix works for maximized and undecorated frames as well out of abundance of caution; they do not represent a special case from the `toFront()` standpoint.
> 
> References
> * `_NET_ACTIVE_WINDOW`: https://specifications.freedesktop.org/wm-spec/1.3/ar01s03.html
> * [Inter-Client Communication Conventions Manual, 4.1.4. Changing Window State](https://tronche.com/gui/x/icccm/sec-4.html#s-4.1.4)

Maxim Kartashev has updated the pull request incrementally with one additional commit since the last revision:

  Made the test to waitForIdle()

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/17985/files
  - new: https://git.openjdk.org/jdk/pull/17985/files/11060c71..d7d134ee

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=17985&range=04
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17985&range=03-04

  Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/17985.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17985/head:pull/17985

PR: https://git.openjdk.org/jdk/pull/17985

From mkartashev at openjdk.org  Tue Mar  5 10:16:59 2024
From: mkartashev at openjdk.org (Maxim Kartashev)
Date: Tue, 5 Mar 2024 10:16:59 GMT
Subject: RFR: 8326497: Window.toFront() fails for iconified windows on
 Linux [v4]
In-Reply-To: <LZ0V6I_Sj7P30XNZNX2NeGp8-lKWKhFcMlHOPJTI85o=.5f5b9d91-78e0-4c4e-816d-9787e5e1e449@github.com>
References: <XmMRoFNpTDQHCZLnmmnNGVjhR2Ib3yw1kWc0v57utUM=.e418325c-7b23-4298-8f75-e81d369b5afc@github.com>
 <JJQy28NlyHF6Wo7jaj2crSWhxehnfskWL7Z8USY--Zk=.70da9fb4-f201-49be-9298-24674759fb70@github.com>
 <LZ0V6I_Sj7P30XNZNX2NeGp8-lKWKhFcMlHOPJTI85o=.5f5b9d91-78e0-4c4e-816d-9787e5e1e449@github.com>
Message-ID: <ar2OpKFtMwTJjFr71u8nThWRXr3B7ABe2Ad-9xjsP7c=.a482ea61-4ac5-403c-9b01-f74f97cb4771@github.com>

On Tue, 5 Mar 2024 09:31:25 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Maxim Kartashev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fixed for Windows also
>>   
>>   And made the test not dependent on swing.
>
> test/jdk/java/awt/Frame/Iconify/IconifiedToFront.java line 100:
> 
>> 98: 
>> 99:     private static void pause() {
>> 100:         robot.delay(PAUSE_MS);
> 
> Adding `robot.waitForIdle(); ` after delay would be better.

Agreed; done.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17985#discussion_r1512569922

From tr at openjdk.org  Tue Mar  5 10:47:46 2024
From: tr at openjdk.org (Tejesh R)
Date: Tue, 5 Mar 2024 10:47:46 GMT
Subject: RFR: 8326497: Window.toFront() fails for iconified windows on
 Linux [v5]
In-Reply-To: <4ZzIgJ3GvtcPQdKqBZ5J49WcKrfNgUjxff02pRSd7fI=.f2e73f77-4aac-4c29-8831-04aaf9d81d23@github.com>
References: <XmMRoFNpTDQHCZLnmmnNGVjhR2Ib3yw1kWc0v57utUM=.e418325c-7b23-4298-8f75-e81d369b5afc@github.com>
 <4ZzIgJ3GvtcPQdKqBZ5J49WcKrfNgUjxff02pRSd7fI=.f2e73f77-4aac-4c29-8831-04aaf9d81d23@github.com>
Message-ID: <Xnvtw_SABWMR-okt1ZOb5NkmKWkkNg6-Tnu1yp6yQkg=.962fcdee-7f9f-49fe-ac96-cfbfbc49cc0c@github.com>

On Tue, 5 Mar 2024 10:16:58 GMT, Maxim Kartashev <mkartashev at openjdk.org> wrote:

>> XToolkit implements `toFront()` essentially by sending the  `_NET_ACTIVE_WINDOW` message to activate the window. This has no effect when the target window is in the iconified state. So the fix is to cancel that state prior to sending the message.
>> 
>> The test verifies that the fix works for maximized and undecorated frames as well out of abundance of caution; they do not represent a special case from the `toFront()` standpoint.
>> 
>> References
>> * `_NET_ACTIVE_WINDOW`: https://specifications.freedesktop.org/wm-spec/1.3/ar01s03.html
>> * [Inter-Client Communication Conventions Manual, 4.1.4. Changing Window State](https://tronche.com/gui/x/icccm/sec-4.html#s-4.1.4)
>
> Maxim Kartashev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Made the test to waitForIdle()

test/jdk/java/awt/Frame/Iconify/IconifiedToFront.java line 41:

> 39: 
> 40: public class IconifiedToFront {
> 41:     private static final int PAUSE_MS = 1500;

1.5 sec is minimum delay, can we reduced it ?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17985#discussion_r1512612075

From aivanov at openjdk.org  Tue Mar  5 11:07:13 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 5 Mar 2024 11:07:13 GMT
Subject: RFR: 8325179: Race in BasicDirectoryModel.validateFileCache [v2]
In-Reply-To: <nOapec57Ql6DHy57oEeWdkUGER8RYdWc2vwmJsqWDYc=.8de81954-d8c2-4937-b426-e61dde05255e@github.com>
References: <nOapec57Ql6DHy57oEeWdkUGER8RYdWc2vwmJsqWDYc=.8de81954-d8c2-4937-b426-e61dde05255e@github.com>
Message-ID: <Wu1AtT0-dY5r8SVpBBJXsX5n4FpEqyMQ7TiY96UvzW8=.dfc34dc8-33c1-4917-96eb-f7ef9e2528db@github.com>

> Ensure access to the `filesLoader` field of `BasicDirectoryModel` is synchronized.
> 
> Without synchronization, a thread checks if `filesLoader` is not null and creates a new `FilesLoader` thread. If the thread is pre-empted between these two operations, another thread or even several threads can see the `null` value and create new `FilesLoader` threads.
> 
> The same way, `BasicDirectoryModel.invalidateFileCache` needs to be synchornized to interrupt the current `filesLoader` and assign `null`.
> 
> This bug allows reproducing `ConcurrentModificationException` seen in [JDK-8323670](https://bugs.openjdk.org/browse/JDK-8323670) and [JDK-8307091](https://bugs.openjdk.org/browse/JDK-8307091) using the test in PR #18109.

Alexey Ivanov has updated the pull request incrementally with four additional commits since the last revision:

 - Replace synchronized invalidateFileCache with synchronized block inside
 - Declare DoChangeContents constructor private, wrap its parameters
 - Space after synchronized in DoChangeContents.run
 - Convert runnable to local variable

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18111/files
  - new: https://git.openjdk.org/jdk/pull/18111/files/4215925b..a0659236

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18111&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18111&range=00-01

  Stats: 13 lines in 1 file changed: 3 ins; 2 del; 8 mod
  Patch: https://git.openjdk.org/jdk/pull/18111.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18111/head:pull/18111

PR: https://git.openjdk.org/jdk/pull/18111

From aivanov at openjdk.org  Tue Mar  5 11:07:14 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 5 Mar 2024 11:07:14 GMT
Subject: RFR: 8325179: Race in BasicDirectoryModel.validateFileCache [v2]
In-Reply-To: <mRgGz4hgCDyP3rkwMuNfdMCmm5YCsIBDtkgwe8TJc_4=.a1ed1fd7-f8fc-44b9-8599-28dd9774a98a@github.com>
References: <nOapec57Ql6DHy57oEeWdkUGER8RYdWc2vwmJsqWDYc=.8de81954-d8c2-4937-b426-e61dde05255e@github.com>
 <mRgGz4hgCDyP3rkwMuNfdMCmm5YCsIBDtkgwe8TJc_4=.a1ed1fd7-f8fc-44b9-8599-28dd9774a98a@github.com>
Message-ID: <y7op4cIxEXuSfLzVymc5kyX7omx7Q4EWluVgyubRqxU=.35b2365e-338d-40f2-9f36-58ad49398892@github.com>

On Tue, 5 Mar 2024 00:48:13 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>> Alexey Ivanov has updated the pull request incrementally with four additional commits since the last revision:
>> 
>>  - Replace synchronized invalidateFileCache with synchronized block inside
>>  - Declare DoChangeContents constructor private, wrap its parameters
>>  - Space after synchronized in DoChangeContents.run
>>  - Convert runnable to local variable
>
> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicDirectoryModel.java line 101:
> 
>> 99:      */
>> 100:     public synchronized void invalidateFileCache() {
>> 101:         if (filesLoader != null) {
> 
> This is a public API method, can we minimize the change and use "synchronized (this)" instead?

The `synchronized` modifier is not part of public API specification, it's not shown in the generated Javadoc. Anyway, I updated the code to use `synchronized (this)` block inside the method.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18111#discussion_r1512638838

From aivanov at openjdk.org  Tue Mar  5 11:07:14 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 5 Mar 2024 11:07:14 GMT
Subject: RFR: 8325179: Race in BasicDirectoryModel.validateFileCache [v2]
In-Reply-To: <QYenoZmWe-JSTMeM40IUu5ePxB_qtfYgLetH2u_skpE=.0c441729-2fc4-41dd-a427-44d9fdb7c9e4@github.com>
References: <nOapec57Ql6DHy57oEeWdkUGER8RYdWc2vwmJsqWDYc=.8de81954-d8c2-4937-b426-e61dde05255e@github.com>
 <QYenoZmWe-JSTMeM40IUu5ePxB_qtfYgLetH2u_skpE=.0c441729-2fc4-41dd-a427-44d9fdb7c9e4@github.com>
Message-ID: <wqeVwgZvcgMyelhnkGhE5pWRUp0Husd4ZBnq-T2fDk4=.d27ccfcb-d878-4955-83a9-c21114f80b59@github.com>

On Tue, 5 Mar 2024 09:24:52 GMT, Andrey Turbanov <aturbanov at openjdk.org> wrote:

>> Alexey Ivanov has updated the pull request incrementally with four additional commits since the last revision:
>> 
>>  - Replace synchronized invalidateFileCache with synchronized block inside
>>  - Declare DoChangeContents constructor private, wrap its parameters
>>  - Space after synchronized in DoChangeContents.run
>>  - Convert runnable to local variable
>
> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicDirectoryModel.java line 281:
> 
>> 279:         private final Thread loadThread;
>> 280: 
>> 281:         private DoChangeContents runnable;
> 
> Can be converted to local variable now

You're right. I didn't notice it.

> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicDirectoryModel.java line 539:
> 
>> 537:             int remSize = (remFiles == null) ? 0 : remFiles.size();
>> 538:             int addSize = (addFiles == null) ? 0 : addFiles.size();
>> 539:             synchronized(fileCache) {
> 
> Suggestion:
> 
>             synchronized (fileCache) {

I didn't modify this code. I went ahead and updated it so that it's consistent in the class.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18111#discussion_r1512635413
PR Review Comment: https://git.openjdk.org/jdk/pull/18111#discussion_r1512636642

From abhiscxk at openjdk.org  Tue Mar  5 11:08:51 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Tue, 5 Mar 2024 11:08:51 GMT
Subject: RFR: 8075917: The regression-swing case failed as the text on
 label is not painted red with the GTK L&F [v5]
In-Reply-To: <dPwYzsPLI8z4TUTMlwXFEKmddbkkjpifAqrM4b2XxeE=.ec943a1a-09b4-48ec-8ad1-bd64b936e2b2@github.com>
References: <iDOTnLkAimOa5kfDerZ09n4wsYiFYYUyBflOTYeUQZ0=.293390bd-bc47-4871-bf4c-d23c191d9426@github.com>
 <5eZ7a0HiqE3hghw3sT0L0Zn4Mi1FFfofz6hLGdLOsoc=.445b16ac-4d91-4538-92ba-a74f17781535@github.com>
 <dPwYzsPLI8z4TUTMlwXFEKmddbkkjpifAqrM4b2XxeE=.ec943a1a-09b4-48ec-8ad1-bd64b936e2b2@github.com>
Message-ID: <yQTL_So5Ud-76evgwEePTvcDSxYXVy0kwN6j_mQwrc0=.12bb609a-b841-480c-9e35-4297f0de6c48@github.com>

On Tue, 5 Mar 2024 08:18:38 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> Also, the enabled state are still not handled

The enabled state is not handled in Metal LAF also, tried adding the enabledText property by setting ui property --
`UIManager.getDefaults().put("CheckBox.enabledText", checkboxColor);`

but the checkbox/radiobutton is painted with default black color.
Should we handle the change in metal LAF as well?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17763#discussion_r1512641363

From aivanov at openjdk.org  Tue Mar  5 11:29:47 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 5 Mar 2024 11:29:47 GMT
Subject: RFR: 8325179: Race in BasicDirectoryModel.validateFileCache [v2]
In-Reply-To: <Wu1AtT0-dY5r8SVpBBJXsX5n4FpEqyMQ7TiY96UvzW8=.dfc34dc8-33c1-4917-96eb-f7ef9e2528db@github.com>
References: <nOapec57Ql6DHy57oEeWdkUGER8RYdWc2vwmJsqWDYc=.8de81954-d8c2-4937-b426-e61dde05255e@github.com>
 <Wu1AtT0-dY5r8SVpBBJXsX5n4FpEqyMQ7TiY96UvzW8=.dfc34dc8-33c1-4917-96eb-f7ef9e2528db@github.com>
Message-ID: <OR8BhVez7FTqow6DkZYNQhoN0ni8yNUdSJUBunHhG5o=.674b44b9-3920-44a5-bf92-46fccc8e50a5@github.com>

On Tue, 5 Mar 2024 11:07:13 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Ensure access to the `filesLoader` field of `BasicDirectoryModel` is synchronized.
>> 
>> Without synchronization, a thread checks if `filesLoader` is not null and creates a new `FilesLoader` thread. If the thread is pre-empted between these two operations, another thread or even several threads can see the `null` value and create new `FilesLoader` threads.
>> 
>> The same way, `BasicDirectoryModel.invalidateFileCache` needs to be synchornized to interrupt the current `filesLoader` and assign `null`.
>> 
>> This bug allows reproducing `ConcurrentModificationException` seen in [JDK-8323670](https://bugs.openjdk.org/browse/JDK-8323670) and [JDK-8307091](https://bugs.openjdk.org/browse/JDK-8307091) using the test in PR #18109.
>
> Alexey Ivanov has updated the pull request incrementally with four additional commits since the last revision:
> 
>  - Replace synchronized invalidateFileCache with synchronized block inside
>  - Declare DoChangeContents constructor private, wrap its parameters
>  - Space after synchronized in DoChangeContents.run
>  - Convert runnable to local variable

src/java.desktop/share/classes/javax/swing/plaf/basic/BasicDirectoryModel.java line 397:

> 395:                         if (!fileCache.equals(newFileCache)) {
> 396:                             if (loadThread.isInterrupted()) {
> 397:                                 return null;

This should've been `return null` all the way.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18111#discussion_r1512665847

From aivanov at openjdk.org  Tue Mar  5 11:51:48 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 5 Mar 2024 11:51:48 GMT
Subject: RFR: 8326458: Menu mnemonics don't toggle in Windows LAF when F10
 is pressed [v6]
In-Reply-To: <8u2GCTfCYV7k8cpsayj-zYwBOlYxOwyEzrs_NYKPnPI=.fcc890c2-7bfa-47b5-b6ff-4f451dc9c2db@github.com>
References: <uv53ohrzj-j8wA3SHr7M0b5V-Ja9HvKGBa2RgWTwoSU=.abf8c336-4b24-479c-af6d-22acb686ed80@github.com>
 <8u2GCTfCYV7k8cpsayj-zYwBOlYxOwyEzrs_NYKPnPI=.fcc890c2-7bfa-47b5-b6ff-4f451dc9c2db@github.com>
Message-ID: <a2Md4wl59GmV_4fv7LSX0wbPL4B54Y-ynk6eaACt_Us=.ba80acca-755e-4183-8e1e-53ca2f51d3bd@github.com>

On Tue, 5 Mar 2024 06:08:00 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Menu mnemonic doesn't toggle between show and hide state when F10 is pressed. Behavior is not similar to windows native application. Fix is to ensure that menu mnemonic state toggles between show and hide.
>> 
>> Can be verified with SwingSet2 application. 
>> CI tests are green with the fix. Link posted in JBS.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review comment update

Looks good to me except for a couple minor comments.

test/jdk/javax/swing/JMenuBar/TestMenuMnemonic.java line 58:

> 56:     public static void main(String[] args) throws Exception {
> 57:         UIManager.setLookAndFeel("com.sun.java.swing.plaf.windows.WindowsLookAndFeel");
> 58:         final int EXPECTED = 5;

I meant making it `private static final` outside of main.

I suggest something like this:


    private static JFrame frame;
    private static JMenuBar menuBar;
    private static JMenu fileMenu;

    private static final AtomicInteger mnemonicHideCount = new AtomicInteger(0);
    private static final AtomicInteger mnemonicShowCount = new AtomicInteger(0);

    private static final int EXPECTED = 5;


The blank lines separate the blocks of related fields.

test/jdk/javax/swing/JMenuBar/TestMenuMnemonic.java line 97:

> 95:         if (WindowsLookAndFeel.isMnemonicHidden()) {
> 96:             mnemonicHideCount.getAndIncrement();
> 97:             // check if selection is cleared when mnemonics are hidden

We capitalise ?C? since it starts a sentence:
Suggestion:

            // Check if selection is cleared when mnemonics are hidden


See [a comment on the subject](https://github.com/openjdk/jdk/pull/18067#discussion_r1511570584).

-------------

Marked as reviewed by aivanov (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17961#pullrequestreview-1916657969
PR Review Comment: https://git.openjdk.org/jdk/pull/17961#discussion_r1512686263
PR Review Comment: https://git.openjdk.org/jdk/pull/17961#discussion_r1512689884

From abhiscxk at openjdk.org  Tue Mar  5 12:16:48 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Tue, 5 Mar 2024 12:16:48 GMT
Subject: RFR: 8326458: Menu mnemonics don't toggle in Windows LAF when F10
 is pressed [v6]
In-Reply-To: <a2Md4wl59GmV_4fv7LSX0wbPL4B54Y-ynk6eaACt_Us=.ba80acca-755e-4183-8e1e-53ca2f51d3bd@github.com>
References: <uv53ohrzj-j8wA3SHr7M0b5V-Ja9HvKGBa2RgWTwoSU=.abf8c336-4b24-479c-af6d-22acb686ed80@github.com>
 <8u2GCTfCYV7k8cpsayj-zYwBOlYxOwyEzrs_NYKPnPI=.fcc890c2-7bfa-47b5-b6ff-4f451dc9c2db@github.com>
 <a2Md4wl59GmV_4fv7LSX0wbPL4B54Y-ynk6eaACt_Us=.ba80acca-755e-4183-8e1e-53ca2f51d3bd@github.com>
Message-ID: <Krw3z9I7oX30V-hFrg-3tlolHzpIUxGKD-szxPgHZog=.27b76a78-6a02-4be4-ac66-8ff4ec8e0447@github.com>

On Tue, 5 Mar 2024 11:44:56 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>private static final int EXPECTED = 5;

this var is used only in main, so I kept it as local variable.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17961#discussion_r1512718810

From aivanov at openjdk.org  Tue Mar  5 12:19:46 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 5 Mar 2024 12:19:46 GMT
Subject: RFR: 8326458: Menu mnemonics don't toggle in Windows LAF when F10
 is pressed [v6]
In-Reply-To: <Krw3z9I7oX30V-hFrg-3tlolHzpIUxGKD-szxPgHZog=.27b76a78-6a02-4be4-ac66-8ff4ec8e0447@github.com>
References: <uv53ohrzj-j8wA3SHr7M0b5V-Ja9HvKGBa2RgWTwoSU=.abf8c336-4b24-479c-af6d-22acb686ed80@github.com>
 <8u2GCTfCYV7k8cpsayj-zYwBOlYxOwyEzrs_NYKPnPI=.fcc890c2-7bfa-47b5-b6ff-4f451dc9c2db@github.com>
 <a2Md4wl59GmV_4fv7LSX0wbPL4B54Y-ynk6eaACt_Us=.ba80acca-755e-4183-8e1e-53ca2f51d3bd@github.com>
 <Krw3z9I7oX30V-hFrg-3tlolHzpIUxGKD-szxPgHZog=.27b76a78-6a02-4be4-ac66-8ff4ec8e0447@github.com>
Message-ID: <nsN0JJjdnG_EiDPDkhQ_Pdsoy4znMicvhPOZXNJgrKI=.b6c5ae57-da96-49dd-987d-f3cc1dfea158@github.com>

On Tue, 5 Mar 2024 12:13:05 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> test/jdk/javax/swing/JMenuBar/TestMenuMnemonic.java line 58:
>> 
>>> 56:     public static void main(String[] args) throws Exception {
>>> 57:         UIManager.setLookAndFeel("com.sun.java.swing.plaf.windows.WindowsLookAndFeel");
>>> 58:         final int EXPECTED = 5;
>> 
>> I meant making it `private static final` outside of main.
>> 
>> I suggest something like this:
>> 
>> 
>>     private static JFrame frame;
>>     private static JMenuBar menuBar;
>>     private static JMenu fileMenu;
>> 
>>     private static final AtomicInteger mnemonicHideCount = new AtomicInteger(0);
>>     private static final AtomicInteger mnemonicShowCount = new AtomicInteger(0);
>> 
>>     private static final int EXPECTED = 5;
>> 
>> 
>> The blank lines separate the blocks of related fields.
>
>>private static final int EXPECTED = 5;
> 
> this var is used only in main, so I kept it as local variable.

There's a difference between _a local variable_ that it is now and _a constant_ declared at the class level. In the latter case, the compiler may eliminate the constant and inline its value; in the former case, it can't do it.

I am still for making it a real constant declared at the class level as per my suggestion above.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17961#discussion_r1512723625

From abhiscxk at openjdk.org  Tue Mar  5 12:31:00 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Tue, 5 Mar 2024 12:31:00 GMT
Subject: RFR: 8326458: Menu mnemonics don't toggle in Windows LAF when F10
 is pressed [v7]
In-Reply-To: <uv53ohrzj-j8wA3SHr7M0b5V-Ja9HvKGBa2RgWTwoSU=.abf8c336-4b24-479c-af6d-22acb686ed80@github.com>
References: <uv53ohrzj-j8wA3SHr7M0b5V-Ja9HvKGBa2RgWTwoSU=.abf8c336-4b24-479c-af6d-22acb686ed80@github.com>
Message-ID: <zZI620b9A4cHoBNEDTC0ZT06JwfbV9qCXjyKmVmsF_M=.23ee4d00-f3f4-4d13-b84d-1caa04ffabd8@github.com>

> Menu mnemonic doesn't toggle between show and hide state when F10 is pressed. Behavior is not similar to windows native application. Fix is to ensure that menu mnemonic state toggles between show and hide.
> 
> Can be verified with SwingSet2 application. 
> CI tests are green with the fix. Link posted in JBS.

Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:

  minor test update

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/17961/files
  - new: https://git.openjdk.org/jdk/pull/17961/files/e520b8f0..10014445

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=17961&range=06
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17961&range=05-06

  Stats: 6 lines in 1 file changed: 3 ins; 2 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/17961.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17961/head:pull/17961

PR: https://git.openjdk.org/jdk/pull/17961

From aivanov at openjdk.org  Tue Mar  5 12:31:00 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 5 Mar 2024 12:31:00 GMT
Subject: RFR: 8326458: Menu mnemonics don't toggle in Windows LAF when F10
 is pressed [v7]
In-Reply-To: <zZI620b9A4cHoBNEDTC0ZT06JwfbV9qCXjyKmVmsF_M=.23ee4d00-f3f4-4d13-b84d-1caa04ffabd8@github.com>
References: <uv53ohrzj-j8wA3SHr7M0b5V-Ja9HvKGBa2RgWTwoSU=.abf8c336-4b24-479c-af6d-22acb686ed80@github.com>
 <zZI620b9A4cHoBNEDTC0ZT06JwfbV9qCXjyKmVmsF_M=.23ee4d00-f3f4-4d13-b84d-1caa04ffabd8@github.com>
Message-ID: <a4ZseiiozEOd9yhGXWynnYlqAhxceJ2-QVBzWL5EZQU=.e2d91672-90f6-4d11-9ca7-539ab5411ac2@github.com>

On Tue, 5 Mar 2024 12:27:28 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Menu mnemonic doesn't toggle between show and hide state when F10 is pressed. Behavior is not similar to windows native application. Fix is to ensure that menu mnemonic state toggles between show and hide.
>> 
>> Can be verified with SwingSet2 application. 
>> CI tests are green with the fix. Link posted in JBS.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   minor test update

Marked as reviewed by aivanov (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/17961#pullrequestreview-1916757644

From abhiscxk at openjdk.org  Tue Mar  5 12:31:00 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Tue, 5 Mar 2024 12:31:00 GMT
Subject: RFR: 8326458: Menu mnemonics don't toggle in Windows LAF when F10
 is pressed [v6]
In-Reply-To: <nsN0JJjdnG_EiDPDkhQ_Pdsoy4znMicvhPOZXNJgrKI=.b6c5ae57-da96-49dd-987d-f3cc1dfea158@github.com>
References: <uv53ohrzj-j8wA3SHr7M0b5V-Ja9HvKGBa2RgWTwoSU=.abf8c336-4b24-479c-af6d-22acb686ed80@github.com>
 <8u2GCTfCYV7k8cpsayj-zYwBOlYxOwyEzrs_NYKPnPI=.fcc890c2-7bfa-47b5-b6ff-4f451dc9c2db@github.com>
 <a2Md4wl59GmV_4fv7LSX0wbPL4B54Y-ynk6eaACt_Us=.ba80acca-755e-4183-8e1e-53ca2f51d3bd@github.com>
 <Krw3z9I7oX30V-hFrg-3tlolHzpIUxGKD-szxPgHZog=.27b76a78-6a02-4be4-ac66-8ff4ec8e0447@github.com>
 <nsN0JJjdnG_EiDPDkhQ_Pdsoy4znMicvhPOZXNJgrKI=.b6c5ae57-da96-49dd-987d-f3cc1dfea158@github.com>
Message-ID: <4B4dycXpCKqlTT2feF6CuABvz3t21jH0OuvzqqehvEk=.97accaaa-5801-46e5-80a6-22a700a1a9b8@github.com>

On Tue, 5 Mar 2024 12:17:07 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>>>private static final int EXPECTED = 5;
>> 
>> this var is used only in main, so I kept it as local variable.
>
> There's a difference between _a local variable_ that it is now and _a constant_ declared at the class level. In the latter case, the compiler may eliminate the constant and inline its value; in the former case, it can't do it.
> 
> I am still for making it a real constant declared at the class level as per my suggestion above.

Updated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17961#discussion_r1512740249

From aivanov at openjdk.org  Tue Mar  5 12:47:54 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 5 Mar 2024 12:47:54 GMT
Subject: RFR: 8320676 : Manual printer tests have no Pass/Fail buttons,
 instructions close set 1 [v11]
In-Reply-To: <iWutKW4UpvMw8nEhcHknq1dlyNEtmppek6JdbLUqKDU=.4fa91123-1d3a-43d6-9f9d-c3967425c164@github.com>
References: <Afd90FypFvXYNR17jgkxcFj2LlxdLlZ1Bgd7WctdKcU=.2a8b05e0-a476-4598-8524-a22a0f54b8a5@github.com>
 <iWutKW4UpvMw8nEhcHknq1dlyNEtmppek6JdbLUqKDU=.4fa91123-1d3a-43d6-9f9d-c3967425c164@github.com>
Message-ID: <G_hFouVypycpSwZ-ovBR6_zxAzwlXbWFuDsgoZKXFfk=.8ac90930-10a8-4550-a564-d5533eaf6e14@github.com>

On Mon, 4 Mar 2024 06:04:07 GMT, Renjith Kannath Pariyangad <rkannathpari at openjdk.org> wrote:

>> Hi Reviewers,
>> 
>> Updated manual printer test cases with 'PassFailJFrame', also removed unused variables. Added 'SkippedException' in case of printer missing or not configured.
>> 
>> Please review and let me know your suggestions.
>> 
>> Regards,
>> Renjith
>
> Renjith Kannath Pariyangad has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Suggesions incorporated

Changes requested by aivanov (Reviewer).

test/jdk/java/awt/print/PageFormat/PageSetupDialog.java line 239:

> 237:         PassFailJFrame.builder()
> 238:                 .instructions(INSTRUCTIONS)
> 239:                 .testUI(PageSetupDialog::new)

Suggestion:

        PassFailJFrame.builder()
                .instructions(INSTRUCTIONS)
                .testTimeOut(10)
                .testUI(PageSetupDialog::new)

Given the number of cases to go through, I suggest increasing the timeout to 10 minutes at least.

test/jdk/java/awt/print/PrinterJob/Cancel/PrinterJobCancel.java line 50:

> 48:             "progress automatically cancels the print job.\n" +
> 49:             "You should see a message on System.out that the job\n" +
> 50:             "was properly cancelled.";

Suggestion:

            "Test that print job cancellation works.\n\n" +
            "This test starts after clicking OK / Print button.
            "While the print job is in progress, the test automatically cancels it.\n" +
            "The test will complete automatically.";

test/jdk/java/awt/print/PrinterJob/Cancel/PrinterJobCancel.java line 69:

> 67:             pjc.pj.cancel();
> 68:         }
> 69:         else {

Suggestion:

        } else {

Use Java style.

test/jdk/java/awt/print/PrinterJob/Cancel/PrinterJobCancel.java line 70:

> 68:         }
> 69:         else {
> 70:             PassFailJFrame.forceFail("User cancelled");

Be more specific?
Suggestion:

            PassFailJFrame.forceFail("User cancelled printing");

test/jdk/java/awt/print/PrinterJob/Cancel/PrinterJobCancel.java line 93:

> 91:             prex.printStackTrace();
> 92:             PassFailJFrame.forceFail("This is wrong .. we shouldn't be here, " +
> 93:                                      "Looks like a test failure");

Suggestion:

            PassFailJFrame.forceFail("Unexpected PrinterException caught: " + prex.getMessage());

test/jdk/java/awt/print/PrinterJob/PrintAllFonts.java line 45:

> 43:     private static final int FONT_SIZE = 14;
> 44:     private final Font[] allFonts =
> 45:             GraphicsEnvironment.getLocalGraphicsEnvironment().getAllFonts();

I suggest adding blank lines to visually separate fields / constants with different purpose.
Suggestion:

    private static final int LINE_HEIGHT = 18;
    private static final int FONT_SIZE = 14;

    private final Font[] allFonts =
            GraphicsEnvironment.getLocalGraphicsEnvironment().getAllFonts();

test/jdk/java/awt/print/PrinterJob/PrintAllFonts.java line 45:

> 43:     boolean done = false;
> 44:     int thisPage = 0;
> 45: 

This blank was actually good, it separated the instance fields from the instructions constant.

test/jdk/java/awt/print/PrinterJob/PrintAllFonts.java line 61:

> 59:         PassFailJFrame passFailJFrame = new PassFailJFrame.Builder()
> 60:                 .instructions(INSTRUCTIONS)
> 61:                 .rows((int) INSTRUCTIONS.lines().count() + 1)

Suggestion:

                .instructions(INSTRUCTIONS)
                .testTimeOut(10)
                .rows((int) INSTRUCTIONS.lines().count() + 1)

The list of fonts could be long, and the tester may need to go to fetch the printouts from a printer.

test/jdk/java/awt/print/PrinterJob/PrintAllFonts.java line 69:

> 67:         if (pj.printDialog()) {
> 68:             pj.print();
> 69:         }

Fail the test if the user clicks Cancel in the print dialog?

test/jdk/java/awt/print/PrinterJob/ValidatePage/ValidatePage.java line 214:

> 212:                 JOptionPane.showMessageDialog(null,
> 213:                         "NumberFormatException occured", "Error",
> 214:                         JOptionPane.ERROR_MESSAGE);

Suggestion:

                JOptionPane.showMessageDialog(ValidatePage.this,
                        "NumberFormatException occurred", "Error",
                        JOptionPane.ERROR_MESSAGE);

You may provide more information to the user, at the very least the message from the exception itself. Add a comment that the tester should correct the error and try again.

test/jdk/java/awt/print/PrinterJob/ValidatePage/ValidatePage.java line 233:

> 231:                 "needed to accomodate the imageable area.\n \n \n" +
> 232:                 "To test 6229507, put the minimum margins (all 0s) in Page Setup dialog.\n" +
> 233:                 "Compare Imageable width, height, and margins of portrait against landscape.");

Suggestion:

                "When validating a page, the process is 1st to find the closest matching\n" +
                "paper size, next to make sure the requested imageable area fits within\n" +
                "the printer's imageable area for that paper size. Finally the top and\n" +
                "left margins will be shrunk if they are too great for the adjusted\n" +
                "imageable area to fit at that position. They will shrink by the minimum\n" +
                "needed to accomodate the imageable area.\n\n\n" +
                "To test 6229507, put the minimum margins (all 0s) in Page Setup dialog.\n" +
                "Compare Imageable width, height, and margins of portrait against landscape.");

The spaces at the end of lines are redundant.

test/jdk/java/awt/print/PrinterJob/ValidatePage/ValidatePage.java line 301:

> 299:         PassFailJFrame.builder()
> 300:                 .instructions(INSTRUCTIONS)
> 301:                 .testUI(ValidatePage::new)

Suggestion:

                .instructions(INSTRUCTIONS)
                .testTimeOut(15)
                .testUI(ValidatePage::new)

The test requires much interaction, so the timeout should be increased accordingly.

test/jdk/java/awt/print/PrinterJob/raster/RasterTest.java line 92:

> 90:         PrinterJob pj = PrinterJob.getPrinterJob();
> 91: 
> 92:         if (pj != null && pj.printDialog()) {

Suggestion:

        if (pj.printDialog()) {

The contract of [`PrinterJob.getPrinterJob`](https://docs.oracle.com/en/java/javase/21/docs/api/java.desktop/java/awt/print/PrinterJob.html#getPrinterJob()) doesn't allow returning `null`, so the null-check can be removed, which will resolve a warning from IDE.

test/jdk/java/awt/print/PrinterJob/raster/RasterTest.java line 105:

> 103:     private static class RasterCanvas extends Canvas implements Printable {
> 104: 
> 105:         public int print(Graphics g, PageFormat pgFmt, int pgIndex) {

Suggestion:

        @Override
        public int print(Graphics g, PageFormat pgFmt, int pgIndex) {

test/jdk/java/awt/print/PrinterJob/raster/RasterTest.java line 118:

> 116:         }
> 117: 
> 118:         public void paint(Graphics g) {

Suggestion:

        @Override
        public void paint(Graphics g) {

test/jdk/java/awt/print/PrinterJob/raster/RasterTest.java line 125:

> 123:             doPaint(g);
> 124:         }
> 125: 

Suggestion:


The `paintComponent` can be removed; `Canvas` doesn't have it, only Swing components extending `JComponent` have `paintComponent` method.

test/jdk/java/awt/print/PrinterJob/raster/RasterTest.java line 126:

> 124:         }
> 125: 
> 126:         public void doPaint(Graphics g) {

Suggestion:

        private void doPaint(Graphics g) {

Should be `private`.

test/jdk/java/awt/print/PrinterJob/raster/RasterTest.java line 150:

> 148:         }
> 149: 
> 150:         public Dimension getPreferredSize() {

Suggestion:

        @Override
        public Dimension getPreferredSize() {

Let's add `@Override` annotations for clarity when a method is overridden or an interface method is implemented.

-------------

PR Review: https://git.openjdk.org/jdk/pull/17607#pullrequestreview-1916685779
PR Review Comment: https://git.openjdk.org/jdk/pull/17607#discussion_r1512702925
PR Review Comment: https://git.openjdk.org/jdk/pull/17607#discussion_r1512710224
PR Review Comment: https://git.openjdk.org/jdk/pull/17607#discussion_r1512705603
PR Review Comment: https://git.openjdk.org/jdk/pull/17607#discussion_r1512712351
PR Review Comment: https://git.openjdk.org/jdk/pull/17607#discussion_r1512714468
PR Review Comment: https://git.openjdk.org/jdk/pull/17607#discussion_r1512718756
PR Review Comment: https://git.openjdk.org/jdk/pull/17607#discussion_r1512719757
PR Review Comment: https://git.openjdk.org/jdk/pull/17607#discussion_r1512742727
PR Review Comment: https://git.openjdk.org/jdk/pull/17607#discussion_r1512739665
PR Review Comment: https://git.openjdk.org/jdk/pull/17607#discussion_r1512749442
PR Review Comment: https://git.openjdk.org/jdk/pull/17607#discussion_r1512750500
PR Review Comment: https://git.openjdk.org/jdk/pull/17607#discussion_r1512754795
PR Review Comment: https://git.openjdk.org/jdk/pull/17607#discussion_r1512761318
PR Review Comment: https://git.openjdk.org/jdk/pull/17607#discussion_r1512768938
PR Review Comment: https://git.openjdk.org/jdk/pull/17607#discussion_r1512768757
PR Review Comment: https://git.openjdk.org/jdk/pull/17607#discussion_r1512766713
PR Review Comment: https://git.openjdk.org/jdk/pull/17607#discussion_r1512765313
PR Review Comment: https://git.openjdk.org/jdk/pull/17607#discussion_r1512767988

From aivanov at openjdk.org  Tue Mar  5 12:47:55 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 5 Mar 2024 12:47:55 GMT
Subject: RFR: 8320676 : Manual printer tests have no Pass/Fail buttons,
 instructions close set 1 [v6]
In-Reply-To: <A-Qi7Ho5ozsqSWFPNEAmNjaLrBGYzpvFcI_7Ja01WJA=.f9a4a013-9e33-4e25-9831-5fb6d6f9c5a0@github.com>
References: <Afd90FypFvXYNR17jgkxcFj2LlxdLlZ1Bgd7WctdKcU=.2a8b05e0-a476-4598-8524-a22a0f54b8a5@github.com>
 <i-Eysl3dnpitEVQGelJb8QFWgrfOYd9-MqbP1FnmcB8=.57ef5468-34cf-4692-930a-1bbf711e3530@github.com>
 <A-Qi7Ho5ozsqSWFPNEAmNjaLrBGYzpvFcI_7Ja01WJA=.f9a4a013-9e33-4e25-9831-5fb6d6f9c5a0@github.com>
Message-ID: <11qQRv-_Zu9zuMe0I6aFHNQkSAQreoymlFi10g_VEP4=.e7d0dfa3-3370-4db4-a372-50d3fc67b425@github.com>

On Tue, 13 Feb 2024 14:01:40 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Renjith Kannath Pariyangad has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fixed compiler error
>
> test/jdk/java/awt/print/PrinterJob/PrintAllFonts.java line 53:
> 
>> 51:             "\n" +
>> 52:             "This bug is system dependent and is not always reproducible.\n" +
>> 53:             "A passing test will have all text printed with correct font style.";
> 
> Clarify that the second column should be proper *italics*. I don't know how to explain it better; you can look at the PDFs attached to [JDK-4884389](https://bugs.openjdk.org/browse/JDK-4884389) to understand better what the bug was.

I still suggest clarifying that the second column should always have the italic style and should use the italic font style if it's available (in the left column) instead of synthesised italic.

Look at the `1.4.2.pdf` file attached to [JDK-4884389](https://bugs.openjdk.org/browse/JDK-4884389).

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17607#discussion_r1512734177

From mkartashev at openjdk.org  Tue Mar  5 13:28:46 2024
From: mkartashev at openjdk.org (Maxim Kartashev)
Date: Tue, 5 Mar 2024 13:28:46 GMT
Subject: RFR: 8326497: Window.toFront() fails for iconified windows on
 Linux [v5]
In-Reply-To: <Xnvtw_SABWMR-okt1ZOb5NkmKWkkNg6-Tnu1yp6yQkg=.962fcdee-7f9f-49fe-ac96-cfbfbc49cc0c@github.com>
References: <XmMRoFNpTDQHCZLnmmnNGVjhR2Ib3yw1kWc0v57utUM=.e418325c-7b23-4298-8f75-e81d369b5afc@github.com>
 <4ZzIgJ3GvtcPQdKqBZ5J49WcKrfNgUjxff02pRSd7fI=.f2e73f77-4aac-4c29-8831-04aaf9d81d23@github.com>
 <Xnvtw_SABWMR-okt1ZOb5NkmKWkkNg6-Tnu1yp6yQkg=.962fcdee-7f9f-49fe-ac96-cfbfbc49cc0c@github.com>
Message-ID: <NbBenH0X5Y6PYa-4SOWxlpukBLauvwN6CZWZNxf_1eI=.e949822b-7457-48ce-8090-df4aae60f65f@github.com>

On Tue, 5 Mar 2024 10:44:53 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Maxim Kartashev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Made the test to waitForIdle()
>
> test/jdk/java/awt/Frame/Iconify/IconifiedToFront.java line 41:
> 
>> 39: 
>> 40: public class IconifiedToFront {
>> 41:     private static final int PAUSE_MS = 1500;
> 
> 1.5 sec is minimum delay, can we reduced it ?

Not unless there's another idea on how to measure tests' success. 1.5 seconds is about the time my MacOS needs to complete an iconify/de-iconfiy process.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17985#discussion_r1512822193

From aivanov at openjdk.org  Tue Mar  5 14:10:54 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 5 Mar 2024 14:10:54 GMT
Subject: RFR: 8324807 : Manual printer tests have no Pass/Fail buttons,
 instructions close set 2 [v10]
In-Reply-To: <3EjlqyLzNCZxo6F1YSOs2zRrNxO5QTIQxkuY27Y3Ro4=.f13abdf7-f15f-44fc-9068-15f3ccda0958@github.com>
References: <UZ9jtQbkj-MoeLoccJnd2_3ciCCy9n-CD5vDv0hVKME=.f67db96d-92e6-46a1-9bb6-4fe77c9a8c4e@github.com>
 <3EjlqyLzNCZxo6F1YSOs2zRrNxO5QTIQxkuY27Y3Ro4=.f13abdf7-f15f-44fc-9068-15f3ccda0958@github.com>
Message-ID: <-3Z3D3ZejKBGJxG_3x26fcoUx2MzUa4vQejYWFRo1-I=.29bf2730-c42a-4f37-a4ad-b14ca74fc025@github.com>

On Mon, 4 Mar 2024 06:33:09 GMT, Renjith Kannath Pariyangad <rkannathpari at openjdk.org> wrote:

>> Hi Reviewers,
>> 
>> Updated manual printer test cases with 'PassFailJFrame', also removed unused variables. Added 'SkippedException' in case of printer missing or not configured.
>> 
>> Please review and let me know your suggestions.
>> 
>> Regards,
>> Renjith
>
> Renjith Kannath Pariyangad has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Updated instruction

Changes requested by aivanov (Reviewer).

test/jdk/java/awt/print/PrinterJob/Collate2DPrintingTest.java line 1:

> 1: /*

Could you please add `@Override` annotations to all the methods which implement the interfaces.

test/jdk/java/awt/print/PrinterJob/Collate2DPrintingTest.java line 59:

> 57:  */
> 58: public class Collate2DPrintingTest
> 59:         extends Frame implements Doc, Printable {

Suggestion:

        implements Doc, Printable {

`Frame` used to be the container to display the buttons, now it's not needed.

test/jdk/java/awt/print/PrinterJob/Collate2DPrintingTest.java line 74:

> 72:                 if (pj.printDialog(prSet)) {
> 73:                     pj.print(prSet);
> 74:                 }

In this case, the print dialog has *Collated* checked and disabled; the number of copies is set to 1 and I can't change the value.

Does it work for you? Is it a bug in JDK?

test/jdk/java/awt/print/PrinterJob/Collate2DPrintingTest.java line 102:

> 100:         main.add(Box.createVerticalGlue());
> 101:         main.add(print2D);
> 102:         main.add(printMerlin);

Suggestion:

        main.add(print2D);
        main.add(Box.createVerticalStrut(4));
        main.add(printMerlin);

Add some margin between the buttons.

test/jdk/java/awt/print/PrinterJob/DrawImage.java line 49:

> 47: public class DrawImage {
> 48:     private static final int OBJECT_BORDER = 15;
> 49:     private static final String INSTRUCTIONS =

Suggestion:

    private static final int OBJECT_BORDER = 15;

    private static final String INSTRUCTIONS =

I think it's better with a blank line, the two constants aren't closely related.

test/jdk/java/awt/print/PrinterJob/DrawImage.java line 57:

> 55:     private final PageFormat pageFormat;
> 56: 
> 57:     public DrawImage(BufferedImage image) {

Let's make it private too.
Suggestion:

    private DrawImage(BufferedImage image) {

test/jdk/java/awt/print/PrinterJob/DrawImage.java line 73:

> 71:         int y = (int) pageFormat.getImageableY();
> 72: 
> 73:         // make slightly smaller (25) than max possible width

Suggestion:

        // Make the image slightly smaller (25) than max possible width

test/jdk/java/awt/print/PrinterJob/DrawImage.java line 87:

> 85:     }
> 86: 
> 87:     public void print() throws PrinterException {

Suggestion:

    private void print() throws PrinterException {

Make it `private` to avoid any confusion with implementation of `Printable` interface which must be `public`.

test/jdk/java/awt/print/PrinterJob/DrawImage.java line 93:

> 91:         if (pj.printDialog()) {
> 92:             pj.print();
> 93:         }

Fail the test if the tester clicks Cancel in the print dialog?

test/jdk/java/awt/print/PrinterJob/DrawImage.java line 104:

> 102:         if (image == null) {
> 103:             throw new RuntimeException("Image creation failed");
> 104:         }

It seems impossible for the `image` to be `null`. Let's drop this condition. If for whatever reason it is `null`, printing will fail with NPE.

test/jdk/java/awt/print/PrinterJob/DrawImage.java line 117:

> 115:     }
> 116: 
> 117:     public static BufferedImage prepareFrontImage() {

Let's make it private too.
Suggestion:

    private static BufferedImage prepareFrontImage() {

test/jdk/java/awt/print/PrinterJob/DrawImage.java line 121:

> 119:         BufferedImage result = new BufferedImage(400, 200,
> 120:                                    BufferedImage.TYPE_BYTE_GRAY);
> 121:         int w = result.getWidth(), h = result.getHeight();

Suggestion:

        int w = result.getWidth();
        int h = result.getHeight();

Avoid declaring several variables at the same line.

test/jdk/java/awt/print/PrinterJob/DrawStringMethods.java line 50:

> 48:             " This test will automatically initiate a print\n" +
> 49:             "\n" +
> 50:             " Confirm that the methods are printed.\n" +

Suggestion:

            " This test will automatically initiate a print.\n" +
            "\n" +
            " Confirm that the following methods are printed:\n" +

test/jdk/java/awt/print/PrinterJob/DrawStringMethods.java line 76:

> 74:     }
> 75: 
> 76:     public static AttributedCharacterIterator getIterator(String s) {

Suggestion:

    private static AttributedCharacterIterator getIterator(String s) {

Let's make it private.

test/jdk/java/awt/print/PrinterJob/InvalidPage.java line 49:

> 47:  * @run main/manual InvalidPage
> 48:  */
> 49: public class InvalidPage extends Frame implements Printable {

Suggestion:

public class InvalidPage implements Printable {

No `Frame` is needed.

test/jdk/java/awt/print/PrinterJob/InvalidPage.java line 116:

> 114:             " Repeat for all the printers as you have installed\n" +
> 115:             " On Solaris and Linux just one printer is sufficient.\n" +
> 116:             " Collect the output and examine it, each print job has two pages\n" +

Suggestion:

            "\n" +
            " Repeat for all the printers you have installed.\n" +
            " On Solaris and Linux just one printer is sufficient.\n" +
            "\n" +
            " Collect the output and examine it, each print job has two pages\n" +

Add blank lines to separate paragraphs for easier parsing / reading.

test/jdk/java/awt/print/PrinterJob/InvalidPage.java line 123:

> 121:             " are positioned identically on both pages\n" +
> 122:             " The test fails if the output from the two\n" +
> 123:             " pages of a job is aligned differently";

Suggestion:

            "\n" +
            " The test fails if the output from the two\n" +
            " pages of a job is aligned differently";

test/jdk/java/awt/print/PrinterJob/InvalidPage.java line 132:

> 130:         PassFailJFrame.builder()
> 131:                 .instructions(INSTRUCTIONS)
> 132:                 .splitUI(InvalidPage::createTestUI)

Suggestion:

                .instructions(INSTRUCTIONS)
                .testTimeOut(10)
                .splitUI(InvalidPage::createTestUI)

Increase the timeout as the tester needs to perform this operation for all the printers installed and verify the printouts.

test/jdk/java/awt/print/PrinterJob/JobName/PrinterJobName.java line 40:

> 38:  */
> 39: public class PrinterJobName implements Printable {
> 40:     private static final String THE_NAME = "Testing the Jobname setting";

Suggestion:

    private static final String THE_NAME = "Testing the Job name setting";

Spell it with space.

test/jdk/java/awt/print/PrinterJob/JobName/PrinterJobName.java line 41:

> 39: public class PrinterJobName implements Printable {
> 40:     private static final String THE_NAME = "Testing the Jobname setting";
> 41:     private static final String INSTRUCTIONS =

Keep the blank line between these two constants.

-------------

PR Review: https://git.openjdk.org/jdk/pull/17608#pullrequestreview-1916838124
PR Review Comment: https://git.openjdk.org/jdk/pull/17608#discussion_r1512798993
PR Review Comment: https://git.openjdk.org/jdk/pull/17608#discussion_r1512791435
PR Review Comment: https://git.openjdk.org/jdk/pull/17608#discussion_r1512798212
PR Review Comment: https://git.openjdk.org/jdk/pull/17608#discussion_r1512792702
PR Review Comment: https://git.openjdk.org/jdk/pull/17608#discussion_r1512803855
PR Review Comment: https://git.openjdk.org/jdk/pull/17608#discussion_r1512811330
PR Review Comment: https://git.openjdk.org/jdk/pull/17608#discussion_r1512812240
PR Review Comment: https://git.openjdk.org/jdk/pull/17608#discussion_r1512807572
PR Review Comment: https://git.openjdk.org/jdk/pull/17608#discussion_r1512808081
PR Review Comment: https://git.openjdk.org/jdk/pull/17608#discussion_r1512822219
PR Review Comment: https://git.openjdk.org/jdk/pull/17608#discussion_r1512808749
PR Review Comment: https://git.openjdk.org/jdk/pull/17608#discussion_r1512809270
PR Review Comment: https://git.openjdk.org/jdk/pull/17608#discussion_r1512828005
PR Review Comment: https://git.openjdk.org/jdk/pull/17608#discussion_r1512829017
PR Review Comment: https://git.openjdk.org/jdk/pull/17608#discussion_r1512839764
PR Review Comment: https://git.openjdk.org/jdk/pull/17608#discussion_r1512836220
PR Review Comment: https://git.openjdk.org/jdk/pull/17608#discussion_r1512836833
PR Review Comment: https://git.openjdk.org/jdk/pull/17608#discussion_r1512837873
PR Review Comment: https://git.openjdk.org/jdk/pull/17608#discussion_r1512881276
PR Review Comment: https://git.openjdk.org/jdk/pull/17608#discussion_r1512872881

From aivanov at openjdk.org  Tue Mar  5 14:41:49 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 5 Mar 2024 14:41:49 GMT
Subject: RFR: 8324807 : Manual printer tests have no Pass/Fail buttons,
 instructions close set 2 [v10]
In-Reply-To: <3EjlqyLzNCZxo6F1YSOs2zRrNxO5QTIQxkuY27Y3Ro4=.f13abdf7-f15f-44fc-9068-15f3ccda0958@github.com>
References: <UZ9jtQbkj-MoeLoccJnd2_3ciCCy9n-CD5vDv0hVKME=.f67db96d-92e6-46a1-9bb6-4fe77c9a8c4e@github.com>
 <3EjlqyLzNCZxo6F1YSOs2zRrNxO5QTIQxkuY27Y3Ro4=.f13abdf7-f15f-44fc-9068-15f3ccda0958@github.com>
Message-ID: <R3Glx0PHUH_1q9FyAuA9MFOO9kvkCkahPpHlizYOGKw=.8373137a-e1ed-4474-87f4-13560b02f772@github.com>

On Mon, 4 Mar 2024 06:33:09 GMT, Renjith Kannath Pariyangad <rkannathpari at openjdk.org> wrote:

>> Hi Reviewers,
>> 
>> Updated manual printer test cases with 'PassFailJFrame', also removed unused variables. Added 'SkippedException' in case of printer missing or not configured.
>> 
>> Please review and let me know your suggestions.
>> 
>> Regards,
>> Renjith
>
> Renjith Kannath Pariyangad has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Updated instruction

The usage of split UI makes printer tests nicer. I think all printer tests should have a Print button or the like to start testing rather than starting a print job right away. I find such tests easier to use.

The instructions appear, you have the time to read through them and then click Print to start testing. In this case, if you clicked Cancel in the print dialog, you can click the Print button in the UI again to retry.

However, it is not a goal at this time? a suggestion for a future improvement.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17608#issuecomment-1978922032

From aivanov at openjdk.org  Tue Mar  5 15:29:00 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 5 Mar 2024 15:29:00 GMT
Subject: RFR: 8324808 : Manual printer tests have no Pass/Fail buttons,
 instructions close set 3 [v9]
In-Reply-To: <A877YpZnLzvXlDU70eT128kB9hnPyuE3xxQlw8UrVCs=.01da0d64-66b0-48d6-b1f3-08c48e251ee8@github.com>
References: <BFuAfPibaBpToXKzPNGUKf6pC1DvjrAedYHdtJxtuO8=.d54fcf6c-0727-4a4e-8a94-73a4ebe78af4@github.com>
 <A877YpZnLzvXlDU70eT128kB9hnPyuE3xxQlw8UrVCs=.01da0d64-66b0-48d6-b1f3-08c48e251ee8@github.com>
Message-ID: <hKIZieC0E6_FFK8wi99i34vjVVuRBnfYT-61unwd4N8=.d76b51ad-717c-47c1-ab11-67b731c63229@github.com>

On Mon, 4 Mar 2024 06:48:18 GMT, Renjith Kannath Pariyangad <rkannathpari at openjdk.org> wrote:

>> Hi Reviewers,
>> 
>> Updated manual printer test cases with 'PassFailJFrame', also removed unused variables. Added 'SkippedException' in case of printer missing or not configured.
>> 
>> Please review and let me know your suggestions.
>> 
>> Regards,
>> Renjith
>
> Renjith Kannath Pariyangad has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Suggesions added

Changes requested by aivanov (Reviewer).

test/jdk/java/awt/print/PrinterJob/PageDlgPrnButton.java line 42:

> 40:  */
> 41: public class PageDlgPrnButton implements Printable
> 42: {

Suggestion:

public class PageDlgPrnButton implements Printable {

Keep the opening brace on the same line.

test/jdk/java/awt/print/PrinterJob/PageDlgPrnButton.java line 44:

> 42: {
> 43:     private static final String INSTRUCTIONS =
> 44:             "You must have at least 2 printers available to perform this test.\n" +

Suggestion:


The first line can be removed, the test verifies this condition before starting.

test/jdk/java/awt/print/PrinterJob/PageDlgPrnButton.java line 52:

> 50:         if (PrinterJob.lookupPrintServices().length < 2) {
> 51:             throw new RuntimeException("Printer not configured or available.");
> 52:         }

This is inaccurate now. We need to cases here:

- No printer configured ? fail the test because the test has `@key printer`.
- There are less than 2 printers ? throw `SkippedException` because the test cannot continue and there's no way to automatically check for it.

Suggestion:

        final int serviceCount = PrinterJob.lookupPrintServices().length;
        if (serviceCount == 0) {
            throw new RuntimeException("Printer not configured or available.");
        }
        if (serviceCount < 2) {
            throw new SkippedException("The test requires at least 2 printers.");
        }

test/jdk/java/awt/print/PrinterJob/PageDlgPrnButton.java line 73:

> 71:         if (originalPageFormat == pageFormat) {
> 72:             throw new RuntimeException("OriginalPageFormat equals pageFormat");
> 73:         }

This does not make sense to me? All code paths seem to return a new object all the times. It is impossible to for these two objects to be identical.

I can't find JDK-4956397 in JBS.

test/jdk/java/awt/print/PrinterJob/PrintImage.java line 57:

> 55:             "Printing must be done in Japanese 2nd Edition.\n" +
> 56:             "Preferably Canon LaserShot A309GII.\n" +
> 57:             "\n" +

Suggestion:


I believe we can remove the first part of the instructions. The original bug [JDK-4298489](https://bugs.openjdk.org/browse/JDK-4298489) says printing by the first method was ugly and the second one was good. Both methods should produce the identical results.

According to the bug description, it was reported against Windows 95 OSR 2 although the instructions in the test refer to Windows 98 Second Edition and its Japanese version for whatever reason.

test/jdk/java/awt/print/PrinterJob/PrintImage.java line 59:

> 57:             "\n" +
> 58:             "Passing test : Output of text image for PrintTest1 and PrintTest2 should be\n" +
> 59:             "same as that on the screen.";

Expand the instructions:
Suggestion:

            "Select PrintTest1 in the File menu.\n" +
            "Print Dialog will appear.\n" +
            "Click OK to start the first print job.\n" +
            "\n" +
            "Select PrintTest2 in the File menu.\n" +
            "Page Setup Dialog will appear.\n" +
            "Click OK.\n" +
            "Print Dialog will appear.\n" +
            "Click OK to start the second print job.\n" +
            "\n" +
            "The text in the printouts for PrintTest1 and PrintTest2 should be\n" +
            "same as that on the screen.\n" +
            "Press Pass if they are, otherwise press Fail.";

test/jdk/java/awt/print/PrinterJob/PrintImage.java line 93:

> 91:         me.add(print2Menu);
> 92:         mb.add(me);
> 93:         this.setMenuBar(mb);

Suggestion:

        setMenuBar(mb);

test/jdk/java/awt/print/PrinterJob/PrintNullString.java line 54:

> 52:             "The messages should contain only 'OK' and 'expected' messages\n" +
> 53:             "If the page fails to print, but there were no exceptions\n" +
> 54:             "then the problem is likely elsewhere (ie your printer)";

Suggestion:

            "This test should print a page which contains the same\n" +
            "text messages as in the test window on the screen.\n" +
            "\n" +
            "The messages should contain only 'OK' and 'expected' messages.\n" +
            "Press Pass if it's the case; otherwise press Fail.\n" +
            "\n" +
            "If the page fails to print, but there were no exceptions\n" +
            "then the problem is likely elsewhere (i.e. your printer)";

test/jdk/java/awt/print/PrinterJob/PrintNullString.java line 76:

> 74:         add("Center", c);
> 75: 
> 76:         JButton b = new JButton("Print");

Suggestion:

        Button b = new Button("Print");

Better use `Button` with other AWT components.

test/jdk/java/awt/print/PrinterJob/PrintNullString.java line 122:

> 120:         }
> 121: 
> 122:         public void paint(Graphics2D g2d) {

Suggestion:

        private void paint(Graphics2D g2d) {

To avoid any confusion with public `paint` and `print`, even though it accepts `Graphics2D` as parameter.

test/jdk/java/awt/print/PrinterJob/PrintNullString.java line 176:

> 174:         }
> 175: 
> 176:         public Dimension getPreferredSize() {

Suggestion:

        @Override
        public Dimension getPreferredSize() {

test/jdk/java/awt/print/PrinterJob/PrintParenString.java line 48:

> 46: public class PrintParenString implements Printable {
> 47:     private static final String STR = "String containing unclosed parenthesis (.";
> 48:     private static final String INSTRUCTIONS =

Suggestion:

    private static final String STR = "String containing unclosed parenthesis (.";

    private static final String INSTRUCTIONS =

I'd add a blank line between these two.

test/jdk/java/awt/print/PrinterJob/PrintTranslatedFont.java line 55:

> 53:             "should be immediately under the text\n" +
> 54:             "You should also monitor the command line to see if any exceptions\n" +
> 55:             "were thrown\n" +

Suggestion:


The tester cannot see the console or any messages printed onto the console by the test.

test/jdk/java/awt/print/PrinterJob/PrintTranslatedFont.java line 79:

> 77:         add("Center", c);
> 78: 
> 79:         JButton b = new JButton("Print");

Suggestion:

        Button b = new Button("Print");

It is better not to mix AWT and Swing components; you use `Frame` as the host instead of `JFrame` in this case.

test/jdk/java/awt/print/PrinterJob/PrintTranslatedFont.java line 100:

> 98:     }
> 99: 
> 100:     static class TextCanvas extends Panel implements Printable {

Suggestion:

    private static class TextCanvas extends Panel implements Printable {

test/jdk/java/awt/print/PrinterJob/PrintTranslatedFont.java line 119:

> 117:         }
> 118: 
> 119:         public void paint(Graphics2D g2d) {

Suggestion:

        private void paint(Graphics2D g2d) {

test/jdk/java/awt/print/PrinterJob/PrintTranslatedFont.java line 143:

> 141:         }
> 142: 
> 143:         public Dimension getPreferredSize() {

Suggestion:

        @Override
        public Dimension getPreferredSize() {

-------------

PR Review: https://git.openjdk.org/jdk/pull/17609#pullrequestreview-1917119360
PR Review Comment: https://git.openjdk.org/jdk/pull/17609#discussion_r1512898725
PR Review Comment: https://git.openjdk.org/jdk/pull/17609#discussion_r1512947071
PR Review Comment: https://git.openjdk.org/jdk/pull/17609#discussion_r1512908332
PR Review Comment: https://git.openjdk.org/jdk/pull/17609#discussion_r1512930564
PR Review Comment: https://git.openjdk.org/jdk/pull/17609#discussion_r1512971059
PR Review Comment: https://git.openjdk.org/jdk/pull/17609#discussion_r1512983320
PR Review Comment: https://git.openjdk.org/jdk/pull/17609#discussion_r1512983789
PR Review Comment: https://git.openjdk.org/jdk/pull/17609#discussion_r1512996573
PR Review Comment: https://git.openjdk.org/jdk/pull/17609#discussion_r1513000538
PR Review Comment: https://git.openjdk.org/jdk/pull/17609#discussion_r1513003163
PR Review Comment: https://git.openjdk.org/jdk/pull/17609#discussion_r1513022787
PR Review Comment: https://git.openjdk.org/jdk/pull/17609#discussion_r1513008822
PR Review Comment: https://git.openjdk.org/jdk/pull/17609#discussion_r1513015864
PR Review Comment: https://git.openjdk.org/jdk/pull/17609#discussion_r1513018179
PR Review Comment: https://git.openjdk.org/jdk/pull/17609#discussion_r1513018642
PR Review Comment: https://git.openjdk.org/jdk/pull/17609#discussion_r1513019078
PR Review Comment: https://git.openjdk.org/jdk/pull/17609#discussion_r1513019442

From aivanov at openjdk.org  Tue Mar  5 15:29:01 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 5 Mar 2024 15:29:01 GMT
Subject: RFR: 8324808 : Manual printer tests have no Pass/Fail buttons,
 instructions close set 3 [v3]
In-Reply-To: <6bPqfn0dGnEWOQOXQZyWUs8pDntf9jrb5uB6DcZJXFY=.5e832da5-87c4-45e5-b586-ea83cc2ee857@github.com>
References: <BFuAfPibaBpToXKzPNGUKf6pC1DvjrAedYHdtJxtuO8=.d54fcf6c-0727-4a4e-8a94-73a4ebe78af4@github.com>
 <Cg8qo9-JP1e79kLZDxsrtgCXVWsR3sNleLmTyrgzKW8=.b6f609e3-e9ed-4fe4-bd96-3bd470f6060b@github.com>
 <jdCv1AlFoX2XnSMCDG8oReuvSwnCQgC--e8b2lyinfw=.ada4e182-4d30-40d3-8190-5d6276c54251@github.com>
 <6bPqfn0dGnEWOQOXQZyWUs8pDntf9jrb5uB6DcZJXFY=.5e832da5-87c4-45e5-b586-ea83cc2ee857@github.com>
Message-ID: <v5PEKNdiO1CXJjA-zAMo-yC0gTikZ5-vvOlPZKUd9us=.1a4c6cf4-5306-4850-9abb-bde94417c499@github.com>

On Tue, 13 Feb 2024 12:06:46 GMT, Renjith Kannath Pariyangad <rkannathpari at openjdk.org> wrote:

>> test/jdk/java/awt/print/PrinterJob/PageDlgPrnButton.java line 48:
>> 
>>> 46:             "For non-windows OS, this test PASSes.\n" +
>>> 47:             "You must have at least 2 printers available to perform this test.\n" +
>>> 48:             "This test brings up a native Windows page dialog.\n" +
>> 
>> Can we verify this too? That is the number of print services is at least 2.
>
> This test is showing only a windows _page setup_ without any option to select printer and printing to default printer. Do you think we should add this condition ?

It shows the print dialog later after you click OK. And you can modify the page format in this Page Setup dialog; perhaps it's what expected but it's not clear.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17609#discussion_r1512949480

From alexey.ivanov at oracle.com  Tue Mar  5 15:40:34 2024
From: alexey.ivanov at oracle.com (Aleksei Ivanov)
Date: Tue, 5 Mar 2024 15:40:34 +0000
Subject: how to get find out the keyboard shortcut for the paste action?
In-Reply-To: <CH3PR12MB76196E29050B67CD2888B8AEF9232@CH3PR12MB7619.namprd12.prod.outlook.com>
References: <CH3PR12MB76198C4F8B2300D806EDCCF0F9452@CH3PR12MB7619.namprd12.prod.outlook.com>
 <em455be664-76d1-43e4-ba85-729678b34dc6@76ca4640.com>
 <CH3PR12MB7619B0682852C7C836096E84F95C2@CH3PR12MB7619.namprd12.prod.outlook.com>
 <CH3PR12MB76199D23AB541CB4C09118AAF95C2@CH3PR12MB7619.namprd12.prod.outlook.com>
 <emfa5db32b-c08c-4ebc-a061-fc24306fbe93@dcff66fe.com>
 <CH3PR12MB76196E29050B67CD2888B8AEF9232@CH3PR12MB7619.namprd12.prod.outlook.com>
Message-ID: <8399c796-17e8-4d78-9916-a55054251420@oracle.com>

Hello Mark,

As far as I know, the shortcuts are localisable. For example, you use 
Ctrl+S to save a file in an English version, yet users of Spanish 
version of Windows use Ctrl+G (for Guardar) instead.

At the same time, the most common actions ? Cut, Copy and Paste as well 
as Undo and Redo ? usually have the same shortcuts across all languages 
and OS, although macOS uses Cmd instead of Ctrl. However, the shortcut 
for Redo is not as standard, Ctrl+Shift+Z and Ctrl+Y are used, both 
could be mapped at the same time.

I wonder what is the shortcut for Undo in German versions since German 
keyboard layout has Z and Y keys swapped. Does anyone know?

So, the shortcuts used in an application are controlled by the 
application and the shortcuts can be localised.

For this reason, the shortcuts are usually ?hardcoded?.


@Jeremy
Does the input map of JTextArea contain shortcuts for Cut, Copy and Paste?

On 2024-03-04 20:42, mark.yagnatinsky at barclays.com wrote:
>
> Thanks!? I don?t have a particularly deep motivation here, other than 
> curiosity.
>
> If you?re wondering how my curiosity got piqued initially, it was 
> something like this:
>
> A while ago, someone at work was adding copy/paste support to some 
> component that didn?t have it.
>
> I noticed that they ?hardcoded? the shortcut ?ctrl C?.
>
> And I thought to myself:
>
> Swing already ?knows? that this is the right keyboard shortcut, in the 
> sense that all components that support copy/paste ?out of the box? use it.
>
> It would be nice if there was some way to ASK it to tell me what it 
> ?knows?.
>
> *From:* Jeremy Wood <mickleness at gmail.com>
> *Sent:* Sunday, March 3, 2024 11:30 PM
> *To:* Yagnatinsky, Mark : Markets Pre Trade 
> <mark.yagnatinsky at barclays.com>; client-libs-dev at openjdk.org
> *Subject:* Re[2]: how to get find out the keyboard shortcut for the 
> paste action?
>
> CAUTION: This email originated from outside our organisation - 
> mickleness at gmail.com Do not click on links, open attachments, or 
> respond unless you recognize the sender and can validate the content 
> is safe.
>
> >?But now I have a new question?
>
> > Is there any way to get the ?usual? letter for a ?common? operation?
>
> Hmm. Good question. Not that I know of.
>
> > Again, one could create a scratch text area and grovel through its 
> input map, but that seems hacky.
>
> I agree sifting through the L&F seems hacky.
>
> I don?t think I understand exactly what you?re trying to implement 
> here. If you give me a more concrete example: maybe I (or someone on 
> this list) can offer a more concrete suggestion?
>
> I?ll add some context in case this speaks to your question.
>
> By default Swing gets this information in places like 
> BasicTextUI#getInputMap(), which calls:
>
> InputMap shared= ??? (InputMap)DefaultLookup./get/(editor, this, ??? getPropertyPrefix() + ".focusInputMap?);
>
> The following works on my Mac & Windows machine (I think using JDK 
> 19), but I wouldn?t be surprised if it fails in other platforms / 
> L&F?s. It feels brittle, but it might (?) have potential:
>
> private KeyStroke getCopyKeyStroke() {
>
> InputMap inputMap = (InputMap) 
> UIManager.getDefaults().get("TextField.focusInputMap"); for (KeyStroke 
> keyStroke : inputMap.keys()) { Object action = 
> inputMap.get(keyStroke); if ("copy-to-clipboard".equals(action)) { 
> return keyStroke; ??????? } ??? } /// this will show all the default 
> keystrokes //??????????????? 
> System.out.println(Arrays.asList(inputMap.allKeys())); /return null; }
>
> Regards,
>
> ?- Jeremy
>
> ------ Original Message ------
>
> From mark.yagnatinsky at barclays.com
>
> To mickleness at gmail.com; client-libs-dev at openjdk.org
>
> Date 3/3/24, 6:00:46?PM
>
> Subject RE: how to get find out the keyboard shortcut for the paste 
> action?
>
>     Thanks for the response!? I didn?t expect to get one at this point J
>
>     It does indeed answer my question!
>
>     (Though you didn?t quite get the name right: there?s no Ex at the end?
>
>     I take it you?ve done some Windows programming at some point)
>
>     But now I have a new question?
>
>     Is there any way to get the ?usual? letter for a ?common? operation?
>
>     For instance, lots of programs support copy and paste.
>
>     Is there a way to ask Java ?what is the standard letter for paste?
>     and get back ?V??
>
>     Again, one could create a scratch text area and grovel through its
>     input map, but that seems hacky.
>
-- 
Regards,
Alexey

From aivanov at openjdk.org  Tue Mar  5 15:51:56 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 5 Mar 2024 15:51:56 GMT
Subject: RFR: 8286759: TextComponentPrintable: consequent -> consecutive
 positions [v2]
In-Reply-To: <CTbRheJJ9yn-OaBNP3gBAhiEfSCS2K9nOXuyuVal9Ns=.72f8155d-78b0-4ec7-93f5-9457b235a205@github.com>
References: <CTbRheJJ9yn-OaBNP3gBAhiEfSCS2K9nOXuyuVal9Ns=.72f8155d-78b0-4ec7-93f5-9457b235a205@github.com>
Message-ID: <g3wtgOSCJWbZsGCqX5329YzMZEmYyk4_b9_KrMusGqs=.19ab236a-98ad-4ad5-8db0-9ff606997515@github.com>

> A trivial change in a comment: consequent ? _consecutive_ positions.
> 
> This was found in [a code review](https://github.com/openjdk/jdk/pull/8328#discussion_r872596373) for [JDK-8285306](https://bugs.openjdk.org/browse/JDK-8285306).

Alexey Ivanov has updated the pull request incrementally with one additional commit since the last revision:

  Amend the comment with the suggested text

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18067/files
  - new: https://git.openjdk.org/jdk/pull/18067/files/310a0855..0bb80196

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18067&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18067&range=00-01

  Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/jdk/pull/18067.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18067/head:pull/18067

PR: https://git.openjdk.org/jdk/pull/18067

From aivanov at openjdk.org  Tue Mar  5 15:51:57 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 5 Mar 2024 15:51:57 GMT
Subject: RFR: 8286759: TextComponentPrintable: consequent -> consecutive
 positions [v2]
In-Reply-To: <3V52jpktdb-W7pezzS8zWsRhH6tvVAaPcORlb7P-55k=.e5d20f00-8e57-42aa-9467-eb9bc2a9e90c@github.com>
References: <CTbRheJJ9yn-OaBNP3gBAhiEfSCS2K9nOXuyuVal9Ns=.72f8155d-78b0-4ec7-93f5-9457b235a205@github.com>
 <3V52jpktdb-W7pezzS8zWsRhH6tvVAaPcORlb7P-55k=.e5d20f00-8e57-42aa-9467-eb9bc2a9e90c@github.com>
Message-ID: <Y_Z1hwO5L7YrOP2VYTduh387CL2kOaxEXyp6iecvYEU=.8f3b158a-b841-40a2-ae43-8f9e3d6047ca@github.com>

On Mon, 4 Mar 2024 18:10:04 GMT, Phil Race <prr at openjdk.org> wrote:

> And capitalise "We", and "In" since they begin sentences

I agree, yet it's not always followed in the comments.

> If we are going to fix that, we might as well fix the entire sentence.

Thank you for your suggestion. The sentence didn't sound right to me. Yet I couldn't figure out the better way to phrase it even though I tried re-writing it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18067#discussion_r1513061245

From mark.yagnatinsky at barclays.com  Tue Mar  5 16:48:48 2024
From: mark.yagnatinsky at barclays.com (mark.yagnatinsky at barclays.com)
Date: Tue, 5 Mar 2024 16:48:48 +0000
Subject: how to get find out the keyboard shortcut for the paste action?
In-Reply-To: <8399c796-17e8-4d78-9916-a55054251420@oracle.com>
References: <CH3PR12MB76198C4F8B2300D806EDCCF0F9452@CH3PR12MB7619.namprd12.prod.outlook.com>
 <em455be664-76d1-43e4-ba85-729678b34dc6@76ca4640.com>
 <CH3PR12MB7619B0682852C7C836096E84F95C2@CH3PR12MB7619.namprd12.prod.outlook.com>
 <CH3PR12MB76199D23AB541CB4C09118AAF95C2@CH3PR12MB7619.namprd12.prod.outlook.com>
 <emfa5db32b-c08c-4ebc-a061-fc24306fbe93@dcff66fe.com>
 <CH3PR12MB76196E29050B67CD2888B8AEF9232@CH3PR12MB7619.namprd12.prod.outlook.com>
 <8399c796-17e8-4d78-9916-a55054251420@oracle.com>
Message-ID: <CH3PR12MB7619083DF388D7365B84BB56F9222@CH3PR12MB7619.namprd12.prod.outlook.com>

Thanks, this was educational.  I never even thought about how localization might affect all this.

-----Original Message-----
From: Aleksei Ivanov <alexey.ivanov at oracle.com> 
Sent: Tuesday, March 5, 2024 10:41 AM
To: Yagnatinsky, Mark : Markets Pre Trade <mark.yagnatinsky at barclays.com>; mickleness at gmail.com; client-libs-dev at openjdk.org
Subject: Re: how to get find out the keyboard shortcut for the paste action?


CAUTION: This email originated from outside our organisation - alexey.ivanov at oracle.com Do not click on links, open attachments, or respond unless you recognize the sender and can validate the content is safe.
Hello Mark,

As far as I know, the shortcuts are localisable. For example, you use
Ctrl+S to save a file in an English version, yet users of Spanish
version of Windows use Ctrl+G (for Guardar) instead.

At the same time, the most common actions ? Cut, Copy and Paste as well as Undo and Redo ? usually have the same shortcuts across all languages and OS, although macOS uses Cmd instead of Ctrl. However, the shortcut for Redo is not as standard, Ctrl+Shift+Z and Ctrl+Y are used, both could be mapped at the same time.

I wonder what is the shortcut for Undo in German versions since German keyboard layout has Z and Y keys swapped. Does anyone know?

So, the shortcuts used in an application are controlled by the application and the shortcuts can be localised.

For this reason, the shortcuts are usually ?hardcoded?.


@Jeremy
Does the input map of JTextArea contain shortcuts for Cut, Copy and Paste?

On 2024-03-04 20:42, mark.yagnatinsky at barclays.com wrote:
>
> Thanks!? I don?t have a particularly deep motivation here, other than 
> curiosity.
>
> If you?re wondering how my curiosity got piqued initially, it was 
> something like this:
>
> A while ago, someone at work was adding copy/paste support to some 
> component that didn?t have it.
>
> I noticed that they ?hardcoded? the shortcut ?ctrl C?.
>
> And I thought to myself:
>
> Swing already ?knows? that this is the right keyboard shortcut, in the 
> sense that all components that support copy/paste ?out of the box? use it.
>
> It would be nice if there was some way to ASK it to tell me what it 
> ?knows?.
>
> *From:* Jeremy Wood <mickleness at gmail.com>
> *Sent:* Sunday, March 3, 2024 11:30 PM
> *To:* Yagnatinsky, Mark : Markets Pre Trade 
> <mark.yagnatinsky at barclays.com>; client-libs-dev at openjdk.org
> *Subject:* Re[2]: how to get find out the keyboard shortcut for the 
> paste action?
>
> CAUTION: This email originated from outside our organisation - 
> mickleness at gmail.com Do not click on links, open attachments, or 
> respond unless you recognize the sender and can validate the content 
> is safe.
>
> >?But now I have a new question?
>
> > Is there any way to get the ?usual? letter for a ?common? operation?
>
> Hmm. Good question. Not that I know of.
>
> > Again, one could create a scratch text area and grovel through its
> input map, but that seems hacky.
>
> I agree sifting through the L&F seems hacky.
>
> I don?t think I understand exactly what you?re trying to implement 
> here. If you give me a more concrete example: maybe I (or someone on 
> this list) can offer a more concrete suggestion?
>
> I?ll add some context in case this speaks to your question.
>
> By default Swing gets this information in places like 
> BasicTextUI#getInputMap(), which calls:
>
> InputMap shared= ??? (InputMap)DefaultLookup./get/(editor, this, ??? 
> getPropertyPrefix() + ".focusInputMap?);
>
> The following works on my Mac & Windows machine (I think using JDK 
> 19), but I wouldn?t be surprised if it fails in other platforms / 
> L&F?s. It feels brittle, but it might (?) have potential:
>
> private KeyStroke getCopyKeyStroke() {
>
> InputMap inputMap = (InputMap)
> UIManager.getDefaults().get("TextField.focusInputMap"); for (KeyStroke 
> keyStroke : inputMap.keys()) { Object action = 
> inputMap.get(keyStroke); if ("copy-to-clipboard".equals(action)) { 
> return keyStroke; ??????? } ??? } /// this will show all the default 
> keystrokes // System.out.println(Arrays.asList(inputMap.allKeys())); 
> /return null; }
>
> Regards,
>
> ?- Jeremy
>
> ------ Original Message ------
>
> From mark.yagnatinsky at barclays.com
>
> To mickleness at gmail.com; client-libs-dev at openjdk.org
>
> Date 3/3/24, 6:00:46?PM
>
> Subject RE: how to get find out the keyboard shortcut for the paste 
> action?
>
>     Thanks for the response!? I didn?t expect to get one at this point 
> J
>
>     It does indeed answer my question!
>
>     (Though you didn?t quite get the name right: there?s no Ex at the 
> end?
>
>     I take it you?ve done some Windows programming at some point)
>
>     But now I have a new question?
>
>     Is there any way to get the ?usual? letter for a ?common? operation?
>
>     For instance, lots of programs support copy and paste.
>
>     Is there a way to ask Java ?what is the standard letter for paste?
>     and get back ?V??
>
>     Again, one could create a scratch text area and grovel through its
>     input map, but that seems hacky.
>
--
Regards,
Alexey

This message is for information purposes only. It is not a recommendation, advice, offer or solicitation to buy or sell a product or service, nor an official confirmation of any transaction. It is directed at persons who are professionals and is intended for the recipient(s) only. It is not directed at retail customers. This message is subject to the terms at: https://www.ib.barclays/disclosures/web-and-email-disclaimer.html. 

For important disclosures, please see: https://www.ib.barclays/disclosures/sales-and-trading-disclaimer.html regarding marketing commentary from Barclays Sales and/or Trading desks, who are active market participants; https://www.ib.barclays/disclosures/barclays-global-markets-disclosures.html regarding our standard terms for Barclays Investment Bank where we trade with you in principal-to-principal wholesale markets transactions; and in respect to Barclays Research, including disclosures relating to specific issuers, see: http://publicresearch.barclays.com.
__________________________________________________________________________________ 
If you are incorporated or operating in Australia, read these important disclosures: https://www.ib.barclays/disclosures/important-disclosures-asia-pacific.html.
__________________________________________________________________________________
For more details about how we use personal information, see our privacy notice: https://www.ib.barclays/disclosures/personal-information-use.html. 
__________________________________________________________________________________

From aivanov at openjdk.org  Tue Mar  5 17:07:02 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 5 Mar 2024 17:07:02 GMT
Subject: RFR: 8305072: Win32ShellFolder2.compareTo is inconsistent
Message-ID: <bEiHvkFnBZDqmiqQdk_-_mATVhDbAD7NZX7VnkHLG2E=.27ee84ba-00fd-405a-9489-8fe11c215af9@github.com>

The implementation of `Win32ShellFolder2.compareTo` is inconsistent: there are cases where  
`a < b & b < c but a == c`  
which *violates its general contract*.

In particular, it happens for the personal folder (*Documents*) if it is listed *twice*: as a special and as a regular folder.

The evaluation performed by the submitter of the bug provided enough details to create a test, reproduce the problem and finally resolve it.

Without the fix, the regression test always fails:

a < b & b < c but a >= c
where
  a = C:\Users<user>\Documents(true)
  b = C:\Users<user>(false)
  c = C:\Users<user>\Documents(false)

as well as for the reverse case: `a > b & b > c`.

How it is possible to have the same folder in a list of files twice remains unknown. I believe it is another bug in JDK, however, no one has been able to reproduce it so far.

-------------

Commit messages:
 - 8305072: Fix Win32ShellFolder2.compareTo
 - 8305072: Add test case for Win32ShellFolder2.compareTo

Changes: https://git.openjdk.org/jdk/pull/18126/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18126&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8305072
  Stats: 156 lines in 2 files changed: 154 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/18126.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18126/head:pull/18126

PR: https://git.openjdk.org/jdk/pull/18126

From aivanov at openjdk.org  Tue Mar  5 17:40:01 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 5 Mar 2024 17:40:01 GMT
Subject: RFR: 8305072: Win32ShellFolder2.compareTo is inconsistent [v2]
In-Reply-To: <bEiHvkFnBZDqmiqQdk_-_mATVhDbAD7NZX7VnkHLG2E=.27ee84ba-00fd-405a-9489-8fe11c215af9@github.com>
References: <bEiHvkFnBZDqmiqQdk_-_mATVhDbAD7NZX7VnkHLG2E=.27ee84ba-00fd-405a-9489-8fe11c215af9@github.com>
Message-ID: <21db5CiFTVN7scwsIHknMxF4YaVQd06m7gUOhcCLvMI=.e2f61ea7-bf9a-4632-bf45-c89f979ae806@github.com>

> The implementation of `Win32ShellFolder2.compareTo` is inconsistent: there are cases where  
> `a < b & b < c but a == c`  
> which *violates its general contract*.
> 
> In particular, it happens for the personal folder (*Documents*) if it is listed *twice*: as a special and as a regular folder.
> 
> The evaluation performed by the submitter of the bug provided enough details to create a test, reproduce the problem and finally resolve it.
> 
> Without the fix, the regression test always fails:
> 
> a < b & b < c but a >= c
> where
>   a = C:\Users<user>\Documents(true)
>   b = C:\Users<user>(false)
>   c = C:\Users<user>\Documents(false)
> 
> as well as for the reverse case: `a > b & b > c`.
> 
> How it is possible to have the same folder in a list of files twice remains unknown. I believe it is another bug in JDK, however, no one has been able to reproduce it so far.

Alexey Ivanov has updated the pull request incrementally with one additional commit since the last revision:

  Handle fakePersonal on Windows 10
  
  The desktop folder on Windows 10 does not include
  the Personal (Documents) folder.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18126/files
  - new: https://git.openjdk.org/jdk/pull/18126/files/7c442382..7bccc847

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18126&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18126&range=00-01

  Stats: 4 lines in 1 file changed: 4 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18126.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18126/head:pull/18126

PR: https://git.openjdk.org/jdk/pull/18126

From aivanov at openjdk.org  Tue Mar  5 18:22:55 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 5 Mar 2024 18:22:55 GMT
Subject: RFR: 8185862: AWT Assertion Failure in ::GetDIBits(hBMDC, hBM, 0, 
 1, 0, gpBitmapInfo, 0) 'awt_Win32GraphicsDevice.cpp', at line 185 [v2]
In-Reply-To: <HtDXNTnHYyrG3rPIaAumR3VnleSlWGKwuN3YjFLApo4=.3d41e0ca-11a3-48b8-ade5-867a3fd544ec@github.com>
References: <Cj_htOZE6ImXdNmj43IBiX7rW4Em4ZF-6kx0qIZW-Ho=.d355fedd-7ec8-463d-969b-e2123987d1dd@github.com>
 <Ptki9SnXavWUHVBaFKxqMJAzNH1Ec8CB4cr9ezJFwxA=.60a8b98b-0d1e-4f8c-bf1a-55908aaedf19@github.com>
 <4jmx37LJU3WWe70P4sSyCBtDgU_iGbJj8q4qMiB9GmQ=.7efffac2-f074-44d4-ae21-e088725ce756@github.com>
 <HtDXNTnHYyrG3rPIaAumR3VnleSlWGKwuN3YjFLApo4=.3d41e0ca-11a3-48b8-ade5-867a3fd544ec@github.com>
Message-ID: <DUfeeaOAaZnEKeqT81SxKj86s57M-b3Ioqggj1lijs8=.6f888fc7-fd6d-4df9-9a75-bca8d4429b4f@github.com>

On Fri, 16 Feb 2024 08:45:59 GMT, Christoph Langer <clanger at openjdk.org> wrote:

>> src/java.desktop/windows/native/libawt/windows/awt_Win32GraphicsDevice.cpp line 191:
>> 
>>> 189:         return;
>>> 190:     }
>>> 191:     VERIFY(::GetDIBits(hBMDC, hBM, 0, 1, NULL, gpBitmapInfo, DIB_RGB_COLORS));
>> 
>> I think the return value of `::GetDIBits` should also be analysed explicitly.
>> 
>> I would prefer backing out if any of the functions above including `::GetDIBits` returns an error.
>> 
>> Yet I'm not sure how critical it is to run the code below. [As I mentioned](https://github.com/openjdk/jdk/pull/17197#issuecomment-1875562325) in PR #17197, there's a workaround for a case where `::GetDIBits` returns 0. @MBaesken implemented a fallback to run the code below if even if all the above calls fail. It may be safe to ignore ? in headless environment.
>
> Hm, I added some code for verification of ::GetDIBits result. If it is 0, I skip the rest of the coding. I don't want to touch more here since I don't understand what it is doing.

It is not what I meant? If we want to preserve the way it work, we should execute the below code even if `this->GetDC()` fails?

On the other hand, testing didn't find any problems, in which case I prefer bailing out after `::GetDIBits` fails too.

@prrace, Do you know how critical the code below is? Is it worth to code the fallback if the path to `::GetDIBits`?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17614#discussion_r1513292270

From aivanov at openjdk.org  Tue Mar  5 18:22:55 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 5 Mar 2024 18:22:55 GMT
Subject: RFR: 8185862: AWT Assertion Failure in ::GetDIBits(hBMDC, hBM, 0, 
 1, 0, gpBitmapInfo, 0) 'awt_Win32GraphicsDevice.cpp', at line 185 [v8]
In-Reply-To: <yLFbIvVt-ZuGKMVJvXx19rUxVgG1-ewJwM5SAEzoUvo=.15df7df6-0c62-4c60-837c-33fdf90eab11@github.com>
References: <Cj_htOZE6ImXdNmj43IBiX7rW4Em4ZF-6kx0qIZW-Ho=.d355fedd-7ec8-463d-969b-e2123987d1dd@github.com>
 <yLFbIvVt-ZuGKMVJvXx19rUxVgG1-ewJwM5SAEzoUvo=.15df7df6-0c62-4c60-837c-33fdf90eab11@github.com>
Message-ID: <cHpGX06SvmwmJasYHGMOITL9-56HUoOeNEJQDPOw8E4=.1ab5aabb-7d6c-465a-bda9-5ae8cc232669@github.com>

On Fri, 1 Mar 2024 08:01:08 GMT, Christoph Langer <clanger at openjdk.org> wrote:

>> The assertions reported in the bug were observed spuriously and here and there broke tests in some Windows configurations.
>> For instance [JDK-8266129](https://bugs.openjdk.org/browse/JDK-8266129), [JDK-8269529](https://bugs.openjdk.org/browse/JDK-8269529) or [JDK-8323664](https://bugs.openjdk.org/browse/JDK-8323664) came up due to this.
>> 
>> The problem is that in Windows environments without a valid display, e.g. started by system services or via PowerShell Remoting, one sees a Monitor with name 'Windisc' in `EnumDisplayMonitors`.
>> However, it seems to be some kind of a pseudo device where you can not get a DC via `CreateDC`. This behavior/monitor type doesn't seem to be well documented, though.
>> 
>> I hereby modify the device initialization code to only count/detect monitors where CreateDC returns non-NULL in Devices.cpp. I also add some more checking/error handling to AwtWin32GraphicsDevice::Initialize() for correctness.
>> 
>> Furthermore, I re-enable the test `javax/swing/reliability/HangDuringStaticInitialization.java` for Windows Debug VMs, which reverts the fix from JDK-8269529 that should not be necessary any more.
>
> Christoph Langer has updated the pull request incrementally with one additional commit since the last revision:
> 
>   load awt.dll before display check

It looks good to me.

The only question I have is for the fallback in `awt_Win32GraphicsDevice.cpp`.

Bailing out quickly makes the code cleaner. In this case, if `::GetDIBits` fails, we can bail out too.

If the fallback is needed, the code below the first call to `::GetDIBits` should be executed even if `GetDC` and `CreateCompatibleBitmap` fail.

Since testing didn't reveal any problems, the fallback is probably not as important, or not critical for a headless system.

src/java.desktop/windows/classes/sun/awt/PlatformGraphicsInfo.java line 35:

> 33: public class PlatformGraphicsInfo {
> 34: 
> 35:     private static boolean hasDisplays;

I believe it can be declared `final`, it's initialised in the static initialiser that follows the declaration.
Suggestion:

    private static final boolean hasDisplays;

src/java.desktop/windows/classes/sun/awt/PlatformGraphicsInfo.java line 38:

> 36: 
> 37:     static {
> 38:         loadAWTLibrary();

Can `WToolkit.loadLibraries()` be used here? The method is declared public, so it should be accessible.

It may create a circular dependency though.

-------------

PR Review: https://git.openjdk.org/jdk/pull/17614#pullrequestreview-1917750109
PR Review Comment: https://git.openjdk.org/jdk/pull/17614#discussion_r1513269942
PR Review Comment: https://git.openjdk.org/jdk/pull/17614#discussion_r1513267417

From rkannathpari at openjdk.org  Wed Mar  6 05:08:08 2024
From: rkannathpari at openjdk.org (Renjith Kannath Pariyangad)
Date: Wed, 6 Mar 2024 05:08:08 GMT
Subject: RFR: 8320676 : Manual printer tests have no Pass/Fail buttons,
 instructions close set 1 [v12]
In-Reply-To: <Afd90FypFvXYNR17jgkxcFj2LlxdLlZ1Bgd7WctdKcU=.2a8b05e0-a476-4598-8524-a22a0f54b8a5@github.com>
References: <Afd90FypFvXYNR17jgkxcFj2LlxdLlZ1Bgd7WctdKcU=.2a8b05e0-a476-4598-8524-a22a0f54b8a5@github.com>
Message-ID: <_-LKuql5zt3ZU24gZkc_06GN7xgqbIKl2ZHSP-HAbdg=.3bcdddfb-7f8a-4d8f-9ba8-35dffb9e10ee@github.com>

> Hi Reviewers,
> 
> Updated manual printer test cases with 'PassFailJFrame', also removed unused variables. Added 'SkippedException' in case of printer missing or not configured.
> 
> Please review and let me know your suggestions.
> 
> Regards,
> Renjith

Renjith Kannath Pariyangad has updated the pull request incrementally with one additional commit since the last revision:

  Added Override

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/17607/files
  - new: https://git.openjdk.org/jdk/pull/17607/files/10c2c695..8cb1d7d4

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=17607&range=11
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17607&range=10-11

  Stats: 36 lines in 5 files changed: 8 ins; 19 del; 9 mod
  Patch: https://git.openjdk.org/jdk/pull/17607.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17607/head:pull/17607

PR: https://git.openjdk.org/jdk/pull/17607

From abhiscxk at openjdk.org  Wed Mar  6 05:32:52 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Wed, 6 Mar 2024 05:32:52 GMT
Subject: Integrated: 8326458: Menu mnemonics don't toggle in Windows LAF when
 F10 is pressed
In-Reply-To: <uv53ohrzj-j8wA3SHr7M0b5V-Ja9HvKGBa2RgWTwoSU=.abf8c336-4b24-479c-af6d-22acb686ed80@github.com>
References: <uv53ohrzj-j8wA3SHr7M0b5V-Ja9HvKGBa2RgWTwoSU=.abf8c336-4b24-479c-af6d-22acb686ed80@github.com>
Message-ID: <zsFcmni0n5zPCQ6mK8gx4kZhBkJ31WRXrYAlNcNQVHg=.9bdca0bf-84a4-4c37-8a5c-90504c64da76@github.com>

On Thu, 22 Feb 2024 11:11:01 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

> Menu mnemonic doesn't toggle between show and hide state when F10 is pressed. Behavior is not similar to windows native application. Fix is to ensure that menu mnemonic state toggles between show and hide.
> 
> Can be verified with SwingSet2 application. 
> CI tests are green with the fix. Link posted in JBS.

This pull request has now been integrated.

Changeset: 96bfe613
Author:    Abhishek Kumar <abhiscxk at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/96bfe613c31f890bc4bbe989c5348ad11c070bf6
Stats:     143 lines in 2 files changed: 135 ins; 0 del; 8 mod

8326458: Menu mnemonics don't toggle in Windows LAF when F10 is pressed

Reviewed-by: psadhukhan, aivanov

-------------

PR: https://git.openjdk.org/jdk/pull/17961

From rkannathpari at openjdk.org  Wed Mar  6 06:09:52 2024
From: rkannathpari at openjdk.org (Renjith Kannath Pariyangad)
Date: Wed, 6 Mar 2024 06:09:52 GMT
Subject: RFR: 8324807 : Manual printer tests have no Pass/Fail buttons,
 instructions close set 2 [v10]
In-Reply-To: <-3Z3D3ZejKBGJxG_3x26fcoUx2MzUa4vQejYWFRo1-I=.29bf2730-c42a-4f37-a4ad-b14ca74fc025@github.com>
References: <UZ9jtQbkj-MoeLoccJnd2_3ciCCy9n-CD5vDv0hVKME=.f67db96d-92e6-46a1-9bb6-4fe77c9a8c4e@github.com>
 <3EjlqyLzNCZxo6F1YSOs2zRrNxO5QTIQxkuY27Y3Ro4=.f13abdf7-f15f-44fc-9068-15f3ccda0958@github.com>
 <-3Z3D3ZejKBGJxG_3x26fcoUx2MzUa4vQejYWFRo1-I=.29bf2730-c42a-4f37-a4ad-b14ca74fc025@github.com>
Message-ID: <zS4DvXH14pqpMTUycxOwB5bmfc-S4ifCFjyA3nlWFLU=.a35ed1f4-7ef5-42a9-957d-8f6ee11539f9@github.com>

On Tue, 5 Mar 2024 13:07:30 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Renjith Kannath Pariyangad has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Updated instruction
>
> test/jdk/java/awt/print/PrinterJob/Collate2DPrintingTest.java line 74:
> 
>> 72:                 if (pj.printDialog(prSet)) {
>> 73:                     pj.print(prSet);
>> 74:                 }
> 
> In this case, the print dialog has *Collated* checked and disabled; the number of copies is set to 1 and I can't change the value.
> 
> Does it work for you? Is it a bug in JDK?

For print to pdf, yes not able to change number of copies, but for actual printer able to change the number.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17608#discussion_r1513869975

From rkannathpari at openjdk.org  Wed Mar  6 06:29:03 2024
From: rkannathpari at openjdk.org (Renjith Kannath Pariyangad)
Date: Wed, 6 Mar 2024 06:29:03 GMT
Subject: RFR: 8324807 : Manual printer tests have no Pass/Fail buttons,
 instructions close set 2 [v11]
In-Reply-To: <UZ9jtQbkj-MoeLoccJnd2_3ciCCy9n-CD5vDv0hVKME=.f67db96d-92e6-46a1-9bb6-4fe77c9a8c4e@github.com>
References: <UZ9jtQbkj-MoeLoccJnd2_3ciCCy9n-CD5vDv0hVKME=.f67db96d-92e6-46a1-9bb6-4fe77c9a8c4e@github.com>
Message-ID: <x6Co4cpdAPaGf3tts9RyBCldzQZ2D_wv1JsbNSNgBzo=.5387e39f-3994-4d65-89a5-d0530648665a@github.com>

> Hi Reviewers,
> 
> Updated manual printer test cases with 'PassFailJFrame', also removed unused variables. Added 'SkippedException' in case of printer missing or not configured.
> 
> Please review and let me know your suggestions.
> 
> Regards,
> Renjith

Renjith Kannath Pariyangad has updated the pull request incrementally with one additional commit since the last revision:

  Added Override

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/17608/files
  - new: https://git.openjdk.org/jdk/pull/17608/files/a9aebeb8..bec0332e

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=17608&range=10
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17608&range=09-10

  Stats: 16 lines in 4 files changed: 10 ins; 2 del; 4 mod
  Patch: https://git.openjdk.org/jdk/pull/17608.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17608/head:pull/17608

PR: https://git.openjdk.org/jdk/pull/17608

From rkannathpari at openjdk.org  Wed Mar  6 06:57:12 2024
From: rkannathpari at openjdk.org (Renjith Kannath Pariyangad)
Date: Wed, 6 Mar 2024 06:57:12 GMT
Subject: RFR: 8324808 : Manual printer tests have no Pass/Fail buttons,
 instructions close set 3 [v10]
In-Reply-To: <BFuAfPibaBpToXKzPNGUKf6pC1DvjrAedYHdtJxtuO8=.d54fcf6c-0727-4a4e-8a94-73a4ebe78af4@github.com>
References: <BFuAfPibaBpToXKzPNGUKf6pC1DvjrAedYHdtJxtuO8=.d54fcf6c-0727-4a4e-8a94-73a4ebe78af4@github.com>
Message-ID: <eb7CRD0sxP_6XlxjmTul27MXTVs-jX_ICXl8taKI5pc=.305f269e-4179-41ea-a451-3425b96e043e@github.com>

> Hi Reviewers,
> 
> Updated manual printer test cases with 'PassFailJFrame', also removed unused variables. Added 'SkippedException' in case of printer missing or not configured.
> 
> Please review and let me know your suggestions.
> 
> Regards,
> Renjith

Renjith Kannath Pariyangad has updated the pull request incrementally with one additional commit since the last revision:

  Added Override

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/17609/files
  - new: https://git.openjdk.org/jdk/pull/17609/files/b2b8548d..df3831c8

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=17609&range=09
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17609&range=08-09

  Stats: 24 lines in 5 files changed: 9 ins; 7 del; 8 mod
  Patch: https://git.openjdk.org/jdk/pull/17609.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17609/head:pull/17609

PR: https://git.openjdk.org/jdk/pull/17609

From clanger at openjdk.org  Wed Mar  6 07:50:08 2024
From: clanger at openjdk.org (Christoph Langer)
Date: Wed, 6 Mar 2024 07:50:08 GMT
Subject: RFR: 8185862: AWT Assertion Failure in ::GetDIBits(hBMDC, hBM, 0, 
 1, 0, gpBitmapInfo, 0) 'awt_Win32GraphicsDevice.cpp', at line 185 [v9]
In-Reply-To: <Cj_htOZE6ImXdNmj43IBiX7rW4Em4ZF-6kx0qIZW-Ho=.d355fedd-7ec8-463d-969b-e2123987d1dd@github.com>
References: <Cj_htOZE6ImXdNmj43IBiX7rW4Em4ZF-6kx0qIZW-Ho=.d355fedd-7ec8-463d-969b-e2123987d1dd@github.com>
Message-ID: <CKYPyukEqiyrhtxwu-wmU6m9orRi5dekY1qQPJ5JRa0=.e9385f22-34b9-451a-b9aa-cfeb2a9fd5f3@github.com>

> The assertions reported in the bug were observed spuriously and here and there broke tests in some Windows configurations.
> For instance [JDK-8266129](https://bugs.openjdk.org/browse/JDK-8266129), [JDK-8269529](https://bugs.openjdk.org/browse/JDK-8269529) or [JDK-8323664](https://bugs.openjdk.org/browse/JDK-8323664) came up due to this.
> 
> The problem is that in Windows environments without a valid display, e.g. started by system services or via PowerShell Remoting, one sees a Monitor with name 'Windisc' in `EnumDisplayMonitors`.
> However, it seems to be some kind of a pseudo device where you can not get a DC via `CreateDC`. This behavior/monitor type doesn't seem to be well documented, though.
> 
> I hereby modify the device initialization code to only count/detect monitors where CreateDC returns non-NULL in Devices.cpp. I also add some more checking/error handling to AwtWin32GraphicsDevice::Initialize() for correctness.
> 
> Furthermore, I re-enable the test `javax/swing/reliability/HangDuringStaticInitialization.java` for Windows Debug VMs, which reverts the fix from JDK-8269529 that should not be necessary any more.

Christoph Langer has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 14 additional commits since the last revision:

 - declare variable hasDisplays final
 - Merge branch 'master' into JDK-8185862
 - load awt.dll before display check
 - Change implementation of headless determination on Windows
 - Merge branch 'master' into JDK-8185862
 - Reflect display detection in java.awt.GraphicsEnvironment::isHeadless()
 - Merge branch 'master' into JDK-8185862
 - Get rid of global variables and restore old handling wrt calling ::GetDIBits
 - Merge branch 'master' into JDK-8185862
 - Little cleanup
 - ... and 4 more: https://git.openjdk.org/jdk/compare/5cf9714c...002fba2d

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/17614/files
  - new: https://git.openjdk.org/jdk/pull/17614/files/7a00a647..002fba2d

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=17614&range=08
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17614&range=07-08

  Stats: 4039 lines in 155 files changed: 2329 ins; 1055 del; 655 mod
  Patch: https://git.openjdk.org/jdk/pull/17614.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17614/head:pull/17614

PR: https://git.openjdk.org/jdk/pull/17614

From clanger at openjdk.org  Wed Mar  6 07:50:08 2024
From: clanger at openjdk.org (Christoph Langer)
Date: Wed, 6 Mar 2024 07:50:08 GMT
Subject: RFR: 8185862: AWT Assertion Failure in ::GetDIBits(hBMDC, hBM, 0, 
 1, 0, gpBitmapInfo, 0) 'awt_Win32GraphicsDevice.cpp', at line 185 [v8]
In-Reply-To: <cHpGX06SvmwmJasYHGMOITL9-56HUoOeNEJQDPOw8E4=.1ab5aabb-7d6c-465a-bda9-5ae8cc232669@github.com>
References: <Cj_htOZE6ImXdNmj43IBiX7rW4Em4ZF-6kx0qIZW-Ho=.d355fedd-7ec8-463d-969b-e2123987d1dd@github.com>
 <yLFbIvVt-ZuGKMVJvXx19rUxVgG1-ewJwM5SAEzoUvo=.15df7df6-0c62-4c60-837c-33fdf90eab11@github.com>
 <cHpGX06SvmwmJasYHGMOITL9-56HUoOeNEJQDPOw8E4=.1ab5aabb-7d6c-465a-bda9-5ae8cc232669@github.com>
Message-ID: <XVmwysBgafPaDip8GbTyMNd-AHnCeAYVPO3TwHFx34Y=.a0e5b742-f28d-4677-8c75-6b6bef2d8845@github.com>

On Tue, 5 Mar 2024 18:00:51 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Christoph Langer has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   load awt.dll before display check
>
> src/java.desktop/windows/classes/sun/awt/PlatformGraphicsInfo.java line 35:
> 
>> 33: public class PlatformGraphicsInfo {
>> 34: 
>> 35:     private static boolean hasDisplays;
> 
> I believe it can be declared `final`, it's initialised in the static initialiser that follows the declaration.
> Suggestion:
> 
>     private static final boolean hasDisplays;

Good catch. I updated it.

> src/java.desktop/windows/classes/sun/awt/PlatformGraphicsInfo.java line 38:
> 
>> 36: 
>> 37:     static {
>> 38:         loadAWTLibrary();
> 
> Can `WToolkit.loadLibraries()` be used here? The method is declared public, so it should be accessible.
> 
> It may create a circular dependency though.

Maybe. I think, as Phil already mentions, a cleanup/centralization of the places that load libawt should be done. But I would suggest to do this in a separate issue.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17614#discussion_r1513974122
PR Review Comment: https://git.openjdk.org/jdk/pull/17614#discussion_r1513973885

From clanger at openjdk.org  Wed Mar  6 07:52:50 2024
From: clanger at openjdk.org (Christoph Langer)
Date: Wed, 6 Mar 2024 07:52:50 GMT
Subject: RFR: 8185862: AWT Assertion Failure in ::GetDIBits(hBMDC, hBM, 0, 
 1, 0, gpBitmapInfo, 0) 'awt_Win32GraphicsDevice.cpp', at line 185 [v9]
In-Reply-To: <CKYPyukEqiyrhtxwu-wmU6m9orRi5dekY1qQPJ5JRa0=.e9385f22-34b9-451a-b9aa-cfeb2a9fd5f3@github.com>
References: <Cj_htOZE6ImXdNmj43IBiX7rW4Em4ZF-6kx0qIZW-Ho=.d355fedd-7ec8-463d-969b-e2123987d1dd@github.com>
 <CKYPyukEqiyrhtxwu-wmU6m9orRi5dekY1qQPJ5JRa0=.e9385f22-34b9-451a-b9aa-cfeb2a9fd5f3@github.com>
Message-ID: <l_C_WhlpEwKBiJgoADRHOmK5EEcrPLoygFY0ygr1WD8=.7e0ea083-e2fd-4e11-9eed-6ce6edea61c6@github.com>

On Wed, 6 Mar 2024 07:50:08 GMT, Christoph Langer <clanger at openjdk.org> wrote:

>> The assertions reported in the bug were observed spuriously and here and there broke tests in some Windows configurations.
>> For instance [JDK-8266129](https://bugs.openjdk.org/browse/JDK-8266129), [JDK-8269529](https://bugs.openjdk.org/browse/JDK-8269529) or [JDK-8323664](https://bugs.openjdk.org/browse/JDK-8323664) came up due to this.
>> 
>> The problem is that in Windows environments without a valid display, e.g. started by system services or via PowerShell Remoting, one sees a Monitor with name 'Windisc' in `EnumDisplayMonitors`.
>> However, it seems to be some kind of a pseudo device where you can not get a DC via `CreateDC`. This behavior/monitor type doesn't seem to be well documented, though.
>> 
>> I hereby modify the device initialization code to only count/detect monitors where CreateDC returns non-NULL in Devices.cpp. I also add some more checking/error handling to AwtWin32GraphicsDevice::Initialize() for correctness.
>> 
>> Furthermore, I re-enable the test `javax/swing/reliability/HangDuringStaticInitialization.java` for Windows Debug VMs, which reverts the fix from JDK-8269529 that should not be necessary any more.
>
> Christoph Langer has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 14 additional commits since the last revision:
> 
>  - declare variable hasDisplays final
>  - Merge branch 'master' into JDK-8185862
>  - load awt.dll before display check
>  - Change implementation of headless determination on Windows
>  - Merge branch 'master' into JDK-8185862
>  - Reflect display detection in java.awt.GraphicsEnvironment::isHeadless()
>  - Merge branch 'master' into JDK-8185862
>  - Get rid of global variables and restore old handling wrt calling ::GetDIBits
>  - Merge branch 'master' into JDK-8185862
>  - Little cleanup
>  - ... and 4 more: https://git.openjdk.org/jdk/compare/7f595d03...002fba2d

> This now passes all my automated testing. Have you tested manual apps like SwingSet ? I doubt they'll have a problem but it would be good to be 100% sure.
> 
> The only thing I notice here is it adds one more place that we duplicate the code to load the AWT native library. Bizarrely Toolkit _and_ WToolkit both do it. The result is not just duplicated code but duplicated (now triplicated) effort at startup. There might even be a fourth place - NativeLibLoader. But fixing that might mean being extra careful about not introducing circularities at start up and since the impact should be negligible I think it is out of scope for this fix.
> 
> So just let me know about the manual testing.

I ran all of test/jdk/sanity/client/SwingSet now and everything passed. So from my end this should be ready.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17614#issuecomment-1980272271

From clanger at openjdk.org  Wed Mar  6 07:52:48 2024
From: clanger at openjdk.org (Christoph Langer)
Date: Wed, 6 Mar 2024 07:52:48 GMT
Subject: RFR: 8185862: AWT Assertion Failure in ::GetDIBits(hBMDC, hBM, 0, 
 1, 0, gpBitmapInfo, 0) 'awt_Win32GraphicsDevice.cpp', at line 185 [v8]
In-Reply-To: <cHpGX06SvmwmJasYHGMOITL9-56HUoOeNEJQDPOw8E4=.1ab5aabb-7d6c-465a-bda9-5ae8cc232669@github.com>
References: <Cj_htOZE6ImXdNmj43IBiX7rW4Em4ZF-6kx0qIZW-Ho=.d355fedd-7ec8-463d-969b-e2123987d1dd@github.com>
 <yLFbIvVt-ZuGKMVJvXx19rUxVgG1-ewJwM5SAEzoUvo=.15df7df6-0c62-4c60-837c-33fdf90eab11@github.com>
 <cHpGX06SvmwmJasYHGMOITL9-56HUoOeNEJQDPOw8E4=.1ab5aabb-7d6c-465a-bda9-5ae8cc232669@github.com>
Message-ID: <VWpIOVnSQcdADE5bvLDIVfssDgA_2JcgICRlCGpO2bY=.1861dbb3-2bfc-4fc4-a9ba-8ed942380a9d@github.com>

On Tue, 5 Mar 2024 18:20:39 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> It looks good to me.
> 
> The only question I have is for the fallback in `awt_Win32GraphicsDevice.cpp`.
> 
> Bailing out quickly makes the code cleaner. In this case, if `::GetDIBits` fails, we can bail out too.
> 
> If the fallback is needed, the code below the first call to `::GetDIBits` should be executed even if `GetDC` and `CreateCompatibleBitmap` fail.
> 
> Since testing didn't reveal any problems, the fallback is probably not as important, or not critical for a headless system.

I think the bailout is unlikely to happen after this fix. At least not for the headless environment where we won't jump into AwtWin32GraphicsDevice::Initialize() at all any more. And in headless environments with working monitors, we would never bail out, I guess. However, the method could be cleaned up I guess. But that should also be done in another issue and by somebody who is more into the details of what's going on there.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17614#issuecomment-1980271374

From psadhukhan at openjdk.org  Wed Mar  6 08:45:46 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Wed, 6 Mar 2024 08:45:46 GMT
Subject: RFR: 8075917: The regression-swing case failed as the text on
 label is not painted red with the GTK L&F [v5]
In-Reply-To: <yQTL_So5Ud-76evgwEePTvcDSxYXVy0kwN6j_mQwrc0=.12bb609a-b841-480c-9e35-4297f0de6c48@github.com>
References: <iDOTnLkAimOa5kfDerZ09n4wsYiFYYUyBflOTYeUQZ0=.293390bd-bc47-4871-bf4c-d23c191d9426@github.com>
 <5eZ7a0HiqE3hghw3sT0L0Zn4Mi1FFfofz6hLGdLOsoc=.445b16ac-4d91-4538-92ba-a74f17781535@github.com>
 <dPwYzsPLI8z4TUTMlwXFEKmddbkkjpifAqrM4b2XxeE=.ec943a1a-09b4-48ec-8ad1-bd64b936e2b2@github.com>
 <yQTL_So5Ud-76evgwEePTvcDSxYXVy0kwN6j_mQwrc0=.12bb609a-b841-480c-9e35-4297f0de6c48@github.com>
Message-ID: <vAIQHEffW4Eq54K_v5vYvLpyfEXzwG74D8wy5-syJxM=.05d14f36-f4a5-491a-b9a7-f7be14201b0c@github.com>

On Tue, 5 Mar 2024 11:06:18 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> src/java.desktop/share/classes/com/sun/java/swing/plaf/gtk/GTKStyle.java line 205:
>> 
>>> 203:     private Color getLAFDefinedColor(SynthContext context, int state,
>>> 204:                                      ColorType type, String propertyName) {
>>> 205:         Color c = (Color) get(context, propertyName);
>> 
>> I guess these condition checks should also be done inside the method since you are passing the values anyway...
>> Also, the enabled state are still not handled..If the existing testcase does not catch those, maybe we can add subtests to it..
>
>> Also, the enabled state are still not handled
> 
> The enabled state is not handled in Metal LAF also, tried adding the enabledText property by setting ui property --
> `UIManager.getDefaults().put("CheckBox.enabledText", checkboxColor);`
> 
> but the checkbox/radiobutton is painted with default black color.
> Should we handle the change in metal LAF as well?

Backtracking a bit, regarding `Label.foreground` why it needs to be done here?

Other L&F, it is added in corresponding LookAndFeel class
for example, in [Metal](https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/javax/swing/plaf/metal/MetalLookAndFeel.java#L1001)
and in [Windows](https://github.com/openjdk/jdk/blob/master/src/java.desktop/windows/classes/com/sun/java/swing/plaf/windows/WindowsLookAndFeel.java#L880)
etc
so I think it is needed to be added in GTKLookAndFeel class

and additionally there is setting of `Label.foreground` and other Label. property in BasicLabelUI.java [installDefaults](https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/javax/swing/plaf/basic/BasicLabelUI.java#L368)
but we dont do it for Nimbus or GTK or Synth so I guess we need to call `super.installDefaults(c)` in SynthLabelUI class since there is no GTKLabelUI class
or 
maybe do
`LookAndFeel.installColorsAndFont(c, "Label.background", "Label.foreground", "Label.font");` alone to avoid other properties being set and to not fallback

Please check if it will work
and if it does, then we need to employ similar for checbox/radiobutton/togglebutton

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17763#discussion_r1514050005

From aivanov at openjdk.org  Wed Mar  6 08:51:48 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Wed, 6 Mar 2024 08:51:48 GMT
Subject: RFR: 8185862: AWT Assertion Failure in ::GetDIBits(hBMDC, hBM, 0, 
 1, 0, gpBitmapInfo, 0) 'awt_Win32GraphicsDevice.cpp', at line 185 [v8]
In-Reply-To: <VWpIOVnSQcdADE5bvLDIVfssDgA_2JcgICRlCGpO2bY=.1861dbb3-2bfc-4fc4-a9ba-8ed942380a9d@github.com>
References: <Cj_htOZE6ImXdNmj43IBiX7rW4Em4ZF-6kx0qIZW-Ho=.d355fedd-7ec8-463d-969b-e2123987d1dd@github.com>
 <yLFbIvVt-ZuGKMVJvXx19rUxVgG1-ewJwM5SAEzoUvo=.15df7df6-0c62-4c60-837c-33fdf90eab11@github.com>
 <cHpGX06SvmwmJasYHGMOITL9-56HUoOeNEJQDPOw8E4=.1ab5aabb-7d6c-465a-bda9-5ae8cc232669@github.com>
 <VWpIOVnSQcdADE5bvLDIVfssDgA_2JcgICRlCGpO2bY=.1861dbb3-2bfc-4fc4-a9ba-8ed942380a9d@github.com>
Message-ID: <ubIMuslFuA6dnnzBlg8TSqNM04SKIR6lVH0WYXi_5_Q=.ad3e17c4-f46b-498d-a53c-f168974bcc6c@github.com>

On Wed, 6 Mar 2024 07:49:35 GMT, Christoph Langer <clanger at openjdk.org> wrote:

> > It looks good to me.
> > The only question I have is for the fallback in `awt_Win32GraphicsDevice.cpp`.
> > Bailing out quickly makes the code cleaner. In this case, if `::GetDIBits` fails, we can bail out too.
> > If the fallback is needed, the code below the first call to `::GetDIBits` should be executed even if `GetDC` and `CreateCompatibleBitmap` fail.
> > Since testing didn't reveal any problems, the fallback is probably not as important, or not critical for a headless system.
> 
> I think the bailout is unlikely to happen after this fix. At least not for the headless environment where we won't jump into AwtWin32GraphicsDevice::Initialize() at all any more. And in headless environments with working monitors, we would never bail out, I guess. However, the method could be cleaned up I guess. But that should also be done in another issue and by somebody who is more into the details of what's going on there.

In this case, I think you should update the code to bail out if `::GetDIBits` fails. This way we will always bail out on any failure.

https://github.com/openjdk/jdk/blob/58a404443691b90439800fb2fd0f76b41667b707/src/java.desktop/windows/native/libawt/windows/awt_Win32GraphicsDevice.cpp#L192-L198

At the moment the code is inconsistent. If this code isn't even run in headless environment, then it's better to make it consistent. Otherwise, it raises questions why it returns if either if `GetDC` or `CreateCompatibleBitmap` fails but continues if `::GetDIBits` fails.

>> src/java.desktop/windows/classes/sun/awt/PlatformGraphicsInfo.java line 38:
>> 
>>> 36: 
>>> 37:     static {
>>> 38:         loadAWTLibrary();
>> 
>> Can `WToolkit.loadLibraries()` be used here? The method is declared public, so it should be accessible.
>> 
>> It may create a circular dependency though.
>
> Maybe. I think, as Phil already mentions, a cleanup/centralization of the places that load libawt should be done. But I would suggest to do this in a separate issue.

Sounds reasonable. Will you create a CR for this? So that we won't forget about it.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17614#issuecomment-1980364103
PR Review Comment: https://git.openjdk.org/jdk/pull/17614#discussion_r1514022885

From aivanov at openjdk.org  Wed Mar  6 08:51:52 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Wed, 6 Mar 2024 08:51:52 GMT
Subject: RFR: 8185862: AWT Assertion Failure in ::GetDIBits(hBMDC, hBM, 0, 
 1, 0, gpBitmapInfo, 0) 'awt_Win32GraphicsDevice.cpp', at line 185 [v9]
In-Reply-To: <CKYPyukEqiyrhtxwu-wmU6m9orRi5dekY1qQPJ5JRa0=.e9385f22-34b9-451a-b9aa-cfeb2a9fd5f3@github.com>
References: <Cj_htOZE6ImXdNmj43IBiX7rW4Em4ZF-6kx0qIZW-Ho=.d355fedd-7ec8-463d-969b-e2123987d1dd@github.com>
 <CKYPyukEqiyrhtxwu-wmU6m9orRi5dekY1qQPJ5JRa0=.e9385f22-34b9-451a-b9aa-cfeb2a9fd5f3@github.com>
Message-ID: <wOn70EG_LG5YDTn09bX1Q28PVgKJ7hMGW_s7ssUWTho=.f46803c0-77c5-40f0-8be1-37cc42338a85@github.com>

On Wed, 6 Mar 2024 07:50:08 GMT, Christoph Langer <clanger at openjdk.org> wrote:

>> The assertions reported in the bug were observed spuriously and here and there broke tests in some Windows configurations.
>> For instance [JDK-8266129](https://bugs.openjdk.org/browse/JDK-8266129), [JDK-8269529](https://bugs.openjdk.org/browse/JDK-8269529) or [JDK-8323664](https://bugs.openjdk.org/browse/JDK-8323664) came up due to this.
>> 
>> The problem is that in Windows environments without a valid display, e.g. started by system services or via PowerShell Remoting, one sees a Monitor with name 'Windisc' in `EnumDisplayMonitors`.
>> However, it seems to be some kind of a pseudo device where you can not get a DC via `CreateDC`. This behavior/monitor type doesn't seem to be well documented, though.
>> 
>> I hereby modify the device initialization code to only count/detect monitors where CreateDC returns non-NULL in Devices.cpp. I also add some more checking/error handling to AwtWin32GraphicsDevice::Initialize() for correctness.
>> 
>> Furthermore, I re-enable the test `javax/swing/reliability/HangDuringStaticInitialization.java` for Windows Debug VMs, which reverts the fix from JDK-8269529 that should not be necessary any more.
>
> Christoph Langer has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 14 additional commits since the last revision:
> 
>  - declare variable hasDisplays final
>  - Merge branch 'master' into JDK-8185862
>  - load awt.dll before display check
>  - Change implementation of headless determination on Windows
>  - Merge branch 'master' into JDK-8185862
>  - Reflect display detection in java.awt.GraphicsEnvironment::isHeadless()
>  - Merge branch 'master' into JDK-8185862
>  - Get rid of global variables and restore old handling wrt calling ::GetDIBits
>  - Merge branch 'master' into JDK-8185862
>  - Little cleanup
>  - ... and 4 more: https://git.openjdk.org/jdk/compare/e7e3e9ca...002fba2d

src/java.desktop/windows/classes/sun/awt/PlatformGraphicsInfo.java line 69:

> 67:     public static boolean getDefaultHeadlessProperty() {
> 68:         // If we don't find usable displays, we run headless.
> 69:         return !hasDisplays();

I wonder if redirection via a private method makes any meaningful difference compared to returning the value of the `hasDisplays` flag directly?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17614#discussion_r1514026459

From abhiscxk at openjdk.org  Wed Mar  6 08:59:48 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Wed, 6 Mar 2024 08:59:48 GMT
Subject: RFR: 8075917: The regression-swing case failed as the text on
 label is not painted red with the GTK L&F [v5]
In-Reply-To: <vAIQHEffW4Eq54K_v5vYvLpyfEXzwG74D8wy5-syJxM=.05d14f36-f4a5-491a-b9a7-f7be14201b0c@github.com>
References: <iDOTnLkAimOa5kfDerZ09n4wsYiFYYUyBflOTYeUQZ0=.293390bd-bc47-4871-bf4c-d23c191d9426@github.com>
 <5eZ7a0HiqE3hghw3sT0L0Zn4Mi1FFfofz6hLGdLOsoc=.445b16ac-4d91-4538-92ba-a74f17781535@github.com>
 <dPwYzsPLI8z4TUTMlwXFEKmddbkkjpifAqrM4b2XxeE=.ec943a1a-09b4-48ec-8ad1-bd64b936e2b2@github.com>
 <yQTL_So5Ud-76evgwEePTvcDSxYXVy0kwN6j_mQwrc0=.12bb609a-b841-480c-9e35-4297f0de6c48@github.com>
 <vAIQHEffW4Eq54K_v5vYvLpyfEXzwG74D8wy5-syJxM=.05d14f36-f4a5-491a-b9a7-f7be14201b0c@github.com>
Message-ID: <9LaK7sRChE5CkU7okuhRSRhRGRFRfjlYrb7dvpE_oFo=.ac9b318d-c3c1-4df5-a880-2baffe8ef502@github.com>

On Wed, 6 Mar 2024 08:43:26 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>>> Also, the enabled state are still not handled
>> 
>> The enabled state is not handled in Metal LAF also, tried adding the enabledText property by setting ui property --
>> `UIManager.getDefaults().put("CheckBox.enabledText", checkboxColor);`
>> 
>> but the checkbox/radiobutton is painted with default black color.
>> Should we handle the change in metal LAF as well?
>
> Backtracking a bit, regarding `Label.foreground` why it needs to be done here?
> 
> Other L&F, it is added in corresponding LookAndFeel class
> for example, in [Metal](https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/javax/swing/plaf/metal/MetalLookAndFeel.java#L1001)
> and in [Windows](https://github.com/openjdk/jdk/blob/master/src/java.desktop/windows/classes/com/sun/java/swing/plaf/windows/WindowsLookAndFeel.java#L880)
> etc
> so I think it is needed to be added in GTKLookAndFeel class
> 
> and additionally there is setting of `Label.foreground` and other Label. property in BasicLabelUI.java [installDefaults](https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/javax/swing/plaf/basic/BasicLabelUI.java#L368)
> but we dont do it for Nimbus or GTK or Synth so I guess we need to call `super.installDefaults(c)` in SynthLabelUI class since there is no GTKLabelUI class
> or 
> maybe do
> `LookAndFeel.installColorsAndFont(c, "Label.background", "Label.foreground", "Label.font");` alone to avoid other properties being set and to not fallback
> 
> Please check if it will work
> and if it does, then we need to employ similar for checbox/radiobutton/togglebutton

I will check and update.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17763#discussion_r1514070177

From aivanov at openjdk.org  Wed Mar  6 09:00:55 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Wed, 6 Mar 2024 09:00:55 GMT
Subject: RFR: 8324808 : Manual printer tests have no Pass/Fail buttons,
 instructions close set 3 [v10]
In-Reply-To: <eb7CRD0sxP_6XlxjmTul27MXTVs-jX_ICXl8taKI5pc=.305f269e-4179-41ea-a451-3425b96e043e@github.com>
References: <BFuAfPibaBpToXKzPNGUKf6pC1DvjrAedYHdtJxtuO8=.d54fcf6c-0727-4a4e-8a94-73a4ebe78af4@github.com>
 <eb7CRD0sxP_6XlxjmTul27MXTVs-jX_ICXl8taKI5pc=.305f269e-4179-41ea-a451-3425b96e043e@github.com>
Message-ID: <JkZSfU4WEcBeUdyBMrgpTtYY29ZUlLTUvlbnX_4hTUc=.c1c21cba-cca0-42c7-a7db-ac4bfe342463@github.com>

On Wed, 6 Mar 2024 06:57:12 GMT, Renjith Kannath Pariyangad <rkannathpari at openjdk.org> wrote:

>> Hi Reviewers,
>> 
>> Updated manual printer test cases with 'PassFailJFrame', also removed unused variables. Added 'SkippedException' in case of printer missing or not configured.
>> 
>> Please review and let me know your suggestions.
>> 
>> Regards,
>> Renjith
>
> Renjith Kannath Pariyangad has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Added Override

Changes requested by aivanov (Reviewer).

test/jdk/java/awt/print/PrinterJob/PageDlgPrnButton.java line 54:

> 52:         if (serviceCount < 2) {
> 53:             throw new SkippedException("The test requires at least 2 printers.");
> 54:         }

This doesn't compile now. You didn't add the import for `jtreg.SkippedException`, nor did you modify the jtreg test to compile `SkippedException`.

test/jdk/java/awt/print/PrinterJob/PrintCompoundString.java line 43:

> 41:  * @key printer
> 42:  * @library /test/lib /java/awt/regtesthelpers
> 43:  * @build PassFailJFrame jtreg.SkippedException

You added `SkippedException` to the test that doesn't need it.

-------------

PR Review: https://git.openjdk.org/jdk/pull/17609#pullrequestreview-1919123845
PR Review Comment: https://git.openjdk.org/jdk/pull/17609#discussion_r1514068434
PR Review Comment: https://git.openjdk.org/jdk/pull/17609#discussion_r1514070364

From aivanov at openjdk.org  Wed Mar  6 09:02:48 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Wed, 6 Mar 2024 09:02:48 GMT
Subject: RFR: 8324807 : Manual printer tests have no Pass/Fail buttons,
 instructions close set 2 [v10]
In-Reply-To: <zS4DvXH14pqpMTUycxOwB5bmfc-S4ifCFjyA3nlWFLU=.a35ed1f4-7ef5-42a9-957d-8f6ee11539f9@github.com>
References: <UZ9jtQbkj-MoeLoccJnd2_3ciCCy9n-CD5vDv0hVKME=.f67db96d-92e6-46a1-9bb6-4fe77c9a8c4e@github.com>
 <3EjlqyLzNCZxo6F1YSOs2zRrNxO5QTIQxkuY27Y3Ro4=.f13abdf7-f15f-44fc-9068-15f3ccda0958@github.com>
 <-3Z3D3ZejKBGJxG_3x26fcoUx2MzUa4vQejYWFRo1-I=.29bf2730-c42a-4f37-a4ad-b14ca74fc025@github.com>
 <zS4DvXH14pqpMTUycxOwB5bmfc-S4ifCFjyA3nlWFLU=.a35ed1f4-7ef5-42a9-957d-8f6ee11539f9@github.com>
Message-ID: <oXzhuXSbOWyqAstqGEmBAMK7vcZkZXVlf_Z3gsbZNOw=.d8d8bbaa-fd65-448e-bced-bf32814703b2@github.com>

On Wed, 6 Mar 2024 06:07:20 GMT, Renjith Kannath Pariyangad <rkannathpari at openjdk.org> wrote:

>> test/jdk/java/awt/print/PrinterJob/Collate2DPrintingTest.java line 74:
>> 
>>> 72:                 if (pj.printDialog(prSet)) {
>>> 73:                     pj.print(prSet);
>>> 74:                 }
>> 
>> In this case, the print dialog has *Collated* checked and disabled; the number of copies is set to 1 and I can't change the value.
>> 
>> Does it work for you? Is it a bug in JDK?
>
> For print to pdf, yes not able to change number of copies, but for actual printer able to change the number.

Makes sense. I had only PDF printer. Thank you for confirming it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17608#discussion_r1514074678

From rkannathpari at openjdk.org  Wed Mar  6 09:46:58 2024
From: rkannathpari at openjdk.org (Renjith Kannath Pariyangad)
Date: Wed, 6 Mar 2024 09:46:58 GMT
Subject: RFR: 8324808 : Manual printer tests have no Pass/Fail buttons,
 instructions close set 3 [v11]
In-Reply-To: <BFuAfPibaBpToXKzPNGUKf6pC1DvjrAedYHdtJxtuO8=.d54fcf6c-0727-4a4e-8a94-73a4ebe78af4@github.com>
References: <BFuAfPibaBpToXKzPNGUKf6pC1DvjrAedYHdtJxtuO8=.d54fcf6c-0727-4a4e-8a94-73a4ebe78af4@github.com>
Message-ID: <SRQoTHOWUizJPydqq56c-ke4u7I0KmDqwZtOu0dPo-Y=.5c28a5a6-0490-436b-aa2c-968dd11b413c@github.com>

> Hi Reviewers,
> 
> Updated manual printer test cases with 'PassFailJFrame', also removed unused variables. Added 'SkippedException' in case of printer missing or not configured.
> 
> Please review and let me know your suggestions.
> 
> Regards,
> Renjith

Renjith Kannath Pariyangad has updated the pull request incrementally with one additional commit since the last revision:

  Fixed comple issue

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/17609/files
  - new: https://git.openjdk.org/jdk/pull/17609/files/df3831c8..e6047f06

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=17609&range=10
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17609&range=09-10

  Stats: 6 lines in 2 files changed: 2 ins; 0 del; 4 mod
  Patch: https://git.openjdk.org/jdk/pull/17609.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17609/head:pull/17609

PR: https://git.openjdk.org/jdk/pull/17609

From tr at openjdk.org  Wed Mar  6 09:47:49 2024
From: tr at openjdk.org (Tejesh R)
Date: Wed, 6 Mar 2024 09:47:49 GMT
Subject: RFR: 8326497: Window.toFront() fails for iconified windows on
 Linux [v5]
In-Reply-To: <NbBenH0X5Y6PYa-4SOWxlpukBLauvwN6CZWZNxf_1eI=.e949822b-7457-48ce-8090-df4aae60f65f@github.com>
References: <XmMRoFNpTDQHCZLnmmnNGVjhR2Ib3yw1kWc0v57utUM=.e418325c-7b23-4298-8f75-e81d369b5afc@github.com>
 <4ZzIgJ3GvtcPQdKqBZ5J49WcKrfNgUjxff02pRSd7fI=.f2e73f77-4aac-4c29-8831-04aaf9d81d23@github.com>
 <Xnvtw_SABWMR-okt1ZOb5NkmKWkkNg6-Tnu1yp6yQkg=.962fcdee-7f9f-49fe-ac96-cfbfbc49cc0c@github.com>
 <NbBenH0X5Y6PYa-4SOWxlpukBLauvwN6CZWZNxf_1eI=.e949822b-7457-48ce-8090-df4aae60f65f@github.com>
Message-ID: <cSdWPr5E8qMXO0YltvLyCGpd8zUNslW0tMjEYYsDKGw=.e8e3b272-53c8-4853-aa2c-fea34ae9746e@github.com>

On Tue, 5 Mar 2024 13:25:42 GMT, Maxim Kartashev <mkartashev at openjdk.org> wrote:

>> test/jdk/java/awt/Frame/Iconify/IconifiedToFront.java line 41:
>> 
>>> 39: 
>>> 40: public class IconifiedToFront {
>>> 41:     private static final int PAUSE_MS = 1500;
>> 
>> 1.5 sec is minimum delay, can we reduced it ?
>
> Not unless there's another idea on how to measure tests' success. 1.5 seconds is about the time my MacOS needs to complete an iconify/de-iconfiy process.

Did u try after adding `waitForIdle` ?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17985#discussion_r1514153337

From tr at openjdk.org  Wed Mar  6 10:45:47 2024
From: tr at openjdk.org (Tejesh R)
Date: Wed, 6 Mar 2024 10:45:47 GMT
Subject: RFR: 8325179: Race in BasicDirectoryModel.validateFileCache [v2]
In-Reply-To: <Wu1AtT0-dY5r8SVpBBJXsX5n4FpEqyMQ7TiY96UvzW8=.dfc34dc8-33c1-4917-96eb-f7ef9e2528db@github.com>
References: <nOapec57Ql6DHy57oEeWdkUGER8RYdWc2vwmJsqWDYc=.8de81954-d8c2-4937-b426-e61dde05255e@github.com>
 <Wu1AtT0-dY5r8SVpBBJXsX5n4FpEqyMQ7TiY96UvzW8=.dfc34dc8-33c1-4917-96eb-f7ef9e2528db@github.com>
Message-ID: <QsODtDE5Lp7Z4Fy0fqhArQ4ucrKQ-AuP_GgJQYjE9wE=.0539d0ec-9e2e-44d6-97bf-5dc5406cea15@github.com>

On Tue, 5 Mar 2024 11:07:13 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Ensure access to the `filesLoader` field of `BasicDirectoryModel` is synchronized.
>> 
>> Without synchronization, a thread checks if `filesLoader` is not null and creates a new `FilesLoader` thread. If the thread is pre-empted between these two operations, another thread or even several threads can see the `null` value and create new `FilesLoader` threads.
>> 
>> The same way, `BasicDirectoryModel.invalidateFileCache` needs to be synchornized to interrupt the current `filesLoader` and assign `null`.
>> 
>> This bug allows reproducing `ConcurrentModificationException` seen in [JDK-8323670](https://bugs.openjdk.org/browse/JDK-8323670) and [JDK-8307091](https://bugs.openjdk.org/browse/JDK-8307091) using the test in PR #18109.
>
> Alexey Ivanov has updated the pull request incrementally with four additional commits since the last revision:
> 
>  - Replace synchronized invalidateFileCache with synchronized block inside
>  - Declare DoChangeContents constructor private, wrap its parameters
>  - Space after synchronized in DoChangeContents.run
>  - Convert runnable to local variable

src/java.desktop/share/classes/javax/swing/plaf/basic/BasicDirectoryModel.java line 552:

> 550:             if (remSize > 0 && addSize == 0) {
> 551:                 fireIntervalRemoved(BasicDirectoryModel.this, remStart, remStart + remSize - 1);
> 552:             } else if (addSize > 0 && remSize == 0 && addStart + addSize <= fileCache.size()) {

Any reason for moving this portion out of `Synchronized` block? Because `fileCache.size()` might need to be inside the `Synchronized` block right?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18111#discussion_r1514242873

From mkartashev at openjdk.org  Wed Mar  6 10:55:00 2024
From: mkartashev at openjdk.org (Maxim Kartashev)
Date: Wed, 6 Mar 2024 10:55:00 GMT
Subject: RFR: 8326497: Window.toFront() fails for iconified windows on
 Linux [v5]
In-Reply-To: <cSdWPr5E8qMXO0YltvLyCGpd8zUNslW0tMjEYYsDKGw=.e8e3b272-53c8-4853-aa2c-fea34ae9746e@github.com>
References: <XmMRoFNpTDQHCZLnmmnNGVjhR2Ib3yw1kWc0v57utUM=.e418325c-7b23-4298-8f75-e81d369b5afc@github.com>
 <4ZzIgJ3GvtcPQdKqBZ5J49WcKrfNgUjxff02pRSd7fI=.f2e73f77-4aac-4c29-8831-04aaf9d81d23@github.com>
 <Xnvtw_SABWMR-okt1ZOb5NkmKWkkNg6-Tnu1yp6yQkg=.962fcdee-7f9f-49fe-ac96-cfbfbc49cc0c@github.com>
 <NbBenH0X5Y6PYa-4SOWxlpukBLauvwN6CZWZNxf_1eI=.e949822b-7457-48ce-8090-df4aae60f65f@github.com>
 <cSdWPr5E8qMXO0YltvLyCGpd8zUNslW0tMjEYYsDKGw=.e8e3b272-53c8-4853-aa2c-fea34ae9746e@github.com>
Message-ID: <2V9QZd8jJBBVE421oG0hlLZSsfgz9uutwvfgvFC1KOI=.d1730d02-f4fa-4952-9a3c-5a275f98714d@github.com>

On Wed, 6 Mar 2024 09:45:33 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Not unless there's another idea on how to measure tests' success. 1.5 seconds is about the time my MacOS needs to complete an iconify/de-iconfiy process.
>
> Did u try after adding `waitForIdle` ?

You were right @TejeshR13. `waitForIdle` helps and I reverted the time back to 500ms.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17985#discussion_r1514255299

From mkartashev at openjdk.org  Wed Mar  6 10:55:00 2024
From: mkartashev at openjdk.org (Maxim Kartashev)
Date: Wed, 6 Mar 2024 10:55:00 GMT
Subject: RFR: 8326497: Window.toFront() fails for iconified windows on
 Linux [v6]
In-Reply-To: <XmMRoFNpTDQHCZLnmmnNGVjhR2Ib3yw1kWc0v57utUM=.e418325c-7b23-4298-8f75-e81d369b5afc@github.com>
References: <XmMRoFNpTDQHCZLnmmnNGVjhR2Ib3yw1kWc0v57utUM=.e418325c-7b23-4298-8f75-e81d369b5afc@github.com>
Message-ID: <0nuVOsFROjoR7wCT94ilnqEjENMSLt5XTHM6hLVWxOk=.873c9a7f-2492-47b6-968d-5f391577e5ed@github.com>

> XToolkit implements `toFront()` essentially by sending the  `_NET_ACTIVE_WINDOW` message to activate the window. This has no effect when the target window is in the iconified state. So the fix is to cancel that state prior to sending the message.
> 
> The test verifies that the fix works for maximized and undecorated frames as well out of abundance of caution; they do not represent a special case from the `toFront()` standpoint.
> 
> References
> * `_NET_ACTIVE_WINDOW`: https://specifications.freedesktop.org/wm-spec/1.3/ar01s03.html
> * [Inter-Client Communication Conventions Manual, 4.1.4. Changing Window State](https://tronche.com/gui/x/icccm/sec-4.html#s-4.1.4)

Maxim Kartashev has updated the pull request incrementally with one additional commit since the last revision:

  Reduced the wait time in the test

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/17985/files
  - new: https://git.openjdk.org/jdk/pull/17985/files/d7d134ee..da72dbc0

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=17985&range=05
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17985&range=04-05

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/17985.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17985/head:pull/17985

PR: https://git.openjdk.org/jdk/pull/17985

From tr at openjdk.org  Wed Mar  6 11:22:45 2024
From: tr at openjdk.org (Tejesh R)
Date: Wed, 6 Mar 2024 11:22:45 GMT
Subject: RFR: 8326497: Window.toFront() fails for iconified windows on
 Linux [v6]
In-Reply-To: <0nuVOsFROjoR7wCT94ilnqEjENMSLt5XTHM6hLVWxOk=.873c9a7f-2492-47b6-968d-5f391577e5ed@github.com>
References: <XmMRoFNpTDQHCZLnmmnNGVjhR2Ib3yw1kWc0v57utUM=.e418325c-7b23-4298-8f75-e81d369b5afc@github.com>
 <0nuVOsFROjoR7wCT94ilnqEjENMSLt5XTHM6hLVWxOk=.873c9a7f-2492-47b6-968d-5f391577e5ed@github.com>
Message-ID: <qgcjEYt-84D-XdqkMTFrXXZmojT_Ix0ZU0p2L5YoCGU=.b4d76379-af32-4639-8673-8c44a9bec1f2@github.com>

On Wed, 6 Mar 2024 10:55:00 GMT, Maxim Kartashev <mkartashev at openjdk.org> wrote:

>> XToolkit implements `toFront()` essentially by sending the  `_NET_ACTIVE_WINDOW` message to activate the window. This has no effect when the target window is in the iconified state. So the fix is to cancel that state prior to sending the message.
>> 
>> The test verifies that the fix works for maximized and undecorated frames as well out of abundance of caution; they do not represent a special case from the `toFront()` standpoint.
>> 
>> References
>> * `_NET_ACTIVE_WINDOW`: https://specifications.freedesktop.org/wm-spec/1.3/ar01s03.html
>> * [Inter-Client Communication Conventions Manual, 4.1.4. Changing Window State](https://tronche.com/gui/x/icccm/sec-4.html#s-4.1.4)
>
> Maxim Kartashev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Reduced the wait time in the test

Looks good to me.

-------------

Marked as reviewed by tr (Committer).

PR Review: https://git.openjdk.org/jdk/pull/17985#pullrequestreview-1919467433

From aivanov at openjdk.org  Wed Mar  6 11:27:08 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Wed, 6 Mar 2024 11:27:08 GMT
Subject: RFR: 8325179: Race in BasicDirectoryModel.validateFileCache [v3]
In-Reply-To: <nOapec57Ql6DHy57oEeWdkUGER8RYdWc2vwmJsqWDYc=.8de81954-d8c2-4937-b426-e61dde05255e@github.com>
References: <nOapec57Ql6DHy57oEeWdkUGER8RYdWc2vwmJsqWDYc=.8de81954-d8c2-4937-b426-e61dde05255e@github.com>
Message-ID: <mVHHIki7p8TDSN0TlD0kaRuNzWUHom5W-y7y51rxjSA=.35bcbabb-4c2c-4f9e-a48b-b34995336da2@github.com>

> Ensure access to the `filesLoader` field of `BasicDirectoryModel` is synchronized.
> 
> Without synchronization, a thread checks if `filesLoader` is not null and creates a new `FilesLoader` thread. If the thread is pre-empted between these two operations, another thread or even several threads can see the `null` value and create new `FilesLoader` threads.
> 
> The same way, `BasicDirectoryModel.invalidateFileCache` needs to be synchornized to interrupt the current `filesLoader` and assign `null`.
> 
> This bug allows reproducing `ConcurrentModificationException` seen in [JDK-8323670](https://bugs.openjdk.org/browse/JDK-8323670) and [JDK-8307091](https://bugs.openjdk.org/browse/JDK-8307091) using the test in PR #18109.

Alexey Ivanov has updated the pull request incrementally with one additional commit since the last revision:

  Store the size of fileCache inside synchronized block

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18111/files
  - new: https://git.openjdk.org/jdk/pull/18111/files/a0659236..a9ec7f64

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18111&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18111&range=01-02

  Stats: 5 lines in 1 file changed: 2 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/jdk/pull/18111.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18111/head:pull/18111

PR: https://git.openjdk.org/jdk/pull/18111

From aivanov at openjdk.org  Wed Mar  6 11:32:45 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Wed, 6 Mar 2024 11:32:45 GMT
Subject: RFR: 8325179: Race in BasicDirectoryModel.validateFileCache [v2]
In-Reply-To: <QsODtDE5Lp7Z4Fy0fqhArQ4ucrKQ-AuP_GgJQYjE9wE=.0539d0ec-9e2e-44d6-97bf-5dc5406cea15@github.com>
References: <nOapec57Ql6DHy57oEeWdkUGER8RYdWc2vwmJsqWDYc=.8de81954-d8c2-4937-b426-e61dde05255e@github.com>
 <Wu1AtT0-dY5r8SVpBBJXsX5n4FpEqyMQ7TiY96UvzW8=.dfc34dc8-33c1-4917-96eb-f7ef9e2528db@github.com>
 <QsODtDE5Lp7Z4Fy0fqhArQ4ucrKQ-AuP_GgJQYjE9wE=.0539d0ec-9e2e-44d6-97bf-5dc5406cea15@github.com>
Message-ID: <IhWy0XxSNuejnj6V1lWQRuvtOHP76pukKwQRNe3PKF0=.1584e6a6-8228-4960-9c19-12fe5ec4dc62@github.com>

On Wed, 6 Mar 2024 10:43:16 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Alexey Ivanov has updated the pull request incrementally with four additional commits since the last revision:
>> 
>>  - Replace synchronized invalidateFileCache with synchronized block inside
>>  - Declare DoChangeContents constructor private, wrap its parameters
>>  - Space after synchronized in DoChangeContents.run
>>  - Convert runnable to local variable
>
> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicDirectoryModel.java line 552:
> 
>> 550:             if (remSize > 0 && addSize == 0) {
>> 551:                 fireIntervalRemoved(BasicDirectoryModel.this, remStart, remStart + remSize - 1);
>> 552:             } else if (addSize > 0 && remSize == 0 && addStart + addSize <= fileCache.size()) {
> 
> Any reason for moving this portion out of `Synchronized` block? Because `fileCache.size()` might need to be inside the `Synchronized` block right?

I didn't touch it, it never was inside the synchronized block. Only indentation was changed in this method.

However, you're right it's better to store the size of `fileCache` inside the synchronized block. The lock should not be held while notifying listeners.

On the other hand, `fileCache` can't change. The only place where `fileCache` is modified is above in this method, and only on EDT. The EDT will remain busy until a `fire*` method returns.

I've updated the code to avoid any confusion. Thanks!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18111#discussion_r1514311500

From mkartashev at openjdk.org  Wed Mar  6 11:42:48 2024
From: mkartashev at openjdk.org (Maxim Kartashev)
Date: Wed, 6 Mar 2024 11:42:48 GMT
Subject: RFR: 8326497: Window.toFront() fails for iconified windows on
 Linux
In-Reply-To: <l3mxqAviT6e_UnVafBEI9QfvL-Ht2h-s6QS97SHZJXw=.e0a29c32-1329-4b50-a394-7b97cdf9e281@github.com>
References: <XmMRoFNpTDQHCZLnmmnNGVjhR2Ib3yw1kWc0v57utUM=.e418325c-7b23-4298-8f75-e81d369b5afc@github.com>
 <l3mxqAviT6e_UnVafBEI9QfvL-Ht2h-s6QS97SHZJXw=.e0a29c32-1329-4b50-a394-7b97cdf9e281@github.com>
Message-ID: <QePxBz_e-pU6359_Rugs1UL7fUcSaBQ3gJQtvdC1AoI=.b3cf8467-452d-48f0-8860-4082fc10faf1@github.com>

On Fri, 23 Feb 2024 21:51:30 GMT, Phil Race <prr at openjdk.org> wrote:

>> XToolkit implements `toFront()` essentially by sending the  `_NET_ACTIVE_WINDOW` message to activate the window. This has no effect when the target window is in the iconified state. So the fix is to cancel that state prior to sending the message.
>> 
>> The test verifies that the fix works for maximized and undecorated frames as well out of abundance of caution; they do not represent a special case from the `toFront()` standpoint.
>> 
>> References
>> * `_NET_ACTIVE_WINDOW`: https://specifications.freedesktop.org/wm-spec/1.3/ar01s03.html
>> * [Inter-Client Communication Conventions Manual, 4.1.4. Changing Window State](https://tronche.com/gui/x/icccm/sec-4.html#s-4.1.4)
>
> Looks reasonable to me. I'm a bit surprised this hasn't come up before.
> 
> On Mac I see that we already do this properly, I presume this is also the case on Windows, so the test will pass on all platforms ?
> 
> I think we should submit a test job ...

@prrace What say you?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17985#issuecomment-1980683967

From aivanov at openjdk.org  Wed Mar  6 15:33:51 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Wed, 6 Mar 2024 15:33:51 GMT
Subject: RFR: 8324808 : Manual printer tests have no Pass/Fail buttons,
 instructions close set 3 [v11]
In-Reply-To: <SRQoTHOWUizJPydqq56c-ke4u7I0KmDqwZtOu0dPo-Y=.5c28a5a6-0490-436b-aa2c-968dd11b413c@github.com>
References: <BFuAfPibaBpToXKzPNGUKf6pC1DvjrAedYHdtJxtuO8=.d54fcf6c-0727-4a4e-8a94-73a4ebe78af4@github.com>
 <SRQoTHOWUizJPydqq56c-ke4u7I0KmDqwZtOu0dPo-Y=.5c28a5a6-0490-436b-aa2c-968dd11b413c@github.com>
Message-ID: <QhvM4NMXRBvEgkbw_hAGDED28wDOAGYihwBiZq7LnlM=.21acbe87-d2b6-4592-ba5a-b76551ca1771@github.com>

On Wed, 6 Mar 2024 09:46:58 GMT, Renjith Kannath Pariyangad <rkannathpari at openjdk.org> wrote:

>> Hi Reviewers,
>> 
>> Updated manual printer test cases with 'PassFailJFrame', also removed unused variables. Added 'SkippedException' in case of printer missing or not configured.
>> 
>> Please review and let me know your suggestions.
>> 
>> Regards,
>> Renjith
>
> Renjith Kannath Pariyangad has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fixed comple issue

There are quite a few other comments unresolved comments.

test/jdk/java/awt/print/PrinterJob/PageDlgPrnButton.java line 40:

> 38:  * @requires os.family=="windows"
> 39:  * @library /test/lib /java/awt/regtesthelpers
> 40:  * @build PassFailJFrame jtreg.SkippedException

Suggestion:

 * @library /test/lib /java/awt/regtesthelpers
 * @build jtreg.SkippedException PassFailJFrame

Change the order to align libraries and classes from the libraries?

-------------

Changes requested by aivanov (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17609#pullrequestreview-1920039700
PR Review Comment: https://git.openjdk.org/jdk/pull/17609#discussion_r1514664523

From aivanov at openjdk.org  Wed Mar  6 15:33:52 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Wed, 6 Mar 2024 15:33:52 GMT
Subject: RFR: 8324808 : Manual printer tests have no Pass/Fail buttons,
 instructions close set 3 [v9]
In-Reply-To: <hKIZieC0E6_FFK8wi99i34vjVVuRBnfYT-61unwd4N8=.d76b51ad-717c-47c1-ab11-67b731c63229@github.com>
References: <BFuAfPibaBpToXKzPNGUKf6pC1DvjrAedYHdtJxtuO8=.d54fcf6c-0727-4a4e-8a94-73a4ebe78af4@github.com>
 <A877YpZnLzvXlDU70eT128kB9hnPyuE3xxQlw8UrVCs=.01da0d64-66b0-48d6-b1f3-08c48e251ee8@github.com>
 <hKIZieC0E6_FFK8wi99i34vjVVuRBnfYT-61unwd4N8=.d76b51ad-717c-47c1-ab11-67b731c63229@github.com>
Message-ID: <_DMmnE4n2H6vzXkb8_Brp-QQmXo50GPC72GF4Ri9aYs=.47d57c0a-dd6d-43e2-9abf-cf1150290190@github.com>

On Tue, 5 Mar 2024 14:56:22 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Renjith Kannath Pariyangad has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Suggesions added
>
> test/jdk/java/awt/print/PrinterJob/PrintImage.java line 57:
> 
>> 55:             "Printing must be done in Japanese 2nd Edition.\n" +
>> 56:             "Preferably Canon LaserShot A309GII.\n" +
>> 57:             "\n" +
> 
> Suggestion:
> 
> 
> I believe we can remove the first part of the instructions. The original bug [JDK-4298489](https://bugs.openjdk.org/browse/JDK-4298489) says printing by the first method was ugly and the second one was good. Both methods should produce the identical results.
> 
> According to the bug description, it was reported against Windows 95 OSR 2 although the instructions in the test refer to Windows 98 Second Edition and its Japanese version for whatever reason.

What about this comment?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17609#discussion_r1514684555

From aivanov at openjdk.org  Wed Mar  6 15:45:50 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Wed, 6 Mar 2024 15:45:50 GMT
Subject: RFR: 8320676 : Manual printer tests have no Pass/Fail buttons,
 instructions close set 1 [v11]
In-Reply-To: <G_hFouVypycpSwZ-ovBR6_zxAzwlXbWFuDsgoZKXFfk=.8ac90930-10a8-4550-a564-d5533eaf6e14@github.com>
References: <Afd90FypFvXYNR17jgkxcFj2LlxdLlZ1Bgd7WctdKcU=.2a8b05e0-a476-4598-8524-a22a0f54b8a5@github.com>
 <iWutKW4UpvMw8nEhcHknq1dlyNEtmppek6JdbLUqKDU=.4fa91123-1d3a-43d6-9f9d-c3967425c164@github.com>
 <G_hFouVypycpSwZ-ovBR6_zxAzwlXbWFuDsgoZKXFfk=.8ac90930-10a8-4550-a564-d5533eaf6e14@github.com>
Message-ID: <dyuhxpVpTsuvYjpIT-s-poGhz1WlJGgkpbZo6Cib1sQ=.071a769b-a22e-410d-a67f-7a2d4c045ba9@github.com>

On Tue, 5 Mar 2024 12:13:02 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Renjith Kannath Pariyangad has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Suggesions incorporated
>
> test/jdk/java/awt/print/PrinterJob/PrintAllFonts.java line 45:
> 
>> 43:     private static final int FONT_SIZE = 14;
>> 44:     private final Font[] allFonts =
>> 45:             GraphicsEnvironment.getLocalGraphicsEnvironment().getAllFonts();
> 
> I suggest adding blank lines to visually separate fields / constants with different purpose.
> Suggestion:
> 
>     private static final int LINE_HEIGHT = 18;
>     private static final int FONT_SIZE = 14;
> 
>     private final Font[] allFonts =
>             GraphicsEnvironment.getLocalGraphicsEnvironment().getAllFonts();

What about this?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17607#discussion_r1514715232

From achung at openjdk.org  Wed Mar  6 20:13:58 2024
From: achung at openjdk.org (Alisen Chung)
Date: Wed, 6 Mar 2024 20:13:58 GMT
Subject: RFR: 8327492: Remove applet usage and update
 DisposeInActionEventTest.html [v10]
In-Reply-To: <wbQWXZ3sLQB90OPGZTWuifQuxdk7bFfiouu2NzUEzHQ=.310c2f89-b621-4f34-a949-1f319bcac8ce@github.com>
References: <wbQWXZ3sLQB90OPGZTWuifQuxdk7bFfiouu2NzUEzHQ=.310c2f89-b621-4f34-a949-1f319bcac8ce@github.com>
Message-ID: <wqOujoNLfVeUa9JAk0YP6R9tJdU_SlQdJOx5TipMmwg=.b68ee2df-e459-4b37-86ce-e0d123084249@github.com>

> Root cause of the test failure was fixed with https://bugs.openjdk.org/browse/JDK-8316931, updating this test since the other fix also included a test update.

Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:

  implemented changes from feedback

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/17838/files
  - new: https://git.openjdk.org/jdk/pull/17838/files/4b9edb5d..9e053cae

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=17838&range=09
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17838&range=08-09

  Stats: 27 lines in 2 files changed: 6 ins; 4 del; 17 mod
  Patch: https://git.openjdk.org/jdk/pull/17838.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17838/head:pull/17838

PR: https://git.openjdk.org/jdk/pull/17838

From honkar at openjdk.org  Wed Mar  6 20:51:48 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Wed, 6 Mar 2024 20:51:48 GMT
Subject: RFR: 8327492: Remove applet usage and update
 DisposeInActionEventTest.html [v10]
In-Reply-To: <wqOujoNLfVeUa9JAk0YP6R9tJdU_SlQdJOx5TipMmwg=.b68ee2df-e459-4b37-86ce-e0d123084249@github.com>
References: <wbQWXZ3sLQB90OPGZTWuifQuxdk7bFfiouu2NzUEzHQ=.310c2f89-b621-4f34-a949-1f319bcac8ce@github.com>
 <wqOujoNLfVeUa9JAk0YP6R9tJdU_SlQdJOx5TipMmwg=.b68ee2df-e459-4b37-86ce-e0d123084249@github.com>
Message-ID: <v59XG0MTZ_ybXZqfMGeJ5HG66UTvbCLDPbBda2xXrEg=.9d30e0f9-01f2-425c-9e15-bc9f8ce09562@github.com>

On Wed, 6 Mar 2024 20:13:58 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> Root cause of the test failure was fixed with https://bugs.openjdk.org/browse/JDK-8316931, updating this test since the other fix also included a test update.
>
> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   implemented changes from feedback

test/jdk/java/awt/TrayIcon/DisposeInActionEventTest/DisposeInActionEventTest.java line 84:

> 82:         } finally {
> 83:             systemTray.remove(trayIcon);
> 84:         }

@alisenchung I missed adding null check here earlier. It is good to have this safety check to avoid NPE.

Suggestion:

        } finally {
            if (systemTray != null) {
               systemTray.remove(trayIcon);
            }
         }

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17838#discussion_r1515135506

From achung at openjdk.org  Wed Mar  6 21:36:10 2024
From: achung at openjdk.org (Alisen Chung)
Date: Wed, 6 Mar 2024 21:36:10 GMT
Subject: RFR: 8327492: Remove applet usage and update
 DisposeInActionEventTest.html [v11]
In-Reply-To: <wbQWXZ3sLQB90OPGZTWuifQuxdk7bFfiouu2NzUEzHQ=.310c2f89-b621-4f34-a949-1f319bcac8ce@github.com>
References: <wbQWXZ3sLQB90OPGZTWuifQuxdk7bFfiouu2NzUEzHQ=.310c2f89-b621-4f34-a949-1f319bcac8ce@github.com>
Message-ID: <xBLwOrYHGNchmi4gDrF18OYHkqMPV1NY9fmteg0AyiU=.adfe4b00-5815-4ba2-b991-4a1672302431@github.com>

> Root cause of the test failure was fixed with https://bugs.openjdk.org/browse/JDK-8316931, updating this test since the other fix also included a test update.

Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:

  null check for system tray before remove

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/17838/files
  - new: https://git.openjdk.org/jdk/pull/17838/files/9e053cae..60bb2701

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=17838&range=10
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17838&range=09-10

  Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/17838.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17838/head:pull/17838

PR: https://git.openjdk.org/jdk/pull/17838

From honkar at openjdk.org  Wed Mar  6 21:44:53 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Wed, 6 Mar 2024 21:44:53 GMT
Subject: RFR: 8327492: Remove applet usage and update
 DisposeInActionEventTest.html [v11]
In-Reply-To: <xBLwOrYHGNchmi4gDrF18OYHkqMPV1NY9fmteg0AyiU=.adfe4b00-5815-4ba2-b991-4a1672302431@github.com>
References: <wbQWXZ3sLQB90OPGZTWuifQuxdk7bFfiouu2NzUEzHQ=.310c2f89-b621-4f34-a949-1f319bcac8ce@github.com>
 <xBLwOrYHGNchmi4gDrF18OYHkqMPV1NY9fmteg0AyiU=.adfe4b00-5815-4ba2-b991-4a1672302431@github.com>
Message-ID: <jbltl2o2y-aYt7q3m1oZtcktsRCoPBJdIDSsdHY2XUk=.fa12a09e-5e29-4512-9c1b-17a9993ca7ce@github.com>

On Wed, 6 Mar 2024 21:36:10 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> Root cause of the test failure was fixed with https://bugs.openjdk.org/browse/JDK-8316931, updating this test since the other fix also included a test update.
>
> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   null check for system tray before remove

Marked as reviewed by honkar (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/17838#pullrequestreview-1920885698

From prr at openjdk.org  Wed Mar  6 23:45:52 2024
From: prr at openjdk.org (Phil Race)
Date: Wed, 6 Mar 2024 23:45:52 GMT
Subject: RFR: 8326497: Window.toFront() fails for iconified windows on
 Linux [v6]
In-Reply-To: <0nuVOsFROjoR7wCT94ilnqEjENMSLt5XTHM6hLVWxOk=.873c9a7f-2492-47b6-968d-5f391577e5ed@github.com>
References: <XmMRoFNpTDQHCZLnmmnNGVjhR2Ib3yw1kWc0v57utUM=.e418325c-7b23-4298-8f75-e81d369b5afc@github.com>
 <0nuVOsFROjoR7wCT94ilnqEjENMSLt5XTHM6hLVWxOk=.873c9a7f-2492-47b6-968d-5f391577e5ed@github.com>
Message-ID: <u8pu4v9JtqTd3I4A8jsX-nyAFoID4D7-JyGsRzGq7eg=.d96c0fd8-3406-49f3-b848-58072dddd2d3@github.com>

On Wed, 6 Mar 2024 10:55:00 GMT, Maxim Kartashev <mkartashev at openjdk.org> wrote:

>> XToolkit implements `toFront()` essentially by sending the  `_NET_ACTIVE_WINDOW` message to activate the window. This has no effect when the target window is in the iconified state. So the fix is to cancel that state prior to sending the message.
>> 
>> The test verifies that the fix works for maximized and undecorated frames as well out of abundance of caution; they do not represent a special case from the `toFront()` standpoint.
>> 
>> References
>> * `_NET_ACTIVE_WINDOW`: https://specifications.freedesktop.org/wm-spec/1.3/ar01s03.html
>> * [Inter-Client Communication Conventions Manual, 4.1.4. Changing Window State](https://tronche.com/gui/x/icccm/sec-4.html#s-4.1.4)
>
> Maxim Kartashev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Reduced the wait time in the test

Let me submit a new test job with this (hopefully final?) version

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17985#issuecomment-1982053728

From prr at openjdk.org  Thu Mar  7 00:49:54 2024
From: prr at openjdk.org (Phil Race)
Date: Thu, 7 Mar 2024 00:49:54 GMT
Subject: RFR: 8185862: AWT Assertion Failure in ::GetDIBits(hBMDC, hBM, 0, 
 1, 0, gpBitmapInfo, 0) 'awt_Win32GraphicsDevice.cpp', at line 185 [v2]
In-Reply-To: <DUfeeaOAaZnEKeqT81SxKj86s57M-b3Ioqggj1lijs8=.6f888fc7-fd6d-4df9-9a75-bca8d4429b4f@github.com>
References: <Cj_htOZE6ImXdNmj43IBiX7rW4Em4ZF-6kx0qIZW-Ho=.d355fedd-7ec8-463d-969b-e2123987d1dd@github.com>
 <Ptki9SnXavWUHVBaFKxqMJAzNH1Ec8CB4cr9ezJFwxA=.60a8b98b-0d1e-4f8c-bf1a-55908aaedf19@github.com>
 <4jmx37LJU3WWe70P4sSyCBtDgU_iGbJj8q4qMiB9GmQ=.7efffac2-f074-44d4-ae21-e088725ce756@github.com>
 <HtDXNTnHYyrG3rPIaAumR3VnleSlWGKwuN3YjFLApo4=.3d41e0ca-11a3-48b8-ade5-867a3fd544ec@github.com>
 <DUfeeaOAaZnEKeqT81SxKj86s57M-b3Ioqggj1lijs8=.6f888fc7-fd6d-4df9-9a75-bca8d4429b4f@github.com>
Message-ID: <2fz9YnrAnu3iMUF-xzXPA1wsOodGvXMjxlD53GA_7Ec=.fc280af9-54cc-473e-9d0c-132f37b77314@github.com>

On Tue, 5 Mar 2024 18:15:50 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> @prrace, Do you know how critical the code below is? Is it worth to code the fallback if the path to ::GetDIBits?

In the headLESS case we should never be here, since this is initializing the devices that don't exist in that case.
In the headFUL case I would prefer to keep the existing non-debug behaviour that we soldier on and try to do something sensible. Line 204 has a comment about a case in which GetDIBits really did fail and there's code to cope. I am writing specifically about GetDIBits.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17614#discussion_r1515338800

From tr at openjdk.org  Thu Mar  7 04:16:54 2024
From: tr at openjdk.org (Tejesh R)
Date: Thu, 7 Mar 2024 04:16:54 GMT
Subject: RFR: 8280392:
 java/awt/Focus/NonFocusableWindowTest/NonfocusableOwnerTest.java failed with
 "RuntimeException: Test failed."
In-Reply-To: <o_Z6zlPUisWgc5LIglgOe4zbIjsijJfuG9MtoBveFAU=.2d730b06-211a-485e-8390-6d6f9ae75947@github.com>
References: <o_Z6zlPUisWgc5LIglgOe4zbIjsijJfuG9MtoBveFAU=.2d730b06-211a-485e-8390-6d6f9ae75947@github.com>
Message-ID: <8pgq8yur6FcZdTrPipbw0lAwEZVBRFQbJ6j0vzYvFeE=.326894bd-0b7d-42d1-9bd8-a45d39b0da82@github.com>

On Fri, 1 Mar 2024 22:49:25 GMT, Alisen Chung <achung at openjdk.org> wrote:

> Introduce delays in test to stabilize. Test passes 50x after fix.

Looks fine to me.

-------------

Marked as reviewed by tr (Committer).

PR Review: https://git.openjdk.org/jdk/pull/18091#pullrequestreview-1921403146

From tr at openjdk.org  Thu Mar  7 04:24:52 2024
From: tr at openjdk.org (Tejesh R)
Date: Thu, 7 Mar 2024 04:24:52 GMT
Subject: RFR: 8280392:
 java/awt/Focus/NonFocusableWindowTest/NonfocusableOwnerTest.java failed with
 "RuntimeException: Test failed."
In-Reply-To: <o_Z6zlPUisWgc5LIglgOe4zbIjsijJfuG9MtoBveFAU=.2d730b06-211a-485e-8390-6d6f9ae75947@github.com>
References: <o_Z6zlPUisWgc5LIglgOe4zbIjsijJfuG9MtoBveFAU=.2d730b06-211a-485e-8390-6d6f9ae75947@github.com>
Message-ID: <C3nyKo6EnAQHFjpoKKktjfOBClecQFIXRP_h7h2QiKU=.2f377962-c89e-48bf-bf2b-f37ef761d448@github.com>

On Fri, 1 Mar 2024 22:49:25 GMT, Alisen Chung <achung at openjdk.org> wrote:

> Introduce delays in test to stabilize. Test passes 50x after fix.

1. Update Copywrite year.
2. Expand the imports.
3. Jtreg test format.
4. Frame title to be update w.r.t test purpose.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18091#issuecomment-1982321981

From rkannathpari at openjdk.org  Thu Mar  7 07:13:02 2024
From: rkannathpari at openjdk.org (Renjith Kannath Pariyangad)
Date: Thu, 7 Mar 2024 07:13:02 GMT
Subject: RFR: 8324808 : Manual printer tests have no Pass/Fail buttons,
 instructions close set 3 [v12]
In-Reply-To: <BFuAfPibaBpToXKzPNGUKf6pC1DvjrAedYHdtJxtuO8=.d54fcf6c-0727-4a4e-8a94-73a4ebe78af4@github.com>
References: <BFuAfPibaBpToXKzPNGUKf6pC1DvjrAedYHdtJxtuO8=.d54fcf6c-0727-4a4e-8a94-73a4ebe78af4@github.com>
Message-ID: <PRKmgKHOtiP-8vog0IQjkYXsm1KF0T-1VIrRc0WIohs=.b989ffe2-2c87-420c-8f0a-26bf27a4b41c@github.com>

> Hi Reviewers,
> 
> Updated manual printer test cases with 'PassFailJFrame', also removed unused variables. Added 'SkippedException' in case of printer missing or not configured.
> 
> Please review and let me know your suggestions.
> 
> Regards,
> Renjith

Renjith Kannath Pariyangad has updated the pull request incrementally with one additional commit since the last revision:

  Updated instructions

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/17609/files
  - new: https://git.openjdk.org/jdk/pull/17609/files/e6047f06..2160b4f5

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=17609&range=11
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17609&range=10-11

  Stats: 25 lines in 3 files changed: 12 ins; 3 del; 10 mod
  Patch: https://git.openjdk.org/jdk/pull/17609.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17609/head:pull/17609

PR: https://git.openjdk.org/jdk/pull/17609

From rkannathpari at openjdk.org  Thu Mar  7 08:39:10 2024
From: rkannathpari at openjdk.org (Renjith Kannath Pariyangad)
Date: Thu, 7 Mar 2024 08:39:10 GMT
Subject: RFR: 8324807 : Manual printer tests have no Pass/Fail buttons,
 instructions close set 2 [v12]
In-Reply-To: <UZ9jtQbkj-MoeLoccJnd2_3ciCCy9n-CD5vDv0hVKME=.f67db96d-92e6-46a1-9bb6-4fe77c9a8c4e@github.com>
References: <UZ9jtQbkj-MoeLoccJnd2_3ciCCy9n-CD5vDv0hVKME=.f67db96d-92e6-46a1-9bb6-4fe77c9a8c4e@github.com>
Message-ID: <XsreWIXeeqsN4tEL3lC0iX5ki7gVRmiu3WEH-FuSgUU=.fbdecc09-1108-4e0d-86d2-0ec8ff4c5342@github.com>

> Hi Reviewers,
> 
> Updated manual printer test cases with 'PassFailJFrame', also removed unused variables. Added 'SkippedException' in case of printer missing or not configured.
> 
> Please review and let me know your suggestions.
> 
> Regards,
> Renjith

Renjith Kannath Pariyangad has updated the pull request incrementally with one additional commit since the last revision:

  Updated instructions and access specifiers

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/17608/files
  - new: https://git.openjdk.org/jdk/pull/17608/files/bec0332e..69fe7d96

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=17608&range=11
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17608&range=10-11

  Stats: 14 lines in 3 files changed: 1 ins; 3 del; 10 mod
  Patch: https://git.openjdk.org/jdk/pull/17608.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17608/head:pull/17608

PR: https://git.openjdk.org/jdk/pull/17608

From rkannathpari at openjdk.org  Thu Mar  7 09:27:10 2024
From: rkannathpari at openjdk.org (Renjith Kannath Pariyangad)
Date: Thu, 7 Mar 2024 09:27:10 GMT
Subject: RFR: 8320676 : Manual printer tests have no Pass/Fail buttons,
 instructions close set 1 [v13]
In-Reply-To: <Afd90FypFvXYNR17jgkxcFj2LlxdLlZ1Bgd7WctdKcU=.2a8b05e0-a476-4598-8524-a22a0f54b8a5@github.com>
References: <Afd90FypFvXYNR17jgkxcFj2LlxdLlZ1Bgd7WctdKcU=.2a8b05e0-a476-4598-8524-a22a0f54b8a5@github.com>
Message-ID: <aJ38KyKWM4IMANDPnfed-auiBzf7my_YDpRfDOvq9Zg=.dddf005b-9d91-415b-b139-9e9b064a7880@github.com>

> Hi Reviewers,
> 
> Updated manual printer test cases with 'PassFailJFrame', also removed unused variables. Added 'SkippedException' in case of printer missing or not configured.
> 
> Please review and let me know your suggestions.
> 
> Regards,
> Renjith

Renjith Kannath Pariyangad has updated the pull request incrementally with one additional commit since the last revision:

  Updated instructions

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/17607/files
  - new: https://git.openjdk.org/jdk/pull/17607/files/8cb1d7d4..892be4a0

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=17607&range=12
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17607&range=11-12

  Stats: 8 lines in 3 files changed: 4 ins; 0 del; 4 mod
  Patch: https://git.openjdk.org/jdk/pull/17607.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17607/head:pull/17607

PR: https://git.openjdk.org/jdk/pull/17607

From abhiscxk at openjdk.org  Thu Mar  7 11:23:55 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Thu, 7 Mar 2024 11:23:55 GMT
Subject: RFR: 8075917: The regression-swing case failed as the text on
 label is not painted red with the GTK L&F [v5]
In-Reply-To: <9LaK7sRChE5CkU7okuhRSRhRGRFRfjlYrb7dvpE_oFo=.ac9b318d-c3c1-4df5-a880-2baffe8ef502@github.com>
References: <iDOTnLkAimOa5kfDerZ09n4wsYiFYYUyBflOTYeUQZ0=.293390bd-bc47-4871-bf4c-d23c191d9426@github.com>
 <5eZ7a0HiqE3hghw3sT0L0Zn4Mi1FFfofz6hLGdLOsoc=.445b16ac-4d91-4538-92ba-a74f17781535@github.com>
 <dPwYzsPLI8z4TUTMlwXFEKmddbkkjpifAqrM4b2XxeE=.ec943a1a-09b4-48ec-8ad1-bd64b936e2b2@github.com>
 <yQTL_So5Ud-76evgwEePTvcDSxYXVy0kwN6j_mQwrc0=.12bb609a-b841-480c-9e35-4297f0de6c48@github.com>
 <vAIQHEffW4Eq54K_v5vYvLpyfEXzwG74D8wy5-syJxM=.05d14f36-f4a5-491a-b9a7-f7be14201b0c@github.com>
 <9LaK7sRChE5CkU7okuhRSRhRGRFRfjlYrb7dvpE_oFo=.ac9b318d-c3c1-4df5-a880-2baffe8ef502@github.com>
Message-ID: <usrU7DN7mu9Dp569LTabmhgWBJXCpjxbzSKKk1x_aOI=.cbacbc4a-0f4f-421e-ba64-3a40d4f50e2d@github.com>

On Wed, 6 Mar 2024 08:57:07 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Backtracking a bit, regarding `Label.foreground` why it needs to be done here?
>> 
>> Other L&F, it is added in corresponding LookAndFeel class
>> for example, in [Metal](https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/javax/swing/plaf/metal/MetalLookAndFeel.java#L1001)
>> and in [Windows](https://github.com/openjdk/jdk/blob/master/src/java.desktop/windows/classes/com/sun/java/swing/plaf/windows/WindowsLookAndFeel.java#L880)
>> etc
>> so I think it is needed to be added in GTKLookAndFeel class
>> 
>> and additionally there is setting of `Label.foreground` and other Label. property in BasicLabelUI.java [installDefaults](https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/javax/swing/plaf/basic/BasicLabelUI.java#L368)
>> but we dont do it for Nimbus or GTK or Synth so I guess we need to call `super.installDefaults(c)` in SynthLabelUI class since there is no GTKLabelUI class
>> or 
>> maybe do
>> `LookAndFeel.installColorsAndFont(c, "Label.background", "Label.foreground", "Label.font");` alone to avoid other properties being set and to not fallback
>> 
>> Please check if it will work
>> and if it does, then we need to employ similar for checbox/radiobutton/togglebutton
>
> I will check and update.

> Backtracking a bit, regarding `Label.foreground` why it needs to be done here?
> 
> Other L&F, it is added in corresponding LookAndFeel class for example, in [Metal](https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/javax/swing/plaf/metal/MetalLookAndFeel.java#L1001) and in [Windows](https://github.com/openjdk/jdk/blob/master/src/java.desktop/windows/classes/com/sun/java/swing/plaf/windows/WindowsLookAndFeel.java#L880) etc so I think it is needed to be added in GTKLookAndFeel class

IN GTKLookAndFeel, the color is returned specific to the style and state from native side . So, even if it is not added the default color for enabled, disabled or any other state is returned by native. Whereas In Metal the color is set by using UIManager define color.

> and additionally there is setting of Label.foreground and other Label. property in BasicLabelUI.java [installDefaults](https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/javax/swing/plaf/basic/BasicLabelUI.java#L368)
but we dont do it for Nimbus or GTK or Synth so I guess we need to call super.installDefaults(c) in SynthLabelUI class since there is no GTKLabelUI class
or
maybe do
LookAndFeel.installColorsAndFont(c, "Label.background", "Label.foreground", "Label.font"); alone to avoid other properties being set and to not fallback

This properties are set via SynthStyle `installDefaults` method where the foreground, background are set by getting the value from `getColorForState` method. So, calling super.installDefaults(c) in SynthLabelUI will not make any difference.

I checked for JLabel properties set in enabled and disabled state. 


In Nimbus LAF
            UIManager.getDefaults().put("Label[Enabled].textForeground", labelColor);
            UIManager.getDefaults().put("Label[Disabled].textForeground", labelDisabledColor);

Other LAF
            UIManager.getDefaults().put("Label.foreground", labelColor);
            UIManager.getDefaults().put("Label.disabledForeground", labelDisabledColor);


It works as expected for Metal and GTK. For Nimbus LAF, disabled color is not painted correctly. In stead the default color specified in skin.laf is rendered.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17763#discussion_r1515994970

From dmarkov at openjdk.org  Thu Mar  7 12:36:05 2024
From: dmarkov at openjdk.org (Dmitry Markov)
Date: Thu, 7 Mar 2024 12:36:05 GMT
Subject: RFR: 8326661: sun/java2d/cmm/ColorConvertOp/ColConvTest.java
 assumes profiles were generated by LCMS [v2]
In-Reply-To: <nFplnFr0UPf-gWrZjoyZhb2pCJ_fjUEieIxTlWesSNs=.7f372d25-5bc5-4fb2-9ecd-8d5e40cc69b8@github.com>
References: <nFplnFr0UPf-gWrZjoyZhb2pCJ_fjUEieIxTlWesSNs=.7f372d25-5bc5-4fb2-9ecd-8d5e40cc69b8@github.com>
Message-ID: <FLf1tladgJ4PCOzVIcNUHaXrbSezgSfiZVtFkwfDCoo=.75437269-3d71-45c4-9372-5c0566ae2312@github.com>

> Updated several tests to avoid potential failure with recent LCMS update and non-LCMS generated profile.

Dmitry Markov has updated the pull request incrementally with one additional commit since the last revision:

  Tolerance update

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18097/files
  - new: https://git.openjdk.org/jdk/pull/18097/files/27d436fb..89557165

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18097&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18097&range=00-01

  Stats: 37 lines in 3 files changed: 30 ins; 0 del; 7 mod
  Patch: https://git.openjdk.org/jdk/pull/18097.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18097/head:pull/18097

PR: https://git.openjdk.org/jdk/pull/18097

From dmarkov at openjdk.org  Thu Mar  7 12:36:06 2024
From: dmarkov at openjdk.org (Dmitry Markov)
Date: Thu, 7 Mar 2024 12:36:06 GMT
Subject: RFR: 8326661: sun/java2d/cmm/ColorConvertOp/ColConvTest.java
 assumes profiles were generated by LCMS [v2]
In-Reply-To: <PuQ3oGFIK3A35zfbSDtT3tRfzVmYyqjxgokbG7jfqSY=.d1d26d54-b9d5-4e82-9c8f-769a965a2d44@github.com>
References: <nFplnFr0UPf-gWrZjoyZhb2pCJ_fjUEieIxTlWesSNs=.7f372d25-5bc5-4fb2-9ecd-8d5e40cc69b8@github.com>
 <6aO1JMWfnuzwP6QH4GVnI9YW7nW8XygymJvsjVU0ykY=.cbf6f144-4a45-428e-9ae3-eacd67641e94@github.com>
 <PuQ3oGFIK3A35zfbSDtT3tRfzVmYyqjxgokbG7jfqSY=.d1d26d54-b9d5-4e82-9c8f-769a965a2d44@github.com>
Message-ID: <Dk8hEFbO8v4sweXxToR-wjNgKCw2GTBXpgpP_jPwG5k=.07e58905-3c2d-45da-b528-f54e03f4b4b3@github.com>

On Tue, 5 Mar 2024 03:49:01 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>> test/jdk/sun/java2d/cmm/ColorConvertOp/ColConvCCMTest.java line 63:
>> 
>>> 61:         10.5,       // GRAY
>>> 62:         215.0,      // PYCC
>>> 63:         56.0        // CIEXYZ
>> 
>> All this change will delete all information about "old and good" values and start to use lcms thresholds for all profiles? I think it should be the opposite - use the good data for all except lcms(or any other not that good as jdk8 profiles), like we do it now.
>
> Actually the purpose of these particular tests is validation of the quality of the built-in color profiles.

I agree, I reverted almost all changes except the ones in tolerance for non-LCMS profiles. That values need to be updated to make the test pass on JDKs (e.g. JDK 8u, etc) where non-LCMS profiles are used

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18097#discussion_r1516077519

From abhiscxk at openjdk.org  Thu Mar  7 12:44:55 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Thu, 7 Mar 2024 12:44:55 GMT
Subject: RFR: 8075917: The regression-swing case failed as the text on
 label is not painted red with the GTK L&F [v5]
In-Reply-To: <usrU7DN7mu9Dp569LTabmhgWBJXCpjxbzSKKk1x_aOI=.cbacbc4a-0f4f-421e-ba64-3a40d4f50e2d@github.com>
References: <iDOTnLkAimOa5kfDerZ09n4wsYiFYYUyBflOTYeUQZ0=.293390bd-bc47-4871-bf4c-d23c191d9426@github.com>
 <5eZ7a0HiqE3hghw3sT0L0Zn4Mi1FFfofz6hLGdLOsoc=.445b16ac-4d91-4538-92ba-a74f17781535@github.com>
 <dPwYzsPLI8z4TUTMlwXFEKmddbkkjpifAqrM4b2XxeE=.ec943a1a-09b4-48ec-8ad1-bd64b936e2b2@github.com>
 <yQTL_So5Ud-76evgwEePTvcDSxYXVy0kwN6j_mQwrc0=.12bb609a-b841-480c-9e35-4297f0de6c48@github.com>
 <vAIQHEffW4Eq54K_v5vYvLpyfEXzwG74D8wy5-syJxM=.05d14f36-f4a5-491a-b9a7-f7be14201b0c@github.com>
 <9LaK7sRChE5CkU7okuhRSRhRGRFRfjlYrb7dvpE_oFo=.ac9b318d-c3c1-4df5-a880-2baffe8ef502@github.com>
 <usrU7DN7mu9Dp569LTabmhgWBJXCpjxbzSKKk1x_aOI=.cbacbc4a-0f4f-421e-ba64-3a40d4f50e2d@github.com>
Message-ID: <W4XgJDzMm6nQOFMOjxvsHh61ScOOtwyxqWodk44vcp8=.4e0a0699-ffe0-4fe6-a8f6-49d465f44882@github.com>

On Thu, 7 Mar 2024 11:21:35 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

> It works as expected for Metal and GTK. For Nimbus LAF, disabled color is not painted correctly. In stead the default color specified in skin.laf is rendered.

For HTML text, disabled state doesn't render in LAF defined color for Metal and GTK as well.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17763#discussion_r1516089603

From aivanov at openjdk.org  Thu Mar  7 15:06:57 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Thu, 7 Mar 2024 15:06:57 GMT
Subject: RFR: 8327492: Remove applet usage and update
 DisposeInActionEventTest.html [v11]
In-Reply-To: <xBLwOrYHGNchmi4gDrF18OYHkqMPV1NY9fmteg0AyiU=.adfe4b00-5815-4ba2-b991-4a1672302431@github.com>
References: <wbQWXZ3sLQB90OPGZTWuifQuxdk7bFfiouu2NzUEzHQ=.310c2f89-b621-4f34-a949-1f319bcac8ce@github.com>
 <xBLwOrYHGNchmi4gDrF18OYHkqMPV1NY9fmteg0AyiU=.adfe4b00-5815-4ba2-b991-4a1672302431@github.com>
Message-ID: <SUR8mt1xV1gZQBJ1XXn_nh9rNcThlQW0tk1TdA-wmPw=.e54655c7-a56e-4829-a88d-6a137c5e6200@github.com>

On Wed, 6 Mar 2024 21:36:10 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> Root cause of the test failure was fixed with https://bugs.openjdk.org/browse/JDK-8316931, updating this test since the other fix also included a test update.
>
> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   null check for system tray before remove

test/jdk/java/awt/TrayIcon/DisposeInActionEventTest/DisposeInActionEventTest.java line 63:

> 61:                        "  (also called Taskbar Status Area on MS Windows, Notification\n" +
> 62:                        "  Area on Gnome or System Tray on KDE) is visible.\n\n" +
> 63:                         clickInstruction + " the button on the tray icon to trigger the\n" +

What I see on Windows: ?Double click _the button_ on the tray icon to trigger the??

What button do I need to click?

test/jdk/java/awt/TrayIcon/DisposeInActionEventTest/DisposeInActionEventTest.java line 65:

> 63:                         clickInstruction + " the button on the tray icon to trigger the\n" +
> 64:                        "  action event. Brief information about action events is printed\n" +
> 65:                        "  in the frame. After each action event the tray icon is removed from\n" +

Suggestion:

                       "  in the frame. After each action event, the tray icon is removed from\n" +

test/jdk/java/awt/TrayIcon/DisposeInActionEventTest/DisposeInActionEventTest.java line 68:

> 66:                        "  the tray and then added back in a second.\n\n" +
> 67:                        "The test performs some automatic checks when removing the icon. If\n" +
> 68:                        "  something is wrong the corresponding message the test will automatically fail.\n" +

Suggestion:

                       "  something is wrong, the test will automatically fail.\n" +

test/jdk/java/awt/TrayIcon/DisposeInActionEventTest/DisposeInActionEventTest.java line 70:

> 68:                        "  something is wrong the corresponding message the test will automatically fail.\n" +
> 69:                        "  Repeat clicks several times. If no 'Test FAILED' messages\n" +
> 70:                        "  are printed, press PASS button else FAIL button.";

Suggestion:

                       "\n" +
                       "Repeat clicks several times. Press PASS button.";

Perhaps, the instructions need to be re-worked further.

The tester needs to perform the action several times. The test will fail automatically if anything's wrong. If it doesn't, press the Pass button.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17838#discussion_r1516286794
PR Review Comment: https://git.openjdk.org/jdk/pull/17838#discussion_r1516287544
PR Review Comment: https://git.openjdk.org/jdk/pull/17838#discussion_r1516288497
PR Review Comment: https://git.openjdk.org/jdk/pull/17838#discussion_r1516295653

From aivanov at openjdk.org  Thu Mar  7 15:10:59 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Thu, 7 Mar 2024 15:10:59 GMT
Subject: RFR: 8327492: Remove applet usage and update
 DisposeInActionEventTest.html [v10]
In-Reply-To: <v59XG0MTZ_ybXZqfMGeJ5HG66UTvbCLDPbBda2xXrEg=.9d30e0f9-01f2-425c-9e15-bc9f8ce09562@github.com>
References: <wbQWXZ3sLQB90OPGZTWuifQuxdk7bFfiouu2NzUEzHQ=.310c2f89-b621-4f34-a949-1f319bcac8ce@github.com>
 <wqOujoNLfVeUa9JAk0YP6R9tJdU_SlQdJOx5TipMmwg=.b68ee2df-e459-4b37-86ce-e0d123084249@github.com>
 <v59XG0MTZ_ybXZqfMGeJ5HG66UTvbCLDPbBda2xXrEg=.9d30e0f9-01f2-425c-9e15-bc9f8ce09562@github.com>
Message-ID: <J9xvMYDXdifN1xKpVsQHEqOcwglB8I2nJpi-AtehsVQ=.530aea8a-6832-49a4-bbf4-679c48f85d4c@github.com>

On Wed, 6 Mar 2024 20:47:53 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   implemented changes from feedback
>
> test/jdk/java/awt/TrayIcon/DisposeInActionEventTest/DisposeInActionEventTest.java line 84:
> 
>> 82:         } finally {
>> 83:             systemTray.remove(trayIcon);
>> 84:         }
> 
> @alisenchung I missed adding null check here earlier. It is good to have this safety check to avoid NPE.
> 
> Suggestion:
> 
>         } finally {
>             if (systemTray != null) {
>                systemTray.remove(trayIcon);
>             }
>          }

`SystemTray.getSystemTray()` can't return `null`. However, the static field `systemTray` can remain `null` in the test.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17838#discussion_r1516326933

From aivanov at openjdk.org  Thu Mar  7 15:06:55 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Thu, 7 Mar 2024 15:06:55 GMT
Subject: RFR: 8327492: Remove applet usage and update
 DisposeInActionEventTest.html [v8]
In-Reply-To: <mPvn_WjxPnMa3HI9F7_FoodKV6HE4ByrZKjO8QPyyNA=.8391487e-3a1e-41b2-acea-337911c2075e@github.com>
References: <wbQWXZ3sLQB90OPGZTWuifQuxdk7bFfiouu2NzUEzHQ=.310c2f89-b621-4f34-a949-1f319bcac8ce@github.com>
 <l1ADMFQYCId4N3tn4FSvNm3Witml58Bqdk-D7E2Pm78=.2932bed0-580f-44fb-931d-b71d75533de5@github.com>
 <2xTHQDg4I2rN2PtBL1FdX-0r_djhoEFoEqYqsFdJaGc=.ee551abe-90d2-4664-a038-73f204d0692f@github.com>
 <mPvn_WjxPnMa3HI9F7_FoodKV6HE4ByrZKjO8QPyyNA=.8391487e-3a1e-41b2-acea-337911c2075e@github.com>
Message-ID: <fDiQS5ddIdv7gtH9LGO38ObSPlG-SKV3tMpCO9alIhQ=.1b10dcf3-af82-4485-9f8d-93363e26c76b@github.com>

On Wed, 28 Feb 2024 14:29:24 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> test/jdk/java/awt/TrayIcon/DisposeInActionEventTest/DisposeInActionEventTest.java line 60:
>> 
>>> 58:                        "  (also called Taskbar Status Area on MS Windows, Notification\n" +
>>> 59:                        "  Area on Gnome or System Tray on KDE) is visible.\n\n" +
>>> 60:                         clickInstruction + " the button on the tray icon to trigger the\n" +
>> 
>> _?Right-click the button?_ or _?Double-left click the button?_ doesn't make sense to me.
>
> The recent update didn't clarify it, now the text reads _?Right-click the button?_ or _?Double click the button?_.
> 
> I assume _?the button?_ refers to the mouse button. But it's very confusing, it's not clear what is required; because ?right-click? and ?double-click? already define which _mouse button_ to use.
> 
> What you want to say is _?Right-click / Double-click on **the tray icon**??_

It is not resolved.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17838#discussion_r1516284965

From aivanov at openjdk.org  Thu Mar  7 15:06:59 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Thu, 7 Mar 2024 15:06:59 GMT
Subject: RFR: 8327492: Remove applet usage and update
 DisposeInActionEventTest.html [v8]
In-Reply-To: <2xTHQDg4I2rN2PtBL1FdX-0r_djhoEFoEqYqsFdJaGc=.ee551abe-90d2-4664-a038-73f204d0692f@github.com>
References: <wbQWXZ3sLQB90OPGZTWuifQuxdk7bFfiouu2NzUEzHQ=.310c2f89-b621-4f34-a949-1f319bcac8ce@github.com>
 <l1ADMFQYCId4N3tn4FSvNm3Witml58Bqdk-D7E2Pm78=.2932bed0-580f-44fb-931d-b71d75533de5@github.com>
 <2xTHQDg4I2rN2PtBL1FdX-0r_djhoEFoEqYqsFdJaGc=.ee551abe-90d2-4664-a038-73f204d0692f@github.com>
Message-ID: <tBxKeDRpFjgWDOqhNXWXyWt-B6oDrKpSX0pWXzDLaY8=.922f3e08-c99a-4a77-aeb1-92dbe22938c5@github.com>

On Tue, 27 Feb 2024 11:01:50 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   remove system property set
>
> test/jdk/java/awt/TrayIcon/DisposeInActionEventTest/DisposeInActionEventTest.java line 67:
> 
>> 65:                        "  something is wrong the corresponding message is displayed below.\n" +
>> 66:                        "  Repeat clicks several times. If no 'Test FAILED' messages\n" +
>> 67:                        "  are printed, press PASS button else FAIL button.";
> 
> It's not displayed below, it's to the right, isn't it?
> 
> Fail the test automatically if you can detect the failure. You may show a message to the tester about the failure before shutting down the test.

This comment also implied amending the instructions to correspond to what the test does.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17838#discussion_r1516304874

From aivanov at openjdk.org  Thu Mar  7 15:13:57 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Thu, 7 Mar 2024 15:13:57 GMT
Subject: RFR: 8327492: Remove applet usage and update
 DisposeInActionEventTest.html [v11]
In-Reply-To: <xBLwOrYHGNchmi4gDrF18OYHkqMPV1NY9fmteg0AyiU=.adfe4b00-5815-4ba2-b991-4a1672302431@github.com>
References: <wbQWXZ3sLQB90OPGZTWuifQuxdk7bFfiouu2NzUEzHQ=.310c2f89-b621-4f34-a949-1f319bcac8ce@github.com>
 <xBLwOrYHGNchmi4gDrF18OYHkqMPV1NY9fmteg0AyiU=.adfe4b00-5815-4ba2-b991-4a1672302431@github.com>
Message-ID: <mSJyBrXS6hhz9bcY88cpvWT8L1LpmaK9xbmY9lweOoM=.d14405ef-37bb-4fc6-aa53-b50658e6d0c1@github.com>

On Wed, 6 Mar 2024 21:36:10 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> Root cause of the test failure was fixed with https://bugs.openjdk.org/browse/JDK-8316931, updating this test since the other fix also included a test update.
>
> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   null check for system tray before remove

Changes requested by aivanov (Reviewer).

test/jdk/java/awt/TrayIcon/ShowAfterDisposeTest/ShowAfterDisposeTest.java line 1:

> 1: /*

Does it make sense to remove the tray icon in this test as well when the test exits?

-------------

PR Review: https://git.openjdk.org/jdk/pull/17838#pullrequestreview-1922717083
PR Review Comment: https://git.openjdk.org/jdk/pull/17838#discussion_r1516328831

From aivanov at openjdk.org  Thu Mar  7 16:15:56 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Thu, 7 Mar 2024 16:15:56 GMT
Subject: RFR: 8309460: JScrollBar leaves behind clutter for non-integer UI
 scales
In-Reply-To: <_6SbN6tphlitPw-J5TpQvgj3UMurM1t5kh-GtGlfs5s=.2464e138-4db5-44f6-8967-c7fc7e4f5caa@github.com>
References: <rCPfSr4i9XMwmlsosHjTcndrV-MH_azYNzfJIl-PIhA=.1fe07ef4-1fac-4cc2-a332-fcc9473943ed@github.com>
 <_6SbN6tphlitPw-J5TpQvgj3UMurM1t5kh-GtGlfs5s=.2464e138-4db5-44f6-8967-c7fc7e4f5caa@github.com>
Message-ID: <MEdUWC1VCSLhqOwlcv1cbLKnw-rDUxmUORgIZGztRe0=.b52f7898-c994-483a-82f1-8868aa73caf3@github.com>

On Wed, 24 Jan 2024 21:11:25 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> > > Because float scale results in fractional pixels?  
> > > If the scale is 1.25, then 1 pixel is 1.25 physical pixels; 2 pixels are 2.5 physical pixels and so on.
> > 
> > Initially this issue looked similar to fractional scaling issues such as border rendering issues observed on windows previously but it seems to happen only on non-standard fractional UI scales such as 2.3, 2.7 and not on standard fractional scales supported on windows (1.25,1.75,2.25 ..) [#17484 (review)](https://github.com/openjdk/jdk/pull/17484#pullrequestreview-1834275178).
> 
> The underlying problem is still the same: there are fractional pixels.

I ran the test now and I'm sure the problem is very similar. When drag the thumb, the width of the left border is usually 2 pixels, sometimes it changes to 3 pixels. As I move farther, that third pixel remains on the background of the scrollbar.

The left over pixels create a regular pattern: 17 pixels followed by 8 pixels, then the cycle repeats. These are physical display pixels.

If you convert user space pixels to physical pixels, you'll see there's a pattern where fraction adds up to whole pixel: 4 user pixels, 3 user pixels.

As you drag the thumb, you can see that the highlight/shadow lines on the thumb itself dance.

This means that as you drag the thumb, the app sees 1-pixel increments which results in 2-pixel and 3-pixel increments on the screen.


> How it related to the "non-standard" fractional metrics(such as 2.3, 2.7) and why it works fine for 1.5 and 1.75.

I believe I explained how it's related to fractional scales. Why does it work for 1.25 and 1.75? I guess we never end up in a situation where a physical pixel doesn't get painted. With 1.5, the probability is even less.

You can still see the width of the left (and right) border changes; the highlight and shadow lines on the thumb continue to dance.

There are this kind of problems wherever pixels are painted by 1-pixel lines. Look at the title bar of a JInternalFrame in SwingSet2 as drag it: the pattern changes even at 1.5 scale; dragging at 1.25 and 1.75 gives another pattern.

> If we draw a border outside of the component that border should be fixed. If the clear/fillRect does not clear the component then we should fix the calculation of the bounds.

No, we don't draw outside of component bounds. We just don't repaint enough pixels as thumb is moved.

As you rightfully noticed something different is needed. Repainting the bounds of the thumb still solves the problem but it doesn't seem right.

As the thumb is dragged, it's repainted in the new location; the old location is erased eventually. When erasure is handled, I'd adjust the left coordinate to be (left - 1) to repaint a larger rectangle or something like this.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17484#issuecomment-1983874053

From aivanov at openjdk.org  Thu Mar  7 16:22:55 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Thu, 7 Mar 2024 16:22:55 GMT
Subject: RFR: 8309460: JScrollBar leaves behind clutter for non-integer UI
 scales [v2]
In-Reply-To: <vuA-OniT8EEWjjHFZF0bRcfbzKONAZrv6KtWFpjkInE=.f754647f-96e9-4d7f-ada8-60f019855746@github.com>
References: <rCPfSr4i9XMwmlsosHjTcndrV-MH_azYNzfJIl-PIhA=.1fe07ef4-1fac-4cc2-a332-fcc9473943ed@github.com>
 <MyVHyLhuv1JNPyQBmi69yDvbEkb-FtINJVwO45QUUwc=.47cab43e-d4d7-4224-8030-5cb2b1dded34@github.com>
 <vuA-OniT8EEWjjHFZF0bRcfbzKONAZrv6KtWFpjkInE=.f754647f-96e9-4d7f-ada8-60f019855746@github.com>
Message-ID: <nXCiBln58X2HZXFgJSz5nw-Z09aSb3aYEA1tpH9hfSI=.762a575c-55bc-45da-b3ed-a6245d0abb80@github.com>

On Thu, 22 Feb 2024 05:50:11 GMT, Tejesh R <tr at openjdk.org> wrote:

> The test can be converted to automatic by comparing the captured scroll area before MousePress and between MousePress and Release events.

I agree, the test can be automatic. Grab the thumb with robot and move to the right edge. Without releasing the left mouse button?, create a multiresolution screenshot to get all the pixels without scaling the image down. The background of the scrollbar on the captured screenshot should not contain darker pixels.

? After you release the mouse button, the position of the thumb is adjusted, and the entire scrollbar is repainted. At which point, the leftover darker lines disappear from the scrollbar background.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17484#issuecomment-1983889766

From achung at openjdk.org  Thu Mar  7 16:33:00 2024
From: achung at openjdk.org (Alisen Chung)
Date: Thu, 7 Mar 2024 16:33:00 GMT
Subject: RFR: 8327492: Remove applet usage and update
 DisposeInActionEventTest.html [v11]
In-Reply-To: <SUR8mt1xV1gZQBJ1XXn_nh9rNcThlQW0tk1TdA-wmPw=.e54655c7-a56e-4829-a88d-6a137c5e6200@github.com>
References: <wbQWXZ3sLQB90OPGZTWuifQuxdk7bFfiouu2NzUEzHQ=.310c2f89-b621-4f34-a949-1f319bcac8ce@github.com>
 <xBLwOrYHGNchmi4gDrF18OYHkqMPV1NY9fmteg0AyiU=.adfe4b00-5815-4ba2-b991-4a1672302431@github.com>
 <SUR8mt1xV1gZQBJ1XXn_nh9rNcThlQW0tk1TdA-wmPw=.e54655c7-a56e-4829-a88d-6a137c5e6200@github.com>
Message-ID: <wt-nLKk3u-W-OabmZbZTcK3oJLqOrMEyJgn0HE8aez8=.c9ab2348-5d1c-47ca-a30b-096facc3cca0@github.com>

On Thu, 7 Mar 2024 14:53:22 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   null check for system tray before remove
>
> test/jdk/java/awt/TrayIcon/DisposeInActionEventTest/DisposeInActionEventTest.java line 63:
> 
>> 61:                        "  (also called Taskbar Status Area on MS Windows, Notification\n" +
>> 62:                        "  Area on Gnome or System Tray on KDE) is visible.\n\n" +
>> 63:                         clickInstruction + " the button on the tray icon to trigger the\n" +
> 
> What I see on Windows: ?Double click _the button_ on the tray icon to trigger the??
> 
> What button do I need to click?

On windows you need to left click twice, on macos you need to right click once

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17838#discussion_r1516477638

From clanger at openjdk.org  Thu Mar  7 16:35:11 2024
From: clanger at openjdk.org (Christoph Langer)
Date: Thu, 7 Mar 2024 16:35:11 GMT
Subject: RFR: 8185862: AWT Assertion Failure in ::GetDIBits(hBMDC, hBM, 0, 
 1, 0, gpBitmapInfo, 0) 'awt_Win32GraphicsDevice.cpp',
 at line 185 [v10]
In-Reply-To: <Cj_htOZE6ImXdNmj43IBiX7rW4Em4ZF-6kx0qIZW-Ho=.d355fedd-7ec8-463d-969b-e2123987d1dd@github.com>
References: <Cj_htOZE6ImXdNmj43IBiX7rW4Em4ZF-6kx0qIZW-Ho=.d355fedd-7ec8-463d-969b-e2123987d1dd@github.com>
Message-ID: <CLMpdyIqPLzz0VGTbav9mRDzKrFXKkb0NH5ExsZagSo=.afc8c41b-9ea6-4c78-8354-9db196b8ace3@github.com>

> The assertions reported in the bug were observed spuriously and here and there broke tests in some Windows configurations.
> For instance [JDK-8266129](https://bugs.openjdk.org/browse/JDK-8266129), [JDK-8269529](https://bugs.openjdk.org/browse/JDK-8269529) or [JDK-8323664](https://bugs.openjdk.org/browse/JDK-8323664) came up due to this.
> 
> The problem is that in Windows environments without a valid display, e.g. started by system services or via PowerShell Remoting, one sees a Monitor with name 'Windisc' in `EnumDisplayMonitors`.
> However, it seems to be some kind of a pseudo device where you can not get a DC via `CreateDC`. This behavior/monitor type doesn't seem to be well documented, though.
> 
> I hereby modify the device initialization code to only count/detect monitors where CreateDC returns non-NULL in Devices.cpp. I also add some more checking/error handling to AwtWin32GraphicsDevice::Initialize() for correctness.
> 
> Furthermore, I re-enable the test `javax/swing/reliability/HangDuringStaticInitialization.java` for Windows Debug VMs, which reverts the fix from JDK-8269529 that should not be necessary any more.

Christoph Langer has updated the pull request incrementally with one additional commit since the last revision:

  Revert touching awt_Win32GraphicsDevice.cpp altogether and remove unnecessary private method for hasDisplays()

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/17614/files
  - new: https://git.openjdk.org/jdk/pull/17614/files/002fba2d..2f378c88

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=17614&range=09
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17614&range=08-09

  Stats: 15 lines in 2 files changed: 0 ins; 13 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/17614.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17614/head:pull/17614

PR: https://git.openjdk.org/jdk/pull/17614

From aivanov at openjdk.org  Thu Mar  7 16:39:55 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Thu, 7 Mar 2024 16:39:55 GMT
Subject: RFR: 8327492: Remove applet usage and update
 DisposeInActionEventTest.html [v11]
In-Reply-To: <wt-nLKk3u-W-OabmZbZTcK3oJLqOrMEyJgn0HE8aez8=.c9ab2348-5d1c-47ca-a30b-096facc3cca0@github.com>
References: <wbQWXZ3sLQB90OPGZTWuifQuxdk7bFfiouu2NzUEzHQ=.310c2f89-b621-4f34-a949-1f319bcac8ce@github.com>
 <xBLwOrYHGNchmi4gDrF18OYHkqMPV1NY9fmteg0AyiU=.adfe4b00-5815-4ba2-b991-4a1672302431@github.com>
 <SUR8mt1xV1gZQBJ1XXn_nh9rNcThlQW0tk1TdA-wmPw=.e54655c7-a56e-4829-a88d-6a137c5e6200@github.com>
 <wt-nLKk3u-W-OabmZbZTcK3oJLqOrMEyJgn0HE8aez8=.c9ab2348-5d1c-47ca-a30b-096facc3cca0@github.com>
Message-ID: <kUUmURztPD7ryyoE1TjtrJz-yEFQuIyXEvAQaSlds_k=.d61926e1-b850-48cd-9359-35fd3ca9636a@github.com>

On Thu, 7 Mar 2024 16:30:32 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> test/jdk/java/awt/TrayIcon/DisposeInActionEventTest/DisposeInActionEventTest.java line 63:
>> 
>>> 61:                        "  (also called Taskbar Status Area on MS Windows, Notification\n" +
>>> 62:                        "  Area on Gnome or System Tray on KDE) is visible.\n\n" +
>>> 63:                         clickInstruction + " the button on the tray icon to trigger the\n" +
>> 
>> What I see on Windows: ?Double click _the button_ on the tray icon to trigger the??
>> 
>> What button do I need to click?
>
> On windows you need to left click twice, on macos you need to right click once

[I did suggest clearer instructions](https://github.com/openjdk/jdk/pull/17838#discussion_r1506056726):

                        clickInstruction + " on the tray icon to trigger the\n" +

You ignored it and marked resolved.

In the current instructions, _?the button?_ does not refer to anything obvious. What button? It's confusing. Remove _?the button?_ from the instructions, and the instructions are clear: _?Right-click / Double-click on **the tray icon**??_

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17838#discussion_r1516487194

From aivanov at openjdk.org  Thu Mar  7 16:47:57 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Thu, 7 Mar 2024 16:47:57 GMT
Subject: RFR: 8185862: AWT Assertion Failure in ::GetDIBits(hBMDC, hBM, 0, 
 1, 0, gpBitmapInfo, 0) 'awt_Win32GraphicsDevice.cpp',
 at line 185 [v10]
In-Reply-To: <CLMpdyIqPLzz0VGTbav9mRDzKrFXKkb0NH5ExsZagSo=.afc8c41b-9ea6-4c78-8354-9db196b8ace3@github.com>
References: <Cj_htOZE6ImXdNmj43IBiX7rW4Em4ZF-6kx0qIZW-Ho=.d355fedd-7ec8-463d-969b-e2123987d1dd@github.com>
 <CLMpdyIqPLzz0VGTbav9mRDzKrFXKkb0NH5ExsZagSo=.afc8c41b-9ea6-4c78-8354-9db196b8ace3@github.com>
Message-ID: <2W66O6KYwhgNV0b9M7rfEv8Ttx5Kef77ga_5yL0rtRQ=.b348f2f3-4800-4dc5-bb33-7d7d4dcc1802@github.com>

On Thu, 7 Mar 2024 16:35:11 GMT, Christoph Langer <clanger at openjdk.org> wrote:

>> The assertions reported in the bug were observed spuriously and here and there broke tests in some Windows configurations.
>> For instance [JDK-8266129](https://bugs.openjdk.org/browse/JDK-8266129), [JDK-8269529](https://bugs.openjdk.org/browse/JDK-8269529) or [JDK-8323664](https://bugs.openjdk.org/browse/JDK-8323664) came up due to this.
>> 
>> The problem is that in Windows environments without a valid display, e.g. started by system services or via PowerShell Remoting, one sees a Monitor with name 'Windisc' in `EnumDisplayMonitors`.
>> However, it seems to be some kind of a pseudo device where you can not get a DC via `CreateDC`. This behavior/monitor type doesn't seem to be well documented, though.
>> 
>> I hereby modify the device initialization code to only count/detect monitors where CreateDC returns non-NULL in Devices.cpp. I also add some more checking/error handling to AwtWin32GraphicsDevice::Initialize() for correctness.
>> 
>> Furthermore, I re-enable the test `javax/swing/reliability/HangDuringStaticInitialization.java` for Windows Debug VMs, which reverts the fix from JDK-8269529 that should not be necessary any more.
>
> Christoph Langer has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Revert touching awt_Win32GraphicsDevice.cpp altogether and remove unnecessary private method for hasDisplays()

Marked as reviewed by aivanov (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/17614#pullrequestreview-1922978004

From clanger at openjdk.org  Thu Mar  7 16:47:58 2024
From: clanger at openjdk.org (Christoph Langer)
Date: Thu, 7 Mar 2024 16:47:58 GMT
Subject: RFR: 8185862: AWT Assertion Failure in ::GetDIBits(hBMDC, hBM, 0, 
 1, 0, gpBitmapInfo, 0) 'awt_Win32GraphicsDevice.cpp', at line 185 [v8]
In-Reply-To: <ubIMuslFuA6dnnzBlg8TSqNM04SKIR6lVH0WYXi_5_Q=.ad3e17c4-f46b-498d-a53c-f168974bcc6c@github.com>
References: <Cj_htOZE6ImXdNmj43IBiX7rW4Em4ZF-6kx0qIZW-Ho=.d355fedd-7ec8-463d-969b-e2123987d1dd@github.com>
 <yLFbIvVt-ZuGKMVJvXx19rUxVgG1-ewJwM5SAEzoUvo=.15df7df6-0c62-4c60-837c-33fdf90eab11@github.com>
 <cHpGX06SvmwmJasYHGMOITL9-56HUoOeNEJQDPOw8E4=.1ab5aabb-7d6c-465a-bda9-5ae8cc232669@github.com>
 <VWpIOVnSQcdADE5bvLDIVfssDgA_2JcgICRlCGpO2bY=.1861dbb3-2bfc-4fc4-a9ba-8ed942380a9d@github.com>
 <ubIMuslFuA6dnnzBlg8TSqNM04SKIR6lVH0WYXi_5_Q=.ad3e17c4-f46b-498d-a53c-f168974bcc6c@github.com>
Message-ID: <CFtVQya5Gl1eWf37e3X8nboii2TPLqwK_AnzWr6qsEQ=.e4f0d043-e81e-4858-8a3f-4c3773a0d194@github.com>

On Wed, 6 Mar 2024 08:29:01 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Maybe. I think, as Phil already mentions, a cleanup/centralization of the places that load libawt should be done. But I would suggest to do this in a separate issue.
>
> Sounds reasonable. Will you create a CR for this? So that we won't forget about it.

Done: https://bugs.openjdk.org/browse/JDK-8327616

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17614#discussion_r1516488647

From clanger at openjdk.org  Thu Mar  7 16:48:00 2024
From: clanger at openjdk.org (Christoph Langer)
Date: Thu, 7 Mar 2024 16:48:00 GMT
Subject: RFR: 8185862: AWT Assertion Failure in ::GetDIBits(hBMDC, hBM, 0, 
 1, 0, gpBitmapInfo, 0) 'awt_Win32GraphicsDevice.cpp', at line 185 [v9]
In-Reply-To: <wOn70EG_LG5YDTn09bX1Q28PVgKJ7hMGW_s7ssUWTho=.f46803c0-77c5-40f0-8be1-37cc42338a85@github.com>
References: <Cj_htOZE6ImXdNmj43IBiX7rW4Em4ZF-6kx0qIZW-Ho=.d355fedd-7ec8-463d-969b-e2123987d1dd@github.com>
 <CKYPyukEqiyrhtxwu-wmU6m9orRi5dekY1qQPJ5JRa0=.e9385f22-34b9-451a-b9aa-cfeb2a9fd5f3@github.com>
 <wOn70EG_LG5YDTn09bX1Q28PVgKJ7hMGW_s7ssUWTho=.f46803c0-77c5-40f0-8be1-37cc42338a85@github.com>
Message-ID: <95GH0jYNsvrXVDoYjcsOWACV4pTrPXff8HGuORd59-o=.93e488d1-a6ee-43d3-9a40-ea6bbe21c62d@github.com>

On Wed, 6 Mar 2024 08:31:34 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Christoph Langer has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 14 additional commits since the last revision:
>> 
>>  - declare variable hasDisplays final
>>  - Merge branch 'master' into JDK-8185862
>>  - load awt.dll before display check
>>  - Change implementation of headless determination on Windows
>>  - Merge branch 'master' into JDK-8185862
>>  - Reflect display detection in java.awt.GraphicsEnvironment::isHeadless()
>>  - Merge branch 'master' into JDK-8185862
>>  - Get rid of global variables and restore old handling wrt calling ::GetDIBits
>>  - Merge branch 'master' into JDK-8185862
>>  - Little cleanup
>>  - ... and 4 more: https://git.openjdk.org/jdk/compare/dcf260b9...002fba2d
>
> src/java.desktop/windows/classes/sun/awt/PlatformGraphicsInfo.java line 69:
> 
>> 67:     public static boolean getDefaultHeadlessProperty() {
>> 68:         // If we don't find usable displays, we run headless.
>> 69:         return !hasDisplays();
> 
> I wonder if redirection via a private method makes any meaningful difference compared to returning the value of the `hasDisplays` flag directly?

Good point. Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17614#discussion_r1516489040

From aivanov at openjdk.org  Thu Mar  7 16:48:01 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Thu, 7 Mar 2024 16:48:01 GMT
Subject: RFR: 8185862: AWT Assertion Failure in ::GetDIBits(hBMDC, hBM, 0, 
 1, 0, gpBitmapInfo, 0) 'awt_Win32GraphicsDevice.cpp', at line 185 [v9]
In-Reply-To: <CKYPyukEqiyrhtxwu-wmU6m9orRi5dekY1qQPJ5JRa0=.e9385f22-34b9-451a-b9aa-cfeb2a9fd5f3@github.com>
References: <Cj_htOZE6ImXdNmj43IBiX7rW4Em4ZF-6kx0qIZW-Ho=.d355fedd-7ec8-463d-969b-e2123987d1dd@github.com>
 <CKYPyukEqiyrhtxwu-wmU6m9orRi5dekY1qQPJ5JRa0=.e9385f22-34b9-451a-b9aa-cfeb2a9fd5f3@github.com>
Message-ID: <9PLYtZE9YazTq5Eix1HIYIaP04vLiR8uDNuSiJM384k=.d190843a-7ec8-4b3b-8868-7f8cbbdc5826@github.com>

On Wed, 6 Mar 2024 07:50:08 GMT, Christoph Langer <clanger at openjdk.org> wrote:

>> The assertions reported in the bug were observed spuriously and here and there broke tests in some Windows configurations.
>> For instance [JDK-8266129](https://bugs.openjdk.org/browse/JDK-8266129), [JDK-8269529](https://bugs.openjdk.org/browse/JDK-8269529) or [JDK-8323664](https://bugs.openjdk.org/browse/JDK-8323664) came up due to this.
>> 
>> The problem is that in Windows environments without a valid display, e.g. started by system services or via PowerShell Remoting, one sees a Monitor with name 'Windisc' in `EnumDisplayMonitors`.
>> However, it seems to be some kind of a pseudo device where you can not get a DC via `CreateDC`. This behavior/monitor type doesn't seem to be well documented, though.
>> 
>> I hereby modify the device initialization code to only count/detect monitors where CreateDC returns non-NULL in Devices.cpp. I also add some more checking/error handling to AwtWin32GraphicsDevice::Initialize() for correctness.
>> 
>> Furthermore, I re-enable the test `javax/swing/reliability/HangDuringStaticInitialization.java` for Windows Debug VMs, which reverts the fix from JDK-8269529 that should not be necessary any more.
>
> Christoph Langer has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 14 additional commits since the last revision:
> 
>  - declare variable hasDisplays final
>  - Merge branch 'master' into JDK-8185862
>  - load awt.dll before display check
>  - Change implementation of headless determination on Windows
>  - Merge branch 'master' into JDK-8185862
>  - Reflect display detection in java.awt.GraphicsEnvironment::isHeadless()
>  - Merge branch 'master' into JDK-8185862
>  - Get rid of global variables and restore old handling wrt calling ::GetDIBits
>  - Merge branch 'master' into JDK-8185862
>  - Little cleanup
>  - ... and 4 more: https://git.openjdk.org/jdk/compare/dcf260b9...002fba2d

src/java.desktop/windows/native/libawt/windows/awt_Win32GraphicsDevice.cpp line 182:

> 180:     gpBitmapInfo->bmiHeader.biBitCount = 0;
> 181:     HDC hBMDC = this->GetDC();
> 182:     VERIFY(hBMDC != NULL);

You may want to leave `VERIFY(hBMDC != NULL)`? just in case.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17614#discussion_r1516489473

From aivanov at openjdk.org  Thu Mar  7 16:48:02 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Thu, 7 Mar 2024 16:48:02 GMT
Subject: RFR: 8185862: AWT Assertion Failure in ::GetDIBits(hBMDC, hBM, 0, 
 1, 0, gpBitmapInfo, 0) 'awt_Win32GraphicsDevice.cpp', at line 185 [v9]
In-Reply-To: <9PLYtZE9YazTq5Eix1HIYIaP04vLiR8uDNuSiJM384k=.d190843a-7ec8-4b3b-8868-7f8cbbdc5826@github.com>
References: <Cj_htOZE6ImXdNmj43IBiX7rW4Em4ZF-6kx0qIZW-Ho=.d355fedd-7ec8-463d-969b-e2123987d1dd@github.com>
 <CKYPyukEqiyrhtxwu-wmU6m9orRi5dekY1qQPJ5JRa0=.e9385f22-34b9-451a-b9aa-cfeb2a9fd5f3@github.com>
 <9PLYtZE9YazTq5Eix1HIYIaP04vLiR8uDNuSiJM384k=.d190843a-7ec8-4b3b-8868-7f8cbbdc5826@github.com>
Message-ID: <Foa7mmf4HyFg73x2OMiSah8eC2PEG9-EIjW4Gnxv_S8=.08581f24-b524-43cf-b07c-d42dabc89271@github.com>

On Thu, 7 Mar 2024 16:39:03 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Christoph Langer has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 14 additional commits since the last revision:
>> 
>>  - declare variable hasDisplays final
>>  - Merge branch 'master' into JDK-8185862
>>  - load awt.dll before display check
>>  - Change implementation of headless determination on Windows
>>  - Merge branch 'master' into JDK-8185862
>>  - Reflect display detection in java.awt.GraphicsEnvironment::isHeadless()
>>  - Merge branch 'master' into JDK-8185862
>>  - Get rid of global variables and restore old handling wrt calling ::GetDIBits
>>  - Merge branch 'master' into JDK-8185862
>>  - Little cleanup
>>  - ... and 4 more: https://git.openjdk.org/jdk/compare/dcf260b9...002fba2d
>
> src/java.desktop/windows/native/libawt/windows/awt_Win32GraphicsDevice.cpp line 182:
> 
>> 180:     gpBitmapInfo->bmiHeader.biBitCount = 0;
>> 181:     HDC hBMDC = this->GetDC();
>> 182:     VERIFY(hBMDC != NULL);
> 
> You may want to leave `VERIFY(hBMDC != NULL)`? just in case.

If you don't add the assertions for `hBMDC` and `hBM`, you should revert all the changes to `awt_Win32GraphicsDevice.cpp`.

At the moment, two lines are removed from `initScreens`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17614#discussion_r1516495998

From clanger at openjdk.org  Thu Mar  7 16:48:02 2024
From: clanger at openjdk.org (Christoph Langer)
Date: Thu, 7 Mar 2024 16:48:02 GMT
Subject: RFR: 8185862: AWT Assertion Failure in ::GetDIBits(hBMDC, hBM, 0, 
 1, 0, gpBitmapInfo, 0) 'awt_Win32GraphicsDevice.cpp', at line 185 [v2]
In-Reply-To: <2fz9YnrAnu3iMUF-xzXPA1wsOodGvXMjxlD53GA_7Ec=.fc280af9-54cc-473e-9d0c-132f37b77314@github.com>
References: <Cj_htOZE6ImXdNmj43IBiX7rW4Em4ZF-6kx0qIZW-Ho=.d355fedd-7ec8-463d-969b-e2123987d1dd@github.com>
 <Ptki9SnXavWUHVBaFKxqMJAzNH1Ec8CB4cr9ezJFwxA=.60a8b98b-0d1e-4f8c-bf1a-55908aaedf19@github.com>
 <4jmx37LJU3WWe70P4sSyCBtDgU_iGbJj8q4qMiB9GmQ=.7efffac2-f074-44d4-ae21-e088725ce756@github.com>
 <HtDXNTnHYyrG3rPIaAumR3VnleSlWGKwuN3YjFLApo4=.3d41e0ca-11a3-48b8-ade5-867a3fd544ec@github.com>
 <DUfeeaOAaZnEKeqT81SxKj86s57M-b3Ioqggj1lijs8=.6f888fc7-fd6d-4df9-9a75-bca8d4429b4f@github.com>
 <2fz9YnrAnu3iMUF-xzXPA1wsOodGvXMjxlD53GA_7Ec=.fc280af9-54cc-473e-9d0c-132f37b77314@github.com>
Message-ID: <IHjutQ5evigQjHbb9S2tSdOSo5m4D7iLkmE_mzGcj8k=.7b0f6569-c8e5-42cb-aaac-ff465f48fe43@github.com>

On Thu, 7 Mar 2024 00:47:00 GMT, Phil Race <prr at openjdk.org> wrote:

>> It is not what I meant? If we want to preserve the way it work, we should execute the below code even if `this->GetDC()` fails?
>> 
>> On the other hand, testing didn't find any problems, in which case I prefer bailing out after `::GetDIBits` fails too.
>> 
>> @prrace, Do you know how critical the code below is? Is it worth to code the fallback if the path to `::GetDIBits`?
>
>> @prrace, Do you know how critical the code below is? Is it worth to code the fallback if the path to ::GetDIBits?
> 
> In the headLESS case we should never be here, since this is initializing the devices that don't exist in that case.
> In the headFUL case I would prefer to keep the existing non-debug behaviour that we soldier on and try to do something sensible. Line 204 has a comment about a case in which GetDIBits really did fail and there's code to cope. I am writing specifically about GetDIBits.

OK, I have reverted all changes to awt_Win32GraphicsDevice.cpp since we don't go through the code in the new headless case any more. I guess it's best to leave any refactoring of this code to later efforts.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17614#discussion_r1516492296

From clanger at openjdk.org  Thu Mar  7 16:51:03 2024
From: clanger at openjdk.org (Christoph Langer)
Date: Thu, 7 Mar 2024 16:51:03 GMT
Subject: RFR: 8185862: AWT Assertion Failure in ::GetDIBits(hBMDC, hBM, 0, 
 1, 0, gpBitmapInfo, 0) 'awt_Win32GraphicsDevice.cpp', at line 185 [v9]
In-Reply-To: <Foa7mmf4HyFg73x2OMiSah8eC2PEG9-EIjW4Gnxv_S8=.08581f24-b524-43cf-b07c-d42dabc89271@github.com>
References: <Cj_htOZE6ImXdNmj43IBiX7rW4Em4ZF-6kx0qIZW-Ho=.d355fedd-7ec8-463d-969b-e2123987d1dd@github.com>
 <CKYPyukEqiyrhtxwu-wmU6m9orRi5dekY1qQPJ5JRa0=.e9385f22-34b9-451a-b9aa-cfeb2a9fd5f3@github.com>
 <9PLYtZE9YazTq5Eix1HIYIaP04vLiR8uDNuSiJM384k=.d190843a-7ec8-4b3b-8868-7f8cbbdc5826@github.com>
 <Foa7mmf4HyFg73x2OMiSah8eC2PEG9-EIjW4Gnxv_S8=.08581f24-b524-43cf-b07c-d42dabc89271@github.com>
Message-ID: <G7LBvAJtYKTniNCk2SxP1mbAkAvLdDBoR_V1-ZqQzw0=.54321a25-900f-4b97-8448-620275a74517@github.com>

On Thu, 7 Mar 2024 16:43:52 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> src/java.desktop/windows/native/libawt/windows/awt_Win32GraphicsDevice.cpp line 182:
>> 
>>> 180:     gpBitmapInfo->bmiHeader.biBitCount = 0;
>>> 181:     HDC hBMDC = this->GetDC();
>>> 182:     VERIFY(hBMDC != NULL);
>> 
>> You may want to leave `VERIFY(hBMDC != NULL)`? just in case.
>
> If you don't add the assertions for `hBMDC` and `hBM`, you should revert all the changes to `awt_Win32GraphicsDevice.cpp`.
> 
> At the moment, two lines are removed from `initScreens`.

The two lines removed from initScreens are in `awt_Win32GraphicsEnv.cpp` ?  That's unrelated cleanup I guess. But I bring back the VERIFY code which seems to make sense and would not alter the behavior in the non-debug case.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17614#discussion_r1516503232

From achung at openjdk.org  Thu Mar  7 16:51:30 2024
From: achung at openjdk.org (Alisen Chung)
Date: Thu, 7 Mar 2024 16:51:30 GMT
Subject: RFR: 8327492: Remove applet usage and update
 DisposeInActionEventTest.html [v12]
In-Reply-To: <wbQWXZ3sLQB90OPGZTWuifQuxdk7bFfiouu2NzUEzHQ=.310c2f89-b621-4f34-a949-1f319bcac8ce@github.com>
References: <wbQWXZ3sLQB90OPGZTWuifQuxdk7bFfiouu2NzUEzHQ=.310c2f89-b621-4f34-a949-1f319bcac8ce@github.com>
Message-ID: <Przopbp5QDjmvDoCA7CDAiTqyjS5YGGwJiqQ3arHM44=.dad41df4-ffdc-4537-b24a-f34240932f1b@github.com>

> Root cause of the test failure was fixed with https://bugs.openjdk.org/browse/JDK-8316931, updating this test since the other fix also included a test update.

Alisen Chung has updated the pull request incrementally with four additional commits since the last revision:

 - instructions update
 - instructions update
 - instructions update
 - instructions update

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/17838/files
  - new: https://git.openjdk.org/jdk/pull/17838/files/60bb2701..a4eef7c3

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=17838&range=11
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17838&range=10-11

  Stats: 8 lines in 1 file changed: 1 ins; 1 del; 6 mod
  Patch: https://git.openjdk.org/jdk/pull/17838.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17838/head:pull/17838

PR: https://git.openjdk.org/jdk/pull/17838

From achung at openjdk.org  Thu Mar  7 16:53:56 2024
From: achung at openjdk.org (Alisen Chung)
Date: Thu, 7 Mar 2024 16:53:56 GMT
Subject: RFR: 8327492: Remove applet usage and update
 DisposeInActionEventTest.html [v11]
In-Reply-To: <kUUmURztPD7ryyoE1TjtrJz-yEFQuIyXEvAQaSlds_k=.d61926e1-b850-48cd-9359-35fd3ca9636a@github.com>
References: <wbQWXZ3sLQB90OPGZTWuifQuxdk7bFfiouu2NzUEzHQ=.310c2f89-b621-4f34-a949-1f319bcac8ce@github.com>
 <xBLwOrYHGNchmi4gDrF18OYHkqMPV1NY9fmteg0AyiU=.adfe4b00-5815-4ba2-b991-4a1672302431@github.com>
 <SUR8mt1xV1gZQBJ1XXn_nh9rNcThlQW0tk1TdA-wmPw=.e54655c7-a56e-4829-a88d-6a137c5e6200@github.com>
 <wt-nLKk3u-W-OabmZbZTcK3oJLqOrMEyJgn0HE8aez8=.c9ab2348-5d1c-47ca-a30b-096facc3cca0@github.com>
 <kUUmURztPD7ryyoE1TjtrJz-yEFQuIyXEvAQaSlds_k=.d61926e1-b850-48cd-9359-35fd3ca9636a@github.com>
Message-ID: <Z35bFe9EwFwVWWneNupz1QvUtZ2e-pcQOtTGry7mKcc=.f2d81e22-4a83-4167-ae47-069bf4c56d11@github.com>

On Thu, 7 Mar 2024 16:37:25 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> On windows you need to left click twice, on macos you need to right click once
>
> [I did suggest clearer instructions](https://github.com/openjdk/jdk/pull/17838#discussion_r1506056726):
> 
>                         clickInstruction + " on the tray icon to trigger the\n" +
> 
> You ignored it and marked resolved.
> 
> In the current instructions, _?the button?_ does not refer to anything obvious. What button? It's confusing. Remove _?the button?_ from the instructions, and the instructions are clear: _?Right-click / Double-click on **the tray icon**??_

I've also added left mouse button in parenthesis for windows, is it unnecessary? I think it should be clear now

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17838#discussion_r1516507424

From clanger at openjdk.org  Thu Mar  7 16:55:12 2024
From: clanger at openjdk.org (Christoph Langer)
Date: Thu, 7 Mar 2024 16:55:12 GMT
Subject: RFR: 8185862: AWT Assertion Failure in ::GetDIBits(hBMDC, hBM, 0, 
 1, 0, gpBitmapInfo, 0) 'awt_Win32GraphicsDevice.cpp',
 at line 185 [v11]
In-Reply-To: <Cj_htOZE6ImXdNmj43IBiX7rW4Em4ZF-6kx0qIZW-Ho=.d355fedd-7ec8-463d-969b-e2123987d1dd@github.com>
References: <Cj_htOZE6ImXdNmj43IBiX7rW4Em4ZF-6kx0qIZW-Ho=.d355fedd-7ec8-463d-969b-e2123987d1dd@github.com>
Message-ID: <I9mJYJqXa-aLxUycPdvGf5iPE823mtPcxj9tKOVtGIE=.c791117f-1bc6-4c4a-83a4-ad27308d33ee@github.com>

> The assertions reported in the bug were observed spuriously and here and there broke tests in some Windows configurations.
> For instance [JDK-8266129](https://bugs.openjdk.org/browse/JDK-8266129), [JDK-8269529](https://bugs.openjdk.org/browse/JDK-8269529) or [JDK-8323664](https://bugs.openjdk.org/browse/JDK-8323664) came up due to this.
> 
> The problem is that in Windows environments without a valid display, e.g. started by system services or via PowerShell Remoting, one sees a Monitor with name 'Windisc' in `EnumDisplayMonitors`.
> However, it seems to be some kind of a pseudo device where you can not get a DC via `CreateDC`. This behavior/monitor type doesn't seem to be well documented, though.
> 
> I hereby modify the device initialization code to only count/detect monitors where CreateDC returns non-NULL in Devices.cpp. I also add some more checking/error handling to AwtWin32GraphicsDevice::Initialize() for correctness.
> 
> Furthermore, I re-enable the test `javax/swing/reliability/HangDuringStaticInitialization.java` for Windows Debug VMs, which reverts the fix from JDK-8269529 that should not be necessary any more.

Christoph Langer has updated the pull request incrementally with one additional commit since the last revision:

  Bring back verification of hBMDC and hBM

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/17614/files
  - new: https://git.openjdk.org/jdk/pull/17614/files/2f378c88..ae139953

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=17614&range=10
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17614&range=09-10

  Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/17614.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17614/head:pull/17614

PR: https://git.openjdk.org/jdk/pull/17614

From aivanov at openjdk.org  Thu Mar  7 16:55:12 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Thu, 7 Mar 2024 16:55:12 GMT
Subject: RFR: 8185862: AWT Assertion Failure in ::GetDIBits(hBMDC, hBM, 0, 
 1, 0, gpBitmapInfo, 0) 'awt_Win32GraphicsDevice.cpp', at line 185 [v9]
In-Reply-To: <G7LBvAJtYKTniNCk2SxP1mbAkAvLdDBoR_V1-ZqQzw0=.54321a25-900f-4b97-8448-620275a74517@github.com>
References: <Cj_htOZE6ImXdNmj43IBiX7rW4Em4ZF-6kx0qIZW-Ho=.d355fedd-7ec8-463d-969b-e2123987d1dd@github.com>
 <CKYPyukEqiyrhtxwu-wmU6m9orRi5dekY1qQPJ5JRa0=.e9385f22-34b9-451a-b9aa-cfeb2a9fd5f3@github.com>
 <9PLYtZE9YazTq5Eix1HIYIaP04vLiR8uDNuSiJM384k=.d190843a-7ec8-4b3b-8868-7f8cbbdc5826@github.com>
 <Foa7mmf4HyFg73x2OMiSah8eC2PEG9-EIjW4Gnxv_S8=.08581f24-b524-43cf-b07c-d42dabc89271@github.com>
 <G7LBvAJtYKTniNCk2SxP1mbAkAvLdDBoR_V1-ZqQzw0=.54321a25-900f-4b97-8448-620275a74517@github.com>
Message-ID: <Xw8ph2p5E0vD9lHcTMHqQTaTOkyCR0SBzBXzA8a783o=.73a32e04-3db3-48bf-a055-40f4c60d905a@github.com>

On Thu, 7 Mar 2024 16:48:27 GMT, Christoph Langer <clanger at openjdk.org> wrote:

>> If you don't add the assertions for `hBMDC` and `hBM`, you should revert all the changes to `awt_Win32GraphicsDevice.cpp`.
>> 
>> At the moment, two lines are removed from `initScreens`.
>
> The two lines removed from initScreens are in `awt_Win32GraphicsEnv.cpp` ?  That's unrelated cleanup I guess. But I bring back the VERIFY code which seems to make sense and would not alter the behavior in the non-debug case.

You're right! `awt_Win32GraphicsDevice.cpp` is not part of the PR at this very moment.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17614#discussion_r1516508137

From achung at openjdk.org  Thu Mar  7 17:06:11 2024
From: achung at openjdk.org (Alisen Chung)
Date: Thu, 7 Mar 2024 17:06:11 GMT
Subject: RFR: 8327492: Remove applet usage and update
 DisposeInActionEventTest.html [v13]
In-Reply-To: <wbQWXZ3sLQB90OPGZTWuifQuxdk7bFfiouu2NzUEzHQ=.310c2f89-b621-4f34-a949-1f319bcac8ce@github.com>
References: <wbQWXZ3sLQB90OPGZTWuifQuxdk7bFfiouu2NzUEzHQ=.310c2f89-b621-4f34-a949-1f319bcac8ce@github.com>
Message-ID: <_1Uc0LfBjl-TobRK4opf_drWHnu5igYbnkaUGFnw-FY=.09f7d498-3b43-485a-8c5f-99002bf532e1@github.com>

> Root cause of the test failure was fixed with https://bugs.openjdk.org/browse/JDK-8316931, updating this test since the other fix also included a test update.

Alisen Chung has updated the pull request incrementally with two additional commits since the last revision:

 - remove trayicon when feiling test
 - remove automatic check line in instructions

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/17838/files
  - new: https://git.openjdk.org/jdk/pull/17838/files/a4eef7c3..4bc3afc1

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=17838&range=12
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17838&range=11-12

  Stats: 8 lines in 1 file changed: 6 ins; 1 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/17838.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17838/head:pull/17838

PR: https://git.openjdk.org/jdk/pull/17838

From achung at openjdk.org  Thu Mar  7 17:06:11 2024
From: achung at openjdk.org (Alisen Chung)
Date: Thu, 7 Mar 2024 17:06:11 GMT
Subject: RFR: 8327492: Remove applet usage and update
 DisposeInActionEventTest.html [v8]
In-Reply-To: <tBxKeDRpFjgWDOqhNXWXyWt-B6oDrKpSX0pWXzDLaY8=.922f3e08-c99a-4a77-aeb1-92dbe22938c5@github.com>
References: <wbQWXZ3sLQB90OPGZTWuifQuxdk7bFfiouu2NzUEzHQ=.310c2f89-b621-4f34-a949-1f319bcac8ce@github.com>
 <l1ADMFQYCId4N3tn4FSvNm3Witml58Bqdk-D7E2Pm78=.2932bed0-580f-44fb-931d-b71d75533de5@github.com>
 <2xTHQDg4I2rN2PtBL1FdX-0r_djhoEFoEqYqsFdJaGc=.ee551abe-90d2-4664-a038-73f204d0692f@github.com>
 <tBxKeDRpFjgWDOqhNXWXyWt-B6oDrKpSX0pWXzDLaY8=.922f3e08-c99a-4a77-aeb1-92dbe22938c5@github.com>
Message-ID: <UTA8h2c06Snn-wGi4XsUp7Xfe5HhtFN136pLhUINxqk=.32d3899e-3b8b-4d6d-9abc-2da862806dfe@github.com>

On Thu, 7 Mar 2024 15:04:36 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> test/jdk/java/awt/TrayIcon/DisposeInActionEventTest/DisposeInActionEventTest.java line 67:
>> 
>>> 65:                        "  something is wrong the corresponding message is displayed below.\n" +
>>> 66:                        "  Repeat clicks several times. If no 'Test FAILED' messages\n" +
>>> 67:                        "  are printed, press PASS button else FAIL button.";
>> 
>> It's not displayed below, it's to the right, isn't it?
>> 
>> Fail the test automatically if you can detect the failure. You may show a message to the tester about the failure before shutting down the test.
>
> This comment also implied amending the instructions to correspond to what the test does.

the test doesn't actually do any automatic checks, so i've removed that line

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17838#discussion_r1516519788

From aivanov at openjdk.org  Thu Mar  7 17:22:56 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Thu, 7 Mar 2024 17:22:56 GMT
Subject: RFR: 8185862: AWT Assertion Failure in ::GetDIBits(hBMDC, hBM, 0, 
 1, 0, gpBitmapInfo, 0) 'awt_Win32GraphicsDevice.cpp',
 at line 185 [v11]
In-Reply-To: <I9mJYJqXa-aLxUycPdvGf5iPE823mtPcxj9tKOVtGIE=.c791117f-1bc6-4c4a-83a4-ad27308d33ee@github.com>
References: <Cj_htOZE6ImXdNmj43IBiX7rW4Em4ZF-6kx0qIZW-Ho=.d355fedd-7ec8-463d-969b-e2123987d1dd@github.com>
 <I9mJYJqXa-aLxUycPdvGf5iPE823mtPcxj9tKOVtGIE=.c791117f-1bc6-4c4a-83a4-ad27308d33ee@github.com>
Message-ID: <FuWAXaHZmQFQAnpaxTFqfYy4wYfMsBpj7F_0KsnhD-I=.79462e0c-0a3f-49df-a3b4-6b7618254e67@github.com>

On Thu, 7 Mar 2024 16:55:12 GMT, Christoph Langer <clanger at openjdk.org> wrote:

>> The assertions reported in the bug were observed spuriously and here and there broke tests in some Windows configurations.
>> For instance [JDK-8266129](https://bugs.openjdk.org/browse/JDK-8266129), [JDK-8269529](https://bugs.openjdk.org/browse/JDK-8269529) or [JDK-8323664](https://bugs.openjdk.org/browse/JDK-8323664) came up due to this.
>> 
>> The problem is that in Windows environments without a valid display, e.g. started by system services or via PowerShell Remoting, one sees a Monitor with name 'Windisc' in `EnumDisplayMonitors`.
>> However, it seems to be some kind of a pseudo device where you can not get a DC via `CreateDC`. This behavior/monitor type doesn't seem to be well documented, though.
>> 
>> I hereby modify the device initialization code to only count/detect monitors where CreateDC returns non-NULL in Devices.cpp. I also add some more checking/error handling to AwtWin32GraphicsDevice::Initialize() for correctness.
>> 
>> Furthermore, I re-enable the test `javax/swing/reliability/HangDuringStaticInitialization.java` for Windows Debug VMs, which reverts the fix from JDK-8269529 that should not be necessary any more.
>
> Christoph Langer has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Bring back verification of hBMDC and hBM

Marked as reviewed by aivanov (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/17614#pullrequestreview-1923069535

From aivanov at openjdk.org  Thu Mar  7 17:37:55 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Thu, 7 Mar 2024 17:37:55 GMT
Subject: RFR: 8327492: Remove applet usage and update
 DisposeInActionEventTest.html [v13]
In-Reply-To: <_1Uc0LfBjl-TobRK4opf_drWHnu5igYbnkaUGFnw-FY=.09f7d498-3b43-485a-8c5f-99002bf532e1@github.com>
References: <wbQWXZ3sLQB90OPGZTWuifQuxdk7bFfiouu2NzUEzHQ=.310c2f89-b621-4f34-a949-1f319bcac8ce@github.com>
 <_1Uc0LfBjl-TobRK4opf_drWHnu5igYbnkaUGFnw-FY=.09f7d498-3b43-485a-8c5f-99002bf532e1@github.com>
Message-ID: <hYky6nXK99czmVC1VDjHwn-hflI39adlHVQLqDsSmN0=.33f1181d-2c8c-4e1d-a528-12db2b303a93@github.com>

On Thu, 7 Mar 2024 17:06:11 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> Root cause of the test failure was fixed with https://bugs.openjdk.org/browse/JDK-8316931, updating this test since the other fix also included a test update.
>
> Alisen Chung has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - remove trayicon when feiling test
>  - remove automatic check line in instructions

Changes requested by aivanov (Reviewer).

test/jdk/java/awt/TrayIcon/DisposeInActionEventTest/DisposeInActionEventTest.java line 117:

> 115:                     if (systemTray != null) {
> 116:                         systemTray.remove(trayIcon);
> 117:                     }

It is not needed. The icon is always removed, the `finally` block in the `main` method is always executed, even when an exception is thrown.
https://github.com/openjdk/jdk/blob/4bc3afc11a8a88599bc70fc7974b4f0782c60b2c/test/jdk/java/awt/TrayIcon/DisposeInActionEventTest/DisposeInActionEventTest.java#L81-L85

If it were needed, you would create a helper method and call it from all the places instead of copying the code around.

-------------

PR Review: https://git.openjdk.org/jdk/pull/17838#pullrequestreview-1923090600
PR Review Comment: https://git.openjdk.org/jdk/pull/17838#discussion_r1516558328

From aivanov at openjdk.org  Thu Mar  7 17:37:56 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Thu, 7 Mar 2024 17:37:56 GMT
Subject: RFR: 8327492: Remove applet usage and update
 DisposeInActionEventTest.html [v8]
In-Reply-To: <UTA8h2c06Snn-wGi4XsUp7Xfe5HhtFN136pLhUINxqk=.32d3899e-3b8b-4d6d-9abc-2da862806dfe@github.com>
References: <wbQWXZ3sLQB90OPGZTWuifQuxdk7bFfiouu2NzUEzHQ=.310c2f89-b621-4f34-a949-1f319bcac8ce@github.com>
 <l1ADMFQYCId4N3tn4FSvNm3Witml58Bqdk-D7E2Pm78=.2932bed0-580f-44fb-931d-b71d75533de5@github.com>
 <2xTHQDg4I2rN2PtBL1FdX-0r_djhoEFoEqYqsFdJaGc=.ee551abe-90d2-4664-a038-73f204d0692f@github.com>
 <tBxKeDRpFjgWDOqhNXWXyWt-B6oDrKpSX0pWXzDLaY8=.922f3e08-c99a-4a77-aeb1-92dbe22938c5@github.com>
 <UTA8h2c06Snn-wGi4XsUp7Xfe5HhtFN136pLhUINxqk=.32d3899e-3b8b-4d6d-9abc-2da862806dfe@github.com>
Message-ID: <HHhEmigfVHv6uX7AW2NtIkSO1jfFN4rj24zf-hZkiLM=.f03f1021-45f4-4b01-9215-3b4605782189@github.com>

On Thu, 7 Mar 2024 17:00:29 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> This comment also implied amending the instructions to correspond to what the test does.
>
> the test doesn't actually do any automatic checks, so i've removed that line

It kind of does.

[JDK-6299866](https://bugs.openjdk.org/browse/JDK-6299866) states NPE was thrown if a tray icon is removed from its action listener. This implies the test fails automatically if NPE is thrown.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17838#discussion_r1516561499

From aivanov at openjdk.org  Thu Mar  7 17:42:57 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Thu, 7 Mar 2024 17:42:57 GMT
Subject: RFR: 8327492: Remove applet usage and update
 DisposeInActionEventTest.html [v11]
In-Reply-To: <mSJyBrXS6hhz9bcY88cpvWT8L1LpmaK9xbmY9lweOoM=.d14405ef-37bb-4fc6-aa53-b50658e6d0c1@github.com>
References: <wbQWXZ3sLQB90OPGZTWuifQuxdk7bFfiouu2NzUEzHQ=.310c2f89-b621-4f34-a949-1f319bcac8ce@github.com>
 <xBLwOrYHGNchmi4gDrF18OYHkqMPV1NY9fmteg0AyiU=.adfe4b00-5815-4ba2-b991-4a1672302431@github.com>
 <mSJyBrXS6hhz9bcY88cpvWT8L1LpmaK9xbmY9lweOoM=.d14405ef-37bb-4fc6-aa53-b50658e6d0c1@github.com>
Message-ID: <1WsDDdgrZzU0cYK3183xmtyaE_1Mrl3TiVx4bNhSLQU=.aa05869a-bc85-4356-9c1a-6432fea4bc80@github.com>

On Thu, 7 Mar 2024 15:09:02 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   null check for system tray before remove
>
> test/jdk/java/awt/TrayIcon/ShowAfterDisposeTest/ShowAfterDisposeTest.java line 1:
> 
>> 1: /*
> 
> Does it make sense to remove the tray icon in this test as well when the test exits?

How is this resolved? You haven't updated `ShowAfterDisposeTest.java` to remove the tray icon when the test exists.

An answer of ?No? is also valid. But you haven't said anything at all.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17838#discussion_r1516573259

From achung at openjdk.org  Thu Mar  7 18:56:55 2024
From: achung at openjdk.org (Alisen Chung)
Date: Thu, 7 Mar 2024 18:56:55 GMT
Subject: RFR: 8327492: Remove applet usage and update
 DisposeInActionEventTest.html [v11]
In-Reply-To: <1WsDDdgrZzU0cYK3183xmtyaE_1Mrl3TiVx4bNhSLQU=.aa05869a-bc85-4356-9c1a-6432fea4bc80@github.com>
References: <wbQWXZ3sLQB90OPGZTWuifQuxdk7bFfiouu2NzUEzHQ=.310c2f89-b621-4f34-a949-1f319bcac8ce@github.com>
 <xBLwOrYHGNchmi4gDrF18OYHkqMPV1NY9fmteg0AyiU=.adfe4b00-5815-4ba2-b991-4a1672302431@github.com>
 <mSJyBrXS6hhz9bcY88cpvWT8L1LpmaK9xbmY9lweOoM=.d14405ef-37bb-4fc6-aa53-b50658e6d0c1@github.com>
 <1WsDDdgrZzU0cYK3183xmtyaE_1Mrl3TiVx4bNhSLQU=.aa05869a-bc85-4356-9c1a-6432fea4bc80@github.com>
Message-ID: <cQtO35JUJvvrqOeOD3dxwagrDhHCi1Qpu5vLFXz1f0E=.379e7425-9d42-426b-a8a8-9d162033e344@github.com>

On Thu, 7 Mar 2024 17:40:32 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> test/jdk/java/awt/TrayIcon/ShowAfterDisposeTest/ShowAfterDisposeTest.java line 1:
>> 
>>> 1: /*
>> 
>> Does it make sense to remove the tray icon in this test as well when the test exits?
>
> How is this resolved? You haven't updated `ShowAfterDisposeTest.java` to remove the tray icon when the test exists.
> 
> An answer of ?No? is also valid. But you haven't said anything at all.

oops, I misinterpreted what you wrote and updated the wrong file

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17838#discussion_r1516660020

From achung at openjdk.org  Thu Mar  7 19:22:06 2024
From: achung at openjdk.org (Alisen Chung)
Date: Thu, 7 Mar 2024 19:22:06 GMT
Subject: RFR: 8327492: Remove applet usage and update
 DisposeInActionEventTest.html [v14]
In-Reply-To: <wbQWXZ3sLQB90OPGZTWuifQuxdk7bFfiouu2NzUEzHQ=.310c2f89-b621-4f34-a949-1f319bcac8ce@github.com>
References: <wbQWXZ3sLQB90OPGZTWuifQuxdk7bFfiouu2NzUEzHQ=.310c2f89-b621-4f34-a949-1f319bcac8ce@github.com>
Message-ID: <gU_Nbfrgw0adtl8u_PT_cBG0AScrh8sc9ZmVNYl42d0=.902c1baf-f332-4d2b-ab47-ff8a41641e1d@github.com>

> Root cause of the test failure was fixed with https://bugs.openjdk.org/browse/JDK-8316931, updating this test since the other fix also included a test update.

Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:

  move jtreg in ShowAfterDisposeTest, remove trayicon in ShowAfterDisposeTest, changed instructions string in DisposeInActionEventTest

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/17838/files
  - new: https://git.openjdk.org/jdk/pull/17838/files/4bc3afc1..0947ce09

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=17838&range=13
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17838&range=12-13

  Stats: 43 lines in 2 files changed: 17 ins; 15 del; 11 mod
  Patch: https://git.openjdk.org/jdk/pull/17838.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17838/head:pull/17838

PR: https://git.openjdk.org/jdk/pull/17838

From prr at openjdk.org  Thu Mar  7 19:40:56 2024
From: prr at openjdk.org (Phil Race)
Date: Thu, 7 Mar 2024 19:40:56 GMT
Subject: RFR: 8185862: AWT Assertion Failure in ::GetDIBits(hBMDC, hBM, 0, 
 1, 0, gpBitmapInfo, 0) 'awt_Win32GraphicsDevice.cpp',
 at line 185 [v11]
In-Reply-To: <I9mJYJqXa-aLxUycPdvGf5iPE823mtPcxj9tKOVtGIE=.c791117f-1bc6-4c4a-83a4-ad27308d33ee@github.com>
References: <Cj_htOZE6ImXdNmj43IBiX7rW4Em4ZF-6kx0qIZW-Ho=.d355fedd-7ec8-463d-969b-e2123987d1dd@github.com>
 <I9mJYJqXa-aLxUycPdvGf5iPE823mtPcxj9tKOVtGIE=.c791117f-1bc6-4c4a-83a4-ad27308d33ee@github.com>
Message-ID: <an87X91lQ-I7-XvUYLHaGNg3adc9UHkkeFaugmL7Ms8=.19bc2f05-e2d4-4b1b-87a0-ce0b7ce2273c@github.com>

On Thu, 7 Mar 2024 16:55:12 GMT, Christoph Langer <clanger at openjdk.org> wrote:

>> The assertions reported in the bug were observed spuriously and here and there broke tests in some Windows configurations.
>> For instance [JDK-8266129](https://bugs.openjdk.org/browse/JDK-8266129), [JDK-8269529](https://bugs.openjdk.org/browse/JDK-8269529) or [JDK-8323664](https://bugs.openjdk.org/browse/JDK-8323664) came up due to this.
>> 
>> The problem is that in Windows environments without a valid display, e.g. started by system services or via PowerShell Remoting, one sees a Monitor with name 'Windisc' in `EnumDisplayMonitors`.
>> However, it seems to be some kind of a pseudo device where you can not get a DC via `CreateDC`. This behavior/monitor type doesn't seem to be well documented, though.
>> 
>> I hereby modify the device initialization code to only count/detect monitors where CreateDC returns non-NULL in Devices.cpp. I also add some more checking/error handling to AwtWin32GraphicsDevice::Initialize() for correctness.
>> 
>> Furthermore, I re-enable the test `javax/swing/reliability/HangDuringStaticInitialization.java` for Windows Debug VMs, which reverts the fix from JDK-8269529 that should not be necessary any more.
>
> Christoph Langer has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Bring back verification of hBMDC and hBM

I think we are done with this.

If a DEBUG build is used for HEADFUL then the new VERIFY calls *might* cause a different failure mode, but that's the only risk I see, and it seems a very, very small one.

-------------

Marked as reviewed by prr (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17614#pullrequestreview-1923370884

From achung at openjdk.org  Thu Mar  7 20:07:19 2024
From: achung at openjdk.org (Alisen Chung)
Date: Thu, 7 Mar 2024 20:07:19 GMT
Subject: RFR: 8280392:
 java/awt/Focus/NonFocusableWindowTest/NonfocusableOwnerTest.java failed with
 "RuntimeException: Test failed." [v2]
In-Reply-To: <o_Z6zlPUisWgc5LIglgOe4zbIjsijJfuG9MtoBveFAU=.2d730b06-211a-485e-8390-6d6f9ae75947@github.com>
References: <o_Z6zlPUisWgc5LIglgOe4zbIjsijJfuG9MtoBveFAU=.2d730b06-211a-485e-8390-6d6f9ae75947@github.com>
Message-ID: <lz60OBe9QYgOuzQM0Uv8pF0URMvFwwAVykTE4-cfRiI=.0abd6616-e428-4986-a55a-adbf72fe91c7@github.com>

> Introduce delays in test to stabilize. Test passes 50x after fix.

Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:

  update copyright, fix jtreg formatting, update frame title, expand imports

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18091/files
  - new: https://git.openjdk.org/jdk/pull/18091/files/25008b78..5ba5eeba

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18091&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18091&range=00-01

  Stats: 35 lines in 1 file changed: 21 ins; 12 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/18091.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18091/head:pull/18091

PR: https://git.openjdk.org/jdk/pull/18091

From prr at openjdk.org  Thu Mar  7 21:34:54 2024
From: prr at openjdk.org (Phil Race)
Date: Thu, 7 Mar 2024 21:34:54 GMT
Subject: RFR: 8326497: Window.toFront() fails for iconified windows on
 Linux [v6]
In-Reply-To: <0nuVOsFROjoR7wCT94ilnqEjENMSLt5XTHM6hLVWxOk=.873c9a7f-2492-47b6-968d-5f391577e5ed@github.com>
References: <XmMRoFNpTDQHCZLnmmnNGVjhR2Ib3yw1kWc0v57utUM=.e418325c-7b23-4298-8f75-e81d369b5afc@github.com>
 <0nuVOsFROjoR7wCT94ilnqEjENMSLt5XTHM6hLVWxOk=.873c9a7f-2492-47b6-968d-5f391577e5ed@github.com>
Message-ID: <lF0idXu-vBYUmbuLvz-K5WK4VEYCWzdz-e5l9oo2mWc=.5a8730a7-9350-49b3-b059-5a5787361ccc@github.com>

On Wed, 6 Mar 2024 10:55:00 GMT, Maxim Kartashev <mkartashev at openjdk.org> wrote:

>> XToolkit implements `toFront()` essentially by sending the  `_NET_ACTIVE_WINDOW` message to activate the window. This has no effect when the target window is in the iconified state. So the fix is to cancel that state prior to sending the message.
>> 
>> The test verifies that the fix works for maximized and undecorated frames as well out of abundance of caution; they do not represent a special case from the `toFront()` standpoint.
>> 
>> References
>> * `_NET_ACTIVE_WINDOW`: https://specifications.freedesktop.org/wm-spec/1.3/ar01s03.html
>> * [Inter-Client Communication Conventions Manual, 4.1.4. Changing Window State](https://tronche.com/gui/x/icccm/sec-4.html#s-4.1.4)
>
> Maxim Kartashev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Reduced the wait time in the test

Testing all good. Approved

-------------

Marked as reviewed by prr (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17985#pullrequestreview-1923594228

From aivanov at openjdk.org  Thu Mar  7 22:33:55 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Thu, 7 Mar 2024 22:33:55 GMT
Subject: RFR: 8327492: Remove applet usage and update
 DisposeInActionEventTest.html [v14]
In-Reply-To: <gU_Nbfrgw0adtl8u_PT_cBG0AScrh8sc9ZmVNYl42d0=.902c1baf-f332-4d2b-ab47-ff8a41641e1d@github.com>
References: <wbQWXZ3sLQB90OPGZTWuifQuxdk7bFfiouu2NzUEzHQ=.310c2f89-b621-4f34-a949-1f319bcac8ce@github.com>
 <gU_Nbfrgw0adtl8u_PT_cBG0AScrh8sc9ZmVNYl42d0=.902c1baf-f332-4d2b-ab47-ff8a41641e1d@github.com>
Message-ID: <pvUNAGUqwlk6hHB6E3wKr48SK7Gh6mvThc2TksBpPGk=.eb6582c3-abf1-4de3-bf5f-4f72cc9543c7@github.com>

On Thu, 7 Mar 2024 19:22:06 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> Root cause of the test failure was fixed with https://bugs.openjdk.org/browse/JDK-8316931, updating this test since the other fix also included a test update.
>
> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   move jtreg in ShowAfterDisposeTest, remove trayicon in ShowAfterDisposeTest, changed instructions string in DisposeInActionEventTest

Marked as reviewed by aivanov (Reviewer).

test/jdk/java/awt/TrayIcon/DisposeInActionEventTest/DisposeInActionEventTest.java line 69:

> 67:                        "  the tray and then added back in a second.\n\n" +
> 68:                        "If something is wrong, the test will automatically fail.\n" +
> 69:                        "  Repeat clicks several times. Press PASS button.";

Suggestion:

                       "  Repeat clicks several times. Then press PASS button.";

Does it sound better this way?

test/jdk/java/awt/TrayIcon/ShowAfterDisposeTest/ShowAfterDisposeTest.java line 46:

> 44: public class ShowAfterDisposeTest {
> 45:     private static SystemTray tray;
> 46:     private static TrayIcon icon ;

Suggestion:

    private static TrayIcon icon;

-------------

PR Review: https://git.openjdk.org/jdk/pull/17838#pullrequestreview-1923688183
PR Review Comment: https://git.openjdk.org/jdk/pull/17838#discussion_r1516922486
PR Review Comment: https://git.openjdk.org/jdk/pull/17838#discussion_r1516921701

From serb at openjdk.org  Fri Mar  8 01:13:00 2024
From: serb at openjdk.org (Sergey Bylokhov)
Date: Fri, 8 Mar 2024 01:13:00 GMT
Subject: RFR: 8326661: sun/java2d/cmm/ColorConvertOp/ColConvTest.java
 assumes profiles were generated by LCMS [v2]
In-Reply-To: <Dk8hEFbO8v4sweXxToR-wjNgKCw2GTBXpgpP_jPwG5k=.07e58905-3c2d-45da-b528-f54e03f4b4b3@github.com>
References: <nFplnFr0UPf-gWrZjoyZhb2pCJ_fjUEieIxTlWesSNs=.7f372d25-5bc5-4fb2-9ecd-8d5e40cc69b8@github.com>
 <6aO1JMWfnuzwP6QH4GVnI9YW7nW8XygymJvsjVU0ykY=.cbf6f144-4a45-428e-9ae3-eacd67641e94@github.com>
 <PuQ3oGFIK3A35zfbSDtT3tRfzVmYyqjxgokbG7jfqSY=.d1d26d54-b9d5-4e82-9c8f-769a965a2d44@github.com>
 <Dk8hEFbO8v4sweXxToR-wjNgKCw2GTBXpgpP_jPwG5k=.07e58905-3c2d-45da-b528-f54e03f4b4b3@github.com>
Message-ID: <0Fr7nxVMAPD27Ejyiw46Vk6mHIQhZagXQUSXBbGeXAA=.d266404a-cc7d-41ef-a2ac-55feb6c95515@github.com>

On Thu, 7 Mar 2024 12:32:09 GMT, Dmitry Markov <dmarkov at openjdk.org> wrote:

>> Actually the purpose of these particular tests is validation of the quality of the built-in color profiles.
>
> I agree, I reverted almost all changes except the ones in tolerance for non-LCMS profiles. That values need to be updated to make the test pass on JDKs (e.g. JDK 8u, etc) where non-LCMS profiles are used

Could you please clarify what is the root cause of the problem. I assume you did not update the profiles itself, so what is the problem in the new lcms library?

>It used to be OK until recent LCMS update where the CMM started to keep original profile ID instead of writing ?lcms? to returned header. 

Do you mean that previously we always use lcms thresholds even for kcms related profiles?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18097#discussion_r1517039982

From tr at openjdk.org  Fri Mar  8 04:11:16 2024
From: tr at openjdk.org (Tejesh R)
Date: Fri, 8 Mar 2024 04:11:16 GMT
Subject: RFR: 8326606: Test
 javax/swing/text/BoxView/6494356/bug6494356.java performs a synchronization on
 a value based class
In-Reply-To: <8VnEO3HS6wKX45a3tokydw_aTorFic1acaSiIqm4-7A=.58457c31-1969-47d9-9c1e-365bba1b7174@github.com>
References: <8VnEO3HS6wKX45a3tokydw_aTorFic1acaSiIqm4-7A=.58457c31-1969-47d9-9c1e-365bba1b7174@github.com>
Message-ID: <ivDZL2CWN-fJhdmezhzhOktIHFmp5SW9yAUxSqo62IU=.0d790dfc-8ab9-41ed-87d0-947aee8cbfd8@github.com>

On Thu, 7 Mar 2024 03:16:20 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> OPensource BoxView test

JBS is confidential and hence not linked.

test/jdk/javax/swing/text/BoxView/bug6494356.java line 28:

> 26:  * @key headful
> 27:  * @summary Test that BoxView.layout() is not called with negative arguments
> 28:  * @run main bug6494356 bug6494356.html

Can the test be converted to non-applet based?

test/jdk/javax/swing/text/BoxView/bug6494356.java line 65:

> 63:                 });
> 64:                 JFrame f = new JFrame();
> 65:                 f.setTitle("6494356");

Frame Title could be meaningful and also the test name.

-------------

PR Review: https://git.openjdk.org/jdk/pull/18147#pullrequestreview-1921434383
PR Review Comment: https://git.openjdk.org/jdk/pull/18147#discussion_r1515522052
PR Review Comment: https://git.openjdk.org/jdk/pull/18147#discussion_r1515523482

From aivanov at openjdk.org  Fri Mar  8 04:11:16 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Fri, 8 Mar 2024 04:11:16 GMT
Subject: RFR: 8326606: Test
 javax/swing/text/BoxView/6494356/bug6494356.java performs a synchronization on
 a value based class
In-Reply-To: <8VnEO3HS6wKX45a3tokydw_aTorFic1acaSiIqm4-7A=.58457c31-1969-47d9-9c1e-365bba1b7174@github.com>
References: <8VnEO3HS6wKX45a3tokydw_aTorFic1acaSiIqm4-7A=.58457c31-1969-47d9-9c1e-365bba1b7174@github.com>
Message-ID: <lRdouna3psO_8yxJ4dD1YRVgTR8eQHjnAo3ByS1cFpw=.74e45c43-e7a2-41ae-a8b4-573f8edff359@github.com>

On Thu, 7 Mar 2024 03:16:20 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> OPensource BoxView test

Changes requested by aivanov (Reviewer).

Changes requested by aivanov (Reviewer).

Changes requested by aivanov (Reviewer).

test/jdk/javax/swing/text/BoxView/bug6494356.html line 1:

> 1: <p>Paragraph</p>

Since the test requires a supporting file, does it make sense to put the test in a folder `6494356/bug6494356.java`?

I wanted to asked whether an external file is needed? I answered this question: yes, it's needed. The test must use `setPage` which loads the file or URL asynchronously.

At the same time, the file to load can be created on the fly in the scratch directory which is the current directory when the test is run by jtreg.

Thus, an additional supporting file can be removed. Could update the test to create the file as a temporary file, please?

test/jdk/javax/swing/text/BoxView/bug6494356.java line 34:

> 32: import java.beans.PropertyChangeEvent;
> 33: import java.beans.PropertyChangeListener;
> 34: import java.io.IOException;

`IOException` is unused.

test/jdk/javax/swing/text/BoxView/bug6494356.java line 56:

> 54:             public void run() {
> 55:                 ep = new JEditorPane();
> 56:                 ep.setEditorKitForContentType("text/html", editorKit);

Suggestion:

                ep.setEditorKitForContentType("text/html", new MyEditorKit());

The instance of the custom `EditorKit` can be created here. I think it makes the test clearer.

test/jdk/javax/swing/text/BoxView/bug6494356.java line 72:

> 70:                 f.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
> 71:                 f.setVisible(true);
> 72:                 File file = new File("file:" + testSrc + "/" + "bug6494356.html");

Where does this file come from?

As the first step, you should write the file into *the current directory* with the content of `bug6494356.html`, that is `<p>Paragraph</p>`.


        final Path file = Path.of("bug6494356.html");
        try (Writer writer = Files.newBufferedWriter(file)) {
            writer.write("<p>Paragraph</p>");
        }


Then you load the file:


                    ep.setPage("file:" + file);


In the end of the test, you may remove the created file:


        Files.delete(file);

test/jdk/javax/swing/text/BoxView/bug6494356.java line 79:

> 77:                     try (Writer writer = Files.newBufferedWriter(file)) {
> 78:                         writer.write("<p>Paragraph</p>");
> 79:                     } catch (Exception e) {

I suggest creating the file *before* calling `SwingUtilities.invokeLater`.

If it throws an exception, the test fails right away, you won't even run the code inside `invokeLater`.

test/jdk/javax/swing/text/BoxView/bug6494356.java line 117:

> 115:         }
> 116: 
> 117:         static ViewFactory viewFactory = new MyViewFactory();

This should be a `final` field of `MyEditorKit`, no need to make it `static`.

-------------

PR Review: https://git.openjdk.org/jdk/pull/18147#pullrequestreview-1922519738
PR Review: https://git.openjdk.org/jdk/pull/18147#pullrequestreview-1922960768
PR Review: https://git.openjdk.org/jdk/pull/18147#pullrequestreview-1923181380
PR Review Comment: https://git.openjdk.org/jdk/pull/18147#discussion_r1516212830
PR Review Comment: https://git.openjdk.org/jdk/pull/18147#discussion_r1516209847
PR Review Comment: https://git.openjdk.org/jdk/pull/18147#discussion_r1516204845
PR Review Comment: https://git.openjdk.org/jdk/pull/18147#discussion_r1516478899
PR Review Comment: https://git.openjdk.org/jdk/pull/18147#discussion_r1516606920
PR Review Comment: https://git.openjdk.org/jdk/pull/18147#discussion_r1516208607

From psadhukhan at openjdk.org  Fri Mar  8 04:11:15 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Fri, 8 Mar 2024 04:11:15 GMT
Subject: RFR: 8326606: Test javax/swing/text/BoxView/6494356/bug6494356.java
 performs a synchronization on a value based class
Message-ID: <8VnEO3HS6wKX45a3tokydw_aTorFic1acaSiIqm4-7A=.58457c31-1969-47d9-9c1e-365bba1b7174@github.com>

OPensource BoxView test

-------------

Commit messages:
 - Move file creation upfront
 - File creation on the fly
 - Review comment
 - 8326606: Test javax/swing/text/BoxView/6494356/bug6494356.java performs a synchronization on a value based class

Changes: https://git.openjdk.org/jdk/pull/18147/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18147&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8326606
  Stats: 136 lines in 1 file changed: 136 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18147.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18147/head:pull/18147

PR: https://git.openjdk.org/jdk/pull/18147

From aivanov at openjdk.org  Fri Mar  8 04:11:16 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Fri, 8 Mar 2024 04:11:16 GMT
Subject: RFR: 8326606: Test
 javax/swing/text/BoxView/6494356/bug6494356.java performs a synchronization on
 a value based class
In-Reply-To: <ivDZL2CWN-fJhdmezhzhOktIHFmp5SW9yAUxSqo62IU=.0d790dfc-8ab9-41ed-87d0-947aee8cbfd8@github.com>
References: <8VnEO3HS6wKX45a3tokydw_aTorFic1acaSiIqm4-7A=.58457c31-1969-47d9-9c1e-365bba1b7174@github.com>
 <ivDZL2CWN-fJhdmezhzhOktIHFmp5SW9yAUxSqo62IU=.0d790dfc-8ab9-41ed-87d0-947aee8cbfd8@github.com>
Message-ID: <7HFSPVZQoehdVV3zw2mW5otRCyL56TxJlAd7xDiIIeg=.9637503a-ed9a-45e1-b004-ef4233f0f429@github.com>

On Thu, 7 Mar 2024 04:53:07 GMT, Tejesh R <tr at openjdk.org> wrote:

>> OPensource BoxView test
>
> test/jdk/javax/swing/text/BoxView/bug6494356.java line 28:
> 
>> 26:  * @key headful
>> 27:  * @summary Test that BoxView.layout() is not called with negative arguments
>> 28:  * @run main bug6494356 bug6494356.html
> 
> Can the test be converted to non-applet based?

It's not applet-based. The HTML file is an argument to the test, it is the file that's loaded into `JEditorPane`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18147#discussion_r1516193959

From tr at openjdk.org  Fri Mar  8 04:11:16 2024
From: tr at openjdk.org (Tejesh R)
Date: Fri, 8 Mar 2024 04:11:16 GMT
Subject: RFR: 8326606: Test
 javax/swing/text/BoxView/6494356/bug6494356.java performs a synchronization on
 a value based class
In-Reply-To: <7HFSPVZQoehdVV3zw2mW5otRCyL56TxJlAd7xDiIIeg=.9637503a-ed9a-45e1-b004-ef4233f0f429@github.com>
References: <8VnEO3HS6wKX45a3tokydw_aTorFic1acaSiIqm4-7A=.58457c31-1969-47d9-9c1e-365bba1b7174@github.com>
 <ivDZL2CWN-fJhdmezhzhOktIHFmp5SW9yAUxSqo62IU=.0d790dfc-8ab9-41ed-87d0-947aee8cbfd8@github.com>
 <7HFSPVZQoehdVV3zw2mW5otRCyL56TxJlAd7xDiIIeg=.9637503a-ed9a-45e1-b004-ef4233f0f429@github.com>
Message-ID: <qoUyEkcABPyqh4e6NwQ2RHHi8DSEk367G9jngQGQnII=.c9904457-9c8f-43e6-8b71-463394c9cebb@github.com>

On Thu, 7 Mar 2024 13:54:18 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> test/jdk/javax/swing/text/BoxView/bug6494356.java line 28:
>> 
>>> 26:  * @key headful
>>> 27:  * @summary Test that BoxView.layout() is not called with negative arguments
>>> 28:  * @run main bug6494356 bug6494356.html
>> 
>> Can the test be converted to non-applet based?
>
> It's not applet-based. The HTML file is an argument to the test, it is the file that's loaded into `JEditorPane`.

Oh, my bad, didn't notice it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18147#discussion_r1516229717

From aivanov at openjdk.org  Fri Mar  8 04:11:17 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Fri, 8 Mar 2024 04:11:17 GMT
Subject: RFR: 8326606: Test
 javax/swing/text/BoxView/6494356/bug6494356.java performs a synchronization on
 a value based class
In-Reply-To: <qoUyEkcABPyqh4e6NwQ2RHHi8DSEk367G9jngQGQnII=.c9904457-9c8f-43e6-8b71-463394c9cebb@github.com>
References: <8VnEO3HS6wKX45a3tokydw_aTorFic1acaSiIqm4-7A=.58457c31-1969-47d9-9c1e-365bba1b7174@github.com>
 <ivDZL2CWN-fJhdmezhzhOktIHFmp5SW9yAUxSqo62IU=.0d790dfc-8ab9-41ed-87d0-947aee8cbfd8@github.com>
 <7HFSPVZQoehdVV3zw2mW5otRCyL56TxJlAd7xDiIIeg=.9637503a-ed9a-45e1-b004-ef4233f0f429@github.com>
 <qoUyEkcABPyqh4e6NwQ2RHHi8DSEk367G9jngQGQnII=.c9904457-9c8f-43e6-8b71-463394c9cebb@github.com>
Message-ID: <uxQ0S_8xnvTjb1AUnQ98qTQnAOlwLPN8yDfdiOfYTL4=.ed19ef91-8c92-4887-bcfe-fc2d752969d9@github.com>

On Thu, 7 Mar 2024 14:18:39 GMT, Tejesh R <tr at openjdk.org> wrote:

>> It's not applet-based. The HTML file is an argument to the test, it is the file that's loaded into `JEditorPane`.
>
> Oh, my bad, didn't notice it.

Yeah, it's a bit confusing?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18147#discussion_r1516237829

From aivanov at openjdk.org  Fri Mar  8 09:11:54 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Fri, 8 Mar 2024 09:11:54 GMT
Subject: RFR: 8326606: Test
 javax/swing/text/BoxView/6494356/bug6494356.java performs a synchronization on
 a value based class
In-Reply-To: <8VnEO3HS6wKX45a3tokydw_aTorFic1acaSiIqm4-7A=.58457c31-1969-47d9-9c1e-365bba1b7174@github.com>
References: <8VnEO3HS6wKX45a3tokydw_aTorFic1acaSiIqm4-7A=.58457c31-1969-47d9-9c1e-365bba1b7174@github.com>
Message-ID: <2PlMlIeN3UYCqrxhTPLZlPUUyQ3e4CwrB-mlQ-96TPI=.9fcf1c14-f6c4-4249-80ab-17436b6468c7@github.com>

On Thu, 7 Mar 2024 03:16:20 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> OPensource BoxView test

Marked as reviewed by aivanov (Reviewer).

test/jdk/javax/swing/text/BoxView/bug6494356.java line 35:

> 33: 
> 34: import java.awt.Dimension;
> 35: import java.awt.Toolkit;

Usually imports are in alphabetical order without giving special treatment to `java.nio` and `java.io` packages.

test/jdk/javax/swing/text/BoxView/bug6494356.java line 51:

> 49: 
> 50: public class bug6494356 {
> 51:     static String testSrc = System.getProperty("test.src", ".");

`testSrc` is now unused.

-------------

PR Review: https://git.openjdk.org/jdk/pull/18147#pullrequestreview-1924415667
PR Review Comment: https://git.openjdk.org/jdk/pull/18147#discussion_r1517439785
PR Review Comment: https://git.openjdk.org/jdk/pull/18147#discussion_r1517440328

From dmarkov at openjdk.org  Fri Mar  8 09:57:52 2024
From: dmarkov at openjdk.org (Dmitry Markov)
Date: Fri, 8 Mar 2024 09:57:52 GMT
Subject: RFR: 8326661: sun/java2d/cmm/ColorConvertOp/ColConvTest.java
 assumes profiles were generated by LCMS [v2]
In-Reply-To: <0Fr7nxVMAPD27Ejyiw46Vk6mHIQhZagXQUSXBbGeXAA=.d266404a-cc7d-41ef-a2ac-55feb6c95515@github.com>
References: <nFplnFr0UPf-gWrZjoyZhb2pCJ_fjUEieIxTlWesSNs=.7f372d25-5bc5-4fb2-9ecd-8d5e40cc69b8@github.com>
 <6aO1JMWfnuzwP6QH4GVnI9YW7nW8XygymJvsjVU0ykY=.cbf6f144-4a45-428e-9ae3-eacd67641e94@github.com>
 <PuQ3oGFIK3A35zfbSDtT3tRfzVmYyqjxgokbG7jfqSY=.d1d26d54-b9d5-4e82-9c8f-769a965a2d44@github.com>
 <Dk8hEFbO8v4sweXxToR-wjNgKCw2GTBXpgpP_jPwG5k=.07e58905-3c2d-45da-b528-f54e03f4b4b3@github.com>
 <0Fr7nxVMAPD27Ejyiw46Vk6mHIQhZagXQUSXBbGeXAA=.d266404a-cc7d-41ef-a2ac-55feb6c95515@github.com>
Message-ID: <IoRzbvXdpNbUXqUvnRtTVHu6YvYlmJI-IgVJSaMecxc=.ab5a40e0-f53e-4088-b35b-4005b7b3a5d1@github.com>

On Fri, 8 Mar 2024 01:09:27 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>> I agree, I reverted almost all changes except the ones in tolerance for non-LCMS profiles. That values need to be updated to make the test pass on JDKs (e.g. JDK 8u, etc) where non-LCMS profiles are used
>
> Could you please clarify what is the root cause of the problem. I assume you did not update the profiles itself, so what is the problem in the new lcms library?
> 
>>It used to be OK until recent LCMS update where the CMM started to keep original profile ID instead of writing ?lcms? to returned header. 
> 
> Do you mean that previously we always use lcms thresholds even for kcms related profiles?

As far as I know there is no any issues with the new LCMS library. There was a bug in LCMS: it used to set ?lcms? as profile ID to the header. As a result we used lcms threshold even for non-LCMS (kcms, etc.) profiles in the test.
In LCMS 2.16 the problem with profile ID was fixed, see https://github.com/openjdk/jdk/pull/17382/files#diff-738d14c3b278e6d7297dbc4943e90cef33fc04d61eba085218a1229c92ea9a33R941
And the tests started failing for non-LCMS profiles.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18097#discussion_r1517499065

From psadhukhan at openjdk.org  Fri Mar  8 11:34:12 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Fri, 8 Mar 2024 11:34:12 GMT
Subject: RFR: 8326606: Test
 javax/swing/text/BoxView/6494356/bug6494356.java performs a synchronization on
 a value based class [v2]
In-Reply-To: <8VnEO3HS6wKX45a3tokydw_aTorFic1acaSiIqm4-7A=.58457c31-1969-47d9-9c1e-365bba1b7174@github.com>
References: <8VnEO3HS6wKX45a3tokydw_aTorFic1acaSiIqm4-7A=.58457c31-1969-47d9-9c1e-365bba1b7174@github.com>
Message-ID: <8LtJgsYdLRa_NuP3AZlv4u7nJFeliOfvGZNNJUzdI38=.a999646d-91da-499d-a1b5-57a098a42a88@github.com>

> OPensource BoxView test

Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:

  Review comment update

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18147/files
  - new: https://git.openjdk.org/jdk/pull/18147/files/f3e6d0a8..43b05813

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18147&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18147&range=00-01

  Stats: 7 lines in 1 file changed: 3 ins; 4 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18147.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18147/head:pull/18147

PR: https://git.openjdk.org/jdk/pull/18147

From ihse at openjdk.org  Fri Mar  8 15:37:00 2024
From: ihse at openjdk.org (Magnus Ihse Bursie)
Date: Fri, 8 Mar 2024 15:37:00 GMT
Subject: RFR: 8327701: Remove the xlc toolchain
Message-ID: <ZNtnRt4ufmZ5Sp8zURIQwBVraTUPmM30KwL-sC37JeQ=.7135ee42-e9b1-4410-afea-b5c7384ae76e@github.com>

As of [JDK-8325880](https://bugs.openjdk.org/browse/JDK-8325880), building the JDK requires version 17 of IBM Open XL C/C++ (xlc). This is in effect clang by another name, and it uses the clang toolchain in the JDK build. Thus the old xlc toolchain is no longer supported, and should be removed.

-------------

Commit messages:
 - 8327701: Remove the xlc toolchain

Changes: https://git.openjdk.org/jdk/pull/18172/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18172&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8327701
  Stats: 333 lines in 19 files changed: 25 ins; 267 del; 41 mod
  Patch: https://git.openjdk.org/jdk/pull/18172.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18172/head:pull/18172

PR: https://git.openjdk.org/jdk/pull/18172

From ihse at openjdk.org  Fri Mar  8 15:37:02 2024
From: ihse at openjdk.org (Magnus Ihse Bursie)
Date: Fri, 8 Mar 2024 15:37:02 GMT
Subject: RFR: 8327701: Remove the xlc toolchain
In-Reply-To: <ZNtnRt4ufmZ5Sp8zURIQwBVraTUPmM30KwL-sC37JeQ=.7135ee42-e9b1-4410-afea-b5c7384ae76e@github.com>
References: <ZNtnRt4ufmZ5Sp8zURIQwBVraTUPmM30KwL-sC37JeQ=.7135ee42-e9b1-4410-afea-b5c7384ae76e@github.com>
Message-ID: <McIPLciH42WumSGkYLGvyyqQ-tntHyzlYa-iou8p3W8=.800e6f9e-1844-4d56-8054-80477058573f@github.com>

On Fri, 8 Mar 2024 15:29:58 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

> As of [JDK-8325880](https://bugs.openjdk.org/browse/JDK-8325880), building the JDK requires version 17 of IBM Open XL C/C++ (xlc). This is in effect clang by another name, and it uses the clang toolchain in the JDK build. Thus the old xlc toolchain is no longer supported, and should be removed.

make/autoconf/flags-cflags.m4 line 687:

> 685:     PICFLAG="-fPIC"
> 686:     PIEFLAG="-fPIE"
> 687:   elif test "x$TOOLCHAIN_TYPE" = xclang && test "x$OPENJDK_TARGET_OS" = xaix; then

Just a remark: This code has never been executed, since running with clang on any OS would hit the branch above. Also, the code is syntactically incorrect, missing a trailing `"`.

make/autoconf/flags-cflags.m4 line 695:

> 693:       -D$FLAGS_CPU_LEGACY"
> 694: 
> 695:   if test "x$FLAGS_CPU_BITS" = x64; then

A wise man said: "If the code and the comments contradict each other, then probably both are wrong".

I am here assuming that the comment claiming that this is only needed by xlc is correct. If it turns out that this is needed even with clang on AIX, we'll have to restore the test and update the comment to this fact.

make/autoconf/flags.m4 line 324:

> 322: AC_DEFUN([FLAGS_SETUP_TOOLCHAIN_CONTROL],
> 323: [
> 324:   # COMPILER_TARGET_BITS_FLAG  : option for selecting 32- or 64-bit output

COMPILER_TARGET_BITS_FLAG and COMPILER_BINDCMD_FILE_FLAG was introduced just for xlc, so they are not needed anymore. COMPILER_COMMAND_FILE_FLAG was introduced to support ancient versions of gcc, and then used by xlc as well. It is not needed for gcc anymore, so I remove it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18172#discussion_r1517871818
PR Review Comment: https://git.openjdk.org/jdk/pull/18172#discussion_r1517873282
PR Review Comment: https://git.openjdk.org/jdk/pull/18172#discussion_r1517874782

From ihse at openjdk.org  Fri Mar  8 15:40:57 2024
From: ihse at openjdk.org (Magnus Ihse Bursie)
Date: Fri, 8 Mar 2024 15:40:57 GMT
Subject: RFR: 8327701: Remove the xlc toolchain
In-Reply-To: <ZNtnRt4ufmZ5Sp8zURIQwBVraTUPmM30KwL-sC37JeQ=.7135ee42-e9b1-4410-afea-b5c7384ae76e@github.com>
References: <ZNtnRt4ufmZ5Sp8zURIQwBVraTUPmM30KwL-sC37JeQ=.7135ee42-e9b1-4410-afea-b5c7384ae76e@github.com>
Message-ID: <ldsvuZ2jndrFP-OVZNw0oKI8hVK_T-1ItWKiUBN9g9M=.aa4a2a37-d87e-4fd5-ad72-2729748b1b5d@github.com>

On Fri, 8 Mar 2024 15:29:58 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

> As of [JDK-8325880](https://bugs.openjdk.org/browse/JDK-8325880), building the JDK requires version 17 of IBM Open XL C/C++ (xlc). This is in effect clang by another name, and it uses the clang toolchain in the JDK build. Thus the old xlc toolchain is no longer supported, and should be removed.

make/autoconf/toolchain.m4 line 420:

> 418:     # Remove "Thread model:" and further details from the version string, and
> 419:     # collapse into a single line
> 420:     COMPILER_VERSION_STRING=`$ECHO $COMPILER_VERSION_OUTPUT | \

These changes are not strictly needed, but it makes printing the clang version nicer, and compensates for the removal of the extra version information that was printed by some of the removed code.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18172#discussion_r1517880241

From ihse at openjdk.org  Fri Mar  8 15:48:08 2024
From: ihse at openjdk.org (Magnus Ihse Bursie)
Date: Fri, 8 Mar 2024 15:48:08 GMT
Subject: RFR: 8327701: Remove the xlc toolchain [v2]
In-Reply-To: <YVdSIUybMmPFB4eNvHAxfmfEqOzrrt5l6AA9j44DlBM=.2bb3f97e-583c-4ee5-9a5a-c02454315b33@github.com>
References: <ZNtnRt4ufmZ5Sp8zURIQwBVraTUPmM30KwL-sC37JeQ=.7135ee42-e9b1-4410-afea-b5c7384ae76e@github.com>
 <YVdSIUybMmPFB4eNvHAxfmfEqOzrrt5l6AA9j44DlBM=.2bb3f97e-583c-4ee5-9a5a-c02454315b33@github.com>
Message-ID: <hFoTfkg6kW-Eskfekboz2zsw04fhxDCtcZSJDX_5ZAE=.5d56943b-67ae-42ce-bdf5-4d972c4d03e8@github.com>

On Fri, 8 Mar 2024 15:44:48 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> As of [JDK-8325880](https://bugs.openjdk.org/browse/JDK-8325880), building the JDK requires version 17 of IBM Open XL C/C++ (xlc). This is in effect clang by another name, and it uses the clang toolchain in the JDK build. Thus the old xlc toolchain is no longer supported, and should be removed.
>
> Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Revert SEARCH_PATH changes

make/autoconf/toolchain.m4 line 444:

> 442:   COMPILER_NAME=$2
> 443:   SEARCH_LIST="$3"
> 444:   SEARCH_PATH="$PATH"

I am note 100% sure about this; I think the intention of some of the old code amounted to this, but it was not entirely clear.

But, then again, I think this is a good idea, and I think we should do this on *all* platforms -- search the toolchain path before the normal path.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18172#discussion_r1517884839

From ihse at openjdk.org  Fri Mar  8 15:48:08 2024
From: ihse at openjdk.org (Magnus Ihse Bursie)
Date: Fri, 8 Mar 2024 15:48:08 GMT
Subject: RFR: 8327701: Remove the xlc toolchain [v2]
In-Reply-To: <hFoTfkg6kW-Eskfekboz2zsw04fhxDCtcZSJDX_5ZAE=.5d56943b-67ae-42ce-bdf5-4d972c4d03e8@github.com>
References: <ZNtnRt4ufmZ5Sp8zURIQwBVraTUPmM30KwL-sC37JeQ=.7135ee42-e9b1-4410-afea-b5c7384ae76e@github.com>
 <YVdSIUybMmPFB4eNvHAxfmfEqOzrrt5l6AA9j44DlBM=.2bb3f97e-583c-4ee5-9a5a-c02454315b33@github.com>
 <hFoTfkg6kW-Eskfekboz2zsw04fhxDCtcZSJDX_5ZAE=.5d56943b-67ae-42ce-bdf5-4d972c4d03e8@github.com>
Message-ID: <HYb0qYm5jcYTQRg6E6nJZr6RfFzc4c2xg-W20M2S3WU=.2ea8e17c-1415-4eab-b9db-a70edee88b34@github.com>

On Fri, 8 Mar 2024 15:41:16 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Revert SEARCH_PATH changes
>
> make/autoconf/toolchain.m4 line 444:
> 
>> 442:   COMPILER_NAME=$2
>> 443:   SEARCH_LIST="$3"
>> 444:   SEARCH_PATH="$PATH"
> 
> I am note 100% sure about this; I think the intention of some of the old code amounted to this, but it was not entirely clear.
> 
> But, then again, I think this is a good idea, and I think we should do this on *all* platforms -- search the toolchain path before the normal path.

Hm, as I write this, it strikes me as odd that we should not do this already. And of course we do, in `TOOLCHAIN_PRE_DETECTION`, so this snippet snippet is actually redundant.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18172#discussion_r1517889315

From ihse at openjdk.org  Fri Mar  8 15:48:08 2024
From: ihse at openjdk.org (Magnus Ihse Bursie)
Date: Fri, 8 Mar 2024 15:48:08 GMT
Subject: RFR: 8327701: Remove the xlc toolchain [v2]
In-Reply-To: <ZNtnRt4ufmZ5Sp8zURIQwBVraTUPmM30KwL-sC37JeQ=.7135ee42-e9b1-4410-afea-b5c7384ae76e@github.com>
References: <ZNtnRt4ufmZ5Sp8zURIQwBVraTUPmM30KwL-sC37JeQ=.7135ee42-e9b1-4410-afea-b5c7384ae76e@github.com>
Message-ID: <YVdSIUybMmPFB4eNvHAxfmfEqOzrrt5l6AA9j44DlBM=.2bb3f97e-583c-4ee5-9a5a-c02454315b33@github.com>

> As of [JDK-8325880](https://bugs.openjdk.org/browse/JDK-8325880), building the JDK requires version 17 of IBM Open XL C/C++ (xlc). This is in effect clang by another name, and it uses the clang toolchain in the JDK build. Thus the old xlc toolchain is no longer supported, and should be removed.

Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:

  Revert SEARCH_PATH changes

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18172/files
  - new: https://git.openjdk.org/jdk/pull/18172/files/9f4a059d..53a05019

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18172&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18172&range=00-01

  Stats: 7 lines in 1 file changed: 0 ins; 5 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/18172.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18172/head:pull/18172

PR: https://git.openjdk.org/jdk/pull/18172

From ihse at openjdk.org  Fri Mar  8 15:55:54 2024
From: ihse at openjdk.org (Magnus Ihse Bursie)
Date: Fri, 8 Mar 2024 15:55:54 GMT
Subject: RFR: 8327701: Remove the xlc toolchain [v2]
In-Reply-To: <YVdSIUybMmPFB4eNvHAxfmfEqOzrrt5l6AA9j44DlBM=.2bb3f97e-583c-4ee5-9a5a-c02454315b33@github.com>
References: <ZNtnRt4ufmZ5Sp8zURIQwBVraTUPmM30KwL-sC37JeQ=.7135ee42-e9b1-4410-afea-b5c7384ae76e@github.com>
 <YVdSIUybMmPFB4eNvHAxfmfEqOzrrt5l6AA9j44DlBM=.2bb3f97e-583c-4ee5-9a5a-c02454315b33@github.com>
Message-ID: <mYm2C3YLu1415eKcAKPGBTAbToAR64cARDtZNQ2nl4w=.3422c02e-2d75-422b-9ab6-eafef1dea0f2@github.com>

On Fri, 8 Mar 2024 15:48:08 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> As of [JDK-8325880](https://bugs.openjdk.org/browse/JDK-8325880), building the JDK requires version 17 of IBM Open XL C/C++ (xlc). This is in effect clang by another name, and it uses the clang toolchain in the JDK build. Thus the old xlc toolchain is no longer supported, and should be removed.
>
> Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Revert SEARCH_PATH changes

Also, I believe that the `HOTSPOT_TOOLCHAIN_TYPE=xlc` quirk actually is bad. This means that the clang functionality in `compilerWarnings_gcc.hpp` (where the `_gcc` is hotspot-speak for "clang or gcc") is being ignored, and it means that globalDefinitions_xlc.hpp is in big parts a direct copy of globalDefinitions_gcc.hpp, but apparently lagging in some fixes that has been made in that file.

And it means a lot of lines like this:

#if defined(TARGET_COMPILER_gcc) || defined(TARGET_COMPILER_xlc)


But cleaning up that is left as an exercise to the AIX team; my goal here just primarily to get rid of the old xlc stuff from the build system.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18172#issuecomment-1985939418

From jwaters at openjdk.org  Fri Mar  8 16:19:53 2024
From: jwaters at openjdk.org (Julian Waters)
Date: Fri, 8 Mar 2024 16:19:53 GMT
Subject: RFR: 8327701: Remove the xlc toolchain [v2]
In-Reply-To: <YVdSIUybMmPFB4eNvHAxfmfEqOzrrt5l6AA9j44DlBM=.2bb3f97e-583c-4ee5-9a5a-c02454315b33@github.com>
References: <ZNtnRt4ufmZ5Sp8zURIQwBVraTUPmM30KwL-sC37JeQ=.7135ee42-e9b1-4410-afea-b5c7384ae76e@github.com>
 <YVdSIUybMmPFB4eNvHAxfmfEqOzrrt5l6AA9j44DlBM=.2bb3f97e-583c-4ee5-9a5a-c02454315b33@github.com>
Message-ID: <H74qiAaDMApqYoSWhSxsvg-xpzqcCmZnfxCjyQr6HLw=.3ecc0c42-b170-43a9-ae2c-bb43ba338287@github.com>

On Fri, 8 Mar 2024 15:48:08 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> As of [JDK-8325880](https://bugs.openjdk.org/browse/JDK-8325880), building the JDK requires version 17 of IBM Open XL C/C++ (xlc). This is in effect clang by another name, and it uses the clang toolchain in the JDK build. Thus the old xlc toolchain is no longer supported, and should be removed.
>
> Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Revert SEARCH_PATH changes

Build changes look ok, but I'm not an AIX developer

-------------

Marked as reviewed by jwaters (Committer).

PR Review: https://git.openjdk.org/jdk/pull/18172#pullrequestreview-1925243852

From tr at openjdk.org  Fri Mar  8 16:31:52 2024
From: tr at openjdk.org (Tejesh R)
Date: Fri, 8 Mar 2024 16:31:52 GMT
Subject: RFR: 8326606: Test
 javax/swing/text/BoxView/6494356/bug6494356.java performs a synchronization on
 a value based class [v2]
In-Reply-To: <8LtJgsYdLRa_NuP3AZlv4u7nJFeliOfvGZNNJUzdI38=.a999646d-91da-499d-a1b5-57a098a42a88@github.com>
References: <8VnEO3HS6wKX45a3tokydw_aTorFic1acaSiIqm4-7A=.58457c31-1969-47d9-9c1e-365bba1b7174@github.com>
 <8LtJgsYdLRa_NuP3AZlv4u7nJFeliOfvGZNNJUzdI38=.a999646d-91da-499d-a1b5-57a098a42a88@github.com>
Message-ID: <dy7b3L76BdmPa37PO5N2gaaY2LUROOwXp00J4Tw7ac0=.0c3beef6-320c-4578-a270-4887e1812d15@github.com>

On Fri, 8 Mar 2024 11:34:12 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> OPensource BoxView test
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review comment update

Marked as reviewed by tr (Committer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18147#pullrequestreview-1925275615

From erikj at openjdk.org  Fri Mar  8 18:51:54 2024
From: erikj at openjdk.org (Erik Joelsson)
Date: Fri, 8 Mar 2024 18:51:54 GMT
Subject: RFR: 8327701: Remove the xlc toolchain [v2]
In-Reply-To: <YVdSIUybMmPFB4eNvHAxfmfEqOzrrt5l6AA9j44DlBM=.2bb3f97e-583c-4ee5-9a5a-c02454315b33@github.com>
References: <ZNtnRt4ufmZ5Sp8zURIQwBVraTUPmM30KwL-sC37JeQ=.7135ee42-e9b1-4410-afea-b5c7384ae76e@github.com>
 <YVdSIUybMmPFB4eNvHAxfmfEqOzrrt5l6AA9j44DlBM=.2bb3f97e-583c-4ee5-9a5a-c02454315b33@github.com>
Message-ID: <AnMHKVWi_3oZVuemQQxlgm2OjFGSOcL52W6qXsBzurw=.27e93fd1-12f8-4504-bcfc-89112dc77f82@github.com>

On Fri, 8 Mar 2024 15:48:08 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> As of [JDK-8325880](https://bugs.openjdk.org/browse/JDK-8325880), building the JDK requires version 17 of IBM Open XL C/C++ (xlc). This is in effect clang by another name, and it uses the clang toolchain in the JDK build. Thus the old xlc toolchain is no longer supported, and should be removed.
>
> Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Revert SEARCH_PATH changes

Build changes look good to me, but needs review and verification from the AIX folks.

-------------

Marked as reviewed by erikj (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18172#pullrequestreview-1925621925

From serb at openjdk.org  Fri Mar  8 22:27:58 2024
From: serb at openjdk.org (Sergey Bylokhov)
Date: Fri, 8 Mar 2024 22:27:58 GMT
Subject: RFR: 8326661: sun/java2d/cmm/ColorConvertOp/ColConvTest.java
 assumes profiles were generated by LCMS [v2]
In-Reply-To: <FLf1tladgJ4PCOzVIcNUHaXrbSezgSfiZVtFkwfDCoo=.75437269-3d71-45c4-9372-5c0566ae2312@github.com>
References: <nFplnFr0UPf-gWrZjoyZhb2pCJ_fjUEieIxTlWesSNs=.7f372d25-5bc5-4fb2-9ecd-8d5e40cc69b8@github.com>
 <FLf1tladgJ4PCOzVIcNUHaXrbSezgSfiZVtFkwfDCoo=.75437269-3d71-45c4-9372-5c0566ae2312@github.com>
Message-ID: <Vxh1yl4YhLvPzRM4zPe5tcJYa03HT4aAs7IgbP7DCBI=.a1e1d287-2f45-4ee5-90df-506c26eea87c@github.com>

On Thu, 7 Mar 2024 12:36:05 GMT, Dmitry Markov <dmarkov at openjdk.org> wrote:

>> Updated several tests to avoid potential failure with recent LCMS update and non-LCMS generated profile.
>
> Dmitry Markov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Tolerance update

Marked as reviewed by serb (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18097#pullrequestreview-1925957557

From mickleness at gmail.com  Fri Mar  8 23:40:08 2024
From: mickleness at gmail.com (Jeremy Wood)
Date: Fri, 08 Mar 2024 23:40:08 +0000
Subject: how to get find out the keyboard shortcut for the paste action?
In-Reply-To: <CH3PR12MB7619083DF388D7365B84BB56F9222@CH3PR12MB7619.namprd12.prod.outlook.com>
References: <CH3PR12MB76198C4F8B2300D806EDCCF0F9452@CH3PR12MB7619.namprd12.prod.outlook.com>
 <em455be664-76d1-43e4-ba85-729678b34dc6@76ca4640.com>
 <CH3PR12MB7619B0682852C7C836096E84F95C2@CH3PR12MB7619.namprd12.prod.outlook.com>
 <CH3PR12MB76199D23AB541CB4C09118AAF95C2@CH3PR12MB7619.namprd12.prod.outlook.com>
 <emfa5db32b-c08c-4ebc-a061-fc24306fbe93@dcff66fe.com>
 <CH3PR12MB76196E29050B67CD2888B8AEF9232@CH3PR12MB7619.namprd12.prod.outlook.com>
 <8399c796-17e8-4d78-9916-a55054251420@oracle.com>
 <CH3PR12MB7619083DF388D7365B84BB56F9222@CH3PR12MB7619.namprd12.prod.outlook.com>
Message-ID: <emb0be8964-a76e-4815-a1aa-19dbefcd2621@dcff66fe.com>

Alexey,

 > Does the input map of JTextArea contain shortcuts for Cut, Copy and 
Paste?

When I call (on my Mac, using openJDK 17)
UIManager.getDefaults().get("TextArea.focusInputMap?)
? I get an InputMap with: ?copy-to-clipboard?, ?cut-to-clipboard?, and 
?paste-from-clipboard?.

The code I tested against is:
InputMap inputMap = (InputMap) UIManager.getDefaults().get("TextArea.focusInputMap");
Map<Object, Collection<KeyStroke>> map = new TreeMap<>();
for (KeyStroke keyStroke : inputMap.keys()) {
Object key = inputMap.get(keyStroke);
Collection value = map.get(key);
if (value == null) {
value = new HashSet();
map.put(key, value);
     }
value.add(keyStroke);
}
for (Map.Entry<Object, Collection<KeyStroke>> e : map.entrySet()) {
System.out.println(e);
}

Previous tests showed the same naming convention on Windows for 
JTextFields; I don?t know how standardized that naming convention is 
across all platforms / L&F?s.

  - Jeremy


------ Original Message ------
>From mark.yagnatinsky at barclays.com
To alexey.ivanov at oracle.com; mickleness at gmail.com; 
client-libs-dev at openjdk.org
Date 3/5/24, 11:48:48?AM
Subject RE: how to get find out the keyboard shortcut for the paste 
action?

>Thanks, this was educational.  I never even thought about how localization might affect all this.
>
>-----Original Message-----
>From: Aleksei Ivanov <alexey.ivanov at oracle.com>
>Sent: Tuesday, March 5, 2024 10:41 AM
>To: Yagnatinsky, Mark : Markets Pre Trade <mark.yagnatinsky at barclays.com>; mickleness at gmail.com; client-libs-dev at openjdk.org
>Subject: Re: how to get find out the keyboard shortcut for the paste action?
>
>
>CAUTION: This email originated from outside our organisation - alexey.ivanov at oracle.com Do not click on links, open attachments, or respond unless you recognize the sender and can validate the content is safe.
>Hello Mark,
>
>As far as I know, the shortcuts are localisable. For example, you use
>Ctrl+S to save a file in an English version, yet users of Spanish
>version of Windows use Ctrl+G (for Guardar) instead.
>
>At the same time, the most common actions ? Cut, Copy and Paste as well as Undo and Redo ? usually have the same shortcuts across all languages and OS, although macOS uses Cmd instead of Ctrl. However, the shortcut for Redo is not as standard, Ctrl+Shift+Z and Ctrl+Y are used, both could be mapped at the same time.
>
>I wonder what is the shortcut for Undo in German versions since German keyboard layout has Z and Y keys swapped. Does anyone know?
>
>So, the shortcuts used in an application are controlled by the application and the shortcuts can be localised.
>
>For this reason, the shortcuts are usually ?hardcoded?.
>
>
>@Jeremy
>Does the input map of JTextArea contain shortcuts for Cut, Copy and Paste?
>
>On 2024-03-04 20:42, mark.yagnatinsky at barclays.com wrote:
>>
>>  Thanks!  I don?t have a particularly deep motivation here, other than
>>  curiosity.
>>
>>  If you?re wondering how my curiosity got piqued initially, it was
>>  something like this:
>>
>>  A while ago, someone at work was adding copy/paste support to some
>>  component that didn?t have it.
>>
>>  I noticed that they ?hardcoded? the shortcut ?ctrl C?.
>>
>>  And I thought to myself:
>>
>>  Swing already ?knows? that this is the right keyboard shortcut, in the
>>  sense that all components that support copy/paste ?out of the box? use it.
>>
>>  It would be nice if there was some way to ASK it to tell me what it
>>  ?knows?.
>>
>>  *From:* Jeremy Wood <mickleness at gmail.com>
>>  *Sent:* Sunday, March 3, 2024 11:30 PM
>>  *To:* Yagnatinsky, Mark : Markets Pre Trade
>>  <mark.yagnatinsky at barclays.com>; client-libs-dev at openjdk.org
>>  *Subject:* Re[2]: how to get find out the keyboard shortcut for the
>>  paste action?
>>
>>  CAUTION: This email originated from outside our organisation -
>>mickleness at gmail.com Do not click on links, open attachments, or
>>  respond unless you recognize the sender and can validate the content
>>  is safe.
>>
>>  > But now I have a new question?
>>
>>  > Is there any way to get the ?usual? letter for a ?common? operation?
>>
>>  Hmm. Good question. Not that I know of.
>>
>>  > Again, one could create a scratch text area and grovel through its
>>  input map, but that seems hacky.
>>
>>  I agree sifting through the L&F seems hacky.
>>
>>  I don?t think I understand exactly what you?re trying to implement
>>  here. If you give me a more concrete example: maybe I (or someone on
>>  this list) can offer a more concrete suggestion?
>>
>>  I?ll add some context in case this speaks to your question.
>>
>>  By default Swing gets this information in places like
>>  BasicTextUI#getInputMap(), which calls:
>>
>>  InputMap shared=     (InputMap)DefaultLookup./get/(editor, this,
>>  getPropertyPrefix() + ".focusInputMap?);
>>
>>  The following works on my Mac & Windows machine (I think using JDK
>>  19), but I wouldn?t be surprised if it fails in other platforms /
>>  L&F?s. It feels brittle, but it might (?) have potential:
>>
>>  private KeyStroke getCopyKeyStroke() {
>>
>>  InputMap inputMap = (InputMap)
>>  UIManager.getDefaults().get("TextField.focusInputMap"); for (KeyStroke
>>  keyStroke : inputMap.keys()) { Object action =
>>  inputMap.get(keyStroke); if ("copy-to-clipboard".equals(action)) {
>>  return keyStroke;         }     } /// this will show all the default
>>  keystrokes // System.out.println(Arrays.asList(inputMap.allKeys()));
>>  /return null; }
>>
>>  Regards,
>>
>>   - Jeremy
>>
>>  ------ Original Message ------
>>
>>  From mark.yagnatinsky at barclays.com
>>
>>  To mickleness at gmail.com; client-libs-dev at openjdk.org
>>
>>  Date 3/3/24, 6:00:46?PM
>>
>>  Subject RE: how to get find out the keyboard shortcut for the paste
>>  action?
>>
>>      Thanks for the response!  I didn?t expect to get one at this point
>>  J
>>
>>      It does indeed answer my question!
>>
>>      (Though you didn?t quite get the name right: there?s no Ex at the
>>  end?
>>
>>      I take it you?ve done some Windows programming at some point)
>>
>>      But now I have a new question?
>>
>>      Is there any way to get the ?usual? letter for a ?common? operation?
>>
>>      For instance, lots of programs support copy and paste.
>>
>>      Is there a way to ask Java ?what is the standard letter for paste?
>>      and get back ?V??
>>
>>      Again, one could create a scratch text area and grovel through its
>>      input map, but that seems hacky.
>>
>--
>Regards,
>Alexey
>
>This message is for information purposes only. It is not a recommendation, advice, offer or solicitation to buy or sell a product or service, nor an official confirmation of any transaction. It is directed at persons who are professionals and is intended for the recipient(s) only. It is not directed at retail customers. This message is subject to the terms at: https://www.ib.barclays/disclosures/web-and-email-disclaimer.html.
>
>For important disclosures, please see: https://www.ib.barclays/disclosures/sales-and-trading-disclaimer.html regarding marketing commentary from Barclays Sales and/or Trading desks, who are active market participants; https://www.ib.barclays/disclosures/barclays-global-markets-disclosures.html regarding our standard terms for Barclays Investment Bank where we trade with you in principal-to-principal wholesale markets transactions; and in respect to Barclays Research, including disclosures relating to specific issuers, see: http://publicresearch.barclays.com.
>__________________________________________________________________________________
>If you are incorporated or operating in Australia, read these important disclosures: https://www.ib.barclays/disclosures/important-disclosures-asia-pacific.html.
>__________________________________________________________________________________
>For more details about how we use personal information, see our privacy notice: https://www.ib.barclays/disclosures/personal-information-use.html.
>__________________________________________________________________________________
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/client-libs-dev/attachments/20240308/efe6cbdb/attachment-0001.htm>

From mark.yagnatinsky at barclays.com  Fri Mar  8 23:46:45 2024
From: mark.yagnatinsky at barclays.com (mark.yagnatinsky at barclays.com)
Date: Fri, 8 Mar 2024 23:46:45 +0000
Subject: how to get find out the keyboard shortcut for the paste
 action?
In-Reply-To: <emb0be8964-a76e-4815-a1aa-19dbefcd2621@dcff66fe.com>
References: <CH3PR12MB76198C4F8B2300D806EDCCF0F9452@CH3PR12MB7619.namprd12.prod.outlook.com>
 <em455be664-76d1-43e4-ba85-729678b34dc6@76ca4640.com>
 <CH3PR12MB7619B0682852C7C836096E84F95C2@CH3PR12MB7619.namprd12.prod.outlook.com>
 <CH3PR12MB76199D23AB541CB4C09118AAF95C2@CH3PR12MB7619.namprd12.prod.outlook.com>
 <emfa5db32b-c08c-4ebc-a061-fc24306fbe93@dcff66fe.com>
 <CH3PR12MB76196E29050B67CD2888B8AEF9232@CH3PR12MB7619.namprd12.prod.outlook.com>
 <8399c796-17e8-4d78-9916-a55054251420@oracle.com>
 <CH3PR12MB7619083DF388D7365B84BB56F9222@CH3PR12MB7619.namprd12.prod.outlook.com>
 <emb0be8964-a76e-4815-a1aa-19dbefcd2621@dcff66fe.com>
Message-ID: <CH3PR12MB7619094C6FF36E2A8A0457CBF9272@CH3PR12MB7619.namprd12.prod.outlook.com>

Turns out that it is standardized:
https://docs.oracle.com/javase/8/docs/api/constant-values.html#javax.swing.text.DefaultEditorKit.cutAction


? I get an InputMap with: ?copy-to-clipboard?, ?cut-to-clipboard?, and ?paste-from-clipboard?.
Previous tests showed the same naming convention on Windows for JTextFields; I don?t know how standardized that naming convention is across all platforms / L&F?s.

This message is for information purposes only. It is not a recommendation, advice, offer or solicitation to buy or sell a product or service, nor an official confirmation of any transaction. It is directed at persons who are professionals and is intended for the recipient(s) only. It is not directed at retail customers. This message is subject to the terms at: https://www.ib.barclays/disclosures/web-and-email-disclaimer.html. 

For important disclosures, please see: https://www.ib.barclays/disclosures/sales-and-trading-disclaimer.html regarding marketing commentary from Barclays Sales and/or Trading desks, who are active market participants; https://www.ib.barclays/disclosures/barclays-global-markets-disclosures.html regarding our standard terms for Barclays Investment Bank where we trade with you in principal-to-principal wholesale markets transactions; and in respect to Barclays Research, including disclosures relating to specific issuers, see: http://publicresearch.barclays.com.
__________________________________________________________________________________ 
If you are incorporated or operating in Australia, read these important disclosures: https://www.ib.barclays/disclosures/important-disclosures-asia-pacific.html.
__________________________________________________________________________________
For more details about how we use personal information, see our privacy notice: https://www.ib.barclays/disclosures/personal-information-use.html. 
__________________________________________________________________________________
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/client-libs-dev/attachments/20240308/e323a95f/attachment.htm>

From achung at openjdk.org  Sat Mar  9 00:54:05 2024
From: achung at openjdk.org (Alisen Chung)
Date: Sat, 9 Mar 2024 00:54:05 GMT
Subject: RFR: 8327492: Remove applet usage and update
 DisposeInActionEventTest.html [v15]
In-Reply-To: <wbQWXZ3sLQB90OPGZTWuifQuxdk7bFfiouu2NzUEzHQ=.310c2f89-b621-4f34-a949-1f319bcac8ce@github.com>
References: <wbQWXZ3sLQB90OPGZTWuifQuxdk7bFfiouu2NzUEzHQ=.310c2f89-b621-4f34-a949-1f319bcac8ce@github.com>
Message-ID: <tA0UFwrVnaMiltnNGunWRJjAoK-09pWb6K_o4l1418U=.b0ade2ca-ad5f-4dfb-bf46-5a79dacaffe3@github.com>

> Root cause of the test failure was fixed with https://bugs.openjdk.org/browse/JDK-8316931, updating this test since the other fix also included a test update.

Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:

  update test instructions, fix spacing

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/17838/files
  - new: https://git.openjdk.org/jdk/pull/17838/files/0947ce09..3cb76575

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=17838&range=14
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17838&range=13-14

  Stats: 4 lines in 2 files changed: 1 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/jdk/pull/17838.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17838/head:pull/17838

PR: https://git.openjdk.org/jdk/pull/17838

From achung at openjdk.org  Sat Mar  9 01:23:03 2024
From: achung at openjdk.org (Alisen Chung)
Date: Sat, 9 Mar 2024 01:23:03 GMT
Subject: Integrated: 8327492: Remove applet usage and update
 DisposeInActionEventTest.html
In-Reply-To: <wbQWXZ3sLQB90OPGZTWuifQuxdk7bFfiouu2NzUEzHQ=.310c2f89-b621-4f34-a949-1f319bcac8ce@github.com>
References: <wbQWXZ3sLQB90OPGZTWuifQuxdk7bFfiouu2NzUEzHQ=.310c2f89-b621-4f34-a949-1f319bcac8ce@github.com>
Message-ID: <bzQ70xg7kZWjyd9_pDHsaSnNeH2BGZmnJSpwWVa2mgQ=.4b672e0a-89c7-46ed-90e4-2714b0afeee1@github.com>

On Tue, 13 Feb 2024 21:34:09 GMT, Alisen Chung <achung at openjdk.org> wrote:

> Root cause of the test failure was fixed with https://bugs.openjdk.org/browse/JDK-8316931, updating this test since the other fix also included a test update.

This pull request has now been integrated.

Changeset: 53628f2e
Author:    Alisen Chung <achung at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/53628f2ea9c2fb60fbdd0a03216e97e00b15fcb6
Stats:     185 lines in 3 files changed: 47 ins; 86 del; 52 mod

8327492: Remove applet usage and update DisposeInActionEventTest.html

Reviewed-by: dnguyen, tr, abhiscxk, honkar, aivanov

-------------

PR: https://git.openjdk.org/jdk/pull/17838

From psadhukhan at openjdk.org  Mon Mar 11 06:27:16 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Mon, 11 Mar 2024 06:27:16 GMT
Subject: RFR: 8327748: Convert javax/swing/JFileChooser/6798062/bug6798062.java
 applet test to main
Message-ID: <lGQbwCvyqdtOr8-NxY9l3pZC4mRPn7gBtd7qPIRPF-I=.0379a965-6ad2-44ba-abfe-ecd0ed3f7b02@github.com>

Conversion of manual applet test to main based using PassFailJFrame manual framework

-------------

Commit messages:
 - 8327748: Convert javax/swing/JFileChooser/6798062/bug6798062.java applet test to main

Changes: https://git.openjdk.org/jdk/pull/18180/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18180&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8327748
  Stats: 108 lines in 2 files changed: 35 ins; 38 del; 35 mod
  Patch: https://git.openjdk.org/jdk/pull/18180.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18180/head:pull/18180

PR: https://git.openjdk.org/jdk/pull/18180

From mbaesken at openjdk.org  Mon Mar 11 07:53:53 2024
From: mbaesken at openjdk.org (Matthias Baesken)
Date: Mon, 11 Mar 2024 07:53:53 GMT
Subject: RFR: 8327701: Remove the xlc toolchain [v2]
In-Reply-To: <YVdSIUybMmPFB4eNvHAxfmfEqOzrrt5l6AA9j44DlBM=.2bb3f97e-583c-4ee5-9a5a-c02454315b33@github.com>
References: <ZNtnRt4ufmZ5Sp8zURIQwBVraTUPmM30KwL-sC37JeQ=.7135ee42-e9b1-4410-afea-b5c7384ae76e@github.com>
 <YVdSIUybMmPFB4eNvHAxfmfEqOzrrt5l6AA9j44DlBM=.2bb3f97e-583c-4ee5-9a5a-c02454315b33@github.com>
Message-ID: <ymrpGsxg65O-y82OYS78OH_iUqSUP5n1irHNtpr1uhU=.8d577b81-8a93-4648-bb03-2bb866a02b1b@github.com>

On Fri, 8 Mar 2024 15:48:08 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> As of [JDK-8325880](https://bugs.openjdk.org/browse/JDK-8325880), building the JDK requires version 17 of IBM Open XL C/C++ (xlc). This is in effect clang by another name, and it uses the clang toolchain in the JDK build. Thus the old xlc toolchain is no longer supported, and should be removed.
>
> Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Revert SEARCH_PATH changes

Hi, thanks for doing this cleanup change.  I put it into our build/test queue to see the results on AIX.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18172#issuecomment-1987807579

From psadhukhan at openjdk.org  Mon Mar 11 08:59:01 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Mon, 11 Mar 2024 08:59:01 GMT
Subject: RFR: 8327750: Convert
 javax/swing/JFileChooser/FileFilterDescription/FileFilterDescription.java
 applet test to main
Message-ID: <Fri2USQ-lXz_OJYx4o2lhB5twAsUnaOn8R2ylmurMSk=.1c9502c4-a43b-4137-854c-25040beb0593@github.com>

Conversion of manual applet test to main based using PassFailJFrame manual framework

-------------

Commit messages:
 - 8327750: Convert javax/swing/JFileChooser/FileFilterDescription/FileFilterDescription.java applet test to main

Changes: https://git.openjdk.org/jdk/pull/18182/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18182&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8327750
  Stats: 81 lines in 2 files changed: 23 ins; 50 del; 8 mod
  Patch: https://git.openjdk.org/jdk/pull/18182.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18182/head:pull/18182

PR: https://git.openjdk.org/jdk/pull/18182

From jkern at openjdk.org  Mon Mar 11 09:23:57 2024
From: jkern at openjdk.org (Joachim Kern)
Date: Mon, 11 Mar 2024 09:23:57 GMT
Subject: RFR: 8327701: Remove the xlc toolchain [v2]
In-Reply-To: <YVdSIUybMmPFB4eNvHAxfmfEqOzrrt5l6AA9j44DlBM=.2bb3f97e-583c-4ee5-9a5a-c02454315b33@github.com>
References: <ZNtnRt4ufmZ5Sp8zURIQwBVraTUPmM30KwL-sC37JeQ=.7135ee42-e9b1-4410-afea-b5c7384ae76e@github.com>
 <YVdSIUybMmPFB4eNvHAxfmfEqOzrrt5l6AA9j44DlBM=.2bb3f97e-583c-4ee5-9a5a-c02454315b33@github.com>
Message-ID: <mehlNc-3I43oISWMHGfAHxhm1W5RKyEvGQk5ru5dwGY=.ebdd700d-4ca2-47c2-961c-b5fcea5c00ec@github.com>

On Fri, 8 Mar 2024 15:48:08 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> As of [JDK-8325880](https://bugs.openjdk.org/browse/JDK-8325880), building the JDK requires version 17 of IBM Open XL C/C++ (xlc). This is in effect clang by another name, and it uses the clang toolchain in the JDK build. Thus the old xlc toolchain is no longer supported, and should be removed.
>
> Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Revert SEARCH_PATH changes

Changes requested by jkern (Author).

doc/building.html line 679:

> 677: <h3 id="ibm-open-xl-cc">IBM Open XL C/C++</h3>
> 678: <p>The minimum accepted version of Open XL is 17.1.1.4. This is in
> 679: essence clang 13, and will be treated as such by the OpenJDK build

It is clang 15 not 13. Clang 13 was in 17.1.0

doc/building.md line 493:

> 491: 
> 492: The minimum accepted version of Open XL is 17.1.1.4. This is in essence clang
> 493: 13, and will be treated as such by the OpenJDK build system.

clang 15 not 13

make/autoconf/toolchain.m4 line 285:

> 283:       XLC_TEST_PATH=${TOOLCHAIN_PATH}/
> 284:     fi
> 285:     if test "x$TOOLCHAIN_TYPE" = xclang; then

Why did you also remove the test for the clang compiler? Ah I see, you moved the clang compiler check down below

make/autoconf/toolchain.m4 line 409:

> 407:     #    Target: powerpc-ibm-aix7.2.0.0
> 408:     #    Thread model: posix
> 409:     #    InstalledDir: /opt/IBM/openxlC/17.1.0/bin

Please correct:
IBM Open XL C/C++ for AIX 17.1.**1** (xxxxxxxxxxxxxxx), clang version 1**5**.0.0
    #    Target: **powerpc-ibm-aix7.2.**5**.7**
    #    Thread model: posix
    #    InstalledDir: /opt/IBM/openxlC/17.1.**1**/bin

-------------

PR Review: https://git.openjdk.org/jdk/pull/18172#pullrequestreview-1927198641
PR Review Comment: https://git.openjdk.org/jdk/pull/18172#discussion_r1519321337
PR Review Comment: https://git.openjdk.org/jdk/pull/18172#discussion_r1519321980
PR Review Comment: https://git.openjdk.org/jdk/pull/18172#discussion_r1519358938
PR Review Comment: https://git.openjdk.org/jdk/pull/18172#discussion_r1519365934

From jkern at openjdk.org  Mon Mar 11 09:23:58 2024
From: jkern at openjdk.org (Joachim Kern)
Date: Mon, 11 Mar 2024 09:23:58 GMT
Subject: RFR: 8327701: Remove the xlc toolchain [v2]
In-Reply-To: <McIPLciH42WumSGkYLGvyyqQ-tntHyzlYa-iou8p3W8=.800e6f9e-1844-4d56-8054-80477058573f@github.com>
References: <ZNtnRt4ufmZ5Sp8zURIQwBVraTUPmM30KwL-sC37JeQ=.7135ee42-e9b1-4410-afea-b5c7384ae76e@github.com>
 <McIPLciH42WumSGkYLGvyyqQ-tntHyzlYa-iou8p3W8=.800e6f9e-1844-4d56-8054-80477058573f@github.com>
Message-ID: <U1lfAxBkklFXkNC4jPSOY9jM-uvs0vMuHH7VZgAC0AM=.4445f8df-c8c8-4363-a35e-b89c571cde03@github.com>

On Fri, 8 Mar 2024 15:31:18 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Revert SEARCH_PATH changes
>
> make/autoconf/flags-cflags.m4 line 687:
> 
>> 685:     PICFLAG="-fPIC"
>> 686:     PIEFLAG="-fPIE"
>> 687:   elif test "x$TOOLCHAIN_TYPE" = xclang && test "x$OPENJDK_TARGET_OS" = xaix; then
> 
> Just a remark: This code has never been executed, since running with clang on any OS would hit the branch above. Also, the code is syntactically incorrect, missing a trailing `"`.

OK this was a flaw in my introduction of clang toolchain for AIX. The intention was to keep the xlc options in form of their clang counterparts. I will try with a corrected version for clang on AIX and will come back to you.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18172#discussion_r1519347031

From jwaters at openjdk.org  Mon Mar 11 09:32:58 2024
From: jwaters at openjdk.org (Julian Waters)
Date: Mon, 11 Mar 2024 09:32:58 GMT
Subject: RFR: 8327701: Remove the xlc toolchain [v2]
In-Reply-To: <mehlNc-3I43oISWMHGfAHxhm1W5RKyEvGQk5ru5dwGY=.ebdd700d-4ca2-47c2-961c-b5fcea5c00ec@github.com>
References: <ZNtnRt4ufmZ5Sp8zURIQwBVraTUPmM30KwL-sC37JeQ=.7135ee42-e9b1-4410-afea-b5c7384ae76e@github.com>
 <YVdSIUybMmPFB4eNvHAxfmfEqOzrrt5l6AA9j44DlBM=.2bb3f97e-583c-4ee5-9a5a-c02454315b33@github.com>
 <mehlNc-3I43oISWMHGfAHxhm1W5RKyEvGQk5ru5dwGY=.ebdd700d-4ca2-47c2-961c-b5fcea5c00ec@github.com>
Message-ID: <Ioh-YZlIDNY5Uts86Hq24PW7qlhd4G0ztoY7Kyjqxqs=.620fb161-9f94-4bb0-acea-c6245869069e@github.com>

On Mon, 11 Mar 2024 08:38:53 GMT, Joachim Kern <jkern at openjdk.org> wrote:

>> Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Revert SEARCH_PATH changes
>
> doc/building.html line 679:
> 
>> 677: <h3 id="ibm-open-xl-cc">IBM Open XL C/C++</h3>
>> 678: <p>The minimum accepted version of Open XL is 17.1.1.4. This is in
>> 679: essence clang 13, and will be treated as such by the OpenJDK build
> 
> It is clang 15 not 13. Clang 13 was in 17.1.0

Is Open XL C/C++ considered a compiler or more akin to a development environment like Xcode is for macOS? Depending on which, we could just say clang is the compiler for AIX without needing to say that Open XL is treated like clang, etc

Also, why did this remove the link to the Supported Build Platforms page?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18172#discussion_r1519394251

From abhiscxk at openjdk.org  Mon Mar 11 09:42:53 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Mon, 11 Mar 2024 09:42:53 GMT
Subject: RFR: 8327748: Convert
 javax/swing/JFileChooser/6798062/bug6798062.java applet test to main
In-Reply-To: <lGQbwCvyqdtOr8-NxY9l3pZC4mRPn7gBtd7qPIRPF-I=.0379a965-6ad2-44ba-abfe-ecd0ed3f7b02@github.com>
References: <lGQbwCvyqdtOr8-NxY9l3pZC4mRPn7gBtd7qPIRPF-I=.0379a965-6ad2-44ba-abfe-ecd0ed3f7b02@github.com>
Message-ID: <kFQxoht4JtXZS13lZycPTvF80pcnC5IwL7bApI_OUGg=.689a325e-b4a5-4658-87cf-fd9e6e61437c@github.com>

On Mon, 11 Mar 2024 06:22:22 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> Conversion of manual applet test to main based using PassFailJFrame manual framework

test/jdk/javax/swing/JFileChooser/6798062/bug6798062.java line 56:

> 54: public class bug6798062 {
> 55: 
> 56:     private static final String instructionsText = """

`instructionsText` may be capitalize as using capital letter is common convention for final variables.

test/jdk/javax/swing/JFileChooser/6798062/bug6798062.java line 65:

> 63:             5. Wait several minutes and observe in the Windows Task Manager
> 64:                that Memory Usage of java process is not increasing
> 65:             If menory usage is increasing, click Fail else click Pass .  """;

Suggestion:

            If memory usage is increasing, click Fail else click Pass .  """;

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18180#discussion_r1519408952
PR Review Comment: https://git.openjdk.org/jdk/pull/18180#discussion_r1519409622

From kizune at openjdk.org  Mon Mar 11 09:46:34 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Mon, 11 Mar 2024 09:46:34 GMT
Subject: RFR: 8316388: Opensource five Swing component related regression tests
Message-ID: <bk66ojURFnGqahRv9IYAhgumqNGFFMOfRkMUzjkIAqI=.9a8c6550-f6d1-4ee2-b53b-54dc6491ff0e@github.com>

Clean up five more tests.

test/jdk/javax/swing/JDesktopPane/4132993/bug4132993.java
test/jdk/javax/swing/JDesktopPane/4773378/bug4773378.java
test/jdk/javax/swing/JEditorPane/4325606/bug4325606.java
test/jdk/javax/swing/JEditorPane/4330998/bug4330998.java
test/jdk/javax/swing/JEditorPane/4694598/FrameContent.html
test/jdk/javax/swing/JEditorPane/4694598/bug4694598.java

-------------

Commit messages:
 - 8316388: Opensource five Swing component related regression tests

Changes: https://git.openjdk.org/jdk/pull/18184/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18184&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8316388
  Stats: 454 lines in 6 files changed: 454 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18184.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18184/head:pull/18184

PR: https://git.openjdk.org/jdk/pull/18184

From psadhukhan at openjdk.org  Mon Mar 11 09:53:17 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Mon, 11 Mar 2024 09:53:17 GMT
Subject: RFR: 8327748: Convert
 javax/swing/JFileChooser/6798062/bug6798062.java applet test to main [v2]
In-Reply-To: <lGQbwCvyqdtOr8-NxY9l3pZC4mRPn7gBtd7qPIRPF-I=.0379a965-6ad2-44ba-abfe-ecd0ed3f7b02@github.com>
References: <lGQbwCvyqdtOr8-NxY9l3pZC4mRPn7gBtd7qPIRPF-I=.0379a965-6ad2-44ba-abfe-ecd0ed3f7b02@github.com>
Message-ID: <WbNziLuyDum0qdGJnLB5bDVKUbYaU5E3OT9IqYQOIpo=.e1bc048b-4fe8-4ea7-979a-1e6481788c47@github.com>

> Conversion of manual applet test to main based using PassFailJFrame manual framework

Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:

  typo

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18180/files
  - new: https://git.openjdk.org/jdk/pull/18180/files/0164adc0..0c8ae3a0

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18180&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18180&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/18180.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18180/head:pull/18180

PR: https://git.openjdk.org/jdk/pull/18180

From psadhukhan at openjdk.org  Mon Mar 11 09:53:18 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Mon, 11 Mar 2024 09:53:18 GMT
Subject: RFR: 8327748: Convert
 javax/swing/JFileChooser/6798062/bug6798062.java applet test to main [v2]
In-Reply-To: <kFQxoht4JtXZS13lZycPTvF80pcnC5IwL7bApI_OUGg=.689a325e-b4a5-4658-87cf-fd9e6e61437c@github.com>
References: <lGQbwCvyqdtOr8-NxY9l3pZC4mRPn7gBtd7qPIRPF-I=.0379a965-6ad2-44ba-abfe-ecd0ed3f7b02@github.com>
 <kFQxoht4JtXZS13lZycPTvF80pcnC5IwL7bApI_OUGg=.689a325e-b4a5-4658-87cf-fd9e6e61437c@github.com>
Message-ID: <ywgrsZPpGZlnkxsV0AD7i3cl1foFOTKu5OQGwsufHxw=.7ec5db6f-2403-4a9a-be49-8870ed5910ee@github.com>

On Mon, 11 Mar 2024 09:38:49 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   typo
>
> test/jdk/javax/swing/JFileChooser/6798062/bug6798062.java line 56:
> 
>> 54: public class bug6798062 {
>> 55: 
>> 56:     private static final String instructionsText = """
> 
> `instructionsText` may be capitalize as using capital letter is common convention for final variables.

That is for constant, IIRC...

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18180#discussion_r1519426787

From psadhukhan at openjdk.org  Mon Mar 11 10:07:02 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Mon, 11 Mar 2024 10:07:02 GMT
Subject: RFR: 8327751: Convert
 javax/swing/JInternalFrame/6726866/bug6726866.java applet test to main
Message-ID: <C5clTEn-okNdD5RVu8jcJW8T9bluj4GTy7BDNxUwKy0=.6b278225-50fa-4714-a066-8ad465cd9766@github.com>

Conversion of manual applet test to main based using PassFailJFrame manual framework

-------------

Commit messages:
 - 8327751: Convert javax/swing/JInternalFrame/6726866/bug6726866.java applet test to main

Changes: https://git.openjdk.org/jdk/pull/18186/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18186&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8327751
  Stats: 70 lines in 2 files changed: 18 ins; 30 del; 22 mod
  Patch: https://git.openjdk.org/jdk/pull/18186.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18186/head:pull/18186

PR: https://git.openjdk.org/jdk/pull/18186

From aivanov at openjdk.org  Mon Mar 11 10:56:53 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Mon, 11 Mar 2024 10:56:53 GMT
Subject: RFR: 8326661: sun/java2d/cmm/ColorConvertOp/ColConvTest.java
 assumes profiles were generated by LCMS [v2]
In-Reply-To: <FLf1tladgJ4PCOzVIcNUHaXrbSezgSfiZVtFkwfDCoo=.75437269-3d71-45c4-9372-5c0566ae2312@github.com>
References: <nFplnFr0UPf-gWrZjoyZhb2pCJ_fjUEieIxTlWesSNs=.7f372d25-5bc5-4fb2-9ecd-8d5e40cc69b8@github.com>
 <FLf1tladgJ4PCOzVIcNUHaXrbSezgSfiZVtFkwfDCoo=.75437269-3d71-45c4-9372-5c0566ae2312@github.com>
Message-ID: <a8UUZCf79hrCGdi2h5L2O6bS0MemaMRIIub3XPbq2DY=.d893178e-50ef-4e1a-b3dd-bd0383edc4a1@github.com>

On Thu, 7 Mar 2024 12:36:05 GMT, Dmitry Markov <dmarkov at openjdk.org> wrote:

>> Updated several tests to avoid potential failure with recent LCMS update and non-LCMS generated profile.
>
> Dmitry Markov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Tolerance update

Marked as reviewed by aivanov (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18097#pullrequestreview-1927516502

From aivanov at openjdk.org  Mon Mar 11 11:02:54 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Mon, 11 Mar 2024 11:02:54 GMT
Subject: RFR: 8326661: sun/java2d/cmm/ColorConvertOp/ColConvTest.java
 assumes profiles were generated by LCMS [v2]
In-Reply-To: <FLf1tladgJ4PCOzVIcNUHaXrbSezgSfiZVtFkwfDCoo=.75437269-3d71-45c4-9372-5c0566ae2312@github.com>
References: <nFplnFr0UPf-gWrZjoyZhb2pCJ_fjUEieIxTlWesSNs=.7f372d25-5bc5-4fb2-9ecd-8d5e40cc69b8@github.com>
 <FLf1tladgJ4PCOzVIcNUHaXrbSezgSfiZVtFkwfDCoo=.75437269-3d71-45c4-9372-5c0566ae2312@github.com>
Message-ID: <RELRvqJ8mvlTRQj7v9KF6zFqN4Xr1lE9-WqqCC9oVJQ=.4189fd3f-f986-4b3e-a259-0454bd50edc8@github.com>

On Thu, 7 Mar 2024 12:36:05 GMT, Dmitry Markov <dmarkov at openjdk.org> wrote:

>> Updated several tests to avoid potential failure with recent LCMS update and non-LCMS generated profile.
>
> Dmitry Markov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Tolerance update

It's not mentioned here, however, I think it's relevant to the discussion: the updated tests pass when the non-LCMS profiles from Java 8 are used.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18097#issuecomment-1988171424

From aivanov at openjdk.org  Mon Mar 11 11:04:53 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Mon, 11 Mar 2024 11:04:53 GMT
Subject: RFR: 8326606: Test
 javax/swing/text/BoxView/6494356/bug6494356.java performs a synchronization on
 a value based class [v2]
In-Reply-To: <8LtJgsYdLRa_NuP3AZlv4u7nJFeliOfvGZNNJUzdI38=.a999646d-91da-499d-a1b5-57a098a42a88@github.com>
References: <8VnEO3HS6wKX45a3tokydw_aTorFic1acaSiIqm4-7A=.58457c31-1969-47d9-9c1e-365bba1b7174@github.com>
 <8LtJgsYdLRa_NuP3AZlv4u7nJFeliOfvGZNNJUzdI38=.a999646d-91da-499d-a1b5-57a098a42a88@github.com>
Message-ID: <5K5mTzzC870xXM4pX5gkk72-vZviS_VkJVmyyI6IPxw=.6e8d29e6-fa53-4fae-9b48-94831a79d44a@github.com>

On Fri, 8 Mar 2024 11:34:12 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> OPensource BoxView test
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review comment update

Marked as reviewed by aivanov (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18147#pullrequestreview-1927533498

From aivanov at openjdk.org  Mon Mar 11 11:08:59 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Mon, 11 Mar 2024 11:08:59 GMT
Subject: RFR: 8327492: Remove applet usage and update
 DisposeInActionEventTest.html [v15]
In-Reply-To: <tA0UFwrVnaMiltnNGunWRJjAoK-09pWb6K_o4l1418U=.b0ade2ca-ad5f-4dfb-bf46-5a79dacaffe3@github.com>
References: <wbQWXZ3sLQB90OPGZTWuifQuxdk7bFfiouu2NzUEzHQ=.310c2f89-b621-4f34-a949-1f319bcac8ce@github.com>
 <tA0UFwrVnaMiltnNGunWRJjAoK-09pWb6K_o4l1418U=.b0ade2ca-ad5f-4dfb-bf46-5a79dacaffe3@github.com>
Message-ID: <CqKNaO5p75CAZiUqNSAwr7gXP7nseaTKRhniIIMSn6A=.fb0871d5-67fc-49f0-bc5d-c8632805eeb5@github.com>

On Sat, 9 Mar 2024 00:54:05 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> Root cause of the test failure was fixed with https://bugs.openjdk.org/browse/JDK-8316931, updating this test since the other fix also included a test update.
>
> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   update test instructions, fix spacing

test/jdk/java/awt/TrayIcon/DisposeInActionEventTest/DisposeInActionEventTest.java line 70:

> 68:                        "The test checks if any exceptions are thrown when removing and\n" +
> 69:                        "  re-adding the icon. If something is wrong, the test will automatically fail.\n" +
> 70:                        "  Repeat clicks several times Then press PASS button.";

You've lost the full stop after _?times?_. It's not worth a new PR.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17838#discussion_r1519541474

From tr at openjdk.org  Mon Mar 11 11:15:01 2024
From: tr at openjdk.org (Tejesh R)
Date: Mon, 11 Mar 2024 11:15:01 GMT
Subject: RFR: 8327787: Convert javax/swing/border/Test4129681.java applet test
 to main
Message-ID: <uZ3hGgyIWuMOTp6qSVNw_3r-F4REh4QvrzqAtH8fMo8=.e55e311d-c0d7-4863-9e8a-0d1edc1d8857@github.com>

Convert javax/swing/border/Test4129681.java applet test to main based test using PassFailJFrame.

-------------

Commit messages:
 - Conversion from Applet to Main

Changes: https://git.openjdk.org/jdk/pull/18189/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18189&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8327787
  Stats: 94 lines in 2 files changed: 37 ins; 44 del; 13 mod
  Patch: https://git.openjdk.org/jdk/pull/18189.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18189/head:pull/18189

PR: https://git.openjdk.org/jdk/pull/18189

From aturbanov at openjdk.org  Mon Mar 11 11:55:56 2024
From: aturbanov at openjdk.org (Andrey Turbanov)
Date: Mon, 11 Mar 2024 11:55:56 GMT
Subject: RFR: 8316388: Opensource five Swing component related regression
 tests
In-Reply-To: <bk66ojURFnGqahRv9IYAhgumqNGFFMOfRkMUzjkIAqI=.9a8c6550-f6d1-4ee2-b53b-54dc6491ff0e@github.com>
References: <bk66ojURFnGqahRv9IYAhgumqNGFFMOfRkMUzjkIAqI=.9a8c6550-f6d1-4ee2-b53b-54dc6491ff0e@github.com>
Message-ID: <Yrz59WLXRE_r_BsSsgsZp6MZPkEkUXLPND--QOkiX_o=.b1273754-3066-4e2b-8c50-34efbcb61377@github.com>

On Mon, 11 Mar 2024 09:41:47 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

> Clean up five more tests.
> 
> test/jdk/javax/swing/JDesktopPane/4132993/bug4132993.java
> test/jdk/javax/swing/JDesktopPane/4773378/bug4773378.java
> test/jdk/javax/swing/JEditorPane/4325606/bug4325606.java
> test/jdk/javax/swing/JEditorPane/4330998/bug4330998.java
> test/jdk/javax/swing/JEditorPane/4694598/FrameContent.html
> test/jdk/javax/swing/JEditorPane/4694598/bug4694598.java

test/jdk/javax/swing/JDesktopPane/4773378/bug4773378.java line 51:

> 49: 
> 50:     Robot robot;
> 51:     volatile boolean  keyTyped = false;

Suggestion:

    volatile boolean keyTyped = false;

test/jdk/javax/swing/JEditorPane/4325606/bug4325606.java line 83:

> 81:             robo.setAutoDelay(100);
> 82:             robo.delay(1000);
> 83:             robo.mouseMove(100,100);

Suggestion:

            robo.mouseMove(100, 100);

test/jdk/javax/swing/JEditorPane/4330998/bug4330998.java line 33:

> 31: 
> 32: public class bug4330998 {
> 33:     public static void main(String[] args)  {

Suggestion:

    public static void main(String[] args) {

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18184#discussion_r1519594212
PR Review Comment: https://git.openjdk.org/jdk/pull/18184#discussion_r1519594515
PR Review Comment: https://git.openjdk.org/jdk/pull/18184#discussion_r1519594745

From jkern at openjdk.org  Mon Mar 11 12:29:55 2024
From: jkern at openjdk.org (Joachim Kern)
Date: Mon, 11 Mar 2024 12:29:55 GMT
Subject: RFR: 8327701: Remove the xlc toolchain [v2]
In-Reply-To: <YVdSIUybMmPFB4eNvHAxfmfEqOzrrt5l6AA9j44DlBM=.2bb3f97e-583c-4ee5-9a5a-c02454315b33@github.com>
References: <ZNtnRt4ufmZ5Sp8zURIQwBVraTUPmM30KwL-sC37JeQ=.7135ee42-e9b1-4410-afea-b5c7384ae76e@github.com>
 <YVdSIUybMmPFB4eNvHAxfmfEqOzrrt5l6AA9j44DlBM=.2bb3f97e-583c-4ee5-9a5a-c02454315b33@github.com>
Message-ID: <0yRLC1SM9um8MIZYJP6sf8OOMeOCbzCc1LF_JQLxZHg=.e3391f4e-ab9e-423c-880c-e84aba29e87b@github.com>

On Fri, 8 Mar 2024 15:48:08 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> As of [JDK-8325880](https://bugs.openjdk.org/browse/JDK-8325880), building the JDK requires version 17 of IBM Open XL C/C++ (xlc). This is in effect clang by another name, and it uses the clang toolchain in the JDK build. Thus the old xlc toolchain is no longer supported, and should be removed.
>
> Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Revert SEARCH_PATH changes

make/autoconf/toolchain.m4 line 940:

> 938:   if test "x$OPENJDK_TARGET_OS" = xaix; then
> 939:     # Make sure we have the Open XL version of clang on AIX
> 940:     $ECHO "$CC_VERSION_OUTPUT" | $GREP "IBM Open XL C/C++ for AIX" > /dev/null

This does not work since $CC_VERSION_OUTPUT is unset. We need 
	CC_VERSION_OUTPUT=`${XLC_TEST_PATH}ibm-clang++_r --version 2>&1 | $HEAD -n 1`
before, as in the previous code some lines above which you removed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18172#discussion_r1519634810

From mbaesken at openjdk.org  Mon Mar 11 12:47:57 2024
From: mbaesken at openjdk.org (Matthias Baesken)
Date: Mon, 11 Mar 2024 12:47:57 GMT
Subject: RFR: 8327701: Remove the xlc toolchain [v2]
In-Reply-To: <YVdSIUybMmPFB4eNvHAxfmfEqOzrrt5l6AA9j44DlBM=.2bb3f97e-583c-4ee5-9a5a-c02454315b33@github.com>
References: <ZNtnRt4ufmZ5Sp8zURIQwBVraTUPmM30KwL-sC37JeQ=.7135ee42-e9b1-4410-afea-b5c7384ae76e@github.com>
 <YVdSIUybMmPFB4eNvHAxfmfEqOzrrt5l6AA9j44DlBM=.2bb3f97e-583c-4ee5-9a5a-c02454315b33@github.com>
Message-ID: <guGW7d1XFNl7TE84CKTrkWngW5mNZ8dEhgiUaUphTcQ=.447ec868-160f-4f96-9dc3-16e955e1c8d7@github.com>

On Fri, 8 Mar 2024 15:48:08 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> As of [JDK-8325880](https://bugs.openjdk.org/browse/JDK-8325880), building the JDK requires version 17 of IBM Open XL C/C++ (xlc). This is in effect clang by another name, and it uses the clang toolchain in the JDK build. Thus the old xlc toolchain is no longer supported, and should be removed.
>
> Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Revert SEARCH_PATH changes

With this change added, currently  configure fails 


checking for ibm-llvm-cxxfilt... /opt/IBM/openxlC/17.1.1/tools/ibm-llvm-cxxfilt
configure: error: ibm-clang_r version output check failed, output: 
configure exiting with result code 

maybe  related to what Joachim pointed out ?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18172#issuecomment-1988358518

From aivanov at openjdk.org  Mon Mar 11 13:37:57 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Mon, 11 Mar 2024 13:37:57 GMT
Subject: RFR: 8075917: The regression-swing case failed as the text on
 label is not painted red with the GTK L&F [v5]
In-Reply-To: <5eZ7a0HiqE3hghw3sT0L0Zn4Mi1FFfofz6hLGdLOsoc=.445b16ac-4d91-4538-92ba-a74f17781535@github.com>
References: <iDOTnLkAimOa5kfDerZ09n4wsYiFYYUyBflOTYeUQZ0=.293390bd-bc47-4871-bf4c-d23c191d9426@github.com>
 <5eZ7a0HiqE3hghw3sT0L0Zn4Mi1FFfofz6hLGdLOsoc=.445b16ac-4d91-4538-92ba-a74f17781535@github.com>
Message-ID: <c4jjcBPHlQ79cCbPxo8-EjjuWUzF3hjObagnARJe23s=.a897d7cb-8150-4871-bea6-6211ce88983e@github.com>

On Tue, 5 Mar 2024 05:28:01 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> JLabel text is not painted with the LAF defined foreground color in GTK LAF. In GTK LAF the foreground color is retrieved by using native system APIs. Fix is to return the foreground color if it is set by LAF defined property otherwise return the default color by calling native APIs.
>> Applet based test has been converted to automatic test and check for all installed LAFs. CI testing is green for test suite and individual test. Link attached in JBS.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   separate method to get LAF defined color

src/java.desktop/share/classes/com/sun/java/swing/plaf/gtk/GTKStyle.java line 186:

> 184: 
> 185:         if (id == Region.LABEL && type == ColorType.FOREGROUND
> 186:                 && (state & SynthConstants.ENABLED) != 0) {

Doesn't `SynthConstants.DISABLED` need the same treatment?

test/jdk/javax/swing/plaf/basic/BasicHTML/bug4248210.java line 111:

> 109: 
> 110:     private static boolean chkImgForegroundColor(BufferedImage img) {
> 111:         Color red = new Color(255, 0, 0);

I believe you should be using `labelColor` here. If anyone changes its value from `Color.RED` to anything else, the test will fail but it shouldn't. After all, why allowing configuring the colour in first place.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17763#discussion_r1519714194
PR Review Comment: https://git.openjdk.org/jdk/pull/17763#discussion_r1519712200

From aivanov at openjdk.org  Mon Mar 11 13:37:58 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Mon, 11 Mar 2024 13:37:58 GMT
Subject: RFR: 8075917: The regression-swing case failed as the text on
 label is not painted red with the GTK L&F [v5]
In-Reply-To: <W4XgJDzMm6nQOFMOjxvsHh61ScOOtwyxqWodk44vcp8=.4e0a0699-ffe0-4fe6-a8f6-49d465f44882@github.com>
References: <iDOTnLkAimOa5kfDerZ09n4wsYiFYYUyBflOTYeUQZ0=.293390bd-bc47-4871-bf4c-d23c191d9426@github.com>
 <5eZ7a0HiqE3hghw3sT0L0Zn4Mi1FFfofz6hLGdLOsoc=.445b16ac-4d91-4538-92ba-a74f17781535@github.com>
 <dPwYzsPLI8z4TUTMlwXFEKmddbkkjpifAqrM4b2XxeE=.ec943a1a-09b4-48ec-8ad1-bd64b936e2b2@github.com>
 <yQTL_So5Ud-76evgwEePTvcDSxYXVy0kwN6j_mQwrc0=.12bb609a-b841-480c-9e35-4297f0de6c48@github.com>
 <vAIQHEffW4Eq54K_v5vYvLpyfEXzwG74D8wy5-syJxM=.05d14f36-f4a5-491a-b9a7-f7be14201b0c@github.com>
 <9LaK7sRChE5CkU7okuhRSRhRGRFRfjlYrb7dvpE_oFo=.ac9b318d-c3c1-4df5-a880-2baffe8ef502@github.com>
 <usrU7DN7mu9Dp569LTabmhgWBJXCpjxbzSKKk1x_aOI=.cbacbc4a-0f4f-421e-ba64-3a40d4f50e2d@github.com>
 <W4XgJDzMm6nQOFMOjxvsHh61ScOOtwyxqWodk44vcp8=.4e0a0699-ffe0-4fe6-a8f6-49d465f44882@github.com>
Message-ID: <yCn_Vvyh-JuSt0u6aBRA0Ct6zKeMeQNZwQbJqXRMH90=.7ee430f9-3692-4e91-806c-8fc9ebef673d@github.com>

On Thu, 7 Mar 2024 12:42:05 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>>> Backtracking a bit, regarding `Label.foreground` why it needs to be done here?
>>> 
>>> Other L&F, it is added in corresponding LookAndFeel class for example, in [Metal](https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/javax/swing/plaf/metal/MetalLookAndFeel.java#L1001) and in [Windows](https://github.com/openjdk/jdk/blob/master/src/java.desktop/windows/classes/com/sun/java/swing/plaf/windows/WindowsLookAndFeel.java#L880) etc so I think it is needed to be added in GTKLookAndFeel class
>> 
>> IN GTKLookAndFeel, the color is returned specific to the style and state from native side . So, even if it is not added the default color for enabled, disabled or any other state is returned by native. Whereas In Metal the color is set by using UIManager define color.
>> 
>>> and additionally there is setting of Label.foreground and other Label. property in BasicLabelUI.java [installDefaults](https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/javax/swing/plaf/basic/BasicLabelUI.java#L368)
>> but we dont do it for Nimbus or GTK or Synth so I guess we need to call super.installDefaults(c) in SynthLabelUI class since there is no GTKLabelUI class
>> or
>> maybe do
>> LookAndFeel.installColorsAndFont(c, "Label.background", "Label.foreground", "Label.font"); alone to avoid other properties being set and to not fallback
>> 
>> This properties are set via SynthStyle [installDefaults](https://github.com/kumarabhi006/jdk/blob/master/src/java.desktop/share/classes/javax/swing/plaf/synth/SynthStyle.java#L928) method where the foreground, background are set by getting the value from `getColorForState` method. So, calling super.installDefaults(c) in SynthLabelUI will not make any difference.
>> 
>> I checked for JLabel properties set in enabled and disabled state. 
>> 
>> 
>> In Nimbus LAF
>>             UIManager.getDefaults().put("Label[Enabled].textForeground", labelColor);
>>             UIManager.getDefaults().put("Label[Disabled].textForeground", labelDisabledColor);
>> 
>> Other LAF
>>             UIManager.getDefaults().put("Label.foreground", labelColor);
>>             UIManager.getDefaults().put("Label.disabledForeground", labelDisabledColor);
>> 
>> 
>> It works as expected for Metal and GTK. For Nimbus LAF, disabled color is not painted correctly. In stead the default color specified in skin.laf is rendered.
>
>> It works as expected for Metal and GTK. For Nimbus LAF, disabled color is not painted correctly. In stead the default color specified in skin.laf is rendered.
> 
> For HTML text, disabled state doesn't render in LAF defined color for Metal and GTK as well.

This looks weird? So you're saying `Label[Enabled].textForeground` and `Label[Disabled].textForeground` are used for Nimbus (and Synth and GTK) instead of `Label.foreground` and `Label.disabledForeground` which are used for other L&Fs.

Shouldn't we fix the problem by correcting the keys instead? It looks like it's what you're doing for specific components.

Is it specified anywhere that Synth-based L&Fs use different constants? It results in incorrect colors.

If a developer sets the common properties, should they override Look-and-Feel defaults?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17763#discussion_r1519696320

From aivanov at openjdk.org  Mon Mar 11 13:46:56 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Mon, 11 Mar 2024 13:46:56 GMT
Subject: RFR: 8327787: Convert javax/swing/border/Test4129681.java applet
 test to main
In-Reply-To: <uZ3hGgyIWuMOTp6qSVNw_3r-F4REh4QvrzqAtH8fMo8=.e55e311d-c0d7-4863-9e8a-0d1edc1d8857@github.com>
References: <uZ3hGgyIWuMOTp6qSVNw_3r-F4REh4QvrzqAtH8fMo8=.e55e311d-c0d7-4863-9e8a-0d1edc1d8857@github.com>
Message-ID: <f0Ho3Eqi3egqVq2Kx4SzKvOR1Jk33ete-t-_PVyO1TA=.47592344-a5ff-42c5-bae2-85386f1cd599@github.com>

On Mon, 11 Mar 2024 11:10:14 GMT, Tejesh R <tr at openjdk.org> wrote:

> Convert javax/swing/border/Test4129681.java applet test to main based test using PassFailJFrame.

Changes requested by aivanov (Reviewer).

test/jdk/javax/swing/border/Test4129681.java line 48:

> 46:         String testInstructions = """
> 47:                 When applet starts, you'll see a checkbox
> 48:                 and a label with a titled border.

Update the instructions not to refer to applet.

test/jdk/javax/swing/border/Test4129681.java line 54:

> 52:                 """;
> 53:         PassFailJFrame passFailJFrame = new PassFailJFrame.Builder()
> 54:                 .title("JInternalFrame Instructions")

Is this test related to `JInternalFrame`? It doesn't look so.

test/jdk/javax/swing/border/Test4129681.java line 56:

> 54:                 .title("JInternalFrame Instructions")
> 55:                 .instructions(testInstructions)
> 56:                 .testTimeOut(5)

The default timeout could be left out.

test/jdk/javax/swing/border/Test4129681.java line 67:

> 65:     }
> 66: 
> 67:     public static void init() {

I propose using `testUI` method of the builder, it hides the complexity of registering and positioning the frame. Modify this method to return the created `frame`.

See PR #17838 as an example or other PRs. The javadoc for `PassFailJFrame` also contains the recommended usage.

-------------

PR Review: https://git.openjdk.org/jdk/pull/18189#pullrequestreview-1927850517
PR Review Comment: https://git.openjdk.org/jdk/pull/18189#discussion_r1519732701
PR Review Comment: https://git.openjdk.org/jdk/pull/18189#discussion_r1519733729
PR Review Comment: https://git.openjdk.org/jdk/pull/18189#discussion_r1519734220
PR Review Comment: https://git.openjdk.org/jdk/pull/18189#discussion_r1519743444

From jkern at openjdk.org  Mon Mar 11 13:48:56 2024
From: jkern at openjdk.org (Joachim Kern)
Date: Mon, 11 Mar 2024 13:48:56 GMT
Subject: RFR: 8327701: Remove the xlc toolchain [v2]
In-Reply-To: <YVdSIUybMmPFB4eNvHAxfmfEqOzrrt5l6AA9j44DlBM=.2bb3f97e-583c-4ee5-9a5a-c02454315b33@github.com>
References: <ZNtnRt4ufmZ5Sp8zURIQwBVraTUPmM30KwL-sC37JeQ=.7135ee42-e9b1-4410-afea-b5c7384ae76e@github.com>
 <YVdSIUybMmPFB4eNvHAxfmfEqOzrrt5l6AA9j44DlBM=.2bb3f97e-583c-4ee5-9a5a-c02454315b33@github.com>
Message-ID: <dvyvE8Ej0mpD9vagOGNtC8Sq9xO_-YJNpXOBkk8tFSA=.bbce5b92-ec7a-47ea-850a-eb23aa281945@github.com>

On Fri, 8 Mar 2024 15:48:08 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> As of [JDK-8325880](https://bugs.openjdk.org/browse/JDK-8325880), building the JDK requires version 17 of IBM Open XL C/C++ (xlc). This is in effect clang by another name, and it uses the clang toolchain in the JDK build. Thus the old xlc toolchain is no longer supported, and should be removed.
>
> Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Revert SEARCH_PATH changes

Changes requested by jkern (Author).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18172#pullrequestreview-1927875301

From jkern at openjdk.org  Mon Mar 11 13:48:56 2024
From: jkern at openjdk.org (Joachim Kern)
Date: Mon, 11 Mar 2024 13:48:56 GMT
Subject: RFR: 8327701: Remove the xlc toolchain [v2]
In-Reply-To: <U1lfAxBkklFXkNC4jPSOY9jM-uvs0vMuHH7VZgAC0AM=.4445f8df-c8c8-4363-a35e-b89c571cde03@github.com>
References: <ZNtnRt4ufmZ5Sp8zURIQwBVraTUPmM30KwL-sC37JeQ=.7135ee42-e9b1-4410-afea-b5c7384ae76e@github.com>
 <McIPLciH42WumSGkYLGvyyqQ-tntHyzlYa-iou8p3W8=.800e6f9e-1844-4d56-8054-80477058573f@github.com>
 <U1lfAxBkklFXkNC4jPSOY9jM-uvs0vMuHH7VZgAC0AM=.4445f8df-c8c8-4363-a35e-b89c571cde03@github.com>
Message-ID: <ym4JkRJQUoM3hQXlhx1Uwrqs0MFrKSA8TDz0ggKFMbc=.fc3722a0-a1ae-4d97-b619-56ea98402c0c@github.com>

On Mon, 11 Mar 2024 08:59:03 GMT, Joachim Kern <jkern at openjdk.org> wrote:

>> make/autoconf/flags-cflags.m4 line 687:
>> 
>>> 685:     PICFLAG="-fPIC"
>>> 686:     PIEFLAG="-fPIE"
>>> 687:   elif test "x$TOOLCHAIN_TYPE" = xclang && test "x$OPENJDK_TARGET_OS" = xaix; then
>> 
>> Just a remark: This code has never been executed, since running with clang on any OS would hit the branch above. Also, the code is syntactically incorrect, missing a trailing `"`.
>
> OK this was a flaw in my introduction of clang toolchain for AIX. The intention was to keep the xlc options in form of their clang counterparts. I will try with a corrected version for clang on AIX and will come back to you.

OK, the `-Wl,-bbigtoc` is not a compiler option but a linker option and it is already set in the linker options.
But the `-fpic -mcmodel=large` should be set to avoid creating a jump to out-of-order code.

So we can replace the

  JVM_PICFLAG="$PICFLAG"
  JDK_PICFLAG="$PICFLAG"


code some lines below by


  if test "x$TOOLCHAIN_TYPE" = xclang && test "x$OPENJDK_TARGET_OS" = xaix; then
    JVM_PICFLAG="-fpic -mcmodel=large"
  else
    JVM_PICFLAG="$PICFLAG"
  fi
  JDK_PICFLAG="$PICFLAG"

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18172#discussion_r1519747481

From alexsch at openjdk.org  Mon Mar 11 13:58:22 2024
From: alexsch at openjdk.org (Alexander Scherbatiy)
Date: Mon, 11 Mar 2024 13:58:22 GMT
Subject: RFR: 8315113: Print request Chromaticity.MONOCHROME attribute does not
 work on macOS
Message-ID: <m_OJNAf9YmC4OJMwtCM5P-eklmNJUymWJjMfo5s_wpI=.7d1c5a1f-2158-49f2-906d-dc074019cb99@github.com>

The fix provides ability to print Black & White pages on macOS.

Cocoa API has [PMSetColorMode](https://developer.apple.com/documentation/applicationservices/core_printing/1805783-pmsetcolormode) function but it is marked as deprecated and really does nothing.

There is no replacement; this function was included to facilitate porting legacy applications to macOS, 
but it serves no useful purpose.

Dumping `NSPrintInfo` print settings which were set by the native print dialog on macOS shows that the keys and values used for Black & White printing depend on the used printer type.
For example, the tested 
`HP Color LaserJet MFP M180n` printer uses `ColorModel` key and`Gray` value, and
`HP Ink Tank 110 series` uses `HPColorMode` key and `grayscale` value.

Printing all `NSPrintInfo` presets shows that they do not contain key/value pairs  for Black&White settings.
This is the code snippet used to print `NSPrintInfo` presets:

    PMPrinter pr;
    PMPrintSession printSession = (PMPrintSession)[printInfo PMPrintSession];
    OSStatus status = PMSessionGetCurrentPrinter(printSession, &pr);
    CFArrayRef presetsList = nil;
    status = PMPrinterCopyPresets(pr, &presetsList);
    CFIndex arrayCount = CFArrayGetCount(presetsList);

    for (CFIndex index = 0; index < arrayCount; index++) {
        PMPreset preset = (PMPreset)CFArrayGetValueAtIndex(presetsList, index);
        CFStringRef presetName = nil;
        if (PMPresetCopyName(preset, &presetName) == noErr && CFStringGetLength(presetName) > 0) {
            NSLog(@"  presetName: '%@'", presetName);
            NSDictionary* dict = nil;
            if (PMPresetGetAttributes(preset, (CFDictionaryRef*)(&dict)) == noErr) {
                   // print preset dict


The idea of the proposed fix is to store printer dependent key/value pairs in the `<jdk-home>/conf/printer.properties` property file.

The property file has the format:

print-attribute.print-attribute-value.key=value

where `print-attribute` is the java print attribute, `print-attribute-value` is the corresponding attribute value, and `key` and `value` is the key/value pair used by a specific printer.

For example, for `Chromaticity` attribute the property file could look like:

Chromaticity.MONOCHROME.ColorModel=Gray
Chromaticity.COLOR.ColorModel=CMYK
Chromaticity.MONOCHROME.HPColorMode=grayscale
Chromaticity.COLOR.HPColorMode=color

where `Chromaticity.MONOCHROME` key prefix corresponds to `Chromaticity.MONOCHOROME` print attribute constant  with  (`ColorModel`, `Gray`) and (`HPColorMode`, `grayscale`) key/value pairs.
Similarly `Chromaticity.COLOR` key prefix with  (`ColorModel`, `CMYK`) and (`HPColorMode`, `color`) key/value pairs correspond to `Chromaticity.COLOR` print attribute.

https://www.openprinting.org/download/PPD/ site has been used to collect `monochrome` and `color` constants from ppd files and save them in `<jdk-home>/conf/printer.properties` file.

For example, for the Brother printer the https://www.openprinting.org/download/PPD/Brother/BR9440_2_GPL.ppd ppd file defines `BRPrintQuality` option:

*OpenUI *BRPrintQuality/Color/Mono: PickOne
*OrderDependency: 15 AnySetup *BRPrintQuality
*DefaultBRPrintQuality: Auto
*BRPrintQuality Auto/Auto: "
        <</BRProcessColor 4 /BRHrc 0>>setpagedevice
        <</BRColorAdapt true>>setpagedevice
        <</BRRenderMode false>>setpagedevice"
*BRPrintQuality Color/Color: "
        <</BRProcessColor 4 /BRHrc 0>>setpagedevice
        <</BRColorAdapt false>>setpagedevice
        <</BRRenderMode false>>setpagedevice"
*BRPrintQuality Black/Mono: "
        <</BRProcessColor 1>>setpagedevice
        <</BRColorAdapt false>>setpagedevice
        <</BRRenderMode true>>setpagedevice"
...
*CloseUI: *BRPrintQuality


which is listed in the `printer.properties` file as:

Chromaticity.MONOCHROME.BRPrintQuality=Black
Chromaticity.COLOR.BRPrintQuality=Color


and for the Epson printer the https://www.openprinting.org/download/PPD/Epson/epal2600.ppd ppd file defines `EPRendering` option:

*OpenUI *EPRendering/Color Mode: PickOne
*% EPRendering must be after EPColorModel
*OrderDependency: 50 AnySetup *EPRendering
*DefaultEPRendering: None
*EPRendering None/Mono: "
        <</ProcessColorModel (DeviceGray)
        /DeviceRenderingInfo <</Type 29 /ValuesPerColorComponent 256>> >>
        setpagedevice"
*End
*% ProcessColorModel is already set in EPColorModel
*EPRendering RGB/Color: "
        << /ProcessColorModel (DeviceRGB) >> setpagedevice
        <</DeviceRenderingInfo <</Type 29 /ValuesPerColorComponent 256>> >>
        setpagedevice"
...
*CloseUI: *EPRendering


which is listed in the `printer.properties` file as:

Chromaticity.MONOCHROME.EPRendering=None
Chromaticity.COLOR.EPRendering=RGB


The full list of constants from https://www.openprinting.org/download/PPD/ used in `printer.properties` is

# Brother
Chromaticity.MONOCHROME.BRPrintQuality=Black
Chromaticity.COLOR.BRPrintQuality=Color

# Dell
Chromaticity.MONOCHROME.DLColorMode=Black
Chromaticity.COLOR.DLColorMode=Color

# Epson
Chromaticity.MONOCHROME.EPRendering=None
Chromaticity.COLOR.EPRendering=RGB

# Gestener
# Kyocera
# Lanier
# NRG
# Ricoh
# Savin
# Utax
Chromaticity.MONOCHROME.ColorModel=Gray
Chromaticity.COLOR.ColorModel=CMYK

# HP
Chromaticity.MONOCHROME.HPColorAsGray=Yes
Chromaticity.COLOR.HPColorAsGray=No

# KONICA_MINOLTA
Chromaticity.MONOCHROME.SelectColor=Grayscale
Chromaticity.COLOR.SelectColor=Color

# Lexmark
Chromaticity.MONOCHROME.ColorMode=FalseM
Chromaticity.COLOR.ColorMode=TrueM
Chromaticity.MONOCHROME.BLW=FalseM
Chromaticity.COLOR.BLW=TrueM

# Oki
Chromaticity.MONOCHROME.OKControl=Gray
Chromaticity.COLOR.OKControl=Auto

# Sharp
Chromaticity.MONOCHROME.ARCMode=CMBW
Chromaticity.COLOR.ARCMode=CMColor

# Xerox
Chromaticity.MONOCHROME.XRXColor=BW
Chromaticity.COLOR.XRXColor=Automatic

Chromaticity.MONOCHROME.XRColorMode=Black
Chromaticity.COLOR.XRColorMode=Color

Chromaticity.MONOCHROME.XRColorModeSetting=Black
Chromaticity.COLOR.XRColorModeSetting=Color

Chromaticity.MONOCHROME.EFColorMode=GRAY
Chromaticity.COLOR.EFColorMode=CMYK


There are printers with the same color attributes and different values.

For example, Kyocera defines `ColorModel` Color option as `CMYK` in https://www.openprinting.org/download/PPD/Kyocera/en/Kyocera_CS-C4035E_en.ppd file:

*OpenUI *ColorModel/Color Mode: PickOne
*OrderDependency: 10 AnySetup *ColorModel
*DefaultColorModel: CMYK
*ColorModel CMYK/Color (CMYK): "<< /ProcessColorModel /DeviceCMYK >> setpagedevice"
*ColorModel Gray/Monochrome: "<< /ProcessColorModel /DeviceGray >> setpagedevice"
...
*CloseUI: *ColorModel


and Samsung defines the same `ColorModel` Color option as `Color`  in https://www.openprinting.org/download/PPD/Samsung/PS/Samsung_C2670_Series.ppd

*OrderDependency: 70 AnySetup *ColorModel
*DefaultColorModel: Color
*ColorModel Gray/Grayscale:  "<</ProcessColorModel /DeviceGray>> setpagedevice"
*ColorModel Color/Color:       "<</ProcessColorModel /DeviceCMYK>> setpagedevice"
*CloseUI: *ColorModel


The fix has been tested with 2 color printers `HP Color LaserJet MFP M180n` and `HP Ink Tank 110 series`.

`HP Color LaserJet MFP M180n` uses `ColorModel` key and `Gray` value for black & white printing.
`HP Ink Tank 110 series` uses `HPColorMode` key and `grayscale` value.

Only `HPColorAsGray` option with `Yes` and `No` values  is listed in https://www.openprinting.org/download/PPD/HP files.
For example, https://www.openprinting.org/download/PPD/HP/HP_DesignJet_3500CP_PS3.ppd

*OpenUI *HPColorAsGray/Print Color as Gray: PickOne
*OrderDependency: 5.0 AnySetup *HPColorAsGray
*DefaultHPColorAsGray: No
*HPColorAsGray Yes/Yes: "<< /ProcessColorModel /DeviceGray >> setpagedevice"
*HPColorAsGray No/No: "<< /ProcessColorModel /DeviceCMYK >> setpagedevice"
...
*CloseUI: *HPColorAsGray


Both `HPColorAsGray` and `HPColorMode` options are added to the `printer.properties` file as:

Chromaticity.MONOCHROME.HPColorAsGray=Yes
Chromaticity.COLOR.HPColorAsGray=No
Chromaticity.MONOCHROME.HPColorMode=grayscale
Chromaticity.COLOR.HPColorMode=color

-------------

Commit messages:
 - 8315113: Print request Chromaticity.MONOCHROME attribute does not work on macOS

Changes: https://git.openjdk.org/jdk/pull/18195/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18195&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8315113
  Stats: 431 lines in 6 files changed: 429 ins; 1 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/18195.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18195/head:pull/18195

PR: https://git.openjdk.org/jdk/pull/18195

From aivanov at openjdk.org  Mon Mar 11 14:17:59 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Mon, 11 Mar 2024 14:17:59 GMT
Subject: RFR: 8316388: Opensource five Swing component related regression
 tests
In-Reply-To: <bk66ojURFnGqahRv9IYAhgumqNGFFMOfRkMUzjkIAqI=.9a8c6550-f6d1-4ee2-b53b-54dc6491ff0e@github.com>
References: <bk66ojURFnGqahRv9IYAhgumqNGFFMOfRkMUzjkIAqI=.9a8c6550-f6d1-4ee2-b53b-54dc6491ff0e@github.com>
Message-ID: <Wz8nlNpeWgJKwr9Keb8ydCDT0mn6Q1bdR4CK50zCPZ8=.f39e7e08-9ec2-472a-9c19-6ecaad9b1f04@github.com>

On Mon, 11 Mar 2024 09:41:47 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

> Clean up five more tests.
> 
> test/jdk/javax/swing/JDesktopPane/4132993/bug4132993.java
> test/jdk/javax/swing/JDesktopPane/4773378/bug4773378.java
> test/jdk/javax/swing/JEditorPane/4325606/bug4325606.java
> test/jdk/javax/swing/JEditorPane/4330998/bug4330998.java
> test/jdk/javax/swing/JEditorPane/4694598/FrameContent.html
> test/jdk/javax/swing/JEditorPane/4694598/bug4694598.java

The copyright year should be updated to 2024.

The directory structure should be flattened, there's no need for additional folder in the path.

test/jdk/javax/swing/JDesktopPane/4132993/bug4132993.java line 47:

> 45:             } catch (PropertyVetoException ex) {
> 46:                 ex.printStackTrace();
> 47:             }

Shouldn't the test fail if an unexpected exception is thrown?

test/jdk/javax/swing/JDesktopPane/4132993/bug4132993.java line 59:

> 57:             throw new RuntimeException("Test interrupted by "
> 58:                     + e.getLocalizedMessage());
> 59:         }

You can add `throws Exception` clause to the `main` method and remove this `catch` block.

test/jdk/javax/swing/JDesktopPane/4773378/bug4773378.java line 69:

> 67:                         keyTyped = true;
> 68:                         bug4773378.this.notifyAll();
> 69:                     }

A `CountDownLatch` would work great in this case.

And `keyTyped` is a confusing name for a flag which gets to `true` when the internal frame is activated.

test/jdk/javax/swing/JDesktopPane/4773378/bug4773378.java line 85:

> 83:     public void performTest() {
> 84:         try {
> 85:             jif.setSelected(true);

This should be called via `SwingUtilities.invokeLater` on EDT.

test/jdk/javax/swing/JDesktopPane/4773378/bug4773378.java line 102:

> 100:         } catch (Throwable t) {
> 101:             t.printStackTrace();
> 102:         }

A `Throwable` should fail the test, it must be propagated.

test/jdk/javax/swing/JEditorPane/4325606/bug4325606.java line 83:

> 81:             robo.setAutoDelay(100);
> 82:             robo.delay(1000);
> 83:             robo.mouseMove(100,100);

This may fail if the frame location of (50, 50) isn't respected by a window manager.

test/jdk/javax/swing/JEditorPane/4325606/bug4325606.java line 115:

> 113:         try {
> 114:             SwingUtilities.invokeAndWait(b::setupGUI);
> 115:             safeSleep(3000);

Instead of sleeping, you can use a `CountDownLatch(3)` which you'll `countDown()` for each mouse click. Here you'll call `await(3, TimeUnit.SECONDS)` and throw a timeout error if `await` returns `false`.

Another synchroniser may be used to handle the case where `BadLocationException` is thrown to fail the test right away. Alternatively, `BadLocationException` may be wrapped into `RuntimeException` and re-thrown.

test/jdk/javax/swing/JEditorPane/4694598/FrameContent.html line 1:

> 1: <HTML><BODY>

Can this file be created by the test on the fly? There's no need for a supporting file.

In #18147, Prasanta handled the same situation.

test/jdk/javax/swing/JEditorPane/4694598/bug4694598.java line 29:

> 27:  * @summary JEditor pane throws NullPointerException on mouse movement.
> 28:  * @library ../../regtesthelpers
> 29:  * @build JRobot

The test doesn't seem to use any of the extended functionality provided by JRobot, so the standard `java.awt.Robot` can be used instead.

test/jdk/javax/swing/JEditorPane/4694598/bug4694598.java line 40:

> 38: 
> 39: public class bug4694598 {
> 40:     JFrame frame = null;

Suggestion:

    JFrame frame;

`null` is the default value any way.

test/jdk/javax/swing/JEditorPane/4694598/bug4694598.java line 69:

> 67:     public void performTest() throws InterruptedException,
> 68:             InvocationTargetException {
> 69:         JRobot jRobo = JRobot.getRobot();

Suggestion:

        JRobot jRobo = JRobot.getRobot();
        jRobo.waitForIdle();

Let the frame appear on the screen.

test/jdk/javax/swing/JEditorPane/4694598/bug4694598.java line 81:

> 79:             try {
> 80:                 Thread.sleep(50);
> 81:             } catch (InterruptedException ex) {}

Suggestion:

            jRobo.delay(50);

test/jdk/javax/swing/JEditorPane/4694598/bug4694598.java line 93:

> 91: 
> 92:     public static void main(String args[]) throws InterruptedException,
> 93:             InvocationTargetException {

Suggestion:

    public static void main(String[] args) throws Exception {

Java-style array declaration, shortened `throws` clause.

-------------

Changes requested by aivanov (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18184#pullrequestreview-1927877446
PR Review Comment: https://git.openjdk.org/jdk/pull/18184#discussion_r1519748640
PR Review Comment: https://git.openjdk.org/jdk/pull/18184#discussion_r1519751913
PR Review Comment: https://git.openjdk.org/jdk/pull/18184#discussion_r1519757762
PR Review Comment: https://git.openjdk.org/jdk/pull/18184#discussion_r1519759741
PR Review Comment: https://git.openjdk.org/jdk/pull/18184#discussion_r1519764367
PR Review Comment: https://git.openjdk.org/jdk/pull/18184#discussion_r1519773893
PR Review Comment: https://git.openjdk.org/jdk/pull/18184#discussion_r1519778086
PR Review Comment: https://git.openjdk.org/jdk/pull/18184#discussion_r1519785057
PR Review Comment: https://git.openjdk.org/jdk/pull/18184#discussion_r1519790641
PR Review Comment: https://git.openjdk.org/jdk/pull/18184#discussion_r1519791220
PR Review Comment: https://git.openjdk.org/jdk/pull/18184#discussion_r1519789098
PR Review Comment: https://git.openjdk.org/jdk/pull/18184#discussion_r1519787470
PR Review Comment: https://git.openjdk.org/jdk/pull/18184#discussion_r1519793301

From aivanov at openjdk.org  Mon Mar 11 16:32:18 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Mon, 11 Mar 2024 16:32:18 GMT
Subject: RFR: 8327751: Convert
 javax/swing/JInternalFrame/6726866/bug6726866.java applet test to main
In-Reply-To: <C5clTEn-okNdD5RVu8jcJW8T9bluj4GTy7BDNxUwKy0=.6b278225-50fa-4714-a066-8ad465cd9766@github.com>
References: <C5clTEn-okNdD5RVu8jcJW8T9bluj4GTy7BDNxUwKy0=.6b278225-50fa-4714-a066-8ad465cd9766@github.com>
Message-ID: <gQ7iFjVbMGzz8I_PD_-buikRJD9NVoQKMqLt4ubD5bo=.84d1cb08-726d-4811-8cd8-bdc4fb9c0a64@github.com>

On Mon, 11 Mar 2024 10:02:21 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> Conversion of manual applet test to main based using PassFailJFrame manual framework

Changes requested by aivanov (Reviewer).

test/jdk/javax/swing/JInternalFrame/6726866/bug6726866.java line 51:

> 49: 
> 50:     public static void main(String[] args) throws Exception {
> 51:         PassFailJFrame passFailJFrame = new PassFailJFrame.Builder()

Please use the `builder` helper method instead of using `new` explicitly.

test/jdk/javax/swing/JInternalFrame/6726866/bug6726866.java line 54:

> 52:                 .title("JInternalFrame Instructions")
> 53:                 .instructions(instructionsText)
> 54:                 .testTimeOut(5)

The default timeout can be omitted.

-------------

PR Review: https://git.openjdk.org/jdk/pull/18186#pullrequestreview-1927995890
PR Review Comment: https://git.openjdk.org/jdk/pull/18186#discussion_r1519859043
PR Review Comment: https://git.openjdk.org/jdk/pull/18186#discussion_r1519820170

From aivanov at openjdk.org  Mon Mar 11 16:32:20 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Mon, 11 Mar 2024 16:32:20 GMT
Subject: RFR: 8327750: Convert
 javax/swing/JFileChooser/FileFilterDescription/FileFilterDescription.java
 applet test to main
In-Reply-To: <Fri2USQ-lXz_OJYx4o2lhB5twAsUnaOn8R2ylmurMSk=.1c9502c4-a43b-4137-854c-25040beb0593@github.com>
References: <Fri2USQ-lXz_OJYx4o2lhB5twAsUnaOn8R2ylmurMSk=.1c9502c4-a43b-4137-854c-25040beb0593@github.com>
Message-ID: <PVxqkPm-hVEP6vWDCuTyVZo6YbbByuc0U1nV_eAUIAU=.d5b36c8c-3344-4aa4-8ec3-620b4e749298@github.com>

On Mon, 11 Mar 2024 08:54:38 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> Conversion of manual applet test to main based using PassFailJFrame manual framework

test/jdk/javax/swing/JFileChooser/FileFilterDescription/FileFilterDescription.java line 60:

> 58:                 .getInstalledLookAndFeels();
> 59:         for (final UIManager.LookAndFeelInfo info : infos) {
> 60:             SwingUtilities.invokeAndWait(() -> {

As far as I can see, the test creates multiple frames. This situation isn't handled well automatically by `PassFailJFrame` so far, no default window layout is provided.

However, it could not be needed here?

test/jdk/javax/swing/JFileChooser/FileFilterDescription/FileFilterDescription.java line 70:

> 68:                 PassFailJFrame.addTestWindow(frame);
> 69:                 PassFailJFrame.positionTestWindow(frame, PassFailJFrame.Position.TOP_LEFT_CORNER);
> 70:                 frame.pack();

You should call `pack()` before positioning the frame, otherwise the frame won't be positioned correctly.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18182#discussion_r1519817966
PR Review Comment: https://git.openjdk.org/jdk/pull/18182#discussion_r1519815357

From aivanov at openjdk.org  Mon Mar 11 16:32:24 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Mon, 11 Mar 2024 16:32:24 GMT
Subject: RFR: 8327748: Convert
 javax/swing/JFileChooser/6798062/bug6798062.java applet test to main [v2]
In-Reply-To: <WbNziLuyDum0qdGJnLB5bDVKUbYaU5E3OT9IqYQOIpo=.e1bc048b-4fe8-4ea7-979a-1e6481788c47@github.com>
References: <lGQbwCvyqdtOr8-NxY9l3pZC4mRPn7gBtd7qPIRPF-I=.0379a965-6ad2-44ba-abfe-ecd0ed3f7b02@github.com>
 <WbNziLuyDum0qdGJnLB5bDVKUbYaU5E3OT9IqYQOIpo=.e1bc048b-4fe8-4ea7-979a-1e6481788c47@github.com>
Message-ID: <vYHYNqFM9TxU6kj7U8dLqSDkScGMPn9GtYpCB_TEbYM=.799c3cb1-87cb-4737-9c0b-5fbf59b16987@github.com>

On Mon, 11 Mar 2024 09:53:17 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Conversion of manual applet test to main based using PassFailJFrame manual framework
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   typo

Changes requested by aivanov (Reviewer).

test/jdk/javax/swing/JFileChooser/6798062/bug6798062.java line 1:

> 1: /*

Likely, all the catch blocks which simply print stack traces should propagate the exception or rather in addition to printing the stack trace call `PassFailJFrame.forceFail` with a corresponding message.

The `fail` method of the test should also call `PassFailJFrame.forceFail` to fail the test.

test/jdk/javax/swing/JFileChooser/6798062/bug6798062.java line 78:

> 76: 
> 77:     public static void main(String[] args) throws Exception {
> 78:          PassFailJFrame passFailJFrame = new PassFailJFrame.Builder()

Please use the `builder` helper method instead of `new`.

test/jdk/javax/swing/JFileChooser/6798062/bug6798062.java line 86:

> 84:                 .build();
> 85: 
> 86:         SwingUtilities.invokeAndWait(() -> {

I suggest using the `testUI` method of the builder which accepts a lambda expression that returns a frame. Calling the passed method reference or lambda expression on EDT, registering the frame with `PassFailJFrame` and its positioning is handled automatically.

test/jdk/javax/swing/JFileChooser/6798062/bug6798062.java line 107:

> 105:     }
> 106: 
> 107:     private JComponent initialize() {

I suggest creating the files in the current directory instead of `temp` or `home`. When run with jtreg, the current directory is set to `scratch` which is automatically removed by jtreg, which ensures no files are left behind if the test fails to clean them up for whatever reason.

-------------

PR Review: https://git.openjdk.org/jdk/pull/18180#pullrequestreview-1928016162
PR Review Comment: https://git.openjdk.org/jdk/pull/18180#discussion_r1519841469
PR Review Comment: https://git.openjdk.org/jdk/pull/18180#discussion_r1519857497
PR Review Comment: https://git.openjdk.org/jdk/pull/18180#discussion_r1519832650
PR Review Comment: https://git.openjdk.org/jdk/pull/18180#discussion_r1519835478

From aivanov at openjdk.org  Mon Mar 11 16:32:25 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Mon, 11 Mar 2024 16:32:25 GMT
Subject: RFR: 8327748: Convert
 javax/swing/JFileChooser/6798062/bug6798062.java applet test to main [v2]
In-Reply-To: <ywgrsZPpGZlnkxsV0AD7i3cl1foFOTKu5OQGwsufHxw=.7ec5db6f-2403-4a9a-be49-8870ed5910ee@github.com>
References: <lGQbwCvyqdtOr8-NxY9l3pZC4mRPn7gBtd7qPIRPF-I=.0379a965-6ad2-44ba-abfe-ecd0ed3f7b02@github.com>
 <kFQxoht4JtXZS13lZycPTvF80pcnC5IwL7bApI_OUGg=.689a325e-b4a5-4658-87cf-fd9e6e61437c@github.com>
 <ywgrsZPpGZlnkxsV0AD7i3cl1foFOTKu5OQGwsufHxw=.7ec5db6f-2403-4a9a-be49-8870ed5910ee@github.com>
Message-ID: <u4Ucx2A7P2FTQr9G559CBs291FqS0hY3HKQxjYtolPg=.b4968b1f-6483-48ce-8925-7e21e842a6a3@github.com>

On Mon, 11 Mar 2024 09:48:36 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> test/jdk/javax/swing/JFileChooser/6798062/bug6798062.java line 56:
>> 
>>> 54: public class bug6798062 {
>>> 55: 
>>> 56:     private static final String instructionsText = """
>> 
>> `instructionsText` may be capitalize as using capital letter is common convention for final variables.
>
> That is for constant, IIRC...

Either way is fine? And `instructionsText` *is* a constant but it's not public.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18180#discussion_r1519826585

From tr at openjdk.org  Mon Mar 11 16:32:38 2024
From: tr at openjdk.org (Tejesh R)
Date: Mon, 11 Mar 2024 16:32:38 GMT
Subject: RFR: 8327787: Convert javax/swing/border/Test4129681.java applet
 test to main [v2]
In-Reply-To: <uZ3hGgyIWuMOTp6qSVNw_3r-F4REh4QvrzqAtH8fMo8=.e55e311d-c0d7-4863-9e8a-0d1edc1d8857@github.com>
References: <uZ3hGgyIWuMOTp6qSVNw_3r-F4REh4QvrzqAtH8fMo8=.e55e311d-c0d7-4863-9e8a-0d1edc1d8857@github.com>
Message-ID: <4X4wbMQLitT4ayAenjHb1g11517tv6pcTceWQBDdzlo=.a08d04f8-d49f-4b89-8d8e-7538d105a53f@github.com>

> Convert javax/swing/border/Test4129681.java applet test to main based test using PassFailJFrame.

Tejesh R has updated the pull request incrementally with three additional commits since the last revision:

 - Review updates
 - Review updates
 - Updates

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18189/files
  - new: https://git.openjdk.org/jdk/pull/18189/files/244437cd..d76714e8

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18189&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18189&range=00-01

  Stats: 21 lines in 1 file changed: 1 ins; 11 del; 9 mod
  Patch: https://git.openjdk.org/jdk/pull/18189.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18189/head:pull/18189

PR: https://git.openjdk.org/jdk/pull/18189

From aivanov at openjdk.org  Mon Mar 11 16:32:39 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Mon, 11 Mar 2024 16:32:39 GMT
Subject: RFR: 8327787: Convert javax/swing/border/Test4129681.java applet
 test to main [v2]
In-Reply-To: <4X4wbMQLitT4ayAenjHb1g11517tv6pcTceWQBDdzlo=.a08d04f8-d49f-4b89-8d8e-7538d105a53f@github.com>
References: <uZ3hGgyIWuMOTp6qSVNw_3r-F4REh4QvrzqAtH8fMo8=.e55e311d-c0d7-4863-9e8a-0d1edc1d8857@github.com>
 <4X4wbMQLitT4ayAenjHb1g11517tv6pcTceWQBDdzlo=.a08d04f8-d49f-4b89-8d8e-7538d105a53f@github.com>
Message-ID: <V49lTP8E-b9kaY3gCayVeVhnH2klEk_ITEL-JR2ZvjQ=.100c4270-7ae6-4a53-b0ec-db0d2beb39a1@github.com>

On Mon, 11 Mar 2024 15:00:21 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Convert javax/swing/border/Test4129681.java applet test to main based test using PassFailJFrame.
>
> Tejesh R has updated the pull request incrementally with three additional commits since the last revision:
> 
>  - Review updates
>  - Review updates
>  - Updates

Changes requested by aivanov (Reviewer).

Marked as reviewed by aivanov (Reviewer).

test/jdk/javax/swing/border/Test4129681.java line 41:

> 39: 
> 40: public class Test4129681 {
> 41:     private static JLabel label;

The `label` does not need to be global, it can be confined to `init`.

test/jdk/javax/swing/border/Test4129681.java line 47:

> 45:     public static void main(String[] args) throws Exception {
> 46:         String testInstructions = """
> 47:                 When frame starts, you'll see a checkbox

It's not what I really meant.

The instructions and the frame appear simultaneously, thus the tester doesn't need to wait for anything. Just describe what the tester needs to do.

test/jdk/javax/swing/border/Test4129681.java line 53:

> 51:                 is disabled as well as the label.
> 52:                 """;
> 53:         PassFailJFrame passFailJFrame = new PassFailJFrame.Builder()

Suggestion:

        PassFailJFrame passFailJFrame = PassFailJFrame.builder()

Use helper method to create the builder, don't use `new` explicitly.

-------------

PR Review: https://git.openjdk.org/jdk/pull/18189#pullrequestreview-1928044311
PR Review: https://git.openjdk.org/jdk/pull/18189#pullrequestreview-1928078877
PR Review Comment: https://git.openjdk.org/jdk/pull/18189#discussion_r1519870582
PR Review Comment: https://git.openjdk.org/jdk/pull/18189#discussion_r1519849859
PR Review Comment: https://git.openjdk.org/jdk/pull/18189#discussion_r1519855420

From aivanov at openjdk.org  Mon Mar 11 16:32:41 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Mon, 11 Mar 2024 16:32:41 GMT
Subject: RFR: 8327787: Convert javax/swing/border/Test4129681.java applet
 test to main [v2]
In-Reply-To: <f0Ho3Eqi3egqVq2Kx4SzKvOR1Jk33ete-t-_PVyO1TA=.47592344-a5ff-42c5-bae2-85386f1cd599@github.com>
References: <uZ3hGgyIWuMOTp6qSVNw_3r-F4REh4QvrzqAtH8fMo8=.e55e311d-c0d7-4863-9e8a-0d1edc1d8857@github.com>
 <f0Ho3Eqi3egqVq2Kx4SzKvOR1Jk33ete-t-_PVyO1TA=.47592344-a5ff-42c5-bae2-85386f1cd599@github.com>
Message-ID: <8Sa7igl3eK0WlSMyMi9uLoCH09b2Rr9Zl9sQo_Ogr0M=.bd1966f2-6118-4dbc-86d5-86a26521ee20@github.com>

On Mon, 11 Mar 2024 13:43:56 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Tejesh R has updated the pull request incrementally with three additional commits since the last revision:
>> 
>>  - Review updates
>>  - Review updates
>>  - Updates
>
> test/jdk/javax/swing/border/Test4129681.java line 67:
> 
>> 65:     }
>> 66: 
>> 67:     public static void init() {
> 
> I propose using `testUI` method of the builder, it hides the complexity of registering and positioning the frame. Modify this method to return the created `frame`.
> 
> See PR #17838 as an example or other PRs. The javadoc for `PassFailJFrame` also contains the recommended usage.

If the test UI is simple enough, you can even use `splitUI` to display the test UI along with the instructions. In this case, instead of frame return a `JComponent`, likely `JPanel`, which contains all the test UI.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18189#discussion_r1519853979

From tr at openjdk.org  Mon Mar 11 16:42:08 2024
From: tr at openjdk.org (Tejesh R)
Date: Mon, 11 Mar 2024 16:42:08 GMT
Subject: RFR: 8327826: Convert javax/swing/border/Test4243289.java applet test
 to main
Message-ID: <M5kMa3NPTVyzBZK7rPRT_gAHTQgVjPY_in-ZZJ8i1zM=.f1def8d8-79cd-4b03-88d2-4016a937d08d@github.com>

Convert javax/swing/border/Test4243289.java applet test to main based test using PassFailJFrame.

-------------

Commit messages:
 - Conversion from Applet to Main

Changes: https://git.openjdk.org/jdk/pull/18197/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18197&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8327826
  Stats: 74 lines in 2 files changed: 31 ins; 35 del; 8 mod
  Patch: https://git.openjdk.org/jdk/pull/18197.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18197/head:pull/18197

PR: https://git.openjdk.org/jdk/pull/18197

From erikj at openjdk.org  Mon Mar 11 17:29:53 2024
From: erikj at openjdk.org (Erik Joelsson)
Date: Mon, 11 Mar 2024 17:29:53 GMT
Subject: RFR: 8315113: Print request Chromaticity.MONOCHROME attribute does
 not work on macOS
In-Reply-To: <m_OJNAf9YmC4OJMwtCM5P-eklmNJUymWJjMfo5s_wpI=.7d1c5a1f-2158-49f2-906d-dc074019cb99@github.com>
References: <m_OJNAf9YmC4OJMwtCM5P-eklmNJUymWJjMfo5s_wpI=.7d1c5a1f-2158-49f2-906d-dc074019cb99@github.com>
Message-ID: <gwslmuVD8tSI8eZvhawyJ8ypM5DQXBZGi655dYuoL7A=.d7494794-9613-42fb-bcad-5ce96382372f@github.com>

On Mon, 11 Mar 2024 13:54:02 GMT, Alexander Scherbatiy <alexsch at openjdk.org> wrote:

> The fix provides ability to print Black & White pages on macOS.
> 
> Cocoa API has [PMSetColorMode](https://developer.apple.com/documentation/applicationservices/core_printing/1805783-pmsetcolormode) function but it is marked as deprecated and really does nothing.
> 
> There is no replacement; this function was included to facilitate porting legacy applications to macOS, 
> but it serves no useful purpose.
> 
> Dumping `NSPrintInfo` print settings which were set by the native print dialog on macOS shows that the keys and values used for Black & White printing depend on the used printer type.
> For example, the tested 
> `HP Color LaserJet MFP M180n` printer uses `ColorModel` key and`Gray` value, and
> `HP Ink Tank 110 series` uses `HPColorMode` key and `grayscale` value.
> 
> Printing all `NSPrintInfo` presets shows that they do not contain key/value pairs  for Black&White settings.
> This is the code snippet used to print `NSPrintInfo` presets:
> 
>     PMPrinter pr;
>     PMPrintSession printSession = (PMPrintSession)[printInfo PMPrintSession];
>     OSStatus status = PMSessionGetCurrentPrinter(printSession, &pr);
>     CFArrayRef presetsList = nil;
>     status = PMPrinterCopyPresets(pr, &presetsList);
>     CFIndex arrayCount = CFArrayGetCount(presetsList);
> 
>     for (CFIndex index = 0; index < arrayCount; index++) {
>         PMPreset preset = (PMPreset)CFArrayGetValueAtIndex(presetsList, index);
>         CFStringRef presetName = nil;
>         if (PMPresetCopyName(preset, &presetName) == noErr && CFStringGetLength(presetName) > 0) {
>             NSLog(@"  presetName: '%@'", presetName);
>             NSDictionary* dict = nil;
>             if (PMPresetGetAttributes(preset, (CFDictionaryRef*)(&dict)) == noErr) {
>                    // print preset dict
> 
> 
> The idea of the proposed fix is to store printer dependent key/value pairs in the `<jdk-home>/conf/printer.properties` property file.
> 
> The property file has the format:
> 
> print-attribute.print-attribute-value.key=value
> 
> where `print-attribute` is the java print attribute, `print-attribute-value` is the corresponding attribute value, and `key` and `value` is the key/value pair used by a specific printer.
> 
> For example, for `Chromaticity` attribute the property file could look like:
> 
> Chromaticity.MONOCHROME.ColorModel=Gray
> Chromaticity.COLOR.ColorModel=CMYK
> Chromaticity.MONOCHROME.HPColorMode=grayscale
> Chromaticity.COLOR.HPColorMode=color
> 
> where `Chromaticity.MONOCHROME` key prefix corresponds to `Chromaticity.MONOCHOROME` print attribute constant  with  (...

Build change looks ok. 

(The copy logic follows the existing pattern in that file so it's fine, even though we have generally moved to different patterns using the SetupCopyFile macro.)

-------------

Marked as reviewed by erikj (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18195#pullrequestreview-1928548932

From azvegint at openjdk.org  Mon Mar 11 17:40:21 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Mon, 11 Mar 2024 17:40:21 GMT
Subject: RFR: 8327835: Convert
 java/awt/FileDialog/RegexpFilterTest/RegexpFilterTest applet test to main
Message-ID: <O_XrLLXwQtMWjKGEoOaYSM8RdDnyH3LF3-Bdp5PDRHo=.72bb3619-6cfc-43c8-83d6-c87eabf24636@github.com>

The `java/awt/FileDialog/RegexpFilterTest/RegexpFilterTest` test is written to test the very specific functionality of `XFileDialogPeer`, so it shouldn't be run on platforms other than Linux.

We also need to set `sun.awt.disableGtkFileDialogs` to `true` to be able to test `XFileDialogPeer`, because by default it tries to use the Gtk file dialog if it is available.
The Gtk file dialog has a search field hidden under the magnifying glass icon, but it has a different syntax.

The Windows system file dialog allows you to use wildcard filtering in the "File name" field by hitting the `enter` afterwards, but again, this test was written to test our own file dialog implementation, not the system's.

-------------

Commit messages:
 - fix spacing
 - remove def timeout
 - remove separate dir
 - initial

Changes: https://git.openjdk.org/jdk/pull/18203/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18203&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8327835
  Stats: 345 lines in 4 files changed: 75 ins; 270 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18203.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18203/head:pull/18203

PR: https://git.openjdk.org/jdk/pull/18203

From azvegint at openjdk.org  Mon Mar 11 17:59:20 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Mon, 11 Mar 2024 17:59:20 GMT
Subject: RFR: 8327838: Convert
 java/awt/FileDialog/MultipleMode/MultipleMode.html applet test to main
Message-ID: <DI0RnXYhvIrM8iYvr6t5rSadWbY_VEnhePX1QnX41dA=.ac99191d-478f-4a09-a941-f9723929634a@github.com>

The test is converted to main.
Tested on Linux, Macos and Windows.

-------------

Commit messages:
 - 8327838 Convert java/awt/FileDialog/MultipleMode/MultipleMode.html applet test to main

Changes: https://git.openjdk.org/jdk/pull/18205/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18205&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8327838
  Stats: 445 lines in 3 files changed: 113 ins; 332 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18205.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18205/head:pull/18205

PR: https://git.openjdk.org/jdk/pull/18205

From aivanov at openjdk.org  Mon Mar 11 17:59:55 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Mon, 11 Mar 2024 17:59:55 GMT
Subject: RFR: 8280392:
 java/awt/Focus/NonFocusableWindowTest/NonfocusableOwnerTest.java failed with
 "RuntimeException: Test failed." [v2]
In-Reply-To: <lz60OBe9QYgOuzQM0Uv8pF0URMvFwwAVykTE4-cfRiI=.0abd6616-e428-4986-a55a-adbf72fe91c7@github.com>
References: <o_Z6zlPUisWgc5LIglgOe4zbIjsijJfuG9MtoBveFAU=.2d730b06-211a-485e-8390-6d6f9ae75947@github.com>
 <lz60OBe9QYgOuzQM0Uv8pF0URMvFwwAVykTE4-cfRiI=.0abd6616-e428-4986-a55a-adbf72fe91c7@github.com>
Message-ID: <RwBe1jifXggpPS3eot6hfqSMsKPfF72Z2YmsuYvZxxk=.ba38be04-15bc-4d37-8d87-1f47e64b817c@github.com>

On Thu, 7 Mar 2024 20:07:19 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> Introduce delays in test to stabilize. Test passes 50x after fix.
>
> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   update copyright, fix jtreg formatting, update frame title, expand imports

Looks fine.

-------------

Marked as reviewed by aivanov (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18091#pullrequestreview-1928660737

From alexey.ivanov at oracle.com  Mon Mar 11 18:19:44 2024
From: alexey.ivanov at oracle.com (Aleksei Ivanov)
Date: Mon, 11 Mar 2024 18:19:44 +0000
Subject: introducing myself
In-Reply-To: <1453988293.356073367.1709908702002.JavaMail.zimbra@free.fr>
References: <1453988293.356073367.1709908702002.JavaMail.zimbra@free.fr>
Message-ID: <b0783524-15f3-4809-b533-839e5d84bad7@oracle.com>

Hello Raphael,

Thank you for your contribution. Your message belongs at 
client-libs-dev at openjdk.org where client issues?2D, AWT, Swing?are 
discussed.

Your PR isn't announced on the mailing list because it's not linked to 
an issue in JDK Bug System (JBS): https://bugs.openjdk.org/

Your PR shortly describes the problem. Do you have a test case to 
demonstrate the problem? This test case would then serve as regression 
test for the changeset, so it's still useful.

Once I've got more details, I'll submit a new bug for you. I searched 
JBS for ChangedCharSetException and I didn't find any bug which is 
similar to what you describe.

On 2024-03-08 14:38, raphael.jolly at free.fr wrote:
> Hello, my name is Raphael Jolly, I am the developer of (among other) this software https://github.com/rjolly/linoleum and I was invited following posting this PR https://github.com/openjdk/jdk/pull/17567 which prevents reading email in HTML format in said software mailer, for which I have a workaround but that I thought would be worth fixing in the JDK, despite Swing (and especially the JEditorPane) not being that much used these days.
>
> Thanks for reading and looking forward to interesting discussions,
> Raphael
-- 
Regards,
Alexey

From aivanov at openjdk.org  Mon Mar 11 18:44:27 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Mon, 11 Mar 2024 18:44:27 GMT
Subject: RFR: 8327787: Convert javax/swing/border/Test4129681.java applet
 test to main [v2]
In-Reply-To: <4X4wbMQLitT4ayAenjHb1g11517tv6pcTceWQBDdzlo=.a08d04f8-d49f-4b89-8d8e-7538d105a53f@github.com>
References: <uZ3hGgyIWuMOTp6qSVNw_3r-F4REh4QvrzqAtH8fMo8=.e55e311d-c0d7-4863-9e8a-0d1edc1d8857@github.com>
 <4X4wbMQLitT4ayAenjHb1g11517tv6pcTceWQBDdzlo=.a08d04f8-d49f-4b89-8d8e-7538d105a53f@github.com>
Message-ID: <Kxo6_3NH0R7xTxgDoP197gATh6zQL1HGaZtFdsItZrU=.dee52480-bda8-4ed6-9eea-461ef8ae74f8@github.com>

On Mon, 11 Mar 2024 16:32:38 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Convert javax/swing/border/Test4129681.java applet test to main based test using PassFailJFrame.
>
> Tejesh R has updated the pull request incrementally with three additional commits since the last revision:
> 
>  - Review updates
>  - Review updates
>  - Updates

> > I propose using testUI method of the builder, it hides the complexity of registering and positioning the frame. Modify this method to return the created frame.
>
> If the test UI is simple enough, you can even use splitUI to display the test UI along with the instructions. In this case, instead of frame return a JComponent, likely JPanel, which contains all the test UI.

It fits into splitUI pretty well, especially if you reduce the size of the test UI frame. Yet you'll have convert `JFrame` to `JPanel` or `Box`.

You can find a sample usage in #17847 or #17608 in [Collate2DPrintingTest.java](https://github.com/openjdk/jdk/blob/69fe7d9651cd759eea0495a0b7bf8c356d9b93a6/test/jdk/java/awt/print/PrinterJob/Collate2DPrintingTest.java#L96-L104).

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18189#issuecomment-1989179731

From aivanov at openjdk.org  Mon Mar 11 19:19:13 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Mon, 11 Mar 2024 19:19:13 GMT
Subject: RFR: 8327137: Add test for ConcurrentModificationException in
 BasicDirectoryModel
In-Reply-To: <mCqqjrXVWDB2PvpOhKHx-Hr8W6tUz6v4stztGmyAeEg=.1f95da1c-e1a5-40be-be8b-0758729fa9b9@github.com>
References: <mCqqjrXVWDB2PvpOhKHx-Hr8W6tUz6v4stztGmyAeEg=.1f95da1c-e1a5-40be-be8b-0758729fa9b9@github.com>
Message-ID: <aRuO2zb4IkM3F28MH5RcfHesc1Z9i7w_uK8kSkIh6i0=.cce14bf8-3384-4e8e-9c12-4e0708dbf3ab@github.com>

On Mon, 4 Mar 2024 15:52:45 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> I'm adding a regression test for [JDK-8323670](https://bugs.openjdk.org/browse/JDK-8323670) and [JDK-8307091](https://bugs.openjdk.org/browse/JDK-8307091); it's also a regression test for [JDK-8240690](https://bugs.openjdk.org/browse/JDK-8240690).
> 
> I referenced this test in PR #17462 in [this comment](https://github.com/openjdk/jdk/pull/17462#issuecomment-1914844026). I fine-tuned the test since that time.
> 
> The test doesn't fail all the time without the fix for JDK-8323670, however, it fails sometimes. If you run the test several times, it will likely fail _without the fix_.
> 
> For me, the test fails about 10 times from 40 runs in the CI. It fails on macOS more frequently than on Linux.
> 
> When the test passes, it usually completes in 5 minutes.
> 
> **How the test works**
> 
> The test creates a temporary directory in the current directory and creates a number of files in it. (The number of files is controlled by `NUMBER_OF_THREADS` constant). Then the test creates `JFileChooser` in the temporary directory.
> 
> The test starts several _scanner_ threads, the number is controlled by `NUMBER_OF_THREADS`, which repeatedly call `fileChooser.rescanCurrentDirectory()`. This results in calling `BasicDirectoryModel.validateFileCache` which starts a background thread ? "Basic L&F File Loading Thread" ? to enumerate the files.
> 
> A timer is used to create new files in the directory that the file chooser is using.
> 
> After enumerating the files, the File Loading Thread posts an event to EDT. The event updates `fileCache` and fires a `ListDataEvent`.
> 
> If the File Loading Thread is iterating over `fileCache` using `Iterator` (when `fileCache.subList` or `fileCache.equals` is running; or a new `Vector` instance is created from a `fileCache` or its sublist) and `fileCache` is being updated on EDT, then `ConcurrentModificationException` is thrown.
> 
> On Linux and on _headless_ macOS, `ShellFolder.invoke` is executed in the caller, which makes it easier to reproduce the issue. Because of [JDK-8325179](https://bugs.openjdk.org/browse/JDK-8325179), there are several File Loading Threads, which also helps to reproduce the issue.
> 
> On _headful_ macOS, the `BasicDirectoryModel` is not used, so the test does not reproduce the issue.
> 
> On Windows, the test does not fail or fails with `OutOfMemoryError`. It is because all the File Loading Threads are serialised on the COM thread, `ShellFolder.invoke` submits the task to the COM thread and waits for it to complete. The chance of updating `fileCache` whil...

@mrserb, @RealCLanger, could you run this test in your environments, please? It is for Linux and macOS only.

I'm looking for confirmation that the test fails without the fix for [JDK-8323670](https://bugs.openjdk.org/browse/JDK-8323670). Since JDK-8323670 is fixed in mainline, you can run it in 21u or 17u which don't have the fix yet.

You'll need to run the test several times because it fails only occasionally. That's why I want to collect more data on whether the test is useful/stable enough.

I greatly appreciate your help.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18109#issuecomment-1989244423

From aivanov at openjdk.org  Mon Mar 11 21:23:23 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Mon, 11 Mar 2024 21:23:23 GMT
Subject: RFR: 8325851: Hide PassFailJFrame.Builder constructor
Message-ID: <NPUEOS3SWj0H7KALdlwfdfJSxqsrpTyn9X4c1N-H8Ho=.cb175d1a-0a9b-4e23-98ae-404101a20531@github.com>

The `Builder` class in `PassFailJFrame` is public and has a public constructor. At the same time, a better design would be to hide all the Builder constructors and rely on the `builder()` method which returns an instance of the `Builder` class.

This PR makes the constructor of the `Builder` class private so that it's not accessible directly.

Use `PassFailJFrame.builder()` to get an instance of the builder and configure parameters of `PassFailJFrame`.

I updated all the tests which used the constructor directly by calling `new PassFailJFrame.Builder()`.

I converted a few tests to use the `testUI`, which greatly simplifies the test code. This change also removes flickering of the test UI.

-------------

Commit messages:
 - Minor updates to createUI in ComboPopupBug
 - Use testUI in ComboPopupBug
 - Use testUI in DefaultCloseOperation and reduce the number of columns
 - Use testUI in LightweightCliprect
 - Remove unused EventQueue import
 - Use testUI in DefaultSizeTest
 - Use testUI in FrameRepackTest
 - Use testUI in MultimonVImage
 - Use testUI in AddRemoveMenuBar_{1..4}
 - Remove unused EventQueue import
 - ... and 5 more: https://git.openjdk.org/jdk/compare/0a6e64e2...91361e52

Changes: https://git.openjdk.org/jdk/pull/18206/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18206&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8325851
  Stats: 242 lines in 21 files changed: 14 ins; 118 del; 110 mod
  Patch: https://git.openjdk.org/jdk/pull/18206.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18206/head:pull/18206

PR: https://git.openjdk.org/jdk/pull/18206

From aivanov at openjdk.org  Mon Mar 11 21:27:14 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Mon, 11 Mar 2024 21:27:14 GMT
Subject: RFR: 8327835: Convert
 java/awt/FileDialog/RegexpFilterTest/RegexpFilterTest applet test to main
In-Reply-To: <O_XrLLXwQtMWjKGEoOaYSM8RdDnyH3LF3-Bdp5PDRHo=.72bb3619-6cfc-43c8-83d6-c87eabf24636@github.com>
References: <O_XrLLXwQtMWjKGEoOaYSM8RdDnyH3LF3-Bdp5PDRHo=.72bb3619-6cfc-43c8-83d6-c87eabf24636@github.com>
Message-ID: <3V8ICRRvev5oxT7k8QDL2ZoeTTi-hCYNTWlJIcvsdo0=.833d3917-a5da-416a-bf22-473def7cff1c@github.com>

On Mon, 11 Mar 2024 17:29:50 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

> The `java/awt/FileDialog/RegexpFilterTest/RegexpFilterTest` test is written to test the very specific functionality of `XFileDialogPeer`, so it shouldn't be run on platforms other than Linux.
> 
> We also need to set `sun.awt.disableGtkFileDialogs` to `true` to be able to test `XFileDialogPeer`, because by default it tries to use the Gtk file dialog if it is available.
> The Gtk file dialog has a search field hidden under the magnifying glass icon, but it has a different syntax.
> 
> The Windows system file dialog allows you to use wildcard filtering in the "File name" field by hitting the `enter` afterwards, but again, this test was written to test our own file dialog implementation, not the system's.

Changes requested by aivanov (Reviewer).

test/jdk/ProblemList.txt line 799:

> 797: java/awt/TrayIcon/DragEventSource/DragEventSource.java 8252242 macosx-all
> 798: java/awt/FileDialog/DefaultFocusOwner/DefaultFocusOwner.java 7187728 macosx-all,linux-all
> 799: java/awt/FileDialog/RegexpFilterTest/RegexpFilterTest.html 7187728 macosx-all,linux-all

What about [JDK-7187728](https://bugs.openjdk.org/browse/JDK-7187728)? It's still unresolved.

test/jdk/java/awt/FileDialog/RegexpFilterTest.java line 73:

> 71:                 .build();
> 72: 
> 73:         passFailJFrame.awaitAndCheck();

Suggestion:

                .build()
                .awaitAndCheck();

Chain it. Then the variable `passFailJFrame` becomes redundant.

test/jdk/java/awt/FileDialog/RegexpFilterTest/RegexpFilterTest.java line 1:

> 1: /*

I believe we haven't flattened the directory structure when modifying tests. On the other hand, this file has no meaningful modification history, so nothing's lost.

-------------

PR Review: https://git.openjdk.org/jdk/pull/18203#pullrequestreview-1929348959
PR Review Comment: https://git.openjdk.org/jdk/pull/18203#discussion_r1520449595
PR Review Comment: https://git.openjdk.org/jdk/pull/18203#discussion_r1520446796
PR Review Comment: https://git.openjdk.org/jdk/pull/18203#discussion_r1520448130

From aivanov at openjdk.org  Mon Mar 11 21:32:18 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Mon, 11 Mar 2024 21:32:18 GMT
Subject: RFR: 8327838: Convert
 java/awt/FileDialog/MultipleMode/MultipleMode.html applet test to main
In-Reply-To: <DI0RnXYhvIrM8iYvr6t5rSadWbY_VEnhePX1QnX41dA=.ac99191d-478f-4a09-a941-f9723929634a@github.com>
References: <DI0RnXYhvIrM8iYvr6t5rSadWbY_VEnhePX1QnX41dA=.ac99191d-478f-4a09-a941-f9723929634a@github.com>
Message-ID: <j4jshGS2_rqumN_sLCrumbdH9i5rtLino-m7ajoZYDM=.cfa0a401-16de-4d3d-9580-c72a16d0132a@github.com>

On Mon, 11 Mar 2024 17:53:48 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

> The test is converted to main.
> Tested on Linux, Macos and Windows.

Changes requested by aivanov (Reviewer).

test/jdk/java/awt/FileDialog/MultipleMode.java line 68:

> 66:                 .build();
> 67: 
> 68:         EventQueue.invokeAndWait(MultipleMode::init);

I suggest using `testUI` method. Make your `init` method return `Frame` after you call `pack()`, don't call `setVisible(true)`.


    .testUI(MultipleMode::init)


Then you'll be able to chain `awaitAndCheck()` call.

test/jdk/java/awt/FileDialog/MultipleMode.java line 82:

> 80:         Button open = new Button("open");
> 81:         open.addActionListener(e -> {
> 82:             FileDialog d = new FileDialog((Frame)null);

Make `frame` the owner?

test/jdk/java/awt/FileDialog/MultipleMode/MultipleMode.java line 1:

> 1: /*

Do we move test files when modifying?

-------------

PR Review: https://git.openjdk.org/jdk/pull/18205#pullrequestreview-1929367696
PR Review Comment: https://git.openjdk.org/jdk/pull/18205#discussion_r1520452456
PR Review Comment: https://git.openjdk.org/jdk/pull/18205#discussion_r1520453034
PR Review Comment: https://git.openjdk.org/jdk/pull/18205#discussion_r1520453449

From aivanov at openjdk.org  Mon Mar 11 21:39:13 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Mon, 11 Mar 2024 21:39:13 GMT
Subject: RFR: 8327826: Convert javax/swing/border/Test4243289.java applet
 test to main
In-Reply-To: <M5kMa3NPTVyzBZK7rPRT_gAHTQgVjPY_in-ZZJ8i1zM=.f1def8d8-79cd-4b03-88d2-4016a937d08d@github.com>
References: <M5kMa3NPTVyzBZK7rPRT_gAHTQgVjPY_in-ZZJ8i1zM=.f1def8d8-79cd-4b03-88d2-4016a937d08d@github.com>
Message-ID: <9KzJQOh_Bn-wPhoA2_vMhHfAjXxNALG6KkJHAQE0NMg=.1d9c6cc5-597c-4ad5-8d51-99dd92621a9f@github.com>

On Mon, 11 Mar 2024 14:46:11 GMT, Tejesh R <tr at openjdk.org> wrote:

> Convert javax/swing/border/Test4243289.java applet test to main based test using PassFailJFrame.

Changes requested by aivanov (Reviewer).

test/jdk/javax/swing/border/Test4243289.java line 47:

> 45:                 When frame starts, you'll see a panel with a TitledBorder
> 46:                 with title "Panel Title". If this title is overstriken with
> 47:                 the border line, test fails, otherwise it passes.

As in #18189, just explain what the tester needs to do. Both the instructions and the test UI appear on the screen simultaneously.

test/jdk/javax/swing/border/Test4243289.java line 49:

> 47:                 the border line, test fails, otherwise it passes.
> 48:                 """;
> 49:         PassFailJFrame passFailJFrame = new PassFailJFrame.Builder()

Suggestion:

        PassFailJFrame passFailJFrame = PassFailJFrame.builder()

Please use the `builder` method instead of instantiating the `Builder` object directly.

test/jdk/javax/swing/border/Test4243289.java line 59:

> 57:         SwingUtilities.invokeAndWait(() -> {
> 58:             init();
> 59:         });

Convert to `testUI` which streamlines the `main` method and simplifies creating the test UI.

Alternatively, use `splitUI` which could simplify the resulting UI.

test/jdk/javax/swing/border/Test4243289.java line 77:

> 75:         frame.setSize(300, 300);
> 76:         PassFailJFrame.addTestWindow(frame);
> 77:         PassFailJFrame.positionTestWindow(frame, PassFailJFrame.Position.TOP_LEFT_CORNER);

Any particular reason why top left corner is used instead of centered-positioning?

-------------

PR Review: https://git.openjdk.org/jdk/pull/18197#pullrequestreview-1928952878
PR Review Comment: https://git.openjdk.org/jdk/pull/18197#discussion_r1520332384
PR Review Comment: https://git.openjdk.org/jdk/pull/18197#discussion_r1520317239
PR Review Comment: https://git.openjdk.org/jdk/pull/18197#discussion_r1520318570
PR Review Comment: https://git.openjdk.org/jdk/pull/18197#discussion_r1520320069

From prr at openjdk.org  Mon Mar 11 22:12:13 2024
From: prr at openjdk.org (Phil Race)
Date: Mon, 11 Mar 2024 22:12:13 GMT
Subject: RFR: 8325851: Hide PassFailJFrame.Builder constructor
In-Reply-To: <NPUEOS3SWj0H7KALdlwfdfJSxqsrpTyn9X4c1N-H8Ho=.cb175d1a-0a9b-4e23-98ae-404101a20531@github.com>
References: <NPUEOS3SWj0H7KALdlwfdfJSxqsrpTyn9X4c1N-H8Ho=.cb175d1a-0a9b-4e23-98ae-404101a20531@github.com>
Message-ID: <qUANlVa2zVEvAQMUb3He2ywrVp5dv3EsjW_opsabFdI=.1db36154-e224-4d7d-b691-9798f9b60db5@github.com>

On Mon, 11 Mar 2024 21:18:40 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> The `Builder` class in `PassFailJFrame` is public and has a public constructor. At the same time, a better design would be to hide all the Builder constructors and rely on the `builder()` method which returns an instance of the `Builder` class.
> 
> This PR makes the constructor of the `Builder` class private so that it's not accessible directly.
> 
> Use `PassFailJFrame.builder()` to get an instance of the builder and configure parameters of `PassFailJFrame`.
> 
> I updated all the tests which used the constructor directly by calling `new PassFailJFrame.Builder()`.
> 
> I converted a few tests to use the `testUI`, which greatly simplifies the test code. This change also removes flickering of the test UI.

test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 1070:

> 1068:         }
> 1069: 
> 1070:         public Builder title(String title) {

So what about this one ? Are too many tests using it ?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18206#discussion_r1520485829

From aivanov at openjdk.org  Mon Mar 11 22:29:12 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Mon, 11 Mar 2024 22:29:12 GMT
Subject: RFR: 8325851: Hide PassFailJFrame.Builder constructor
In-Reply-To: <qUANlVa2zVEvAQMUb3He2ywrVp5dv3EsjW_opsabFdI=.1db36154-e224-4d7d-b691-9798f9b60db5@github.com>
References: <NPUEOS3SWj0H7KALdlwfdfJSxqsrpTyn9X4c1N-H8Ho=.cb175d1a-0a9b-4e23-98ae-404101a20531@github.com>
 <qUANlVa2zVEvAQMUb3He2ywrVp5dv3EsjW_opsabFdI=.1db36154-e224-4d7d-b691-9798f9b60db5@github.com>
Message-ID: <Ca4Mw3qzjQDSsd_Kkl-78XO2MjaB7G-LWTo5Ifz1pWU=.2a73c76c-5322-43b7-98f6-6dcbaafc1c32@github.com>

On Mon, 11 Mar 2024 22:09:09 GMT, Phil Race <prr at openjdk.org> wrote:

>> The `Builder` class in `PassFailJFrame` is public and has a public constructor. At the same time, a better design would be to hide all the Builder constructors and rely on the `builder()` method which returns an instance of the `Builder` class.
>> 
>> This PR makes the constructor of the `Builder` class private so that it's not accessible directly.
>> 
>> Use `PassFailJFrame.builder()` to get an instance of the builder and configure parameters of `PassFailJFrame`.
>> 
>> I updated all the tests which used the constructor directly by calling `new PassFailJFrame.Builder()`.
>> 
>> I converted a few tests to use the `testUI`, which greatly simplifies the test code. This change also removes flickering of the test UI.
>
> test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 1070:
> 
>> 1068:         }
>> 1069: 
>> 1070:         public Builder title(String title) {
> 
> So what about this one ? Are too many tests using it ?

What about them? All the methods in `Builder` return `Builder`, that's perfectly fine.

The goal of this PR is to make impossible to write


new PassFailJFrame.Builder();


which is replaced with


PassFailJFrame.builder();


In the former case, the test explicitly depends on the fact that the builder pattern implementation is in the `PassFailJFrame.Builder` class.

In the latter case, I can change the `builder()` method to return another class. As long as that other class has the same set of methods, like `instructions` and title`, which return the same object, nothing breaks. Encapsulation.

With this change, all the existing tests continue to run. Those tests which failed to compile because of a breaking API change are updated in this PR.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18206#discussion_r1520497593

From prr at openjdk.org  Mon Mar 11 22:52:14 2024
From: prr at openjdk.org (Phil Race)
Date: Mon, 11 Mar 2024 22:52:14 GMT
Subject: RFR: 8325851: Hide PassFailJFrame.Builder constructor
In-Reply-To: <Ca4Mw3qzjQDSsd_Kkl-78XO2MjaB7G-LWTo5Ifz1pWU=.2a73c76c-5322-43b7-98f6-6dcbaafc1c32@github.com>
References: <NPUEOS3SWj0H7KALdlwfdfJSxqsrpTyn9X4c1N-H8Ho=.cb175d1a-0a9b-4e23-98ae-404101a20531@github.com>
 <qUANlVa2zVEvAQMUb3He2ywrVp5dv3EsjW_opsabFdI=.1db36154-e224-4d7d-b691-9798f9b60db5@github.com>
 <Ca4Mw3qzjQDSsd_Kkl-78XO2MjaB7G-LWTo5Ifz1pWU=.2a73c76c-5322-43b7-98f6-6dcbaafc1c32@github.com>
Message-ID: <lXFk7rSn4-hJKD7HjuP1ZQao91l5G7mO0_Uhp1HD-4c=.ecca4053-e460-4b4d-b0bd-3b4e767dbad8@github.com>

On Mon, 11 Mar 2024 22:25:40 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 1070:
>> 
>>> 1068:         }
>>> 1069: 
>>> 1070:         public Builder title(String title) {
>> 
>> So what about this one ? Are too many tests using it ?
>
> What about them? All the methods in `Builder` return `Builder`, that's perfectly fine.
> 
> The goal of this PR is to make impossible to write
> 
> 
> new PassFailJFrame.Builder();
> 
> 
> which is replaced with
> 
> 
> PassFailJFrame.builder();
> 
> 
> In the former case, the test explicitly depends on the fact that the builder pattern implementation is in the `PassFailJFrame.Builder` class.
> 
> In the latter case, I can change the `builder()` method to return another class. As long as that other class has the same set of methods, like `instructions` and title`, which return the same object, nothing breaks. Encapsulation.
> 
> With this change, all the existing tests continue to run. Those tests which failed to compile because of a breaking API change are updated in this PR.

Never mind. I wasn't reading it properly.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18206#discussion_r1520513514

From prr at openjdk.org  Mon Mar 11 23:07:25 2024
From: prr at openjdk.org (Phil Race)
Date: Mon, 11 Mar 2024 23:07:25 GMT
Subject: RFR: 8327856: Convert applet test SpanishDiacriticsTest.java to a main
 program
Message-ID: <JnPnHUoBMQd1YGVtRimzTC2Y5Sn5ezSWq2Fkw9jh-KA=.8df82997-452b-41c9-a698-68ab33e49f13@github.com>

Converts the  manual applet test in the files ..
SpanishDiacriticsTest/SpanishDiacriticsTest.html
SpanishDiacriticsTest/SpanishDiacriticsTest.java
.. to a main program using PassFailJFrame

Added requires windows since it seems very windows-specific.

I got rid of the redundant extra directory which makes the .java file "new" according to github but it is largely changed anyway

-------------

Commit messages:
 - 8327856

Changes: https://git.openjdk.org/jdk/pull/18208/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18208&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8327856
  Stats: 190 lines in 3 files changed: 93 ins; 97 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18208.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18208/head:pull/18208

PR: https://git.openjdk.org/jdk/pull/18208

From azvegint at openjdk.org  Mon Mar 11 23:18:28 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Mon, 11 Mar 2024 23:18:28 GMT
Subject: RFR: 8327835: Convert
 java/awt/FileDialog/RegexpFilterTest/RegexpFilterTest applet test to main [v2]
In-Reply-To: <O_XrLLXwQtMWjKGEoOaYSM8RdDnyH3LF3-Bdp5PDRHo=.72bb3619-6cfc-43c8-83d6-c87eabf24636@github.com>
References: <O_XrLLXwQtMWjKGEoOaYSM8RdDnyH3LF3-Bdp5PDRHo=.72bb3619-6cfc-43c8-83d6-c87eabf24636@github.com>
Message-ID: <8BxI9OhD7drWcWGzTy22JA6F30UTV-XoyAHaTm-X72s=.d8c57f42-050d-44b8-b6fd-5eca399c8f3a@github.com>

> The `java/awt/FileDialog/RegexpFilterTest/RegexpFilterTest` test is written to test the very specific functionality of `XFileDialogPeer`, so it shouldn't be run on platforms other than Linux.
> 
> We also need to set `sun.awt.disableGtkFileDialogs` to `true` to be able to test `XFileDialogPeer`, because by default it tries to use the Gtk file dialog if it is available.
> The Gtk file dialog has a search field hidden under the magnifying glass icon, but it has a different syntax.
> 
> The Windows system file dialog allows you to use wildcard filtering in the "File name" field by hitting the `enter` afterwards, but again, this test was written to test our own file dialog implementation, not the system's.

Alexander Zvegintsev has updated the pull request incrementally with one additional commit since the last revision:

  better chaining

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18203/files
  - new: https://git.openjdk.org/jdk/pull/18203/files/04f14aef..b43ce26b

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18203&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18203&range=00-01

  Stats: 5 lines in 1 file changed: 0 ins; 2 del; 3 mod
  Patch: https://git.openjdk.org/jdk/pull/18203.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18203/head:pull/18203

PR: https://git.openjdk.org/jdk/pull/18203

From azvegint at openjdk.org  Mon Mar 11 23:18:28 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Mon, 11 Mar 2024 23:18:28 GMT
Subject: RFR: 8327835: Convert
 java/awt/FileDialog/RegexpFilterTest/RegexpFilterTest applet test to main [v2]
In-Reply-To: <3V8ICRRvev5oxT7k8QDL2ZoeTTi-hCYNTWlJIcvsdo0=.833d3917-a5da-416a-bf22-473def7cff1c@github.com>
References: <O_XrLLXwQtMWjKGEoOaYSM8RdDnyH3LF3-Bdp5PDRHo=.72bb3619-6cfc-43c8-83d6-c87eabf24636@github.com>
 <3V8ICRRvev5oxT7k8QDL2ZoeTTi-hCYNTWlJIcvsdo0=.833d3917-a5da-416a-bf22-473def7cff1c@github.com>
Message-ID: <HkiDM-n2Xos5EtigjO5Y3Mp-Vhs4wdGrjl4KTWM-JGs=.0ca001e3-76d3-4e1e-a7b7-868b131d335a@github.com>

On Mon, 11 Mar 2024 21:24:51 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Alexander Zvegintsev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   better chaining
>
> test/jdk/ProblemList.txt line 799:
> 
>> 797: java/awt/TrayIcon/DragEventSource/DragEventSource.java 8252242 macosx-all
>> 798: java/awt/FileDialog/DefaultFocusOwner/DefaultFocusOwner.java 7187728 macosx-all,linux-all
>> 799: java/awt/FileDialog/RegexpFilterTest/RegexpFilterTest.html 7187728 macosx-all,linux-all
> 
> What about [JDK-7187728](https://bugs.openjdk.org/browse/JDK-7187728)? It's still unresolved.

It is still open because there is another non-applet test `java/awt/FileDialog/DefaultFocusOwner/DefaultFocusOwner.java` that needs attention.
Since that test sprint is regarding the elimination of applet tests, it is out of scope.
Hence the new bug id for this test.

[JDK-8327835](https://bugs.openjdk.org/browse/JDK-8327835)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18203#discussion_r1520531854

From azvegint at openjdk.org  Mon Mar 11 23:28:30 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Mon, 11 Mar 2024 23:28:30 GMT
Subject: RFR: 8327838: Convert
 java/awt/FileDialog/MultipleMode/MultipleMode.html applet test to main [v2]
In-Reply-To: <DI0RnXYhvIrM8iYvr6t5rSadWbY_VEnhePX1QnX41dA=.ac99191d-478f-4a09-a941-f9723929634a@github.com>
References: <DI0RnXYhvIrM8iYvr6t5rSadWbY_VEnhePX1QnX41dA=.ac99191d-478f-4a09-a941-f9723929634a@github.com>
Message-ID: <yW_v_dZq1oZPtGMrbPJ029j9EhrqsJNnp8gQaVfcxOc=.a9a37234-46cc-41eb-8020-c8a7e6c01ba8@github.com>

> The test is converted to main.
> Tested on Linux, Macos and Windows.

Alexander Zvegintsev has updated the pull request incrementally with one additional commit since the last revision:

  review comments

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18205/files
  - new: https://git.openjdk.org/jdk/pull/18205/files/d33c3178..a9f8e21b

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18205&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18205&range=00-01

  Stats: 20 lines in 1 file changed: 0 ins; 8 del; 12 mod
  Patch: https://git.openjdk.org/jdk/pull/18205.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18205/head:pull/18205

PR: https://git.openjdk.org/jdk/pull/18205

From azvegint at openjdk.org  Mon Mar 11 23:30:14 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Mon, 11 Mar 2024 23:30:14 GMT
Subject: RFR: 8327838: Convert
 java/awt/FileDialog/MultipleMode/MultipleMode.html applet test to main [v2]
In-Reply-To: <j4jshGS2_rqumN_sLCrumbdH9i5rtLino-m7ajoZYDM=.cfa0a401-16de-4d3d-9580-c72a16d0132a@github.com>
References: <DI0RnXYhvIrM8iYvr6t5rSadWbY_VEnhePX1QnX41dA=.ac99191d-478f-4a09-a941-f9723929634a@github.com>
 <j4jshGS2_rqumN_sLCrumbdH9i5rtLino-m7ajoZYDM=.cfa0a401-16de-4d3d-9580-c72a16d0132a@github.com>
Message-ID: <nCc93NWcIOdX2wrtXFgsF65AgXEFapnrNGdUrde5BWs=.f408297e-7354-4a96-9d9e-f54b1f2854cb@github.com>

On Mon, 11 Mar 2024 21:29:14 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Alexander Zvegintsev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review comments
>
> test/jdk/java/awt/FileDialog/MultipleMode/MultipleMode.java line 1:
> 
>> 1: /*
> 
> Do we move test files when modifying?

I think this is a good time to do it, during such a big refactory.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18205#discussion_r1520541258

From achung at openjdk.org  Tue Mar 12 00:02:13 2024
From: achung at openjdk.org (Alisen Chung)
Date: Tue, 12 Mar 2024 00:02:13 GMT
Subject: RFR: 8327857: Remove applet usage from JColorChooser tests 1
Message-ID: <k-sLqO64HbTaYgimerOjfrS6NdPEYkOW4Wh9u-ln1P4=.fcb4e582-2189-4486-afb4-570cdeed6e69@github.com>

Removing applet usage from manual JColorChooser tests

-------------

Commit messages:
 - delete html
 - init commit

Changes: https://git.openjdk.org/jdk/pull/18209/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18209&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8327857
  Stats: 182 lines in 4 files changed: 40 ins; 101 del; 41 mod
  Patch: https://git.openjdk.org/jdk/pull/18209.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18209/head:pull/18209

PR: https://git.openjdk.org/jdk/pull/18209

From achung at openjdk.org  Tue Mar 12 00:30:09 2024
From: achung at openjdk.org (Alisen Chung)
Date: Tue, 12 Mar 2024 00:30:09 GMT
Subject: RFR: 8327859: Remove applet usage from JColorChooser tests Test4319113
Message-ID: <mzB8yqtVTWIuecXJk5qt1J5Me6iU857a4YMC26xXiyg=.b8fc4e43-3298-4f5c-ab52-8664d30c2d08@github.com>

Removing applet usage from manual JColorChooser tests

-------------

Commit messages:
 - init commit

Changes: https://git.openjdk.org/jdk/pull/18210/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18210&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8327859
  Stats: 104 lines in 2 files changed: 17 ins; 57 del; 30 mod
  Patch: https://git.openjdk.org/jdk/pull/18210.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18210/head:pull/18210

PR: https://git.openjdk.org/jdk/pull/18210

From mark.yagnatinsky at barclays.com  Fri Mar  8 23:43:54 2024
From: mark.yagnatinsky at barclays.com (mark.yagnatinsky at barclays.com)
Date: Fri, 8 Mar 2024 23:43:54 +0000
Subject: how to get find out the keyboard shortcut for the paste
 action?
In-Reply-To: <emb0be8964-a76e-4815-a1aa-19dbefcd2621@dcff66fe.com>
References: <CH3PR12MB76198C4F8B2300D806EDCCF0F9452@CH3PR12MB7619.namprd12.prod.outlook.com>
 <em455be664-76d1-43e4-ba85-729678b34dc6@76ca4640.com>
 <CH3PR12MB7619B0682852C7C836096E84F95C2@CH3PR12MB7619.namprd12.prod.outlook.com>
 <CH3PR12MB76199D23AB541CB4C09118AAF95C2@CH3PR12MB7619.namprd12.prod.outlook.com>
 <emfa5db32b-c08c-4ebc-a061-fc24306fbe93@dcff66fe.com>
 <CH3PR12MB76196E29050B67CD2888B8AEF9232@CH3PR12MB7619.namprd12.prod.outlook.com>
 <8399c796-17e8-4d78-9916-a55054251420@oracle.com>
 <CH3PR12MB7619083DF388D7365B84BB56F9222@CH3PR12MB7619.namprd12.prod.outlook.com>
 <emb0be8964-a76e-4815-a1aa-19dbefcd2621@dcff66fe.com>
Message-ID: <CH3PR12MB76199E07BDA6956180D683ACF9272@CH3PR12MB7619.namprd12.prod.outlook.com>

Turns out that is standardized:
https://docs.oracle.com/javase/8/docs/api/constant-values.html#javax.swing.text.DefaultEditorKit.cutAction

From: Jeremy Wood <mickleness at gmail.com>
Sent: Friday, March 8, 2024 6:40 PM
To: Yagnatinsky, Mark : Markets Pre Trade <mark.yagnatinsky at barclays.com>; alexey.ivanov at oracle.com; client-libs-dev at openjdk.org
Subject: Re[2]: how to get find out the keyboard shortcut for the paste action?


CAUTION: This email originated from outside our organisation - mickleness at gmail.com<mailto:mickleness at gmail.com> Do not click on links, open attachments, or respond unless you recognize the sender and can validate the content is safe.
Alexey,

> Does the input map of JTextArea contain shortcuts for Cut, Copy and Paste?

When I call (on my Mac, using openJDK 17)

UIManager.getDefaults().get("TextArea.focusInputMap?)
? I get an InputMap with: ?copy-to-clipboard?, ?cut-to-clipboard?, and ?paste-from-clipboard?.

The code I tested against is:

InputMap inputMap = (InputMap) UIManager.getDefaults().get("TextArea.focusInputMap");
Map<Object, Collection<KeyStroke>> map = new TreeMap<>();
for (KeyStroke keyStroke : inputMap.keys()) {
    Object key = inputMap.get(keyStroke);
    Collection value = map.get(key);
    if (value == null) {
        value = new HashSet();
        map.put(key, value);
    }
    value.add(keyStroke);
}
for (Map.Entry<Object, Collection<KeyStroke>> e : map.entrySet()) {
    System.out.println(e);
}

Previous tests showed the same naming convention on Windows for JTextFields; I don?t know how standardized that naming convention is across all platforms / L&F?s.

 - Jeremy


------ Original Message ------
From mark.yagnatinsky at barclays.com<mailto:mark.yagnatinsky at barclays.com>
To alexey.ivanov at oracle.com<mailto:alexey.ivanov at oracle.com>; mickleness at gmail.com<mailto:mickleness at gmail.com>; client-libs-dev at openjdk.org<mailto:client-libs-dev at openjdk.org>
Date 3/5/24, 11:48:48?AM
Subject RE: how to get find out the keyboard shortcut for the paste action?

Thanks, this was educational. I never even thought about how localization might affect all this.

-----Original Message-----
From: Aleksei Ivanov <alexey.ivanov at oracle.com<mailto:alexey.ivanov at oracle.com>>
Sent: Tuesday, March 5, 2024 10:41 AM
To: Yagnatinsky, Mark : Markets Pre Trade <mark.yagnatinsky at barclays.com<mailto:mark.yagnatinsky at barclays.com>>; mickleness at gmail.com<mailto:mickleness at gmail.com>; client-libs-dev at openjdk.org<mailto:client-libs-dev at openjdk.org>
Subject: Re: how to get find out the keyboard shortcut for the paste action?


CAUTION: This email originated from outside our organisation - alexey.ivanov at oracle.com<mailto:alexey.ivanov at oracle.com> Do not click on links, open attachments, or respond unless you recognize the sender and can validate the content is safe.
Hello Mark,

As far as I know, the shortcuts are localisable. For example, you use
Ctrl+S to save a file in an English version, yet users of Spanish
version of Windows use Ctrl+G (for Guardar) instead.

At the same time, the most common actions ? Cut, Copy and Paste as well as Undo and Redo ? usually have the same shortcuts across all languages and OS, although macOS uses Cmd instead of Ctrl. However, the shortcut for Redo is not as standard, Ctrl+Shift+Z and Ctrl+Y are used, both could be mapped at the same time.

I wonder what is the shortcut for Undo in German versions since German keyboard layout has Z and Y keys swapped. Does anyone know?

So, the shortcuts used in an application are controlled by the application and the shortcuts can be localised.

For this reason, the shortcuts are usually ?hardcoded?.


@Jeremy
Does the input map of JTextArea contain shortcuts for Cut, Copy and Paste?

On 2024-03-04 20:42, mark.yagnatinsky at barclays.com<mailto:mark.yagnatinsky at barclays.com> wrote:

Thanks!  I don?t have a particularly deep motivation here, other than
curiosity.

If you?re wondering how my curiosity got piqued initially, it was
something like this:

A while ago, someone at work was adding copy/paste support to some
component that didn?t have it.

I noticed that they ?hardcoded? the shortcut ?ctrl C?.

And I thought to myself:

Swing already ?knows? that this is the right keyboard shortcut, in the
sense that all components that support copy/paste ?out of the box? use it.

It would be nice if there was some way to ASK it to tell me what it
?knows?.

*From:* Jeremy Wood <mickleness at gmail.com<mailto:mickleness at gmail.com>>
*Sent:* Sunday, March 3, 2024 11:30 PM
*To:* Yagnatinsky, Mark : Markets Pre Trade
<mark.yagnatinsky at barclays.com<mailto:mark.yagnatinsky at barclays.com>>; client-libs-dev at openjdk.org<mailto:client-libs-dev at openjdk.org>
*Subject:* Re[2]: how to get find out the keyboard shortcut for the
paste action?

CAUTION: This email originated from outside our organisation -
mickleness at gmail.com<mailto:mickleness at gmail.com> Do not click on links, open attachments, or
respond unless you recognize the sender and can validate the content
is safe.

> But now I have a new question?

> Is there any way to get the ?usual? letter for a ?common? operation?

Hmm. Good question. Not that I know of.

> Again, one could create a scratch text area and grovel through its
input map, but that seems hacky.

I agree sifting through the L&F seems hacky.

I don?t think I understand exactly what you?re trying to implement
here. If you give me a more concrete example: maybe I (or someone on
this list) can offer a more concrete suggestion?

I?ll add some context in case this speaks to your question.

By default Swing gets this information in places like
BasicTextUI#getInputMap(), which calls:

InputMap shared=     (InputMap)DefaultLookup./get/(editor, this,
getPropertyPrefix() + ".focusInputMap?);

The following works on my Mac & Windows machine (I think using JDK
19), but I wouldn?t be surprised if it fails in other platforms /
L&F?s. It feels brittle, but it might (?) have potential:

private KeyStroke getCopyKeyStroke() {

InputMap inputMap = (InputMap)
UIManager.getDefaults().get("TextField.focusInputMap"); for (KeyStroke
keyStroke : inputMap.keys()) { Object action =
inputMap.get(keyStroke); if ("copy-to-clipboard".equals(action)) {
return keyStroke;         }     } /// this will show all the default
keystrokes // System.out.println(Arrays.asList(inputMap.allKeys()));
/return null; }

Regards,

 - Jeremy

------ Original Message ------

From mark.yagnatinsky at barclays.com<mailto:mark.yagnatinsky at barclays.com>

To mickleness at gmail.com<mailto:mickleness at gmail.com>; client-libs-dev at openjdk.org<mailto:client-libs-dev at openjdk.org>

Date 3/3/24, 6:00:46?PM

Subject RE: how to get find out the keyboard shortcut for the paste
action?

Thanks for the response!  I didn?t expect to get one at this point
J

It does indeed answer my question!

(Though you didn?t quite get the name right: there?s no Ex at the
end?

I take it you?ve done some Windows programming at some point)

But now I have a new question?

Is there any way to get the ?usual? letter for a ?common? operation?

For instance, lots of programs support copy and paste.

Is there a way to ask Java ?what is the standard letter for paste?
and get back ?V??

Again, one could create a scratch text area and grovel through its
input map, but that seems hacky.

--
Regards,
Alexey

This message is for information purposes only. It is not a recommendation, advice, offer or solicitation to buy or sell a product or service, nor an official confirmation of any transaction. It is directed at persons who are professionals and is intended for the recipient(s) only. It is not directed at retail customers. This message is subject to the terms at: https://www.ib.barclays/disclosures/web-and-email-disclaimer.html<https://clicktime.symantec.com/15t5z4nzQ9mVyiYmXLJWp?h=rugiybCsNVrtvlgv0oiWK531TT-aEC8cdJoNgo0eicA=&u=https://www.ib.barclays/disclosures/web-and-email-disclaimer.html>.

For important disclosures, please see: https://www.ib.barclays/disclosures/sales-and-trading-disclaimer.html<https://clicktime.symantec.com/15t5uEbhwY5uZmiqymuNC?h=UUYilPcbuojDIsLAzJWyu0nJlLCHoCyghR5_RMssH0o=&u=https://www.ib.barclays/disclosures/sales-and-trading-disclaimer.html> regarding marketing commentary from Barclays Sales and/or Trading desks, who are active market participants; https://www.ib.barclays/disclosures/barclays-global-markets-disclosures.html<https://clicktime.symantec.com/15t5ek1rZh38KwF5M6hvL?h=ZDyeQZN-V_95O-lzOTIVWhfaptDBYTvgrAhbCC9UfZU=&u=https://www.ib.barclays/disclosures/barclays-global-markets-disclosures.html> regarding our standard terms for Barclays Investment Bank where we trade with you in principal-to-principal wholesale markets transactions; and in respect to Barclays Research, including disclosures relating to specific issuers, see: http://publicresearch.barclays.com<https://clicktime.symantec.com/15t5Zupa75MXuzR9oYJmi?h=7tVYpwZrUz-9ooO1JlNnWU655b7rnLE_E-tzFWQJPF0=&u=http://publicresearch.barclays.com>.
__________________________________________________________________________________
If you are incorporated or operating in Australia, read these important disclosures: https://www.ib.barclays/disclosures/important-disclosures-asia-pacific.html<https://clicktime.symantec.com/15t5jaD92Jiijt4ztf74x?h=cZIWzy3Q9k2MTdJ-Z3X5bD8POR6nFxCfEHP3mI43Buo=&u=https://www.ib.barclays/disclosures/important-disclosures-asia-pacific.html>.
__________________________________________________________________________________
For more details about how we use personal information, see our privacy notice: https://www.ib.barclays/disclosures/personal-information-use.html<https://clicktime.symantec.com/15t5pQQRUvQK9ptvSDWDa?h=7L8jQPnb4feGYIXIkHVU8obgMQC0JaTkbrYiRZ3xZBo=&u=https://www.ib.barclays/disclosures/personal-information-use.html>.
__________________________________________________________________________________

This message is for information purposes only. It is not a recommendation, advice, offer or solicitation to buy or sell a product or service, nor an official confirmation of any transaction. It is directed at persons who are professionals and is intended for the recipient(s) only. It is not directed at retail customers. This message is subject to the terms at: https://www.ib.barclays/disclosures/web-and-email-disclaimer.html. 

For important disclosures, please see: https://www.ib.barclays/disclosures/sales-and-trading-disclaimer.html regarding marketing commentary from Barclays Sales and/or Trading desks, who are active market participants; https://www.ib.barclays/disclosures/barclays-global-markets-disclosures.html regarding our standard terms for Barclays Investment Bank where we trade with you in principal-to-principal wholesale markets transactions; and in respect to Barclays Research, including disclosures relating to specific issuers, see: http://publicresearch.barclays.com.
__________________________________________________________________________________ 
If you are incorporated or operating in Australia, read these important disclosures: https://www.ib.barclays/disclosures/important-disclosures-asia-pacific.html.
__________________________________________________________________________________
For more details about how we use personal information, see our privacy notice: https://www.ib.barclays/disclosures/personal-information-use.html. 
__________________________________________________________________________________
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/client-libs-dev/attachments/20240308/4734b8e4/attachment-0001.htm>

From achung at openjdk.org  Tue Mar 12 00:37:37 2024
From: achung at openjdk.org (Alisen Chung)
Date: Tue, 12 Mar 2024 00:37:37 GMT
Subject: RFR: 8327859: Remove applet usage from JColorChooser tests
 Test4319113 [v2]
In-Reply-To: <mzB8yqtVTWIuecXJk5qt1J5Me6iU857a4YMC26xXiyg=.b8fc4e43-3298-4f5c-ab52-8664d30c2d08@github.com>
References: <mzB8yqtVTWIuecXJk5qt1J5Me6iU857a4YMC26xXiyg=.b8fc4e43-3298-4f5c-ab52-8664d30c2d08@github.com>
Message-ID: <Y0cNaKroRwoBpY8tdntyaAshMErZt6l180kgZ17fta4=.098e959d-c4a0-4ecb-9257-6cb5aa443c41@github.com>

> Removing applet usage from manual JColorChooser tests

Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:

  fix pfjframe builder styling and jtreg manual tag

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18210/files
  - new: https://git.openjdk.org/jdk/pull/18210/files/a46995a4..b720007d

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18210&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18210&range=00-01

  Stats: 3 lines in 1 file changed: 1 ins; 1 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/18210.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18210/head:pull/18210

PR: https://git.openjdk.org/jdk/pull/18210

From achung at openjdk.org  Tue Mar 12 00:39:26 2024
From: achung at openjdk.org (Alisen Chung)
Date: Tue, 12 Mar 2024 00:39:26 GMT
Subject: RFR: 8327857: Remove applet usage from JColorChooser tests
 Test4222508 [v2]
In-Reply-To: <k-sLqO64HbTaYgimerOjfrS6NdPEYkOW4Wh9u-ln1P4=.fcb4e582-2189-4486-afb4-570cdeed6e69@github.com>
References: <k-sLqO64HbTaYgimerOjfrS6NdPEYkOW4Wh9u-ln1P4=.fcb4e582-2189-4486-afb4-570cdeed6e69@github.com>
Message-ID: <2jj3nqjuevk8X1Ew2lCdYGdP6PVvjJii1QfKkUF0_e4=.dad52d97-0c05-4fe7-984c-b395562722f4@github.com>

> Removing applet usage from manual JColorChooser tests

Alisen Chung has updated the pull request incrementally with five additional commits since the last revision:

 - fix pfjframe builder styling and jtreg manual tag
 - revert spacing
 - revert files
 - restore file
 - revert file

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18209/files
  - new: https://git.openjdk.org/jdk/pull/18209/files/83a839fe..0c45d1cc

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18209&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18209&range=00-01

  Stats: 107 lines in 3 files changed: 58 ins; 18 del; 31 mod
  Patch: https://git.openjdk.org/jdk/pull/18209.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18209/head:pull/18209

PR: https://git.openjdk.org/jdk/pull/18209

From prr at openjdk.org  Tue Mar 12 00:39:27 2024
From: prr at openjdk.org (Phil Race)
Date: Tue, 12 Mar 2024 00:39:27 GMT
Subject: RFR: 8327857: Remove applet usage from JColorChooser tests
 Test4222508 [v2]
In-Reply-To: <2jj3nqjuevk8X1Ew2lCdYGdP6PVvjJii1QfKkUF0_e4=.dad52d97-0c05-4fe7-984c-b395562722f4@github.com>
References: <k-sLqO64HbTaYgimerOjfrS6NdPEYkOW4Wh9u-ln1P4=.fcb4e582-2189-4486-afb4-570cdeed6e69@github.com>
 <2jj3nqjuevk8X1Ew2lCdYGdP6PVvjJii1QfKkUF0_e4=.dad52d97-0c05-4fe7-984c-b395562722f4@github.com>
Message-ID: <5Z5WUM8Xc3vKv-RLWhfOXzIWhdWTFGPap6iMVbgVzag=.3c52f6aa-e9fc-4ae7-85b8-c093e4eeaecc@github.com>

On Tue, 12 Mar 2024 00:35:24 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> Removing applet usage from manual JColorChooser tests
>
> Alisen Chung has updated the pull request incrementally with five additional commits since the last revision:
> 
>  - fix pfjframe builder styling and jtreg manual tag
>  - revert spacing
>  - revert files
>  - restore file
>  - revert file

test/jdk/javax/swing/JColorChooser/Test4222508.java line 35:

> 33:  * @build PassFailJFrame
> 34:  * @summary Tests the color chooser disabling
> 35:  * @run main Test4222508

This needs to specify the test is manual.

test/jdk/javax/swing/JColorChooser/Test4222508.java line 47:

> 45:                 .testTimeOut(10)
> 46:                 .rows(5)
> 47:                 .columns(40)

A style thing but since rows + columns apply to the instruction window I think they should go right after .instructions

test/jdk/javax/swing/JColorChooser/Test4319113.java line 47:

> 45:  * @build PassFailJFrame
> 46:  * @summary Tests the open JColorChooser behavior on LaF change.
> 47:  * @run main Test4319113

This needs to specify the test is manual.

test/jdk/javax/swing/JColorChooser/Test4319113.java line 58:

> 56:                 .testTimeOut(10)
> 57:                 .rows(5)
> 58:                 .columns(40)

same style comment

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18209#discussion_r1520604494
PR Review Comment: https://git.openjdk.org/jdk/pull/18209#discussion_r1520606750
PR Review Comment: https://git.openjdk.org/jdk/pull/18209#discussion_r1520605090
PR Review Comment: https://git.openjdk.org/jdk/pull/18209#discussion_r1520610670

From achung at openjdk.org  Tue Mar 12 00:39:27 2024
From: achung at openjdk.org (Alisen Chung)
Date: Tue, 12 Mar 2024 00:39:27 GMT
Subject: RFR: 8327857: Remove applet usage from JColorChooser tests
 Test4222508 [v2]
In-Reply-To: <5Z5WUM8Xc3vKv-RLWhfOXzIWhdWTFGPap6iMVbgVzag=.3c52f6aa-e9fc-4ae7-85b8-c093e4eeaecc@github.com>
References: <k-sLqO64HbTaYgimerOjfrS6NdPEYkOW4Wh9u-ln1P4=.fcb4e582-2189-4486-afb4-570cdeed6e69@github.com>
 <2jj3nqjuevk8X1Ew2lCdYGdP6PVvjJii1QfKkUF0_e4=.dad52d97-0c05-4fe7-984c-b395562722f4@github.com>
 <5Z5WUM8Xc3vKv-RLWhfOXzIWhdWTFGPap6iMVbgVzag=.3c52f6aa-e9fc-4ae7-85b8-c093e4eeaecc@github.com>
Message-ID: <iJNRQU7f1ls2jc3GnwCG7cX76edmrXw0T9wMLQpFNvM=.da7f6b3d-5278-4549-9570-e4ae831f0d88@github.com>

On Tue, 12 Mar 2024 00:24:11 GMT, Phil Race <prr at openjdk.org> wrote:

>> Alisen Chung has updated the pull request incrementally with five additional commits since the last revision:
>> 
>>  - fix pfjframe builder styling and jtreg manual tag
>>  - revert spacing
>>  - revert files
>>  - restore file
>>  - revert file
>
> test/jdk/javax/swing/JColorChooser/Test4319113.java line 47:
> 
>> 45:  * @build PassFailJFrame
>> 46:  * @summary Tests the open JColorChooser behavior on LaF change.
>> 47:  * @run main Test4319113
> 
> This needs to specify the test is manual.

i've separated the two tests into two separate PRs

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18209#discussion_r1520618967

From psadhukhan at openjdk.org  Tue Mar 12 02:47:25 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Tue, 12 Mar 2024 02:47:25 GMT
Subject: RFR: 8327750: Convert
 javax/swing/JFileChooser/FileFilterDescription/FileFilterDescription.java
 applet test to main [v2]
In-Reply-To: <Fri2USQ-lXz_OJYx4o2lhB5twAsUnaOn8R2ylmurMSk=.1c9502c4-a43b-4137-854c-25040beb0593@github.com>
References: <Fri2USQ-lXz_OJYx4o2lhB5twAsUnaOn8R2ylmurMSk=.1c9502c4-a43b-4137-854c-25040beb0593@github.com>
Message-ID: <EkY__SHfzUZxe_hCwbGswIXd_JlVRfucwuTHshh39FA=.902e5584-9dae-4ccf-a55e-818976f0eb6b@github.com>

> Conversion of manual applet test to main based using PassFailJFrame manual framework

Prasanta Sadhukhan has updated the pull request incrementally with two additional commits since the last revision:

 - Review comment update
 - Review comment update

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18182/files
  - new: https://git.openjdk.org/jdk/pull/18182/files/3c0f1be9..7c2ce443

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18182&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18182&range=00-01

  Stats: 5 lines in 1 file changed: 1 ins; 2 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/18182.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18182/head:pull/18182

PR: https://git.openjdk.org/jdk/pull/18182

From psadhukhan at openjdk.org  Tue Mar 12 02:47:25 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Tue, 12 Mar 2024 02:47:25 GMT
Subject: RFR: 8327750: Convert
 javax/swing/JFileChooser/FileFilterDescription/FileFilterDescription.java
 applet test to main [v2]
In-Reply-To: <PVxqkPm-hVEP6vWDCuTyVZo6YbbByuc0U1nV_eAUIAU=.d5b36c8c-3344-4aa4-8ec3-620b4e749298@github.com>
References: <Fri2USQ-lXz_OJYx4o2lhB5twAsUnaOn8R2ylmurMSk=.1c9502c4-a43b-4137-854c-25040beb0593@github.com>
 <PVxqkPm-hVEP6vWDCuTyVZo6YbbByuc0U1nV_eAUIAU=.d5b36c8c-3344-4aa4-8ec3-620b4e749298@github.com>
Message-ID: <GCkYA732vfCwP_CojCvaEVxDWZ3n2_LatVU648W1GPg=.f9026f50-9410-4da0-9ce6-08c6d72ce416@github.com>

On Mon, 11 Mar 2024 14:27:09 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Prasanta Sadhukhan has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Review comment update
>>  - Review comment update
>
> test/jdk/javax/swing/JFileChooser/FileFilterDescription/FileFilterDescription.java line 70:
> 
>> 68:                 PassFailJFrame.addTestWindow(frame);
>> 69:                 PassFailJFrame.positionTestWindow(frame, PassFailJFrame.Position.TOP_LEFT_CORNER);
>> 70:                 frame.pack();
> 
> You should call `pack()` before positioning the frame, otherwise the frame won't be positioned correctly.

Updated...

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18182#discussion_r1520763715

From psadhukhan at openjdk.org  Tue Mar 12 02:49:25 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Tue, 12 Mar 2024 02:49:25 GMT
Subject: RFR: 8327748: Convert
 javax/swing/JFileChooser/6798062/bug6798062.java applet test to main [v3]
In-Reply-To: <lGQbwCvyqdtOr8-NxY9l3pZC4mRPn7gBtd7qPIRPF-I=.0379a965-6ad2-44ba-abfe-ecd0ed3f7b02@github.com>
References: <lGQbwCvyqdtOr8-NxY9l3pZC4mRPn7gBtd7qPIRPF-I=.0379a965-6ad2-44ba-abfe-ecd0ed3f7b02@github.com>
Message-ID: <S7B9SumsKmtgNCkT9j8t8_wPVBZe05ZPg7V0MbDVSy4=.9dca42c1-76df-45b0-9d82-c9571168c8b5@github.com>

> Conversion of manual applet test to main based using PassFailJFrame manual framework

Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:

  Review comment update

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18180/files
  - new: https://git.openjdk.org/jdk/pull/18180/files/0c8ae3a0..71d387b5

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18180&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18180&range=01-02

  Stats: 38 lines in 1 file changed: 1 ins; 12 del; 25 mod
  Patch: https://git.openjdk.org/jdk/pull/18180.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18180/head:pull/18180

PR: https://git.openjdk.org/jdk/pull/18180

From psadhukhan at openjdk.org  Tue Mar 12 02:49:25 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Tue, 12 Mar 2024 02:49:25 GMT
Subject: RFR: 8327748: Convert
 javax/swing/JFileChooser/6798062/bug6798062.java applet test to main [v2]
In-Reply-To: <vYHYNqFM9TxU6kj7U8dLqSDkScGMPn9GtYpCB_TEbYM=.799c3cb1-87cb-4737-9c0b-5fbf59b16987@github.com>
References: <lGQbwCvyqdtOr8-NxY9l3pZC4mRPn7gBtd7qPIRPF-I=.0379a965-6ad2-44ba-abfe-ecd0ed3f7b02@github.com>
 <WbNziLuyDum0qdGJnLB5bDVKUbYaU5E3OT9IqYQOIpo=.e1bc048b-4fe8-4ea7-979a-1e6481788c47@github.com>
 <vYHYNqFM9TxU6kj7U8dLqSDkScGMPn9GtYpCB_TEbYM=.799c3cb1-87cb-4737-9c0b-5fbf59b16987@github.com>
Message-ID: <nl9IEtFyhTK0szc_R42NquqXScA4P_tBkTVm_s0hjrw=.2e0076b5-2a1d-4fcb-8835-4a47c4101dc0@github.com>

On Mon, 11 Mar 2024 14:52:04 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   typo
>
> test/jdk/javax/swing/JFileChooser/6798062/bug6798062.java line 78:
> 
>> 76: 
>> 77:     public static void main(String[] args) throws Exception {
>> 78:          PassFailJFrame passFailJFrame = new PassFailJFrame.Builder()
> 
> Please use the `builder` helper method instead of `new`.

Updated...

> test/jdk/javax/swing/JFileChooser/6798062/bug6798062.java line 86:
> 
>> 84:                 .build();
>> 85: 
>> 86:         SwingUtilities.invokeAndWait(() -> {
> 
> I suggest using the `testUI` method of the builder which accepts a lambda expression that returns a frame. Calling the passed method reference or lambda expression on EDT, registering the frame with `PassFailJFrame` and its positioning is handled automatically.

ok..updated...

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18180#discussion_r1520765177
PR Review Comment: https://git.openjdk.org/jdk/pull/18180#discussion_r1520765007

From psadhukhan at openjdk.org  Tue Mar 12 02:51:48 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Tue, 12 Mar 2024 02:51:48 GMT
Subject: RFR: 8327751: Convert
 javax/swing/JInternalFrame/6726866/bug6726866.java applet test to main [v2]
In-Reply-To: <C5clTEn-okNdD5RVu8jcJW8T9bluj4GTy7BDNxUwKy0=.6b278225-50fa-4714-a066-8ad465cd9766@github.com>
References: <C5clTEn-okNdD5RVu8jcJW8T9bluj4GTy7BDNxUwKy0=.6b278225-50fa-4714-a066-8ad465cd9766@github.com>
Message-ID: <euEaxFEAEu2TZbcfeDeT5BjHlzvv6Kt-Y47BOFLMKDI=.26d6b611-bdd2-44e2-817f-62780e135060@github.com>

> Conversion of manual applet test to main based using PassFailJFrame manual framework

Prasanta Sadhukhan has updated the pull request incrementally with two additional commits since the last revision:

 - Review comment update
 - Review comment update

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18186/files
  - new: https://git.openjdk.org/jdk/pull/18186/files/ad5564c4..14679ff1

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18186&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18186&range=00-01

  Stats: 28 lines in 1 file changed: 4 ins; 5 del; 19 mod
  Patch: https://git.openjdk.org/jdk/pull/18186.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18186/head:pull/18186

PR: https://git.openjdk.org/jdk/pull/18186

From psadhukhan at openjdk.org  Tue Mar 12 02:51:48 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Tue, 12 Mar 2024 02:51:48 GMT
Subject: RFR: 8327751: Convert
 javax/swing/JInternalFrame/6726866/bug6726866.java applet test to main [v2]
In-Reply-To: <gQ7iFjVbMGzz8I_PD_-buikRJD9NVoQKMqLt4ubD5bo=.84d1cb08-726d-4811-8cd8-bdc4fb9c0a64@github.com>
References: <C5clTEn-okNdD5RVu8jcJW8T9bluj4GTy7BDNxUwKy0=.6b278225-50fa-4714-a066-8ad465cd9766@github.com>
 <gQ7iFjVbMGzz8I_PD_-buikRJD9NVoQKMqLt4ubD5bo=.84d1cb08-726d-4811-8cd8-bdc4fb9c0a64@github.com>
Message-ID: <1VpDe74cAPS6coz2SknpH-iO7K1rEb3hXwXvBJdjT04=.741b2e0c-05cc-4db2-b370-59982f4c82b2@github.com>

On Mon, 11 Mar 2024 14:52:57 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Prasanta Sadhukhan has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Review comment update
>>  - Review comment update
>
> test/jdk/javax/swing/JInternalFrame/6726866/bug6726866.java line 51:
> 
>> 49: 
>> 50:     public static void main(String[] args) throws Exception {
>> 51:         PassFailJFrame passFailJFrame = new PassFailJFrame.Builder()
> 
> Please use the `builder` helper method instead of using `new` explicitly.

updated...

> test/jdk/javax/swing/JInternalFrame/6726866/bug6726866.java line 54:
> 
>> 52:                 .title("JInternalFrame Instructions")
>> 53:                 .instructions(instructionsText)
>> 54:                 .testTimeOut(5)
> 
> The default timeout can be omitted.

ok

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18186#discussion_r1520766343
PR Review Comment: https://git.openjdk.org/jdk/pull/18186#discussion_r1520766184

From tr at openjdk.org  Tue Mar 12 03:21:12 2024
From: tr at openjdk.org (Tejesh R)
Date: Tue, 12 Mar 2024 03:21:12 GMT
Subject: RFR: 8327787: Convert javax/swing/border/Test4129681.java applet
 test to main [v2]
In-Reply-To: <V49lTP8E-b9kaY3gCayVeVhnH2klEk_ITEL-JR2ZvjQ=.100c4270-7ae6-4a53-b0ec-db0d2beb39a1@github.com>
References: <uZ3hGgyIWuMOTp6qSVNw_3r-F4REh4QvrzqAtH8fMo8=.e55e311d-c0d7-4863-9e8a-0d1edc1d8857@github.com>
 <4X4wbMQLitT4ayAenjHb1g11517tv6pcTceWQBDdzlo=.a08d04f8-d49f-4b89-8d8e-7538d105a53f@github.com>
 <V49lTP8E-b9kaY3gCayVeVhnH2klEk_ITEL-JR2ZvjQ=.100c4270-7ae6-4a53-b0ec-db0d2beb39a1@github.com>
Message-ID: <zJF8MFEbdfpUxnw0sgmbcwECK2cBocyg2XBUjJx7tKY=.6a811626-e2d2-463b-9ecb-88c7889c56bf@github.com>

On Mon, 11 Mar 2024 14:59:43 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Tejesh R has updated the pull request incrementally with three additional commits since the last revision:
>> 
>>  - Review updates
>>  - Review updates
>>  - Updates
>
> test/jdk/javax/swing/border/Test4129681.java line 41:
> 
>> 39: 
>> 40: public class Test4129681 {
>> 41:     private static JLabel label;
> 
> The `label` does not need to be global, it can be confined to `init`.

Its been used inside `itemListener`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18189#discussion_r1520795726

From tr at openjdk.org  Tue Mar 12 03:29:26 2024
From: tr at openjdk.org (Tejesh R)
Date: Tue, 12 Mar 2024 03:29:26 GMT
Subject: RFR: 8327787: Convert javax/swing/border/Test4129681.java applet
 test to main [v3]
In-Reply-To: <uZ3hGgyIWuMOTp6qSVNw_3r-F4REh4QvrzqAtH8fMo8=.e55e311d-c0d7-4863-9e8a-0d1edc1d8857@github.com>
References: <uZ3hGgyIWuMOTp6qSVNw_3r-F4REh4QvrzqAtH8fMo8=.e55e311d-c0d7-4863-9e8a-0d1edc1d8857@github.com>
Message-ID: <ORgFggDMzuMJm7m9p0A8azZtJOYe9_fkWl7pzsAtmDs=.6d5bab60-4629-4317-bfce-533aa30894e2@github.com>

> Convert javax/swing/border/Test4129681.java applet test to main based test using PassFailJFrame.

Tejesh R has updated the pull request incrementally with one additional commit since the last revision:

  Review updates

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18189/files
  - new: https://git.openjdk.org/jdk/pull/18189/files/d76714e8..e77cb0cc

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18189&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18189&range=01-02

  Stats: 15 lines in 1 file changed: 5 ins; 2 del; 8 mod
  Patch: https://git.openjdk.org/jdk/pull/18189.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18189/head:pull/18189

PR: https://git.openjdk.org/jdk/pull/18189

From tr at openjdk.org  Tue Mar 12 03:48:37 2024
From: tr at openjdk.org (Tejesh R)
Date: Tue, 12 Mar 2024 03:48:37 GMT
Subject: RFR: 8327826: Convert javax/swing/border/Test4243289.java applet
 test to main [v2]
In-Reply-To: <M5kMa3NPTVyzBZK7rPRT_gAHTQgVjPY_in-ZZJ8i1zM=.f1def8d8-79cd-4b03-88d2-4016a937d08d@github.com>
References: <M5kMa3NPTVyzBZK7rPRT_gAHTQgVjPY_in-ZZJ8i1zM=.f1def8d8-79cd-4b03-88d2-4016a937d08d@github.com>
Message-ID: <TeZ9JpatV5DGUzWuoAe5X6qVtZ9mDS73oiM5vMIO3aQ=.3baa9c76-48eb-45d4-815a-1998bdd0aef5@github.com>

> Convert javax/swing/border/Test4243289.java applet test to main based test using PassFailJFrame.

Tejesh R has updated the pull request incrementally with one additional commit since the last revision:

  Review updates - splitUI

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18197/files
  - new: https://git.openjdk.org/jdk/pull/18197/files/c0c109a6..458b55fc

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18197&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18197&range=00-01

  Stats: 28 lines in 1 file changed: 5 ins; 8 del; 15 mod
  Patch: https://git.openjdk.org/jdk/pull/18197.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18197/head:pull/18197

PR: https://git.openjdk.org/jdk/pull/18197

From tr at openjdk.org  Tue Mar 12 03:48:37 2024
From: tr at openjdk.org (Tejesh R)
Date: Tue, 12 Mar 2024 03:48:37 GMT
Subject: RFR: 8327826: Convert javax/swing/border/Test4243289.java applet
 test to main [v2]
In-Reply-To: <9KzJQOh_Bn-wPhoA2_vMhHfAjXxNALG6KkJHAQE0NMg=.1d9c6cc5-597c-4ad5-8d51-99dd92621a9f@github.com>
References: <M5kMa3NPTVyzBZK7rPRT_gAHTQgVjPY_in-ZZJ8i1zM=.f1def8d8-79cd-4b03-88d2-4016a937d08d@github.com>
 <9KzJQOh_Bn-wPhoA2_vMhHfAjXxNALG6KkJHAQE0NMg=.1d9c6cc5-597c-4ad5-8d51-99dd92621a9f@github.com>
Message-ID: <IeWTBmXk-zNKXSoY2VEq38nrq0yUIEjtNBRENImpBa0=.dd3851c8-3793-40fa-8c9f-73a5b42a6fdf@github.com>

On Mon, 11 Mar 2024 19:30:15 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review updates - splitUI
>
> test/jdk/javax/swing/border/Test4243289.java line 77:
> 
>> 75:         frame.setSize(300, 300);
>> 76:         PassFailJFrame.addTestWindow(frame);
>> 77:         PassFailJFrame.positionTestWindow(frame, PassFailJFrame.Position.TOP_LEFT_CORNER);
> 
> Any particular reason why top left corner is used instead of centered-positioning?

Nothing particular, anyhow I have used spiltUI now.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18197#discussion_r1520809453

From tr at openjdk.org  Tue Mar 12 03:54:12 2024
From: tr at openjdk.org (Tejesh R)
Date: Tue, 12 Mar 2024 03:54:12 GMT
Subject: RFR: 8327750: Convert
 javax/swing/JFileChooser/FileFilterDescription/FileFilterDescription.java
 applet test to main [v2]
In-Reply-To: <EkY__SHfzUZxe_hCwbGswIXd_JlVRfucwuTHshh39FA=.902e5584-9dae-4ccf-a55e-818976f0eb6b@github.com>
References: <Fri2USQ-lXz_OJYx4o2lhB5twAsUnaOn8R2ylmurMSk=.1c9502c4-a43b-4137-854c-25040beb0593@github.com>
 <EkY__SHfzUZxe_hCwbGswIXd_JlVRfucwuTHshh39FA=.902e5584-9dae-4ccf-a55e-818976f0eb6b@github.com>
Message-ID: <IoCnMRSZPW3cLwHL8qpDOQ94BlZW_-5RqecAXa1Jhe0=.e2f57c32-c8eb-4498-8e79-297b14b46748@github.com>

On Tue, 12 Mar 2024 02:47:25 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Conversion of manual applet test to main based using PassFailJFrame manual framework
>
> Prasanta Sadhukhan has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Review comment update
>  - Review comment update

test/jdk/javax/swing/JFileChooser/FileFilterDescription/FileFilterDescription.java line 53:

> 51:                 .instructions(INSTRUCTIONS)
> 52:                 .rows(10)
> 53:                 .columns(35)

I guess testUI and awaitAndCheck can be used here only.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18182#discussion_r1520812289

From tr at openjdk.org  Tue Mar 12 05:21:19 2024
From: tr at openjdk.org (Tejesh R)
Date: Tue, 12 Mar 2024 05:21:19 GMT
Subject: RFR: 8327838: Convert
 java/awt/FileDialog/MultipleMode/MultipleMode.html applet test to main [v2]
In-Reply-To: <yW_v_dZq1oZPtGMrbPJ029j9EhrqsJNnp8gQaVfcxOc=.a9a37234-46cc-41eb-8020-c8a7e6c01ba8@github.com>
References: <DI0RnXYhvIrM8iYvr6t5rSadWbY_VEnhePX1QnX41dA=.ac99191d-478f-4a09-a941-f9723929634a@github.com>
 <yW_v_dZq1oZPtGMrbPJ029j9EhrqsJNnp8gQaVfcxOc=.a9a37234-46cc-41eb-8020-c8a7e6c01ba8@github.com>
Message-ID: <sgiE9ec8eeQVEi8AsQr89JqWt2U1HW0UFKZNlC2JRjs=.3b4e4821-950e-471a-a22d-c061d8534b8a@github.com>

On Mon, 11 Mar 2024 23:28:30 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>> The test is converted to main.
>> Tested on Linux, Macos and Windows.
>
> Alexander Zvegintsev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   review comments

test/jdk/java/awt/FileDialog/MultipleMode.java line 63:

> 61:             .instructions(INSTRUCTIONS)
> 62:             .rows(15)
> 63:             .columns(40)

column size can be reduced based on the test instructions.

test/jdk/java/awt/FileDialog/MultipleMode.java line 101:

> 99:         frame.add(sysout, BorderLayout.CENTER);
> 100: 
> 101:         frame.pack();

Frame size is too big and going out of the screen, might fix a size here.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18205#discussion_r1520865593
PR Review Comment: https://git.openjdk.org/jdk/pull/18205#discussion_r1520864787

From tr at openjdk.org  Tue Mar 12 05:26:14 2024
From: tr at openjdk.org (Tejesh R)
Date: Tue, 12 Mar 2024 05:26:14 GMT
Subject: RFR: 8327859: Remove applet usage from JColorChooser tests
 Test4319113 [v2]
In-Reply-To: <Y0cNaKroRwoBpY8tdntyaAshMErZt6l180kgZ17fta4=.098e959d-c4a0-4ecb-9257-6cb5aa443c41@github.com>
References: <mzB8yqtVTWIuecXJk5qt1J5Me6iU857a4YMC26xXiyg=.b8fc4e43-3298-4f5c-ab52-8664d30c2d08@github.com>
 <Y0cNaKroRwoBpY8tdntyaAshMErZt6l180kgZ17fta4=.098e959d-c4a0-4ecb-9257-6cb5aa443c41@github.com>
Message-ID: <jRNFRpTpsK41ejbiTyQlFQmPphYg7jcLeAQhpIBPIvs=.fc513a7c-1b59-4bf8-ad61-ce56e9ed22e1@github.com>

On Tue, 12 Mar 2024 00:37:37 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> Removing applet usage from manual JColorChooser tests
>
> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fix pfjframe builder styling and jtreg manual tag

test/jdk/javax/swing/JColorChooser/Test4319113.java line 53:

> 51:         PassFailJFrame.builder()
> 52:                 .title("Test4319113")
> 53:                 .instructions("Choose a LaF using the dropdown. Click on the Show JColorChooser button.\n" +

I feel its better to use a separate String variable for Test instructions and then use it here.

test/jdk/javax/swing/JColorChooser/Test4319113.java line 65:

> 63: 
> 64:     private static JFrame test() {
> 65:         JFrame frame = new JFrame("Test4319113");

Title can be something like "JColorChooser behavior test".

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18210#discussion_r1520870884
PR Review Comment: https://git.openjdk.org/jdk/pull/18210#discussion_r1520869172

From tr at openjdk.org  Tue Mar 12 05:29:13 2024
From: tr at openjdk.org (Tejesh R)
Date: Tue, 12 Mar 2024 05:29:13 GMT
Subject: RFR: 8327859: Remove applet usage from JColorChooser tests
 Test4319113 [v2]
In-Reply-To: <Y0cNaKroRwoBpY8tdntyaAshMErZt6l180kgZ17fta4=.098e959d-c4a0-4ecb-9257-6cb5aa443c41@github.com>
References: <mzB8yqtVTWIuecXJk5qt1J5Me6iU857a4YMC26xXiyg=.b8fc4e43-3298-4f5c-ab52-8664d30c2d08@github.com>
 <Y0cNaKroRwoBpY8tdntyaAshMErZt6l180kgZ17fta4=.098e959d-c4a0-4ecb-9257-6cb5aa443c41@github.com>
Message-ID: <j7XVRXZlMjaiy6o8SHbvpO-g3m8QdsTDx6dArZ-818M=.48501025-0dd8-4814-85c4-af511179ee1d@github.com>

On Tue, 12 Mar 2024 00:37:37 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> Removing applet usage from manual JColorChooser tests
>
> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fix pfjframe builder styling and jtreg manual tag

test/jdk/javax/swing/JColorChooser/Test4319113.java line 44:

> 42:  * @test
> 43:  * @bug 4319113
> 44:  * @library /test/jdk/java/awt/regtesthelpers /test/lib

Any reason why /test/lib is used here?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18210#discussion_r1520872616

From abhiscxk at openjdk.org  Tue Mar 12 05:40:14 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Tue, 12 Mar 2024 05:40:14 GMT
Subject: RFR: 8327872: Convert javax/swing/JToolTip/4644444/bug4644444.java
 applet test to main
Message-ID: <gQj8exwWxjXFUAyXBGVxxXeflmLCCUQJ8flxhU22-7I=.75d72581-8868-4dc4-9736-af6e54dbe3ca@github.com>

Conversion of manual applet test to main based using PassFailJFrame manual framework

-------------

Commit messages:
 - Whitespace fix
 -  Applet test converted to manual main based

Changes: https://git.openjdk.org/jdk/pull/18212/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18212&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8327872
  Stats: 369 lines in 2 files changed: 0 ins; 331 del; 38 mod
  Patch: https://git.openjdk.org/jdk/pull/18212.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18212/head:pull/18212

PR: https://git.openjdk.org/jdk/pull/18212

From tr at openjdk.org  Tue Mar 12 06:07:31 2024
From: tr at openjdk.org (Tejesh R)
Date: Tue, 12 Mar 2024 06:07:31 GMT
Subject: RFR: 8327873: Convert javax/swing/border/Test4247606.java applet test
 to main
Message-ID: <wHX-Mo2XWPKls-WPhv6L7m1xdtKWQF40Nr-U9rjGxqw=.7f21fa24-8bc3-4c36-8132-408fe1372e60@github.com>

Convert javax/swing/border/Test4247606.java applet test to main based test using PassFailJFrame.

-------------

Commit messages:
 - Conversion from Applet to Main

Changes: https://git.openjdk.org/jdk/pull/18213/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18213&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8327873
  Stats: 79 lines in 2 files changed: 33 ins; 41 del; 5 mod
  Patch: https://git.openjdk.org/jdk/pull/18213.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18213/head:pull/18213

PR: https://git.openjdk.org/jdk/pull/18213

From abhiscxk at openjdk.org  Tue Mar 12 06:48:20 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Tue, 12 Mar 2024 06:48:20 GMT
Subject: RFR: 8327874: Convert javax/swing/JTree/4314199/bug4314199.java applet
 test to main
Message-ID: <4HQ5z1My4A9Qcac-1K9Y9sTf7dqWpxrJtdIgSxC1vro=.41a923c6-8607-4c95-8c6f-8a6c5ed1504f@github.com>

Conversion of manual applet test to main based using PassFailJFrame manual framework

-------------

Commit messages:
 - Applet based test converted to main manual

Changes: https://git.openjdk.org/jdk/pull/18215/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18215&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8327874
  Stats: 79 lines in 2 files changed: 18 ins; 41 del; 20 mod
  Patch: https://git.openjdk.org/jdk/pull/18215.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18215/head:pull/18215

PR: https://git.openjdk.org/jdk/pull/18215

From tr at openjdk.org  Tue Mar 12 07:00:35 2024
From: tr at openjdk.org (Tejesh R)
Date: Tue, 12 Mar 2024 07:00:35 GMT
Subject: RFR: 8327876: Convert javax/swing/border/Test4252164.java applet test
 to main
Message-ID: <Nc7KlfEEQnoms0Ja9qgzfbVjkrWbZXjkcfU1pL6XdU0=.6fa50ee3-8610-43b3-8b3f-913f40281a5e@github.com>

Convert javax/swing/border/Test4252164.java applet test to main based test using PassFailJFrame.

-------------

Commit messages:
 - Conversion from Applet to Main

Changes: https://git.openjdk.org/jdk/pull/18216/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18216&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8327876
  Stats: 81 lines in 2 files changed: 14 ins; 44 del; 23 mod
  Patch: https://git.openjdk.org/jdk/pull/18216.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18216/head:pull/18216

PR: https://git.openjdk.org/jdk/pull/18216

From tr at openjdk.org  Tue Mar 12 07:40:21 2024
From: tr at openjdk.org (Tejesh R)
Date: Tue, 12 Mar 2024 07:40:21 GMT
Subject: RFR: 8327879: Convert javax/swing/border/Test4760089.java applet test
 to main
Message-ID: <Vq0kXwaE6TFmJzGmgpo13OA3VEqSnqsjQpDpGZj2ob4=.4f188f8b-5581-4774-8345-76363b4e3cf6@github.com>

Convert javax/swing/border/Test4760089.java applet test to main based test using PassFailJFrame.

-------------

Commit messages:
 - Conversion from Applet to Main

Changes: https://git.openjdk.org/jdk/pull/18217/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18217&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8327879
  Stats: 72 lines in 2 files changed: 26 ins; 35 del; 11 mod
  Patch: https://git.openjdk.org/jdk/pull/18217.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18217/head:pull/18217

PR: https://git.openjdk.org/jdk/pull/18217

From mkartashev at openjdk.org  Tue Mar 12 08:18:20 2024
From: mkartashev at openjdk.org (Maxim Kartashev)
Date: Tue, 12 Mar 2024 08:18:20 GMT
Subject: Integrated: 8326497: Window.toFront() fails for iconified windows on
 Linux
In-Reply-To: <XmMRoFNpTDQHCZLnmmnNGVjhR2Ib3yw1kWc0v57utUM=.e418325c-7b23-4298-8f75-e81d369b5afc@github.com>
References: <XmMRoFNpTDQHCZLnmmnNGVjhR2Ib3yw1kWc0v57utUM=.e418325c-7b23-4298-8f75-e81d369b5afc@github.com>
Message-ID: <o2t6iHiN9qaWdt-ReqDjuuW2IxyW2DCPJ5gBZxC1xfY=.e47e81e9-502b-459d-b05a-92a76f62ec7a@github.com>

On Fri, 23 Feb 2024 15:58:18 GMT, Maxim Kartashev <mkartashev at openjdk.org> wrote:

> XToolkit implements `toFront()` essentially by sending the  `_NET_ACTIVE_WINDOW` message to activate the window. This has no effect when the target window is in the iconified state. So the fix is to cancel that state prior to sending the message.
> 
> The test verifies that the fix works for maximized and undecorated frames as well out of abundance of caution; they do not represent a special case from the `toFront()` standpoint.
> 
> References
> * `_NET_ACTIVE_WINDOW`: https://specifications.freedesktop.org/wm-spec/1.3/ar01s03.html
> * [Inter-Client Communication Conventions Manual, 4.1.4. Changing Window State](https://tronche.com/gui/x/icccm/sec-4.html#s-4.1.4)

This pull request has now been integrated.

Changeset: 139681a7
Author:    Maxim Kartashev <mkartashev at openjdk.org>
Committer: Alexey Ushakov <avu at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/139681a7eb7a0a1207f66e72095766983e7b717b
Stats:     124 lines in 3 files changed: 122 ins; 0 del; 2 mod

8326497: Window.toFront() fails for iconified windows on Linux

Reviewed-by: tr, prr

-------------

PR: https://git.openjdk.org/jdk/pull/17985

From aivanov at openjdk.org  Tue Mar 12 08:38:22 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 12 Mar 2024 08:38:22 GMT
Subject: RFR: 8327924: Simplify TrayIconScalingTest.java
Message-ID: <v4lDY1J2WCp2RqxfYXNYImaEx5EOeX2x4LM23n93Zrs=.010ab607-ba30-484d-b293-460ed4444b1a@github.com>

This is to simplify `TrayIconScalingTest.java`.

1. Rename `createAndShowGUI` to `createAndShowTrayIcon` which is more specific.
2. Move creating tray icon to the top.
3. Streamline PassFailJFrame with the chained calls, including `awaitAndCheck`.
4. Ensure tray is not null before removing the icon.
5. Pass AWTException as the cause in the wrapped exception.

Previously, before the builder pattern was introduced, `PassFailJFrame.positionTestWindow` had had to be called to show the instructions UI. It's not required any more. Additionally, it has the effect of moving the instruction frame to the left, which doesn't look good and sometimes results in positioning the instructions outside of the screen bounds if the screen resolution is low.

With the builder pattern, the call to the `build` method shows all the registered windows on the screen, including the instruction frame. Since there's no secondary UI, the instructions remain in the centre of the screen.

-------------

Depends on: https://git.openjdk.org/jdk/pull/18206

Commit messages:
 - Pass AWTException as the cause in the wrapped exception
 - Re-arrange the code in TrayIconScalingTest.java

Changes: https://git.openjdk.org/jdk/pull/18224/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18224&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8327924
  Stats: 27 lines in 1 file changed: 10 ins; 11 del; 6 mod
  Patch: https://git.openjdk.org/jdk/pull/18224.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18224/head:pull/18224

PR: https://git.openjdk.org/jdk/pull/18224

From kizune at openjdk.org  Tue Mar 12 08:49:14 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Tue, 12 Mar 2024 08:49:14 GMT
Subject: RFR: 8316388: Opensource five Swing component related regression
 tests
In-Reply-To: <Wz8nlNpeWgJKwr9Keb8ydCDT0mn6Q1bdR4CK50zCPZ8=.f39e7e08-9ec2-472a-9c19-6ecaad9b1f04@github.com>
References: <bk66ojURFnGqahRv9IYAhgumqNGFFMOfRkMUzjkIAqI=.9a8c6550-f6d1-4ee2-b53b-54dc6491ff0e@github.com>
 <Wz8nlNpeWgJKwr9Keb8ydCDT0mn6Q1bdR4CK50zCPZ8=.f39e7e08-9ec2-472a-9c19-6ecaad9b1f04@github.com>
Message-ID: <rUm-kOKAOHaPEQV2BfxmaYHQNd3rEu_IP5CrT7pSz2w=.6f9c023b-8ed8-4a8a-9667-57092c3b14a8@github.com>

On Mon, 11 Mar 2024 13:46:23 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Clean up five more tests.
>> 
>> test/jdk/javax/swing/JDesktopPane/4132993/bug4132993.java
>> test/jdk/javax/swing/JDesktopPane/4773378/bug4773378.java
>> test/jdk/javax/swing/JEditorPane/4325606/bug4325606.java
>> test/jdk/javax/swing/JEditorPane/4330998/bug4330998.java
>> test/jdk/javax/swing/JEditorPane/4694598/FrameContent.html
>> test/jdk/javax/swing/JEditorPane/4694598/bug4694598.java
>
> test/jdk/javax/swing/JDesktopPane/4132993/bug4132993.java line 47:
> 
>> 45:             } catch (PropertyVetoException ex) {
>> 46:                 ex.printStackTrace();
>> 47:             }
> 
> Shouldn't the test fail if an unexpected exception is thrown?

It is not unexpected but instead of failing i think test should just pass. Which will happen because the internal frame is not minimized so the test condition is not recreated.

> test/jdk/javax/swing/JDesktopPane/4132993/bug4132993.java line 59:
> 
>> 57:             throw new RuntimeException("Test interrupted by "
>> 58:                     + e.getLocalizedMessage());
>> 59:         }
> 
> You can add `throws Exception` clause to the `main` method and remove this `catch` block.

Ok.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18184#discussion_r1521066921
PR Review Comment: https://git.openjdk.org/jdk/pull/18184#discussion_r1521067257

From aivanov at openjdk.org  Tue Mar 12 08:51:13 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 12 Mar 2024 08:51:13 GMT
Subject: RFR: 8327826: Convert javax/swing/border/Test4243289.java applet
 test to main [v2]
In-Reply-To: <TeZ9JpatV5DGUzWuoAe5X6qVtZ9mDS73oiM5vMIO3aQ=.3baa9c76-48eb-45d4-815a-1998bdd0aef5@github.com>
References: <M5kMa3NPTVyzBZK7rPRT_gAHTQgVjPY_in-ZZJ8i1zM=.f1def8d8-79cd-4b03-88d2-4016a937d08d@github.com>
 <TeZ9JpatV5DGUzWuoAe5X6qVtZ9mDS73oiM5vMIO3aQ=.3baa9c76-48eb-45d4-815a-1998bdd0aef5@github.com>
Message-ID: <y789HVmsg1rmnwyKAx5XqvvBpPkhiR_PoG_18mEUc1Q=.26aed0d9-bde0-48d3-81bc-a5b6bb457a48@github.com>

On Tue, 12 Mar 2024 03:48:37 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Convert javax/swing/border/Test4243289.java applet test to main based test using PassFailJFrame.
>
> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review updates - splitUI

Changes requested by aivanov (Reviewer).

test/jdk/javax/swing/border/Test4243289.java line 44:

> 42:     public static void main(String[] args) throws Exception {
> 43:         String testInstructions = """
> 44:                 If TiltedBorder with title "Panel Title" is overstriken with

Suggestion:

                If TitledBorder with title "Panel Title" is overstruck with

Typo in the border class name; _?overstriken?_ is a rare form, more standard form is _?overstruck?_, see Wiktionary [entry for ?overstrike?](https://en.wiktionary.org/wiki/overstrike#Verb), other dictionaries agree.

test/jdk/javax/swing/border/Test4243289.java line 59:

> 57: 
> 58:     public static JComponent init() {
> 59:         Font font = new Font("Dialog", Font.PLAIN, 12); // NON-NLS: the font name

Suggestion:

        Font font = new Font(Font.DIALOG, Font.PLAIN, 12);

I suggest using the constant. The test may have been written before this constant became available.

test/jdk/javax/swing/border/Test4243289.java line 74:

> 72:         main.add(Box.createVerticalGlue());
> 73:         main.add(panel);
> 74:         main.add(Box.createVerticalGlue());

Suggestion:

        main.add(panel);

The glue isn't needed here, the panel handles resizing well.

-------------

PR Review: https://git.openjdk.org/jdk/pull/18197#pullrequestreview-1930429030
PR Review Comment: https://git.openjdk.org/jdk/pull/18197#discussion_r1521066252
PR Review Comment: https://git.openjdk.org/jdk/pull/18197#discussion_r1521068946
PR Review Comment: https://git.openjdk.org/jdk/pull/18197#discussion_r1521067546

From aivanov at openjdk.org  Tue Mar 12 09:03:16 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 12 Mar 2024 09:03:16 GMT
Subject: RFR: 8327787: Convert javax/swing/border/Test4129681.java applet
 test to main [v2]
In-Reply-To: <zJF8MFEbdfpUxnw0sgmbcwECK2cBocyg2XBUjJx7tKY=.6a811626-e2d2-463b-9ecb-88c7889c56bf@github.com>
References: <uZ3hGgyIWuMOTp6qSVNw_3r-F4REh4QvrzqAtH8fMo8=.e55e311d-c0d7-4863-9e8a-0d1edc1d8857@github.com>
 <4X4wbMQLitT4ayAenjHb1g11517tv6pcTceWQBDdzlo=.a08d04f8-d49f-4b89-8d8e-7538d105a53f@github.com>
 <V49lTP8E-b9kaY3gCayVeVhnH2klEk_ITEL-JR2ZvjQ=.100c4270-7ae6-4a53-b0ec-db0d2beb39a1@github.com>
 <zJF8MFEbdfpUxnw0sgmbcwECK2cBocyg2XBUjJx7tKY=.6a811626-e2d2-463b-9ecb-88c7889c56bf@github.com>
Message-ID: <sQab091tfNOqTUtNPAPZX4hYhGh2-_R3OQHg6meimac=.ff910c54-b9c4-473e-9306-d42db15e7e76@github.com>

On Tue, 12 Mar 2024 03:18:15 GMT, Tejesh R <tr at openjdk.org> wrote:

>> test/jdk/javax/swing/border/Test4129681.java line 41:
>> 
>>> 39: 
>>> 40: public class Test4129681 {
>>> 41:     private static JLabel label;
>> 
>> The `label` does not need to be global, it can be confined to `init`.
>
> Its been used inside `itemListener`.

I guess it was needed but now it's not; so it's better to clean this up.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18189#discussion_r1521088159

From kizune at openjdk.org  Tue Mar 12 09:05:17 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Tue, 12 Mar 2024 09:05:17 GMT
Subject: RFR: 8316388: Opensource five Swing component related regression
 tests
In-Reply-To: <Wz8nlNpeWgJKwr9Keb8ydCDT0mn6Q1bdR4CK50zCPZ8=.f39e7e08-9ec2-472a-9c19-6ecaad9b1f04@github.com>
References: <bk66ojURFnGqahRv9IYAhgumqNGFFMOfRkMUzjkIAqI=.9a8c6550-f6d1-4ee2-b53b-54dc6491ff0e@github.com>
 <Wz8nlNpeWgJKwr9Keb8ydCDT0mn6Q1bdR4CK50zCPZ8=.f39e7e08-9ec2-472a-9c19-6ecaad9b1f04@github.com>
Message-ID: <TsbWXpNEfDOdyQ_1opNjH9LySOsVOU2lcM7xZJ60eYA=.74e9988c-beb6-4388-b263-5db0f1edc98a@github.com>

On Mon, 11 Mar 2024 13:51:47 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Clean up five more tests.
>> 
>> test/jdk/javax/swing/JDesktopPane/4132993/bug4132993.java
>> test/jdk/javax/swing/JDesktopPane/4773378/bug4773378.java
>> test/jdk/javax/swing/JEditorPane/4325606/bug4325606.java
>> test/jdk/javax/swing/JEditorPane/4330998/bug4330998.java
>> test/jdk/javax/swing/JEditorPane/4694598/FrameContent.html
>> test/jdk/javax/swing/JEditorPane/4694598/bug4694598.java
>
> test/jdk/javax/swing/JDesktopPane/4773378/bug4773378.java line 69:
> 
>> 67:                         keyTyped = true;
>> 68:                         bug4773378.this.notifyAll();
>> 69:                     }
> 
> A `CountDownLatch` would work great in this case.
> 
> And `keyTyped` is a confusing name for a flag which gets to `true` when the internal frame is activated.

Renamed as frameActivated

> test/jdk/javax/swing/JDesktopPane/4773378/bug4773378.java line 85:
> 
>> 83:     public void performTest() {
>> 84:         try {
>> 85:             jif.setSelected(true);
> 
> This should be called via `SwingUtilities.invokeLater` on EDT.

Fixed

> test/jdk/javax/swing/JDesktopPane/4773378/bug4773378.java line 102:
> 
>> 100:         } catch (Throwable t) {
>> 101:             t.printStackTrace();
>> 102:         }
> 
> A `Throwable` should fail the test, it must be propagated.

Fixed.

> test/jdk/javax/swing/JEditorPane/4694598/FrameContent.html line 1:
> 
>> 1: <HTML><BODY>
> 
> Can this file be created by the test on the fly? There's no need for a supporting file.
> 
> In #18147, Prasanta handled the same situation.

I prefer to keep things simpler and not to create an additional possible point of failure. The supporting html file is self-explanatory and, if needed, can be changed outside of fixing the test itself.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18184#discussion_r1521088031
PR Review Comment: https://git.openjdk.org/jdk/pull/18184#discussion_r1521088346
PR Review Comment: https://git.openjdk.org/jdk/pull/18184#discussion_r1521088621
PR Review Comment: https://git.openjdk.org/jdk/pull/18184#discussion_r1521092628

From aivanov at openjdk.org  Tue Mar 12 09:12:16 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 12 Mar 2024 09:12:16 GMT
Subject: RFR: 8327787: Convert javax/swing/border/Test4129681.java applet
 test to main [v3]
In-Reply-To: <ORgFggDMzuMJm7m9p0A8azZtJOYe9_fkWl7pzsAtmDs=.6d5bab60-4629-4317-bfce-533aa30894e2@github.com>
References: <uZ3hGgyIWuMOTp6qSVNw_3r-F4REh4QvrzqAtH8fMo8=.e55e311d-c0d7-4863-9e8a-0d1edc1d8857@github.com>
 <ORgFggDMzuMJm7m9p0A8azZtJOYe9_fkWl7pzsAtmDs=.6d5bab60-4629-4317-bfce-533aa30894e2@github.com>
Message-ID: <L7-TgsTwqrbKoxKxqJeqri8-YxExWulqv1yqE1C52uM=.2df29ec5-1235-458c-8f72-8a0fc60d7424@github.com>

On Tue, 12 Mar 2024 03:29:26 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Convert javax/swing/border/Test4129681.java applet test to main based test using PassFailJFrame.
>
> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review updates

Changes requested by aivanov (Reviewer).

test/jdk/javax/swing/border/Test4129681.java line 61:

> 59: 
> 60:     public static JComponent init() {
> 61:         JCheckBox check = new JCheckBox("Enable/Disable");

Suggestion:

        JLable label = new JLabel("message");
        JCheckBox check = new JCheckBox("Enable/Disable");

And then both are local variables which you can use in lambda expressions.

test/jdk/javax/swing/border/Test4129681.java line 75:

> 73:         main.add(Box.createVerticalStrut(4));
> 74:         main.add(label);
> 75:         main.add(Box.createVerticalGlue());

A `JPanel` with `BorderLayout` works better here, you can fill the area with the `JLabel`:
Suggestion:

        JPanel main = new JPanel(new BorderLayout());
        main.setBorder(BorderFactory.createEmptyBorder(8, 8, 8, 8));
        main.add(check, BorderLayout.NORTH);
        main.add(label, BorderLayout.CENTER);

-------------

PR Review: https://git.openjdk.org/jdk/pull/18189#pullrequestreview-1930479454
PR Review Comment: https://git.openjdk.org/jdk/pull/18189#discussion_r1521101975
PR Review Comment: https://git.openjdk.org/jdk/pull/18189#discussion_r1521099890

From kizune at openjdk.org  Tue Mar 12 09:38:15 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Tue, 12 Mar 2024 09:38:15 GMT
Subject: RFR: 8316388: Opensource five Swing component related regression
 tests
In-Reply-To: <bk66ojURFnGqahRv9IYAhgumqNGFFMOfRkMUzjkIAqI=.9a8c6550-f6d1-4ee2-b53b-54dc6491ff0e@github.com>
References: <bk66ojURFnGqahRv9IYAhgumqNGFFMOfRkMUzjkIAqI=.9a8c6550-f6d1-4ee2-b53b-54dc6491ff0e@github.com>
Message-ID: <PhNQ1C_THcjABeR2F3S3qgS7gcGbXgqrXw4UHjRj7yc=.6465bdd3-f135-47bb-abcc-463150d919a3@github.com>

On Mon, 11 Mar 2024 09:41:47 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

> Clean up five more tests.
> 
> test/jdk/javax/swing/JDesktopPane/4132993/bug4132993.java
> test/jdk/javax/swing/JDesktopPane/4773378/bug4773378.java
> test/jdk/javax/swing/JEditorPane/4325606/bug4325606.java
> test/jdk/javax/swing/JEditorPane/4330998/bug4330998.java
> test/jdk/javax/swing/JEditorPane/4694598/FrameContent.html
> test/jdk/javax/swing/JEditorPane/4694598/bug4694598.java

I would prefer to keep the directory structure - it does not make any difference after al and sometimes makes test logs more readable.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18184#issuecomment-1991170522

From kizune at openjdk.org  Tue Mar 12 09:38:17 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Tue, 12 Mar 2024 09:38:17 GMT
Subject: RFR: 8316388: Opensource five Swing component related regression
 tests
In-Reply-To: <Wz8nlNpeWgJKwr9Keb8ydCDT0mn6Q1bdR4CK50zCPZ8=.f39e7e08-9ec2-472a-9c19-6ecaad9b1f04@github.com>
References: <bk66ojURFnGqahRv9IYAhgumqNGFFMOfRkMUzjkIAqI=.9a8c6550-f6d1-4ee2-b53b-54dc6491ff0e@github.com>
 <Wz8nlNpeWgJKwr9Keb8ydCDT0mn6Q1bdR4CK50zCPZ8=.f39e7e08-9ec2-472a-9c19-6ecaad9b1f04@github.com>
Message-ID: <IYvpD5CDXISexiUc_HvgS0tPV7_QaCDg3xhycvm-aWw=.30787b55-2119-400d-9fed-d8a4b0c3257e@github.com>

On Mon, 11 Mar 2024 14:12:33 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Clean up five more tests.
>> 
>> test/jdk/javax/swing/JDesktopPane/4132993/bug4132993.java
>> test/jdk/javax/swing/JDesktopPane/4773378/bug4773378.java
>> test/jdk/javax/swing/JEditorPane/4325606/bug4325606.java
>> test/jdk/javax/swing/JEditorPane/4330998/bug4330998.java
>> test/jdk/javax/swing/JEditorPane/4694598/FrameContent.html
>> test/jdk/javax/swing/JEditorPane/4694598/bug4694598.java
>
> test/jdk/javax/swing/JEditorPane/4694598/bug4694598.java line 29:
> 
>> 27:  * @summary JEditor pane throws NullPointerException on mouse movement.
>> 28:  * @library ../../regtesthelpers
>> 29:  * @build JRobot
> 
> The test doesn't seem to use any of the extended functionality provided by JRobot, so the standard `java.awt.Robot` can be used instead.

I do not see any harm in using JRobot, it is a Swing test after all.

> test/jdk/javax/swing/JEditorPane/4694598/bug4694598.java line 40:
> 
>> 38: 
>> 39: public class bug4694598 {
>> 40:     JFrame frame = null;
> 
> Suggestion:
> 
>     JFrame frame;
> 
> `null` is the default value any way.

Ok.

> test/jdk/javax/swing/JEditorPane/4694598/bug4694598.java line 81:
> 
>> 79:             try {
>> 80:                 Thread.sleep(50);
>> 81:             } catch (InterruptedException ex) {}
> 
> Suggestion:
> 
>             jRobo.delay(50);

Fixed.

> test/jdk/javax/swing/JEditorPane/4694598/bug4694598.java line 93:
> 
>> 91: 
>> 92:     public static void main(String args[]) throws InterruptedException,
>> 93:             InvocationTargetException {
> 
> Suggestion:
> 
>     public static void main(String[] args) throws Exception {
> 
> Java-style array declaration, shortened `throws` clause.

Switched the array declaration but i would prefer to keep all the exceptions listed in the main method declaration.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18184#discussion_r1521142437
PR Review Comment: https://git.openjdk.org/jdk/pull/18184#discussion_r1521141637
PR Review Comment: https://git.openjdk.org/jdk/pull/18184#discussion_r1521139604
PR Review Comment: https://git.openjdk.org/jdk/pull/18184#discussion_r1521136603

From aivanov at openjdk.org  Tue Mar 12 09:40:15 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 12 Mar 2024 09:40:15 GMT
Subject: RFR: 8327835: Convert
 java/awt/FileDialog/RegexpFilterTest/RegexpFilterTest applet test to main [v2]
In-Reply-To: <8BxI9OhD7drWcWGzTy22JA6F30UTV-XoyAHaTm-X72s=.d8c57f42-050d-44b8-b6fd-5eca399c8f3a@github.com>
References: <O_XrLLXwQtMWjKGEoOaYSM8RdDnyH3LF3-Bdp5PDRHo=.72bb3619-6cfc-43c8-83d6-c87eabf24636@github.com>
 <8BxI9OhD7drWcWGzTy22JA6F30UTV-XoyAHaTm-X72s=.d8c57f42-050d-44b8-b6fd-5eca399c8f3a@github.com>
Message-ID: <TqXVSz6aPOB4bIYCC3x0DTG5BpTZnDz4HWuPKYe5GLw=.8386e3cf-d49f-40e5-a3fa-71c5c3f6388b@github.com>

On Mon, 11 Mar 2024 23:18:28 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>> The `java/awt/FileDialog/RegexpFilterTest/RegexpFilterTest` test is written to test the very specific functionality of `XFileDialogPeer`, so it shouldn't be run on platforms other than Linux.
>> 
>> We also need to set `sun.awt.disableGtkFileDialogs` to `true` to be able to test `XFileDialogPeer`, because by default it tries to use the Gtk file dialog if it is available.
>> The Gtk file dialog has a search field hidden under the magnifying glass icon, but it has a different syntax.
>> 
>> The Windows system file dialog allows you to use wildcard filtering in the "File name" field by hitting the `enter` afterwards, but again, this test was written to test our own file dialog implementation, not the system's.
>
> Alexander Zvegintsev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   better chaining

Changes requested by aivanov (Reviewer).

test/jdk/java/awt/FileDialog/RegexpFilterTest.java line 59:

> 57: 
> 58:     public static void main(String[] args) throws Exception {
> 59:         new PassFailJFrame.Builder()

Suggestion:

        PassFailJFrame.builder()

Please, use the helper method `builder()` instead of instantiating the `Builder` class explicitly.

-------------

PR Review: https://git.openjdk.org/jdk/pull/18203#pullrequestreview-1930546191
PR Review Comment: https://git.openjdk.org/jdk/pull/18203#discussion_r1521143484

From aivanov at openjdk.org  Tue Mar 12 09:44:17 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 12 Mar 2024 09:44:17 GMT
Subject: RFR: 8327835: Convert
 java/awt/FileDialog/RegexpFilterTest/RegexpFilterTest applet test to main [v2]
In-Reply-To: <8BxI9OhD7drWcWGzTy22JA6F30UTV-XoyAHaTm-X72s=.d8c57f42-050d-44b8-b6fd-5eca399c8f3a@github.com>
References: <O_XrLLXwQtMWjKGEoOaYSM8RdDnyH3LF3-Bdp5PDRHo=.72bb3619-6cfc-43c8-83d6-c87eabf24636@github.com>
 <8BxI9OhD7drWcWGzTy22JA6F30UTV-XoyAHaTm-X72s=.d8c57f42-050d-44b8-b6fd-5eca399c8f3a@github.com>
Message-ID: <FzHsnYGuIw4XGRHaEZb_SDWVOGimTTDYreZBfT6FX6c=.1ce60844-0acd-4a6a-bbfa-bbe5fdd15632@github.com>

On Mon, 11 Mar 2024 23:18:28 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>> The `java/awt/FileDialog/RegexpFilterTest/RegexpFilterTest` test is written to test the very specific functionality of `XFileDialogPeer`, so it shouldn't be run on platforms other than Linux.
>> 
>> We also need to set `sun.awt.disableGtkFileDialogs` to `true` to be able to test `XFileDialogPeer`, because by default it tries to use the Gtk file dialog if it is available.
>> The Gtk file dialog has a search field hidden under the magnifying glass icon, but it has a different syntax.
>> 
>> The Windows system file dialog allows you to use wildcard filtering in the "File name" field by hitting the `enter` afterwards, but again, this test was written to test our own file dialog implementation, not the system's.
>
> Alexander Zvegintsev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   better chaining

Changes requested by aivanov (Reviewer).

test/jdk/java/awt/FileDialog/RegexpFilterTest.java line 65:

> 63:                     JButton show = new JButton("show");
> 64:                     show.addActionListener(e ->
> 65:                             new FileDialog(new Frame()).setVisible(true));

Suggestion:

                            new FileDialog((Frame) null).setVisible(true));

There's no meaningful owner, `null` should do. Alternatively, you can find the top level owner of the `show` button, but I don't think it's worth the effort.

-------------

PR Review: https://git.openjdk.org/jdk/pull/18203#pullrequestreview-1930557050
PR Review Comment: https://git.openjdk.org/jdk/pull/18203#discussion_r1521150843

From tr at openjdk.org  Tue Mar 12 09:44:20 2024
From: tr at openjdk.org (Tejesh R)
Date: Tue, 12 Mar 2024 09:44:20 GMT
Subject: RFR: 8327787: Convert javax/swing/border/Test4129681.java applet
 test to main [v2]
In-Reply-To: <sQab091tfNOqTUtNPAPZX4hYhGh2-_R3OQHg6meimac=.ff910c54-b9c4-473e-9306-d42db15e7e76@github.com>
References: <uZ3hGgyIWuMOTp6qSVNw_3r-F4REh4QvrzqAtH8fMo8=.e55e311d-c0d7-4863-9e8a-0d1edc1d8857@github.com>
 <4X4wbMQLitT4ayAenjHb1g11517tv6pcTceWQBDdzlo=.a08d04f8-d49f-4b89-8d8e-7538d105a53f@github.com>
 <V49lTP8E-b9kaY3gCayVeVhnH2klEk_ITEL-JR2ZvjQ=.100c4270-7ae6-4a53-b0ec-db0d2beb39a1@github.com>
 <zJF8MFEbdfpUxnw0sgmbcwECK2cBocyg2XBUjJx7tKY=.6a811626-e2d2-463b-9ecb-88c7889c56bf@github.com>
 <sQab091tfNOqTUtNPAPZX4hYhGh2-_R3OQHg6meimac=.ff910c54-b9c4-473e-9306-d42db15e7e76@github.com>
Message-ID: <KljFPjsoWHmtBzjf8tUfHsygGENOVK-Cts3bG5nzKG4=.13462f93-109c-4868-8076-815439b95098@github.com>

On Tue, 12 Mar 2024 09:00:23 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Its been used inside `itemListener`.
>
> I guess it was needed but now it's not; so it's better to clean this up.

Yeah, will do it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18189#discussion_r1521152598

From tr at openjdk.org  Tue Mar 12 09:47:37 2024
From: tr at openjdk.org (Tejesh R)
Date: Tue, 12 Mar 2024 09:47:37 GMT
Subject: RFR: 8327787: Convert javax/swing/border/Test4129681.java applet
 test to main [v4]
In-Reply-To: <uZ3hGgyIWuMOTp6qSVNw_3r-F4REh4QvrzqAtH8fMo8=.e55e311d-c0d7-4863-9e8a-0d1edc1d8857@github.com>
References: <uZ3hGgyIWuMOTp6qSVNw_3r-F4REh4QvrzqAtH8fMo8=.e55e311d-c0d7-4863-9e8a-0d1edc1d8857@github.com>
Message-ID: <M9iPASdsgS4F4Y7z1nwaIu9qKwmSgm_gHY0U8EYi2U0=.f82229d4-ebf5-4dd4-890e-050216283943@github.com>

> Convert javax/swing/border/Test4129681.java applet test to main based test using PassFailJFrame.

Tejesh R has updated the pull request incrementally with one additional commit since the last revision:

  Review updates

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18189/files
  - new: https://git.openjdk.org/jdk/pull/18189/files/e77cb0cc..bc78d143

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18189&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18189&range=02-03

  Stats: 8 lines in 1 file changed: 1 ins; 7 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18189.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18189/head:pull/18189

PR: https://git.openjdk.org/jdk/pull/18189

From aivanov at openjdk.org  Tue Mar 12 09:51:15 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 12 Mar 2024 09:51:15 GMT
Subject: RFR: 8327838: Convert
 java/awt/FileDialog/MultipleMode/MultipleMode.html applet test to main [v2]
In-Reply-To: <sgiE9ec8eeQVEi8AsQr89JqWt2U1HW0UFKZNlC2JRjs=.3b4e4821-950e-471a-a22d-c061d8534b8a@github.com>
References: <DI0RnXYhvIrM8iYvr6t5rSadWbY_VEnhePX1QnX41dA=.ac99191d-478f-4a09-a941-f9723929634a@github.com>
 <yW_v_dZq1oZPtGMrbPJ029j9EhrqsJNnp8gQaVfcxOc=.a9a37234-46cc-41eb-8020-c8a7e6c01ba8@github.com>
 <sgiE9ec8eeQVEi8AsQr89JqWt2U1HW0UFKZNlC2JRjs=.3b4e4821-950e-471a-a22d-c061d8534b8a@github.com>
Message-ID: <qHUq3OEr1q4IJe2m08KcrB3_VvNnDjnuYjZikrKgo88=.7c14872b-f36b-4ca6-98e3-f8ce23972cb4@github.com>

On Tue, 12 Mar 2024 05:17:31 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Alexander Zvegintsev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review comments
>
> test/jdk/java/awt/FileDialog/MultipleMode.java line 101:
> 
>> 99:         frame.add(sysout, BorderLayout.CENTER);
>> 100: 
>> 101:         frame.pack();
> 
> Frame size is too big and going out of the screen, might fix a size here.

It doesn't fit on the screen of my VM either.

One way to resolve this problem is to add

            .position(PassFailJFrame.Position.TOP_LEFT_CORNER)

to `PassFailJFrame` builder as there's no easy way to move the instruction frame to the left so that both frames fit on the screen.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18205#discussion_r1521162323

From tr at openjdk.org  Tue Mar 12 09:53:43 2024
From: tr at openjdk.org (Tejesh R)
Date: Tue, 12 Mar 2024 09:53:43 GMT
Subject: RFR: 8327826: Convert javax/swing/border/Test4243289.java applet
 test to main [v3]
In-Reply-To: <M5kMa3NPTVyzBZK7rPRT_gAHTQgVjPY_in-ZZJ8i1zM=.f1def8d8-79cd-4b03-88d2-4016a937d08d@github.com>
References: <M5kMa3NPTVyzBZK7rPRT_gAHTQgVjPY_in-ZZJ8i1zM=.f1def8d8-79cd-4b03-88d2-4016a937d08d@github.com>
Message-ID: <5j-kUmJAGV9tEZBTNWCCUAYbQCdYbkS2aT4smyVjqe4=.61f56bc7-0389-4182-9b5a-6d06b676cdea@github.com>

> Convert javax/swing/border/Test4243289.java applet test to main based test using PassFailJFrame.

Tejesh R has updated the pull request incrementally with one additional commit since the last revision:

  Review updates

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18197/files
  - new: https://git.openjdk.org/jdk/pull/18197/files/458b55fc..9077a872

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18197&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18197&range=01-02

  Stats: 5 lines in 1 file changed: 0 ins; 2 del; 3 mod
  Patch: https://git.openjdk.org/jdk/pull/18197.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18197/head:pull/18197

PR: https://git.openjdk.org/jdk/pull/18197

From psadhukhan at openjdk.org  Tue Mar 12 09:55:22 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Tue, 12 Mar 2024 09:55:22 GMT
Subject: Integrated: 8326606: Test
 javax/swing/text/BoxView/6494356/bug6494356.java performs a synchronization on
 a value based class
In-Reply-To: <8VnEO3HS6wKX45a3tokydw_aTorFic1acaSiIqm4-7A=.58457c31-1969-47d9-9c1e-365bba1b7174@github.com>
References: <8VnEO3HS6wKX45a3tokydw_aTorFic1acaSiIqm4-7A=.58457c31-1969-47d9-9c1e-365bba1b7174@github.com>
Message-ID: <l1GS9FfYY27VZiD8HDDWyGOWMbOEjn9Flawrv2zdhv8=.f782eb1f-3740-42fc-aac9-62a709dec269@github.com>

On Thu, 7 Mar 2024 03:16:20 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> OPensource BoxView test

This pull request has now been integrated.

Changeset: 013aff87
Author:    Prasanta Sadhukhan <psadhukhan at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/013aff87ce7ece5cd4676aa452557ea3f222cede
Stats:     135 lines in 1 file changed: 135 ins; 0 del; 0 mod

8326606: Test javax/swing/text/BoxView/6494356/bug6494356.java performs a synchronization on a value based class

Reviewed-by: tr, aivanov

-------------

PR: https://git.openjdk.org/jdk/pull/18147

From tr at openjdk.org  Tue Mar 12 09:56:44 2024
From: tr at openjdk.org (Tejesh R)
Date: Tue, 12 Mar 2024 09:56:44 GMT
Subject: RFR: 8327879: Convert javax/swing/border/Test4760089.java applet
 test to main [v2]
In-Reply-To: <Vq0kXwaE6TFmJzGmgpo13OA3VEqSnqsjQpDpGZj2ob4=.4f188f8b-5581-4774-8345-76363b4e3cf6@github.com>
References: <Vq0kXwaE6TFmJzGmgpo13OA3VEqSnqsjQpDpGZj2ob4=.4f188f8b-5581-4774-8345-76363b4e3cf6@github.com>
Message-ID: <md1FNnWLW56N0Ucpj-BSxyVKz1FXVcJjHo5_8_uzOV8=.9db4b144-5f94-47ba-b837-23a7c33f6e9f@github.com>

> Convert javax/swing/border/Test4760089.java applet test to main based test using PassFailJFrame.

Tejesh R has updated the pull request incrementally with one additional commit since the last revision:

  Review updates

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18217/files
  - new: https://git.openjdk.org/jdk/pull/18217/files/4490174c..689c9091

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18217&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18217&range=00-01

  Stats: 3 lines in 1 file changed: 0 ins; 2 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/18217.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18217/head:pull/18217

PR: https://git.openjdk.org/jdk/pull/18217

From aivanov at openjdk.org  Tue Mar 12 09:59:14 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 12 Mar 2024 09:59:14 GMT
Subject: RFR: 8327838: Convert
 java/awt/FileDialog/MultipleMode/MultipleMode.html applet test to main [v2]
In-Reply-To: <yW_v_dZq1oZPtGMrbPJ029j9EhrqsJNnp8gQaVfcxOc=.a9a37234-46cc-41eb-8020-c8a7e6c01ba8@github.com>
References: <DI0RnXYhvIrM8iYvr6t5rSadWbY_VEnhePX1QnX41dA=.ac99191d-478f-4a09-a941-f9723929634a@github.com>
 <yW_v_dZq1oZPtGMrbPJ029j9EhrqsJNnp8gQaVfcxOc=.a9a37234-46cc-41eb-8020-c8a7e6c01ba8@github.com>
Message-ID: <ZWvRNK2VMl7Kc0F7s36S5xlGR9umYYnE0qBSIbePM9g=.c9207405-088e-429a-b2ae-1940b2f24126@github.com>

On Mon, 11 Mar 2024 23:28:30 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>> The test is converted to main.
>> Tested on Linux, Macos and Windows.
>
> Alexander Zvegintsev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   review comments

Looks good to me.

Yet I left a couple of suggestions.

test/jdk/java/awt/FileDialog/MultipleMode.java line 74:

> 72:         sysout.setEditable(false);
> 73: 
> 74:         final Checkbox mode = new Checkbox("multiple", true);

Does it make sense to leave the checkbox unselected, provided the instructions start with unselect the _Multiple_ checkbox (turn off)?

test/jdk/java/awt/FileDialog/MultipleMode.java line 90:

> 88:             for (File f : d.getFiles()) {
> 89:                 sysout.append("  %s\n".formatted(f));
> 90:             }

If you like you can replace the for-loop with functional-style stream:
Suggestion:

            sysout.append("FILES:\n");
            sysout.append(Arrays.stream(d.getFiles())
                                .map("  %s\n"::formatted)
                                .collect(Collectors.joining()));

-------------

Marked as reviewed by aivanov (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18205#pullrequestreview-1930590396
PR Review Comment: https://git.openjdk.org/jdk/pull/18205#discussion_r1521173947
PR Review Comment: https://git.openjdk.org/jdk/pull/18205#discussion_r1521172060

From tr at openjdk.org  Tue Mar 12 10:01:25 2024
From: tr at openjdk.org (Tejesh R)
Date: Tue, 12 Mar 2024 10:01:25 GMT
Subject: RFR: 8327873: Convert javax/swing/border/Test4247606.java applet
 test to main [v2]
In-Reply-To: <wHX-Mo2XWPKls-WPhv6L7m1xdtKWQF40Nr-U9rjGxqw=.7f21fa24-8bc3-4c36-8132-408fe1372e60@github.com>
References: <wHX-Mo2XWPKls-WPhv6L7m1xdtKWQF40Nr-U9rjGxqw=.7f21fa24-8bc3-4c36-8132-408fe1372e60@github.com>
Message-ID: <UYnE3LP5gu-GW9KkT6DzW2ZoO_XWodi4-j3w0HS97tM=.43755923-c415-4074-a97a-5328bc2f31c6@github.com>

> Convert javax/swing/border/Test4247606.java applet test to main based test using PassFailJFrame.

Tejesh R has updated the pull request incrementally with one additional commit since the last revision:

  Review updates

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18213/files
  - new: https://git.openjdk.org/jdk/pull/18213/files/8d7c3236..22f73583

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18213&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18213&range=00-01

  Stats: 4 lines in 1 file changed: 0 ins; 2 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/18213.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18213/head:pull/18213

PR: https://git.openjdk.org/jdk/pull/18213

From tr at openjdk.org  Tue Mar 12 10:06:19 2024
From: tr at openjdk.org (Tejesh R)
Date: Tue, 12 Mar 2024 10:06:19 GMT
Subject: RFR: 8327872: Convert javax/swing/JToolTip/4644444/bug4644444.java
 applet test to main
In-Reply-To: <gQj8exwWxjXFUAyXBGVxxXeflmLCCUQJ8flxhU22-7I=.75d72581-8868-4dc4-9736-af6e54dbe3ca@github.com>
References: <gQj8exwWxjXFUAyXBGVxxXeflmLCCUQJ8flxhU22-7I=.75d72581-8868-4dc4-9736-af6e54dbe3ca@github.com>
Message-ID: <SqocsgM1nPezAN2BSwFPkbOy62IlWYyVpVimaCMqqos=.4f16ac01-9577-41d0-a911-47d59ff3a723@github.com>

On Tue, 12 Mar 2024 05:33:40 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

> Conversion of manual applet test to main based using PassFailJFrame manual framework

test/jdk/javax/swing/JToolTip/4644444/bug4644444.java line 46:

> 44: 
> 45:     private static JFrame frame;
> 46:     private static JButton button;

Both frame and button can be inside `creatUI()`. If you can use `splitUI` instead of `testUI` that would be even better.

test/jdk/javax/swing/JToolTip/4644444/bug4644444.java line 64:

> 62:         frame.getContentPane().add(button);
> 63:         frame.setSize(200, 80);
> 64:         frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);

`frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE); `Not required.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18212#discussion_r1521184513
PR Review Comment: https://git.openjdk.org/jdk/pull/18212#discussion_r1521185597

From tr at openjdk.org  Tue Mar 12 10:08:13 2024
From: tr at openjdk.org (Tejesh R)
Date: Tue, 12 Mar 2024 10:08:13 GMT
Subject: RFR: 8327874: Convert javax/swing/JTree/4314199/bug4314199.java
 applet test to main
In-Reply-To: <4HQ5z1My4A9Qcac-1K9Y9sTf7dqWpxrJtdIgSxC1vro=.41a923c6-8607-4c95-8c6f-8a6c5ed1504f@github.com>
References: <4HQ5z1My4A9Qcac-1K9Y9sTf7dqWpxrJtdIgSxC1vro=.41a923c6-8607-4c95-8c6f-8a6c5ed1504f@github.com>
Message-ID: <y4I_E5jNidEkzM5bv8NSjlbgxWhUnHSw3i434-yujnQ=.463d2c4e-827a-4247-984e-ade2ca7347cd@github.com>

On Tue, 12 Mar 2024 06:43:36 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

> Conversion of manual applet test to main based using PassFailJFrame manual framework

test/jdk/javax/swing/JTree/4314199/bug4314199.java line 53:

> 51:             press 'Pass' else 'Fail'. """;
> 52: 
> 53:     private static JFrame frame;

Frame can be moved inside creatUI(). If you can use splitUI instead of testUI that would be even better.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18215#discussion_r1521187565

From dmarkov at openjdk.org  Tue Mar 12 10:10:13 2024
From: dmarkov at openjdk.org (Dmitry Markov)
Date: Tue, 12 Mar 2024 10:10:13 GMT
Subject: RFR: 8327856: Convert applet test SpanishDiacriticsTest.java to a
 main program
In-Reply-To: <JnPnHUoBMQd1YGVtRimzTC2Y5Sn5ezSWq2Fkw9jh-KA=.8df82997-452b-41c9-a698-68ab33e49f13@github.com>
References: <JnPnHUoBMQd1YGVtRimzTC2Y5Sn5ezSWq2Fkw9jh-KA=.8df82997-452b-41c9-a698-68ab33e49f13@github.com>
Message-ID: <E3aILHexWgdiu7oi8d1yHK1PvKPhLucgWE8hyApSA58=.50a488df-3a60-40f8-9369-68066a49d87f@github.com>

On Mon, 11 Mar 2024 23:02:53 GMT, Phil Race <prr at openjdk.org> wrote:

> Converts the  manual applet test in the files ..
> SpanishDiacriticsTest/SpanishDiacriticsTest.html
> SpanishDiacriticsTest/SpanishDiacriticsTest.java
> .. to a main program using PassFailJFrame
> 
> Added requires windows since it seems very windows-specific.
> 
> I got rid of the redundant extra directory which makes the .java file "new" according to github but it is largely changed anyway

Marked as reviewed by dmarkov (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18208#pullrequestreview-1930620808

From aivanov at openjdk.org  Tue Mar 12 10:11:15 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 12 Mar 2024 10:11:15 GMT
Subject: RFR: 8327750: Convert
 javax/swing/JFileChooser/FileFilterDescription/FileFilterDescription.java
 applet test to main [v2]
In-Reply-To: <EkY__SHfzUZxe_hCwbGswIXd_JlVRfucwuTHshh39FA=.902e5584-9dae-4ccf-a55e-818976f0eb6b@github.com>
References: <Fri2USQ-lXz_OJYx4o2lhB5twAsUnaOn8R2ylmurMSk=.1c9502c4-a43b-4137-854c-25040beb0593@github.com>
 <EkY__SHfzUZxe_hCwbGswIXd_JlVRfucwuTHshh39FA=.902e5584-9dae-4ccf-a55e-818976f0eb6b@github.com>
Message-ID: <A07XLEp9Xw_gpExSsL-muAdLDSnaAVZZt_nAc0F9mJU=.1dd96515-be8f-49e7-b013-63c6e36de98e@github.com>

On Tue, 12 Mar 2024 02:47:25 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Conversion of manual applet test to main based using PassFailJFrame manual framework
>
> Prasanta Sadhukhan has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Review comment update
>  - Review comment update

Marked as reviewed by aivanov (Reviewer).

test/jdk/javax/swing/JFileChooser/FileFilterDescription/FileFilterDescription.java line 54:

> 52:                 .rows(10)
> 53:                 .columns(35)
> 54:                 .build();

Suggestion:

                .position(PassFailJFrame.Position.TOP_LEFT_CORNER)
                .build();

To move the instruction frame into its final position right away since `build()` shows the instruction UI. Later the instruction frame is moved when you use `PassFailJFrame.positionTestWindow`.

-------------

PR Review: https://git.openjdk.org/jdk/pull/18182#pullrequestreview-1930616215
PR Review Comment: https://git.openjdk.org/jdk/pull/18182#discussion_r1521190975

From aivanov at openjdk.org  Tue Mar 12 10:11:16 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 12 Mar 2024 10:11:16 GMT
Subject: RFR: 8327750: Convert
 javax/swing/JFileChooser/FileFilterDescription/FileFilterDescription.java
 applet test to main [v2]
In-Reply-To: <IoCnMRSZPW3cLwHL8qpDOQ94BlZW_-5RqecAXa1Jhe0=.e2f57c32-c8eb-4498-8e79-297b14b46748@github.com>
References: <Fri2USQ-lXz_OJYx4o2lhB5twAsUnaOn8R2ylmurMSk=.1c9502c4-a43b-4137-854c-25040beb0593@github.com>
 <EkY__SHfzUZxe_hCwbGswIXd_JlVRfucwuTHshh39FA=.902e5584-9dae-4ccf-a55e-818976f0eb6b@github.com>
 <IoCnMRSZPW3cLwHL8qpDOQ94BlZW_-5RqecAXa1Jhe0=.e2f57c32-c8eb-4498-8e79-297b14b46748@github.com>
Message-ID: <xLtP8tyxxXEnzwDnClrYaECzUgZyekjwhssJTQDkcjU=.83d79f04-6ae8-4136-9002-f0ae832d510a@github.com>

On Tue, 12 Mar 2024 03:51:52 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Prasanta Sadhukhan has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Review comment update
>>  - Review comment update
>
> test/jdk/javax/swing/JFileChooser/FileFilterDescription/FileFilterDescription.java line 53:
> 
>> 51:                 .instructions(INSTRUCTIONS)
>> 52:                 .rows(10)
>> 53:                 .columns(35)
> 
> I guess testUI and awaitAndCheck can be used here only.

It may, but it wouldn't work well. Prasanta's approach works better.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18182#discussion_r1521188014

From dmarkov at openjdk.org  Tue Mar 12 10:12:21 2024
From: dmarkov at openjdk.org (Dmitry Markov)
Date: Tue, 12 Mar 2024 10:12:21 GMT
Subject: Integrated: 8326661: sun/java2d/cmm/ColorConvertOp/ColConvTest.java
 assumes profiles were generated by LCMS
In-Reply-To: <nFplnFr0UPf-gWrZjoyZhb2pCJ_fjUEieIxTlWesSNs=.7f372d25-5bc5-4fb2-9ecd-8d5e40cc69b8@github.com>
References: <nFplnFr0UPf-gWrZjoyZhb2pCJ_fjUEieIxTlWesSNs=.7f372d25-5bc5-4fb2-9ecd-8d5e40cc69b8@github.com>
Message-ID: <WcSTRVglBNtp_xi-jRMBxDQUipIblzPomAMa4OJnAVk=.9fa68838-acb5-4695-9438-e41ff204a5a9@github.com>

On Sun, 3 Mar 2024 09:01:49 GMT, Dmitry Markov <dmarkov at openjdk.org> wrote:

> Updated several tests to avoid potential failure with recent LCMS update and non-LCMS generated profile.

This pull request has now been integrated.

Changeset: 1f43fa0f
Author:    Dmitry Markov <dmarkov at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/1f43fa0f8b0f956b41015e0ebc257e15a11ad99b
Stats:     4 lines in 1 file changed: 0 ins; 0 del; 4 mod

8326661: sun/java2d/cmm/ColorConvertOp/ColConvTest.java assumes profiles were generated by LCMS

Reviewed-by: aivanov, serb

-------------

PR: https://git.openjdk.org/jdk/pull/18097

From tr at openjdk.org  Tue Mar 12 10:15:15 2024
From: tr at openjdk.org (Tejesh R)
Date: Tue, 12 Mar 2024 10:15:15 GMT
Subject: RFR: 8327750: Convert
 javax/swing/JFileChooser/FileFilterDescription/FileFilterDescription.java
 applet test to main [v2]
In-Reply-To: <EkY__SHfzUZxe_hCwbGswIXd_JlVRfucwuTHshh39FA=.902e5584-9dae-4ccf-a55e-818976f0eb6b@github.com>
References: <Fri2USQ-lXz_OJYx4o2lhB5twAsUnaOn8R2ylmurMSk=.1c9502c4-a43b-4137-854c-25040beb0593@github.com>
 <EkY__SHfzUZxe_hCwbGswIXd_JlVRfucwuTHshh39FA=.902e5584-9dae-4ccf-a55e-818976f0eb6b@github.com>
Message-ID: <JInxKf8d3vuhfa7GXJBGozDOuhsUN64n9oKOvci8tOI=.62acf6a1-0499-410f-9552-acec32dea797@github.com>

On Tue, 12 Mar 2024 02:47:25 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Conversion of manual applet test to main based using PassFailJFrame manual framework
>
> Prasanta Sadhukhan has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Review comment update
>  - Review comment update

test/jdk/javax/swing/JFileChooser/FileFilterDescription/FileFilterDescription.java line 42:

> 40: public final class FileFilterDescription {
> 41: 
> 42:      private static final String INSTRUCTIONS = """

`INSTRUCTIONS ` can be moved inside main.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18182#discussion_r1521197001

From tr at openjdk.org  Tue Mar 12 10:22:15 2024
From: tr at openjdk.org (Tejesh R)
Date: Tue, 12 Mar 2024 10:22:15 GMT
Subject: RFR: 8327748: Convert
 javax/swing/JFileChooser/6798062/bug6798062.java applet test to main [v3]
In-Reply-To: <S7B9SumsKmtgNCkT9j8t8_wPVBZe05ZPg7V0MbDVSy4=.9dca42c1-76df-45b0-9d82-c9571168c8b5@github.com>
References: <lGQbwCvyqdtOr8-NxY9l3pZC4mRPn7gBtd7qPIRPF-I=.0379a965-6ad2-44ba-abfe-ecd0ed3f7b02@github.com>
 <S7B9SumsKmtgNCkT9j8t8_wPVBZe05ZPg7V0MbDVSy4=.9dca42c1-76df-45b0-9d82-c9571168c8b5@github.com>
Message-ID: <740m_-_rhTLqYbNfOFhsfqyjK9dNJWLns-CbXGLN5mY=.1e0c06b5-5426-4ec8-a913-7e0e22d30865@github.com>

On Tue, 12 Mar 2024 02:49:25 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Conversion of manual applet test to main based using PassFailJFrame manual framework
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review comment update

test/jdk/javax/swing/JFileChooser/6798062/bug6798062.java line 68:

> 66: 
> 67:     private static JSlider slider;
> 68:     private static JFrame frame;

`frame` Can be moved inside `createUI()`.

test/jdk/javax/swing/JFileChooser/6798062/bug6798062.java line 69:

> 67:     private static JSlider slider;
> 68:     private static JFrame frame;
> 69:     private static JTextField tfLink;

`tfLink` and `btnGC` can be initialized inside `initialize()` and moved there.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18180#discussion_r1521204448
PR Review Comment: https://git.openjdk.org/jdk/pull/18180#discussion_r1521206245

From azvegint at openjdk.org  Tue Mar 12 10:22:35 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Tue, 12 Mar 2024 10:22:35 GMT
Subject: RFR: 8327838: Convert
 java/awt/FileDialog/MultipleMode/MultipleMode.html applet test to main [v3]
In-Reply-To: <DI0RnXYhvIrM8iYvr6t5rSadWbY_VEnhePX1QnX41dA=.ac99191d-478f-4a09-a941-f9723929634a@github.com>
References: <DI0RnXYhvIrM8iYvr6t5rSadWbY_VEnhePX1QnX41dA=.ac99191d-478f-4a09-a941-f9723929634a@github.com>
Message-ID: <H17CvXEDgSuAg0WQfS89BUSARAHjmpTHGTxlo786qTI=.d9705383-f15e-4551-8d08-dbe32fe44a3c@github.com>

> The test is converted to main.
> Tested on Linux, Macos and Windows.

Alexander Zvegintsev has updated the pull request incrementally with one additional commit since the last revision:

  review comments

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18205/files
  - new: https://git.openjdk.org/jdk/pull/18205/files/a9f8e21b..58e3d73a

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18205&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18205&range=01-02

  Stats: 4 lines in 1 file changed: 1 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/jdk/pull/18205.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18205/head:pull/18205

PR: https://git.openjdk.org/jdk/pull/18205

From azvegint at openjdk.org  Tue Mar 12 10:22:35 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Tue, 12 Mar 2024 10:22:35 GMT
Subject: RFR: 8327838: Convert
 java/awt/FileDialog/MultipleMode/MultipleMode.html applet test to main [v2]
In-Reply-To: <sgiE9ec8eeQVEi8AsQr89JqWt2U1HW0UFKZNlC2JRjs=.3b4e4821-950e-471a-a22d-c061d8534b8a@github.com>
References: <DI0RnXYhvIrM8iYvr6t5rSadWbY_VEnhePX1QnX41dA=.ac99191d-478f-4a09-a941-f9723929634a@github.com>
 <yW_v_dZq1oZPtGMrbPJ029j9EhrqsJNnp8gQaVfcxOc=.a9a37234-46cc-41eb-8020-c8a7e6c01ba8@github.com>
 <sgiE9ec8eeQVEi8AsQr89JqWt2U1HW0UFKZNlC2JRjs=.3b4e4821-950e-471a-a22d-c061d8534b8a@github.com>
Message-ID: <QCUYLgzpcupHdNtC7mjvYFl7N8XvXKr3oDclktkN_XY=.470fba2b-80c0-4380-bb10-1da6e7048c2d@github.com>

On Tue, 12 Mar 2024 05:18:15 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Alexander Zvegintsev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review comments
>
> test/jdk/java/awt/FileDialog/MultipleMode.java line 63:
> 
>> 61:             .instructions(INSTRUCTIONS)
>> 62:             .rows(15)
>> 63:             .columns(40)
> 
> column size can be reduced based on the test instructions.

The instructions use different default fonts and sizes on each system, if I reduce the columns it will not fit on Linux.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18205#discussion_r1521193766

From azvegint at openjdk.org  Tue Mar 12 10:22:36 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Tue, 12 Mar 2024 10:22:36 GMT
Subject: RFR: 8327838: Convert
 java/awt/FileDialog/MultipleMode/MultipleMode.html applet test to main [v2]
In-Reply-To: <ZWvRNK2VMl7Kc0F7s36S5xlGR9umYYnE0qBSIbePM9g=.c9207405-088e-429a-b2ae-1940b2f24126@github.com>
References: <DI0RnXYhvIrM8iYvr6t5rSadWbY_VEnhePX1QnX41dA=.ac99191d-478f-4a09-a941-f9723929634a@github.com>
 <yW_v_dZq1oZPtGMrbPJ029j9EhrqsJNnp8gQaVfcxOc=.a9a37234-46cc-41eb-8020-c8a7e6c01ba8@github.com>
 <ZWvRNK2VMl7Kc0F7s36S5xlGR9umYYnE0qBSIbePM9g=.c9207405-088e-429a-b2ae-1940b2f24126@github.com>
Message-ID: <sERsfHeKMyvGwozMgU1DcJ2FHeaOlfQQufBVNcozp1A=.df03eabb-3559-4440-913d-596ff7ddab2e@github.com>

On Tue, 12 Mar 2024 09:55:57 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Alexander Zvegintsev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review comments
>
> test/jdk/java/awt/FileDialog/MultipleMode.java line 74:
> 
>> 72:         sysout.setEditable(false);
>> 73: 
>> 74:         final Checkbox mode = new Checkbox("multiple", true);
> 
> Does it make sense to leave the checkbox unselected, provided the instructions start with unselect the _Multiple_ checkbox (turn off)?

It could be, updated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18205#discussion_r1521204415

From azvegint at openjdk.org  Tue Mar 12 10:22:36 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Tue, 12 Mar 2024 10:22:36 GMT
Subject: RFR: 8327838: Convert
 java/awt/FileDialog/MultipleMode/MultipleMode.html applet test to main [v2]
In-Reply-To: <qHUq3OEr1q4IJe2m08KcrB3_VvNnDjnuYjZikrKgo88=.7c14872b-f36b-4ca6-98e3-f8ce23972cb4@github.com>
References: <DI0RnXYhvIrM8iYvr6t5rSadWbY_VEnhePX1QnX41dA=.ac99191d-478f-4a09-a941-f9723929634a@github.com>
 <yW_v_dZq1oZPtGMrbPJ029j9EhrqsJNnp8gQaVfcxOc=.a9a37234-46cc-41eb-8020-c8a7e6c01ba8@github.com>
 <sgiE9ec8eeQVEi8AsQr89JqWt2U1HW0UFKZNlC2JRjs=.3b4e4821-950e-471a-a22d-c061d8534b8a@github.com>
 <qHUq3OEr1q4IJe2m08KcrB3_VvNnDjnuYjZikrKgo88=.7c14872b-f36b-4ca6-98e3-f8ce23972cb4@github.com>
Message-ID: <b3gfSp2BX9u71B22ZfFXZF9QL2eyaCSwYGbwv3f5XgQ=.bc7b75c6-1ffa-40cc-9408-93b7bca20765@github.com>

On Tue, 12 Mar 2024 09:48:11 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> test/jdk/java/awt/FileDialog/MultipleMode.java line 101:
>> 
>>> 99:         frame.add(sysout, BorderLayout.CENTER);
>>> 100: 
>>> 101:         frame.pack();
>> 
>> Frame size is too big and going out of the screen, might fix a size here.
>
> It doesn't fit on the screen of my VM either.
> 
> One way to resolve this problem is to add
> 
>             .position(PassFailJFrame.Position.TOP_LEFT_CORNER)
> 
> to `PassFailJFrame` builder as there's no easy way to move the instruction frame to the left so that both frames fit on the screen.

Updated.

What resolution and scale are you using?
I've tested at 1920x1080 and default scale 1, and it has plenty of room: 
![image](https://github.com/openjdk/jdk/assets/77687766/5ab8035b-7d50-402b-a26d-0cbade786673)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18205#discussion_r1521196731

From azvegint at openjdk.org  Tue Mar 12 10:25:28 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Tue, 12 Mar 2024 10:25:28 GMT
Subject: RFR: 8327835: Convert
 java/awt/FileDialog/RegexpFilterTest/RegexpFilterTest applet test to main [v3]
In-Reply-To: <O_XrLLXwQtMWjKGEoOaYSM8RdDnyH3LF3-Bdp5PDRHo=.72bb3619-6cfc-43c8-83d6-c87eabf24636@github.com>
References: <O_XrLLXwQtMWjKGEoOaYSM8RdDnyH3LF3-Bdp5PDRHo=.72bb3619-6cfc-43c8-83d6-c87eabf24636@github.com>
Message-ID: <eznjGudEzhwQkzYNcW8TH-dMrbFF1xxfpXXmae22WXM=.edbd8ad0-840f-4c49-8d05-79348c7322c5@github.com>

> The `java/awt/FileDialog/RegexpFilterTest/RegexpFilterTest` test is written to test the very specific functionality of `XFileDialogPeer`, so it shouldn't be run on platforms other than Linux.
> 
> We also need to set `sun.awt.disableGtkFileDialogs` to `true` to be able to test `XFileDialogPeer`, because by default it tries to use the Gtk file dialog if it is available.
> The Gtk file dialog has a search field hidden under the magnifying glass icon, but it has a different syntax.
> 
> The Windows system file dialog allows you to use wildcard filtering in the "File name" field by hitting the `enter` afterwards, but again, this test was written to test our own file dialog implementation, not the system's.

Alexander Zvegintsev has updated the pull request incrementally with one additional commit since the last revision:

  review comments

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18203/files
  - new: https://git.openjdk.org/jdk/pull/18203/files/b43ce26b..e1b9422e

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18203&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18203&range=01-02

  Stats: 14 lines in 1 file changed: 1 ins; 0 del; 13 mod
  Patch: https://git.openjdk.org/jdk/pull/18203.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18203/head:pull/18203

PR: https://git.openjdk.org/jdk/pull/18203

From tr at openjdk.org  Tue Mar 12 10:26:15 2024
From: tr at openjdk.org (Tejesh R)
Date: Tue, 12 Mar 2024 10:26:15 GMT
Subject: RFR: 8327838: Convert
 java/awt/FileDialog/MultipleMode/MultipleMode.html applet test to main [v2]
In-Reply-To: <b3gfSp2BX9u71B22ZfFXZF9QL2eyaCSwYGbwv3f5XgQ=.bc7b75c6-1ffa-40cc-9408-93b7bca20765@github.com>
References: <DI0RnXYhvIrM8iYvr6t5rSadWbY_VEnhePX1QnX41dA=.ac99191d-478f-4a09-a941-f9723929634a@github.com>
 <yW_v_dZq1oZPtGMrbPJ029j9EhrqsJNnp8gQaVfcxOc=.a9a37234-46cc-41eb-8020-c8a7e6c01ba8@github.com>
 <sgiE9ec8eeQVEi8AsQr89JqWt2U1HW0UFKZNlC2JRjs=.3b4e4821-950e-471a-a22d-c061d8534b8a@github.com>
 <qHUq3OEr1q4IJe2m08KcrB3_VvNnDjnuYjZikrKgo88=.7c14872b-f36b-4ca6-98e3-f8ce23972cb4@github.com>
 <b3gfSp2BX9u71B22ZfFXZF9QL2eyaCSwYGbwv3f5XgQ=.bc7b75c6-1ffa-40cc-9408-93b7bca20765@github.com>
Message-ID: <RV5uFN4g7kJd-d_R5nv9PrL9MZeyAJ8YES8s-qLrTwk=.322e501d-4d47-4849-b866-01f3e2342de5@github.com>

On Tue, 12 Mar 2024 10:12:22 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>> It doesn't fit on the screen of my VM either.
>> 
>> One way to resolve this problem is to add
>> 
>>             .position(PassFailJFrame.Position.TOP_LEFT_CORNER)
>> 
>> to `PassFailJFrame` builder as there's no easy way to move the instruction frame to the left so that both frames fit on the screen.
>
> Updated.
> 
> What resolution and scale are you using?
> I've tested at 1920x1080 and default scale 1, and it has plenty of room: 
> ![image](https://github.com/openjdk/jdk/assets/77687766/5ab8035b-7d50-402b-a26d-0cbade786673)

Now its fine on my screen. But its not in center, but top. Does it differ for windows and linux?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18205#discussion_r1521211983

From azvegint at openjdk.org  Tue Mar 12 10:30:14 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Tue, 12 Mar 2024 10:30:14 GMT
Subject: RFR: 8327838: Convert
 java/awt/FileDialog/MultipleMode/MultipleMode.html applet test to main [v2]
In-Reply-To: <RV5uFN4g7kJd-d_R5nv9PrL9MZeyAJ8YES8s-qLrTwk=.322e501d-4d47-4849-b866-01f3e2342de5@github.com>
References: <DI0RnXYhvIrM8iYvr6t5rSadWbY_VEnhePX1QnX41dA=.ac99191d-478f-4a09-a941-f9723929634a@github.com>
 <yW_v_dZq1oZPtGMrbPJ029j9EhrqsJNnp8gQaVfcxOc=.a9a37234-46cc-41eb-8020-c8a7e6c01ba8@github.com>
 <sgiE9ec8eeQVEi8AsQr89JqWt2U1HW0UFKZNlC2JRjs=.3b4e4821-950e-471a-a22d-c061d8534b8a@github.com>
 <qHUq3OEr1q4IJe2m08KcrB3_VvNnDjnuYjZikrKgo88=.7c14872b-f36b-4ca6-98e3-f8ce23972cb4@github.com>
 <b3gfSp2BX9u71B22ZfFXZF9QL2eyaCSwYGbwv3f5XgQ=.bc7b75c6-1ffa-40cc-9408-93b7bca20765@github.com>
 <RV5uFN4g7kJd-d_R5nv9PrL9MZeyAJ8YES8s-qLrTwk=.322e501d-4d47-4849-b866-01f3e2342de5@github.com>
Message-ID: <C8J0U0Nf75Pj4wfeyThCIBrRSGBf-NuaxzQ3n3kDPo4=.5b289b53-6e29-44fe-be1c-1183c813f41f@github.com>

On Tue, 12 Mar 2024 10:23:39 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Updated.
>> 
>> What resolution and scale are you using?
>> I've tested at 1920x1080 and default scale 1, and it has plenty of room: 
>> ![image](https://github.com/openjdk/jdk/assets/77687766/5ab8035b-7d50-402b-a26d-0cbade786673)
>
> Now its fine on my screen. But its not in center, but top. Does it differ for windows and linux?

It is not in the center, because in the latest commit I added `.position(PassFailJFrame.Position.TOP_LEFT_CORNER)`, as Alexey suggested.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18205#discussion_r1521217782

From psadhukhan at openjdk.org  Tue Mar 12 10:41:24 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Tue, 12 Mar 2024 10:41:24 GMT
Subject: RFR: 8327750: Convert
 javax/swing/JFileChooser/FileFilterDescription/FileFilterDescription.java
 applet test to main [v3]
In-Reply-To: <Fri2USQ-lXz_OJYx4o2lhB5twAsUnaOn8R2ylmurMSk=.1c9502c4-a43b-4137-854c-25040beb0593@github.com>
References: <Fri2USQ-lXz_OJYx4o2lhB5twAsUnaOn8R2ylmurMSk=.1c9502c4-a43b-4137-854c-25040beb0593@github.com>
Message-ID: <xMeM0pU0RnMxNAxYbSS7ndwSkI6zE8WuJH3K2AXoGng=.20f07611-d04d-464c-9930-6f004fffe969@github.com>

> Conversion of manual applet test to main based using PassFailJFrame manual framework

Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:

  Position frame at TOP_LEFT_CORNER before build

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18182/files
  - new: https://git.openjdk.org/jdk/pull/18182/files/7c2ce443..f5bae849

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18182&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18182&range=01-02

  Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18182.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18182/head:pull/18182

PR: https://git.openjdk.org/jdk/pull/18182

From psadhukhan at openjdk.org  Tue Mar 12 10:41:24 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Tue, 12 Mar 2024 10:41:24 GMT
Subject: RFR: 8327750: Convert
 javax/swing/JFileChooser/FileFilterDescription/FileFilterDescription.java
 applet test to main [v2]
In-Reply-To: <A07XLEp9Xw_gpExSsL-muAdLDSnaAVZZt_nAc0F9mJU=.1dd96515-be8f-49e7-b013-63c6e36de98e@github.com>
References: <Fri2USQ-lXz_OJYx4o2lhB5twAsUnaOn8R2ylmurMSk=.1c9502c4-a43b-4137-854c-25040beb0593@github.com>
 <EkY__SHfzUZxe_hCwbGswIXd_JlVRfucwuTHshh39FA=.902e5584-9dae-4ccf-a55e-818976f0eb6b@github.com>
 <A07XLEp9Xw_gpExSsL-muAdLDSnaAVZZt_nAc0F9mJU=.1dd96515-be8f-49e7-b013-63c6e36de98e@github.com>
Message-ID: <CuO5tTNBcGS3mbksOTCi8VvlrMQ6QT9kSnEogVPeow8=.6ee74c54-7e9b-41b8-8823-d2239e5404fe@github.com>

On Tue, 12 Mar 2024 10:08:04 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Prasanta Sadhukhan has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Review comment update
>>  - Review comment update
>
> test/jdk/javax/swing/JFileChooser/FileFilterDescription/FileFilterDescription.java line 54:
> 
>> 52:                 .rows(10)
>> 53:                 .columns(35)
>> 54:                 .build();
> 
> Suggestion:
> 
>                 .position(PassFailJFrame.Position.TOP_LEFT_CORNER)
>                 .build();
> 
> To move the instruction frame into its final position right away since `build()` shows the instruction UI. Later the instruction frame is moved when you use `PassFailJFrame.positionTestWindow`.

ok. updated..but it doesn't seem to make any difference..

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18182#discussion_r1521229399

From tr at openjdk.org  Tue Mar 12 10:45:18 2024
From: tr at openjdk.org (Tejesh R)
Date: Tue, 12 Mar 2024 10:45:18 GMT
Subject: RFR: 8327838: Convert
 java/awt/FileDialog/MultipleMode/MultipleMode.html applet test to main [v3]
In-Reply-To: <H17CvXEDgSuAg0WQfS89BUSARAHjmpTHGTxlo786qTI=.d9705383-f15e-4551-8d08-dbe32fe44a3c@github.com>
References: <DI0RnXYhvIrM8iYvr6t5rSadWbY_VEnhePX1QnX41dA=.ac99191d-478f-4a09-a941-f9723929634a@github.com>
 <H17CvXEDgSuAg0WQfS89BUSARAHjmpTHGTxlo786qTI=.d9705383-f15e-4551-8d08-dbe32fe44a3c@github.com>
Message-ID: <K-vyMHRLwZy2z-G5ja3pxiHkgvtAdWVeJalkpDIBdhM=.d943a4ff-2eae-4ce8-8a96-c47d0d15d6e7@github.com>

On Tue, 12 Mar 2024 10:22:35 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>> The test is converted to main.
>> Tested on Linux, Macos and Windows.
>
> Alexander Zvegintsev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   review comments

Marked as reviewed by tr (Committer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18205#pullrequestreview-1930693062

From psadhukhan at openjdk.org  Tue Mar 12 10:48:17 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Tue, 12 Mar 2024 10:48:17 GMT
Subject: Integrated: 8327750: Convert
 javax/swing/JFileChooser/FileFilterDescription/FileFilterDescription.java
 applet test to main
In-Reply-To: <Fri2USQ-lXz_OJYx4o2lhB5twAsUnaOn8R2ylmurMSk=.1c9502c4-a43b-4137-854c-25040beb0593@github.com>
References: <Fri2USQ-lXz_OJYx4o2lhB5twAsUnaOn8R2ylmurMSk=.1c9502c4-a43b-4137-854c-25040beb0593@github.com>
Message-ID: <Mvx56BwyHJmSZfi1VrZy-WOeWJFmEl35ha1OBSYNrys=.c925d5e7-8136-44a6-a3f6-eabb81380cd0@github.com>

On Mon, 11 Mar 2024 08:54:38 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> Conversion of manual applet test to main based using PassFailJFrame manual framework

This pull request has now been integrated.

Changeset: 78beb031
Author:    Prasanta Sadhukhan <psadhukhan at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/78beb031c75d2435c3543a0edc2335b92e115858
Stats:     81 lines in 2 files changed: 23 ins; 50 del; 8 mod

8327750: Convert javax/swing/JFileChooser/FileFilterDescription/FileFilterDescription.java applet test to main

Reviewed-by: aivanov

-------------

PR: https://git.openjdk.org/jdk/pull/18182

From psadhukhan at openjdk.org  Tue Mar 12 10:54:37 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Tue, 12 Mar 2024 10:54:37 GMT
Subject: RFR: 8327748: Convert
 javax/swing/JFileChooser/6798062/bug6798062.java applet test to main [v4]
In-Reply-To: <lGQbwCvyqdtOr8-NxY9l3pZC4mRPn7gBtd7qPIRPF-I=.0379a965-6ad2-44ba-abfe-ecd0ed3f7b02@github.com>
References: <lGQbwCvyqdtOr8-NxY9l3pZC4mRPn7gBtd7qPIRPF-I=.0379a965-6ad2-44ba-abfe-ecd0ed3f7b02@github.com>
Message-ID: <m3hgBXSx6mYm24AxAKD76jaXq_y4dlA85pGwrcacB28=.5cd84744-1764-4413-856e-d33b55bf9f93@github.com>

> Conversion of manual applet test to main based using PassFailJFrame manual framework

Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:

  move frame init in createUI

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18180/files
  - new: https://git.openjdk.org/jdk/pull/18180/files/71d387b5..abd16b4f

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18180&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18180&range=02-03

  Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/18180.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18180/head:pull/18180

PR: https://git.openjdk.org/jdk/pull/18180

From psadhukhan at openjdk.org  Tue Mar 12 10:54:37 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Tue, 12 Mar 2024 10:54:37 GMT
Subject: RFR: 8327748: Convert
 javax/swing/JFileChooser/6798062/bug6798062.java applet test to main [v3]
In-Reply-To: <740m_-_rhTLqYbNfOFhsfqyjK9dNJWLns-CbXGLN5mY=.1e0c06b5-5426-4ec8-a913-7e0e22d30865@github.com>
References: <lGQbwCvyqdtOr8-NxY9l3pZC4mRPn7gBtd7qPIRPF-I=.0379a965-6ad2-44ba-abfe-ecd0ed3f7b02@github.com>
 <S7B9SumsKmtgNCkT9j8t8_wPVBZe05ZPg7V0MbDVSy4=.9dca42c1-76df-45b0-9d82-c9571168c8b5@github.com>
 <740m_-_rhTLqYbNfOFhsfqyjK9dNJWLns-CbXGLN5mY=.1e0c06b5-5426-4ec8-a913-7e0e22d30865@github.com>
Message-ID: <ihXuVr-vtLjOIgjHuywbqizfcOyOnI88bn_rd6vf1BI=.c2e9f781-4044-4f7a-b747-d91cfc121dff@github.com>

On Tue, 12 Mar 2024 10:18:06 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review comment update
>
> test/jdk/javax/swing/JFileChooser/6798062/bug6798062.java line 68:
> 
>> 66: 
>> 67:     private static JSlider slider;
>> 68:     private static JFrame frame;
> 
> `frame` Can be moved inside `createUI()`.

ok

> test/jdk/javax/swing/JFileChooser/6798062/bug6798062.java line 69:
> 
>> 67:     private static JSlider slider;
>> 68:     private static JFrame frame;
>> 69:     private static JTextField tfLink;
> 
> `tfLink` and `btnGC` can be initialized inside `initialize()` and moved there.

As I understood, testUI calls the passed method in EDT so I think it's better to init the swing variables there..

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18180#discussion_r1521247916
PR Review Comment: https://git.openjdk.org/jdk/pull/18180#discussion_r1521249290

From kizune at openjdk.org  Tue Mar 12 11:07:38 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Tue, 12 Mar 2024 11:07:38 GMT
Subject: RFR: 8316388: Opensource five Swing component related regression
 tests [v2]
In-Reply-To: <bk66ojURFnGqahRv9IYAhgumqNGFFMOfRkMUzjkIAqI=.9a8c6550-f6d1-4ee2-b53b-54dc6491ff0e@github.com>
References: <bk66ojURFnGqahRv9IYAhgumqNGFFMOfRkMUzjkIAqI=.9a8c6550-f6d1-4ee2-b53b-54dc6491ff0e@github.com>
Message-ID: <EHPasDTxg3TnE9aQRpJBFifbJmui-m81Aq9wCHpm2i8=.9e7f7b1b-afef-4ddf-b990-c5467d78329c@github.com>

> Clean up five more tests.
> 
> test/jdk/javax/swing/JDesktopPane/4132993/bug4132993.java
> test/jdk/javax/swing/JDesktopPane/4773378/bug4773378.java
> test/jdk/javax/swing/JEditorPane/4325606/bug4325606.java
> test/jdk/javax/swing/JEditorPane/4330998/bug4330998.java
> test/jdk/javax/swing/JEditorPane/4694598/FrameContent.html
> test/jdk/javax/swing/JEditorPane/4694598/bug4694598.java

Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:

  Bumped copyright year of the affected tests
  Minor changes based on the review comments

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18184/files
  - new: https://git.openjdk.org/jdk/pull/18184/files/71461d63..84eb696b

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18184&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18184&range=00-01

  Stats: 60 lines in 5 files changed: 12 ins; 13 del; 35 mod
  Patch: https://git.openjdk.org/jdk/pull/18184.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18184/head:pull/18184

PR: https://git.openjdk.org/jdk/pull/18184

From kizune at openjdk.org  Tue Mar 12 11:07:39 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Tue, 12 Mar 2024 11:07:39 GMT
Subject: RFR: 8316388: Opensource five Swing component related regression
 tests [v2]
In-Reply-To: <Wz8nlNpeWgJKwr9Keb8ydCDT0mn6Q1bdR4CK50zCPZ8=.f39e7e08-9ec2-472a-9c19-6ecaad9b1f04@github.com>
References: <bk66ojURFnGqahRv9IYAhgumqNGFFMOfRkMUzjkIAqI=.9a8c6550-f6d1-4ee2-b53b-54dc6491ff0e@github.com>
 <Wz8nlNpeWgJKwr9Keb8ydCDT0mn6Q1bdR4CK50zCPZ8=.f39e7e08-9ec2-472a-9c19-6ecaad9b1f04@github.com>
Message-ID: <xCn6dRc7-eEUmHTrMKrQaPrPdBMmFkYPrkW9T06ifTY=.ccae35e0-bcd1-4bf7-bb22-bac081c2fca0@github.com>

On Mon, 11 Mar 2024 14:04:36 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Bumped copyright year of the affected tests
>>   Minor changes based on the review comments
>
> test/jdk/javax/swing/JEditorPane/4325606/bug4325606.java line 115:
> 
>> 113:         try {
>> 114:             SwingUtilities.invokeAndWait(b::setupGUI);
>> 115:             safeSleep(3000);
> 
> Instead of sleeping, you can use a `CountDownLatch(3)` which you'll `countDown()` for each mouse click. Here you'll call `await(3, TimeUnit.SECONDS)` and throw a timeout error if `await` returns `false`.
> 
> Another synchroniser may be used to handle the case where `BadLocationException` is thrown to fail the test right away. Alternatively, `BadLocationException` may be wrapped into `RuntimeException` and re-thrown.

This is a very simple case and sleeping worked for it so i do not see reason to rewrite it with CDL.

> test/jdk/javax/swing/JEditorPane/4694598/bug4694598.java line 69:
> 
>> 67:     public void performTest() throws InterruptedException,
>> 68:             InvocationTargetException {
>> 69:         JRobot jRobo = JRobot.getRobot();
> 
> Suggestion:
> 
>         JRobot jRobo = JRobot.getRobot();
>         jRobo.waitForIdle();
> 
> Let the frame appear on the screen.

Done

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18184#discussion_r1521268654
PR Review Comment: https://git.openjdk.org/jdk/pull/18184#discussion_r1521267248

From aivanov at openjdk.org  Tue Mar 12 11:14:16 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 12 Mar 2024 11:14:16 GMT
Subject: RFR: 8327748: Convert
 javax/swing/JFileChooser/6798062/bug6798062.java applet test to main [v3]
In-Reply-To: <S7B9SumsKmtgNCkT9j8t8_wPVBZe05ZPg7V0MbDVSy4=.9dca42c1-76df-45b0-9d82-c9571168c8b5@github.com>
References: <lGQbwCvyqdtOr8-NxY9l3pZC4mRPn7gBtd7qPIRPF-I=.0379a965-6ad2-44ba-abfe-ecd0ed3f7b02@github.com>
 <S7B9SumsKmtgNCkT9j8t8_wPVBZe05ZPg7V0MbDVSy4=.9dca42c1-76df-45b0-9d82-c9571168c8b5@github.com>
Message-ID: <BuJF_WEENS6BlNK7cOfB32-1ugXTos4FkO9VpTvlLvs=.3f2987a7-a5d8-43e8-955b-e3434c5d9e9e@github.com>

On Tue, 12 Mar 2024 02:49:25 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Conversion of manual applet test to main based using PassFailJFrame manual framework
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review comment update

test/jdk/javax/swing/JFileChooser/6798062/bug6798062.java line 52:

> 50: import javax.swing.JSlider;
> 51: import javax.swing.JTextField;
> 52: import javax.swing.SwingUtilities;

`SwingUtilities` is unused now.

test/jdk/javax/swing/JFileChooser/6798062/bug6798062.java line 60:

> 58: 
> 59:             1. Create a link
> 60:             2. Copy path to the link into TextField

I understand the instructions aren't new but I can't comprehend what it's required.

Does it mean a Windows shortcut, `.lnk` file? Seems like it's the case because `getLinkLocation` is called which resolves a shortcut to its original file.

Can the text field be pre-populated with a default? There could be shortcuts on Desktop, there are many shortcuts in the Start menu.

test/jdk/javax/swing/JFileChooser/6798062/bug6798062.java line 65:

> 63:             5. Wait several minutes and observe in the Windows Task Manager
> 64:                that Memory Usage of java process is not increasing
> 65:             If memory usage is increasing, click Fail else click Pass .  """;

Suggestion:

            If memory usage is increasing, click Fail else click Pass.""";

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18180#discussion_r1521264352
PR Review Comment: https://git.openjdk.org/jdk/pull/18180#discussion_r1521262560
PR Review Comment: https://git.openjdk.org/jdk/pull/18180#discussion_r1521263213

From aivanov at openjdk.org  Tue Mar 12 11:14:16 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 12 Mar 2024 11:14:16 GMT
Subject: RFR: 8327748: Convert
 javax/swing/JFileChooser/6798062/bug6798062.java applet test to main [v3]
In-Reply-To: <ihXuVr-vtLjOIgjHuywbqizfcOyOnI88bn_rd6vf1BI=.c2e9f781-4044-4f7a-b747-d91cfc121dff@github.com>
References: <lGQbwCvyqdtOr8-NxY9l3pZC4mRPn7gBtd7qPIRPF-I=.0379a965-6ad2-44ba-abfe-ecd0ed3f7b02@github.com>
 <S7B9SumsKmtgNCkT9j8t8_wPVBZe05ZPg7V0MbDVSy4=.9dca42c1-76df-45b0-9d82-c9571168c8b5@github.com>
 <740m_-_rhTLqYbNfOFhsfqyjK9dNJWLns-CbXGLN5mY=.1e0c06b5-5426-4ec8-a913-7e0e22d30865@github.com>
 <ihXuVr-vtLjOIgjHuywbqizfcOyOnI88bn_rd6vf1BI=.c2e9f781-4044-4f7a-b747-d91cfc121dff@github.com>
Message-ID: <njnHmJJbpJtuVdKTQisDlU4yJ3YtxTtosrfJLAV3J98=.d3d76e80-96bb-4cc7-8bd0-60428edda6b9@github.com>

On Tue, 12 Mar 2024 10:51:47 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> As I understood, testUI calls the passed method in EDT so I think it's better to init the swing variables there..

Yes, that's true, if you pass a lambda expression to `testUI`, it is called on EDT.

Since `initialize` is called from `createUI`, both methods will be called on EDT.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18180#discussion_r1521271334

From aivanov at openjdk.org  Tue Mar 12 11:14:18 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 12 Mar 2024 11:14:18 GMT
Subject: RFR: 8327748: Convert
 javax/swing/JFileChooser/6798062/bug6798062.java applet test to main [v4]
In-Reply-To: <m3hgBXSx6mYm24AxAKD76jaXq_y4dlA85pGwrcacB28=.5cd84744-1764-4413-856e-d33b55bf9f93@github.com>
References: <lGQbwCvyqdtOr8-NxY9l3pZC4mRPn7gBtd7qPIRPF-I=.0379a965-6ad2-44ba-abfe-ecd0ed3f7b02@github.com>
 <m3hgBXSx6mYm24AxAKD76jaXq_y4dlA85pGwrcacB28=.5cd84744-1764-4413-856e-d33b55bf9f93@github.com>
Message-ID: <PWMpOx9P_yloO2Ay7vsB5vCJKOqAmm27E6OQETHNto8=.7bd39819-fa26-40fa-852b-963551d51032@github.com>

On Tue, 12 Mar 2024 10:54:37 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Conversion of manual applet test to main based using PassFailJFrame manual framework
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   move frame init in createUI

test/jdk/javax/swing/JFileChooser/6798062/bug6798062.java line 108:

> 106: 
> 107:         try {
> 108:             folder = ShellFolder.getShellFolder(new File("."));

I wonder if it was expected that there are files in the directory. Like yes, so I could be wrong. I assumed files were created but no file is created, instead the files in this directory is listed. The expected result is that each file in the directory creates a new `ShellFolder` instance.

test/jdk/javax/swing/JFileChooser/6798062/bug6798062.java line 177:

> 175:     private static void fail(String msg) {
> 176:         PassFailJFrame.forceFail();
> 177:         throw new RuntimeException(msg);

Suggestion:

        PassFailJFrame.forceFail(msg);

`forceFail` will throw the exception on the main thread.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18180#discussion_r1521274628
PR Review Comment: https://git.openjdk.org/jdk/pull/18180#discussion_r1521275324

From psadhukhan at openjdk.org  Tue Mar 12 11:14:25 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Tue, 12 Mar 2024 11:14:25 GMT
Subject: RFR: 8327752: Convert javax/swing/JOptionPane/4174551/bug4174551.java
 applet to main
Message-ID: <uEqsAwVSEu11kSzb6ccgfje4GyOGoZ4G0Wk59AYnvAI=.37029531-7173-4ea8-9ad7-3eb3dadde5a0@github.com>

Conversion of manual applet test to main based using PassFailJFrame manual framework

-------------

Commit messages:
 - 8327752: Convert javax/swing/JOptionPane/4174551/bug4174551.java applet to main

Changes: https://git.openjdk.org/jdk/pull/18228/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18228&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8327752
  Stats: 75 lines in 2 files changed: 21 ins; 40 del; 14 mod
  Patch: https://git.openjdk.org/jdk/pull/18228.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18228/head:pull/18228

PR: https://git.openjdk.org/jdk/pull/18228

From aivanov at openjdk.org  Tue Mar 12 11:16:15 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 12 Mar 2024 11:16:15 GMT
Subject: RFR: 8327751: Convert
 javax/swing/JInternalFrame/6726866/bug6726866.java applet test to main [v2]
In-Reply-To: <euEaxFEAEu2TZbcfeDeT5BjHlzvv6Kt-Y47BOFLMKDI=.26d6b611-bdd2-44e2-817f-62780e135060@github.com>
References: <C5clTEn-okNdD5RVu8jcJW8T9bluj4GTy7BDNxUwKy0=.6b278225-50fa-4714-a066-8ad465cd9766@github.com>
 <euEaxFEAEu2TZbcfeDeT5BjHlzvv6Kt-Y47BOFLMKDI=.26d6b611-bdd2-44e2-817f-62780e135060@github.com>
Message-ID: <0E8XfAia27yUjZuJ9OtIJQGCMgXJ0c0TTkle3OUiwIQ=.008e3dd9-d3d2-4096-b452-ea15917886fe@github.com>

On Tue, 12 Mar 2024 02:51:48 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Conversion of manual applet test to main based using PassFailJFrame manual framework
>
> Prasanta Sadhukhan has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Review comment update
>  - Review comment update

Marked as reviewed by aivanov (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18186#pullrequestreview-1930764110

From aivanov at openjdk.org  Tue Mar 12 11:18:14 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 12 Mar 2024 11:18:14 GMT
Subject: RFR: 8327748: Convert
 javax/swing/JFileChooser/6798062/bug6798062.java applet test to main [v4]
In-Reply-To: <m3hgBXSx6mYm24AxAKD76jaXq_y4dlA85pGwrcacB28=.5cd84744-1764-4413-856e-d33b55bf9f93@github.com>
References: <lGQbwCvyqdtOr8-NxY9l3pZC4mRPn7gBtd7qPIRPF-I=.0379a965-6ad2-44ba-abfe-ecd0ed3f7b02@github.com>
 <m3hgBXSx6mYm24AxAKD76jaXq_y4dlA85pGwrcacB28=.5cd84744-1764-4413-856e-d33b55bf9f93@github.com>
Message-ID: <GnOia85R27h3cMysH3_CYajUIvtF7EF-YnlhvjdQF8k=.93693e9c-4626-4e48-a81a-fbeb23550710@github.com>

On Tue, 12 Mar 2024 10:54:37 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Conversion of manual applet test to main based using PassFailJFrame manual framework
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   move frame init in createUI

test/jdk/javax/swing/JFileChooser/6798062/bug6798062.java line 80:

> 78:                 .title("JFileChooser Instructions")
> 79:                 .instructions(INSTRUCTIONS)
> 80:                 .rows(10)

Suggestion:

                .instructions(INSTRUCTIONS)
                .testTimeOut(10)
                .rows(10)

This test will benefit from a longer time out.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18180#discussion_r1521282483

From tr at openjdk.org  Tue Mar 12 11:20:31 2024
From: tr at openjdk.org (Tejesh R)
Date: Tue, 12 Mar 2024 11:20:31 GMT
Subject: RFR: 8327969: Convert javax/swing/border/Test6910490.java applet test
 to main
Message-ID: <ArKktd5_qKLn7B3HLdLakGlHSCWaxQ1ivx-miiQUGCQ=.604d8ce0-8405-4558-bc19-60a0d47d1122@github.com>

Convert javax/swing/border/Test6910490.java applet test to main based test using PassFailJFrame.

-------------

Commit messages:
 - Conversion from Applet to Main

Changes: https://git.openjdk.org/jdk/pull/18229/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18229&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8327969
  Stats: 61 lines in 2 files changed: 20 ins; 34 del; 7 mod
  Patch: https://git.openjdk.org/jdk/pull/18229.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18229/head:pull/18229

PR: https://git.openjdk.org/jdk/pull/18229

From aivanov at openjdk.org  Tue Mar 12 11:26:15 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 12 Mar 2024 11:26:15 GMT
Subject: RFR: 8327826: Convert javax/swing/border/Test4243289.java applet
 test to main [v3]
In-Reply-To: <5j-kUmJAGV9tEZBTNWCCUAYbQCdYbkS2aT4smyVjqe4=.61f56bc7-0389-4182-9b5a-6d06b676cdea@github.com>
References: <M5kMa3NPTVyzBZK7rPRT_gAHTQgVjPY_in-ZZJ8i1zM=.f1def8d8-79cd-4b03-88d2-4016a937d08d@github.com>
 <5j-kUmJAGV9tEZBTNWCCUAYbQCdYbkS2aT4smyVjqe4=.61f56bc7-0389-4182-9b5a-6d06b676cdea@github.com>
Message-ID: <RPEF6M7oDw-vEk-YOmuyuEP3YtKFsfVRFFPYUeyhfQw=.d2440f4e-3c62-4acf-a606-cb57c2d03eff@github.com>

On Tue, 12 Mar 2024 09:53:43 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Convert javax/swing/border/Test4243289.java applet test to main based test using PassFailJFrame.
>
> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review updates

Marked as reviewed by aivanov (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18197#pullrequestreview-1930784580

From aivanov at openjdk.org  Tue Mar 12 11:26:15 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 12 Mar 2024 11:26:15 GMT
Subject: RFR: 8327787: Convert javax/swing/border/Test4129681.java applet
 test to main [v4]
In-Reply-To: <M9iPASdsgS4F4Y7z1nwaIu9qKwmSgm_gHY0U8EYi2U0=.f82229d4-ebf5-4dd4-890e-050216283943@github.com>
References: <uZ3hGgyIWuMOTp6qSVNw_3r-F4REh4QvrzqAtH8fMo8=.e55e311d-c0d7-4863-9e8a-0d1edc1d8857@github.com>
 <M9iPASdsgS4F4Y7z1nwaIu9qKwmSgm_gHY0U8EYi2U0=.f82229d4-ebf5-4dd4-890e-050216283943@github.com>
Message-ID: <Alf7WQozdO-XLFBjciny6XrMGz5OMCPEIZA0KOHAqfk=.a26f6921-a764-479a-b08a-c5da01604727@github.com>

On Tue, 12 Mar 2024 09:47:37 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Convert javax/swing/border/Test4129681.java applet test to main based test using PassFailJFrame.
>
> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review updates

Marked as reviewed by aivanov (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18189#pullrequestreview-1930781424

From aivanov at openjdk.org  Tue Mar 12 11:26:16 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 12 Mar 2024 11:26:16 GMT
Subject: RFR: 8327787: Convert javax/swing/border/Test4129681.java applet
 test to main [v3]
In-Reply-To: <L7-TgsTwqrbKoxKxqJeqri8-YxExWulqv1yqE1C52uM=.2df29ec5-1235-458c-8f72-8a0fc60d7424@github.com>
References: <uZ3hGgyIWuMOTp6qSVNw_3r-F4REh4QvrzqAtH8fMo8=.e55e311d-c0d7-4863-9e8a-0d1edc1d8857@github.com>
 <ORgFggDMzuMJm7m9p0A8azZtJOYe9_fkWl7pzsAtmDs=.6d5bab60-4629-4317-bfce-533aa30894e2@github.com>
 <L7-TgsTwqrbKoxKxqJeqri8-YxExWulqv1yqE1C52uM=.2df29ec5-1235-458c-8f72-8a0fc60d7424@github.com>
Message-ID: <JHD_1wn5YNqN-6BF60Kj5mJwfeGwXc5_uAwp0T3wcVc=.07179a40-ac8f-4727-82f9-d2c6c85ac416@github.com>

On Tue, 12 Mar 2024 09:08:08 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review updates
>
> test/jdk/javax/swing/border/Test4129681.java line 75:
> 
>> 73:         main.add(Box.createVerticalStrut(4));
>> 74:         main.add(label);
>> 75:         main.add(Box.createVerticalGlue());
> 
> A `JPanel` with `BorderLayout` works better here, you can fill the area with the `JLabel`:
> Suggestion:
> 
>         JPanel main = new JPanel(new BorderLayout());
>         main.setBorder(BorderFactory.createEmptyBorder(8, 8, 8, 8));
>         main.add(check, BorderLayout.NORTH);
>         main.add(label, BorderLayout.CENTER);

You didn't change to `JPanel` with `BorderLayout`. Whatever.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18189#discussion_r1521290590

From psadhukhan at openjdk.org  Tue Mar 12 11:27:13 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Tue, 12 Mar 2024 11:27:13 GMT
Subject: RFR: 8327748: Convert
 javax/swing/JFileChooser/6798062/bug6798062.java applet test to main [v4]
In-Reply-To: <PWMpOx9P_yloO2Ay7vsB5vCJKOqAmm27E6OQETHNto8=.7bd39819-fa26-40fa-852b-963551d51032@github.com>
References: <lGQbwCvyqdtOr8-NxY9l3pZC4mRPn7gBtd7qPIRPF-I=.0379a965-6ad2-44ba-abfe-ecd0ed3f7b02@github.com>
 <m3hgBXSx6mYm24AxAKD76jaXq_y4dlA85pGwrcacB28=.5cd84744-1764-4413-856e-d33b55bf9f93@github.com>
 <PWMpOx9P_yloO2Ay7vsB5vCJKOqAmm27E6OQETHNto8=.7bd39819-fa26-40fa-852b-963551d51032@github.com>
Message-ID: <3V0bSMbDRx1AkWBosiTRtEYV8tt5xHh-mcImXu7NR1o=.72b016b3-8fe2-4bfa-89c9-142465fccf61@github.com>

On Tue, 12 Mar 2024 11:09:17 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   move frame init in createUI
>
> test/jdk/javax/swing/JFileChooser/6798062/bug6798062.java line 108:
> 
>> 106: 
>> 107:         try {
>> 108:             folder = ShellFolder.getShellFolder(new File("."));
> 
> I wonder if it was expected that there are files in the directory. Like yes, so I could be wrong. I assumed files were created but no file is created, instead the files in this directory is listed. The expected result is that each file in the directory creates a new `ShellFolder` instance.

I think it's needed to have some files in the directory..
This test is problemlisted actually and as per [this comment](https://bugs.openjdk.org/browse/JDK-8146446?focusedId=13884125&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13884125) it needs to be tested on a directory with some files in it but sometimes, in CI system temp folder may have thousand of files so I think we should revert back to "java.io.tmpdir" for this test sprint and figure out the fix for the tmpdir in JDK-8146446...Any objection?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18180#discussion_r1521295800

From aivanov at openjdk.org  Tue Mar 12 11:33:15 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 12 Mar 2024 11:33:15 GMT
Subject: RFR: 8327838: Convert
 java/awt/FileDialog/MultipleMode/MultipleMode.html applet test to main [v3]
In-Reply-To: <H17CvXEDgSuAg0WQfS89BUSARAHjmpTHGTxlo786qTI=.d9705383-f15e-4551-8d08-dbe32fe44a3c@github.com>
References: <DI0RnXYhvIrM8iYvr6t5rSadWbY_VEnhePX1QnX41dA=.ac99191d-478f-4a09-a941-f9723929634a@github.com>
 <H17CvXEDgSuAg0WQfS89BUSARAHjmpTHGTxlo786qTI=.d9705383-f15e-4551-8d08-dbe32fe44a3c@github.com>
Message-ID: <OTdFRfzJq7uFShJYlIexel0AH1ztcyfZhyb7Qxr9V7w=.91e3ddf6-d54d-4752-b579-09c3b8edc8dd@github.com>

On Tue, 12 Mar 2024 10:22:35 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>> The test is converted to main.
>> Tested on Linux, Macos and Windows.
>
> Alexander Zvegintsev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   review comments

Marked as reviewed by aivanov (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18205#pullrequestreview-1930798500

From aivanov at openjdk.org  Tue Mar 12 11:33:16 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 12 Mar 2024 11:33:16 GMT
Subject: RFR: 8327838: Convert
 java/awt/FileDialog/MultipleMode/MultipleMode.html applet test to main [v2]
In-Reply-To: <C8J0U0Nf75Pj4wfeyThCIBrRSGBf-NuaxzQ3n3kDPo4=.5b289b53-6e29-44fe-be1c-1183c813f41f@github.com>
References: <DI0RnXYhvIrM8iYvr6t5rSadWbY_VEnhePX1QnX41dA=.ac99191d-478f-4a09-a941-f9723929634a@github.com>
 <yW_v_dZq1oZPtGMrbPJ029j9EhrqsJNnp8gQaVfcxOc=.a9a37234-46cc-41eb-8020-c8a7e6c01ba8@github.com>
 <sgiE9ec8eeQVEi8AsQr89JqWt2U1HW0UFKZNlC2JRjs=.3b4e4821-950e-471a-a22d-c061d8534b8a@github.com>
 <qHUq3OEr1q4IJe2m08KcrB3_VvNnDjnuYjZikrKgo88=.7c14872b-f36b-4ca6-98e3-f8ce23972cb4@github.com>
 <b3gfSp2BX9u71B22ZfFXZF9QL2eyaCSwYGbwv3f5XgQ=.bc7b75c6-1ffa-40cc-9408-93b7bca20765@github.com>
 <RV5uFN4g7kJd-d_R5nv9PrL9MZeyAJ8YES8s-qLrTwk=.322e501d-4d47-4849-b866-01f3e2342de5@github.com>
 <C8J0U0Nf75Pj4wfeyThCIBrRSGBf-NuaxzQ3n3kDPo4=.5b289b53-6e29-44fe-be1c-1183c813f41f@github.com>
Message-ID: <0BgrMHnRLNliT2frpabItYx4BBckGEoj0-nRJNDkgTg=.dd03fbd1-27e3-4ff0-84da-f770f21abfcf@github.com>

On Tue, 12 Mar 2024 10:27:45 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>> Now its fine on my screen. But its not in center, but top. Does it differ for windows and linux?
>
> It is not in the center, because in the latest commit I added `.position(PassFailJFrame.Position.TOP_LEFT_CORNER)`, as Alexey suggested.

I have 1920?1200 with 150%. This is why it doesn't fit. The second frame overlapped instructions a bit.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18205#discussion_r1521302367

From aivanov at openjdk.org  Tue Mar 12 11:34:14 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 12 Mar 2024 11:34:14 GMT
Subject: RFR: 8327835: Convert
 java/awt/FileDialog/RegexpFilterTest/RegexpFilterTest applet test to main [v3]
In-Reply-To: <eznjGudEzhwQkzYNcW8TH-dMrbFF1xxfpXXmae22WXM=.edbd8ad0-840f-4c49-8d05-79348c7322c5@github.com>
References: <O_XrLLXwQtMWjKGEoOaYSM8RdDnyH3LF3-Bdp5PDRHo=.72bb3619-6cfc-43c8-83d6-c87eabf24636@github.com>
 <eznjGudEzhwQkzYNcW8TH-dMrbFF1xxfpXXmae22WXM=.edbd8ad0-840f-4c49-8d05-79348c7322c5@github.com>
Message-ID: <hEdcTBqrMgwvAUPKvaHuYGYWQ-jGKz3GgW2mey6PRfk=.c4d75211-6b04-4f34-8d6b-78aa1363e371@github.com>

On Tue, 12 Mar 2024 10:25:28 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>> The `java/awt/FileDialog/RegexpFilterTest/RegexpFilterTest` test is written to test the very specific functionality of `XFileDialogPeer`, so it shouldn't be run on platforms other than Linux.
>> 
>> We also need to set `sun.awt.disableGtkFileDialogs` to `true` to be able to test `XFileDialogPeer`, because by default it tries to use the Gtk file dialog if it is available.
>> The Gtk file dialog has a search field hidden under the magnifying glass icon, but it has a different syntax.
>> 
>> The Windows system file dialog allows you to use wildcard filtering in the "File name" field by hitting the `enter` afterwards, but again, this test was written to test our own file dialog implementation, not the system's.
>
> Alexander Zvegintsev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   review comments

Marked as reviewed by aivanov (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18203#pullrequestreview-1930801282

From aivanov at openjdk.org  Tue Mar 12 11:36:17 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 12 Mar 2024 11:36:17 GMT
Subject: RFR: 8327750: Convert
 javax/swing/JFileChooser/FileFilterDescription/FileFilterDescription.java
 applet test to main [v2]
In-Reply-To: <CuO5tTNBcGS3mbksOTCi8VvlrMQ6QT9kSnEogVPeow8=.6ee74c54-7e9b-41b8-8823-d2239e5404fe@github.com>
References: <Fri2USQ-lXz_OJYx4o2lhB5twAsUnaOn8R2ylmurMSk=.1c9502c4-a43b-4137-854c-25040beb0593@github.com>
 <EkY__SHfzUZxe_hCwbGswIXd_JlVRfucwuTHshh39FA=.902e5584-9dae-4ccf-a55e-818976f0eb6b@github.com>
 <A07XLEp9Xw_gpExSsL-muAdLDSnaAVZZt_nAc0F9mJU=.1dd96515-be8f-49e7-b013-63c6e36de98e@github.com>
 <CuO5tTNBcGS3mbksOTCi8VvlrMQ6QT9kSnEogVPeow8=.6ee74c54-7e9b-41b8-8823-d2239e5404fe@github.com>
Message-ID: <yg4yblPopWiAkB--bXPb5tUH4BacR15rUnMBfC2LFaw=.a47457b9-cda8-4aa2-af6f-c0db0ae0c733@github.com>

On Tue, 12 Mar 2024 10:37:04 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> test/jdk/javax/swing/JFileChooser/FileFilterDescription/FileFilterDescription.java line 54:
>> 
>>> 52:                 .rows(10)
>>> 53:                 .columns(35)
>>> 54:                 .build();
>> 
>> Suggestion:
>> 
>>                 .position(PassFailJFrame.Position.TOP_LEFT_CORNER)
>>                 .build();
>> 
>> To move the instruction frame into its final position right away since `build()` shows the instruction UI. Later the instruction frame is moved when you use `PassFailJFrame.positionTestWindow`.
>
> ok. updated..but it doesn't seem to make any difference..

It does. Now the instruction frame is always in the top left corner.

Before this update, it showed in the centre of the screen and in a short while moved to the top left corner.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18182#discussion_r1521306491

From aivanov at openjdk.org  Tue Mar 12 11:43:13 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 12 Mar 2024 11:43:13 GMT
Subject: RFR: 8327748: Convert
 javax/swing/JFileChooser/6798062/bug6798062.java applet test to main [v4]
In-Reply-To: <3V0bSMbDRx1AkWBosiTRtEYV8tt5xHh-mcImXu7NR1o=.72b016b3-8fe2-4bfa-89c9-142465fccf61@github.com>
References: <lGQbwCvyqdtOr8-NxY9l3pZC4mRPn7gBtd7qPIRPF-I=.0379a965-6ad2-44ba-abfe-ecd0ed3f7b02@github.com>
 <m3hgBXSx6mYm24AxAKD76jaXq_y4dlA85pGwrcacB28=.5cd84744-1764-4413-856e-d33b55bf9f93@github.com>
 <PWMpOx9P_yloO2Ay7vsB5vCJKOqAmm27E6OQETHNto8=.7bd39819-fa26-40fa-852b-963551d51032@github.com>
 <3V0bSMbDRx1AkWBosiTRtEYV8tt5xHh-mcImXu7NR1o=.72b016b3-8fe2-4bfa-89c9-142465fccf61@github.com>
Message-ID: <EWdPtvIQB5vdYF4U4jTzvOZ3K1RWctCg9UAkufhdGcs=.e6c87c26-2a54-4f39-9908-c07fef50d3ba@github.com>

On Tue, 12 Mar 2024 11:24:37 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> test/jdk/javax/swing/JFileChooser/6798062/bug6798062.java line 108:
>> 
>>> 106: 
>>> 107:         try {
>>> 108:             folder = ShellFolder.getShellFolder(new File("."));
>> 
>> I wonder if it was expected that there are files in the directory. Like yes, so I could be wrong. I assumed files were created but no file is created, instead the files in this directory is listed. The expected result is that each file in the directory creates a new `ShellFolder` instance.
>
> I think it's needed to have some files in the directory..
> This test is problemlisted actually and as per [this comment](https://bugs.openjdk.org/browse/JDK-8146446?focusedId=13884125&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13884125) it needs to be tested on a directory with some files in it but sometimes, in CI system temp folder may have thousand of files so I think we should revert back to "java.io.tmpdir" for this test sprint and figure out the fix for the tmpdir in JDK-8146446...Any objection?

One way to handle it is to create a number of files in the current directory, the `scratch` directory that jtreg provides and then rely on jtreg to remove it. Or to create a temp directory in the current directory and create files there.

We have no control over how many files are in the temporary directory, however, in most cases it's not empty.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18180#discussion_r1521313859

From aivanov at openjdk.org  Tue Mar 12 11:43:14 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 12 Mar 2024 11:43:14 GMT
Subject: RFR: 8327748: Convert
 javax/swing/JFileChooser/6798062/bug6798062.java applet test to main [v4]
In-Reply-To: <EWdPtvIQB5vdYF4U4jTzvOZ3K1RWctCg9UAkufhdGcs=.e6c87c26-2a54-4f39-9908-c07fef50d3ba@github.com>
References: <lGQbwCvyqdtOr8-NxY9l3pZC4mRPn7gBtd7qPIRPF-I=.0379a965-6ad2-44ba-abfe-ecd0ed3f7b02@github.com>
 <m3hgBXSx6mYm24AxAKD76jaXq_y4dlA85pGwrcacB28=.5cd84744-1764-4413-856e-d33b55bf9f93@github.com>
 <PWMpOx9P_yloO2Ay7vsB5vCJKOqAmm27E6OQETHNto8=.7bd39819-fa26-40fa-852b-963551d51032@github.com>
 <3V0bSMbDRx1AkWBosiTRtEYV8tt5xHh-mcImXu7NR1o=.72b016b3-8fe2-4bfa-89c9-142465fccf61@github.com>
 <EWdPtvIQB5vdYF4U4jTzvOZ3K1RWctCg9UAkufhdGcs=.e6c87c26-2a54-4f39-9908-c07fef50d3ba@github.com>
Message-ID: <ubssMjbMwsjQ7Pi8Psdub-Tl5sD-vVHGQVrhv1ObC2Q=.0dd0b7e4-698b-4238-b0e1-64ed600e0738@github.com>

On Tue, 12 Mar 2024 11:39:46 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> I think it's needed to have some files in the directory..
>> This test is problemlisted actually and as per [this comment](https://bugs.openjdk.org/browse/JDK-8146446?focusedId=13884125&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13884125) it needs to be tested on a directory with some files in it but sometimes, in CI system temp folder may have thousand of files so I think we should revert back to "java.io.tmpdir" for this test sprint and figure out the fix for the tmpdir in JDK-8146446...Any objection?
>
> One way to handle it is to create a number of files in the current directory, the `scratch` directory that jtreg provides and then rely on jtreg to remove it. Or to create a temp directory in the current directory and create files there.
> 
> We have no control over how many files are in the temporary directory, however, in most cases it's not empty.

> I think we should revert back to "java.io.tmpdir" for this test sprint and figure out the fix for the tmpdir in JDK-8146446...Any objection?

Sounds reasonable.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18180#discussion_r1521314423

From aivanov at openjdk.org  Tue Mar 12 12:01:17 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 12 Mar 2024 12:01:17 GMT
Subject: RFR: 8316388: Opensource five Swing component related regression
 tests [v2]
In-Reply-To: <rUm-kOKAOHaPEQV2BfxmaYHQNd3rEu_IP5CrT7pSz2w=.6f9c023b-8ed8-4a8a-9667-57092c3b14a8@github.com>
References: <bk66ojURFnGqahRv9IYAhgumqNGFFMOfRkMUzjkIAqI=.9a8c6550-f6d1-4ee2-b53b-54dc6491ff0e@github.com>
 <Wz8nlNpeWgJKwr9Keb8ydCDT0mn6Q1bdR4CK50zCPZ8=.f39e7e08-9ec2-472a-9c19-6ecaad9b1f04@github.com>
 <rUm-kOKAOHaPEQV2BfxmaYHQNd3rEu_IP5CrT7pSz2w=.6f9c023b-8ed8-4a8a-9667-57092c3b14a8@github.com>
Message-ID: <GJGNjOXshSl4w7-HD0zKHcMid8DhMMkObc2quQfEt58=.83082644-94fe-4e14-8fd7-cc4141c41a33@github.com>

On Tue, 12 Mar 2024 08:46:45 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

>> test/jdk/javax/swing/JDesktopPane/4132993/bug4132993.java line 47:
>> 
>>> 45:             } catch (PropertyVetoException ex) {
>>> 46:                 ex.printStackTrace();
>>> 47:             }
>> 
>> Shouldn't the test fail if an unexpected exception is thrown?
>
> It is not unexpected but instead of failing i think test should just pass. Which will happen because the internal frame is not minimized so the test condition is not recreated.

I believe it's unexpected because we don't expect `PropertyVetoException`, in which case failure seems a better option.

If anything changes so that `PropertyVetoException` would be thrown all the time, the test would appear to be passing whereas it would not run at all.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18184#discussion_r1521337005

From aivanov at openjdk.org  Tue Mar 12 12:12:16 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 12 Mar 2024 12:12:16 GMT
Subject: RFR: 8316388: Opensource five Swing component related regression
 tests [v2]
In-Reply-To: <EHPasDTxg3TnE9aQRpJBFifbJmui-m81Aq9wCHpm2i8=.9e7f7b1b-afef-4ddf-b990-c5467d78329c@github.com>
References: <bk66ojURFnGqahRv9IYAhgumqNGFFMOfRkMUzjkIAqI=.9a8c6550-f6d1-4ee2-b53b-54dc6491ff0e@github.com>
 <EHPasDTxg3TnE9aQRpJBFifbJmui-m81Aq9wCHpm2i8=.9e7f7b1b-afef-4ddf-b990-c5467d78329c@github.com>
Message-ID: <LD1QVryK3a6zBilW7IbMtSOPPkOJsd0sNH8kd2XB5to=.f8b7b4cb-c1cb-477c-b534-6dd005ca2e44@github.com>

On Tue, 12 Mar 2024 11:07:38 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

>> Clean up five more tests.
>> 
>> test/jdk/javax/swing/JDesktopPane/4132993/bug4132993.java
>> test/jdk/javax/swing/JDesktopPane/4773378/bug4773378.java
>> test/jdk/javax/swing/JEditorPane/4325606/bug4325606.java
>> test/jdk/javax/swing/JEditorPane/4330998/bug4330998.java
>> test/jdk/javax/swing/JEditorPane/4694598/FrameContent.html
>> test/jdk/javax/swing/JEditorPane/4694598/bug4694598.java
>
> Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Bumped copyright year of the affected tests
>   Minor changes based on the review comments

Marked as reviewed by aivanov (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18184#pullrequestreview-1930877050

From aivanov at openjdk.org  Tue Mar 12 12:12:18 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 12 Mar 2024 12:12:18 GMT
Subject: RFR: 8316388: Opensource five Swing component related regression
 tests [v2]
In-Reply-To: <TsbWXpNEfDOdyQ_1opNjH9LySOsVOU2lcM7xZJ60eYA=.74e9988c-beb6-4388-b263-5db0f1edc98a@github.com>
References: <bk66ojURFnGqahRv9IYAhgumqNGFFMOfRkMUzjkIAqI=.9a8c6550-f6d1-4ee2-b53b-54dc6491ff0e@github.com>
 <Wz8nlNpeWgJKwr9Keb8ydCDT0mn6Q1bdR4CK50zCPZ8=.f39e7e08-9ec2-472a-9c19-6ecaad9b1f04@github.com>
 <TsbWXpNEfDOdyQ_1opNjH9LySOsVOU2lcM7xZJ60eYA=.74e9988c-beb6-4388-b263-5db0f1edc98a@github.com>
Message-ID: <eZS662QHcPnAwt8Qg--Og5QFWXF5FkU3cGfn-yYgELg=.9e60d711-e97f-4e25-adbd-9ef60779a23a@github.com>

On Tue, 12 Mar 2024 09:00:18 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

>> test/jdk/javax/swing/JDesktopPane/4773378/bug4773378.java line 69:
>> 
>>> 67:                         keyTyped = true;
>>> 68:                         bug4773378.this.notifyAll();
>>> 69:                     }
>> 
>> A `CountDownLatch` would work great in this case.
>> 
>> And `keyTyped` is a confusing name for a flag which gets to `true` when the internal frame is activated.
>
> Renamed as frameActivated

I'm still for using `CountDownLatch`, it looks cleaner in my opinion.

>> test/jdk/javax/swing/JEditorPane/4325606/bug4325606.java line 115:
>> 
>>> 113:         try {
>>> 114:             SwingUtilities.invokeAndWait(b::setupGUI);
>>> 115:             safeSleep(3000);
>> 
>> Instead of sleeping, you can use a `CountDownLatch(3)` which you'll `countDown()` for each mouse click. Here you'll call `await(3, TimeUnit.SECONDS)` and throw a timeout error if `await` returns `false`.
>> 
>> Another synchroniser may be used to handle the case where `BadLocationException` is thrown to fail the test right away. Alternatively, `BadLocationException` may be wrapped into `RuntimeException` and re-thrown.
>
> This is a very simple case and sleeping worked for it so i do not see reason to rewrite it with CDL.

Using CDL can reduce the execution time? likely the three clicks are handled more quickly than in 3 seconds.

>> test/jdk/javax/swing/JEditorPane/4694598/FrameContent.html line 1:
>> 
>>> 1: <HTML><BODY>
>> 
>> Can this file be created by the test on the fly? There's no need for a supporting file.
>> 
>> In #18147, Prasanta handled the same situation.
>
> I prefer to keep things simpler and not to create an additional possible point of failure. The supporting html file is self-explanatory and, if needed, can be changed outside of fixing the test itself.

It will make the test self-contained, which, in my opinion, is preferred.

>> test/jdk/javax/swing/JEditorPane/4694598/bug4694598.java line 29:
>> 
>>> 27:  * @summary JEditor pane throws NullPointerException on mouse movement.
>>> 28:  * @library ../../regtesthelpers
>>> 29:  * @build JRobot
>> 
>> The test doesn't seem to use any of the extended functionality provided by JRobot, so the standard `java.awt.Robot` can be used instead.
>
> I do not see any harm in using JRobot, it is a Swing test after all.

No harm but a dependency on a library which isn't used.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18184#discussion_r1521350860
PR Review Comment: https://git.openjdk.org/jdk/pull/18184#discussion_r1521346223
PR Review Comment: https://git.openjdk.org/jdk/pull/18184#discussion_r1521347941
PR Review Comment: https://git.openjdk.org/jdk/pull/18184#discussion_r1521348935

From aivanov at openjdk.org  Tue Mar 12 12:15:17 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 12 Mar 2024 12:15:17 GMT
Subject: RFR: 8316388: Opensource five Swing component related regression
 tests
In-Reply-To: <PhNQ1C_THcjABeR2F3S3qgS7gcGbXgqrXw4UHjRj7yc=.6465bdd3-f135-47bb-abcc-463150d919a3@github.com>
References: <bk66ojURFnGqahRv9IYAhgumqNGFFMOfRkMUzjkIAqI=.9a8c6550-f6d1-4ee2-b53b-54dc6491ff0e@github.com>
 <PhNQ1C_THcjABeR2F3S3qgS7gcGbXgqrXw4UHjRj7yc=.6465bdd3-f135-47bb-abcc-463150d919a3@github.com>
Message-ID: <CTl9tH_q3Zhe6w2Cv4sYDsdfSqjZJMdk0urzpzqGQF0=.06112d28-1f9d-4411-92d2-636f34530637@github.com>

On Tue, 12 Mar 2024 09:34:38 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

> I would prefer to keep the directory structure - it does not make any difference after al and sometimes makes test logs more readable.

At times, I find it easier to manage in IDE either. Just mark one folder as Test Sources, and it brings only one test. A folder with lots of tests often results in compilation errors because of duplicate classes and so on.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18184#issuecomment-1991512231

From aivanov at openjdk.org  Tue Mar 12 12:18:15 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 12 Mar 2024 12:18:15 GMT
Subject: RFR: 8316388: Opensource five Swing component related regression
 tests [v2]
In-Reply-To: <eZS662QHcPnAwt8Qg--Og5QFWXF5FkU3cGfn-yYgELg=.9e60d711-e97f-4e25-adbd-9ef60779a23a@github.com>
References: <bk66ojURFnGqahRv9IYAhgumqNGFFMOfRkMUzjkIAqI=.9a8c6550-f6d1-4ee2-b53b-54dc6491ff0e@github.com>
 <Wz8nlNpeWgJKwr9Keb8ydCDT0mn6Q1bdR4CK50zCPZ8=.f39e7e08-9ec2-472a-9c19-6ecaad9b1f04@github.com>
 <TsbWXpNEfDOdyQ_1opNjH9LySOsVOU2lcM7xZJ60eYA=.74e9988c-beb6-4388-b263-5db0f1edc98a@github.com>
 <eZS662QHcPnAwt8Qg--Og5QFWXF5FkU3cGfn-yYgELg=.9e60d711-e97f-4e25-adbd-9ef60779a23a@github.com>
Message-ID: <HYgonFsl_obFVOBpSQfkShxjkG1w0VjGMUMgeaAsMR8=.31ad8c3c-4b1b-4f2d-883d-1b3dfd562304@github.com>

On Tue, 12 Mar 2024 12:05:33 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> This is a very simple case and sleeping worked for it so i do not see reason to rewrite it with CDL.
>
> Using CDL can reduce the execution time? likely the three clicks are handled more quickly than in 3 seconds.

On the other hand, overengineering a simple case could do more harm? as using `CountDownLatch` isn't straightforward in this case.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18184#discussion_r1521358716

From aivanov at openjdk.org  Tue Mar 12 12:21:19 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 12 Mar 2024 12:21:19 GMT
Subject: RFR: 8316388: Opensource five Swing component related regression
 tests [v2]
In-Reply-To: <GJGNjOXshSl4w7-HD0zKHcMid8DhMMkObc2quQfEt58=.83082644-94fe-4e14-8fd7-cc4141c41a33@github.com>
References: <bk66ojURFnGqahRv9IYAhgumqNGFFMOfRkMUzjkIAqI=.9a8c6550-f6d1-4ee2-b53b-54dc6491ff0e@github.com>
 <Wz8nlNpeWgJKwr9Keb8ydCDT0mn6Q1bdR4CK50zCPZ8=.f39e7e08-9ec2-472a-9c19-6ecaad9b1f04@github.com>
 <rUm-kOKAOHaPEQV2BfxmaYHQNd3rEu_IP5CrT7pSz2w=.6f9c023b-8ed8-4a8a-9667-57092c3b14a8@github.com>
 <GJGNjOXshSl4w7-HD0zKHcMid8DhMMkObc2quQfEt58=.83082644-94fe-4e14-8fd7-cc4141c41a33@github.com>
Message-ID: <f7YH-ZUti5QrS8-S3ygFr1Hj9XVNiiLqX1woPi_I_6c=.8d5ee0d4-2125-4ec6-bce7-fe45b431d584@github.com>

On Tue, 12 Mar 2024 11:58:40 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> It is not unexpected but instead of failing i think test should just pass. Which will happen because the internal frame is not minimized so the test condition is not recreated.
>
> I believe it's unexpected because we don't expect `PropertyVetoException`, in which case failure seems a better option.
> 
> If anything changes so that `PropertyVetoException` would be thrown all the time, the test would appear to be passing whereas it would not run at all.

This is the only point with which I *disagree*.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18184#discussion_r1521362228

From psadhukhan at openjdk.org  Tue Mar 12 12:25:17 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Tue, 12 Mar 2024 12:25:17 GMT
Subject: Integrated: 8327751: Convert
 javax/swing/JInternalFrame/6726866/bug6726866.java applet test to main
In-Reply-To: <C5clTEn-okNdD5RVu8jcJW8T9bluj4GTy7BDNxUwKy0=.6b278225-50fa-4714-a066-8ad465cd9766@github.com>
References: <C5clTEn-okNdD5RVu8jcJW8T9bluj4GTy7BDNxUwKy0=.6b278225-50fa-4714-a066-8ad465cd9766@github.com>
Message-ID: <t7O5ckCDKcbhyr9F5MbW8W_dwlY80v1nKYzq1UX8c_g=.a69a7743-1f25-4e70-97c5-72afa4f0fd2c@github.com>

On Mon, 11 Mar 2024 10:02:21 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> Conversion of manual applet test to main based using PassFailJFrame manual framework

This pull request has now been integrated.

Changeset: cfd9209e
Author:    Prasanta Sadhukhan <psadhukhan at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/cfd9209e03176bd8e02acd74b51a16f3113fbd21
Stats:     59 lines in 2 files changed: 19 ins; 32 del; 8 mod

8327751: Convert javax/swing/JInternalFrame/6726866/bug6726866.java applet test to main

Reviewed-by: aivanov

-------------

PR: https://git.openjdk.org/jdk/pull/18186

From psadhukhan at openjdk.org  Tue Mar 12 12:33:37 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Tue, 12 Mar 2024 12:33:37 GMT
Subject: RFR: 8327748: Convert
 javax/swing/JFileChooser/6798062/bug6798062.java applet test to main [v5]
In-Reply-To: <lGQbwCvyqdtOr8-NxY9l3pZC4mRPn7gBtd7qPIRPF-I=.0379a965-6ad2-44ba-abfe-ecd0ed3f7b02@github.com>
References: <lGQbwCvyqdtOr8-NxY9l3pZC4mRPn7gBtd7qPIRPF-I=.0379a965-6ad2-44ba-abfe-ecd0ed3f7b02@github.com>
Message-ID: <HfDGjrhdqe454Ovwyin0FMWuTmbf_vqNKbKgmkWX3UU=.a20a0408-56b4-422c-a873-1145ddc8baa9@github.com>

> Conversion of manual applet test to main based using PassFailJFrame manual framework

Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:

  Revert to tempDir

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18180/files
  - new: https://git.openjdk.org/jdk/pull/18180/files/abd16b4f..d2da657b

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18180&range=04
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18180&range=03-04

  Stats: 12 lines in 1 file changed: 9 ins; 1 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/18180.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18180/head:pull/18180

PR: https://git.openjdk.org/jdk/pull/18180

From azvegint at openjdk.org  Tue Mar 12 12:39:34 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Tue, 12 Mar 2024 12:39:34 GMT
Subject: RFR: 8327972: Convert
 java/awt/FileDialog/SaveFileNameOverrideTest/SaveFileNameOverrideTest.html
 applet test to main
Message-ID: <aAQg8fWlF7MafeuvNc76VYN5p6LBosaENVTOluAigfM=.b47d5d3e-6edc-4843-990f-cb489eb1aed9@github.com>

The test is converted to main.
Tested on Linux, Macos and Windows.

-------------

Commit messages:
 - test move
 - 8327972: Convert java/awt/FileDialog/SaveFileNameOverrideTest/SaveFileNameOverrideTest.html applet test to main

Changes: https://git.openjdk.org/jdk/pull/18231/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18231&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8327972
  Stats: 225 lines in 3 files changed: 91 ins; 134 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18231.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18231/head:pull/18231

PR: https://git.openjdk.org/jdk/pull/18231

From aivanov at openjdk.org  Tue Mar 12 12:40:15 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 12 Mar 2024 12:40:15 GMT
Subject: RFR: 8327748: Convert
 javax/swing/JFileChooser/6798062/bug6798062.java applet test to main [v3]
In-Reply-To: <BuJF_WEENS6BlNK7cOfB32-1ugXTos4FkO9VpTvlLvs=.3f2987a7-a5d8-43e8-955b-e3434c5d9e9e@github.com>
References: <lGQbwCvyqdtOr8-NxY9l3pZC4mRPn7gBtd7qPIRPF-I=.0379a965-6ad2-44ba-abfe-ecd0ed3f7b02@github.com>
 <S7B9SumsKmtgNCkT9j8t8_wPVBZe05ZPg7V0MbDVSy4=.9dca42c1-76df-45b0-9d82-c9571168c8b5@github.com>
 <BuJF_WEENS6BlNK7cOfB32-1ugXTos4FkO9VpTvlLvs=.3f2987a7-a5d8-43e8-955b-e3434c5d9e9e@github.com>
Message-ID: <x39IorR4on7EDgwcYAiSYY6ffpVpX9AsbM9owXfpg6k=.ccf5efd2-00e9-4b20-a641-47af272443ef@github.com>

On Tue, 12 Mar 2024 10:59:48 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review comment update
>
> test/jdk/javax/swing/JFileChooser/6798062/bug6798062.java line 60:
> 
>> 58: 
>> 59:             1. Create a link
>> 60:             2. Copy path to the link into TextField
> 
> I understand the instructions aren't new but I can't comprehend what it's required.
> 
> Does it mean a Windows shortcut, `.lnk` file? Seems like it's the case because `getLinkLocation` is called which resolves a shortcut to its original file.
> 
> Can the text field be pre-populated with a default? There could be shortcuts on Desktop, there are many shortcuts in the Start menu.

Could you amend the instructions to clarify them?

Define what is a _link_.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18180#discussion_r1521390282

From azvegint at openjdk.org  Tue Mar 12 12:42:14 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Tue, 12 Mar 2024 12:42:14 GMT
Subject: RFR: 8327972: Convert
 java/awt/FileDialog/SaveFileNameOverrideTest/SaveFileNameOverrideTest.html
 applet test to main
In-Reply-To: <aAQg8fWlF7MafeuvNc76VYN5p6LBosaENVTOluAigfM=.b47d5d3e-6edc-4843-990f-cb489eb1aed9@github.com>
References: <aAQg8fWlF7MafeuvNc76VYN5p6LBosaENVTOluAigfM=.b47d5d3e-6edc-4843-990f-cb489eb1aed9@github.com>
Message-ID: <Hy6jTalLLUL9bmsJP-TJ0_v4qt5BilSJTIYS55U7nTI=.54d5423e-0ae2-4a3f-8ae5-5df444f6af79@github.com>

On Tue, 12 Mar 2024 12:34:57 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

> The test is converted to main.
> Tested on Linux, Macos and Windows.

test/jdk/java/awt/FileDialog/SaveFileNameOverrideTest.java line 79:

> 77: 
> 78:             fd.setFile("input");
> 79:             fd.setDirectory(new File(dirPath).getAbsolutePath());

Originally it was just the `dirPath` (== `.`).
However, a recently opened directory is opened when we pass `.` to `setDirectory` on WIndows. 
To make the test consistent, the absolute path is used.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18231#discussion_r1521393330

From aivanov at openjdk.org  Tue Mar 12 12:45:13 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 12 Mar 2024 12:45:13 GMT
Subject: RFR: 8327748: Convert
 javax/swing/JFileChooser/6798062/bug6798062.java applet test to main [v3]
In-Reply-To: <x39IorR4on7EDgwcYAiSYY6ffpVpX9AsbM9owXfpg6k=.ccf5efd2-00e9-4b20-a641-47af272443ef@github.com>
References: <lGQbwCvyqdtOr8-NxY9l3pZC4mRPn7gBtd7qPIRPF-I=.0379a965-6ad2-44ba-abfe-ecd0ed3f7b02@github.com>
 <S7B9SumsKmtgNCkT9j8t8_wPVBZe05ZPg7V0MbDVSy4=.9dca42c1-76df-45b0-9d82-c9571168c8b5@github.com>
 <BuJF_WEENS6BlNK7cOfB32-1ugXTos4FkO9VpTvlLvs=.3f2987a7-a5d8-43e8-955b-e3434c5d9e9e@github.com>
 <x39IorR4on7EDgwcYAiSYY6ffpVpX9AsbM9owXfpg6k=.ccf5efd2-00e9-4b20-a641-47af272443ef@github.com>
Message-ID: <y6ltqyjpnM2Z7H2MiY4CXNxG5Kof6ctjcCBn-SxvstQ=.df6be3bb-153c-413d-9813-b6df10f23cad@github.com>

On Tue, 12 Mar 2024 12:37:18 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> test/jdk/javax/swing/JFileChooser/6798062/bug6798062.java line 60:
>> 
>>> 58: 
>>> 59:             1. Create a link
>>> 60:             2. Copy path to the link into TextField
>> 
>> I understand the instructions aren't new but I can't comprehend what it's required.
>> 
>> Does it mean a Windows shortcut, `.lnk` file? Seems like it's the case because `getLinkLocation` is called which resolves a shortcut to its original file.
>> 
>> Can the text field be pre-populated with a default? There could be shortcuts on Desktop, there are many shortcuts in the Start menu.
>
> Could you amend the instructions to clarify them?
> 
> Define what is a _link_.

It seems a Windows shortcut is crucial to reproducing the original problem, if it is, the handler for the Start button could show an error message about this fact.

Perhaps, if this link cannot be converted to a file in `MyThread` constructor, `FileNotFoundException` should be propagated and caught in the Start button actionPerformed handler to show an error message and let the tester use another Windows shortcut.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18180#discussion_r1521398715

From psadhukhan at openjdk.org  Tue Mar 12 12:50:13 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Tue, 12 Mar 2024 12:50:13 GMT
Subject: RFR: 8327748: Convert
 javax/swing/JFileChooser/6798062/bug6798062.java applet test to main [v3]
In-Reply-To: <y6ltqyjpnM2Z7H2MiY4CXNxG5Kof6ctjcCBn-SxvstQ=.df6be3bb-153c-413d-9813-b6df10f23cad@github.com>
References: <lGQbwCvyqdtOr8-NxY9l3pZC4mRPn7gBtd7qPIRPF-I=.0379a965-6ad2-44ba-abfe-ecd0ed3f7b02@github.com>
 <S7B9SumsKmtgNCkT9j8t8_wPVBZe05ZPg7V0MbDVSy4=.9dca42c1-76df-45b0-9d82-c9571168c8b5@github.com>
 <BuJF_WEENS6BlNK7cOfB32-1ugXTos4FkO9VpTvlLvs=.3f2987a7-a5d8-43e8-955b-e3434c5d9e9e@github.com>
 <x39IorR4on7EDgwcYAiSYY6ffpVpX9AsbM9owXfpg6k=.ccf5efd2-00e9-4b20-a641-47af272443ef@github.com>
 <y6ltqyjpnM2Z7H2MiY4CXNxG5Kof6ctjcCBn-SxvstQ=.df6be3bb-153c-413d-9813-b6df10f23cad@github.com>
Message-ID: <sww2BAnuOI35JAi6LRJnJKjz2R5U3xz6WdmytXHJk8k=.86e043c2-7c2e-4a49-a752-1d79d15f16c5@github.com>

On Tue, 12 Mar 2024 12:42:53 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Could you amend the instructions to clarify them?
>> 
>> Define what is a _link_.
>
> It seems a Windows shortcut is crucial to reproducing the original problem, if it is, the handler for the Start button could show an error message about this fact.
> 
> Perhaps, if this link cannot be converted to a file in `MyThread` constructor, `FileNotFoundException` should be propagated and caught in the Start button actionPerformed handler to show an error message and let the tester use another Windows shortcut.

SInce this exercise is just to convert applet to main, I tried to keep the instructions same (although I agree it seems ambiguous and I also am not clear what needs to be done) which seems to be ok with the tester since 2009 when the test was written.
I think whatever test change needs to be done should be done in JDK-8146446 as till then this test will not be run..

ELse if you disagree, what you propose to be written in the "instructions"?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18180#discussion_r1521405837

From aivanov at openjdk.org  Tue Mar 12 12:54:14 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 12 Mar 2024 12:54:14 GMT
Subject: RFR: 8327856: Convert applet test SpanishDiacriticsTest.java to a
 main program
In-Reply-To: <JnPnHUoBMQd1YGVtRimzTC2Y5Sn5ezSWq2Fkw9jh-KA=.8df82997-452b-41c9-a698-68ab33e49f13@github.com>
References: <JnPnHUoBMQd1YGVtRimzTC2Y5Sn5ezSWq2Fkw9jh-KA=.8df82997-452b-41c9-a698-68ab33e49f13@github.com>
Message-ID: <SNg1zw2YMUUXhrWAnzfI7NjNDK4dJjwgSxGwIQ1heuM=.74e12e8f-25cf-4c61-b4b5-da3b1bdde99c@github.com>

On Mon, 11 Mar 2024 23:02:53 GMT, Phil Race <prr at openjdk.org> wrote:

> Converts the  manual applet test in the files ..
> SpanishDiacriticsTest/SpanishDiacriticsTest.html
> SpanishDiacriticsTest/SpanishDiacriticsTest.java
> .. to a main program using PassFailJFrame
> 
> Added requires windows since it seems very windows-specific.
> 
> I got rid of the redundant extra directory which makes the .java file "new" according to github but it is largely changed anyway

test/jdk/java/awt/InputMethods/SpanishDiacriticsTest.java line 60:

> 58:           expected behaviour for this test.
> 59: 
> 60:        If the text field displays ''o, (i.e. o should be without an acute)

Suggestion:

       If the text field displays \u00f3, (i.e. o should be without an acute)

Use the real character?

test/jdk/java/awt/InputMethods/SpanishDiacriticsTest.java line 71:

> 69:                       .rows(18)
> 70:                       .columns(50)
> 71:                       .testUI(() -> createTestUI())

Suggestion:

                      .testUI(SpanishDiacriticsTest::createTestUI)

I prefer method references in such cases, it looks cleaner.

test/jdk/java/awt/InputMethods/SpanishDiacriticsTest.java line 72:

> 70:                       .columns(50)
> 71:                       .testUI(() -> createTestUI())
> 72:                       .testTimeOut(5)

Default timeout could be omitted.

test/jdk/java/awt/InputMethods/SpanishDiacriticsTest.java line 89:

> 87:         frame.setDefaultCloseOperation(WindowConstants.EXIT_ON_CLOSE);
> 88:         frame.pack();
> 89:         frame.setVisible(true);

Suggestion:

        frame.pack();

Calling `setVisible(true)` here causes flickering as the frame gets shown at its default location and later gets moved to its final location.

Setting close operation is redundant, `PassFailJFrame` handles closing test UI (when you use the builder pattern) and fails the test.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18208#discussion_r1521405668
PR Review Comment: https://git.openjdk.org/jdk/pull/18208#discussion_r1521410458
PR Review Comment: https://git.openjdk.org/jdk/pull/18208#discussion_r1521410885
PR Review Comment: https://git.openjdk.org/jdk/pull/18208#discussion_r1521409226

From psadhukhan at openjdk.org  Tue Mar 12 12:55:25 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Tue, 12 Mar 2024 12:55:25 GMT
Subject: RFR: 8327748: Convert
 javax/swing/JFileChooser/6798062/bug6798062.java applet test to main [v6]
In-Reply-To: <lGQbwCvyqdtOr8-NxY9l3pZC4mRPn7gBtd7qPIRPF-I=.0379a965-6ad2-44ba-abfe-ecd0ed3f7b02@github.com>
References: <lGQbwCvyqdtOr8-NxY9l3pZC4mRPn7gBtd7qPIRPF-I=.0379a965-6ad2-44ba-abfe-ecd0ed3f7b02@github.com>
Message-ID: <SEF_fSE0f4scb0mYayn2H02lvy22hN11Q8qVkxEByoE=.33c9b665-da31-44f5-bc7f-44ff9da8526a@github.com>

> Conversion of manual applet test to main based using PassFailJFrame manual framework

Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:

  review comment update

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18180/files
  - new: https://git.openjdk.org/jdk/pull/18180/files/d2da657b..8c8d1b90

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18180&range=05
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18180&range=04-05

  Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/18180.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18180/head:pull/18180

PR: https://git.openjdk.org/jdk/pull/18180

From abhiscxk at openjdk.org  Tue Mar 12 12:56:20 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Tue, 12 Mar 2024 12:56:20 GMT
Subject: RFR: 8327980: Convert
 javax/swing/JToggleButton/4128979/bug4128979.java applet test to main
Message-ID: <lZHt9pYb75UtaIEtbB0paOkfqR5CUAc6tikhb9YAakU=.ff2adbed-1db2-490a-8747-66ac96d03657@github.com>

Conversion of manual applet test to main based using PassFailJFrame manual framework

-------------

Commit messages:
 - whitespace fix
 - Applet test converted to main manual

Changes: https://git.openjdk.org/jdk/pull/18233/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18233&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8327980
  Stats: 114 lines in 2 files changed: 27 ins; 61 del; 26 mod
  Patch: https://git.openjdk.org/jdk/pull/18233.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18233/head:pull/18233

PR: https://git.openjdk.org/jdk/pull/18233

From psadhukhan at openjdk.org  Tue Mar 12 13:21:19 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Tue, 12 Mar 2024 13:21:19 GMT
Subject: RFR: 8327753: Convert javax/swing/JOptionPane/8024926/bug8024926.java
 applet to main
Message-ID: <Mh1aFrqe1Kw2tD_2nNzeAoMRhSWzNoh67d-2yTqoIPE=.e8e324d4-f0fa-4b41-b2ea-39cc18faf088@github.com>

Conversion of manual applet test to main based using PassFailJFrame manual framework

-------------

Commit messages:
 - fix
 - 8327753: Convert javax/swing/JOptionPane/8024926/bug8024926.java applet to main

Changes: https://git.openjdk.org/jdk/pull/18232/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18232&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8327753
  Stats: 213 lines in 2 files changed: 5 ins; 178 del; 30 mod
  Patch: https://git.openjdk.org/jdk/pull/18232.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18232/head:pull/18232

PR: https://git.openjdk.org/jdk/pull/18232

From aivanov at openjdk.org  Tue Mar 12 13:39:23 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 12 Mar 2024 13:39:23 GMT
Subject: RFR: 8320079: The ArabicBox.java test has no control buttons
Message-ID: <uW_uKMlwlOFidrejEZ7wkFRyC4Kqx_MmSQdenASo6EQ=.aebdca22-c37d-40f8-8d48-8f298f082adf@github.com>

The test is converted to use `PassFailJFrame`.

I confirmed the updated test reproduce the original problem described in [JDK-4427483](https://bugs.openjdk.org/browse/JDK-4427483) where Arabic text displayed as missing glyphs.

-------------

Commit messages:
 - 8320079: The ArabicBox.java test has no control buttons

Changes: https://git.openjdk.org/jdk/pull/18234/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18234&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8320079
  Stats: 103 lines in 1 file changed: 103 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18234.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18234/head:pull/18234

PR: https://git.openjdk.org/jdk/pull/18234

From aivanov at openjdk.org  Tue Mar 12 13:42:13 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 12 Mar 2024 13:42:13 GMT
Subject: RFR: 8327748: Convert
 javax/swing/JFileChooser/6798062/bug6798062.java applet test to main [v3]
In-Reply-To: <sww2BAnuOI35JAi6LRJnJKjz2R5U3xz6WdmytXHJk8k=.86e043c2-7c2e-4a49-a752-1d79d15f16c5@github.com>
References: <lGQbwCvyqdtOr8-NxY9l3pZC4mRPn7gBtd7qPIRPF-I=.0379a965-6ad2-44ba-abfe-ecd0ed3f7b02@github.com>
 <S7B9SumsKmtgNCkT9j8t8_wPVBZe05ZPg7V0MbDVSy4=.9dca42c1-76df-45b0-9d82-c9571168c8b5@github.com>
 <BuJF_WEENS6BlNK7cOfB32-1ugXTos4FkO9VpTvlLvs=.3f2987a7-a5d8-43e8-955b-e3434c5d9e9e@github.com>
 <x39IorR4on7EDgwcYAiSYY6ffpVpX9AsbM9owXfpg6k=.ccf5efd2-00e9-4b20-a641-47af272443ef@github.com>
 <y6ltqyjpnM2Z7H2MiY4CXNxG5Kof6ctjcCBn-SxvstQ=.df6be3bb-153c-413d-9813-b6df10f23cad@github.com>
 <sww2BAnuOI35JAi6LRJnJKjz2R5U3xz6WdmytXHJk8k=.86e043c2-7c2e-4a49-a752-1d79d15f16c5@github.com>
Message-ID: <ryxiNiPeJQIo4I901HkAIcb18sYaUtYGJ_96LubBvQU=.8e1e89cf-043b-4e29-aa82-b9e820edccbe@github.com>

On Tue, 12 Mar 2024 12:47:55 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> It seems a Windows shortcut is crucial to reproducing the original problem, if it is, the handler for the Start button could show an error message about this fact.
>> 
>> Perhaps, if this link cannot be converted to a file in `MyThread` constructor, `FileNotFoundException` should be propagated and caught in the Start button actionPerformed handler to show an error message and let the tester use another Windows shortcut.
>
> SInce this exercise is just to convert applet to main, I tried to keep the instructions same (although I agree it seems ambiguous and I also am not clear what needs to be done) which seems to be ok with the tester since 2009 when the test was written.
> I think whatever test change needs to be done should be done in JDK-8146446 as till then this test will not be run..
> 
> ELse if you disagree, what you propose to be written in the "instructions"?

Create a new bug to improve and to clean up the test then.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18180#discussion_r1521485042

From aivanov at openjdk.org  Tue Mar 12 13:47:16 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 12 Mar 2024 13:47:16 GMT
Subject: RFR: 8327748: Convert
 javax/swing/JFileChooser/6798062/bug6798062.java applet test to main [v3]
In-Reply-To: <ryxiNiPeJQIo4I901HkAIcb18sYaUtYGJ_96LubBvQU=.8e1e89cf-043b-4e29-aa82-b9e820edccbe@github.com>
References: <lGQbwCvyqdtOr8-NxY9l3pZC4mRPn7gBtd7qPIRPF-I=.0379a965-6ad2-44ba-abfe-ecd0ed3f7b02@github.com>
 <S7B9SumsKmtgNCkT9j8t8_wPVBZe05ZPg7V0MbDVSy4=.9dca42c1-76df-45b0-9d82-c9571168c8b5@github.com>
 <BuJF_WEENS6BlNK7cOfB32-1ugXTos4FkO9VpTvlLvs=.3f2987a7-a5d8-43e8-955b-e3434c5d9e9e@github.com>
 <x39IorR4on7EDgwcYAiSYY6ffpVpX9AsbM9owXfpg6k=.ccf5efd2-00e9-4b20-a641-47af272443ef@github.com>
 <y6ltqyjpnM2Z7H2MiY4CXNxG5Kof6ctjcCBn-SxvstQ=.df6be3bb-153c-413d-9813-b6df10f23cad@github.com>
 <sww2BAnuOI35JAi6LRJnJKjz2R5U3xz6WdmytXHJk8k=.86e043c2-7c2e-4a49-a752-1d79d15f16c5@github.com>
 <ryxiNiPeJQIo4I901HkAIcb18sYaUtYGJ_96LubBvQU=.8e1e89cf-043b-4e29-aa82-b9e820edccbe@github.com>
Message-ID: <l02iEzPmx3VTgYTvYWXJn5L0BCgApaMMdm56oll5Ubk=.1c1c5147-4977-451c-8e9a-e568f14d66d4@github.com>

On Tue, 12 Mar 2024 13:39:43 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> SInce this exercise is just to convert applet to main, I tried to keep the instructions same (although I agree it seems ambiguous and I also am not clear what needs to be done) which seems to be ok with the tester since 2009 when the test was written.
>> I think whatever test change needs to be done should be done in JDK-8146446 as till then this test will not be run..
>> 
>> ELse if you disagree, what you propose to be written in the "instructions"?
>
> Create a new bug to improve and to clean up the test then.

At the same time, I think you should use the term _?shortcut (.lnk file)?_ in the instructions so that it's clear.

The thing is .lnk files are known as shortcuts for most users, even though in Windows Shell API uses link internally which is reflected in the file extension.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18180#discussion_r1521489601

From abhiscxk at openjdk.org  Tue Mar 12 13:47:29 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Tue, 12 Mar 2024 13:47:29 GMT
Subject: RFR: 8327872: Convert javax/swing/JToolTip/4644444/bug4644444.java
 applet test to main [v2]
In-Reply-To: <gQj8exwWxjXFUAyXBGVxxXeflmLCCUQJ8flxhU22-7I=.75d72581-8868-4dc4-9736-af6e54dbe3ca@github.com>
References: <gQj8exwWxjXFUAyXBGVxxXeflmLCCUQJ8flxhU22-7I=.75d72581-8868-4dc4-9736-af6e54dbe3ca@github.com>
Message-ID: <5h_Cx5GZBks5nYsBwPD5qVFIVDln4nHsRKgILyFtLf0=.bfc00fee-21c6-4af4-8102-3c63a681ff94@github.com>

> Conversion of manual applet test to main based using PassFailJFrame manual framework

Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:

  Review comment fix

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18212/files
  - new: https://git.openjdk.org/jdk/pull/18212/files/5e6fc19d..0d0af40d

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18212&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18212&range=00-01

  Stats: 6 lines in 1 file changed: 0 ins; 3 del; 3 mod
  Patch: https://git.openjdk.org/jdk/pull/18212.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18212/head:pull/18212

PR: https://git.openjdk.org/jdk/pull/18212

From abhiscxk at openjdk.org  Tue Mar 12 13:47:30 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Tue, 12 Mar 2024 13:47:30 GMT
Subject: RFR: 8327872: Convert javax/swing/JToolTip/4644444/bug4644444.java
 applet test to main [v2]
In-Reply-To: <SqocsgM1nPezAN2BSwFPkbOy62IlWYyVpVimaCMqqos=.4f16ac01-9577-41d0-a911-47d59ff3a723@github.com>
References: <gQj8exwWxjXFUAyXBGVxxXeflmLCCUQJ8flxhU22-7I=.75d72581-8868-4dc4-9736-af6e54dbe3ca@github.com>
 <SqocsgM1nPezAN2BSwFPkbOy62IlWYyVpVimaCMqqos=.4f16ac01-9577-41d0-a911-47d59ff3a723@github.com>
Message-ID: <dUXx2oAWD6y7XHogjgVTkNQXMCNB-pPD9YpA6VPqs74=.5311703b-96f5-4a87-8fac-c94a3f23d2f6@github.com>

On Tue, 12 Mar 2024 10:03:10 GMT, Tejesh R <tr at openjdk.org> wrote:

> Both frame and button can be inside creatUI()

Updated.

> If you can use splitUI instead of testUI that would be even better.

Since the original bug [JDK-4644444](https://bugs.openjdk.org/browse/JDK-4644444) says `JToolTip is shown partially when placed very close to screen boundaries`, it would not be a good idea to use splitUI. User may not be able to move the testUI near screen boundaries.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18212#discussion_r1521491592

From abhiscxk at openjdk.org  Tue Mar 12 13:50:42 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Tue, 12 Mar 2024 13:50:42 GMT
Subject: RFR: 8327872: Convert javax/swing/JToolTip/4644444/bug4644444.java
 applet test to main [v3]
In-Reply-To: <gQj8exwWxjXFUAyXBGVxxXeflmLCCUQJ8flxhU22-7I=.75d72581-8868-4dc4-9736-af6e54dbe3ca@github.com>
References: <gQj8exwWxjXFUAyXBGVxxXeflmLCCUQJ8flxhU22-7I=.75d72581-8868-4dc4-9736-af6e54dbe3ca@github.com>
Message-ID: <TlcvBlcu2t7ig3X4uSywRm8W3dOIYvA810VC8dFmA0I=.df4d1b49-6fbb-4752-a8f2-2e605f686083@github.com>

> Conversion of manual applet test to main based using PassFailJFrame manual framework

Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:

  Remove commented line

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18212/files
  - new: https://git.openjdk.org/jdk/pull/18212/files/0d0af40d..0892ab7c

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18212&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18212&range=01-02

  Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18212.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18212/head:pull/18212

PR: https://git.openjdk.org/jdk/pull/18212

From psadhukhan at openjdk.org  Tue Mar 12 13:52:28 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Tue, 12 Mar 2024 13:52:28 GMT
Subject: RFR: 8327748: Convert
 javax/swing/JFileChooser/6798062/bug6798062.java applet test to main [v7]
In-Reply-To: <lGQbwCvyqdtOr8-NxY9l3pZC4mRPn7gBtd7qPIRPF-I=.0379a965-6ad2-44ba-abfe-ecd0ed3f7b02@github.com>
References: <lGQbwCvyqdtOr8-NxY9l3pZC4mRPn7gBtd7qPIRPF-I=.0379a965-6ad2-44ba-abfe-ecd0ed3f7b02@github.com>
Message-ID: <Gl6Z_Livy_Y3IFUf1XPjMq6ABEW1e_D1nTJ0ZWY90Ro=.607af534-ec8e-428f-841e-8ab656e673fd@github.com>

> Conversion of manual applet test to main based using PassFailJFrame manual framework

Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:

  instruction update

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18180/files
  - new: https://git.openjdk.org/jdk/pull/18180/files/8c8d1b90..e994fcda

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18180&range=06
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18180&range=05-06

  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/18180.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18180/head:pull/18180

PR: https://git.openjdk.org/jdk/pull/18180

From aivanov at openjdk.org  Tue Mar 12 13:59:15 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 12 Mar 2024 13:59:15 GMT
Subject: RFR: 8327748: Convert
 javax/swing/JFileChooser/6798062/bug6798062.java applet test to main [v7]
In-Reply-To: <Gl6Z_Livy_Y3IFUf1XPjMq6ABEW1e_D1nTJ0ZWY90Ro=.607af534-ec8e-428f-841e-8ab656e673fd@github.com>
References: <lGQbwCvyqdtOr8-NxY9l3pZC4mRPn7gBtd7qPIRPF-I=.0379a965-6ad2-44ba-abfe-ecd0ed3f7b02@github.com>
 <Gl6Z_Livy_Y3IFUf1XPjMq6ABEW1e_D1nTJ0ZWY90Ro=.607af534-ec8e-428f-841e-8ab656e673fd@github.com>
Message-ID: <c02pTlly3Zx4tPC1pWc1I68E2TJycUv1JymsPNP1W_8=.8a1ae468-8395-4036-a3aa-bdcfcc5882f3@github.com>

On Tue, 12 Mar 2024 13:52:28 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Conversion of manual applet test to main based using PassFailJFrame manual framework
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   instruction update

Marked as reviewed by aivanov (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18180#pullrequestreview-1931145301

From aivanov at openjdk.org  Tue Mar 12 13:59:15 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 12 Mar 2024 13:59:15 GMT
Subject: RFR: 8327748: Convert
 javax/swing/JFileChooser/6798062/bug6798062.java applet test to main [v3]
In-Reply-To: <l02iEzPmx3VTgYTvYWXJn5L0BCgApaMMdm56oll5Ubk=.1c1c5147-4977-451c-8e9a-e568f14d66d4@github.com>
References: <lGQbwCvyqdtOr8-NxY9l3pZC4mRPn7gBtd7qPIRPF-I=.0379a965-6ad2-44ba-abfe-ecd0ed3f7b02@github.com>
 <S7B9SumsKmtgNCkT9j8t8_wPVBZe05ZPg7V0MbDVSy4=.9dca42c1-76df-45b0-9d82-c9571168c8b5@github.com>
 <BuJF_WEENS6BlNK7cOfB32-1ugXTos4FkO9VpTvlLvs=.3f2987a7-a5d8-43e8-955b-e3434c5d9e9e@github.com>
 <x39IorR4on7EDgwcYAiSYY6ffpVpX9AsbM9owXfpg6k=.ccf5efd2-00e9-4b20-a641-47af272443ef@github.com>
 <y6ltqyjpnM2Z7H2MiY4CXNxG5Kof6ctjcCBn-SxvstQ=.df6be3bb-153c-413d-9813-b6df10f23cad@github.com>
 <sww2BAnuOI35JAi6LRJnJKjz2R5U3xz6WdmytXHJk8k=.86e043c2-7c2e-4a49-a752-1d79d15f16c5@github.com>
 <ryxiNiPeJQIo4I901HkAIcb18sYaUtYGJ_96LubBvQU=.8e1e89cf-043b-4e29-aa82-b9e820edccbe@github.com>
 <l02iEzPmx3VTgYTvYWXJn5L0BCgApaMMdm56oll5Ubk=.1c1c5147-4977-451c-8e9a-e568f14d66d4@github.com>
Message-ID: <0_ckfPYUpeQdobZZJ6ZnJiJnmXKxOklOZ3E4b9eXEbI=.67d1ed60-e96e-49e6-8c07-04a24db4aea3@github.com>

On Tue, 12 Mar 2024 13:42:28 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Create a new bug to improve and to clean up the test then.
>
> At the same time, I think you should use the term _?shortcut (.lnk file)?_ in the instructions so that it's clear.
> 
> The thing is .lnk files are known as shortcuts for most users, even though in Windows Shell API uses link internally which is reflected in the file extension.

> Create a new bug to improve and to clean up the test then.

I see, there's an existing bug?[JDK-8146446](https://bugs.openjdk.org/browse/JDK-8146446)?against this test. Although the bug describes that memory usage somewhat grows while the background thread is running, it actually does. It has just grown for me from 100MB to 300MB. Running `System.gc` reduces the memory consumption to 200 MB.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18180#discussion_r1521509910

From ihse at openjdk.org  Tue Mar 12 14:08:16 2024
From: ihse at openjdk.org (Magnus Ihse Bursie)
Date: Tue, 12 Mar 2024 14:08:16 GMT
Subject: RFR: 8315113: Print request Chromaticity.MONOCHROME attribute does
 not work on macOS
In-Reply-To: <m_OJNAf9YmC4OJMwtCM5P-eklmNJUymWJjMfo5s_wpI=.7d1c5a1f-2158-49f2-906d-dc074019cb99@github.com>
References: <m_OJNAf9YmC4OJMwtCM5P-eklmNJUymWJjMfo5s_wpI=.7d1c5a1f-2158-49f2-906d-dc074019cb99@github.com>
Message-ID: <8qVPKaqO0Y8go0K791uKhaxuCkmAP0v5S0ZdyBzeCtI=.1c22ea81-f39e-40f3-898a-02a0609d5831@github.com>

On Mon, 11 Mar 2024 13:54:02 GMT, Alexander Scherbatiy <alexsch at openjdk.org> wrote:

> The fix provides ability to print Black & White pages on macOS.
> 
> Cocoa API has [PMSetColorMode](https://developer.apple.com/documentation/applicationservices/core_printing/1805783-pmsetcolormode) function but it is marked as deprecated and really does nothing.
> 
> There is no replacement; this function was included to facilitate porting legacy applications to macOS, 
> but it serves no useful purpose.
> 
> Dumping `NSPrintInfo` print settings which were set by the native print dialog on macOS shows that the keys and values used for Black & White printing depend on the used printer type.
> For example, the tested 
> `HP Color LaserJet MFP M180n` printer uses `ColorModel` key and`Gray` value, and
> `HP Ink Tank 110 series` uses `HPColorMode` key and `grayscale` value.
> 
> Printing all `NSPrintInfo` presets shows that they do not contain key/value pairs  for Black&White settings.
> This is the code snippet used to print `NSPrintInfo` presets:
> 
>     PMPrinter pr;
>     PMPrintSession printSession = (PMPrintSession)[printInfo PMPrintSession];
>     OSStatus status = PMSessionGetCurrentPrinter(printSession, &pr);
>     CFArrayRef presetsList = nil;
>     status = PMPrinterCopyPresets(pr, &presetsList);
>     CFIndex arrayCount = CFArrayGetCount(presetsList);
> 
>     for (CFIndex index = 0; index < arrayCount; index++) {
>         PMPreset preset = (PMPreset)CFArrayGetValueAtIndex(presetsList, index);
>         CFStringRef presetName = nil;
>         if (PMPresetCopyName(preset, &presetName) == noErr && CFStringGetLength(presetName) > 0) {
>             NSLog(@"  presetName: '%@'", presetName);
>             NSDictionary* dict = nil;
>             if (PMPresetGetAttributes(preset, (CFDictionaryRef*)(&dict)) == noErr) {
>                    // print preset dict
> 
> 
> The idea of the proposed fix is to store printer dependent key/value pairs in the `<jdk-home>/conf/printer.properties` property file.
> 
> The property file has the format:
> 
> print-attribute.print-attribute-value.key=value
> 
> where `print-attribute` is the java print attribute, `print-attribute-value` is the corresponding attribute value, and `key` and `value` is the key/value pair used by a specific printer.
> 
> For example, for `Chromaticity` attribute the property file could look like:
> 
> Chromaticity.MONOCHROME.ColorModel=Gray
> Chromaticity.COLOR.ColorModel=CMYK
> Chromaticity.MONOCHROME.HPColorMode=grayscale
> Chromaticity.COLOR.HPColorMode=color
> 
> where `Chromaticity.MONOCHROME` key prefix corresponds to `Chromaticity.MONOCHOROME` print attribute constant  with  (...

Build changes look good. However, I think there is some kind of movement trying to *remove* stuff from the conf directory, rather than adding new files there. @AlanBateman might want to chime in on this.

-------------

Marked as reviewed by ihse (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18195#pullrequestreview-1931171225

From aivanov at openjdk.org  Tue Mar 12 14:18:12 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 12 Mar 2024 14:18:12 GMT
Subject: RFR: 8327924: Simplify TrayIconScalingTest.java
In-Reply-To: <v4lDY1J2WCp2RqxfYXNYImaEx5EOeX2x4LM23n93Zrs=.010ab607-ba30-484d-b293-460ed4444b1a@github.com>
References: <v4lDY1J2WCp2RqxfYXNYImaEx5EOeX2x4LM23n93Zrs=.010ab607-ba30-484d-b293-460ed4444b1a@github.com>
Message-ID: <p8CyJn9l-wOCtckaY6d6zE2oij0ACau7InDmcWjjkE8=.e94e5200-322e-4b0c-b55e-9dd106e631c5@github.com>

On Tue, 12 Mar 2024 08:33:41 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> This is to simplify `TrayIconScalingTest.java`.
> 
> 1. Rename `createAndShowGUI` to `createAndShowTrayIcon` which is more specific.
> 2. Move creating tray icon to the top.
> 3. Streamline PassFailJFrame with the chained calls, including `awaitAndCheck`.
> 4. Ensure tray is not null before removing the icon.
> 5. Pass AWTException as the cause in the wrapped exception.
> 
> Previously, before the builder pattern was introduced, `PassFailJFrame.positionTestWindow` had had to be called to show the instructions UI. It's not required any more. Additionally, it has the effect of moving the instruction frame to the left, which doesn't look good and sometimes results in positioning the instructions outside of the screen bounds if the screen resolution is low.
> 
> With the builder pattern, the call to the `build` method shows all the registered windows on the screen, including the instruction frame. Since there's no secondary UI, the instructions remain in the centre of the screen.

@honkar-jdk, could you, as the author of the test, take a look, please?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18224#issuecomment-1991753900

From ihse at openjdk.org  Tue Mar 12 15:16:30 2024
From: ihse at openjdk.org (Magnus Ihse Bursie)
Date: Tue, 12 Mar 2024 15:16:30 GMT
Subject: RFR: 8327701: Remove the xlc toolchain [v3]
In-Reply-To: <ZNtnRt4ufmZ5Sp8zURIQwBVraTUPmM30KwL-sC37JeQ=.7135ee42-e9b1-4410-afea-b5c7384ae76e@github.com>
References: <ZNtnRt4ufmZ5Sp8zURIQwBVraTUPmM30KwL-sC37JeQ=.7135ee42-e9b1-4410-afea-b5c7384ae76e@github.com>
Message-ID: <0TOkCbNH7MaB96StWPTbQZUzo2mT-9jzCSpNlqg-PJM=.4f227516-fe08-4e6b-a5db-63d39e29a4fe@github.com>

> As of [JDK-8325880](https://bugs.openjdk.org/browse/JDK-8325880), building the JDK requires version 17 of IBM Open XL C/C++ (xlc). This is in effect clang by another name, and it uses the clang toolchain in the JDK build. Thus the old xlc toolchain is no longer supported, and should be removed.

Magnus Ihse Bursie has updated the pull request incrementally with two additional commits since the last revision:

 - Set JVM_PICFLAG="-fpic -mcmodel=large" for AIX
 -  Open XL 17.1.1.4 is clang 15.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18172/files
  - new: https://git.openjdk.org/jdk/pull/18172/files/53a05019..e7949499

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18172&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18172&range=01-02

  Stats: 7 lines in 3 files changed: 4 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/jdk/pull/18172.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18172/head:pull/18172

PR: https://git.openjdk.org/jdk/pull/18172

From ihse at openjdk.org  Tue Mar 12 15:16:30 2024
From: ihse at openjdk.org (Magnus Ihse Bursie)
Date: Tue, 12 Mar 2024 15:16:30 GMT
Subject: RFR: 8327701: Remove the xlc toolchain [v2]
In-Reply-To: <Ioh-YZlIDNY5Uts86Hq24PW7qlhd4G0ztoY7Kyjqxqs=.620fb161-9f94-4bb0-acea-c6245869069e@github.com>
References: <ZNtnRt4ufmZ5Sp8zURIQwBVraTUPmM30KwL-sC37JeQ=.7135ee42-e9b1-4410-afea-b5c7384ae76e@github.com>
 <YVdSIUybMmPFB4eNvHAxfmfEqOzrrt5l6AA9j44DlBM=.2bb3f97e-583c-4ee5-9a5a-c02454315b33@github.com>
 <mehlNc-3I43oISWMHGfAHxhm1W5RKyEvGQk5ru5dwGY=.ebdd700d-4ca2-47c2-961c-b5fcea5c00ec@github.com>
 <Ioh-YZlIDNY5Uts86Hq24PW7qlhd4G0ztoY7Kyjqxqs=.620fb161-9f94-4bb0-acea-c6245869069e@github.com>
Message-ID: <P7f5s7dJpE9cr-hDRRRiIFyJiP_A5gFjXGjE-77EiZY=.37406161-2f57-4b30-b910-88d17ef2bf9a@github.com>

On Mon, 11 Mar 2024 09:30:20 GMT, Julian Waters <jwaters at openjdk.org> wrote:

> Is Open XL C/C++ considered a compiler or more akin to a development environment like Xcode is for macOS? Depending on which, we could just say clang is the compiler for AIX without needing to say that Open XL is treated like clang, etc

You are raising a good point. Our current concept of "toolchain" is not working as smoothly as it should be. We should probably split it into "toolchain environment" (or whatever), like Xcode or Open XL, and "toolchain compiler" (like clang), and/or possibly also some concept of "toolchain sdk".

The work you are doing of untangling Windows from Visual Studio would probably influence such a redesign, seeing what part of the Windows adaptions which arise from cl, and which are constant given that you compile for windows (like the Windows SDK).

But this is a more architectural issue that will need to be resolved in another PR, and probably discussed quite a bit beforehand.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18172#discussion_r1521637464

From ihse at openjdk.org  Tue Mar 12 15:16:30 2024
From: ihse at openjdk.org (Magnus Ihse Bursie)
Date: Tue, 12 Mar 2024 15:16:30 GMT
Subject: RFR: 8327701: Remove the xlc toolchain [v2]
In-Reply-To: <P7f5s7dJpE9cr-hDRRRiIFyJiP_A5gFjXGjE-77EiZY=.37406161-2f57-4b30-b910-88d17ef2bf9a@github.com>
References: <ZNtnRt4ufmZ5Sp8zURIQwBVraTUPmM30KwL-sC37JeQ=.7135ee42-e9b1-4410-afea-b5c7384ae76e@github.com>
 <YVdSIUybMmPFB4eNvHAxfmfEqOzrrt5l6AA9j44DlBM=.2bb3f97e-583c-4ee5-9a5a-c02454315b33@github.com>
 <mehlNc-3I43oISWMHGfAHxhm1W5RKyEvGQk5ru5dwGY=.ebdd700d-4ca2-47c2-961c-b5fcea5c00ec@github.com>
 <Ioh-YZlIDNY5Uts86Hq24PW7qlhd4G0ztoY7Kyjqxqs=.620fb161-9f94-4bb0-acea-c6245869069e@github.com>
 <P7f5s7dJpE9cr-hDRRRiIFyJiP_A5gFjXGjE-77EiZY=.37406161-2f57-4b30-b910-88d17ef2bf9a@github.com>
Message-ID: <lhFGFpyEmGC_7dM5iZA1yv4wDlgmFs4Aet3ksLzCclo=.15182a62-341b-40a1-afdd-48f4027673a9@github.com>

On Tue, 12 Mar 2024 15:04:56 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> Is Open XL C/C++ considered a compiler or more akin to a development environment like Xcode is for macOS? Depending on which, we could just say clang is the compiler for AIX without needing to say that Open XL is treated like clang, etc
>> 
>> Also, why did this remove the link to the Supported Build Platforms page?
>
>> Is Open XL C/C++ considered a compiler or more akin to a development environment like Xcode is for macOS? Depending on which, we could just say clang is the compiler for AIX without needing to say that Open XL is treated like clang, etc
> 
> You are raising a good point. Our current concept of "toolchain" is not working as smoothly as it should be. We should probably split it into "toolchain environment" (or whatever), like Xcode or Open XL, and "toolchain compiler" (like clang), and/or possibly also some concept of "toolchain sdk".
> 
> The work you are doing of untangling Windows from Visual Studio would probably influence such a redesign, seeing what part of the Windows adaptions which arise from cl, and which are constant given that you compile for windows (like the Windows SDK).
> 
> But this is a more architectural issue that will need to be resolved in another PR, and probably discussed quite a bit beforehand.

> why did this remove the link to the Supported Build Platforms page?

You make it sound like it is a bad thing, but in fact I promoted the AIX build to be of the same status as all other platforms. I cowardly did not put anything specific about the AIX build in the readme before, but just referred to the wiki. Now I decided we should actually treat this as a proper platform and describe the compiler version in the readme, since it is checked in configure, just like all other platforms.

There is still a link to the Supported Build Platforms wiki page in the general part of the readme.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18172#discussion_r1521642995

From ihse at openjdk.org  Tue Mar 12 15:16:30 2024
From: ihse at openjdk.org (Magnus Ihse Bursie)
Date: Tue, 12 Mar 2024 15:16:30 GMT
Subject: RFR: 8327701: Remove the xlc toolchain [v2]
In-Reply-To: <lhFGFpyEmGC_7dM5iZA1yv4wDlgmFs4Aet3ksLzCclo=.15182a62-341b-40a1-afdd-48f4027673a9@github.com>
References: <ZNtnRt4ufmZ5Sp8zURIQwBVraTUPmM30KwL-sC37JeQ=.7135ee42-e9b1-4410-afea-b5c7384ae76e@github.com>
 <YVdSIUybMmPFB4eNvHAxfmfEqOzrrt5l6AA9j44DlBM=.2bb3f97e-583c-4ee5-9a5a-c02454315b33@github.com>
 <mehlNc-3I43oISWMHGfAHxhm1W5RKyEvGQk5ru5dwGY=.ebdd700d-4ca2-47c2-961c-b5fcea5c00ec@github.com>
 <Ioh-YZlIDNY5Uts86Hq24PW7qlhd4G0ztoY7Kyjqxqs=.620fb161-9f94-4bb0-acea-c6245869069e@github.com>
 <P7f5s7dJpE9cr-hDRRRiIFyJiP_A5gFjXGjE-77EiZY=.37406161-2f57-4b30-b910-88d17ef2bf9a@github.com>
 <lhFGFpyEmGC_7dM5iZA1yv4wDlgmFs4Aet3ksLzCclo=.15182a62-341b-40a1-afdd-48f4027673a9@github.com>
Message-ID: <Ar1IFhPb5b3al2ywNyc9Noe1Z6oUl2dyrX5TxF89KlQ=.46043776-03b2-4598-bcb1-f39081351abc@github.com>

On Tue, 12 Mar 2024 15:07:15 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>>> Is Open XL C/C++ considered a compiler or more akin to a development environment like Xcode is for macOS? Depending on which, we could just say clang is the compiler for AIX without needing to say that Open XL is treated like clang, etc
>> 
>> You are raising a good point. Our current concept of "toolchain" is not working as smoothly as it should be. We should probably split it into "toolchain environment" (or whatever), like Xcode or Open XL, and "toolchain compiler" (like clang), and/or possibly also some concept of "toolchain sdk".
>> 
>> The work you are doing of untangling Windows from Visual Studio would probably influence such a redesign, seeing what part of the Windows adaptions which arise from cl, and which are constant given that you compile for windows (like the Windows SDK).
>> 
>> But this is a more architectural issue that will need to be resolved in another PR, and probably discussed quite a bit beforehand.
>
>> why did this remove the link to the Supported Build Platforms page?
> 
> You make it sound like it is a bad thing, but in fact I promoted the AIX build to be of the same status as all other platforms. I cowardly did not put anything specific about the AIX build in the readme before, but just referred to the wiki. Now I decided we should actually treat this as a proper platform and describe the compiler version in the readme, since it is checked in configure, just like all other platforms.
> 
> There is still a link to the Supported Build Platforms wiki page in the general part of the readme.

> It is clang 15 not 13. Clang 13 was in 17.1.0

Thanks! Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18172#discussion_r1521646622

From ihse at openjdk.org  Tue Mar 12 15:16:30 2024
From: ihse at openjdk.org (Magnus Ihse Bursie)
Date: Tue, 12 Mar 2024 15:16:30 GMT
Subject: RFR: 8327701: Remove the xlc toolchain [v3]
In-Reply-To: <ym4JkRJQUoM3hQXlhx1Uwrqs0MFrKSA8TDz0ggKFMbc=.fc3722a0-a1ae-4d97-b619-56ea98402c0c@github.com>
References: <ZNtnRt4ufmZ5Sp8zURIQwBVraTUPmM30KwL-sC37JeQ=.7135ee42-e9b1-4410-afea-b5c7384ae76e@github.com>
 <McIPLciH42WumSGkYLGvyyqQ-tntHyzlYa-iou8p3W8=.800e6f9e-1844-4d56-8054-80477058573f@github.com>
 <U1lfAxBkklFXkNC4jPSOY9jM-uvs0vMuHH7VZgAC0AM=.4445f8df-c8c8-4363-a35e-b89c571cde03@github.com>
 <ym4JkRJQUoM3hQXlhx1Uwrqs0MFrKSA8TDz0ggKFMbc=.fc3722a0-a1ae-4d97-b619-56ea98402c0c@github.com>
Message-ID: <BIhbzXI75pM_diWYSgO4wf1H-wjuvFq0ox0HPypK9-I=.34a7de3c-883d-4308-bda0-96a4d163077a@github.com>

On Mon, 11 Mar 2024 13:45:46 GMT, Joachim Kern <jkern at openjdk.org> wrote:

>> OK this was a flaw in my introduction of clang toolchain for AIX. The intention was to keep the xlc options in form of their clang counterparts. I will try with a corrected version for clang on AIX and will come back to you.
>
> OK, the `-Wl,-bbigtoc` is not a compiler option but a linker option and it is already set in the linker options.
> But the `-fpic -mcmodel=large` should be set to avoid creating a jump to out-of-order code.
> 
> So we can replace the
> 
>   JVM_PICFLAG="$PICFLAG"
>   JDK_PICFLAG="$PICFLAG"
> 
> 
> code some lines below by
> 
> 
>   if test "x$TOOLCHAIN_TYPE" = xclang && test "x$OPENJDK_TARGET_OS" = xaix; then
>     JVM_PICFLAG="-fpic -mcmodel=large"
>   else
>     JVM_PICFLAG="$PICFLAG"
>   fi
>   JDK_PICFLAG="$PICFLAG"

I'm not entirely happy to do this here, as it is a bug fix, and it will change behavior, in contrast to the rest of the patch which is just about removing unused code.

But it's a small fix, and I'm messing with the part of the code anyway, so if you are sure that this is the right thing to do I'll sneak it in here. Please make sure it works.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18172#discussion_r1521652510

From ihse at openjdk.org  Tue Mar 12 15:19:18 2024
From: ihse at openjdk.org (Magnus Ihse Bursie)
Date: Tue, 12 Mar 2024 15:19:18 GMT
Subject: RFR: 8327701: Remove the xlc toolchain [v2]
In-Reply-To: <mehlNc-3I43oISWMHGfAHxhm1W5RKyEvGQk5ru5dwGY=.ebdd700d-4ca2-47c2-961c-b5fcea5c00ec@github.com>
References: <ZNtnRt4ufmZ5Sp8zURIQwBVraTUPmM30KwL-sC37JeQ=.7135ee42-e9b1-4410-afea-b5c7384ae76e@github.com>
 <YVdSIUybMmPFB4eNvHAxfmfEqOzrrt5l6AA9j44DlBM=.2bb3f97e-583c-4ee5-9a5a-c02454315b33@github.com>
 <mehlNc-3I43oISWMHGfAHxhm1W5RKyEvGQk5ru5dwGY=.ebdd700d-4ca2-47c2-961c-b5fcea5c00ec@github.com>
Message-ID: <TfNIppAJuRdhDtTIe7_UEZacBWEB-QQgz-syx8MaNmI=.86318625-3843-4292-ac86-ab66ef5a095e@github.com>

On Mon, 11 Mar 2024 09:14:27 GMT, Joachim Kern <jkern at openjdk.org> wrote:

>> Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Revert SEARCH_PATH changes
>
> make/autoconf/toolchain.m4 line 409:
> 
>> 407:     #    Target: powerpc-ibm-aix7.2.0.0
>> 408:     #    Thread model: posix
>> 409:     #    InstalledDir: /opt/IBM/openxlC/17.1.0/bin
> 
> Please correct:
> IBM Open XL C/C++ for AIX 17.1.**1** (xxxxxxxxxxxxxxx), clang version 1**5**.0.0
>     #    Target: **powerpc-ibm-aix7.2.**5**.7**
>     #    Thread model: posix
>     #    InstalledDir: /opt/IBM/openxlC/17.1.**1**/bin

That was just intended as an example code. At one point, this has been printed by the compiler output (at least according to the source I found on the net). I tried to find a bunch of different examples from different platforms and versions. 

But sure, if it makes you happier, I can replace it with a more up to date example.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18172#discussion_r1521656819

From ihse at openjdk.org  Tue Mar 12 15:19:19 2024
From: ihse at openjdk.org (Magnus Ihse Bursie)
Date: Tue, 12 Mar 2024 15:19:19 GMT
Subject: RFR: 8327701: Remove the xlc toolchain [v2]
In-Reply-To: <TfNIppAJuRdhDtTIe7_UEZacBWEB-QQgz-syx8MaNmI=.86318625-3843-4292-ac86-ab66ef5a095e@github.com>
References: <ZNtnRt4ufmZ5Sp8zURIQwBVraTUPmM30KwL-sC37JeQ=.7135ee42-e9b1-4410-afea-b5c7384ae76e@github.com>
 <YVdSIUybMmPFB4eNvHAxfmfEqOzrrt5l6AA9j44DlBM=.2bb3f97e-583c-4ee5-9a5a-c02454315b33@github.com>
 <mehlNc-3I43oISWMHGfAHxhm1W5RKyEvGQk5ru5dwGY=.ebdd700d-4ca2-47c2-961c-b5fcea5c00ec@github.com>
 <TfNIppAJuRdhDtTIe7_UEZacBWEB-QQgz-syx8MaNmI=.86318625-3843-4292-ac86-ab66ef5a095e@github.com>
Message-ID: <nJyUXYL3Mt5LnI_2H0hfT7yTDFNmuPZd8LvW8msfl5Y=.3e503566-d993-463f-a37f-4d7382565a89@github.com>

On Tue, 12 Mar 2024 15:15:27 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> make/autoconf/toolchain.m4 line 409:
>> 
>>> 407:     #    Target: powerpc-ibm-aix7.2.0.0
>>> 408:     #    Thread model: posix
>>> 409:     #    InstalledDir: /opt/IBM/openxlC/17.1.0/bin
>> 
>> Please correct:
>> IBM Open XL C/C++ for AIX 17.1.**1** (xxxxxxxxxxxxxxx), clang version 1**5**.0.0
>>     #    Target: **powerpc-ibm-aix7.2.**5**.7**
>>     #    Thread model: posix
>>     #    InstalledDir: /opt/IBM/openxlC/17.1.**1**/bin
>
> That was just intended as an example code. At one point, this has been printed by the compiler output (at least according to the source I found on the net). I tried to find a bunch of different examples from different platforms and versions. 
> 
> But sure, if it makes you happier, I can replace it with a more up to date example.

Actually, your example seems doctored (the `xxxxx`) string. I think I'll keep the real world example.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18172#discussion_r1521659238

From psadhukhan at openjdk.org  Tue Mar 12 15:21:19 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Tue, 12 Mar 2024 15:21:19 GMT
Subject: Integrated: 8327748: Convert
 javax/swing/JFileChooser/6798062/bug6798062.java applet test to main
In-Reply-To: <lGQbwCvyqdtOr8-NxY9l3pZC4mRPn7gBtd7qPIRPF-I=.0379a965-6ad2-44ba-abfe-ecd0ed3f7b02@github.com>
References: <lGQbwCvyqdtOr8-NxY9l3pZC4mRPn7gBtd7qPIRPF-I=.0379a965-6ad2-44ba-abfe-ecd0ed3f7b02@github.com>
Message-ID: <qjFs9geeBzScqz3THvle5AhyCs-kwJJwN494aWWC8B8=.f1a12241-0f7a-4275-b545-d54414567ed9@github.com>

On Mon, 11 Mar 2024 06:22:22 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> Conversion of manual applet test to main based using PassFailJFrame manual framework

This pull request has now been integrated.

Changeset: 782206bc
Author:    Prasanta Sadhukhan <psadhukhan at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/782206bc97dc6ae953b0c3ce01f8b6edab4ad30b
Stats:     106 lines in 2 files changed: 35 ins; 43 del; 28 mod

8327748: Convert javax/swing/JFileChooser/6798062/bug6798062.java applet test to main

Reviewed-by: aivanov

-------------

PR: https://git.openjdk.org/jdk/pull/18180

From ihse at openjdk.org  Tue Mar 12 15:27:29 2024
From: ihse at openjdk.org (Magnus Ihse Bursie)
Date: Tue, 12 Mar 2024 15:27:29 GMT
Subject: RFR: 8327701: Remove the xlc toolchain [v4]
In-Reply-To: <ZNtnRt4ufmZ5Sp8zURIQwBVraTUPmM30KwL-sC37JeQ=.7135ee42-e9b1-4410-afea-b5c7384ae76e@github.com>
References: <ZNtnRt4ufmZ5Sp8zURIQwBVraTUPmM30KwL-sC37JeQ=.7135ee42-e9b1-4410-afea-b5c7384ae76e@github.com>
Message-ID: <Nd9G2lbssxwTvHQHeSHqaRqJ7uQIq8rVO2HulAV5V1w=.0b12fe1c-b990-4025-b24b-9636a25e424d@github.com>

> As of [JDK-8325880](https://bugs.openjdk.org/browse/JDK-8325880), building the JDK requires version 17 of IBM Open XL C/C++ (xlc). This is in effect clang by another name, and it uses the clang toolchain in the JDK build. Thus the old xlc toolchain is no longer supported, and should be removed.

Magnus Ihse Bursie has updated the pull request incrementally with two additional commits since the last revision:

 - Replace CC_VERSION_OUTPUT with CC_VERSION_STRING
 - We need CC_VERSION_OUTPUT before we can check it

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18172/files
  - new: https://git.openjdk.org/jdk/pull/18172/files/e7949499..577715b3

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18172&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18172&range=02-03

  Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/18172.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18172/head:pull/18172

PR: https://git.openjdk.org/jdk/pull/18172

From ihse at openjdk.org  Tue Mar 12 15:27:29 2024
From: ihse at openjdk.org (Magnus Ihse Bursie)
Date: Tue, 12 Mar 2024 15:27:29 GMT
Subject: RFR: 8327701: Remove the xlc toolchain [v2]
In-Reply-To: <guGW7d1XFNl7TE84CKTrkWngW5mNZ8dEhgiUaUphTcQ=.447ec868-160f-4f96-9dc3-16e955e1c8d7@github.com>
References: <ZNtnRt4ufmZ5Sp8zURIQwBVraTUPmM30KwL-sC37JeQ=.7135ee42-e9b1-4410-afea-b5c7384ae76e@github.com>
 <YVdSIUybMmPFB4eNvHAxfmfEqOzrrt5l6AA9j44DlBM=.2bb3f97e-583c-4ee5-9a5a-c02454315b33@github.com>
 <guGW7d1XFNl7TE84CKTrkWngW5mNZ8dEhgiUaUphTcQ=.447ec868-160f-4f96-9dc3-16e955e1c8d7@github.com>
Message-ID: <3S9pyv9jOnJihfgqtK_CXhDDV62pzek2TrduKffVTnI=.4e8d8016-a299-4596-92f4-1bcf6bd206f4@github.com>

On Mon, 11 Mar 2024 12:44:55 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

>> Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Revert SEARCH_PATH changes
>
> With this change added, currently  configure fails 
> 
> 
> checking for ibm-llvm-cxxfilt... /opt/IBM/openxlC/17.1.1/tools/ibm-llvm-cxxfilt
> configure: error: ibm-clang_r version output check failed, output: 
> configure exiting with result code 
> 
> maybe  related to what Joachim pointed out ?

@MBaesken Yes, it was the bug Joachim found. It should be fixed now, together will all other comments (except the example version string in the comments).

Please re-test.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18172#issuecomment-1991913029

From ihse at openjdk.org  Tue Mar 12 15:27:29 2024
From: ihse at openjdk.org (Magnus Ihse Bursie)
Date: Tue, 12 Mar 2024 15:27:29 GMT
Subject: RFR: 8327701: Remove the xlc toolchain [v2]
In-Reply-To: <0yRLC1SM9um8MIZYJP6sf8OOMeOCbzCc1LF_JQLxZHg=.e3391f4e-ab9e-423c-880c-e84aba29e87b@github.com>
References: <ZNtnRt4ufmZ5Sp8zURIQwBVraTUPmM30KwL-sC37JeQ=.7135ee42-e9b1-4410-afea-b5c7384ae76e@github.com>
 <YVdSIUybMmPFB4eNvHAxfmfEqOzrrt5l6AA9j44DlBM=.2bb3f97e-583c-4ee5-9a5a-c02454315b33@github.com>
 <0yRLC1SM9um8MIZYJP6sf8OOMeOCbzCc1LF_JQLxZHg=.e3391f4e-ab9e-423c-880c-e84aba29e87b@github.com>
Message-ID: <7IuMlu40vZGHuJYHQZvYgMVi72Hd72bn1RfkvD0gygg=.27838cfe-7ae7-42e7-ac46-b08b5610d979@github.com>

On Mon, 11 Mar 2024 12:27:08 GMT, Joachim Kern <jkern at openjdk.org> wrote:

>> Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Revert SEARCH_PATH changes
>
> make/autoconf/toolchain.m4 line 940:
> 
>> 938:   if test "x$OPENJDK_TARGET_OS" = xaix; then
>> 939:     # Make sure we have the Open XL version of clang on AIX
>> 940:     $ECHO "$CC_VERSION_OUTPUT" | $GREP "IBM Open XL C/C++ for AIX" > /dev/null
> 
> This does not work since $CC_VERSION_OUTPUT is unset. We need 
> 	CC_VERSION_OUTPUT=`${XLC_TEST_PATH}ibm-clang++_r --version 2>&1 | $HEAD -n 1`
> before, as in the previous code some lines above which you removed.

Yeah, you are right. I confused it with CC_VERSION_STRING.

... duh.

Actually, that is what I should be using instead.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18172#discussion_r1521667916

From mbaesken at openjdk.org  Tue Mar 12 16:05:18 2024
From: mbaesken at openjdk.org (Matthias Baesken)
Date: Tue, 12 Mar 2024 16:05:18 GMT
Subject: RFR: 8327701: Remove the xlc toolchain [v2]
In-Reply-To: <3S9pyv9jOnJihfgqtK_CXhDDV62pzek2TrduKffVTnI=.4e8d8016-a299-4596-92f4-1bcf6bd206f4@github.com>
References: <ZNtnRt4ufmZ5Sp8zURIQwBVraTUPmM30KwL-sC37JeQ=.7135ee42-e9b1-4410-afea-b5c7384ae76e@github.com>
 <YVdSIUybMmPFB4eNvHAxfmfEqOzrrt5l6AA9j44DlBM=.2bb3f97e-583c-4ee5-9a5a-c02454315b33@github.com>
 <guGW7d1XFNl7TE84CKTrkWngW5mNZ8dEhgiUaUphTcQ=.447ec868-160f-4f96-9dc3-16e955e1c8d7@github.com>
 <3S9pyv9jOnJihfgqtK_CXhDDV62pzek2TrduKffVTnI=.4e8d8016-a299-4596-92f4-1bcf6bd206f4@github.com>
Message-ID: <q5kj9HuS9Z3kwwvqqgfUBu10pYPuUK7JVhHingVcUw4=.32cf7474-73be-4537-af92-ad528ef4e8d5@github.com>

On Tue, 12 Mar 2024 15:24:21 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

> Please re-test.

Hi Magnus, thanks for the adjustments.  I reenabled your patch in our build/test queue .

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18172#issuecomment-1992009593

From aivanov at openjdk.org  Tue Mar 12 16:05:13 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 12 Mar 2024 16:05:13 GMT
Subject: RFR: 8327972: Convert
 java/awt/FileDialog/SaveFileNameOverrideTest/SaveFileNameOverrideTest.html
 applet test to main
In-Reply-To: <aAQg8fWlF7MafeuvNc76VYN5p6LBosaENVTOluAigfM=.b47d5d3e-6edc-4843-990f-cb489eb1aed9@github.com>
References: <aAQg8fWlF7MafeuvNc76VYN5p6LBosaENVTOluAigfM=.b47d5d3e-6edc-4843-990f-cb489eb1aed9@github.com>
Message-ID: <YWwA8MX7JcSIZJn0Ywgzgc1NYMO4u-NS45pCKPvoPAs=.86bdc115-f7a7-4a71-bed2-62382159bd44@github.com>

On Tue, 12 Mar 2024 12:34:57 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

> The test is converted to main.
> Tested on Linux, Macos and Windows.

Marked as reviewed by aivanov (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18231#pullrequestreview-1931511748

From duke at openjdk.org  Tue Mar 12 16:32:13 2024
From: duke at openjdk.org (Tres Finocchiaro)
Date: Tue, 12 Mar 2024 16:32:13 GMT
Subject: RFR: 8315113: Print request Chromaticity.MONOCHROME attribute does
 not work on macOS
In-Reply-To: <m_OJNAf9YmC4OJMwtCM5P-eklmNJUymWJjMfo5s_wpI=.7d1c5a1f-2158-49f2-906d-dc074019cb99@github.com>
References: <m_OJNAf9YmC4OJMwtCM5P-eklmNJUymWJjMfo5s_wpI=.7d1c5a1f-2158-49f2-906d-dc074019cb99@github.com>
Message-ID: <i5ocYtJjjntD6SpoZa3sZ9LS7OWMBJwxoj4kA3m2kps=.03d12d51-d0f9-4ee2-aea3-c7d0571c7aec@github.com>

On Mon, 11 Mar 2024 13:54:02 GMT, Alexander Scherbatiy <alexsch at openjdk.org> wrote:

> The fix provides ability to print Black & White pages on macOS.
> 
> Cocoa API has [PMSetColorMode](https://developer.apple.com/documentation/applicationservices/core_printing/1805783-pmsetcolormode) function but it is marked as deprecated and really does nothing.
> 
> There is no replacement; this function was included to facilitate porting legacy applications to macOS, 
> but it serves no useful purpose.
> 
> Dumping `NSPrintInfo` print settings which were set by the native print dialog on macOS shows that the keys and values used for Black & White printing depend on the used printer type.
> For example, the tested 
> `HP Color LaserJet MFP M180n` printer uses `ColorModel` key and`Gray` value, and
> `HP Ink Tank 110 series` uses `HPColorMode` key and `grayscale` value.
> 
> Printing all `NSPrintInfo` presets shows that they do not contain key/value pairs  for Black&White settings.
> This is the code snippet used to print `NSPrintInfo` presets:
> 
>     PMPrinter pr;
>     PMPrintSession printSession = (PMPrintSession)[printInfo PMPrintSession];
>     OSStatus status = PMSessionGetCurrentPrinter(printSession, &pr);
>     CFArrayRef presetsList = nil;
>     status = PMPrinterCopyPresets(pr, &presetsList);
>     CFIndex arrayCount = CFArrayGetCount(presetsList);
> 
>     for (CFIndex index = 0; index < arrayCount; index++) {
>         PMPreset preset = (PMPreset)CFArrayGetValueAtIndex(presetsList, index);
>         CFStringRef presetName = nil;
>         if (PMPresetCopyName(preset, &presetName) == noErr && CFStringGetLength(presetName) > 0) {
>             NSLog(@"  presetName: '%@'", presetName);
>             NSDictionary* dict = nil;
>             if (PMPresetGetAttributes(preset, (CFDictionaryRef*)(&dict)) == noErr) {
>                    // print preset dict
> 
> 
> The idea of the proposed fix is to store printer dependent key/value pairs in the `<jdk-home>/conf/printer.properties` property file.
> 
> The property file has the format:
> 
> print-attribute.print-attribute-value.key=value
> 
> where `print-attribute` is the java print attribute, `print-attribute-value` is the corresponding attribute value, and `key` and `value` is the key/value pair used by a specific printer.
> 
> For example, for `Chromaticity` attribute the property file could look like:
> 
> Chromaticity.MONOCHROME.ColorModel=Gray
> Chromaticity.COLOR.ColorModel=CMYK
> Chromaticity.MONOCHROME.HPColorMode=grayscale
> Chromaticity.COLOR.HPColorMode=color
> 
> where `Chromaticity.MONOCHROME` key prefix corresponds to `Chromaticity.MONOCHOROME` print attribute constant  with  (...

> Build changes look good. However, I think there is some kind of movement trying to _remove_ stuff from the conf directory, rather than adding new files there. @AlanBateman might want to chime in on this.

Hi, as a regular JDK user and a stakeholder to this getting fixed, is there any insight as to where they're moving to?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18195#issuecomment-1992075911

From prr at openjdk.org  Tue Mar 12 16:39:15 2024
From: prr at openjdk.org (Phil Race)
Date: Tue, 12 Mar 2024 16:39:15 GMT
Subject: RFR: 8320079: The ArabicBox.java test has no control buttons
In-Reply-To: <uW_uKMlwlOFidrejEZ7wkFRyC4Kqx_MmSQdenASo6EQ=.aebdca22-c37d-40f8-8d48-8f298f082adf@github.com>
References: <uW_uKMlwlOFidrejEZ7wkFRyC4Kqx_MmSQdenASo6EQ=.aebdca22-c37d-40f8-8d48-8f298f082adf@github.com>
Message-ID: <btYVSTOU23A21fikHzUnbk69uF6SZBaDfI2G7e_a6us=.de3e0dc3-db69-4adc-8aba-02e4c57f47ed@github.com>

On Tue, 12 Mar 2024 13:35:33 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> The test is converted to use `PassFailJFrame`.
> 
> I confirmed the updated test reproduce the original problem described in [JDK-4427483](https://bugs.openjdk.org/browse/JDK-4427483) where Arabic text displayed as missing glyphs.

test/jdk/java/awt/font/TextLayout/ArabicBox.java line 38:

> 36:  * @bug 4427483
> 37:  * @summary Arabic text followed by newline should have no missing glyphs
> 38:  * @library /open/test/jdk/java/awt/regtesthelpers

Are you sure about that path prefix ? this works properly on a purely open repo ?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18234#discussion_r1521792908

From prr at openjdk.org  Tue Mar 12 16:41:14 2024
From: prr at openjdk.org (Phil Race)
Date: Tue, 12 Mar 2024 16:41:14 GMT
Subject: RFR: 8315113: Print request Chromaticity.MONOCHROME attribute does
 not work on macOS
In-Reply-To: <m_OJNAf9YmC4OJMwtCM5P-eklmNJUymWJjMfo5s_wpI=.7d1c5a1f-2158-49f2-906d-dc074019cb99@github.com>
References: <m_OJNAf9YmC4OJMwtCM5P-eklmNJUymWJjMfo5s_wpI=.7d1c5a1f-2158-49f2-906d-dc074019cb99@github.com>
Message-ID: <tnG07ikGEAt-LbUV9bWiVi-GU8kpOUJyq5vbODAjfCs=.7fb47ae0-2e9e-4a09-b0cc-b4a44b78804a@github.com>

On Mon, 11 Mar 2024 13:54:02 GMT, Alexander Scherbatiy <alexsch at openjdk.org> wrote:

> The fix provides ability to print Black & White pages on macOS.
> 
> Cocoa API has [PMSetColorMode](https://developer.apple.com/documentation/applicationservices/core_printing/1805783-pmsetcolormode) function but it is marked as deprecated and really does nothing.
> 
> There is no replacement; this function was included to facilitate porting legacy applications to macOS, 
> but it serves no useful purpose.
> 
> Dumping `NSPrintInfo` print settings which were set by the native print dialog on macOS shows that the keys and values used for Black & White printing depend on the used printer type.
> For example, the tested 
> `HP Color LaserJet MFP M180n` printer uses `ColorModel` key and`Gray` value, and
> `HP Ink Tank 110 series` uses `HPColorMode` key and `grayscale` value.
> 
> Printing all `NSPrintInfo` presets shows that they do not contain key/value pairs  for Black&White settings.
> This is the code snippet used to print `NSPrintInfo` presets:
> 
>     PMPrinter pr;
>     PMPrintSession printSession = (PMPrintSession)[printInfo PMPrintSession];
>     OSStatus status = PMSessionGetCurrentPrinter(printSession, &pr);
>     CFArrayRef presetsList = nil;
>     status = PMPrinterCopyPresets(pr, &presetsList);
>     CFIndex arrayCount = CFArrayGetCount(presetsList);
> 
>     for (CFIndex index = 0; index < arrayCount; index++) {
>         PMPreset preset = (PMPreset)CFArrayGetValueAtIndex(presetsList, index);
>         CFStringRef presetName = nil;
>         if (PMPresetCopyName(preset, &presetName) == noErr && CFStringGetLength(presetName) > 0) {
>             NSLog(@"  presetName: '%@'", presetName);
>             NSDictionary* dict = nil;
>             if (PMPresetGetAttributes(preset, (CFDictionaryRef*)(&dict)) == noErr) {
>                    // print preset dict
> 
> 
> The idea of the proposed fix is to store printer dependent key/value pairs in the `<jdk-home>/conf/printer.properties` property file.
> 
> The property file has the format:
> 
> print-attribute.print-attribute-value.key=value
> 
> where `print-attribute` is the java print attribute, `print-attribute-value` is the corresponding attribute value, and `key` and `value` is the key/value pair used by a specific printer.
> 
> For example, for `Chromaticity` attribute the property file could look like:
> 
> Chromaticity.MONOCHROME.ColorModel=Gray
> Chromaticity.COLOR.ColorModel=CMYK
> Chromaticity.MONOCHROME.HPColorMode=grayscale
> Chromaticity.COLOR.HPColorMode=color
> 
> where `Chromaticity.MONOCHROME` key prefix corresponds to `Chromaticity.MONOCHOROME` print attribute constant  with  (...

/Reviewers 2

/Reviewers 4

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18195#issuecomment-1992093431
PR Comment: https://git.openjdk.org/jdk/pull/18195#issuecomment-1992094712

From prr at openjdk.org  Tue Mar 12 16:46:16 2024
From: prr at openjdk.org (Phil Race)
Date: Tue, 12 Mar 2024 16:46:16 GMT
Subject: RFR: 8315113: Print request Chromaticity.MONOCHROME attribute does
 not work on macOS
In-Reply-To: <m_OJNAf9YmC4OJMwtCM5P-eklmNJUymWJjMfo5s_wpI=.7d1c5a1f-2158-49f2-906d-dc074019cb99@github.com>
References: <m_OJNAf9YmC4OJMwtCM5P-eklmNJUymWJjMfo5s_wpI=.7d1c5a1f-2158-49f2-906d-dc074019cb99@github.com>
Message-ID: <rFR7u1Wwwgj7BLZ5pkeB-Mp0I1NTudpOexznsjHnyjc=.2ef59877-5a8e-46bc-97d3-80537f166aef@github.com>

On Mon, 11 Mar 2024 13:54:02 GMT, Alexander Scherbatiy <alexsch at openjdk.org> wrote:

> The fix provides ability to print Black & White pages on macOS.
> 
> Cocoa API has [PMSetColorMode](https://developer.apple.com/documentation/applicationservices/core_printing/1805783-pmsetcolormode) function but it is marked as deprecated and really does nothing.
> 
> There is no replacement; this function was included to facilitate porting legacy applications to macOS, 
> but it serves no useful purpose.
> 
> Dumping `NSPrintInfo` print settings which were set by the native print dialog on macOS shows that the keys and values used for Black & White printing depend on the used printer type.
> For example, the tested 
> `HP Color LaserJet MFP M180n` printer uses `ColorModel` key and`Gray` value, and
> `HP Ink Tank 110 series` uses `HPColorMode` key and `grayscale` value.
> 
> Printing all `NSPrintInfo` presets shows that they do not contain key/value pairs  for Black&White settings.
> This is the code snippet used to print `NSPrintInfo` presets:
> 
>     PMPrinter pr;
>     PMPrintSession printSession = (PMPrintSession)[printInfo PMPrintSession];
>     OSStatus status = PMSessionGetCurrentPrinter(printSession, &pr);
>     CFArrayRef presetsList = nil;
>     status = PMPrinterCopyPresets(pr, &presetsList);
>     CFIndex arrayCount = CFArrayGetCount(presetsList);
> 
>     for (CFIndex index = 0; index < arrayCount; index++) {
>         PMPreset preset = (PMPreset)CFArrayGetValueAtIndex(presetsList, index);
>         CFStringRef presetName = nil;
>         if (PMPresetCopyName(preset, &presetName) == noErr && CFStringGetLength(presetName) > 0) {
>             NSLog(@"  presetName: '%@'", presetName);
>             NSDictionary* dict = nil;
>             if (PMPresetGetAttributes(preset, (CFDictionaryRef*)(&dict)) == noErr) {
>                    // print preset dict
> 
> 
> The idea of the proposed fix is to store printer dependent key/value pairs in the `<jdk-home>/conf/printer.properties` property file.
> 
> The property file has the format:
> 
> print-attribute.print-attribute-value.key=value
> 
> where `print-attribute` is the java print attribute, `print-attribute-value` is the corresponding attribute value, and `key` and `value` is the key/value pair used by a specific printer.
> 
> For example, for `Chromaticity` attribute the property file could look like:
> 
> Chromaticity.MONOCHROME.ColorModel=Gray
> Chromaticity.COLOR.ColorModel=CMYK
> Chromaticity.MONOCHROME.HPColorMode=grayscale
> Chromaticity.COLOR.HPColorMode=color
> 
> where `Chromaticity.MONOCHROME` key prefix corresponds to `Chromaticity.MONOCHOROME` print attribute constant  with  (...

This needs at least two client Capital R reviewers to approve. And a CSR. 
But I am really surprised to see a PR rather than a discussion first as it is making a lot of policy decisions
and implies we need to support something I am not sure we want to support.

Yeah this looks like a complete mis-feature. Meaning it is very unlikely we will ever agree to integrate this.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18195#issuecomment-1992099400
PR Comment: https://git.openjdk.org/jdk/pull/18195#issuecomment-1992103790

From aivanov at openjdk.org  Tue Mar 12 16:48:28 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 12 Mar 2024 16:48:28 GMT
Subject: RFR: 8320079: The ArabicBox.java test has no control buttons [v2]
In-Reply-To: <uW_uKMlwlOFidrejEZ7wkFRyC4Kqx_MmSQdenASo6EQ=.aebdca22-c37d-40f8-8d48-8f298f082adf@github.com>
References: <uW_uKMlwlOFidrejEZ7wkFRyC4Kqx_MmSQdenASo6EQ=.aebdca22-c37d-40f8-8d48-8f298f082adf@github.com>
Message-ID: <pG0zC4m8VUNlRyEl1aPD9exDtkqU0wKRKikbGCFRuf8=.2a0250ed-3157-4303-9b7e-44efd0d17559@github.com>

> The test is converted to use `PassFailJFrame`.
> 
> I confirmed the updated test reproduce the original problem described in [JDK-4427483](https://bugs.openjdk.org/browse/JDK-4427483) where Arabic text displayed as missing glyphs.

Alexey Ivanov has updated the pull request incrementally with one additional commit since the last revision:

  Use the correct path to library

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18234/files
  - new: https://git.openjdk.org/jdk/pull/18234/files/ef948140..bba0baae

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18234&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18234&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/18234.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18234/head:pull/18234

PR: https://git.openjdk.org/jdk/pull/18234

From aivanov at openjdk.org  Tue Mar 12 16:51:15 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 12 Mar 2024 16:51:15 GMT
Subject: RFR: 8320079: The ArabicBox.java test has no control buttons [v2]
In-Reply-To: <btYVSTOU23A21fikHzUnbk69uF6SZBaDfI2G7e_a6us=.de3e0dc3-db69-4adc-8aba-02e4c57f47ed@github.com>
References: <uW_uKMlwlOFidrejEZ7wkFRyC4Kqx_MmSQdenASo6EQ=.aebdca22-c37d-40f8-8d48-8f298f082adf@github.com>
 <btYVSTOU23A21fikHzUnbk69uF6SZBaDfI2G7e_a6us=.de3e0dc3-db69-4adc-8aba-02e4c57f47ed@github.com>
Message-ID: <OtqaXVne2S-8kDQyFIsv_r6UmGAtDNgP7m-BSYWkdUI=.900c9d9f-1b60-4704-8491-c6259e7c8b62@github.com>

On Tue, 12 Mar 2024 16:36:15 GMT, Phil Race <prr at openjdk.org> wrote:

>> Alexey Ivanov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Use the correct path to library
>
> test/jdk/java/awt/font/TextLayout/ArabicBox.java line 38:
> 
>> 36:  * @bug 4427483
>> 37:  * @summary Arabic text followed by newline should have no missing glyphs
>> 38:  * @library /open/test/jdk/java/awt/regtesthelpers
> 
> Are you sure about that path prefix ? this works properly on a purely open repo ?

My bad, I forgot to update the path. I might've used a wrong command after copying the file around and didn't notice it. Updated now.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18234#discussion_r1521810999

From prr at openjdk.org  Tue Mar 12 16:54:16 2024
From: prr at openjdk.org (Phil Race)
Date: Tue, 12 Mar 2024 16:54:16 GMT
Subject: RFR: 8315113: Print request Chromaticity.MONOCHROME attribute does
 not work on macOS
In-Reply-To: <m_OJNAf9YmC4OJMwtCM5P-eklmNJUymWJjMfo5s_wpI=.7d1c5a1f-2158-49f2-906d-dc074019cb99@github.com>
References: <m_OJNAf9YmC4OJMwtCM5P-eklmNJUymWJjMfo5s_wpI=.7d1c5a1f-2158-49f2-906d-dc074019cb99@github.com>
Message-ID: <lwK-_ltza3bhmw75Zch_-PHSIkJ1BfMVrJ8FkI5TvTw=.2e7a8090-48af-403d-92bc-1e4e632d292a@github.com>

On Mon, 11 Mar 2024 13:54:02 GMT, Alexander Scherbatiy <alexsch at openjdk.org> wrote:

> The fix provides ability to print Black & White pages on macOS.
> 
> Cocoa API has [PMSetColorMode](https://developer.apple.com/documentation/applicationservices/core_printing/1805783-pmsetcolormode) function but it is marked as deprecated and really does nothing.
> 
> There is no replacement; this function was included to facilitate porting legacy applications to macOS, 
> but it serves no useful purpose.
> 
> Dumping `NSPrintInfo` print settings which were set by the native print dialog on macOS shows that the keys and values used for Black & White printing depend on the used printer type.
> For example, the tested 
> `HP Color LaserJet MFP M180n` printer uses `ColorModel` key and`Gray` value, and
> `HP Ink Tank 110 series` uses `HPColorMode` key and `grayscale` value.
> 
> Printing all `NSPrintInfo` presets shows that they do not contain key/value pairs  for Black&White settings.
> This is the code snippet used to print `NSPrintInfo` presets:
> 
>     PMPrinter pr;
>     PMPrintSession printSession = (PMPrintSession)[printInfo PMPrintSession];
>     OSStatus status = PMSessionGetCurrentPrinter(printSession, &pr);
>     CFArrayRef presetsList = nil;
>     status = PMPrinterCopyPresets(pr, &presetsList);
>     CFIndex arrayCount = CFArrayGetCount(presetsList);
> 
>     for (CFIndex index = 0; index < arrayCount; index++) {
>         PMPreset preset = (PMPreset)CFArrayGetValueAtIndex(presetsList, index);
>         CFStringRef presetName = nil;
>         if (PMPresetCopyName(preset, &presetName) == noErr && CFStringGetLength(presetName) > 0) {
>             NSLog(@"  presetName: '%@'", presetName);
>             NSDictionary* dict = nil;
>             if (PMPresetGetAttributes(preset, (CFDictionaryRef*)(&dict)) == noErr) {
>                    // print preset dict
> 
> 
> The idea of the proposed fix is to store printer dependent key/value pairs in the `<jdk-home>/conf/printer.properties` property file.
> 
> The property file has the format:
> 
> print-attribute.print-attribute-value.key=value
> 
> where `print-attribute` is the java print attribute, `print-attribute-value` is the corresponding attribute value, and `key` and `value` is the key/value pair used by a specific printer.
> 
> For example, for `Chromaticity` attribute the property file could look like:
> 
> Chromaticity.MONOCHROME.ColorModel=Gray
> Chromaticity.COLOR.ColorModel=CMYK
> Chromaticity.MONOCHROME.HPColorMode=grayscale
> Chromaticity.COLOR.HPColorMode=color
> 
> where `Chromaticity.MONOCHROME` key prefix corresponds to `Chromaticity.MONOCHOROME` print attribute constant  with  (...

I wonder how this is supposed to be documented ? And who is supposed to maintain this file ?
I think this PR should be withdrawn.

src/java.desktop/share/conf/printer.properties line 1:

> 1: Chromaticity.MONOCHROME.BRPrintQuality=Black

Why, oh why  would a file needed for CUPS on macOS be in shared code ?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18195#issuecomment-1992119844
PR Review Comment: https://git.openjdk.org/jdk/pull/18195#discussion_r1521814087

From honkar at openjdk.org  Tue Mar 12 16:57:12 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Tue, 12 Mar 2024 16:57:12 GMT
Subject: RFR: 8327924: Simplify TrayIconScalingTest.java
In-Reply-To: <v4lDY1J2WCp2RqxfYXNYImaEx5EOeX2x4LM23n93Zrs=.010ab607-ba30-484d-b293-460ed4444b1a@github.com>
References: <v4lDY1J2WCp2RqxfYXNYImaEx5EOeX2x4LM23n93Zrs=.010ab607-ba30-484d-b293-460ed4444b1a@github.com>
Message-ID: <jh_pWnZK92MIHEPj3ZsmXtYBviFFvg_iNF8oZJg_DOI=.19bc27ef-be01-401f-a1ae-62b705f43870@github.com>

On Tue, 12 Mar 2024 08:33:41 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> This is to simplify `TrayIconScalingTest.java`.
> 
> 1. Rename `createAndShowGUI` to `createAndShowTrayIcon` which is more specific.
> 2. Move creating tray icon to the top.
> 3. Streamline PassFailJFrame with the chained calls, including `awaitAndCheck`.
> 4. Ensure tray is not null before removing the icon.
> 5. Pass AWTException as the cause in the wrapped exception.
> 
> Previously, before the builder pattern was introduced, `PassFailJFrame.positionTestWindow` had had to be called to show the instructions UI. It's not required any more. Additionally, it has the effect of moving the instruction frame to the left, which doesn't look good and sometimes results in positioning the instructions outside of the screen bounds if the screen resolution is low.
> 
> With the builder pattern, the call to the `build` method shows all the registered windows on the screen, including the instruction frame. Since there's no secondary UI, the instructions remain in the centre of the screen.

Changes looks good.

-------------

Marked as reviewed by honkar (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18224#pullrequestreview-1931662180

From prr at openjdk.org  Tue Mar 12 16:57:13 2024
From: prr at openjdk.org (Phil Race)
Date: Tue, 12 Mar 2024 16:57:13 GMT
Subject: RFR: 8320079: The ArabicBox.java test has no control buttons [v2]
In-Reply-To: <pG0zC4m8VUNlRyEl1aPD9exDtkqU0wKRKikbGCFRuf8=.2a0250ed-3157-4303-9b7e-44efd0d17559@github.com>
References: <uW_uKMlwlOFidrejEZ7wkFRyC4Kqx_MmSQdenASo6EQ=.aebdca22-c37d-40f8-8d48-8f298f082adf@github.com>
 <pG0zC4m8VUNlRyEl1aPD9exDtkqU0wKRKikbGCFRuf8=.2a0250ed-3157-4303-9b7e-44efd0d17559@github.com>
Message-ID: <WZILwvipjLu7WhOh9Ryz_mAAyafMxLj1YD0VdhkzCCQ=.932b445c-9d92-45ad-8105-6dbf607c90cb@github.com>

On Tue, 12 Mar 2024 16:48:28 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> The test is converted to use `PassFailJFrame`.
>> 
>> I confirmed the updated test reproduce the original problem described in [JDK-4427483](https://bugs.openjdk.org/browse/JDK-4427483) where Arabic text displayed as missing glyphs.
>
> Alexey Ivanov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Use the correct path to library

Marked as reviewed by prr (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18234#pullrequestreview-1931663214

From honkar at openjdk.org  Tue Mar 12 17:00:16 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Tue, 12 Mar 2024 17:00:16 GMT
Subject: RFR: 8325851: Hide PassFailJFrame.Builder constructor
In-Reply-To: <NPUEOS3SWj0H7KALdlwfdfJSxqsrpTyn9X4c1N-H8Ho=.cb175d1a-0a9b-4e23-98ae-404101a20531@github.com>
References: <NPUEOS3SWj0H7KALdlwfdfJSxqsrpTyn9X4c1N-H8Ho=.cb175d1a-0a9b-4e23-98ae-404101a20531@github.com>
Message-ID: <1dB0wbceTakN-sKndzyzrRfCvtcoyR95a4Djd44S-Qo=.a458fa76-32af-498f-84d0-585496575801@github.com>

On Mon, 11 Mar 2024 21:18:40 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> The `Builder` class in `PassFailJFrame` is public and has a public constructor. At the same time, a better design would be to hide all the Builder constructors and rely on the `builder()` method which returns an instance of the `Builder` class.
> 
> This PR makes the constructor of the `Builder` class private so that it's not accessible directly.
> 
> Use `PassFailJFrame.builder()` to get an instance of the builder and configure parameters of `PassFailJFrame`.
> 
> I updated all the tests which used the constructor directly by calling `new PassFailJFrame.Builder()`.
> 
> I converted a few tests to use the `testUI`, which greatly simplifies the test code. This change also removes flickering of the test UI.

PassFailJFrame's Builder changes and corresponding test changes look good.

-------------

Marked as reviewed by honkar (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18206#pullrequestreview-1931674713

From prr at openjdk.org  Tue Mar 12 17:02:14 2024
From: prr at openjdk.org (Phil Race)
Date: Tue, 12 Mar 2024 17:02:14 GMT
Subject: RFR: 8327972: Convert
 java/awt/FileDialog/SaveFileNameOverrideTest/SaveFileNameOverrideTest.html
 applet test to main
In-Reply-To: <aAQg8fWlF7MafeuvNc76VYN5p6LBosaENVTOluAigfM=.b47d5d3e-6edc-4843-990f-cb489eb1aed9@github.com>
References: <aAQg8fWlF7MafeuvNc76VYN5p6LBosaENVTOluAigfM=.b47d5d3e-6edc-4843-990f-cb489eb1aed9@github.com>
Message-ID: <K3HntykZA_jlrtntCtRhZOBiV4NlvXZ8jshQc1D9qWo=.04ba0fd0-7add-40d6-8cb4-79db68813795@github.com>

On Tue, 12 Mar 2024 12:34:57 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

> The test is converted to main.
> Tested on Linux, Macos and Windows.

Marked as reviewed by prr (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18231#pullrequestreview-1931679316

From prr at openjdk.org  Tue Mar 12 17:07:14 2024
From: prr at openjdk.org (Phil Race)
Date: Tue, 12 Mar 2024 17:07:14 GMT
Subject: RFR: 8327856: Convert applet test SpanishDiacriticsTest.java to a
 main program
In-Reply-To: <SNg1zw2YMUUXhrWAnzfI7NjNDK4dJjwgSxGwIQ1heuM=.74e12e8f-25cf-4c61-b4b5-da3b1bdde99c@github.com>
References: <JnPnHUoBMQd1YGVtRimzTC2Y5Sn5ezSWq2Fkw9jh-KA=.8df82997-452b-41c9-a698-68ab33e49f13@github.com>
 <SNg1zw2YMUUXhrWAnzfI7NjNDK4dJjwgSxGwIQ1heuM=.74e12e8f-25cf-4c61-b4b5-da3b1bdde99c@github.com>
Message-ID: <LtPTdEhbzu5w97v-16GSDhvLkg-41nUFhMsIaoUk5vc=.6440c8d5-4177-45b2-8d3c-cae7a7dcd839@github.com>

On Tue, 12 Mar 2024 12:47:46 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Converts the  manual applet test in the files ..
>> SpanishDiacriticsTest/SpanishDiacriticsTest.html
>> SpanishDiacriticsTest/SpanishDiacriticsTest.java
>> .. to a main program using PassFailJFrame
>> 
>> Added requires windows since it seems very windows-specific.
>> 
>> I got rid of the redundant extra directory which makes the .java file "new" according to github but it is largely changed anyway
>
> test/jdk/java/awt/InputMethods/SpanishDiacriticsTest.java line 60:
> 
>> 58:           expected behaviour for this test.
>> 59: 
>> 60:        If the text field displays ''o, (i.e. o should be without an acute)
> 
> Suggestion:
> 
>        If the text field displays \u00f3, (i.e. o should be without an acute)
> 
> Use the real character?

It isn't  a single char. It is as written - the  sequence of 3 characters - "single quote" "single quote", "latin lower case o"

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18208#discussion_r1521834822

From aivanov at openjdk.org  Tue Mar 12 17:11:14 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 12 Mar 2024 17:11:14 GMT
Subject: RFR: 8327856: Convert applet test SpanishDiacriticsTest.java to a
 main program
In-Reply-To: <LtPTdEhbzu5w97v-16GSDhvLkg-41nUFhMsIaoUk5vc=.6440c8d5-4177-45b2-8d3c-cae7a7dcd839@github.com>
References: <JnPnHUoBMQd1YGVtRimzTC2Y5Sn5ezSWq2Fkw9jh-KA=.8df82997-452b-41c9-a698-68ab33e49f13@github.com>
 <SNg1zw2YMUUXhrWAnzfI7NjNDK4dJjwgSxGwIQ1heuM=.74e12e8f-25cf-4c61-b4b5-da3b1bdde99c@github.com>
 <LtPTdEhbzu5w97v-16GSDhvLkg-41nUFhMsIaoUk5vc=.6440c8d5-4177-45b2-8d3c-cae7a7dcd839@github.com>
Message-ID: <PPLRLFNzMjrrhmk9FC0AbPaehklIEa-RbdqZaMbp_NI=.25731659-a8e0-4874-b1af-f263d748a606@github.com>

On Tue, 12 Mar 2024 17:05:04 GMT, Phil Race <prr at openjdk.org> wrote:

>> test/jdk/java/awt/InputMethods/SpanishDiacriticsTest.java line 60:
>> 
>>> 58:           expected behaviour for this test.
>>> 59: 
>>> 60:        If the text field displays ''o, (i.e. o should be without an acute)
>> 
>> Suggestion:
>> 
>>        If the text field displays \u00f3, (i.e. o should be without an acute)
>> 
>> Use the real character?
>
> It isn't  a single char. It is as written - the  sequence of 3 characters - "single quote" "single quote", "latin lower case o"

I misread it. If the text is `''o` instead of `?`?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18208#discussion_r1521839155

From aivanov at openjdk.org  Tue Mar 12 17:15:20 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 12 Mar 2024 17:15:20 GMT
Subject: RFR: 8327856: Convert applet test SpanishDiacriticsTest.java to a
 main program
In-Reply-To: <PPLRLFNzMjrrhmk9FC0AbPaehklIEa-RbdqZaMbp_NI=.25731659-a8e0-4874-b1af-f263d748a606@github.com>
References: <JnPnHUoBMQd1YGVtRimzTC2Y5Sn5ezSWq2Fkw9jh-KA=.8df82997-452b-41c9-a698-68ab33e49f13@github.com>
 <SNg1zw2YMUUXhrWAnzfI7NjNDK4dJjwgSxGwIQ1heuM=.74e12e8f-25cf-4c61-b4b5-da3b1bdde99c@github.com>
 <LtPTdEhbzu5w97v-16GSDhvLkg-41nUFhMsIaoUk5vc=.6440c8d5-4177-45b2-8d3c-cae7a7dcd839@github.com>
 <PPLRLFNzMjrrhmk9FC0AbPaehklIEa-RbdqZaMbp_NI=.25731659-a8e0-4874-b1af-f263d748a606@github.com>
Message-ID: <h_Wkp4wkCjuD6PmgmH4L09f1kcfCZhw9jA4-NchhooU=.9c9866b0-e24a-4173-a86b-5d7e8e8c3712@github.com>

On Tue, 12 Mar 2024 17:08:18 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> It isn't  a single char. It is as written - the  sequence of 3 characters - "single quote" "single quote", "latin lower case o"
>
> I misread it. If the text is `''o` instead of `?`?

What if we spell the conditions explicitly:

The text field should display ''o (i.e. two apostrophes and o without an acute), press Pass.
If you see ? (i.e. o with an acute), press Fail.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18208#discussion_r1521844133

From prr at openjdk.org  Tue Mar 12 17:27:14 2024
From: prr at openjdk.org (Phil Race)
Date: Tue, 12 Mar 2024 17:27:14 GMT
Subject: RFR: 8327856: Convert applet test SpanishDiacriticsTest.java to a
 main program
In-Reply-To: <h_Wkp4wkCjuD6PmgmH4L09f1kcfCZhw9jA4-NchhooU=.9c9866b0-e24a-4173-a86b-5d7e8e8c3712@github.com>
References: <JnPnHUoBMQd1YGVtRimzTC2Y5Sn5ezSWq2Fkw9jh-KA=.8df82997-452b-41c9-a698-68ab33e49f13@github.com>
 <SNg1zw2YMUUXhrWAnzfI7NjNDK4dJjwgSxGwIQ1heuM=.74e12e8f-25cf-4c61-b4b5-da3b1bdde99c@github.com>
 <LtPTdEhbzu5w97v-16GSDhvLkg-41nUFhMsIaoUk5vc=.6440c8d5-4177-45b2-8d3c-cae7a7dcd839@github.com>
 <PPLRLFNzMjrrhmk9FC0AbPaehklIEa-RbdqZaMbp_NI=.25731659-a8e0-4874-b1af-f263d748a606@github.com>
 <h_Wkp4wkCjuD6PmgmH4L09f1kcfCZhw9jA4-NchhooU=.9c9866b0-e24a-4173-a86b-5d7e8e8c3712@github.com>
Message-ID: <WmFbIHeEf1aJLKpGOmRIoCXbhvq94HOb-rjeFQIRZpU=.ad3e7905-6675-4420-9ef1-6ce35185bf43@github.com>

On Tue, 12 Mar 2024 17:12:08 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> I misread it. If the text is `''o` instead of `?`?
>
> What if we spell the conditions explicitly:
> 
> The text field should display ''o (i.e. two apostrophes and o without an acute), press Pass.
> If you see ? (i.e. o with an acute), press Fail.

I will reword it but the text is the same as was in the HTML file with just some minor grammatical changes in the surrounding text.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18208#discussion_r1521860016

From alexsch at openjdk.org  Tue Mar 12 17:31:14 2024
From: alexsch at openjdk.org (Alexander Scherbatiy)
Date: Tue, 12 Mar 2024 17:31:14 GMT
Subject: RFR: 8315113: Print request Chromaticity.MONOCHROME attribute does
 not work on macOS
In-Reply-To: <rFR7u1Wwwgj7BLZ5pkeB-Mp0I1NTudpOexznsjHnyjc=.2ef59877-5a8e-46bc-97d3-80537f166aef@github.com>
References: <m_OJNAf9YmC4OJMwtCM5P-eklmNJUymWJjMfo5s_wpI=.7d1c5a1f-2158-49f2-906d-dc074019cb99@github.com>
 <rFR7u1Wwwgj7BLZ5pkeB-Mp0I1NTudpOexznsjHnyjc=.2ef59877-5a8e-46bc-97d3-80537f166aef@github.com>
Message-ID: <m7sDuwEArkLnR6xti1Ld4JNfuRN2mQmn97uLnzMUWiA=.75f71128-eb19-48e5-9c21-27d2a22f0fe3@github.com>

On Tue, 12 Mar 2024 16:41:12 GMT, Phil Race <prr at openjdk.org> wrote:

> But I am really surprised to see a PR rather than a discussion first as it is making a lot of policy decisions
and implies we need to support something I am not sure we want to support.

There was an email with the issue discussion on the client-libs-dev alias:
https://mail.openjdk.org/pipermail/client-libs-dev/2023-August/014497.html


Setting Chromaticity.MONOCHROME print request attribute on macOS

What is the right way to use different key/values (ColorModel: Gray, 
HPColorMode: grayscale, ...) in code to set Black & White settings for 
NSPrintInfo?
Could it be a configuration file which contains all color model 
key/values for all known printers?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18195#issuecomment-1992189765

From prr at openjdk.org  Tue Mar 12 17:36:46 2024
From: prr at openjdk.org (Phil Race)
Date: Tue, 12 Mar 2024 17:36:46 GMT
Subject: RFR: 8327856: Convert applet test SpanishDiacriticsTest.java to a
 main program [v2]
In-Reply-To: <JnPnHUoBMQd1YGVtRimzTC2Y5Sn5ezSWq2Fkw9jh-KA=.8df82997-452b-41c9-a698-68ab33e49f13@github.com>
References: <JnPnHUoBMQd1YGVtRimzTC2Y5Sn5ezSWq2Fkw9jh-KA=.8df82997-452b-41c9-a698-68ab33e49f13@github.com>
Message-ID: <YP6BbBdWfkZz8f1kpC1Bs-NZJ6rmhEamwg_4cZpEu8Q=.25777c87-5fcb-4dbd-9230-c5b8e281619c@github.com>

> Converts the  manual applet test in the files ..
> SpanishDiacriticsTest/SpanishDiacriticsTest.html
> SpanishDiacriticsTest/SpanishDiacriticsTest.java
> .. to a main program using PassFailJFrame
> 
> Added requires windows since it seems very windows-specific.
> 
> I got rid of the redundant extra directory which makes the .java file "new" according to github but it is largely changed anyway

Phil Race has updated the pull request incrementally with two additional commits since the last revision:

 - 8327856
 - 8327856

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18208/files
  - new: https://git.openjdk.org/jdk/pull/18208/files/a2cb3493..7fb3fe7c

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18208&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18208&range=00-01

  Stats: 6 lines in 1 file changed: 1 ins; 1 del; 4 mod
  Patch: https://git.openjdk.org/jdk/pull/18208.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18208/head:pull/18208

PR: https://git.openjdk.org/jdk/pull/18208

From aivanov at openjdk.org  Tue Mar 12 17:55:12 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 12 Mar 2024 17:55:12 GMT
Subject: RFR: 8327856: Convert applet test SpanishDiacriticsTest.java to a
 main program [v2]
In-Reply-To: <WmFbIHeEf1aJLKpGOmRIoCXbhvq94HOb-rjeFQIRZpU=.ad3e7905-6675-4420-9ef1-6ce35185bf43@github.com>
References: <JnPnHUoBMQd1YGVtRimzTC2Y5Sn5ezSWq2Fkw9jh-KA=.8df82997-452b-41c9-a698-68ab33e49f13@github.com>
 <SNg1zw2YMUUXhrWAnzfI7NjNDK4dJjwgSxGwIQ1heuM=.74e12e8f-25cf-4c61-b4b5-da3b1bdde99c@github.com>
 <LtPTdEhbzu5w97v-16GSDhvLkg-41nUFhMsIaoUk5vc=.6440c8d5-4177-45b2-8d3c-cae7a7dcd839@github.com>
 <PPLRLFNzMjrrhmk9FC0AbPaehklIEa-RbdqZaMbp_NI=.25731659-a8e0-4874-b1af-f263d748a606@github.com>
 <h_Wkp4wkCjuD6PmgmH4L09f1kcfCZhw9jA4-NchhooU=.9c9866b0-e24a-4173-a86b-5d7e8e8c3712@github.com>
 <WmFbIHeEf1aJLKpGOmRIoCXbhvq94HOb-rjeFQIRZpU=.ad3e7905-6675-4420-9ef1-6ce35185bf43@github.com>
Message-ID: <2VuqrJiojAD00M1Wzqo1uJPUFUFiaQmr4iqBf2T97eo=.50c1f6d0-9288-43b9-b140-f0a518bb3f31@github.com>

On Tue, 12 Mar 2024 17:24:22 GMT, Phil Race <prr at openjdk.org> wrote:

>> What if we spell the conditions explicitly:
>> 
>> The text field should display ''o (i.e. two apostrophes and o without an acute), press Pass.
>> If you see ? (i.e. o with an acute), press Fail.
>
> I will reword it but the text is the same as was in the HTML file with just some minor grammatical changes in the surrounding text.

Making the instructions clearer helps to avoid confusion. Thank you for updating them, looks clearer now.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18208#discussion_r1521897700

From aivanov at openjdk.org  Tue Mar 12 17:55:14 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 12 Mar 2024 17:55:14 GMT
Subject: RFR: 8327856: Convert applet test SpanishDiacriticsTest.java to a
 main program [v2]
In-Reply-To: <SNg1zw2YMUUXhrWAnzfI7NjNDK4dJjwgSxGwIQ1heuM=.74e12e8f-25cf-4c61-b4b5-da3b1bdde99c@github.com>
References: <JnPnHUoBMQd1YGVtRimzTC2Y5Sn5ezSWq2Fkw9jh-KA=.8df82997-452b-41c9-a698-68ab33e49f13@github.com>
 <SNg1zw2YMUUXhrWAnzfI7NjNDK4dJjwgSxGwIQ1heuM=.74e12e8f-25cf-4c61-b4b5-da3b1bdde99c@github.com>
Message-ID: <i2qDw5OyZiVYhvGErS7bsu9OD-LfQKkUWF75doJRi_Q=.53750e98-daef-404c-b42c-c1024519afe6@github.com>

On Tue, 12 Mar 2024 12:50:16 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Phil Race has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - 8327856
>>  - 8327856
>
> test/jdk/java/awt/InputMethods/SpanishDiacriticsTest.java line 89:
> 
>> 87:         frame.setDefaultCloseOperation(WindowConstants.EXIT_ON_CLOSE);
>> 88:         frame.pack();
>> 89:         frame.setVisible(true);
> 
> Suggestion:
> 
>         frame.pack();
> 
> Calling `setVisible(true)` here causes flickering as the frame gets shown at its default location and later gets moved to its final location.
> 
> Setting close operation is redundant, `PassFailJFrame` handles closing test UI (when you use the builder pattern) and fails the test if it's closed.

Calling `setVisible(true)` does not affect functionality, purely aesthetic effect to avoid window flickering.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18208#discussion_r1521899607

From aivanov at openjdk.org  Tue Mar 12 18:01:13 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 12 Mar 2024 18:01:13 GMT
Subject: RFR: 8327856: Convert applet test SpanishDiacriticsTest.java to a
 main program [v2]
In-Reply-To: <YP6BbBdWfkZz8f1kpC1Bs-NZJ6rmhEamwg_4cZpEu8Q=.25777c87-5fcb-4dbd-9230-c5b8e281619c@github.com>
References: <JnPnHUoBMQd1YGVtRimzTC2Y5Sn5ezSWq2Fkw9jh-KA=.8df82997-452b-41c9-a698-68ab33e49f13@github.com>
 <YP6BbBdWfkZz8f1kpC1Bs-NZJ6rmhEamwg_4cZpEu8Q=.25777c87-5fcb-4dbd-9230-c5b8e281619c@github.com>
Message-ID: <3V94z10zAR33k1zhAAESJ3Kf9Z7SJTP3Lk0pBiAYyDA=.f94cbf19-2c3c-4a80-bc05-6ddc4ec8cec3@github.com>

On Tue, 12 Mar 2024 17:36:46 GMT, Phil Race <prr at openjdk.org> wrote:

>> Converts the  manual applet test in the files ..
>> SpanishDiacriticsTest/SpanishDiacriticsTest.html
>> SpanishDiacriticsTest/SpanishDiacriticsTest.java
>> .. to a main program using PassFailJFrame
>> 
>> Added requires windows since it seems very windows-specific.
>> 
>> I got rid of the redundant extra directory which makes the .java file "new" according to github but it is largely changed anyway
>
> Phil Race has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - 8327856
>  - 8327856

Looks good to me except for `setVisible(true)` in `createUI`.

-------------

Marked as reviewed by aivanov (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18208#pullrequestreview-1931891527

From prr at openjdk.org  Tue Mar 12 18:24:31 2024
From: prr at openjdk.org (Phil Race)
Date: Tue, 12 Mar 2024 18:24:31 GMT
Subject: RFR: 8327856: Convert applet test SpanishDiacriticsTest.java to a
 main program [v3]
In-Reply-To: <JnPnHUoBMQd1YGVtRimzTC2Y5Sn5ezSWq2Fkw9jh-KA=.8df82997-452b-41c9-a698-68ab33e49f13@github.com>
References: <JnPnHUoBMQd1YGVtRimzTC2Y5Sn5ezSWq2Fkw9jh-KA=.8df82997-452b-41c9-a698-68ab33e49f13@github.com>
Message-ID: <Hm9QM_p6UXkZHGRsbl0EfZpdOyU-EdE3U8Z6YQ_6wP8=.6863fdc4-f338-49ff-8308-0e552ba81445@github.com>

> Converts the  manual applet test in the files ..
> SpanishDiacriticsTest/SpanishDiacriticsTest.html
> SpanishDiacriticsTest/SpanishDiacriticsTest.java
> .. to a main program using PassFailJFrame
> 
> Added requires windows since it seems very windows-specific.
> 
> I got rid of the redundant extra directory which makes the .java file "new" according to github but it is largely changed anyway

Phil Race has updated the pull request incrementally with one additional commit since the last revision:

  8327856

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18208/files
  - new: https://git.openjdk.org/jdk/pull/18208/files/7fb3fe7c..73aa1b7a

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18208&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18208&range=01-02

  Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/18208.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18208/head:pull/18208

PR: https://git.openjdk.org/jdk/pull/18208

From aivanov at openjdk.org  Tue Mar 12 18:24:31 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 12 Mar 2024 18:24:31 GMT
Subject: RFR: 8327856: Convert applet test SpanishDiacriticsTest.java to a
 main program [v3]
In-Reply-To: <Hm9QM_p6UXkZHGRsbl0EfZpdOyU-EdE3U8Z6YQ_6wP8=.6863fdc4-f338-49ff-8308-0e552ba81445@github.com>
References: <JnPnHUoBMQd1YGVtRimzTC2Y5Sn5ezSWq2Fkw9jh-KA=.8df82997-452b-41c9-a698-68ab33e49f13@github.com>
 <Hm9QM_p6UXkZHGRsbl0EfZpdOyU-EdE3U8Z6YQ_6wP8=.6863fdc4-f338-49ff-8308-0e552ba81445@github.com>
Message-ID: <jEPUK4bWL-7XgmjoiBuxdXanfrAmeCcOm9NppXufjNI=.43baf005-4e88-4f5c-96e2-b61f32d04362@github.com>

On Tue, 12 Mar 2024 18:21:58 GMT, Phil Race <prr at openjdk.org> wrote:

>> Converts the  manual applet test in the files ..
>> SpanishDiacriticsTest/SpanishDiacriticsTest.html
>> SpanishDiacriticsTest/SpanishDiacriticsTest.java
>> .. to a main program using PassFailJFrame
>> 
>> Added requires windows since it seems very windows-specific.
>> 
>> I got rid of the redundant extra directory which makes the .java file "new" according to github but it is largely changed anyway
>
> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8327856

Marked as reviewed by aivanov (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18208#pullrequestreview-1931975342

From honkar at openjdk.org  Tue Mar 12 18:25:26 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Tue, 12 Mar 2024 18:25:26 GMT
Subject: RFR: JDK-8328000 : Convert /java/awt/im/8154816/bug8154816.java applet
 test to main
Message-ID: <FShkxXV6Z_KcU6INfTyHyx-GfO9-xpgrDJi6ZQ0bmhE=.4cfc6764-b51b-4ab6-9323-5c7c1e2ca5e7@github.com>

The following InputMethod test, bug8154816.java is converted to main using PassFailJFrame.

- test renamed to PinyinIMCapsTest
- moved one directory above - /java/awt/im/
- html file deleted.

-------------

Commit messages:
 - added requires tag
 - removed extra newline
 - test file added
 - applet test to main

Changes: https://git.openjdk.org/jdk/pull/18245/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18245&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8328000
  Stats: 168 lines in 3 files changed: 82 ins; 86 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18245.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18245/head:pull/18245

PR: https://git.openjdk.org/jdk/pull/18245

From azvegint at openjdk.org  Tue Mar 12 18:26:21 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Tue, 12 Mar 2024 18:26:21 GMT
Subject: Integrated: 8327838: Convert
 java/awt/FileDialog/MultipleMode/MultipleMode.html applet test to main
In-Reply-To: <DI0RnXYhvIrM8iYvr6t5rSadWbY_VEnhePX1QnX41dA=.ac99191d-478f-4a09-a941-f9723929634a@github.com>
References: <DI0RnXYhvIrM8iYvr6t5rSadWbY_VEnhePX1QnX41dA=.ac99191d-478f-4a09-a941-f9723929634a@github.com>
Message-ID: <PWAk3WfBUXLWfDzxEiESsI2ORSmD5JSYoDrZYECxLn8=.337a978a-9762-4f90-baac-7a7106e6fbdb@github.com>

On Mon, 11 Mar 2024 17:53:48 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

> The test is converted to main.
> Tested on Linux, Macos and Windows.

This pull request has now been integrated.

Changeset: 30249c4c
Author:    Alexander Zvegintsev <azvegint at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/30249c4cca51dccd24d5f8f58c7a34c27948a295
Stats:     438 lines in 3 files changed: 106 ins; 332 del; 0 mod

8327838: Convert java/awt/FileDialog/MultipleMode/MultipleMode.html applet test to main

Reviewed-by: aivanov, tr

-------------

PR: https://git.openjdk.org/jdk/pull/18205

From azvegint at openjdk.org  Tue Mar 12 18:27:21 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Tue, 12 Mar 2024 18:27:21 GMT
Subject: Integrated: 8327972: Convert
 java/awt/FileDialog/SaveFileNameOverrideTest/SaveFileNameOverrideTest.html
 applet test to main
In-Reply-To: <aAQg8fWlF7MafeuvNc76VYN5p6LBosaENVTOluAigfM=.b47d5d3e-6edc-4843-990f-cb489eb1aed9@github.com>
References: <aAQg8fWlF7MafeuvNc76VYN5p6LBosaENVTOluAigfM=.b47d5d3e-6edc-4843-990f-cb489eb1aed9@github.com>
Message-ID: <MNDhzbcNli320BaMY1-CtZDmrdIwEef3-mCuW9ENkk4=.8f6ea257-f689-4b57-847b-4556e4bc7439@github.com>

On Tue, 12 Mar 2024 12:34:57 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

> The test is converted to main.
> Tested on Linux, Macos and Windows.

This pull request has now been integrated.

Changeset: 7283c8b0
Author:    Alexander Zvegintsev <azvegint at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/7283c8b075aa289dbb9cb80f6937b3349c8d4769
Stats:     225 lines in 3 files changed: 91 ins; 134 del; 0 mod

8327972: Convert java/awt/FileDialog/SaveFileNameOverrideTest/SaveFileNameOverrideTest.html applet test to main

Reviewed-by: aivanov, prr

-------------

PR: https://git.openjdk.org/jdk/pull/18231

From honkar at openjdk.org  Tue Mar 12 18:29:12 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Tue, 12 Mar 2024 18:29:12 GMT
Subject: RFR: JDK-8328000 : Convert /java/awt/im/8154816/bug8154816.java
 applet test to main
In-Reply-To: <FShkxXV6Z_KcU6INfTyHyx-GfO9-xpgrDJi6ZQ0bmhE=.4cfc6764-b51b-4ab6-9323-5c7c1e2ca5e7@github.com>
References: <FShkxXV6Z_KcU6INfTyHyx-GfO9-xpgrDJi6ZQ0bmhE=.4cfc6764-b51b-4ab6-9323-5c7c1e2ca5e7@github.com>
Message-ID: <utS-riE2mXfwOc65tGvmApPzwkmCXjiy8BpSnU_yOHA=.1e3b53a1-198d-44ff-b7a4-9ed0ca4898eb@github.com>

On Tue, 12 Mar 2024 18:20:14 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

> The following InputMethod test, bug8154816.java is converted to main using PassFailJFrame.
> 
> - test renamed to PinyinIMCapsTest
> - moved one directory above - /java/awt/im/
> - html file deleted.

I tried to automate this test using Robot, but was unable to produce the same effect as a keyboard keypress for Pinyin.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18245#issuecomment-1992294533

From prr at openjdk.org  Tue Mar 12 18:30:24 2024
From: prr at openjdk.org (Phil Race)
Date: Tue, 12 Mar 2024 18:30:24 GMT
Subject: Integrated: 8327856: Convert applet test SpanishDiacriticsTest.java to
 a main program
In-Reply-To: <JnPnHUoBMQd1YGVtRimzTC2Y5Sn5ezSWq2Fkw9jh-KA=.8df82997-452b-41c9-a698-68ab33e49f13@github.com>
References: <JnPnHUoBMQd1YGVtRimzTC2Y5Sn5ezSWq2Fkw9jh-KA=.8df82997-452b-41c9-a698-68ab33e49f13@github.com>
Message-ID: <376WJeSOKzdDfgFt-ByO2StnN8TjERWS9jaJFbC5TXg=.bd0c8e7d-db5a-4759-a216-75701fd1883d@github.com>

On Mon, 11 Mar 2024 23:02:53 GMT, Phil Race <prr at openjdk.org> wrote:

> Converts the  manual applet test in the files ..
> SpanishDiacriticsTest/SpanishDiacriticsTest.html
> SpanishDiacriticsTest/SpanishDiacriticsTest.java
> .. to a main program using PassFailJFrame
> 
> Added requires windows since it seems very windows-specific.
> 
> I got rid of the redundant extra directory which makes the .java file "new" according to github but it is largely changed anyway

This pull request has now been integrated.

Changeset: 22f10e04
Author:    Phil Race <prr at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/22f10e045b3decdb51a3cc7644c47f911aec753d
Stats:     189 lines in 3 files changed: 92 ins; 97 del; 0 mod

8327856: Convert applet test SpanishDiacriticsTest.java to a main program

Reviewed-by: dmarkov, aivanov

-------------

PR: https://git.openjdk.org/jdk/pull/18208

From prr at openjdk.org  Tue Mar 12 18:54:24 2024
From: prr at openjdk.org (Phil Race)
Date: Tue, 12 Mar 2024 18:54:24 GMT
Subject: RFR: 8328004: Minor updates to TrayIcon test
 DisposeInActionEventTest.java
Message-ID: <4Zq2gsAshsqM3HxMV4jxpgm25WDx40QRJ-EuBMVaAfQ=.f96fc9c2-ad2f-4026-9d9e-74d7444bb3fb@github.com>

This was recently converted from a manual Applet to a PassFailJFrame main program
But I see a few things that could be tweaked
 - Clarify instructions
 -  Set path to PassFailJFrame
 - reduce timeout to default
 - eliminate redundant folder

-------------

Commit messages:
 - 8328004
 - 8328004

Changes: https://git.openjdk.org/jdk/pull/18246/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18246&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8328004
  Stats: 264 lines in 2 files changed: 133 ins; 131 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18246.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18246/head:pull/18246

PR: https://git.openjdk.org/jdk/pull/18246

From dnguyen at openjdk.org  Tue Mar 12 18:55:32 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Tue, 12 Mar 2024 18:55:32 GMT
Subject: RFR: 8328005: Convert java/awt/im/JTextFieldTest.java applet test to
 main
Message-ID: <L1GhxeYrU35BXYEe9h_FL05fGrPgE7q4vWv3qTOe854=.c20a5812-ec96-4541-94b8-106dd17d9f95@github.com>

Convert java/awt/im/JTextFieldTest.java applet test to main using PassFailJFrame.

-------------

Commit messages:
 - Initial test changes

Changes: https://git.openjdk.org/jdk/pull/18247/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18247&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8328005
  Stats: 72 lines in 2 files changed: 15 ins; 31 del; 26 mod
  Patch: https://git.openjdk.org/jdk/pull/18247.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18247/head:pull/18247

PR: https://git.openjdk.org/jdk/pull/18247

From prr at openjdk.org  Tue Mar 12 18:56:14 2024
From: prr at openjdk.org (Phil Race)
Date: Tue, 12 Mar 2024 18:56:14 GMT
Subject: RFR: 8315113: Print request Chromaticity.MONOCHROME attribute does
 not work on macOS
In-Reply-To: <m7sDuwEArkLnR6xti1Ld4JNfuRN2mQmn97uLnzMUWiA=.75f71128-eb19-48e5-9c21-27d2a22f0fe3@github.com>
References: <m_OJNAf9YmC4OJMwtCM5P-eklmNJUymWJjMfo5s_wpI=.7d1c5a1f-2158-49f2-906d-dc074019cb99@github.com>
 <rFR7u1Wwwgj7BLZ5pkeB-Mp0I1NTudpOexznsjHnyjc=.2ef59877-5a8e-46bc-97d3-80537f166aef@github.com>
 <m7sDuwEArkLnR6xti1Ld4JNfuRN2mQmn97uLnzMUWiA=.75f71128-eb19-48e5-9c21-27d2a22f0fe3@github.com>
Message-ID: <ujAWeDICLPxEpJW-ENStv7xATqXOsghO5LryPli-t6E=.546d1761-7760-479e-8bf9-0d54bd610cd9@github.com>

On Tue, 12 Mar 2024 17:28:57 GMT, Alexander Scherbatiy <alexsch at openjdk.org> wrote:

> > But I am really surprised to see a PR rather than a discussion first as it is making a lot of policy decisions
> > and implies we need to support something I am not sure we want to support.
> 
> There was an email with the issue discussion on the client-libs-dev alias: https://mail.openjdk.org/pipermail/client-libs-dev/2023-August/014497.html
> 
> ```
> Setting Chromaticity.MONOCHROME print request attribute on macOS
> 
> What is the right way to use different key/values (ColorModel: Gray, 
> HPColorMode: grayscale, ...) in code to set Black & White settings for 
> NSPrintInfo?
> Could it be a configuration file which contains all color model 
> key/values for all known printers?
> ```

No replies to that. Clearly it was not noticed.
A problem with all the PR notifications to the mailing lists is that real emails get overlooked.
You should have re-sent it.

I don't know what the right answer is for this. Not off the top of my head.
I just know that this smells like the Linux font configuration files which were always wrong and/or late as well
as being a serious maintenance burden.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18195#issuecomment-1992334610

From prr at openjdk.org  Tue Mar 12 19:38:14 2024
From: prr at openjdk.org (Phil Race)
Date: Tue, 12 Mar 2024 19:38:14 GMT
Subject: RFR: 8305072: Win32ShellFolder2.compareTo is inconsistent [v2]
In-Reply-To: <21db5CiFTVN7scwsIHknMxF4YaVQd06m7gUOhcCLvMI=.e2f61ea7-bf9a-4632-bf45-c89f979ae806@github.com>
References: <bEiHvkFnBZDqmiqQdk_-_mATVhDbAD7NZX7VnkHLG2E=.27ee84ba-00fd-405a-9489-8fe11c215af9@github.com>
 <21db5CiFTVN7scwsIHknMxF4YaVQd06m7gUOhcCLvMI=.e2f61ea7-bf9a-4632-bf45-c89f979ae806@github.com>
Message-ID: <6dQg9rhDwh4ZL7D2JfYpA0xNP_eJDbOK3rNgj7efckM=.c5001d8a-cce5-4a11-a91d-eda8e90b8056@github.com>

On Tue, 5 Mar 2024 17:40:01 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> The implementation of `Win32ShellFolder2.compareTo` is inconsistent: there are cases where  
>> `a < b & b < c but a == c`  
>> which *violates its general contract*.
>> 
>> In particular, it happens for the personal folder (*Documents*) if it is listed *twice*: as a special and as a regular folder.
>> 
>> The evaluation performed by the submitter of the bug provided enough details to create a test, reproduce the problem and finally resolve it.
>> 
>> Without the fix, the regression test always fails:
>> 
>> a < b & b < c but a >= c
>> where
>>   a = C:\Users<user>\Documents(true)
>>   b = C:\Users<user>(false)
>>   c = C:\Users<user>\Documents(false)
>> 
>> as well as for the reverse case: `a > b & b > c`.
>> 
>> How it is possible to have the same folder in a list of files twice remains unknown. I believe it is another bug in JDK, however, no one has been able to reproduce it so far.
>
> Alexey Ivanov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Handle fakePersonal on Windows 10
>   
>   The desktop folder on Windows 10 does not include
>   the Personal (Documents) folder.

src/java.desktop/windows/classes/sun/awt/shell/Win32ShellFolderManager2.java line 525:

> 523:         boolean special2 = sf2.isSpecial();
> 524: 
> 525:         if (special1 && special2) {

Could you please say something on how/why this change solves it ?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18126#discussion_r1522020052

From prr at openjdk.org  Tue Mar 12 20:04:13 2024
From: prr at openjdk.org (Phil Race)
Date: Tue, 12 Mar 2024 20:04:13 GMT
Subject: RFR: 8325179: Race in BasicDirectoryModel.validateFileCache [v3]
In-Reply-To: <mVHHIki7p8TDSN0TlD0kaRuNzWUHom5W-y7y51rxjSA=.35bcbabb-4c2c-4f9e-a48b-b34995336da2@github.com>
References: <nOapec57Ql6DHy57oEeWdkUGER8RYdWc2vwmJsqWDYc=.8de81954-d8c2-4937-b426-e61dde05255e@github.com>
 <mVHHIki7p8TDSN0TlD0kaRuNzWUHom5W-y7y51rxjSA=.35bcbabb-4c2c-4f9e-a48b-b34995336da2@github.com>
Message-ID: <kZ9T1t_lVzMto4NQ9zTiD5pvPitMVbCAAh2msOrmnCc=.51106a22-6d6b-4845-8f36-5bb8aa73c3ab@github.com>

On Wed, 6 Mar 2024 11:27:08 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Ensure access to the `filesLoader` field of `BasicDirectoryModel` is synchronized.
>> 
>> Without synchronization, a thread checks if `filesLoader` is not null and creates a new `FilesLoader` thread. If the thread is pre-empted between these two operations, another thread or even several threads can see the `null` value and create new `FilesLoader` threads.
>> 
>> The same way, `BasicDirectoryModel.invalidateFileCache` needs to be synchornized to interrupt the current `filesLoader` and assign `null`.
>> 
>> This bug allows reproducing `ConcurrentModificationException` seen in [JDK-8323670](https://bugs.openjdk.org/browse/JDK-8323670) and [JDK-8307091](https://bugs.openjdk.org/browse/JDK-8307091) using the test in PR #18109.
>
> Alexey Ivanov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Store the size of fileCache inside synchronized block

If this makes that CCME go away I'll be pleased.
I am assuming you've run the "full" battery of tests on this.

-------------

Marked as reviewed by prr (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18111#pullrequestreview-1932311404

From azvegint at openjdk.org  Tue Mar 12 20:09:25 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Tue, 12 Mar 2024 20:09:25 GMT
Subject: RFR: 8328011: Convert
 java/awt/Frame/GetBoundsResizeTest/GetBoundsResizeTest.java applet test to
 main
Message-ID: <77msAoji3SrhXCIcFcOTndR5MCc5jsoomdQ9Udl0WeE=.893b27fe-2ba5-48d9-920f-aab38592b614@github.com>

The test is converted to main.
Tested on Linux, Macos and Windows.

-------------

Commit messages:
 - 8328011: Convert java/awt/Frame/GetBoundsResizeTest/GetBoundsResizeTest.java applet test to main
 - 8328011: Convert java/awt/Frame/GetBoundsResizeTest/GetBoundsResizeTest.java applet test to main

Changes: https://git.openjdk.org/jdk/pull/18250/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18250&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8328011
  Stats: 271 lines in 3 files changed: 95 ins; 176 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18250.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18250/head:pull/18250

PR: https://git.openjdk.org/jdk/pull/18250

From honkar at openjdk.org  Tue Mar 12 20:09:30 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Tue, 12 Mar 2024 20:09:30 GMT
Subject: RFR: JDK-8328012 : Convert java/awt/im/8148984/bug8148984.java applet
 test to main
Message-ID: <iDY1JdxeSzLcbW-ASx1PylUqKY-kGUjMj8tr4Sj5NDM=.a0b9fbdb-a959-4e98-ae08-d086fd8f210f@github.com>

The following InputMethod test, bug8148984.java is converted to main using PassFailJFrame.

- test intruction updated to make to more clear
- test renamed to PinyinIMCommaTest
- moved one directory above - /java/awt/im/
- html file deleted.

-------------

Commit messages:
 - applet to main changes

Changes: https://git.openjdk.org/jdk/pull/18251/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18251&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8328012
  Stats: 170 lines in 3 files changed: 85 ins; 85 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18251.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18251/head:pull/18251

PR: https://git.openjdk.org/jdk/pull/18251

From azvegint at openjdk.org  Tue Mar 12 20:09:25 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Tue, 12 Mar 2024 20:09:25 GMT
Subject: RFR: 8328011: Convert
 java/awt/Frame/GetBoundsResizeTest/GetBoundsResizeTest.java applet test to
 main
In-Reply-To: <77msAoji3SrhXCIcFcOTndR5MCc5jsoomdQ9Udl0WeE=.893b27fe-2ba5-48d9-920f-aab38592b614@github.com>
References: <77msAoji3SrhXCIcFcOTndR5MCc5jsoomdQ9Udl0WeE=.893b27fe-2ba5-48d9-920f-aab38592b614@github.com>
Message-ID: <PoNxnSPkBb4Bdy-YC-sy3CCKtW9o4QB1mx7pqc99Ntc=.327a9543-9fd9-43c9-9720-9115868e65af@github.com>

On Tue, 12 Mar 2024 19:28:45 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

> The test is converted to main.
> Tested on Linux, Macos and Windows.

test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 1338:

> 1336:             if (panelCreator != null) {
> 1337:                 if (splitUI && (testWindows != null || windowListCreator != null)) {
> 1338:                     // TODO Is it required? We can support both

@aivanov-jdk please note, I am going to remove this check, it looks artificial to me.

In this test I added a JTextArea to display logs and messages. 
It looks like we could add similar functionality to PassFailJFrame (outside the scope of this issue, of course).

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18250#discussion_r1522022355

From prr at openjdk.org  Tue Mar 12 20:10:15 2024
From: prr at openjdk.org (Phil Race)
Date: Tue, 12 Mar 2024 20:10:15 GMT
Subject: RFR: 8316388: Opensource five Swing component related regression
 tests [v2]
In-Reply-To: <EHPasDTxg3TnE9aQRpJBFifbJmui-m81Aq9wCHpm2i8=.9e7f7b1b-afef-4ddf-b990-c5467d78329c@github.com>
References: <bk66ojURFnGqahRv9IYAhgumqNGFFMOfRkMUzjkIAqI=.9a8c6550-f6d1-4ee2-b53b-54dc6491ff0e@github.com>
 <EHPasDTxg3TnE9aQRpJBFifbJmui-m81Aq9wCHpm2i8=.9e7f7b1b-afef-4ddf-b990-c5467d78329c@github.com>
Message-ID: <O3uS7Lbh6A8YVDoYhRvWMJhdno3i4pHffhOCcmvhju0=.e61a34b9-b268-47b0-9130-c5858877a4cd@github.com>

On Tue, 12 Mar 2024 11:07:38 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

>> Clean up five more tests.
>> 
>> test/jdk/javax/swing/JDesktopPane/4132993/bug4132993.java
>> test/jdk/javax/swing/JDesktopPane/4773378/bug4773378.java
>> test/jdk/javax/swing/JEditorPane/4325606/bug4325606.java
>> test/jdk/javax/swing/JEditorPane/4330998/bug4330998.java
>> test/jdk/javax/swing/JEditorPane/4694598/FrameContent.html
>> test/jdk/javax/swing/JEditorPane/4694598/bug4694598.java
>
> Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Bumped copyright year of the affected tests
>   Minor changes based on the review comments

With the exception of bug4694598.java, there is no need for the extra level of folder for these tests

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18184#issuecomment-1992474806

From prr at openjdk.org  Tue Mar 12 20:10:16 2024
From: prr at openjdk.org (Phil Race)
Date: Tue, 12 Mar 2024 20:10:16 GMT
Subject: RFR: 8316388: Opensource five Swing component related regression
 tests [v2]
In-Reply-To: <f7YH-ZUti5QrS8-S3ygFr1Hj9XVNiiLqX1woPi_I_6c=.8d5ee0d4-2125-4ec6-bce7-fe45b431d584@github.com>
References: <bk66ojURFnGqahRv9IYAhgumqNGFFMOfRkMUzjkIAqI=.9a8c6550-f6d1-4ee2-b53b-54dc6491ff0e@github.com>
 <Wz8nlNpeWgJKwr9Keb8ydCDT0mn6Q1bdR4CK50zCPZ8=.f39e7e08-9ec2-472a-9c19-6ecaad9b1f04@github.com>
 <rUm-kOKAOHaPEQV2BfxmaYHQNd3rEu_IP5CrT7pSz2w=.6f9c023b-8ed8-4a8a-9667-57092c3b14a8@github.com>
 <GJGNjOXshSl4w7-HD0zKHcMid8DhMMkObc2quQfEt58=.83082644-94fe-4e14-8fd7-cc4141c41a33@github.com>
 <f7YH-ZUti5QrS8-S3ygFr1Hj9XVNiiLqX1woPi_I_6c=.8d5ee0d4-2125-4ec6-bce7-fe45b431d584@github.com>
Message-ID: <DyyMMp7wguIsiyTmxSVs1uONPctDUQ8XtjjAofojRnQ=.9ef677a0-4c43-4ae6-a403-d0d88556054d@github.com>

On Tue, 12 Mar 2024 12:18:25 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> I believe it's unexpected because we don't expect `PropertyVetoException`, in which case failure seems a better option.
>> 
>> If anything changes so that `PropertyVetoException` would be thrown all the time, the test would appear to be passing whereas it would not run at all.
>
> This is the only point with which I *disagree*.

Right, I see no reason to catch anything unless it is known to sometimes happen and not be a problem.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18184#discussion_r1522052020

From prr at openjdk.org  Tue Mar 12 20:10:16 2024
From: prr at openjdk.org (Phil Race)
Date: Tue, 12 Mar 2024 20:10:16 GMT
Subject: RFR: 8316388: Opensource five Swing component related regression
 tests [v2]
In-Reply-To: <eZS662QHcPnAwt8Qg--Og5QFWXF5FkU3cGfn-yYgELg=.9e60d711-e97f-4e25-adbd-9ef60779a23a@github.com>
References: <bk66ojURFnGqahRv9IYAhgumqNGFFMOfRkMUzjkIAqI=.9a8c6550-f6d1-4ee2-b53b-54dc6491ff0e@github.com>
 <Wz8nlNpeWgJKwr9Keb8ydCDT0mn6Q1bdR4CK50zCPZ8=.f39e7e08-9ec2-472a-9c19-6ecaad9b1f04@github.com>
 <TsbWXpNEfDOdyQ_1opNjH9LySOsVOU2lcM7xZJ60eYA=.74e9988c-beb6-4388-b263-5db0f1edc98a@github.com>
 <eZS662QHcPnAwt8Qg--Og5QFWXF5FkU3cGfn-yYgELg=.9e60d711-e97f-4e25-adbd-9ef60779a23a@github.com>
Message-ID: <xBdioKUUFWXkpcj05SMRsv-LSg-Lrvuxx4XQakXc9Qo=.6e2a2976-0b5a-4634-a32a-bfb0bc212ea3@github.com>

On Tue, 12 Mar 2024 12:06:59 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> I prefer to keep things simpler and not to create an additional possible point of failure. The supporting html file is self-explanatory and, if needed, can be changed outside of fixing the test itself.
>
> It will make the test self-contained, which, in my opinion, is preferred.

This is a good point. If we can find a way to do this without the extra file it is very much preferred.
Then we don't need the extra folder level either.

>> I do not see any harm in using JRobot, it is a Swing test after all.
>
> No harm but a dependency on a library which isn't used.

I am very much against including libraries that aren't needed.
If this test isn't using any JRobot functionality, please remove it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18184#discussion_r1522051125
PR Review Comment: https://git.openjdk.org/jdk/pull/18184#discussion_r1522049055

From azvegint at openjdk.org  Tue Mar 12 20:13:15 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Tue, 12 Mar 2024 20:13:15 GMT
Subject: RFR: 8328004: Minor updates to TrayIcon test
 DisposeInActionEventTest.java
In-Reply-To: <4Zq2gsAshsqM3HxMV4jxpgm25WDx40QRJ-EuBMVaAfQ=.f96fc9c2-ad2f-4026-9d9e-74d7444bb3fb@github.com>
References: <4Zq2gsAshsqM3HxMV4jxpgm25WDx40QRJ-EuBMVaAfQ=.f96fc9c2-ad2f-4026-9d9e-74d7444bb3fb@github.com>
Message-ID: <Eh6rc39YziMtNFCLbmv19ZXRy3PQaR80RioHhtb_UWA=.d7961ae7-ada2-4b94-9e26-cd96614cd853@github.com>

On Tue, 12 Mar 2024 18:49:03 GMT, Phil Race <prr at openjdk.org> wrote:

> This was recently converted from a manual Applet to a PassFailJFrame main program
> But I see a few things that could be tweaked
>  - Clarify instructions
>  -  Set path to PassFailJFrame
>  - reduce timeout to default
>  - eliminate redundant folder

test/jdk/java/awt/TrayIcon/DisposeInActionEventTest.java line 58:

> 56:         }
> 57:         String clickInstruction =
> 58:                 (Platform.isOSX()) ? "Right-click" : "Double click (left mouse button)";

On Linux, it triggers with a single click(Tested on Ubuntu 23.10)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18246#discussion_r1522053539

From prr at openjdk.org  Tue Mar 12 20:13:15 2024
From: prr at openjdk.org (Phil Race)
Date: Tue, 12 Mar 2024 20:13:15 GMT
Subject: RFR: 8316388: Opensource five Swing component related regression
 tests [v2]
In-Reply-To: <Yrz59WLXRE_r_BsSsgsZp6MZPkEkUXLPND--QOkiX_o=.b1273754-3066-4e2b-8c50-34efbcb61377@github.com>
References: <bk66ojURFnGqahRv9IYAhgumqNGFFMOfRkMUzjkIAqI=.9a8c6550-f6d1-4ee2-b53b-54dc6491ff0e@github.com>
 <Yrz59WLXRE_r_BsSsgsZp6MZPkEkUXLPND--QOkiX_o=.b1273754-3066-4e2b-8c50-34efbcb61377@github.com>
Message-ID: <j_rw8CySgTC4WliGC-AOIy4renX0ClbFe805J_ur6hg=.4a516eef-d2ff-4bcd-8f1e-ee93aa06997c@github.com>

On Mon, 11 Mar 2024 11:53:14 GMT, Andrey Turbanov <aturbanov at openjdk.org> wrote:

>> Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Bumped copyright year of the affected tests
>>   Minor changes based on the review comments
>
> test/jdk/javax/swing/JEditorPane/4325606/bug4325606.java line 83:
> 
>> 81:             robo.setAutoDelay(100);
>> 82:             robo.delay(1000);
>> 83:             robo.mouseMove(100,100);
> 
> Suggestion:
> 
>             robo.mouseMove(100, 100);

Whilst it is fine to use setLocation(int, int), I do agree that assuming it will be precisely honoured is risky.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18184#discussion_r1522054869

From prr at openjdk.org  Tue Mar 12 20:19:16 2024
From: prr at openjdk.org (Phil Race)
Date: Tue, 12 Mar 2024 20:19:16 GMT
Subject: RFR: 8325851: Hide PassFailJFrame.Builder constructor
In-Reply-To: <NPUEOS3SWj0H7KALdlwfdfJSxqsrpTyn9X4c1N-H8Ho=.cb175d1a-0a9b-4e23-98ae-404101a20531@github.com>
References: <NPUEOS3SWj0H7KALdlwfdfJSxqsrpTyn9X4c1N-H8Ho=.cb175d1a-0a9b-4e23-98ae-404101a20531@github.com>
Message-ID: <D3deUBB08boUcuq1UnLA_5FBbQsfZ8OPQtWhSPqiF7c=.ca21b5ff-c5fd-4029-ac33-057cd20d8325@github.com>

On Mon, 11 Mar 2024 21:18:40 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> The `Builder` class in `PassFailJFrame` is public and has a public constructor. At the same time, a better design would be to hide all the Builder constructors and rely on the `builder()` method which returns an instance of the `Builder` class.
> 
> This PR makes the constructor of the `Builder` class private so that it's not accessible directly.
> 
> Use `PassFailJFrame.builder()` to get an instance of the builder and configure parameters of `PassFailJFrame`.
> 
> I updated all the tests which used the constructor directly by calling `new PassFailJFrame.Builder()`.
> 
> I converted a few tests to use the `testUI`, which greatly simplifies the test code. This change also removes flickering of the test UI.

Marked as reviewed by prr (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18206#pullrequestreview-1932375765

From prr at openjdk.org  Tue Mar 12 20:29:19 2024
From: prr at openjdk.org (Phil Race)
Date: Tue, 12 Mar 2024 20:29:19 GMT
Subject: RFR: 8327857: Remove applet usage from JColorChooser tests
 Test4222508 [v2]
In-Reply-To: <2jj3nqjuevk8X1Ew2lCdYGdP6PVvjJii1QfKkUF0_e4=.dad52d97-0c05-4fe7-984c-b395562722f4@github.com>
References: <k-sLqO64HbTaYgimerOjfrS6NdPEYkOW4Wh9u-ln1P4=.fcb4e582-2189-4486-afb4-570cdeed6e69@github.com>
 <2jj3nqjuevk8X1Ew2lCdYGdP6PVvjJii1QfKkUF0_e4=.dad52d97-0c05-4fe7-984c-b395562722f4@github.com>
Message-ID: <EWKMDjU8d9QFOy65b0qXctZNS31eoeTbS6hbiEew4ow=.bc96b139-1fb9-402d-a82d-c4cb08157bf5@github.com>

On Tue, 12 Mar 2024 00:39:26 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> Removing applet usage from manual JColorChooser tests
>
> Alisen Chung has updated the pull request incrementally with five additional commits since the last revision:
> 
>  - fix pfjframe builder styling and jtreg manual tag
>  - revert spacing
>  - revert files
>  - restore file
>  - revert file

test/jdk/javax/swing/JColorChooser/Test4222508.java line 32:

> 30:  * @test
> 31:  * @bug 4222508
> 32:  * @library /test/jdk/java/awt/regtesthelpers /test/lib

change this to remove /test/jdk

test/jdk/javax/swing/JColorChooser/Test4222508.java line 44:

> 42:                         "and click on colors again. \n" +
> 43:                         "If the JColorChooser is disabled when the checkbox is unchecked, \n" +
> 44:                         "then pass the test.")

The line breaks here are in random odd places.
It should be more like this
"Click on colors in the JColorChooser.\n" +
"Then uncheck the checkbox and click on colors again.\n" +
"If the JColorChooser is disabled when the checkbox is unchecked, then pass the test.";

You can also  use text blocks if you want

test/jdk/javax/swing/JColorChooser/Test4222508.java line 54:

> 52: 
> 53:     public static JFrame test() {
> 54:         JFrame frame = new JFrame();

give the frame a meaningful title that is not identical to the one to the PassFailJFrame.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18209#discussion_r1522066024
PR Review Comment: https://git.openjdk.org/jdk/pull/18209#discussion_r1522068889
PR Review Comment: https://git.openjdk.org/jdk/pull/18209#discussion_r1522070278

From honkar at openjdk.org  Tue Mar 12 20:33:29 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Tue, 12 Mar 2024 20:33:29 GMT
Subject: RFR: JDK-8328012 : Convert java/awt/im/8148984/bug8148984.java
 applet test to main [v2]
In-Reply-To: <iDY1JdxeSzLcbW-ASx1PylUqKY-kGUjMj8tr4Sj5NDM=.a0b9fbdb-a959-4e98-ae08-d086fd8f210f@github.com>
References: <iDY1JdxeSzLcbW-ASx1PylUqKY-kGUjMj8tr4Sj5NDM=.a0b9fbdb-a959-4e98-ae08-d086fd8f210f@github.com>
Message-ID: <w73SrCkWS6w6DJNLa84dEUcVdwuwzTQp9YM1aHkYo8c=.aae2f099-6830-421a-8113-8d982ea57400@github.com>

> The following InputMethod test, bug8148984.java is converted to main using PassFailJFrame.
> 
> - test instructions updated to make to more clear
> - test renamed to PinyinIMCommaTest
> - moved one directory above - /java/awt/im/
> - html file deleted.

Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:

  removed unused Util from jtreg header

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18251/files
  - new: https://git.openjdk.org/jdk/pull/18251/files/4db1ad72..2253bf68

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18251&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18251&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/18251.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18251/head:pull/18251

PR: https://git.openjdk.org/jdk/pull/18251

From prr at openjdk.org  Tue Mar 12 20:43:15 2024
From: prr at openjdk.org (Phil Race)
Date: Tue, 12 Mar 2024 20:43:15 GMT
Subject: RFR: 8327872: Convert javax/swing/JToolTip/4644444/bug4644444.java
 applet test to main [v3]
In-Reply-To: <TlcvBlcu2t7ig3X4uSywRm8W3dOIYvA810VC8dFmA0I=.df4d1b49-6fbb-4752-a8f2-2e605f686083@github.com>
References: <gQj8exwWxjXFUAyXBGVxxXeflmLCCUQJ8flxhU22-7I=.75d72581-8868-4dc4-9736-af6e54dbe3ca@github.com>
 <TlcvBlcu2t7ig3X4uSywRm8W3dOIYvA810VC8dFmA0I=.df4d1b49-6fbb-4752-a8f2-2e605f686083@github.com>
Message-ID: <pAEqg9LVLHX4pgr_E7tQ8fKzzqDh8WWddfNtOwJ_5Go=.f3b0a7a7-4042-4cf3-86ae-0be3287e8da3@github.com>

On Tue, 12 Mar 2024 13:50:42 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Conversion of manual applet test to main based using PassFailJFrame manual framework
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove commented line

Marked as reviewed by prr (Reviewer).

Oh, I just noticed we have an extra folder level. Please fix that.

test/jdk/javax/swing/JToolTip/4644444/bug4644444.java line 58:

> 56:         JButton button = new JButton("Button");
> 57:         button.setToolTipText("Somthing really long 1234567890 1234567890 " +
> 58:                 "1234567890 1234567890 1234567890 1234567890 1234567890 1234567890");

VERY minor : Somthing -> Something

-------------

PR Review: https://git.openjdk.org/jdk/pull/18212#pullrequestreview-1932482393
PR Comment: https://git.openjdk.org/jdk/pull/18212#issuecomment-1992539883
PR Review Comment: https://git.openjdk.org/jdk/pull/18212#discussion_r1522083936

From prr at openjdk.org  Tue Mar 12 20:50:14 2024
From: prr at openjdk.org (Phil Race)
Date: Tue, 12 Mar 2024 20:50:14 GMT
Subject: RFR: 8327873: Convert javax/swing/border/Test4247606.java applet
 test to main [v2]
In-Reply-To: <UYnE3LP5gu-GW9KkT6DzW2ZoO_XWodi4-j3w0HS97tM=.43755923-c415-4074-a97a-5328bc2f31c6@github.com>
References: <wHX-Mo2XWPKls-WPhv6L7m1xdtKWQF40Nr-U9rjGxqw=.7f21fa24-8bc3-4c36-8132-408fe1372e60@github.com>
 <UYnE3LP5gu-GW9KkT6DzW2ZoO_XWodi4-j3w0HS97tM=.43755923-c415-4074-a97a-5328bc2f31c6@github.com>
Message-ID: <_LATXltsWFMkk0DScS2Xk5e4_Yc-iGQbts9NDYjUOQg=.84dc1a2a-8622-45df-a980-5cd33571af0c@github.com>

On Tue, 12 Mar 2024 10:01:25 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Convert javax/swing/border/Test4247606.java applet test to main based test using PassFailJFrame.
>
> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review updates

test/jdk/javax/swing/border/Test4247606.java line 47:

> 45:     public static void main(String[] args) throws Exception {
> 46:         String testInstructions = """
> 47:                 If the button do not fit into the titled border bounds

do -> does

test/jdk/javax/swing/border/Test4247606.java line 62:

> 60:     }
> 61: 
> 62:     public static JComponent init() {

It is no longer an applet. I expect we can find a different method name.

test/jdk/javax/swing/border/Test4247606.java line 74:

> 72: 
> 73:         Box main = Box.createVerticalBox();
> 74:         main.setBorder(BorderFactory.createEmptyBorder(8, 8, 8, 8));

The above empty border was not in the original test. Why is it needed ? And why the Box too ?
Surely we should just return the value of the call to create(..) ?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18213#discussion_r1522086715
PR Review Comment: https://git.openjdk.org/jdk/pull/18213#discussion_r1522090271
PR Review Comment: https://git.openjdk.org/jdk/pull/18213#discussion_r1522092280

From prr at openjdk.org  Tue Mar 12 20:53:13 2024
From: prr at openjdk.org (Phil Race)
Date: Tue, 12 Mar 2024 20:53:13 GMT
Subject: RFR: 8327874: Convert javax/swing/JTree/4314199/bug4314199.java
 applet test to main
In-Reply-To: <4HQ5z1My4A9Qcac-1K9Y9sTf7dqWpxrJtdIgSxC1vro=.41a923c6-8607-4c95-8c6f-8a6c5ed1504f@github.com>
References: <4HQ5z1My4A9Qcac-1K9Y9sTf7dqWpxrJtdIgSxC1vro=.41a923c6-8607-4c95-8c6f-8a6c5ed1504f@github.com>
Message-ID: <jfIMdRykaFAGPaN45MwGkQUZWOt3e_cYNS7VPvL9Pu8=.6fb5f88a-c736-4a08-abeb-ea99b61dc1a4@github.com>

On Tue, 12 Mar 2024 06:43:36 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

> Conversion of manual applet test to main based using PassFailJFrame manual framework

We no longer need the extra folder level.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18215#issuecomment-1992552561

From prr at openjdk.org  Tue Mar 12 20:59:19 2024
From: prr at openjdk.org (Phil Race)
Date: Tue, 12 Mar 2024 20:59:19 GMT
Subject: RFR: 8327838: Convert
 java/awt/FileDialog/MultipleMode/MultipleMode.html applet test to main [v3]
In-Reply-To: <H17CvXEDgSuAg0WQfS89BUSARAHjmpTHGTxlo786qTI=.d9705383-f15e-4551-8d08-dbe32fe44a3c@github.com>
References: <DI0RnXYhvIrM8iYvr6t5rSadWbY_VEnhePX1QnX41dA=.ac99191d-478f-4a09-a941-f9723929634a@github.com>
 <H17CvXEDgSuAg0WQfS89BUSARAHjmpTHGTxlo786qTI=.d9705383-f15e-4551-8d08-dbe32fe44a3c@github.com>
Message-ID: <F0wRC7PGuAtyv-ohHrQrZgMYW7JQ2uIGUyh05Vh3Be0=.f32a1065-e1ca-4d60-91d6-723078a709ea@github.com>

On Tue, 12 Mar 2024 10:22:35 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>> The test is converted to main.
>> Tested on Linux, Macos and Windows.
>
> Alexander Zvegintsev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   review comments

test/jdk/java/awt/FileDialog/MultipleMode.java line 70:

> 68:     }
> 69: 
> 70:     private static Frame init() {

init() -> createMultiModeFrame() ?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18205#discussion_r1522100330

From prr at openjdk.org  Tue Mar 12 20:59:19 2024
From: prr at openjdk.org (Phil Race)
Date: Tue, 12 Mar 2024 20:59:19 GMT
Subject: RFR: 8327838: Convert
 java/awt/FileDialog/MultipleMode/MultipleMode.html applet test to main [v2]
In-Reply-To: <0BgrMHnRLNliT2frpabItYx4BBckGEoj0-nRJNDkgTg=.dd03fbd1-27e3-4ff0-84da-f770f21abfcf@github.com>
References: <DI0RnXYhvIrM8iYvr6t5rSadWbY_VEnhePX1QnX41dA=.ac99191d-478f-4a09-a941-f9723929634a@github.com>
 <yW_v_dZq1oZPtGMrbPJ029j9EhrqsJNnp8gQaVfcxOc=.a9a37234-46cc-41eb-8020-c8a7e6c01ba8@github.com>
 <sgiE9ec8eeQVEi8AsQr89JqWt2U1HW0UFKZNlC2JRjs=.3b4e4821-950e-471a-a22d-c061d8534b8a@github.com>
 <qHUq3OEr1q4IJe2m08KcrB3_VvNnDjnuYjZikrKgo88=.7c14872b-f36b-4ca6-98e3-f8ce23972cb4@github.com>
 <b3gfSp2BX9u71B22ZfFXZF9QL2eyaCSwYGbwv3f5XgQ=.bc7b75c6-1ffa-40cc-9408-93b7bca20765@github.com>
 <RV5uFN4g7kJd-d_R5nv9PrL9MZeyAJ8YES8s-qLrTwk=.322e501d-4d47-4849-b866-01f3e2342de5@github.com>
 <C8J0U0Nf75Pj4wfeyThCIBrRSGBf-NuaxzQ3n3kDPo4=.5b289b53-6e29-44fe-be1c-1183c813f41f@github.com>
 <0BgrMHnRLNliT2frpabItYx4BBckGEoj0-nRJNDkgTg=.dd03fbd1-27e3-4ff0-84da-f770f21abfcf@github.com>
Message-ID: <TFcbdRnNYgLIFkeTrHZTqo682Pr6Cd3rpjjk36otIbo=.179fe3f8-061e-4d8a-8d18-7add93f5ca84@github.com>

On Tue, 12 Mar 2024 11:30:00 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> It is not in the center, because in the latest commit I added `.position(PassFailJFrame.Position.TOP_LEFT_CORNER)`, as Alexey suggested.
>
> I have 1920?1200 with 150%. This is why it doesn't fit. The second frame overlapped instructions a bit.

That would be 1280x800 user pixels ?

These days tests should be able to assume that there are 1920x1080 user-space pixels on the screen.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18205#discussion_r1522099974

From prr at openjdk.org  Tue Mar 12 21:05:15 2024
From: prr at openjdk.org (Phil Race)
Date: Tue, 12 Mar 2024 21:05:15 GMT
Subject: RFR: 8327137: Add test for ConcurrentModificationException in
 BasicDirectoryModel
In-Reply-To: <mCqqjrXVWDB2PvpOhKHx-Hr8W6tUz6v4stztGmyAeEg=.1f95da1c-e1a5-40be-be8b-0758729fa9b9@github.com>
References: <mCqqjrXVWDB2PvpOhKHx-Hr8W6tUz6v4stztGmyAeEg=.1f95da1c-e1a5-40be-be8b-0758729fa9b9@github.com>
Message-ID: <gIGqmfIGYKUboNVv9D50mSDiBnPqp_lxzKQysYU9KMY=.fdf35b88-e839-445d-995e-e45e6aa305b2@github.com>

On Mon, 4 Mar 2024 15:52:45 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> I'm adding a regression test for [JDK-8323670](https://bugs.openjdk.org/browse/JDK-8323670) and [JDK-8307091](https://bugs.openjdk.org/browse/JDK-8307091); it's also a regression test for [JDK-8240690](https://bugs.openjdk.org/browse/JDK-8240690).
> 
> I referenced this test in PR #17462 in [this comment](https://github.com/openjdk/jdk/pull/17462#issuecomment-1914844026). I fine-tuned the test since that time.
> 
> The test doesn't fail all the time without the fix for JDK-8323670, however, it fails sometimes. If you run the test several times, it will likely fail _without the fix_.
> 
> For me, the test fails about 10 times from 40 runs in the CI. It fails on macOS more frequently than on Linux.
> 
> When the test passes, it usually completes in 5 minutes.
> 
> **How the test works**
> 
> The test creates a temporary directory in the current directory and creates a number of files in it. (The number of files is controlled by `NUMBER_OF_THREADS` constant). Then the test creates `JFileChooser` in the temporary directory.
> 
> The test starts several _scanner_ threads, the number is controlled by `NUMBER_OF_THREADS`, which repeatedly call `fileChooser.rescanCurrentDirectory()`. This results in calling `BasicDirectoryModel.validateFileCache` which starts a background thread ? "Basic L&F File Loading Thread" ? to enumerate the files.
> 
> A timer is used to create new files in the directory that the file chooser is using.
> 
> After enumerating the files, the File Loading Thread posts an event to EDT. The event updates `fileCache` and fires a `ListDataEvent`.
> 
> If the File Loading Thread is iterating over `fileCache` using `Iterator` (when `fileCache.subList` or `fileCache.equals` is running; or a new `Vector` instance is created from a `fileCache` or its sublist) and `fileCache` is being updated on EDT, then `ConcurrentModificationException` is thrown.
> 
> On Linux and on _headless_ macOS, `ShellFolder.invoke` is executed in the caller, which makes it easier to reproduce the issue. Because of [JDK-8325179](https://bugs.openjdk.org/browse/JDK-8325179), there are several File Loading Threads, which also helps to reproduce the issue.
> 
> On _headful_ macOS, the `BasicDirectoryModel` is not used, so the test does not reproduce the issue.
> 
> On Windows, the test does not fail or fails with `OutOfMemoryError`. It is because all the File Loading Threads are serialised on the COM thread, `ShellFolder.invoke` submits the task to the COM thread and waits for it to complete. The chance of updating `fileCache` whil...

"When the test passes, it usually completes in 5 minutes."

and you've never seen the test time out ? I thought default jtreg timeout is 120 seconds.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18109#issuecomment-1992583634

From prr at openjdk.org  Tue Mar 12 21:06:14 2024
From: prr at openjdk.org (Phil Race)
Date: Tue, 12 Mar 2024 21:06:14 GMT
Subject: RFR: 8280392:
 java/awt/Focus/NonFocusableWindowTest/NonfocusableOwnerTest.java failed with
 "RuntimeException: Test failed." [v2]
In-Reply-To: <lz60OBe9QYgOuzQM0Uv8pF0URMvFwwAVykTE4-cfRiI=.0abd6616-e428-4986-a55a-adbf72fe91c7@github.com>
References: <o_Z6zlPUisWgc5LIglgOe4zbIjsijJfuG9MtoBveFAU=.2d730b06-211a-485e-8390-6d6f9ae75947@github.com>
 <lz60OBe9QYgOuzQM0Uv8pF0URMvFwwAVykTE4-cfRiI=.0abd6616-e428-4986-a55a-adbf72fe91c7@github.com>
Message-ID: <iiUFlbyiX-k4QQ2Uc0-uztJV-KxOmPyHVfPT3zcTfuQ=.e4f9e31c-dc2b-4561-8829-79b6956c687b@github.com>

On Thu, 7 Mar 2024 20:07:19 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> Introduce delays in test to stabilize. Test passes 50x after fix.
>
> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   update copyright, fix jtreg formatting, update frame title, expand imports

Marked as reviewed by prr (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18091#pullrequestreview-1932592126

From prr at openjdk.org  Tue Mar 12 21:07:15 2024
From: prr at openjdk.org (Phil Race)
Date: Tue, 12 Mar 2024 21:07:15 GMT
Subject: RFR: 8286759: TextComponentPrintable: consequent -> consecutive
 positions [v2]
In-Reply-To: <g3wtgOSCJWbZsGCqX5329YzMZEmYyk4_b9_KrMusGqs=.19ab236a-98ad-4ad5-8db0-9ff606997515@github.com>
References: <CTbRheJJ9yn-OaBNP3gBAhiEfSCS2K9nOXuyuVal9Ns=.72f8155d-78b0-4ec7-93f5-9457b235a205@github.com>
 <g3wtgOSCJWbZsGCqX5329YzMZEmYyk4_b9_KrMusGqs=.19ab236a-98ad-4ad5-8db0-9ff606997515@github.com>
Message-ID: <vWVJJjEqeDJMF3qwU5hSNiGFJEZ6UGorEj-br--1vAM=.591871a4-3bfe-4dd1-85fd-614c8df62c23@github.com>

On Tue, 5 Mar 2024 15:51:56 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> A trivial change in a comment: consequent ? _consecutive_ positions.
>> 
>> This was found in [a code review](https://github.com/openjdk/jdk/pull/8328#discussion_r872596373) for [JDK-8285306](https://bugs.openjdk.org/browse/JDK-8285306).
>
> Alexey Ivanov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Amend the comment with the suggested text

Marked as reviewed by prr (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18067#pullrequestreview-1932599239

From honkar at openjdk.org  Tue Mar 12 21:07:39 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Tue, 12 Mar 2024 21:07:39 GMT
Subject: RFR: JDK-8328012 : Convert InputMethod (/java/awt/im) applet tests
 to main [v3]
In-Reply-To: <iDY1JdxeSzLcbW-ASx1PylUqKY-kGUjMj8tr4Sj5NDM=.a0b9fbdb-a959-4e98-ae08-d086fd8f210f@github.com>
References: <iDY1JdxeSzLcbW-ASx1PylUqKY-kGUjMj8tr4Sj5NDM=.a0b9fbdb-a959-4e98-ae08-d086fd8f210f@github.com>
Message-ID: <41r-RpEnShR3W-_8U1yyKQ5OmfUO3FvHMLQgR9oNeB0=.b6c4544c-b75f-4476-8dee-df1dae44c7d7@github.com>

> The following InputMethod test, bug8148984.java is converted to main using PassFailJFrame.
> 
> - test instructions updated to make to more clear
> - test renamed to PinyinIMCommaTest
> - moved one directory above - /java/awt/im/
> - html file deleted.
> 
> Two tests are updated as part of this PR as they are similar, details here https://github.com/openjdk/jdk/pull/18251#issuecomment-1992577598

Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:

  added Fullstop test case

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18251/files
  - new: https://git.openjdk.org/jdk/pull/18251/files/2253bf68..e82034f4

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18251&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18251&range=01-02

  Stats: 171 lines in 3 files changed: 86 ins; 85 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18251.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18251/head:pull/18251

PR: https://git.openjdk.org/jdk/pull/18251

From honkar at openjdk.org  Tue Mar 12 21:07:39 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Tue, 12 Mar 2024 21:07:39 GMT
Subject: RFR: JDK-8328012 : Convert InputMethod (/java/awt/im) applet tests
 to main [v2]
In-Reply-To: <w73SrCkWS6w6DJNLa84dEUcVdwuwzTQp9YM1aHkYo8c=.aae2f099-6830-421a-8113-8d982ea57400@github.com>
References: <iDY1JdxeSzLcbW-ASx1PylUqKY-kGUjMj8tr4Sj5NDM=.a0b9fbdb-a959-4e98-ae08-d086fd8f210f@github.com>
 <w73SrCkWS6w6DJNLa84dEUcVdwuwzTQp9YM1aHkYo8c=.aae2f099-6830-421a-8113-8d982ea57400@github.com>
Message-ID: <QXVtZDpXdIP_PxnKdoFPGoZ6JanHIOo3ozLiAf4l6t0=.87291c95-fc0c-4b54-8259-e62e0a207420@github.com>

On Tue, 12 Mar 2024 20:33:29 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> The following InputMethod test, bug8148984.java is converted to main using PassFailJFrame.
>> 
>> - test instructions updated to make to more clear
>> - test renamed to PinyinIMCommaTest
>> - moved one directory above - /java/awt/im/
>> - html file deleted.
>> 
>> Two tests are updated as part of this PR as they are similar, details here https://github.com/openjdk/jdk/pull/18251#issuecomment-1992577598
>
> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   removed unused Util from jtreg header

`java/awt/im/8148984/bug8148984.java` (tests comma character) & `test/jdk/java/awt/im/8132503/bug8132503.java` (tests fullstop character) are similar so I'm using the same PR to update both. These tests essentially have similar instructions and test settings except testing a different character. As such these can be combined as a single test, but the instruction may become long and complex hence keeping them as separate tests.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18251#issuecomment-1992577598

From kizune at openjdk.org  Tue Mar 12 21:36:13 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Tue, 12 Mar 2024 21:36:13 GMT
Subject: RFR: 8316388: Opensource five Swing component related regression
 tests [v2]
In-Reply-To: <DyyMMp7wguIsiyTmxSVs1uONPctDUQ8XtjjAofojRnQ=.9ef677a0-4c43-4ae6-a403-d0d88556054d@github.com>
References: <bk66ojURFnGqahRv9IYAhgumqNGFFMOfRkMUzjkIAqI=.9a8c6550-f6d1-4ee2-b53b-54dc6491ff0e@github.com>
 <Wz8nlNpeWgJKwr9Keb8ydCDT0mn6Q1bdR4CK50zCPZ8=.f39e7e08-9ec2-472a-9c19-6ecaad9b1f04@github.com>
 <rUm-kOKAOHaPEQV2BfxmaYHQNd3rEu_IP5CrT7pSz2w=.6f9c023b-8ed8-4a8a-9667-57092c3b14a8@github.com>
 <GJGNjOXshSl4w7-HD0zKHcMid8DhMMkObc2quQfEt58=.83082644-94fe-4e14-8fd7-cc4141c41a33@github.com>
 <f7YH-ZUti5QrS8-S3ygFr1Hj9XVNiiLqX1woPi_I_6c=.8d5ee0d4-2125-4ec6-bce7-fe45b431d584@github.com>
 <DyyMMp7wguIsiyTmxSVs1uONPctDUQ8XtjjAofojRnQ=.9ef677a0-4c43-4ae6-a403-d0d88556054d@github.com>
Message-ID: <iVowr29aNcYaj0zwn41Ue8zgaqlIfeukG7k6E8eSl8o=.b9b3ac1e-4598-460d-9036-1083fcab4c5a@github.com>

On Tue, 12 Mar 2024 20:08:00 GMT, Phil Race <prr at openjdk.org> wrote:

>> This is the only point with which I *disagree*.
>
> Right, I see no reason to catch anything unless it is known to sometimes happen and not be a problem.

Ok, removing the try/catch clause, this will cause this exception to cause test to fail.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18184#discussion_r1522142476

From honkar at openjdk.org  Tue Mar 12 21:47:12 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Tue, 12 Mar 2024 21:47:12 GMT
Subject: RFR: 8328005: Convert java/awt/im/JTextFieldTest.java applet test
 to main
In-Reply-To: <L1GhxeYrU35BXYEe9h_FL05fGrPgE7q4vWv3qTOe854=.c20a5812-ec96-4541-94b8-106dd17d9f95@github.com>
References: <L1GhxeYrU35BXYEe9h_FL05fGrPgE7q4vWv3qTOe854=.c20a5812-ec96-4541-94b8-106dd17d9f95@github.com>
Message-ID: <8mKengQY72zZc6x55LgXMuV4LpH7s9Ak0sNY1FipFcU=.34987801-8b2e-491c-a6c3-d058b7c9d3f0@github.com>

On Tue, 12 Mar 2024 18:50:58 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

> Convert java/awt/im/JTextFieldTest.java applet test to main using PassFailJFrame.

test/jdk/java/awt/im/JTextFieldTest.java line 73:

> 71:         frame.getContentPane().add(tf2);
> 72:         frame.setDefaultCloseOperation(WindowConstants.EXIT_ON_CLOSE);
> 73:         frame.setVisible(true);

frame.setVisible(true) not required here. Can be removed has PassFailJFrame manages it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18247#discussion_r1522153325

From honkar at openjdk.org  Tue Mar 12 21:53:12 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Tue, 12 Mar 2024 21:53:12 GMT
Subject: RFR: 8328005: Convert java/awt/im/JTextFieldTest.java applet test
 to main
In-Reply-To: <L1GhxeYrU35BXYEe9h_FL05fGrPgE7q4vWv3qTOe854=.c20a5812-ec96-4541-94b8-106dd17d9f95@github.com>
References: <L1GhxeYrU35BXYEe9h_FL05fGrPgE7q4vWv3qTOe854=.c20a5812-ec96-4541-94b8-106dd17d9f95@github.com>
Message-ID: <C9bJkmUI1Hr-rh-6sodHa7NwC0muoRuKhWdaBr_KYpk=.1b77751f-4430-49c8-b7ef-10c79b0ea1c2@github.com>

On Tue, 12 Mar 2024 18:50:58 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

> Convert java/awt/im/JTextFieldTest.java applet test to main using PassFailJFrame.

test/jdk/java/awt/im/JTextFieldTest.java line 59:

> 57:             .columns(40)
> 58:             .position(PassFailJFrame.Position.TOP_LEFT_CORNER)
> 59:             .testUI(JTextFieldTest::createAndShowGUI)

TestUI automatically positioned .position() is redundant

Suggestion:

            .testUI(JTextFieldTest::createAndShowGUI)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18247#discussion_r1522158754

From honkar at openjdk.org  Tue Mar 12 21:58:13 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Tue, 12 Mar 2024 21:58:13 GMT
Subject: RFR: 8320079: The ArabicBox.java test has no control buttons [v2]
In-Reply-To: <pG0zC4m8VUNlRyEl1aPD9exDtkqU0wKRKikbGCFRuf8=.2a0250ed-3157-4303-9b7e-44efd0d17559@github.com>
References: <uW_uKMlwlOFidrejEZ7wkFRyC4Kqx_MmSQdenASo6EQ=.aebdca22-c37d-40f8-8d48-8f298f082adf@github.com>
 <pG0zC4m8VUNlRyEl1aPD9exDtkqU0wKRKikbGCFRuf8=.2a0250ed-3157-4303-9b7e-44efd0d17559@github.com>
Message-ID: <vyE6l-UBiIsQFsbYcK0Yu9PFENqMAYKFWbN70S47dus=.40936e9e-65da-4487-8417-4a0d2e59b250@github.com>

On Tue, 12 Mar 2024 16:48:28 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> The test is converted to use `PassFailJFrame`.
>> 
>> I confirmed the updated test reproduce the original problem described in [JDK-4427483](https://bugs.openjdk.org/browse/JDK-4427483) where Arabic text displayed as missing glyphs.
>
> Alexey Ivanov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Use the correct path to library

Marked as reviewed by honkar (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18234#pullrequestreview-1932771068

From kizune at openjdk.org  Tue Mar 12 22:20:14 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Tue, 12 Mar 2024 22:20:14 GMT
Subject: RFR: 8316388: Opensource five Swing component related regression
 tests [v2]
In-Reply-To: <j_rw8CySgTC4WliGC-AOIy4renX0ClbFe805J_ur6hg=.4a516eef-d2ff-4bcd-8f1e-ee93aa06997c@github.com>
References: <bk66ojURFnGqahRv9IYAhgumqNGFFMOfRkMUzjkIAqI=.9a8c6550-f6d1-4ee2-b53b-54dc6491ff0e@github.com>
 <Yrz59WLXRE_r_BsSsgsZp6MZPkEkUXLPND--QOkiX_o=.b1273754-3066-4e2b-8c50-34efbcb61377@github.com>
 <j_rw8CySgTC4WliGC-AOIy4renX0ClbFe805J_ur6hg=.4a516eef-d2ff-4bcd-8f1e-ee93aa06997c@github.com>
Message-ID: <oocaV_rYV5oIKf7VkZ9CJ41pYD9ZYEjgpqQzMfCFZ9w=.c2f0edcc-383e-4886-b622-3a6792e4de81@github.com>

On Tue, 12 Mar 2024 20:11:02 GMT, Phil Race <prr at openjdk.org> wrote:

>> test/jdk/javax/swing/JEditorPane/4325606/bug4325606.java line 83:
>> 
>>> 81:             robo.setAutoDelay(100);
>>> 82:             robo.delay(1000);
>>> 83:             robo.mouseMove(100,100);
>> 
>> Suggestion:
>> 
>>             robo.mouseMove(100, 100);
>
> Whilst it is fine to use setLocation(int, int), I do agree that assuming it will be precisely honoured is risky.

Ok, i will ise the actual location of the frame instead.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18184#discussion_r1522183171

From kizune at openjdk.org  Tue Mar 12 22:33:51 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Tue, 12 Mar 2024 22:33:51 GMT
Subject: RFR: 8316388: Opensource five Swing component related regression
 tests [v3]
In-Reply-To: <bk66ojURFnGqahRv9IYAhgumqNGFFMOfRkMUzjkIAqI=.9a8c6550-f6d1-4ee2-b53b-54dc6491ff0e@github.com>
References: <bk66ojURFnGqahRv9IYAhgumqNGFFMOfRkMUzjkIAqI=.9a8c6550-f6d1-4ee2-b53b-54dc6491ff0e@github.com>
Message-ID: <hsVJ_tuuvvy-x_JCsb2pSdzWZjKKd3cS-WuIht-hRjw=.6e39aa90-d464-4d2b-8c76-ccb68d523fce@github.com>

> Clean up five more tests.
> 
> test/jdk/javax/swing/JDesktopPane/4132993/bug4132993.java
> test/jdk/javax/swing/JDesktopPane/4773378/bug4773378.java
> test/jdk/javax/swing/JEditorPane/4325606/bug4325606.java
> test/jdk/javax/swing/JEditorPane/4330998/bug4330998.java
> test/jdk/javax/swing/JEditorPane/4694598/FrameContent.html
> test/jdk/javax/swing/JEditorPane/4694598/bug4694598.java

Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:

  Minor changes based on the review.
  Tests moved to the components folders.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18184/files
  - new: https://git.openjdk.org/jdk/pull/18184/files/84eb696b..8a3496c3

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18184&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18184&range=01-02

  Stats: 20 lines in 4 files changed: 4 ins; 7 del; 9 mod
  Patch: https://git.openjdk.org/jdk/pull/18184.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18184/head:pull/18184

PR: https://git.openjdk.org/jdk/pull/18184

From kizune at openjdk.org  Tue Mar 12 22:33:51 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Tue, 12 Mar 2024 22:33:51 GMT
Subject: RFR: 8316388: Opensource five Swing component related regression
 tests [v3]
In-Reply-To: <xBdioKUUFWXkpcj05SMRsv-LSg-Lrvuxx4XQakXc9Qo=.6e2a2976-0b5a-4634-a32a-bfb0bc212ea3@github.com>
References: <bk66ojURFnGqahRv9IYAhgumqNGFFMOfRkMUzjkIAqI=.9a8c6550-f6d1-4ee2-b53b-54dc6491ff0e@github.com>
 <Wz8nlNpeWgJKwr9Keb8ydCDT0mn6Q1bdR4CK50zCPZ8=.f39e7e08-9ec2-472a-9c19-6ecaad9b1f04@github.com>
 <TsbWXpNEfDOdyQ_1opNjH9LySOsVOU2lcM7xZJ60eYA=.74e9988c-beb6-4388-b263-5db0f1edc98a@github.com>
 <eZS662QHcPnAwt8Qg--Og5QFWXF5FkU3cGfn-yYgELg=.9e60d711-e97f-4e25-adbd-9ef60779a23a@github.com>
 <xBdioKUUFWXkpcj05SMRsv-LSg-Lrvuxx4XQakXc9Qo=.6e2a2976-0b5a-4634-a32a-bfb0bc212ea3@github.com>
Message-ID: <69zPqF_bYOTi4OPkuaUINvLJhWo-q-07ovKH3vGTH5E=.d5682e08-a711-460d-acbb-71bed7b9f6df@github.com>

On Tue, 12 Mar 2024 20:04:52 GMT, Phil Race <prr at openjdk.org> wrote:

>> No harm but a dependency on a library which isn't used.
>
> I am very much against including libraries that aren't needed.
> If this test isn't using any JRobot functionality, please remove it.

Ok, removed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18184#discussion_r1522192083

From prr at openjdk.org  Tue Mar 12 22:59:21 2024
From: prr at openjdk.org (Phil Race)
Date: Tue, 12 Mar 2024 22:59:21 GMT
Subject: RFR: 8328021: Convert applet test
 java/awt/List/SetFontTest/SetFontTest.html to main program
Message-ID: <PDXY83ODTZ4gxjrMQMJIoLyXeDHkkHJBbsoMVKwL5bQ=.ba1001ce-1197-4ea8-b9c7-bee0605dbf83@github.com>

java/awt/List/SetFontTest/SetFontTest.html is a manual applet-based test.
It can be converted to a main program test using PassFailJFrame

-------------

Commit messages:
 - 8328021
 - 8328021
 - 8328021

Changes: https://git.openjdk.org/jdk/pull/18255/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18255&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8328021
  Stats: 372 lines in 3 files changed: 95 ins; 277 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18255.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18255/head:pull/18255

PR: https://git.openjdk.org/jdk/pull/18255

From prr at openjdk.org  Tue Mar 12 23:00:17 2024
From: prr at openjdk.org (Phil Race)
Date: Tue, 12 Mar 2024 23:00:17 GMT
Subject: RFR: 8316388: Opensource five Swing component related regression
 tests [v3]
In-Reply-To: <hsVJ_tuuvvy-x_JCsb2pSdzWZjKKd3cS-WuIht-hRjw=.6e39aa90-d464-4d2b-8c76-ccb68d523fce@github.com>
References: <bk66ojURFnGqahRv9IYAhgumqNGFFMOfRkMUzjkIAqI=.9a8c6550-f6d1-4ee2-b53b-54dc6491ff0e@github.com>
 <hsVJ_tuuvvy-x_JCsb2pSdzWZjKKd3cS-WuIht-hRjw=.6e39aa90-d464-4d2b-8c76-ccb68d523fce@github.com>
Message-ID: <LaxqjxTWmttlM2GpaINulGKm-70eEHkaqlxluZXjD7k=.07934aa3-9f31-44b1-a45a-b6ca9fc68155@github.com>

On Tue, 12 Mar 2024 22:33:51 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

>> Clean up five more tests.
>> 
>> test/jdk/javax/swing/JDesktopPane/4132993/bug4132993.java
>> test/jdk/javax/swing/JDesktopPane/4773378/bug4773378.java
>> test/jdk/javax/swing/JEditorPane/4325606/bug4325606.java
>> test/jdk/javax/swing/JEditorPane/4330998/bug4330998.java
>> test/jdk/javax/swing/JEditorPane/4694598/FrameContent.html
>> test/jdk/javax/swing/JEditorPane/4694598/bug4694598.java
>
> Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Minor changes based on the review.
>   Tests moved to the components folders.

test/jdk/javax/swing/JEditorPane/4694598/FrameContent.html line 1:

> 1: <HTML><BODY>

Looks like you forgot to remove this file ?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18184#discussion_r1522219073

From prr at openjdk.org  Tue Mar 12 23:07:14 2024
From: prr at openjdk.org (Phil Race)
Date: Tue, 12 Mar 2024 23:07:14 GMT
Subject: RFR: 8316388: Opensource five Swing component related regression
 tests [v3]
In-Reply-To: <LaxqjxTWmttlM2GpaINulGKm-70eEHkaqlxluZXjD7k=.07934aa3-9f31-44b1-a45a-b6ca9fc68155@github.com>
References: <bk66ojURFnGqahRv9IYAhgumqNGFFMOfRkMUzjkIAqI=.9a8c6550-f6d1-4ee2-b53b-54dc6491ff0e@github.com>
 <hsVJ_tuuvvy-x_JCsb2pSdzWZjKKd3cS-WuIht-hRjw=.6e39aa90-d464-4d2b-8c76-ccb68d523fce@github.com>
 <LaxqjxTWmttlM2GpaINulGKm-70eEHkaqlxluZXjD7k=.07934aa3-9f31-44b1-a45a-b6ca9fc68155@github.com>
Message-ID: <0ryKzZHF2d93tY_BwUSXcLEkf53B5VqGQ3d68iWZ87A=.c87d8105-a1af-4213-a337-cbe5d5bb695a@github.com>

On Tue, 12 Mar 2024 22:57:45 GMT, Phil Race <prr at openjdk.org> wrote:

>> Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Minor changes based on the review.
>>   Tests moved to the components folders.
>
> test/jdk/javax/swing/JEditorPane/4694598/FrameContent.html line 1:
> 
>> 1: <HTML><BODY>
> 
> Looks like you forgot to remove this file ?

I'm also a bit surprised I don't see all the rest of the original html & java files anywhere now, not as deleted, not as changed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18184#discussion_r1522226490

From dnguyen at openjdk.org  Wed Mar 13 00:27:32 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Wed, 13 Mar 2024 00:27:32 GMT
Subject: RFR: 8328005: Convert java/awt/im/JTextFieldTest.java applet test
 to main [v2]
In-Reply-To: <L1GhxeYrU35BXYEe9h_FL05fGrPgE7q4vWv3qTOe854=.c20a5812-ec96-4541-94b8-106dd17d9f95@github.com>
References: <L1GhxeYrU35BXYEe9h_FL05fGrPgE7q4vWv3qTOe854=.c20a5812-ec96-4541-94b8-106dd17d9f95@github.com>
Message-ID: <YplUkKLbuHJpxhSKnrcLGhMzl0skOF2qnsd48VZrfHg=.864412ed-d927-47e5-8d3e-2f583477dad5@github.com>

> Convert java/awt/im/JTextFieldTest.java applet test to main using PassFailJFrame.

Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:

  Fix suggested redudant changes

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18247/files
  - new: https://git.openjdk.org/jdk/pull/18247/files/4c2658c5..9c1ceab9

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18247&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18247&range=00-01

  Stats: 2 lines in 1 file changed: 0 ins; 2 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18247.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18247/head:pull/18247

PR: https://git.openjdk.org/jdk/pull/18247

From honkar at openjdk.org  Wed Mar 13 00:40:14 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Wed, 13 Mar 2024 00:40:14 GMT
Subject: RFR: 8328011: Convert
 java/awt/Frame/GetBoundsResizeTest/GetBoundsResizeTest.java applet test to
 main
In-Reply-To: <77msAoji3SrhXCIcFcOTndR5MCc5jsoomdQ9Udl0WeE=.893b27fe-2ba5-48d9-920f-aab38592b614@github.com>
References: <77msAoji3SrhXCIcFcOTndR5MCc5jsoomdQ9Udl0WeE=.893b27fe-2ba5-48d9-920f-aab38592b614@github.com>
Message-ID: <oR4C7KiZWG0UMvlySL67uYwDJE7UUXooIUbsz2Frn7o=.2da982f7-2c10-459e-8508-d9212c57396b@github.com>

On Tue, 12 Mar 2024 19:28:45 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

> The test is converted to main.
> Tested on Linux, Macos and Windows.

test/jdk/java/awt/Frame/GetBoundsResizeTest.java line 76:

> 74:                 textArea
> 75:                         .append("Original Frame.getBounds() = %s\n"
> 76:                                 .formatted(frame.getBounds())));

Indentation looks off here.

test/jdk/java/awt/Frame/GetBoundsResizeTest.java line 88:

> 86:                 textArea
> 87:                         .append("Current Frame.getBounds() = %s\n"
> 88:                                 .formatted(frame.getBounds())));

Here too.

test/jdk/java/awt/Frame/GetBoundsResizeTest.java line 95:

> 93:         return frame;
> 94:     }
> 95: }

newline missing at EOF

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18250#discussion_r1522307251
PR Review Comment: https://git.openjdk.org/jdk/pull/18250#discussion_r1522307449
PR Review Comment: https://git.openjdk.org/jdk/pull/18250#discussion_r1522307686

From honkar at openjdk.org  Wed Mar 13 00:40:15 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Wed, 13 Mar 2024 00:40:15 GMT
Subject: RFR: 8328011: Convert
 java/awt/Frame/GetBoundsResizeTest/GetBoundsResizeTest.java applet test to
 main
In-Reply-To: <PoNxnSPkBb4Bdy-YC-sy3CCKtW9o4QB1mx7pqc99Ntc=.327a9543-9fd9-43c9-9720-9115868e65af@github.com>
References: <77msAoji3SrhXCIcFcOTndR5MCc5jsoomdQ9Udl0WeE=.893b27fe-2ba5-48d9-920f-aab38592b614@github.com>
 <PoNxnSPkBb4Bdy-YC-sy3CCKtW9o4QB1mx7pqc99Ntc=.327a9543-9fd9-43c9-9720-9115868e65af@github.com>
Message-ID: <a-ixU6CuSuVzH955LBRP3edwuGTIZpsSAJo7Hv0Jmjk=.1c698cf0-5072-4972-a772-4c50990e406f@github.com>

On Tue, 12 Mar 2024 19:37:55 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>> The test is converted to main.
>> Tested on Linux, Macos and Windows.
>
> test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 1338:
> 
>> 1336:             if (panelCreator != null) {
>> 1337:                 if (splitUI && (testWindows != null || windowListCreator != null)) {
>> 1338:                     // TODO Is it required? We can support both
> 
> @aivanov-jdk please note, I am going to remove this check, it looks artificial to me.
> 
> In this test I added a JTextArea to display logs and messages. 
> It looks like we could add similar functionality to PassFailJFrame (outside the scope of this issue, of course).

This looks like a valid scenario where testUI as well as splitUI are required to be used in combination. Making this change to PassFailJFrame can be helpful.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18250#discussion_r1522311897

From kizune at openjdk.org  Wed Mar 13 00:52:21 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Wed, 13 Mar 2024 00:52:21 GMT
Subject: RFR: 8316388: Opensource five Swing component related regression
 tests [v3]
In-Reply-To: <0ryKzZHF2d93tY_BwUSXcLEkf53B5VqGQ3d68iWZ87A=.c87d8105-a1af-4213-a337-cbe5d5bb695a@github.com>
References: <bk66ojURFnGqahRv9IYAhgumqNGFFMOfRkMUzjkIAqI=.9a8c6550-f6d1-4ee2-b53b-54dc6491ff0e@github.com>
 <hsVJ_tuuvvy-x_JCsb2pSdzWZjKKd3cS-WuIht-hRjw=.6e39aa90-d464-4d2b-8c76-ccb68d523fce@github.com>
 <LaxqjxTWmttlM2GpaINulGKm-70eEHkaqlxluZXjD7k=.07934aa3-9f31-44b1-a45a-b6ca9fc68155@github.com>
 <0ryKzZHF2d93tY_BwUSXcLEkf53B5VqGQ3d68iWZ87A=.c87d8105-a1af-4213-a337-cbe5d5bb695a@github.com>
Message-ID: <7eQxH7YccnlqX_6URln_xJ5si0IQ-Wzdhu1WRL59VG8=.3c4c7294-3c31-43e5-8842-c0dfa327631e@github.com>

On Tue, 12 Mar 2024 23:04:17 GMT, Phil Race <prr at openjdk.org> wrote:

>> test/jdk/javax/swing/JEditorPane/4694598/FrameContent.html line 1:
>> 
>>> 1: <HTML><BODY>
>> 
>> Looks like you forgot to remove this file ?
>
> I'm also a bit surprised I don't see all the rest of the original html & java files anywhere now, not as deleted, not as changed.

There's something wrong with the latest commit. Looking at it now.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18184#discussion_r1522320776

From azvegint at openjdk.org  Wed Mar 13 00:53:36 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Wed, 13 Mar 2024 00:53:36 GMT
Subject: RFR: 8328011: Convert
 java/awt/Frame/GetBoundsResizeTest/GetBoundsResizeTest.java applet test to
 main [v2]
In-Reply-To: <77msAoji3SrhXCIcFcOTndR5MCc5jsoomdQ9Udl0WeE=.893b27fe-2ba5-48d9-920f-aab38592b614@github.com>
References: <77msAoji3SrhXCIcFcOTndR5MCc5jsoomdQ9Udl0WeE=.893b27fe-2ba5-48d9-920f-aab38592b614@github.com>
Message-ID: <9qtp_TZCirnTU3uMugjf4btFEirXuWK8UBSqWGQ-qRQ=.9fbc6b9e-51a7-44b3-84d5-1353edd0cdbd@github.com>

> The test is converted to main.
> Tested on Linux, Macos and Windows.

Alexander Zvegintsev has updated the pull request incrementally with one additional commit since the last revision:

  minor formatting

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18250/files
  - new: https://git.openjdk.org/jdk/pull/18250/files/4bf3d766..c09f4949

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18250&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18250&range=00-01

  Stats: 7 lines in 1 file changed: 0 ins; 2 del; 5 mod
  Patch: https://git.openjdk.org/jdk/pull/18250.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18250/head:pull/18250

PR: https://git.openjdk.org/jdk/pull/18250

From azvegint at openjdk.org  Wed Mar 13 00:53:36 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Wed, 13 Mar 2024 00:53:36 GMT
Subject: RFR: 8328011: Convert
 java/awt/Frame/GetBoundsResizeTest/GetBoundsResizeTest.java applet test to
 main [v2]
In-Reply-To: <oR4C7KiZWG0UMvlySL67uYwDJE7UUXooIUbsz2Frn7o=.2da982f7-2c10-459e-8508-d9212c57396b@github.com>
References: <77msAoji3SrhXCIcFcOTndR5MCc5jsoomdQ9Udl0WeE=.893b27fe-2ba5-48d9-920f-aab38592b614@github.com>
 <oR4C7KiZWG0UMvlySL67uYwDJE7UUXooIUbsz2Frn7o=.2da982f7-2c10-459e-8508-d9212c57396b@github.com>
Message-ID: <LWzptAAZ47sxmXKLUuWkSyJ8ILee9uGJdqxERBMA-o8=.02169ce3-ea35-4ce5-9030-119d8ec2955f@github.com>

On Wed, 13 Mar 2024 00:30:56 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Alexander Zvegintsev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   minor formatting
>
> test/jdk/java/awt/Frame/GetBoundsResizeTest.java line 76:
> 
>> 74:                 textArea
>> 75:                         .append("Original Frame.getBounds() = %s\n"
>> 76:                                 .formatted(frame.getBounds())));
> 
> Indentation looks off here.

Updated

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18250#discussion_r1522321553

From honkar at openjdk.org  Wed Mar 13 00:56:17 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Wed, 13 Mar 2024 00:56:17 GMT
Subject: RFR: 8328011: Convert
 java/awt/Frame/GetBoundsResizeTest/GetBoundsResizeTest.java applet test to
 main [v2]
In-Reply-To: <9qtp_TZCirnTU3uMugjf4btFEirXuWK8UBSqWGQ-qRQ=.9fbc6b9e-51a7-44b3-84d5-1353edd0cdbd@github.com>
References: <77msAoji3SrhXCIcFcOTndR5MCc5jsoomdQ9Udl0WeE=.893b27fe-2ba5-48d9-920f-aab38592b614@github.com>
 <9qtp_TZCirnTU3uMugjf4btFEirXuWK8UBSqWGQ-qRQ=.9fbc6b9e-51a7-44b3-84d5-1353edd0cdbd@github.com>
Message-ID: <iuBJ6YxVB0HNhgvYCfclEMI1MGI7KC4UwILA2MWdUZs=.521605f2-cdfd-49ce-83eb-489e8fdc1f99@github.com>

On Wed, 13 Mar 2024 00:53:36 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>> The test is converted to main.
>> Tested on Linux, Macos and Windows.
>
> Alexander Zvegintsev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   minor formatting

Marked as reviewed by honkar (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18250#pullrequestreview-1932986444

From dnguyen at openjdk.org  Wed Mar 13 01:14:12 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Wed, 13 Mar 2024 01:14:12 GMT
Subject: RFR: 8327969: Convert javax/swing/border/Test6910490.java applet
 test to main
In-Reply-To: <ArKktd5_qKLn7B3HLdLakGlHSCWaxQ1ivx-miiQUGCQ=.604d8ce0-8405-4558-bc19-60a0d47d1122@github.com>
References: <ArKktd5_qKLn7B3HLdLakGlHSCWaxQ1ivx-miiQUGCQ=.604d8ce0-8405-4558-bc19-60a0d47d1122@github.com>
Message-ID: <vNbVMs3pIqa1h5I0a7czd-C-uPcq25LiJ-7K9xbzddc=.be33f10c-f7ee-4430-80e1-92c891b7ecf0@github.com>

On Tue, 12 Mar 2024 11:15:38 GMT, Tejesh R <tr at openjdk.org> wrote:

> Convert javax/swing/border/Test6910490.java applet test to main based test using PassFailJFrame.

Changes look straightforward and good to me.

Changes requested by dnguyen (Committer).

test/jdk/javax/swing/border/Test6910490.java line 63:

> 61:     public JFrame init() {
> 62:         Insets insets = new Insets(10, 10, 10, 10);
> 63:         JFrame frame = new JFrame("Matte border test");

Suggestion:

        JFrame frame = new JFrame("Matte Border Test");

-------------

Marked as reviewed by dnguyen (Committer).

PR Review: https://git.openjdk.org/jdk/pull/18229#pullrequestreview-1932997587
PR Review: https://git.openjdk.org/jdk/pull/18229#pullrequestreview-1932997852
PR Review Comment: https://git.openjdk.org/jdk/pull/18229#discussion_r1522337337

From dnguyen at openjdk.org  Wed Mar 13 01:14:13 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Wed, 13 Mar 2024 01:14:13 GMT
Subject: RFR: 8327969: Convert javax/swing/border/Test6910490.java applet
 test to main
In-Reply-To: <vNbVMs3pIqa1h5I0a7czd-C-uPcq25LiJ-7K9xbzddc=.be33f10c-f7ee-4430-80e1-92c891b7ecf0@github.com>
References: <ArKktd5_qKLn7B3HLdLakGlHSCWaxQ1ivx-miiQUGCQ=.604d8ce0-8405-4558-bc19-60a0d47d1122@github.com>
 <vNbVMs3pIqa1h5I0a7czd-C-uPcq25LiJ-7K9xbzddc=.be33f10c-f7ee-4430-80e1-92c891b7ecf0@github.com>
Message-ID: <mBueLcn5kgWn2-eEQu8M-Eg30B_hltObjpoQyzo2llE=.0b549948-e3ff-4048-b925-16c961ce48ff@github.com>

On Wed, 13 Mar 2024 01:11:10 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

>> Convert javax/swing/border/Test6910490.java applet test to main based test using PassFailJFrame.
>
> test/jdk/javax/swing/border/Test6910490.java line 63:
> 
>> 61:     public JFrame init() {
>> 62:         Insets insets = new Insets(10, 10, 10, 10);
>> 63:         JFrame frame = new JFrame("Matte border test");
> 
> Suggestion:
> 
>         JFrame frame = new JFrame("Matte Border Test");

Title case

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18229#discussion_r1522337788

From honkar at openjdk.org  Wed Mar 13 01:20:14 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Wed, 13 Mar 2024 01:20:14 GMT
Subject: RFR: 8327969: Convert javax/swing/border/Test6910490.java applet
 test to main
In-Reply-To: <ArKktd5_qKLn7B3HLdLakGlHSCWaxQ1ivx-miiQUGCQ=.604d8ce0-8405-4558-bc19-60a0d47d1122@github.com>
References: <ArKktd5_qKLn7B3HLdLakGlHSCWaxQ1ivx-miiQUGCQ=.604d8ce0-8405-4558-bc19-60a0d47d1122@github.com>
Message-ID: <iQ4TeB_4VSJsGe6zevQT-jGIe8QgBC53yuAXntYniMo=.b9ea7c90-86bc-41e5-99b5-c31895cbc1cd@github.com>

On Tue, 12 Mar 2024 11:15:38 GMT, Tejesh R <tr at openjdk.org> wrote:

> Convert javax/swing/border/Test6910490.java applet test to main based test using PassFailJFrame.

Marked as reviewed by honkar (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18229#pullrequestreview-1933002465

From honkar at openjdk.org  Wed Mar 13 01:23:13 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Wed, 13 Mar 2024 01:23:13 GMT
Subject: RFR: 8327980: Convert
 javax/swing/JToggleButton/4128979/bug4128979.java applet test to main
In-Reply-To: <lZHt9pYb75UtaIEtbB0paOkfqR5CUAc6tikhb9YAakU=.ff2adbed-1db2-490a-8747-66ac96d03657@github.com>
References: <lZHt9pYb75UtaIEtbB0paOkfqR5CUAc6tikhb9YAakU=.ff2adbed-1db2-490a-8747-66ac96d03657@github.com>
Message-ID: <fsD1Tq4f9aI5XhKF2rJN1SSjtF8J-Lv447WGPf_TPR0=.219bfb1a-a105-4c26-a050-55fdbb57bf20@github.com>

On Tue, 12 Mar 2024 12:49:06 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

> Conversion of manual applet test to main based using PassFailJFrame manual framework

Changes requested by honkar (Reviewer).

test/jdk/javax/swing/JToggleButton/4128979/bug4128979.java line 81:

> 79: 
> 80:     public static JFrame createAndShowUI() {
> 81:         frame = new JFrame("Test window");

Frame title can be more descriptive.

test/jdk/javax/swing/JToggleButton/4128979/bug4128979.java line 123:

> 121:         frame.setSize(600, 250);
> 122:         frame.setDefaultCloseOperation(WindowConstants.EXIT_ON_CLOSE);
> 123:         frame.setVisible(true);

frame.setVisible(true); redundant can be removed.

-------------

PR Review: https://git.openjdk.org/jdk/pull/18233#pullrequestreview-1933003573
PR Review Comment: https://git.openjdk.org/jdk/pull/18233#discussion_r1522343889
PR Review Comment: https://git.openjdk.org/jdk/pull/18233#discussion_r1522343535

From tr at openjdk.org  Wed Mar 13 03:10:12 2024
From: tr at openjdk.org (Tejesh R)
Date: Wed, 13 Mar 2024 03:10:12 GMT
Subject: RFR: 8327872: Convert javax/swing/JToolTip/4644444/bug4644444.java
 applet test to main [v3]
In-Reply-To: <TlcvBlcu2t7ig3X4uSywRm8W3dOIYvA810VC8dFmA0I=.df4d1b49-6fbb-4752-a8f2-2e605f686083@github.com>
References: <gQj8exwWxjXFUAyXBGVxxXeflmLCCUQJ8flxhU22-7I=.75d72581-8868-4dc4-9736-af6e54dbe3ca@github.com>
 <TlcvBlcu2t7ig3X4uSywRm8W3dOIYvA810VC8dFmA0I=.df4d1b49-6fbb-4752-a8f2-2e605f686083@github.com>
Message-ID: <s9TRCYwOaqOzt-noerNHes6nv0S6soBbGPmf8Hh4W-4=.dfa854ec-7780-4017-977c-407232d359e0@github.com>

On Tue, 12 Mar 2024 13:50:42 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Conversion of manual applet test to main based using PassFailJFrame manual framework
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove commented line

Marked as reviewed by tr (Committer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18212#pullrequestreview-1933084241

From kizune at openjdk.org  Wed Mar 13 04:46:14 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Wed, 13 Mar 2024 04:46:14 GMT
Subject: RFR: 8316388: Opensource five Swing component related regression
 tests [v3]
In-Reply-To: <7eQxH7YccnlqX_6URln_xJ5si0IQ-Wzdhu1WRL59VG8=.3c4c7294-3c31-43e5-8842-c0dfa327631e@github.com>
References: <bk66ojURFnGqahRv9IYAhgumqNGFFMOfRkMUzjkIAqI=.9a8c6550-f6d1-4ee2-b53b-54dc6491ff0e@github.com>
 <hsVJ_tuuvvy-x_JCsb2pSdzWZjKKd3cS-WuIht-hRjw=.6e39aa90-d464-4d2b-8c76-ccb68d523fce@github.com>
 <LaxqjxTWmttlM2GpaINulGKm-70eEHkaqlxluZXjD7k=.07934aa3-9f31-44b1-a45a-b6ca9fc68155@github.com>
 <0ryKzZHF2d93tY_BwUSXcLEkf53B5VqGQ3d68iWZ87A=.c87d8105-a1af-4213-a337-cbe5d5bb695a@github.com>
 <7eQxH7YccnlqX_6URln_xJ5si0IQ-Wzdhu1WRL59VG8=.3c4c7294-3c31-43e5-8842-c0dfa327631e@github.com>
Message-ID: <8YyEugvoumikE2jnUD1332TWjKCr3P-mUjSu7wi_0IA=.7579aae5-8faf-4343-86d9-1a09cb7eeba8@github.com>

On Wed, 13 Mar 2024 00:49:15 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

>> I'm also a bit surprised I don't see all the rest of the original html & java files anywhere now, not as deleted, not as changed.
>
> There's something wrong with the latest commit. Looking at it now.

Ok, either github or skara got mad at me for pushing commit with both rename and edit changes of the same files. Tried to fix it but it only gets worse so what i'm going to do is i will clone a fresh repository, move stuff there, close this PR and create a new one tomorrow morning with the latest versions of files in correct places.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18184#discussion_r1522506236

From tr at openjdk.org  Wed Mar 13 04:49:26 2024
From: tr at openjdk.org (Tejesh R)
Date: Wed, 13 Mar 2024 04:49:26 GMT
Subject: RFR: 8327969: Convert javax/swing/border/Test6910490.java applet
 test to main [v2]
In-Reply-To: <ArKktd5_qKLn7B3HLdLakGlHSCWaxQ1ivx-miiQUGCQ=.604d8ce0-8405-4558-bc19-60a0d47d1122@github.com>
References: <ArKktd5_qKLn7B3HLdLakGlHSCWaxQ1ivx-miiQUGCQ=.604d8ce0-8405-4558-bc19-60a0d47d1122@github.com>
Message-ID: <3rekONFkE6iTJQtljUWwkpZ0NRWacqI3cK6pO33ao_U=.62c269c8-3169-4748-8dcc-c7c8ec37306e@github.com>

> Convert javax/swing/border/Test6910490.java applet test to main based test using PassFailJFrame.

Tejesh R has updated the pull request incrementally with one additional commit since the last revision:

  Review updates

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18229/files
  - new: https://git.openjdk.org/jdk/pull/18229/files/8e4729c3..d8f01e22

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18229&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18229&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/18229.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18229/head:pull/18229

PR: https://git.openjdk.org/jdk/pull/18229

From tr at openjdk.org  Wed Mar 13 04:54:23 2024
From: tr at openjdk.org (Tejesh R)
Date: Wed, 13 Mar 2024 04:54:23 GMT
Subject: RFR: 8327969: Convert javax/swing/border/Test6910490.java applet
 test to main [v3]
In-Reply-To: <ArKktd5_qKLn7B3HLdLakGlHSCWaxQ1ivx-miiQUGCQ=.604d8ce0-8405-4558-bc19-60a0d47d1122@github.com>
References: <ArKktd5_qKLn7B3HLdLakGlHSCWaxQ1ivx-miiQUGCQ=.604d8ce0-8405-4558-bc19-60a0d47d1122@github.com>
Message-ID: <wN5NloPTsZWKmrKiryRI_C49_gdcOhAYnGonH38_-jA=.36377aa0-94ad-4ebb-a8aa-c487ab2a26bf@github.com>

> Convert javax/swing/border/Test6910490.java applet test to main based test using PassFailJFrame.

Tejesh R has updated the pull request incrementally with one additional commit since the last revision:

  Review updates

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18229/files
  - new: https://git.openjdk.org/jdk/pull/18229/files/d8f01e22..11a0e2c3

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18229&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18229&range=01-02

  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/18229.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18229/head:pull/18229

PR: https://git.openjdk.org/jdk/pull/18229

From tr at openjdk.org  Wed Mar 13 05:00:35 2024
From: tr at openjdk.org (Tejesh R)
Date: Wed, 13 Mar 2024 05:00:35 GMT
Subject: RFR: 8327873: Convert javax/swing/border/Test4247606.java applet
 test to main [v3]
In-Reply-To: <wHX-Mo2XWPKls-WPhv6L7m1xdtKWQF40Nr-U9rjGxqw=.7f21fa24-8bc3-4c36-8132-408fe1372e60@github.com>
References: <wHX-Mo2XWPKls-WPhv6L7m1xdtKWQF40Nr-U9rjGxqw=.7f21fa24-8bc3-4c36-8132-408fe1372e60@github.com>
Message-ID: <Kpj8ZEwW-6xNC2kfb5JOknRvpsP6zDVZuS8k3K4pFwQ=.ba2fe6e3-dd7f-4820-aa6c-47005c87db62@github.com>

> Convert javax/swing/border/Test4247606.java applet test to main based test using PassFailJFrame.

Tejesh R has updated the pull request incrementally with one additional commit since the last revision:

  Review updates

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18213/files
  - new: https://git.openjdk.org/jdk/pull/18213/files/22f73583..e1a5a360

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18213&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18213&range=01-02

  Stats: 8 lines in 1 file changed: 0 ins; 4 del; 4 mod
  Patch: https://git.openjdk.org/jdk/pull/18213.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18213/head:pull/18213

PR: https://git.openjdk.org/jdk/pull/18213

From tr at openjdk.org  Wed Mar 13 05:00:36 2024
From: tr at openjdk.org (Tejesh R)
Date: Wed, 13 Mar 2024 05:00:36 GMT
Subject: RFR: 8327873: Convert javax/swing/border/Test4247606.java applet
 test to main [v2]
In-Reply-To: <_LATXltsWFMkk0DScS2Xk5e4_Yc-iGQbts9NDYjUOQg=.84dc1a2a-8622-45df-a980-5cd33571af0c@github.com>
References: <wHX-Mo2XWPKls-WPhv6L7m1xdtKWQF40Nr-U9rjGxqw=.7f21fa24-8bc3-4c36-8132-408fe1372e60@github.com>
 <UYnE3LP5gu-GW9KkT6DzW2ZoO_XWodi4-j3w0HS97tM=.43755923-c415-4074-a97a-5328bc2f31c6@github.com>
 <_LATXltsWFMkk0DScS2Xk5e4_Yc-iGQbts9NDYjUOQg=.84dc1a2a-8622-45df-a980-5cd33571af0c@github.com>
Message-ID: <2WSOzJnACIV8zFYfVF7D1N38SVEqPQCJyB4Pl_O8JsI=.9b831735-31f2-4239-8bd1-31ab6b98c2d4@github.com>

On Tue, 12 Mar 2024 20:47:47 GMT, Phil Race <prr at openjdk.org> wrote:

>> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review updates
>
> test/jdk/javax/swing/border/Test4247606.java line 74:
> 
>> 72: 
>> 73:         Box main = Box.createVerticalBox();
>> 74:         main.setBorder(BorderFactory.createEmptyBorder(8, 8, 8, 8));
> 
> The above empty border was not in the original test. Why is it needed ? And why the Box too ?
> Surely we should just return the value of the call to create(..) ?

Yes, we can return the JPanel directly instead of Box.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18213#discussion_r1522517361

From tr at openjdk.org  Wed Mar 13 05:06:14 2024
From: tr at openjdk.org (Tejesh R)
Date: Wed, 13 Mar 2024 05:06:14 GMT
Subject: RFR: 8327857: Remove applet usage from JColorChooser tests
 Test4222508 [v2]
In-Reply-To: <2jj3nqjuevk8X1Ew2lCdYGdP6PVvjJii1QfKkUF0_e4=.dad52d97-0c05-4fe7-984c-b395562722f4@github.com>
References: <k-sLqO64HbTaYgimerOjfrS6NdPEYkOW4Wh9u-ln1P4=.fcb4e582-2189-4486-afb4-570cdeed6e69@github.com>
 <2jj3nqjuevk8X1Ew2lCdYGdP6PVvjJii1QfKkUF0_e4=.dad52d97-0c05-4fe7-984c-b395562722f4@github.com>
Message-ID: <s3W4daxbQHMsGJe8Nlny6bNE1gv4WmlMPeB74mhHlrU=.274bd620-1b43-40a5-8890-287b912ac254@github.com>

On Tue, 12 Mar 2024 00:39:26 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> Removing applet usage from manual JColorChooser tests
>
> Alisen Chung has updated the pull request incrementally with five additional commits since the last revision:
> 
>  - fix pfjframe builder styling and jtreg manual tag
>  - revert spacing
>  - revert files
>  - restore file
>  - revert file

test/jdk/javax/swing/JColorChooser/Test4222508.java line 37:

> 35:  * @run main/manual Test4222508
> 36:  */
> 37: public final class Test4222508 {

line space here.

test/jdk/javax/swing/JColorChooser/Test4222508.java line 61:

> 59: 
> 60:         frame.getContentPane().add(chooser, BorderLayout.SOUTH);
> 61:         frame.getContentPane().add(checkbox, BorderLayout.NORTH);

U can directly add to frame, without getting the ContentPane.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18209#discussion_r1522521299
PR Review Comment: https://git.openjdk.org/jdk/pull/18209#discussion_r1522521879

From tr at openjdk.org  Wed Mar 13 05:15:16 2024
From: tr at openjdk.org (Tejesh R)
Date: Wed, 13 Mar 2024 05:15:16 GMT
Subject: RFR: 8328004: Minor updates to TrayIcon test
 DisposeInActionEventTest.java
In-Reply-To: <4Zq2gsAshsqM3HxMV4jxpgm25WDx40QRJ-EuBMVaAfQ=.f96fc9c2-ad2f-4026-9d9e-74d7444bb3fb@github.com>
References: <4Zq2gsAshsqM3HxMV4jxpgm25WDx40QRJ-EuBMVaAfQ=.f96fc9c2-ad2f-4026-9d9e-74d7444bb3fb@github.com>
Message-ID: <xMZKPOhHKquFqscY7E7GRG8M5t9lFdfKp6lkqgdPTKQ=.2137d4e7-a3b4-493d-95c6-58984e0371da@github.com>

On Tue, 12 Mar 2024 18:49:03 GMT, Phil Race <prr at openjdk.org> wrote:

> This was recently converted from a manual Applet to a PassFailJFrame main program
> But I see a few things that could be tweaked
>  - Clarify instructions
>  -  Set path to PassFailJFrame
>  - reduce timeout to default
>  - eliminate redundant folder

`textArea` can be moved inside `showFrameAndIcon()`.

-------------

PR Review: https://git.openjdk.org/jdk/pull/18246#pullrequestreview-1933175995

From psadhukhan at openjdk.org  Wed Mar 13 05:18:23 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Wed, 13 Mar 2024 05:18:23 GMT
Subject: RFR: 8327752: Convert
 javax/swing/JOptionPane/4174551/bug4174551.java applet to main [v2]
In-Reply-To: <uEqsAwVSEu11kSzb6ccgfje4GyOGoZ4G0Wk59AYnvAI=.37029531-7173-4ea8-9ad7-3eb3dadde5a0@github.com>
References: <uEqsAwVSEu11kSzb6ccgfje4GyOGoZ4G0Wk59AYnvAI=.37029531-7173-4ea8-9ad7-3eb3dadde5a0@github.com>
Message-ID: <jmLu6jzpq9ic58H3FgIKohAb_Z44JE17Gedbjryz-0k=.89879927-bc76-4d2f-8558-995e3114b792@github.com>

> Conversion of manual applet test to main based using PassFailJFrame manual framework

Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:

  Remove redundant dir

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18228/files
  - new: https://git.openjdk.org/jdk/pull/18228/files/0597f306..0bade49a

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18228&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18228&range=00-01

  Stats: 0 lines in 1 file changed: 0 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18228.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18228/head:pull/18228

PR: https://git.openjdk.org/jdk/pull/18228

From abhiscxk at openjdk.org  Wed Mar 13 05:19:32 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Wed, 13 Mar 2024 05:19:32 GMT
Subject: RFR: 8327874: Convert javax/swing/JTree/4314199/bug4314199.java
 applet test to main [v2]
In-Reply-To: <4HQ5z1My4A9Qcac-1K9Y9sTf7dqWpxrJtdIgSxC1vro=.41a923c6-8607-4c95-8c6f-8a6c5ed1504f@github.com>
References: <4HQ5z1My4A9Qcac-1K9Y9sTf7dqWpxrJtdIgSxC1vro=.41a923c6-8607-4c95-8c6f-8a6c5ed1504f@github.com>
Message-ID: <fkPnsJhSLbXmHNeZSo3pjcJZRAiwhSOjyraO8R7iXN4=.54918c80-5210-4bcd-bd67-a1832390ebbc@github.com>

> Conversion of manual applet test to main based using PassFailJFrame manual framework

Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:

  Review comment update

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18215/files
  - new: https://git.openjdk.org/jdk/pull/18215/files/d8d6aaf0..b99be0aa

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18215&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18215&range=00-01

  Stats: 199 lines in 2 files changed: 99 ins; 100 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18215.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18215/head:pull/18215

PR: https://git.openjdk.org/jdk/pull/18215

From psadhukhan at openjdk.org  Wed Mar 13 05:21:32 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Wed, 13 Mar 2024 05:21:32 GMT
Subject: RFR: 8327753: Convert
 javax/swing/JOptionPane/8024926/bug8024926.java applet to main [v2]
In-Reply-To: <Mh1aFrqe1Kw2tD_2nNzeAoMRhSWzNoh67d-2yTqoIPE=.e8e324d4-f0fa-4b41-b2ea-39cc18faf088@github.com>
References: <Mh1aFrqe1Kw2tD_2nNzeAoMRhSWzNoh67d-2yTqoIPE=.e8e324d4-f0fa-4b41-b2ea-39cc18faf088@github.com>
Message-ID: <XvhjkzvZ6qLmp2eWL1iF1ztfTRgGe4aZGUZ0epXBV2w=.654067f3-1f2b-429b-9656-2360600e09f9@github.com>

> Conversion of manual applet test to main based using PassFailJFrame manual framework

Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:

  Remove redundant dir

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18232/files
  - new: https://git.openjdk.org/jdk/pull/18232/files/7cdfccd2..b3cae5e6

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18232&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18232&range=00-01

  Stats: 0 lines in 1 file changed: 0 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18232.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18232/head:pull/18232

PR: https://git.openjdk.org/jdk/pull/18232

From abhiscxk at openjdk.org  Wed Mar 13 05:27:43 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Wed, 13 Mar 2024 05:27:43 GMT
Subject: RFR: 8327872: Convert javax/swing/JToolTip/4644444/bug4644444.java
 applet test to main [v4]
In-Reply-To: <gQj8exwWxjXFUAyXBGVxxXeflmLCCUQJ8flxhU22-7I=.75d72581-8868-4dc4-9736-af6e54dbe3ca@github.com>
References: <gQj8exwWxjXFUAyXBGVxxXeflmLCCUQJ8flxhU22-7I=.75d72581-8868-4dc4-9736-af6e54dbe3ca@github.com>
Message-ID: <jpuDhRfIz9dNOU371kmIwtu_lnF-Bg6zs5lAZitGeWw=.5d975d31-b82f-485a-b077-49d21d98a044@github.com>

> Conversion of manual applet test to main based using PassFailJFrame manual framework

Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:

  Test file moved outside of folder

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18212/files
  - new: https://git.openjdk.org/jdk/pull/18212/files/0892ab7c..a1adcc7c

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18212&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18212&range=02-03

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/18212.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18212/head:pull/18212

PR: https://git.openjdk.org/jdk/pull/18212

From prr at openjdk.org  Wed Mar 13 05:35:13 2024
From: prr at openjdk.org (Phil Race)
Date: Wed, 13 Mar 2024 05:35:13 GMT
Subject: RFR: 8328004: Minor updates to TrayIcon test
 DisposeInActionEventTest.java
In-Reply-To: <Eh6rc39YziMtNFCLbmv19ZXRy3PQaR80RioHhtb_UWA=.d7961ae7-ada2-4b94-9e26-cd96614cd853@github.com>
References: <4Zq2gsAshsqM3HxMV4jxpgm25WDx40QRJ-EuBMVaAfQ=.f96fc9c2-ad2f-4026-9d9e-74d7444bb3fb@github.com>
 <Eh6rc39YziMtNFCLbmv19ZXRy3PQaR80RioHhtb_UWA=.d7961ae7-ada2-4b94-9e26-cd96614cd853@github.com>
Message-ID: <NN8a6nD8c62Te_T4545qHRH_M3Xa3nKItMshzBEFd-c=.ec635821-afeb-49e0-a6bb-463a0383e99b@github.com>

On Tue, 12 Mar 2024 20:09:35 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>> This was recently converted from a manual Applet to a PassFailJFrame main program
>> But I see a few things that could be tweaked
>>  - Clarify instructions
>>  -  Set path to PassFailJFrame
>>  - reduce timeout to default
>>  - eliminate redundant folder
>
> test/jdk/java/awt/TrayIcon/DisposeInActionEventTest.java line 58:
> 
>> 56:         }
>> 57:         String clickInstruction =
>> 58:                 (Platform.isOSX()) ? "Right-click" : "Double click (left mouse button)";
> 
> On Linux, it triggers with a single click(Tested on Ubuntu 23.10)

Manual tests that require a tester's interpretation and that are specific to the way a platform expects user interaction can be  subjective but the idea is that they are objective. I already didn't like the clickInstruction logic, now I  like it even less.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18246#discussion_r1522547494

From abhiscxk at openjdk.org  Wed Mar 13 05:38:35 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Wed, 13 Mar 2024 05:38:35 GMT
Subject: RFR: 8327980: Convert
 javax/swing/JToggleButton/4128979/bug4128979.java applet test to main [v2]
In-Reply-To: <lZHt9pYb75UtaIEtbB0paOkfqR5CUAc6tikhb9YAakU=.ff2adbed-1db2-490a-8747-66ac96d03657@github.com>
References: <lZHt9pYb75UtaIEtbB0paOkfqR5CUAc6tikhb9YAakU=.ff2adbed-1db2-490a-8747-66ac96d03657@github.com>
Message-ID: <h9V1lpm9LrxoTXicUWMB1SyIDjJmPXlp5ohLCmpt3Kw=.32d56f64-83ae-47cc-86ec-efe8a568e038@github.com>

> Conversion of manual applet test to main based using PassFailJFrame manual framework

Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:

  Review comment fix

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18233/files
  - new: https://git.openjdk.org/jdk/pull/18233/files/104ad507..61318960

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18233&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18233&range=00-01

  Stats: 3 lines in 1 file changed: 0 ins; 2 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/18233.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18233/head:pull/18233

PR: https://git.openjdk.org/jdk/pull/18233

From prr at openjdk.org  Wed Mar 13 05:40:12 2024
From: prr at openjdk.org (Phil Race)
Date: Wed, 13 Mar 2024 05:40:12 GMT
Subject: RFR: 8327872: Convert javax/swing/JToolTip/4644444/bug4644444.java
 applet test to main [v4]
In-Reply-To: <jpuDhRfIz9dNOU371kmIwtu_lnF-Bg6zs5lAZitGeWw=.5d975d31-b82f-485a-b077-49d21d98a044@github.com>
References: <gQj8exwWxjXFUAyXBGVxxXeflmLCCUQJ8flxhU22-7I=.75d72581-8868-4dc4-9736-af6e54dbe3ca@github.com>
 <jpuDhRfIz9dNOU371kmIwtu_lnF-Bg6zs5lAZitGeWw=.5d975d31-b82f-485a-b077-49d21d98a044@github.com>
Message-ID: <8jbrQ40omnCFSfwlC3USolGNnMLbeHUP8eGuZMMMH2Q=.b9731203-dafa-47d9-9e76-24ab33b9f4c6@github.com>

On Wed, 13 Mar 2024 05:27:43 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Conversion of manual applet test to main based using PassFailJFrame manual framework
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Test file moved outside of folder

Marked as reviewed by prr (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18212#pullrequestreview-1933200257

From prr at openjdk.org  Wed Mar 13 05:46:15 2024
From: prr at openjdk.org (Phil Race)
Date: Wed, 13 Mar 2024 05:46:15 GMT
Subject: RFR: 8327753: Convert
 javax/swing/JOptionPane/8024926/bug8024926.java applet to main [v2]
In-Reply-To: <XvhjkzvZ6qLmp2eWL1iF1ztfTRgGe4aZGUZ0epXBV2w=.654067f3-1f2b-429b-9656-2360600e09f9@github.com>
References: <Mh1aFrqe1Kw2tD_2nNzeAoMRhSWzNoh67d-2yTqoIPE=.e8e324d4-f0fa-4b41-b2ea-39cc18faf088@github.com>
 <XvhjkzvZ6qLmp2eWL1iF1ztfTRgGe4aZGUZ0epXBV2w=.654067f3-1f2b-429b-9656-2360600e09f9@github.com>
Message-ID: <W9FX6uDmrG2exwdtiAs4sq8AP_RFqX876RyDcaPbbTA=.3162b12b-db3d-4db5-b63b-faf8926f5696@github.com>

On Wed, 13 Mar 2024 05:21:32 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Conversion of manual applet test to main based using PassFailJFrame manual framework
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove redundant dir

test/jdk/javax/swing/JOptionPane/bug8024926.java line 46:

> 44:                 Verify that high resolution system icons are used
> 45:                  in JOptionPane on HiDPI displays.
> 46:                 1) Run the test on Retina display or enable the Quartz Debug

Quartz debug ? How ? And we don't even use Quartz.
The pass criteria is completely subjective. 
So this test looks like it needs to be better.
If you can't figure out a better test for this in less than a day just delete this useless thing.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18232#discussion_r1522556572

From prr at openjdk.org  Wed Mar 13 05:48:12 2024
From: prr at openjdk.org (Phil Race)
Date: Wed, 13 Mar 2024 05:48:12 GMT
Subject: RFR: 8327752: Convert
 javax/swing/JOptionPane/4174551/bug4174551.java applet to main [v2]
In-Reply-To: <jmLu6jzpq9ic58H3FgIKohAb_Z44JE17Gedbjryz-0k=.89879927-bc76-4d2f-8558-995e3114b792@github.com>
References: <uEqsAwVSEu11kSzb6ccgfje4GyOGoZ4G0Wk59AYnvAI=.37029531-7173-4ea8-9ad7-3eb3dadde5a0@github.com>
 <jmLu6jzpq9ic58H3FgIKohAb_Z44JE17Gedbjryz-0k=.89879927-bc76-4d2f-8558-995e3114b792@github.com>
Message-ID: <yfZT_pA_p2Rw59j-3wQ8rX6G1gA9BsZzmeqckmL5TdE=.769b177e-6927-415e-ad15-10016599cadd@github.com>

On Wed, 13 Mar 2024 05:18:23 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Conversion of manual applet test to main based using PassFailJFrame manual framework
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove redundant dir

test/jdk/javax/swing/JOptionPane/bug4174551.java line 43:

> 41:           It should be true even on OS X.
> 42:           If it is not so press "Fail" else press "Pass". """;
> 43: 

These instructions are so odd. How is the tester supposed to know the size they see ?
What can we do better ?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18228#discussion_r1522558818

From tr at openjdk.org  Wed Mar 13 05:55:22 2024
From: tr at openjdk.org (Tejesh R)
Date: Wed, 13 Mar 2024 05:55:22 GMT
Subject: RFR: 8328030: Convert
 javax/swing/text/GlyphView/4984669/bug4984669.java applet test to main
Message-ID: <A08Xop2Zkm3QWsIXqy6DnupA4aku_YonZ5kpD4Mclrs=.0f8874a0-d2ba-4042-9768-e80dbfb44356@github.com>

Convert javax/swing/text/GlyphView/4984669/bug4984669.java manual applet test to main based using PassFailJFrame.

-------------

Commit messages:
 - Conversion from Applet to Main

Changes: https://git.openjdk.org/jdk/pull/18256/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18256&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8328030
  Stats: 165 lines in 3 files changed: 80 ins; 85 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18256.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18256/head:pull/18256

PR: https://git.openjdk.org/jdk/pull/18256

From psadhukhan at openjdk.org  Wed Mar 13 06:13:36 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Wed, 13 Mar 2024 06:13:36 GMT
Subject: RFR: 8327754: Convert javax/swing/JPopupMenu/7160604/bug7160604.java
 applet to main
Message-ID: <7frwXMi-bkKDX7Xw-pSh-AtGg7PcEdykdSmbvlVylhI=.9c9002c1-9c12-44ad-916a-f6c7dfd579ff@github.com>

Conversion of manual applet test to main based using PassFailJFrame manual framework

-------------

Commit messages:
 - Fix
 - 8327754: Convert javax/swing/JPopupMenu/7160604/bug7160604.java applet to main

Changes: https://git.openjdk.org/jdk/pull/18257/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18257&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8327754
  Stats: 237 lines in 3 files changed: 112 ins; 125 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18257.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18257/head:pull/18257

PR: https://git.openjdk.org/jdk/pull/18257

From psadhukhan at openjdk.org  Wed Mar 13 06:35:33 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Wed, 13 Mar 2024 06:35:33 GMT
Subject: RFR: 8327755: Convert javax/swing/JScrollBar/8039464/Test8039464.java
 applet to main
Message-ID: <pn0rpaAbI1GrXNB2gVRKVEilfCbM0NX6M-T5E_xaidw=.96b0b4fb-ef4b-4749-b143-ed4a67531fd1@github.com>

Conversion of manual applet test to main based using PassFailJFrame manual framework

-------------

Commit messages:
 - 8327755: Convert javax/swing/JScrollBar/8039464/Test8039464.java applet to main

Changes: https://git.openjdk.org/jdk/pull/18258/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18258&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8327755
  Stats: 219 lines in 3 files changed: 95 ins; 124 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18258.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18258/head:pull/18258

PR: https://git.openjdk.org/jdk/pull/18258

From kizune at openjdk.org  Wed Mar 13 06:51:25 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Wed, 13 Mar 2024 06:51:25 GMT
Subject: Withdrawn: 8316388: Opensource five Swing component related regression
 tests
In-Reply-To: <bk66ojURFnGqahRv9IYAhgumqNGFFMOfRkMUzjkIAqI=.9a8c6550-f6d1-4ee2-b53b-54dc6491ff0e@github.com>
References: <bk66ojURFnGqahRv9IYAhgumqNGFFMOfRkMUzjkIAqI=.9a8c6550-f6d1-4ee2-b53b-54dc6491ff0e@github.com>
Message-ID: <-3Cb6R_Devak8w2HldVSRO2Jn4aYl1OjW-CJHiKQcmY=.69d5af32-09b6-46d9-9b2d-05a9e7934eff@github.com>

On Mon, 11 Mar 2024 09:41:47 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

> Clean up five more tests.
> 
> test/jdk/javax/swing/JDesktopPane/4132993/bug4132993.java
> test/jdk/javax/swing/JDesktopPane/4773378/bug4773378.java
> test/jdk/javax/swing/JEditorPane/4325606/bug4325606.java
> test/jdk/javax/swing/JEditorPane/4330998/bug4330998.java
> test/jdk/javax/swing/JEditorPane/4694598/FrameContent.html
> test/jdk/javax/swing/JEditorPane/4694598/bug4694598.java

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.org/jdk/pull/18184

From kizune at openjdk.org  Wed Mar 13 06:55:40 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Wed, 13 Mar 2024 06:55:40 GMT
Subject: RFR: 8316388: Opensource five Swing component related regression tests
Message-ID: <lyqr03dS3RFZwQum85-sdTUI2flExMCQm9Dps70wX5w=.1e207aa6-34e2-48e5-866c-bc39eb8d479f@github.com>

Cleaned up five more tests.

Continuation of https://github.com/openjdk/jdk/pull/18184

Unfortunately one of the commits rendered the whole PR invalid so i closed it and restarting it here.
All comments from the previous review are addressed.

-------------

Commit messages:
 - 8316388: Opensource five Swing component related regression tests

Changes: https://git.openjdk.org/jdk/pull/18259/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18259&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8316388
  Stats: 468 lines in 5 files changed: 468 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18259.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18259/head:pull/18259

PR: https://git.openjdk.org/jdk/pull/18259

From tr at openjdk.org  Wed Mar 13 07:05:29 2024
From: tr at openjdk.org (Tejesh R)
Date: Wed, 13 Mar 2024 07:05:29 GMT
Subject: RFR: 8328035: Convert
 javax/swing/text/html/TableView/7030332/bug7030332.java applet test to main
Message-ID: <sa4wl3VTL1p3Zxmat10wUsqex-uQewN2R2N8tXTwFFo=.013c255b-d875-4b52-a0f0-403664011199@github.com>

Convert javax/swing/text/html/TableView/7030332/bug7030332.java applet test to main based test using PassFailJFrame.

-------------

Commit messages:
 - Conversion from Applet to Main

Changes: https://git.openjdk.org/jdk/pull/18260/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18260&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8328035
  Stats: 109 lines in 2 files changed: 29 ins; 71 del; 9 mod
  Patch: https://git.openjdk.org/jdk/pull/18260.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18260/head:pull/18260

PR: https://git.openjdk.org/jdk/pull/18260

From psadhukhan at openjdk.org  Wed Mar 13 07:18:21 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Wed, 13 Mar 2024 07:18:21 GMT
Subject: RFR: 8327756: Convert javax/swing/JSlider/4987336/bug4987336.java
 applet to main
Message-ID: <zFe1pB_IJT8gqZC2WVKRnHq_9W2DBWU_UAmM3_QdXpM=.b5493e4d-1d4d-451a-a373-753d8c682fa8@github.com>

Conversion of manual applet test to main based using PassFailJFrame manual framework

-------------

Commit messages:
 - Fix
 - 8327756: Convert javax/swing/JSlider/4987336/bug4987336.java applet to main

Changes: https://git.openjdk.org/jdk/pull/18261/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18261&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8327756
  Stats: 84 lines in 2 files changed: 38 ins; 35 del; 11 mod
  Patch: https://git.openjdk.org/jdk/pull/18261.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18261/head:pull/18261

PR: https://git.openjdk.org/jdk/pull/18261

From tr at openjdk.org  Wed Mar 13 07:23:17 2024
From: tr at openjdk.org (Tejesh R)
Date: Wed, 13 Mar 2024 07:23:17 GMT
Subject: RFR: 8325179: Race in BasicDirectoryModel.validateFileCache [v3]
In-Reply-To: <mVHHIki7p8TDSN0TlD0kaRuNzWUHom5W-y7y51rxjSA=.35bcbabb-4c2c-4f9e-a48b-b34995336da2@github.com>
References: <nOapec57Ql6DHy57oEeWdkUGER8RYdWc2vwmJsqWDYc=.8de81954-d8c2-4937-b426-e61dde05255e@github.com>
 <mVHHIki7p8TDSN0TlD0kaRuNzWUHom5W-y7y51rxjSA=.35bcbabb-4c2c-4f9e-a48b-b34995336da2@github.com>
Message-ID: <e_3HYZmomtNFpbvV6fhxOPAdbBQjTZTt95xOfdYK3_4=.792b1feb-1cf5-47f7-89d4-215b2e339f8a@github.com>

On Wed, 6 Mar 2024 11:27:08 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Ensure access to the `filesLoader` field of `BasicDirectoryModel` is synchronized.
>> 
>> Without synchronization, a thread checks if `filesLoader` is not null and creates a new `FilesLoader` thread. If the thread is pre-empted between these two operations, another thread or even several threads can see the `null` value and create new `FilesLoader` threads.
>> 
>> The same way, `BasicDirectoryModel.invalidateFileCache` needs to be synchornized to interrupt the current `filesLoader` and assign `null`.
>> 
>> This bug allows reproducing `ConcurrentModificationException` seen in [JDK-8323670](https://bugs.openjdk.org/browse/JDK-8323670) and [JDK-8307091](https://bugs.openjdk.org/browse/JDK-8307091) using the test in PR #18109.
>
> Alexey Ivanov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Store the size of fileCache inside synchronized block

Marked as reviewed by tr (Committer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18111#pullrequestreview-1933320793

From psadhukhan at openjdk.org  Wed Mar 13 07:41:37 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Wed, 13 Mar 2024 07:41:37 GMT
Subject: RFR: 8327757: Convert javax/swing/JSlider/6524424/bug6524424.java
 applet to main
Message-ID: <bq4piqGxP9zZiBlAc8_w-hnLs84WeA78AngOyTg7lwI=.b2572769-5729-4612-81b9-aac8f1a30398@github.com>

Conversion of manual applet test to main based using PassFailJFrame manual framework

-------------

Commit messages:
 - Fix
 - 8327757: Convert javax/swing/JSlider/6524424/bug6524424.java applet to main

Changes: https://git.openjdk.org/jdk/pull/18263/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18263&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8327757
  Stats: 256 lines in 3 files changed: 121 ins; 135 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18263.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18263/head:pull/18263

PR: https://git.openjdk.org/jdk/pull/18263

From psadhukhan at openjdk.org  Wed Mar 13 07:57:13 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Wed, 13 Mar 2024 07:57:13 GMT
Subject: RFR: 8327753: Convert
 javax/swing/JOptionPane/8024926/bug8024926.java applet to main [v2]
In-Reply-To: <W9FX6uDmrG2exwdtiAs4sq8AP_RFqX876RyDcaPbbTA=.3162b12b-db3d-4db5-b63b-faf8926f5696@github.com>
References: <Mh1aFrqe1Kw2tD_2nNzeAoMRhSWzNoh67d-2yTqoIPE=.e8e324d4-f0fa-4b41-b2ea-39cc18faf088@github.com>
 <XvhjkzvZ6qLmp2eWL1iF1ztfTRgGe4aZGUZ0epXBV2w=.654067f3-1f2b-429b-9656-2360600e09f9@github.com>
 <W9FX6uDmrG2exwdtiAs4sq8AP_RFqX876RyDcaPbbTA=.3162b12b-db3d-4db5-b63b-faf8926f5696@github.com>
Message-ID: <9Uu4kiGuYNcEHM6uzMpskhFqrpZiCJ0tsS3SI2rp-Aw=.76da1624-7b98-4ac7-9cac-5bc899ab7dc7@github.com>

On Wed, 13 Mar 2024 05:43:20 GMT, Phil Race <prr at openjdk.org> wrote:

>> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove redundant dir
>
> test/jdk/javax/swing/JOptionPane/bug8024926.java line 46:
> 
>> 44:                 Verify that high resolution system icons are used
>> 45:                  in JOptionPane on HiDPI displays.
>> 46:                 1) Run the test on Retina display or enable the Quartz Debug
> 
> Quartz debug ? How ? And we don't even use Quartz.
> The pass criteria is completely subjective. 
> So this test looks like it needs to be better.
> If you can't figure out a better test for this in less than a day just delete this useless thing.

I can remove the "Quartz debug" portion if it is not applicable, but as you know, it's a straight lift from the existing instructions...The reviewer that time did not object to this phrase it seems (was it used that time and subsequently revoked later?)
https://hg.openjdk.org/jdk9/jdk9/jdk/rev/4991a758abef

Also, the product fix has another test `test/javax/swing/JMenuItem/8031573/bug8031573.java`	which also put the same pass criteria that icons should be smooth and our manual testing team has not made any objections to the instructions of both test it seems..

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18232#discussion_r1522695516

From mbaesken at openjdk.org  Wed Mar 13 08:30:16 2024
From: mbaesken at openjdk.org (Matthias Baesken)
Date: Wed, 13 Mar 2024 08:30:16 GMT
Subject: RFR: 8327701: Remove the xlc toolchain [v2]
In-Reply-To: <q5kj9HuS9Z3kwwvqqgfUBu10pYPuUK7JVhHingVcUw4=.32cf7474-73be-4537-af92-ad528ef4e8d5@github.com>
References: <ZNtnRt4ufmZ5Sp8zURIQwBVraTUPmM30KwL-sC37JeQ=.7135ee42-e9b1-4410-afea-b5c7384ae76e@github.com>
 <YVdSIUybMmPFB4eNvHAxfmfEqOzrrt5l6AA9j44DlBM=.2bb3f97e-583c-4ee5-9a5a-c02454315b33@github.com>
 <guGW7d1XFNl7TE84CKTrkWngW5mNZ8dEhgiUaUphTcQ=.447ec868-160f-4f96-9dc3-16e955e1c8d7@github.com>
 <3S9pyv9jOnJihfgqtK_CXhDDV62pzek2TrduKffVTnI=.4e8d8016-a299-4596-92f4-1bcf6bd206f4@github.com>
 <q5kj9HuS9Z3kwwvqqgfUBu10pYPuUK7JVhHingVcUw4=.32cf7474-73be-4537-af92-ad528ef4e8d5@github.com>
Message-ID: <wHSV8PuqYJ8msJuXq_LLVbFQLiA13TAPbZTCv8vwm3A=.83fdba40-b69f-454f-b48f-7c590ef89813@github.com>

On Tue, 12 Mar 2024 16:02:41 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

> > Please re-test.
> 
> Hi Magnus, thanks for the adjustments. I reenabled your patch in our build/test queue .

Builds and test results on AIX (product and fastdebug) are fine with the latest version of the PR .

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18172#issuecomment-1993808324

From psadhukhan at openjdk.org  Wed Mar 13 08:40:42 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Wed, 13 Mar 2024 08:40:42 GMT
Subject: RFR: 8327752: Convert
 javax/swing/JOptionPane/4174551/bug4174551.java applet to main [v3]
In-Reply-To: <uEqsAwVSEu11kSzb6ccgfje4GyOGoZ4G0Wk59AYnvAI=.37029531-7173-4ea8-9ad7-3eb3dadde5a0@github.com>
References: <uEqsAwVSEu11kSzb6ccgfje4GyOGoZ4G0Wk59AYnvAI=.37029531-7173-4ea8-9ad7-3eb3dadde5a0@github.com>
Message-ID: <ghSGfbJo4HU6RIIjDHPVp-nXieddPCm6RoJSzZl6uB4=.af32e47e-ec13-4919-b357-6e09d49e137f@github.com>

> Conversion of manual applet test to main based using PassFailJFrame manual framework

Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:

  Test passcriteria instructions update

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18228/files
  - new: https://git.openjdk.org/jdk/pull/18228/files/0bade49a..55adbfd4

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18228&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18228&range=01-02

  Stats: 17 lines in 1 file changed: 9 ins; 0 del; 8 mod
  Patch: https://git.openjdk.org/jdk/pull/18228.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18228/head:pull/18228

PR: https://git.openjdk.org/jdk/pull/18228

From psadhukhan at openjdk.org  Wed Mar 13 08:43:16 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Wed, 13 Mar 2024 08:43:16 GMT
Subject: RFR: 8327752: Convert
 javax/swing/JOptionPane/4174551/bug4174551.java applet to main [v2]
In-Reply-To: <yfZT_pA_p2Rw59j-3wQ8rX6G1gA9BsZzmeqckmL5TdE=.769b177e-6927-415e-ad15-10016599cadd@github.com>
References: <uEqsAwVSEu11kSzb6ccgfje4GyOGoZ4G0Wk59AYnvAI=.37029531-7173-4ea8-9ad7-3eb3dadde5a0@github.com>
 <jmLu6jzpq9ic58H3FgIKohAb_Z44JE17Gedbjryz-0k=.89879927-bc76-4d2f-8558-995e3114b792@github.com>
 <yfZT_pA_p2Rw59j-3wQ8rX6G1gA9BsZzmeqckmL5TdE=.769b177e-6927-415e-ad15-10016599cadd@github.com>
Message-ID: <Y5qqX2XTueX9fgjZMM2zV_gaTcMAwRrPWg3r9IeVNGI=.cf07aa86-afca-4e2e-a7e5-70baf0152120@github.com>

On Wed, 13 Mar 2024 05:45:49 GMT, Phil Race <prr at openjdk.org> wrote:

>> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove redundant dir
>
> test/jdk/javax/swing/JOptionPane/bug4174551.java line 43:
> 
>> 41:           It should be true even on OS X.
>> 42:           If it is not so press "Fail" else press "Pass". """;
>> 43: 
> 
> These instructions are so odd. How is the tester supposed to know the size they see ?
> What can we do better ?

Since this test is about support of custom button in optionpane
Test instructions updated for easier-to-understand pass-criteria with side-by-side optionpanes one with custom fontsize of 24 and another with default fontsize (guess it's 12) asking to verify if custom fontsize is more than default-fontsize

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18228#discussion_r1522763600

From ihse at openjdk.org  Wed Mar 13 08:45:20 2024
From: ihse at openjdk.org (Magnus Ihse Bursie)
Date: Wed, 13 Mar 2024 08:45:20 GMT
Subject: Integrated: 8327701: Remove the xlc toolchain
In-Reply-To: <ZNtnRt4ufmZ5Sp8zURIQwBVraTUPmM30KwL-sC37JeQ=.7135ee42-e9b1-4410-afea-b5c7384ae76e@github.com>
References: <ZNtnRt4ufmZ5Sp8zURIQwBVraTUPmM30KwL-sC37JeQ=.7135ee42-e9b1-4410-afea-b5c7384ae76e@github.com>
Message-ID: <fbB3ULOpMcJtTUs3SmpzWMzdzMZr1o59VOOXyR-nP04=.0c1a553c-7409-40ba-beaf-1af05a5cc97a@github.com>

On Fri, 8 Mar 2024 15:29:58 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

> As of [JDK-8325880](https://bugs.openjdk.org/browse/JDK-8325880), building the JDK requires version 17 of IBM Open XL C/C++ (xlc). This is in effect clang by another name, and it uses the clang toolchain in the JDK build. Thus the old xlc toolchain is no longer supported, and should be removed.

This pull request has now been integrated.

Changeset: 107cb536
Author:    Magnus Ihse Bursie <ihse at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/107cb536e75509ad63b245d20772eb2c3f73d595
Stats:     327 lines in 19 files changed: 24 ins; 266 del; 37 mod

8327701: Remove the xlc toolchain

Reviewed-by: jwaters, erikj

-------------

PR: https://git.openjdk.org/jdk/pull/18172

From mbaesken at openjdk.org  Wed Mar 13 08:53:23 2024
From: mbaesken at openjdk.org (Matthias Baesken)
Date: Wed, 13 Mar 2024 08:53:23 GMT
Subject: RFR: 8327701: Remove the xlc toolchain [v4]
In-Reply-To: <Nd9G2lbssxwTvHQHeSHqaRqJ7uQIq8rVO2HulAV5V1w=.0b12fe1c-b990-4025-b24b-9636a25e424d@github.com>
References: <ZNtnRt4ufmZ5Sp8zURIQwBVraTUPmM30KwL-sC37JeQ=.7135ee42-e9b1-4410-afea-b5c7384ae76e@github.com>
 <Nd9G2lbssxwTvHQHeSHqaRqJ7uQIq8rVO2HulAV5V1w=.0b12fe1c-b990-4025-b24b-9636a25e424d@github.com>
Message-ID: <-uA04de5qrhwkzJkst47cUY1ZdLaHDPn3KIclLd4b84=.e15c4d6c-2f79-4ab0-a1a0-8cc0dee581c8@github.com>

On Tue, 12 Mar 2024 15:27:29 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> As of [JDK-8325880](https://bugs.openjdk.org/browse/JDK-8325880), building the JDK requires version 17 of IBM Open XL C/C++ (xlc). This is in effect clang by another name, and it uses the clang toolchain in the JDK build. Thus the old xlc toolchain is no longer supported, and should be removed.
>
> Magnus Ihse Bursie has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Replace CC_VERSION_OUTPUT with CC_VERSION_STRING
>  - We need CC_VERSION_OUTPUT before we can check it

Seems  `HOTSPOT_TOOLCHAIN_TYPE=xlc ` and  `TARGET_COMPILER_xlc`  macros stay, is this intended ?
(not saying this is a wrong thing to do, but I believed first that all the xlc toolchain references are replaced by clang?)

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18172#issuecomment-1993844670

From ihse at openjdk.org  Wed Mar 13 09:03:23 2024
From: ihse at openjdk.org (Magnus Ihse Bursie)
Date: Wed, 13 Mar 2024 09:03:23 GMT
Subject: RFR: 8327701: Remove the xlc toolchain [v4]
In-Reply-To: <-uA04de5qrhwkzJkst47cUY1ZdLaHDPn3KIclLd4b84=.e15c4d6c-2f79-4ab0-a1a0-8cc0dee581c8@github.com>
References: <ZNtnRt4ufmZ5Sp8zURIQwBVraTUPmM30KwL-sC37JeQ=.7135ee42-e9b1-4410-afea-b5c7384ae76e@github.com>
 <Nd9G2lbssxwTvHQHeSHqaRqJ7uQIq8rVO2HulAV5V1w=.0b12fe1c-b990-4025-b24b-9636a25e424d@github.com>
 <-uA04de5qrhwkzJkst47cUY1ZdLaHDPn3KIclLd4b84=.e15c4d6c-2f79-4ab0-a1a0-8cc0dee581c8@github.com>
Message-ID: <VKgCPLuZgM30TmVJBCoohzba_L66Xc_VPTox6SAwQnE=.1cca38c2-49a2-4e4b-a00f-5412e2195c98@github.com>

On Wed, 13 Mar 2024 08:50:10 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

>> Magnus Ihse Bursie has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Replace CC_VERSION_OUTPUT with CC_VERSION_STRING
>>  - We need CC_VERSION_OUTPUT before we can check it
>
> Seems  `HOTSPOT_TOOLCHAIN_TYPE=xlc ` and  `TARGET_COMPILER_xlc`  macros stay, is this intended ?
> (not saying this is a wrong thing to do, but I believed first that all the xlc toolchain references are replaced by clang?)

@MBaesken Yes, I discussed this in length above: https://github.com/openjdk/jdk/pull/18172#issuecomment-1985939418.

In short, changing that would mean changing behavior, and that is not something I want to do in a removal refactoring. Also, it is up to you guys to make it work correctly.

But I really believe you should address this. Let me know if you need help with the build aspects.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18172#issuecomment-1993862922

From tr at openjdk.org  Wed Mar 13 09:41:18 2024
From: tr at openjdk.org (Tejesh R)
Date: Wed, 13 Mar 2024 09:41:18 GMT
Subject: RFR: JDK-8328000 : Convert /java/awt/im/8154816/bug8154816.java
 applet test to main
In-Reply-To: <FShkxXV6Z_KcU6INfTyHyx-GfO9-xpgrDJi6ZQ0bmhE=.4cfc6764-b51b-4ab6-9323-5c7c1e2ca5e7@github.com>
References: <FShkxXV6Z_KcU6INfTyHyx-GfO9-xpgrDJi6ZQ0bmhE=.4cfc6764-b51b-4ab6-9323-5c7c1e2ca5e7@github.com>
Message-ID: <WUdwWnKYlw0JcAMzYbaTmpjBeOa36sCL3SNJ5xIjtIY=.71ba1c7a-9ddf-4fcd-94c8-a22d56b40630@github.com>

On Tue, 12 Mar 2024 18:20:14 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

> The following InputMethod test, bug8154816.java is converted to main using PassFailJFrame.
> 
> - test renamed to PinyinIMCapsTest
> - moved one directory above - /java/awt/im/
> - html file deleted.
> 
> PS: I tried to automate this test using Robot, but was unable to produce the same effect as a keyboard keypress for Pinyin, hence keep it as a manual test.

test/jdk/java/awt/im/PinyinIMCapsTest.java line 43:

> 41: 
> 42: public class PinyinIMCapsTest {
> 43:     private static final String INSTRUCTIONS = """

Can move `INSTRUCTIONS ` to main.

test/jdk/java/awt/im/PinyinIMCapsTest.java line 44:

> 42: public class PinyinIMCapsTest {
> 43:     private static final String INSTRUCTIONS = """
> 44:             This test is for OS X only. It verifies if the Caps Lock key works properly

I guess its not required to mention regarding OS X requirement in test instructions, anyhow its taken care in jtreg tag and also a check has been made before test initialization.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18245#discussion_r1522864097
PR Review Comment: https://git.openjdk.org/jdk/pull/18245#discussion_r1522868354

From jkern at openjdk.org  Wed Mar 13 09:53:22 2024
From: jkern at openjdk.org (Joachim Kern)
Date: Wed, 13 Mar 2024 09:53:22 GMT
Subject: RFR: 8327701: Remove the xlc toolchain [v4]
In-Reply-To: <Nd9G2lbssxwTvHQHeSHqaRqJ7uQIq8rVO2HulAV5V1w=.0b12fe1c-b990-4025-b24b-9636a25e424d@github.com>
References: <ZNtnRt4ufmZ5Sp8zURIQwBVraTUPmM30KwL-sC37JeQ=.7135ee42-e9b1-4410-afea-b5c7384ae76e@github.com>
 <Nd9G2lbssxwTvHQHeSHqaRqJ7uQIq8rVO2HulAV5V1w=.0b12fe1c-b990-4025-b24b-9636a25e424d@github.com>
Message-ID: <SDYoOHLW6KZ8qYvZlfV9X3DXqdBWJ5O18f3e76Rh3rs=.a9316152-28fa-43e8-b1e2-9ea34cfa8d5e@github.com>

On Tue, 12 Mar 2024 15:27:29 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> As of [JDK-8325880](https://bugs.openjdk.org/browse/JDK-8325880), building the JDK requires version 17 of IBM Open XL C/C++ (xlc). This is in effect clang by another name, and it uses the clang toolchain in the JDK build. Thus the old xlc toolchain is no longer supported, and should be removed.
>
> Magnus Ihse Bursie has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Replace CC_VERSION_OUTPUT with CC_VERSION_STRING
>  - We need CC_VERSION_OUTPUT before we can check it

e.g. We should change the HOTSPOT_TOOLCHAIN_TYPE=xlc to aix, because it is not toolchain, but OS related. As a consequence the globalDefinitions_xlc.hpp will become globalDefinitions_aix.hpp

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18172#issuecomment-1993979991

From azvegint at openjdk.org  Wed Mar 13 10:11:13 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Wed, 13 Mar 2024 10:11:13 GMT
Subject: RFR: 8328004: Minor updates to TrayIcon test
 DisposeInActionEventTest.java
In-Reply-To: <4Zq2gsAshsqM3HxMV4jxpgm25WDx40QRJ-EuBMVaAfQ=.f96fc9c2-ad2f-4026-9d9e-74d7444bb3fb@github.com>
References: <4Zq2gsAshsqM3HxMV4jxpgm25WDx40QRJ-EuBMVaAfQ=.f96fc9c2-ad2f-4026-9d9e-74d7444bb3fb@github.com>
Message-ID: <xUFylFRPBAP1eNhm0gfm6gC_VfRiISkiMfhy3lHzgHQ=.b4f07cd6-a999-47be-9343-25fb6a2e24d2@github.com>

On Tue, 12 Mar 2024 18:49:03 GMT, Phil Race <prr at openjdk.org> wrote:

> This was recently converted from a manual Applet to a PassFailJFrame main program
> But I see a few things that could be tweaked
>  - Clarify instructions
>  -  Set path to PassFailJFrame
>  - reduce timeout to default
>  - eliminate redundant folder

Marked as reviewed by azvegint (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18246#pullrequestreview-1933679765

From ihse at openjdk.org  Wed Mar 13 10:28:25 2024
From: ihse at openjdk.org (Magnus Ihse Bursie)
Date: Wed, 13 Mar 2024 10:28:25 GMT
Subject: RFR: 8327701: Remove the xlc toolchain [v4]
In-Reply-To: <SDYoOHLW6KZ8qYvZlfV9X3DXqdBWJ5O18f3e76Rh3rs=.a9316152-28fa-43e8-b1e2-9ea34cfa8d5e@github.com>
References: <ZNtnRt4ufmZ5Sp8zURIQwBVraTUPmM30KwL-sC37JeQ=.7135ee42-e9b1-4410-afea-b5c7384ae76e@github.com>
 <Nd9G2lbssxwTvHQHeSHqaRqJ7uQIq8rVO2HulAV5V1w=.0b12fe1c-b990-4025-b24b-9636a25e424d@github.com>
 <SDYoOHLW6KZ8qYvZlfV9X3DXqdBWJ5O18f3e76Rh3rs=.a9316152-28fa-43e8-b1e2-9ea34cfa8d5e@github.com>
Message-ID: <dbRq-mRFnOzoYCVnYFJohoF1ocyiPuaoaIrbkWOaIhc=.63e21a26-5b63-4b5e-bf8b-1bd69bbf163c@github.com>

On Wed, 13 Mar 2024 09:50:20 GMT, Joachim Kern <jkern at openjdk.org> wrote:

> e.g. We should change the HOTSPOT_TOOLCHAIN_TYPE=xlc to aix, because it is not toolchain, but OS related. As a consequence the globalDefinitions_xlc.hpp will become globalDefinitions_aix.hpp

No, it's not that simple. First, the `globalDefinitions_<compiler>` files are included on a per-toolchain basis, not OS basis. Secondly, I think you will want to have the stuff in globalDefinitions_gcc.h. In fact, if you compare globalDefinitions_gcc.h and globalDefinitions_xlc.h side-by-side, you see that they are much more similar than you'd perhaps naively expect. The remaining differences will probably be better expressed as #ifdef AIX inside globalDefinitions_gcc.h, I assume. (But of course, in the end this is up to the hotspot team.)

I recommend doing such a side-by-side check yourself to get an understanding of the actual differences.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18172#issuecomment-1994049434

From abhiscxk at openjdk.org  Wed Mar 13 11:43:20 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Wed, 13 Mar 2024 11:43:20 GMT
Subject: Integrated: 8327872: Convert
 javax/swing/JToolTip/4644444/bug4644444.java applet test to main
In-Reply-To: <gQj8exwWxjXFUAyXBGVxxXeflmLCCUQJ8flxhU22-7I=.75d72581-8868-4dc4-9736-af6e54dbe3ca@github.com>
References: <gQj8exwWxjXFUAyXBGVxxXeflmLCCUQJ8flxhU22-7I=.75d72581-8868-4dc4-9736-af6e54dbe3ca@github.com>
Message-ID: <ycKmEWGJEfwdiAx5OS3Othkf0qhYQG58BMqgzn5_UlQ=.d2aa4471-4198-4025-9341-870706f04f6a@github.com>

On Tue, 12 Mar 2024 05:33:40 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

> Conversion of manual applet test to main based using PassFailJFrame manual framework

This pull request has now been integrated.

Changeset: a4a51963
Author:    Abhishek Kumar <abhiscxk at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/a4a5196351a3c8ce45e2e36d27842194cbfcc5ff
Stats:     461 lines in 3 files changed: 63 ins; 398 del; 0 mod

8327872: Convert javax/swing/JToolTip/4644444/bug4644444.java applet test to main

Reviewed-by: prr, tr

-------------

PR: https://git.openjdk.org/jdk/pull/18212

From ihse at openjdk.org  Wed Mar 13 12:34:20 2024
From: ihse at openjdk.org (Magnus Ihse Bursie)
Date: Wed, 13 Mar 2024 12:34:20 GMT
Subject: RFR: 8326583: Remove over-generalized DefineNativeToolchain
 solution [v4]
In-Reply-To: <V4syuDAMRYe1BSG2okxw2sdceihpIarwtYI1wIbfxhY=.16d008af-c3df-42fe-a97c-7ac41eaab757@github.com>
References: <lGtsPt-jwk2yeMj9usOUTYfflYDwX8DAhD7RLxWJQ9o=.ae41dd0a-9b28-43a4-9979-84c2f675e531@github.com>
 <V4syuDAMRYe1BSG2okxw2sdceihpIarwtYI1wIbfxhY=.16d008af-c3df-42fe-a97c-7ac41eaab757@github.com>
Message-ID: <YnEDV8WKjbtBEb-Fb-ugaSZdcxKW_Na1__l8H8PQBLE=.8da56e70-ef00-4aa4-b629-b13b253b3fd2@github.com>

On Tue, 27 Feb 2024 11:19:59 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> The idea of setting up general "toolchains" in the native build was good, but it turned out that we really only need a single toolchain, with a single twist: if it should use CC or CPP to link. This is better described by a specific argument to SetupNativeCompilation, LANG := C++ or LANG := C (the default).
>> 
>> There is a single exception to this rule, and that is if we want to compile for the build platform rather than the target platform. (This is only done for adlc) To keep expressing this difference, introduce TARGET_TYPE := BUILD (or TARGET_TYPE := TARGET, the default).
>> 
>> The final odd-case was the hack for building hsdis/bin on mingw. This can be resolved using direct variables to SetupNativeCompilation, instead of first creating a toolchain.
>> 
>> Doing this refactoring will simplify the SetupNativeCompilation code, and make it much clearer if we use the C or C++ linker.
>
> Magnus Ihse Bursie has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits:
> 
>  - Merge branch 'master' into remove-toolchain-define
>  - Rename LANG to LINK_TYPE
>  - Reword "lib" comment to fit in better
>  - Merge branch 'master' into remove-toolchain-define
>  - 8326583: Remove over-generalized DefineNativeToolchain solution

I have opened https://bugs.openjdk.org/browse/JDK-8328079 to track the ccache regression.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17986#issuecomment-1994283777

From abhiscxk at openjdk.org  Wed Mar 13 13:31:24 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Wed, 13 Mar 2024 13:31:24 GMT
Subject: RFR: 8328087: Automate javax/swing/JTable/TAB/TAB.java applet test
Message-ID: <MumC6TL2XcA5TmVgQXy8yIDFEqUD08b2dvCUyYu7Kd8=.5891ab36-873a-41f0-b22f-d2fc883c8734@github.com>

Conversion of manual applet test to automated test. CI testing is green. Link attached to JBS.

-------------

Commit messages:
 - Automate applet based test

Changes: https://git.openjdk.org/jdk/pull/18274/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18274&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8328087
  Stats: 457 lines in 3 files changed: 245 ins; 212 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18274.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18274/head:pull/18274

PR: https://git.openjdk.org/jdk/pull/18274

From dmarkov at openjdk.org  Wed Mar 13 13:37:15 2024
From: dmarkov at openjdk.org (Dmitry Markov)
Date: Wed, 13 Mar 2024 13:37:15 GMT
Subject: RFR: 8320079: The ArabicBox.java test has no control buttons [v2]
In-Reply-To: <pG0zC4m8VUNlRyEl1aPD9exDtkqU0wKRKikbGCFRuf8=.2a0250ed-3157-4303-9b7e-44efd0d17559@github.com>
References: <uW_uKMlwlOFidrejEZ7wkFRyC4Kqx_MmSQdenASo6EQ=.aebdca22-c37d-40f8-8d48-8f298f082adf@github.com>
 <pG0zC4m8VUNlRyEl1aPD9exDtkqU0wKRKikbGCFRuf8=.2a0250ed-3157-4303-9b7e-44efd0d17559@github.com>
Message-ID: <ogqRX_TcUR72lGIuaKRlWBRpt6-jQz0nsx0zSl-NMLM=.f1c3960f-eb82-48bd-95a7-0fe181dcbbab@github.com>

On Tue, 12 Mar 2024 16:48:28 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> The test is converted to use `PassFailJFrame`.
>> 
>> I confirmed the updated test reproduce the original problem described in [JDK-4427483](https://bugs.openjdk.org/browse/JDK-4427483) where Arabic text displayed as missing glyphs.
>
> Alexey Ivanov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Use the correct path to library

Marked as reviewed by dmarkov (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18234#pullrequestreview-1934200154

From abhiscxk at openjdk.org  Wed Mar 13 13:37:32 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Wed, 13 Mar 2024 13:37:32 GMT
Subject: RFR: 8328087: Automate javax/swing/JTable/TAB/TAB.java applet test
 [v2]
In-Reply-To: <MumC6TL2XcA5TmVgQXy8yIDFEqUD08b2dvCUyYu7Kd8=.5891ab36-873a-41f0-b22f-d2fc883c8734@github.com>
References: <MumC6TL2XcA5TmVgQXy8yIDFEqUD08b2dvCUyYu7Kd8=.5891ab36-873a-41f0-b22f-d2fc883c8734@github.com>
Message-ID: <57vHBqQV5Hiqcr5Oaaj2A5-gwwi4r_QPFcDpqGGueK4=.28909cca-86f6-4c4a-a416-620d0d7052fd@github.com>

> Conversion of manual applet test to automated test. CI testing is green. Link attached to JBS.

Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:

  Remove commented code

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18274/files
  - new: https://git.openjdk.org/jdk/pull/18274/files/6b3f50a0..66d7884c

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18274&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18274&range=00-01

  Stats: 18 lines in 1 file changed: 0 ins; 18 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18274.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18274/head:pull/18274

PR: https://git.openjdk.org/jdk/pull/18274

From abhiscxk at openjdk.org  Wed Mar 13 13:43:40 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Wed, 13 Mar 2024 13:43:40 GMT
Subject: RFR: 8328089: Automate javax/swing/JTable/4222153/bug4222153.java
 applet test
Message-ID: <mVE4zdUddu3XPR7DxR9mbyzZwAMXUy0ylxrFmtuHAZU=.df6d1ce0-3afe-4370-b23a-0f4042efc9c9@github.com>

Conversion of manual applet test to automated test. CI testing is green. Link attached to JBS.

-------------

Commit messages:
 - Automate applet manual test

Changes: https://git.openjdk.org/jdk/pull/18275/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18275&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8328089
  Stats: 194 lines in 3 files changed: 115 ins; 79 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18275.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18275/head:pull/18275

PR: https://git.openjdk.org/jdk/pull/18275

From alexander.scherbatiy at bell-sw.com  Wed Mar 13 14:20:23 2024
From: alexander.scherbatiy at bell-sw.com (Alexander Scherbatiy)
Date: Wed, 13 Mar 2024 17:20:23 +0300
Subject: Setting Chromaticity.MONOCHROME print request attribute on macOS
In-Reply-To: <8eb8b503-6202-0bff-a512-24ab45f39d56@bell-sw.com>
References: <8eb8b503-6202-0bff-a512-24ab45f39d56@bell-sw.com>
Message-ID: <78e594fc-e0fb-4d02-ae32-21fe2957c0d0@bell-sw.com>

Hello,

There is a known issue that a PrinterJob does not take 
Chromaticity.MONOCHROME print request attribute into account on macOS 
(JDK-8315113 [1])

The possible ways for solving the issue with black & white printing on 
macOS could be:

1. Setting black & white printing with macOS API.

 ?? There is the deprecated PMSetColorMode [2] function:
 ?? "There is no replacement; this function was included to facilitate 
porting legacy applications to macOS, but it serves no useful purpose."
 ?? and I was not able to find another one.

2. Using a predefined printer.properties file with black & white 
key/value pairs for known printers.
 ??? It needs to maintain the property file to keep list with black & 
white key/value pairs.
 ??? Or just leave only one default? ColorModel=Gray key/value in the 
property file so users will need to add another ones for their needs.

3. Using a PPD API to get the corresponding black & white value for the 
given key.
 ??? In this way the black & white keys are printer specific and there 
should be a way to provide these keys to the program.
 ??? Another way is parsing a ppd file to find the black & white 
key/value pair in question. It still requires some search criteria to 
find the printer specific key.

4. Adding a custom PrintRequestAttribute which allows for a user to add 
a printer specific key values to PrintRequestAttributeSet.
 ???? These key/value pairs are then added to the NSPrintInfo 
printSettings on macOS.

5. Providing other ways like a jvm option which allows a user to pass 
black & white key/value pairs to the program.


Are there better solutions for the black & white printing issue on macOS?
What is the best option to start solving the issue with?

Thanks,
Alexander.

[1] https://bugs.openjdk.org/browse/JDK-8315113

[2] 
https://developer.apple.com/documentation/applicationservices/core_printing/1805783-pmsetcolormode


On 8/28/23 18:00, Alexander Scherbatiy wrote:
> Hello,
>
> I am working on issue "8315113 Print request Chromaticity.MONOCHROME 
> attribute does not work on macOS" [1].
>
> There is PMSetColorMode function in the Apple Developer documentation 
> [2] but it is marked as deprecated
> ? "There is no replacement; this function was included to facilitate 
> porting legacy applications to macOS, but it serves no useful purpose."
> and really does nothing.
>
>
> Using native print dialog and selecting Black & White box allows to 
> print black and white pages on macOS.
> I dumped NSPrintInfo print settings dictionary for two printers when 
> the Black & White box is selected and the logs contain
> ColorModel key, Gray value for HP ColorLaserJet MFP M178-M181-AirPrint 
> printer and
> HPColorMode key, grayscale value for HP Ink Tank 115.
> It looks like each printer can have each own key/value for Black & 
> White settings.
>
> I tried to print key/values for all presets available for NSPrintInfo 
> without using the native print dialog:
> ----------
> ??? PMPrinter pr;
> ??? PMPrintSession printSession = (PMPrintSession)[printInfo 
> PMPrintSession];
> ??? OSStatus status = PMSessionGetCurrentPrinter(printSession, &pr);
> ??? CFArrayRef presetsList = nil;
> ??? status = PMPrinterCopyPresets(pr, &presetsList);
> ??? CFIndex arrayCount = CFArrayGetCount(presetsList);
>
> ??? for (CFIndex index = 0; index < arrayCount; index++) {
> ??????? PMPreset preset = 
> (PMPreset)CFArrayGetValueAtIndex(presetsList, index);
> ??????? CFStringRef presetName = nil;
> ??????? if (PMPresetCopyName(preset, &presetName) == noErr && 
> CFStringGetLength(presetName) > 0) {
> ??????????? NSLog(@"? presetName: '%@'", presetName);
> ??????????? NSDictionary* dict = nil;
> ??????????? if (PMPresetGetAttributes(preset, 
> (CFDictionaryRef*)(&dict)) == noErr) {
> ?????????????????? // print preset dict
>
> ----------
> The printers which I tested do contain "Black and White" preset but 
> they do not include key/values related to black and white printing.
>
>
> What is the right way to use different key/values (ColorModel: Gray, 
> HPColorMode: grayscale, ...) in code to set Black & White settings for 
> NSPrintInfo?
> Could it be a configuration file which contains all color model 
> key/values for all known printers?
>
> Thanks,
> Alexander.
>
> [1] https://bugs.openjdk.org/browse/JDK-8315113
>
> [2] 
> https://developer.apple.com/documentation/applicationservices/core_printing/1805783-pmsetcolormode
>
>

From aivanov at openjdk.org  Wed Mar 13 15:54:17 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Wed, 13 Mar 2024 15:54:17 GMT
Subject: RFR: 8328011: Convert
 java/awt/Frame/GetBoundsResizeTest/GetBoundsResizeTest.java applet test to
 main [v2]
In-Reply-To: <PoNxnSPkBb4Bdy-YC-sy3CCKtW9o4QB1mx7pqc99Ntc=.327a9543-9fd9-43c9-9720-9115868e65af@github.com>
References: <77msAoji3SrhXCIcFcOTndR5MCc5jsoomdQ9Udl0WeE=.893b27fe-2ba5-48d9-920f-aab38592b614@github.com>
 <PoNxnSPkBb4Bdy-YC-sy3CCKtW9o4QB1mx7pqc99Ntc=.327a9543-9fd9-43c9-9720-9115868e65af@github.com>
Message-ID: <MYmnU-Uo3zehLvNAuj4Kzn7vcr8Br3AqOAVEFJEXYgg=.ac865922-b8bb-4622-9c62-1e1332622292@github.com>

On Tue, 12 Mar 2024 19:37:55 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>> Alexander Zvegintsev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   minor formatting
>
> test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 1338:
> 
>> 1336:             if (panelCreator != null) {
>> 1337:                 if (splitUI && (testWindows != null || windowListCreator != null)) {
>> 1338:                     // TODO Is it required? We can support both
> 
> @aivanov-jdk please note, I am going to remove this check, it looks artificial to me.
> 
> In this test I added a JTextArea to display logs and messages. 
> It looks like we could add similar functionality to PassFailJFrame (outside the scope of this issue, of course).

@azvegint, yes, we can support both. But I didn't test it thoroughly, so I decided it was safer to add this.

Please, don't modify `PassFailJFrame` together with tests unless it's strictly required? It is for the sake of facilitating backporting the changes. Otherwise, backporting improvements to the framework will depend on the presence of a test.

In this case, it could be fine though? provided that the test you're updating exists in all the repos.

Either way, I think it's good to create a separate bug for `PassFailJFrame` which you'll resolve with the current one.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18250#discussion_r1523522304

From aivanov at openjdk.org  Wed Mar 13 16:01:15 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Wed, 13 Mar 2024 16:01:15 GMT
Subject: RFR: 8325179: Race in BasicDirectoryModel.validateFileCache [v3]
In-Reply-To: <kZ9T1t_lVzMto4NQ9zTiD5pvPitMVbCAAh2msOrmnCc=.51106a22-6d6b-4845-8f36-5bb8aa73c3ab@github.com>
References: <nOapec57Ql6DHy57oEeWdkUGER8RYdWc2vwmJsqWDYc=.8de81954-d8c2-4937-b426-e61dde05255e@github.com>
 <mVHHIki7p8TDSN0TlD0kaRuNzWUHom5W-y7y51rxjSA=.35bcbabb-4c2c-4f9e-a48b-b34995336da2@github.com>
 <kZ9T1t_lVzMto4NQ9zTiD5pvPitMVbCAAh2msOrmnCc=.51106a22-6d6b-4845-8f36-5bb8aa73c3ab@github.com>
Message-ID: <GLQxmatdPMwTT74RdruaUm8tD5IZYGyauCY8O5YX_Zo=.4f7e0cef-1aee-4f72-aa11-89cf278d47fb@github.com>

On Tue, 12 Mar 2024 20:01:29 GMT, Phil Race <prr at openjdk.org> wrote:

> If this makes that CCME go away I'll be pleased.

@prrace CCME is already gone, Tejesh and I resolved it under [JDK-8323670](https://bugs.openjdk.org/browse/JDK-8323670) in #17462.

> I am assuming you've run the "full" battery of tests on this.

Yes, I did. No failures found.

This is an isolated change, it prevents creating several background thread to load files.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18111#issuecomment-1994775574

From abhiscxk at openjdk.org  Wed Mar 13 16:09:16 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Wed, 13 Mar 2024 16:09:16 GMT
Subject: RFR: 8327980: Convert
 javax/swing/JToggleButton/4128979/bug4128979.java applet test to main [v2]
In-Reply-To: <fsD1Tq4f9aI5XhKF2rJN1SSjtF8J-Lv447WGPf_TPR0=.219bfb1a-a105-4c26-a050-55fdbb57bf20@github.com>
References: <lZHt9pYb75UtaIEtbB0paOkfqR5CUAc6tikhb9YAakU=.ff2adbed-1db2-490a-8747-66ac96d03657@github.com>
 <fsD1Tq4f9aI5XhKF2rJN1SSjtF8J-Lv447WGPf_TPR0=.219bfb1a-a105-4c26-a050-55fdbb57bf20@github.com>
Message-ID: <eEAFNEdxFxtP6Xv5MdkC_aJ6z4cB6o5Z4KRFZZOLCiA=.b93ccff3-ddf8-4286-878a-1017bded34db@github.com>

On Wed, 13 Mar 2024 01:20:05 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review comment fix
>
> test/jdk/javax/swing/JToggleButton/4128979/bug4128979.java line 81:
> 
>> 79: 
>> 80:     public static JFrame createAndShowUI() {
>> 81:         frame = new JFrame("Test window");
> 
> Frame title can be more descriptive.

Updated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18233#discussion_r1523547010

From aivanov at openjdk.org  Wed Mar 13 16:57:21 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Wed, 13 Mar 2024 16:57:21 GMT
Subject: RFR: 8316388: Opensource five Swing component related regression
 tests
In-Reply-To: <lyqr03dS3RFZwQum85-sdTUI2flExMCQm9Dps70wX5w=.1e207aa6-34e2-48e5-866c-bc39eb8d479f@github.com>
References: <lyqr03dS3RFZwQum85-sdTUI2flExMCQm9Dps70wX5w=.1e207aa6-34e2-48e5-866c-bc39eb8d479f@github.com>
Message-ID: <9hBnCXqmWqizqPJKVIA8M8wL2i9lqgddkRMwMmIU4qM=.a09493e9-a861-4383-aa51-4e692f0acf67@github.com>

On Wed, 13 Mar 2024 06:49:16 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

> Cleaned up five more tests.
> 
> Continuation of https://github.com/openjdk/jdk/pull/18184
> 
> Unfortunately one of the commits rendered the whole PR invalid so i closed it and restarting it here.
> All comments from the previous review are addressed.

Changes requested by aivanov (Reviewer).

test/jdk/javax/swing/JDesktopPane/bug4773378.java line 53:

> 51: 
> 52:     Robot robot;
> 53:     volatile boolean frameActivated = false;

Suggestion:

    private final CountDownLatch frameActivated = new CountDownLatch(1);

test/jdk/javax/swing/JDesktopPane/bug4773378.java line 71:

> 69:                         frameActivated = true;
> 70:                         bug4773378.this.notifyAll();
> 71:                     }

Suggestion:

                    frameActivated.countDown();

test/jdk/javax/swing/JDesktopPane/bug4773378.java line 92:

> 90:             } catch (PropertyVetoException e) {
> 91:                 e.printStackTrace();
> 92:             }

Suggestion:

            try {
                jif.setSelected(true);
            } catch (PropertyVetoException e) {
                throw new RuntimeException(e);
            }

Fail the test if an unexpected is thrown.

Can `jif.setSelected(true)` be called in the setup code?

test/jdk/javax/swing/JDesktopPane/bug4773378.java line 99:

> 97:                 bug4773378.this.wait();
> 98:             }
> 99:         }

Suggestion:

        frameActivated.await();


Using `CountDownLatch` is so much cleaner.

test/jdk/javax/swing/JDesktopPane/bug4773378.java line 107:

> 105:         robot.keyRelease(KeyEvent.VK_CONTROL);
> 106: 
> 107:         Thread.sleep(2000);

Suggestion:

        robot.waitForIdle();

Is it really necessary to wait for 2 seconds before shutting down the test.

According to [JDK-4773378](https://bugs.openjdk.org/browse/JDK-4773378), `NullPointerException` was thrown when <kbd>Ctrl</kbd>+<kbd>F6</kbd> was pressed. The `waitForIdle` method doesn't return until the event queue is empty which implies the keyboard events are handled. It saves nearly 2 seconds.

test/jdk/javax/swing/JDesktopPane/bug4773378.java line 117:

> 115:     }
> 116: 
> 117:     class MyDesktopManager extends DefaultDesktopManager {

Suggestion:

    private static class MyDesktopManager extends DefaultDesktopManager {

test/jdk/javax/swing/JEditorPane/bug4325606.java line 80:

> 78:                 robo = new Robot();
> 79:             } catch (AWTException e) {
> 80:                 throw new RuntimeException("Robot could not be created");

Suggestion:

                throw new RuntimeException("Robot could not be created", e);

Preserve the original exception, which would be very helpful for debugging if it ever occurs.

test/jdk/javax/swing/JEditorPane/bug4325606.java line 84:

> 82:             robo.setAutoDelay(100);
> 83:             robo.delay(1000);
> 84:             Point p = frame.getLocationOnScreen();

Technically, `getLocationOnScreen` should be called on EDT.

test/jdk/javax/swing/JEditorPane/bug4325606.java line 101:

> 99:             } catch (BadLocationException blex) {
> 100:                 passed = false;
> 101:             }

Suggestion:

            } catch (BadLocationException blex) {
                throw new RuntimeException("Test failed", blex);
            }

Throw exception preserving the original exception which will help analysing the failure?

test/jdk/javax/swing/JEditorPane/bug4325606.java line 120:

> 118:             if (!b.passed) {
> 119:                 throw new RuntimeException("Test failed.");
> 120:             }

Suggestion:

            robot.waitForIdle();

Wait until all events are processed. If test fails, it throws an exception on EDT; otherwise, the test is finished as soon as the event queue is empty. No need to waste 3 seconds.

test/jdk/javax/swing/JEditorPane/bug4694598.java line 64:

> 62:         } catch (IOException ioe){
> 63:             throw new RuntimeException("Could not create html file to embed", ioe);
> 64:         }

Move creating the file to `main` method before setting up GUI and let `IOException` escape from main.

test/jdk/javax/swing/JEditorPane/bug4694598.java line 74:

> 72:         String html = "<HTML> <BODY>" +
> 73:                 "<FRAMESET cols=\"100%\">" +
> 74:                 "<FRAME src=\"" + frameContentUrl + "\">" +

Suggestion:

                "<FRAME src="" + frameContentFile.toUri()+ "">" +

Isn't it enough? Alternatively, `"file:/" + frameContentFile.toAbsolutePath()` produces the same result as `frameContentFile.toUri().toURL()`.

Another option is to convert the `Path` to `URL` in the `main` method before calling `setupGUI` and remove try-catch blocks.

-------------

PR Review: https://git.openjdk.org/jdk/pull/18259#pullrequestreview-1934620670
PR Review Comment: https://git.openjdk.org/jdk/pull/18259#discussion_r1523563210
PR Review Comment: https://git.openjdk.org/jdk/pull/18259#discussion_r1523564258
PR Review Comment: https://git.openjdk.org/jdk/pull/18259#discussion_r1523549703
PR Review Comment: https://git.openjdk.org/jdk/pull/18259#discussion_r1523565594
PR Review Comment: https://git.openjdk.org/jdk/pull/18259#discussion_r1523573470
PR Review Comment: https://git.openjdk.org/jdk/pull/18259#discussion_r1523575719
PR Review Comment: https://git.openjdk.org/jdk/pull/18259#discussion_r1523578951
PR Review Comment: https://git.openjdk.org/jdk/pull/18259#discussion_r1523587677
PR Review Comment: https://git.openjdk.org/jdk/pull/18259#discussion_r1523582352
PR Review Comment: https://git.openjdk.org/jdk/pull/18259#discussion_r1523586920
PR Review Comment: https://git.openjdk.org/jdk/pull/18259#discussion_r1523592475
PR Review Comment: https://git.openjdk.org/jdk/pull/18259#discussion_r1523611406

From azvegint at openjdk.org  Wed Mar 13 17:00:38 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Wed, 13 Mar 2024 17:00:38 GMT
Subject: RFR: 8328110: Allow simultaneous use of PassFailJFrame with split UI
 and additional windows
Message-ID: <eI8LV-JCDm0Y9cNYRO14jzecmYDY_Lh-ghiZXLsl3Uc=.9107f629-a355-456a-99ba-cb5e036b2fb4@github.com>

It is currently blocked with an artificial check:


if (panelCreator != null) {
    if (splitUI && (testWindows != null || windowListCreator != null)) {
        // TODO Is it required? We can support both
        throw new IllegalStateException("Split UI is not allowed "
                                        + "with additional windows");
    }
}


We have a number of manual tests, which has some text area in the instruction window to print a feedback from the test to be evaluated by a tester.

Removing this check allows us to implement this.
We can consider making a special methods for this later.

This is required for the #18250

-------------

Commit messages:
 - 8328110: Allow simultaneous use of PassFailJFrame with split UI and additional windows

Changes: https://git.openjdk.org/jdk/pull/18281/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18281&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8328110
  Stats: 8 lines in 1 file changed: 0 ins; 8 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18281.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18281/head:pull/18281

PR: https://git.openjdk.org/jdk/pull/18281

From azvegint at openjdk.org  Wed Mar 13 17:00:21 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Wed, 13 Mar 2024 17:00:21 GMT
Subject: RFR: 8328011: Convert
 java/awt/Frame/GetBoundsResizeTest/GetBoundsResizeTest.java applet test to
 main [v2]
In-Reply-To: <MYmnU-Uo3zehLvNAuj4Kzn7vcr8Br3AqOAVEFJEXYgg=.ac865922-b8bb-4622-9c62-1e1332622292@github.com>
References: <77msAoji3SrhXCIcFcOTndR5MCc5jsoomdQ9Udl0WeE=.893b27fe-2ba5-48d9-920f-aab38592b614@github.com>
 <PoNxnSPkBb4Bdy-YC-sy3CCKtW9o4QB1mx7pqc99Ntc=.327a9543-9fd9-43c9-9720-9115868e65af@github.com>
 <MYmnU-Uo3zehLvNAuj4Kzn7vcr8Br3AqOAVEFJEXYgg=.ac865922-b8bb-4622-9c62-1e1332622292@github.com>
Message-ID: <lpPM8XHaWO8beIUi8-vlGDZyLkrCHDgn_q3t_yh-swY=.047a79f3-738a-4c51-83be-aecb8b83c309@github.com>

On Wed, 13 Mar 2024 15:51:21 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 1338:
>> 
>>> 1336:             if (panelCreator != null) {
>>> 1337:                 if (splitUI && (testWindows != null || windowListCreator != null)) {
>>> 1338:                     // TODO Is it required? We can support both
>> 
>> @aivanov-jdk please note, I am going to remove this check, it looks artificial to me.
>> 
>> In this test I added a JTextArea to display logs and messages. 
>> It looks like we could add similar functionality to PassFailJFrame (outside the scope of this issue, of course).
>
> @azvegint, yes, we can support both. But I didn't test it thoroughly, so I decided it was safer to add this.
> 
> Please, don't modify `PassFailJFrame` together with tests unless it's strictly required? It is for the sake of facilitating backporting the changes. Otherwise, backporting improvements to the framework will depend on the presence of a test.
> 
> In this case, it could be fine though? provided that the test you're updating exists in all the repos.
> 
> Either way, I think it's good to create a separate bug for `PassFailJFrame` which you'll resolve with the current one.

That's a good point, I created #18281 for that.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18250#discussion_r1523619919

From aivanov at openjdk.org  Wed Mar 13 17:02:15 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Wed, 13 Mar 2024 17:02:15 GMT
Subject: RFR: 8327137: Add test for ConcurrentModificationException in
 BasicDirectoryModel
In-Reply-To: <gIGqmfIGYKUboNVv9D50mSDiBnPqp_lxzKQysYU9KMY=.fdf35b88-e839-445d-995e-e45e6aa305b2@github.com>
References: <mCqqjrXVWDB2PvpOhKHx-Hr8W6tUz6v4stztGmyAeEg=.1f95da1c-e1a5-40be-be8b-0758729fa9b9@github.com>
 <gIGqmfIGYKUboNVv9D50mSDiBnPqp_lxzKQysYU9KMY=.fdf35b88-e839-445d-995e-e45e6aa305b2@github.com>
Message-ID: <oeh4pZAGhxLIuj-eO5vDTX9_YC5gPSIK3RgTuMV3QVc=.5535d258-4e26-4ea3-93a2-b5e8ffb36960@github.com>

On Tue, 12 Mar 2024 21:02:08 GMT, Phil Race <prr at openjdk.org> wrote:

> > "When the test passes, it usually completes in 5 minutes."
> 
> and you've never seen the test time out ? I thought default jtreg timeout is 120 seconds.

No, I've never seen the test time out.

The default timeout is factored by 2 in client jobs, another factor could be applied on the hosts.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18109#issuecomment-1994999914

From honkar at openjdk.org  Wed Mar 13 17:06:15 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Wed, 13 Mar 2024 17:06:15 GMT
Subject: RFR: 8328089: Automate javax/swing/JTable/4222153/bug4222153.java
 applet test
In-Reply-To: <mVE4zdUddu3XPR7DxR9mbyzZwAMXUy0ylxrFmtuHAZU=.df6d1ce0-3afe-4370-b23a-0f4042efc9c9@github.com>
References: <mVE4zdUddu3XPR7DxR9mbyzZwAMXUy0ylxrFmtuHAZU=.df6d1ce0-3afe-4370-b23a-0f4042efc9c9@github.com>
Message-ID: <f_gLRcEQ2JGuUwMAhMm0JZz_YrIo56wVryDm0U0OXpU=.64d84d03-39e0-4647-98b7-c77834b5f612@github.com>

On Wed, 13 Mar 2024 13:39:08 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

> Conversion of manual applet test to automated test. CI testing is green. Link attached to JBS.

Changes requested by honkar (Reviewer).

test/jdk/javax/swing/JTable/bug4222153.java line 57:

> 55:         UIManager.setLookAndFeel("javax.swing.plaf.metal.MetalLookAndFeel");
> 56:         Robot robot = new Robot();
> 57:         robot.setAutoDelay(100);

Delay can be reduced to 50ms

test/jdk/javax/swing/JTable/bug4222153.java line 91:

> 89:             robot.keyRelease(KeyEvent.VK_TAB);
> 90:             robot.delay(100);
> 91:             robot.waitForIdle();

Since autodelay is already set you can remove the additional delay after key release or reduce it to a smaller number.

Suggestion:

            robot.waitForIdle();
            robot.delay(20);

test/jdk/javax/swing/JTable/bug4222153.java line 95:

> 93:             robot.keyRelease(KeyEvent.VK_TAB);
> 94:             robot.delay(100);
> 95:             robot.waitForIdle();

Same here and usually it is waitForIdle() followed by delay().

-------------

PR Review: https://git.openjdk.org/jdk/pull/18275#pullrequestreview-1934739075
PR Review Comment: https://git.openjdk.org/jdk/pull/18275#discussion_r1523624229
PR Review Comment: https://git.openjdk.org/jdk/pull/18275#discussion_r1523626805
PR Review Comment: https://git.openjdk.org/jdk/pull/18275#discussion_r1523628934

From aivanov at openjdk.org  Wed Mar 13 17:09:15 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Wed, 13 Mar 2024 17:09:15 GMT
Subject: RFR: 8325179: Race in BasicDirectoryModel.validateFileCache [v3]
In-Reply-To: <GLQxmatdPMwTT74RdruaUm8tD5IZYGyauCY8O5YX_Zo=.4f7e0cef-1aee-4f72-aa11-89cf278d47fb@github.com>
References: <nOapec57Ql6DHy57oEeWdkUGER8RYdWc2vwmJsqWDYc=.8de81954-d8c2-4937-b426-e61dde05255e@github.com>
 <mVHHIki7p8TDSN0TlD0kaRuNzWUHom5W-y7y51rxjSA=.35bcbabb-4c2c-4f9e-a48b-b34995336da2@github.com>
 <kZ9T1t_lVzMto4NQ9zTiD5pvPitMVbCAAh2msOrmnCc=.51106a22-6d6b-4845-8f36-5bb8aa73c3ab@github.com>
 <GLQxmatdPMwTT74RdruaUm8tD5IZYGyauCY8O5YX_Zo=.4f7e0cef-1aee-4f72-aa11-89cf278d47fb@github.com>
Message-ID: <hqHraN44XPb7lqJcBiUW3LB-gM7UX9HpOLc4AmBYGUk=.3b968996-08ab-490e-921e-c6090b623fff@github.com>

On Wed, 13 Mar 2024 15:57:55 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> > If this makes that CCME go away I'll be pleased.
> 
> @prrace CCME is already gone, Tejesh and I resolved it under [JDK-8323670](https://bugs.openjdk.org/browse/JDK-8323670) in #17462.
 
The `BasicDirectoryModel/ConcurrentModification.java` test in #18109 usually failed with `OutOfMemoryError` on Windows because too many background threads were created and they couldn't complete contending on the COM thread. I saw more than 100 `BasicDirectoryModel.FilesLoader` threads in the debugger.

With this fix, the test passes without OOME on Windows. At each given time, there's no more than one background thread loading the list of files.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18111#issuecomment-1995019580

From aivanov at openjdk.org  Wed Mar 13 17:15:14 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Wed, 13 Mar 2024 17:15:14 GMT
Subject: RFR: 8328110: Allow simultaneous use of PassFailJFrame with split
 UI and additional windows
In-Reply-To: <eI8LV-JCDm0Y9cNYRO14jzecmYDY_Lh-ghiZXLsl3Uc=.9107f629-a355-456a-99ba-cb5e036b2fb4@github.com>
References: <eI8LV-JCDm0Y9cNYRO14jzecmYDY_Lh-ghiZXLsl3Uc=.9107f629-a355-456a-99ba-cb5e036b2fb4@github.com>
Message-ID: <j2D2NUeOcVTEfxz-8ziEH2peqknBtiZiHDIWYwcduFw=.756883e9-73e7-448d-b935-121f7d1097cf@github.com>

On Wed, 13 Mar 2024 16:55:08 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

> It is currently blocked with an artificial check:
> 
> 
> if (panelCreator != null) {
>     if (splitUI && (testWindows != null || windowListCreator != null)) {
>         // TODO Is it required? We can support both
>         throw new IllegalStateException("Split UI is not allowed "
>                                         + "with additional windows");
>     }
> }
> 
> 
> We have a number of manual tests, which has some text area in the instruction window to print a feedback from the test to be evaluated by a tester.
> 
> Removing this check allows us to implement this.
> We can consider making a special methods for this later.
> 
> This is required for the #18250

Let's go for it.

-------------

Marked as reviewed by aivanov (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18281#pullrequestreview-1934766274

From aivanov at openjdk.org  Wed Mar 13 17:19:13 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Wed, 13 Mar 2024 17:19:13 GMT
Subject: RFR: 8328110: Allow simultaneous use of PassFailJFrame with split
 UI and additional windows
In-Reply-To: <eI8LV-JCDm0Y9cNYRO14jzecmYDY_Lh-ghiZXLsl3Uc=.9107f629-a355-456a-99ba-cb5e036b2fb4@github.com>
References: <eI8LV-JCDm0Y9cNYRO14jzecmYDY_Lh-ghiZXLsl3Uc=.9107f629-a355-456a-99ba-cb5e036b2fb4@github.com>
Message-ID: <YK5YH6T3HiRcWorGrLca8HApKyWi0j19GeW0PaHV1N4=.e6b0b1c7-90cb-4bbc-93dd-32df9b806d79@github.com>

On Wed, 13 Mar 2024 16:55:08 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

> It is currently blocked with an artificial check:
> 
> 
> if (panelCreator != null) {
>     if (splitUI && (testWindows != null || windowListCreator != null)) {
>         // TODO Is it required? We can support both
>         throw new IllegalStateException("Split UI is not allowed "
>                                         + "with additional windows");
>     }
> }
> 
> 
> We have a number of manual tests, which has some text area in the instruction window to print a feedback from the test to be evaluated by a tester.
> 
> Removing this check allows us to implement this.
> We can consider making a special methods for this later.
> 
> This is required for the #18250

I also considered extending `PanelCreator` to `PanelListCreator`, similar to how window lists are handled.

The first panel could be used as a split panel. (Two splits are possible but will it be good?) Additional panels would be converted to `JDialog`s like it's done for a single panel if split UI isn't enabled.

However, I'm unsure there's a use case for that. Using owned `JDialog`s results in easier switching to a running test.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18281#issuecomment-1995051952

From honkar at openjdk.org  Wed Mar 13 17:20:38 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Wed, 13 Mar 2024 17:20:38 GMT
Subject: RFR: JDK-8328012 : Convert InputMethod (/java/awt/im) applet tests
 to main [v4]
In-Reply-To: <iDY1JdxeSzLcbW-ASx1PylUqKY-kGUjMj8tr4Sj5NDM=.a0b9fbdb-a959-4e98-ae08-d086fd8f210f@github.com>
References: <iDY1JdxeSzLcbW-ASx1PylUqKY-kGUjMj8tr4Sj5NDM=.a0b9fbdb-a959-4e98-ae08-d086fd8f210f@github.com>
Message-ID: <oadTMu4xuH37vGnNOY1TXF6dJTwx5-nA0gNWtQCKFf4=.3f7711ea-7b32-4ad3-8e1b-536a8757aa28@github.com>

> Following InputMethod applet tests are converted to main using PassFailJFrame
> 
> 1. java/awt/im/8132503/bug8132503.java (Renamed to PinyinIMFullstopTest.java)
> 2. java/awt/im/8148984/bug8148984.java (Renamed to PinyinIMCommaTest.java) 
> 
> - test instructions are updated to make to more clear
> - tests renamed 
> - moved one directory above - /java/awt/im/
> - html file deleted.
> 
> Two tests are updated as part of this PR as they are similar, details here https://github.com/openjdk/jdk/pull/18251#issuecomment-1992577598

Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:

  instruction updated

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18251/files
  - new: https://git.openjdk.org/jdk/pull/18251/files/e82034f4..67acd86f

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18251&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18251&range=02-03

  Stats: 5 lines in 2 files changed: 0 ins; 0 del; 5 mod
  Patch: https://git.openjdk.org/jdk/pull/18251.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18251/head:pull/18251

PR: https://git.openjdk.org/jdk/pull/18251

From azvegint at openjdk.org  Wed Mar 13 17:22:14 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Wed, 13 Mar 2024 17:22:14 GMT
Subject: RFR: 8328030: Convert
 javax/swing/text/GlyphView/4984669/bug4984669.java applet test to main
In-Reply-To: <A08Xop2Zkm3QWsIXqy6DnupA4aku_YonZ5kpD4Mclrs=.0f8874a0-d2ba-4042-9768-e80dbfb44356@github.com>
References: <A08Xop2Zkm3QWsIXqy6DnupA4aku_YonZ5kpD4Mclrs=.0f8874a0-d2ba-4042-9768-e80dbfb44356@github.com>
Message-ID: <jVw56VbONZ1DBOmNndMs17xYMPVNZM1Dxwxp8aiZM3s=.61651fd3-ea4e-43d7-926f-373939455372@github.com>

On Wed, 13 Mar 2024 05:52:07 GMT, Tejesh R <tr at openjdk.org> wrote:

> Convert javax/swing/text/GlyphView/4984669/bug4984669.java manual applet test to main based using PassFailJFrame.

It may be a good time to give the test a meaningful name.

test/jdk/javax/swing/text/GlyphView/bug4984669.java line 37:

> 35:  * @library /java/awt/regtesthelpers
> 36:  * @build PassFailJFrame
> 37:  *  @run main/manual bug4984669

Please remove extra space before `@run`

-------------

Marked as reviewed by azvegint (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18256#pullrequestreview-1934778425
PR Review Comment: https://git.openjdk.org/jdk/pull/18256#discussion_r1523648132

From honkar at openjdk.org  Wed Mar 13 17:28:41 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Wed, 13 Mar 2024 17:28:41 GMT
Subject: RFR: JDK-8328000 : Convert /java/awt/im/8154816/bug8154816.java
 applet test to main [v2]
In-Reply-To: <FShkxXV6Z_KcU6INfTyHyx-GfO9-xpgrDJi6ZQ0bmhE=.4cfc6764-b51b-4ab6-9323-5c7c1e2ca5e7@github.com>
References: <FShkxXV6Z_KcU6INfTyHyx-GfO9-xpgrDJi6ZQ0bmhE=.4cfc6764-b51b-4ab6-9323-5c7c1e2ca5e7@github.com>
Message-ID: <Azte6I6cEY6KA72UP-XDnUYBok3Ao5KMyylStmL2owY=.bd42326d-c097-4cf7-bd7c-70f3e7ac181e@github.com>

> The following InputMethod test, bug8154816.java is converted to main using PassFailJFrame.
> 
> - test renamed to PinyinIMCapsTest
> - moved one directory above - /java/awt/im/
> - html file deleted.
> 
> PS: I tried to automate this test using Robot, but was unable to produce the same effect as a keyboard keypress for Pinyin, hence keep it as a manual test.

Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:

  instructions updated

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18245/files
  - new: https://git.openjdk.org/jdk/pull/18245/files/b3aab572..98a13808

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18245&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18245&range=00-01

  Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/jdk/pull/18245.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18245/head:pull/18245

PR: https://git.openjdk.org/jdk/pull/18245

From honkar at openjdk.org  Wed Mar 13 17:28:41 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Wed, 13 Mar 2024 17:28:41 GMT
Subject: RFR: JDK-8328000 : Convert /java/awt/im/8154816/bug8154816.java
 applet test to main [v2]
In-Reply-To: <WUdwWnKYlw0JcAMzYbaTmpjBeOa36sCL3SNJ5xIjtIY=.71ba1c7a-9ddf-4fcd-94c8-a22d56b40630@github.com>
References: <FShkxXV6Z_KcU6INfTyHyx-GfO9-xpgrDJi6ZQ0bmhE=.4cfc6764-b51b-4ab6-9323-5c7c1e2ca5e7@github.com>
 <WUdwWnKYlw0JcAMzYbaTmpjBeOa36sCL3SNJ5xIjtIY=.71ba1c7a-9ddf-4fcd-94c8-a22d56b40630@github.com>
Message-ID: <cnmNdIQPj2isti2oi5tH3eL1jnbsRdoEk5Byz03PYdk=.09a4b482-5034-4aee-b019-150c0cb9aa65@github.com>

On Wed, 13 Mar 2024 09:38:20 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   instructions updated
>
> test/jdk/java/awt/im/PinyinIMCapsTest.java line 44:
> 
>> 42: public class PinyinIMCapsTest {
>> 43:     private static final String INSTRUCTIONS = """
>> 44:             This test is for OS X only. It verifies if the Caps Lock key works properly
> 
> I guess its not required to mention regarding OS X requirement in test instructions, anyhow its taken care in jtreg tag and also a check has been made before test initialization.

Updated

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18245#discussion_r1523657165

From honkar at openjdk.org  Wed Mar 13 17:31:15 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Wed, 13 Mar 2024 17:31:15 GMT
Subject: RFR: JDK-8328000 : Convert /java/awt/im/8154816/bug8154816.java
 applet test to main [v2]
In-Reply-To: <WUdwWnKYlw0JcAMzYbaTmpjBeOa36sCL3SNJ5xIjtIY=.71ba1c7a-9ddf-4fcd-94c8-a22d56b40630@github.com>
References: <FShkxXV6Z_KcU6INfTyHyx-GfO9-xpgrDJi6ZQ0bmhE=.4cfc6764-b51b-4ab6-9323-5c7c1e2ca5e7@github.com>
 <WUdwWnKYlw0JcAMzYbaTmpjBeOa36sCL3SNJ5xIjtIY=.71ba1c7a-9ddf-4fcd-94c8-a22d56b40630@github.com>
Message-ID: <bplxDK1jlpstUQzQuzfEZyMYBjOGDhKdMWvzWwcB1bo=.d49e5004-a820-45be-b60e-3b985c18ad2f@github.com>

On Wed, 13 Mar 2024 09:36:01 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   instructions updated
>
> test/jdk/java/awt/im/PinyinIMCapsTest.java line 43:
> 
>> 41: 
>> 42: public class PinyinIMCapsTest {
>> 43:     private static final String INSTRUCTIONS = """
> 
> Can move `INSTRUCTIONS ` to main.

Some tests follow this pattern and few others have it within main. I usually define it as static var so retaining it the same here.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18245#discussion_r1523661666

From prr at openjdk.org  Wed Mar 13 17:44:15 2024
From: prr at openjdk.org (Phil Race)
Date: Wed, 13 Mar 2024 17:44:15 GMT
Subject: RFR: 8328030: Convert
 javax/swing/text/GlyphView/4984669/bug4984669.java applet test to main
In-Reply-To: <A08Xop2Zkm3QWsIXqy6DnupA4aku_YonZ5kpD4Mclrs=.0f8874a0-d2ba-4042-9768-e80dbfb44356@github.com>
References: <A08Xop2Zkm3QWsIXqy6DnupA4aku_YonZ5kpD4Mclrs=.0f8874a0-d2ba-4042-9768-e80dbfb44356@github.com>
Message-ID: <sCacHN1bU40CyiSLY0t0PyeBur8HjdLZTbAJQJS6Xwc=.a2d6dc3a-1e2f-4cb1-bd4d-68ff9214dd0f@github.com>

On Wed, 13 Mar 2024 05:52:07 GMT, Tejesh R <tr at openjdk.org> wrote:

> Convert javax/swing/text/GlyphView/4984669/bug4984669.java manual applet test to main based using PassFailJFrame.

Marked as reviewed by prr (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18256#pullrequestreview-1934826032

From prr at openjdk.org  Wed Mar 13 17:47:15 2024
From: prr at openjdk.org (Phil Race)
Date: Wed, 13 Mar 2024 17:47:15 GMT
Subject: RFR: 8327754: Convert
 javax/swing/JPopupMenu/7160604/bug7160604.java applet to main
In-Reply-To: <7frwXMi-bkKDX7Xw-pSh-AtGg7PcEdykdSmbvlVylhI=.9c9002c1-9c12-44ad-916a-f6c7dfd579ff@github.com>
References: <7frwXMi-bkKDX7Xw-pSh-AtGg7PcEdykdSmbvlVylhI=.9c9002c1-9c12-44ad-916a-f6c7dfd579ff@github.com>
Message-ID: <OvjG9r_LtT_DcXucZ6ADUxSWODbD8UbPR5TnYVaDtjE=.04849060-379e-4bbb-ac0a-611c2c1588a2@github.com>

On Wed, 13 Mar 2024 06:04:35 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> Conversion of manual applet test to main based using PassFailJFrame manual framework

Marked as reviewed by prr (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18257#pullrequestreview-1934831099

From abhiscxk at openjdk.org  Wed Mar 13 17:49:13 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Wed, 13 Mar 2024 17:49:13 GMT
Subject: RFR: 8327874: Convert javax/swing/JTree/4314199/bug4314199.java
 applet test to main
In-Reply-To: <jfIMdRykaFAGPaN45MwGkQUZWOt3e_cYNS7VPvL9Pu8=.6fb5f88a-c736-4a08-abeb-ea99b61dc1a4@github.com>
References: <4HQ5z1My4A9Qcac-1K9Y9sTf7dqWpxrJtdIgSxC1vro=.41a923c6-8607-4c95-8c6f-8a6c5ed1504f@github.com>
 <jfIMdRykaFAGPaN45MwGkQUZWOt3e_cYNS7VPvL9Pu8=.6fb5f88a-c736-4a08-abeb-ea99b61dc1a4@github.com>
Message-ID: <_g0lXPcneLwc74naGbvMaBlYvZ3JmZLNZLG8Iknrm8c=.8198f5a5-8365-4d03-97b7-6afd524cda23@github.com>

On Tue, 12 Mar 2024 20:50:18 GMT, Phil Race <prr at openjdk.org> wrote:

> We no longer need the extra folder level.

Updated.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18215#issuecomment-1995154631

From abhiscxk at openjdk.org  Wed Mar 13 17:52:29 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Wed, 13 Mar 2024 17:52:29 GMT
Subject: RFR: 8328089: Automate javax/swing/JTable/4222153/bug4222153.java
 applet test [v2]
In-Reply-To: <mVE4zdUddu3XPR7DxR9mbyzZwAMXUy0ylxrFmtuHAZU=.df6d1ce0-3afe-4370-b23a-0f4042efc9c9@github.com>
References: <mVE4zdUddu3XPR7DxR9mbyzZwAMXUy0ylxrFmtuHAZU=.df6d1ce0-3afe-4370-b23a-0f4042efc9c9@github.com>
Message-ID: <ErH_dwTdmbXCSYoDOuM16sR4G7aXLj4KgGWpc-3VQ8Y=.e7cfc360-5131-4a52-9d34-d6d7dcd2bc15@github.com>

> Conversion of manual applet test to automated test. CI testing is green. Link attached to JBS.

Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:

  Review comment fix

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18275/files
  - new: https://git.openjdk.org/jdk/pull/18275/files/6dee3d26..b8039815

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18275&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18275&range=00-01

  Stats: 8 lines in 1 file changed: 3 ins; 3 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/18275.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18275/head:pull/18275

PR: https://git.openjdk.org/jdk/pull/18275

From abhiscxk at openjdk.org  Wed Mar 13 17:52:30 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Wed, 13 Mar 2024 17:52:30 GMT
Subject: RFR: 8328089: Automate javax/swing/JTable/4222153/bug4222153.java
 applet test [v2]
In-Reply-To: <f_gLRcEQ2JGuUwMAhMm0JZz_YrIo56wVryDm0U0OXpU=.64d84d03-39e0-4647-98b7-c77834b5f612@github.com>
References: <mVE4zdUddu3XPR7DxR9mbyzZwAMXUy0ylxrFmtuHAZU=.df6d1ce0-3afe-4370-b23a-0f4042efc9c9@github.com>
 <f_gLRcEQ2JGuUwMAhMm0JZz_YrIo56wVryDm0U0OXpU=.64d84d03-39e0-4647-98b7-c77834b5f612@github.com>
Message-ID: <If5z20wLb0IkAE3Q2HcTmAsF00zFDbm21x_3QAELRk0=.e5c30b2a-f728-4cb1-8116-69ba47f7614f@github.com>

On Wed, 13 Mar 2024 16:59:43 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

> Delay can be reduced to 50ms

AutoDealy has been set to 100ms for many of the PRs. So, kept it as 100. Anyway, I will update to 50.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18275#discussion_r1523680206

From prr at openjdk.org  Wed Mar 13 17:58:13 2024
From: prr at openjdk.org (Phil Race)
Date: Wed, 13 Mar 2024 17:58:13 GMT
Subject: RFR: 8327755: Convert
 javax/swing/JScrollBar/8039464/Test8039464.java applet to main
In-Reply-To: <pn0rpaAbI1GrXNB2gVRKVEilfCbM0NX6M-T5E_xaidw=.96b0b4fb-ef4b-4749-b143-ed4a67531fd1@github.com>
References: <pn0rpaAbI1GrXNB2gVRKVEilfCbM0NX6M-T5E_xaidw=.96b0b4fb-ef4b-4749-b143-ed4a67531fd1@github.com>
Message-ID: <2p6ODfDpPtYphZXvbxcCflGRQTaNbuEGkNK-pwxRtvA=.65b8a2ae-086e-4f7a-97a4-6711d2a5ed62@github.com>

On Wed, 13 Mar 2024 06:30:34 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> Conversion of manual applet test to main based using PassFailJFrame manual framework

Marked as reviewed by prr (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18258#pullrequestreview-1934853604

From honkar at openjdk.org  Wed Mar 13 18:08:13 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Wed, 13 Mar 2024 18:08:13 GMT
Subject: RFR: 8328089: Automate javax/swing/JTable/4222153/bug4222153.java
 applet test [v2]
In-Reply-To: <ErH_dwTdmbXCSYoDOuM16sR4G7aXLj4KgGWpc-3VQ8Y=.e7cfc360-5131-4a52-9d34-d6d7dcd2bc15@github.com>
References: <mVE4zdUddu3XPR7DxR9mbyzZwAMXUy0ylxrFmtuHAZU=.df6d1ce0-3afe-4370-b23a-0f4042efc9c9@github.com>
 <ErH_dwTdmbXCSYoDOuM16sR4G7aXLj4KgGWpc-3VQ8Y=.e7cfc360-5131-4a52-9d34-d6d7dcd2bc15@github.com>
Message-ID: <5GQcNtKcaMCCwbwZIWJvU0SsnPIf84CXvHRH6u_3aHg=.eefe6d8a-c826-488f-8e90-13a2c3a1f2b7@github.com>

On Wed, 13 Mar 2024 17:52:29 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Conversion of manual applet test to automated test. CI testing is green. Link attached to JBS.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review comment fix

test/jdk/javax/swing/JTable/bug4222153.java line 95:

> 93:             robot.keyRelease(KeyEvent.VK_TAB);
> 94:             robot.waitForIdle();
> 95:             robot.delay(20);

@kumarabhi006 whitespace error detected at line#96.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18275#discussion_r1523706463

From abhiscxk at openjdk.org  Wed Mar 13 18:12:38 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Wed, 13 Mar 2024 18:12:38 GMT
Subject: RFR: 8328089: Automate javax/swing/JTable/4222153/bug4222153.java
 applet test [v3]
In-Reply-To: <mVE4zdUddu3XPR7DxR9mbyzZwAMXUy0ylxrFmtuHAZU=.df6d1ce0-3afe-4370-b23a-0f4042efc9c9@github.com>
References: <mVE4zdUddu3XPR7DxR9mbyzZwAMXUy0ylxrFmtuHAZU=.df6d1ce0-3afe-4370-b23a-0f4042efc9c9@github.com>
Message-ID: <r4hNSmyPdczUEL6rDJdXrZACk7d_ZHLmutZg4leKY6M=.73f48361-dfc1-4d9d-af21-53e2c35772a6@github.com>

> Conversion of manual applet test to automated test. CI testing is green. Link attached to JBS.

Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:

  Whitespace error fix

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18275/files
  - new: https://git.openjdk.org/jdk/pull/18275/files/b8039815..c251b3f3

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18275&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18275&range=01-02

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/18275.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18275/head:pull/18275

PR: https://git.openjdk.org/jdk/pull/18275

From abhiscxk at openjdk.org  Wed Mar 13 18:12:38 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Wed, 13 Mar 2024 18:12:38 GMT
Subject: RFR: 8328089: Automate javax/swing/JTable/4222153/bug4222153.java
 applet test [v2]
In-Reply-To: <5GQcNtKcaMCCwbwZIWJvU0SsnPIf84CXvHRH6u_3aHg=.eefe6d8a-c826-488f-8e90-13a2c3a1f2b7@github.com>
References: <mVE4zdUddu3XPR7DxR9mbyzZwAMXUy0ylxrFmtuHAZU=.df6d1ce0-3afe-4370-b23a-0f4042efc9c9@github.com>
 <ErH_dwTdmbXCSYoDOuM16sR4G7aXLj4KgGWpc-3VQ8Y=.e7cfc360-5131-4a52-9d34-d6d7dcd2bc15@github.com>
 <5GQcNtKcaMCCwbwZIWJvU0SsnPIf84CXvHRH6u_3aHg=.eefe6d8a-c826-488f-8e90-13a2c3a1f2b7@github.com>
Message-ID: <DucdSmyOHJS_--nvpE63Fa8t40q1xR4iw3NVzMmOsAI=.e2aac23f-dd5f-4b8c-8527-9e3ddf53b9e9@github.com>

On Wed, 13 Mar 2024 18:05:08 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review comment fix
>
> test/jdk/javax/swing/JTable/bug4222153.java line 95:
> 
>> 93:             robot.keyRelease(KeyEvent.VK_TAB);
>> 94:             robot.waitForIdle();
>> 95:             robot.delay(20);
> 
> @kumarabhi006 whitespace error detected at line#96.

Updated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18275#discussion_r1523711411

From honkar at openjdk.org  Wed Mar 13 18:17:14 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Wed, 13 Mar 2024 18:17:14 GMT
Subject: RFR: 8328089: Automate javax/swing/JTable/4222153/bug4222153.java
 applet test [v3]
In-Reply-To: <r4hNSmyPdczUEL6rDJdXrZACk7d_ZHLmutZg4leKY6M=.73f48361-dfc1-4d9d-af21-53e2c35772a6@github.com>
References: <mVE4zdUddu3XPR7DxR9mbyzZwAMXUy0ylxrFmtuHAZU=.df6d1ce0-3afe-4370-b23a-0f4042efc9c9@github.com>
 <r4hNSmyPdczUEL6rDJdXrZACk7d_ZHLmutZg4leKY6M=.73f48361-dfc1-4d9d-af21-53e2c35772a6@github.com>
Message-ID: <orvlEGHBfm-OV-dszsSNmRMAfsyN1MlnzmOLpdDl5es=.6e926dd4-06e4-4b72-845f-0072be9b2f29@github.com>

On Wed, 13 Mar 2024 18:12:38 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Conversion of manual applet test to automated test. CI testing is green. Link attached to JBS.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Whitespace error fix

Changes look good.

-------------

Marked as reviewed by honkar (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18275#pullrequestreview-1934888206

From prr at openjdk.org  Wed Mar 13 18:18:14 2024
From: prr at openjdk.org (Phil Race)
Date: Wed, 13 Mar 2024 18:18:14 GMT
Subject: RFR: 8328005: Convert java/awt/im/JTextFieldTest.java applet test
 to main [v2]
In-Reply-To: <YplUkKLbuHJpxhSKnrcLGhMzl0skOF2qnsd48VZrfHg=.864412ed-d927-47e5-8d3e-2f583477dad5@github.com>
References: <L1GhxeYrU35BXYEe9h_FL05fGrPgE7q4vWv3qTOe854=.c20a5812-ec96-4541-94b8-106dd17d9f95@github.com>
 <YplUkKLbuHJpxhSKnrcLGhMzl0skOF2qnsd48VZrfHg=.864412ed-d927-47e5-8d3e-2f583477dad5@github.com>
Message-ID: <05oH95MKBN-FyFfVFwzVbPXCnao8ni4J5EGiYOZRpu4=.8309b557-35b0-4fd6-898b-08db632faea2@github.com>

On Wed, 13 Mar 2024 00:27:32 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

>> Convert java/awt/im/JTextFieldTest.java applet test to main using PassFailJFrame.
>
> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix suggested redudant changes

test/jdk/java/awt/im/JTextFieldTest.java line 47:

> 45:             """
> 46:              Please run this test case under Solaris cjk locale with inputmethod
> 47:              support, if you could input Chinese/Japanese/Korean in the swing

The scenario here should not be specific to Solaris.
I think you should rephrase the first sentence to
"Please run this test in a CJK (Chinese/Japanese/Korean) locale with input method support".

I some times wonder how well these tests that say "please change your environment" actually get properly tested.
It is perhaps possible to do change desktop locale support on the fly but by the time
you read the instructions the test is already running.
That introduces another wrinkle. Maybe you need to restart at least this test.
And I am not 100% sure that jtreg passes through locale vars. I hope it does.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18247#discussion_r1523718224

From azvegint at openjdk.org  Wed Mar 13 18:18:22 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Wed, 13 Mar 2024 18:18:22 GMT
Subject: RFR: JDK-8328012 : Convert InputMethod (/java/awt/im) applet tests
 to main [v4]
In-Reply-To: <oadTMu4xuH37vGnNOY1TXF6dJTwx5-nA0gNWtQCKFf4=.3f7711ea-7b32-4ad3-8e1b-536a8757aa28@github.com>
References: <iDY1JdxeSzLcbW-ASx1PylUqKY-kGUjMj8tr4Sj5NDM=.a0b9fbdb-a959-4e98-ae08-d086fd8f210f@github.com>
 <oadTMu4xuH37vGnNOY1TXF6dJTwx5-nA0gNWtQCKFf4=.3f7711ea-7b32-4ad3-8e1b-536a8757aa28@github.com>
Message-ID: <jZpj-paG-TRIN44h9NoJkg2F--_cYhfFa7ZceGm-FCM=.489836e0-0787-4f6d-bfe4-fcb2afd947ce@github.com>

On Wed, 13 Mar 2024 17:20:38 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Following InputMethod applet tests are converted to main using PassFailJFrame
>> 
>> 1. java/awt/im/8132503/bug8132503.java (Renamed to PinyinIMFullstopTest.java)
>> 2. java/awt/im/8148984/bug8148984.java (Renamed to PinyinIMCommaTest.java) 
>> 
>> - test instructions are updated to make to more clear
>> - tests renamed 
>> - moved one directory above - /java/awt/im/
>> - html file deleted.
>> 
>> Two tests are updated as part of this PR as they are similar, details here https://github.com/openjdk/jdk/pull/18251#issuecomment-1992577598
>
> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   instruction updated

Marked as reviewed by azvegint (Reviewer).

test/jdk/java/awt/im/PinyinIMFullstopTest.java line 81:

> 79:     private static JComponent createUI() {
> 80:         JPanel panel = new JPanel();
> 81:         JTextField input = new JTextField(20);

Is there a specific reason why we switched from a text area to a text field?

-------------

PR Review: https://git.openjdk.org/jdk/pull/18251#pullrequestreview-1934832780
PR Review Comment: https://git.openjdk.org/jdk/pull/18251#discussion_r1523682463

From aivanov at openjdk.org  Wed Mar 13 18:30:16 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Wed, 13 Mar 2024 18:30:16 GMT
Subject: RFR: 8328011: Convert
 java/awt/Frame/GetBoundsResizeTest/GetBoundsResizeTest.java applet test to
 main [v2]
In-Reply-To: <9qtp_TZCirnTU3uMugjf4btFEirXuWK8UBSqWGQ-qRQ=.9fbc6b9e-51a7-44b3-84d5-1353edd0cdbd@github.com>
References: <77msAoji3SrhXCIcFcOTndR5MCc5jsoomdQ9Udl0WeE=.893b27fe-2ba5-48d9-920f-aab38592b614@github.com>
 <9qtp_TZCirnTU3uMugjf4btFEirXuWK8UBSqWGQ-qRQ=.9fbc6b9e-51a7-44b3-84d5-1353edd0cdbd@github.com>
Message-ID: <bayyKOGSoGiI5CAxGiO0PKSAvFWJQ6CuSCxNL4wkfkM=.207d7688-39b9-4d16-9785-5ee69e797272@github.com>

On Wed, 13 Mar 2024 00:53:36 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>> The test is converted to main.
>> Tested on Linux, Macos and Windows.
>
> Alexander Zvegintsev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   minor formatting

test/jdk/java/awt/Frame/GetBoundsResizeTest.java line 29:

> 27: import java.awt.Frame;
> 28: import java.awt.EventQueue;
> 29: import java.awt.Robot;

We haven't agreed on the order of imports, yet in most cases `javax.*` packages follow `java.*` packages.

test/jdk/java/awt/Frame/GetBoundsResizeTest.java line 47:

> 45:             2. Press the button to print the result of getBounds() to the terminal.
> 46:             3. If getBounds() prints the correct values for the window, click Pass,
> 47:              otherwise click Fail.

How do I determine whether the newly printed values are correct?

test/jdk/java/awt/Frame/GetBoundsResizeTest.java line 75:

> 73:         EventQueue.invokeAndWait(() ->
> 74:                 textArea.append("Original Frame.getBounds() = %s\n"
> 75:                         .formatted(frame.getBounds())));

Suggestion:

                textArea.append("Original Frame.getBounds() = %s\n"
                                .formatted(frame.getBounds())));

I believe @honkar-jdk made you update formatting? whereas the previous version looked right. Since `.formatted` is called on the string literal, it should be aligned to the start of the literal, to the opening quote. With such formatting, it could be misinterpreted to be called on the result of `textArea.append` which doesn't return anything.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18250#discussion_r1523648136
PR Review Comment: https://git.openjdk.org/jdk/pull/18250#discussion_r1523665403
PR Review Comment: https://git.openjdk.org/jdk/pull/18250#discussion_r1523662651

From aivanov at openjdk.org  Wed Mar 13 18:30:17 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Wed, 13 Mar 2024 18:30:17 GMT
Subject: RFR: 8328011: Convert
 java/awt/Frame/GetBoundsResizeTest/GetBoundsResizeTest.java applet test to
 main [v2]
In-Reply-To: <bayyKOGSoGiI5CAxGiO0PKSAvFWJQ6CuSCxNL4wkfkM=.207d7688-39b9-4d16-9785-5ee69e797272@github.com>
References: <77msAoji3SrhXCIcFcOTndR5MCc5jsoomdQ9Udl0WeE=.893b27fe-2ba5-48d9-920f-aab38592b614@github.com>
 <9qtp_TZCirnTU3uMugjf4btFEirXuWK8UBSqWGQ-qRQ=.9fbc6b9e-51a7-44b3-84d5-1353edd0cdbd@github.com>
 <bayyKOGSoGiI5CAxGiO0PKSAvFWJQ6CuSCxNL4wkfkM=.207d7688-39b9-4d16-9785-5ee69e797272@github.com>
Message-ID: <OSU_puPuNlJ9bi9p71APIMQNXx8cSx6mK_Q7wmxmyLo=.91932bd8-5789-4603-9b20-5ee2059bf831@github.com>

On Wed, 13 Mar 2024 17:29:46 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Alexander Zvegintsev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   minor formatting
>
> test/jdk/java/awt/Frame/GetBoundsResizeTest.java line 75:
> 
>> 73:         EventQueue.invokeAndWait(() ->
>> 74:                 textArea.append("Original Frame.getBounds() = %s\n"
>> 75:                         .formatted(frame.getBounds())));
> 
> Suggestion:
> 
>                 textArea.append("Original Frame.getBounds() = %s\n"
>                                 .formatted(frame.getBounds())));
> 
> I believe @honkar-jdk made you update formatting? whereas the previous version looked right. Since `.formatted` is called on the string literal, it should be aligned to the start of the literal, to the opening quote. With such formatting, it could be misinterpreted to be called on the result of `textArea.append` which doesn't return anything.

The same applies to the following event handler.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18250#discussion_r1523730047

From aivanov at openjdk.org  Wed Mar 13 18:30:17 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Wed, 13 Mar 2024 18:30:17 GMT
Subject: RFR: 8328011: Convert
 java/awt/Frame/GetBoundsResizeTest/GetBoundsResizeTest.java applet test to
 main [v2]
In-Reply-To: <OSU_puPuNlJ9bi9p71APIMQNXx8cSx6mK_Q7wmxmyLo=.91932bd8-5789-4603-9b20-5ee2059bf831@github.com>
References: <77msAoji3SrhXCIcFcOTndR5MCc5jsoomdQ9Udl0WeE=.893b27fe-2ba5-48d9-920f-aab38592b614@github.com>
 <9qtp_TZCirnTU3uMugjf4btFEirXuWK8UBSqWGQ-qRQ=.9fbc6b9e-51a7-44b3-84d5-1353edd0cdbd@github.com>
 <bayyKOGSoGiI5CAxGiO0PKSAvFWJQ6CuSCxNL4wkfkM=.207d7688-39b9-4d16-9785-5ee69e797272@github.com>
 <OSU_puPuNlJ9bi9p71APIMQNXx8cSx6mK_Q7wmxmyLo=.91932bd8-5789-4603-9b20-5ee2059bf831@github.com>
Message-ID: <iGZn3xUJydlyYaQzF9caPFD7t27h_ZyRCRmeKgirr-0=.70bc1dce-d6bb-410e-ad1a-58948aa92a4d@github.com>

On Wed, 13 Mar 2024 18:26:28 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> test/jdk/java/awt/Frame/GetBoundsResizeTest.java line 75:
>> 
>>> 73:         EventQueue.invokeAndWait(() ->
>>> 74:                 textArea.append("Original Frame.getBounds() = %s\n"
>>> 75:                         .formatted(frame.getBounds())));
>> 
>> Suggestion:
>> 
>>                 textArea.append("Original Frame.getBounds() = %s\n"
>>                                 .formatted(frame.getBounds())));
>> 
>> I believe @honkar-jdk made you update formatting? whereas the previous version looked right. Since `.formatted` is called on the string literal, it should be aligned to the start of the literal, to the opening quote. With such formatting, it could be misinterpreted to be called on the result of `textArea.append` which doesn't return anything.
>
> The same applies to the following event handler.

What can help to reduce the indentation is introducing a helper method. If it's still too long, store the result of formatting into a local variable and then append it to `textArea`. This can be done even in lambdas.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18250#discussion_r1523730416

From aivanov at openjdk.org  Wed Mar 13 18:36:14 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Wed, 13 Mar 2024 18:36:14 GMT
Subject: RFR: 8325179: Race in BasicDirectoryModel.validateFileCache [v3]
In-Reply-To: <mVHHIki7p8TDSN0TlD0kaRuNzWUHom5W-y7y51rxjSA=.35bcbabb-4c2c-4f9e-a48b-b34995336da2@github.com>
References: <nOapec57Ql6DHy57oEeWdkUGER8RYdWc2vwmJsqWDYc=.8de81954-d8c2-4937-b426-e61dde05255e@github.com>
 <mVHHIki7p8TDSN0TlD0kaRuNzWUHom5W-y7y51rxjSA=.35bcbabb-4c2c-4f9e-a48b-b34995336da2@github.com>
Message-ID: <ym5m29LRsQE9UqQ5rBR2k-CI0e_08DAhmPdYKEuRrpQ=.2a9ff13b-a175-4859-a846-228154ed4baf@github.com>

On Wed, 6 Mar 2024 11:27:08 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Ensure access to the `filesLoader` field of `BasicDirectoryModel` is synchronized.
>> 
>> Without synchronization, a thread checks if `filesLoader` is not null and creates a new `FilesLoader` thread. If the thread is pre-empted between these two operations, another thread or even several threads can see the `null` value and create new `FilesLoader` threads.
>> 
>> The same way, `BasicDirectoryModel.invalidateFileCache` needs to be synchornized to interrupt the current `filesLoader` and assign `null`.
>> 
>> This bug allows reproducing `ConcurrentModificationException` seen in [JDK-8323670](https://bugs.openjdk.org/browse/JDK-8323670) and [JDK-8307091](https://bugs.openjdk.org/browse/JDK-8307091) using the test in PR #18109.
>
> Alexey Ivanov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Store the size of fileCache inside synchronized block

@mrserb Do you have any comments?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18111#issuecomment-1995314980

From honkar at openjdk.org  Wed Mar 13 18:55:23 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Wed, 13 Mar 2024 18:55:23 GMT
Subject: RFR: JDK-8328115 : Convert
 java/awt/font/TextLayout/TestJustification.html applet test to main
Message-ID: <-yOR9f0Ysff7awg6qHW2OoFR1zmgLk6c8r9qTFC6QhE=.7ac90ce0-f3f7-4ac6-ba46-945f73a5f4a8@github.com>

java/awt/font/TextLayout/TestJustification.html  is converted to main manual test using PassFailJFrame. 

This test was previously problemlisted on macOS. When tested on macOS, the problem still exists and not all lines are justified to the same length (lines containing Arabic & Hebrew differ by a small amount, Refer [JDK-8250791](https://bugs.openjdk.org/browse/JDK-8250791)). For this reason, the test is retained in problemlist but the extension is changed to .java to match the test changes.

-------------

Commit messages:
 - reindented file
 - applet to main changes

Changes: https://git.openjdk.org/jdk/pull/18285/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18285&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8328115
  Stats: 359 lines in 3 files changed: 114 ins; 154 del; 91 mod
  Patch: https://git.openjdk.org/jdk/pull/18285.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18285/head:pull/18285

PR: https://git.openjdk.org/jdk/pull/18285

From aturbanov at openjdk.org  Wed Mar 13 18:59:14 2024
From: aturbanov at openjdk.org (Andrey Turbanov)
Date: Wed, 13 Mar 2024 18:59:14 GMT
Subject: RFR: 8325179: Race in BasicDirectoryModel.validateFileCache [v3]
In-Reply-To: <mVHHIki7p8TDSN0TlD0kaRuNzWUHom5W-y7y51rxjSA=.35bcbabb-4c2c-4f9e-a48b-b34995336da2@github.com>
References: <nOapec57Ql6DHy57oEeWdkUGER8RYdWc2vwmJsqWDYc=.8de81954-d8c2-4937-b426-e61dde05255e@github.com>
 <mVHHIki7p8TDSN0TlD0kaRuNzWUHom5W-y7y51rxjSA=.35bcbabb-4c2c-4f9e-a48b-b34995336da2@github.com>
Message-ID: <9QDt94sVU4wTNy6YhVR6g8M0RF19IQuAGUswHah0JYQ=.055ae03f-7e71-49c3-b41d-c47618c12a5e@github.com>

On Wed, 6 Mar 2024 11:27:08 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Ensure access to the `filesLoader` field of `BasicDirectoryModel` is synchronized.
>> 
>> Without synchronization, a thread checks if `filesLoader` is not null and creates a new `FilesLoader` thread. If the thread is pre-empted between these two operations, another thread or even several threads can see the `null` value and create new `FilesLoader` threads.
>> 
>> The same way, `BasicDirectoryModel.invalidateFileCache` needs to be synchornized to interrupt the current `filesLoader` and assign `null`.
>> 
>> This bug allows reproducing `ConcurrentModificationException` seen in [JDK-8323670](https://bugs.openjdk.org/browse/JDK-8323670) and [JDK-8307091](https://bugs.openjdk.org/browse/JDK-8307091) using the test in PR #18109.
>
> Alexey Ivanov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Store the size of fileCache inside synchronized block

Marked as reviewed by aturbanov (Committer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18111#pullrequestreview-1934977862

From azvegint at openjdk.org  Wed Mar 13 19:01:27 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Wed, 13 Mar 2024 19:01:27 GMT
Subject: RFR: 8328011: Convert
 java/awt/Frame/GetBoundsResizeTest/GetBoundsResizeTest.java applet test to
 main [v3]
In-Reply-To: <77msAoji3SrhXCIcFcOTndR5MCc5jsoomdQ9Udl0WeE=.893b27fe-2ba5-48d9-920f-aab38592b614@github.com>
References: <77msAoji3SrhXCIcFcOTndR5MCc5jsoomdQ9Udl0WeE=.893b27fe-2ba5-48d9-920f-aab38592b614@github.com>
Message-ID: <r3m0FPAacrLKOI6SVZnH7GVRslKDpDjwaGECcCD3o0I=.c16baf2a-78f1-4634-93fa-0813f5e381cc@github.com>

> The test is converted to main.
> Tested on Linux, Macos and Windows.

Alexander Zvegintsev has updated the pull request incrementally with one additional commit since the last revision:

  extract logFrameBounds, instructions update

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18250/files
  - new: https://git.openjdk.org/jdk/pull/18250/files/c09f4949..2c90d8e3

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18250&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18250&range=01-02

  Stats: 17 lines in 1 file changed: 8 ins; 4 del; 5 mod
  Patch: https://git.openjdk.org/jdk/pull/18250.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18250/head:pull/18250

PR: https://git.openjdk.org/jdk/pull/18250

From azvegint at openjdk.org  Wed Mar 13 19:01:27 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Wed, 13 Mar 2024 19:01:27 GMT
Subject: RFR: 8328011: Convert
 java/awt/Frame/GetBoundsResizeTest/GetBoundsResizeTest.java applet test to
 main [v2]
In-Reply-To: <bayyKOGSoGiI5CAxGiO0PKSAvFWJQ6CuSCxNL4wkfkM=.207d7688-39b9-4d16-9785-5ee69e797272@github.com>
References: <77msAoji3SrhXCIcFcOTndR5MCc5jsoomdQ9Udl0WeE=.893b27fe-2ba5-48d9-920f-aab38592b614@github.com>
 <9qtp_TZCirnTU3uMugjf4btFEirXuWK8UBSqWGQ-qRQ=.9fbc6b9e-51a7-44b3-84d5-1353edd0cdbd@github.com>
 <bayyKOGSoGiI5CAxGiO0PKSAvFWJQ6CuSCxNL4wkfkM=.207d7688-39b9-4d16-9785-5ee69e797272@github.com>
Message-ID: <9YxeUeeVFrKVvlymncS2p8IPO-rg4yBhN44Ju-F-YSU=.b8f11906-0e89-4fef-825c-4c53dbfc81dc@github.com>

On Wed, 13 Mar 2024 17:32:01 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Alexander Zvegintsev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   minor formatting
>
> test/jdk/java/awt/Frame/GetBoundsResizeTest.java line 47:
> 
>> 45:             2. Press the button to print the result of getBounds() to the terminal.
>> 46:             3. If getBounds() prints the correct values for the window, click Pass,
>> 47:              otherwise click Fail.
> 
> How do I determine whether the newly printed values are correct?

The instructions updated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18250#discussion_r1523772401

From achung at openjdk.org  Wed Mar 13 19:30:22 2024
From: achung at openjdk.org (Alisen Chung)
Date: Wed, 13 Mar 2024 19:30:22 GMT
Subject: RFR: 8328121: Remove applet usage from JColorChooser tests Test4759306
Message-ID: <C8wP7UJKyxmliTDxZ5YYEZS4TcPytfHn86fCL_zTI3o=.8fa88a3e-1156-4f66-b6d8-00c182299d66@github.com>

Removing applet usage from manual JColorChooser tests

-------------

Commit messages:
 - init commit

Changes: https://git.openjdk.org/jdk/pull/18286/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18286&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8328121
  Stats: 61 lines in 2 files changed: 20 ins; 36 del; 5 mod
  Patch: https://git.openjdk.org/jdk/pull/18286.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18286/head:pull/18286

PR: https://git.openjdk.org/jdk/pull/18286

From kizune at openjdk.org  Wed Mar 13 19:43:14 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Wed, 13 Mar 2024 19:43:14 GMT
Subject: RFR: 8316388: Opensource five Swing component related regression
 tests
In-Reply-To: <9hBnCXqmWqizqPJKVIA8M8wL2i9lqgddkRMwMmIU4qM=.a09493e9-a861-4383-aa51-4e692f0acf67@github.com>
References: <lyqr03dS3RFZwQum85-sdTUI2flExMCQm9Dps70wX5w=.1e207aa6-34e2-48e5-866c-bc39eb8d479f@github.com>
 <9hBnCXqmWqizqPJKVIA8M8wL2i9lqgddkRMwMmIU4qM=.a09493e9-a861-4383-aa51-4e692f0acf67@github.com>
Message-ID: <UNFvvQw5qKczcFoJUmKum9Sl9pbk0YI_I2aQRjsiqW0=.e6f228d1-6ff9-4009-b8fe-5a0e0209901a@github.com>

On Wed, 13 Mar 2024 16:19:35 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Cleaned up five more tests.
>> 
>> Continuation of https://github.com/openjdk/jdk/pull/18184
>> 
>> Unfortunately one of the commits rendered the whole PR invalid so i closed it and restarting it here.
>> All comments from the previous review are addressed.
>
> test/jdk/javax/swing/JDesktopPane/bug4773378.java line 99:
> 
>> 97:                 bug4773378.this.wait();
>> 98:             }
>> 99:         }
> 
> Suggestion:
> 
>         frameActivated.await();
> 
> 
> Using `CountDownLatch` is so much cleaner.

You like your countdown latches :) Ok, i will re-write this test with CDL.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18259#discussion_r1523824985

From azvegint at openjdk.org  Wed Mar 13 19:48:19 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Wed, 13 Mar 2024 19:48:19 GMT
Subject: RFR: 8328124: Convert java/awt/Frame/ShownOnPack/ShownOnPack.html
 applet test to main
Message-ID: <yC3Qtep10q3KRJrCfQv-ThrGmE7xdedwQjrr0dBMVMw=.9b87a76e-5af8-411e-bd31-dd8f390d6b24@github.com>

The test is converted to main.
Tested on Linux, Macos and Windows.

-------------

Commit messages:
 - 8328124: Convert java/awt/Frame/ShownOnPack/ShownOnPack.html applet test to main

Changes: https://git.openjdk.org/jdk/pull/18287/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18287&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8328124
  Stats: 250 lines in 2 files changed: 4 ins; 208 del; 38 mod
  Patch: https://git.openjdk.org/jdk/pull/18287.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18287/head:pull/18287

PR: https://git.openjdk.org/jdk/pull/18287

From kizune at openjdk.org  Wed Mar 13 19:49:13 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Wed, 13 Mar 2024 19:49:13 GMT
Subject: RFR: 8316388: Opensource five Swing component related regression
 tests
In-Reply-To: <9hBnCXqmWqizqPJKVIA8M8wL2i9lqgddkRMwMmIU4qM=.a09493e9-a861-4383-aa51-4e692f0acf67@github.com>
References: <lyqr03dS3RFZwQum85-sdTUI2flExMCQm9Dps70wX5w=.1e207aa6-34e2-48e5-866c-bc39eb8d479f@github.com>
 <9hBnCXqmWqizqPJKVIA8M8wL2i9lqgddkRMwMmIU4qM=.a09493e9-a861-4383-aa51-4e692f0acf67@github.com>
Message-ID: <ODsdlmTo8IeRg5OKHBTR7QhmWr3FN1vowgoBQehcKRo=.8bd80175-00af-4af1-af29-8ac6f6e7ec52@github.com>

On Wed, 13 Mar 2024 16:25:03 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Cleaned up five more tests.
>> 
>> Continuation of https://github.com/openjdk/jdk/pull/18184
>> 
>> Unfortunately one of the commits rendered the whole PR invalid so i closed it and restarting it here.
>> All comments from the previous review are addressed.
>
> test/jdk/javax/swing/JDesktopPane/bug4773378.java line 107:
> 
>> 105:         robot.keyRelease(KeyEvent.VK_CONTROL);
>> 106: 
>> 107:         Thread.sleep(2000);
> 
> Suggestion:
> 
>         robot.waitForIdle();
> 
> Is it really necessary to wait for 2 seconds before shutting down the test.
> 
> According to [JDK-4773378](https://bugs.openjdk.org/browse/JDK-4773378), `NullPointerException` was thrown when <kbd>Ctrl</kbd>+<kbd>F6</kbd> was pressed. The `waitForIdle` method doesn't return until the event queue is empty which implies the keyboard events are handled. It saves nearly 2 seconds.

Ok.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18259#discussion_r1523831409

From kizune at openjdk.org  Wed Mar 13 20:08:07 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Wed, 13 Mar 2024 20:08:07 GMT
Subject: RFR: 8316388: Opensource five Swing component related regression
 tests
In-Reply-To: <9hBnCXqmWqizqPJKVIA8M8wL2i9lqgddkRMwMmIU4qM=.a09493e9-a861-4383-aa51-4e692f0acf67@github.com>
References: <lyqr03dS3RFZwQum85-sdTUI2flExMCQm9Dps70wX5w=.1e207aa6-34e2-48e5-866c-bc39eb8d479f@github.com>
 <9hBnCXqmWqizqPJKVIA8M8wL2i9lqgddkRMwMmIU4qM=.a09493e9-a861-4383-aa51-4e692f0acf67@github.com>
Message-ID: <baU5LsUrDpWgtFKq1zoKW2GtOnISwyBqaqySkIQqC5A=.94e8a1a6-020a-4ded-b8e1-fea5b86b1438@github.com>

On Wed, 13 Mar 2024 16:28:47 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Cleaned up five more tests.
>> 
>> Continuation of https://github.com/openjdk/jdk/pull/18184
>> 
>> Unfortunately one of the commits rendered the whole PR invalid so i closed it and restarting it here.
>> All comments from the previous review are addressed.
>
> test/jdk/javax/swing/JEditorPane/bug4325606.java line 80:
> 
>> 78:                 robo = new Robot();
>> 79:             } catch (AWTException e) {
>> 80:                 throw new RuntimeException("Robot could not be created");
> 
> Suggestion:
> 
>                 throw new RuntimeException("Robot could not be created", e);
> 
> Preserve the original exception, which would be very helpful for debugging if it ever occurs.

Ok.

> test/jdk/javax/swing/JEditorPane/bug4325606.java line 84:
> 
>> 82:             robo.setAutoDelay(100);
>> 83:             robo.delay(1000);
>> 84:             Point p = frame.getLocationOnScreen();
> 
> Technically, `getLocationOnScreen` should be called on EDT.

It happens in the windowOpened method of the WindowAdapter. If window events arrive not on EDT then we have a whole other slew of problems :)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18259#discussion_r1523834899
PR Review Comment: https://git.openjdk.org/jdk/pull/18259#discussion_r1523842229

From kizune at openjdk.org  Wed Mar 13 20:56:12 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Wed, 13 Mar 2024 20:56:12 GMT
Subject: RFR: 8316388: Opensource five Swing component related regression
 tests [v2]
In-Reply-To: <lyqr03dS3RFZwQum85-sdTUI2flExMCQm9Dps70wX5w=.1e207aa6-34e2-48e5-866c-bc39eb8d479f@github.com>
References: <lyqr03dS3RFZwQum85-sdTUI2flExMCQm9Dps70wX5w=.1e207aa6-34e2-48e5-866c-bc39eb8d479f@github.com>
Message-ID: <NrnqPz84LBQAj_3HGLajFOm0pmWnnR-tVRiqPllrU_s=.4f1cb3d0-7d86-4b19-ade4-a236dd4cdfa8@github.com>

> Cleaned up five more tests.
> 
> Continuation of https://github.com/openjdk/jdk/pull/18184
> 
> Unfortunately one of the commits rendered the whole PR invalid so i closed it and restarting it here.
> All comments from the previous review are addressed.

Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:

  Minor changes based on review comments.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18259/files
  - new: https://git.openjdk.org/jdk/pull/18259/files/450cdda7..de3acd64

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18259&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18259&range=00-01

  Stats: 31 lines in 2 files changed: 2 ins; 20 del; 9 mod
  Patch: https://git.openjdk.org/jdk/pull/18259.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18259/head:pull/18259

PR: https://git.openjdk.org/jdk/pull/18259

From kizune at openjdk.org  Wed Mar 13 20:56:12 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Wed, 13 Mar 2024 20:56:12 GMT
Subject: RFR: 8316388: Opensource five Swing component related regression
 tests [v2]
In-Reply-To: <9hBnCXqmWqizqPJKVIA8M8wL2i9lqgddkRMwMmIU4qM=.a09493e9-a861-4383-aa51-4e692f0acf67@github.com>
References: <lyqr03dS3RFZwQum85-sdTUI2flExMCQm9Dps70wX5w=.1e207aa6-34e2-48e5-866c-bc39eb8d479f@github.com>
 <9hBnCXqmWqizqPJKVIA8M8wL2i9lqgddkRMwMmIU4qM=.a09493e9-a861-4383-aa51-4e692f0acf67@github.com>
Message-ID: <l9OECT3rO4xtyvPaduDgc9fOX8dHsK8PR-lIbnDx3G8=.f8c24649-d93b-431e-a9c2-bc16cfd9816f@github.com>

On Wed, 13 Mar 2024 16:38:14 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Minor changes based on review comments.
>
> test/jdk/javax/swing/JEditorPane/bug4694598.java line 64:
> 
>> 62:         } catch (IOException ioe){
>> 63:             throw new RuntimeException("Could not create html file to embed", ioe);
>> 64:         }
> 
> Move creating the file to `main` method before setting up GUI and let `IOException` escape from main.

This is try-with-resources so if i will do it in main i will have to add synchronizing and closing of writer which is a strange trade-off so i would have to do try block anyways.

> test/jdk/javax/swing/JEditorPane/bug4694598.java line 74:
> 
>> 72:         String html = "<HTML> <BODY>" +
>> 73:                 "<FRAMESET cols=\"100%\">" +
>> 74:                 "<FRAME src=\"" + frameContentUrl + "\">" +
> 
> Suggestion:
> 
>                 "<FRAME src="" + frameContentFile.toUri()+ "">" +
> 
> Isn't it enough? Alternatively, `"file:/" + frameContentFile.toAbsolutePath()` produces the same result as `frameContentFile.toUri().toURL()`.
> 
> Another option is to convert the `Path` to `URL` in the `main` method before calling `setupGUI` and remove try-catch blocks.

Again, i do not mind the try/catch block and using URI instead of URL gives different result and i am not sure the original bug would be reproducible with URI which will make it a strange case of the regression test.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18259#discussion_r1523895158
PR Review Comment: https://git.openjdk.org/jdk/pull/18259#discussion_r1523900378

From achung at openjdk.org  Wed Mar 13 21:03:47 2024
From: achung at openjdk.org (Alisen Chung)
Date: Wed, 13 Mar 2024 21:03:47 GMT
Subject: RFR: 8328130: Remove applet usage from JColorChooser tests Test4759934
Message-ID: <V5jXFcSvoonQJFoR7h-oRHEL9JLd6Pz5J1gzv2DJVH0=.aa6c1453-59fc-41ed-bfa9-af86f2d52a1f@github.com>

Removing applet usage from manual JColorChooser tests

-------------

Commit messages:
 - remove html file
 - init commit

Changes: https://git.openjdk.org/jdk/pull/18288/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18288&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8328130
  Stats: 93 lines in 2 files changed: 31 ins; 47 del; 15 mod
  Patch: https://git.openjdk.org/jdk/pull/18288.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18288/head:pull/18288

PR: https://git.openjdk.org/jdk/pull/18288

From prr at openjdk.org  Wed Mar 13 21:11:40 2024
From: prr at openjdk.org (Phil Race)
Date: Wed, 13 Mar 2024 21:11:40 GMT
Subject: RFR: 8328130: Remove applet usage from JColorChooser tests
 Test4759934
In-Reply-To: <V5jXFcSvoonQJFoR7h-oRHEL9JLd6Pz5J1gzv2DJVH0=.aa6c1453-59fc-41ed-bfa9-af86f2d52a1f@github.com>
References: <V5jXFcSvoonQJFoR7h-oRHEL9JLd6Pz5J1gzv2DJVH0=.aa6c1453-59fc-41ed-bfa9-af86f2d52a1f@github.com>
Message-ID: <lolhyLOWWBTzXqVilcCfcN5lg044R1fytXnQziv3aws=.0fe5aa01-f71b-43ba-b792-0ab5d60480f3@github.com>

On Wed, 13 Mar 2024 20:57:42 GMT, Alisen Chung <achung at openjdk.org> wrote:

> Removing applet usage from manual JColorChooser tests

test/jdk/javax/swing/JColorChooser/Test4759934.java line 27:

> 25:  * @test
> 26:  * @bug 4759934
> 27:  * * @library /test/jdk/java/awt/regtesthelpers /test/lib

remove /test/jdk from this

test/jdk/javax/swing/JColorChooser/Test4759934.java line 73:

> 71:                 .title("Test4759934")
> 72:                 .instructions("Click on show Dialog. Then click on Show ColorChooser.\n" +
> 73:                         "If a ColorChooser is shown, then pass.")

Why is this just the first part of the instructions as given in the previous HTML ?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18288#discussion_r1523914522
PR Review Comment: https://git.openjdk.org/jdk/pull/18288#discussion_r1523917663

From clanger at openjdk.org  Wed Mar 13 21:11:53 2024
From: clanger at openjdk.org (Christoph Langer)
Date: Wed, 13 Mar 2024 21:11:53 GMT
Subject: RFR: 8185862: AWT Assertion Failure in ::GetDIBits(hBMDC, hBM, 0, 
 1, 0, gpBitmapInfo, 0) 'awt_Win32GraphicsDevice.cpp',
 at line 185 [v11]
In-Reply-To: <I9mJYJqXa-aLxUycPdvGf5iPE823mtPcxj9tKOVtGIE=.c791117f-1bc6-4c4a-83a4-ad27308d33ee@github.com>
References: <Cj_htOZE6ImXdNmj43IBiX7rW4Em4ZF-6kx0qIZW-Ho=.d355fedd-7ec8-463d-969b-e2123987d1dd@github.com>
 <I9mJYJqXa-aLxUycPdvGf5iPE823mtPcxj9tKOVtGIE=.c791117f-1bc6-4c4a-83a4-ad27308d33ee@github.com>
Message-ID: <iajPmtQx9hjLBvuMTBy2emUrqs7EGgak4ONVYiOLOgs=.c10df9a6-9195-42d1-9df5-1e987f8e46ba@github.com>

On Thu, 7 Mar 2024 16:55:12 GMT, Christoph Langer <clanger at openjdk.org> wrote:

>> The assertions reported in the bug were observed spuriously and here and there broke tests in some Windows configurations.
>> For instance [JDK-8266129](https://bugs.openjdk.org/browse/JDK-8266129), [JDK-8269529](https://bugs.openjdk.org/browse/JDK-8269529) or [JDK-8323664](https://bugs.openjdk.org/browse/JDK-8323664) came up due to this.
>> 
>> The problem is that in Windows environments without a valid display, e.g. started by system services or via PowerShell Remoting, one sees a Monitor with name 'Windisc' in `EnumDisplayMonitors`.
>> However, it seems to be some kind of a pseudo device where you can not get a DC via `CreateDC`. This behavior/monitor type doesn't seem to be well documented, though.
>> 
>> I hereby modify the device initialization code to only count/detect monitors where CreateDC returns non-NULL in Devices.cpp. I also add some more checking/error handling to AwtWin32GraphicsDevice::Initialize() for correctness.
>> 
>> Furthermore, I re-enable the test `javax/swing/reliability/HangDuringStaticInitialization.java` for Windows Debug VMs, which reverts the fix from JDK-8269529 that should not be necessary any more.
>
> Christoph Langer has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Bring back verification of hBMDC and hBM

Thanks for the reviews.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17614#issuecomment-1995820690

From clanger at openjdk.org  Wed Mar 13 21:11:54 2024
From: clanger at openjdk.org (Christoph Langer)
Date: Wed, 13 Mar 2024 21:11:54 GMT
Subject: Integrated: 8185862: AWT Assertion Failure in ::GetDIBits(hBMDC, hBM, 
 0, 1, 0, gpBitmapInfo, 0) 'awt_Win32GraphicsDevice.cpp', at line 185
In-Reply-To: <Cj_htOZE6ImXdNmj43IBiX7rW4Em4ZF-6kx0qIZW-Ho=.d355fedd-7ec8-463d-969b-e2123987d1dd@github.com>
References: <Cj_htOZE6ImXdNmj43IBiX7rW4Em4ZF-6kx0qIZW-Ho=.d355fedd-7ec8-463d-969b-e2123987d1dd@github.com>
Message-ID: <yzQQHAGiZocQ66AjsnScVf79csZoQQ5TNDWCaKilIew=.de2c67a5-e142-4f27-a7b3-267535b9106d@github.com>

On Mon, 29 Jan 2024 14:24:43 GMT, Christoph Langer <clanger at openjdk.org> wrote:

> The assertions reported in the bug were observed spuriously and here and there broke tests in some Windows configurations.
> For instance [JDK-8266129](https://bugs.openjdk.org/browse/JDK-8266129), [JDK-8269529](https://bugs.openjdk.org/browse/JDK-8269529) or [JDK-8323664](https://bugs.openjdk.org/browse/JDK-8323664) came up due to this.
> 
> The problem is that in Windows environments without a valid display, e.g. started by system services or via PowerShell Remoting, one sees a Monitor with name 'Windisc' in `EnumDisplayMonitors`.
> However, it seems to be some kind of a pseudo device where you can not get a DC via `CreateDC`. This behavior/monitor type doesn't seem to be well documented, though.
> 
> I hereby modify the device initialization code to only count/detect monitors where CreateDC returns non-NULL in Devices.cpp. I also add some more checking/error handling to AwtWin32GraphicsDevice::Initialize() for correctness.
> 
> Furthermore, I re-enable the test `javax/swing/reliability/HangDuringStaticInitialization.java` for Windows Debug VMs, which reverts the fix from JDK-8269529 that should not be necessary any more.

This pull request has now been integrated.

Changeset: 1ad3ebcf
Author:    Christoph Langer <clanger at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/1ad3ebcf11834ec1d119ee95c858d98fb7bc6e68
Stats:     149 lines in 9 files changed: 89 ins; 25 del; 35 mod

8185862: AWT Assertion Failure in ::GetDIBits(hBMDC, hBM, 0, 1, 0, gpBitmapInfo, 0) 'awt_Win32GraphicsDevice.cpp', at line 185

Reviewed-by: aivanov, prr

-------------

PR: https://git.openjdk.org/jdk/pull/17614

From prr at openjdk.org  Wed Mar 13 22:03:38 2024
From: prr at openjdk.org (Phil Race)
Date: Wed, 13 Mar 2024 22:03:38 GMT
Subject: RFR: 8327752: Convert
 javax/swing/JOptionPane/4174551/bug4174551.java applet to main [v3]
In-Reply-To: <ghSGfbJo4HU6RIIjDHPVp-nXieddPCm6RoJSzZl6uB4=.af32e47e-ec13-4919-b357-6e09d49e137f@github.com>
References: <uEqsAwVSEu11kSzb6ccgfje4GyOGoZ4G0Wk59AYnvAI=.37029531-7173-4ea8-9ad7-3eb3dadde5a0@github.com>
 <ghSGfbJo4HU6RIIjDHPVp-nXieddPCm6RoJSzZl6uB4=.af32e47e-ec13-4919-b357-6e09d49e137f@github.com>
Message-ID: <x5xBoi90j5xbwCJuE0XYjYJeI5ZtmQ7OmuXK59IuI1g=.a5ccb7d4-109d-44b3-8a1a-e2340c4aa26f@github.com>

On Wed, 13 Mar 2024 08:40:42 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Conversion of manual applet test to main based using PassFailJFrame manual framework
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Test passcriteria instructions update

Marked as reviewed by prr (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18228#pullrequestreview-1935289278

From prr at openjdk.org  Wed Mar 13 22:03:54 2024
From: prr at openjdk.org (Phil Race)
Date: Wed, 13 Mar 2024 22:03:54 GMT
Subject: RFR: 8328004: Minor updates to TrayIcon test
 DisposeInActionEventTest.java [v2]
In-Reply-To: <4Zq2gsAshsqM3HxMV4jxpgm25WDx40QRJ-EuBMVaAfQ=.f96fc9c2-ad2f-4026-9d9e-74d7444bb3fb@github.com>
References: <4Zq2gsAshsqM3HxMV4jxpgm25WDx40QRJ-EuBMVaAfQ=.f96fc9c2-ad2f-4026-9d9e-74d7444bb3fb@github.com>
Message-ID: <4RDiLuYguODpYpWcs4xkfBHMLgPNF53N5u0aVdHhxlk=.d73676a4-6b51-4e4f-b8db-4f5f966423ef@github.com>

> This was recently converted from a manual Applet to a PassFailJFrame main program
> But I see a few things that could be tweaked
>  - Clarify instructions
>  -  Set path to PassFailJFrame
>  - reduce timeout to default
>  - eliminate redundant folder

Phil Race has updated the pull request incrementally with one additional commit since the last revision:

  8328004

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18246/files
  - new: https://git.openjdk.org/jdk/pull/18246/files/800c3c43..a94468d6

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18246&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18246&range=00-01

  Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/18246.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18246/head:pull/18246

PR: https://git.openjdk.org/jdk/pull/18246

From prr at openjdk.org  Wed Mar 13 22:06:40 2024
From: prr at openjdk.org (Phil Race)
Date: Wed, 13 Mar 2024 22:06:40 GMT
Subject: RFR: 8327924: Simplify TrayIconScalingTest.java
In-Reply-To: <v4lDY1J2WCp2RqxfYXNYImaEx5EOeX2x4LM23n93Zrs=.010ab607-ba30-484d-b293-460ed4444b1a@github.com>
References: <v4lDY1J2WCp2RqxfYXNYImaEx5EOeX2x4LM23n93Zrs=.010ab607-ba30-484d-b293-460ed4444b1a@github.com>
Message-ID: <6JqcozfzKx1Ec8z9bT_uCZ7Dm9tTexqdmVYEbvTRBno=.409249f8-b6aa-4374-8213-4f8681490623@github.com>

On Tue, 12 Mar 2024 08:33:41 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> This is to simplify `TrayIconScalingTest.java`.
> 
> 1. Rename `createAndShowGUI` to `createAndShowTrayIcon` which is more specific.
> 2. Move creating tray icon to the top.
> 3. Streamline PassFailJFrame with the chained calls, including `awaitAndCheck`.
> 4. Ensure tray is not null before removing the icon.
> 5. Pass AWTException as the cause in the wrapped exception.
> 
> Previously, before the builder pattern was introduced, `PassFailJFrame.positionTestWindow` had had to be called to show the instructions UI. It's not required any more. Additionally, it has the effect of moving the instruction frame to the left, which doesn't look good and sometimes results in positioning the instructions outside of the screen bounds if the screen resolution is low.
> 
> With the builder pattern, the call to the `build` method shows all the registered windows on the screen, including the instruction frame. Since there's no secondary UI, the instructions remain in the centre of the screen.

Marked as reviewed by prr (Reviewer).

test/jdk/java/awt/TrayIcon/TrayIconScalingTest.java line 97:

> 95:                     .testTimeOut(8)
> 96:                     .rows(25)
> 97:                     .columns(70)

Personally I like rows+columns to immediately follow instructions,
but I'll approve anyway and let you decide.

-------------

PR Review: https://git.openjdk.org/jdk/pull/18224#pullrequestreview-1935292499
PR Review Comment: https://git.openjdk.org/jdk/pull/18224#discussion_r1523967651

From prr at openjdk.org  Wed Mar 13 22:09:40 2024
From: prr at openjdk.org (Phil Race)
Date: Wed, 13 Mar 2024 22:09:40 GMT
Subject: RFR: 8327879: Convert javax/swing/border/Test4760089.java applet
 test to main [v2]
In-Reply-To: <md1FNnWLW56N0Ucpj-BSxyVKz1FXVcJjHo5_8_uzOV8=.9db4b144-5f94-47ba-b837-23a7c33f6e9f@github.com>
References: <Vq0kXwaE6TFmJzGmgpo13OA3VEqSnqsjQpDpGZj2ob4=.4f188f8b-5581-4774-8345-76363b4e3cf6@github.com>
 <md1FNnWLW56N0Ucpj-BSxyVKz1FXVcJjHo5_8_uzOV8=.9db4b144-5f94-47ba-b837-23a7c33f6e9f@github.com>
Message-ID: <m4RM-rvbILC6ecXOcjjnKbYiFeFvvdeIQdIWjfI57xA=.7613d7b9-c5b9-4b14-b77c-8de26b78fc1a@github.com>

On Tue, 12 Mar 2024 09:56:44 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Convert javax/swing/border/Test4760089.java applet test to main based test using PassFailJFrame.
>
> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review updates

test/jdk/javax/swing/border/Test4760089.java line 44:

> 42: public class Test4760089 {
> 43:     public static void main(String[] args) throws Exception {
> 44:         String testInstructions = """

You have lost the first part of the instructions.
It used to start with
"When applet starts, you'll see a panel with a compound titled border."

now this would be 
"When the test starts, ..."

Probably you'll need to add an extra row to the instructions.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18217#discussion_r1523969962

From prr at openjdk.org  Wed Mar 13 22:10:39 2024
From: prr at openjdk.org (Phil Race)
Date: Wed, 13 Mar 2024 22:10:39 GMT
Subject: RFR: 8327876: Convert javax/swing/border/Test4252164.java applet
 test to main
In-Reply-To: <Nc7KlfEEQnoms0Ja9qgzfbVjkrWbZXjkcfU1pL6XdU0=.6fa50ee3-8610-43b3-8b3f-913f40281a5e@github.com>
References: <Nc7KlfEEQnoms0Ja9qgzfbVjkrWbZXjkcfU1pL6XdU0=.6fa50ee3-8610-43b3-8b3f-913f40281a5e@github.com>
Message-ID: <w6Wv6CE3sh-_eD14euiho0fg1Ynpr_s6msTdNOlVKVQ=.cd4adc10-0842-4dbd-b69a-57e06561625d@github.com>

On Tue, 12 Mar 2024 06:56:20 GMT, Tejesh R <tr at openjdk.org> wrote:

> Convert javax/swing/border/Test4252164.java applet test to main based test using PassFailJFrame.

Marked as reviewed by prr (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18216#pullrequestreview-1935297637

From achung at openjdk.org  Wed Mar 13 22:11:53 2024
From: achung at openjdk.org (Alisen Chung)
Date: Wed, 13 Mar 2024 22:11:53 GMT
Subject: RFR: 8327857: Remove applet usage from JColorChooser tests
 Test4222508 [v3]
In-Reply-To: <k-sLqO64HbTaYgimerOjfrS6NdPEYkOW4Wh9u-ln1P4=.fcb4e582-2189-4486-afb4-570cdeed6e69@github.com>
References: <k-sLqO64HbTaYgimerOjfrS6NdPEYkOW4Wh9u-ln1P4=.fcb4e582-2189-4486-afb4-570cdeed6e69@github.com>
Message-ID: <AVTVqaZSWMNinhbz4V6527yU2tS35xIeI4xNoaurmBA=.c6472a7e-ce5c-4509-8cac-585f23f5e3ce@github.com>

> Removing applet usage from manual JColorChooser tests

Alisen Chung has updated the pull request incrementally with two additional commits since the last revision:

 - fix spacing
 - fix instructions, add frame title, jtreg tag fix, spacing fix, add to frame without contentpane

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18209/files
  - new: https://git.openjdk.org/jdk/pull/18209/files/0c45d1cc..a3741361

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18209&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18209&range=01-02

  Stats: 8 lines in 1 file changed: 1 ins; 0 del; 7 mod
  Patch: https://git.openjdk.org/jdk/pull/18209.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18209/head:pull/18209

PR: https://git.openjdk.org/jdk/pull/18209

From prr at openjdk.org  Wed Mar 13 22:15:39 2024
From: prr at openjdk.org (Phil Race)
Date: Wed, 13 Mar 2024 22:15:39 GMT
Subject: RFR: 8327874: Convert javax/swing/JTree/4314199/bug4314199.java
 applet test to main [v2]
In-Reply-To: <fkPnsJhSLbXmHNeZSo3pjcJZRAiwhSOjyraO8R7iXN4=.54918c80-5210-4bcd-bd67-a1832390ebbc@github.com>
References: <4HQ5z1My4A9Qcac-1K9Y9sTf7dqWpxrJtdIgSxC1vro=.41a923c6-8607-4c95-8c6f-8a6c5ed1504f@github.com>
 <fkPnsJhSLbXmHNeZSo3pjcJZRAiwhSOjyraO8R7iXN4=.54918c80-5210-4bcd-bd67-a1832390ebbc@github.com>
Message-ID: <BfUzLFXARaRpa6WRmW-A3egJnpyzG2xsGOtrHCPAz5Q=.6573796a-9c8d-4b15-9cbf-4837b8c4195f@github.com>

On Wed, 13 Mar 2024 05:19:32 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Conversion of manual applet test to main based using PassFailJFrame manual framework
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review comment update

Marked as reviewed by prr (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18215#pullrequestreview-1935302238

From achung at openjdk.org  Wed Mar 13 22:16:49 2024
From: achung at openjdk.org (Alisen Chung)
Date: Wed, 13 Mar 2024 22:16:49 GMT
Subject: RFR: 8327859: Remove applet usage from JColorChooser tests
 Test4319113 [v3]
In-Reply-To: <mzB8yqtVTWIuecXJk5qt1J5Me6iU857a4YMC26xXiyg=.b8fc4e43-3298-4f5c-ab52-8664d30c2d08@github.com>
References: <mzB8yqtVTWIuecXJk5qt1J5Me6iU857a4YMC26xXiyg=.b8fc4e43-3298-4f5c-ab52-8664d30c2d08@github.com>
Message-ID: <NqogjbSZ-TZlzZYzyGKYTiXTdJXuCRPJU5wNaYDvNGk=.a4833fe2-58d5-4d12-9363-7ec2b6659414@github.com>

> Removing applet usage from manual JColorChooser tests

Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:

  fix jtreg tag, spacing, frame title

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18210/files
  - new: https://git.openjdk.org/jdk/pull/18210/files/b720007d..a6aed520

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18210&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18210&range=01-02

  Stats: 10 lines in 1 file changed: 5 ins; 2 del; 3 mod
  Patch: https://git.openjdk.org/jdk/pull/18210.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18210/head:pull/18210

PR: https://git.openjdk.org/jdk/pull/18210

From prr at openjdk.org  Wed Mar 13 22:17:41 2024
From: prr at openjdk.org (Phil Race)
Date: Wed, 13 Mar 2024 22:17:41 GMT
Subject: RFR: 8327873: Convert javax/swing/border/Test4247606.java applet
 test to main [v3]
In-Reply-To: <Kpj8ZEwW-6xNC2kfb5JOknRvpsP6zDVZuS8k3K4pFwQ=.ba2fe6e3-dd7f-4820-aa6c-47005c87db62@github.com>
References: <wHX-Mo2XWPKls-WPhv6L7m1xdtKWQF40Nr-U9rjGxqw=.7f21fa24-8bc3-4c36-8132-408fe1372e60@github.com>
 <Kpj8ZEwW-6xNC2kfb5JOknRvpsP6zDVZuS8k3K4pFwQ=.ba2fe6e3-dd7f-4820-aa6c-47005c87db62@github.com>
Message-ID: <7IPLj5l-qCrI1rEjFg3p-_Bsczu_MYKvPb7O2ZRIeyI=.3d1c405b-456c-4482-9852-182b602d5e4e@github.com>

On Wed, 13 Mar 2024 05:00:35 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Convert javax/swing/border/Test4247606.java applet test to main based test using PassFailJFrame.
>
> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review updates

Marked as reviewed by prr (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18213#pullrequestreview-1935306434

From achung at openjdk.org  Wed Mar 13 22:17:51 2024
From: achung at openjdk.org (Alisen Chung)
Date: Wed, 13 Mar 2024 22:17:51 GMT
Subject: RFR: 8328121: Remove applet usage from JColorChooser tests
 Test4759306 [v2]
In-Reply-To: <C8wP7UJKyxmliTDxZ5YYEZS4TcPytfHn86fCL_zTI3o=.8fa88a3e-1156-4f66-b6d8-00c182299d66@github.com>
References: <C8wP7UJKyxmliTDxZ5YYEZS4TcPytfHn86fCL_zTI3o=.8fa88a3e-1156-4f66-b6d8-00c182299d66@github.com>
Message-ID: <FjRW5NM2BRs-fU6axbRtC4eiFIG_cXxphZhO1eOmlR4=.23b077d4-888b-4dd8-a3d2-de0dca75505b@github.com>

> Removing applet usage from manual JColorChooser tests

Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:

  fix jtreg tag

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18286/files
  - new: https://git.openjdk.org/jdk/pull/18286/files/cf1fa65a..ac4cb4b1

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18286&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18286&range=00-01

  Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/18286.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18286/head:pull/18286

PR: https://git.openjdk.org/jdk/pull/18286

From achung at openjdk.org  Wed Mar 13 22:18:00 2024
From: achung at openjdk.org (Alisen Chung)
Date: Wed, 13 Mar 2024 22:18:00 GMT
Subject: RFR: 8327857: Remove applet usage from JColorChooser tests
 Test4222508 [v4]
In-Reply-To: <k-sLqO64HbTaYgimerOjfrS6NdPEYkOW4Wh9u-ln1P4=.fcb4e582-2189-4486-afb4-570cdeed6e69@github.com>
References: <k-sLqO64HbTaYgimerOjfrS6NdPEYkOW4Wh9u-ln1P4=.fcb4e582-2189-4486-afb4-570cdeed6e69@github.com>
Message-ID: <Bi1taUI2KyGz0W7ijWPWNht63FitUwOgs8jhgQqWGH8=.98b0c924-ed79-444f-b359-e296eadcf7aa@github.com>

> Removing applet usage from manual JColorChooser tests

Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:

  move instructions string outside

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18209/files
  - new: https://git.openjdk.org/jdk/pull/18209/files/a3741361..74c34ada

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18209&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18209&range=02-03

  Stats: 9 lines in 1 file changed: 5 ins; 3 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/18209.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18209/head:pull/18209

PR: https://git.openjdk.org/jdk/pull/18209

From azvegint at openjdk.org  Wed Mar 13 22:17:52 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Wed, 13 Mar 2024 22:17:52 GMT
Subject: RFR: 8328121: Remove applet usage from JColorChooser tests
 Test4759306 [v2]
In-Reply-To: <FjRW5NM2BRs-fU6axbRtC4eiFIG_cXxphZhO1eOmlR4=.23b077d4-888b-4dd8-a3d2-de0dca75505b@github.com>
References: <C8wP7UJKyxmliTDxZ5YYEZS4TcPytfHn86fCL_zTI3o=.8fa88a3e-1156-4f66-b6d8-00c182299d66@github.com>
 <FjRW5NM2BRs-fU6axbRtC4eiFIG_cXxphZhO1eOmlR4=.23b077d4-888b-4dd8-a3d2-de0dca75505b@github.com>
Message-ID: <antnRpNa9xbmavDrK_9A65MVC0rAL7dgEd5VBL4kfds=.f7d08d71-9d7e-4582-ad2d-8a2bd7f69cea@github.com>

On Wed, 13 Mar 2024 22:15:16 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> Removing applet usage from manual JColorChooser tests
>
> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fix jtreg tag

test/jdk/javax/swing/JColorChooser/Test4759306.java line 40:

> 38:         PassFailJFrame.builder()
> 39:                 .title("Test4759306")
> 40:                 .instructions("Check that there is no preview panel in the JColorChooser.")

> Check that there is no preview panel

For a tester who didn't use JColorChooser before this can be confusing

It might be worth describing where to look for the Preview panel and what it looks like(e.g. `Check that there is no panel titled "Preview"` or similar)

test/jdk/javax/swing/JColorChooser/Test4759306.java line 44:

> 42:                 .columns(40)
> 43:                 .testTimeOut(10)
> 44:                 .testUI(Test4759306::test)

Actually, we don't need to create a separate window for this, we can place the color chooser in the intruction window by using something like 
`.splitUIRight(Test4759306::createColorChooser)`


private static JColorChooser createColorChooser() {
    JColorChooser chooser = new JColorChooser();
    chooser.setPreviewPanel(new JPanel());
    return chooser;
}

test/jdk/javax/swing/JColorChooser/Test4759306.java line 49:

> 47:     }
> 48: 
> 49:     private static JFrame test() {

Probably a more meaningful name would be welcome.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18286#discussion_r1523852885
PR Review Comment: https://git.openjdk.org/jdk/pull/18286#discussion_r1523848100
PR Review Comment: https://git.openjdk.org/jdk/pull/18286#discussion_r1523848026

From achung at openjdk.org  Wed Mar 13 22:20:51 2024
From: achung at openjdk.org (Alisen Chung)
Date: Wed, 13 Mar 2024 22:20:51 GMT
Subject: RFR: 8328130: Remove applet usage from JColorChooser tests
 Test4759934 [v2]
In-Reply-To: <V5jXFcSvoonQJFoR7h-oRHEL9JLd6Pz5J1gzv2DJVH0=.aa6c1453-59fc-41ed-bfa9-af86f2d52a1f@github.com>
References: <V5jXFcSvoonQJFoR7h-oRHEL9JLd6Pz5J1gzv2DJVH0=.aa6c1453-59fc-41ed-bfa9-af86f2d52a1f@github.com>
Message-ID: <4L0-dpdqb-GfmafzCu1u4K68bWjlYQKJ1JCLI0buyC0=.fccc9641-cf44-423d-9636-1ad5f6e4a1dd@github.com>

> Removing applet usage from manual JColorChooser tests

Alisen Chung has updated the pull request incrementally with two additional commits since the last revision:

 - move jtreg tag above class
 - fix jtreg tag, move instructions string outside

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18288/files
  - new: https://git.openjdk.org/jdk/pull/18288/files/88b40d55..f0546b5f

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18288&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18288&range=00-01

  Stats: 22 lines in 1 file changed: 11 ins; 10 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/18288.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18288/head:pull/18288

PR: https://git.openjdk.org/jdk/pull/18288

From achung at openjdk.org  Wed Mar 13 22:23:51 2024
From: achung at openjdk.org (Alisen Chung)
Date: Wed, 13 Mar 2024 22:23:51 GMT
Subject: RFR: 8328121: Remove applet usage from JColorChooser tests
 Test4759306 [v3]
In-Reply-To: <C8wP7UJKyxmliTDxZ5YYEZS4TcPytfHn86fCL_zTI3o=.8fa88a3e-1156-4f66-b6d8-00c182299d66@github.com>
References: <C8wP7UJKyxmliTDxZ5YYEZS4TcPytfHn86fCL_zTI3o=.8fa88a3e-1156-4f66-b6d8-00c182299d66@github.com>
Message-ID: <Fv7MFC8GNOappT9_Kk2RsW4_PMK8mc2xipvmyQ_QM0c=.593e8483-c4a6-482d-9156-d21dd45f189e@github.com>

> Removing applet usage from manual JColorChooser tests

Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:

  absolute path jtreg tag

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18286/files
  - new: https://git.openjdk.org/jdk/pull/18286/files/ac4cb4b1..5b1d20e6

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18286&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18286&range=01-02

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/18286.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18286/head:pull/18286

PR: https://git.openjdk.org/jdk/pull/18286

From achung at openjdk.org  Wed Mar 13 22:24:03 2024
From: achung at openjdk.org (Alisen Chung)
Date: Wed, 13 Mar 2024 22:24:03 GMT
Subject: RFR: 8327857: Remove applet usage from JColorChooser tests
 Test4222508 [v5]
In-Reply-To: <k-sLqO64HbTaYgimerOjfrS6NdPEYkOW4Wh9u-ln1P4=.fcb4e582-2189-4486-afb4-570cdeed6e69@github.com>
References: <k-sLqO64HbTaYgimerOjfrS6NdPEYkOW4Wh9u-ln1P4=.fcb4e582-2189-4486-afb4-570cdeed6e69@github.com>
Message-ID: <Ry42nY0jCekYQLoktQpicrUuCFoPn1DU51a3TB2rKZw=.c2a72b14-ed09-4fa5-807c-87b75662fc25@github.com>

> Removing applet usage from manual JColorChooser tests

Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:

  relative path

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18209/files
  - new: https://git.openjdk.org/jdk/pull/18209/files/74c34ada..071f1713

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18209&range=04
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18209&range=03-04

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/18209.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18209/head:pull/18209

PR: https://git.openjdk.org/jdk/pull/18209

From prr at openjdk.org  Wed Mar 13 22:24:03 2024
From: prr at openjdk.org (Phil Race)
Date: Wed, 13 Mar 2024 22:24:03 GMT
Subject: RFR: 8327857: Remove applet usage from JColorChooser tests
 Test4222508 [v4]
In-Reply-To: <Bi1taUI2KyGz0W7ijWPWNht63FitUwOgs8jhgQqWGH8=.98b0c924-ed79-444f-b359-e296eadcf7aa@github.com>
References: <k-sLqO64HbTaYgimerOjfrS6NdPEYkOW4Wh9u-ln1P4=.fcb4e582-2189-4486-afb4-570cdeed6e69@github.com>
 <Bi1taUI2KyGz0W7ijWPWNht63FitUwOgs8jhgQqWGH8=.98b0c924-ed79-444f-b359-e296eadcf7aa@github.com>
Message-ID: <nnoR8xR7YSpEukci3LzY0Lb4AIzJ8UKy5Vmb6VDvyOI=.27b73def-ae36-43cf-9692-82b8c93570a3@github.com>

On Wed, 13 Mar 2024 22:18:00 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> Removing applet usage from manual JColorChooser tests
>
> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   move instructions string outside

test/jdk/javax/swing/JColorChooser/Test4222508.java line 32:

> 30:  * @test
> 31:  * @bug 4222508
> 32:  * @library ../../../java/awt/regtesthelpers

make it absolute not relative, ie /java/awt/regtesthelpers

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18209#discussion_r1523978352

From achung at openjdk.org  Wed Mar 13 22:24:50 2024
From: achung at openjdk.org (Alisen Chung)
Date: Wed, 13 Mar 2024 22:24:50 GMT
Subject: RFR: 8328130: Remove applet usage from JColorChooser tests
 Test4759934 [v3]
In-Reply-To: <V5jXFcSvoonQJFoR7h-oRHEL9JLd6Pz5J1gzv2DJVH0=.aa6c1453-59fc-41ed-bfa9-af86f2d52a1f@github.com>
References: <V5jXFcSvoonQJFoR7h-oRHEL9JLd6Pz5J1gzv2DJVH0=.aa6c1453-59fc-41ed-bfa9-af86f2d52a1f@github.com>
Message-ID: <DO3VeZYdc97HfTH61bzAId0CSCXPuLT1Q486RW-2wCQ=.d0bd9b79-2f1e-4936-ab34-ee6526f33c80@github.com>

> Removing applet usage from manual JColorChooser tests

Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:

  absolute path jtreg tag

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18288/files
  - new: https://git.openjdk.org/jdk/pull/18288/files/f0546b5f..f7121e6d

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18288&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18288&range=01-02

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/18288.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18288/head:pull/18288

PR: https://git.openjdk.org/jdk/pull/18288

From achung at openjdk.org  Wed Mar 13 22:24:59 2024
From: achung at openjdk.org (Alisen Chung)
Date: Wed, 13 Mar 2024 22:24:59 GMT
Subject: RFR: 8327859: Remove applet usage from JColorChooser tests
 Test4319113 [v4]
In-Reply-To: <mzB8yqtVTWIuecXJk5qt1J5Me6iU857a4YMC26xXiyg=.b8fc4e43-3298-4f5c-ab52-8664d30c2d08@github.com>
References: <mzB8yqtVTWIuecXJk5qt1J5Me6iU857a4YMC26xXiyg=.b8fc4e43-3298-4f5c-ab52-8664d30c2d08@github.com>
Message-ID: <muH7Blej8GsQWNvdKa7jHdnlOYP1c-BVQlBakJy03qg=.44b38474-e38d-4cfd-ad61-a5e5d13208f2@github.com>

> Removing applet usage from manual JColorChooser tests

Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:

  absolute path jtreg tag

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18210/files
  - new: https://git.openjdk.org/jdk/pull/18210/files/a6aed520..ee09aec5

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18210&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18210&range=02-03

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/18210.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18210/head:pull/18210

PR: https://git.openjdk.org/jdk/pull/18210

From prr at openjdk.org  Wed Mar 13 22:24:59 2024
From: prr at openjdk.org (Phil Race)
Date: Wed, 13 Mar 2024 22:24:59 GMT
Subject: RFR: 8327859: Remove applet usage from JColorChooser tests
 Test4319113 [v3]
In-Reply-To: <NqogjbSZ-TZlzZYzyGKYTiXTdJXuCRPJU5wNaYDvNGk=.a4833fe2-58d5-4d12-9363-7ec2b6659414@github.com>
References: <mzB8yqtVTWIuecXJk5qt1J5Me6iU857a4YMC26xXiyg=.b8fc4e43-3298-4f5c-ab52-8664d30c2d08@github.com>
 <NqogjbSZ-TZlzZYzyGKYTiXTdJXuCRPJU5wNaYDvNGk=.a4833fe2-58d5-4d12-9363-7ec2b6659414@github.com>
Message-ID: <54DcF5KmPhyYVAlbw9IrlDjSrjEumf0532gFlGfuq_g=.e7d7ef7f-e4a3-4129-9db0-9282c676b811@github.com>

On Wed, 13 Mar 2024 22:16:49 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> Removing applet usage from manual JColorChooser tests
>
> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fix jtreg tag, spacing, frame title

test/jdk/javax/swing/JColorChooser/Test4319113.java line 44:

> 42:  * @test
> 43:  * @bug 4319113
> 44:  * @library ../../../java/awt/regtesthelpers

absolute please

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18210#discussion_r1523979003

From achung at openjdk.org  Wed Mar 13 22:37:49 2024
From: achung at openjdk.org (Alisen Chung)
Date: Wed, 13 Mar 2024 22:37:49 GMT
Subject: RFR: 8327859: Remove applet usage from JColorChooser tests
 Test4319113 [v5]
In-Reply-To: <mzB8yqtVTWIuecXJk5qt1J5Me6iU857a4YMC26xXiyg=.b8fc4e43-3298-4f5c-ab52-8664d30c2d08@github.com>
References: <mzB8yqtVTWIuecXJk5qt1J5Me6iU857a4YMC26xXiyg=.b8fc4e43-3298-4f5c-ab52-8664d30c2d08@github.com>
Message-ID: <PUVMZijAuCSfsboAkxw402dd60tNEDc4vFlOJe--KB4=.2370c92c-ff99-4a65-a299-50025b937d0a@github.com>

> Removing applet usage from manual JColorChooser tests

Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:

  use old instructions string

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18210/files
  - new: https://git.openjdk.org/jdk/pull/18210/files/ee09aec5..3e28310a

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18210&range=04
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18210&range=03-04

  Stats: 9 lines in 1 file changed: 6 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/jdk/pull/18210.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18210/head:pull/18210

PR: https://git.openjdk.org/jdk/pull/18210

From achung at openjdk.org  Wed Mar 13 22:41:49 2024
From: achung at openjdk.org (Alisen Chung)
Date: Wed, 13 Mar 2024 22:41:49 GMT
Subject: RFR: 8328130: Remove applet usage from JColorChooser tests
 Test4759934 [v4]
In-Reply-To: <V5jXFcSvoonQJFoR7h-oRHEL9JLd6Pz5J1gzv2DJVH0=.aa6c1453-59fc-41ed-bfa9-af86f2d52a1f@github.com>
References: <V5jXFcSvoonQJFoR7h-oRHEL9JLd6Pz5J1gzv2DJVH0=.aa6c1453-59fc-41ed-bfa9-af86f2d52a1f@github.com>
Message-ID: <P_zoBukhydIUXPzG4zstUIsjPXdS5LBfXXpEEyfUPjk=.c5c40e8f-5220-43e5-be3f-3a56e85d1d9f@github.com>

> Removing applet usage from manual JColorChooser tests

Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:

  use old instructions string, give frame title

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18288/files
  - new: https://git.openjdk.org/jdk/pull/18288/files/f7121e6d..e3cc9a4c

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18288&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18288&range=02-03

  Stats: 8 lines in 1 file changed: 5 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/jdk/pull/18288.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18288/head:pull/18288

PR: https://git.openjdk.org/jdk/pull/18288

From achung at openjdk.org  Wed Mar 13 22:45:50 2024
From: achung at openjdk.org (Alisen Chung)
Date: Wed, 13 Mar 2024 22:45:50 GMT
Subject: RFR: 8328121: Remove applet usage from JColorChooser tests
 Test4759306 [v4]
In-Reply-To: <C8wP7UJKyxmliTDxZ5YYEZS4TcPytfHn86fCL_zTI3o=.8fa88a3e-1156-4f66-b6d8-00c182299d66@github.com>
References: <C8wP7UJKyxmliTDxZ5YYEZS4TcPytfHn86fCL_zTI3o=.8fa88a3e-1156-4f66-b6d8-00c182299d66@github.com>
Message-ID: <RmLPhp_Ewp6EFol8XsdWfiuk0eHap1lPxOu28Oj4Ppk=.ab3e44ad-37ad-4bc7-9825-f7e6d64ca455@github.com>

> Removing applet usage from manual JColorChooser tests

Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:

  update instructions string, remove extra frame

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18286/files
  - new: https://git.openjdk.org/jdk/pull/18286/files/5b1d20e6..464822ca

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18286&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18286&range=02-03

  Stats: 7 lines in 1 file changed: 0 ins; 3 del; 4 mod
  Patch: https://git.openjdk.org/jdk/pull/18286.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18286/head:pull/18286

PR: https://git.openjdk.org/jdk/pull/18286

From azvegint at openjdk.org  Wed Mar 13 23:16:37 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Wed, 13 Mar 2024 23:16:37 GMT
Subject: RFR: 8328121: Remove applet usage from JColorChooser tests
 Test4759306 [v4]
In-Reply-To: <RmLPhp_Ewp6EFol8XsdWfiuk0eHap1lPxOu28Oj4Ppk=.ab3e44ad-37ad-4bc7-9825-f7e6d64ca455@github.com>
References: <C8wP7UJKyxmliTDxZ5YYEZS4TcPytfHn86fCL_zTI3o=.8fa88a3e-1156-4f66-b6d8-00c182299d66@github.com>
 <RmLPhp_Ewp6EFol8XsdWfiuk0eHap1lPxOu28Oj4Ppk=.ab3e44ad-37ad-4bc7-9825-f7e6d64ca455@github.com>
Message-ID: <3hFz99_hlPEVXUtDdCIwtuK3VaZL3Bw2mjuzzcOjhvo=.42879da2-9ea0-408b-ac12-7d0a074d3e22@github.com>

On Wed, 13 Mar 2024 22:45:50 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> Removing applet usage from manual JColorChooser tests
>
> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   update instructions string, remove extra frame

Marked as reviewed by azvegint (Reviewer).

test/jdk/javax/swing/JColorChooser/Test4759306.java line 25:

> 23: 
> 24: import javax.swing.JColorChooser;
> 25: import javax.swing.JFrame;

JFrame is no longer used.

-------------

PR Review: https://git.openjdk.org/jdk/pull/18286#pullrequestreview-1935376276
PR Review Comment: https://git.openjdk.org/jdk/pull/18286#discussion_r1524018757

From prr at openjdk.org  Wed Mar 13 23:45:38 2024
From: prr at openjdk.org (Phil Race)
Date: Wed, 13 Mar 2024 23:45:38 GMT
Subject: RFR: 8327857: Remove applet usage from JColorChooser tests
 Test4222508 [v5]
In-Reply-To: <Ry42nY0jCekYQLoktQpicrUuCFoPn1DU51a3TB2rKZw=.c2a72b14-ed09-4fa5-807c-87b75662fc25@github.com>
References: <k-sLqO64HbTaYgimerOjfrS6NdPEYkOW4Wh9u-ln1P4=.fcb4e582-2189-4486-afb4-570cdeed6e69@github.com>
 <Ry42nY0jCekYQLoktQpicrUuCFoPn1DU51a3TB2rKZw=.c2a72b14-ed09-4fa5-807c-87b75662fc25@github.com>
Message-ID: <h77UQMUXCLLM2nilf5OzAm7U696eCImMIAoTLE65KOM=.8a86627c-a0d7-4fe9-8f30-ef939e9f8ff4@github.com>

On Wed, 13 Mar 2024 22:24:03 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> Removing applet usage from manual JColorChooser tests
>
> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   relative path

Marked as reviewed by prr (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18209#pullrequestreview-1935403663

From prr at openjdk.org  Wed Mar 13 23:48:38 2024
From: prr at openjdk.org (Phil Race)
Date: Wed, 13 Mar 2024 23:48:38 GMT
Subject: RFR: 8328130: Remove applet usage from JColorChooser tests
 Test4759934 [v4]
In-Reply-To: <P_zoBukhydIUXPzG4zstUIsjPXdS5LBfXXpEEyfUPjk=.c5c40e8f-5220-43e5-be3f-3a56e85d1d9f@github.com>
References: <V5jXFcSvoonQJFoR7h-oRHEL9JLd6Pz5J1gzv2DJVH0=.aa6c1453-59fc-41ed-bfa9-af86f2d52a1f@github.com>
 <P_zoBukhydIUXPzG4zstUIsjPXdS5LBfXXpEEyfUPjk=.c5c40e8f-5220-43e5-be3f-3a56e85d1d9f@github.com>
Message-ID: <AAJ10NjAB34fAZiZP_llcBcqJYiPeg_ewDbne3ZQ59E=.def79742-abed-4f62-9876-c3f35965f786@github.com>

On Wed, 13 Mar 2024 22:41:49 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> Removing applet usage from manual JColorChooser tests
>
> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   use old instructions string, give frame title

Marked as reviewed by prr (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18288#pullrequestreview-1935406241

From prr at openjdk.org  Wed Mar 13 23:50:44 2024
From: prr at openjdk.org (Phil Race)
Date: Wed, 13 Mar 2024 23:50:44 GMT
Subject: Integrated: 8328004: Minor updates to TrayIcon test
 DisposeInActionEventTest.java
In-Reply-To: <4Zq2gsAshsqM3HxMV4jxpgm25WDx40QRJ-EuBMVaAfQ=.f96fc9c2-ad2f-4026-9d9e-74d7444bb3fb@github.com>
References: <4Zq2gsAshsqM3HxMV4jxpgm25WDx40QRJ-EuBMVaAfQ=.f96fc9c2-ad2f-4026-9d9e-74d7444bb3fb@github.com>
Message-ID: <FQTZHRoivS7sB5gD5qSLa5NWuvaAuybLCCUsqunlu8U=.5398a89c-d493-43ed-840c-9cebe58083b1@github.com>

On Tue, 12 Mar 2024 18:49:03 GMT, Phil Race <prr at openjdk.org> wrote:

> This was recently converted from a manual Applet to a PassFailJFrame main program
> But I see a few things that could be tweaked
>  - Clarify instructions
>  -  Set path to PassFailJFrame
>  - reduce timeout to default
>  - eliminate redundant folder

This pull request has now been integrated.

Changeset: 2edf4081
Author:    Phil Race <prr at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/2edf4081af727c197c0f158beb4b392bb4e70318
Stats:     263 lines in 2 files changed: 132 ins; 131 del; 0 mod

8328004: Minor updates to TrayIcon test DisposeInActionEventTest.java

Reviewed-by: azvegint

-------------

PR: https://git.openjdk.org/jdk/pull/18246

From prr at openjdk.org  Thu Mar 14 00:01:40 2024
From: prr at openjdk.org (Phil Race)
Date: Thu, 14 Mar 2024 00:01:40 GMT
Subject: RFR: 8327859: Remove applet usage from JColorChooser tests
 Test4319113 [v5]
In-Reply-To: <PUVMZijAuCSfsboAkxw402dd60tNEDc4vFlOJe--KB4=.2370c92c-ff99-4a65-a299-50025b937d0a@github.com>
References: <mzB8yqtVTWIuecXJk5qt1J5Me6iU857a4YMC26xXiyg=.b8fc4e43-3298-4f5c-ab52-8664d30c2d08@github.com>
 <PUVMZijAuCSfsboAkxw402dd60tNEDc4vFlOJe--KB4=.2370c92c-ff99-4a65-a299-50025b937d0a@github.com>
Message-ID: <VCnE9z9sATaAMFrVheAbuZuvW0lEUkMDnBCySnhUNkM=.e8684fcc-f111-422b-a678-6cd1976d6af1@github.com>

On Wed, 13 Mar 2024 22:37:49 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> Removing applet usage from manual JColorChooser tests
>
> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   use old instructions string

Marked as reviewed by prr (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18210#pullrequestreview-1935415667

From prr at openjdk.org  Thu Mar 14 00:16:37 2024
From: prr at openjdk.org (Phil Race)
Date: Thu, 14 Mar 2024 00:16:37 GMT
Subject: RFR: 8327753: Convert
 javax/swing/JOptionPane/8024926/bug8024926.java applet to main [v2]
In-Reply-To: <XvhjkzvZ6qLmp2eWL1iF1ztfTRgGe4aZGUZ0epXBV2w=.654067f3-1f2b-429b-9656-2360600e09f9@github.com>
References: <Mh1aFrqe1Kw2tD_2nNzeAoMRhSWzNoh67d-2yTqoIPE=.e8e324d4-f0fa-4b41-b2ea-39cc18faf088@github.com>
 <XvhjkzvZ6qLmp2eWL1iF1ztfTRgGe4aZGUZ0epXBV2w=.654067f3-1f2b-429b-9656-2360600e09f9@github.com>
Message-ID: <u0uEC796QEPn1GjCQch_rIoFy1AdzXSFfmI23JzcnSk=.294afecd-eb63-4652-be66-4c569b1014eb@github.com>

On Wed, 13 Mar 2024 05:21:32 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Conversion of manual applet test to main based using PassFailJFrame manual framework
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove redundant dir

Marked as reviewed by prr (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18232#pullrequestreview-1935426664

From prr at openjdk.org  Thu Mar 14 00:16:38 2024
From: prr at openjdk.org (Phil Race)
Date: Thu, 14 Mar 2024 00:16:38 GMT
Subject: RFR: 8327753: Convert
 javax/swing/JOptionPane/8024926/bug8024926.java applet to main [v2]
In-Reply-To: <9Uu4kiGuYNcEHM6uzMpskhFqrpZiCJ0tsS3SI2rp-Aw=.76da1624-7b98-4ac7-9cac-5bc899ab7dc7@github.com>
References: <Mh1aFrqe1Kw2tD_2nNzeAoMRhSWzNoh67d-2yTqoIPE=.e8e324d4-f0fa-4b41-b2ea-39cc18faf088@github.com>
 <XvhjkzvZ6qLmp2eWL1iF1ztfTRgGe4aZGUZ0epXBV2w=.654067f3-1f2b-429b-9656-2360600e09f9@github.com>
 <W9FX6uDmrG2exwdtiAs4sq8AP_RFqX876RyDcaPbbTA=.3162b12b-db3d-4db5-b63b-faf8926f5696@github.com>
 <9Uu4kiGuYNcEHM6uzMpskhFqrpZiCJ0tsS3SI2rp-Aw=.76da1624-7b98-4ac7-9cac-5bc899ab7dc7@github.com>
Message-ID: <D4-LFQ-ttJeI_2dE323LO3tcibTwLj_EPPSqM4vzjzk=.095637be-2c08-4f02-a727-a677c5622d83@github.com>

On Wed, 13 Mar 2024 07:54:12 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> test/jdk/javax/swing/JOptionPane/bug8024926.java line 46:
>> 
>>> 44:                 Verify that high resolution system icons are used
>>> 45:                  in JOptionPane on HiDPI displays.
>>> 46:                 1) Run the test on Retina display or enable the Quartz Debug
>> 
>> Quartz debug ? How ? And we don't even use Quartz.
>> The pass criteria is completely subjective. 
>> So this test looks like it needs to be better.
>> If you can't figure out a better test for this in less than a day just delete this useless thing.
>
> I can remove the "Quartz debug" portion if it is not applicable, but as you know, it's a straight lift from the existing instructions...The reviewer that time did not object to this phrase it seems (was it used that time and subsequently revoked later?)
> https://hg.openjdk.org/jdk9/jdk9/jdk/rev/4991a758abef
> 
> Also, the product fix has another test `test/javax/swing/JMenuItem/8031573/bug8031573.java`	which also put the same pass criteria that icons should be smooth and our manual testing team has not made any objections to the instructions of both test it seems..

It looks like Quartz is still used in some native image handling code.
OK. If the instruction is harmless let it stay, but I doubt anyone does that.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18232#discussion_r1524053294

From honkar at openjdk.org  Thu Mar 14 00:29:42 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Thu, 14 Mar 2024 00:29:42 GMT
Subject: RFR: 8328021: Convert applet test
 java/awt/List/SetFontTest/SetFontTest.html to main program
In-Reply-To: <PDXY83ODTZ4gxjrMQMJIoLyXeDHkkHJBbsoMVKwL5bQ=.ba1001ce-1197-4ea8-b9c7-bee0605dbf83@github.com>
References: <PDXY83ODTZ4gxjrMQMJIoLyXeDHkkHJBbsoMVKwL5bQ=.ba1001ce-1197-4ea8-b9c7-bee0605dbf83@github.com>
Message-ID: <OunX7t4cLmm7bcpooHtypgxdS2Fcsscc0dR2dtKrCjA=.efff622d-bd6c-4583-a4eb-c32bcf3173cf@github.com>

On Tue, 12 Mar 2024 22:55:02 GMT, Phil Race <prr at openjdk.org> wrote:

> java/awt/List/SetFontTest/SetFontTest.html is a manual applet-based test.
> It can be converted to a main program test using PassFailJFrame

Changes looks good, except for minor formatting issues.
Are we still considering on moving the tests one level up?

test/jdk/java/awt/List/SetFontTest.java line 55:

> 53:                        .instructions(INSTRUCTIONS)
> 54:                        .rows(10)
> 55:                        .columns(60)

Existing config looks too wide for the instructions.

Suggestion:

                       .columns(35)

test/jdk/java/awt/List/SetFontTest.java line 74:

> 72: 
> 73:         button1.addActionListener(
> 74:             new ActionListener(){

It can be shortened with lambda

-------------

Marked as reviewed by honkar (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18255#pullrequestreview-1935432555
PR Review Comment: https://git.openjdk.org/jdk/pull/18255#discussion_r1524057294
PR Review Comment: https://git.openjdk.org/jdk/pull/18255#discussion_r1524058068

From honkar at openjdk.org  Thu Mar 14 00:38:45 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Thu, 14 Mar 2024 00:38:45 GMT
Subject: RFR: 8328124: Convert java/awt/Frame/ShownOnPack/ShownOnPack.html
 applet test to main
In-Reply-To: <yC3Qtep10q3KRJrCfQv-ThrGmE7xdedwQjrr0dBMVMw=.9b87a76e-5af8-411e-bd31-dd8f390d6b24@github.com>
References: <yC3Qtep10q3KRJrCfQv-ThrGmE7xdedwQjrr0dBMVMw=.9b87a76e-5af8-411e-bd31-dd8f390d6b24@github.com>
Message-ID: <_F3q0PIGAuHIpqb9H4K9mNBpQCBOjgqPuRjrrmaBfNE=.e589f0a8-e92f-4f06-9119-ee7495daa9f4@github.com>

On Wed, 13 Mar 2024 19:43:10 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

> The test is converted to main.
> Tested on Linux, Macos and Windows.

Test changes look good.

-------------

Marked as reviewed by honkar (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18287#pullrequestreview-1935448738

From honkar at openjdk.org  Thu Mar 14 00:44:44 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Thu, 14 Mar 2024 00:44:44 GMT
Subject: RFR: 8328110: Allow simultaneous use of PassFailJFrame with split
 UI and additional windows
In-Reply-To: <eI8LV-JCDm0Y9cNYRO14jzecmYDY_Lh-ghiZXLsl3Uc=.9107f629-a355-456a-99ba-cb5e036b2fb4@github.com>
References: <eI8LV-JCDm0Y9cNYRO14jzecmYDY_Lh-ghiZXLsl3Uc=.9107f629-a355-456a-99ba-cb5e036b2fb4@github.com>
Message-ID: <WzyTQ00nefBrDjit2vaVVdmLATqFthbOOOF4GTaZYAE=.6ce4a75f-7434-493b-8eb4-623d8b1f4097@github.com>

On Wed, 13 Mar 2024 16:55:08 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

> It is currently blocked with an artificial check:
> 
> 
> if (panelCreator != null) {
>     if (splitUI && (testWindows != null || windowListCreator != null)) {
>         // TODO Is it required? We can support both
>         throw new IllegalStateException("Split UI is not allowed "
>                                         + "with additional windows");
>     }
> }
> 
> 
> We have a number of manual tests, which has some text area in the instruction window to print a feedback from the test to be evaluated by a tester.
> 
> Removing this check allows us to implement this.
> We can consider making a special methods for this later.
> 
> This is required for the #18250

Couple of similar tests can benefit by integrating this change of using testUI & splitUI in combination.

-------------

Marked as reviewed by honkar (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18281#pullrequestreview-1935452653

From honkar at openjdk.org  Thu Mar 14 00:46:44 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Thu, 14 Mar 2024 00:46:44 GMT
Subject: RFR: 8328011: Convert
 java/awt/Frame/GetBoundsResizeTest/GetBoundsResizeTest.java applet test to
 main [v2]
In-Reply-To: <iGZn3xUJydlyYaQzF9caPFD7t27h_ZyRCRmeKgirr-0=.70bc1dce-d6bb-410e-ad1a-58948aa92a4d@github.com>
References: <77msAoji3SrhXCIcFcOTndR5MCc5jsoomdQ9Udl0WeE=.893b27fe-2ba5-48d9-920f-aab38592b614@github.com>
 <9qtp_TZCirnTU3uMugjf4btFEirXuWK8UBSqWGQ-qRQ=.9fbc6b9e-51a7-44b3-84d5-1353edd0cdbd@github.com>
 <bayyKOGSoGiI5CAxGiO0PKSAvFWJQ6CuSCxNL4wkfkM=.207d7688-39b9-4d16-9785-5ee69e797272@github.com>
 <OSU_puPuNlJ9bi9p71APIMQNXx8cSx6mK_Q7wmxmyLo=.91932bd8-5789-4603-9b20-5ee2059bf831@github.com>
 <iGZn3xUJydlyYaQzF9caPFD7t27h_ZyRCRmeKgirr-0=.70bc1dce-d6bb-410e-ad1a-58948aa92a4d@github.com>
Message-ID: <L3EbJBE3lCPreA36y4qCL2T0cWmK8WX39pUsTl8QJAI=.2c713060-912d-4cdc-8c9a-65fc528c131b@github.com>

On Wed, 13 Mar 2024 18:26:49 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> The same applies to the following event handler.
>
> What can help to reduce the indentation is introducing a helper method. If it's still too long, store the result of formatting into a local variable and then append it to `textArea`. This can be done even in lambdas.

@aivanov-jdk oh I might have missed the chaining order. Thanks for catching it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18250#discussion_r1524070649

From honkar at openjdk.org  Thu Mar 14 01:04:43 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Thu, 14 Mar 2024 01:04:43 GMT
Subject: RFR: 8328087: Automate javax/swing/JTable/TAB/TAB.java applet test
 [v2]
In-Reply-To: <57vHBqQV5Hiqcr5Oaaj2A5-gwwi4r_QPFcDpqGGueK4=.28909cca-86f6-4c4a-a416-620d0d7052fd@github.com>
References: <MumC6TL2XcA5TmVgQXy8yIDFEqUD08b2dvCUyYu7Kd8=.5891ab36-873a-41f0-b22f-d2fc883c8734@github.com>
 <57vHBqQV5Hiqcr5Oaaj2A5-gwwi4r_QPFcDpqGGueK4=.28909cca-86f6-4c4a-a416-620d0d7052fd@github.com>
Message-ID: <UIgpUKGnMmGZUSYwpIoTo_38Sf1JoUR5cfkHoRJlM18=.5f78a9fa-ec07-4e84-83f5-cf6462d47e4a@github.com>

On Wed, 13 Mar 2024 13:37:32 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Conversion of manual applet test to automated test. CI testing is green. Link attached to JBS.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove commented code

Changes requested by honkar (Reviewer).

test/jdk/javax/swing/JTable/TAB.java line 56:

> 54:  */
> 55: 
> 56: public class TAB

Class name is in all-caps, `Tab` would be more appropriate.

test/jdk/javax/swing/JTable/TAB.java line 88:

> 86:             robot.mousePress(InputEvent.BUTTON1_DOWN_MASK);
> 87:             robot.mouseRelease(InputEvent.BUTTON1_DOWN_MASK);
> 88:             robot.delay(100);

Like the previous test since autoDelay() is set,  this delay can be reduced or removed completely.

test/jdk/javax/swing/JTable/TAB.java line 120:

> 118:     }
> 119: 
> 120:     static void createAndShowUI()

There are few places where boxing (Integer(), Boolean()) is not required and can be removed as part of clean up.

-------------

PR Review: https://git.openjdk.org/jdk/pull/18274#pullrequestreview-1935462874
PR Review Comment: https://git.openjdk.org/jdk/pull/18274#discussion_r1524079096
PR Review Comment: https://git.openjdk.org/jdk/pull/18274#discussion_r1524077589
PR Review Comment: https://git.openjdk.org/jdk/pull/18274#discussion_r1524076867

From kizune at openjdk.org  Thu Mar 14 01:15:45 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Thu, 14 Mar 2024 01:15:45 GMT
Subject: RFR: 8316388: Opensource five Swing component related regression
 tests [v3]
In-Reply-To: <lyqr03dS3RFZwQum85-sdTUI2flExMCQm9Dps70wX5w=.1e207aa6-34e2-48e5-866c-bc39eb8d479f@github.com>
References: <lyqr03dS3RFZwQum85-sdTUI2flExMCQm9Dps70wX5w=.1e207aa6-34e2-48e5-866c-bc39eb8d479f@github.com>
Message-ID: <8EQNKy3Uz6Lv16s6-hKGSSX7AtI9cVH3cB2UZwemte8=.12a3b862-f9b3-4ece-899e-650d622aef90@github.com>

> Cleaned up five more tests.
> 
> Continuation of https://github.com/openjdk/jdk/pull/18184
> 
> Unfortunately one of the commits rendered the whole PR invalid so i closed it and restarting it here.
> All comments from the previous review are addressed.

Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:

  Update test/jdk/javax/swing/JDesktopPane/bug4773378.java
  
  Co-authored-by: Alexey Ivanov <alexey.ivanov at oracle.com>

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18259/files
  - new: https://git.openjdk.org/jdk/pull/18259/files/de3acd64..fa83e095

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18259&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18259&range=01-02

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/18259.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18259/head:pull/18259

PR: https://git.openjdk.org/jdk/pull/18259

From psadhukhan at openjdk.org  Thu Mar 14 02:34:43 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Thu, 14 Mar 2024 02:34:43 GMT
Subject: Integrated: 8327752: Convert
 javax/swing/JOptionPane/4174551/bug4174551.java applet to main
In-Reply-To: <uEqsAwVSEu11kSzb6ccgfje4GyOGoZ4G0Wk59AYnvAI=.37029531-7173-4ea8-9ad7-3eb3dadde5a0@github.com>
References: <uEqsAwVSEu11kSzb6ccgfje4GyOGoZ4G0Wk59AYnvAI=.37029531-7173-4ea8-9ad7-3eb3dadde5a0@github.com>
Message-ID: <gpzWj4vuf3C9YyjvxDNZEfRLTJyp_Dx4Fcz_Z6pySxk=.67b47377-bc0a-44c0-8781-a88df87d34d3@github.com>

On Tue, 12 Mar 2024 11:09:28 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> Conversion of manual applet test to main based using PassFailJFrame manual framework

This pull request has now been integrated.

Changeset: 7858138a
Author:    Prasanta Sadhukhan <psadhukhan at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/7858138ad212bb4dec0b30e7235b72fe74cdb960
Stats:     166 lines in 3 files changed: 78 ins; 88 del; 0 mod

8327752: Convert javax/swing/JOptionPane/4174551/bug4174551.java applet to main

Reviewed-by: prr

-------------

PR: https://git.openjdk.org/jdk/pull/18228

From psadhukhan at openjdk.org  Thu Mar 14 02:41:49 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Thu, 14 Mar 2024 02:41:49 GMT
Subject: Integrated: 8327753: Convert
 javax/swing/JOptionPane/8024926/bug8024926.java applet to main
In-Reply-To: <Mh1aFrqe1Kw2tD_2nNzeAoMRhSWzNoh67d-2yTqoIPE=.e8e324d4-f0fa-4b41-b2ea-39cc18faf088@github.com>
References: <Mh1aFrqe1Kw2tD_2nNzeAoMRhSWzNoh67d-2yTqoIPE=.e8e324d4-f0fa-4b41-b2ea-39cc18faf088@github.com>
Message-ID: <PAq2fCSQ29ZNIiYrUT1nJhJnwakuWxeik4qJHGu9wuQ=.0e42a831-78c9-4239-ac5a-880015bf69e7@github.com>

On Tue, 12 Mar 2024 12:43:22 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> Conversion of manual applet test to main based using PassFailJFrame manual framework

This pull request has now been integrated.

Changeset: 092a7343
Author:    Prasanta Sadhukhan <psadhukhan at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/092a7343a45297e481f9facb3420b2e91af5699d
Stats:     315 lines in 3 files changed: 71 ins; 244 del; 0 mod

8327753: Convert javax/swing/JOptionPane/8024926/bug8024926.java applet to main

Reviewed-by: prr

-------------

PR: https://git.openjdk.org/jdk/pull/18232

From psadhukhan at openjdk.org  Thu Mar 14 02:53:44 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Thu, 14 Mar 2024 02:53:44 GMT
Subject: Integrated: 8327754: Convert
 javax/swing/JPopupMenu/7160604/bug7160604.java applet to main
In-Reply-To: <7frwXMi-bkKDX7Xw-pSh-AtGg7PcEdykdSmbvlVylhI=.9c9002c1-9c12-44ad-916a-f6c7dfd579ff@github.com>
References: <7frwXMi-bkKDX7Xw-pSh-AtGg7PcEdykdSmbvlVylhI=.9c9002c1-9c12-44ad-916a-f6c7dfd579ff@github.com>
Message-ID: <YcJ0AZf0a2gMCmb86gfmZd13n4I7nGXCp2m46YD4NZg=.a225c507-68bb-4d22-95aa-f3750b97efe5@github.com>

On Wed, 13 Mar 2024 06:04:35 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> Conversion of manual applet test to main based using PassFailJFrame manual framework

This pull request has now been integrated.

Changeset: 628e7702
Author:    Prasanta Sadhukhan <psadhukhan at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/628e7702746ed4cc899d9727432b64c701533eb3
Stats:     237 lines in 3 files changed: 112 ins; 125 del; 0 mod

8327754: Convert javax/swing/JPopupMenu/7160604/bug7160604.java applet to main

Reviewed-by: prr

-------------

PR: https://git.openjdk.org/jdk/pull/18257

From psadhukhan at openjdk.org  Thu Mar 14 02:54:51 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Thu, 14 Mar 2024 02:54:51 GMT
Subject: Integrated: 8327755: Convert
 javax/swing/JScrollBar/8039464/Test8039464.java applet to main
In-Reply-To: <pn0rpaAbI1GrXNB2gVRKVEilfCbM0NX6M-T5E_xaidw=.96b0b4fb-ef4b-4749-b143-ed4a67531fd1@github.com>
References: <pn0rpaAbI1GrXNB2gVRKVEilfCbM0NX6M-T5E_xaidw=.96b0b4fb-ef4b-4749-b143-ed4a67531fd1@github.com>
Message-ID: <K1NXG8fhNXBkiJy115-mayAwhI8FL1yDew8xB-c8YWU=.d2dbe4eb-6fac-4df3-87e7-26be53908d7a@github.com>

On Wed, 13 Mar 2024 06:30:34 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> Conversion of manual applet test to main based using PassFailJFrame manual framework

This pull request has now been integrated.

Changeset: 98e4b753
Author:    Prasanta Sadhukhan <psadhukhan at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/98e4b753e8d7fbbf651c866901734d4f6a7d1680
Stats:     219 lines in 3 files changed: 95 ins; 124 del; 0 mod

8327755: Convert javax/swing/JScrollBar/8039464/Test8039464.java applet to main

Reviewed-by: prr

-------------

PR: https://git.openjdk.org/jdk/pull/18258

From tr at openjdk.org  Thu Mar 14 03:27:40 2024
From: tr at openjdk.org (Tejesh R)
Date: Thu, 14 Mar 2024 03:27:40 GMT
Subject: RFR: 8327874: Convert javax/swing/JTree/4314199/bug4314199.java
 applet test to main [v2]
In-Reply-To: <fkPnsJhSLbXmHNeZSo3pjcJZRAiwhSOjyraO8R7iXN4=.54918c80-5210-4bcd-bd67-a1832390ebbc@github.com>
References: <4HQ5z1My4A9Qcac-1K9Y9sTf7dqWpxrJtdIgSxC1vro=.41a923c6-8607-4c95-8c6f-8a6c5ed1504f@github.com>
 <fkPnsJhSLbXmHNeZSo3pjcJZRAiwhSOjyraO8R7iXN4=.54918c80-5210-4bcd-bd67-a1832390ebbc@github.com>
Message-ID: <ZdtSiJe3d1J9swOjbOrcJHZDER2FavxyQY-1f5B75as=.ee2174d1-539a-4574-b1f5-e3b4013e562d@github.com>

On Wed, 13 Mar 2024 05:19:32 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Conversion of manual applet test to main based using PassFailJFrame manual framework
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review comment update

Marked as reviewed by tr (Committer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18215#pullrequestreview-1935577423

From tr at openjdk.org  Thu Mar 14 03:27:41 2024
From: tr at openjdk.org (Tejesh R)
Date: Thu, 14 Mar 2024 03:27:41 GMT
Subject: RFR: 8327859: Remove applet usage from JColorChooser tests
 Test4319113 [v5]
In-Reply-To: <PUVMZijAuCSfsboAkxw402dd60tNEDc4vFlOJe--KB4=.2370c92c-ff99-4a65-a299-50025b937d0a@github.com>
References: <mzB8yqtVTWIuecXJk5qt1J5Me6iU857a4YMC26xXiyg=.b8fc4e43-3298-4f5c-ab52-8664d30c2d08@github.com>
 <PUVMZijAuCSfsboAkxw402dd60tNEDc4vFlOJe--KB4=.2370c92c-ff99-4a65-a299-50025b937d0a@github.com>
Message-ID: <5ZiNfo88IR5CjloToX2ciMQOWeAEWB_im1e1Qk-UFVM=.a3bd1066-d854-42c9-91a9-b82a5bdb56c4@github.com>

On Wed, 13 Mar 2024 22:37:49 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> Removing applet usage from manual JColorChooser tests
>
> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   use old instructions string

Marked as reviewed by tr (Committer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18210#pullrequestreview-1935576928

From tr at openjdk.org  Thu Mar 14 03:28:38 2024
From: tr at openjdk.org (Tejesh R)
Date: Thu, 14 Mar 2024 03:28:38 GMT
Subject: RFR: 8327857: Remove applet usage from JColorChooser tests
 Test4222508 [v5]
In-Reply-To: <Ry42nY0jCekYQLoktQpicrUuCFoPn1DU51a3TB2rKZw=.c2a72b14-ed09-4fa5-807c-87b75662fc25@github.com>
References: <k-sLqO64HbTaYgimerOjfrS6NdPEYkOW4Wh9u-ln1P4=.fcb4e582-2189-4486-afb4-570cdeed6e69@github.com>
 <Ry42nY0jCekYQLoktQpicrUuCFoPn1DU51a3TB2rKZw=.c2a72b14-ed09-4fa5-807c-87b75662fc25@github.com>
Message-ID: <FaRo6O7ML2aPAPbqsSYBsO-_yk9WGKGink3HaIHE6bQ=.5929ddf1-94a9-487e-8e6e-33fba1c3850d@github.com>

On Wed, 13 Mar 2024 22:24:03 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> Removing applet usage from manual JColorChooser tests
>
> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   relative path

Marked as reviewed by tr (Committer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18209#pullrequestreview-1935577997

From tr at openjdk.org  Thu Mar 14 03:29:39 2024
From: tr at openjdk.org (Tejesh R)
Date: Thu, 14 Mar 2024 03:29:39 GMT
Subject: RFR: JDK-8328000 : Convert /java/awt/im/8154816/bug8154816.java
 applet test to main [v2]
In-Reply-To: <Azte6I6cEY6KA72UP-XDnUYBok3Ao5KMyylStmL2owY=.bd42326d-c097-4cf7-bd7c-70f3e7ac181e@github.com>
References: <FShkxXV6Z_KcU6INfTyHyx-GfO9-xpgrDJi6ZQ0bmhE=.4cfc6764-b51b-4ab6-9323-5c7c1e2ca5e7@github.com>
 <Azte6I6cEY6KA72UP-XDnUYBok3Ao5KMyylStmL2owY=.bd42326d-c097-4cf7-bd7c-70f3e7ac181e@github.com>
Message-ID: <MbHe0iVMZbOMfw7Wtw0eUAZfzwmSRhJKbVp8zfGJIxg=.4ec55f9a-5bfb-429c-9783-6ca5c4f9bc8b@github.com>

On Wed, 13 Mar 2024 17:28:41 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> The following InputMethod test, bug8154816.java is converted to main using PassFailJFrame.
>> 
>> - test renamed to PinyinIMCapsTest
>> - moved one directory above - /java/awt/im/
>> - html file deleted.
>> 
>> PS: I tried to automate this test using Robot, but was unable to produce the same effect as a keyboard keypress for Pinyin, hence keep it as a manual test.
>
> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   instructions updated

Marked as reviewed by tr (Committer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18245#pullrequestreview-1935578519

From tr at openjdk.org  Thu Mar 14 04:48:41 2024
From: tr at openjdk.org (Tejesh R)
Date: Thu, 14 Mar 2024 04:48:41 GMT
Subject: RFR: JDK-8328012 : Convert InputMethod (/java/awt/im) applet tests
 to main [v4]
In-Reply-To: <oadTMu4xuH37vGnNOY1TXF6dJTwx5-nA0gNWtQCKFf4=.3f7711ea-7b32-4ad3-8e1b-536a8757aa28@github.com>
References: <iDY1JdxeSzLcbW-ASx1PylUqKY-kGUjMj8tr4Sj5NDM=.a0b9fbdb-a959-4e98-ae08-d086fd8f210f@github.com>
 <oadTMu4xuH37vGnNOY1TXF6dJTwx5-nA0gNWtQCKFf4=.3f7711ea-7b32-4ad3-8e1b-536a8757aa28@github.com>
Message-ID: <2Ei6cim7yoEWHTzirrQ8TbqcAIjY2shmstPaXcoUGIg=.a8774df0-5d69-45f7-bc79-6d0856fb56e1@github.com>

On Wed, 13 Mar 2024 17:20:38 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Following InputMethod applet tests are converted to main using PassFailJFrame
>> 
>> 1. java/awt/im/8132503/bug8132503.java (Renamed to PinyinIMFullstopTest.java)
>> 2. java/awt/im/8148984/bug8148984.java (Renamed to PinyinIMCommaTest.java) 
>> 
>> - test instructions are updated to make to more clear
>> - tests renamed 
>> - moved one directory above - /java/awt/im/
>> - html file deleted.
>> 
>> Two tests are updated as part of this PR as they are similar, details here https://github.com/openjdk/jdk/pull/18251#issuecomment-1992577598
>
> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   instruction updated

test/jdk/java/awt/im/PinyinIMCommaTest.java line 44:

> 42: 
> 43: public class PinyinIMCommaTest {
> 44:     private static final String INSTRUCTIONS = """

`INSTRUCTIONS ` can be moved inside main  (Other test also)

test/jdk/java/awt/im/PinyinIMCommaTest.java line 82:

> 80:         JTextField input = new JTextField(20);
> 81:         panel.add(new JLabel("Text field:"));
> 82:         panel.add(input);

can add JTextField also this way `panel.add(new JTextField(20));`?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18251#discussion_r1524234200
PR Review Comment: https://git.openjdk.org/jdk/pull/18251#discussion_r1524235092

From tr at openjdk.org  Thu Mar 14 04:59:09 2024
From: tr at openjdk.org (Tejesh R)
Date: Thu, 14 Mar 2024 04:59:09 GMT
Subject: RFR: 8328030: Convert
 javax/swing/text/GlyphView/4984669/bug4984669.java applet test to main [v2]
In-Reply-To: <A08Xop2Zkm3QWsIXqy6DnupA4aku_YonZ5kpD4Mclrs=.0f8874a0-d2ba-4042-9768-e80dbfb44356@github.com>
References: <A08Xop2Zkm3QWsIXqy6DnupA4aku_YonZ5kpD4Mclrs=.0f8874a0-d2ba-4042-9768-e80dbfb44356@github.com>
Message-ID: <2SmALyVZo0rL4kADlcwPABn1vBCIKWK2L7Ac_Qtlvfs=.3396ee1d-50d8-45b9-b41c-44c4997794dc@github.com>

> Convert javax/swing/text/GlyphView/4984669/bug4984669.java manual applet test to main based using PassFailJFrame.

Tejesh R has updated the pull request incrementally with two additional commits since the last revision:

 - minor updates
 - Test renamed and minor updates

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18256/files
  - new: https://git.openjdk.org/jdk/pull/18256/files/03eb1122..2b927f3d

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18256&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18256&range=00-01

  Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/jdk/pull/18256.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18256/head:pull/18256

PR: https://git.openjdk.org/jdk/pull/18256

From abhiscxk at openjdk.org  Thu Mar 14 05:11:04 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Thu, 14 Mar 2024 05:11:04 GMT
Subject: RFR: 8328087: Automate javax/swing/JTable/TAB/TAB.java applet test
 [v3]
In-Reply-To: <MumC6TL2XcA5TmVgQXy8yIDFEqUD08b2dvCUyYu7Kd8=.5891ab36-873a-41f0-b22f-d2fc883c8734@github.com>
References: <MumC6TL2XcA5TmVgQXy8yIDFEqUD08b2dvCUyYu7Kd8=.5891ab36-873a-41f0-b22f-d2fc883c8734@github.com>
Message-ID: <9qBuiIpcpe0XKpu4Kj01JDyIZ7HWufLugUXFLmNe_Co=.14f6c8d0-9f5e-4e42-92d0-10f3980da77e@github.com>

> Conversion of manual applet test to automated test. CI testing is green. Link attached to JBS.

Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:

  class anme change and minor update

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18274/files
  - new: https://git.openjdk.org/jdk/pull/18274/files/66d7884c..dc82c84b

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18274&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18274&range=01-02

  Stats: 29 lines in 1 file changed: 2 ins; 2 del; 25 mod
  Patch: https://git.openjdk.org/jdk/pull/18274.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18274/head:pull/18274

PR: https://git.openjdk.org/jdk/pull/18274

From tr at openjdk.org  Thu Mar 14 05:13:42 2024
From: tr at openjdk.org (Tejesh R)
Date: Thu, 14 Mar 2024 05:13:42 GMT
Subject: Integrated: 8328030: Convert
 javax/swing/text/GlyphView/4984669/bug4984669.java applet test to main
In-Reply-To: <A08Xop2Zkm3QWsIXqy6DnupA4aku_YonZ5kpD4Mclrs=.0f8874a0-d2ba-4042-9768-e80dbfb44356@github.com>
References: <A08Xop2Zkm3QWsIXqy6DnupA4aku_YonZ5kpD4Mclrs=.0f8874a0-d2ba-4042-9768-e80dbfb44356@github.com>
Message-ID: <PWIMD_2IDOaBN2EQ40Ab3TfLWXwc4sr2KsIUen8GYr4=.cc7ce517-f556-4d8e-bc67-634cb549d6d8@github.com>

On Wed, 13 Mar 2024 05:52:07 GMT, Tejesh R <tr at openjdk.org> wrote:

> Convert javax/swing/text/GlyphView/4984669/bug4984669.java manual applet test to main based using PassFailJFrame.

This pull request has now been integrated.

Changeset: 7502dc99
Author:    Tejesh R <tr at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/7502dc99bf23109ef16fb99de25b09bab51e4978
Stats:     165 lines in 3 files changed: 80 ins; 85 del; 0 mod

8328030: Convert javax/swing/text/GlyphView/4984669/bug4984669.java applet test to main

Reviewed-by: azvegint, prr

-------------

PR: https://git.openjdk.org/jdk/pull/18256

From tr at openjdk.org  Thu Mar 14 05:21:03 2024
From: tr at openjdk.org (Tejesh R)
Date: Thu, 14 Mar 2024 05:21:03 GMT
Subject: RFR: 8327879: Convert javax/swing/border/Test4760089.java applet
 test to main [v3]
In-Reply-To: <Vq0kXwaE6TFmJzGmgpo13OA3VEqSnqsjQpDpGZj2ob4=.4f188f8b-5581-4774-8345-76363b4e3cf6@github.com>
References: <Vq0kXwaE6TFmJzGmgpo13OA3VEqSnqsjQpDpGZj2ob4=.4f188f8b-5581-4774-8345-76363b4e3cf6@github.com>
Message-ID: <kmmRhyUGap3vchu_3SbWDiEO15b4CVJGpkrAW5RrMqw=.3771ee8b-747d-47aa-86f2-605f5497cd2b@github.com>

> Convert javax/swing/border/Test4760089.java applet test to main based test using PassFailJFrame.

Tejesh R has updated the pull request incrementally with one additional commit since the last revision:

  Review updates

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18217/files
  - new: https://git.openjdk.org/jdk/pull/18217/files/689c9091..fc2ea7b5

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18217&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18217&range=01-02

  Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/18217.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18217/head:pull/18217

PR: https://git.openjdk.org/jdk/pull/18217

From tr at openjdk.org  Thu Mar 14 05:21:03 2024
From: tr at openjdk.org (Tejesh R)
Date: Thu, 14 Mar 2024 05:21:03 GMT
Subject: RFR: 8327879: Convert javax/swing/border/Test4760089.java applet
 test to main [v2]
In-Reply-To: <m4RM-rvbILC6ecXOcjjnKbYiFeFvvdeIQdIWjfI57xA=.7613d7b9-c5b9-4b14-b77c-8de26b78fc1a@github.com>
References: <Vq0kXwaE6TFmJzGmgpo13OA3VEqSnqsjQpDpGZj2ob4=.4f188f8b-5581-4774-8345-76363b4e3cf6@github.com>
 <md1FNnWLW56N0Ucpj-BSxyVKz1FXVcJjHo5_8_uzOV8=.9db4b144-5f94-47ba-b837-23a7c33f6e9f@github.com>
 <m4RM-rvbILC6ecXOcjjnKbYiFeFvvdeIQdIWjfI57xA=.7613d7b9-c5b9-4b14-b77c-8de26b78fc1a@github.com>
Message-ID: <Ni5uJJjaGiWyS-2Ae1mgFncxMvrbvF8zU-oZOijla-I=.6795f6d9-c177-4588-9b11-48afa373d131@github.com>

On Wed, 13 Mar 2024 22:07:02 GMT, Phil Race <prr at openjdk.org> wrote:

>> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review updates
>
> test/jdk/javax/swing/border/Test4760089.java line 44:
> 
>> 42: public class Test4760089 {
>> 43:     public static void main(String[] args) throws Exception {
>> 44:         String testInstructions = """
> 
> You have lost the first part of the instructions.
> It used to start with
> "When applet starts, you'll see a panel with a compound titled border."
> 
> now this would be 
> "When the test starts, ..."
> 
> Probably you'll need to add an extra row to the instructions.

Updated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18217#discussion_r1524253482

From abhiscxk at openjdk.org  Thu Mar 14 05:22:40 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Thu, 14 Mar 2024 05:22:40 GMT
Subject: RFR: 8328087: Automate javax/swing/JTable/TAB/TAB.java applet test
 [v4]
In-Reply-To: <MumC6TL2XcA5TmVgQXy8yIDFEqUD08b2dvCUyYu7Kd8=.5891ab36-873a-41f0-b22f-d2fc883c8734@github.com>
References: <MumC6TL2XcA5TmVgQXy8yIDFEqUD08b2dvCUyYu7Kd8=.5891ab36-873a-41f0-b22f-d2fc883c8734@github.com>
Message-ID: <njiH2w-M29ROc1KPXAvAYzk06ixeb4eEskw7cGK3J3A=.d63b0290-368f-4d4a-b451-4bba41e9bffc@github.com>

> Conversion of manual applet test to automated test. CI testing is green. Link attached to JBS.

Abhishek Kumar has updated the pull request incrementally with two additional commits since the last revision:

 - Test file update
 - Rename test file

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18274/files
  - new: https://git.openjdk.org/jdk/pull/18274/files/dc82c84b..0a6e5acb

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18274&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18274&range=02-03

  Stats: 0 lines in 1 file changed: 0 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18274.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18274/head:pull/18274

PR: https://git.openjdk.org/jdk/pull/18274

From tr at openjdk.org  Thu Mar 14 05:39:39 2024
From: tr at openjdk.org (Tejesh R)
Date: Thu, 14 Mar 2024 05:39:39 GMT
Subject: RFR: 8328089: Automate javax/swing/JTable/4222153/bug4222153.java
 applet test [v3]
In-Reply-To: <r4hNSmyPdczUEL6rDJdXrZACk7d_ZHLmutZg4leKY6M=.73f48361-dfc1-4d9d-af21-53e2c35772a6@github.com>
References: <mVE4zdUddu3XPR7DxR9mbyzZwAMXUy0ylxrFmtuHAZU=.df6d1ce0-3afe-4370-b23a-0f4042efc9c9@github.com>
 <r4hNSmyPdczUEL6rDJdXrZACk7d_ZHLmutZg4leKY6M=.73f48361-dfc1-4d9d-af21-53e2c35772a6@github.com>
Message-ID: <a8P8FO2LpDNBfsmcfmcRd17FRBLXllyWtyblJPbyL_Q=.110191ed-e063-40e5-9f02-b53fc89797b7@github.com>

On Wed, 13 Mar 2024 18:12:38 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Conversion of manual applet test to automated test. CI testing is green. Link attached to JBS.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Whitespace error fix

test/jdk/javax/swing/JTable/bug4222153.java line 66:

> 64:                 frame.setLocationRelativeTo(null);
> 65:                 frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
> 66:                 frame.setVisible(true);

I guess it is better to move frame initialization part into a separate method rather here.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18275#discussion_r1524263059

From abhiscxk at openjdk.org  Thu Mar 14 05:43:39 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Thu, 14 Mar 2024 05:43:39 GMT
Subject: RFR: 8327787: Convert javax/swing/border/Test4129681.java applet
 test to main [v4]
In-Reply-To: <M9iPASdsgS4F4Y7z1nwaIu9qKwmSgm_gHY0U8EYi2U0=.f82229d4-ebf5-4dd4-890e-050216283943@github.com>
References: <uZ3hGgyIWuMOTp6qSVNw_3r-F4REh4QvrzqAtH8fMo8=.e55e311d-c0d7-4863-9e8a-0d1edc1d8857@github.com>
 <M9iPASdsgS4F4Y7z1nwaIu9qKwmSgm_gHY0U8EYi2U0=.f82229d4-ebf5-4dd4-890e-050216283943@github.com>
Message-ID: <MsO-8WQO5OJTugFB1sPlWhFjqmxy_WYdH9-uGTUNokg=.0132a748-cc2c-4658-a041-68350f1d4cca@github.com>

On Tue, 12 Mar 2024 09:47:37 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Convert javax/swing/border/Test4129681.java applet test to main based test using PassFailJFrame.
>
> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review updates

test/jdk/javax/swing/border/Test4129681.java line 43:

> 41:     public static void main(String[] args) throws Exception {
> 42:         String testInstructions = """
> 43:                 Turn on the checkbox to disable the label.

Can I suggest something like this ?
Suggestion:

                Click the checkbox to disable/enable the label.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18189#discussion_r1524267502

From abhiscxk at openjdk.org  Thu Mar 14 05:51:55 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Thu, 14 Mar 2024 05:51:55 GMT
Subject: RFR: 8328089: Automate javax/swing/JTable/4222153/bug4222153.java
 applet test [v4]
In-Reply-To: <mVE4zdUddu3XPR7DxR9mbyzZwAMXUy0ylxrFmtuHAZU=.df6d1ce0-3afe-4370-b23a-0f4042efc9c9@github.com>
References: <mVE4zdUddu3XPR7DxR9mbyzZwAMXUy0ylxrFmtuHAZU=.df6d1ce0-3afe-4370-b23a-0f4042efc9c9@github.com>
Message-ID: <1okH-q00rjuD4KfgG4FDMLFGS81efUOzvROW_QdRFrU=.ffe5e1df-bec6-4220-9b79-c9dd461d81b1@github.com>

> Conversion of manual applet test to automated test. CI testing is green. Link attached to JBS.

Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:

  UI init in separate method

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18275/files
  - new: https://git.openjdk.org/jdk/pull/18275/files/c251b3f3..d18103e8

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18275&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18275&range=02-03

  Stats: 19 lines in 1 file changed: 10 ins; 8 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/18275.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18275/head:pull/18275

PR: https://git.openjdk.org/jdk/pull/18275

From abhiscxk at openjdk.org  Thu Mar 14 05:51:55 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Thu, 14 Mar 2024 05:51:55 GMT
Subject: RFR: 8328089: Automate javax/swing/JTable/4222153/bug4222153.java
 applet test [v3]
In-Reply-To: <a8P8FO2LpDNBfsmcfmcRd17FRBLXllyWtyblJPbyL_Q=.110191ed-e063-40e5-9f02-b53fc89797b7@github.com>
References: <mVE4zdUddu3XPR7DxR9mbyzZwAMXUy0ylxrFmtuHAZU=.df6d1ce0-3afe-4370-b23a-0f4042efc9c9@github.com>
 <r4hNSmyPdczUEL6rDJdXrZACk7d_ZHLmutZg4leKY6M=.73f48361-dfc1-4d9d-af21-53e2c35772a6@github.com>
 <a8P8FO2LpDNBfsmcfmcRd17FRBLXllyWtyblJPbyL_Q=.110191ed-e063-40e5-9f02-b53fc89797b7@github.com>
Message-ID: <MbTF5d6ZoVEK_glkUm_5d98rUzsiarb_Za7clLoNDV4=.905f6965-4c94-49d1-b753-9539013625d7@github.com>

On Thu, 14 Mar 2024 05:33:41 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Whitespace error fix
>
> test/jdk/javax/swing/JTable/bug4222153.java line 66:
> 
>> 64:                 frame.setLocationRelativeTo(null);
>> 65:                 frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
>> 66:                 frame.setVisible(true);
> 
> I guess it is better to move frame initialization part into a separate method rather here.

Since the UI initialization was minimal, I kept it in main. Moved to separate method now.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18275#discussion_r1524271401

From abhiscxk at openjdk.org  Thu Mar 14 05:55:39 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Thu, 14 Mar 2024 05:55:39 GMT
Subject: RFR: 8327826: Convert javax/swing/border/Test4243289.java applet
 test to main [v3]
In-Reply-To: <5j-kUmJAGV9tEZBTNWCCUAYbQCdYbkS2aT4smyVjqe4=.61f56bc7-0389-4182-9b5a-6d06b676cdea@github.com>
References: <M5kMa3NPTVyzBZK7rPRT_gAHTQgVjPY_in-ZZJ8i1zM=.f1def8d8-79cd-4b03-88d2-4016a937d08d@github.com>
 <5j-kUmJAGV9tEZBTNWCCUAYbQCdYbkS2aT4smyVjqe4=.61f56bc7-0389-4182-9b5a-6d06b676cdea@github.com>
Message-ID: <FCCMQETuZYUyb2LhKYexcIJosZak4NZVkoDtVUAVtKc=.92b9e696-2154-4629-9c9b-ea1793716d90@github.com>

On Tue, 12 Mar 2024 09:53:43 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Convert javax/swing/border/Test4243289.java applet test to main based test using PassFailJFrame.
>
> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review updates

Minor comment: 
Sort the imports.

test/jdk/javax/swing/border/Test4243289.java line 24:

> 22:  */
> 23: 
> 24: import java.awt.Font;

Suggestion:

import java.awt.Dimension;
import java.awt.Font;

-------------

Marked as reviewed by abhiscxk (Committer).

PR Review: https://git.openjdk.org/jdk/pull/18197#pullrequestreview-1935742960
PR Review Comment: https://git.openjdk.org/jdk/pull/18197#discussion_r1524274292

From tr at openjdk.org  Thu Mar 14 05:57:38 2024
From: tr at openjdk.org (Tejesh R)
Date: Thu, 14 Mar 2024 05:57:38 GMT
Subject: RFR: 8328089: Automate javax/swing/JTable/4222153/bug4222153.java
 applet test [v4]
In-Reply-To: <1okH-q00rjuD4KfgG4FDMLFGS81efUOzvROW_QdRFrU=.ffe5e1df-bec6-4220-9b79-c9dd461d81b1@github.com>
References: <mVE4zdUddu3XPR7DxR9mbyzZwAMXUy0ylxrFmtuHAZU=.df6d1ce0-3afe-4370-b23a-0f4042efc9c9@github.com>
 <1okH-q00rjuD4KfgG4FDMLFGS81efUOzvROW_QdRFrU=.ffe5e1df-bec6-4220-9b79-c9dd461d81b1@github.com>
Message-ID: <-klM66JxSB2gLNarbafu3TwarnXjv6IgIxstZXQ2UCU=.0bbff320-957e-4d43-b5e0-77dc230d5a47@github.com>

On Thu, 14 Mar 2024 05:51:55 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Conversion of manual applet test to automated test. CI testing is green. Link attached to JBS.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   UI init in separate method

Looks good to me.

-------------

Marked as reviewed by tr (Committer).

PR Review: https://git.openjdk.org/jdk/pull/18275#pullrequestreview-1935746268

From tr at openjdk.org  Thu Mar 14 06:51:47 2024
From: tr at openjdk.org (Tejesh R)
Date: Thu, 14 Mar 2024 06:51:47 GMT
Subject: RFR: 8327787: Convert javax/swing/border/Test4129681.java applet
 test to main [v5]
In-Reply-To: <uZ3hGgyIWuMOTp6qSVNw_3r-F4REh4QvrzqAtH8fMo8=.e55e311d-c0d7-4863-9e8a-0d1edc1d8857@github.com>
References: <uZ3hGgyIWuMOTp6qSVNw_3r-F4REh4QvrzqAtH8fMo8=.e55e311d-c0d7-4863-9e8a-0d1edc1d8857@github.com>
Message-ID: <fV0jZcqqMTIOAAXLtGSCFdiMxM7Mw4ycYHdScv071J4=.695deca1-6f04-46b3-8fca-4a998323c894@github.com>

> Convert javax/swing/border/Test4129681.java applet test to main based test using PassFailJFrame.

Tejesh R has updated the pull request incrementally with one additional commit since the last revision:

  Review updates

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18189/files
  - new: https://git.openjdk.org/jdk/pull/18189/files/bc78d143..a485fd75

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18189&range=04
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18189&range=03-04

  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/18189.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18189/head:pull/18189

PR: https://git.openjdk.org/jdk/pull/18189

From tr at openjdk.org  Thu Mar 14 06:51:48 2024
From: tr at openjdk.org (Tejesh R)
Date: Thu, 14 Mar 2024 06:51:48 GMT
Subject: RFR: 8327787: Convert javax/swing/border/Test4129681.java applet
 test to main [v4]
In-Reply-To: <MsO-8WQO5OJTugFB1sPlWhFjqmxy_WYdH9-uGTUNokg=.0132a748-cc2c-4658-a041-68350f1d4cca@github.com>
References: <uZ3hGgyIWuMOTp6qSVNw_3r-F4REh4QvrzqAtH8fMo8=.e55e311d-c0d7-4863-9e8a-0d1edc1d8857@github.com>
 <M9iPASdsgS4F4Y7z1nwaIu9qKwmSgm_gHY0U8EYi2U0=.f82229d4-ebf5-4dd4-890e-050216283943@github.com>
 <MsO-8WQO5OJTugFB1sPlWhFjqmxy_WYdH9-uGTUNokg=.0132a748-cc2c-4658-a041-68350f1d4cca@github.com>
Message-ID: <Htgt1OrFcLyZQMQSaaW9mictnvES-Vrjjb7_gYLHVeM=.552317bd-1c03-4c04-871f-179a1195c0b4@github.com>

On Thu, 14 Mar 2024 05:40:59 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review updates
>
> test/jdk/javax/swing/border/Test4129681.java line 43:
> 
>> 41:     public static void main(String[] args) throws Exception {
>> 42:         String testInstructions = """
>> 43:                 Turn on the checkbox to disable the label.
> 
> Can I suggest something like this ?
> Suggestion:
> 
>                 Click the checkbox to disable/enable the label.

Since the test is for disable, I would retain the instructions to disable.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18189#discussion_r1524314441

From aivanov at openjdk.org  Thu Mar 14 09:08:40 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Thu, 14 Mar 2024 09:08:40 GMT
Subject: RFR: 8316388: Opensource five Swing component related regression
 tests [v3]
In-Reply-To: <UNFvvQw5qKczcFoJUmKum9Sl9pbk0YI_I2aQRjsiqW0=.e6f228d1-6ff9-4009-b8fe-5a0e0209901a@github.com>
References: <lyqr03dS3RFZwQum85-sdTUI2flExMCQm9Dps70wX5w=.1e207aa6-34e2-48e5-866c-bc39eb8d479f@github.com>
 <9hBnCXqmWqizqPJKVIA8M8wL2i9lqgddkRMwMmIU4qM=.a09493e9-a861-4383-aa51-4e692f0acf67@github.com>
 <UNFvvQw5qKczcFoJUmKum9Sl9pbk0YI_I2aQRjsiqW0=.e6f228d1-6ff9-4009-b8fe-5a0e0209901a@github.com>
Message-ID: <COddHfSsg4HWeT-PtWL_P1HMKF1caMHJDnjTouE_EeA=.5fb3f778-9fb7-4ae6-87ea-c4def8b9d439@github.com>

On Wed, 13 Mar 2024 19:40:16 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

>> test/jdk/javax/swing/JDesktopPane/bug4773378.java line 99:
>> 
>>> 97:                 bug4773378.this.wait();
>>> 98:             }
>>> 99:         }
>> 
>> Suggestion:
>> 
>>         frameActivated.await();
>> 
>> 
>> Using `CountDownLatch` is so much cleaner.
>
> You like your countdown latches :) Ok, i will re-write this test with CDL.

Because 1 line of code replaces 4 lines of code and communicates what's happening much clearer than a synchronized block with a flag.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18259#discussion_r1524493581

From abhiscxk at openjdk.org  Thu Mar 14 09:09:41 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Thu, 14 Mar 2024 09:09:41 GMT
Subject: RFR: 8327787: Convert javax/swing/border/Test4129681.java applet
 test to main [v5]
In-Reply-To: <fV0jZcqqMTIOAAXLtGSCFdiMxM7Mw4ycYHdScv071J4=.695deca1-6f04-46b3-8fca-4a998323c894@github.com>
References: <uZ3hGgyIWuMOTp6qSVNw_3r-F4REh4QvrzqAtH8fMo8=.e55e311d-c0d7-4863-9e8a-0d1edc1d8857@github.com>
 <fV0jZcqqMTIOAAXLtGSCFdiMxM7Mw4ycYHdScv071J4=.695deca1-6f04-46b3-8fca-4a998323c894@github.com>
Message-ID: <IeppbjKg9XtwVCJxjW3dsrrNDIjYs9shKLQKcF4RL4U=.e7a1b909-dc2e-4852-9a66-cb044f7bd061@github.com>

On Thu, 14 Mar 2024 06:51:47 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Convert javax/swing/border/Test4129681.java applet test to main based test using PassFailJFrame.
>
> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review updates

Marked as reviewed by abhiscxk (Committer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18189#pullrequestreview-1936096203

From abhiscxk at openjdk.org  Thu Mar 14 09:10:45 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Thu, 14 Mar 2024 09:10:45 GMT
Subject: Integrated: 8327874: Convert javax/swing/JTree/4314199/bug4314199.java
 applet test to main
In-Reply-To: <4HQ5z1My4A9Qcac-1K9Y9sTf7dqWpxrJtdIgSxC1vro=.41a923c6-8607-4c95-8c6f-8a6c5ed1504f@github.com>
References: <4HQ5z1My4A9Qcac-1K9Y9sTf7dqWpxrJtdIgSxC1vro=.41a923c6-8607-4c95-8c6f-8a6c5ed1504f@github.com>
Message-ID: <To4YP8VXFBGjX3zqoSX4cJRJjLT1Adiczsqgc8Xq-ss=.f3d4e042-4c1d-4dde-b9f0-f4e7fae04b04@github.com>

On Tue, 12 Mar 2024 06:43:36 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

> Conversion of manual applet test to main based using PassFailJFrame manual framework

This pull request has now been integrated.

Changeset: 49ce85fa
Author:    Abhishek Kumar <abhiscxk at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/49ce85fae9f06d05367c94615532f6ff87952c79
Stats:     222 lines in 3 files changed: 99 ins; 123 del; 0 mod

8327874: Convert javax/swing/JTree/4314199/bug4314199.java applet test to main

Reviewed-by: prr, tr

-------------

PR: https://git.openjdk.org/jdk/pull/18215

From kizune at openjdk.org  Thu Mar 14 09:15:41 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Thu, 14 Mar 2024 09:15:41 GMT
Subject: RFR: 8316388: Opensource five Swing component related regression
 tests [v3]
In-Reply-To: <9hBnCXqmWqizqPJKVIA8M8wL2i9lqgddkRMwMmIU4qM=.a09493e9-a861-4383-aa51-4e692f0acf67@github.com>
References: <lyqr03dS3RFZwQum85-sdTUI2flExMCQm9Dps70wX5w=.1e207aa6-34e2-48e5-866c-bc39eb8d479f@github.com>
 <9hBnCXqmWqizqPJKVIA8M8wL2i9lqgddkRMwMmIU4qM=.a09493e9-a861-4383-aa51-4e692f0acf67@github.com>
Message-ID: <QIqwk6Fxi8Y4BgAxix8xkAS5kI8LAazdWMSmdQv4Sjk=.592482b8-dddf-425e-922b-56cea7eb8ea0@github.com>

On Wed, 13 Mar 2024 16:26:38 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update test/jdk/javax/swing/JDesktopPane/bug4773378.java
>>   
>>   Co-authored-by: Alexey Ivanov <alexey.ivanov at oracle.com>
>
> test/jdk/javax/swing/JDesktopPane/bug4773378.java line 117:
> 
>> 115:     }
>> 116: 
>> 117:     class MyDesktopManager extends DefaultDesktopManager {
> 
> Suggestion:
> 
>     private static class MyDesktopManager extends DefaultDesktopManager {

Done.

> test/jdk/javax/swing/JEditorPane/bug4325606.java line 101:
> 
>> 99:             } catch (BadLocationException blex) {
>> 100:                 passed = false;
>> 101:             }
> 
> Suggestion:
> 
>             } catch (BadLocationException blex) {
>                 throw new RuntimeException("Test failed", blex);
>             }
> 
> Throw exception preserving the original exception which will help analysing the failure?

Fixed.

> test/jdk/javax/swing/JEditorPane/bug4325606.java line 120:
> 
>> 118:             if (!b.passed) {
>> 119:                 throw new RuntimeException("Test failed.");
>> 120:             }
> 
> Suggestion:
> 
>             robot.waitForIdle();
> 
> Wait until all events are processed. If test fails, it throws an exception on EDT; otherwise, the test is finished as soon as the event queue is empty. No need to waste 3 seconds.

Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18259#discussion_r1524501718
PR Review Comment: https://git.openjdk.org/jdk/pull/18259#discussion_r1524502044
PR Review Comment: https://git.openjdk.org/jdk/pull/18259#discussion_r1524502442

From abhiscxk at openjdk.org  Thu Mar 14 09:30:42 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Thu, 14 Mar 2024 09:30:42 GMT
Subject: RFR: 8327757: Convert javax/swing/JSlider/6524424/bug6524424.java
 applet to main
In-Reply-To: <bq4piqGxP9zZiBlAc8_w-hnLs84WeA78AngOyTg7lwI=.b2572769-5729-4612-81b9-aac8f1a30398@github.com>
References: <bq4piqGxP9zZiBlAc8_w-hnLs84WeA78AngOyTg7lwI=.b2572769-5729-4612-81b9-aac8f1a30398@github.com>
Message-ID: <vAKGtESuVZvJmHHks_xa1cUPGm0PlebUEhv-9X_yNhk=.5db31485-b133-4ae9-9793-73ba328c6851@github.com>

On Wed, 13 Mar 2024 07:34:24 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> Conversion of manual applet test to main based using PassFailJFrame manual framework

test/jdk/javax/swing/JSlider/bug6524424.java line 28:

> 26:  * @bug 6524424
> 27:  * @requires (os.family == "windows")
> 28:  * @summary JSlider Clicking In Tracks Behavior Inconsistent For Different Tick Spacings

Minor suggestion: All words need not to be start with Capital letter.
Suggestion:

 * @summary JSlider clicking in tracks behavior inconsistent for different tick spacings

test/jdk/javax/swing/JSlider/bug6524424.java line 80:

> 78:         JFrame frame = new JFrame();
> 79: 
> 80:         frame.setContentPane(panel);

`JFrame frame = new JFrame();`

Please add suitable frame title.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18263#discussion_r1524521674
PR Review Comment: https://git.openjdk.org/jdk/pull/18263#discussion_r1524524351

From aivanov at openjdk.org  Thu Mar 14 09:30:41 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Thu, 14 Mar 2024 09:30:41 GMT
Subject: RFR: 8316388: Opensource five Swing component related regression
 tests [v3]
In-Reply-To: <baU5LsUrDpWgtFKq1zoKW2GtOnISwyBqaqySkIQqC5A=.94e8a1a6-020a-4ded-b8e1-fea5b86b1438@github.com>
References: <lyqr03dS3RFZwQum85-sdTUI2flExMCQm9Dps70wX5w=.1e207aa6-34e2-48e5-866c-bc39eb8d479f@github.com>
 <9hBnCXqmWqizqPJKVIA8M8wL2i9lqgddkRMwMmIU4qM=.a09493e9-a861-4383-aa51-4e692f0acf67@github.com>
 <baU5LsUrDpWgtFKq1zoKW2GtOnISwyBqaqySkIQqC5A=.94e8a1a6-020a-4ded-b8e1-fea5b86b1438@github.com>
Message-ID: <lgxnXf9bapHcvBBC_nqk2i8HkTQ6N1_yGeyQVAjcWWw=.2394fbc4-a1b4-4f56-b6ee-df73ad985e0f@github.com>

On Wed, 13 Mar 2024 19:57:08 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

>> test/jdk/javax/swing/JEditorPane/bug4325606.java line 84:
>> 
>>> 82:             robo.setAutoDelay(100);
>>> 83:             robo.delay(1000);
>>> 84:             Point p = frame.getLocationOnScreen();
>> 
>> Technically, `getLocationOnScreen` should be called on EDT.
>
> It happens in the windowOpened method of the WindowAdapter. If window events arrive not on EDT then we have a whole other slew of problems :)

???? That's right!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18259#discussion_r1524524570

From aivanov at openjdk.org  Thu Mar 14 09:30:43 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Thu, 14 Mar 2024 09:30:43 GMT
Subject: RFR: 8316388: Opensource five Swing component related regression
 tests [v3]
In-Reply-To: <8EQNKy3Uz6Lv16s6-hKGSSX7AtI9cVH3cB2UZwemte8=.12a3b862-f9b3-4ece-899e-650d622aef90@github.com>
References: <lyqr03dS3RFZwQum85-sdTUI2flExMCQm9Dps70wX5w=.1e207aa6-34e2-48e5-866c-bc39eb8d479f@github.com>
 <8EQNKy3Uz6Lv16s6-hKGSSX7AtI9cVH3cB2UZwemte8=.12a3b862-f9b3-4ece-899e-650d622aef90@github.com>
Message-ID: <e1SK-X45PDxJmdyI539EX6t6UeziMrQU2PU2uwliwYg=.b5d50bf7-0afd-47d1-a13a-73afd48af411@github.com>

On Thu, 14 Mar 2024 01:15:45 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

>> Cleaned up five more tests.
>> 
>> Continuation of https://github.com/openjdk/jdk/pull/18184
>> 
>> Unfortunately one of the commits rendered the whole PR invalid so i closed it and restarting it here.
>> All comments from the previous review are addressed.
>
> Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update test/jdk/javax/swing/JDesktopPane/bug4773378.java
>   
>   Co-authored-by: Alexey Ivanov <alexey.ivanov at oracle.com>

test/jdk/javax/swing/JEditorPane/bug4325606.java line 100:

> 98:                 Utilities.getRowStart(pane, pane.getCaretPosition());
> 99:             } catch (BadLocationException blex) {
> 100:                 throw new RuntimeException("Test failed.");

Suggestion:

                throw new RuntimeException("Test failed.", blex);

Preserve the original exception as it shows where the problem occurred.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18259#discussion_r1524520356

From abhiscxk at openjdk.org  Thu Mar 14 09:33:38 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Thu, 14 Mar 2024 09:33:38 GMT
Subject: RFR: 8327757: Convert javax/swing/JSlider/6524424/bug6524424.java
 applet to main
In-Reply-To: <bq4piqGxP9zZiBlAc8_w-hnLs84WeA78AngOyTg7lwI=.b2572769-5729-4612-81b9-aac8f1a30398@github.com>
References: <bq4piqGxP9zZiBlAc8_w-hnLs84WeA78AngOyTg7lwI=.b2572769-5729-4612-81b9-aac8f1a30398@github.com>
Message-ID: <L32L97HcJxHe9vq8smIyAVU990qhtVPMGAuoRVNQMAI=.c610756f-57dc-4810-96dc-a5e246bf5fe3@github.com>

On Wed, 13 Mar 2024 07:34:24 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> Conversion of manual applet test to main based using PassFailJFrame manual framework

test/jdk/javax/swing/JSlider/bug6524424.java line 81:

> 79: 
> 80:         frame.setContentPane(panel);
> 81:         frame.setDefaultCloseOperation(JFrame.DISPOSE_ON_CLOSE);

`frame.setDefaultCloseOperation(JFrame.DISPOSE_ON_CLOSE); ` redundant can be removed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18263#discussion_r1524528145

From aivanov at openjdk.org  Thu Mar 14 09:34:40 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Thu, 14 Mar 2024 09:34:40 GMT
Subject: RFR: 8316388: Opensource five Swing component related regression
 tests [v3]
In-Reply-To: <l9OECT3rO4xtyvPaduDgc9fOX8dHsK8PR-lIbnDx3G8=.f8c24649-d93b-431e-a9c2-bc16cfd9816f@github.com>
References: <lyqr03dS3RFZwQum85-sdTUI2flExMCQm9Dps70wX5w=.1e207aa6-34e2-48e5-866c-bc39eb8d479f@github.com>
 <9hBnCXqmWqizqPJKVIA8M8wL2i9lqgddkRMwMmIU4qM=.a09493e9-a861-4383-aa51-4e692f0acf67@github.com>
 <l9OECT3rO4xtyvPaduDgc9fOX8dHsK8PR-lIbnDx3G8=.f8c24649-d93b-431e-a9c2-bc16cfd9816f@github.com>
Message-ID: <tghuMnFzGvpgkpLTAieFkO9oseJF_rYQptWS0S32VRA=.76c2d537-fe1b-4cea-96dc-658d5e0b864b@github.com>

On Wed, 13 Mar 2024 20:49:19 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

>> test/jdk/javax/swing/JEditorPane/bug4694598.java line 64:
>> 
>>> 62:         } catch (IOException ioe){
>>> 63:             throw new RuntimeException("Could not create html file to embed", ioe);
>>> 64:         }
>> 
>> Move creating the file to `main` method before setting up GUI and let `IOException` escape from main.
>
> This is try-with-resources so if i will do it in main i will have to add synchronizing and closing of writer which is a strange trade-off so i would have to do try block anyways.

Why would you need synchronisation?


        try (Writer writer = Files.newBufferedWriter(frameContentFile)) {
            writer.write(frameContentString);
        }

would write out the contents of the file and close the file handle. In setupGui, you would still use `frameContentFile` object only which is `final` and immutable, therefore it's thread-safe.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18259#discussion_r1524529046

From abhiscxk at openjdk.org  Thu Mar 14 09:37:41 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Thu, 14 Mar 2024 09:37:41 GMT
Subject: RFR: 8327756: Convert javax/swing/JSlider/4987336/bug4987336.java
 applet to main
In-Reply-To: <zFe1pB_IJT8gqZC2WVKRnHq_9W2DBWU_UAmM3_QdXpM=.b5493e4d-1d4d-451a-a373-753d8c682fa8@github.com>
References: <zFe1pB_IJT8gqZC2WVKRnHq_9W2DBWU_UAmM3_QdXpM=.b5493e4d-1d4d-451a-a373-753d8c682fa8@github.com>
Message-ID: <IjRTuWi_us7T52lUadXWbVJKuf-IJPKCzn5vwtnfXKA=.50cd5d45-ec6c-4c6b-8905-1bc1d2d17bdb@github.com>

On Wed, 13 Mar 2024 07:10:32 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> Conversion of manual applet test to main based using PassFailJFrame manual framework

test/jdk/javax/swing/JSlider/4987336/bug4987336.java line 47:

> 45: import javax.swing.SwingUtilities;
> 46: import javax.swing.border.TitledBorder;
> 47: import javax.swing.UIManager;

`import javax.swing.UIManager;` can be put before `import javax.swing.border.TitledBorder;`

test/jdk/javax/swing/JSlider/4987336/bug4987336.java line 75:

> 73: 
> 74:     private static JFrame createTestUI() {
> 75:         frame = new JFrame();

frame title.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18261#discussion_r1524533267
PR Review Comment: https://git.openjdk.org/jdk/pull/18261#discussion_r1524531641

From aivanov at openjdk.org  Thu Mar 14 09:38:38 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Thu, 14 Mar 2024 09:38:38 GMT
Subject: RFR: 8316388: Opensource five Swing component related regression
 tests [v3]
In-Reply-To: <l9OECT3rO4xtyvPaduDgc9fOX8dHsK8PR-lIbnDx3G8=.f8c24649-d93b-431e-a9c2-bc16cfd9816f@github.com>
References: <lyqr03dS3RFZwQum85-sdTUI2flExMCQm9Dps70wX5w=.1e207aa6-34e2-48e5-866c-bc39eb8d479f@github.com>
 <9hBnCXqmWqizqPJKVIA8M8wL2i9lqgddkRMwMmIU4qM=.a09493e9-a861-4383-aa51-4e692f0acf67@github.com>
 <l9OECT3rO4xtyvPaduDgc9fOX8dHsK8PR-lIbnDx3G8=.f8c24649-d93b-431e-a9c2-bc16cfd9816f@github.com>
Message-ID: <9bTglbV8F9dZ3vGxlS_VjiEuyrt1WRajxNxeSytmYk8=.1728dac3-66c0-4ced-acf7-0438e83bc79e@github.com>

On Wed, 13 Mar 2024 20:51:18 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

>> test/jdk/javax/swing/JEditorPane/bug4694598.java line 74:
>> 
>>> 72:         String html = "<HTML> <BODY>" +
>>> 73:                 "<FRAMESET cols=\"100%\">" +
>>> 74:                 "<FRAME src=\"" + frameContentUrl + "\">" +
>> 
>> Suggestion:
>> 
>>                 "<FRAME src="" + frameContentFile.toUri()+ "">" +
>> 
>> Isn't it enough? Alternatively, `"file:/" + frameContentFile.toAbsolutePath()` produces the same result as `frameContentFile.toUri().toURL()`.
>> 
>> Another option is to convert the `Path` to `URL` in the `main` method before calling `setupGUI` and remove try-catch blocks.
>
> Again, i do not mind the try/catch block and using URI instead of URL gives different result and i am not sure the original bug would be reproducible with URI which will make it a strange case of the regression test.

Okay.

Without the try-catch blocks, the code is simpler? Ensuring the updated test still reproduces the original issue is always a good thing to do, but running the updated with an old version of Java often requires modifying the source code again.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18259#discussion_r1524534991

From aivanov at openjdk.org  Thu Mar 14 09:48:41 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Thu, 14 Mar 2024 09:48:41 GMT
Subject: RFR: 8327787: Convert javax/swing/border/Test4129681.java applet
 test to main [v4]
In-Reply-To: <Htgt1OrFcLyZQMQSaaW9mictnvES-Vrjjb7_gYLHVeM=.552317bd-1c03-4c04-871f-179a1195c0b4@github.com>
References: <uZ3hGgyIWuMOTp6qSVNw_3r-F4REh4QvrzqAtH8fMo8=.e55e311d-c0d7-4863-9e8a-0d1edc1d8857@github.com>
 <M9iPASdsgS4F4Y7z1nwaIu9qKwmSgm_gHY0U8EYi2U0=.f82229d4-ebf5-4dd4-890e-050216283943@github.com>
 <MsO-8WQO5OJTugFB1sPlWhFjqmxy_WYdH9-uGTUNokg=.0132a748-cc2c-4658-a041-68350f1d4cca@github.com>
 <Htgt1OrFcLyZQMQSaaW9mictnvES-Vrjjb7_gYLHVeM=.552317bd-1c03-4c04-871f-179a1195c0b4@github.com>
Message-ID: <gZbAifPM1INfBmimC1w-74PzXH-Nj3BiWaMtZuYkY24=.fcb136d2-5c69-4ac8-bec6-ec9e76a634cc@github.com>

On Thu, 14 Mar 2024 06:48:08 GMT, Tejesh R <tr at openjdk.org> wrote:

>> test/jdk/javax/swing/border/Test4129681.java line 43:
>> 
>>> 41:     public static void main(String[] args) throws Exception {
>>> 42:         String testInstructions = """
>>> 43:                 Turn on the checkbox to disable the label.
>> 
>> Can I suggest something like this ?
>> Suggestion:
>> 
>>                 Click the checkbox to disable/enable the label.
>
> Since the test is for disable, I would retain the instructions to disable.

[Microsoft recommends](https://learn.microsoft.com/en-us/windows/win32/uxguide/ctrl-check-boxes#documentation) using *select / clear* the check box:

<q cite="https://learn.microsoft.com/en-us/windows/win32/uxguide/ctrl-check-boxes#documentation">To describe user interaction, use select and clear.</q>

I don't know about Apple macOS and Linux systems.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18189#discussion_r1524548512

From aivanov at openjdk.org  Thu Mar 14 09:56:41 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Thu, 14 Mar 2024 09:56:41 GMT
Subject: RFR: 8327787: Convert javax/swing/border/Test4129681.java applet
 test to main [v5]
In-Reply-To: <fV0jZcqqMTIOAAXLtGSCFdiMxM7Mw4ycYHdScv071J4=.695deca1-6f04-46b3-8fca-4a998323c894@github.com>
References: <uZ3hGgyIWuMOTp6qSVNw_3r-F4REh4QvrzqAtH8fMo8=.e55e311d-c0d7-4863-9e8a-0d1edc1d8857@github.com>
 <fV0jZcqqMTIOAAXLtGSCFdiMxM7Mw4ycYHdScv071J4=.695deca1-6f04-46b3-8fca-4a998323c894@github.com>
Message-ID: <UDAT5KQAWlGuomK9LU1iYrguuuONmQNeiCm7fEqXIZE=.65801baa-3095-4cf2-97a0-2f34b0753220@github.com>

On Thu, 14 Mar 2024 06:51:47 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Convert javax/swing/border/Test4129681.java applet test to main based test using PassFailJFrame.
>
> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review updates

Marked as reviewed by aivanov (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18189#pullrequestreview-1936201343

From aivanov at openjdk.org  Thu Mar 14 10:02:41 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Thu, 14 Mar 2024 10:02:41 GMT
Subject: RFR: 8316388: Opensource five Swing component related regression
 tests [v3]
In-Reply-To: <e1SK-X45PDxJmdyI539EX6t6UeziMrQU2PU2uwliwYg=.b5d50bf7-0afd-47d1-a13a-73afd48af411@github.com>
References: <lyqr03dS3RFZwQum85-sdTUI2flExMCQm9Dps70wX5w=.1e207aa6-34e2-48e5-866c-bc39eb8d479f@github.com>
 <8EQNKy3Uz6Lv16s6-hKGSSX7AtI9cVH3cB2UZwemte8=.12a3b862-f9b3-4ece-899e-650d622aef90@github.com>
 <e1SK-X45PDxJmdyI539EX6t6UeziMrQU2PU2uwliwYg=.b5d50bf7-0afd-47d1-a13a-73afd48af411@github.com>
Message-ID: <UROvD2_5rY9iL2EJPh2zFvhpASswTgIaVWS_UiVCTRo=.a466e7df-b85e-4a66-84f3-909af009e31c@github.com>

On Thu, 14 Mar 2024 09:25:29 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update test/jdk/javax/swing/JDesktopPane/bug4773378.java
>>   
>>   Co-authored-by: Alexey Ivanov <alexey.ivanov at oracle.com>
>
> test/jdk/javax/swing/JEditorPane/bug4325606.java line 100:
> 
>> 98:                 Utilities.getRowStart(pane, pane.getCaretPosition());
>> 99:             } catch (BadLocationException blex) {
>> 100:                 throw new RuntimeException("Test failed.");
> 
> Suggestion:
> 
>                 throw new RuntimeException("Test failed.", blex);
> 
> Preserve the original exception as it shows where the problem occurred.

The only thing left? I consider it important.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18259#discussion_r1524568506

From abhiscxk at openjdk.org  Thu Mar 14 10:11:41 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Thu, 14 Mar 2024 10:11:41 GMT
Subject: RFR: 8328021: Convert applet test
 java/awt/List/SetFontTest/SetFontTest.html to main program
In-Reply-To: <PDXY83ODTZ4gxjrMQMJIoLyXeDHkkHJBbsoMVKwL5bQ=.ba1001ce-1197-4ea8-b9c7-bee0605dbf83@github.com>
References: <PDXY83ODTZ4gxjrMQMJIoLyXeDHkkHJBbsoMVKwL5bQ=.ba1001ce-1197-4ea8-b9c7-bee0605dbf83@github.com>
Message-ID: <8mOuRoC4aJ-TF7NSC35Qh9w-TcjUg1dvbkpRoNNs01s=.8fe0cb9f-6918-4034-9030-80a1036b23e7@github.com>

On Tue, 12 Mar 2024 22:55:02 GMT, Phil Race <prr at openjdk.org> wrote:

> java/awt/List/SetFontTest/SetFontTest.html is a manual applet-based test.
> It can be converted to a main program test using PassFailJFrame

Marked as reviewed by abhiscxk (Committer).

test/jdk/java/awt/List/SetFontTest.java line 92:

> 90:         frame.add(button1);
> 91:         frame.add(button2);
> 92:         frame.setSize(200,250);

minor : 
Suggestion:

        frame.setSize(200, 250);

-------------

PR Review: https://git.openjdk.org/jdk/pull/18255#pullrequestreview-1936233608
PR Review Comment: https://git.openjdk.org/jdk/pull/18255#discussion_r1524580794

From abhiscxk at openjdk.org  Thu Mar 14 10:25:38 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Thu, 14 Mar 2024 10:25:38 GMT
Subject: RFR: 8328021: Convert applet test
 java/awt/List/SetFontTest/SetFontTest.html to main program
In-Reply-To: <PDXY83ODTZ4gxjrMQMJIoLyXeDHkkHJBbsoMVKwL5bQ=.ba1001ce-1197-4ea8-b9c7-bee0605dbf83@github.com>
References: <PDXY83ODTZ4gxjrMQMJIoLyXeDHkkHJBbsoMVKwL5bQ=.ba1001ce-1197-4ea8-b9c7-bee0605dbf83@github.com>
Message-ID: <b7svqyTpHBgX5k1qhFZLjbDM-jWDyfgecjhtRYo5CjU=.4edafbff-55ff-4185-a2b8-fd5e5acb3ebc@github.com>

On Tue, 12 Mar 2024 22:55:02 GMT, Phil Race <prr at openjdk.org> wrote:

> java/awt/List/SetFontTest/SetFontTest.html is a manual applet-based test.
> It can be converted to a main program test using PassFailJFrame

test/jdk/java/awt/List/SetFontTest.java line 42:

> 40: public class SetFontTest {
> 41: 
> 42:     static final String INSTRUCTIONS =

Looks cleaner with `Text Blocks`.

""" 
                    1) Click on the 'Enlarge font' button to enlarge font of the list.
                    2) If you see that the rows of the list overlap one another
                    then the test failed. Otherwise, go to step 3.
                    3) Click on the 'Change mode' button to set multiple-selection mode.
                    4) If you see that the rows of the list overlap one another
                    then the test failed. Otherwise, the test passed.""";

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18255#discussion_r1524600042

From kizune at openjdk.org  Thu Mar 14 10:34:06 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Thu, 14 Mar 2024 10:34:06 GMT
Subject: RFR: 8316388: Opensource five Swing component related regression
 tests [v4]
In-Reply-To: <tghuMnFzGvpgkpLTAieFkO9oseJF_rYQptWS0S32VRA=.76c2d537-fe1b-4cea-96dc-658d5e0b864b@github.com>
References: <lyqr03dS3RFZwQum85-sdTUI2flExMCQm9Dps70wX5w=.1e207aa6-34e2-48e5-866c-bc39eb8d479f@github.com>
 <9hBnCXqmWqizqPJKVIA8M8wL2i9lqgddkRMwMmIU4qM=.a09493e9-a861-4383-aa51-4e692f0acf67@github.com>
 <l9OECT3rO4xtyvPaduDgc9fOX8dHsK8PR-lIbnDx3G8=.f8c24649-d93b-431e-a9c2-bc16cfd9816f@github.com>
 <tghuMnFzGvpgkpLTAieFkO9oseJF_rYQptWS0S32VRA=.76c2d537-fe1b-4cea-96dc-658d5e0b864b@github.com>
Message-ID: <Gi_Hc-rt2aDDDUD_HHwIrzFrjj88xDopaZRbkIglLu4=.34b8409a-30dc-4e1e-aae0-ae6b2e520973@github.com>

On Thu, 14 Mar 2024 09:31:39 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> This is try-with-resources so if i will do it in main i will have to add synchronizing and closing of writer which is a strange trade-off so i would have to do try block anyways.
>
> Why would you need synchronisation?
> 
> 
>         try (Writer writer = Files.newBufferedWriter(frameContentFile)) {
>             writer.write(frameContentString);
>         }
> 
> would write out the contents of the file and close the file handle. In setupGui, you would still use `frameContentFile` object only which is `final` and immutable, therefore it's thread-safe.

And that's pretty much what i do here - except for the exception handling. I just do not see a reason to move it to main, it makes no difference except now the HTML creation will be split and harder to understand.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18259#discussion_r1524607845

From kizune at openjdk.org  Thu Mar 14 10:34:06 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Thu, 14 Mar 2024 10:34:06 GMT
Subject: RFR: 8316388: Opensource five Swing component related regression
 tests [v4]
In-Reply-To: <lyqr03dS3RFZwQum85-sdTUI2flExMCQm9Dps70wX5w=.1e207aa6-34e2-48e5-866c-bc39eb8d479f@github.com>
References: <lyqr03dS3RFZwQum85-sdTUI2flExMCQm9Dps70wX5w=.1e207aa6-34e2-48e5-866c-bc39eb8d479f@github.com>
Message-ID: <hvnnoMREj3lpyJcWtvvQqKoHL7tzB640OJLnPq0kOmw=.0bc51ea2-5c5f-41a1-aadd-333a0dafde8b@github.com>

> Cleaned up five more tests.
> 
> Continuation of https://github.com/openjdk/jdk/pull/18184
> 
> Unfortunately one of the commits rendered the whole PR invalid so i closed it and restarting it here.
> All comments from the previous review are addressed.

Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:

  Update test/jdk/javax/swing/JEditorPane/bug4325606.java
  
  Co-authored-by: Alexey Ivanov <alexey.ivanov at oracle.com>

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18259/files
  - new: https://git.openjdk.org/jdk/pull/18259/files/fa83e095..40585165

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18259&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18259&range=02-03

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/18259.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18259/head:pull/18259

PR: https://git.openjdk.org/jdk/pull/18259

From kizune at openjdk.org  Thu Mar 14 10:34:06 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Thu, 14 Mar 2024 10:34:06 GMT
Subject: RFR: 8316388: Opensource five Swing component related regression
 tests [v3]
In-Reply-To: <UROvD2_5rY9iL2EJPh2zFvhpASswTgIaVWS_UiVCTRo=.a466e7df-b85e-4a66-84f3-909af009e31c@github.com>
References: <lyqr03dS3RFZwQum85-sdTUI2flExMCQm9Dps70wX5w=.1e207aa6-34e2-48e5-866c-bc39eb8d479f@github.com>
 <8EQNKy3Uz6Lv16s6-hKGSSX7AtI9cVH3cB2UZwemte8=.12a3b862-f9b3-4ece-899e-650d622aef90@github.com>
 <e1SK-X45PDxJmdyI539EX6t6UeziMrQU2PU2uwliwYg=.b5d50bf7-0afd-47d1-a13a-73afd48af411@github.com>
 <UROvD2_5rY9iL2EJPh2zFvhpASswTgIaVWS_UiVCTRo=.a466e7df-b85e-4a66-84f3-909af009e31c@github.com>
Message-ID: <Vz0BWLxWvDUV6dNblNekaerLz6wzwhTDvVaOw2dI1ZQ=.b6f0f32d-2e0c-4522-b4f9-10b714e86e00@github.com>

On Thu, 14 Mar 2024 09:59:43 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> test/jdk/javax/swing/JEditorPane/bug4325606.java line 100:
>> 
>>> 98:                 Utilities.getRowStart(pane, pane.getCaretPosition());
>>> 99:             } catch (BadLocationException blex) {
>>> 100:                 throw new RuntimeException("Test failed.");
>> 
>> Suggestion:
>> 
>>                 throw new RuntimeException("Test failed.", blex);
>> 
>> Preserve the original exception as it shows where the problem occurred.
>
> The only thing left? I consider it important.

Done.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18259#discussion_r1524611456

From abhiscxk at openjdk.org  Thu Mar 14 10:36:41 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Thu, 14 Mar 2024 10:36:41 GMT
Subject: RFR: 8328035: Convert
 javax/swing/text/html/TableView/7030332/bug7030332.java applet test to main
In-Reply-To: <sa4wl3VTL1p3Zxmat10wUsqex-uQewN2R2N8tXTwFFo=.013c255b-d875-4b52-a0f0-403664011199@github.com>
References: <sa4wl3VTL1p3Zxmat10wUsqex-uQewN2R2N8tXTwFFo=.013c255b-d875-4b52-a0f0-403664011199@github.com>
Message-ID: <Mx8hsoxS4x4HwPwPISCUa4AbTTrRxlb6YgFTxihTtUc=.8c86ea8d-f767-484b-aa26-2d9011259954@github.com>

On Wed, 13 Mar 2024 06:59:02 GMT, Tejesh R <tr at openjdk.org> wrote:

> Convert javax/swing/text/html/TableView/7030332/bug7030332.java applet test to main based test using PassFailJFrame.

test/jdk/javax/swing/text/html/TableView/7030332/bug7030332.java line 37:

> 35: /* @test
> 36:  * @bug 7030332
> 37:  * @summary Default borders in tables looks incorrect JEditorPane

Is something missing in summary?

test/jdk/javax/swing/text/html/TableView/7030332/bug7030332.java line 47:

> 45:         String testInstructions = """
> 46:                 Compare Golden Images with rendered JEditorPane.
> 47:                 They should looks similar in each line.

Suggestion:

                They should look similar in each line.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18260#discussion_r1524615475
PR Review Comment: https://git.openjdk.org/jdk/pull/18260#discussion_r1524613250

From tr at openjdk.org  Thu Mar 14 10:43:58 2024
From: tr at openjdk.org (Tejesh R)
Date: Thu, 14 Mar 2024 10:43:58 GMT
Subject: RFR: 8328154: Convert sun/java2d/loops/CopyAreaSpeed.java applet test
 to main
Message-ID: <QHf2yYI8zQSoqYjld0VQjVQmFWrIk2f53wArMF0qL14=.a7a41b62-f301-4c7a-9da4-09603d95cbd5@github.com>

Convert  sun/java2d/loops/CopyAreaSpeed.java manual applet test to main based using PassFailJFrame. This is a performance measurement test which provide benchmark to compare the outcome with different releases. I have converted the test using a PassFailJFrame though PASS/FAIL doesn't matter here. The result have been shown in `JOptionPane` message.

-------------

Commit messages:
 - Conversion from Applet to Main

Changes: https://git.openjdk.org/jdk/pull/18296/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18296&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8328154
  Stats: 257 lines in 2 files changed: 34 ins; 198 del; 25 mod
  Patch: https://git.openjdk.org/jdk/pull/18296.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18296/head:pull/18296

PR: https://git.openjdk.org/jdk/pull/18296

From azvegint at openjdk.org  Thu Mar 14 10:44:42 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Thu, 14 Mar 2024 10:44:42 GMT
Subject: Integrated: 8328110: Allow simultaneous use of PassFailJFrame with
 split UI and additional windows
In-Reply-To: <eI8LV-JCDm0Y9cNYRO14jzecmYDY_Lh-ghiZXLsl3Uc=.9107f629-a355-456a-99ba-cb5e036b2fb4@github.com>
References: <eI8LV-JCDm0Y9cNYRO14jzecmYDY_Lh-ghiZXLsl3Uc=.9107f629-a355-456a-99ba-cb5e036b2fb4@github.com>
Message-ID: <I4Ips0nOpM6AuRp93XtHX5CX8rz0lbIXB6VsYNTRlgg=.d41bc940-2724-460b-b174-dff5903cc1e9@github.com>

On Wed, 13 Mar 2024 16:55:08 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

> It is currently blocked with an artificial check:
> 
> 
> if (panelCreator != null) {
>     if (splitUI && (testWindows != null || windowListCreator != null)) {
>         // TODO Is it required? We can support both
>         throw new IllegalStateException("Split UI is not allowed "
>                                         + "with additional windows");
>     }
> }
> 
> 
> We have a number of manual tests, which has some text area in the instruction window to print a feedback from the test to be evaluated by a tester.
> 
> Removing this check allows us to implement this.
> We can consider making a special methods for this later.
> 
> This is required for the #18250

This pull request has now been integrated.

Changeset: 11a3673d
Author:    Alexander Zvegintsev <azvegint at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/11a3673d42edbefef70228b4d14595aab11fdac4
Stats:     8 lines in 1 file changed: 0 ins; 8 del; 0 mod

8328110: Allow simultaneous use of PassFailJFrame with split UI and additional windows

Reviewed-by: aivanov, honkar

-------------

PR: https://git.openjdk.org/jdk/pull/18281

From tr at openjdk.org  Thu Mar 14 10:52:59 2024
From: tr at openjdk.org (Tejesh R)
Date: Thu, 14 Mar 2024 10:52:59 GMT
Subject: Integrated: 8327826: Convert javax/swing/border/Test4243289.java
 applet test to main
In-Reply-To: <M5kMa3NPTVyzBZK7rPRT_gAHTQgVjPY_in-ZZJ8i1zM=.f1def8d8-79cd-4b03-88d2-4016a937d08d@github.com>
References: <M5kMa3NPTVyzBZK7rPRT_gAHTQgVjPY_in-ZZJ8i1zM=.f1def8d8-79cd-4b03-88d2-4016a937d08d@github.com>
Message-ID: <zl3qE4XraDbEQlaRtSoP-gCdI3dHiAgMjyV2WzLm7Qg=.b2d32e33-5222-4ed6-a210-80d037c400cb@github.com>

On Mon, 11 Mar 2024 14:46:11 GMT, Tejesh R <tr at openjdk.org> wrote:

> Convert javax/swing/border/Test4243289.java applet test to main based test using PassFailJFrame.

This pull request has now been integrated.

Changeset: a43c3cc3
Author:    Tejesh R <tr at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/a43c3cc3476f18c048809bcd08f81fc4288ca399
Stats:     69 lines in 2 files changed: 24 ins; 33 del; 12 mod

8327826: Convert javax/swing/border/Test4243289.java applet test to main

Reviewed-by: aivanov, abhiscxk

-------------

PR: https://git.openjdk.org/jdk/pull/18197

From tr at openjdk.org  Thu Mar 14 10:52:58 2024
From: tr at openjdk.org (Tejesh R)
Date: Thu, 14 Mar 2024 10:52:58 GMT
Subject: RFR: 8327826: Convert javax/swing/border/Test4243289.java applet
 test to main [v4]
In-Reply-To: <M5kMa3NPTVyzBZK7rPRT_gAHTQgVjPY_in-ZZJ8i1zM=.f1def8d8-79cd-4b03-88d2-4016a937d08d@github.com>
References: <M5kMa3NPTVyzBZK7rPRT_gAHTQgVjPY_in-ZZJ8i1zM=.f1def8d8-79cd-4b03-88d2-4016a937d08d@github.com>
Message-ID: <S5GKFSlc_vLIZo9wXzzAPR-1e7ae6xqdestE8qIH5vM=.e5f6f04f-4e08-4c0e-894b-e0cae5d5dffd@github.com>

> Convert javax/swing/border/Test4243289.java applet test to main based test using PassFailJFrame.

Tejesh R has updated the pull request incrementally with one additional commit since the last revision:

  Review updates

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18197/files
  - new: https://git.openjdk.org/jdk/pull/18197/files/9077a872..379f796f

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18197&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18197&range=02-03

  Stats: 2 lines in 1 file changed: 1 ins; 1 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18197.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18197/head:pull/18197

PR: https://git.openjdk.org/jdk/pull/18197

From aivanov at openjdk.org  Thu Mar 14 10:57:41 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Thu, 14 Mar 2024 10:57:41 GMT
Subject: RFR: 8316388: Opensource five Swing component related regression
 tests [v4]
In-Reply-To: <hvnnoMREj3lpyJcWtvvQqKoHL7tzB640OJLnPq0kOmw=.0bc51ea2-5c5f-41a1-aadd-333a0dafde8b@github.com>
References: <lyqr03dS3RFZwQum85-sdTUI2flExMCQm9Dps70wX5w=.1e207aa6-34e2-48e5-866c-bc39eb8d479f@github.com>
 <hvnnoMREj3lpyJcWtvvQqKoHL7tzB640OJLnPq0kOmw=.0bc51ea2-5c5f-41a1-aadd-333a0dafde8b@github.com>
Message-ID: <QfrEUbtmwrBdatLN7I9TCi2Rau2m1lUmPcnift7xyf0=.aa85260b-7276-41ed-bee3-fa3acde54ddc@github.com>

On Thu, 14 Mar 2024 10:34:06 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

>> Cleaned up five more tests.
>> 
>> Continuation of https://github.com/openjdk/jdk/pull/18184
>> 
>> Unfortunately one of the commits rendered the whole PR invalid so i closed it and restarting it here.
>> All comments from the previous review are addressed.
>
> Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update test/jdk/javax/swing/JEditorPane/bug4325606.java
>   
>   Co-authored-by: Alexey Ivanov <alexey.ivanov at oracle.com>

Marked as reviewed by aivanov (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18259#pullrequestreview-1936332431

From tr at openjdk.org  Thu Mar 14 10:57:45 2024
From: tr at openjdk.org (Tejesh R)
Date: Thu, 14 Mar 2024 10:57:45 GMT
Subject: Integrated: 8327787: Convert javax/swing/border/Test4129681.java
 applet test to main
In-Reply-To: <uZ3hGgyIWuMOTp6qSVNw_3r-F4REh4QvrzqAtH8fMo8=.e55e311d-c0d7-4863-9e8a-0d1edc1d8857@github.com>
References: <uZ3hGgyIWuMOTp6qSVNw_3r-F4REh4QvrzqAtH8fMo8=.e55e311d-c0d7-4863-9e8a-0d1edc1d8857@github.com>
Message-ID: <w56Es1GXPMNCitpXHNT5dwvzDi9Pombu-ITPkiNEBp4=.a56a223e-2cf0-43a5-83e9-6fd53b1cb289@github.com>

On Mon, 11 Mar 2024 11:10:14 GMT, Tejesh R <tr at openjdk.org> wrote:

> Convert javax/swing/border/Test4129681.java applet test to main based test using PassFailJFrame.

This pull request has now been integrated.

Changeset: ad0f3294
Author:    Tejesh R <tr at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/ad0f329493a73020899640b0815e33ee6d3ea78d
Stats:     82 lines in 2 files changed: 23 ins; 43 del; 16 mod

8327787: Convert javax/swing/border/Test4129681.java applet test to main

Reviewed-by: aivanov, abhiscxk

-------------

PR: https://git.openjdk.org/jdk/pull/18189

From ihse at openjdk.org  Thu Mar 14 10:59:48 2024
From: ihse at openjdk.org (Magnus Ihse Bursie)
Date: Thu, 14 Mar 2024 10:59:48 GMT
Subject: RFR: 8328146: Set LIBCXX automatically
Message-ID: <G4PfVrm0hXu7yxO8Kl2TxJ1zoxzW7NQ7WEwUWxM6zMs=.b0f7e904-1c70-4349-b987-1ca60aa2fb15@github.com>

We are adding LIBCXX to LIBS in calls to SetupJdkLibrary whenever LINK_TYPE is C++. We should do this automatically in SetupJdkLibrary for C++ linking.

I also removed the superfluous `-lc` from some places where it had been added.

-------------

Commit messages:
 - 8328146: Set LIBCXX automatically

Changes: https://git.openjdk.org/jdk/pull/18298/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18298&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8328146
  Stats: 27 lines in 10 files changed: 8 ins; 4 del; 15 mod
  Patch: https://git.openjdk.org/jdk/pull/18298.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18298/head:pull/18298

PR: https://git.openjdk.org/jdk/pull/18298

From aivanov at openjdk.org  Thu Mar 14 11:00:45 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Thu, 14 Mar 2024 11:00:45 GMT
Subject: Integrated: 8325851: Hide PassFailJFrame.Builder constructor
In-Reply-To: <NPUEOS3SWj0H7KALdlwfdfJSxqsrpTyn9X4c1N-H8Ho=.cb175d1a-0a9b-4e23-98ae-404101a20531@github.com>
References: <NPUEOS3SWj0H7KALdlwfdfJSxqsrpTyn9X4c1N-H8Ho=.cb175d1a-0a9b-4e23-98ae-404101a20531@github.com>
Message-ID: <_8OiwezmXJmJ7UE3w0c0Dzpt3crq-C7wCTnrhpAULz8=.e7dc0297-badb-46d9-b18f-57a76972f786@github.com>

On Mon, 11 Mar 2024 21:18:40 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> The `Builder` class in `PassFailJFrame` is public and has a public constructor. At the same time, a better design would be to hide all the Builder constructors and rely on the `builder()` method which returns an instance of the `Builder` class.
> 
> This PR makes the constructor of the `Builder` class private so that it's not accessible directly.
> 
> Use `PassFailJFrame.builder()` to get an instance of the builder and configure parameters of `PassFailJFrame`.
> 
> I updated all the tests which used the constructor directly by calling `new PassFailJFrame.Builder()`.
> 
> I converted a few tests to use the `testUI`, which greatly simplifies the test code. This change also removes flickering of the test UI.

This pull request has now been integrated.

Changeset: 3b9255eb
Author:    Alexey Ivanov <aivanov at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/3b9255eb663b4c90aa5cec89f0d9380ef8eba49e
Stats:     242 lines in 21 files changed: 14 ins; 118 del; 110 mod

8325851: Hide PassFailJFrame.Builder constructor

Reviewed-by: honkar, prr

-------------

PR: https://git.openjdk.org/jdk/pull/18206

From tr at openjdk.org  Thu Mar 14 11:02:52 2024
From: tr at openjdk.org (Tejesh R)
Date: Thu, 14 Mar 2024 11:02:52 GMT
Subject: RFR: 8328035: Convert
 javax/swing/text/html/TableView/7030332/bug7030332.java applet test to main
 [v2]
In-Reply-To: <sa4wl3VTL1p3Zxmat10wUsqex-uQewN2R2N8tXTwFFo=.013c255b-d875-4b52-a0f0-403664011199@github.com>
References: <sa4wl3VTL1p3Zxmat10wUsqex-uQewN2R2N8tXTwFFo=.013c255b-d875-4b52-a0f0-403664011199@github.com>
Message-ID: <_k4T1yzAqADVQLTUScWnfSqbGYg-YZJ9SecWpQB55kM=.ffa6e901-7cee-40b6-954a-528dfb04dc83@github.com>

> Convert javax/swing/text/html/TableView/7030332/bug7030332.java applet test to main based test using PassFailJFrame.

Tejesh R has updated the pull request incrementally with one additional commit since the last revision:

  Review updates

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18260/files
  - new: https://git.openjdk.org/jdk/pull/18260/files/130bf5b3..8c40a81b

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18260&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18260&range=00-01

  Stats: 3 lines in 1 file changed: 1 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/18260.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18260/head:pull/18260

PR: https://git.openjdk.org/jdk/pull/18260

From tr at openjdk.org  Thu Mar 14 11:02:52 2024
From: tr at openjdk.org (Tejesh R)
Date: Thu, 14 Mar 2024 11:02:52 GMT
Subject: RFR: 8328035: Convert
 javax/swing/text/html/TableView/7030332/bug7030332.java applet test to main
 [v2]
In-Reply-To: <Mx8hsoxS4x4HwPwPISCUa4AbTTrRxlb6YgFTxihTtUc=.8c86ea8d-f767-484b-aa26-2d9011259954@github.com>
References: <sa4wl3VTL1p3Zxmat10wUsqex-uQewN2R2N8tXTwFFo=.013c255b-d875-4b52-a0f0-403664011199@github.com>
 <Mx8hsoxS4x4HwPwPISCUa4AbTTrRxlb6YgFTxihTtUc=.8c86ea8d-f767-484b-aa26-2d9011259954@github.com>
Message-ID: <WkK1Km-Bn1owrFgVX_UAo9oVTblzn3wWoMRH0Lu9L24=.01a9551c-90fe-4c2e-a57c-0cf33e05f4b0@github.com>

On Thu, 14 Mar 2024 10:34:20 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review updates
>
> test/jdk/javax/swing/text/html/TableView/7030332/bug7030332.java line 37:
> 
>> 35: /* @test
>> 36:  * @bug 7030332
>> 37:  * @summary Default borders in tables looks incorrect JEditorPane
> 
> Is something missing in summary?

Modified it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18260#discussion_r1524647558

From aivanov at openjdk.org  Thu Mar 14 11:06:05 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Thu, 14 Mar 2024 11:06:05 GMT
Subject: RFR: 8327924: Simplify TrayIconScalingTest.java [v2]
In-Reply-To: <v4lDY1J2WCp2RqxfYXNYImaEx5EOeX2x4LM23n93Zrs=.010ab607-ba30-484d-b293-460ed4444b1a@github.com>
References: <v4lDY1J2WCp2RqxfYXNYImaEx5EOeX2x4LM23n93Zrs=.010ab607-ba30-484d-b293-460ed4444b1a@github.com>
Message-ID: <9mYIwIdmyK_x79tut5_2KNa677wZvqvv4pkj50X3mLU=.46b8baa0-0d75-4070-8d5f-1a01b5fde61c@github.com>

> This is to simplify `TrayIconScalingTest.java`.
> 
> 1. Rename `createAndShowGUI` to `createAndShowTrayIcon` which is more specific.
> 2. Move creating tray icon to the top.
> 3. Streamline PassFailJFrame with the chained calls, including `awaitAndCheck`.
> 4. Ensure tray is not null before removing the icon.
> 5. Pass AWTException as the cause in the wrapped exception.
> 
> Previously, before the builder pattern was introduced, `PassFailJFrame.positionTestWindow` had had to be called to show the instructions UI. It's not required any more. Additionally, it has the effect of moving the instruction frame to the left, which doesn't look good and sometimes results in positioning the instructions outside of the screen bounds if the screen resolution is low.
> 
> With the builder pattern, the call to the `build` method shows all the registered windows on the screen, including the instruction frame. Since there's no secondary UI, the instructions remain in the centre of the screen.

Alexey Ivanov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18224/files
  - new: https://git.openjdk.org/jdk/pull/18224/files/b0e9218f..b0e9218f

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18224&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18224&range=00-01

  Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18224.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18224/head:pull/18224

PR: https://git.openjdk.org/jdk/pull/18224

From aivanov at openjdk.org  Thu Mar 14 11:37:47 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Thu, 14 Mar 2024 11:37:47 GMT
Subject: RFR: 8327924: Simplify TrayIconScalingTest.java [v3]
In-Reply-To: <v4lDY1J2WCp2RqxfYXNYImaEx5EOeX2x4LM23n93Zrs=.010ab607-ba30-484d-b293-460ed4444b1a@github.com>
References: <v4lDY1J2WCp2RqxfYXNYImaEx5EOeX2x4LM23n93Zrs=.010ab607-ba30-484d-b293-460ed4444b1a@github.com>
Message-ID: <-rIyMZ8jGI7vy5gAgxuf_JO3EBSd5fGSkLumgK1tRNg=.825c7e8e-c75e-4bc9-b710-a8db6f25ee56@github.com>

> This is to simplify `TrayIconScalingTest.java`.
> 
> 1. Rename `createAndShowGUI` to `createAndShowTrayIcon` which is more specific.
> 2. Move creating tray icon to the top.
> 3. Streamline PassFailJFrame with the chained calls, including `awaitAndCheck`.
> 4. Ensure tray is not null before removing the icon.
> 5. Pass AWTException as the cause in the wrapped exception.
> 
> Previously, before the builder pattern was introduced, `PassFailJFrame.positionTestWindow` had had to be called to show the instructions UI. It's not required any more. Additionally, it has the effect of moving the instruction frame to the left, which doesn't look good and sometimes results in positioning the instructions outside of the screen bounds if the screen resolution is low.
> 
> With the builder pattern, the call to the `build` method shows all the registered windows on the screen, including the instruction frame. Since there's no secondary UI, the instructions remain in the centre of the screen.

Alexey Ivanov has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 18 commits:

 - Merge master
 - Pass AWTException as the cause in the wrapped exception
 - Re-arrange the code in TrayIconScalingTest.java
   
   Rename createAndShowGUI to createAndShowTrayIcon which is more specific.
   Move creating tray icon to the top.
   Streamline PassFailJFrame with the chained calls.
   Ensure tray is not null before removing the icon.
 - Minor updates to createUI in ComboPopupBug
 - Use testUI in ComboPopupBug
 - Use testUI in DefaultCloseOperation and reduce the number of columns
 - Use testUI in LightweightCliprect
 - Remove unused EventQueue import
 - Use testUI in DefaultSizeTest
 - Use testUI in FrameRepackTest
 - ... and 8 more: https://git.openjdk.org/jdk/compare/3b9255eb...7e10304a

-------------

Changes: https://git.openjdk.org/jdk/pull/18224/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18224&range=02
  Stats: 27 lines in 1 file changed: 10 ins; 11 del; 6 mod
  Patch: https://git.openjdk.org/jdk/pull/18224.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18224/head:pull/18224

PR: https://git.openjdk.org/jdk/pull/18224

From aivanov at openjdk.org  Thu Mar 14 11:46:40 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Thu, 14 Mar 2024 11:46:40 GMT
Subject: RFR: 8327924: Simplify TrayIconScalingTest.java [v2]
In-Reply-To: <6JqcozfzKx1Ec8z9bT_uCZ7Dm9tTexqdmVYEbvTRBno=.409249f8-b6aa-4374-8213-4f8681490623@github.com>
References: <v4lDY1J2WCp2RqxfYXNYImaEx5EOeX2x4LM23n93Zrs=.010ab607-ba30-484d-b293-460ed4444b1a@github.com>
 <6JqcozfzKx1Ec8z9bT_uCZ7Dm9tTexqdmVYEbvTRBno=.409249f8-b6aa-4374-8213-4f8681490623@github.com>
Message-ID: <DyxCLqwNQuz9c2Htj6UCFq8dqHqIUZJXJVAIUh_p_js=.6165a27e-8d4f-44ae-8c6b-8f551af321a0@github.com>

On Wed, 13 Mar 2024 22:04:00 GMT, Phil Race <prr at openjdk.org> wrote:

>> Alexey Ivanov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase.
>
> test/jdk/java/awt/TrayIcon/TrayIconScalingTest.java line 97:
> 
>> 95:                     .testTimeOut(8)
>> 96:                     .rows(25)
>> 97:                     .columns(70)
> 
> Personally I like rows+columns to immediately follow instructions,
> but I'll approve anyway and let you decide.

I haven't changed these lines, only indentation is changed because I moved it into `try` block.

I prefer keeping it as is so that these lines are attributed to Lawrence who modified the lines when he introduced the builder.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18224#discussion_r1524700032

From rkannathpari at openjdk.org  Thu Mar 14 11:55:48 2024
From: rkannathpari at openjdk.org (Renjith Kannath Pariyangad)
Date: Thu, 14 Mar 2024 11:55:48 GMT
Subject: RFR: JDK-8320675 : PrinterJob/SecurityDialogTest.java hangs
Message-ID: <OMBWLwH7044RMtwdrZSiahQDdy-1T-4oJjOQgnQEKjI=.18a31ad0-710f-44e5-86ec-b4566946b063@github.com>

Hi Reviewers,

I have updated the test with  PassFailJFrame with information panel, earlier this was informed through terminal.
Please review and let me know your suggestions if any.

-------------

Commit messages:
 - Removed extra space before instruction lines
 - Updated with message
 - Use new PageFormat() for pageDialog
 - Move printing services after Security Manager is set
 - Update instructions
 - Refactor the test
 - JDK-8320675 : PrinterJob/SecurityDialogTest.java hangs

Changes: https://git.openjdk.org/jdk/pull/18299/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18299&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8320675
  Stats: 232 lines in 1 file changed: 47 ins; 149 del; 36 mod
  Patch: https://git.openjdk.org/jdk/pull/18299.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18299/head:pull/18299

PR: https://git.openjdk.org/jdk/pull/18299

From abhiscxk at openjdk.org  Thu Mar 14 12:17:03 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Thu, 14 Mar 2024 12:17:03 GMT
Subject: RFR: 8328035: Convert
 javax/swing/text/html/TableView/7030332/bug7030332.java applet test to main
 [v2]
In-Reply-To: <_k4T1yzAqADVQLTUScWnfSqbGYg-YZJ9SecWpQB55kM=.ffa6e901-7cee-40b6-954a-528dfb04dc83@github.com>
References: <sa4wl3VTL1p3Zxmat10wUsqex-uQewN2R2N8tXTwFFo=.013c255b-d875-4b52-a0f0-403664011199@github.com>
 <_k4T1yzAqADVQLTUScWnfSqbGYg-YZJ9SecWpQB55kM=.ffa6e901-7cee-40b6-954a-528dfb04dc83@github.com>
Message-ID: <MWrDKJNtv3tgAM_5zfXz2Js6ioEuG002f5UCfE7StJ8=.34c43b19-05fc-45d4-9bd0-3a9af1a37e78@github.com>

On Thu, 14 Mar 2024 11:02:52 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Convert javax/swing/text/html/TableView/7030332/bug7030332.java applet test to main based test using PassFailJFrame.
>
> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review updates

LGTM.

-------------

Marked as reviewed by abhiscxk (Committer).

PR Review: https://git.openjdk.org/jdk/pull/18260#pullrequestreview-1936486148

From aivanov at openjdk.org  Thu Mar 14 12:24:03 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Thu, 14 Mar 2024 12:24:03 GMT
Subject: RFR: 8327924: Simplify TrayIconScalingTest.java [v2]
In-Reply-To: <DyxCLqwNQuz9c2Htj6UCFq8dqHqIUZJXJVAIUh_p_js=.6165a27e-8d4f-44ae-8c6b-8f551af321a0@github.com>
References: <v4lDY1J2WCp2RqxfYXNYImaEx5EOeX2x4LM23n93Zrs=.010ab607-ba30-484d-b293-460ed4444b1a@github.com>
 <6JqcozfzKx1Ec8z9bT_uCZ7Dm9tTexqdmVYEbvTRBno=.409249f8-b6aa-4374-8213-4f8681490623@github.com>
 <DyxCLqwNQuz9c2Htj6UCFq8dqHqIUZJXJVAIUh_p_js=.6165a27e-8d4f-44ae-8c6b-8f551af321a0@github.com>
Message-ID: <sw0zaUz4qVite11UEhG4pP9u4pN162jIyvovO6enxZU=.b0383d2a-9d8e-47bf-9aba-2c1ff5958016@github.com>

On Thu, 14 Mar 2024 11:43:44 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> test/jdk/java/awt/TrayIcon/TrayIconScalingTest.java line 97:
>> 
>>> 95:                     .testTimeOut(8)
>>> 96:                     .rows(25)
>>> 97:                     .columns(70)
>> 
>> Personally I like rows+columns to immediately follow instructions,
>> but I'll approve anyway and let you decide.
>
> I haven't changed these lines, only indentation is changed because I moved it into `try` block.
> 
> I prefer keeping it as is so that these lines are attributed to Lawrence who modified the lines when he introduced the builder.

It would be good to get rid of `.rows` and `.columns` at all. I can't remember why using `JTextArea.getPreferredSize()` wasn't enough to size the instructions so that there are no scrollbars.

I submitted [JDK-8328163](https://bugs.openjdk.org/browse/JDK-8328163): _Implement automatic instruction sizing for PassFailJFrame_. Let's see if it's doable.

I saw some use `.rows((int) INSTRUCTIONS.lines().count() + 1)`, which implies the number of rows can be automatically calculated? up to a reasonable limit. The number of columns needed can also be estimated. I think `JTextArea.getPreferredSize()` should handle most cases.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18224#discussion_r1524742691

From abhiscxk at openjdk.org  Thu Mar 14 12:28:03 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Thu, 14 Mar 2024 12:28:03 GMT
Subject: RFR: 8327876: Convert javax/swing/border/Test4252164.java applet
 test to main
In-Reply-To: <Nc7KlfEEQnoms0Ja9qgzfbVjkrWbZXjkcfU1pL6XdU0=.6fa50ee3-8610-43b3-8b3f-913f40281a5e@github.com>
References: <Nc7KlfEEQnoms0Ja9qgzfbVjkrWbZXjkcfU1pL6XdU0=.6fa50ee3-8610-43b3-8b3f-913f40281a5e@github.com>
Message-ID: <cjGUCnX00n-ULeYYhsK6UCfRvvenSMhgg5hd9_GS1AM=.e8f68187-e2e2-4ead-8201-52a0cbb3b8d1@github.com>

On Tue, 12 Mar 2024 06:56:20 GMT, Tejesh R <tr at openjdk.org> wrote:

> Convert javax/swing/border/Test4252164.java applet test to main based test using PassFailJFrame.

Marked as reviewed by abhiscxk (Committer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18216#pullrequestreview-1936509329

From abhiscxk at openjdk.org  Thu Mar 14 12:35:40 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Thu, 14 Mar 2024 12:35:40 GMT
Subject: RFR: 8327835: Convert
 java/awt/FileDialog/RegexpFilterTest/RegexpFilterTest applet test to main [v3]
In-Reply-To: <eznjGudEzhwQkzYNcW8TH-dMrbFF1xxfpXXmae22WXM=.edbd8ad0-840f-4c49-8d05-79348c7322c5@github.com>
References: <O_XrLLXwQtMWjKGEoOaYSM8RdDnyH3LF3-Bdp5PDRHo=.72bb3619-6cfc-43c8-83d6-c87eabf24636@github.com>
 <eznjGudEzhwQkzYNcW8TH-dMrbFF1xxfpXXmae22WXM=.edbd8ad0-840f-4c49-8d05-79348c7322c5@github.com>
Message-ID: <YcbtLQROB70q3hVV9i_AcYQjZtOzkLO6ElwxLbkKJwM=.748352fa-67b4-41f5-8681-f38c3313c326@github.com>

On Tue, 12 Mar 2024 10:25:28 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>> The `java/awt/FileDialog/RegexpFilterTest/RegexpFilterTest` test is written to test the very specific functionality of `XFileDialogPeer`, so it shouldn't be run on platforms other than Linux.
>> 
>> We also need to set `sun.awt.disableGtkFileDialogs` to `true` to be able to test `XFileDialogPeer`, because by default it tries to use the Gtk file dialog if it is available.
>> The Gtk file dialog has a search field hidden under the magnifying glass icon, but it has a different syntax.
>> 
>> The Windows system file dialog allows you to use wildcard filtering in the "File name" field by hitting the `enter` afterwards, but again, this test was written to test our own file dialog implementation, not the system's.
>
> Alexander Zvegintsev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   review comments

Marked as reviewed by abhiscxk (Committer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18203#pullrequestreview-1936528345

From kizune at openjdk.org  Thu Mar 14 12:32:06 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Thu, 14 Mar 2024 12:32:06 GMT
Subject: RFR: 8328158: Convert java/awt/Choice/NonFocusablePopupMenuTest to
 automatic main test
Message-ID: <5o5Qhfltwmw1WbGujddcfKdNxIQahHyXXFHhaYfrLsM=.6437d7e5-ad8c-43be-b04c-3f45c0c9c54a@github.com>

Convert test to the automatic main and move it from its own folder since it is no longer required.

-------------

Commit messages:
 - 8328158: Convert java/awt/Choice/NonFocusablePopupMenuTest to automatic main test

Changes: https://git.openjdk.org/jdk/pull/18300/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18300&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8328158
  Stats: 351 lines in 3 files changed: 94 ins; 257 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18300.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18300/head:pull/18300

PR: https://git.openjdk.org/jdk/pull/18300

From ihse at openjdk.org  Thu Mar 14 12:40:59 2024
From: ihse at openjdk.org (Magnus Ihse Bursie)
Date: Thu, 14 Mar 2024 12:40:59 GMT
Subject: RFR: 8328157: Move C[XX]FLAGS_JDK[LIB/EXE] to JdkNativeCompilation.gmk
Message-ID: <HWRIVhg1Alb0zwfbVmKdAcAlfLX2uEblr5a06TmAzDc=.0c11539b-e1a0-44f1-9ce1-1d9e49e1f2bf@github.com>

We are setting one of the flags `CFLAGS_JDKLIB`, `CXXFLAGS_JDKLIB`, `CFLAGS_JDKEXE` or `CXXFLAGS_JDKEXE` to `CFLAGS` or `CXXFLAGS`, respectively, in basically all calls to `SetupJdkLibrary` and `SetupJdkExecutable`.

These flag variables contain a lot of duplication.

The first step towards bringing some sanity to this mess is to move the setting of these variables into `SetupJdkLibrary/SetupJdkExecutable`.

In a few places these standard flags are not set, partially or fullly. This is handled by the new arguments `DEFAULT_CFLAGS := false` (to disable the entire setting) and `C[XX]FLAGS_FILTER_OUT` (which excludes some specific flag) to `SetupJdkLibrary/SetupJdkExecutable`.

-------------

Commit messages:
 - 8328157: Move C[XX]FLAGS_JDK[LIB/EXE] to JdkNativeCompilation.gmk

Changes: https://git.openjdk.org/jdk/pull/18301/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18301&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8328157
  Stats: 170 lines in 31 files changed: 45 ins; 66 del; 59 mod
  Patch: https://git.openjdk.org/jdk/pull/18301.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18301/head:pull/18301

PR: https://git.openjdk.org/jdk/pull/18301

From ihse at openjdk.org  Thu Mar 14 12:40:59 2024
From: ihse at openjdk.org (Magnus Ihse Bursie)
Date: Thu, 14 Mar 2024 12:40:59 GMT
Subject: RFR: 8328157: Move C[XX]FLAGS_JDK[LIB/EXE] to
 JdkNativeCompilation.gmk
In-Reply-To: <HWRIVhg1Alb0zwfbVmKdAcAlfLX2uEblr5a06TmAzDc=.0c11539b-e1a0-44f1-9ce1-1d9e49e1f2bf@github.com>
References: <HWRIVhg1Alb0zwfbVmKdAcAlfLX2uEblr5a06TmAzDc=.0c11539b-e1a0-44f1-9ce1-1d9e49e1f2bf@github.com>
Message-ID: <bB4J2iWMPAT_zrDk8K3yy0fMbt0CftBhh5j0iK2hEA0=.27809d16-3c01-40b0-a19e-63f84062c4f8@github.com>

On Thu, 14 Mar 2024 12:36:05 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

> We are setting one of the flags `CFLAGS_JDKLIB`, `CXXFLAGS_JDKLIB`, `CFLAGS_JDKEXE` or `CXXFLAGS_JDKEXE` to `CFLAGS` or `CXXFLAGS`, respectively, in basically all calls to `SetupJdkLibrary` and `SetupJdkExecutable`.
> 
> These flag variables contain a lot of duplication.
> 
> The first step towards bringing some sanity to this mess is to move the setting of these variables into `SetupJdkLibrary/SetupJdkExecutable`.
> 
> In a few places these standard flags are not set, partially or fullly. This is handled by the new arguments `DEFAULT_CFLAGS := false` (to disable the entire setting) and `C[XX]FLAGS_FILTER_OUT` (which excludes some specific flag) to `SetupJdkLibrary/SetupJdkExecutable`.

I have verified with `COMPARE_BUILD` that there is no significant difference in the build result with or without this patch on Oracle default CI platforms (linux x64/aarch64, macos x64/aarch64, windows x64).

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18301#issuecomment-1997359912

From abhiscxk at openjdk.org  Thu Mar 14 12:47:40 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Thu, 14 Mar 2024 12:47:40 GMT
Subject: RFR: 8328158: Convert java/awt/Choice/NonFocusablePopupMenuTest to
 automatic main test
In-Reply-To: <5o5Qhfltwmw1WbGujddcfKdNxIQahHyXXFHhaYfrLsM=.6437d7e5-ad8c-43be-b04c-3f45c0c9c54a@github.com>
References: <5o5Qhfltwmw1WbGujddcfKdNxIQahHyXXFHhaYfrLsM=.6437d7e5-ad8c-43be-b04c-3f45c0c9c54a@github.com>
Message-ID: <OeDn08P18rFZMo4meLm_2eCBHRIzacMVtwrg2gzwXhY=.a4349902-5154-4353-a1d8-2c9a91ce379f@github.com>

On Thu, 14 Mar 2024 12:27:29 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

> Convert test to the automatic main and move it from its own folder since it is no longer required.

test/jdk/java/awt/Choice/NonFocusablePopupMenuTest.java line 46:

> 44:     Choice choice;
> 45:     Point pos;
> 46:     Dimension size;

Should we declare `Point` and `Dimesnion` variable as volatile?

test/jdk/java/awt/Choice/NonFocusablePopupMenuTest.java line 65:

> 63:         });
> 64:         robot.waitForIdle();
> 65:         SwingUtilities.invokeAndWait(() -> {

Is it ok to have SwingUtilities.invokeAndWait? 
Or should we use EventQueue.invokeAndWait ?

test/jdk/java/awt/Choice/NonFocusablePopupMenuTest.java line 69:

> 67:             size = choice.getSize();
> 68:         });
> 69:         int selected = choice.getSelectedIndex();

choice accessed outside EDT.

test/jdk/java/awt/Choice/NonFocusablePopupMenuTest.java line 74:

> 72:         robot.mouseRelease(InputEvent.BUTTON1_DOWN_MASK);
> 73:         robot.waitForIdle();
> 74:         robot.delay(500);

Any specific reason to have 500 ms delay. Can it be reduced?

test/jdk/java/awt/Choice/NonFocusablePopupMenuTest.java line 79:

> 77:         robot.mouseRelease(InputEvent.BUTTON1_DOWN_MASK);
> 78:         robot.waitForIdle();
> 79:         robot.delay(500);

same here as well.

test/jdk/java/awt/Choice/NonFocusablePopupMenuTest.java line 84:

> 82:             dispose();
> 83:         });
> 84:         if (choice.getSelectedIndex() == selected) {

`choice.getSelectedIndex()` accessed outside EDT.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18300#discussion_r1524770591
PR Review Comment: https://git.openjdk.org/jdk/pull/18300#discussion_r1524773238
PR Review Comment: https://git.openjdk.org/jdk/pull/18300#discussion_r1524773831
PR Review Comment: https://git.openjdk.org/jdk/pull/18300#discussion_r1524775195
PR Review Comment: https://git.openjdk.org/jdk/pull/18300#discussion_r1524775871
PR Review Comment: https://git.openjdk.org/jdk/pull/18300#discussion_r1524777069

From abhiscxk at openjdk.org  Thu Mar 14 12:48:40 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Thu, 14 Mar 2024 12:48:40 GMT
Subject: RFR: 8328124: Convert java/awt/Frame/ShownOnPack/ShownOnPack.html
 applet test to main
In-Reply-To: <yC3Qtep10q3KRJrCfQv-ThrGmE7xdedwQjrr0dBMVMw=.9b87a76e-5af8-411e-bd31-dd8f390d6b24@github.com>
References: <yC3Qtep10q3KRJrCfQv-ThrGmE7xdedwQjrr0dBMVMw=.9b87a76e-5af8-411e-bd31-dd8f390d6b24@github.com>
Message-ID: <5dy-uoP7lADTPqGeMNClHISMMNVszCHrou5ws8_SzS8=.6b2a6f02-ddc4-4283-8f1d-8c7f634c29b2@github.com>

On Wed, 13 Mar 2024 19:43:10 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

> The test is converted to main.
> Tested on Linux, Macos and Windows.

LGTM.

test/jdk/java/awt/Frame/ShownOnPack/ShownOnPack.java line 34:

> 32:  * @build PassFailJFrame
> 33:  * @run main/manual ShownOnPack
> 34: */

May add a blank line after this.

-------------

Marked as reviewed by abhiscxk (Committer).

PR Review: https://git.openjdk.org/jdk/pull/18287#pullrequestreview-1936565858
PR Review Comment: https://git.openjdk.org/jdk/pull/18287#discussion_r1524784087

From kizune at openjdk.org  Thu Mar 14 12:47:41 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Thu, 14 Mar 2024 12:47:41 GMT
Subject: RFR: 8328158: Convert java/awt/Choice/NonFocusablePopupMenuTest to
 automatic main test
In-Reply-To: <OeDn08P18rFZMo4meLm_2eCBHRIzacMVtwrg2gzwXhY=.a4349902-5154-4353-a1d8-2c9a91ce379f@github.com>
References: <5o5Qhfltwmw1WbGujddcfKdNxIQahHyXXFHhaYfrLsM=.6437d7e5-ad8c-43be-b04c-3f45c0c9c54a@github.com>
 <OeDn08P18rFZMo4meLm_2eCBHRIzacMVtwrg2gzwXhY=.a4349902-5154-4353-a1d8-2c9a91ce379f@github.com>
Message-ID: <XX_MeIkokDD522Cotgv0HxOn6noQyRu1SMy8adlv_i0=.e816a632-559d-4ff3-87e2-2308a03cc902@github.com>

On Thu, 14 Mar 2024 12:40:59 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Convert test to the automatic main and move it from its own folder since it is no longer required.
>
> test/jdk/java/awt/Choice/NonFocusablePopupMenuTest.java line 65:
> 
>> 63:         });
>> 64:         robot.waitForIdle();
>> 65:         SwingUtilities.invokeAndWait(() -> {
> 
> Is it ok to have SwingUtilities.invokeAndWait? 
> Or should we use EventQueue.invokeAndWait ?

My bad. We should use EventQueue.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18300#discussion_r1524783681

From abhiscxk at openjdk.org  Thu Mar 14 12:30:57 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Thu, 14 Mar 2024 12:30:57 GMT
Subject: RFR: 8327873: Convert javax/swing/border/Test4247606.java applet
 test to main [v3]
In-Reply-To: <Kpj8ZEwW-6xNC2kfb5JOknRvpsP6zDVZuS8k3K4pFwQ=.ba2fe6e3-dd7f-4820-aa6c-47005c87db62@github.com>
References: <wHX-Mo2XWPKls-WPhv6L7m1xdtKWQF40Nr-U9rjGxqw=.7f21fa24-8bc3-4c36-8132-408fe1372e60@github.com>
 <Kpj8ZEwW-6xNC2kfb5JOknRvpsP6zDVZuS8k3K4pFwQ=.ba2fe6e3-dd7f-4820-aa6c-47005c87db62@github.com>
Message-ID: <pE6t_Zj6BlnUdPvoReW-xVWs-B5STLeKfjKKg6Bn7Z8=.6d299e14-b27b-4cec-8b15-7dd9fda5f6f5@github.com>

On Wed, 13 Mar 2024 05:00:35 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Convert javax/swing/border/Test4247606.java applet test to main based test using PassFailJFrame.
>
> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review updates

Marked as reviewed by abhiscxk (Committer).

test/jdk/javax/swing/border/Test4247606.java line 37:

> 35:  * @test
> 36:  * @bug 4247606
> 37:  * @summary BorderedPane appears wrong with Title Position Below Bottom

Minor suggestion else looks good to me.

Suggestion:

 * @summary BorderedPane appears wrong with title position below bottom

-------------

PR Review: https://git.openjdk.org/jdk/pull/18213#pullrequestreview-1936516116
PR Review Comment: https://git.openjdk.org/jdk/pull/18213#discussion_r1524751863

From kizune at openjdk.org  Thu Mar 14 12:51:39 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Thu, 14 Mar 2024 12:51:39 GMT
Subject: RFR: 8328158: Convert java/awt/Choice/NonFocusablePopupMenuTest to
 automatic main test
In-Reply-To: <OeDn08P18rFZMo4meLm_2eCBHRIzacMVtwrg2gzwXhY=.a4349902-5154-4353-a1d8-2c9a91ce379f@github.com>
References: <5o5Qhfltwmw1WbGujddcfKdNxIQahHyXXFHhaYfrLsM=.6437d7e5-ad8c-43be-b04c-3f45c0c9c54a@github.com>
 <OeDn08P18rFZMo4meLm_2eCBHRIzacMVtwrg2gzwXhY=.a4349902-5154-4353-a1d8-2c9a91ce379f@github.com>
Message-ID: <sO1cxztThhWZGe0-edfcLDA_u6o1rCyTXibiF9IJxZM=.5bc90257-a375-4027-9274-dbd461226322@github.com>

On Thu, 14 Mar 2024 12:42:00 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Convert test to the automatic main and move it from its own folder since it is no longer required.
>
> test/jdk/java/awt/Choice/NonFocusablePopupMenuTest.java line 74:
> 
>> 72:         robot.mouseRelease(InputEvent.BUTTON1_DOWN_MASK);
>> 73:         robot.waitForIdle();
>> 74:         robot.delay(500);
> 
> Any specific reason to have 500 ms delay. Can it be reduced?

Giving native peer some time to process request to populate a popup from choice. 500 ms seems reasonable.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18300#discussion_r1524795470

From kizune at openjdk.org  Thu Mar 14 13:00:06 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Thu, 14 Mar 2024 13:00:06 GMT
Subject: RFR: 8328158: Convert java/awt/Choice/NonFocusablePopupMenuTest to
 automatic main test [v2]
In-Reply-To: <5o5Qhfltwmw1WbGujddcfKdNxIQahHyXXFHhaYfrLsM=.6437d7e5-ad8c-43be-b04c-3f45c0c9c54a@github.com>
References: <5o5Qhfltwmw1WbGujddcfKdNxIQahHyXXFHhaYfrLsM=.6437d7e5-ad8c-43be-b04c-3f45c0c9c54a@github.com>
Message-ID: <6EpS7_zMFB6XCjZzzrgnJbe0RwDRj4fk58Ez0Ar6Cdo=.7aa2d059-d226-4453-b24b-760a9ffc970e@github.com>

> Convert test to the automatic main and move it from its own folder since it is no longer required.

Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:

  Minor fixes

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18300/files
  - new: https://git.openjdk.org/jdk/pull/18300/files/98b62aaa..e91df298

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18300&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18300&range=00-01

  Stats: 13 lines in 1 file changed: 5 ins; 1 del; 7 mod
  Patch: https://git.openjdk.org/jdk/pull/18300.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18300/head:pull/18300

PR: https://git.openjdk.org/jdk/pull/18300

From kizune at openjdk.org  Thu Mar 14 13:00:06 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Thu, 14 Mar 2024 13:00:06 GMT
Subject: RFR: 8328158: Convert java/awt/Choice/NonFocusablePopupMenuTest to
 automatic main test [v2]
In-Reply-To: <OeDn08P18rFZMo4meLm_2eCBHRIzacMVtwrg2gzwXhY=.a4349902-5154-4353-a1d8-2c9a91ce379f@github.com>
References: <5o5Qhfltwmw1WbGujddcfKdNxIQahHyXXFHhaYfrLsM=.6437d7e5-ad8c-43be-b04c-3f45c0c9c54a@github.com>
 <OeDn08P18rFZMo4meLm_2eCBHRIzacMVtwrg2gzwXhY=.a4349902-5154-4353-a1d8-2c9a91ce379f@github.com>
Message-ID: <bZfeQbbkbBKxBzi4EMlGLug3vQvgj8c7iFY0_t68ArM=.5afa729b-daa7-4aa7-9c79-5944cc9a73ac@github.com>

On Thu, 14 Mar 2024 12:41:20 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Minor fixes
>
> test/jdk/java/awt/Choice/NonFocusablePopupMenuTest.java line 69:
> 
>> 67:             size = choice.getSize();
>> 68:         });
>> 69:         int selected = choice.getSelectedIndex();
> 
> choice accessed outside EDT.

Not sure it poses any significant problem but i will move it to EDT.

> test/jdk/java/awt/Choice/NonFocusablePopupMenuTest.java line 79:
> 
>> 77:         robot.mouseRelease(InputEvent.BUTTON1_DOWN_MASK);
>> 78:         robot.waitForIdle();
>> 79:         robot.delay(500);
> 
> same here as well.

Here it can be dropped.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18300#discussion_r1524813227
PR Review Comment: https://git.openjdk.org/jdk/pull/18300#discussion_r1524813670

From aivanov at openjdk.org  Thu Mar 14 13:29:42 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Thu, 14 Mar 2024 13:29:42 GMT
Subject: RFR: 8328011: Convert
 java/awt/Frame/GetBoundsResizeTest/GetBoundsResizeTest.java applet test to
 main [v3]
In-Reply-To: <r3m0FPAacrLKOI6SVZnH7GVRslKDpDjwaGECcCD3o0I=.c16baf2a-78f1-4634-93fa-0813f5e381cc@github.com>
References: <77msAoji3SrhXCIcFcOTndR5MCc5jsoomdQ9Udl0WeE=.893b27fe-2ba5-48d9-920f-aab38592b614@github.com>
 <r3m0FPAacrLKOI6SVZnH7GVRslKDpDjwaGECcCD3o0I=.c16baf2a-78f1-4634-93fa-0813f5e381cc@github.com>
Message-ID: <We8H7oIHrqnp_eMe6gGnfjOgAIGyLS7A2gBL68Gvkaw=.10eae84d-b2f7-4e1e-bc9a-0ec7b0b5e1cc@github.com>

On Wed, 13 Mar 2024 19:01:27 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>> The test is converted to main.
>> Tested on Linux, Macos and Windows.
>
> Alexander Zvegintsev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   extract logFrameBounds, instructions update

test/jdk/java/awt/Frame/GetBoundsResizeTest.java line 44:

> 42:             0. There is a test window with a "Press" button,
> 43:                 Its original bounds should be printed in the text area below.
> 44:             1. Resize the test window using the upper left corner.

I found it impossible to resize the window by top left corner on Windows? The frame is so small that the Minimize button in the title bar covers the icon.

test/jdk/java/awt/Frame/GetBoundsResizeTest.java line 45:

> 43:                 Its original bounds should be printed in the text area below.
> 44:             1. Resize the test window using the upper left corner.
> 45:             2. Press the button to print the result of getBounds() to the terminal.

Suggestion:

            2. Press the button to print the result of getBounds() to the text area.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18250#discussion_r1524878679
PR Review Comment: https://git.openjdk.org/jdk/pull/18250#discussion_r1524864989

From aivanov at openjdk.org  Thu Mar 14 13:32:40 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Thu, 14 Mar 2024 13:32:40 GMT
Subject: RFR: 8328011: Convert
 java/awt/Frame/GetBoundsResizeTest/GetBoundsResizeTest.java applet test to
 main [v3]
In-Reply-To: <lpPM8XHaWO8beIUi8-vlGDZyLkrCHDgn_q3t_yh-swY=.047a79f3-738a-4c51-83be-aecb8b83c309@github.com>
References: <77msAoji3SrhXCIcFcOTndR5MCc5jsoomdQ9Udl0WeE=.893b27fe-2ba5-48d9-920f-aab38592b614@github.com>
 <PoNxnSPkBb4Bdy-YC-sy3CCKtW9o4QB1mx7pqc99Ntc=.327a9543-9fd9-43c9-9720-9115868e65af@github.com>
 <MYmnU-Uo3zehLvNAuj4Kzn7vcr8Br3AqOAVEFJEXYgg=.ac865922-b8bb-4622-9c62-1e1332622292@github.com>
 <lpPM8XHaWO8beIUi8-vlGDZyLkrCHDgn_q3t_yh-swY=.047a79f3-738a-4c51-83be-aecb8b83c309@github.com>
Message-ID: <mH9ESriiLQ3iHAbsHq5BVVe2DGIAlhd7JEzZ3g5GGcw=.2449a624-9841-4adf-9640-c34c96d4a552@github.com>

On Wed, 13 Mar 2024 16:56:39 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>> @azvegint, yes, we can support both. But I didn't test it thoroughly, so I decided it was safer to add this.
>> 
>> Please, don't modify `PassFailJFrame` together with tests unless it's strictly required? It is for the sake of facilitating backporting the changes. Otherwise, backporting improvements to the framework will depend on the presence of a test.
>> 
>> In this case, it could be fine though? provided that the test you're updating exists in all the repos.
>> 
>> Either way, I think it's good to create a separate bug for `PassFailJFrame` which you'll resolve with the current one.
>
> That's a good point, I created #18281 for that.

It's integrated now. Likely, you want to merge master into your branch to avoid possible conflicts, although bot don't complain about any conflict.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18250#discussion_r1524883723

From aivanov at openjdk.org  Thu Mar 14 13:36:39 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Thu, 14 Mar 2024 13:36:39 GMT
Subject: RFR: JDK-8320675 : PrinterJob/SecurityDialogTest.java hangs
In-Reply-To: <OMBWLwH7044RMtwdrZSiahQDdy-1T-4oJjOQgnQEKjI=.18a31ad0-710f-44e5-86ec-b4566946b063@github.com>
References: <OMBWLwH7044RMtwdrZSiahQDdy-1T-4oJjOQgnQEKjI=.18a31ad0-710f-44e5-86ec-b4566946b063@github.com>
Message-ID: <SThBBAyvdXOL7RuvaU5Dlwlji5hP58JUZEgz3kpmzks=.619209f7-7b80-4305-9e60-ae54075cd48a@github.com>

On Thu, 14 Mar 2024 11:52:09 GMT, Renjith Kannath Pariyangad <rkannathpari at openjdk.org> wrote:

> Hi Reviewers,
> 
> I have updated the test with  PassFailJFrame with information panel, earlier this was informed through terminal.
> Please review and let me know your suggestions if any.

Marked as reviewed by aivanov (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18299#pullrequestreview-1936728141

From aivanov at openjdk.org  Thu Mar 14 14:05:45 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Thu, 14 Mar 2024 14:05:45 GMT
Subject: Integrated: 8320079: The ArabicBox.java test has no control buttons
In-Reply-To: <uW_uKMlwlOFidrejEZ7wkFRyC4Kqx_MmSQdenASo6EQ=.aebdca22-c37d-40f8-8d48-8f298f082adf@github.com>
References: <uW_uKMlwlOFidrejEZ7wkFRyC4Kqx_MmSQdenASo6EQ=.aebdca22-c37d-40f8-8d48-8f298f082adf@github.com>
Message-ID: <Pub0kkydu0mHqKnLC63nvDg4Q-A3uZrkYndh1uOjhps=.82096425-64fe-4ba2-b1a7-daf733d99a77@github.com>

On Tue, 12 Mar 2024 13:35:33 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> The test is converted to use `PassFailJFrame`.
> 
> I confirmed the updated test reproduce the original problem described in [JDK-4427483](https://bugs.openjdk.org/browse/JDK-4427483) where Arabic text displayed as missing glyphs.

This pull request has now been integrated.

Changeset: 792fc9d1
Author:    Alexey Ivanov <aivanov at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/792fc9d114977664da0b3bebf0f1d82360d375b6
Stats:     103 lines in 1 file changed: 103 ins; 0 del; 0 mod

8320079: The ArabicBox.java test has no control buttons

Reviewed-by: prr, honkar, dmarkov

-------------

PR: https://git.openjdk.org/jdk/pull/18234

From kizune at openjdk.org  Thu Mar 14 15:04:41 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Thu, 14 Mar 2024 15:04:41 GMT
Subject: RFR: 8328158: Convert java/awt/Choice/NonFocusablePopupMenuTest to
 automatic main test [v2]
In-Reply-To: <OeDn08P18rFZMo4meLm_2eCBHRIzacMVtwrg2gzwXhY=.a4349902-5154-4353-a1d8-2c9a91ce379f@github.com>
References: <5o5Qhfltwmw1WbGujddcfKdNxIQahHyXXFHhaYfrLsM=.6437d7e5-ad8c-43be-b04c-3f45c0c9c54a@github.com>
 <OeDn08P18rFZMo4meLm_2eCBHRIzacMVtwrg2gzwXhY=.a4349902-5154-4353-a1d8-2c9a91ce379f@github.com>
Message-ID: <-h8i5JBvUKJog4-jaP_3GAjfrgXQE5pravzlZ-6_0CU=.64edb448-7b99-47ef-8841-5dc606670a81@github.com>

On Thu, 14 Mar 2024 12:39:40 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Minor fixes
>
> test/jdk/java/awt/Choice/NonFocusablePopupMenuTest.java line 46:
> 
>> 44:     Choice choice;
>> 45:     Point pos;
>> 46:     Dimension size;
> 
> Should we declare `Point` and `Dimesnion` variable as volatile?

Fixed.

> test/jdk/java/awt/Choice/NonFocusablePopupMenuTest.java line 84:
> 
>> 82:             dispose();
>> 83:         });
>> 84:         if (choice.getSelectedIndex() == selected) {
> 
> `choice.getSelectedIndex()` accessed outside EDT.

Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18300#discussion_r1525038508
PR Review Comment: https://git.openjdk.org/jdk/pull/18300#discussion_r1525037673

From dnguyen at openjdk.org  Thu Mar 14 15:30:40 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Thu, 14 Mar 2024 15:30:40 GMT
Subject: RFR: 8327969: Convert javax/swing/border/Test6910490.java applet
 test to main [v3]
In-Reply-To: <wN5NloPTsZWKmrKiryRI_C49_gdcOhAYnGonH38_-jA=.36377aa0-94ad-4ebb-a8aa-c487ab2a26bf@github.com>
References: <ArKktd5_qKLn7B3HLdLakGlHSCWaxQ1ivx-miiQUGCQ=.604d8ce0-8405-4558-bc19-60a0d47d1122@github.com>
 <wN5NloPTsZWKmrKiryRI_C49_gdcOhAYnGonH38_-jA=.36377aa0-94ad-4ebb-a8aa-c487ab2a26bf@github.com>
Message-ID: <nve3NciwDGKky2U5PfkTCNM1iZzAeDtftrPanUyPX2k=.648d9277-30d0-4ed3-9f3f-8f0b0e6bbe60@github.com>

On Wed, 13 Mar 2024 04:54:23 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Convert javax/swing/border/Test6910490.java applet test to main based test using PassFailJFrame.
>
> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review updates

Marked as reviewed by dnguyen (Committer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18229#pullrequestreview-1937050629

From tr at openjdk.org  Thu Mar 14 15:42:46 2024
From: tr at openjdk.org (Tejesh R)
Date: Thu, 14 Mar 2024 15:42:46 GMT
Subject: Integrated: 8327969: Convert javax/swing/border/Test6910490.java
 applet test to main
In-Reply-To: <ArKktd5_qKLn7B3HLdLakGlHSCWaxQ1ivx-miiQUGCQ=.604d8ce0-8405-4558-bc19-60a0d47d1122@github.com>
References: <ArKktd5_qKLn7B3HLdLakGlHSCWaxQ1ivx-miiQUGCQ=.604d8ce0-8405-4558-bc19-60a0d47d1122@github.com>
Message-ID: <96QO8Kc1B7rnMLHrGwGVrgw2WPHaZrdUhlkVcqIGtZ8=.ceebd4ad-5ad7-4068-aab0-e003e0bfe6ee@github.com>

On Tue, 12 Mar 2024 11:15:38 GMT, Tejesh R <tr at openjdk.org> wrote:

> Convert javax/swing/border/Test6910490.java applet test to main based test using PassFailJFrame.

This pull request has now been integrated.

Changeset: 759cc675
Author:    Tejesh R <tr at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/759cc675915c551cc1d6899eedb95900752f2703
Stats:     61 lines in 2 files changed: 20 ins; 34 del; 7 mod

8327969: Convert javax/swing/border/Test6910490.java applet test to main

Reviewed-by: dnguyen, honkar

-------------

PR: https://git.openjdk.org/jdk/pull/18229

From kizune at openjdk.org  Thu Mar 14 15:45:41 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Thu, 14 Mar 2024 15:45:41 GMT
Subject: RFR: 8328154: Convert sun/java2d/loops/CopyAreaSpeed.java applet
 test to main
In-Reply-To: <QHf2yYI8zQSoqYjld0VQjVQmFWrIk2f53wArMF0qL14=.a7a41b62-f301-4c7a-9da4-09603d95cbd5@github.com>
References: <QHf2yYI8zQSoqYjld0VQjVQmFWrIk2f53wArMF0qL14=.a7a41b62-f301-4c7a-9da4-09603d95cbd5@github.com>
Message-ID: <pMH61rcy0nzbY-FylMVa7iqZO8i3aKov4eplIEsI6vk=.e088f806-d0c9-4ec7-88c9-b7b461051585@github.com>

On Thu, 14 Mar 2024 10:39:15 GMT, Tejesh R <tr at openjdk.org> wrote:

> Convert  sun/java2d/loops/CopyAreaSpeed.java manual applet test to main based using PassFailJFrame. This is a performance measurement test which provide benchmark to compare the outcome with different releases. I have converted the test using a PassFailJFrame though PASS/FAIL doesn't matter here. The result have been shown in `JOptionPane` message.

test/jdk/sun/java2d/loops/CopyAreaSpeed.java line 131:

> 129:             }
> 130:             try {
> 131:                 Thread.sleep(1);

I know it is an old code but i just wonder why do we add sleep to every iteration of something that is supposed to be a performance test. What are we achieving by doing this sleep?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18296#discussion_r1525105010

From azvegint at openjdk.org  Thu Mar 14 15:47:49 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Thu, 14 Mar 2024 15:47:49 GMT
Subject: Integrated: 8327835: Convert
 java/awt/FileDialog/RegexpFilterTest/RegexpFilterTest applet test to main
In-Reply-To: <O_XrLLXwQtMWjKGEoOaYSM8RdDnyH3LF3-Bdp5PDRHo=.72bb3619-6cfc-43c8-83d6-c87eabf24636@github.com>
References: <O_XrLLXwQtMWjKGEoOaYSM8RdDnyH3LF3-Bdp5PDRHo=.72bb3619-6cfc-43c8-83d6-c87eabf24636@github.com>
Message-ID: <-rjGPUgBlac2sy8wWewhmRedIhKKfplkPy_KiBwwO1U=.da5f3022-19c7-4431-a23d-029076d436f8@github.com>

On Mon, 11 Mar 2024 17:29:50 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

> The `java/awt/FileDialog/RegexpFilterTest/RegexpFilterTest` test is written to test the very specific functionality of `XFileDialogPeer`, so it shouldn't be run on platforms other than Linux.
> 
> We also need to set `sun.awt.disableGtkFileDialogs` to `true` to be able to test `XFileDialogPeer`, because by default it tries to use the Gtk file dialog if it is available.
> The Gtk file dialog has a search field hidden under the magnifying glass icon, but it has a different syntax.
> 
> The Windows system file dialog allows you to use wildcard filtering in the "File name" field by hitting the `enter` afterwards, but again, this test was written to test our own file dialog implementation, not the system's.

This pull request has now been integrated.

Changeset: d25c452f
Author:    Alexander Zvegintsev <azvegint at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/d25c452f0c4a2106a1fa06b56039f0f0b5d6e952
Stats:     344 lines in 4 files changed: 74 ins; 270 del; 0 mod

8327835: Convert java/awt/FileDialog/RegexpFilterTest/RegexpFilterTest applet test to main

Reviewed-by: aivanov, abhiscxk

-------------

PR: https://git.openjdk.org/jdk/pull/18203

From aivanov at openjdk.org  Thu Mar 14 15:49:43 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Thu, 14 Mar 2024 15:49:43 GMT
Subject: Integrated: 8286759: TextComponentPrintable: consequent -> consecutive
 positions
In-Reply-To: <CTbRheJJ9yn-OaBNP3gBAhiEfSCS2K9nOXuyuVal9Ns=.72f8155d-78b0-4ec7-93f5-9457b235a205@github.com>
References: <CTbRheJJ9yn-OaBNP3gBAhiEfSCS2K9nOXuyuVal9Ns=.72f8155d-78b0-4ec7-93f5-9457b235a205@github.com>
Message-ID: <jvgvoEpNYRd7qtJQHozEVMKhEHhdRyg68EUukMW6mEs=.8f1ae436-f609-4048-beaf-09e867da8f63@github.com>

On Thu, 29 Feb 2024 15:13:16 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> A trivial change in a comment: consequent ? _consecutive_ positions.
> 
> This was found in [a code review](https://github.com/openjdk/jdk/pull/8328#discussion_r872596373) for [JDK-8285306](https://bugs.openjdk.org/browse/JDK-8285306).

This pull request has now been integrated.

Changeset: 0c3998d2
Author:    Alexey Ivanov <aivanov at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/0c3998d2c6dd735d356bfe26662c93d97364b2ad
Stats:     4 lines in 1 file changed: 0 ins; 0 del; 4 mod

8286759: TextComponentPrintable: consequent -> consecutive positions

Reviewed-by: gli, prr

-------------

PR: https://git.openjdk.org/jdk/pull/18067

From tr at openjdk.org  Thu Mar 14 15:50:43 2024
From: tr at openjdk.org (Tejesh R)
Date: Thu, 14 Mar 2024 15:50:43 GMT
Subject: Integrated: 8327876: Convert javax/swing/border/Test4252164.java
 applet test to main
In-Reply-To: <Nc7KlfEEQnoms0Ja9qgzfbVjkrWbZXjkcfU1pL6XdU0=.6fa50ee3-8610-43b3-8b3f-913f40281a5e@github.com>
References: <Nc7KlfEEQnoms0Ja9qgzfbVjkrWbZXjkcfU1pL6XdU0=.6fa50ee3-8610-43b3-8b3f-913f40281a5e@github.com>
Message-ID: <U0XI0Vk5k6UHuSi7oB1tyvcy6HeVafsEI5I0K9Y_bCY=.269df13a-b572-4aba-8829-3d47f38e7e03@github.com>

On Tue, 12 Mar 2024 06:56:20 GMT, Tejesh R <tr at openjdk.org> wrote:

> Convert javax/swing/border/Test4252164.java applet test to main based test using PassFailJFrame.

This pull request has now been integrated.

Changeset: acfefc6c
Author:    Tejesh R <tr at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/acfefc6c7aea6903bd575c2cb6edddbd88b112bf
Stats:     81 lines in 2 files changed: 14 ins; 44 del; 23 mod

8327876: Convert javax/swing/border/Test4252164.java applet test to main

Reviewed-by: prr, abhiscxk

-------------

PR: https://git.openjdk.org/jdk/pull/18216

From tr at openjdk.org  Thu Mar 14 15:57:57 2024
From: tr at openjdk.org (Tejesh R)
Date: Thu, 14 Mar 2024 15:57:57 GMT
Subject: RFR: 8327873: Convert javax/swing/border/Test4247606.java applet
 test to main [v4]
In-Reply-To: <wHX-Mo2XWPKls-WPhv6L7m1xdtKWQF40Nr-U9rjGxqw=.7f21fa24-8bc3-4c36-8132-408fe1372e60@github.com>
References: <wHX-Mo2XWPKls-WPhv6L7m1xdtKWQF40Nr-U9rjGxqw=.7f21fa24-8bc3-4c36-8132-408fe1372e60@github.com>
Message-ID: <q4t5M-kOc2KyecB0RhNPJWqrwZyQpdxUBRKqYnFMaoU=.38c824c7-6990-4122-aab2-c1387187ca61@github.com>

> Convert javax/swing/border/Test4247606.java applet test to main based test using PassFailJFrame.

Tejesh R has updated the pull request incrementally with one additional commit since the last revision:

  Review updates

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18213/files
  - new: https://git.openjdk.org/jdk/pull/18213/files/e1a5a360..6922ce80

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18213&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18213&range=02-03

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/18213.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18213/head:pull/18213

PR: https://git.openjdk.org/jdk/pull/18213

From tr at openjdk.org  Thu Mar 14 15:57:57 2024
From: tr at openjdk.org (Tejesh R)
Date: Thu, 14 Mar 2024 15:57:57 GMT
Subject: Integrated: 8327873: Convert javax/swing/border/Test4247606.java
 applet test to main
In-Reply-To: <wHX-Mo2XWPKls-WPhv6L7m1xdtKWQF40Nr-U9rjGxqw=.7f21fa24-8bc3-4c36-8132-408fe1372e60@github.com>
References: <wHX-Mo2XWPKls-WPhv6L7m1xdtKWQF40Nr-U9rjGxqw=.7f21fa24-8bc3-4c36-8132-408fe1372e60@github.com>
Message-ID: <OLYiD5eabFSc4-ot5AQRAjbXAfyk0Hy1nJu5h3ufgmU=.1c757a1b-2768-4bd5-ba44-798be18a6926@github.com>

On Tue, 12 Mar 2024 06:03:27 GMT, Tejesh R <tr at openjdk.org> wrote:

> Convert javax/swing/border/Test4247606.java applet test to main based test using PassFailJFrame.

This pull request has now been integrated.

Changeset: d4ec7831
Author:    Tejesh R <tr at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/d4ec783108828efd158c749f37e4220bb1df86fc
Stats:     76 lines in 2 files changed: 28 ins; 42 del; 6 mod

8327873: Convert javax/swing/border/Test4247606.java applet test to main

Reviewed-by: prr, abhiscxk

-------------

PR: https://git.openjdk.org/jdk/pull/18213

From azvegint at openjdk.org  Thu Mar 14 16:01:56 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Thu, 14 Mar 2024 16:01:56 GMT
Subject: RFR: 8328124: Convert java/awt/Frame/ShownOnPack/ShownOnPack.html
 applet test to main [v2]
In-Reply-To: <yC3Qtep10q3KRJrCfQv-ThrGmE7xdedwQjrr0dBMVMw=.9b87a76e-5af8-411e-bd31-dd8f390d6b24@github.com>
References: <yC3Qtep10q3KRJrCfQv-ThrGmE7xdedwQjrr0dBMVMw=.9b87a76e-5af8-411e-bd31-dd8f390d6b24@github.com>
Message-ID: <ChWPcaBxRlMnwM-WjIGHKnqgxNsjxj-DV5eg2bEKb4Y=.71d6a56e-48ee-4300-9c8a-5efcd53fe064@github.com>

> The test is converted to main.
> Tested on Linux, Macos and Windows.

Alexander Zvegintsev has updated the pull request incrementally with one additional commit since the last revision:

  add empty line

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18287/files
  - new: https://git.openjdk.org/jdk/pull/18287/files/1e797b7f..85a4cfe9

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18287&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18287&range=00-01

  Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18287.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18287/head:pull/18287

PR: https://git.openjdk.org/jdk/pull/18287

From azvegint at openjdk.org  Thu Mar 14 16:06:45 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Thu, 14 Mar 2024 16:06:45 GMT
Subject: Integrated: 8328124: Convert
 java/awt/Frame/ShownOnPack/ShownOnPack.html applet test to main
In-Reply-To: <yC3Qtep10q3KRJrCfQv-ThrGmE7xdedwQjrr0dBMVMw=.9b87a76e-5af8-411e-bd31-dd8f390d6b24@github.com>
References: <yC3Qtep10q3KRJrCfQv-ThrGmE7xdedwQjrr0dBMVMw=.9b87a76e-5af8-411e-bd31-dd8f390d6b24@github.com>
Message-ID: <emnC88gsw2ikeiA6wPiH31ozpLxG14FGaPXAAZKkdgs=.1b7bb055-aa39-4bc1-a55f-3acaa9430882@github.com>

On Wed, 13 Mar 2024 19:43:10 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

> The test is converted to main.
> Tested on Linux, Macos and Windows.

This pull request has now been integrated.

Changeset: 7cc1965a
Author:    Alexander Zvegintsev <azvegint at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/7cc1965a252347f37dca69859d5ecaf2b55020c6
Stats:     249 lines in 2 files changed: 4 ins; 207 del; 38 mod

8328124: Convert java/awt/Frame/ShownOnPack/ShownOnPack.html applet test to main

Reviewed-by: honkar, abhiscxk

-------------

PR: https://git.openjdk.org/jdk/pull/18287

From tr at openjdk.org  Thu Mar 14 16:07:42 2024
From: tr at openjdk.org (Tejesh R)
Date: Thu, 14 Mar 2024 16:07:42 GMT
Subject: RFR: 8328154: Convert sun/java2d/loops/CopyAreaSpeed.java applet
 test to main
In-Reply-To: <pMH61rcy0nzbY-FylMVa7iqZO8i3aKov4eplIEsI6vk=.e088f806-d0c9-4ec7-88c9-b7b461051585@github.com>
References: <QHf2yYI8zQSoqYjld0VQjVQmFWrIk2f53wArMF0qL14=.a7a41b62-f301-4c7a-9da4-09603d95cbd5@github.com>
 <pMH61rcy0nzbY-FylMVa7iqZO8i3aKov4eplIEsI6vk=.e088f806-d0c9-4ec7-88c9-b7b461051585@github.com>
Message-ID: <-p_u3q1fM-8p0wgRiKohiYi9dc6Kz-TASSP_LBc1W1I=.50d1c283-22b0-48e4-8993-f32a339d0505@github.com>

On Thu, 14 Mar 2024 15:42:46 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

>> Convert  sun/java2d/loops/CopyAreaSpeed.java manual applet test to main based using PassFailJFrame. This is a performance measurement test which provide benchmark to compare the outcome with different releases. I have converted the test using a PassFailJFrame though PASS/FAIL doesn't matter here. The result have been shown in `JOptionPane` message.
>
> test/jdk/sun/java2d/loops/CopyAreaSpeed.java line 131:
> 
>> 129:             }
>> 130:             try {
>> 131:                 Thread.sleep(1);
> 
> I know it is an old code but i just wonder why do we add sleep to every iteration of something that is supposed to be a performance test. What are we achieving by doing this sleep?

Maybe because of Graphics paint and copyArea ?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18296#discussion_r1525138504

From abhiscxk at openjdk.org  Thu Mar 14 16:07:46 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Thu, 14 Mar 2024 16:07:46 GMT
Subject: RFR: 8328158: Convert java/awt/Choice/NonFocusablePopupMenuTest to
 automatic main test [v2]
In-Reply-To: <6EpS7_zMFB6XCjZzzrgnJbe0RwDRj4fk58Ez0Ar6Cdo=.7aa2d059-d226-4453-b24b-760a9ffc970e@github.com>
References: <5o5Qhfltwmw1WbGujddcfKdNxIQahHyXXFHhaYfrLsM=.6437d7e5-ad8c-43be-b04c-3f45c0c9c54a@github.com>
 <6EpS7_zMFB6XCjZzzrgnJbe0RwDRj4fk58Ez0Ar6Cdo=.7aa2d059-d226-4453-b24b-760a9ffc970e@github.com>
Message-ID: <bzqvsDI6z0ZTd9eMuCRi-9U6PTFxO-h615bwZwYocZw=.086996cc-66e5-4dfa-bd34-763a804ba0d4@github.com>

On Thu, 14 Mar 2024 13:00:06 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

>> Convert test to the automatic main and move it from its own folder since it is no longer required.
>
> Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Minor fixes

test/jdk/java/awt/Choice/NonFocusablePopupMenuTest.java line 46:

> 44:     volatile Point pos;
> 45:     volatile Dimension size;
> 46:     volatile int selection1, selection2;

May add a blank line after this.

test/jdk/java/awt/Choice/NonFocusablePopupMenuTest.java line 59:

> 57:             choice.setFocusable(false);
> 58:             this.add(choice);
> 59:             this.setLayout (new FlowLayout());

Suggestion:

            this.setLayout(new FlowLayout());

test/jdk/java/awt/Choice/NonFocusablePopupMenuTest.java line 60:

> 58:             this.add(choice);
> 59:             this.setLayout (new FlowLayout());
> 60:             setSize (200,200);

Suggestion:

            setSize (200, 200);

test/jdk/java/awt/Choice/NonFocusablePopupMenuTest.java line 70:

> 68:         });
> 69:         EventQueue.invokeAndWait(() -> {
> 70:             selection1 = choice.getSelectedIndex();

May be moved inside the EventQueue above.

test/jdk/java/awt/Choice/NonFocusablePopupMenuTest.java line 85:

> 83:         });
> 84:         EventQueue.invokeAndWait(() -> {
> 85:             setVisible(false);

I think this also can be moved inside above EventQueue.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18300#discussion_r1525130997
PR Review Comment: https://git.openjdk.org/jdk/pull/18300#discussion_r1525131265
PR Review Comment: https://git.openjdk.org/jdk/pull/18300#discussion_r1525131484
PR Review Comment: https://git.openjdk.org/jdk/pull/18300#discussion_r1525134150
PR Review Comment: https://git.openjdk.org/jdk/pull/18300#discussion_r1525136979

From abhiscxk at openjdk.org  Thu Mar 14 16:09:43 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Thu, 14 Mar 2024 16:09:43 GMT
Subject: RFR: 8328087: Automate javax/swing/JTable/TAB/TAB.java applet test
 [v2]
In-Reply-To: <UIgpUKGnMmGZUSYwpIoTo_38Sf1JoUR5cfkHoRJlM18=.5f78a9fa-ec07-4e84-83f5-cf6462d47e4a@github.com>
References: <MumC6TL2XcA5TmVgQXy8yIDFEqUD08b2dvCUyYu7Kd8=.5891ab36-873a-41f0-b22f-d2fc883c8734@github.com>
 <57vHBqQV5Hiqcr5Oaaj2A5-gwwi4r_QPFcDpqGGueK4=.28909cca-86f6-4c4a-a416-620d0d7052fd@github.com>
 <UIgpUKGnMmGZUSYwpIoTo_38Sf1JoUR5cfkHoRJlM18=.5f78a9fa-ec07-4e84-83f5-cf6462d47e4a@github.com>
Message-ID: <D2t_8ZyaVRovFJ58sUQNneEG-JgGezUo0RWqC60Pbtk=.c3652af9-d399-4414-99ab-52f259935943@github.com>

On Thu, 14 Mar 2024 01:01:51 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove commented code
>
> Changes requested by honkar (Reviewer).

@honkar-jdk Updated as per last review. Please take a look.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18274#issuecomment-1997809970

From abhiscxk at openjdk.org  Thu Mar 14 16:10:41 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Thu, 14 Mar 2024 16:10:41 GMT
Subject: RFR: 8327980: Convert
 javax/swing/JToggleButton/4128979/bug4128979.java applet test to main [v2]
In-Reply-To: <fsD1Tq4f9aI5XhKF2rJN1SSjtF8J-Lv447WGPf_TPR0=.219bfb1a-a105-4c26-a050-55fdbb57bf20@github.com>
References: <lZHt9pYb75UtaIEtbB0paOkfqR5CUAc6tikhb9YAakU=.ff2adbed-1db2-490a-8747-66ac96d03657@github.com>
 <fsD1Tq4f9aI5XhKF2rJN1SSjtF8J-Lv447WGPf_TPR0=.219bfb1a-a105-4c26-a050-55fdbb57bf20@github.com>
Message-ID: <US8MeZpRAuIPdqR3Uv-k0xCX4NvtNAYqDHWkbPaAN60=.c641f593-19b9-45a0-9e82-3ac8215453bc@github.com>

On Wed, 13 Mar 2024 01:20:11 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review comment fix
>
> Changes requested by honkar (Reviewer).

@honkar-jdk Updated as per last review. Please take a look.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18233#issuecomment-1997810580

From dnguyen at openjdk.org  Thu Mar 14 16:13:54 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Thu, 14 Mar 2024 16:13:54 GMT
Subject: RFR: 8328005: Convert java/awt/im/JTextFieldTest.java applet test
 to main [v3]
In-Reply-To: <L1GhxeYrU35BXYEe9h_FL05fGrPgE7q4vWv3qTOe854=.c20a5812-ec96-4541-94b8-106dd17d9f95@github.com>
References: <L1GhxeYrU35BXYEe9h_FL05fGrPgE7q4vWv3qTOe854=.c20a5812-ec96-4541-94b8-106dd17d9f95@github.com>
Message-ID: <Xn_2HUsUI0JCP0TWCQVonGZa2byojUgp1WMGSLQ0Huc=.396ecb47-21f2-4609-bd60-d39e2c0a1ba5@github.com>

> Convert java/awt/im/JTextFieldTest.java applet test to main using PassFailJFrame.

Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:

  Review comments

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18247/files
  - new: https://git.openjdk.org/jdk/pull/18247/files/9c1ceab9..e5f694ef

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18247&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18247&range=01-02

  Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/jdk/pull/18247.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18247/head:pull/18247

PR: https://git.openjdk.org/jdk/pull/18247

From azvegint at openjdk.org  Thu Mar 14 16:26:06 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Thu, 14 Mar 2024 16:26:06 GMT
Subject: RFR: 8328011: Convert
 java/awt/Frame/GetBoundsResizeTest/GetBoundsResizeTest.java applet test to
 main [v4]
In-Reply-To: <77msAoji3SrhXCIcFcOTndR5MCc5jsoomdQ9Udl0WeE=.893b27fe-2ba5-48d9-920f-aab38592b614@github.com>
References: <77msAoji3SrhXCIcFcOTndR5MCc5jsoomdQ9Udl0WeE=.893b27fe-2ba5-48d9-920f-aab38592b614@github.com>
Message-ID: <PobDvnZXaC9ndd17lzssLfxHjVeNp4NIow8pDjPt5Bc=.13a35555-efa6-46e2-b920-1a4b0480ed72@github.com>

> The test is converted to main.
> Tested on Linux, Macos and Windows.

Alexander Zvegintsev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:

 - Merge branch 'master' into testsprint_2024_03/8328011_GetBoundsResizeTest
 - instructions update, frame resize
 - extract logFrameBounds, instructions update
 - minor formatting
 - 8328011: Convert java/awt/Frame/GetBoundsResizeTest/GetBoundsResizeTest.java applet test to main
 - 8328011: Convert java/awt/Frame/GetBoundsResizeTest/GetBoundsResizeTest.java applet test to main

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18250/files
  - new: https://git.openjdk.org/jdk/pull/18250/files/2c90d8e3..50fb9b5f

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18250&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18250&range=02-03

  Stats: 6934 lines in 243 files changed: 3307 ins; 2849 del; 778 mod
  Patch: https://git.openjdk.org/jdk/pull/18250.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18250/head:pull/18250

PR: https://git.openjdk.org/jdk/pull/18250

From azvegint at openjdk.org  Thu Mar 14 16:26:06 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Thu, 14 Mar 2024 16:26:06 GMT
Subject: RFR: 8328011: Convert
 java/awt/Frame/GetBoundsResizeTest/GetBoundsResizeTest.java applet test to
 main [v3]
In-Reply-To: <We8H7oIHrqnp_eMe6gGnfjOgAIGyLS7A2gBL68Gvkaw=.10eae84d-b2f7-4e1e-bc9a-0ec7b0b5e1cc@github.com>
References: <77msAoji3SrhXCIcFcOTndR5MCc5jsoomdQ9Udl0WeE=.893b27fe-2ba5-48d9-920f-aab38592b614@github.com>
 <r3m0FPAacrLKOI6SVZnH7GVRslKDpDjwaGECcCD3o0I=.c16baf2a-78f1-4634-93fa-0813f5e381cc@github.com>
 <We8H7oIHrqnp_eMe6gGnfjOgAIGyLS7A2gBL68Gvkaw=.10eae84d-b2f7-4e1e-bc9a-0ec7b0b5e1cc@github.com>
Message-ID: <SrddTqycaD8aD2WSL255mcF79oiejmztWQU1bodvUiE=.afd1eb59-b97f-487f-8afa-f1d3fab5654e@github.com>

On Thu, 14 Mar 2024 13:26:37 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Alexander Zvegintsev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   extract logFrameBounds, instructions update
>
> test/jdk/java/awt/Frame/GetBoundsResizeTest.java line 44:
> 
>> 42:             0. There is a test window with a "Press" button,
>> 43:                 Its original bounds should be printed in the text area below.
>> 44:             1. Resize the test window using the upper left corner.
> 
> I found it impossible to resize the window by top left corner on Windows? The frame is so small that the Minimize button in the title bar covers the icon.

Hmm, works for me:

[Screencast.webm](https://github.com/openjdk/jdk/assets/77687766/8d6d5edd-178c-4dd4-9385-9492fde3ce1a)

Anyway, I changed the default size of the window.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18250#discussion_r1525165288

From dnguyen at openjdk.org  Thu Mar 14 16:41:41 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Thu, 14 Mar 2024 16:41:41 GMT
Subject: RFR: 8328005: Convert java/awt/im/JTextFieldTest.java applet test
 to main [v2]
In-Reply-To: <05oH95MKBN-FyFfVFwzVbPXCnao8ni4J5EGiYOZRpu4=.8309b557-35b0-4fd6-898b-08db632faea2@github.com>
References: <L1GhxeYrU35BXYEe9h_FL05fGrPgE7q4vWv3qTOe854=.c20a5812-ec96-4541-94b8-106dd17d9f95@github.com>
 <YplUkKLbuHJpxhSKnrcLGhMzl0skOF2qnsd48VZrfHg=.864412ed-d927-47e5-8d3e-2f583477dad5@github.com>
 <05oH95MKBN-FyFfVFwzVbPXCnao8ni4J5EGiYOZRpu4=.8309b557-35b0-4fd6-898b-08db632faea2@github.com>
Message-ID: <zA5hgd4E7ZNvnKxM-Lj2ry6KBknVXSmAVhYwQ8c5ayA=.c3d7be20-c0a3-4296-bbb9-ac3fb3526fb7@github.com>

On Wed, 13 Mar 2024 18:15:58 GMT, Phil Race <prr at openjdk.org> wrote:

>> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix suggested redudant changes
>
> test/jdk/java/awt/im/JTextFieldTest.java line 47:
> 
>> 45:             """
>> 46:              Please run this test case under Solaris cjk locale with inputmethod
>> 47:              support, if you could input Chinese/Japanese/Korean in the swing
> 
> The scenario here should not be specific to Solaris.
> I think you should rephrase the first sentence to
> "Please run this test in a CJK (Chinese/Japanese/Korean) locale with input method support".
> 
> I some times wonder how well these tests that say "please change your environment" actually get properly tested.
> It is perhaps possible to do change desktop locale support on the fly but by the time
> you read the instructions the test is already running.
> That introduces another wrinkle. Maybe you need to restart at least this test.
> And I am not 100% sure that jtreg passes through locale vars. I hope it does.

Updated the instructions.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18247#discussion_r1525187262

From kizune at openjdk.org  Thu Mar 14 16:44:55 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Thu, 14 Mar 2024 16:44:55 GMT
Subject: RFR: 8328158: Convert java/awt/Choice/NonFocusablePopupMenuTest to
 automatic main test [v3]
In-Reply-To: <5o5Qhfltwmw1WbGujddcfKdNxIQahHyXXFHhaYfrLsM=.6437d7e5-ad8c-43be-b04c-3f45c0c9c54a@github.com>
References: <5o5Qhfltwmw1WbGujddcfKdNxIQahHyXXFHhaYfrLsM=.6437d7e5-ad8c-43be-b04c-3f45c0c9c54a@github.com>
Message-ID: <DQuTmu8Ralq894tZWRt9gOAIUyuX9AdBKcruZdZrnAI=.f4b1da1d-de9d-40cf-bc73-27688da8bac6@github.com>

> Convert test to the automatic main and move it from its own folder since it is no longer required.

Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:

  Update test/jdk/java/awt/Choice/NonFocusablePopupMenuTest.java
  
  Co-authored-by: Abhishek Kumar <abhishek.cx.kumar at oracle.com>

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18300/files
  - new: https://git.openjdk.org/jdk/pull/18300/files/e91df298..17b1fb4d

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18300&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18300&range=01-02

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/18300.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18300/head:pull/18300

PR: https://git.openjdk.org/jdk/pull/18300

From dnguyen at openjdk.org  Thu Mar 14 16:45:48 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Thu, 14 Mar 2024 16:45:48 GMT
Subject: RFR: 8328185: Convert
 java/awt/image/MemoryLeakTest/MemoryLeakTest.java applet test to main
Message-ID: <TFYjDmsHDFBm5tcakvQmk_o_3bkZxQmS8FLPZW5bI8Y=.c7bebd2f-13cb-4bae-bd85-64cbff6c17b8@github.com>

Convert java/awt/image/MemoryLeakTest/MemoryLeakTest.java applet test to main using PassFailJFrame

-------------

Commit messages:
 - Update title
 - Initial test conversion

Changes: https://git.openjdk.org/jdk/pull/18307/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18307&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8328185
  Stats: 173 lines in 1 file changed: 44 ins; 81 del; 48 mod
  Patch: https://git.openjdk.org/jdk/pull/18307.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18307/head:pull/18307

PR: https://git.openjdk.org/jdk/pull/18307

From kizune at openjdk.org  Thu Mar 14 16:48:57 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Thu, 14 Mar 2024 16:48:57 GMT
Subject: RFR: 8328158: Convert java/awt/Choice/NonFocusablePopupMenuTest to
 automatic main test [v4]
In-Reply-To: <5o5Qhfltwmw1WbGujddcfKdNxIQahHyXXFHhaYfrLsM=.6437d7e5-ad8c-43be-b04c-3f45c0c9c54a@github.com>
References: <5o5Qhfltwmw1WbGujddcfKdNxIQahHyXXFHhaYfrLsM=.6437d7e5-ad8c-43be-b04c-3f45c0c9c54a@github.com>
Message-ID: <_cLhzMaHV2B6w0DWMogu5Abv8Zk4xS_ve9HYWSdTGWc=.32d0ed31-80f1-4fac-b05f-eef88709c2d1@github.com>

> Convert test to the automatic main and move it from its own folder since it is no longer required.

Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:

  Minor updates

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18300/files
  - new: https://git.openjdk.org/jdk/pull/18300/files/17b1fb4d..71885dd6

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18300&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18300&range=02-03

  Stats: 6 lines in 1 file changed: 1 ins; 4 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/18300.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18300/head:pull/18300

PR: https://git.openjdk.org/jdk/pull/18300

From kizune at openjdk.org  Thu Mar 14 16:48:57 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Thu, 14 Mar 2024 16:48:57 GMT
Subject: RFR: 8328158: Convert java/awt/Choice/NonFocusablePopupMenuTest to
 automatic main test [v2]
In-Reply-To: <bzqvsDI6z0ZTd9eMuCRi-9U6PTFxO-h615bwZwYocZw=.086996cc-66e5-4dfa-bd34-763a804ba0d4@github.com>
References: <5o5Qhfltwmw1WbGujddcfKdNxIQahHyXXFHhaYfrLsM=.6437d7e5-ad8c-43be-b04c-3f45c0c9c54a@github.com>
 <6EpS7_zMFB6XCjZzzrgnJbe0RwDRj4fk58Ez0Ar6Cdo=.7aa2d059-d226-4453-b24b-760a9ffc970e@github.com>
 <bzqvsDI6z0ZTd9eMuCRi-9U6PTFxO-h615bwZwYocZw=.086996cc-66e5-4dfa-bd34-763a804ba0d4@github.com>
Message-ID: <aMS0X6VWC65QBK8lizj1E2PU8BOg8ahQ9E7Vb12JTos=.321ab1c4-d533-48ea-94a9-2eeb09fb8278@github.com>

On Thu, 14 Mar 2024 16:03:46 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Minor fixes
>
> test/jdk/java/awt/Choice/NonFocusablePopupMenuTest.java line 85:
> 
>> 83:         });
>> 84:         EventQueue.invokeAndWait(() -> {
>> 85:             setVisible(false);
> 
> I think this also can be moved inside above EventQueue.

Sure.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18300#discussion_r1525197200

From aivanov at openjdk.org  Thu Mar 14 16:52:38 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Thu, 14 Mar 2024 16:52:38 GMT
Subject: RFR: 8305072: Win32ShellFolder2.compareTo is inconsistent [v2]
In-Reply-To: <6dQg9rhDwh4ZL7D2JfYpA0xNP_eJDbOK3rNgj7efckM=.c5001d8a-cce5-4a11-a91d-eda8e90b8056@github.com>
References: <bEiHvkFnBZDqmiqQdk_-_mATVhDbAD7NZX7VnkHLG2E=.27ee84ba-00fd-405a-9489-8fe11c215af9@github.com>
 <21db5CiFTVN7scwsIHknMxF4YaVQd06m7gUOhcCLvMI=.e2f61ea7-bf9a-4632-bf45-c89f979ae806@github.com>
 <6dQg9rhDwh4ZL7D2JfYpA0xNP_eJDbOK3rNgj7efckM=.c5001d8a-cce5-4a11-a91d-eda8e90b8056@github.com>
Message-ID: <76BSt4HYmTD2DiZzBUvNvBdvd5d1MFinIDsgp2YuHjs=.68646608-e266-4ca3-8495-59e237f8607c@github.com>

On Tue, 12 Mar 2024 19:35:30 GMT, Phil Race <prr at openjdk.org> wrote:

>> Alexey Ivanov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Handle fakePersonal on Windows 10
>>   
>>   The desktop folder on Windows 10 does not include
>>   the Personal (Documents) folder.
>
> src/java.desktop/windows/classes/sun/awt/shell/Win32ShellFolderManager2.java line 525:
> 
>> 523:         boolean special2 = sf2.isSpecial();
>> 524: 
>> 525:         if (special1 && special2) {
> 
> Could you please say something on how/why this change solves it ?

It is well described in a [JBS comment](https://bugs.openjdk.org/browse/JDK-8305072?focusedId=14610400&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14610400) by the submitter.

Let's consider the failing case where:

a = C:\Users<user>\Documents(true)
b = C:\Users<user>(false)
c = C:\Users<user>\Documents(false)

The value in parentheses is `isSpecial()` flag.

When `a` and `c` are compared, `special1 = true` and `special2 = false`, therefore the code flow enters this `if`-block. Because the `equals` method doesn't take into account the `isSpecial` flag, both `i1` and `i2` are 0.

https://github.com/openjdk/jdk/blob/7bccc847fe9e8c5e640d8fa9c93ce32563a0ccfa/src/java.desktop/windows/classes/sun/awt/shell/Win32ShellFolderManager2.java#L534-L535

Thus, `a` and `c` are considered equal, which breaks the general contract of [`Comparable.compareTo`](https://docs.oracle.com/en/java/javase/21/docs/api/java.base/java/lang/Comparable.html#compareTo(T)).

If you look below this `if`-statement:

https://github.com/openjdk/jdk/blob/7bccc847fe9e8c5e640d8fa9c93ce32563a0ccfa/src/java.desktop/windows/classes/sun/awt/shell/Win32ShellFolderManager2.java#L545-L550

The comment and the code say that any special folder sorts above any regular folder. Therefore the code shouldn't enter that `if`-block above if only one of the folders is *special* ? the order is already well-defined for such case.

The purpose of the `if`-block is to make some of the special folders even more special. In other words, it ensures the following special folders?`getPersonal`, `getDesktop`, `getDrives`, `getNetwork`?are at the top of the list, above any other special folders.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18126#discussion_r1525204254

From aivanov at openjdk.org  Thu Mar 14 16:58:38 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Thu, 14 Mar 2024 16:58:38 GMT
Subject: RFR: 8305072: Win32ShellFolder2.compareTo is inconsistent [v2]
In-Reply-To: <76BSt4HYmTD2DiZzBUvNvBdvd5d1MFinIDsgp2YuHjs=.68646608-e266-4ca3-8495-59e237f8607c@github.com>
References: <bEiHvkFnBZDqmiqQdk_-_mATVhDbAD7NZX7VnkHLG2E=.27ee84ba-00fd-405a-9489-8fe11c215af9@github.com>
 <21db5CiFTVN7scwsIHknMxF4YaVQd06m7gUOhcCLvMI=.e2f61ea7-bf9a-4632-bf45-c89f979ae806@github.com>
 <6dQg9rhDwh4ZL7D2JfYpA0xNP_eJDbOK3rNgj7efckM=.c5001d8a-cce5-4a11-a91d-eda8e90b8056@github.com>
 <76BSt4HYmTD2DiZzBUvNvBdvd5d1MFinIDsgp2YuHjs=.68646608-e266-4ca3-8495-59e237f8607c@github.com>
Message-ID: <5btT_N4c5R89DQ8aoSyjm6lIR7PHLWC141uAIdH_Bjw=.f36326e9-0f59-4545-82bf-f3c8b4dbaa87@github.com>

On Thu, 14 Mar 2024 16:49:39 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> src/java.desktop/windows/classes/sun/awt/shell/Win32ShellFolderManager2.java line 525:
>> 
>>> 523:         boolean special2 = sf2.isSpecial();
>>> 524: 
>>> 525:         if (special1 && special2) {
>> 
>> Could you please say something on how/why this change solves it ?
>
> It is well described in a [JBS comment](https://bugs.openjdk.org/browse/JDK-8305072?focusedId=14610400&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14610400) by the submitter.
> 
> Let's consider the failing case where:
> 
> a = C:\Users<user>\Documents(true)
> b = C:\Users<user>(false)
> c = C:\Users<user>\Documents(false)
> 
> The value in parentheses is `isSpecial()` flag.
> 
> When `a` and `c` are compared, `special1 = true` and `special2 = false`, therefore the code flow enters this `if`-block. Because the `equals` method doesn't take into account the `isSpecial` flag, both `i1` and `i2` are 0.
> 
> https://github.com/openjdk/jdk/blob/7bccc847fe9e8c5e640d8fa9c93ce32563a0ccfa/src/java.desktop/windows/classes/sun/awt/shell/Win32ShellFolderManager2.java#L534-L535
> 
> Thus, `a` and `c` are considered equal, which breaks the general contract of [`Comparable.compareTo`](https://docs.oracle.com/en/java/javase/21/docs/api/java.base/java/lang/Comparable.html#compareTo(T)).
> 
> If you look below this `if`-statement:
> 
> https://github.com/openjdk/jdk/blob/7bccc847fe9e8c5e640d8fa9c93ce32563a0ccfa/src/java.desktop/windows/classes/sun/awt/shell/Win32ShellFolderManager2.java#L545-L550
> 
> The comment and the code say that any special folder sorts above any regular folder. Therefore the code shouldn't enter that `if`-block above if only one of the folders is *special* ? the order is already well-defined for such case.
> 
> The purpose of the `if`-block is to make some of the special folders even more special. In other words, it ensures the following special folders?`getPersonal`, `getDesktop`, `getDrives`, `getNetwork`?are at the top of the list, above any other special folders.

So, changing the condition in the `if`-block from `special1 || special2` to `special1 && special2` makes the sorting order consistent because the relation is now *transitive*:


a < b & b < c therefore a < c

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18126#discussion_r1525214351

From aivanov at openjdk.org  Thu Mar 14 17:05:42 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Thu, 14 Mar 2024 17:05:42 GMT
Subject: RFR: 8328011: Convert
 java/awt/Frame/GetBoundsResizeTest/GetBoundsResizeTest.java applet test to
 main [v3]
In-Reply-To: <SrddTqycaD8aD2WSL255mcF79oiejmztWQU1bodvUiE=.afd1eb59-b97f-487f-8afa-f1d3fab5654e@github.com>
References: <77msAoji3SrhXCIcFcOTndR5MCc5jsoomdQ9Udl0WeE=.893b27fe-2ba5-48d9-920f-aab38592b614@github.com>
 <r3m0FPAacrLKOI6SVZnH7GVRslKDpDjwaGECcCD3o0I=.c16baf2a-78f1-4634-93fa-0813f5e381cc@github.com>
 <We8H7oIHrqnp_eMe6gGnfjOgAIGyLS7A2gBL68Gvkaw=.10eae84d-b2f7-4e1e-bc9a-0ec7b0b5e1cc@github.com>
 <SrddTqycaD8aD2WSL255mcF79oiejmztWQU1bodvUiE=.afd1eb59-b97f-487f-8afa-f1d3fab5654e@github.com>
Message-ID: <0U6Gavbvk-y0Ss-urcDihc0UzkvcPI-qNwxaam9PPRA=.f061150b-57db-41b5-853d-6e10dd36c98a@github.com>

On Thu, 14 Mar 2024 16:23:20 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>> test/jdk/java/awt/Frame/GetBoundsResizeTest.java line 44:
>> 
>>> 42:             0. There is a test window with a "Press" button,
>>> 43:                 Its original bounds should be printed in the text area below.
>>> 44:             1. Resize the test window using the upper left corner.
>> 
>> I found it impossible to resize the window by top left corner on Windows? The frame is so small that the Minimize button in the title bar covers the icon.
>
> Hmm, works for me:
> 
> [Screencast.webm](https://github.com/openjdk/jdk/assets/77687766/8d6d5edd-178c-4dd4-9385-9492fde3ce1a)
> 
> Anyway, I changed the default size of the window.

I'm using Windows 11 where the window borders are rounded, it could be the reason why it didn't work for me: the target area to grab the border is already covered by the _Minimise_ button.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18250#discussion_r1525225614

From honkar at openjdk.org  Thu Mar 14 17:07:42 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Thu, 14 Mar 2024 17:07:42 GMT
Subject: RFR: 8327980: Convert
 javax/swing/JToggleButton/4128979/bug4128979.java applet test to main [v2]
In-Reply-To: <h9V1lpm9LrxoTXicUWMB1SyIDjJmPXlp5ohLCmpt3Kw=.32d56f64-83ae-47cc-86ec-efe8a568e038@github.com>
References: <lZHt9pYb75UtaIEtbB0paOkfqR5CUAc6tikhb9YAakU=.ff2adbed-1db2-490a-8747-66ac96d03657@github.com>
 <h9V1lpm9LrxoTXicUWMB1SyIDjJmPXlp5ohLCmpt3Kw=.32d56f64-83ae-47cc-86ec-efe8a568e038@github.com>
Message-ID: <ZqXC3FEtY0pXKoXFcvxL3z-qR-3RkQZ3LlHPyE2IRzw=.440fd1d1-56b2-47f0-9efc-3b33593edf60@github.com>

On Wed, 13 Mar 2024 05:38:35 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Conversion of manual applet test to main based using PassFailJFrame manual framework
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review comment fix

Please remove unused imports

test/jdk/javax/swing/JToggleButton/bug4128979.java line 69:

> 67: 
> 68:     public static void main(String[] args) throws Exception {
> 69:         UIManager.setLookAndFeel("com.sun.java.swing.plaf.windows.WindowsClassicLookAndFeel");

As the test is for Windows only it is good to have OS check along with the `@requires (os.family == "windows")` and throw skipped exception otherwise.

Since it is followed by setting `WindowsClassicLookAndFeel` all the more reason to include this check.

Suggestion:

         if (OSInfo.getOSType() != OSInfo.OSType.WINDOWS) {
            throw new SkippedException("This test is for Windows only");
        }
        UIManager.setLookAndFeel("com.sun.java.swing.plaf.windows.WindowsClassicLookAndFeel");

-------------

Changes requested by honkar (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18233#pullrequestreview-1937291754
PR Review Comment: https://git.openjdk.org/jdk/pull/18233#discussion_r1525227378

From aivanov at openjdk.org  Thu Mar 14 17:11:42 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Thu, 14 Mar 2024 17:11:42 GMT
Subject: RFR: 8328011: Convert
 java/awt/Frame/GetBoundsResizeTest/GetBoundsResizeTest.java applet test to
 main [v4]
In-Reply-To: <PobDvnZXaC9ndd17lzssLfxHjVeNp4NIow8pDjPt5Bc=.13a35555-efa6-46e2-b920-1a4b0480ed72@github.com>
References: <77msAoji3SrhXCIcFcOTndR5MCc5jsoomdQ9Udl0WeE=.893b27fe-2ba5-48d9-920f-aab38592b614@github.com>
 <PobDvnZXaC9ndd17lzssLfxHjVeNp4NIow8pDjPt5Bc=.13a35555-efa6-46e2-b920-1a4b0480ed72@github.com>
Message-ID: <JC4LSnkGkTUh4EMWmcahUqv9q5GD_1AOLPMXgEWa2HI=.0fc8056d-62b6-4821-a03c-f73db666404e@github.com>

On Thu, 14 Mar 2024 16:26:06 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>> The test is converted to main.
>> Tested on Linux, Macos and Windows.
>
> Alexander Zvegintsev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
> 
>  - Merge branch 'master' into testsprint_2024_03/8328011_GetBoundsResizeTest
>  - instructions update, frame resize
>  - extract logFrameBounds, instructions update
>  - minor formatting
>  - 8328011: Convert java/awt/Frame/GetBoundsResizeTest/GetBoundsResizeTest.java applet test to main
>  - 8328011: Convert java/awt/Frame/GetBoundsResizeTest/GetBoundsResizeTest.java applet test to main

Marked as reviewed by aivanov (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18250#pullrequestreview-1937304191

From honkar at openjdk.org  Thu Mar 14 17:22:39 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Thu, 14 Mar 2024 17:22:39 GMT
Subject: RFR: 8328087: Automate javax/swing/JTable/TAB/TAB.java applet test
 [v4]
In-Reply-To: <njiH2w-M29ROc1KPXAvAYzk06ixeb4eEskw7cGK3J3A=.d63b0290-368f-4d4a-b451-4bba41e9bffc@github.com>
References: <MumC6TL2XcA5TmVgQXy8yIDFEqUD08b2dvCUyYu7Kd8=.5891ab36-873a-41f0-b22f-d2fc883c8734@github.com>
 <njiH2w-M29ROc1KPXAvAYzk06ixeb4eEskw7cGK3J3A=.d63b0290-368f-4d4a-b451-4bba41e9bffc@github.com>
Message-ID: <drUg0vaZH0DbphmwEe3vzdxwMsK6oqRhKtbXaoPA_fg=.25309e83-6216-45c2-bd74-962934d5fc22@github.com>

On Thu, 14 Mar 2024 05:22:40 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Conversion of manual applet test to automated test. CI testing is green. Link attached to JBS.
>
> Abhishek Kumar has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Test file update
>  - Rename test file

test/jdk/javax/swing/JTable/Tab.java line 57:

> 55: 
> 56: public class Tab
> 57: {

Minor nit: Opening brace placement

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18274#discussion_r1525247626

From honkar at openjdk.org  Thu Mar 14 17:26:37 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Thu, 14 Mar 2024 17:26:37 GMT
Subject: RFR: 8328087: Automate javax/swing/JTable/TAB/TAB.java applet test
 [v4]
In-Reply-To: <njiH2w-M29ROc1KPXAvAYzk06ixeb4eEskw7cGK3J3A=.d63b0290-368f-4d4a-b451-4bba41e9bffc@github.com>
References: <MumC6TL2XcA5TmVgQXy8yIDFEqUD08b2dvCUyYu7Kd8=.5891ab36-873a-41f0-b22f-d2fc883c8734@github.com>
 <njiH2w-M29ROc1KPXAvAYzk06ixeb4eEskw7cGK3J3A=.d63b0290-368f-4d4a-b451-4bba41e9bffc@github.com>
Message-ID: <DZwXjf4d_ulDMUPEtscTAd7p0BfFu9LXXJHXgf-1GUE=.0fd5ccf8-9072-4318-8e0f-af23ea010d9c@github.com>

On Thu, 14 Mar 2024 05:22:40 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Conversion of manual applet test to automated test. CI testing is green. Link attached to JBS.
>
> Abhishek Kumar has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Test file update
>  - Rename test file

Marked as reviewed by honkar (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18274#pullrequestreview-1937334835

From abhiscxk at openjdk.org  Thu Mar 14 17:27:41 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Thu, 14 Mar 2024 17:27:41 GMT
Subject: RFR: 8328158: Convert java/awt/Choice/NonFocusablePopupMenuTest to
 automatic main test [v4]
In-Reply-To: <_cLhzMaHV2B6w0DWMogu5Abv8Zk4xS_ve9HYWSdTGWc=.32d0ed31-80f1-4fac-b05f-eef88709c2d1@github.com>
References: <5o5Qhfltwmw1WbGujddcfKdNxIQahHyXXFHhaYfrLsM=.6437d7e5-ad8c-43be-b04c-3f45c0c9c54a@github.com>
 <_cLhzMaHV2B6w0DWMogu5Abv8Zk4xS_ve9HYWSdTGWc=.32d0ed31-80f1-4fac-b05f-eef88709c2d1@github.com>
Message-ID: <PKF1YFpA8vealdYvTQnCg48iMWMubHA3XWQhQ-Cy5T8=.bcb9fb47-25d8-4009-97c6-764f253ba909@github.com>

On Thu, 14 Mar 2024 16:48:57 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

>> Convert test to the automatic main and move it from its own folder since it is no longer required.
>
> Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Minor updates

LGTM.

-------------

Marked as reviewed by abhiscxk (Committer).

PR Review: https://git.openjdk.org/jdk/pull/18300#pullrequestreview-1937338680

From abhiscxk at openjdk.org  Thu Mar 14 18:01:55 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Thu, 14 Mar 2024 18:01:55 GMT
Subject: RFR: 8327980: Convert
 javax/swing/JToggleButton/4128979/bug4128979.java applet test to main [v3]
In-Reply-To: <lZHt9pYb75UtaIEtbB0paOkfqR5CUAc6tikhb9YAakU=.ff2adbed-1db2-490a-8747-66ac96d03657@github.com>
References: <lZHt9pYb75UtaIEtbB0paOkfqR5CUAc6tikhb9YAakU=.ff2adbed-1db2-490a-8747-66ac96d03657@github.com>
Message-ID: <HouINeFZmEg4LfJn0h05VOxh-WpGMpMvlzhjCnZ3wzA=.edab7234-7e5b-457a-a111-f27e303664a5@github.com>

> Conversion of manual applet test to main based using PassFailJFrame manual framework

Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:

  Added OS check and remove unused imports

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18233/files
  - new: https://git.openjdk.org/jdk/pull/18233/files/61318960..bd1aaf2e

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18233&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18233&range=01-02

  Stats: 10 lines in 1 file changed: 4 ins; 2 del; 4 mod
  Patch: https://git.openjdk.org/jdk/pull/18233.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18233/head:pull/18233

PR: https://git.openjdk.org/jdk/pull/18233

From abhiscxk at openjdk.org  Thu Mar 14 18:01:55 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Thu, 14 Mar 2024 18:01:55 GMT
Subject: RFR: 8327980: Convert
 javax/swing/JToggleButton/4128979/bug4128979.java applet test to main [v2]
In-Reply-To: <ZqXC3FEtY0pXKoXFcvxL3z-qR-3RkQZ3LlHPyE2IRzw=.440fd1d1-56b2-47f0-9efc-3b33593edf60@github.com>
References: <lZHt9pYb75UtaIEtbB0paOkfqR5CUAc6tikhb9YAakU=.ff2adbed-1db2-490a-8747-66ac96d03657@github.com>
 <h9V1lpm9LrxoTXicUWMB1SyIDjJmPXlp5ohLCmpt3Kw=.32d56f64-83ae-47cc-86ec-efe8a568e038@github.com>
 <ZqXC3FEtY0pXKoXFcvxL3z-qR-3RkQZ3LlHPyE2IRzw=.440fd1d1-56b2-47f0-9efc-3b33593edf60@github.com>
Message-ID: <s7vPeOnHKVsnZ6zzhhYacdGv5APFSHLS6A3AsUgjMhM=.16b7f28c-0d79-446f-b142-ed8585dc0399@github.com>

On Thu, 14 Mar 2024 17:04:22 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review comment fix
>
> test/jdk/javax/swing/JToggleButton/bug4128979.java line 69:
> 
>> 67: 
>> 68:     public static void main(String[] args) throws Exception {
>> 69:         UIManager.setLookAndFeel("com.sun.java.swing.plaf.windows.WindowsClassicLookAndFeel");
> 
> As the test is for Windows only it is good to have OS check along with the `@requires (os.family == "windows")` and throw skipped exception otherwise.
> 
> Since it is followed by setting `WindowsClassicLookAndFeel` all the more reason to include this check.
> 
> Suggestion:
> 
>          if (OSInfo.getOSType() != OSInfo.OSType.WINDOWS) {
>             throw new SkippedException("This test is for Windows only");
>         }
>         UIManager.setLookAndFeel("com.sun.java.swing.plaf.windows.WindowsClassicLookAndFeel");

Updated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18233#discussion_r1525298637

From aivanov at openjdk.org  Thu Mar 14 18:04:40 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Thu, 14 Mar 2024 18:04:40 GMT
Subject: RFR: JDK-8328115 : Convert
 java/awt/font/TextLayout/TestJustification.html applet test to main
In-Reply-To: <-yOR9f0Ysff7awg6qHW2OoFR1zmgLk6c8r9qTFC6QhE=.7ac90ce0-f3f7-4ac6-ba46-945f73a5f4a8@github.com>
References: <-yOR9f0Ysff7awg6qHW2OoFR1zmgLk6c8r9qTFC6QhE=.7ac90ce0-f3f7-4ac6-ba46-945f73a5f4a8@github.com>
Message-ID: <aGZkG2aX5c7g5dCbCtBvaNqp060gRTy2MW3V0rR7XhI=.e07fb132-0bb9-4828-a528-71615c7d2188@github.com>

On Wed, 13 Mar 2024 18:49:03 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

> java/awt/font/TextLayout/TestJustification.html  is converted to main manual test using PassFailJFrame. 
> 
> This test was previously problemlisted on macOS. When tested on macOS, the problem still exists and not all lines are justified to the same length (lines containing Arabic & Hebrew differ by a small amount, Refer [JDK-8250791](https://bugs.openjdk.org/browse/JDK-8250791)). For this reason, the test is retained in problemlist and the file extension in problemlist is changed to .java to match the test changes.

Looks good except for a minor comment.

test/jdk/java/awt/font/TextLayout/TestJustification.java line 77:

> 75: 
> 76:     private static JFrame createUI() {
> 77:         JFrame frame= new JFrame("Test Text Justification");

You probably want to use `Frame` instead of `JFrame` since `JustificationPanel` is an AWT component.

-------------

Marked as reviewed by aivanov (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18285#pullrequestreview-1937403627
PR Review Comment: https://git.openjdk.org/jdk/pull/18285#discussion_r1525297032

From abhiscxk at openjdk.org  Thu Mar 14 18:05:11 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Thu, 14 Mar 2024 18:05:11 GMT
Subject: RFR: 8328087: Automate javax/swing/JTable/TAB/TAB.java applet test
 [v5]
In-Reply-To: <MumC6TL2XcA5TmVgQXy8yIDFEqUD08b2dvCUyYu7Kd8=.5891ab36-873a-41f0-b22f-d2fc883c8734@github.com>
References: <MumC6TL2XcA5TmVgQXy8yIDFEqUD08b2dvCUyYu7Kd8=.5891ab36-873a-41f0-b22f-d2fc883c8734@github.com>
Message-ID: <pGm_A8fwdgfWubc_0dPZKMHUZiAjFcUagULfh0X5OWw=.050b2e38-8e22-43b1-938d-48b899578ef0@github.com>

> Conversion of manual applet test to automated test. CI testing is green. Link attached to JBS.

Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:

  Minor update

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18274/files
  - new: https://git.openjdk.org/jdk/pull/18274/files/0a6e5acb..04c887c9

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18274&range=04
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18274&range=03-04

  Stats: 4 lines in 1 file changed: 0 ins; 2 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/18274.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18274/head:pull/18274

PR: https://git.openjdk.org/jdk/pull/18274

From aivanov at openjdk.org  Thu Mar 14 18:10:40 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Thu, 14 Mar 2024 18:10:40 GMT
Subject: RFR: JDK-8328115 : Convert
 java/awt/font/TextLayout/TestJustification.html applet test to main
In-Reply-To: <-yOR9f0Ysff7awg6qHW2OoFR1zmgLk6c8r9qTFC6QhE=.7ac90ce0-f3f7-4ac6-ba46-945f73a5f4a8@github.com>
References: <-yOR9f0Ysff7awg6qHW2OoFR1zmgLk6c8r9qTFC6QhE=.7ac90ce0-f3f7-4ac6-ba46-945f73a5f4a8@github.com>
Message-ID: <2H_AryxNVoqZ5VBkvXHiSDU7XabSl5zYJGgzvCDatgU=.ef4700c5-d52c-452d-b161-6e31e380b4b8@github.com>

On Wed, 13 Mar 2024 18:49:03 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

> This test was previously problemlisted on macOS. When tested on macOS, the problem still exists?

I wonder if it depends on the font used. Is the selected font available on macOS?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18285#issuecomment-1998041339

From honkar at openjdk.org  Thu Mar 14 18:10:40 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Thu, 14 Mar 2024 18:10:40 GMT
Subject: RFR: JDK-8328115 : Convert
 java/awt/font/TextLayout/TestJustification.html applet test to main
In-Reply-To: <2H_AryxNVoqZ5VBkvXHiSDU7XabSl5zYJGgzvCDatgU=.ef4700c5-d52c-452d-b161-6e31e380b4b8@github.com>
References: <-yOR9f0Ysff7awg6qHW2OoFR1zmgLk6c8r9qTFC6QhE=.7ac90ce0-f3f7-4ac6-ba46-945f73a5f4a8@github.com>
 <2H_AryxNVoqZ5VBkvXHiSDU7XabSl5zYJGgzvCDatgU=.ef4700c5-d52c-452d-b161-6e31e380b4b8@github.com>
Message-ID: <jihcwWyTNO7_Oj3ZZY5RYpxOtvOfIenKPqP9BNSJYqs=.081313e5-2abd-4289-bb09-63eb2d2f37ad@github.com>

On Thu, 14 Mar 2024 18:05:59 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> I wonder if it depends on the font used. Is the selected font available on macOS?

I tried it with Dialog on macOS, it looked the same.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18285#issuecomment-1998045712

From prr at openjdk.org  Thu Mar 14 18:43:06 2024
From: prr at openjdk.org (Phil Race)
Date: Thu, 14 Mar 2024 18:43:06 GMT
Subject: RFR: 8328021: Convert applet test
 java/awt/List/SetFontTest/SetFontTest.html to main program [v2]
In-Reply-To: <PDXY83ODTZ4gxjrMQMJIoLyXeDHkkHJBbsoMVKwL5bQ=.ba1001ce-1197-4ea8-b9c7-bee0605dbf83@github.com>
References: <PDXY83ODTZ4gxjrMQMJIoLyXeDHkkHJBbsoMVKwL5bQ=.ba1001ce-1197-4ea8-b9c7-bee0605dbf83@github.com>
Message-ID: <NcvA-346-v_Z0-t5_icjr7cYZNUOPj1_PpmyFDdyKWk=.7bdebe4d-ecfd-467a-8974-c5dbab71ca55@github.com>

> java/awt/List/SetFontTest/SetFontTest.html is a manual applet-based test.
> It can be converted to a main program test using PassFailJFrame

Phil Race has updated the pull request incrementally with one additional commit since the last revision:

  8328021

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18255/files
  - new: https://git.openjdk.org/jdk/pull/18255/files/08a3ab67..84ba13b2

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18255&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18255&range=00-01

  Stats: 10 lines in 1 file changed: 1 ins; 0 del; 9 mod
  Patch: https://git.openjdk.org/jdk/pull/18255.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18255/head:pull/18255

PR: https://git.openjdk.org/jdk/pull/18255

From prr at openjdk.org  Thu Mar 14 18:43:06 2024
From: prr at openjdk.org (Phil Race)
Date: Thu, 14 Mar 2024 18:43:06 GMT
Subject: RFR: 8328021: Convert applet test
 java/awt/List/SetFontTest/SetFontTest.html to main program [v2]
In-Reply-To: <b7svqyTpHBgX5k1qhFZLjbDM-jWDyfgecjhtRYo5CjU=.4edafbff-55ff-4185-a2b8-fd5e5acb3ebc@github.com>
References: <PDXY83ODTZ4gxjrMQMJIoLyXeDHkkHJBbsoMVKwL5bQ=.ba1001ce-1197-4ea8-b9c7-bee0605dbf83@github.com>
 <b7svqyTpHBgX5k1qhFZLjbDM-jWDyfgecjhtRYo5CjU=.4edafbff-55ff-4185-a2b8-fd5e5acb3ebc@github.com>
Message-ID: <yb7BXtW7Sphvf-FF0NKDkV2dTESrxp8mGl_-9rnjLa8=.3c78db9a-cd43-44b9-b5fe-e830e8e6fa08@github.com>

On Thu, 14 Mar 2024 10:22:50 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8328021
>
> test/jdk/java/awt/List/SetFontTest.java line 42:
> 
>> 40: public class SetFontTest {
>> 41: 
>> 42:     static final String INSTRUCTIONS =
> 
> Looks cleaner with `Text Blocks`.
> 
> """ 
>                     1) Click on the 'Enlarge font' button to enlarge font of the list.
>                     2) If you see that the rows of the list overlap one another
>                     then the test failed. Otherwise, go to step 3.
>                     3) Click on the 'Change mode' button to set multiple-selection mode.
>                     4) If you see that the rows of the list overlap one another
>                     then the test failed. Otherwise, the test passed.""";

It does, so I changed it, although this was an edit of the existing code, not a new one from the HTML file contents.

> test/jdk/java/awt/List/SetFontTest.java line 92:
> 
>> 90:         frame.add(button1);
>> 91:         frame.add(button2);
>> 92:         frame.setSize(200,250);
> 
> minor : 
> Suggestion:
> 
>         frame.setSize(200, 250);

ok

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18255#discussion_r1525340200
PR Review Comment: https://git.openjdk.org/jdk/pull/18255#discussion_r1525340737

From prr at openjdk.org  Thu Mar 14 18:43:06 2024
From: prr at openjdk.org (Phil Race)
Date: Thu, 14 Mar 2024 18:43:06 GMT
Subject: RFR: 8328021: Convert applet test
 java/awt/List/SetFontTest/SetFontTest.html to main program [v2]
In-Reply-To: <OunX7t4cLmm7bcpooHtypgxdS2Fcsscc0dR2dtKrCjA=.efff622d-bd6c-4583-a4eb-c32bcf3173cf@github.com>
References: <PDXY83ODTZ4gxjrMQMJIoLyXeDHkkHJBbsoMVKwL5bQ=.ba1001ce-1197-4ea8-b9c7-bee0605dbf83@github.com>
 <OunX7t4cLmm7bcpooHtypgxdS2Fcsscc0dR2dtKrCjA=.efff622d-bd6c-4583-a4eb-c32bcf3173cf@github.com>
Message-ID: <eNz1cvLlTiwXgudqHFYtd5jV0sHxmB0dBv-F3R6KHS8=.5e05c5d8-a058-423f-8eab-b9bc1e4db7ee@github.com>

On Thu, 14 Mar 2024 00:23:01 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8328021
>
> test/jdk/java/awt/List/SetFontTest.java line 55:
> 
>> 53:                        .instructions(INSTRUCTIONS)
>> 54:                        .rows(10)
>> 55:                        .columns(60)
> 
> Existing config looks too wide for the instructions.
> 
> Suggestion:
> 
>                        .columns(35)

35 seems too tight - 40 looks better

> test/jdk/java/awt/List/SetFontTest.java line 74:
> 
>> 72: 
>> 73:         button1.addActionListener(
>> 74:             new ActionListener(){
> 
> It can be shortened with lambda

hmm, yes, but not necessary for porting the test.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18255#discussion_r1525339013
PR Review Comment: https://git.openjdk.org/jdk/pull/18255#discussion_r1525340562

From honkar at openjdk.org  Thu Mar 14 19:05:38 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Thu, 14 Mar 2024 19:05:38 GMT
Subject: RFR: 8328021: Convert applet test
 java/awt/List/SetFontTest/SetFontTest.html to main program [v2]
In-Reply-To: <NcvA-346-v_Z0-t5_icjr7cYZNUOPj1_PpmyFDdyKWk=.7bdebe4d-ecfd-467a-8974-c5dbab71ca55@github.com>
References: <PDXY83ODTZ4gxjrMQMJIoLyXeDHkkHJBbsoMVKwL5bQ=.ba1001ce-1197-4ea8-b9c7-bee0605dbf83@github.com>
 <NcvA-346-v_Z0-t5_icjr7cYZNUOPj1_PpmyFDdyKWk=.7bdebe4d-ecfd-467a-8974-c5dbab71ca55@github.com>
Message-ID: <Z-2FV1gNgVxtCK-tNNrYqySkh8Ygi6n7rqyLeIp7g_0=.f2e66e68-cd65-455a-ac65-20e9f751066a@github.com>

On Thu, 14 Mar 2024 18:43:06 GMT, Phil Race <prr at openjdk.org> wrote:

>> java/awt/List/SetFontTest/SetFontTest.html is a manual applet-based test.
>> It can be converted to a main program test using PassFailJFrame
>
> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8328021

Marked as reviewed by honkar (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18255#pullrequestreview-1937521366

From prr at openjdk.org  Thu Mar 14 19:23:43 2024
From: prr at openjdk.org (Phil Race)
Date: Thu, 14 Mar 2024 19:23:43 GMT
Subject: Integrated: 8328021: Convert applet test
 java/awt/List/SetFontTest/SetFontTest.html to main program
In-Reply-To: <PDXY83ODTZ4gxjrMQMJIoLyXeDHkkHJBbsoMVKwL5bQ=.ba1001ce-1197-4ea8-b9c7-bee0605dbf83@github.com>
References: <PDXY83ODTZ4gxjrMQMJIoLyXeDHkkHJBbsoMVKwL5bQ=.ba1001ce-1197-4ea8-b9c7-bee0605dbf83@github.com>
Message-ID: <9r4g9w9Ybh_03EbPwHjqlgaqbYTC44g-yOw3UmfJti8=.ea0736df-bc35-47bc-9fd7-8a97df018a8b@github.com>

On Tue, 12 Mar 2024 22:55:02 GMT, Phil Race <prr at openjdk.org> wrote:

> java/awt/List/SetFontTest/SetFontTest.html is a manual applet-based test.
> It can be converted to a main program test using PassFailJFrame

This pull request has now been integrated.

Changeset: 87bd6cac
Author:    Phil Race <prr at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/87bd6caca03745c21172c3b5e8b0d28724810352
Stats:     373 lines in 3 files changed: 96 ins; 277 del; 0 mod

8328021: Convert applet test java/awt/List/SetFontTest/SetFontTest.html to main program

Reviewed-by: honkar, abhiscxk

-------------

PR: https://git.openjdk.org/jdk/pull/18255

From serb at openjdk.org  Thu Mar 14 19:41:41 2024
From: serb at openjdk.org (Sergey Bylokhov)
Date: Thu, 14 Mar 2024 19:41:41 GMT
Subject: RFR: 8327137: Add test for ConcurrentModificationException in
 BasicDirectoryModel
In-Reply-To: <mCqqjrXVWDB2PvpOhKHx-Hr8W6tUz6v4stztGmyAeEg=.1f95da1c-e1a5-40be-be8b-0758729fa9b9@github.com>
References: <mCqqjrXVWDB2PvpOhKHx-Hr8W6tUz6v4stztGmyAeEg=.1f95da1c-e1a5-40be-be8b-0758729fa9b9@github.com>
Message-ID: <HvJ96YzIfnTtdNh7R5XtYs_t0sc5VfHjBHUxi9uyJdI=.94715923-e3c0-4666-9a51-340ef91b8b3b@github.com>

On Mon, 4 Mar 2024 15:52:45 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> I'm adding a regression test for [JDK-8323670](https://bugs.openjdk.org/browse/JDK-8323670) and [JDK-8307091](https://bugs.openjdk.org/browse/JDK-8307091); it's also a regression test for [JDK-8240690](https://bugs.openjdk.org/browse/JDK-8240690).
> 
> I referenced this test in PR #17462 in [this comment](https://github.com/openjdk/jdk/pull/17462#issuecomment-1914844026). I fine-tuned the test since that time.
> 
> The test doesn't fail all the time without the fix for JDK-8323670, however, it fails sometimes. If you run the test several times, it will likely fail _without the fix_.
> 
> For me, the test fails about 10 times from 40 runs in the CI. It fails on macOS more frequently than on Linux.
> 
> When the test passes, it usually completes in 5 minutes.
> 
> **How the test works**
> 
> The test creates a temporary directory in the current directory and creates a number of files in it. (The number of files is controlled by `NUMBER_OF_THREADS` constant). Then the test creates `JFileChooser` in the temporary directory.
> 
> The test starts several _scanner_ threads, the number is controlled by `NUMBER_OF_THREADS`, which repeatedly call `fileChooser.rescanCurrentDirectory()`. This results in calling `BasicDirectoryModel.validateFileCache` which starts a background thread ? "Basic L&F File Loading Thread" ? to enumerate the files.
> 
> A timer is used to create new files in the directory that the file chooser is using.
> 
> After enumerating the files, the File Loading Thread posts an event to EDT. The event updates `fileCache` and fires a `ListDataEvent`.
> 
> If the File Loading Thread is iterating over `fileCache` using `Iterator` (when `fileCache.subList` or `fileCache.equals` is running; or a new `Vector` instance is created from a `fileCache` or its sublist) and `fileCache` is being updated on EDT, then `ConcurrentModificationException` is thrown.
> 
> On Linux and on _headless_ macOS, `ShellFolder.invoke` is executed in the caller, which makes it easier to reproduce the issue. Because of [JDK-8325179](https://bugs.openjdk.org/browse/JDK-8325179), there are several File Loading Threads, which also helps to reproduce the issue.
> 
> On _headful_ macOS, the `BasicDirectoryModel` is not used, so the test does not reproduce the issue.
> 
> On Windows, the test does not fail or fails with `OutOfMemoryError`. It is because all the File Loading Threads are serialised on the COM thread, `ShellFolder.invoke` submits the task to the COM thread and waits for it to complete. The chance of updating `fileCache` whil...

test/jdk/javax/swing/plaf/basic/BasicDirectoryModel/ConcurrentModification.java line 1:

> 1: import java.io.IOException;

the header is missing.

test/jdk/javax/swing/plaf/basic/BasicDirectoryModel/ConcurrentModification.java line 99:

> 97:             createFiles(temp);
> 98: 
> 99:             final JFileChooser fc = new JFileChooser(temp.toFile());

it should be created on EDT, just in case.

test/jdk/javax/swing/plaf/basic/BasicDirectoryModel/ConcurrentModification.java line 211:

> 209:     private static void deleteFile(final Path file) {
> 210:         try {
> 211:             Files.delete(file);

Should we try to delete all files first and then throw an exception if any?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18109#discussion_r1525401885
PR Review Comment: https://git.openjdk.org/jdk/pull/18109#discussion_r1525401638
PR Review Comment: https://git.openjdk.org/jdk/pull/18109#discussion_r1525403026

From prr at openjdk.org  Thu Mar 14 19:41:46 2024
From: prr at openjdk.org (Phil Race)
Date: Thu, 14 Mar 2024 19:41:46 GMT
Subject: RFR: 8203867: Delete test
 java/awt/TrayIcon/DblClickActionEventTest/DblClickActionEventTest.html
Message-ID: <XsHRbu46y31j1NdHaDYd6R-N0AUPWFtop4Z68OdjKwM=.54968e7f-1d43-4dfa-a672-00eda52e7264@github.com>

This test draws the same tray icon, has similar instructions to, and is subsumed by the related test   DisposeInActionEventTest.java
And because this test has incomplete instructions not covering macOS it is problem-listed.
The other test explicitly covers macOS. 
So the right answer is to remove this manual applet test which adds no valuable coverage and just costs time + effort to run.

-------------

Commit messages:
 - 8203867

Changes: https://git.openjdk.org/jdk/pull/18311/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18311&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8203867
  Stats: 165 lines in 3 files changed: 0 ins; 165 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18311.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18311/head:pull/18311

PR: https://git.openjdk.org/jdk/pull/18311

From serb at openjdk.org  Thu Mar 14 19:45:39 2024
From: serb at openjdk.org (Sergey Bylokhov)
Date: Thu, 14 Mar 2024 19:45:39 GMT
Subject: RFR: 8325179: Race in BasicDirectoryModel.validateFileCache [v3]
In-Reply-To: <y7op4cIxEXuSfLzVymc5kyX7omx7Q4EWluVgyubRqxU=.35b2365e-338d-40f2-9f36-58ad49398892@github.com>
References: <nOapec57Ql6DHy57oEeWdkUGER8RYdWc2vwmJsqWDYc=.8de81954-d8c2-4937-b426-e61dde05255e@github.com>
 <mRgGz4hgCDyP3rkwMuNfdMCmm5YCsIBDtkgwe8TJc_4=.a1ed1fd7-f8fc-44b9-8599-28dd9774a98a@github.com>
 <y7op4cIxEXuSfLzVymc5kyX7omx7Q4EWluVgyubRqxU=.35b2365e-338d-40f2-9f36-58ad49398892@github.com>
Message-ID: <tD0OyG3jQZnOmsLS_KkfZA6OfxjpQFISvAe3lNtN0oY=.c7c8053b-3038-47c9-b540-da8ca32b940e@github.com>

On Tue, 5 Mar 2024 11:04:30 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicDirectoryModel.java line 101:
>> 
>>> 99:      */
>>> 100:     public synchronized void invalidateFileCache() {
>>> 101:         if (filesLoader != null) {
>> 
>> This is a public API method, can we minimize the change and use "synchronized (this)" instead?
>
> The `synchronized` modifier is not part of public API specification, it's not shown in the generated Javadoc. Anyway, I updated the code to use `synchronized (this)` block inside the method.

I thought that is checked by the sigtests. at least previously the removing of synchronized keyword requires the CSR.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18111#discussion_r1525408186

From serb at openjdk.org  Thu Mar 14 19:59:40 2024
From: serb at openjdk.org (Sergey Bylokhov)
Date: Thu, 14 Mar 2024 19:59:40 GMT
Subject: RFR: 8325179: Race in BasicDirectoryModel.validateFileCache [v3]
In-Reply-To: <mVHHIki7p8TDSN0TlD0kaRuNzWUHom5W-y7y51rxjSA=.35bcbabb-4c2c-4f9e-a48b-b34995336da2@github.com>
References: <nOapec57Ql6DHy57oEeWdkUGER8RYdWc2vwmJsqWDYc=.8de81954-d8c2-4937-b426-e61dde05255e@github.com>
 <mVHHIki7p8TDSN0TlD0kaRuNzWUHom5W-y7y51rxjSA=.35bcbabb-4c2c-4f9e-a48b-b34995336da2@github.com>
Message-ID: <auKMGEN3ftIcC2HpqrsLEEYXkA4zaZwj5wayrEZREEs=.93c4622b-8aa4-447e-955c-dbf3a39ec730@github.com>

On Wed, 6 Mar 2024 11:27:08 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Ensure access to the `filesLoader` field of `BasicDirectoryModel` is synchronized.
>> 
>> Without synchronization, a thread checks if `filesLoader` is not null and creates a new `FilesLoader` thread. If the thread is pre-empted between these two operations, another thread or even several threads can see the `null` value and create new `FilesLoader` threads.
>> 
>> The same way, `BasicDirectoryModel.invalidateFileCache` needs to be synchornized to interrupt the current `filesLoader` and assign `null`.
>> 
>> This bug allows reproducing `ConcurrentModificationException` seen in [JDK-8323670](https://bugs.openjdk.org/browse/JDK-8323670) and [JDK-8307091](https://bugs.openjdk.org/browse/JDK-8307091) using the test in PR #18109.
>
> Alexey Ivanov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Store the size of fileCache inside synchronized block

src/java.desktop/share/classes/javax/swing/plaf/basic/BasicDirectoryModel.java line 534:

> 532:         @Override
> 533:         public void run() {
> 534:             if (fetchID.get() != fid) {

How it will work if the "FilesLoader" was created already but before loading the files the "invalidateFileCache" was called, before the patch we stop execution due to "doFire=false".

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18111#discussion_r1525420964

From honkar at openjdk.org  Thu Mar 14 20:07:50 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Thu, 14 Mar 2024 20:07:50 GMT
Subject: RFR: JDK-8328190 : Convert AWTPanelSmoothWheel.html applet test to
 main
Message-ID: <sn9qb9ctS_sr3isHbwcbMCYh2RQokz2ptsw0rGBRnJY=.955d7549-72c7-4a4f-8ac8-a5d6f122cf68@github.com>

This test is converted to main using PassFailJFrame. It verifies wheel rotation value for high-res mouse on windows.

The test requires the updated PassFailJFrame changes added in this PR https://github.com/openjdk/jdk/pull/18281

-------------

Commit messages:
 - whitespace removed
 - default timeout used
 - @requires tag
 - title change
 - converted test to main
 - delete .html file
 - moved test file

Changes: https://git.openjdk.org/jdk/pull/18312/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18312&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8328190
  Stats: 377 lines in 3 files changed: 83 ins; 294 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18312.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18312/head:pull/18312

PR: https://git.openjdk.org/jdk/pull/18312

From honkar at openjdk.org  Thu Mar 14 20:07:51 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Thu, 14 Mar 2024 20:07:51 GMT
Subject: RFR: JDK-8328190 : Convert AWTPanelSmoothWheel.html applet test to
 main
In-Reply-To: <sn9qb9ctS_sr3isHbwcbMCYh2RQokz2ptsw0rGBRnJY=.955d7549-72c7-4a4f-8ac8-a5d6f122cf68@github.com>
References: <sn9qb9ctS_sr3isHbwcbMCYh2RQokz2ptsw0rGBRnJY=.955d7549-72c7-4a4f-8ac8-a5d6f122cf68@github.com>
Message-ID: <RPwPEOEJRJlr-Ll8yhvyfdyN_WV3FXErSPRlfjnNCAc=.eb6c0714-2631-4f95-a93e-9f43125ee726@github.com>

On Thu, 14 Mar 2024 19:50:18 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

> This test is converted to main using PassFailJFrame. It verifies wheel rotation value for high-res mouse on windows.
> 
> The test requires the updated PassFailJFrame changes added in this PR https://github.com/openjdk/jdk/pull/18281

test/jdk/java/awt/event/MouseEvent/AWTPanelSmoothWheel.java line 47:

> 45:             This test is relevant for windows platforms and mouses with high-resolution wheel,
> 46:             please just press pass if this is not the case.
> 47:             

@prrace I wanted to check the relevance of the testing requirement. The original test was created for Windows Vista and for a high-res mouse. I think the test can be retained to check on newer versions of windows. Any suggestions?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18312#discussion_r1525418163

From honkar at openjdk.org  Thu Mar 14 21:02:50 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Thu, 14 Mar 2024 21:02:50 GMT
Subject: RFR: JDK-8328190 : Convert AWTPanelSmoothWheel.html applet test to
 main [v2]
In-Reply-To: <sn9qb9ctS_sr3isHbwcbMCYh2RQokz2ptsw0rGBRnJY=.955d7549-72c7-4a4f-8ac8-a5d6f122cf68@github.com>
References: <sn9qb9ctS_sr3isHbwcbMCYh2RQokz2ptsw0rGBRnJY=.955d7549-72c7-4a4f-8ac8-a5d6f122cf68@github.com>
Message-ID: <WKAY4W7HpBPciFiIFaiXUkU3MSnQPkF2dRL0wQTnHpM=.58e661c4-9df2-4586-a029-0b1604cac9c1@github.com>

> This test is converted to main using PassFailJFrame. It verifies wheel rotation value for high-res mouse on windows.
> 
> The test requires the updated PassFailJFrame changes added in this PR https://github.com/openjdk/jdk/pull/18281

Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:

  ordering of imports

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18312/files
  - new: https://git.openjdk.org/jdk/pull/18312/files/c6f6070e..627ec863

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18312&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18312&range=00-01

  Stats: 4 lines in 1 file changed: 2 ins; 2 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18312.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18312/head:pull/18312

PR: https://git.openjdk.org/jdk/pull/18312

From prr at openjdk.org  Thu Mar 14 21:32:59 2024
From: prr at openjdk.org (Phil Race)
Date: Thu, 14 Mar 2024 21:32:59 GMT
Subject: RFR: 8328218: Delete test java/awt/Window/FindOwner/FindOwner.html
Message-ID: <rPYMpiZKqRGM9UMbqQmyW2gQXGogpJC0klAbrW1PeAU=.744fd84d-f5a7-4082-8ff0-48e7c8b39a2c@github.com>

After some experimentation/thought I think it best to delete this applet test.

It is supposed to be a manual test but is missing the manual keyword so
as far as I can tell it has never been usefully run. Except perhaps a few times
when first being verified.
When I run it in jtreg a window popups up, disappears and the test is passed
Contradicting instructions in the test that tell you it has to be manual because
you need to run it *in the browser* not jtreg.

Well, we don't support browser applets any more.
And the scenario it was testing was explicitly a case that happened with the browser.

And to cap it all, I see no way for you to tell jtreg that it passed or failed - because
you run it in the browser.

So it is manual in the sense that it is NOT a jtreg test and so it should not even have
an @test tag.

These are more than enough reasons to just delete it.

-------------

Commit messages:
 - 8328218

Changes: https://git.openjdk.org/jdk/pull/18314/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18314&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8328218
  Stats: 154 lines in 2 files changed: 0 ins; 154 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18314.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18314/head:pull/18314

PR: https://git.openjdk.org/jdk/pull/18314

From azvegint at openjdk.org  Thu Mar 14 21:44:46 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Thu, 14 Mar 2024 21:44:46 GMT
Subject: Integrated: 8328011: Convert
 java/awt/Frame/GetBoundsResizeTest/GetBoundsResizeTest.java applet test to
 main
In-Reply-To: <77msAoji3SrhXCIcFcOTndR5MCc5jsoomdQ9Udl0WeE=.893b27fe-2ba5-48d9-920f-aab38592b614@github.com>
References: <77msAoji3SrhXCIcFcOTndR5MCc5jsoomdQ9Udl0WeE=.893b27fe-2ba5-48d9-920f-aab38592b614@github.com>
Message-ID: <IGKH_wQgn1PYEYbTEC7uOWWPtyliWBVHj_5TlrhC2w4=.a2cfb3d5-3c83-4f17-b75d-d4bd452008f5@github.com>

On Tue, 12 Mar 2024 19:28:45 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

> The test is converted to main.
> Tested on Linux, Macos and Windows.

This pull request has now been integrated.

Changeset: df909e2f
Author:    Alexander Zvegintsev <azvegint at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/df909e2f9c83d6de119ae20edf57e604644e0441
Stats:     265 lines in 2 files changed: 97 ins; 168 del; 0 mod

8328011: Convert java/awt/Frame/GetBoundsResizeTest/GetBoundsResizeTest.java applet test to main

Reviewed-by: honkar, aivanov

-------------

PR: https://git.openjdk.org/jdk/pull/18250

From honkar at openjdk.org  Thu Mar 14 22:46:56 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Thu, 14 Mar 2024 22:46:56 GMT
Subject: RFR: JDK-8328225: Convert ImageDecoratedDnD.html applet test to main
Message-ID: <yHnt-BqOUlo1IKduuk0nv0ZsoReWANI_g4BxukwDzUQ=.24dff5fe-2737-45cc-867e-42f137172363@github.com>

Following test is converted to main using PassFailJFrame.

-------------

Commit messages:
 - EOF newline added
 - Instructions updated
 - applet to main

Changes: https://git.openjdk.org/jdk/pull/18315/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18315&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8328225
  Stats: 247 lines in 2 files changed: 45 ins; 186 del; 16 mod
  Patch: https://git.openjdk.org/jdk/pull/18315.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18315/head:pull/18315

PR: https://git.openjdk.org/jdk/pull/18315

From honkar at openjdk.org  Thu Mar 14 22:46:56 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Thu, 14 Mar 2024 22:46:56 GMT
Subject: RFR: JDK-8328225: Convert ImageDecoratedDnD.html applet test to
 main
In-Reply-To: <yHnt-BqOUlo1IKduuk0nv0ZsoReWANI_g4BxukwDzUQ=.24dff5fe-2737-45cc-867e-42f137172363@github.com>
References: <yHnt-BqOUlo1IKduuk0nv0ZsoReWANI_g4BxukwDzUQ=.24dff5fe-2737-45cc-867e-42f137172363@github.com>
Message-ID: <8-xeU7RcrWLzg2ODCm5TFeqO8d_XR4uDsiy-VdLMB0c=.391ef94a-1c24-4799-9ae4-a7fb752364ab@github.com>

On Thu, 14 Mar 2024 22:41:20 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

> Following test is converted to main using PassFailJFrame.

test/jdk/java/awt/dnd/ImageDecoratedDnD/ImageDecoratedDnD.java line 56:

> 54:                 In WIN32 systems the image under cursor would be visible ONLY over
> 55:                 the drop targets with activated extended OLE D'n'D support (that are,
> 56:                 the desktop and IE).

@prrace Do we retain the testing instructions related to Win32 as they are quite old?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18315#discussion_r1525572508

From achung at openjdk.org  Thu Mar 14 22:55:44 2024
From: achung at openjdk.org (Alisen Chung)
Date: Thu, 14 Mar 2024 22:55:44 GMT
Subject: Integrated: 8327857: Remove applet usage from JColorChooser tests
 Test4222508
In-Reply-To: <k-sLqO64HbTaYgimerOjfrS6NdPEYkOW4Wh9u-ln1P4=.fcb4e582-2189-4486-afb4-570cdeed6e69@github.com>
References: <k-sLqO64HbTaYgimerOjfrS6NdPEYkOW4Wh9u-ln1P4=.fcb4e582-2189-4486-afb4-570cdeed6e69@github.com>
Message-ID: <nrRg2yEqCoXtR3yTgQwXmGypRdmuAGar1sEjLXlVKTA=.7e4c1d7e-2c86-4e53-b2f8-7effb910c9ab@github.com>

On Mon, 11 Mar 2024 23:57:17 GMT, Alisen Chung <achung at openjdk.org> wrote:

> Removing applet usage from manual JColorChooser tests

This pull request has now been integrated.

Changeset: 7c6fd337
Author:    Alisen Chung <achung at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/7c6fd337d00d4bdeaac724a6ea26fac3654846e0
Stats:     76 lines in 2 files changed: 22 ins; 40 del; 14 mod

8327857: Remove applet usage from JColorChooser tests Test4222508

Reviewed-by: prr, tr

-------------

PR: https://git.openjdk.org/jdk/pull/18209

From achung at openjdk.org  Thu Mar 14 22:55:44 2024
From: achung at openjdk.org (Alisen Chung)
Date: Thu, 14 Mar 2024 22:55:44 GMT
Subject: Integrated: 8327859: Remove applet usage from JColorChooser tests
 Test4319113
In-Reply-To: <mzB8yqtVTWIuecXJk5qt1J5Me6iU857a4YMC26xXiyg=.b8fc4e43-3298-4f5c-ab52-8664d30c2d08@github.com>
References: <mzB8yqtVTWIuecXJk5qt1J5Me6iU857a4YMC26xXiyg=.b8fc4e43-3298-4f5c-ab52-8664d30c2d08@github.com>
Message-ID: <dTfqVUR8iuMHIrOJQLxJGNZZ_0LUbCZk8Eu7OCsdjdk=.9e4ff883-0772-456f-95f6-a96ee6a7d864@github.com>

On Tue, 12 Mar 2024 00:24:38 GMT, Alisen Chung <achung at openjdk.org> wrote:

> Removing applet usage from manual JColorChooser tests

This pull request has now been integrated.

Changeset: 89fb0f83
Author:    Alisen Chung <achung at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/89fb0f837b7dbeed581f5db79d915cf405afda31
Stats:     108 lines in 2 files changed: 22 ins; 53 del; 33 mod

8327859: Remove applet usage from JColorChooser tests Test4319113

Reviewed-by: prr, tr

-------------

PR: https://git.openjdk.org/jdk/pull/18210

From achung at openjdk.org  Thu Mar 14 22:56:07 2024
From: achung at openjdk.org (Alisen Chung)
Date: Thu, 14 Mar 2024 22:56:07 GMT
Subject: RFR: 8328121: Remove applet usage from JColorChooser tests
 Test4759306 [v5]
In-Reply-To: <C8wP7UJKyxmliTDxZ5YYEZS4TcPytfHn86fCL_zTI3o=.8fa88a3e-1156-4f66-b6d8-00c182299d66@github.com>
References: <C8wP7UJKyxmliTDxZ5YYEZS4TcPytfHn86fCL_zTI3o=.8fa88a3e-1156-4f66-b6d8-00c182299d66@github.com>
Message-ID: <JkiT1b4Yh0Eo3LHJ0ui8NDTrQbig_rcNle8JK_TCt0s=.8177469b-c406-41f0-9bc1-9ac8f8a3feb0@github.com>

> Removing applet usage from manual JColorChooser tests

Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:

  remove jframe import

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18286/files
  - new: https://git.openjdk.org/jdk/pull/18286/files/464822ca..de7c3328

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18286&range=04
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18286&range=03-04

  Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18286.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18286/head:pull/18286

PR: https://git.openjdk.org/jdk/pull/18286

From achung at openjdk.org  Thu Mar 14 22:56:08 2024
From: achung at openjdk.org (Alisen Chung)
Date: Thu, 14 Mar 2024 22:56:08 GMT
Subject: Integrated: 8328121: Remove applet usage from JColorChooser tests
 Test4759306
In-Reply-To: <C8wP7UJKyxmliTDxZ5YYEZS4TcPytfHn86fCL_zTI3o=.8fa88a3e-1156-4f66-b6d8-00c182299d66@github.com>
References: <C8wP7UJKyxmliTDxZ5YYEZS4TcPytfHn86fCL_zTI3o=.8fa88a3e-1156-4f66-b6d8-00c182299d66@github.com>
Message-ID: <qsDN7ZYeOm5zGPDSWNP0-OshrIPmsC0o0Wj9hU37MH0=.4fb69c4a-fd69-4be4-ab66-6374723d2e21@github.com>

On Wed, 13 Mar 2024 19:26:15 GMT, Alisen Chung <achung at openjdk.org> wrote:

> Removing applet usage from manual JColorChooser tests

This pull request has now been integrated.

Changeset: fab0edc9
Author:    Alisen Chung <achung at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/fab0edc9e636c69d7012e476e97661ddae993a03
Stats:     54 lines in 2 files changed: 14 ins; 33 del; 7 mod

8328121: Remove applet usage from JColorChooser tests Test4759306

Reviewed-by: azvegint

-------------

PR: https://git.openjdk.org/jdk/pull/18286

From achung at openjdk.org  Thu Mar 14 22:56:42 2024
From: achung at openjdk.org (Alisen Chung)
Date: Thu, 14 Mar 2024 22:56:42 GMT
Subject: Integrated: 8328130: Remove applet usage from JColorChooser tests
 Test4759934
In-Reply-To: <V5jXFcSvoonQJFoR7h-oRHEL9JLd6Pz5J1gzv2DJVH0=.aa6c1453-59fc-41ed-bfa9-af86f2d52a1f@github.com>
References: <V5jXFcSvoonQJFoR7h-oRHEL9JLd6Pz5J1gzv2DJVH0=.aa6c1453-59fc-41ed-bfa9-af86f2d52a1f@github.com>
Message-ID: <T5sibqDKc-5hm93JGLA16UzFJxy4x_xedqqjYnsY2C0=.087bc591-c38d-4ecd-9570-a8bbe6700ffd@github.com>

On Wed, 13 Mar 2024 20:57:42 GMT, Alisen Chung <achung at openjdk.org> wrote:

> Removing applet usage from manual JColorChooser tests

This pull request has now been integrated.

Changeset: be1dd275
Author:    Alisen Chung <achung at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/be1dd275a4b4fcae00e4c3c48b3e8e4b1d84ba2b
Stats:     112 lines in 2 files changed: 44 ins; 54 del; 14 mod

8328130: Remove applet usage from JColorChooser tests Test4759934

Reviewed-by: prr

-------------

PR: https://git.openjdk.org/jdk/pull/18288

From achung at openjdk.org  Thu Mar 14 23:09:45 2024
From: achung at openjdk.org (Alisen Chung)
Date: Thu, 14 Mar 2024 23:09:45 GMT
Subject: RFR: 8328227: Remove applet usage from JColorChooser tests Test4887836
Message-ID: <sz94hhkj7mCeInxQ075Uwe14NVjdUMDk3sbuOr1E2X0=.2cc0c644-dd7a-4044-aa17-c082abaf74b6@github.com>

Removing applet usage from manual JColorChooser tests

-------------

Commit messages:
 - init commit

Changes: https://git.openjdk.org/jdk/pull/18316/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18316&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8328227
  Stats: 66 lines in 2 files changed: 23 ins; 38 del; 5 mod
  Patch: https://git.openjdk.org/jdk/pull/18316.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18316/head:pull/18316

PR: https://git.openjdk.org/jdk/pull/18316

From achung at openjdk.org  Thu Mar 14 23:41:59 2024
From: achung at openjdk.org (Alisen Chung)
Date: Thu, 14 Mar 2024 23:41:59 GMT
Subject: RFR: 8328228: Missing comma in copyright year for a few JColorChooser
 tests
Message-ID: <VJw2CeCxX1eJEhaCg1liDRHS3G3yDzuqtG9SW6FCb1M=.55059924-1e47-4ad4-bbf0-80f2bfcbab03@github.com>

Adding comma to copyright years

-------------

Commit messages:
 - init commit

Changes: https://git.openjdk.org/jdk/pull/18317/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18317&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8328228
  Stats: 4 lines in 4 files changed: 0 ins; 0 del; 4 mod
  Patch: https://git.openjdk.org/jdk/pull/18317.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18317/head:pull/18317

PR: https://git.openjdk.org/jdk/pull/18317

From dholmes at openjdk.org  Thu Mar 14 23:41:59 2024
From: dholmes at openjdk.org (David Holmes)
Date: Thu, 14 Mar 2024 23:41:59 GMT
Subject: RFR: 8328228: Missing comma in copyright year for a few
 JColorChooser tests
In-Reply-To: <VJw2CeCxX1eJEhaCg1liDRHS3G3yDzuqtG9SW6FCb1M=.55059924-1e47-4ad4-bbf0-80f2bfcbab03@github.com>
References: <VJw2CeCxX1eJEhaCg1liDRHS3G3yDzuqtG9SW6FCb1M=.55059924-1e47-4ad4-bbf0-80f2bfcbab03@github.com>
Message-ID: <-r6p4PjPn8f_QXRtfUMCWrq2qHnvjHcJuZLLBiXRJNI=.745298ad-d021-4db7-a453-2245cf19c9b9@github.com>

On Thu, 14 Mar 2024 23:36:13 GMT, Alisen Chung <achung at openjdk.org> wrote:

> Adding comma to copyright years

Changes requested by dholmes (Reviewer).

test/jdk/javax/swing/JColorChooser/Test4759306.java line 2:

> 1: /*
> 2:  * Copyright (c) 2002, 2008, 2024, Oracle and/or its affiliates. All rights reserved.

This line is wrong, we only use the first and last years. Please delete "2008, "

test/jdk/javax/swing/JColorChooser/Test4759934.java line 2:

> 1: /*
> 2:  * Copyright (c) 2003, 2008, 2024, Oracle and/or its affiliates. All rights reserved.

Same here - please delete 2008.

-------------

PR Review: https://git.openjdk.org/jdk/pull/18317#pullrequestreview-1937894902
PR Review Comment: https://git.openjdk.org/jdk/pull/18317#discussion_r1525602281
PR Review Comment: https://git.openjdk.org/jdk/pull/18317#discussion_r1525602402

From achung at openjdk.org  Fri Mar 15 00:15:50 2024
From: achung at openjdk.org (Alisen Chung)
Date: Fri, 15 Mar 2024 00:15:50 GMT
Subject: RFR: 8328228: Missing comma in copyright year for a few
 JColorChooser tests [v2]
In-Reply-To: <VJw2CeCxX1eJEhaCg1liDRHS3G3yDzuqtG9SW6FCb1M=.55059924-1e47-4ad4-bbf0-80f2bfcbab03@github.com>
References: <VJw2CeCxX1eJEhaCg1liDRHS3G3yDzuqtG9SW6FCb1M=.55059924-1e47-4ad4-bbf0-80f2bfcbab03@github.com>
Message-ID: <mPgBlHPkvyLX_jSmzYAxVDdi8Ff1UUHzVxCvwkg1gy0=.ea9832d6-1adf-43c3-a371-b88bafabc663@github.com>

> Adding comma to copyright years

Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:

  remove middle copyright year

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18317/files
  - new: https://git.openjdk.org/jdk/pull/18317/files/e6143840..cb3cce1f

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18317&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18317&range=00-01

  Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/18317.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18317/head:pull/18317

PR: https://git.openjdk.org/jdk/pull/18317

From jpai at openjdk.org  Fri Mar 15 00:30:40 2024
From: jpai at openjdk.org (Jaikiran Pai)
Date: Fri, 15 Mar 2024 00:30:40 GMT
Subject: RFR: 8328228: Missing comma in copyright year for a few
 JColorChooser tests [v2]
In-Reply-To: <mPgBlHPkvyLX_jSmzYAxVDdi8Ff1UUHzVxCvwkg1gy0=.ea9832d6-1adf-43c3-a371-b88bafabc663@github.com>
References: <VJw2CeCxX1eJEhaCg1liDRHS3G3yDzuqtG9SW6FCb1M=.55059924-1e47-4ad4-bbf0-80f2bfcbab03@github.com>
 <mPgBlHPkvyLX_jSmzYAxVDdi8Ff1UUHzVxCvwkg1gy0=.ea9832d6-1adf-43c3-a371-b88bafabc663@github.com>
Message-ID: <XRE0UiMzElcxb0BNqGP3bzq1UyJ_MRryEBtc4nJH_7c=.5a346cab-1190-4524-91fb-5fb0e8be8a67@github.com>

On Fri, 15 Mar 2024 00:15:50 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> Adding comma to copyright years
>
> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   remove middle copyright year

Trivial copyright year update. This looks good to me.

-------------

Marked as reviewed by jpai (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18317#pullrequestreview-1937926802

From honkar at openjdk.org  Fri Mar 15 00:35:45 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Fri, 15 Mar 2024 00:35:45 GMT
Subject: RFR: 8328089: Automate javax/swing/JTable/4222153/bug4222153.java
 applet test [v4]
In-Reply-To: <1okH-q00rjuD4KfgG4FDMLFGS81efUOzvROW_QdRFrU=.ffe5e1df-bec6-4220-9b79-c9dd461d81b1@github.com>
References: <mVE4zdUddu3XPR7DxR9mbyzZwAMXUy0ylxrFmtuHAZU=.df6d1ce0-3afe-4370-b23a-0f4042efc9c9@github.com>
 <1okH-q00rjuD4KfgG4FDMLFGS81efUOzvROW_QdRFrU=.ffe5e1df-bec6-4220-9b79-c9dd461d81b1@github.com>
Message-ID: <QxE8mvmT17P7y8yFjq0j2G1SKyLJMDASrqEyTm79yZM=.1f45def6-855a-484d-a0fe-677cd220d2e1@github.com>

On Thu, 14 Mar 2024 05:51:55 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Conversion of manual applet test to automated test. CI testing is green. Link attached to JBS.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   UI init in separate method

Updated changes look good.

-------------

Marked as reviewed by honkar (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18275#pullrequestreview-1937929765

From achung at openjdk.org  Fri Mar 15 00:37:43 2024
From: achung at openjdk.org (Alisen Chung)
Date: Fri, 15 Mar 2024 00:37:43 GMT
Subject: Integrated: 8328228: Missing comma in copyright year for a few
 JColorChooser tests
In-Reply-To: <VJw2CeCxX1eJEhaCg1liDRHS3G3yDzuqtG9SW6FCb1M=.55059924-1e47-4ad4-bbf0-80f2bfcbab03@github.com>
References: <VJw2CeCxX1eJEhaCg1liDRHS3G3yDzuqtG9SW6FCb1M=.55059924-1e47-4ad4-bbf0-80f2bfcbab03@github.com>
Message-ID: <fdkUpYKTK76zKgUcuHyATaHVfqHeyDHBpQMHKeBitHk=.ee383d1c-41fd-403e-ae62-7295ad31b1c7@github.com>

On Thu, 14 Mar 2024 23:36:13 GMT, Alisen Chung <achung at openjdk.org> wrote:

> Adding comma to copyright years

This pull request has now been integrated.

Changeset: e8d1ba33
Author:    Alisen Chung <achung at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/e8d1ba33b48dc8e6b937258c3765b91426c5b6f1
Stats:     4 lines in 4 files changed: 0 ins; 0 del; 4 mod

8328228: Missing comma in copyright year for a few JColorChooser tests

Reviewed-by: jpai

-------------

PR: https://git.openjdk.org/jdk/pull/18317

From honkar at openjdk.org  Fri Mar 15 00:48:38 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Fri, 15 Mar 2024 00:48:38 GMT
Subject: RFR: 8328227: Remove applet usage from JColorChooser tests
 Test4887836
In-Reply-To: <sz94hhkj7mCeInxQ075Uwe14NVjdUMDk3sbuOr1E2X0=.2cc0c644-dd7a-4044-aa17-c082abaf74b6@github.com>
References: <sz94hhkj7mCeInxQ075Uwe14NVjdUMDk3sbuOr1E2X0=.2cc0c644-dd7a-4044-aa17-c082abaf74b6@github.com>
Message-ID: <aBk176U0tL-uoUduGF37m99NMTL6OO3xkkZnLfexZyI=.3f73a14b-b5e9-4684-a76d-1a2ccb3897fe@github.com>

On Thu, 14 Mar 2024 23:02:58 GMT, Alisen Chung <achung at openjdk.org> wrote:

> Removing applet usage from manual JColorChooser tests

Changes requested by honkar (Reviewer).

test/jdk/javax/swing/JColorChooser/Test4887836.java line 2:

> 1: /*
> 2:  * Copyright (c) 2003, 2008, 2024 Oracle and/or its affiliates. All rights reserved.

Same here. Please remove 2008 and add comma.

test/jdk/javax/swing/JColorChooser/Test4887836.java line 34:

> 32:  * @library /java/awt/regtesthelpers
> 33:  * @build PassFailJFrame
> 34:  * @summary Checks if no tooltip modification when no KeyStroke modifier

@alisenchung summary doesn't match with the test.

test/jdk/javax/swing/JColorChooser/Test4887836.java line 41:

> 39:     public static void main(String[] args) throws Exception {
> 40:         String instructions = "If you do not see white area under the \"Swatches\" tab,\n" +
> 41:                 "then test passed, otherwise it failed.";

The original instructions seem a bit vague and the test window has a lot going on so probably more details here would add clarity.

test/jdk/javax/swing/JColorChooser/Test4887836.java line 49:

> 47:                 .columns(40)
> 48:                 .testTimeOut(10)
> 49:                 .splitUIRight(Test4887836::createColorChooser)

Here having separate windows for instructions and test window look better.
Suggestion:

                .testUI(Test4887836::createColorChooser)

-------------

PR Review: https://git.openjdk.org/jdk/pull/18316#pullrequestreview-1937931742
PR Review Comment: https://git.openjdk.org/jdk/pull/18316#discussion_r1525629485
PR Review Comment: https://git.openjdk.org/jdk/pull/18316#discussion_r1525633461
PR Review Comment: https://git.openjdk.org/jdk/pull/18316#discussion_r1525632027
PR Review Comment: https://git.openjdk.org/jdk/pull/18316#discussion_r1525632789

From honkar at openjdk.org  Fri Mar 15 00:59:42 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Fri, 15 Mar 2024 00:59:42 GMT
Subject: RFR: 8203867: Delete test
 java/awt/TrayIcon/DblClickActionEventTest/DblClickActionEventTest.html
In-Reply-To: <XsHRbu46y31j1NdHaDYd6R-N0AUPWFtop4Z68OdjKwM=.54968e7f-1d43-4dfa-a672-00eda52e7264@github.com>
References: <XsHRbu46y31j1NdHaDYd6R-N0AUPWFtop4Z68OdjKwM=.54968e7f-1d43-4dfa-a672-00eda52e7264@github.com>
Message-ID: <n8VHFP7JNbB3BGvZ6FCOqTNJcQgVqmyln8zERhvJlG0=.683d5dde-64c0-43ee-8d75-5144ba85c267@github.com>

On Thu, 14 Mar 2024 19:36:53 GMT, Phil Race <prr at openjdk.org> wrote:

> This test draws the same tray icon, has similar instructions to, and is subsumed by the related test   DisposeInActionEventTest.java
> And because this test has incomplete instructions not covering macOS it is problem-listed.
> The other test explicitly covers macOS. 
> So the right answer is to remove this manual applet test which adds no valuable coverage and just costs time + effort to run.

The reason to delete the test sounds reasonable.
Moreover the instructions in the test are indeed confusing and not clear.

-------------

Marked as reviewed by honkar (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18311#pullrequestreview-1937948809

From honkar at openjdk.org  Fri Mar 15 01:20:42 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Fri, 15 Mar 2024 01:20:42 GMT
Subject: RFR: 8328158: Convert java/awt/Choice/NonFocusablePopupMenuTest to
 automatic main test [v4]
In-Reply-To: <_cLhzMaHV2B6w0DWMogu5Abv8Zk4xS_ve9HYWSdTGWc=.32d0ed31-80f1-4fac-b05f-eef88709c2d1@github.com>
References: <5o5Qhfltwmw1WbGujddcfKdNxIQahHyXXFHhaYfrLsM=.6437d7e5-ad8c-43be-b04c-3f45c0c9c54a@github.com>
 <_cLhzMaHV2B6w0DWMogu5Abv8Zk4xS_ve9HYWSdTGWc=.32d0ed31-80f1-4fac-b05f-eef88709c2d1@github.com>
Message-ID: <GsIcV2EE-fHjP5aIzFKFYAY4WAS6dQpjH6g_u20uBrs=.22e7edea-a89b-4279-b575-6db2131b917d@github.com>

On Thu, 14 Mar 2024 16:48:57 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

>> Convert test to the automatic main and move it from its own folder since it is no longer required.
>
> Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Minor updates

LGTM

-------------

Marked as reviewed by honkar (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18300#pullrequestreview-1937963578

From psadhukhan at openjdk.org  Fri Mar 15 03:14:50 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Fri, 15 Mar 2024 03:14:50 GMT
Subject: RFR: 8327756: Convert javax/swing/JSlider/4987336/bug4987336.java
 applet to main [v2]
In-Reply-To: <zFe1pB_IJT8gqZC2WVKRnHq_9W2DBWU_UAmM3_QdXpM=.b5493e4d-1d4d-451a-a373-753d8c682fa8@github.com>
References: <zFe1pB_IJT8gqZC2WVKRnHq_9W2DBWU_UAmM3_QdXpM=.b5493e4d-1d4d-451a-a373-753d8c682fa8@github.com>
Message-ID: <Xkhqg-GG457IIzbNpm2z0inj2f4K16r4jJZuAvd7rwg=.4f4dcb30-587b-45a4-981c-745b71cb4822@github.com>

> Conversion of manual applet test to main based using PassFailJFrame manual framework

Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:

  Minor update

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18261/files
  - new: https://git.openjdk.org/jdk/pull/18261/files/11d47c03..ca2d42c4

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18261&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18261&range=00-01

  Stats: 3 lines in 1 file changed: 1 ins; 1 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/18261.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18261/head:pull/18261

PR: https://git.openjdk.org/jdk/pull/18261

From psadhukhan at openjdk.org  Fri Mar 15 03:17:07 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Fri, 15 Mar 2024 03:17:07 GMT
Subject: RFR: 8327757: Convert javax/swing/JSlider/6524424/bug6524424.java
 applet to main [v2]
In-Reply-To: <bq4piqGxP9zZiBlAc8_w-hnLs84WeA78AngOyTg7lwI=.b2572769-5729-4612-81b9-aac8f1a30398@github.com>
References: <bq4piqGxP9zZiBlAc8_w-hnLs84WeA78AngOyTg7lwI=.b2572769-5729-4612-81b9-aac8f1a30398@github.com>
Message-ID: <lVaGWU7mLft2CXiRyK73OM-szVSXoLrJJ_YrTuBYXEk=.af7e88b2-5954-4839-948a-29bb4578902e@github.com>

> Conversion of manual applet test to main based using PassFailJFrame manual framework

Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:

  Ninor update

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18263/files
  - new: https://git.openjdk.org/jdk/pull/18263/files/5ad7971a..8ac57f0c

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18263&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18263&range=00-01

  Stats: 3 lines in 1 file changed: 0 ins; 1 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/18263.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18263/head:pull/18263

PR: https://git.openjdk.org/jdk/pull/18263

From prr at openjdk.org  Fri Mar 15 03:22:38 2024
From: prr at openjdk.org (Phil Race)
Date: Fri, 15 Mar 2024 03:22:38 GMT
Subject: RFR: 8327756: Convert javax/swing/JSlider/4987336/bug4987336.java
 applet to main [v2]
In-Reply-To: <Xkhqg-GG457IIzbNpm2z0inj2f4K16r4jJZuAvd7rwg=.4f4dcb30-587b-45a4-981c-745b71cb4822@github.com>
References: <zFe1pB_IJT8gqZC2WVKRnHq_9W2DBWU_UAmM3_QdXpM=.b5493e4d-1d4d-451a-a373-753d8c682fa8@github.com>
 <Xkhqg-GG457IIzbNpm2z0inj2f4K16r4jJZuAvd7rwg=.4f4dcb30-587b-45a4-981c-745b71cb4822@github.com>
Message-ID: <S53ximuAKAfrIJKAXZHsNUZ9KrBL7S_l-EzSD4uqkr4=.d0495d5c-0bc8-4cea-90b6-8776c9d5c503@github.com>

On Fri, 15 Mar 2024 03:14:50 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Conversion of manual applet test to main based using PassFailJFrame manual framework
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Minor update

Marked as reviewed by prr (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18261#pullrequestreview-1938047289

From tr at openjdk.org  Fri Mar 15 03:47:41 2024
From: tr at openjdk.org (Tejesh R)
Date: Fri, 15 Mar 2024 03:47:41 GMT
Subject: RFR: JDK-8320675 : PrinterJob/SecurityDialogTest.java hangs
In-Reply-To: <OMBWLwH7044RMtwdrZSiahQDdy-1T-4oJjOQgnQEKjI=.18a31ad0-710f-44e5-86ec-b4566946b063@github.com>
References: <OMBWLwH7044RMtwdrZSiahQDdy-1T-4oJjOQgnQEKjI=.18a31ad0-710f-44e5-86ec-b4566946b063@github.com>
Message-ID: <5aXzOToA5dTIrM_tO6JCDfVnpABlsInYnNw5XPbnndA=.d6aea1ef-a09d-48bf-a092-948097e93b21@github.com>

On Thu, 14 Mar 2024 11:52:09 GMT, Renjith Kannath Pariyangad <rkannathpari at openjdk.org> wrote:

> Hi Reviewers,
> 
> I have updated the test with  PassFailJFrame with information panel, earlier this was informed through terminal.
> Please review and let me know your suggestions if any.

test/jdk/java/awt/print/PrinterJob/SecurityDialogTest.java line 43:

> 41:  * @key printer
> 42:  * @library /java/awt/regtesthelpers
> 43:  * @build PassFailJFrame

Any reason why test summary is not there?

test/jdk/java/awt/print/PrinterJob/SecurityDialogTest.java line 45:

> 43:  * @build PassFailJFrame
> 44:  * @run main/manual/othervm -Djava.security.manager=allow SecurityDialogTest
> 45:  */

Line spacing here would be nice.

test/jdk/java/awt/print/PrinterJob/SecurityDialogTest.java line 47:

> 45:  */
> 46: public class SecurityDialogTest extends Frame {
> 47:     private static final String INSTRUCTIONS =

`INSTRUCTIONS` can be moved inside main.

test/jdk/java/awt/print/PrinterJob/SecurityDialogTest.java line 67:

> 65:         }
> 66: 
> 67:         PassFailJFrame passFailJFrame = new PassFailJFrame.Builder()

I am getting an error for using new `PassFailJFrame passFailJFrame = new PassFailJFrame.Builder()`, stating _"'Builder()' has private access in 'PassFailJFrame.Builder'"_ Probably because I have fetched latest PassFailJFrame.
And also you can use `PassFailJFrame.builder()` method.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18299#discussion_r1525717301
PR Review Comment: https://git.openjdk.org/jdk/pull/18299#discussion_r1525717515
PR Review Comment: https://git.openjdk.org/jdk/pull/18299#discussion_r1525716495
PR Review Comment: https://git.openjdk.org/jdk/pull/18299#discussion_r1525721443

From dholmes at openjdk.org  Fri Mar 15 03:50:43 2024
From: dholmes at openjdk.org (David Holmes)
Date: Fri, 15 Mar 2024 03:50:43 GMT
Subject: RFR: 8328228: Missing comma in copyright year for a few
 JColorChooser tests [v2]
In-Reply-To: <mPgBlHPkvyLX_jSmzYAxVDdi8Ff1UUHzVxCvwkg1gy0=.ea9832d6-1adf-43c3-a371-b88bafabc663@github.com>
References: <VJw2CeCxX1eJEhaCg1liDRHS3G3yDzuqtG9SW6FCb1M=.55059924-1e47-4ad4-bbf0-80f2bfcbab03@github.com>
 <mPgBlHPkvyLX_jSmzYAxVDdi8Ff1UUHzVxCvwkg1gy0=.ea9832d6-1adf-43c3-a371-b88bafabc663@github.com>
Message-ID: <-zafRqFYzMNHgW8wFFv-N8M4HpsgWKx8h6q9mGgzHGU=.abcd73df-efda-408f-a316-b15e0882a14a@github.com>

On Fri, 15 Mar 2024 00:15:50 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> Adding comma to copyright years
>
> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   remove middle copyright year

@alisenchung  sorry I became unavailable to follow this through. Thanks for fixing.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18317#issuecomment-1998887761

From abhiscxk at openjdk.org  Fri Mar 15 04:17:44 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Fri, 15 Mar 2024 04:17:44 GMT
Subject: Integrated: 8328089: Automate
 javax/swing/JTable/4222153/bug4222153.java applet test
In-Reply-To: <mVE4zdUddu3XPR7DxR9mbyzZwAMXUy0ylxrFmtuHAZU=.df6d1ce0-3afe-4370-b23a-0f4042efc9c9@github.com>
References: <mVE4zdUddu3XPR7DxR9mbyzZwAMXUy0ylxrFmtuHAZU=.df6d1ce0-3afe-4370-b23a-0f4042efc9c9@github.com>
Message-ID: <iz1vafFO3yExCxX4G0wLOkK7iyNPZ-BbbD3xgLmpBKc=.744a381c-0512-415a-93c6-fcec1ff6340f@github.com>

On Wed, 13 Mar 2024 13:39:08 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

> Conversion of manual applet test to automated test. CI testing is green. Link attached to JBS.

This pull request has now been integrated.

Changeset: f6390e5f
Author:    Abhishek Kumar <abhiscxk at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/f6390e5f801a3e25bda591e30e49db86519bf028
Stats:     196 lines in 3 files changed: 117 ins; 79 del; 0 mod

8328089: Automate javax/swing/JTable/4222153/bug4222153.java applet test

Reviewed-by: honkar, tr

-------------

PR: https://git.openjdk.org/jdk/pull/18275

From psadhukhan at openjdk.org  Fri Mar 15 04:26:38 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Fri, 15 Mar 2024 04:26:38 GMT
Subject: RFR: 8328218: Delete test java/awt/Window/FindOwner/FindOwner.html
In-Reply-To: <rPYMpiZKqRGM9UMbqQmyW2gQXGogpJC0klAbrW1PeAU=.744fd84d-f5a7-4082-8ff0-48e7c8b39a2c@github.com>
References: <rPYMpiZKqRGM9UMbqQmyW2gQXGogpJC0klAbrW1PeAU=.744fd84d-f5a7-4082-8ff0-48e7c8b39a2c@github.com>
Message-ID: <t2EwIdUUx4bnsGLQrGKE7ilaYsHSrLUDZ1wEAB6mmII=.f932d7e7-4112-49ba-9131-06153988b1df@github.com>

On Thu, 14 Mar 2024 21:27:47 GMT, Phil Race <prr at openjdk.org> wrote:

> After some experimentation/thought I think it best to delete this applet test.
> 
> It is supposed to be a manual test but is missing the manual keyword so
> as far as I can tell it has never been usefully run. Except perhaps a few times
> when first being verified.
> When I run it in jtreg a window popups up, disappears and the test is passed
> Contradicting instructions in the test that tell you it has to be manual because
> you need to run it *in the browser* not jtreg.
> 
> Well, we don't support browser applets any more.
> And the scenario it was testing was explicitly a case that happened with the browser.
> 
> And to cap it all, I see no way for you to tell jtreg that it passed or failed - because
> you run it in the browser.
> 
> So it is manual in the sense that it is NOT a jtreg test and so it should not even have
> an @test tag.
> 
> These are more than enough reasons to just delete it.

It was originally meant for browser applet which as you told is not supported and therefore test can be removed but I see it is also used to test a Unity fix for [8159460](https://bugs.openjdk.org/browse/JDK-8159460) that does not seem to be about applet, rather undecorated child window not getting focus...
Yet the test instructions is being done in SecurityException catch-block which itself looks odd...Guess it's fair enough to delete..

-------------

Marked as reviewed by psadhukhan (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18314#pullrequestreview-1938093291

From prr at openjdk.org  Fri Mar 15 04:39:41 2024
From: prr at openjdk.org (Phil Race)
Date: Fri, 15 Mar 2024 04:39:41 GMT
Subject: RFR: 8328218: Delete test java/awt/Window/FindOwner/FindOwner.html
In-Reply-To: <t2EwIdUUx4bnsGLQrGKE7ilaYsHSrLUDZ1wEAB6mmII=.f932d7e7-4112-49ba-9131-06153988b1df@github.com>
References: <rPYMpiZKqRGM9UMbqQmyW2gQXGogpJC0klAbrW1PeAU=.744fd84d-f5a7-4082-8ff0-48e7c8b39a2c@github.com>
 <t2EwIdUUx4bnsGLQrGKE7ilaYsHSrLUDZ1wEAB6mmII=.f932d7e7-4112-49ba-9131-06153988b1df@github.com>
Message-ID: <XsCqT9rNG76OVldB-G93CrqnCF0LMGUtH7EM5OsZ_rM=.c6ac290c-ba66-4912-aec9-0e52125dd4d8@github.com>

On Fri, 15 Mar 2024 04:23:39 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> It was originally meant for browser applet which as you told is not supported and therefore test can be removed but I see it is also used to test a Unity fix for [8159460](https://bugs.openjdk.org/browse/JDK-8159460) that does not seem to be about applet, rather undecorated child window not getting focus... Yet the test instructions is being done in SecurityException catch-block which itself looks odd...Guess it's fair enough to delete..

Yes, I saw & followed that because of the bug id. Made me pause but not change my mind.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18314#issuecomment-1998922158

From prr at openjdk.org  Fri Mar 15 04:39:41 2024
From: prr at openjdk.org (Phil Race)
Date: Fri, 15 Mar 2024 04:39:41 GMT
Subject: Integrated: 8328218: Delete test
 java/awt/Window/FindOwner/FindOwner.html
In-Reply-To: <rPYMpiZKqRGM9UMbqQmyW2gQXGogpJC0klAbrW1PeAU=.744fd84d-f5a7-4082-8ff0-48e7c8b39a2c@github.com>
References: <rPYMpiZKqRGM9UMbqQmyW2gQXGogpJC0klAbrW1PeAU=.744fd84d-f5a7-4082-8ff0-48e7c8b39a2c@github.com>
Message-ID: <OlFVEPYlEU9LlzZjH2_9hktXh9Mu6t5NwXCCHZ8a8oA=.50646ea3-02c9-4084-8ba6-c90d20c3307b@github.com>

On Thu, 14 Mar 2024 21:27:47 GMT, Phil Race <prr at openjdk.org> wrote:

> After some experimentation/thought I think it best to delete this applet test.
> 
> It is supposed to be a manual test but is missing the manual keyword so
> as far as I can tell it has never been usefully run. Except perhaps a few times
> when first being verified.
> When I run it in jtreg a window popups up, disappears and the test is passed
> Contradicting instructions in the test that tell you it has to be manual because
> you need to run it *in the browser* not jtreg.
> 
> Well, we don't support browser applets any more.
> And the scenario it was testing was explicitly a case that happened with the browser.
> 
> And to cap it all, I see no way for you to tell jtreg that it passed or failed - because
> you run it in the browser.
> 
> So it is manual in the sense that it is NOT a jtreg test and so it should not even have
> an @test tag.
> 
> These are more than enough reasons to just delete it.

This pull request has now been integrated.

Changeset: 09439374
Author:    Phil Race <prr at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/09439374edec8178fc2a0494bb96a8a24384c2a3
Stats:     154 lines in 2 files changed: 0 ins; 154 del; 0 mod

8328218: Delete test java/awt/Window/FindOwner/FindOwner.html

Reviewed-by: psadhukhan

-------------

PR: https://git.openjdk.org/jdk/pull/18314

From azvegint at openjdk.org  Fri Mar 15 04:45:56 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Fri, 15 Mar 2024 04:45:56 GMT
Subject: RFR: 8328242: Add a log area to the PassFailJFrame
Message-ID: <c2nhXjjZerGqDlD3X3gInMwiJ3ng1vsR0AKnmabksPE=.649bf743-3372-4218-939a-84caea3fae71@github.com>

Often manual tests have a text area in the instruction window to print feedback from the test to be evaluated by a tester.
I stumbled across another test that needed this, so I decided to make these changes a standard feature.

List of changes:
* The log text area can be added below the `Pass` and `Fail` buttons panel.
To do this, use the builder methods `logArea()`, `logArea(int rows)`.
* `PassFailJFrame.log(message)`, `PassFailJFrame.logClear()` and `PassFailJFrame.logSet()` are added to control this text area. (maybe I missed something?)
* added `invokeOnEDTUncheckedException' for easier use of logging methods

So typical usage would be like:

        PassFailJFrame
                .builder()
                .title("GetBoundsResizeTest Instructions")
                .instructions(INSTRUCTIONS)
                .rows(20)
                .columns(70)
                .logArea()
                .build()
                .awaitAndCheck();


----

//somewhere in event handlers:
PassFailJFrame.log("Very important message");

-------------

Commit messages:
 - 8328242: Add a log area to the PassFailJFrame

Changes: https://git.openjdk.org/jdk/pull/18319/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18319&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8328242
  Stats: 111 lines in 1 file changed: 106 ins; 0 del; 5 mod
  Patch: https://git.openjdk.org/jdk/pull/18319.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18319/head:pull/18319

PR: https://git.openjdk.org/jdk/pull/18319

From azvegint at openjdk.org  Fri Mar 15 04:45:56 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Fri, 15 Mar 2024 04:45:56 GMT
Subject: RFR: 8328242: Add a log area to the PassFailJFrame
In-Reply-To: <c2nhXjjZerGqDlD3X3gInMwiJ3ng1vsR0AKnmabksPE=.649bf743-3372-4218-939a-84caea3fae71@github.com>
References: <c2nhXjjZerGqDlD3X3gInMwiJ3ng1vsR0AKnmabksPE=.649bf743-3372-4218-939a-84caea3fae71@github.com>
Message-ID: <yQMhH8WxoKK8CcYYTSOcJcLGwm-TsTmg6wezpbeyznI=.910e9350-d0f2-4b3d-a9a8-275bee8daad1@github.com>

On Fri, 15 Mar 2024 04:40:14 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

> Often manual tests have a text area in the instruction window to print feedback from the test to be evaluated by a tester.
> I stumbled across another test that needed this, so I decided to make these changes a standard feature.
> 
> List of changes:
> * The log text area can be added below the `Pass` and `Fail` buttons panel.
> To do this, use the builder methods `logArea()`, `logArea(int rows)`.
> * `PassFailJFrame.log(message)`, `PassFailJFrame.logClear()` and `PassFailJFrame.logSet()` are added to control this text area. (maybe I missed something?)
> * added `invokeOnEDTUncheckedException' for easier use of logging methods
> 
> So typical usage would be like:
> 
>         PassFailJFrame
>                 .builder()
>                 .title("GetBoundsResizeTest Instructions")
>                 .instructions(INSTRUCTIONS)
>                 .rows(20)
>                 .columns(70)
>                 .logArea()
>                 .build()
>                 .awaitAndCheck();
> 
> 
> ----
> 
> //somewhere in event handlers:
> PassFailJFrame.log("Very important message");

test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 406:

> 404:                                            rows, columns,
> 405:                                            enableScreenCapture,
> 406:                                            false, 0),

It is intentionally added only to the builder to avoid excessive changes to all constructors.

It seems that the builder produces much cleaner code, so we probably shouldn't spend our time to changing a bunch of `PassFailJFrame` constructors, and at some point we can make the builder the only option available.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18319#discussion_r1525751536

From azvegint at openjdk.org  Fri Mar 15 04:57:46 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Fri, 15 Mar 2024 04:57:46 GMT
Subject: RFR: 8203867: Delete test
 java/awt/TrayIcon/DblClickActionEventTest/DblClickActionEventTest.html
In-Reply-To: <XsHRbu46y31j1NdHaDYd6R-N0AUPWFtop4Z68OdjKwM=.54968e7f-1d43-4dfa-a672-00eda52e7264@github.com>
References: <XsHRbu46y31j1NdHaDYd6R-N0AUPWFtop4Z68OdjKwM=.54968e7f-1d43-4dfa-a672-00eda52e7264@github.com>
Message-ID: <vI2twcf_Tz6W0LvsrD6CoV-b_hlVVDYfuAgM86V7dBU=.a4cf68e0-973a-437d-a8a1-183a3fb2a58f@github.com>

On Thu, 14 Mar 2024 19:36:53 GMT, Phil Race <prr at openjdk.org> wrote:

> This test draws the same tray icon, has similar instructions to, and is subsumed by the related test   DisposeInActionEventTest.java
> And because this test has incomplete instructions not covering macOS it is problem-listed.
> The other test explicitly covers macOS. 
> So the right answer is to remove this manual applet test which adds no valuable coverage and just costs time + effort to run.

Marked as reviewed by azvegint (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18311#pullrequestreview-1938116937

From prr at openjdk.org  Fri Mar 15 05:28:41 2024
From: prr at openjdk.org (Phil Race)
Date: Fri, 15 Mar 2024 05:28:41 GMT
Subject: RFR: 8328242: Add a log area to the PassFailJFrame
In-Reply-To: <c2nhXjjZerGqDlD3X3gInMwiJ3ng1vsR0AKnmabksPE=.649bf743-3372-4218-939a-84caea3fae71@github.com>
References: <c2nhXjjZerGqDlD3X3gInMwiJ3ng1vsR0AKnmabksPE=.649bf743-3372-4218-939a-84caea3fae71@github.com>
Message-ID: <Uvetkc5MtbvdRV8i9lzneKCao5xNlTsu9OmFMkJu1dc=.40ef9118-1f91-4c47-83f3-415f6145dc36@github.com>

On Fri, 15 Mar 2024 04:40:14 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

> Often manual tests have a text area in the instruction window to print feedback from the test to be evaluated by a tester.
> I stumbled across another test that needed this, so I decided to make these changes a standard feature.
> 
> List of changes:
> * The log text area can be added below the `Pass` and `Fail` buttons panel.
> To do this, use the builder methods `logArea()`, `logArea(int rows)`.
> * `PassFailJFrame.log(message)`, `PassFailJFrame.logClear()` and `PassFailJFrame.logSet()` are added to control this text area. (maybe I missed something?)
> * added `invokeOnEDTUncheckedException` for easier use of logging methods
> 
> So typical usage would be like:
> 
>         PassFailJFrame
>                 .builder()
>                 .title("GetBoundsResizeTest Instructions")
>                 .instructions(INSTRUCTIONS)
>                 .rows(20)
>                 .columns(70)
>                 .logArea()
>                 .build()
>                 .awaitAndCheck();
> 
> 
> ----
> 
> //somewhere in event handlers:
> PassFailJFrame.log("Very important message");

Marked as reviewed by prr (Reviewer).

The way you did it is as I imagined. As a result of the extra builder call,
there is an implicit log target created with a known way to use with which you can write to when you want.
And the size is the same width as the instructions with and you just specify
as many lines (rows) to be visible that makes sense, so long as it is scrollable.

-------------

PR Review: https://git.openjdk.org/jdk/pull/18319#pullrequestreview-1938142923
PR Comment: https://git.openjdk.org/jdk/pull/18319#issuecomment-1998960777

From azvegint at openjdk.org  Fri Mar 15 05:28:46 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Fri, 15 Mar 2024 05:28:46 GMT
Subject: RFR: 8328185: Convert
 java/awt/image/MemoryLeakTest/MemoryLeakTest.java applet test to main
In-Reply-To: <TFYjDmsHDFBm5tcakvQmk_o_3bkZxQmS8FLPZW5bI8Y=.c7bebd2f-13cb-4bae-bd85-64cbff6c17b8@github.com>
References: <TFYjDmsHDFBm5tcakvQmk_o_3bkZxQmS8FLPZW5bI8Y=.c7bebd2f-13cb-4bae-bd85-64cbff6c17b8@github.com>
Message-ID: <F6adbGUfdGwkbg6GwOxMhhSih2ImOflTuJNT2BOAGSs=.525d8696-72fb-43dd-9a34-cb906e730106@github.com>

On Thu, 14 Mar 2024 16:40:56 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

> Convert java/awt/image/MemoryLeakTest/MemoryLeakTest.java applet test to main using PassFailJFrame

test/jdk/java/awt/image/MemoryLeakTest/MemoryLeakTest.java line 67:

> 65:             .rows(15)
> 66:             .columns(40)
> 67:             .testUI(new MemoryLeak())

It currently creates the MemoryLeak(aka Frame) on the main thread, instead of EDT.

Suggestion:

            .testUI(MemoryLeak::new)

test/jdk/java/awt/image/MemoryLeakTest/MemoryLeakTest.java line 73:

> 71:         if (Globals.mainThread != null) {
> 72:             Globals.mainThread.interrupt();
> 73:         }

Not sure why do we need this.

test/jdk/java/awt/image/MemoryLeakTest/MemoryLeakTest.java line 77:

> 75:             Thread.sleep(300000);
> 76:         } catch (InterruptedException e) {
> 77:             if (!Globals.testPassed) {

It looks like `Globals.testPassed` is never changed, so the test will always fail.
Shouldn't this be controlled by the PassFailJFrame Pass/Fail buttons?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18307#discussion_r1525764471
PR Review Comment: https://git.openjdk.org/jdk/pull/18307#discussion_r1525768022
PR Review Comment: https://git.openjdk.org/jdk/pull/18307#discussion_r1525768354

From prr at openjdk.org  Fri Mar 15 05:36:47 2024
From: prr at openjdk.org (Phil Race)
Date: Fri, 15 Mar 2024 05:36:47 GMT
Subject: Integrated: 8203867: Delete test
 java/awt/TrayIcon/DblClickActionEventTest/DblClickActionEventTest.html
In-Reply-To: <XsHRbu46y31j1NdHaDYd6R-N0AUPWFtop4Z68OdjKwM=.54968e7f-1d43-4dfa-a672-00eda52e7264@github.com>
References: <XsHRbu46y31j1NdHaDYd6R-N0AUPWFtop4Z68OdjKwM=.54968e7f-1d43-4dfa-a672-00eda52e7264@github.com>
Message-ID: <saNoGuw9YfdGZCK-XpNNX-JiV3dIevb5Ka873eZN_Hk=.b83ca5ba-b960-401b-bd7d-5c9183399302@github.com>

On Thu, 14 Mar 2024 19:36:53 GMT, Phil Race <prr at openjdk.org> wrote:

> This test draws the same tray icon, has similar instructions to, and is subsumed by the related test   DisposeInActionEventTest.java
> And because this test has incomplete instructions not covering macOS it is problem-listed.
> The other test explicitly covers macOS. 
> So the right answer is to remove this manual applet test which adds no valuable coverage and just costs time + effort to run.

This pull request has now been integrated.

Changeset: 605800e5
Author:    Phil Race <prr at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/605800e5abd244c57a421f3a511a79c531583471
Stats:     165 lines in 3 files changed: 0 ins; 165 del; 0 mod

8203867: Delete test java/awt/TrayIcon/DblClickActionEventTest/DblClickActionEventTest.html

Reviewed-by: honkar, azvegint

-------------

PR: https://git.openjdk.org/jdk/pull/18311

From psadhukhan at openjdk.org  Fri Mar 15 05:46:42 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Fri, 15 Mar 2024 05:46:42 GMT
Subject: Integrated: 8327756: Convert
 javax/swing/JSlider/4987336/bug4987336.java applet to main
In-Reply-To: <zFe1pB_IJT8gqZC2WVKRnHq_9W2DBWU_UAmM3_QdXpM=.b5493e4d-1d4d-451a-a373-753d8c682fa8@github.com>
References: <zFe1pB_IJT8gqZC2WVKRnHq_9W2DBWU_UAmM3_QdXpM=.b5493e4d-1d4d-451a-a373-753d8c682fa8@github.com>
Message-ID: <j4H7IKy0cHV-99PGJcbbYkj4Ka9t6XiA2YPQNyu1PuM=.a231729c-90eb-47db-8148-46a63de4e009@github.com>

On Wed, 13 Mar 2024 07:10:32 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> Conversion of manual applet test to main based using PassFailJFrame manual framework

This pull request has now been integrated.

Changeset: 06f4b7f5
Author:    Prasanta Sadhukhan <psadhukhan at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/06f4b7f54da03e57abfe8958e4354c1ecb7e3039
Stats:     84 lines in 2 files changed: 38 ins; 35 del; 11 mod

8327756: Convert javax/swing/JSlider/4987336/bug4987336.java applet to main

Reviewed-by: prr

-------------

PR: https://git.openjdk.org/jdk/pull/18261

From abhiscxk at openjdk.org  Fri Mar 15 05:59:46 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Fri, 15 Mar 2024 05:59:46 GMT
Subject: RFR: 8328244: Convert javax/swing/JSlider/6742358/bug6742358.java.java
 applet test to main
Message-ID: <AN6EAjyACY33ukKyOjp8SuzxRt80B9Z_UO1fy83Nijw=.42fbb5cd-fb5c-413d-a1f2-842657fa7f0e@github.com>

Conversion of manual applet test to main based using PassFailJFrame manual framework

-------------

Commit messages:
 - Applet test converted to main manual

Changes: https://git.openjdk.org/jdk/pull/18321/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18321&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8328244
  Stats: 61 lines in 2 files changed: 13 ins; 39 del; 9 mod
  Patch: https://git.openjdk.org/jdk/pull/18321.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18321/head:pull/18321

PR: https://git.openjdk.org/jdk/pull/18321

From rkannathpari at openjdk.org  Fri Mar 15 06:12:39 2024
From: rkannathpari at openjdk.org (Renjith Kannath Pariyangad)
Date: Fri, 15 Mar 2024 06:12:39 GMT
Subject: RFR: JDK-8320675 : PrinterJob/SecurityDialogTest.java hangs
In-Reply-To: <5aXzOToA5dTIrM_tO6JCDfVnpABlsInYnNw5XPbnndA=.d6aea1ef-a09d-48bf-a092-948097e93b21@github.com>
References: <OMBWLwH7044RMtwdrZSiahQDdy-1T-4oJjOQgnQEKjI=.18a31ad0-710f-44e5-86ec-b4566946b063@github.com>
 <5aXzOToA5dTIrM_tO6JCDfVnpABlsInYnNw5XPbnndA=.d6aea1ef-a09d-48bf-a092-948097e93b21@github.com>
Message-ID: <EBEMv4WjMiaP2puQyFe4ULCiWDhPiHTZj-dASIcZwNo=.72a31043-cae8-4a81-85fe-acd1fb54cf62@github.com>

On Fri, 15 Mar 2024 03:31:32 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Hi Reviewers,
>> 
>> I have updated the test with  PassFailJFrame with information panel, earlier this was informed through terminal.
>> Please review and let me know your suggestions if any.
>
> test/jdk/java/awt/print/PrinterJob/SecurityDialogTest.java line 47:
> 
>> 45:  */
>> 46: public class SecurityDialogTest extends Frame {
>> 47:     private static final String INSTRUCTIONS =
> 
> `INSTRUCTIONS` can be moved inside main.

Most of the test with PassFailJFrame instruction stored as string inside class, what additional benefit will get keeping it inside Main ?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18299#discussion_r1525799780

From abhiscxk at openjdk.org  Fri Mar 15 06:44:12 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Fri, 15 Mar 2024 06:44:12 GMT
Subject: RFR: 8328244: Convert
 javax/swing/JSlider/6742358/bug6742358.java.java applet test to main [v2]
In-Reply-To: <AN6EAjyACY33ukKyOjp8SuzxRt80B9Z_UO1fy83Nijw=.42fbb5cd-fb5c-413d-a1f2-842657fa7f0e@github.com>
References: <AN6EAjyACY33ukKyOjp8SuzxRt80B9Z_UO1fy83Nijw=.42fbb5cd-fb5c-413d-a1f2-842657fa7f0e@github.com>
Message-ID: <_pdd0UCywDJH3dNcGWbRPNlZ6wADT0Vx_qMXLvrHVwo=.454d4d62-2749-4aa0-836d-222020b7b4b9@github.com>

> Conversion of manual applet test to main based using PassFailJFrame manual framework

Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:

  wild card imports and moved one folder up

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18321/files
  - new: https://git.openjdk.org/jdk/pull/18321/files/88675d0d..d891c49e

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18321&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18321&range=00-01

  Stats: 5 lines in 1 file changed: 4 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/18321.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18321/head:pull/18321

PR: https://git.openjdk.org/jdk/pull/18321

From tr at openjdk.org  Fri Mar 15 06:48:38 2024
From: tr at openjdk.org (Tejesh R)
Date: Fri, 15 Mar 2024 06:48:38 GMT
Subject: RFR: JDK-8320675 : PrinterJob/SecurityDialogTest.java hangs
In-Reply-To: <EBEMv4WjMiaP2puQyFe4ULCiWDhPiHTZj-dASIcZwNo=.72a31043-cae8-4a81-85fe-acd1fb54cf62@github.com>
References: <OMBWLwH7044RMtwdrZSiahQDdy-1T-4oJjOQgnQEKjI=.18a31ad0-710f-44e5-86ec-b4566946b063@github.com>
 <5aXzOToA5dTIrM_tO6JCDfVnpABlsInYnNw5XPbnndA=.d6aea1ef-a09d-48bf-a092-948097e93b21@github.com>
 <EBEMv4WjMiaP2puQyFe4ULCiWDhPiHTZj-dASIcZwNo=.72a31043-cae8-4a81-85fe-acd1fb54cf62@github.com>
Message-ID: <WCtIYtNKB1VG1l_4oyqRp-x6HP2teFbww7c2bk6vr5Y=.0ed28334-9f86-4200-ba72-7d1ad7cf233a@github.com>

On Fri, 15 Mar 2024 06:10:05 GMT, Renjith Kannath Pariyangad <rkannathpari at openjdk.org> wrote:

>> test/jdk/java/awt/print/PrinterJob/SecurityDialogTest.java line 47:
>> 
>>> 45:  */
>>> 46: public class SecurityDialogTest extends Frame {
>>> 47:     private static final String INSTRUCTIONS =
>> 
>> `INSTRUCTIONS` can be moved inside main.
>
> Most of the test with PassFailJFrame instruction stored as string inside class, what additional benefit will get keeping it inside Main ?

When it can become local variable then why to keep it in class? Not like significant benefit maybe, but yeah just to keep its scope locally when it can be.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18299#discussion_r1525822683

From abhiscxk at openjdk.org  Fri Mar 15 07:06:40 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Fri, 15 Mar 2024 07:06:40 GMT
Subject: RFR: 8327757: Convert javax/swing/JSlider/6524424/bug6524424.java
 applet to main [v2]
In-Reply-To: <lVaGWU7mLft2CXiRyK73OM-szVSXoLrJJ_YrTuBYXEk=.af7e88b2-5954-4839-948a-29bb4578902e@github.com>
References: <bq4piqGxP9zZiBlAc8_w-hnLs84WeA78AngOyTg7lwI=.b2572769-5729-4612-81b9-aac8f1a30398@github.com>
 <lVaGWU7mLft2CXiRyK73OM-szVSXoLrJJ_YrTuBYXEk=.af7e88b2-5954-4839-948a-29bb4578902e@github.com>
Message-ID: <nLirTpjwIM8QrYIiiOy3sn_pZ0q7pWhCGupeq5Hir0w=.11bfa9fc-f6b9-45fc-b794-828870851c95@github.com>

On Fri, 15 Mar 2024 03:17:07 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Conversion of manual applet test to main based using PassFailJFrame manual framework
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Ninor update

Marked as reviewed by abhiscxk (Committer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18263#pullrequestreview-1938235842

From tr at openjdk.org  Fri Mar 15 07:18:40 2024
From: tr at openjdk.org (Tejesh R)
Date: Fri, 15 Mar 2024 07:18:40 GMT
Subject: RFR: 8328087: Automate javax/swing/JTable/TAB/TAB.java applet test
 [v5]
In-Reply-To: <pGm_A8fwdgfWubc_0dPZKMHUZiAjFcUagULfh0X5OWw=.050b2e38-8e22-43b1-938d-48b899578ef0@github.com>
References: <MumC6TL2XcA5TmVgQXy8yIDFEqUD08b2dvCUyYu7Kd8=.5891ab36-873a-41f0-b22f-d2fc883c8734@github.com>
 <pGm_A8fwdgfWubc_0dPZKMHUZiAjFcUagULfh0X5OWw=.050b2e38-8e22-43b1-938d-48b899578ef0@github.com>
Message-ID: <-OImXzW8qddK4eXpclABH6epfQ0u6GpUZCmA56Djfgk=.d830a67b-536e-4d42-88a3-f4dbfdc9af53@github.com>

On Thu, 14 Mar 2024 18:05:11 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Conversion of manual applet test to automated test. CI testing is green. Link attached to JBS.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Minor update

Looks good to me. Does this work fine in other L&F (Like Aqua), because you have explicitly mentioned as Metal right?

-------------

PR Review: https://git.openjdk.org/jdk/pull/18274#pullrequestreview-1938251076

From clanger at openjdk.org  Fri Mar 15 07:20:40 2024
From: clanger at openjdk.org (Christoph Langer)
Date: Fri, 15 Mar 2024 07:20:40 GMT
Subject: RFR: 8327137: Add test for ConcurrentModificationException in
 BasicDirectoryModel
In-Reply-To: <aRuO2zb4IkM3F28MH5RcfHesc1Z9i7w_uK8kSkIh6i0=.cce14bf8-3384-4e8e-9c12-4e0708dbf3ab@github.com>
References: <mCqqjrXVWDB2PvpOhKHx-Hr8W6tUz6v4stztGmyAeEg=.1f95da1c-e1a5-40be-be8b-0758729fa9b9@github.com>
 <aRuO2zb4IkM3F28MH5RcfHesc1Z9i7w_uK8kSkIh6i0=.cce14bf8-3384-4e8e-9c12-4e0708dbf3ab@github.com>
Message-ID: <iT0AkMDtFdmSgs9hw1n8wICk_ywpXnbklk9I-STL7WM=.d6dc05f1-7cdc-43f2-bc86-dc9e7e3bdc39@github.com>

On Mon, 11 Mar 2024 19:16:21 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> @mrserb, @RealCLanger, could you run this test in your environments, please? It is for Linux and macOS only.
> 
> I'm looking for confirmation that the test fails without the fix for [JDK-8323670](https://bugs.openjdk.org/browse/JDK-8323670). Since JDK-8323670 is fixed in mainline, you can run it in 21u or 17u which don't have the fix yet.
> 
> You'll need to run the test several times because it fails only occasionally. That's why I want to collect more data on whether the test is useful/stable enough.
> 
> I greatly appreciate your help.

I added it to our testing. Results early next week.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18109#issuecomment-1999070246

From rkannathpari at openjdk.org  Fri Mar 15 07:24:40 2024
From: rkannathpari at openjdk.org (Renjith Kannath Pariyangad)
Date: Fri, 15 Mar 2024 07:24:40 GMT
Subject: RFR: JDK-8320675 : PrinterJob/SecurityDialogTest.java hangs
In-Reply-To: <5aXzOToA5dTIrM_tO6JCDfVnpABlsInYnNw5XPbnndA=.d6aea1ef-a09d-48bf-a092-948097e93b21@github.com>
References: <OMBWLwH7044RMtwdrZSiahQDdy-1T-4oJjOQgnQEKjI=.18a31ad0-710f-44e5-86ec-b4566946b063@github.com>
 <5aXzOToA5dTIrM_tO6JCDfVnpABlsInYnNw5XPbnndA=.d6aea1ef-a09d-48bf-a092-948097e93b21@github.com>
Message-ID: <eBwJMAbGwgq5OxxcvXMhvx2XnuGo0v0a6bXcgGu4HJo=.33815623-8db2-410b-b890-2e049de24d58@github.com>

On Fri, 15 Mar 2024 03:43:13 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Hi Reviewers,
>> 
>> I have updated the test with  PassFailJFrame with information panel, earlier this was informed through terminal.
>> Please review and let me know your suggestions if any.
>
> test/jdk/java/awt/print/PrinterJob/SecurityDialogTest.java line 67:
> 
>> 65:         }
>> 66: 
>> 67:         PassFailJFrame passFailJFrame = new PassFailJFrame.Builder()
> 
> I am getting an error for using new `PassFailJFrame passFailJFrame = new PassFailJFrame.Builder()`, stating _"'Builder()' has private access in 'PassFailJFrame.Builder'"_ Probably because I have fetched latest PassFailJFrame.
> And also you can use `PassFailJFrame.builder()` method.

For me its building and running properly

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18299#discussion_r1525848915

From tr at openjdk.org  Fri Mar 15 07:24:40 2024
From: tr at openjdk.org (Tejesh R)
Date: Fri, 15 Mar 2024 07:24:40 GMT
Subject: RFR: JDK-8320675 : PrinterJob/SecurityDialogTest.java hangs
In-Reply-To: <eBwJMAbGwgq5OxxcvXMhvx2XnuGo0v0a6bXcgGu4HJo=.33815623-8db2-410b-b890-2e049de24d58@github.com>
References: <OMBWLwH7044RMtwdrZSiahQDdy-1T-4oJjOQgnQEKjI=.18a31ad0-710f-44e5-86ec-b4566946b063@github.com>
 <5aXzOToA5dTIrM_tO6JCDfVnpABlsInYnNw5XPbnndA=.d6aea1ef-a09d-48bf-a092-948097e93b21@github.com>
 <eBwJMAbGwgq5OxxcvXMhvx2XnuGo0v0a6bXcgGu4HJo=.33815623-8db2-410b-b890-2e049de24d58@github.com>
Message-ID: <yP9p-CohJr6gqyDTPQzq8AFbS2JAcGinDpHGWb-kDGc=.8e6b908b-6e86-4517-b7dd-e98465603046@github.com>

On Fri, 15 Mar 2024 07:20:30 GMT, Renjith Kannath Pariyangad <rkannathpari at openjdk.org> wrote:

>> test/jdk/java/awt/print/PrinterJob/SecurityDialogTest.java line 67:
>> 
>>> 65:         }
>>> 66: 
>>> 67:         PassFailJFrame passFailJFrame = new PassFailJFrame.Builder()
>> 
>> I am getting an error for using new `PassFailJFrame passFailJFrame = new PassFailJFrame.Builder()`, stating _"'Builder()' has private access in 'PassFailJFrame.Builder'"_ Probably because I have fetched latest PassFailJFrame.
>> And also you can use `PassFailJFrame.builder()` method.
>
> For me its building and running properly

Ok, might be an issue from my side. Will look into it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18299#discussion_r1525850281

From psadhukhan at openjdk.org  Fri Mar 15 07:27:45 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Fri, 15 Mar 2024 07:27:45 GMT
Subject: RFR: 8328247: Remove redundant dir for tests converted from applet to
 main
Message-ID: <Y7y9_ogLr40MhuuVRA1WPXNDc2_i9B0SJ0h71bm-nfw=.6afd340e-4a94-45a0-aee2-c770aba1e05f@github.com>

Few tests were converted from applet manual to main using PassFailJFrame manual framework but the extra folder was not deleted

javax/swing/JFileChooser/6798062/bug6798062.java
javax/swing/JFileChooser/FileFilterDescription/FileFilterDescription.html
javax/swing/JInternalFrame/6726866/bug6726866.java 

so tests are now moved to one folder up..

-------------

Commit messages:
 - Remove redundant dir

Changes: https://git.openjdk.org/jdk/pull/18322/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18322&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8328247
  Stats: 0 lines in 3 files changed: 0 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18322.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18322/head:pull/18322

PR: https://git.openjdk.org/jdk/pull/18322

From abhiscxk at openjdk.org  Fri Mar 15 07:35:04 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Fri, 15 Mar 2024 07:35:04 GMT
Subject: RFR: 8328248: Convert javax/swing/JSlider/6587742/bug6587742.java
 applet test to main
Message-ID: <zudlyAHwM4k8coUTGWVcF3b7uHwYpBPZwhUS9ecExqY=.2d5ec5ca-aecb-4e68-85f9-1b57cf2b2b36@github.com>

Conversion of manual applet test to main based using PassFailJFrame manual framework

-------------

Commit messages:
 - Applet test converted to main manual

Changes: https://git.openjdk.org/jdk/pull/18323/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18323&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8328248
  Stats: 332 lines in 3 files changed: 166 ins; 166 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18323.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18323/head:pull/18323

PR: https://git.openjdk.org/jdk/pull/18323

From abhiscxk at openjdk.org  Fri Mar 15 07:36:55 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Fri, 15 Mar 2024 07:36:55 GMT
Subject: RFR: 8328244: Convert
 javax/swing/JSlider/6742358/bug6742358.java.java applet test to main [v3]
In-Reply-To: <AN6EAjyACY33ukKyOjp8SuzxRt80B9Z_UO1fy83Nijw=.42fbb5cd-fb5c-413d-a1f2-842657fa7f0e@github.com>
References: <AN6EAjyACY33ukKyOjp8SuzxRt80B9Z_UO1fy83Nijw=.42fbb5cd-fb5c-413d-a1f2-842657fa7f0e@github.com>
Message-ID: <xXAG1uSfdyroFueY6L1D7spn9gDjUA8ZxgOLkMWbVK4=.45df8961-7f77-46c6-b84e-3445c9c5555d@github.com>

> Conversion of manual applet test to main based using PassFailJFrame manual framework

Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:

  jtreg manual tag update

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18321/files
  - new: https://git.openjdk.org/jdk/pull/18321/files/d891c49e..976964f0

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18321&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18321&range=01-02

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/18321.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18321/head:pull/18321

PR: https://git.openjdk.org/jdk/pull/18321

From abhiscxk at openjdk.org  Fri Mar 15 07:38:56 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Fri, 15 Mar 2024 07:38:56 GMT
Subject: RFR: 8327980: Convert
 javax/swing/JToggleButton/4128979/bug4128979.java applet test to main [v4]
In-Reply-To: <lZHt9pYb75UtaIEtbB0paOkfqR5CUAc6tikhb9YAakU=.ff2adbed-1db2-490a-8747-66ac96d03657@github.com>
References: <lZHt9pYb75UtaIEtbB0paOkfqR5CUAc6tikhb9YAakU=.ff2adbed-1db2-490a-8747-66ac96d03657@github.com>
Message-ID: <n0vT_fy8wfZX68dx4u3XCeJjm6Scet9KPaXbLdpwvII=.d7567f62-498f-4aa3-ac42-d9490ba0faa7@github.com>

> Conversion of manual applet test to main based using PassFailJFrame manual framework

Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:

  jtreg manual tag update

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18233/files
  - new: https://git.openjdk.org/jdk/pull/18233/files/bd1aaf2e..4e5c83d6

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18233&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18233&range=02-03

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/18233.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18233/head:pull/18233

PR: https://git.openjdk.org/jdk/pull/18233

From abhiscxk at openjdk.org  Fri Mar 15 07:45:38 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Fri, 15 Mar 2024 07:45:38 GMT
Subject: RFR: 8328087: Automate javax/swing/JTable/TAB/TAB.java applet test
 [v5]
In-Reply-To: <-OImXzW8qddK4eXpclABH6epfQ0u6GpUZCmA56Djfgk=.d830a67b-536e-4d42-88a3-f4dbfdc9af53@github.com>
References: <MumC6TL2XcA5TmVgQXy8yIDFEqUD08b2dvCUyYu7Kd8=.5891ab36-873a-41f0-b22f-d2fc883c8734@github.com>
 <pGm_A8fwdgfWubc_0dPZKMHUZiAjFcUagULfh0X5OWw=.050b2e38-8e22-43b1-938d-48b899578ef0@github.com>
 <-OImXzW8qddK4eXpclABH6epfQ0u6GpUZCmA56Djfgk=.d830a67b-536e-4d42-88a3-f4dbfdc9af53@github.com>
Message-ID: <IerGZlHheUyIyI4SvXwsh5njVhi4TqGdrGMtr0O3-4c=.0897e885-3b6d-4597-ab97-8cada0fbabe2@github.com>

On Fri, 15 Mar 2024 07:16:31 GMT, Tejesh R <tr at openjdk.org> wrote:

> Looks good to me. Does this work fine in other L&F (Like Aqua), because you have explicitly mentioned as Metal right?

The older version of applet test also checks for MetalLookAndFeel. Since the test is just converted to main manual, didn't check explicitly on Aqua or other LAFs.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18274#issuecomment-1999099185

From rkannathpari at openjdk.org  Fri Mar 15 08:39:51 2024
From: rkannathpari at openjdk.org (Renjith Kannath Pariyangad)
Date: Fri, 15 Mar 2024 08:39:51 GMT
Subject: RFR: JDK-8320675 : PrinterJob/SecurityDialogTest.java hangs [v2]
In-Reply-To: <OMBWLwH7044RMtwdrZSiahQDdy-1T-4oJjOQgnQEKjI=.18a31ad0-710f-44e5-86ec-b4566946b063@github.com>
References: <OMBWLwH7044RMtwdrZSiahQDdy-1T-4oJjOQgnQEKjI=.18a31ad0-710f-44e5-86ec-b4566946b063@github.com>
Message-ID: <BsLiAhSp_phTUdJsw0l_itKv97FUbWOpMI8vmmEQO-Y=.1c65049c-590c-4939-af95-ba012c487767@github.com>

> Hi Reviewers,
> 
> I have updated the test with  PassFailJFrame with information panel, earlier this was informed through terminal.
> Please review and let me know your suggestions if any.

Renjith Kannath Pariyangad has updated the pull request incrementally with one additional commit since the last revision:

  Added summary

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18299/files
  - new: https://git.openjdk.org/jdk/pull/18299/files/ede65c0b..6e80eaa0

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18299&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18299&range=00-01

  Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18299.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18299/head:pull/18299

PR: https://git.openjdk.org/jdk/pull/18299

From rkannathpari at openjdk.org  Fri Mar 15 08:39:51 2024
From: rkannathpari at openjdk.org (Renjith Kannath Pariyangad)
Date: Fri, 15 Mar 2024 08:39:51 GMT
Subject: RFR: JDK-8320675 : PrinterJob/SecurityDialogTest.java hangs [v2]
In-Reply-To: <5aXzOToA5dTIrM_tO6JCDfVnpABlsInYnNw5XPbnndA=.d6aea1ef-a09d-48bf-a092-948097e93b21@github.com>
References: <OMBWLwH7044RMtwdrZSiahQDdy-1T-4oJjOQgnQEKjI=.18a31ad0-710f-44e5-86ec-b4566946b063@github.com>
 <5aXzOToA5dTIrM_tO6JCDfVnpABlsInYnNw5XPbnndA=.d6aea1ef-a09d-48bf-a092-948097e93b21@github.com>
Message-ID: <tf97AvskVN9tg7cqPqY71hfeGauJMVeuYRBmR5itRPw=.da2eaafe-dd2a-47aa-9293-b615d3114575@github.com>

On Fri, 15 Mar 2024 03:33:24 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Renjith Kannath Pariyangad has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Added summary
>
> test/jdk/java/awt/print/PrinterJob/SecurityDialogTest.java line 43:
> 
>> 41:  * @key printer
>> 42:  * @library /java/awt/regtesthelpers
>> 43:  * @build PassFailJFrame
> 
> Any reason why test summary is not there?

It was not part of original test case, I have updated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18299#discussion_r1525919146

From kizune at openjdk.org  Fri Mar 15 09:03:45 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Fri, 15 Mar 2024 09:03:45 GMT
Subject: Integrated: 8328158: Convert java/awt/Choice/NonFocusablePopupMenuTest
 to automatic main test
In-Reply-To: <5o5Qhfltwmw1WbGujddcfKdNxIQahHyXXFHhaYfrLsM=.6437d7e5-ad8c-43be-b04c-3f45c0c9c54a@github.com>
References: <5o5Qhfltwmw1WbGujddcfKdNxIQahHyXXFHhaYfrLsM=.6437d7e5-ad8c-43be-b04c-3f45c0c9c54a@github.com>
Message-ID: <KYh7UYMfxobasmy2ZZ4wsgZLymrPfn1JO5ZXtr9vuLQ=.28f047c4-3ba6-4c6a-8191-9427d1ad85d9@github.com>

On Thu, 14 Mar 2024 12:27:29 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

> Convert test to the automatic main and move it from its own folder since it is no longer required.

This pull request has now been integrated.

Changeset: b8dfeafd
Author:    Alexander Zuev <kizune at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/b8dfeafdfd9ca024c92c9a73b59e6e71c0551985
Stats:     352 lines in 3 files changed: 95 ins; 257 del; 0 mod

8328158: Convert java/awt/Choice/NonFocusablePopupMenuTest to automatic main test

Reviewed-by: abhiscxk, honkar

-------------

PR: https://git.openjdk.org/jdk/pull/18300

From kizune at openjdk.org  Fri Mar 15 09:16:46 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Fri, 15 Mar 2024 09:16:46 GMT
Subject: Integrated: 8316388: Opensource five Swing component related
 regression tests
In-Reply-To: <lyqr03dS3RFZwQum85-sdTUI2flExMCQm9Dps70wX5w=.1e207aa6-34e2-48e5-866c-bc39eb8d479f@github.com>
References: <lyqr03dS3RFZwQum85-sdTUI2flExMCQm9Dps70wX5w=.1e207aa6-34e2-48e5-866c-bc39eb8d479f@github.com>
Message-ID: <x1iaDQq-zSsD7TR8VYoNJxLUwXOugdGDCCgS_wUTPBg=.9f2e5518-2d5a-4117-b039-6e1eddfbdcc3@github.com>

On Wed, 13 Mar 2024 06:49:16 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

> Cleaned up five more tests.
> 
> Continuation of https://github.com/openjdk/jdk/pull/18184
> 
> Unfortunately one of the commits rendered the whole PR invalid so i closed it and restarting it here.
> All comments from the previous review are addressed.

This pull request has now been integrated.

Changeset: c05f8c72
Author:    Alexander Zuev <kizune at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/c05f8c72239ed3f16ff0d13f4dba795731f9559f
Stats:     450 lines in 5 files changed: 450 ins; 0 del; 0 mod

8316388: Opensource five Swing component related regression tests

Reviewed-by: aivanov

-------------

PR: https://git.openjdk.org/jdk/pull/18259

From tr at openjdk.org  Fri Mar 15 09:40:39 2024
From: tr at openjdk.org (Tejesh R)
Date: Fri, 15 Mar 2024 09:40:39 GMT
Subject: RFR: 8328087: Automate javax/swing/JTable/TAB/TAB.java applet test
 [v5]
In-Reply-To: <pGm_A8fwdgfWubc_0dPZKMHUZiAjFcUagULfh0X5OWw=.050b2e38-8e22-43b1-938d-48b899578ef0@github.com>
References: <MumC6TL2XcA5TmVgQXy8yIDFEqUD08b2dvCUyYu7Kd8=.5891ab36-873a-41f0-b22f-d2fc883c8734@github.com>
 <pGm_A8fwdgfWubc_0dPZKMHUZiAjFcUagULfh0X5OWw=.050b2e38-8e22-43b1-938d-48b899578ef0@github.com>
Message-ID: <7FzaI0UHwDXqyHOpIQ_3lFveompRdy3wXuWQZvSTx_w=.d9240d31-dbd6-4ddf-a7ea-4a11430a2fef@github.com>

On Thu, 14 Mar 2024 18:05:11 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Conversion of manual applet test to automated test. CI testing is green. Link attached to JBS.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Minor update

Marked as reviewed by tr (Committer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18274#pullrequestreview-1938502030

From tr at openjdk.org  Fri Mar 15 09:40:39 2024
From: tr at openjdk.org (Tejesh R)
Date: Fri, 15 Mar 2024 09:40:39 GMT
Subject: RFR: JDK-8320675 : PrinterJob/SecurityDialogTest.java hangs [v2]
In-Reply-To: <BsLiAhSp_phTUdJsw0l_itKv97FUbWOpMI8vmmEQO-Y=.1c65049c-590c-4939-af95-ba012c487767@github.com>
References: <OMBWLwH7044RMtwdrZSiahQDdy-1T-4oJjOQgnQEKjI=.18a31ad0-710f-44e5-86ec-b4566946b063@github.com>
 <BsLiAhSp_phTUdJsw0l_itKv97FUbWOpMI8vmmEQO-Y=.1c65049c-590c-4939-af95-ba012c487767@github.com>
Message-ID: <4wDf_d_LDRCq388Zhyr0KgWJDf1jhcPpRoVtrob7WTk=.ae3637ed-d3f1-4bbb-bbc0-2ab9dc97d4e4@github.com>

On Fri, 15 Mar 2024 08:39:51 GMT, Renjith Kannath Pariyangad <rkannathpari at openjdk.org> wrote:

>> Hi Reviewers,
>> 
>> I have updated the test with  PassFailJFrame with information panel, earlier this was informed through terminal.
>> Please review and let me know your suggestions if any.
>
> Renjith Kannath Pariyangad has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Added summary

Marked as reviewed by tr (Committer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18299#pullrequestreview-1938503166

From aivanov at openjdk.org  Fri Mar 15 10:45:38 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Fri, 15 Mar 2024 10:45:38 GMT
Subject: RFR: JDK-8320675 : PrinterJob/SecurityDialogTest.java hangs [v2]
In-Reply-To: <BsLiAhSp_phTUdJsw0l_itKv97FUbWOpMI8vmmEQO-Y=.1c65049c-590c-4939-af95-ba012c487767@github.com>
References: <OMBWLwH7044RMtwdrZSiahQDdy-1T-4oJjOQgnQEKjI=.18a31ad0-710f-44e5-86ec-b4566946b063@github.com>
 <BsLiAhSp_phTUdJsw0l_itKv97FUbWOpMI8vmmEQO-Y=.1c65049c-590c-4939-af95-ba012c487767@github.com>
Message-ID: <-HK_j4W24AReAluZX0O4pa1i2bavNtET37hn9HxOqGo=.0aff8ab0-cf6a-4b8b-aae3-21c3902c64e7@github.com>

On Fri, 15 Mar 2024 08:39:51 GMT, Renjith Kannath Pariyangad <rkannathpari at openjdk.org> wrote:

>> Hi Reviewers,
>> 
>> I have updated the test with  PassFailJFrame with information panel, earlier this was informed through terminal.
>> Please review and let me know your suggestions if any.
>
> Renjith Kannath Pariyangad has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Added summary

Changes requested by aivanov (Reviewer).

test/jdk/java/awt/print/PrinterJob/SecurityDialogTest.java line 48:

> 46:  * @run main/manual/othervm -Djava.security.manager=allow SecurityDialogTest
> 47:  */
> 48: public class SecurityDialogTest extends Frame {

Suggestion:

public class SecurityDialogTest {

It does not need to extend `Frame`.

-------------

PR Review: https://git.openjdk.org/jdk/pull/18299#pullrequestreview-1938621163
PR Review Comment: https://git.openjdk.org/jdk/pull/18299#discussion_r1526078681

From aivanov at openjdk.org  Fri Mar 15 10:45:39 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Fri, 15 Mar 2024 10:45:39 GMT
Subject: RFR: JDK-8320675 : PrinterJob/SecurityDialogTest.java hangs [v2]
In-Reply-To: <WCtIYtNKB1VG1l_4oyqRp-x6HP2teFbww7c2bk6vr5Y=.0ed28334-9f86-4200-ba72-7d1ad7cf233a@github.com>
References: <OMBWLwH7044RMtwdrZSiahQDdy-1T-4oJjOQgnQEKjI=.18a31ad0-710f-44e5-86ec-b4566946b063@github.com>
 <5aXzOToA5dTIrM_tO6JCDfVnpABlsInYnNw5XPbnndA=.d6aea1ef-a09d-48bf-a092-948097e93b21@github.com>
 <EBEMv4WjMiaP2puQyFe4ULCiWDhPiHTZj-dASIcZwNo=.72a31043-cae8-4a81-85fe-acd1fb54cf62@github.com>
 <WCtIYtNKB1VG1l_4oyqRp-x6HP2teFbww7c2bk6vr5Y=.0ed28334-9f86-4200-ba72-7d1ad7cf233a@github.com>
Message-ID: <fjPuuOGjaVD3goTo99Io6eB_cgeUzIuuoAipgTbnS84=.58c7bcfc-e99d-41ad-989e-95e0e014d8fc@github.com>

On Fri, 15 Mar 2024 06:45:57 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Most of the test with PassFailJFrame instruction stored as string inside class, what additional benefit will get keeping it inside Main ?
>
> When it can become local variable then why to keep it in class? Not like significant benefit maybe, but yeah just to keep its scope locally when it can be.

> INSTRUCTIONS can be moved inside main.

No. Well, it can but what's the point?

I find a value in having the instructions as a dedicated constant at the top of the file. When you open the test, the instructions will be the first thing you see, and it's what you need after reading the summary in `@summary` tag above the class declaration.

>> For me its building and running properly
>
> Ok, might be an issue from my side. Will look into it.

> I am getting an error for using `new PassFailJFrame passFailJFrame = new PassFailJFrame.Builder()`, stating *"'Builder()' has private access in 'PassFailJFrame.Builder'"*. Probably because I have fetched latest `PassFailJFrame`.

@TejeshR13 You're absolutely right. Thanks for catching it.

> And also you can use `PassFailJFrame.builder()` method.

Not *can* but *must*.

The test won't work after it's integrated, it won't compile.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18299#discussion_r1526081314
PR Review Comment: https://git.openjdk.org/jdk/pull/18299#discussion_r1526084123

From abhiscxk at openjdk.org  Fri Mar 15 10:51:44 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Fri, 15 Mar 2024 10:51:44 GMT
Subject: Integrated: 8328087: Automate javax/swing/JTable/TAB/TAB.java applet
 test
In-Reply-To: <MumC6TL2XcA5TmVgQXy8yIDFEqUD08b2dvCUyYu7Kd8=.5891ab36-873a-41f0-b22f-d2fc883c8734@github.com>
References: <MumC6TL2XcA5TmVgQXy8yIDFEqUD08b2dvCUyYu7Kd8=.5891ab36-873a-41f0-b22f-d2fc883c8734@github.com>
Message-ID: <NPS_w-ziaPYGd2u3FGWLrj29rJ32YXR021AEPzijLAk=.3605cf49-0d54-4bec-9ab3-4b722bb49a75@github.com>

On Wed, 13 Mar 2024 13:26:46 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

> Conversion of manual applet test to automated test. CI testing is green. Link attached to JBS.

This pull request has now been integrated.

Changeset: 5249cc0a
Author:    Abhishek Kumar <abhiscxk at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/5249cc0a79f05b71f4c31bb6b02775976eef77aa
Stats:     437 lines in 3 files changed: 225 ins; 212 del; 0 mod

8328087: Automate javax/swing/JTable/TAB/TAB.java applet test

Reviewed-by: honkar, tr

-------------

PR: https://git.openjdk.org/jdk/pull/18274

From aivanov at openjdk.org  Fri Mar 15 10:52:40 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Fri, 15 Mar 2024 10:52:40 GMT
Subject: RFR: JDK-8320675 : PrinterJob/SecurityDialogTest.java hangs [v2]
In-Reply-To: <BsLiAhSp_phTUdJsw0l_itKv97FUbWOpMI8vmmEQO-Y=.1c65049c-590c-4939-af95-ba012c487767@github.com>
References: <OMBWLwH7044RMtwdrZSiahQDdy-1T-4oJjOQgnQEKjI=.18a31ad0-710f-44e5-86ec-b4566946b063@github.com>
 <BsLiAhSp_phTUdJsw0l_itKv97FUbWOpMI8vmmEQO-Y=.1c65049c-590c-4939-af95-ba012c487767@github.com>
Message-ID: <hWHGqQdNVHnpVLOIxHa4G7R8a9UissjhIfUGqj65SIs=.88d3d765-b7f1-4490-8840-e90f20a2442e@github.com>

On Fri, 15 Mar 2024 08:39:51 GMT, Renjith Kannath Pariyangad <rkannathpari at openjdk.org> wrote:

>> Hi Reviewers,
>> 
>> I have updated the test with  PassFailJFrame with information panel, earlier this was informed through terminal.
>> Please review and let me know your suggestions if any.
>
> Renjith Kannath Pariyangad has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Added summary

> > INSTRUCTIONS can be moved inside main.
>
> No. Well, it can but what's the point?

IDE never suggests converting *constants* to local variables. It is because constants can be inlined by Java compiler.

Static or instance fields as well as local variables are usually kept. Converting a field to local variable reduces the size of the object.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18299#issuecomment-1999395558

From aivanov at openjdk.org  Fri Mar 15 10:52:41 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Fri, 15 Mar 2024 10:52:41 GMT
Subject: RFR: JDK-8320675 : PrinterJob/SecurityDialogTest.java hangs [v2]
In-Reply-To: <5aXzOToA5dTIrM_tO6JCDfVnpABlsInYnNw5XPbnndA=.d6aea1ef-a09d-48bf-a092-948097e93b21@github.com>
References: <OMBWLwH7044RMtwdrZSiahQDdy-1T-4oJjOQgnQEKjI=.18a31ad0-710f-44e5-86ec-b4566946b063@github.com>
 <5aXzOToA5dTIrM_tO6JCDfVnpABlsInYnNw5XPbnndA=.d6aea1ef-a09d-48bf-a092-948097e93b21@github.com>
Message-ID: <XN5jc0ERObzLCw6OZejO16g0xjbu3nTEEHwEKdXYhqA=.f76056c8-80fe-41f4-b7e5-38fe80f4a290@github.com>

On Fri, 15 Mar 2024 03:33:50 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Renjith Kannath Pariyangad has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Added summary
>
> test/jdk/java/awt/print/PrinterJob/SecurityDialogTest.java line 45:
> 
>> 43:  * @build PassFailJFrame
>> 44:  * @run main/manual/othervm -Djava.security.manager=allow SecurityDialogTest
>> 45:  */
> 
> Line spacing here would be nice.

@TejeshR13 What do you mean? What kind of line spacing would be nice here?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18299#discussion_r1526093131

From tr at openjdk.org  Fri Mar 15 10:55:41 2024
From: tr at openjdk.org (Tejesh R)
Date: Fri, 15 Mar 2024 10:55:41 GMT
Subject: RFR: JDK-8320675 : PrinterJob/SecurityDialogTest.java hangs [v2]
In-Reply-To: <XN5jc0ERObzLCw6OZejO16g0xjbu3nTEEHwEKdXYhqA=.f76056c8-80fe-41f4-b7e5-38fe80f4a290@github.com>
References: <OMBWLwH7044RMtwdrZSiahQDdy-1T-4oJjOQgnQEKjI=.18a31ad0-710f-44e5-86ec-b4566946b063@github.com>
 <5aXzOToA5dTIrM_tO6JCDfVnpABlsInYnNw5XPbnndA=.d6aea1ef-a09d-48bf-a092-948097e93b21@github.com>
 <XN5jc0ERObzLCw6OZejO16g0xjbu3nTEEHwEKdXYhqA=.f76056c8-80fe-41f4-b7e5-38fe80f4a290@github.com>
Message-ID: <5dzcKqIjwUep6idzLMqJu69-3v8TAypobMOpoG7llGk=.d17db09f-1871-465c-8de1-f151ee595fe6@github.com>

On Fri, 15 Mar 2024 10:50:18 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> test/jdk/java/awt/print/PrinterJob/SecurityDialogTest.java line 45:
>> 
>>> 43:  * @build PassFailJFrame
>>> 44:  * @run main/manual/othervm -Djava.security.manager=allow SecurityDialogTest
>>> 45:  */
>> 
>> Line spacing here would be nice.
>
> @TejeshR13 What do you mean? What kind of line spacing would be nice here?

Line spacing between JTREG tag and class.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18299#discussion_r1526096418

From aivanov at openjdk.org  Fri Mar 15 10:57:39 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Fri, 15 Mar 2024 10:57:39 GMT
Subject: RFR: 8327137: Add test for ConcurrentModificationException in
 BasicDirectoryModel
In-Reply-To: <iT0AkMDtFdmSgs9hw1n8wICk_ywpXnbklk9I-STL7WM=.d6dc05f1-7cdc-43f2-bc86-dc9e7e3bdc39@github.com>
References: <mCqqjrXVWDB2PvpOhKHx-Hr8W6tUz6v4stztGmyAeEg=.1f95da1c-e1a5-40be-be8b-0758729fa9b9@github.com>
 <aRuO2zb4IkM3F28MH5RcfHesc1Z9i7w_uK8kSkIh6i0=.cce14bf8-3384-4e8e-9c12-4e0708dbf3ab@github.com>
 <iT0AkMDtFdmSgs9hw1n8wICk_ywpXnbklk9I-STL7WM=.d6dc05f1-7cdc-43f2-bc86-dc9e7e3bdc39@github.com>
Message-ID: <MjyHoVphv3Ydr6ZvzpIwEEJa9ijiccVne_AUzme8e8c=.09ad81a2-13e9-4b6f-93c8-5a4e8e0192a1@github.com>

On Fri, 15 Mar 2024 07:17:59 GMT, Christoph Langer <clanger at openjdk.org> wrote:

> I added it to our testing. Results early next week.

@RealCLanger Thank you. I'm more interested in the failing case. How reliable does the test reproduce the problem?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18109#issuecomment-1999404398

From aivanov at openjdk.org  Fri Mar 15 10:57:40 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Fri, 15 Mar 2024 10:57:40 GMT
Subject: RFR: 8327137: Add test for ConcurrentModificationException in
 BasicDirectoryModel
In-Reply-To: <HvJ96YzIfnTtdNh7R5XtYs_t0sc5VfHjBHUxi9uyJdI=.94715923-e3c0-4666-9a51-340ef91b8b3b@github.com>
References: <mCqqjrXVWDB2PvpOhKHx-Hr8W6tUz6v4stztGmyAeEg=.1f95da1c-e1a5-40be-be8b-0758729fa9b9@github.com>
 <HvJ96YzIfnTtdNh7R5XtYs_t0sc5VfHjBHUxi9uyJdI=.94715923-e3c0-4666-9a51-340ef91b8b3b@github.com>
Message-ID: <njiOwL5NcyzbScH7ysPpGcgwKsHE3dS-4lRIZyNoIRk=.d33e6673-6fce-47a9-a8ba-91e52fcaf05d@github.com>

On Thu, 14 Mar 2024 19:37:48 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>> I'm adding a regression test for [JDK-8323670](https://bugs.openjdk.org/browse/JDK-8323670) and [JDK-8307091](https://bugs.openjdk.org/browse/JDK-8307091); it's also a regression test for [JDK-8240690](https://bugs.openjdk.org/browse/JDK-8240690).
>> 
>> I referenced this test in PR #17462 in [this comment](https://github.com/openjdk/jdk/pull/17462#issuecomment-1914844026). I fine-tuned the test since that time.
>> 
>> The test doesn't fail all the time without the fix for JDK-8323670, however, it fails sometimes. If you run the test several times, it will likely fail _without the fix_.
>> 
>> For me, the test fails about 10 times from 40 runs in the CI. It fails on macOS more frequently than on Linux.
>> 
>> When the test passes, it usually completes in 5 minutes.
>> 
>> **How the test works**
>> 
>> The test creates a temporary directory in the current directory and creates a number of files in it. (The number of files is controlled by `NUMBER_OF_THREADS` constant). Then the test creates `JFileChooser` in the temporary directory.
>> 
>> The test starts several _scanner_ threads, the number is controlled by `NUMBER_OF_THREADS`, which repeatedly call `fileChooser.rescanCurrentDirectory()`. This results in calling `BasicDirectoryModel.validateFileCache` which starts a background thread ? "Basic L&F File Loading Thread" ? to enumerate the files.
>> 
>> A timer is used to create new files in the directory that the file chooser is using.
>> 
>> After enumerating the files, the File Loading Thread posts an event to EDT. The event updates `fileCache` and fires a `ListDataEvent`.
>> 
>> If the File Loading Thread is iterating over `fileCache` using `Iterator` (when `fileCache.subList` or `fileCache.equals` is running; or a new `Vector` instance is created from a `fileCache` or its sublist) and `fileCache` is being updated on EDT, then `ConcurrentModificationException` is thrown.
>> 
>> On Linux and on _headless_ macOS, `ShellFolder.invoke` is executed in the caller, which makes it easier to reproduce the issue. Because of [JDK-8325179](https://bugs.openjdk.org/browse/JDK-8325179), there are several File Loading Threads, which also helps to reproduce the issue.
>> 
>> On _headful_ macOS, the `BasicDirectoryModel` is not used, so the test does not reproduce the issue.
>> 
>> On Windows, the test does not fail or fails with `OutOfMemoryError`. It is because all the File Loading Threads are serialised on the COM thread, `ShellFolder.invoke` submits the task to the COM thread and waits for i...
>
> test/jdk/javax/swing/plaf/basic/BasicDirectoryModel/ConcurrentModification.java line 1:
> 
>> 1: import java.io.IOException;
> 
> the header is missing.

Do you mean the license? Yes, it needs the copyright and license block.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18109#discussion_r1526098180

From aivanov at openjdk.org  Fri Mar 15 11:02:39 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Fri, 15 Mar 2024 11:02:39 GMT
Subject: RFR: JDK-8320675 : PrinterJob/SecurityDialogTest.java hangs [v2]
In-Reply-To: <5dzcKqIjwUep6idzLMqJu69-3v8TAypobMOpoG7llGk=.d17db09f-1871-465c-8de1-f151ee595fe6@github.com>
References: <OMBWLwH7044RMtwdrZSiahQDdy-1T-4oJjOQgnQEKjI=.18a31ad0-710f-44e5-86ec-b4566946b063@github.com>
 <5aXzOToA5dTIrM_tO6JCDfVnpABlsInYnNw5XPbnndA=.d6aea1ef-a09d-48bf-a092-948097e93b21@github.com>
 <XN5jc0ERObzLCw6OZejO16g0xjbu3nTEEHwEKdXYhqA=.f76056c8-80fe-41f4-b7e5-38fe80f4a290@github.com>
 <5dzcKqIjwUep6idzLMqJu69-3v8TAypobMOpoG7llGk=.d17db09f-1871-465c-8de1-f151ee595fe6@github.com>
Message-ID: <Y37hlRVZ3kWAel1ylQNYM3_LHoLGnPALH4VguFpVF4o=.84ccd9b9-10c1-492d-a252-82924804cff2@github.com>

On Fri, 15 Mar 2024 10:53:14 GMT, Tejesh R <tr at openjdk.org> wrote:

>> @TejeshR13 What do you mean? What kind of line spacing would be nice here?
>
> Line spacing between JTREG tag and class.

It's not needed? but most people add it. And we cannot agree on *a common style*, unfortunately.

These jtreg tags are akin to javadoc comment (but they're not javadoc comment, and javadoc syntax `/**` with double-asterisk should not be used), and in most cases the javadoc comment is not separated with a blank line from its class.

The last line of the jtreg tags comment is nearly empty by itself.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18299#discussion_r1526104200

From aivanov at openjdk.org  Fri Mar 15 11:07:52 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Fri, 15 Mar 2024 11:07:52 GMT
Subject: RFR: 8327137: Add test for ConcurrentModificationException in
 BasicDirectoryModel [v2]
In-Reply-To: <mCqqjrXVWDB2PvpOhKHx-Hr8W6tUz6v4stztGmyAeEg=.1f95da1c-e1a5-40be-be8b-0758729fa9b9@github.com>
References: <mCqqjrXVWDB2PvpOhKHx-Hr8W6tUz6v4stztGmyAeEg=.1f95da1c-e1a5-40be-be8b-0758729fa9b9@github.com>
Message-ID: <TDZ3TfpM7B-KdPnzf1ZI73gDIxWLdBrtCQAlY374gkg=.be7d9720-8a5d-4802-9802-dabcb133181c@github.com>

> I'm adding a regression test for [JDK-8323670](https://bugs.openjdk.org/browse/JDK-8323670) and [JDK-8307091](https://bugs.openjdk.org/browse/JDK-8307091); it's also a regression test for [JDK-8240690](https://bugs.openjdk.org/browse/JDK-8240690).
> 
> I referenced this test in PR #17462 in [this comment](https://github.com/openjdk/jdk/pull/17462#issuecomment-1914844026). I fine-tuned the test since that time.
> 
> The test doesn't fail all the time without the fix for JDK-8323670, however, it fails sometimes. If you run the test several times, it will likely fail _without the fix_.
> 
> For me, the test fails about 10 times from 40 runs in the CI. It fails on macOS more frequently than on Linux.
> 
> When the test passes, it usually completes in 5 minutes.
> 
> **How the test works**
> 
> The test creates a temporary directory in the current directory and creates a number of files in it. (The number of files is controlled by `NUMBER_OF_THREADS` constant). Then the test creates `JFileChooser` in the temporary directory.
> 
> The test starts several _scanner_ threads, the number is controlled by `NUMBER_OF_THREADS`, which repeatedly call `fileChooser.rescanCurrentDirectory()`. This results in calling `BasicDirectoryModel.validateFileCache` which starts a background thread ? "Basic L&F File Loading Thread" ? to enumerate the files.
> 
> A timer is used to create new files in the directory that the file chooser is using.
> 
> After enumerating the files, the File Loading Thread posts an event to EDT. The event updates `fileCache` and fires a `ListDataEvent`.
> 
> If the File Loading Thread is iterating over `fileCache` using `Iterator` (when `fileCache.subList` or `fileCache.equals` is running; or a new `Vector` instance is created from a `fileCache` or its sublist) and `fileCache` is being updated on EDT, then `ConcurrentModificationException` is thrown.
> 
> On Linux and on _headless_ macOS, `ShellFolder.invoke` is executed in the caller, which makes it easier to reproduce the issue. Because of [JDK-8325179](https://bugs.openjdk.org/browse/JDK-8325179), there are several File Loading Threads, which also helps to reproduce the issue.
> 
> On _headful_ macOS, the `BasicDirectoryModel` is not used, so the test does not reproduce the issue.
> 
> On Windows, the test does not fail or fails with `OutOfMemoryError`. It is because all the File Loading Threads are serialised on the COM thread, `ShellFolder.invoke` submits the task to the COM thread and waits for it to complete. The chance of updating `fileCache` whil...

Alexey Ivanov has updated the pull request incrementally with one additional commit since the last revision:

  Add copyright header

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18109/files
  - new: https://git.openjdk.org/jdk/pull/18109/files/0d6be7a4..0dfff701

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18109&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18109&range=00-01

  Stats: 23 lines in 1 file changed: 23 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18109.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18109/head:pull/18109

PR: https://git.openjdk.org/jdk/pull/18109

From abhiscxk at openjdk.org  Fri Mar 15 11:08:50 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Fri, 15 Mar 2024 11:08:50 GMT
Subject: RFR: 8328262: Convert javax/swing/JSplitPane/8132123/bug8132123.java
 applet test to main
Message-ID: <UGuBjBTuGecghDM14mLTft1l8zGsY_PPueIqolFvq1U=.65c37ac4-3dbb-4385-85e5-f9393ec1445c@github.com>

Conversion of manual applet test to main based using PassFailJFrame manual framework

-------------

Commit messages:
 - whitespace fix
 - Applet test converted to main manual

Changes: https://git.openjdk.org/jdk/pull/18325/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18325&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8328262
  Stats: 165 lines in 3 files changed: 76 ins; 89 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18325.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18325/head:pull/18325

PR: https://git.openjdk.org/jdk/pull/18325

From aivanov at openjdk.org  Fri Mar 15 11:19:38 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Fri, 15 Mar 2024 11:19:38 GMT
Subject: RFR: 8327137: Add test for ConcurrentModificationException in
 BasicDirectoryModel [v2]
In-Reply-To: <HvJ96YzIfnTtdNh7R5XtYs_t0sc5VfHjBHUxi9uyJdI=.94715923-e3c0-4666-9a51-340ef91b8b3b@github.com>
References: <mCqqjrXVWDB2PvpOhKHx-Hr8W6tUz6v4stztGmyAeEg=.1f95da1c-e1a5-40be-be8b-0758729fa9b9@github.com>
 <HvJ96YzIfnTtdNh7R5XtYs_t0sc5VfHjBHUxi9uyJdI=.94715923-e3c0-4666-9a51-340ef91b8b3b@github.com>
Message-ID: <A1Xg00x43EWd5dSFubiC2EeaiUcyY3Ale2aiOYeHxg0=.59600fe8-c41a-42fb-9520-4f84883c2db7@github.com>

On Thu, 14 Mar 2024 19:38:48 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>> Alexey Ivanov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add copyright header
>
> test/jdk/javax/swing/plaf/basic/BasicDirectoryModel/ConcurrentModification.java line 211:
> 
>> 209:     private static void deleteFile(final Path file) {
>> 210:         try {
>> 211:             Files.delete(file);
> 
> Should we try to delete all files first and then throw an exception if any?

I do try to remove all the files:

https://github.com/openjdk/jdk/blob/0d6be7a4e4368ea67382af4321b9483236276e5a/test/jdk/javax/swing/plaf/basic/BasicDirectoryModel/ConcurrentModification.java#L115-L120

https://github.com/openjdk/jdk/blob/0d6be7a4e4368ea67382af4321b9483236276e5a/test/jdk/javax/swing/plaf/basic/BasicDirectoryModel/ConcurrentModification.java#L202-L215

Probably, this can be chained via `handleException`. On the other hand, I don't want to fail the test if cleaning up the files fails. However, now an exception thrown from the `finally` block will override any exception thrown from the test code, which is a bad thing, so I'll need to reconsider exception handling during clean-up.

If test fails to clean up the files it created, jtreg will remove them. It is the reason why I use the current directory as the base, which is the `scratch` directory when run in jtreg.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18109#discussion_r1526123644

From abhiscxk at openjdk.org  Fri Mar 15 11:30:53 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Fri, 15 Mar 2024 11:30:53 GMT
Subject: RFR: 8328262: Convert
 javax/swing/JSplitPane/8132123/bug8132123.java applet test to main [v2]
In-Reply-To: <UGuBjBTuGecghDM14mLTft1l8zGsY_PPueIqolFvq1U=.65c37ac4-3dbb-4385-85e5-f9393ec1445c@github.com>
References: <UGuBjBTuGecghDM14mLTft1l8zGsY_PPueIqolFvq1U=.65c37ac4-3dbb-4385-85e5-f9393ec1445c@github.com>
Message-ID: <YxENRn8yEx0_KxJCT5XcYa6XE2nUkhtbYZcgmm09gFI=.096c7cfb-ed3b-4cf6-9c5b-ba5898ae7716@github.com>

> Conversion of manual applet test to main based using PassFailJFrame manual framework

Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:

  jtreg manual tag update

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18325/files
  - new: https://git.openjdk.org/jdk/pull/18325/files/eed9cab6..cfac93ab

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18325&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18325&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/18325.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18325/head:pull/18325

PR: https://git.openjdk.org/jdk/pull/18325

From clanger at openjdk.org  Fri Mar 15 11:41:38 2024
From: clanger at openjdk.org (Christoph Langer)
Date: Fri, 15 Mar 2024 11:41:38 GMT
Subject: RFR: 8327137: Add test for ConcurrentModificationException in
 BasicDirectoryModel
In-Reply-To: <MjyHoVphv3Ydr6ZvzpIwEEJa9ijiccVne_AUzme8e8c=.09ad81a2-13e9-4b6f-93c8-5a4e8e0192a1@github.com>
References: <mCqqjrXVWDB2PvpOhKHx-Hr8W6tUz6v4stztGmyAeEg=.1f95da1c-e1a5-40be-be8b-0758729fa9b9@github.com>
 <aRuO2zb4IkM3F28MH5RcfHesc1Z9i7w_uK8kSkIh6i0=.cce14bf8-3384-4e8e-9c12-4e0708dbf3ab@github.com>
 <iT0AkMDtFdmSgs9hw1n8wICk_ywpXnbklk9I-STL7WM=.d6dc05f1-7cdc-43f2-bc86-dc9e7e3bdc39@github.com>
 <MjyHoVphv3Ydr6ZvzpIwEEJa9ijiccVne_AUzme8e8c=.09ad81a2-13e9-4b6f-93c8-5a4e8e0192a1@github.com>
Message-ID: <e2WB9a0OV6zGGQClxDliRZpSybk0Yf-1tghML0ddNM4=.e571d038-cbbc-4f29-8618-60c9df796169@github.com>

On Fri, 15 Mar 2024 10:53:06 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> > I added it to our testing. Results early next week.
> 
> @RealCLanger Thank you. I'm more interested in the failing case. How reliable does the test reproduce the problem?

Yes, it's running in 21 and 22 as well, so we'll see what happens there.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18109#issuecomment-1999476829

From aivanov at openjdk.org  Fri Mar 15 12:05:41 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Fri, 15 Mar 2024 12:05:41 GMT
Subject: RFR: 8327137: Add test for ConcurrentModificationException in
 BasicDirectoryModel [v2]
In-Reply-To: <HvJ96YzIfnTtdNh7R5XtYs_t0sc5VfHjBHUxi9uyJdI=.94715923-e3c0-4666-9a51-340ef91b8b3b@github.com>
References: <mCqqjrXVWDB2PvpOhKHx-Hr8W6tUz6v4stztGmyAeEg=.1f95da1c-e1a5-40be-be8b-0758729fa9b9@github.com>
 <HvJ96YzIfnTtdNh7R5XtYs_t0sc5VfHjBHUxi9uyJdI=.94715923-e3c0-4666-9a51-340ef91b8b3b@github.com>
Message-ID: <V1fPYAjQ6U8TFSOTRQ-Fk9dRnFAwbimWAPUkicxtklk=.6fe019f2-a478-4e11-8c02-b606f8f14709@github.com>

On Thu, 14 Mar 2024 19:37:30 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>> Alexey Ivanov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add copyright header
>
> test/jdk/javax/swing/plaf/basic/BasicDirectoryModel/ConcurrentModification.java line 99:
> 
>> 97:             createFiles(temp);
>> 98: 
>> 99:             final JFileChooser fc = new JFileChooser(temp.toFile());
> 
> it should be created on EDT, just in case.

I don't think it matters here? The test does not rely on even processing on EDT, no state of `JFileChooser` is modified except for calling `rescanCurrentDirectory`. Technically, I am not allowed to do so either. But if I call `rescanCurrentDirectory` from EDT only, the test becomes void.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18109#discussion_r1526185553

From aivanov at openjdk.org  Fri Mar 15 12:07:39 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Fri, 15 Mar 2024 12:07:39 GMT
Subject: RFR: 8325179: Race in BasicDirectoryModel.validateFileCache [v3]
In-Reply-To: <auKMGEN3ftIcC2HpqrsLEEYXkA4zaZwj5wayrEZREEs=.93c4622b-8aa4-447e-955c-dbf3a39ec730@github.com>
References: <nOapec57Ql6DHy57oEeWdkUGER8RYdWc2vwmJsqWDYc=.8de81954-d8c2-4937-b426-e61dde05255e@github.com>
 <mVHHIki7p8TDSN0TlD0kaRuNzWUHom5W-y7y51rxjSA=.35bcbabb-4c2c-4f9e-a48b-b34995336da2@github.com>
 <auKMGEN3ftIcC2HpqrsLEEYXkA4zaZwj5wayrEZREEs=.93c4622b-8aa4-447e-955c-dbf3a39ec730@github.com>
Message-ID: <tkSiCt0JAtyKGRoctRfZgAZGFIdTcqt3LTQNsP1b5SA=.56d66108-dc9c-489a-844c-5c74f4369503@github.com>

On Thu, 14 Mar 2024 19:57:06 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>> Alexey Ivanov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Store the size of fileCache inside synchronized block
>
> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicDirectoryModel.java line 534:
> 
>> 532:         @Override
>> 533:         public void run() {
>> 534:             if (fetchID.get() != fid) {
> 
> How it will work if the "FilesLoader" was created already but before loading the files the "invalidateFileCache" was called, before the patch we stop execution due to "doFire=false".

Good catch!

I'll bump `fetchID` in `invalidateFileCache`. I missed this part.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18111#discussion_r1526188484

From jiefu at openjdk.org  Fri Mar 15 12:12:51 2024
From: jiefu at openjdk.org (Jie Fu)
Date: Fri, 15 Mar 2024 12:12:51 GMT
Subject: RFR: 8328269: NonFocusablePopupMenuTest.java should be marked as
 headful
Message-ID: <aXsXRnqmU1uRl-PUN9EVtUz3R4niy_7Gk-kPBFV-5ZQ=.eba5e758-1716-4891-a335-04985f856c72@github.com>

Please review this trivial change.
Thanks.

-------------

Commit messages:
 - 8328269: NonFocusablePopupMenuTest.java should be marked as headful

Changes: https://git.openjdk.org/jdk/pull/18326/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18326&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8328269
  Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18326.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18326/head:pull/18326

PR: https://git.openjdk.org/jdk/pull/18326

From rkannathpari at openjdk.org  Fri Mar 15 12:13:52 2024
From: rkannathpari at openjdk.org (Renjith Kannath Pariyangad)
Date: Fri, 15 Mar 2024 12:13:52 GMT
Subject: RFR: JDK-8320675 : PrinterJob/SecurityDialogTest.java hangs [v3]
In-Reply-To: <OMBWLwH7044RMtwdrZSiahQDdy-1T-4oJjOQgnQEKjI=.18a31ad0-710f-44e5-86ec-b4566946b063@github.com>
References: <OMBWLwH7044RMtwdrZSiahQDdy-1T-4oJjOQgnQEKjI=.18a31ad0-710f-44e5-86ec-b4566946b063@github.com>
Message-ID: <wlOhHurbE90-XbylGzqnQb6oLYZmvxnmXRGFfBBfSSM=.15989ee0-76ae-43d3-a1b0-d4ab8fbba574@github.com>

> Hi Reviewers,
> 
> I have updated the test with  PassFailJFrame with information panel, earlier this was informed through terminal.
> Please review and let me know your suggestions if any.

Renjith Kannath Pariyangad has updated the pull request incrementally with two additional commits since the last revision:

 - Removed frame
 - Updated PassFailJFrame object access

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18299/files
  - new: https://git.openjdk.org/jdk/pull/18299/files/6e80eaa0..b95f9022

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18299&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18299&range=01-02

  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/18299.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18299/head:pull/18299

PR: https://git.openjdk.org/jdk/pull/18299

From jiefu at openjdk.org  Fri Mar 15 12:14:46 2024
From: jiefu at openjdk.org (Jie Fu)
Date: Fri, 15 Mar 2024 12:14:46 GMT
Subject: RFR: 8328158: Convert java/awt/Choice/NonFocusablePopupMenuTest to
 automatic main test [v4]
In-Reply-To: <_cLhzMaHV2B6w0DWMogu5Abv8Zk4xS_ve9HYWSdTGWc=.32d0ed31-80f1-4fac-b05f-eef88709c2d1@github.com>
References: <5o5Qhfltwmw1WbGujddcfKdNxIQahHyXXFHhaYfrLsM=.6437d7e5-ad8c-43be-b04c-3f45c0c9c54a@github.com>
 <_cLhzMaHV2B6w0DWMogu5Abv8Zk4xS_ve9HYWSdTGWc=.32d0ed31-80f1-4fac-b05f-eef88709c2d1@github.com>
Message-ID: <4-xEuByM6rwfDdfNCQXip02JE2KuCrJXbtPqp7mAwoE=.6a17b131-a311-448a-adfa-6f0a6cebaedc@github.com>

On Thu, 14 Mar 2024 16:48:57 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

>> Convert test to the automatic main and move it from its own folder since it is no longer required.
>
> Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Minor updates

Hi, this test should be marked as headful.
Please see: https://github.com/openjdk/jdk/pull/18326
Thanks.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18300#issuecomment-1999532838

From jiefu at openjdk.org  Fri Mar 15 12:45:43 2024
From: jiefu at openjdk.org (Jie Fu)
Date: Fri, 15 Mar 2024 12:45:43 GMT
Subject: RFR: 8328269: NonFocusablePopupMenuTest.java should be marked as
 headful
In-Reply-To: <633pHsre59vR1nozxc0MiSoLa7tJmT3mIbIMmek3ZHE=.cf9a00fe-501d-43d9-b334-83c6ce2591c8@github.com>
References: <aXsXRnqmU1uRl-PUN9EVtUz3R4niy_7Gk-kPBFV-5ZQ=.eba5e758-1716-4891-a335-04985f856c72@github.com>
 <633pHsre59vR1nozxc0MiSoLa7tJmT3mIbIMmek3ZHE=.cf9a00fe-501d-43d9-b334-83c6ce2591c8@github.com>
Message-ID: <BvV2ixrirFVko8eLuXhOBzM_RqtmOogF7hRbYpfV_iY=.001f1513-56bf-4f9c-a31e-06f434f4222d@github.com>

On Fri, 15 Mar 2024 12:38:23 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>> Please review this trivial change.
>> Thanks.
>
> Marked as reviewed by azvegint (Reviewer).

Thanks @azvegint for the review.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18326#issuecomment-1999581499

From jiefu at openjdk.org  Fri Mar 15 12:45:45 2024
From: jiefu at openjdk.org (Jie Fu)
Date: Fri, 15 Mar 2024 12:45:45 GMT
Subject: Integrated: 8328269: NonFocusablePopupMenuTest.java should be marked
 as headful
In-Reply-To: <aXsXRnqmU1uRl-PUN9EVtUz3R4niy_7Gk-kPBFV-5ZQ=.eba5e758-1716-4891-a335-04985f856c72@github.com>
References: <aXsXRnqmU1uRl-PUN9EVtUz3R4niy_7Gk-kPBFV-5ZQ=.eba5e758-1716-4891-a335-04985f856c72@github.com>
Message-ID: <0EdbrNmHiayZ0rldv9rB_chwkrMHRBIgriGJOkldNw4=.db6c40c2-daa8-40eb-927e-4c685bcc3885@github.com>

On Fri, 15 Mar 2024 12:07:49 GMT, Jie Fu <jiefu at openjdk.org> wrote:

> Please review this trivial change.
> Thanks.

This pull request has now been integrated.

Changeset: bf990c8b
Author:    Jie Fu <jiefu at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/bf990c8b32f1ce050450d94f4f8706e5a01aa3ec
Stats:     1 line in 1 file changed: 1 ins; 0 del; 0 mod

8328269: NonFocusablePopupMenuTest.java should be marked as headful

Reviewed-by: azvegint

-------------

PR: https://git.openjdk.org/jdk/pull/18326

From azvegint at openjdk.org  Fri Mar 15 12:45:43 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Fri, 15 Mar 2024 12:45:43 GMT
Subject: RFR: 8328269: NonFocusablePopupMenuTest.java should be marked as
 headful
In-Reply-To: <633pHsre59vR1nozxc0MiSoLa7tJmT3mIbIMmek3ZHE=.cf9a00fe-501d-43d9-b334-83c6ce2591c8@github.com>
References: <aXsXRnqmU1uRl-PUN9EVtUz3R4niy_7Gk-kPBFV-5ZQ=.eba5e758-1716-4891-a335-04985f856c72@github.com>
 <633pHsre59vR1nozxc0MiSoLa7tJmT3mIbIMmek3ZHE=.cf9a00fe-501d-43d9-b334-83c6ce2591c8@github.com>
Message-ID: <0vrduA85Jwi_3pzdXriogPIjikX0YhvLWovb9qJsmEY=.bfcd206e-a38c-4a55-88a4-79307fdfc785@github.com>

On Fri, 15 Mar 2024 12:38:23 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>> Please review this trivial change.
>> Thanks.
>
> Marked as reviewed by azvegint (Reviewer).

> Thanks @azvegint for the review.

Thank you for the fix

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18326#issuecomment-1999586398

From azvegint at openjdk.org  Fri Mar 15 12:45:43 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Fri, 15 Mar 2024 12:45:43 GMT
Subject: RFR: 8328269: NonFocusablePopupMenuTest.java should be marked as
 headful
In-Reply-To: <aXsXRnqmU1uRl-PUN9EVtUz3R4niy_7Gk-kPBFV-5ZQ=.eba5e758-1716-4891-a335-04985f856c72@github.com>
References: <aXsXRnqmU1uRl-PUN9EVtUz3R4niy_7Gk-kPBFV-5ZQ=.eba5e758-1716-4891-a335-04985f856c72@github.com>
Message-ID: <633pHsre59vR1nozxc0MiSoLa7tJmT3mIbIMmek3ZHE=.cf9a00fe-501d-43d9-b334-83c6ce2591c8@github.com>

On Fri, 15 Mar 2024 12:07:49 GMT, Jie Fu <jiefu at openjdk.org> wrote:

> Please review this trivial change.
> Thanks.

Marked as reviewed by azvegint (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18326#pullrequestreview-1938858286

From azvegint at openjdk.org  Fri Mar 15 13:01:49 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Fri, 15 Mar 2024 13:01:49 GMT
Subject: RFR: 8328248: Convert javax/swing/JSlider/6587742/bug6587742.java
 applet test to main
In-Reply-To: <zudlyAHwM4k8coUTGWVcF3b7uHwYpBPZwhUS9ecExqY=.2d5ec5ca-aecb-4e68-85f9-1b57cf2b2b36@github.com>
References: <zudlyAHwM4k8coUTGWVcF3b7uHwYpBPZwhUS9ecExqY=.2d5ec5ca-aecb-4e68-85f9-1b57cf2b2b36@github.com>
Message-ID: <tbWjkkkYnzTdA08tLxmhcqduMX1lb-HjDTJYN75xrxM=.c244dac7-8424-448e-8cb3-f391607412b9@github.com>

On Fri, 15 Mar 2024 07:29:53 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

> Conversion of manual applet test to main based using PassFailJFrame manual framework

Marked as reviewed by azvegint (Reviewer).

test/jdk/javax/swing/JSlider/bug6587742.java line 30:

> 28:  * @build PassFailJFrame
> 29:  * @run main/manual bug6587742
> 30:  */

Can be moved to the bug6587742 class declaration for better readability

-------------

PR Review: https://git.openjdk.org/jdk/pull/18323#pullrequestreview-1938892178
PR Review Comment: https://git.openjdk.org/jdk/pull/18323#discussion_r1526253430

From aivanov at openjdk.org  Fri Mar 15 13:13:51 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Fri, 15 Mar 2024 13:13:51 GMT
Subject: RFR: 8328242: Add a log area to the PassFailJFrame
In-Reply-To: <yQMhH8WxoKK8CcYYTSOcJcLGwm-TsTmg6wezpbeyznI=.910e9350-d0f2-4b3d-a9a8-275bee8daad1@github.com>
References: <c2nhXjjZerGqDlD3X3gInMwiJ3ng1vsR0AKnmabksPE=.649bf743-3372-4218-939a-84caea3fae71@github.com>
 <yQMhH8WxoKK8CcYYTSOcJcLGwm-TsTmg6wezpbeyznI=.910e9350-d0f2-4b3d-a9a8-275bee8daad1@github.com>
Message-ID: <QJzBxBKWTNrmPlEdfXJhub9lxaj6uFqYbBcSMfh8_KY=.8c7920df-bf8f-4370-8c72-303d7447baaa@github.com>

On Fri, 15 Mar 2024 04:40:35 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>> Often manual tests have a text area in the instruction window to print feedback from the test to be evaluated by a tester.
>> I stumbled across another test that needed this, so I decided to make these changes a standard feature.
>> 
>> List of changes:
>> * The log text area can be added below the `Pass` and `Fail` buttons panel.
>> To do this, use the builder methods `logArea()`, `logArea(int rows)`.
>> * `PassFailJFrame.log(message)`, `PassFailJFrame.logClear()` and `PassFailJFrame.logSet()` are added to control this text area. (maybe I missed something?)
>> * added `invokeOnEDTUncheckedException` for easier use of logging methods
>> 
>> So typical usage would be like:
>> 
>>         PassFailJFrame
>>                 .builder()
>>                 .title("GetBoundsResizeTest Instructions")
>>                 .instructions(INSTRUCTIONS)
>>                 .rows(20)
>>                 .columns(70)
>>                 .logArea()
>>                 .build()
>>                 .awaitAndCheck();
>> 
>> 
>> ----
>> 
>> //somewhere in event handlers:
>> PassFailJFrame.log("Very important message");
>
> test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 406:
> 
>> 404:                                            rows, columns,
>> 405:                                            enableScreenCapture,
>> 406:                                            false, 0),
> 
> It is intentionally added only to the builder to avoid excessive changes to all constructors.
> 
> It seems that the builder produces much cleaner code, so we probably shouldn't spend our time to changing a bunch of `PassFailJFrame` constructors, and at some point we can make the builder the only option available.

Right. We should deprecate all the constructors, or rather remove them altogether and update tests which use them. At this moment, there are 32 tests which use `PassFailJFrame` constructors explicitly.

I submitted [JDK-8328274](https://bugs.openjdk.org/browse/JDK-8328274): _Remove PassFailJFrame constructors in favour of Builder_.

Feel free to re-assign and implement it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18319#discussion_r1526267646

From aivanov at openjdk.org  Fri Mar 15 13:17:02 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Fri, 15 Mar 2024 13:17:02 GMT
Subject: RFR: 8328242: Add a log area to the PassFailJFrame
In-Reply-To: <QJzBxBKWTNrmPlEdfXJhub9lxaj6uFqYbBcSMfh8_KY=.8c7920df-bf8f-4370-8c72-303d7447baaa@github.com>
References: <c2nhXjjZerGqDlD3X3gInMwiJ3ng1vsR0AKnmabksPE=.649bf743-3372-4218-939a-84caea3fae71@github.com>
 <yQMhH8WxoKK8CcYYTSOcJcLGwm-TsTmg6wezpbeyznI=.910e9350-d0f2-4b3d-a9a8-275bee8daad1@github.com>
 <QJzBxBKWTNrmPlEdfXJhub9lxaj6uFqYbBcSMfh8_KY=.8c7920df-bf8f-4370-8c72-303d7447baaa@github.com>
Message-ID: <JsMTlf6v1dFcXseAPGtatYaUV0bVGVtVaqZ_nCLTsxg=.bb8e93cb-c1d1-495d-afda-0c34304fa3be@github.com>

On Fri, 15 Mar 2024 13:11:06 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 406:
>> 
>>> 404:                                            rows, columns,
>>> 405:                                            enableScreenCapture,
>>> 406:                                            false, 0),
>> 
>> It is intentionally added only to the builder to avoid excessive changes to all constructors.
>> 
>> It seems that the builder produces much cleaner code, so we probably shouldn't spend our time to changing a bunch of `PassFailJFrame` constructors, and at some point we can make the builder the only option available.
>
> Right. We should deprecate all the constructors, or rather remove them altogether and update tests which use them. At this moment, there are 32 tests which use `PassFailJFrame` constructors explicitly.
> 
> I submitted [JDK-8328274](https://bugs.openjdk.org/browse/JDK-8328274): _Remove PassFailJFrame constructors in favour of Builder_.
> 
> Feel free to re-assign and implement it.

If we remove the constructors, the builder object can be passed thus eliminating the need to add more parameters. So, it's a good thing to do.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18319#discussion_r1526271182

From aivanov at openjdk.org  Fri Mar 15 13:37:39 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Fri, 15 Mar 2024 13:37:39 GMT
Subject: RFR: 8328242: Add a log area to the PassFailJFrame
In-Reply-To: <c2nhXjjZerGqDlD3X3gInMwiJ3ng1vsR0AKnmabksPE=.649bf743-3372-4218-939a-84caea3fae71@github.com>
References: <c2nhXjjZerGqDlD3X3gInMwiJ3ng1vsR0AKnmabksPE=.649bf743-3372-4218-939a-84caea3fae71@github.com>
Message-ID: <MGlPezQt9YlsX7VfML-0RhpyP1pDlHhmIjn5_8P0Aeg=.a189c584-52ae-41d4-8881-802d89a1fdfd@github.com>

On Fri, 15 Mar 2024 04:40:14 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

> Often manual tests have a text area in the instruction window to print feedback from the test to be evaluated by a tester.
> I stumbled across another test that needed this, so I decided to make these changes a standard feature.
> 
> List of changes:
> * The log text area can be added below the `Pass` and `Fail` buttons panel.
> To do this, use the builder methods `logArea()`, `logArea(int rows)`.
> * `PassFailJFrame.log(message)`, `PassFailJFrame.logClear()` and `PassFailJFrame.logSet()` are added to control this text area. (maybe I missed something?)
> * added `invokeOnEDTUncheckedException` for easier use of logging methods
> 
> So typical usage would be like:
> 
>         PassFailJFrame
>                 .builder()
>                 .title("GetBoundsResizeTest Instructions")
>                 .instructions(INSTRUCTIONS)
>                 .rows(20)
>                 .columns(70)
>                 .logArea()
>                 .build()
>                 .awaitAndCheck();
> 
> 
> ----
> 
> //somewhere in event handlers:
> PassFailJFrame.log("Very important message");

Changes requested by aivanov (Reviewer).

test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 486:

> 484:             JPanel buttonsLogPanel = new JPanel();
> 485:             BoxLayout layout = new BoxLayout(buttonsLogPanel, BoxLayout.Y_AXIS);
> 486:             buttonsLogPanel.setLayout(layout);

You can use Box:
Suggestion:

            Box buttonsLogPanel = Box.createVerticalBox();

test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 489:

> 487: 
> 488:             buttonsLogPanel.add(buttonsPanel);
> 489:             buttonsLogPanel.add(new JScrollPane(logArea));

Suggestion:

            buttonsLogPanel.add(new JLabel("Log:"));
            buttonsLogPanel.add(new JScrollPane(logArea));

Add a header to explain the purpose of the component below?

test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 1088:

> 1086:     public static void log(String message) {
> 1087:         invokeOnEDTUncheckedException(() -> {
> 1088:             if (logArea != null) {

Should it throw `NullPointerException`? It's a developer error. If logging is used, it should be enabled; therefore throwing an exception rather than hiding the problem is reasonable, isn't it? Otherwise, the problem could remain unnoticed.

test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 1090:

> 1088:             if (logArea != null) {
> 1089:                 logArea.append(message + System.lineSeparator());
> 1090:             }

Suggestion:

            if (logArea != null) {
                logArea.append(message + "\n");
            }

Text components in Swing use `\n` as line separator.

test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 1109:

> 1107:      * Replaces the log area content with provided {@code text}, if enabled by
> 1108:      * {@link Builder#logArea()} or {@link Builder#logArea(int)}.
> 1109:      * @param text replacement

Suggestion:

     * @param text new text for log area

test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 1179:

> 1177:         /**
> 1178:          * Adds a log area below the "Pass", "Fail" buttons.
> 1179:          * <p> The log area can be controlled by {@link #log(String)},

Suggestion:

         * <p>
         * The log area can be controlled by {@link #log(String)},

Starting on the next line makes it easier to parse when reading the source code.

test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 1185:

> 1183:          */
> 1184:         public Builder logArea() {
> 1185:             this.addLogArea = true;

Suggestion:

            addLogArea = true;

I think the usage of `this.` is redundant when there's no naming conflict.

test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 1195:

> 1193:          *
> 1194:          * <p> The number of columns is taken from the number of
> 1195:          * columns in the instructional JTextArea.

This may be not what we want?

I'd like to get rid of specifying rows and columns for instructions, see [JDK-8328163](https://bugs.openjdk.org/browse/JDK-8328163). I can't remember why we decided to specify those explicitly.

On the other hand, if adjustment is required, `.columns` will do the job for both cases, so adding another parameter is likely an overkill.

-------------

PR Review: https://git.openjdk.org/jdk/pull/18319#pullrequestreview-1938932389
PR Review Comment: https://git.openjdk.org/jdk/pull/18319#discussion_r1526274310
PR Review Comment: https://git.openjdk.org/jdk/pull/18319#discussion_r1526277177
PR Review Comment: https://git.openjdk.org/jdk/pull/18319#discussion_r1526298831
PR Review Comment: https://git.openjdk.org/jdk/pull/18319#discussion_r1526280119
PR Review Comment: https://git.openjdk.org/jdk/pull/18319#discussion_r1526281419
PR Review Comment: https://git.openjdk.org/jdk/pull/18319#discussion_r1526284864
PR Review Comment: https://git.openjdk.org/jdk/pull/18319#discussion_r1526284131
PR Review Comment: https://git.openjdk.org/jdk/pull/18319#discussion_r1526293989

From aivanov at openjdk.org  Fri Mar 15 14:45:36 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Fri, 15 Mar 2024 14:45:36 GMT
Subject: RFR: 8327137: Add test for ConcurrentModificationException in
 BasicDirectoryModel [v3]
In-Reply-To: <mCqqjrXVWDB2PvpOhKHx-Hr8W6tUz6v4stztGmyAeEg=.1f95da1c-e1a5-40be-be8b-0758729fa9b9@github.com>
References: <mCqqjrXVWDB2PvpOhKHx-Hr8W6tUz6v4stztGmyAeEg=.1f95da1c-e1a5-40be-be8b-0758729fa9b9@github.com>
Message-ID: <UUsO_EIt0zPtpVszwLEVfDD-oBjT2UBnsbvdd9746-g=.9a6d10be-825a-4388-adfd-21b79e0f8731@github.com>

> I'm adding a regression test for [JDK-8323670](https://bugs.openjdk.org/browse/JDK-8323670) and [JDK-8307091](https://bugs.openjdk.org/browse/JDK-8307091); it's also a regression test for [JDK-8240690](https://bugs.openjdk.org/browse/JDK-8240690).
> 
> I referenced this test in PR #17462 in [this comment](https://github.com/openjdk/jdk/pull/17462#issuecomment-1914844026). I fine-tuned the test since that time.
> 
> The test doesn't fail all the time without the fix for JDK-8323670, however, it fails sometimes. If you run the test several times, it will likely fail _without the fix_.
> 
> For me, the test fails about 10 times from 40 runs in the CI. It fails on macOS more frequently than on Linux.
> 
> When the test passes, it usually completes in 5 minutes.
> 
> **How the test works**
> 
> The test creates a temporary directory in the current directory and creates a number of files in it. (The number of files is controlled by `NUMBER_OF_THREADS` constant). Then the test creates `JFileChooser` in the temporary directory.
> 
> The test starts several _scanner_ threads, the number is controlled by `NUMBER_OF_THREADS`, which repeatedly call `fileChooser.rescanCurrentDirectory()`. This results in calling `BasicDirectoryModel.validateFileCache` which starts a background thread ? "Basic L&F File Loading Thread" ? to enumerate the files.
> 
> A timer is used to create new files in the directory that the file chooser is using.
> 
> After enumerating the files, the File Loading Thread posts an event to EDT. The event updates `fileCache` and fires a `ListDataEvent`.
> 
> If the File Loading Thread is iterating over `fileCache` using `Iterator` (when `fileCache.subList` or `fileCache.equals` is running; or a new `Vector` instance is created from a `fileCache` or its sublist) and `fileCache` is being updated on EDT, then `ConcurrentModificationException` is thrown.
> 
> On Linux and on _headless_ macOS, `ShellFolder.invoke` is executed in the caller, which makes it easier to reproduce the issue. Because of [JDK-8325179](https://bugs.openjdk.org/browse/JDK-8325179), there are several File Loading Threads, which also helps to reproduce the issue.
> 
> On _headful_ macOS, the `BasicDirectoryModel` is not used, so the test does not reproduce the issue.
> 
> On Windows, the test does not fail or fails with `OutOfMemoryError`. It is because all the File Loading Threads are serialised on the COM thread, `ShellFolder.invoke` submits the task to the COM thread and waits for it to complete. The chance of updating `fileCache` whil...

Alexey Ivanov has updated the pull request incrementally with one additional commit since the last revision:

  Suppress throwing exceptions while deleting files

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18109/files
  - new: https://git.openjdk.org/jdk/pull/18109/files/0dfff701..73ea5bf4

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18109&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18109&range=01-02

  Stats: 15 lines in 1 file changed: 13 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/18109.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18109/head:pull/18109

PR: https://git.openjdk.org/jdk/pull/18109

From azvegint at openjdk.org  Fri Mar 15 14:48:41 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Fri, 15 Mar 2024 14:48:41 GMT
Subject: RFR: 8328242: Add a log area to the PassFailJFrame [v2]
In-Reply-To: <c2nhXjjZerGqDlD3X3gInMwiJ3ng1vsR0AKnmabksPE=.649bf743-3372-4218-939a-84caea3fae71@github.com>
References: <c2nhXjjZerGqDlD3X3gInMwiJ3ng1vsR0AKnmabksPE=.649bf743-3372-4218-939a-84caea3fae71@github.com>
Message-ID: <wrEiZ1C9FfLvVh1BGnpm09OKh3Gvo4mgVlGPqiVloQk=.c8806790-5fa3-47a6-9807-ed7aa66606e4@github.com>

> Often manual tests have a text area in the instruction window to print feedback from the test to be evaluated by a tester.
> I stumbled across another test that needed this, so I decided to make these changes a standard feature.
> 
> List of changes:
> * The log text area can be added below the `Pass` and `Fail` buttons panel.
> To do this, use the builder methods `logArea()`, `logArea(int rows)`.
> * `PassFailJFrame.log(message)`, `PassFailJFrame.logClear()` and `PassFailJFrame.logSet()` are added to control this text area. (maybe I missed something?)
> * added `invokeOnEDTUncheckedException` for easier use of logging methods
> 
> So typical usage would be like:
> 
>         PassFailJFrame
>                 .builder()
>                 .title("GetBoundsResizeTest Instructions")
>                 .instructions(INSTRUCTIONS)
>                 .rows(20)
>                 .columns(70)
>                 .logArea()
>                 .build()
>                 .awaitAndCheck();
> 
> 
> ----
> 
> //somewhere in event handlers:
> PassFailJFrame.log("Very important message");

Alexander Zvegintsev has updated the pull request incrementally with two additional commits since the last revision:

 - Add logArea placeholder text
 - review comments

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18319/files
  - new: https://git.openjdk.org/jdk/pull/18319/files/a0fc617c..77e5e4a5

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18319&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18319&range=00-01

  Stats: 29 lines in 1 file changed: 7 ins; 10 del; 12 mod
  Patch: https://git.openjdk.org/jdk/pull/18319.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18319/head:pull/18319

PR: https://git.openjdk.org/jdk/pull/18319

From aivanov at openjdk.org  Fri Mar 15 14:50:12 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Fri, 15 Mar 2024 14:50:12 GMT
Subject: RFR: 8325179: Race in BasicDirectoryModel.validateFileCache [v4]
In-Reply-To: <nOapec57Ql6DHy57oEeWdkUGER8RYdWc2vwmJsqWDYc=.8de81954-d8c2-4937-b426-e61dde05255e@github.com>
References: <nOapec57Ql6DHy57oEeWdkUGER8RYdWc2vwmJsqWDYc=.8de81954-d8c2-4937-b426-e61dde05255e@github.com>
Message-ID: <uXXE9lt4oJLSC0rBvzdMGoja_ITHHL9s9P1ehDf50TM=.744bfbb8-92a9-4ff0-8db2-4b03ffe0c881@github.com>

> Ensure access to the `filesLoader` field of `BasicDirectoryModel` is synchronized.
> 
> Without synchronization, a thread checks if `filesLoader` is not null and creates a new `FilesLoader` thread. If the thread is pre-empted between these two operations, another thread or even several threads can see the `null` value and create new `FilesLoader` threads.
> 
> The same way, `BasicDirectoryModel.invalidateFileCache` needs to be synchornized to interrupt the current `filesLoader` and assign `null`.
> 
> This bug allows reproducing `ConcurrentModificationException` seen in [JDK-8323670](https://bugs.openjdk.org/browse/JDK-8323670) and [JDK-8307091](https://bugs.openjdk.org/browse/JDK-8307091) using the test in PR #18109.

Alexey Ivanov has updated the pull request incrementally with one additional commit since the last revision:

  Increment fetch ID to invalidate pending DoChangeContents

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18111/files
  - new: https://git.openjdk.org/jdk/pull/18111/files/a9ec7f64..478cb500

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18111&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18111&range=02-03

  Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18111.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18111/head:pull/18111

PR: https://git.openjdk.org/jdk/pull/18111

From azvegint at openjdk.org  Fri Mar 15 14:48:46 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Fri, 15 Mar 2024 14:48:46 GMT
Subject: RFR: 8328242: Add a log area to the PassFailJFrame [v2]
In-Reply-To: <MGlPezQt9YlsX7VfML-0RhpyP1pDlHhmIjn5_8P0Aeg=.a189c584-52ae-41d4-8881-802d89a1fdfd@github.com>
References: <c2nhXjjZerGqDlD3X3gInMwiJ3ng1vsR0AKnmabksPE=.649bf743-3372-4218-939a-84caea3fae71@github.com>
 <MGlPezQt9YlsX7VfML-0RhpyP1pDlHhmIjn5_8P0Aeg=.a189c584-52ae-41d4-8881-802d89a1fdfd@github.com>
Message-ID: <sSu-_inBJhvfHYAMRDJmEtbY_XDlkPXFvwT3xj4tGfc=.6f7c1746-7e6b-4c11-87e9-14355bdc0a5e@github.com>

On Fri, 15 Mar 2024 13:16:39 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Alexander Zvegintsev has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Add logArea placeholder text
>>  - review comments
>
> test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 486:
> 
>> 484:             JPanel buttonsLogPanel = new JPanel();
>> 485:             BoxLayout layout = new BoxLayout(buttonsLogPanel, BoxLayout.Y_AXIS);
>> 486:             buttonsLogPanel.setLayout(layout);
> 
> You can use Box:
> Suggestion:
> 
>             Box buttonsLogPanel = Box.createVerticalBox();

Thanks, this is much better.

> test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 489:
> 
>> 487: 
>> 488:             buttonsLogPanel.add(buttonsPanel);
>> 489:             buttonsLogPanel.add(new JScrollPane(logArea));
> 
> Suggestion:
> 
>             buttonsLogPanel.add(new JLabel("Log:"));
>             buttonsLogPanel.add(new JScrollPane(logArea));
> 
> Add a header to explain the purpose of the component below?

This doesn't look good to me
![image](https://github.com/openjdk/jdk/assets/77687766/331e19e6-e1c6-4fa0-ba65-e925c29ca01d)

So how about a placeholder text? It will not take up any of the height of the window.

![image](https://github.com/openjdk/jdk/assets/77687766/e0390333-4974-4799-adb3-8b8f304b664c)

> test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 1088:
> 
>> 1086:     public static void log(String message) {
>> 1087:         invokeOnEDTUncheckedException(() -> {
>> 1088:             if (logArea != null) {
> 
> Should it throw `NullPointerException`? It's a developer error. If logging is used, it should be enabled; therefore throwing an exception rather than hiding the problem is reasonable, isn't it? Otherwise, the problem could remain unnoticed.

Good point, updated.

> test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 1185:
> 
>> 1183:          */
>> 1184:         public Builder logArea() {
>> 1185:             this.addLogArea = true;
> 
> Suggestion:
> 
>             addLogArea = true;
> 
> I think the usage of `this.` is redundant when there's no naming conflict.

I keep it for consistency across builder methods, e.g. `screenCapture` does not need to specify it either.

> test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 1195:
> 
>> 1193:          *
>> 1194:          * <p> The number of columns is taken from the number of
>> 1195:          * columns in the instructional JTextArea.
> 
> This may be not what we want?
> 
> I'd like to get rid of specifying rows and columns for instructions, see [JDK-8328163](https://bugs.openjdk.org/browse/JDK-8328163). I can't remember why we decided to specify those explicitly.
> 
> On the other hand, if adjustment is required, `.columns` will do the job for both cases, so adding another parameter is likely an overkill.

It does the job well for now, so we can get to that later when the actual automatic instruction size is implemented.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18319#discussion_r1526353192
PR Review Comment: https://git.openjdk.org/jdk/pull/18319#discussion_r1526356831
PR Review Comment: https://git.openjdk.org/jdk/pull/18319#discussion_r1526357356
PR Review Comment: https://git.openjdk.org/jdk/pull/18319#discussion_r1526352609
PR Review Comment: https://git.openjdk.org/jdk/pull/18319#discussion_r1526360058

From aivanov at openjdk.org  Fri Mar 15 15:16:41 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Fri, 15 Mar 2024 15:16:41 GMT
Subject: RFR: 8328242: Add a log area to the PassFailJFrame [v2]
In-Reply-To: <gb9kYdPLcdJulXKIK49OR_hj_mcxLL_Mysfhi3RMUdE=.6bee44dc-d025-4731-bb62-5e73390b599c@github.com>
References: <c2nhXjjZerGqDlD3X3gInMwiJ3ng1vsR0AKnmabksPE=.649bf743-3372-4218-939a-84caea3fae71@github.com>
 <MGlPezQt9YlsX7VfML-0RhpyP1pDlHhmIjn5_8P0Aeg=.a189c584-52ae-41d4-8881-802d89a1fdfd@github.com>
 <sSu-_inBJhvfHYAMRDJmEtbY_XDlkPXFvwT3xj4tGfc=.6f7c1746-7e6b-4c11-87e9-14355bdc0a5e@github.com>
 <gb9kYdPLcdJulXKIK49OR_hj_mcxLL_Mysfhi3RMUdE=.6bee44dc-d025-4731-bb62-5e73390b599c@github.com>
Message-ID: <UhCBLZo1wTshl_vnTdzsAhjuh_8K5fbkMU21DfEpF6s=.ef12bb8b-f89b-4ad1-a463-e8e93a8f6e1e@github.com>

On Fri, 15 Mar 2024 14:59:07 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> This doesn't look good to me
>> ![image](https://github.com/openjdk/jdk/assets/77687766/331e19e6-e1c6-4fa0-ba65-e925c29ca01d)
>> 
>> So how about a placeholder text? It will not take up any of the height of the window.
>> 
>> ![image](https://github.com/openjdk/jdk/assets/77687766/e0390333-4974-4799-adb3-8b8f304b664c)
>
> I expected the label to be aligned to the left. For this to happen, the label may need to wrapped into another panel or horizontal box with added glue.
> 
> 
> 
>             Box logLabelBox = Box.createHorizontalBox();
>             logLabelBox.add(new JLabel("Log:"));
>             logLabelBox.add(Box.createHorizontalGlue());
> 
>             Box buttonsLogPanel = Box.createVerticalBox();
>             buttonsLogPanel.add(buttonsPanel);
>             buttonsLogPanel.add(logLabelBox);
>             buttonsLogPanel.add(new JScrollPane(logArea));
> 
> 
> ![Log Area with the "Log:" header, screenshot of PassFailJFrame](https://github.com/openjdk/jdk/assets/70774172/69a86152-a8a6-45ec-9a66-a457f4f5e396)
> 
> Placeholder text isn't supported by Swing natively, is it? Therefore, you'll have to remove the placeholder text when you add the first message, which complicates logging a message.

It could be obvious from the usage? so we may skip the header altogether? if it's mentioned in the instructions, which should still be mentioned to let the test know they need to look for the messages.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18319#discussion_r1526425332

From aivanov at openjdk.org  Fri Mar 15 15:25:06 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Fri, 15 Mar 2024 15:25:06 GMT
Subject: RFR: JDK-8320675 : PrinterJob/SecurityDialogTest.java hangs [v3]
In-Reply-To: <wlOhHurbE90-XbylGzqnQb6oLYZmvxnmXRGFfBBfSSM=.15989ee0-76ae-43d3-a1b0-d4ab8fbba574@github.com>
References: <OMBWLwH7044RMtwdrZSiahQDdy-1T-4oJjOQgnQEKjI=.18a31ad0-710f-44e5-86ec-b4566946b063@github.com>
 <wlOhHurbE90-XbylGzqnQb6oLYZmvxnmXRGFfBBfSSM=.15989ee0-76ae-43d3-a1b0-d4ab8fbba574@github.com>
Message-ID: <NzL8IFvV0MdRO2rsrhcgOCc6nUpLISYuC2kTtX-zt74=.87e1085c-58f6-4ed3-9213-2b078d772b01@github.com>

On Fri, 15 Mar 2024 12:13:52 GMT, Renjith Kannath Pariyangad <rkannathpari at openjdk.org> wrote:

>> Hi Reviewers,
>> 
>> I have updated the test with  PassFailJFrame with information panel, earlier this was informed through terminal.
>> Please review and let me know your suggestions if any.
>
> Renjith Kannath Pariyangad has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Removed frame
>  - Updated PassFailJFrame object access

Changes requested by aivanov (Reviewer).

test/jdk/java/awt/print/PrinterJob/SecurityDialogTest.java line 43:

> 41:  * @key printer
> 42:  * @summary tests native and cross-platform page and print dialog
> 43:  *          when security manager is installed

Verifies "Print to file" option is disable if reading/writing files is not allowed by Security Manager.

I believe this type of summary explains better the purpose of the test, and the purpose is to ensure "Print to file" is disabled in writing to files is not allowed, according to the instructions of in the test.

test/jdk/java/awt/print/PrinterJob/SecurityDialogTest.java line 69:

> 67:         }
> 68: 
> 69:         PassFailJFrame passFailJFrame =  PassFailJFrame.builder()

Suggestion:

        PassFailJFrame passFailJFrame = PassFailJFrame.builder()

Removed redundant double space.

-------------

PR Review: https://git.openjdk.org/jdk/pull/18299#pullrequestreview-1939223692
PR Review Comment: https://git.openjdk.org/jdk/pull/18299#discussion_r1526449041
PR Review Comment: https://git.openjdk.org/jdk/pull/18299#discussion_r1526450895

From azvegint at openjdk.org  Fri Mar 15 15:24:39 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Fri, 15 Mar 2024 15:24:39 GMT
Subject: RFR: 8328242: Add a log area to the PassFailJFrame [v2]
In-Reply-To: <UhCBLZo1wTshl_vnTdzsAhjuh_8K5fbkMU21DfEpF6s=.ef12bb8b-f89b-4ad1-a463-e8e93a8f6e1e@github.com>
References: <c2nhXjjZerGqDlD3X3gInMwiJ3ng1vsR0AKnmabksPE=.649bf743-3372-4218-939a-84caea3fae71@github.com>
 <MGlPezQt9YlsX7VfML-0RhpyP1pDlHhmIjn5_8P0Aeg=.a189c584-52ae-41d4-8881-802d89a1fdfd@github.com>
 <sSu-_inBJhvfHYAMRDJmEtbY_XDlkPXFvwT3xj4tGfc=.6f7c1746-7e6b-4c11-87e9-14355bdc0a5e@github.com>
 <gb9kYdPLcdJulXKIK49OR_hj_mcxLL_Mysfhi3RMUdE=.6bee44dc-d025-4731-bb62-5e73390b599c@github.com>
 <UhCBLZo1wTshl_vnTdzsAhjuh_8K5fbkMU21DfEpF6s=.ef12bb8b-f89b-4ad1-a463-e8e93a8f6e1e@github.com>
Message-ID: <vQTJfudsQCEInRB3pYYVpz3464h2azx6675MXuFBIh4=.20a87de0-9594-4edf-aa12-435465344961@github.com>

On Fri, 15 Mar 2024 15:02:27 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> I expected the label to be aligned to the left. For this to happen, the label may need to wrapped into another panel or horizontal box with added glue.
>> 
>> 
>> 
>>             Box logLabelBox = Box.createHorizontalBox();
>>             logLabelBox.add(new JLabel("Log:"));
>>             logLabelBox.add(Box.createHorizontalGlue());
>> 
>>             Box buttonsLogPanel = Box.createVerticalBox();
>>             buttonsLogPanel.add(buttonsPanel);
>>             buttonsLogPanel.add(logLabelBox);
>>             buttonsLogPanel.add(new JScrollPane(logArea));
>> 
>> 
>> ![Log Area with the "Log:" header, screenshot of PassFailJFrame](https://github.com/openjdk/jdk/assets/70774172/69a86152-a8a6-45ec-9a66-a457f4f5e396)
>> 
>> Placeholder text isn't supported by Swing natively, is it? Therefore, you'll have to remove the placeholder text when you add the first message, which complicates logging a message.
>
> It could be obvious from the usage? so we may skip the header altogether? if it's mentioned in the instructions, which should still be mentioned to let the test know they need to look for the messages.

> Placeholder text isn't supported by Swing natively, is it?  Therefore, you'll have to remove the placeholder text when you add the first message, which complicates logging a message.

It is not a big overhead, e.g. I already did it by slightly changing the `log()` method. `logClear()` and `logSet()` are untouched.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18319#discussion_r1526451001

From aivanov at openjdk.org  Fri Mar 15 15:16:34 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Fri, 15 Mar 2024 15:16:34 GMT
Subject: RFR: 8328242: Add a log area to the PassFailJFrame [v2]
In-Reply-To: <sSu-_inBJhvfHYAMRDJmEtbY_XDlkPXFvwT3xj4tGfc=.6f7c1746-7e6b-4c11-87e9-14355bdc0a5e@github.com>
References: <c2nhXjjZerGqDlD3X3gInMwiJ3ng1vsR0AKnmabksPE=.649bf743-3372-4218-939a-84caea3fae71@github.com>
 <MGlPezQt9YlsX7VfML-0RhpyP1pDlHhmIjn5_8P0Aeg=.a189c584-52ae-41d4-8881-802d89a1fdfd@github.com>
 <sSu-_inBJhvfHYAMRDJmEtbY_XDlkPXFvwT3xj4tGfc=.6f7c1746-7e6b-4c11-87e9-14355bdc0a5e@github.com>
Message-ID: <gb9kYdPLcdJulXKIK49OR_hj_mcxLL_Mysfhi3RMUdE=.6bee44dc-d025-4731-bb62-5e73390b599c@github.com>

On Fri, 15 Mar 2024 14:15:12 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>> test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 489:
>> 
>>> 487: 
>>> 488:             buttonsLogPanel.add(buttonsPanel);
>>> 489:             buttonsLogPanel.add(new JScrollPane(logArea));
>> 
>> Suggestion:
>> 
>>             buttonsLogPanel.add(new JLabel("Log:"));
>>             buttonsLogPanel.add(new JScrollPane(logArea));
>> 
>> Add a header to explain the purpose of the component below?
>
> This doesn't look good to me
> ![image](https://github.com/openjdk/jdk/assets/77687766/331e19e6-e1c6-4fa0-ba65-e925c29ca01d)
> 
> So how about a placeholder text? It will not take up any of the height of the window.
> 
> ![image](https://github.com/openjdk/jdk/assets/77687766/e0390333-4974-4799-adb3-8b8f304b664c)

I expected the label to be aligned to the left. For this to happen, the label may need to wrapped into another panel or horizontal box with added glue.



            Box logLabelBox = Box.createHorizontalBox();
            logLabelBox.add(new JLabel("Log:"));
            logLabelBox.add(Box.createHorizontalGlue());

            Box buttonsLogPanel = Box.createVerticalBox();
            buttonsLogPanel.add(buttonsPanel);
            buttonsLogPanel.add(logLabelBox);
            buttonsLogPanel.add(new JScrollPane(logArea));


![Log Area with the "Log:" header, screenshot of PassFailJFrame](https://github.com/openjdk/jdk/assets/70774172/69a86152-a8a6-45ec-9a66-a457f4f5e396)

Placeholder text isn't supported by Swing natively, is it? Therefore, you'll have to remove the placeholder text when you add the first message, which complicates logging a message.

>> test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 1185:
>> 
>>> 1183:          */
>>> 1184:         public Builder logArea() {
>>> 1185:             this.addLogArea = true;
>> 
>> Suggestion:
>> 
>>             addLogArea = true;
>> 
>> I think the usage of `this.` is redundant when there's no naming conflict.
>
> I keep it for consistency across builder methods, e.g. `screenCapture` does not need to specify it either.

Okay. Most methods of the builder use `this.` prefix when assigning something to a field.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18319#discussion_r1526420764
PR Review Comment: https://git.openjdk.org/jdk/pull/18319#discussion_r1526429613

From duke at openjdk.org  Fri Mar 15 15:40:53 2024
From: duke at openjdk.org (lawrence.andrews)
Date: Fri, 15 Mar 2024 15:40:53 GMT
Subject: RFR: 8328242: Add a log area to the PassFailJFrame [v2]
In-Reply-To: <bhvk0Nf1-AbbCM0f48pVTiouNE8diYhkSSWp6CH5Fxc=.05a8ccdf-a1b6-4581-9f0c-d0e3d58afddf@github.com>
References: <c2nhXjjZerGqDlD3X3gInMwiJ3ng1vsR0AKnmabksPE=.649bf743-3372-4218-939a-84caea3fae71@github.com>
 <MGlPezQt9YlsX7VfML-0RhpyP1pDlHhmIjn5_8P0Aeg=.a189c584-52ae-41d4-8881-802d89a1fdfd@github.com>
 <sSu-_inBJhvfHYAMRDJmEtbY_XDlkPXFvwT3xj4tGfc=.6f7c1746-7e6b-4c11-87e9-14355bdc0a5e@github.com>
 <gb9kYdPLcdJulXKIK49OR_hj_mcxLL_Mysfhi3RMUdE=.6bee44dc-d025-4731-bb62-5e73390b599c@github.com>
 <bhvk0Nf1-AbbCM0f48pVTiouNE8diYhkSSWp6CH5Fxc=.05a8ccdf-a1b6-4581-9f0c-d0e3d58afddf@github.com>
Message-ID: <QcyhPJ3FYVvEo7IGH2up48br3lkZ23Y3W0NuRQVhg5c=.baedd08f-0caf-4d12-99fe-ffbf4df4d142@github.com>

On Fri, 15 Mar 2024 15:33:30 GMT, lawrence.andrews <duke at openjdk.org> wrote:

>> Okay. Most methods of the builder use `this.` prefix when assigning something to a field.
>
> How about having a clear log button. Just an idea
> Example : 
> I have a mouse event test & I am using the logArea to add all the events into it. But when I have to file a bug & I wanted to show only the required log in the log area in the screen shot by clicking on the 'screen capture' button. I have to clear the log in the logarea and repeat the test and show only the required log in the log area. In this scenario if we can provide a 'Clear log' button will be much useful .

'Clear log' button calling logClear().

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18319#discussion_r1526468319

From kizune at openjdk.org  Fri Mar 15 15:41:29 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Fri, 15 Mar 2024 15:41:29 GMT
Subject: RFR: 8328154: Convert sun/java2d/loops/CopyAreaSpeed.java applet
 test to main
In-Reply-To: <QHf2yYI8zQSoqYjld0VQjVQmFWrIk2f53wArMF0qL14=.a7a41b62-f301-4c7a-9da4-09603d95cbd5@github.com>
References: <QHf2yYI8zQSoqYjld0VQjVQmFWrIk2f53wArMF0qL14=.a7a41b62-f301-4c7a-9da4-09603d95cbd5@github.com>
Message-ID: <QxBA-672c-PlJ0fvIVlejPoFrnmav-Gn6McLgseQ_TI=.109a2b43-f694-47c0-8c6e-7ec066dcf0e7@github.com>

On Thu, 14 Mar 2024 10:39:15 GMT, Tejesh R <tr at openjdk.org> wrote:

> Convert  sun/java2d/loops/CopyAreaSpeed.java manual applet test to main based using PassFailJFrame. This is a performance measurement test which provide benchmark to compare the outcome with different releases. I have converted the test using a PassFailJFrame though PASS/FAIL doesn't matter here. The result have been shown in `JOptionPane` message.

Marked as reviewed by kizune (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18296#pullrequestreview-1939265158

From kizune at openjdk.org  Fri Mar 15 15:41:30 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Fri, 15 Mar 2024 15:41:30 GMT
Subject: RFR: 8328154: Convert sun/java2d/loops/CopyAreaSpeed.java applet
 test to main
In-Reply-To: <-p_u3q1fM-8p0wgRiKohiYi9dc6Kz-TASSP_LBc1W1I=.50d1c283-22b0-48e4-8993-f32a339d0505@github.com>
References: <QHf2yYI8zQSoqYjld0VQjVQmFWrIk2f53wArMF0qL14=.a7a41b62-f301-4c7a-9da4-09603d95cbd5@github.com>
 <pMH61rcy0nzbY-FylMVa7iqZO8i3aKov4eplIEsI6vk=.e088f806-d0c9-4ec7-88c9-b7b461051585@github.com>
 <-p_u3q1fM-8p0wgRiKohiYi9dc6Kz-TASSP_LBc1W1I=.50d1c283-22b0-48e4-8993-f32a339d0505@github.com>
Message-ID: <WQ4rYaXl1YFRI8VeqrJP1tclypLVjWxMxsM0D2VRqlQ=.277049b3-6ff4-41b6-86a6-9b72513ae009@github.com>

On Thu, 14 Mar 2024 16:04:50 GMT, Tejesh R <tr at openjdk.org> wrote:

>> test/jdk/sun/java2d/loops/CopyAreaSpeed.java line 131:
>> 
>>> 129:             }
>>> 130:             try {
>>> 131:                 Thread.sleep(1);
>> 
>> I know it is an old code but i just wonder why do we add sleep to every iteration of something that is supposed to be a performance test. What are we achieving by doing this sleep?
>
> Maybe because of Graphics paint and copyArea ?

It is still a little bit suspicious because adding fixed delay into the test loop makes the test less accurate the fastest hardware gets but i guess in order to maintain the test value compared to the previous versions of the test it will be wrong to change time calculations.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18296#discussion_r1526473747

From aivanov at openjdk.org  Fri Mar 15 15:45:33 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Fri, 15 Mar 2024 15:45:33 GMT
Subject: RFR: 8328242: Add a log area to the PassFailJFrame [v2]
In-Reply-To: <QcyhPJ3FYVvEo7IGH2up48br3lkZ23Y3W0NuRQVhg5c=.baedd08f-0caf-4d12-99fe-ffbf4df4d142@github.com>
References: <c2nhXjjZerGqDlD3X3gInMwiJ3ng1vsR0AKnmabksPE=.649bf743-3372-4218-939a-84caea3fae71@github.com>
 <MGlPezQt9YlsX7VfML-0RhpyP1pDlHhmIjn5_8P0Aeg=.a189c584-52ae-41d4-8881-802d89a1fdfd@github.com>
 <sSu-_inBJhvfHYAMRDJmEtbY_XDlkPXFvwT3xj4tGfc=.6f7c1746-7e6b-4c11-87e9-14355bdc0a5e@github.com>
 <gb9kYdPLcdJulXKIK49OR_hj_mcxLL_Mysfhi3RMUdE=.6bee44dc-d025-4731-bb62-5e73390b599c@github.com>
 <bhvk0Nf1-AbbCM0f48pVTiouNE8diYhkSSWp6CH5Fxc=.05a8ccdf-a1b6-4581-9f0c-d0e3d58afddf@github.com>
 <QcyhPJ3FYVvEo7IGH2up48br3lkZ23Y3W0NuRQVhg5c=.baedd08f-0caf-4d12-99fe-ffbf4df4d142@github.com>
Message-ID: <R0NXnSzFwyi6_YPIqtqAhjqYOaf8uUhN27bfnd1q10o=.af879c35-96f9-4302-ac31-063b88d2a447@github.com>

On Fri, 15 Mar 2024 15:34:27 GMT, lawrence.andrews <duke at openjdk.org> wrote:

>> How about having a clear log button. Just an idea
>> Example : 
>> I have a mouse event test & I am using the logArea to add all the events into it. But when I have to file a bug & I wanted to show only the required log in the log area in the screen shot by clicking on the 'screen capture' button. I have to clear the log in the logarea and repeat the test and show only the required log in the log area. In this scenario if we can provide a 'Clear log' button will be much useful .
>
> 'Clear log' button calling logClear().

@lawrence-andrew I can't see much value?

Capturing logs by a screenshot is not something that you should ever do ? copy the messages and paste them as text into a bug report.

However, you've raised a good point: the log messages could / should be copied to System.out too.

If a test fails, the logs will already be available in the test log, and the tester will not need to copy the log to preserve the messages for submitting the bug. The .jtr file from jtreg will contain all the information.

When submitting a bug, you would filter the log and paste the relevant pieces into the bug report.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18319#discussion_r1526480326

From duke at openjdk.org  Fri Mar 15 15:40:52 2024
From: duke at openjdk.org (lawrence.andrews)
Date: Fri, 15 Mar 2024 15:40:52 GMT
Subject: RFR: 8328242: Add a log area to the PassFailJFrame [v2]
In-Reply-To: <gb9kYdPLcdJulXKIK49OR_hj_mcxLL_Mysfhi3RMUdE=.6bee44dc-d025-4731-bb62-5e73390b599c@github.com>
References: <c2nhXjjZerGqDlD3X3gInMwiJ3ng1vsR0AKnmabksPE=.649bf743-3372-4218-939a-84caea3fae71@github.com>
 <MGlPezQt9YlsX7VfML-0RhpyP1pDlHhmIjn5_8P0Aeg=.a189c584-52ae-41d4-8881-802d89a1fdfd@github.com>
 <sSu-_inBJhvfHYAMRDJmEtbY_XDlkPXFvwT3xj4tGfc=.6f7c1746-7e6b-4c11-87e9-14355bdc0a5e@github.com>
 <gb9kYdPLcdJulXKIK49OR_hj_mcxLL_Mysfhi3RMUdE=.6bee44dc-d025-4731-bb62-5e73390b599c@github.com>
Message-ID: <bhvk0Nf1-AbbCM0f48pVTiouNE8diYhkSSWp6CH5Fxc=.05a8ccdf-a1b6-4581-9f0c-d0e3d58afddf@github.com>

On Fri, 15 Mar 2024 15:05:28 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> I keep it for consistency across builder methods, e.g. `screenCapture` does not need to specify it either.
>
> Okay. Most methods of the builder use `this.` prefix when assigning something to a field.

How about having a clear log button. Just an idea
Example : 
I have a mouse event test & I am using the logArea to add all the events into it. But when I have to file a bug & I wanted to show only the required log in the log area in the screen shot by clicking on the 'screen capture' button. I have to clear the log in the logarea and repeat the test and show only the required log in the log area. In this scenario if we can provide a 'Clear log' button will be much useful .

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18319#discussion_r1526466970

From aivanov at openjdk.org  Fri Mar 15 15:40:52 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Fri, 15 Mar 2024 15:40:52 GMT
Subject: RFR: 8328242: Add a log area to the PassFailJFrame [v2]
In-Reply-To: <vQTJfudsQCEInRB3pYYVpz3464h2azx6675MXuFBIh4=.20a87de0-9594-4edf-aa12-435465344961@github.com>
References: <c2nhXjjZerGqDlD3X3gInMwiJ3ng1vsR0AKnmabksPE=.649bf743-3372-4218-939a-84caea3fae71@github.com>
 <MGlPezQt9YlsX7VfML-0RhpyP1pDlHhmIjn5_8P0Aeg=.a189c584-52ae-41d4-8881-802d89a1fdfd@github.com>
 <sSu-_inBJhvfHYAMRDJmEtbY_XDlkPXFvwT3xj4tGfc=.6f7c1746-7e6b-4c11-87e9-14355bdc0a5e@github.com>
 <gb9kYdPLcdJulXKIK49OR_hj_mcxLL_Mysfhi3RMUdE=.6bee44dc-d025-4731-bb62-5e73390b599c@github.com>
 <UhCBLZo1wTshl_vnTdzsAhjuh_8K5fbkMU21DfEpF6s=.ef12bb8b-f89b-4ad1-a463-e8e93a8f6e1e@github.com>
 <vQTJfudsQCEInRB3pYYVpz3464h2azx6675MXuFBIh4=.20a87de0-9594-4edf-aa12-435465344961@github.com>
Message-ID: <mpog2C7EA6_8ctN7wNlzv66YuoOqKnqREvJPkn-BY_o=.c5f375f9-e55a-4a49-9417-720e82ece9e3@github.com>

On Fri, 15 Mar 2024 15:21:23 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>> It could be obvious from the usage? so we may skip the header altogether? if it's mentioned in the instructions, which should still be mentioned to let the test know they need to look for the messages.
>
>> Placeholder text isn't supported by Swing natively, is it?  Therefore, you'll have to remove the placeholder text when you add the first message, which complicates logging a message.
> 
> It is not a big overhead, e.g. I already did it by slightly changing the `log()` method. `logClear()` and `logSet()` are untouched.

Yep, I see it. I'm still inclined for going without the header or placeholder.

Handling the placeholder text converts a one-liner into six lines of code. And I'm unsure the placeholder improves the tester experience?

I may be overthinking? in which case *no header* and *no placeholder* seem a better option.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18319#discussion_r1526467731

From duke at openjdk.org  Fri Mar 15 15:50:48 2024
From: duke at openjdk.org (lawrence.andrews)
Date: Fri, 15 Mar 2024 15:50:48 GMT
Subject: RFR: 8328242: Add a log area to the PassFailJFrame [v2]
In-Reply-To: <R0NXnSzFwyi6_YPIqtqAhjqYOaf8uUhN27bfnd1q10o=.af879c35-96f9-4302-ac31-063b88d2a447@github.com>
References: <c2nhXjjZerGqDlD3X3gInMwiJ3ng1vsR0AKnmabksPE=.649bf743-3372-4218-939a-84caea3fae71@github.com>
 <MGlPezQt9YlsX7VfML-0RhpyP1pDlHhmIjn5_8P0Aeg=.a189c584-52ae-41d4-8881-802d89a1fdfd@github.com>
 <sSu-_inBJhvfHYAMRDJmEtbY_XDlkPXFvwT3xj4tGfc=.6f7c1746-7e6b-4c11-87e9-14355bdc0a5e@github.com>
 <gb9kYdPLcdJulXKIK49OR_hj_mcxLL_Mysfhi3RMUdE=.6bee44dc-d025-4731-bb62-5e73390b599c@github.com>
 <bhvk0Nf1-AbbCM0f48pVTiouNE8diYhkSSWp6CH5Fxc=.05a8ccdf-a1b6-4581-9f0c-d0e3d58afddf@github.com>
 <QcyhPJ3FYVvEo7IGH2up48br3lkZ23Y3W0NuRQVhg5c=.baedd08f-0caf-4d12-99fe-ffbf4df4d142@github.com>
 <R0NXnSzFwyi6_YPIqtqAhjqYOaf8uUhN27bfnd1q10o=.af879c35-96f9-4302-ac31-063b88d2a447@github.com>
Message-ID: <3BKHgxf_SDGUCHcRwsxw9LMBSv8pGmqDgW0ijk10uRE=.38f0773c-6209-4b87-825b-9316f8d25138@github.com>

On Fri, 15 Mar 2024 15:42:42 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> 'Clear log' button calling logClear().
>
> @lawrence-andrew I can't see much value?
> 
> Capturing logs by a screenshot is not something that you should ever do ? copy the messages and paste them as text into a bug report.
> 
> However, you've raised a good point: the log messages could / should be copied to System.out too.
> 
> If a test fails, the logs will already be available in the test log, and the tester will not need to copy the log to preserve the messages for submitting the bug. The .jtr file from jtreg will contain all the information.
> 
> When submitting a bug, you would filter the log and paste the relevant pieces into the bug report.

My original intention was to filter the log and paste the relevant pieces into the bug report. But I used screen shot as an example. Thanks

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18319#discussion_r1526486701

From prr at openjdk.org  Sat Mar 16 22:18:50 2024
From: prr at openjdk.org (Phil Race)
Date: Sat, 16 Mar 2024 22:18:50 GMT
Subject: RFR: 8328300: Convert PrintDialogsTest.java from Applet to main
 program
Message-ID: <awEafcUuB7m-r62HTUPpL9DsuGnRuT1czVoirtsYJRI=.725d3d5f-04f9-4012-bcc3-a8e7d157f07f@github.com>

This applet test is converted to a main program using PassFailJFrame.
Other than that, the main thing I improved is the instructions.

-------------

Commit messages:
 - 8328300
 - 8328300
 - 8328300

Changes: https://git.openjdk.org/jdk/pull/18333/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18333&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8328300
  Stats: 124 lines in 2 files changed: 63 ins; 54 del; 7 mod
  Patch: https://git.openjdk.org/jdk/pull/18333.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18333/head:pull/18333

PR: https://git.openjdk.org/jdk/pull/18333

From honkar at openjdk.org  Sat Mar 16 22:18:44 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Sat, 16 Mar 2024 22:18:44 GMT
Subject: RFR: JDK-8328299 : Convert DnDFileGroupDescriptor.html applet test to
 main
Message-ID: <CTOJXaNDso7Gmw-A2kTkmsZmAWqcWllOim2Y_BGgeok=.5d62efd5-66c2-47a7-b1f0-c10f4c366b40@github.com>

Following test java/awt/dnd/DnDFileGroupDescriptor/DnDFileGroupDescriptor.html is converted to main using PassFailJFrame.

This test is currently problem-listed on macOS and linux, but as per the previous JBS bugs [[JDK-6242241](https://bugs.openjdk.org/browse/JDK-6242241), [JDK-8080185](https://bugs.openjdk.org/browse/JDK-8080185), [JDK-7147083](https://bugs.openjdk.org/browse/JDK-7147083)] this test was original created for testing DnD of MS Outlook attachments on Windows system.

Based on the test history and JBS details, I believe this should be windows-only test and should NOT be problemlisted on macOS and linux as it is **not applicable**.

-------------

Commit messages:
 - typo
 - windows check added
 - EOF newline added
 - problemlist.txt changes

Changes: https://git.openjdk.org/jdk/pull/18335/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18335&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8328299
  Stats: 266 lines in 3 files changed: 44 ins; 187 del; 35 mod
  Patch: https://git.openjdk.org/jdk/pull/18335.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18335/head:pull/18335

PR: https://git.openjdk.org/jdk/pull/18335

From serb at openjdk.org  Sat Mar 16 22:18:54 2024
From: serb at openjdk.org (Sergey Bylokhov)
Date: Sat, 16 Mar 2024 22:18:54 GMT
Subject: RFR: 8328194: Add a test to check default rendering engine
Message-ID: <xxsxmOwVdXyBrSIp2WwIQ3_RvWLBL5KORk_X6bNkAnU=.588f07e6-2967-4d9e-a780-046af14d2ca1@github.com>

This is a request to forward port the test added by the [JDK-8241307](https://bugs.openjdk.org/browse/JDK-8241307) with inverted condition - jdk jdk11 the marlin should be used by default.

-------------

Commit messages:
 - Create DefaultRenderingEngine.java

Changes: https://git.openjdk.org/jdk/pull/18313/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18313&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8328194
  Stats: 42 lines in 1 file changed: 42 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18313.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18313/head:pull/18313

PR: https://git.openjdk.org/jdk/pull/18313

From honkar at openjdk.org  Sat Mar 16 22:18:48 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Sat, 16 Mar 2024 22:18:48 GMT
Subject: RFR: JDK-8328299 : Convert DnDFileGroupDescriptor.html applet test
 to main
In-Reply-To: <CTOJXaNDso7Gmw-A2kTkmsZmAWqcWllOim2Y_BGgeok=.5d62efd5-66c2-47a7-b1f0-c10f4c366b40@github.com>
References: <CTOJXaNDso7Gmw-A2kTkmsZmAWqcWllOim2Y_BGgeok=.5d62efd5-66c2-47a7-b1f0-c10f4c366b40@github.com>
Message-ID: <JMSgb5T4kBS4vbQUOgin4jajdDd9xSqFOUm9eExUP44=.9d01c4da-1d84-49e4-b0c0-a7bb874a643d@github.com>

On Fri, 15 Mar 2024 22:54:23 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

> Following test java/awt/dnd/DnDFileGroupDescriptor/DnDFileGroupDescriptor.html is converted to main using PassFailJFrame.
> 
> This test is currently problem-listed on macOS and linux, but as per the previous JBS bugs [[JDK-6242241](https://bugs.openjdk.org/browse/JDK-6242241), [JDK-8080185](https://bugs.openjdk.org/browse/JDK-8080185), [JDK-7147083](https://bugs.openjdk.org/browse/JDK-7147083)] this test was original created for testing DnD of MS Outlook attachments on Windows system.
> 
> Based on the test history and JBS details, I believe this should be windows-only test and should NOT be problemlisted on macOS and linux as it is **not applicable**.

test/jdk/ProblemList.txt line 788:

> 786: java/awt/xembed/server/TestXEmbedServerJava.java 8001150,8004031 generic-all
> 787: java/awt/Modal/PrintDialogsTest/PrintDialogsTest.java 8068378 generic-all
> 788: java/awt/dnd/DnDFileGroupDescriptor/DnDFileGroupDescriptor.java 8080185 macosx-all,linux-all

@prsadhuk While looking into the test history I noticed you had previous worked on it PR https://github.com/openjdk/jdk/pull/3406, it wasn't integrated though. Any thoughts whether to make this test windows-only or extend the test to other platforms ?

Your previous PR description sounds correct, when I went through the related test bugs it seemed like the test was created for windows-only issue.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18335#discussion_r1526942638

From prr at openjdk.org  Sat Mar 16 22:18:56 2024
From: prr at openjdk.org (Phil Race)
Date: Sat, 16 Mar 2024 22:18:56 GMT
Subject: RFR: 8328194: Add a test to check default rendering engine
In-Reply-To: <xxsxmOwVdXyBrSIp2WwIQ3_RvWLBL5KORk_X6bNkAnU=.588f07e6-2967-4d9e-a780-046af14d2ca1@github.com>
References: <xxsxmOwVdXyBrSIp2WwIQ3_RvWLBL5KORk_X6bNkAnU=.588f07e6-2967-4d9e-a780-046af14d2ca1@github.com>
Message-ID: <wLJ2MjVk-CoAO31dEvaoY7-BCgw6yQYutiX01vsGsZA=.2d3cf6fc-0064-4985-b3be-616f9ba99085@github.com>

On Thu, 14 Mar 2024 20:13:58 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

> This is a request to forward port the test added by the [JDK-8241307](https://bugs.openjdk.org/browse/JDK-8241307) with inverted condition - jdk jdk11 the marlin should be used by default.

We don't have any others in JDK 23, so I am not sure what this test does for us.
Also if there *are* alternatives, then the test should only fail if those alternatives aren't selected.
Like if there was pisces and sun.java2d.renderingengine=pisces, then surely the test should not fail ?
But I guess that part is OK for this test, since it controls "main" and will be othervm mode.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18313#issuecomment-2002141009

From aturbanov at openjdk.org  Sat Mar 16 22:18:53 2024
From: aturbanov at openjdk.org (Andrey Turbanov)
Date: Sat, 16 Mar 2024 22:18:53 GMT
Subject: RFR: JDK-8328299 : Convert DnDFileGroupDescriptor.html applet test
 to main
In-Reply-To: <CTOJXaNDso7Gmw-A2kTkmsZmAWqcWllOim2Y_BGgeok=.5d62efd5-66c2-47a7-b1f0-c10f4c366b40@github.com>
References: <CTOJXaNDso7Gmw-A2kTkmsZmAWqcWllOim2Y_BGgeok=.5d62efd5-66c2-47a7-b1f0-c10f4c366b40@github.com>
Message-ID: <Q2IjKmUqkYFs0XdPyxVcLmEtCAsLCOz07xOEshCEYT0=.df104127-4d81-481f-9b64-d60fa14e2500@github.com>

On Fri, 15 Mar 2024 22:54:23 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

> Following test java/awt/dnd/DnDFileGroupDescriptor/DnDFileGroupDescriptor.html is converted to main using PassFailJFrame.
> 
> This test is currently problem-listed on macOS and linux, but as per the previous JBS bugs [[JDK-6242241](https://bugs.openjdk.org/browse/JDK-6242241), [JDK-8080185](https://bugs.openjdk.org/browse/JDK-8080185), [JDK-7147083](https://bugs.openjdk.org/browse/JDK-7147083)] this test was original created for testing DnD of MS Outlook attachments on Windows system.
> 
> Based on the test history and JBS details, I believe this should be windows-only test and should NOT be problemlisted on macOS and linux as it is **not applicable**.

test/jdk/java/awt/dnd/DnDFileGroupDescriptor/DnDFileGroupDescriptor.java line 84:

> 82: 
> 83:         frame.add(mainPanel);
> 84:         frame.setSize(400,200);

Suggestion:

        frame.setSize(400, 200);

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18335#discussion_r1527142182

From aivanov at openjdk.org  Sat Mar 16 22:19:10 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Sat, 16 Mar 2024 22:19:10 GMT
Subject: RFR: 8305072: Win32ShellFolder2.compareTo is inconsistent [v2]
In-Reply-To: <5btT_N4c5R89DQ8aoSyjm6lIR7PHLWC141uAIdH_Bjw=.f36326e9-0f59-4545-82bf-f3c8b4dbaa87@github.com>
References: <bEiHvkFnBZDqmiqQdk_-_mATVhDbAD7NZX7VnkHLG2E=.27ee84ba-00fd-405a-9489-8fe11c215af9@github.com>
 <21db5CiFTVN7scwsIHknMxF4YaVQd06m7gUOhcCLvMI=.e2f61ea7-bf9a-4632-bf45-c89f979ae806@github.com>
 <6dQg9rhDwh4ZL7D2JfYpA0xNP_eJDbOK3rNgj7efckM=.c5001d8a-cce5-4a11-a91d-eda8e90b8056@github.com>
 <76BSt4HYmTD2DiZzBUvNvBdvd5d1MFinIDsgp2YuHjs=.68646608-e266-4ca3-8495-59e237f8607c@github.com>
 <5btT_N4c5R89DQ8aoSyjm6lIR7PHLWC141uAIdH_Bjw=.f36326e9-0f59-4545-82bf-f3c8b4dbaa87@github.com>
Message-ID: <O50uV-2r3dt50V8SWvG8-hefuMVYMgpa3Kbn4L-eKxg=.ab496041-3ad6-4b2d-8d04-f4ff200eb0be@github.com>

On Thu, 14 Mar 2024 16:56:03 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> It is well described in a [JBS comment](https://bugs.openjdk.org/browse/JDK-8305072?focusedId=14610400&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14610400) by the submitter.
>> 
>> Let's consider the failing case where:
>> 
>> a = C:\Users<user>\Documents(true)
>> b = C:\Users<user>(false)
>> c = C:\Users<user>\Documents(false)
>> 
>> The value in parentheses is `isSpecial()` flag.
>> 
>> When `a` and `c` are compared, `special1 = true` and `special2 = false`, therefore the code flow enters this `if`-block. Because the `equals` method doesn't take into account the `isSpecial` flag, both `i1` and `i2` are 0.
>> 
>> https://github.com/openjdk/jdk/blob/7bccc847fe9e8c5e640d8fa9c93ce32563a0ccfa/src/java.desktop/windows/classes/sun/awt/shell/Win32ShellFolderManager2.java#L534-L535
>> 
>> Thus, `a` and `c` are considered equal, which breaks the general contract of [`Comparable.compareTo`](https://docs.oracle.com/en/java/javase/21/docs/api/java.base/java/lang/Comparable.html#compareTo(T)).
>> 
>> If you look below this `if`-statement:
>> 
>> https://github.com/openjdk/jdk/blob/7bccc847fe9e8c5e640d8fa9c93ce32563a0ccfa/src/java.desktop/windows/classes/sun/awt/shell/Win32ShellFolderManager2.java#L545-L550
>> 
>> The comment and the code say that any special folder sorts above any regular folder. Therefore the code shouldn't enter that `if`-block above if *only one* of the folders is *special* ? the order is already well-defined for such case.
>> 
>> The purpose of the `if`-block is to make some of the special folders even more special. In other words, it ensures the following special folders?`getPersonal`, `getDesktop`, `getDrives`, `getNetwork`?are at the top of the list, above any other special folders.
>
> So, changing the condition in the `if`-block from `special1 || special2` to `special1 && special2` makes the sorting order consistent because the relation is now *transitive*:
> 
> 
> a < b & b < c therefore a < c

@uckelman, Your message is hidden until you accept OpenJDK Terms of Use.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18126#discussion_r1526738043

From prr at openjdk.org  Sat Mar 16 22:18:58 2024
From: prr at openjdk.org (Phil Race)
Date: Sat, 16 Mar 2024 22:18:58 GMT
Subject: RFR: 8328301: Convert Applet test ManualHTMLDataFlavorTest.java to
 main program
Message-ID: <ezZp85g1cKWnR1M7apMh6bxP2_G6P9O5tN6DTSQEOU4=.951f4e5d-e956-4af8-b4f1-725c667224b5@github.com>

Convert this applet based test to a main program

-------------

Commit messages:
 - 8328301

Changes: https://git.openjdk.org/jdk/pull/18334/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18334&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8328301
  Stats: 260 lines in 2 files changed: 15 ins; 189 del; 56 mod
  Patch: https://git.openjdk.org/jdk/pull/18334.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18334/head:pull/18334

PR: https://git.openjdk.org/jdk/pull/18334

From honkar at openjdk.org  Sat Mar 16 22:19:06 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Sat, 16 Mar 2024 22:19:06 GMT
Subject: RFR: 8328301: Convert Applet test ManualHTMLDataFlavorTest.java to
 main program
In-Reply-To: <ezZp85g1cKWnR1M7apMh6bxP2_G6P9O5tN6DTSQEOU4=.951f4e5d-e956-4af8-b4f1-725c667224b5@github.com>
References: <ezZp85g1cKWnR1M7apMh6bxP2_G6P9O5tN6DTSQEOU4=.951f4e5d-e956-4af8-b4f1-725c667224b5@github.com>
Message-ID: <VQRx1VHO9Ksr-SB8zgf2gdqI4cVh5LGogYPHqyZPIoQ=.000fcb4c-e824-4321-88a9-e86cde0009ea@github.com>

On Fri, 15 Mar 2024 22:32:12 GMT, Phil Race <prr at openjdk.org> wrote:

> Convert this applet based test to a main program

test/jdk/java/awt/datatransfer/HTMLDataFlavors/ManualHTMLDataFlavorTest.java line 27:

> 25:   @test
> 26:   @bug 7075105
> 27:   @summary WIN: Provide a way to format HTML on drop

Do we add `@requires (os.family == "windows")` since the test summary indicates Windows issue?

test/jdk/java/awt/datatransfer/HTMLDataFlavors/ManualHTMLDataFlavorTest.java line 143:

> 141:         frame.add(new DropPane());
> 142:         frame.pack();
> 143:         return frame;

Changes looks good expect that when the the test is started and I switch to the browser window the drop target frame goes behind and becomes difficult to drag and drop to the Red panel.

Setting `frame.setAlwaysOnTop(true)` will ensure that the DnD panel is on top.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18334#discussion_r1527001893
PR Review Comment: https://git.openjdk.org/jdk/pull/18334#discussion_r1526997015

From aturbanov at openjdk.org  Sat Mar 16 22:19:11 2024
From: aturbanov at openjdk.org (Andrey Turbanov)
Date: Sat, 16 Mar 2024 22:19:11 GMT
Subject: RFR: 8328301: Convert Applet test ManualHTMLDataFlavorTest.java to
 main program
In-Reply-To: <ezZp85g1cKWnR1M7apMh6bxP2_G6P9O5tN6DTSQEOU4=.951f4e5d-e956-4af8-b4f1-725c667224b5@github.com>
References: <ezZp85g1cKWnR1M7apMh6bxP2_G6P9O5tN6DTSQEOU4=.951f4e5d-e956-4af8-b4f1-725c667224b5@github.com>
Message-ID: <6a3gk6l9Y5taEtc_Mp7y9IPfcjPNTOCSYWg1liUz5jY=.cf77bcab-e8aa-4bb9-a869-608bf7615f32@github.com>

On Fri, 15 Mar 2024 22:32:12 GMT, Phil Race <prr at openjdk.org> wrote:

> Convert this applet based test to a main program

test/jdk/java/awt/datatransfer/HTMLDataFlavors/ManualHTMLDataFlavorTest.java line 60:

> 58:         @Override
> 59:         public Dimension getPreferredSize() {
> 60:             return new Dimension(400,400);

Suggestion:

            return new Dimension(400, 400);

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18334#discussion_r1527142240

From kizune at openjdk.org  Sat Mar 16 22:19:16 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Sat, 16 Mar 2024 22:19:16 GMT
Subject: RFR: 8328279: Convert java/awt/Cursor/CursorOverlappedPanelsTest test
 to main
Message-ID: <l6NLWusbqshFG9pUWWsoatnBo79fRPWVqtjLmkd3gTo=.7ca881bb-6874-4328-acb6-0b895df0e56e@github.com>

Converted to a main manual test.

-------------

Commit messages:
 - Correct the run clause of the test
 - Added a line to separate two methods
 - 8328279: Convert java/awt/Cursor/CursorOverlappedPanelsTest test to main

Changes: https://git.openjdk.org/jdk/pull/18331/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18331&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8328279
  Stats: 349 lines in 3 files changed: 91 ins; 258 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18331.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18331/head:pull/18331

PR: https://git.openjdk.org/jdk/pull/18331

From honkar at openjdk.org  Sat Mar 16 22:19:32 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Sat, 16 Mar 2024 22:19:32 GMT
Subject: RFR: 8328279: Convert java/awt/Cursor/CursorOverlappedPanelsTest
 test to main
In-Reply-To: <l6NLWusbqshFG9pUWWsoatnBo79fRPWVqtjLmkd3gTo=.7ca881bb-6874-4328-acb6-0b895df0e56e@github.com>
References: <l6NLWusbqshFG9pUWWsoatnBo79fRPWVqtjLmkd3gTo=.7ca881bb-6874-4328-acb6-0b895df0e56e@github.com>
Message-ID: <DDSPj7NePJT9gWgUgPf9Q42p1CGnPX5NSQl22KdlAzc=.80b30b8c-6004-421a-876c-33dd946fea5b@github.com>

On Fri, 15 Mar 2024 16:13:33 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

> Converted to a main manual test.

test/jdk/java/awt/Cursor/CursorOverlappedPanelsTest.java line 34:

> 32: import javax.swing.JPanel;
> 33: 
> 34: /**

Suggestion:

/*

test/jdk/java/awt/Cursor/CursorOverlappedPanelsTest.java line 56:

> 54:         frame.getContentPane().add(layeredPane);
> 55:         frame.pack();
> 56:         frame.setVisible(true);

frame.setVisible(true) can be removed, this avoid the test pane to appear initially at a different location and then switch the final location, additionally PassFailJFrame handles it.

test/jdk/java/awt/Cursor/CursorOverlappedPanelsTest.java line 85:

> 83:                 .title("Overlapping Panels Cursor Test Instructions")
> 84:                 .instructions(instructions)
> 85:                 .rows(4)

May be 5-6 rows looks better for the instruction length.
Using the below format avoids the need to specify a hardcoded row count number :)

Suggestion:

                .rows((int) instructions.lines().count() + 1)

test/jdk/java/awt/Cursor/CursorOverlappedPanelsTest.java line 91:

> 89:                 .awaitAndCheck();
> 90:     }
> 91: }

EOF newline missing.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18331#discussion_r1527004319
PR Review Comment: https://git.openjdk.org/jdk/pull/18331#discussion_r1527005718
PR Review Comment: https://git.openjdk.org/jdk/pull/18331#discussion_r1527007416
PR Review Comment: https://git.openjdk.org/jdk/pull/18331#discussion_r1527005886

From ihse at openjdk.org  Sat Mar 16 22:20:51 2024
From: ihse at openjdk.org (Magnus Ihse Bursie)
Date: Sat, 16 Mar 2024 22:20:51 GMT
Subject: RFR: 8325163: Enable -Wpedantic on clang [v2]
In-Reply-To: <qja7u1WGpMGYvymUwKDAfovke8Kplizcby_j0hNN-r4=.9a3603e4-1446-4b57-9059-7553d21c64a1@github.com>
References: <vXYByM6yWkaXbcmeoVEFhax5Ttw-oWqcckV8kFGnKug=.ea49e50a-7734-43af-84a9-f89652fc71f6@github.com>
 <qja7u1WGpMGYvymUwKDAfovke8Kplizcby_j0hNN-r4=.9a3603e4-1446-4b57-9059-7553d21c64a1@github.com>
Message-ID: <rgKpveCfonVCT7TsHXysUeDBuYrb28aW0QRhlt1P6Lw=.6cca9703-7335-42b7-8d8b-d871b3e54e55@github.com>

On Mon, 5 Feb 2024 10:58:17 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> Inspired by (the later backed-out) [JDK-8296115](https://bugs.openjdk.org/browse/JDK-8296115), I propose to enable `-Wpedantic` for clang. This has already found some irregularities in the code, like mistakenly using `#import` instead of `#include`. In this patch, I disable warnings for these individual buggy or badly written files, but I intend to post follow-up issues on the respective teams to have them properly fixed.
>> 
>> Unfortunately, it is not possible to enable `-Wpedantic` on gcc, since individual warnings in `-Wpedantic` cannot be disabled. This means that code like this:
>> 
>> 
>> #define DEBUG_ONLY(code) code;
>> 
>> DEBUG_ONLY(foo());
>> 
>> 
>> will result in a `; ;`. This breaks the C standard, but is benign, and we use it all over the place. On clang, we can ignore this by `-Wno-extra-semi`, but this is not available on gcc.
>
> Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:
> 
>   FIx dtrace build

Keep it for a bit more, bot.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17687#issuecomment-2000843635

From honkar at openjdk.org  Sat Mar 16 22:34:10 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Sat, 16 Mar 2024 22:34:10 GMT
Subject: RFR: JDK-8328190 : Convert AWTPanelSmoothWheel.html applet test to
 main [v3]
In-Reply-To: <sn9qb9ctS_sr3isHbwcbMCYh2RQokz2ptsw0rGBRnJY=.955d7549-72c7-4a4f-8ac8-a5d6f122cf68@github.com>
References: <sn9qb9ctS_sr3isHbwcbMCYh2RQokz2ptsw0rGBRnJY=.955d7549-72c7-4a4f-8ac8-a5d6f122cf68@github.com>
Message-ID: <MPJgRPFs3q9yLE9tiHUrRqh-dPdkg_Kqwf9u1CfuS-8=.7e4e33f7-d775-446a-aeef-8a126f4dba4a@github.com>

> This test is converted to main using PassFailJFrame. It verifies wheel rotation value for high-res mouse on windows.
> 
> The test requires the updated PassFailJFrame's logArea() feature added in this PR https://github.com/openjdk/jdk/pull/18319

Harshitha Onkar has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 10 additional commits since the last revision:

 - used PassFailJFrame.logArea()
 - Merge branch 'master' into WheelRotation_8328190
 - ordering of imports
 - whitespace removed
 - default timeout used
 - @requires tag
 - title change
 - converted test to main
 - delete .html file
 - moved test file

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18312/files
  - new: https://git.openjdk.org/jdk/pull/18312/files/627ec863..a2b9b95a

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18312&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18312&range=01-02

  Stats: 4580 lines in 85 files changed: 2040 ins; 2125 del; 415 mod
  Patch: https://git.openjdk.org/jdk/pull/18312.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18312/head:pull/18312

PR: https://git.openjdk.org/jdk/pull/18312

From honkar at openjdk.org  Sat Mar 16 22:34:22 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Sat, 16 Mar 2024 22:34:22 GMT
Subject: RFR: JDK-8328190 : Convert AWTPanelSmoothWheel.html applet test to
 main [v2]
In-Reply-To: <WKAY4W7HpBPciFiIFaiXUkU3MSnQPkF2dRL0wQTnHpM=.58e661c4-9df2-4586-a029-0b1604cac9c1@github.com>
References: <sn9qb9ctS_sr3isHbwcbMCYh2RQokz2ptsw0rGBRnJY=.955d7549-72c7-4a4f-8ac8-a5d6f122cf68@github.com>
 <WKAY4W7HpBPciFiIFaiXUkU3MSnQPkF2dRL0wQTnHpM=.58e661c4-9df2-4586-a029-0b1604cac9c1@github.com>
Message-ID: <1K3b9xSaMO26iqig-NCkqHiB1c3uZWI_Qf7Dsj2_Lpg=.061f023a-f2bc-439d-bd4e-1fbb57d7e392@github.com>

On Thu, 14 Mar 2024 21:02:50 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> This test is converted to main using PassFailJFrame. It verifies wheel rotation value for high-res mouse on windows.
>> 
>> The test requires the updated PassFailJFrame's logArea() feature added in this PR https://github.com/openjdk/jdk/pull/18319
>
> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   ordering of imports

This PR has been updated to use PassFailJFrame's new logArea() feature.
@azvegint @aivanov-jdk Please review.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18312#issuecomment-2000427947

From aturbanov at openjdk.org  Sat Mar 16 22:34:25 2024
From: aturbanov at openjdk.org (Andrey Turbanov)
Date: Sat, 16 Mar 2024 22:34:25 GMT
Subject: RFR: JDK-8328190 : Convert AWTPanelSmoothWheel.html applet test to
 main [v3]
In-Reply-To: <MPJgRPFs3q9yLE9tiHUrRqh-dPdkg_Kqwf9u1CfuS-8=.7e4e33f7-d775-446a-aeef-8a126f4dba4a@github.com>
References: <sn9qb9ctS_sr3isHbwcbMCYh2RQokz2ptsw0rGBRnJY=.955d7549-72c7-4a4f-8ac8-a5d6f122cf68@github.com>
 <MPJgRPFs3q9yLE9tiHUrRqh-dPdkg_Kqwf9u1CfuS-8=.7e4e33f7-d775-446a-aeef-8a126f4dba4a@github.com>
Message-ID: <D4vUVfbXwRHlqF-e4oRyAGeNj2og_QHbqDv3h4nCADI=.ddb891c5-da9c-4dbf-b8b0-dbdd003d9983@github.com>

On Sat, 16 Mar 2024 09:36:57 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> This test is converted to main using PassFailJFrame. It verifies wheel rotation value for high-res mouse on windows.
>> 
>> The test requires the updated PassFailJFrame's logArea() feature added in this PR https://github.com/openjdk/jdk/pull/18319
>
> Harshitha Onkar has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 10 additional commits since the last revision:
> 
>  - used PassFailJFrame.logArea()
>  - Merge branch 'master' into WheelRotation_8328190
>  - ordering of imports
>  - whitespace removed
>  - default timeout used
>  - @requires tag
>  - title change
>  - converted test to main
>  - delete .html file
>  - moved test file

test/jdk/java/awt/event/MouseEvent/AWTPanelSmoothWheel.java line 71:

> 69:         panel.setBackground(Color.GREEN);
> 70:         panel.addMouseWheelListener(e -> PassFailJFrame.log(e.toString()));
> 71:         frame.setSize (200,200);

Suggestion:

        frame.setSize(200, 200);

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18312#discussion_r1527142345

From honkar at openjdk.org  Sat Mar 16 22:35:16 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Sat, 16 Mar 2024 22:35:16 GMT
Subject: RFR: JDK-8328012 : Convert InputMethod (/java/awt/im) applet tests
 to main [v5]
In-Reply-To: <iDY1JdxeSzLcbW-ASx1PylUqKY-kGUjMj8tr4Sj5NDM=.a0b9fbdb-a959-4e98-ae08-d086fd8f210f@github.com>
References: <iDY1JdxeSzLcbW-ASx1PylUqKY-kGUjMj8tr4Sj5NDM=.a0b9fbdb-a959-4e98-ae08-d086fd8f210f@github.com>
Message-ID: <wy9bLFymQ0_gqjxVqgIhc7s5Q3QHFC17th2FkmbLIB4=.be7612dc-904d-457e-b2df-fee9c73cf6c1@github.com>

> Following InputMethod applet tests are converted to main using PassFailJFrame
> 
> 1. java/awt/im/8132503/bug8132503.java (Renamed to PinyinIMFullstopTest.java)
> 2. java/awt/im/8148984/bug8148984.java (Renamed to PinyinIMCommaTest.java) 
> 
> - test instructions are updated to make to more clear
> - tests renamed 
> - moved one directory above - /java/awt/im/
> - html file deleted.
> 
> Two tests are updated as part of this PR as they are similar, details here https://github.com/openjdk/jdk/pull/18251#issuecomment-1992577598

Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:

  review updates

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18251/files
  - new: https://git.openjdk.org/jdk/pull/18251/files/67acd86f..19fa3fe8

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18251&range=04
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18251&range=03-04

  Stats: 12 lines in 2 files changed: 1 ins; 1 del; 10 mod
  Patch: https://git.openjdk.org/jdk/pull/18251.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18251/head:pull/18251

PR: https://git.openjdk.org/jdk/pull/18251

From tr at openjdk.org  Sat Mar 16 22:35:17 2024
From: tr at openjdk.org (Tejesh R)
Date: Sat, 16 Mar 2024 22:35:17 GMT
Subject: RFR: JDK-8328012 : Convert InputMethod (/java/awt/im) applet tests
 to main [v5]
In-Reply-To: <wy9bLFymQ0_gqjxVqgIhc7s5Q3QHFC17th2FkmbLIB4=.be7612dc-904d-457e-b2df-fee9c73cf6c1@github.com>
References: <iDY1JdxeSzLcbW-ASx1PylUqKY-kGUjMj8tr4Sj5NDM=.a0b9fbdb-a959-4e98-ae08-d086fd8f210f@github.com>
 <wy9bLFymQ0_gqjxVqgIhc7s5Q3QHFC17th2FkmbLIB4=.be7612dc-904d-457e-b2df-fee9c73cf6c1@github.com>
Message-ID: <6OSCK1-XBHdW8oqHeK9LSJjwMAfSJ7GqyDeC2Oq_aJE=.5a5a2cb2-ecce-4ce8-9cc0-dceb8eb53825@github.com>

On Sat, 16 Mar 2024 22:19:36 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Following InputMethod applet tests are converted to main using PassFailJFrame
>> 
>> 1. java/awt/im/8132503/bug8132503.java (Renamed to PinyinIMFullstopTest.java)
>> 2. java/awt/im/8148984/bug8148984.java (Renamed to PinyinIMCommaTest.java) 
>> 
>> - test instructions are updated to make to more clear
>> - tests renamed 
>> - moved one directory above - /java/awt/im/
>> - html file deleted.
>> 
>> Two tests are updated as part of this PR as they are similar, details here https://github.com/openjdk/jdk/pull/18251#issuecomment-1992577598
>
> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   review updates

Marked as reviewed by tr (Committer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18251#pullrequestreview-1940991012

From tr at openjdk.org  Sat Mar 16 22:35:29 2024
From: tr at openjdk.org (Tejesh R)
Date: Sat, 16 Mar 2024 22:35:29 GMT
Subject: RFR: 8327840: Automate javax/swing/border/Test4129681.java
Message-ID: <BbQ2iwy01dkTxtQ9Aj7RhRkSxWm3pq3BEIlGIzlSTCk=.7bdaafe4-681a-4f03-8462-4ffa7dc99507@github.com>

Automated the Test `javax/swing/border/Test4129681.java` from manual as suggested in JBS description.
Verified in CI system and its Green. The test has been verified for Metal L&F and the same is set explicitly..

-------------

Commit messages:
 - Test converted to automated

Changes: https://git.openjdk.org/jdk/pull/18336/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18336&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8327840
  Stats: 60 lines in 1 file changed: 24 ins; 11 del; 25 mod
  Patch: https://git.openjdk.org/jdk/pull/18336.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18336/head:pull/18336

PR: https://git.openjdk.org/jdk/pull/18336

From honkar at openjdk.org  Sat Mar 16 22:35:19 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Sat, 16 Mar 2024 22:35:19 GMT
Subject: RFR: JDK-8328012 : Convert InputMethod (/java/awt/im) applet tests
 to main [v4]
In-Reply-To: <2Ei6cim7yoEWHTzirrQ8TbqcAIjY2shmstPaXcoUGIg=.a8774df0-5d69-45f7-bc79-6d0856fb56e1@github.com>
References: <iDY1JdxeSzLcbW-ASx1PylUqKY-kGUjMj8tr4Sj5NDM=.a0b9fbdb-a959-4e98-ae08-d086fd8f210f@github.com>
 <oadTMu4xuH37vGnNOY1TXF6dJTwx5-nA0gNWtQCKFf4=.3f7711ea-7b32-4ad3-8e1b-536a8757aa28@github.com>
 <2Ei6cim7yoEWHTzirrQ8TbqcAIjY2shmstPaXcoUGIg=.a8774df0-5d69-45f7-bc79-6d0856fb56e1@github.com>
Message-ID: <oJytG-WbygQEwNYE2K9mMGgCcMEYfFjT-LeJWvbA2bM=.b9c46efe-6300-4889-b420-76a8339caab8@github.com>

On Thu, 14 Mar 2024 04:43:48 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   instruction updated
>
> test/jdk/java/awt/im/PinyinIMCommaTest.java line 44:
> 
>> 42: 
>> 43: public class PinyinIMCommaTest {
>> 44:     private static final String INSTRUCTIONS = """
> 
> `INSTRUCTIONS ` can be moved inside main  (Other test also)

Since it is okay to have it either as static var or within main, I'm going to leave it as it is now.

> test/jdk/java/awt/im/PinyinIMCommaTest.java line 82:
> 
>> 80:         JTextField input = new JTextField(20);
>> 81:         panel.add(new JLabel("Text field:"));
>> 82:         panel.add(input);
> 
> can add JTextField also this way `panel.add(new JTextField(20));`?

Updated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18251#discussion_r1526685355
PR Review Comment: https://git.openjdk.org/jdk/pull/18251#discussion_r1526685550

From honkar at openjdk.org  Sat Mar 16 22:35:21 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Sat, 16 Mar 2024 22:35:21 GMT
Subject: RFR: JDK-8328012 : Convert InputMethod (/java/awt/im) applet tests
 to main [v4]
In-Reply-To: <jZpj-paG-TRIN44h9NoJkg2F--_cYhfFa7ZceGm-FCM=.489836e0-0787-4f6d-bfe4-fcb2afd947ce@github.com>
References: <iDY1JdxeSzLcbW-ASx1PylUqKY-kGUjMj8tr4Sj5NDM=.a0b9fbdb-a959-4e98-ae08-d086fd8f210f@github.com>
 <oadTMu4xuH37vGnNOY1TXF6dJTwx5-nA0gNWtQCKFf4=.3f7711ea-7b32-4ad3-8e1b-536a8757aa28@github.com>
 <jZpj-paG-TRIN44h9NoJkg2F--_cYhfFa7ZceGm-FCM=.489836e0-0787-4f6d-bfe4-fcb2afd947ce@github.com>
Message-ID: <2IRH2uQkvLYtmIvk8Qxp70EikTWgmSDnndFAZKscfOI=.c6d39b29-e3c8-407e-b23d-e4e107799027@github.com>

On Wed, 13 Mar 2024 17:45:28 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   instruction updated
>
> test/jdk/java/awt/im/PinyinIMFullstopTest.java line 81:
> 
>> 79:     private static JComponent createUI() {
>> 80:         JPanel panel = new JPanel();
>> 81:         JTextField input = new JTextField(20);
> 
> Is there a specific reason why we switched from a text area to a text field?

I have updated it to JTextArea as per the original test. Missed it earlier.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18251#discussion_r1526683784

From serb at openjdk.org  Sun Mar 17 08:56:33 2024
From: serb at openjdk.org (Sergey Bylokhov)
Date: Sun, 17 Mar 2024 08:56:33 GMT
Subject: RFR: 8328194: Add a test to check default rendering engine
In-Reply-To: <wLJ2MjVk-CoAO31dEvaoY7-BCgw6yQYutiX01vsGsZA=.2d3cf6fc-0064-4985-b3be-616f9ba99085@github.com>
References: <xxsxmOwVdXyBrSIp2WwIQ3_RvWLBL5KORk_X6bNkAnU=.588f07e6-2967-4d9e-a780-046af14d2ca1@github.com>
 <wLJ2MjVk-CoAO31dEvaoY7-BCgw6yQYutiX01vsGsZA=.2d3cf6fc-0064-4985-b3be-616f9ba99085@github.com>
Message-ID: <0a5Q1MibQDAMg4dKEOqpFjMg78_S2Xa1ByM1bElKgaM=.df9fc7de-bfd1-49a6-84d7-6bebc71df16c@github.com>

On Sat, 16 Mar 2024 21:32:02 GMT, Phil Race <prr at openjdk.org> wrote:

> We don't have any others in JDK 23, so I am not sure what this test does for us.

Right now it is not useful, but that is the same story we had in OpenJDK 8 - only the one engine for years, and then the engine "accidentally" changed to marlin. This test will help to catch such bugs.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18313#issuecomment-2002368655

From kizune at openjdk.org  Mon Mar 18 03:00:49 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Mon, 18 Mar 2024 03:00:49 GMT
Subject: RFR: 8328279: Convert java/awt/Cursor/CursorOverlappedPanelsTest
 test to main [v2]
In-Reply-To: <l6NLWusbqshFG9pUWWsoatnBo79fRPWVqtjLmkd3gTo=.7ca881bb-6874-4328-acb6-0b895df0e56e@github.com>
References: <l6NLWusbqshFG9pUWWsoatnBo79fRPWVqtjLmkd3gTo=.7ca881bb-6874-4328-acb6-0b895df0e56e@github.com>
Message-ID: <W5FDh69omNPRB7PRHjLyYyB9JUxKAe-RNM4wQug-cAg=.ea319c3f-0d93-4efd-9f98-d400e90d6dea@github.com>

> Converted to a main manual test.

Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:

  Fixes based on review feedback

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18331/files
  - new: https://git.openjdk.org/jdk/pull/18331/files/e74f3d26..c94a124e

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18331&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18331&range=00-01

  Stats: 4 lines in 1 file changed: 0 ins; 1 del; 3 mod
  Patch: https://git.openjdk.org/jdk/pull/18331.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18331/head:pull/18331

PR: https://git.openjdk.org/jdk/pull/18331

From kizune at openjdk.org  Mon Mar 18 03:00:50 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Mon, 18 Mar 2024 03:00:50 GMT
Subject: RFR: 8328279: Convert java/awt/Cursor/CursorOverlappedPanelsTest
 test to main [v2]
In-Reply-To: <DDSPj7NePJT9gWgUgPf9Q42p1CGnPX5NSQl22KdlAzc=.80b30b8c-6004-421a-876c-33dd946fea5b@github.com>
References: <l6NLWusbqshFG9pUWWsoatnBo79fRPWVqtjLmkd3gTo=.7ca881bb-6874-4328-acb6-0b895df0e56e@github.com>
 <DDSPj7NePJT9gWgUgPf9Q42p1CGnPX5NSQl22KdlAzc=.80b30b8c-6004-421a-876c-33dd946fea5b@github.com>
Message-ID: <XziLM0hAOjS35Yw0Jx9eYclotHQCFHE_2M0CTNBpD0U=.5c3f59d9-f117-44de-b9ee-88d7a0fd074d@github.com>

On Sat, 16 Mar 2024 00:44:12 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fixes based on review feedback
>
> test/jdk/java/awt/Cursor/CursorOverlappedPanelsTest.java line 34:
> 
>> 32: import javax.swing.JPanel;
>> 33: 
>> 34: /**
> 
> Suggestion:
> 
> /*

Done.

> test/jdk/java/awt/Cursor/CursorOverlappedPanelsTest.java line 56:
> 
>> 54:         frame.getContentPane().add(layeredPane);
>> 55:         frame.pack();
>> 56:         frame.setVisible(true);
> 
> frame.setVisible(true) can be removed, this avoid the test pane to appear initially at a different location and then switch the final location, additionally PassFailJFrame handles it.

Fixed.

> test/jdk/java/awt/Cursor/CursorOverlappedPanelsTest.java line 85:
> 
>> 83:                 .title("Overlapping Panels Cursor Test Instructions")
>> 84:                 .instructions(instructions)
>> 85:                 .rows(4)
> 
> May be 5-6 rows looks better for the instruction length.
> Using the below format avoids the need to specify a hardcoded row count number :)
> 
> Suggestion:
> 
>                 .rows((int) instructions.lines().count() + 1)

Ok.

> test/jdk/java/awt/Cursor/CursorOverlappedPanelsTest.java line 91:
> 
>> 89:                 .awaitAndCheck();
>> 90:     }
>> 91: }
> 
> EOF newline missing.

Added new line

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18331#discussion_r1527725691
PR Review Comment: https://git.openjdk.org/jdk/pull/18331#discussion_r1527724615
PR Review Comment: https://git.openjdk.org/jdk/pull/18331#discussion_r1527724519
PR Review Comment: https://git.openjdk.org/jdk/pull/18331#discussion_r1527724792

From tr at openjdk.org  Mon Mar 18 03:40:27 2024
From: tr at openjdk.org (Tejesh R)
Date: Mon, 18 Mar 2024 03:40:27 GMT
Subject: RFR: 8328247: Remove redundant dir for tests converted from applet
 to main
In-Reply-To: <Y7y9_ogLr40MhuuVRA1WPXNDc2_i9B0SJ0h71bm-nfw=.6afd340e-4a94-45a0-aee2-c770aba1e05f@github.com>
References: <Y7y9_ogLr40MhuuVRA1WPXNDc2_i9B0SJ0h71bm-nfw=.6afd340e-4a94-45a0-aee2-c770aba1e05f@github.com>
Message-ID: <rxhvfJhRcepdmGSOwSIljyQ8LHjC9j-11UH_3BM6-Ek=.6f3653ad-779d-4a97-ac61-5a8556e30814@github.com>

On Fri, 15 Mar 2024 07:23:30 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> Few tests were converted from applet manual to main using PassFailJFrame manual framework but the extra folder was not deleted
> 
> javax/swing/JFileChooser/6798062/bug6798062.java
> javax/swing/JFileChooser/FileFilterDescription/FileFilterDescription.html
> javax/swing/JInternalFrame/6726866/bug6726866.java 
> 
> so tests are now moved to one folder up..

Marked as reviewed by tr (Committer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18322#pullrequestreview-1941920879

From psadhukhan at openjdk.org  Mon Mar 18 06:07:26 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Mon, 18 Mar 2024 06:07:26 GMT
Subject: RFR: JDK-8328299 : Convert DnDFileGroupDescriptor.html applet test
 to main
In-Reply-To: <JMSgb5T4kBS4vbQUOgin4jajdDd9xSqFOUm9eExUP44=.9d01c4da-1d84-49e4-b0c0-a7bb874a643d@github.com>
References: <CTOJXaNDso7Gmw-A2kTkmsZmAWqcWllOim2Y_BGgeok=.5d62efd5-66c2-47a7-b1f0-c10f4c366b40@github.com>
 <JMSgb5T4kBS4vbQUOgin4jajdDd9xSqFOUm9eExUP44=.9d01c4da-1d84-49e4-b0c0-a7bb874a643d@github.com>
Message-ID: <7gn73bmbH0pkfkIHn2DYdwVXpNoZ2dgxRwbMyRxUz9E=.d2f822c9-6c6a-4d68-8c54-f1087d71144d@github.com>

On Fri, 15 Mar 2024 23:03:41 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Following test java/awt/dnd/DnDFileGroupDescriptor/DnDFileGroupDescriptor.html is converted to main using PassFailJFrame.
>> 
>> This test is currently problem-listed on macOS and linux, but as per the previous JBS bugs [[JDK-6242241](https://bugs.openjdk.org/browse/JDK-6242241), [JDK-8080185](https://bugs.openjdk.org/browse/JDK-8080185), [JDK-7147083](https://bugs.openjdk.org/browse/JDK-7147083)] this test was original created for testing DnD of MS Outlook attachments on Windows system.
>> 
>> Based on the test history and JBS details, I believe this should be windows-only test and should NOT be problemlisted on macOS and linux as it is **not applicable**.
>
> test/jdk/ProblemList.txt line 788:
> 
>> 786: java/awt/xembed/server/TestXEmbedServerJava.java 8001150,8004031 generic-all
>> 787: java/awt/Modal/PrintDialogsTest/PrintDialogsTest.java 8068378 generic-all
>> 788: java/awt/dnd/DnDFileGroupDescriptor/DnDFileGroupDescriptor.java 8080185 macosx-all,linux-all
> 
> @prsadhuk While looking into the test history I noticed you had previous worked on it PR https://github.com/openjdk/jdk/pull/3406, it wasn't integrated though. Any thoughts whether to make this test windows-only or extend the test to other platforms ?
> 
> Your previous PR description sounds correct, when I went through the related test bugs it seemed like the test was created for windows-only issue.

The reason it was not integrated was because of this [comment](https://github.com/openjdk/jdk/pull/3406#pullrequestreview-632106612) wherein it was mentioned to update the test to run without MSOutlook dependancy so that it could be run on all platforms so making it not platform dependant..

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18335#discussion_r1527889042

From dnguyen at openjdk.org  Mon Mar 18 06:40:36 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Mon, 18 Mar 2024 06:40:36 GMT
Subject: RFR: 8328185: Convert
 java/awt/image/MemoryLeakTest/MemoryLeakTest.java applet test to main [v2]
In-Reply-To: <TFYjDmsHDFBm5tcakvQmk_o_3bkZxQmS8FLPZW5bI8Y=.c7bebd2f-13cb-4bae-bd85-64cbff6c17b8@github.com>
References: <TFYjDmsHDFBm5tcakvQmk_o_3bkZxQmS8FLPZW5bI8Y=.c7bebd2f-13cb-4bae-bd85-64cbff6c17b8@github.com>
Message-ID: <fO7-Lz2ovhV9pcOGqJqX92QbrGyWgFWmW_B2Pi73ocs=.31463f6c-5cdd-4ba9-b0a6-e993807c5776@github.com>

> Convert java/awt/image/MemoryLeakTest/MemoryLeakTest.java applet test to main using PassFailJFrame

Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:

  Remove unneeded Global var. Review comments

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18307/files
  - new: https://git.openjdk.org/jdk/pull/18307/files/3c3e5410..fb3d566e

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18307&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18307&range=00-01

  Stats: 18 lines in 1 file changed: 1 ins; 7 del; 10 mod
  Patch: https://git.openjdk.org/jdk/pull/18307.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18307/head:pull/18307

PR: https://git.openjdk.org/jdk/pull/18307

From jdv at openjdk.org  Mon Mar 18 06:51:26 2024
From: jdv at openjdk.org (Jayathirth D V)
Date: Mon, 18 Mar 2024 06:51:26 GMT
Subject: RFR: 8328247: Remove redundant dir for tests converted from applet
 to main
In-Reply-To: <Y7y9_ogLr40MhuuVRA1WPXNDc2_i9B0SJ0h71bm-nfw=.6afd340e-4a94-45a0-aee2-c770aba1e05f@github.com>
References: <Y7y9_ogLr40MhuuVRA1WPXNDc2_i9B0SJ0h71bm-nfw=.6afd340e-4a94-45a0-aee2-c770aba1e05f@github.com>
Message-ID: <Gt1AL3t43ODJAC5gsF6kT9YJjij1R3g97eA48EaBfAc=.f6f1c8db-e005-4bb2-96c9-585ab9f2410c@github.com>

On Fri, 15 Mar 2024 07:23:30 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> Few tests were converted from applet manual to main using PassFailJFrame manual framework but the extra folder was not deleted
> 
> javax/swing/JFileChooser/6798062/bug6798062.java
> javax/swing/JFileChooser/FileFilterDescription/FileFilterDescription.html
> javax/swing/JInternalFrame/6726866/bug6726866.java 
> 
> so tests are now moved to one folder up..

Marked as reviewed by jdv (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18322#pullrequestreview-1942087474

From psadhukhan at openjdk.org  Mon Mar 18 06:58:29 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Mon, 18 Mar 2024 06:58:29 GMT
Subject: RFR: 8328035: Convert
 javax/swing/text/html/TableView/7030332/bug7030332.java applet test to main
 [v2]
In-Reply-To: <_k4T1yzAqADVQLTUScWnfSqbGYg-YZJ9SecWpQB55kM=.ffa6e901-7cee-40b6-954a-528dfb04dc83@github.com>
References: <sa4wl3VTL1p3Zxmat10wUsqex-uQewN2R2N8tXTwFFo=.013c255b-d875-4b52-a0f0-403664011199@github.com>
 <_k4T1yzAqADVQLTUScWnfSqbGYg-YZJ9SecWpQB55kM=.ffa6e901-7cee-40b6-954a-528dfb04dc83@github.com>
Message-ID: <1cAYTvs4Pw5aUeqZ7LFZTinmO1M4m3c2eqznYbrXO7c=.d86ae1d1-4fc7-46a8-a311-cf41d8e5a4e1@github.com>

On Thu, 14 Mar 2024 11:02:52 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Convert javax/swing/text/html/TableView/7030332/bug7030332.java applet test to main based test using PassFailJFrame.
>
> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review updates

I am not sure but to me the images dont seem to match in windows11..it seems JEditorPane image is 1 pixel thicker than golden images...in which case, it needs to be problemlisted
Also, I guess this has potential of making it automated by loading the golden images and JEditorPane in BufferedImage and then compare...

![image](https://github.com/openjdk/jdk/assets/43534309/c9b84f20-5b0c-44f2-a9a8-c5568d1b0ef4)

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18260#issuecomment-2003053107

From psadhukhan at openjdk.org  Mon Mar 18 07:02:30 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Mon, 18 Mar 2024 07:02:30 GMT
Subject: Integrated: 8328247: Remove redundant dir for tests converted from
 applet to main
In-Reply-To: <Y7y9_ogLr40MhuuVRA1WPXNDc2_i9B0SJ0h71bm-nfw=.6afd340e-4a94-45a0-aee2-c770aba1e05f@github.com>
References: <Y7y9_ogLr40MhuuVRA1WPXNDc2_i9B0SJ0h71bm-nfw=.6afd340e-4a94-45a0-aee2-c770aba1e05f@github.com>
Message-ID: <9O333jjmJdPBnyHWLBDH6Q8yXFVb1m--GxE_AyH9390=.38918ffe-7dea-4d1e-85c9-cd449cd2a844@github.com>

On Fri, 15 Mar 2024 07:23:30 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> Few tests were converted from applet manual to main using PassFailJFrame manual framework but the extra folder was not deleted
> 
> javax/swing/JFileChooser/6798062/bug6798062.java
> javax/swing/JFileChooser/FileFilterDescription/FileFilterDescription.html
> javax/swing/JInternalFrame/6726866/bug6726866.java 
> 
> so tests are now moved to one folder up..

This pull request has now been integrated.

Changeset: ece4124f
Author:    Prasanta Sadhukhan <psadhukhan at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/ece4124f25f676da9bf2d1b7fd8e4394dd7d31af
Stats:     0 lines in 3 files changed: 0 ins; 0 del; 0 mod

8328247: Remove redundant dir for tests converted from applet to main

Reviewed-by: tr, jdv

-------------

PR: https://git.openjdk.org/jdk/pull/18322

From psadhukhan at openjdk.org  Mon Mar 18 07:12:27 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Mon, 18 Mar 2024 07:12:27 GMT
Subject: RFR: JDK-8328012 : Convert InputMethod (/java/awt/im) applet tests
 to main [v5]
In-Reply-To: <wy9bLFymQ0_gqjxVqgIhc7s5Q3QHFC17th2FkmbLIB4=.be7612dc-904d-457e-b2df-fee9c73cf6c1@github.com>
References: <iDY1JdxeSzLcbW-ASx1PylUqKY-kGUjMj8tr4Sj5NDM=.a0b9fbdb-a959-4e98-ae08-d086fd8f210f@github.com>
 <wy9bLFymQ0_gqjxVqgIhc7s5Q3QHFC17th2FkmbLIB4=.be7612dc-904d-457e-b2df-fee9c73cf6c1@github.com>
Message-ID: <LmjN-Y6QEKt8A1NWWCdrZynsVoKFx4NepFOcqrq1s-o=.af4dc9c6-e026-4e3f-81a1-0fd9f5b1b170@github.com>

On Sat, 16 Mar 2024 22:35:16 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Following InputMethod applet tests are converted to main using PassFailJFrame
>> 
>> 1. java/awt/im/8132503/bug8132503.java (Renamed to PinyinIMFullstopTest.java)
>> 2. java/awt/im/8148984/bug8148984.java (Renamed to PinyinIMCommaTest.java) 
>> 
>> - test instructions are updated to make to more clear
>> - tests renamed 
>> - moved one directory above - /java/awt/im/
>> - html file deleted.
>> 
>> Two tests are updated as part of this PR as they are similar, details here https://github.com/openjdk/jdk/pull/18251#issuecomment-1992577598
>
> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   review updates

test/jdk/java/awt/im/PinyinIMCommaTest.java line 67:

> 65:         if (OSInfo.getOSType() != OSInfo.OSType.MACOSX) {
> 66:             throw new SkippedException("This test is for macOS only");
> 67:         }

Is it required to have this SkippedException?

I guess this test already have jtreg tag @requires("mac") and the test needs to be run with jtreg since we are using PassFailJFrame so I think it's redundant to have this check again in test.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18251#discussion_r1527956025

From abhiscxk at openjdk.org  Mon Mar 18 07:49:38 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Mon, 18 Mar 2024 07:49:38 GMT
Subject: RFR: 8328328: Convert javax/swing/JTabbedPane/4666224/bug4666224.java
 applet test to main
Message-ID: <4fqxbuw6GwuEAg6v7kvn72AQC3LeXPodKf8OrBDOr1w=.1cffa811-37e8-4294-b469-6487763bdeed@github.com>

Conversion of manual applet test to main based using PassFailJFrame manual framework

-------------

Commit messages:
 - Applet test converted to maim manual

Changes: https://git.openjdk.org/jdk/pull/18340/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18340&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8328328
  Stats: 785 lines in 4 files changed: 170 ins; 614 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/18340.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18340/head:pull/18340

PR: https://git.openjdk.org/jdk/pull/18340

From abhiscxk at openjdk.org  Mon Mar 18 08:01:41 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Mon, 18 Mar 2024 08:01:41 GMT
Subject: RFR: 8328248: Convert javax/swing/JSlider/6587742/bug6587742.java
 applet test to main [v2]
In-Reply-To: <zudlyAHwM4k8coUTGWVcF3b7uHwYpBPZwhUS9ecExqY=.2d5ec5ca-aecb-4e68-85f9-1b57cf2b2b36@github.com>
References: <zudlyAHwM4k8coUTGWVcF3b7uHwYpBPZwhUS9ecExqY=.2d5ec5ca-aecb-4e68-85f9-1b57cf2b2b36@github.com>
Message-ID: <11rpqXZBWd0vrxXUt5IhGY_b00GaVTcEwo93nILK4wI=.2a4820ff-d7e5-4f62-989a-bf39d670c145@github.com>

> Conversion of manual applet test to main based using PassFailJFrame manual framework

Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:

  jtreg tag update

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18323/files
  - new: https://git.openjdk.org/jdk/pull/18323/files/ee30cdbb..ef49f3b8

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18323&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18323&range=00-01

  Stats: 16 lines in 1 file changed: 8 ins; 8 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18323.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18323/head:pull/18323

PR: https://git.openjdk.org/jdk/pull/18323

From abhiscxk at openjdk.org  Mon Mar 18 08:01:41 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Mon, 18 Mar 2024 08:01:41 GMT
Subject: RFR: 8328248: Convert javax/swing/JSlider/6587742/bug6587742.java
 applet test to main [v2]
In-Reply-To: <tbWjkkkYnzTdA08tLxmhcqduMX1lb-HjDTJYN75xrxM=.c244dac7-8424-448e-8cb3-f391607412b9@github.com>
References: <zudlyAHwM4k8coUTGWVcF3b7uHwYpBPZwhUS9ecExqY=.2d5ec5ca-aecb-4e68-85f9-1b57cf2b2b36@github.com>
 <tbWjkkkYnzTdA08tLxmhcqduMX1lb-HjDTJYN75xrxM=.c244dac7-8424-448e-8cb3-f391607412b9@github.com>
Message-ID: <DMJpvChGRMNHA_S8v6MTFvI2mbiQjmRFIwP2kqNjEXs=.ee8bb475-b764-45cd-b67b-92218ee0f13c@github.com>

On Fri, 15 Mar 2024 12:59:24 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   jtreg tag update
>
> test/jdk/javax/swing/JSlider/bug6587742.java line 30:
> 
>> 28:  * @build PassFailJFrame
>> 29:  * @run main/manual bug6587742
>> 30:  */
> 
> Can be moved to the bug6587742 class declaration for better readability

There is a discussion going on for "where to put jtreg tags ?". Since there was no final conclusion, I left it as it was before the conversion.

Updated now.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18323#discussion_r1528019157

From abhiscxk at openjdk.org  Mon Mar 18 08:16:27 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Mon, 18 Mar 2024 08:16:27 GMT
Subject: RFR: 8327840: Automate javax/swing/border/Test4129681.java
In-Reply-To: <BbQ2iwy01dkTxtQ9Aj7RhRkSxWm3pq3BEIlGIzlSTCk=.7bdaafe4-681a-4f03-8462-4ffa7dc99507@github.com>
References: <BbQ2iwy01dkTxtQ9Aj7RhRkSxWm3pq3BEIlGIzlSTCk=.7bdaafe4-681a-4f03-8462-4ffa7dc99507@github.com>
Message-ID: <RHPY41M4MrZpauL2wMKeLtZi4az10CC1XNvrfmX0x-8=.6ac297dd-3b93-4ff8-bdda-51cd6d5a535d@github.com>

On Sat, 16 Mar 2024 07:43:18 GMT, Tejesh R <tr at openjdk.org> wrote:

> Automated the Test `javax/swing/border/Test4129681.java` from manual as suggested in JBS description.
> Verified in CI system and its Green. The test has been verified for Metal L&F and the same is set explicitly..

test/jdk/javax/swing/border/Test4129681.java line 48:

> 46:     private static final Dimension SIZE = new Dimension(100, 40);
> 47:     private static final Point startPoint = new Point(8, 4);
> 48:     private static final Point endPoint = new Point(18, 14);

I think all variables can be defined locally inside main.

test/jdk/javax/swing/border/Test4129681.java line 55:

> 53:         int tolerance = 20;
> 54: 
> 55:         UIManager.setLookAndFeel("javax.swing.plaf.metal.MetalLookAndFeel");

Is the test exclusive for Metal Look And Feel or should it be checked in other LAFs as well?
I think it may not work for Nimbus of GTK LAF as setting the property `UIManager.getDefaults().put("Label.disabledForeground", labelDisableColor);` may not work.

test/jdk/javax/swing/border/Test4129681.java line 62:

> 60:         label.setSize(SIZE);
> 61:         label.setEnabled(false);
> 62:         BufferedImage image = new BufferedImage((int) Math.ceil(label.getWidth()),

It can be - 
BufferedImage(label.getWidth(), label.getHeight(),
                TYPE_INT_RGB);

Why Math.ceil is required ?

test/jdk/javax/swing/border/Test4129681.java line 79:

> 77:         }
> 78: 
> 79:         if (((double)correctColoredPixels/totalPixels*100) <= tolerance) {

fix spacing.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18336#discussion_r1528024716
PR Review Comment: https://git.openjdk.org/jdk/pull/18336#discussion_r1528032073
PR Review Comment: https://git.openjdk.org/jdk/pull/18336#discussion_r1528025999
PR Review Comment: https://git.openjdk.org/jdk/pull/18336#discussion_r1528027557

From abhiscxk at openjdk.org  Mon Mar 18 08:27:32 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Mon, 18 Mar 2024 08:27:32 GMT
Subject: RFR: 8328279: Convert java/awt/Cursor/CursorOverlappedPanelsTest
 test to main [v2]
In-Reply-To: <W5FDh69omNPRB7PRHjLyYyB9JUxKAe-RNM4wQug-cAg=.ea319c3f-0d93-4efd-9f98-d400e90d6dea@github.com>
References: <l6NLWusbqshFG9pUWWsoatnBo79fRPWVqtjLmkd3gTo=.7ca881bb-6874-4328-acb6-0b895df0e56e@github.com>
 <W5FDh69omNPRB7PRHjLyYyB9JUxKAe-RNM4wQug-cAg=.ea319c3f-0d93-4efd-9f98-d400e90d6dea@github.com>
Message-ID: <xsm_iimQquleOOpQBW69A_zS4G_g7rL2qXri0L9GlPE=.5bc8f89d-9be7-429b-b342-482b6642ecc1@github.com>

On Mon, 18 Mar 2024 03:00:49 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

>> Converted to a main manual test.
>
> Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fixes based on review feedback

test/jdk/java/awt/Cursor/CursorOverlappedPanelsTest.java line 37:

> 35:  * @test
> 36:  * @bug 8007155
> 37:  * @summary [macosx] Disabled panel takes mouse input in JLayeredPane

Is the test exclusive for MacOS?

test/jdk/java/awt/Cursor/CursorOverlappedPanelsTest.java line 41:

> 39:  * @build PassFailJFrame
> 40:  * @run main/manual CursorOverlappedPanelsTest
> 41:  */

May add a blank line after this.

test/jdk/java/awt/Cursor/CursorOverlappedPanelsTest.java line 45:

> 43:     public static JFrame initialize() {
> 44:         final JFrame frame = new JFrame("Overlapping Panels Cursor Test");
> 45:         frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);

frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE); redundant, can be removed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18331#discussion_r1528053426
PR Review Comment: https://git.openjdk.org/jdk/pull/18331#discussion_r1528052078
PR Review Comment: https://git.openjdk.org/jdk/pull/18331#discussion_r1528050661

From abhiscxk at openjdk.org  Mon Mar 18 08:32:27 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Mon, 18 Mar 2024 08:32:27 GMT
Subject: RFR: 8328227: Remove applet usage from JColorChooser tests
 Test4887836
In-Reply-To: <sz94hhkj7mCeInxQ075Uwe14NVjdUMDk3sbuOr1E2X0=.2cc0c644-dd7a-4044-aa17-c082abaf74b6@github.com>
References: <sz94hhkj7mCeInxQ075Uwe14NVjdUMDk3sbuOr1E2X0=.2cc0c644-dd7a-4044-aa17-c082abaf74b6@github.com>
Message-ID: <KByFzAQwuk0gQc44_i5EkjokaHxOLEHzaWxcwOej_n0=.60f5636e-b0d7-4562-9e36-495ba239f00b@github.com>

On Thu, 14 Mar 2024 23:02:58 GMT, Alisen Chung <achung at openjdk.org> wrote:

> Removing applet usage from manual JColorChooser tests

test/jdk/javax/swing/JColorChooser/Test4887836.java line 36:

> 34:  * @summary Checks if no tooltip modification when no KeyStroke modifier
> 35:  * @run main/manual Test4887836
> 36:  */

May add a blank line after this for better readability.

test/jdk/javax/swing/JColorChooser/Test4887836.java line 54:

> 52:     }
> 53: 
> 54: 

can be removed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18316#discussion_r1528059759
PR Review Comment: https://git.openjdk.org/jdk/pull/18316#discussion_r1528060529

From abhiscxk at openjdk.org  Mon Mar 18 08:37:27 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Mon, 18 Mar 2024 08:37:27 GMT
Subject: RFR: 8328227: Remove applet usage from JColorChooser tests
 Test4887836
In-Reply-To: <sz94hhkj7mCeInxQ075Uwe14NVjdUMDk3sbuOr1E2X0=.2cc0c644-dd7a-4044-aa17-c082abaf74b6@github.com>
References: <sz94hhkj7mCeInxQ075Uwe14NVjdUMDk3sbuOr1E2X0=.2cc0c644-dd7a-4044-aa17-c082abaf74b6@github.com>
Message-ID: <fGQja-YISXkPxGI1R0y8G1D8H6pTR1gJAGmBzZ_JVhc=.9465c287-9ce2-4752-9a7d-02fcadcb17b5@github.com>

On Thu, 14 Mar 2024 23:02:58 GMT, Alisen Chung <achung at openjdk.org> wrote:

> Removing applet usage from manual JColorChooser tests

test/jdk/javax/swing/JColorChooser/Test4887836.java line 57:

> 55:     private static JColorChooser createColorChooser() {
> 56:         JColorChooser chooser = new JColorChooser(Color.LIGHT_GRAY);
> 57:         UIManager.put("Label.font", new Font("Perpetua", 0, 36)); // NON-NLS: property and font names

Can add comment above.
Suggestion:

        // NON-NLS: property and font names
        UIManager.put("Label.font", new Font("Perpetua", 0, 36));

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18316#discussion_r1528068244

From psadhukhan at openjdk.org  Mon Mar 18 08:44:26 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Mon, 18 Mar 2024 08:44:26 GMT
Subject: RFR: 8328244: Convert javax/swing/JSlider/6742358/bug6742358.java
 applet test to main [v3]
In-Reply-To: <xXAG1uSfdyroFueY6L1D7spn9gDjUA8ZxgOLkMWbVK4=.45df8961-7f77-46c6-b84e-3445c9c5555d@github.com>
References: <AN6EAjyACY33ukKyOjp8SuzxRt80B9Z_UO1fy83Nijw=.42fbb5cd-fb5c-413d-a1f2-842657fa7f0e@github.com>
 <xXAG1uSfdyroFueY6L1D7spn9gDjUA8ZxgOLkMWbVK4=.45df8961-7f77-46c6-b84e-3445c9c5555d@github.com>
Message-ID: <olaYP3SfJRBDYi6NrVJeIrdhKZjM47RFvgMAx53ItrA=.ccac9804-c18a-4a53-be52-93c23da5f3b2@github.com>

On Fri, 15 Mar 2024 07:36:55 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Conversion of manual applet test to main based using PassFailJFrame manual framework
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   jtreg manual tag update

Marked as reviewed by psadhukhan (Reviewer).

test/jdk/javax/swing/JSlider/bug6742358.java line 24:

> 22:  */
> 23: 
> 24: /* @test

start @test at next line

-------------

PR Review: https://git.openjdk.org/jdk/pull/18321#pullrequestreview-1942270311
PR Review Comment: https://git.openjdk.org/jdk/pull/18321#discussion_r1528079546

From psadhukhan at openjdk.org  Mon Mar 18 08:54:30 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Mon, 18 Mar 2024 08:54:30 GMT
Subject: RFR: 8328262: Convert
 javax/swing/JSplitPane/8132123/bug8132123.java applet test to main [v2]
In-Reply-To: <YxENRn8yEx0_KxJCT5XcYa6XE2nUkhtbYZcgmm09gFI=.096c7cfb-ed3b-4cf6-9c5b-ba5898ae7716@github.com>
References: <UGuBjBTuGecghDM14mLTft1l8zGsY_PPueIqolFvq1U=.65c37ac4-3dbb-4385-85e5-f9393ec1445c@github.com>
 <YxENRn8yEx0_KxJCT5XcYa6XE2nUkhtbYZcgmm09gFI=.096c7cfb-ed3b-4cf6-9c5b-ba5898ae7716@github.com>
Message-ID: <aq7bwiXbi3aRNF7RtPjSC1gnKi5EpeT0KlIs4yV6jRA=.556aefb3-c9d8-45c8-9403-75bac5227fff@github.com>

On Fri, 15 Mar 2024 11:30:53 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Conversion of manual applet test to main based using PassFailJFrame manual framework
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   jtreg manual tag update

test/jdk/javax/swing/JSplitPane/bug8132123.java line 30:

> 28: import javax.swing.JSplitPane;
> 29: 
> 30: /* @test

start @test at next line

test/jdk/javax/swing/JSplitPane/bug8132123.java line 37:

> 35:  * @build PassFailJFrame
> 36:  * @run main/manual bug8132123
> 37:  */

ALso, I know the current instruction doesn't specify that but should we run with -Dsun.java2d.uiScale=2.0 since it is supposed to be a hidpi test...

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18325#discussion_r1528081758
PR Review Comment: https://git.openjdk.org/jdk/pull/18325#discussion_r1528094508

From tr at openjdk.org  Mon Mar 18 09:19:34 2024
From: tr at openjdk.org (Tejesh R)
Date: Mon, 18 Mar 2024 09:19:34 GMT
Subject: RFR: 8328035: Convert
 javax/swing/text/html/TableView/7030332/bug7030332.java applet test to main
 [v2]
In-Reply-To: <_k4T1yzAqADVQLTUScWnfSqbGYg-YZJ9SecWpQB55kM=.ffa6e901-7cee-40b6-954a-528dfb04dc83@github.com>
References: <sa4wl3VTL1p3Zxmat10wUsqex-uQewN2R2N8tXTwFFo=.013c255b-d875-4b52-a0f0-403664011199@github.com>
 <_k4T1yzAqADVQLTUScWnfSqbGYg-YZJ9SecWpQB55kM=.ffa6e901-7cee-40b6-954a-528dfb04dc83@github.com>
Message-ID: <W29eRitCPAyu8VSvEwFL7Ys8a4jIiPess1tABLwMFzU=.2fd4d642-8d2d-4d11-8d28-e3d8395e41df@github.com>

On Thu, 14 Mar 2024 11:02:52 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Convert javax/swing/text/html/TableView/7030332/bug7030332.java applet test to main based test using PassFailJFrame.
>
> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review updates

> I am not sure but to me the images dont seem to match in windows11..it seems JEditorPane image is 1 pixel thicker than golden images...in which case, it needs to be problemlisted Also, I guess this has potential of making it automated by loading the golden images and JEditorPane in BufferedImage and then compare...
> 
> ![image](https://private-user-images.githubusercontent.com/43534309/313576442-c9b84f20-5b0c-44f2-a9a8-c5568d1b0ef4.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTA3NTM2MTEsIm5iZiI6MTcxMDc1MzMxMSwicGF0aCI6Ii80MzUzNDMwOS8zMTM1NzY0NDItYzliODRmMjAtNWIwYy00NGYyLWE5YTgtYzU1NjhkMWIwZWY0LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAzMTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMzE4VDA5MTUxMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWY2NjJmNzRmMzBjMzUyMzUxOWRiODBmZGJmNGU5Zjc4NThmMTUwZjc4NWJkN2NhYWI0ZmE4YWJkYmZkYTg3YjgmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.c3EEHxT_VGBlWLLQkH4xIdbcXBBuvpYoNW3KQfZNgAw)

You mean to say the border of JEditorPane is 1 pixel thicker ?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18260#issuecomment-2003287567

From abhiscxk at openjdk.org  Mon Mar 18 09:21:02 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Mon, 18 Mar 2024 09:21:02 GMT
Subject: RFR: 8328262: Convert
 javax/swing/JSplitPane/8132123/bug8132123.java applet test to main [v3]
In-Reply-To: <UGuBjBTuGecghDM14mLTft1l8zGsY_PPueIqolFvq1U=.65c37ac4-3dbb-4385-85e5-f9393ec1445c@github.com>
References: <UGuBjBTuGecghDM14mLTft1l8zGsY_PPueIqolFvq1U=.65c37ac4-3dbb-4385-85e5-f9393ec1445c@github.com>
Message-ID: <7HFbDcncHLgKFUBmnrGUcgoYof-23Dj4qhTCaf2ZF-g=.0198f934-7808-457a-9991-06f92ed02811@github.com>

> Conversion of manual applet test to main based using PassFailJFrame manual framework

Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:

  Review comment update

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18325/files
  - new: https://git.openjdk.org/jdk/pull/18325/files/cfac93ab..5456a5c7

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18325&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18325&range=01-02

  Stats: 3 lines in 1 file changed: 1 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/18325.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18325/head:pull/18325

PR: https://git.openjdk.org/jdk/pull/18325

From abhiscxk at openjdk.org  Mon Mar 18 09:21:02 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Mon, 18 Mar 2024 09:21:02 GMT
Subject: RFR: 8328262: Convert
 javax/swing/JSplitPane/8132123/bug8132123.java applet test to main [v2]
In-Reply-To: <aq7bwiXbi3aRNF7RtPjSC1gnKi5EpeT0KlIs4yV6jRA=.556aefb3-c9d8-45c8-9403-75bac5227fff@github.com>
References: <UGuBjBTuGecghDM14mLTft1l8zGsY_PPueIqolFvq1U=.65c37ac4-3dbb-4385-85e5-f9393ec1445c@github.com>
 <YxENRn8yEx0_KxJCT5XcYa6XE2nUkhtbYZcgmm09gFI=.096c7cfb-ed3b-4cf6-9c5b-ba5898ae7716@github.com>
 <aq7bwiXbi3aRNF7RtPjSC1gnKi5EpeT0KlIs4yV6jRA=.556aefb3-c9d8-45c8-9403-75bac5227fff@github.com>
Message-ID: <CcYNMmmmSVNQogJG5kvZq1pMghso2elDXoXo-MFfokc=.1ae1e9aa-c90e-4903-8fb9-be66aec8ab13@github.com>

On Mon, 18 Mar 2024 08:43:33 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   jtreg manual tag update
>
> test/jdk/javax/swing/JSplitPane/bug8132123.java line 30:
> 
>> 28: import javax.swing.JSplitPane;
>> 29: 
>> 30: /* @test
> 
> start @test at next line

Updated.

> test/jdk/javax/swing/JSplitPane/bug8132123.java line 37:
> 
>> 35:  * @build PassFailJFrame
>> 36:  * @run main/manual bug8132123
>> 37:  */
> 
> ALso, I know the current instruction doesn't specify that but should we run with -Dsun.java2d.uiScale=2.0 since it is supposed to be a hidpi test...

Yeah, updated now.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18325#discussion_r1528150624
PR Review Comment: https://git.openjdk.org/jdk/pull/18325#discussion_r1528151708

From tr at openjdk.org  Mon Mar 18 09:24:31 2024
From: tr at openjdk.org (Tejesh R)
Date: Mon, 18 Mar 2024 09:24:31 GMT
Subject: RFR: 8327840: Automate javax/swing/border/Test4129681.java
In-Reply-To: <RHPY41M4MrZpauL2wMKeLtZi4az10CC1XNvrfmX0x-8=.6ac297dd-3b93-4ff8-bdda-51cd6d5a535d@github.com>
References: <BbQ2iwy01dkTxtQ9Aj7RhRkSxWm3pq3BEIlGIzlSTCk=.7bdaafe4-681a-4f03-8462-4ffa7dc99507@github.com>
 <RHPY41M4MrZpauL2wMKeLtZi4az10CC1XNvrfmX0x-8=.6ac297dd-3b93-4ff8-bdda-51cd6d5a535d@github.com>
Message-ID: <lphMTN_WhVHzwnErlOGTlZT4LpnJI2OwNR7IVDPQExw=.487e72e3-104d-4b01-a661-0c6de2274e5d@github.com>

On Mon, 18 Mar 2024 08:09:07 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

> Is the test exclusive for Metal Look And Feel or should it be checked in other LAFs as well? I think it may not work for Nimbus of GTK LAF as setting the property `UIManager.getDefaults().put("Label.disabledForeground", labelDisableColor);` may not work.

Yeah, because its difficult to verify it automatically for all L&F. And yeah you are right, it didn't work for Nimbus either.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18336#discussion_r1528162083

From psadhukhan at openjdk.org  Mon Mar 18 09:27:28 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Mon, 18 Mar 2024 09:27:28 GMT
Subject: RFR: 8328035: Convert
 javax/swing/text/html/TableView/7030332/bug7030332.java applet test to main
 [v2]
In-Reply-To: <W29eRitCPAyu8VSvEwFL7Ys8a4jIiPess1tABLwMFzU=.2fd4d642-8d2d-4d11-8d28-e3d8395e41df@github.com>
References: <sa4wl3VTL1p3Zxmat10wUsqex-uQewN2R2N8tXTwFFo=.013c255b-d875-4b52-a0f0-403664011199@github.com>
 <_k4T1yzAqADVQLTUScWnfSqbGYg-YZJ9SecWpQB55kM=.ffa6e901-7cee-40b6-954a-528dfb04dc83@github.com>
 <W29eRitCPAyu8VSvEwFL7Ys8a4jIiPess1tABLwMFzU=.2fd4d642-8d2d-4d11-8d28-e3d8395e41df@github.com>
Message-ID: <9zdwvT5QVbv2Vw7zwTrU-LtotHnmkyagUEDgikirDWM=.1fc59ab5-21e7-43f4-bd83-6ecfe79e7cc2@github.com>

On Mon, 18 Mar 2024 09:17:16 GMT, Tejesh R <tr at openjdk.org> wrote:

> > I am not sure but to me the images dont seem to match in windows11..it seems JEditorPane image is 1 pixel thicker than golden images...in which case, it needs to be problemlisted Also, I guess this has potential of making it automated by loading the golden images and JEditorPane in BufferedImage and then compare...
> > ![image](https://private-user-images.githubusercontent.com/43534309/313576442-c9b84f20-5b0c-44f2-a9a8-c5568d1b0ef4.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTA3NTM2MTEsIm5iZiI6MTcxMDc1MzMxMSwicGF0aCI6Ii80MzUzNDMwOS8zMTM1NzY0NDItYzliODRmMjAtNWIwYy00NGYyLWE5YTgtYzU1NjhkMWIwZWY0LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAzMTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMzE4VDA5MTUxMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWY2NjJmNzRmMzBjMzUyMzUxOWRiODBmZGJmNGU5Zjc4NThmMTUwZjc4NWJkN2NhYWI0ZmE4YWJkYmZkYTg3YjgmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.c3EEHxT_VGBlWLLQkH4xIdbcXBBuvpYoNW3KQfZNgAw)
> 
> You mean to say the border of JEditorPane is 1 pixel thicker ?

it doesn't look exactly same subjectively...

![image](https://github.com/openjdk/jdk/assets/43534309/15dcdcab-fdf4-4bf4-8ef8-7c0689d6b538)

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18260#issuecomment-2003314034

From abhiscxk at openjdk.org  Mon Mar 18 09:35:37 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Mon, 18 Mar 2024 09:35:37 GMT
Subject: RFR: 8327840: Automate javax/swing/border/Test4129681.java
In-Reply-To: <lphMTN_WhVHzwnErlOGTlZT4LpnJI2OwNR7IVDPQExw=.487e72e3-104d-4b01-a661-0c6de2274e5d@github.com>
References: <BbQ2iwy01dkTxtQ9Aj7RhRkSxWm3pq3BEIlGIzlSTCk=.7bdaafe4-681a-4f03-8462-4ffa7dc99507@github.com>
 <RHPY41M4MrZpauL2wMKeLtZi4az10CC1XNvrfmX0x-8=.6ac297dd-3b93-4ff8-bdda-51cd6d5a535d@github.com>
 <lphMTN_WhVHzwnErlOGTlZT4LpnJI2OwNR7IVDPQExw=.487e72e3-104d-4b01-a661-0c6de2274e5d@github.com>
Message-ID: <wF59mhIj-B6RGR8ddi3YdQ3ijttapQyblwbFhzmgc6c=.c2a5b730-aeaa-48d5-8720-7a9acb783715@github.com>

On Mon, 18 Mar 2024 09:22:02 GMT, Tejesh R <tr at openjdk.org> wrote:

> Yeah, because its difficult to verify it automatically for all L&F.

Not really, this can be done. But if it is not required to check except Metal then it is ok.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18336#discussion_r1528181286

From tr at openjdk.org  Mon Mar 18 09:35:38 2024
From: tr at openjdk.org (Tejesh R)
Date: Mon, 18 Mar 2024 09:35:38 GMT
Subject: RFR: 8328035: Convert
 javax/swing/text/html/TableView/7030332/bug7030332.java applet test to main
 [v2]
In-Reply-To: <_k4T1yzAqADVQLTUScWnfSqbGYg-YZJ9SecWpQB55kM=.ffa6e901-7cee-40b6-954a-528dfb04dc83@github.com>
References: <sa4wl3VTL1p3Zxmat10wUsqex-uQewN2R2N8tXTwFFo=.013c255b-d875-4b52-a0f0-403664011199@github.com>
 <_k4T1yzAqADVQLTUScWnfSqbGYg-YZJ9SecWpQB55kM=.ffa6e901-7cee-40b6-954a-528dfb04dc83@github.com>
Message-ID: <czzx6URRvyadj98-Yf5hr87K7wDcKpAlQ6R_vEtlI9M=.957c488a-bb26-4dc9-8e90-e02a5c894ef1@github.com>

On Thu, 14 Mar 2024 11:02:52 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Convert javax/swing/text/html/TableView/7030332/bug7030332.java applet test to main based test using PassFailJFrame.
>
> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review updates

> > > I am not sure but to me the images dont seem to match in windows11..it seems JEditorPane image is 1 pixel thicker than golden images...in which case, it needs to be problemlisted Also, I guess this has potential of making it automated by loading the golden images and JEditorPane in BufferedImage and then compare...
> > > ![image](https://private-user-images.githubusercontent.com/43534309/313576442-c9b84f20-5b0c-44f2-a9a8-c5568d1b0ef4.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTA3NTM2MTEsIm5iZiI6MTcxMDc1MzMxMSwicGF0aCI6Ii80MzUzNDMwOS8zMTM1NzY0NDItYzliODRmMjAtNWIwYy00NGYyLWE5YTgtYzU1NjhkMWIwZWY0LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAzMTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMzE4VDA5MTUxMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWY2NjJmNzRmMzBjMzUyMzUxOWRiODBmZGJmNGU5Zjc4NThmMTUwZjc4NWJkN2NhYWI0ZmE4YWJkYmZkYTg3YjgmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.c3EEHxT_VGBlWLLQkH4xIdbcXBBuvpYoNW3KQfZNgAw)
> > 
> > 
> > You mean to say the border of JEditorPane is 1 pixel thicker ?
> 
> it doesn't look exactly same subjectively...
> 
> ![image](https://private-user-images.githubusercontent.com/43534309/313618601-15dcdcab-fdf4-4bf4-8ef8-7c0689d6b538.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTA3NTQyNDIsIm5iZiI6MTcxMDc1Mzk0MiwicGF0aCI6Ii80MzUzNDMwOS8zMTM2MTg2MDEtMTVkY2RjYWItZmRmNC00YmY0LThlZjgtN2MwNjg5ZDZiNTM4LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAzMTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMzE4VDA5MjU0MlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTU3NmZmMGZhNDUyYzM2Y2UyNGExN2QyZjFiNjljZDljMTE2NDdiMmM4NzIwYzgzOTdjYWJmZGY5ZDdjOTkwMTYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.d_TI9VegwGDfOcO0zHhgHhxtOHRiTZudNBS0IXIIGhI)

Yeah, but in instructions they say it should look similar, so wasn't sure whether to problem list or proceed with conversion. You think we should problem list?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18260#issuecomment-2003330021

From psadhukhan at openjdk.org  Mon Mar 18 09:36:31 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Mon, 18 Mar 2024 09:36:31 GMT
Subject: RFR: 8328262: Convert
 javax/swing/JSplitPane/8132123/bug8132123.java applet test to main [v3]
In-Reply-To: <7HFbDcncHLgKFUBmnrGUcgoYof-23Dj4qhTCaf2ZF-g=.0198f934-7808-457a-9991-06f92ed02811@github.com>
References: <UGuBjBTuGecghDM14mLTft1l8zGsY_PPueIqolFvq1U=.65c37ac4-3dbb-4385-85e5-f9393ec1445c@github.com>
 <7HFbDcncHLgKFUBmnrGUcgoYof-23Dj4qhTCaf2ZF-g=.0198f934-7808-457a-9991-06f92ed02811@github.com>
Message-ID: <tnlVNk0v9jneawL86TaDkRltcq1e1bCBWHoRki8kwdc=.f4e9ba1b-a246-4474-a741-362640aff735@github.com>

On Mon, 18 Mar 2024 09:21:02 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Conversion of manual applet test to main based using PassFailJFrame manual framework
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review comment update

Marked as reviewed by psadhukhan (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18325#pullrequestreview-1942408356

From tr at openjdk.org  Mon Mar 18 09:38:29 2024
From: tr at openjdk.org (Tejesh R)
Date: Mon, 18 Mar 2024 09:38:29 GMT
Subject: RFR: 8327840: Automate javax/swing/border/Test4129681.java
In-Reply-To: <wF59mhIj-B6RGR8ddi3YdQ3ijttapQyblwbFhzmgc6c=.c2a5b730-aeaa-48d5-8720-7a9acb783715@github.com>
References: <BbQ2iwy01dkTxtQ9Aj7RhRkSxWm3pq3BEIlGIzlSTCk=.7bdaafe4-681a-4f03-8462-4ffa7dc99507@github.com>
 <RHPY41M4MrZpauL2wMKeLtZi4az10CC1XNvrfmX0x-8=.6ac297dd-3b93-4ff8-bdda-51cd6d5a535d@github.com>
 <lphMTN_WhVHzwnErlOGTlZT4LpnJI2OwNR7IVDPQExw=.487e72e3-104d-4b01-a661-0c6de2274e5d@github.com>
 <wF59mhIj-B6RGR8ddi3YdQ3ijttapQyblwbFhzmgc6c=.c2a5b730-aeaa-48d5-8720-7a9acb783715@github.com>
Message-ID: <kRVPWD9mcBveEjQ71JkX5zJwqT0XlvIYrROgkjKVAlc=.40de0486-6b0a-42e8-b446-defba9d552ac@github.com>

On Mon, 18 Mar 2024 09:32:37 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>>> Is the test exclusive for Metal Look And Feel or should it be checked in other LAFs as well? I think it may not work for Nimbus of GTK LAF as setting the property `UIManager.getDefaults().put("Label.disabledForeground", labelDisableColor);` may not work.
>> 
>> Yeah, because its difficult to verify it automatically for all L&F. And yeah you are right, it didn't work for Nimbus either.
>
>> Yeah, because its difficult to verify it automatically for all L&F.
> 
> Not really, this can be done. But if it is not required to check except Metal then it is ok.

I meant the label position might vary slightly for different L&F, here I have hardcoded it for metal L&F...... Not sure it would remain same for all the L&F......

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18336#discussion_r1528187092

From psadhukhan at openjdk.org  Mon Mar 18 09:40:26 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Mon, 18 Mar 2024 09:40:26 GMT
Subject: RFR: 8328035: Convert
 javax/swing/text/html/TableView/7030332/bug7030332.java applet test to main
 [v2]
In-Reply-To: <czzx6URRvyadj98-Yf5hr87K7wDcKpAlQ6R_vEtlI9M=.957c488a-bb26-4dc9-8e90-e02a5c894ef1@github.com>
References: <sa4wl3VTL1p3Zxmat10wUsqex-uQewN2R2N8tXTwFFo=.013c255b-d875-4b52-a0f0-403664011199@github.com>
 <_k4T1yzAqADVQLTUScWnfSqbGYg-YZJ9SecWpQB55kM=.ffa6e901-7cee-40b6-954a-528dfb04dc83@github.com>
 <czzx6URRvyadj98-Yf5hr87K7wDcKpAlQ6R_vEtlI9M=.957c488a-bb26-4dc9-8e90-e02a5c894ef1@github.com>
Message-ID: <6SPvUhuB-QIgakHdRqx1_LzOADDQNU25xRz7k2obSZc=.ac2b9979-d177-412e-be68-7b10f9a3a0ae@github.com>

On Mon, 18 Mar 2024 09:32:42 GMT, Tejesh R <tr at openjdk.org> wrote:

> > > > I am not sure but to me the images dont seem to match in windows11..it seems JEditorPane image is 1 pixel thicker than golden images...in which case, it needs to be problemlisted Also, I guess this has potential of making it automated by loading the golden images and JEditorPane in BufferedImage and then compare...
> > > > ![image](https://private-user-images.githubusercontent.com/43534309/313576442-c9b84f20-5b0c-44f2-a9a8-c5568d1b0ef4.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTA3NTM2MTEsIm5iZiI6MTcxMDc1MzMxMSwicGF0aCI6Ii80MzUzNDMwOS8zMTM1NzY0NDItYzliODRmMjAtNWIwYy00NGYyLWE5YTgtYzU1NjhkMWIwZWY0LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAzMTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMzE4VDA5MTUxMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWY2NjJmNzRmMzBjMzUyMzUxOWRiODBmZGJmNGU5Zjc4NThmMTUwZjc4NWJkN2NhYWI0ZmE4YWJkYmZkYTg3YjgmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.c3EEHxT_VGBlWLLQkH4xIdbcXBBuvpYoNW3KQfZNgAw)
> > > 
> > > 
> > > You mean to say the border of JEditorPane is 1 pixel thicker ?
> > 
> > 
> > it doesn't look exactly same subjectively...
> > ![image](https://private-user-images.githubusercontent.com/43534309/313618601-15dcdcab-fdf4-4bf4-8ef8-7c0689d6b538.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTA3NTQyNDIsIm5iZiI6MTcxMDc1Mzk0MiwicGF0aCI6Ii80MzUzNDMwOS8zMTM2MTg2MDEtMTVkY2RjYWItZmRmNC00YmY0LThlZjgtN2MwNjg5ZDZiNTM4LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAzMTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMzE4VDA5MjU0MlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTU3NmZmMGZhNDUyYzM2Y2UyNGExN2QyZjFiNjljZDljMTE2NDdiMmM4NzIwYzgzOTdjYWJmZGY5ZDdjOTkwMTYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.d_TI9VegwGDfOcO0zHhgHhxtOHRiTZudNBS0IXIIGhI)
> 
> Yeah, but in instructions they say it should look similar, so wasn't sure whether to problem list or proceed with conversion. You think we should problem list?

I am not sure...I think there was some fix regarding border stroke sometime back either by @honkar-jdk or @DamonGuy . Maybe expectation should be somewhat different now in which case, probably the instructions should be amended accordingly...Let them verify once..

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18260#issuecomment-2003339203

From tr at openjdk.org  Mon Mar 18 09:50:43 2024
From: tr at openjdk.org (Tejesh R)
Date: Mon, 18 Mar 2024 09:50:43 GMT
Subject: RFR: 8327840: Automate javax/swing/border/Test4129681.java [v2]
In-Reply-To: <BbQ2iwy01dkTxtQ9Aj7RhRkSxWm3pq3BEIlGIzlSTCk=.7bdaafe4-681a-4f03-8462-4ffa7dc99507@github.com>
References: <BbQ2iwy01dkTxtQ9Aj7RhRkSxWm3pq3BEIlGIzlSTCk=.7bdaafe4-681a-4f03-8462-4ffa7dc99507@github.com>
Message-ID: <vLPl9zuaDaTVOE0xHeQ5WN3mkNqEzArFgPNnKO3EU20=.b910622f-bb8d-4909-9c54-48c2943775f9@github.com>

> Automated the Test `javax/swing/border/Test4129681.java` from manual as suggested in JBS description.
> Verified in CI system and its Green. The test has been verified for Metal L&F and the same is set explicitly..

Tejesh R has updated the pull request incrementally with one additional commit since the last revision:

  Review updates

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18336/files
  - new: https://git.openjdk.org/jdk/pull/18336/files/2ab358db..cfb599ff

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18336&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18336&range=00-01

  Stats: 22 lines in 1 file changed: 6 ins; 8 del; 8 mod
  Patch: https://git.openjdk.org/jdk/pull/18336.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18336/head:pull/18336

PR: https://git.openjdk.org/jdk/pull/18336

From tr at openjdk.org  Mon Mar 18 09:50:43 2024
From: tr at openjdk.org (Tejesh R)
Date: Mon, 18 Mar 2024 09:50:43 GMT
Subject: RFR: 8327840: Automate javax/swing/border/Test4129681.java [v2]
In-Reply-To: <RHPY41M4MrZpauL2wMKeLtZi4az10CC1XNvrfmX0x-8=.6ac297dd-3b93-4ff8-bdda-51cd6d5a535d@github.com>
References: <BbQ2iwy01dkTxtQ9Aj7RhRkSxWm3pq3BEIlGIzlSTCk=.7bdaafe4-681a-4f03-8462-4ffa7dc99507@github.com>
 <RHPY41M4MrZpauL2wMKeLtZi4az10CC1XNvrfmX0x-8=.6ac297dd-3b93-4ff8-bdda-51cd6d5a535d@github.com>
Message-ID: <C1Uj8ZwnwcgizwDcPuK3nX6Ru7NFys2_US3DyV2q2OQ=.275eb259-56a1-416e-a934-7eaa6fa331fa@github.com>

On Mon, 18 Mar 2024 08:04:36 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review updates
>
> test/jdk/javax/swing/border/Test4129681.java line 62:
> 
>> 60:         label.setSize(SIZE);
>> 61:         label.setEnabled(false);
>> 62:         BufferedImage image = new BufferedImage((int) Math.ceil(label.getWidth()),
> 
> It can be - 
> BufferedImage(label.getWidth(), label.getHeight(),
>                 TYPE_INT_RGB);
> 
> Why Math.ceil is required ?

Removed.

> test/jdk/javax/swing/border/Test4129681.java line 79:
> 
>> 77:         }
>> 78: 
>> 79:         if (((double)correctColoredPixels/totalPixels*100) <= tolerance) {
> 
> fix spacing.

Done.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18336#discussion_r1528218032
PR Review Comment: https://git.openjdk.org/jdk/pull/18336#discussion_r1528217624

From psadhukhan at openjdk.org  Mon Mar 18 09:51:28 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Mon, 18 Mar 2024 09:51:28 GMT
Subject: RFR: 8328300: Convert PrintDialogsTest.java from Applet to main
 program
In-Reply-To: <awEafcUuB7m-r62HTUPpL9DsuGnRuT1czVoirtsYJRI=.725d3d5f-04f9-4012-bcc3-a8e7d157f07f@github.com>
References: <awEafcUuB7m-r62HTUPpL9DsuGnRuT1czVoirtsYJRI=.725d3d5f-04f9-4012-bcc3-a8e7d157f07f@github.com>
Message-ID: <_w1yg_VbWtBKL_8P4h-VdWqkWQFi9Vuhv1yY5BWiqMY=.96749489-32e4-4ba2-ae04-9d7debf4cee4@github.com>

On Fri, 15 Mar 2024 21:20:04 GMT, Phil Race <prr at openjdk.org> wrote:

> This applet test is converted to a main program using PassFailJFrame.
> Other than that, the main thing I improved is the instructions.

Marked as reviewed by psadhukhan (Reviewer).

test/jdk/java/awt/Modal/PrintDialogsTest/PrintDialogsTest.java line 58:

> 56:         (a) The dialog parent type.
> 57:         (b) The dialog modality type
> 58:         (c) The print dialog type (Print dialog or Page Setup dialog)

Can we put a one line gap in the GUI between Dialog parent type options and next dialog modality type heading...Right now the type and the options of all 3 appear one after the other,,,maybe 1 line gap between each category would help 

![image](https://github.com/openjdk/jdk/assets/43534309/a6c0f3f2-def3-4648-a13c-6e720bf6350c)

-------------

PR Review: https://git.openjdk.org/jdk/pull/18333#pullrequestreview-1942457324
PR Review Comment: https://git.openjdk.org/jdk/pull/18333#discussion_r1528220823

From tr at openjdk.org  Mon Mar 18 10:47:33 2024
From: tr at openjdk.org (Tejesh R)
Date: Mon, 18 Mar 2024 10:47:33 GMT
Subject: RFR: 8328248: Convert javax/swing/JSlider/6587742/bug6587742.java
 applet test to main [v2]
In-Reply-To: <11rpqXZBWd0vrxXUt5IhGY_b00GaVTcEwo93nILK4wI=.2a4820ff-d7e5-4f62-989a-bf39d670c145@github.com>
References: <zudlyAHwM4k8coUTGWVcF3b7uHwYpBPZwhUS9ecExqY=.2d5ec5ca-aecb-4e68-85f9-1b57cf2b2b36@github.com>
 <11rpqXZBWd0vrxXUt5IhGY_b00GaVTcEwo93nILK4wI=.2a4820ff-d7e5-4f62-989a-bf39d670c145@github.com>
Message-ID: <lrx95Zwf97AqbliVW4ID41jpBwYvbYplAJ9_6G-8x9Q=.fd933522-77a2-4a23-be2c-8f69fbd62c95@github.com>

On Mon, 18 Mar 2024 08:01:41 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Conversion of manual applet test to main based using PassFailJFrame manual framework
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   jtreg tag update

Looks good to me.

-------------

Marked as reviewed by tr (Committer).

PR Review: https://git.openjdk.org/jdk/pull/18323#pullrequestreview-1942590142

From ihse at openjdk.org  Mon Mar 18 10:56:54 2024
From: ihse at openjdk.org (Magnus Ihse Bursie)
Date: Mon, 18 Mar 2024 10:56:54 GMT
Subject: RFR: 8328177: Move LDFLAGS_JDK[LIB/EXE] to JdkNativeCompilation.gmk
Message-ID: <SLLx5r0atjXi0tBfduohg2HrVPUvTQxorYZR4cmqsu4=.3b0a90c0-78b2-4dd7-9d74-cc5ff084faab@github.com>

Similar to [JDK-8328157](https://bugs.openjdk.org/browse/JDK-8328157), we want to move the setting of LDFLAGS to LDFLAGS_JDK[LIB/EXE into SetupJdkLibrary and SetupJdkExecutable.

-------------

Commit messages:
 - 8328177: Move LDFLAGS_JDK[LIB/EXE] to JdkNativeCompilation.gmk

Changes: https://git.openjdk.org/jdk/pull/18343/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18343&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8328177
  Stats: 155 lines in 32 files changed: 29 ins; 99 del; 27 mod
  Patch: https://git.openjdk.org/jdk/pull/18343.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18343/head:pull/18343

PR: https://git.openjdk.org/jdk/pull/18343

From abhiscxk at openjdk.org  Mon Mar 18 11:52:35 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Mon, 18 Mar 2024 11:52:35 GMT
Subject: Integrated: 8328248: Convert
 javax/swing/JSlider/6587742/bug6587742.java applet test to main
In-Reply-To: <zudlyAHwM4k8coUTGWVcF3b7uHwYpBPZwhUS9ecExqY=.2d5ec5ca-aecb-4e68-85f9-1b57cf2b2b36@github.com>
References: <zudlyAHwM4k8coUTGWVcF3b7uHwYpBPZwhUS9ecExqY=.2d5ec5ca-aecb-4e68-85f9-1b57cf2b2b36@github.com>
Message-ID: <TWQYUMEMCJQfUIUEfUejkExD3B6ltGv92lQnyufhSR0=.08bb0d6b-c270-41f1-b638-89a01d976957@github.com>

On Fri, 15 Mar 2024 07:29:53 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

> Conversion of manual applet test to main based using PassFailJFrame manual framework

This pull request has now been integrated.

Changeset: 86f17447
Author:    Abhishek Kumar <abhiscxk at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/86f17447362483162a5983c270e0b530d8d99354
Stats:     332 lines in 3 files changed: 166 ins; 166 del; 0 mod

8328248: Convert javax/swing/JSlider/6587742/bug6587742.java applet test to main

Reviewed-by: azvegint, tr

-------------

PR: https://git.openjdk.org/jdk/pull/18323

From abhiscxk at openjdk.org  Mon Mar 18 11:56:27 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Mon, 18 Mar 2024 11:56:27 GMT
Subject: RFR: 8327980: Convert
 javax/swing/JToggleButton/4128979/bug4128979.java applet test to main [v2]
In-Reply-To: <ZqXC3FEtY0pXKoXFcvxL3z-qR-3RkQZ3LlHPyE2IRzw=.440fd1d1-56b2-47f0-9efc-3b33593edf60@github.com>
References: <lZHt9pYb75UtaIEtbB0paOkfqR5CUAc6tikhb9YAakU=.ff2adbed-1db2-490a-8747-66ac96d03657@github.com>
 <h9V1lpm9LrxoTXicUWMB1SyIDjJmPXlp5ohLCmpt3Kw=.32d56f64-83ae-47cc-86ec-efe8a568e038@github.com>
 <ZqXC3FEtY0pXKoXFcvxL3z-qR-3RkQZ3LlHPyE2IRzw=.440fd1d1-56b2-47f0-9efc-3b33593edf60@github.com>
Message-ID: <fEpsdYfNajg1RZ16-ZDlE5TRgYe4B1c4AK11q_9Z1_I=.15668854-f254-43c3-8080-b2647dc8b28c@github.com>

On Thu, 14 Mar 2024 17:05:04 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review comment fix
>
> Please remove unused imports

@honkar-jdk Please take a look.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18233#issuecomment-2003712693

From abhiscxk at openjdk.org  Mon Mar 18 11:56:54 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Mon, 18 Mar 2024 11:56:54 GMT
Subject: RFR: 8328244: Convert javax/swing/JSlider/6742358/bug6742358.java
 applet test to main [v4]
In-Reply-To: <AN6EAjyACY33ukKyOjp8SuzxRt80B9Z_UO1fy83Nijw=.42fbb5cd-fb5c-413d-a1f2-842657fa7f0e@github.com>
References: <AN6EAjyACY33ukKyOjp8SuzxRt80B9Z_UO1fy83Nijw=.42fbb5cd-fb5c-413d-a1f2-842657fa7f0e@github.com>
Message-ID: <tg3ksJkHLr36rUBzWL7NG7vyBTyBqYm76KV4OOso5HQ=.3d3050cd-a562-42d1-839e-8c8c5071af26@github.com>

> Conversion of manual applet test to main based using PassFailJFrame manual framework

Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:

  jtreg tag update

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18321/files
  - new: https://git.openjdk.org/jdk/pull/18321/files/976964f0..bb95c4e9

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18321&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18321&range=02-03

  Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/18321.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18321/head:pull/18321

PR: https://git.openjdk.org/jdk/pull/18321

From abhiscxk at openjdk.org  Mon Mar 18 11:57:26 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Mon, 18 Mar 2024 11:57:26 GMT
Subject: RFR: 8327840: Automate javax/swing/border/Test4129681.java [v2]
In-Reply-To: <kRVPWD9mcBveEjQ71JkX5zJwqT0XlvIYrROgkjKVAlc=.40de0486-6b0a-42e8-b446-defba9d552ac@github.com>
References: <BbQ2iwy01dkTxtQ9Aj7RhRkSxWm3pq3BEIlGIzlSTCk=.7bdaafe4-681a-4f03-8462-4ffa7dc99507@github.com>
 <RHPY41M4MrZpauL2wMKeLtZi4az10CC1XNvrfmX0x-8=.6ac297dd-3b93-4ff8-bdda-51cd6d5a535d@github.com>
 <lphMTN_WhVHzwnErlOGTlZT4LpnJI2OwNR7IVDPQExw=.487e72e3-104d-4b01-a661-0c6de2274e5d@github.com>
 <wF59mhIj-B6RGR8ddi3YdQ3ijttapQyblwbFhzmgc6c=.c2a5b730-aeaa-48d5-8720-7a9acb783715@github.com>
 <kRVPWD9mcBveEjQ71JkX5zJwqT0XlvIYrROgkjKVAlc=.40de0486-6b0a-42e8-b446-defba9d552ac@github.com>
Message-ID: <dsA8puUnE3i0Qs35KVL_vOTPn3q9eaE7kDDTjn86bPk=.0766ebbf-a164-414c-a58b-38ea5f74185d@github.com>

On Mon, 18 Mar 2024 09:36:02 GMT, Tejesh R <tr at openjdk.org> wrote:

>>> Yeah, because its difficult to verify it automatically for all L&F.
>> 
>> Not really, this can be done. But if it is not required to check except Metal then it is ok.
>
> I meant the label position might vary slightly for different L&F, here I have hardcoded it for metal L&F...... Not sure it would remain same for all the L&F......

Since you are painting to buffered image, I don't think it should matter.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18336#discussion_r1528406112

From abhiscxk at openjdk.org  Mon Mar 18 12:03:30 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Mon, 18 Mar 2024 12:03:30 GMT
Subject: RFR: 8327840: Automate javax/swing/border/Test4129681.java [v2]
In-Reply-To: <vLPl9zuaDaTVOE0xHeQ5WN3mkNqEzArFgPNnKO3EU20=.b910622f-bb8d-4909-9c54-48c2943775f9@github.com>
References: <BbQ2iwy01dkTxtQ9Aj7RhRkSxWm3pq3BEIlGIzlSTCk=.7bdaafe4-681a-4f03-8462-4ffa7dc99507@github.com>
 <vLPl9zuaDaTVOE0xHeQ5WN3mkNqEzArFgPNnKO3EU20=.b910622f-bb8d-4909-9c54-48c2943775f9@github.com>
Message-ID: <YjxSDz7dItWEQNTf-SADS9AtqbU2CCXpMJS7gIsxP58=.b1391d5d-54d2-4fad-8fa0-54e645a2bafa@github.com>

On Mon, 18 Mar 2024 09:50:43 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Automated the Test `javax/swing/border/Test4129681.java` from manual as suggested in JBS description.
>> Verified in CI system and its Green. The test has been verified for Metal L&F and the same is set explicitly..
>
> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review updates

test/jdk/javax/swing/border/Test4129681.java line 77:

> 75:         }
> 76: 
> 77:         if (((double)correctColoredPixels / totalPixels * 100) <= tolerance) {

Minor:
Suggestion:

        if (((double) correctColoredPixels / totalPixels * 100) <= tolerance) {

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18336#discussion_r1528412319

From abhiscxk at openjdk.org  Mon Mar 18 12:09:26 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Mon, 18 Mar 2024 12:09:26 GMT
Subject: RFR: 8327879: Convert javax/swing/border/Test4760089.java applet
 test to main [v3]
In-Reply-To: <kmmRhyUGap3vchu_3SbWDiEO15b4CVJGpkrAW5RrMqw=.3771ee8b-747d-47aa-86f2-605f5497cd2b@github.com>
References: <Vq0kXwaE6TFmJzGmgpo13OA3VEqSnqsjQpDpGZj2ob4=.4f188f8b-5581-4774-8345-76363b4e3cf6@github.com>
 <kmmRhyUGap3vchu_3SbWDiEO15b4CVJGpkrAW5RrMqw=.3771ee8b-747d-47aa-86f2-605f5497cd2b@github.com>
Message-ID: <ahGGGOkzYtLKW7TvCV-h9fOV9D_ytPDL734KyZwCWis=.a1f5ed3d-b4c1-4f28-b4ac-e40945fe3f7f@github.com>

On Thu, 14 Mar 2024 05:21:03 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Convert javax/swing/border/Test4760089.java applet test to main based test using PassFailJFrame.
>
> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review updates

Marked as reviewed by abhiscxk (Committer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18217#pullrequestreview-1942774121

From abhiscxk at openjdk.org  Mon Mar 18 12:14:29 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Mon, 18 Mar 2024 12:14:29 GMT
Subject: RFR: 8328005: Convert java/awt/im/JTextFieldTest.java applet test
 to main [v3]
In-Reply-To: <Xn_2HUsUI0JCP0TWCQVonGZa2byojUgp1WMGSLQ0Huc=.396ecb47-21f2-4609-bd60-d39e2c0a1ba5@github.com>
References: <L1GhxeYrU35BXYEe9h_FL05fGrPgE7q4vWv3qTOe854=.c20a5812-ec96-4541-94b8-106dd17d9f95@github.com>
 <Xn_2HUsUI0JCP0TWCQVonGZa2byojUgp1WMGSLQ0Huc=.396ecb47-21f2-4609-bd60-d39e2c0a1ba5@github.com>
Message-ID: <RXyCXggzpKBrPgsT3GvtxCAe4BOu0clOTGndvXu6WFo=.311a1050-d82d-475c-9b7d-33d6ecf5ccb9@github.com>

On Thu, 14 Mar 2024 16:13:54 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

>> Convert java/awt/im/JTextFieldTest.java applet test to main using PassFailJFrame.
>
> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review comments

test/jdk/java/awt/im/JTextFieldTest.java line 71:

> 69:         frame.getContentPane().add(tf1);
> 70:         frame.getContentPane().add(tf2);
> 71:         frame.setDefaultCloseOperation(WindowConstants.EXIT_ON_CLOSE);

frame.setDefaultCloseOperation(WindowConstants.EXIT_ON_CLOSE);
Redundat, can be removed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18247#discussion_r1528428015

From abhiscxk at openjdk.org  Mon Mar 18 12:20:28 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Mon, 18 Mar 2024 12:20:28 GMT
Subject: RFR: 8328154: Convert sun/java2d/loops/CopyAreaSpeed.java applet
 test to main
In-Reply-To: <QHf2yYI8zQSoqYjld0VQjVQmFWrIk2f53wArMF0qL14=.a7a41b62-f301-4c7a-9da4-09603d95cbd5@github.com>
References: <QHf2yYI8zQSoqYjld0VQjVQmFWrIk2f53wArMF0qL14=.a7a41b62-f301-4c7a-9da4-09603d95cbd5@github.com>
Message-ID: <CGvCZje1fitO6Vr8OTDxKvxxRz6o9sXwBhrPkAs7wrI=.1718699d-13e2-43c5-a0bc-47744a450a6a@github.com>

On Thu, 14 Mar 2024 10:39:15 GMT, Tejesh R <tr at openjdk.org> wrote:

> Convert  sun/java2d/loops/CopyAreaSpeed.java manual applet test to main based using PassFailJFrame. This is a performance measurement test which provide benchmark to compare the outcome with different releases. I have converted the test using a PassFailJFrame though PASS/FAIL doesn't matter here. The result have been shown in `JOptionPane` message.

Marked as reviewed by abhiscxk (Committer).

test/jdk/sun/java2d/loops/CopyAreaSpeed.java line 52:

> 50:                     "of copyArea calls to be completed. Because the performance ",
> 51:                     "measurement is relative, this code only provides a benchmark ",
> 52:                     "to run with different releases to compare the outcomes."

Bit of clean-up, double-quotes can be removed.

-------------

PR Review: https://git.openjdk.org/jdk/pull/18296#pullrequestreview-1942798677
PR Review Comment: https://git.openjdk.org/jdk/pull/18296#discussion_r1528434348

From abhiscxk at openjdk.org  Mon Mar 18 12:28:30 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Mon, 18 Mar 2024 12:28:30 GMT
Subject: RFR: JDK-8328190 : Convert AWTPanelSmoothWheel.html applet test to
 main [v3]
In-Reply-To: <MPJgRPFs3q9yLE9tiHUrRqh-dPdkg_Kqwf9u1CfuS-8=.7e4e33f7-d775-446a-aeef-8a126f4dba4a@github.com>
References: <sn9qb9ctS_sr3isHbwcbMCYh2RQokz2ptsw0rGBRnJY=.955d7549-72c7-4a4f-8ac8-a5d6f122cf68@github.com>
 <MPJgRPFs3q9yLE9tiHUrRqh-dPdkg_Kqwf9u1CfuS-8=.7e4e33f7-d775-446a-aeef-8a126f4dba4a@github.com>
Message-ID: <Copfo7e_14Z5HM23jnUixI6EfnLQUYD72zCtzIX0do8=.e820764d-e181-4251-8c32-b082e5b3c60b@github.com>

On Sat, 16 Mar 2024 22:34:10 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> This test is converted to main using PassFailJFrame. It verifies wheel rotation value for high-res mouse on windows.
>> 
>> The test requires the updated PassFailJFrame's logArea() feature added in this PR https://github.com/openjdk/jdk/pull/18319
>
> Harshitha Onkar has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 10 additional commits since the last revision:
> 
>  - used PassFailJFrame.logArea()
>  - Merge branch 'master' into WheelRotation_8328190
>  - ordering of imports
>  - whitespace removed
>  - default timeout used
>  - @requires tag
>  - title change
>  - converted test to main
>  - delete .html file
>  - moved test file

test/jdk/java/awt/event/MouseEvent/AWTPanelSmoothWheel.java line 55:

> 53: 
> 54:     public static void main (String[] args) throws Exception {
> 55:         PassFailJFrame.builder()

OS check can be added. https://github.com/openjdk/jdk/pull/18233#discussion_r1525227378

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18312#discussion_r1528444067

From tr at openjdk.org  Mon Mar 18 13:29:37 2024
From: tr at openjdk.org (Tejesh R)
Date: Mon, 18 Mar 2024 13:29:37 GMT
Subject: RFR: 8327840: Automate javax/swing/border/Test4129681.java [v3]
In-Reply-To: <BbQ2iwy01dkTxtQ9Aj7RhRkSxWm3pq3BEIlGIzlSTCk=.7bdaafe4-681a-4f03-8462-4ffa7dc99507@github.com>
References: <BbQ2iwy01dkTxtQ9Aj7RhRkSxWm3pq3BEIlGIzlSTCk=.7bdaafe4-681a-4f03-8462-4ffa7dc99507@github.com>
Message-ID: <7mXA4yB1IQMruvOFP2-u6IIiYPDX-wW8nnTIScNuqPQ=.75f7794c-27f6-4759-b3a2-ff65fbf367b8@github.com>

> Automated the Test `javax/swing/border/Test4129681.java` from manual as suggested in JBS description.
> Verified in CI system and its Green. The test has been verified for Metal L&F and the same is set explicitly..

Tejesh R has updated the pull request incrementally with one additional commit since the last revision:

  Review updates

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18336/files
  - new: https://git.openjdk.org/jdk/pull/18336/files/cfb599ff..029be55c

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18336&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18336&range=01-02

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/18336.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18336/head:pull/18336

PR: https://git.openjdk.org/jdk/pull/18336

From psadhukhan at openjdk.org  Mon Mar 18 13:30:29 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Mon, 18 Mar 2024 13:30:29 GMT
Subject: RFR: 8328035: Convert
 javax/swing/text/html/TableView/7030332/bug7030332.java applet test to main
 [v2]
In-Reply-To: <6SPvUhuB-QIgakHdRqx1_LzOADDQNU25xRz7k2obSZc=.ac2b9979-d177-412e-be68-7b10f9a3a0ae@github.com>
References: <sa4wl3VTL1p3Zxmat10wUsqex-uQewN2R2N8tXTwFFo=.013c255b-d875-4b52-a0f0-403664011199@github.com>
 <_k4T1yzAqADVQLTUScWnfSqbGYg-YZJ9SecWpQB55kM=.ffa6e901-7cee-40b6-954a-528dfb04dc83@github.com>
 <czzx6URRvyadj98-Yf5hr87K7wDcKpAlQ6R_vEtlI9M=.957c488a-bb26-4dc9-8e90-e02a5c894ef1@github.com>
 <6SPvUhuB-QIgakHdRqx1_LzOADDQNU25xRz7k2obSZc=.ac2b9979-d177-412e-be68-7b10f9a3a0ae@github.com>
Message-ID: <_tDJv5UgWgGj_eogkTzVvY7YvJtzckfxRAQs_pDzBsw=.f905413d-f540-41f2-a464-c647822de64d@github.com>

On Mon, 18 Mar 2024 09:37:23 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> > > > > I am not sure but to me the images dont seem to match in windows11..it seems JEditorPane image is 1 pixel thicker than golden images...in which case, it needs to be problemlisted Also, I guess this has potential of making it automated by loading the golden images and JEditorPane in BufferedImage and then compare...
> > > > > ![image](https://private-user-images.githubusercontent.com/43534309/313576442-c9b84f20-5b0c-44f2-a9a8-c5568d1b0ef4.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTA3NTM2MTEsIm5iZiI6MTcxMDc1MzMxMSwicGF0aCI6Ii80MzUzNDMwOS8zMTM1NzY0NDItYzliODRmMjAtNWIwYy00NGYyLWE5YTgtYzU1NjhkMWIwZWY0LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAzMTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMzE4VDA5MTUxMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWY2NjJmNzRmMzBjMzUyMzUxOWRiODBmZGJmNGU5Zjc4NThmMTUwZjc4NWJkN2NhYWI0ZmE4YWJkYmZkYTg3YjgmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.c3EEHxT_VGBlWLLQkH4xIdbcXBBuvpYoNW3KQfZNgAw)
> > > > 
> > > > 
> > > > You mean to say the border of JEditorPane is 1 pixel thicker ?
> > > 
> > > 
> > > it doesn't look exactly same subjectively...
> > > ![image](https://private-user-images.githubusercontent.com/43534309/313618601-15dcdcab-fdf4-4bf4-8ef8-7c0689d6b538.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTA3NTQyNDIsIm5iZiI6MTcxMDc1Mzk0MiwicGF0aCI6Ii80MzUzNDMwOS8zMTM2MTg2MDEtMTVkY2RjYWItZmRmNC00YmY0LThlZjgtN2MwNjg5ZDZiNTM4LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAzMTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMzE4VDA5MjU0MlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTU3NmZmMGZhNDUyYzM2Y2UyNGExN2QyZjFiNjljZDljMTE2NDdiMmM4NzIwYzgzOTdjYWJmZGY5ZDdjOTkwMTYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.d_TI9VegwGDfOcO0zHhgHhxtOHRiTZudNBS0IXIIGhI)
> > 
> > 
> > Yeah, but in instructions they say it should look similar, so wasn't sure whether to problem list or proceed with conversion. You think we should problem list?
> 
> I am not sure...I think there was some fix regarding border stroke sometime back either by @honkar-jdk or @DamonGuy . Maybe expectation should be somewhat different now in which case, probably the instructions should be amended accordingly...Let them verify once..

or maybe run the test with uiScale 1.0 as I believe the golden images are generated without any scaling and windows has default 1.25/1.5 scaling

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18260#issuecomment-2003905130

From tr at openjdk.org  Mon Mar 18 13:36:27 2024
From: tr at openjdk.org (Tejesh R)
Date: Mon, 18 Mar 2024 13:36:27 GMT
Subject: RFR: 8328035: Convert
 javax/swing/text/html/TableView/7030332/bug7030332.java applet test to main
 [v2]
In-Reply-To: <_tDJv5UgWgGj_eogkTzVvY7YvJtzckfxRAQs_pDzBsw=.f905413d-f540-41f2-a464-c647822de64d@github.com>
References: <sa4wl3VTL1p3Zxmat10wUsqex-uQewN2R2N8tXTwFFo=.013c255b-d875-4b52-a0f0-403664011199@github.com>
 <_k4T1yzAqADVQLTUScWnfSqbGYg-YZJ9SecWpQB55kM=.ffa6e901-7cee-40b6-954a-528dfb04dc83@github.com>
 <czzx6URRvyadj98-Yf5hr87K7wDcKpAlQ6R_vEtlI9M=.957c488a-bb26-4dc9-8e90-e02a5c894ef1@github.com>
 <6SPvUhuB-QIgakHdRqx1_LzOADDQNU25xRz7k2obSZc=.ac2b9979-d177-412e-be68-7b10f9a3a0ae@github.com>
 <_tDJv5UgWgGj_eogkTzVvY7YvJtzckfxRAQs_pDzBsw=.f905413d-f540-41f2-a464-c647822de64d@github.com>
Message-ID: <ggTu-wk_mgGw32oJ2CT0-VEeYon_AFHXBulbDvJyiYk=.dda56523-ac38-42f9-a09f-87bd9293b241@github.com>

On Mon, 18 Mar 2024 13:27:56 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>>> > > > I am not sure but to me the images dont seem to match in windows11..it seems JEditorPane image is 1 pixel thicker than golden images...in which case, it needs to be problemlisted Also, I guess this has potential of making it automated by loading the golden images and JEditorPane in BufferedImage and then compare...
>>> > > > ![image](https://private-user-images.githubusercontent.com/43534309/313576442-c9b84f20-5b0c-44f2-a9a8-c5568d1b0ef4.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTA3NTM2MTEsIm5iZiI6MTcxMDc1MzMxMSwicGF0aCI6Ii80MzUzNDMwOS8zMTM1NzY0NDItYzliODRmMjAtNWIwYy00NGYyLWE5YTgtYzU1NjhkMWIwZWY0LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAzMTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMzE4VDA5MTUxMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWY2NjJmNzRmMzBjMzUyMzUxOWRiODBmZGJmNGU5Zjc4NThmMTUwZjc4NWJkN2NhYWI0ZmE4YWJkYmZkYTg3YjgmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.c3EEHxT_VGBlWLLQkH4xIdbcXBBuvpYoNW3KQfZNgAw)
>>> > > 
>>> > > 
>>> > > You mean to say the border of JEditorPane is 1 pixel thicker ?
>>> > 
>>> > 
>>> > it doesn't look exactly same subjectively...
>>> > ![image](https://private-user-images.githubusercontent.com/43534309/313618601-15dcdcab-fdf4-4bf4-8ef8-7c0689d6b538.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTA3NTQyNDIsIm5iZiI6MTcxMDc1Mzk0MiwicGF0aCI6Ii80MzUzNDMwOS8zMTM2MTg2MDEtMTVkY2RjYWItZmRmNC00YmY0LThlZjgtN2MwNjg5ZDZiNTM4LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAzMTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMzE4VDA5MjU0MlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTU3NmZmMGZhNDUyYzM2Y2UyNGExN2QyZjFiNjljZDljMTE2NDdiMmM4NzIwYzgzOTdjYWJmZGY5ZDdjOTkwMTYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.d_TI9VegwGDfOcO0zHhgHhxtOHRiTZudNBS0IXIIGhI)
>>> 
>>> Yeah, but in instructions they say it should look similar, so wasn't sure whether to problem list or proceed with conversion. You think we should problem list?
>> 
>> I am not sure...I think there was some fix regarding border stroke sometime back either by @honkar-jdk or @DamonGuy . Maybe expectation should be somewhat different now in which case...
>
>> > > > > I am not sure but to me the images dont seem to match in windows11..it seems JEditorPane image is 1 pixel thicker than golden images...in which case, it needs to be problemlisted Also, I guess this has potential of making it automated by loading the golden images and JEditorPane in BufferedImage and then compare...
>> > > > > ![image](https://private-user-images.githubusercontent.com/43534309/313576442-c9b84f20-5b0c-44f2-a9a8-c5568d1b0ef4.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTA3NTM2MTEsIm5iZiI6MTcxMDc1MzMxMSwicGF0aCI6Ii80MzUzNDMwOS8zMTM1NzY0NDItYzliODRmMjAtNWIwYy00NGYyLWE5YTgtYzU1NjhkMWIwZWY0LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAzMTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMzE4VDA5MTUxMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWY2NjJmNzRmMzBjMzUyMzUxOWRiODBmZGJmNGU5Zjc4NThmMTUwZjc4NWJkN2NhYWI0ZmE4YWJkYmZkYTg3YjgmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.c3EEHxT_VGBlWLLQkH4xIdbcXBBuvpYoNW3KQfZNgAw)
>> > > > 
>> > > > 
>> > > > You mean to say the border of JEditorPane is 1 pixel thicker ?
>> > > 
>> > > 
>> > > it doesn't look exactly same subjectively...
>> > > ![image](https://private-user-images.githubusercontent.com/43534309/313618601-15dcdcab-fdf4-4bf4-8ef8-7c0689d6b538.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTA3NTQyNDIsIm5iZiI6MTcxMDc1Mzk0MiwicGF0aCI6Ii80MzUzNDMwOS8zMTM2MTg2MDEtMTVkY2RjYWItZmRmNC00YmY0LThlZjgtN2MwNjg5ZDZiNTM4LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAzMTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMzE4VDA5MjU0MlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTU3NmZmMGZhNDUyYzM2Y2UyNGExN2QyZjFiNjljZDljMTE2NDdiMmM4NzIwYzgzOTdjYWJmZGY5ZDdjOTkwMTYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.d_TI9VegwGDfOcO0zHhgHhxtOHRiTZudNBS0IXIIGhI)
>> > 
>> > 
>> > Yeah, but in instructions they say it should look similar, so wasn't sure whether to problem list or proceed with conversion. You think we should problem list?
>> 
>> I am not sure...I think there was some fix regarding border stroke sometime back either by @honkar-jdk or @DamonGuy . Maybe expectation should be somewhat different n...

@prsadhuk With scaling 1.0 it'll appear this way. I think it's supposed to be 1.0 scaling and its looking similar now.
![image](https://github.com/openjdk/jdk/assets/94159358/92e4358b-651d-43d9-bdc8-cb4a44aa021c)

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18260#issuecomment-2003914767

From psadhukhan at openjdk.org  Mon Mar 18 14:09:28 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Mon, 18 Mar 2024 14:09:28 GMT
Subject: RFR: 8328035: Convert
 javax/swing/text/html/TableView/7030332/bug7030332.java applet test to main
 [v2]
In-Reply-To: <_tDJv5UgWgGj_eogkTzVvY7YvJtzckfxRAQs_pDzBsw=.f905413d-f540-41f2-a464-c647822de64d@github.com>
References: <sa4wl3VTL1p3Zxmat10wUsqex-uQewN2R2N8tXTwFFo=.013c255b-d875-4b52-a0f0-403664011199@github.com>
 <_k4T1yzAqADVQLTUScWnfSqbGYg-YZJ9SecWpQB55kM=.ffa6e901-7cee-40b6-954a-528dfb04dc83@github.com>
 <czzx6URRvyadj98-Yf5hr87K7wDcKpAlQ6R_vEtlI9M=.957c488a-bb26-4dc9-8e90-e02a5c894ef1@github.com>
 <6SPvUhuB-QIgakHdRqx1_LzOADDQNU25xRz7k2obSZc=.ac2b9979-d177-412e-be68-7b10f9a3a0ae@github.com>
 <_tDJv5UgWgGj_eogkTzVvY7YvJtzckfxRAQs_pDzBsw=.f905413d-f540-41f2-a464-c647822de64d@github.com>
Message-ID: <FAjlZDEEsrqlCQNM2ts-63ItAXkujwyx5Mpuc81trfk=.1090d65d-01a7-4b3d-9b97-2695af6c73fa@github.com>

On Mon, 18 Mar 2024 13:27:56 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>>> > > > I am not sure but to me the images dont seem to match in windows11..it seems JEditorPane image is 1 pixel thicker than golden images...in which case, it needs to be problemlisted Also, I guess this has potential of making it automated by loading the golden images and JEditorPane in BufferedImage and then compare...
>>> > > > ![image](https://private-user-images.githubusercontent.com/43534309/313576442-c9b84f20-5b0c-44f2-a9a8-c5568d1b0ef4.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTA3NTM2MTEsIm5iZiI6MTcxMDc1MzMxMSwicGF0aCI6Ii80MzUzNDMwOS8zMTM1NzY0NDItYzliODRmMjAtNWIwYy00NGYyLWE5YTgtYzU1NjhkMWIwZWY0LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAzMTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMzE4VDA5MTUxMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWY2NjJmNzRmMzBjMzUyMzUxOWRiODBmZGJmNGU5Zjc4NThmMTUwZjc4NWJkN2NhYWI0ZmE4YWJkYmZkYTg3YjgmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.c3EEHxT_VGBlWLLQkH4xIdbcXBBuvpYoNW3KQfZNgAw)
>>> > > 
>>> > > 
>>> > > You mean to say the border of JEditorPane is 1 pixel thicker ?
>>> > 
>>> > 
>>> > it doesn't look exactly same subjectively...
>>> > ![image](https://private-user-images.githubusercontent.com/43534309/313618601-15dcdcab-fdf4-4bf4-8ef8-7c0689d6b538.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTA3NTQyNDIsIm5iZiI6MTcxMDc1Mzk0MiwicGF0aCI6Ii80MzUzNDMwOS8zMTM2MTg2MDEtMTVkY2RjYWItZmRmNC00YmY0LThlZjgtN2MwNjg5ZDZiNTM4LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAzMTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMzE4VDA5MjU0MlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTU3NmZmMGZhNDUyYzM2Y2UyNGExN2QyZjFiNjljZDljMTE2NDdiMmM4NzIwYzgzOTdjYWJmZGY5ZDdjOTkwMTYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.d_TI9VegwGDfOcO0zHhgHhxtOHRiTZudNBS0IXIIGhI)
>>> 
>>> Yeah, but in instructions they say it should look similar, so wasn't sure whether to problem list or proceed with conversion. You think we should problem list?
>> 
>> I am not sure...I think there was some fix regarding border stroke sometime back either by @honkar-jdk or @DamonGuy . Maybe expectation should be somewhat different now in which case...
>
>> > > > > I am not sure but to me the images dont seem to match in windows11..it seems JEditorPane image is 1 pixel thicker than golden images...in which case, it needs to be problemlisted Also, I guess this has potential of making it automated by loading the golden images and JEditorPane in BufferedImage and then compare...
>> > > > > ![image](https://private-user-images.githubusercontent.com/43534309/313576442-c9b84f20-5b0c-44f2-a9a8-c5568d1b0ef4.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTA3NTM2MTEsIm5iZiI6MTcxMDc1MzMxMSwicGF0aCI6Ii80MzUzNDMwOS8zMTM1NzY0NDItYzliODRmMjAtNWIwYy00NGYyLWE5YTgtYzU1NjhkMWIwZWY0LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAzMTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMzE4VDA5MTUxMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWY2NjJmNzRmMzBjMzUyMzUxOWRiODBmZGJmNGU5Zjc4NThmMTUwZjc4NWJkN2NhYWI0ZmE4YWJkYmZkYTg3YjgmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.c3EEHxT_VGBlWLLQkH4xIdbcXBBuvpYoNW3KQfZNgAw)
>> > > > 
>> > > > 
>> > > > You mean to say the border of JEditorPane is 1 pixel thicker ?
>> > > 
>> > > 
>> > > it doesn't look exactly same subjectively...
>> > > ![image](https://private-user-images.githubusercontent.com/43534309/313618601-15dcdcab-fdf4-4bf4-8ef8-7c0689d6b538.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTA3NTQyNDIsIm5iZiI6MTcxMDc1Mzk0MiwicGF0aCI6Ii80MzUzNDMwOS8zMTM2MTg2MDEtMTVkY2RjYWItZmRmNC00YmY0LThlZjgtN2MwNjg5ZDZiNTM4LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAzMTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMzE4VDA5MjU0MlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTU3NmZmMGZhNDUyYzM2Y2UyNGExN2QyZjFiNjljZDljMTE2NDdiMmM4NzIwYzgzOTdjYWJmZGY5ZDdjOTkwMTYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.d_TI9VegwGDfOcO0zHhgHhxtOHRiTZudNBS0IXIIGhI)
>> > 
>> > 
>> > Yeah, but in instructions they say it should look similar, so wasn't sure whether to problem list or proceed with conversion. You think we should problem list?
>> 
>> I am not sure...I think there was some fix regarding border stroke sometime back either by @honkar-jdk or @DamonGuy . Maybe expectation should be somewhat different n...

> @prsadhuk With scaling 1.0 it'll appear this way. I think it's supposed to be 1.0 scaling and its looking similar now. ![image](https://private-user-images.githubusercontent.com/94159358/313696311-92e4358b-651d-43d9-bdc8-cb4a44aa021c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTA3NzA5MjMsIm5iZiI6MTcxMDc3MDYyMywicGF0aCI6Ii85NDE1OTM1OC8zMTM2OTYzMTEtOTJlNDM1OGItNjUxZC00M2Q5LWJkYzgtY2I0YTQ0YWEwMjFjLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAzMTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMzE4VDE0MDM0M1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTc0NTcyZGE3NTBlOWFhY2YxYzk3NWNjZjc4ZDliNmJlZDE5ZWZhMDA3NTc2ZDliYjJmOGJmOTEwOTdlY2M1YWEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.sSwTFVLibyG4g0u0xl92qA8fS5zU08-CP_6UICqH6Ds)

I am not sure..it still seems 1.25 bigger than golden image..."similar" word has different connotation and is very subjective....is it intentional that "same" was not mentioned?
What if we say, Earth and Mars are similar as they are planets...

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18260#issuecomment-2004016674

From azvegint at openjdk.org  Mon Mar 18 14:51:28 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Mon, 18 Mar 2024 14:51:28 GMT
Subject: RFR: JDK-8328000 : Convert /java/awt/im/8154816/bug8154816.java
 applet test to main [v2]
In-Reply-To: <Azte6I6cEY6KA72UP-XDnUYBok3Ao5KMyylStmL2owY=.bd42326d-c097-4cf7-bd7c-70f3e7ac181e@github.com>
References: <FShkxXV6Z_KcU6INfTyHyx-GfO9-xpgrDJi6ZQ0bmhE=.4cfc6764-b51b-4ab6-9323-5c7c1e2ca5e7@github.com>
 <Azte6I6cEY6KA72UP-XDnUYBok3Ao5KMyylStmL2owY=.bd42326d-c097-4cf7-bd7c-70f3e7ac181e@github.com>
Message-ID: <7M3UUufwySry70nSSRRPgCZ7UTUeFnOf3WTCpKaLmpA=.18e709e2-5f0b-4f4a-a8cf-4355fa8c05eb@github.com>

On Wed, 13 Mar 2024 17:28:41 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> The following InputMethod test, bug8154816.java is converted to main using PassFailJFrame.
>> 
>> - test renamed to PinyinIMCapsTest
>> - moved one directory above - /java/awt/im/
>> - html file deleted.
>> 
>> PS: I tried to automate this test using Robot, but was unable to produce the same effect as a keyboard keypress for Pinyin, hence keep it as a manual test.
>
> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   instructions updated

Marked as reviewed by azvegint (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18245#pullrequestreview-1943311364

From clanger at openjdk.org  Mon Mar 18 15:11:29 2024
From: clanger at openjdk.org (Christoph Langer)
Date: Mon, 18 Mar 2024 15:11:29 GMT
Subject: RFR: 8327137: Add test for ConcurrentModificationException in
 BasicDirectoryModel
In-Reply-To: <e2WB9a0OV6zGGQClxDliRZpSybk0Yf-1tghML0ddNM4=.e571d038-cbbc-4f29-8618-60c9df796169@github.com>
References: <mCqqjrXVWDB2PvpOhKHx-Hr8W6tUz6v4stztGmyAeEg=.1f95da1c-e1a5-40be-be8b-0758729fa9b9@github.com>
 <aRuO2zb4IkM3F28MH5RcfHesc1Z9i7w_uK8kSkIh6i0=.cce14bf8-3384-4e8e-9c12-4e0708dbf3ab@github.com>
 <iT0AkMDtFdmSgs9hw1n8wICk_ywpXnbklk9I-STL7WM=.d6dc05f1-7cdc-43f2-bc86-dc9e7e3bdc39@github.com>
 <MjyHoVphv3Ydr6ZvzpIwEEJa9ijiccVne_AUzme8e8c=.09ad81a2-13e9-4b6f-93c8-5a4e8e0192a1@github.com>
 <e2WB9a0OV6zGGQClxDliRZpSybk0Yf-1tghML0ddNM4=.e571d038-cbbc-4f29-8618-60c9df796169@github.com>
Message-ID: <YlEf-rnP9E5iSzk8W5YhsLokR44b_NZnU-o3RpB2yfk=.c9c0e2bc-2a86-4818-8ae7-0d6df7108060@github.com>

On Fri, 15 Mar 2024 11:39:05 GMT, Christoph Langer <clanger at openjdk.org> wrote:

> > > I added it to our testing. Results early next week.
> > 
> > 
> > @RealCLanger Thank you. I'm more interested in the failing case. How reliable does the test reproduce the problem?
> 
> Yes, it's running in 21 and 22 as well, so we'll see what happens there.

We got the following, once in jdk21u and once in jdk21u-dev on macintelx64 through the weekend:

> 2024-03-16 05:55:37.407 java[3056:1287194577] XType: Using static font registry.
> 2024-03-16 05:55:38.047 java[3056:1287194577] name is : .SFNS-Regular
> 2024-03-16 05:55:38.047 java[3056:1287194577] family is : .AppleSystemUIFont
> 2024-03-16 05:55:38.047 java[3056:1287194577] name is : .SFNS-Bold
> 2024-03-16 05:55:38.047 java[3056:1287194577] family is : .AppleSystemUIFont
> 2024-03-16 05:55:38.616 java[3056:1287194577] nsFont-name is : .AppleSystemUIFont
> 2024-03-16 05:55:38.616 java[3056:1287194577] nsFont-family is : .AppleSystemUIFont
> 2024-03-16 05:55:38.616 java[3056:1287194577] nsFont-desc-name is : .SFNS-Regular
> 2024-03-16 05:55:38.616 java[3056:1287194577] nsFont-name is : .AppleSystemUIFont
> 2024-03-16 05:55:38.617 java[3056:1287194577] nsFont-family is : .AppleSystemUIFontBold
> 2024-03-16 05:55:38.617 java[3056:1287194577] nsFont-desc-name is : .SFNS-Bold
> 2024-03-16 05:55:38.629 java[3056:1287194577] nsFont-name is : .AppleSystemUIFont
> 2024-03-16 05:55:38.629 java[3056:1287194577] nsFont-family is : .AppleSystemUIFont
> 2024-03-16 05:55:38.629 java[3056:1287194577] nsFont-desc-name is : .SFNS-Regular
> 2024-03-16 05:55:38.629 java[3056:1287194577] nsFont-name is : .AppleSystemUIFont
> 2024-03-16 05:55:38.629 java[3056:1287194577] nsFont-family is : .AppleSystemUIFontBold
> 2024-03-16 05:55:38.629 java[3056:1287194577] nsFont-desc-name is : .SFNS-Bold
> Exception in Basic L&F File Loading Thread: class java.util.ConcurrentModificationException
> java.util.ConcurrentModificationException
> 	at java.base/java.util.AbstractList$SubList.checkForComodification(AbstractList.java:906)
> 	at java.base/java.util.AbstractList$SubList.size(AbstractList.java:792)
> 	at java.base/java.util.AbstractCollection.toArray(AbstractCollection.java:143)
> 	at java.base/java.util.Collections$SynchronizedCollection.toArray(Collections.java:2310)
> 	at java.base/java.util.Vector.<init>(Vector.java:182)
> 	at java.desktop/javax.swing.plaf.basic.BasicDirectoryModel$FilesLoader$1.call(BasicDirectoryModel.java:365)
> 	at java.desktop/javax.swing.plaf.basic.BasicDirectoryModel$FilesLoader$1.call(BasicDirectoryModel.java:342)
> 	at java.desktop/sun.awt.shell.ShellFolderManager$DirectInvoker.invoke(ShellFolderManager.java:148)
> 	at java.desktop/sun.awt.shell.ShellFolder.invoke(ShellFolder.java:532)
> 	at java.desktop/sun.awt.shell.ShellFolder.invoke(ShellFolder.java:518)
> 	at java.desktop/javax.swing.plaf.basic.BasicDirectoryModel$FilesLoader.run0(BasicDirectoryModel.java:342)
> 	at java.desktop/javax.swing.plaf.basic.BasicDirectoryModel$FilesLoader.run(BasicDirectoryModel.java:295)
> 	at java.base/java.lang.Thread.run(Thread.java:1583)

So it seems to work that the test can reproduce the issue.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18109#issuecomment-2004174197

From azvegint at openjdk.org  Mon Mar 18 15:44:32 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Mon, 18 Mar 2024 15:44:32 GMT
Subject: RFR: JDK-8328190 : Convert AWTPanelSmoothWheel.html applet test to
 main [v3]
In-Reply-To: <Copfo7e_14Z5HM23jnUixI6EfnLQUYD72zCtzIX0do8=.e820764d-e181-4251-8c32-b082e5b3c60b@github.com>
References: <sn9qb9ctS_sr3isHbwcbMCYh2RQokz2ptsw0rGBRnJY=.955d7549-72c7-4a4f-8ac8-a5d6f122cf68@github.com>
 <MPJgRPFs3q9yLE9tiHUrRqh-dPdkg_Kqwf9u1CfuS-8=.7e4e33f7-d775-446a-aeef-8a126f4dba4a@github.com>
 <Copfo7e_14Z5HM23jnUixI6EfnLQUYD72zCtzIX0do8=.e820764d-e181-4251-8c32-b082e5b3c60b@github.com>
Message-ID: <5MG7j4Aphi1BnlAYJYXtR5nLkwQDM66c8dqMXpmnoW4=.51875b0f-7adb-4eb6-8951-5338bd0727ff@github.com>

On Mon, 18 Mar 2024 12:25:24 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Harshitha Onkar has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 10 additional commits since the last revision:
>> 
>>  - used PassFailJFrame.logArea()
>>  - Merge branch 'master' into WheelRotation_8328190
>>  - ordering of imports
>>  - whitespace removed
>>  - default timeout used
>>  - @requires tag
>>  - title change
>>  - converted test to main
>>  - delete .html file
>>  - moved test file
>
> test/jdk/java/awt/event/MouseEvent/AWTPanelSmoothWheel.java line 55:
> 
>> 53: 
>> 54:     public static void main (String[] args) throws Exception {
>> 55:         PassFailJFrame.builder()
> 
> OS check can be added. https://github.com/openjdk/jdk/pull/18233#discussion_r1525227378

It can be added, but I see no reason to do so.

It may be helpful for tests that can be run standalone (that don't respect the jtreg tags and depend on some other jtreg libraries), but for this one the only easy way to run it is through jtreg, so the `@requires (os.family == "windows")` is sufficient.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18312#discussion_r1528802959

From azvegint at openjdk.org  Mon Mar 18 15:57:35 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Mon, 18 Mar 2024 15:57:35 GMT
Subject: RFR: JDK-8328190 : Convert AWTPanelSmoothWheel.html applet test to
 main [v3]
In-Reply-To: <MPJgRPFs3q9yLE9tiHUrRqh-dPdkg_Kqwf9u1CfuS-8=.7e4e33f7-d775-446a-aeef-8a126f4dba4a@github.com>
References: <sn9qb9ctS_sr3isHbwcbMCYh2RQokz2ptsw0rGBRnJY=.955d7549-72c7-4a4f-8ac8-a5d6f122cf68@github.com>
 <MPJgRPFs3q9yLE9tiHUrRqh-dPdkg_Kqwf9u1CfuS-8=.7e4e33f7-d775-446a-aeef-8a126f4dba4a@github.com>
Message-ID: <xl2NuvpYpTPPIUjwmfTDxbzNys3MkxhXy6QmToUllKU=.3be9964a-dee6-4965-b562-6ad537876a45@github.com>

On Sat, 16 Mar 2024 22:34:10 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> This test is converted to main using PassFailJFrame. It verifies wheel rotation value for high-res mouse on windows.
>> 
>> The test requires the updated PassFailJFrame's logArea() feature added in this PR https://github.com/openjdk/jdk/pull/18319
>
> Harshitha Onkar has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 10 additional commits since the last revision:
> 
>  - used PassFailJFrame.logArea()
>  - Merge branch 'master' into WheelRotation_8328190
>  - ordering of imports
>  - whitespace removed
>  - default timeout used
>  - @requires tag
>  - title change
>  - converted test to main
>  - delete .html file
>  - moved test file

Marked as reviewed by azvegint (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18312#pullrequestreview-1943521440

From ihse at openjdk.org  Mon Mar 18 15:57:55 2024
From: ihse at openjdk.org (Magnus Ihse Bursie)
Date: Mon, 18 Mar 2024 15:57:55 GMT
Subject: RFR: 8307160: Fix AWT/2D/A11Y to support the permissive- flag on
 the Microsoft Visual C compiler [v50]
In-Reply-To: <oMTWDHUD8wvoaxiISrGY1ijZecfyRw2GoMN_lIENT6U=.69c833b2-1210-41ad-b08b-4775ab662243@github.com>
References: <7piLRto5nNbhYYYfENCr5ecm4M2xNtMkjkE8XhrLLQ0=.8fd1ac3a-46f8-47a8-ae37-a4abbf7757d9@github.com>
 <oMTWDHUD8wvoaxiISrGY1ijZecfyRw2GoMN_lIENT6U=.69c833b2-1210-41ad-b08b-4775ab662243@github.com>
Message-ID: <xuf6JToKZYgafEovpGhphLBEzENZYSYduo1HqkVDd78=.3b49e309-eb0e-4c25-9f35-e02f79c12374@github.com>

On Sun, 21 Jan 2024 07:58:11 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> We should set the -permissive- flag for the Microsoft Visual C compiler, as was requested by the now backed out [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). Doing so makes the Visual C compiler much less accepting of ill formed code, which will improve code quality on Windows in the future.
>
> Julian Waters has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 84 commits:
> 
>  - Merge branch 'openjdk:master' into patch-10
>  - awt_Window.cpp
>  - awt_Frame.cpp
>  - awt_Component.cpp
>  - awt_Canvas.cpp
>  - Merge branch 'openjdk:master' into patch-10
>  - Merge branch 'openjdk:master' into patch-10
>  - Fix awt_Window.cpp
>  - Fix awt_PrintJob.cpp
>  - -Zc:stringStrings no longer needed with -permissive- flags-cflags.m4
>  - ... and 74 more: https://git.openjdk.org/jdk/compare/a474b372...0f34608b

bot-keep-alive

@TheShermanTanker Did you understand the remaining changes that Phil has requested? Do you think you'll be able to fix this?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15096#issuecomment-2004305924

From honkar at openjdk.org  Mon Mar 18 16:58:32 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Mon, 18 Mar 2024 16:58:32 GMT
Subject: Integrated: JDK-8328000 : Convert /java/awt/im/8154816/bug8154816.java
 applet test to main
In-Reply-To: <FShkxXV6Z_KcU6INfTyHyx-GfO9-xpgrDJi6ZQ0bmhE=.4cfc6764-b51b-4ab6-9323-5c7c1e2ca5e7@github.com>
References: <FShkxXV6Z_KcU6INfTyHyx-GfO9-xpgrDJi6ZQ0bmhE=.4cfc6764-b51b-4ab6-9323-5c7c1e2ca5e7@github.com>
Message-ID: <nkqukkfzA_PzC1YpaeUu_0O65GJao0F7TkpDeH-hRGs=.9e845492-a38d-4fd9-9d98-5e6d7c4c6014@github.com>

On Tue, 12 Mar 2024 18:20:14 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

> The following InputMethod test, bug8154816.java is converted to main using PassFailJFrame.
> 
> - test renamed to PinyinIMCapsTest
> - moved one directory above - /java/awt/im/
> - html file deleted.
> 
> PS: I tried to automate this test using Robot, but was unable to produce the same effect as a keyboard keypress for Pinyin, hence keep it as a manual test.

This pull request has now been integrated.

Changeset: fc0472ba
Author:    Harshitha Onkar <honkar at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/fc0472baf9bad298e853bf2ca3d10dc9415272cd
Stats:     168 lines in 3 files changed: 82 ins; 86 del; 0 mod

8328000: Convert /java/awt/im/8154816/bug8154816.java applet test to main

Reviewed-by: tr, azvegint

-------------

PR: https://git.openjdk.org/jdk/pull/18245

From honkar at openjdk.org  Mon Mar 18 17:27:43 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Mon, 18 Mar 2024 17:27:43 GMT
Subject: RFR: JDK-8328190 : Convert AWTPanelSmoothWheel.html applet test to
 main [v4]
In-Reply-To: <sn9qb9ctS_sr3isHbwcbMCYh2RQokz2ptsw0rGBRnJY=.955d7549-72c7-4a4f-8ac8-a5d6f122cf68@github.com>
References: <sn9qb9ctS_sr3isHbwcbMCYh2RQokz2ptsw0rGBRnJY=.955d7549-72c7-4a4f-8ac8-a5d6f122cf68@github.com>
Message-ID: <p8toDCsUN5dAL4dDyYVndsUESgStV4k9kaORTsC30T0=.1bb5f251-baa8-4eb9-9edf-7a01bb004824@github.com>

> This test is converted to main using PassFailJFrame. It verifies wheel rotation value for high-res mouse on windows.
> 
> The test requires the updated PassFailJFrame's logArea() feature added in this PR https://github.com/openjdk/jdk/pull/18319

Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:

  minor changes

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18312/files
  - new: https://git.openjdk.org/jdk/pull/18312/files/a2b9b95a..0299e8e2

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18312&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18312&range=02-03

  Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/jdk/pull/18312.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18312/head:pull/18312

PR: https://git.openjdk.org/jdk/pull/18312

From honkar at openjdk.org  Mon Mar 18 17:30:29 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Mon, 18 Mar 2024 17:30:29 GMT
Subject: RFR: JDK-8328190 : Convert AWTPanelSmoothWheel.html applet test to
 main [v3]
In-Reply-To: <5MG7j4Aphi1BnlAYJYXtR5nLkwQDM66c8dqMXpmnoW4=.51875b0f-7adb-4eb6-8951-5338bd0727ff@github.com>
References: <sn9qb9ctS_sr3isHbwcbMCYh2RQokz2ptsw0rGBRnJY=.955d7549-72c7-4a4f-8ac8-a5d6f122cf68@github.com>
 <MPJgRPFs3q9yLE9tiHUrRqh-dPdkg_Kqwf9u1CfuS-8=.7e4e33f7-d775-446a-aeef-8a126f4dba4a@github.com>
 <Copfo7e_14Z5HM23jnUixI6EfnLQUYD72zCtzIX0do8=.e820764d-e181-4251-8c32-b082e5b3c60b@github.com>
 <5MG7j4Aphi1BnlAYJYXtR5nLkwQDM66c8dqMXpmnoW4=.51875b0f-7adb-4eb6-8951-5338bd0727ff@github.com>
Message-ID: <-76l48ZU_OawRCTXD7RyqR47QuC6WFZHpABRMf8PFyY=.6db9668d-df49-4412-b44b-d10d2ad845e3@github.com>

On Mon, 18 Mar 2024 15:39:52 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>> test/jdk/java/awt/event/MouseEvent/AWTPanelSmoothWheel.java line 55:
>> 
>>> 53: 
>>> 54:     public static void main (String[] args) throws Exception {
>>> 55:         PassFailJFrame.builder()
>> 
>> OS check can be added. https://github.com/openjdk/jdk/pull/18233#discussion_r1525227378
>
> It can be added, but I see no reason to do so.
> 
> It may be helpful for tests that can be run standalone (that don't respect the jtreg tags and depend on some other jtreg libraries), but for this one the only easy way to run it is through jtreg, so the `@requires (os.family == "windows")` is sufficient.

I agree with @azvegint, since it has @requires check in jtreg and the test will mainly be run using jtreg framework , the OS check is not strictly required.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18312#discussion_r1528977895

From honkar at openjdk.org  Mon Mar 18 17:33:28 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Mon, 18 Mar 2024 17:33:28 GMT
Subject: RFR: 8327980: Convert
 javax/swing/JToggleButton/4128979/bug4128979.java applet test to main [v2]
In-Reply-To: <s7vPeOnHKVsnZ6zzhhYacdGv5APFSHLS6A3AsUgjMhM=.16b7f28c-0d79-446f-b142-ed8585dc0399@github.com>
References: <lZHt9pYb75UtaIEtbB0paOkfqR5CUAc6tikhb9YAakU=.ff2adbed-1db2-490a-8747-66ac96d03657@github.com>
 <h9V1lpm9LrxoTXicUWMB1SyIDjJmPXlp5ohLCmpt3Kw=.32d56f64-83ae-47cc-86ec-efe8a568e038@github.com>
 <ZqXC3FEtY0pXKoXFcvxL3z-qR-3RkQZ3LlHPyE2IRzw=.440fd1d1-56b2-47f0-9efc-3b33593edf60@github.com>
 <s7vPeOnHKVsnZ6zzhhYacdGv5APFSHLS6A3AsUgjMhM=.16b7f28c-0d79-446f-b142-ed8585dc0399@github.com>
Message-ID: <C46MrJPzi0zrmbvT34uXD2jOecj78PfvQAoY4FtmrVA=.a208aaee-be1e-4439-8e9b-a34bca0089b1@github.com>

On Thu, 14 Mar 2024 17:59:04 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> test/jdk/javax/swing/JToggleButton/bug4128979.java line 69:
>> 
>>> 67: 
>>> 68:     public static void main(String[] args) throws Exception {
>>> 69:         UIManager.setLookAndFeel("com.sun.java.swing.plaf.windows.WindowsClassicLookAndFeel");
>> 
>> As the test is for Windows only it is good to have OS check along with the `@requires (os.family == "windows")` and throw skipped exception otherwise.
>> 
>> Since it is followed by setting `WindowsClassicLookAndFeel` all the more reason to include this check.
>> 
>> Suggestion:
>> 
>>          if (OSInfo.getOSType() != OSInfo.OSType.WINDOWS) {
>>             throw new SkippedException("This test is for Windows only");
>>         }
>>         UIManager.setLookAndFeel("com.sun.java.swing.plaf.windows.WindowsClassicLookAndFeel");
>
> Updated.

You can remove the OS check here if you would like to, since it is not strictly required when run as jtreg test (which is essentially the case here).

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18233#discussion_r1528981229

From dnguyen at openjdk.org  Mon Mar 18 17:39:39 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Mon, 18 Mar 2024 17:39:39 GMT
Subject: RFR: 8328368: Convert
 java/awt/image/multiresolution/MultiDisplayTest/MultiDisplayTest.java applet
 test to main
Message-ID: <VarHifZU9rXM4lqKzE_slP-8Q9K0CA65KBTCD6CD9Zc=.ec8e5b7b-cd94-43d2-9eb2-ea90997d030d@github.com>

Convert java/awt/image/multiresolution/MultiDisplayTest/MultiDisplayTest.java applet test to main using PassFailJFrame

-------------

Commit messages:
 - Move test out. Remove extra directory
 - Resize instructions
 - Initial test conversion

Changes: https://git.openjdk.org/jdk/pull/18354/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18354&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8328368
  Stats: 391 lines in 3 files changed: 184 ins; 207 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18354.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18354/head:pull/18354

PR: https://git.openjdk.org/jdk/pull/18354

From dnguyen at openjdk.org  Mon Mar 18 17:40:03 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Mon, 18 Mar 2024 17:40:03 GMT
Subject: RFR: 8328005: Convert java/awt/im/JTextFieldTest.java applet test
 to main [v4]
In-Reply-To: <L1GhxeYrU35BXYEe9h_FL05fGrPgE7q4vWv3qTOe854=.c20a5812-ec96-4541-94b8-106dd17d9f95@github.com>
References: <L1GhxeYrU35BXYEe9h_FL05fGrPgE7q4vWv3qTOe854=.c20a5812-ec96-4541-94b8-106dd17d9f95@github.com>
Message-ID: <M1vo4AmKe8F14Ot3-1JJBQuEg05q6MyAvrKUrKaItXs=.343f5a2a-f341-4fbd-8264-1059b2b19009@github.com>

> Convert java/awt/im/JTextFieldTest.java applet test to main using PassFailJFrame.

Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:

  Remove reundant window constant

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18247/files
  - new: https://git.openjdk.org/jdk/pull/18247/files/e5f694ef..c27b6139

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18247&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18247&range=02-03

  Stats: 2 lines in 1 file changed: 0 ins; 2 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18247.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18247/head:pull/18247

PR: https://git.openjdk.org/jdk/pull/18247

From dnguyen at openjdk.org  Mon Mar 18 17:40:03 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Mon, 18 Mar 2024 17:40:03 GMT
Subject: RFR: 8328005: Convert java/awt/im/JTextFieldTest.java applet test
 to main [v3]
In-Reply-To: <RXyCXggzpKBrPgsT3GvtxCAe4BOu0clOTGndvXu6WFo=.311a1050-d82d-475c-9b7d-33d6ecf5ccb9@github.com>
References: <L1GhxeYrU35BXYEe9h_FL05fGrPgE7q4vWv3qTOe854=.c20a5812-ec96-4541-94b8-106dd17d9f95@github.com>
 <Xn_2HUsUI0JCP0TWCQVonGZa2byojUgp1WMGSLQ0Huc=.396ecb47-21f2-4609-bd60-d39e2c0a1ba5@github.com>
 <RXyCXggzpKBrPgsT3GvtxCAe4BOu0clOTGndvXu6WFo=.311a1050-d82d-475c-9b7d-33d6ecf5ccb9@github.com>
Message-ID: <lHbkRvClMMl5A4qzYAlZDFMdi3yhDS7zj6hethcfleU=.0f082197-a153-4bd3-a748-9abeccc7b7ec@github.com>

On Mon, 18 Mar 2024 12:11:48 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review comments
>
> test/jdk/java/awt/im/JTextFieldTest.java line 71:
> 
>> 69:         frame.getContentPane().add(tf1);
>> 70:         frame.getContentPane().add(tf2);
>> 71:         frame.setDefaultCloseOperation(WindowConstants.EXIT_ON_CLOSE);
> 
> frame.setDefaultCloseOperation(WindowConstants.EXIT_ON_CLOSE);
> Redundat, can be removed.

Removed. Thanks!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18247#discussion_r1528989275

From kizune at openjdk.org  Mon Mar 18 17:40:42 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Mon, 18 Mar 2024 17:40:42 GMT
Subject: RFR: 8328367: Convert java/awt/Component/UpdatingBootTime test to main
Message-ID: <9gtCIzXrOP-RQJyjhkP8ibENRjEXP9rMUkEbZry4uWc=.2d949d4b-c1ed-45b0-84b9-82859af8a4b0@github.com>

Convert test to manual main
Move test to the Component folder

-------------

Commit messages:
 - 8328367: Convert java/awt/Component/UpdatingBootTime test to main

Changes: https://git.openjdk.org/jdk/pull/18355/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18355&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8328367
  Stats: 361 lines in 3 files changed: 96 ins; 265 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18355.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18355/head:pull/18355

PR: https://git.openjdk.org/jdk/pull/18355

From kizune at openjdk.org  Mon Mar 18 17:45:02 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Mon, 18 Mar 2024 17:45:02 GMT
Subject: RFR: 8328279: Convert java/awt/Cursor/CursorOverlappedPanelsTest
 test to main [v3]
In-Reply-To: <l6NLWusbqshFG9pUWWsoatnBo79fRPWVqtjLmkd3gTo=.7ca881bb-6874-4328-acb6-0b895df0e56e@github.com>
References: <l6NLWusbqshFG9pUWWsoatnBo79fRPWVqtjLmkd3gTo=.7ca881bb-6874-4328-acb6-0b895df0e56e@github.com>
Message-ID: <MUFOYKDcNJ2PGsLPn2wn0ZDFv8pKCC-I50EjlYKFlTc=.54ca1142-9d27-421c-b28d-905a8b58ef13@github.com>

> Converted to a main manual test.

Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:

  Additional fixes based on review

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18331/files
  - new: https://git.openjdk.org/jdk/pull/18331/files/c94a124e..72e6bcb9

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18331&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18331&range=01-02

  Stats: 2 lines in 1 file changed: 1 ins; 1 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18331.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18331/head:pull/18331

PR: https://git.openjdk.org/jdk/pull/18331

From kizune at openjdk.org  Mon Mar 18 17:45:03 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Mon, 18 Mar 2024 17:45:03 GMT
Subject: RFR: 8328279: Convert java/awt/Cursor/CursorOverlappedPanelsTest
 test to main [v2]
In-Reply-To: <xsm_iimQquleOOpQBW69A_zS4G_g7rL2qXri0L9GlPE=.5bc8f89d-9be7-429b-b342-482b6642ecc1@github.com>
References: <l6NLWusbqshFG9pUWWsoatnBo79fRPWVqtjLmkd3gTo=.7ca881bb-6874-4328-acb6-0b895df0e56e@github.com>
 <W5FDh69omNPRB7PRHjLyYyB9JUxKAe-RNM4wQug-cAg=.ea319c3f-0d93-4efd-9f98-d400e90d6dea@github.com>
 <xsm_iimQquleOOpQBW69A_zS4G_g7rL2qXri0L9GlPE=.5bc8f89d-9be7-429b-b342-482b6642ecc1@github.com>
Message-ID: <WkLsmjHojOAD4LzRqCvS_t_QsoLSGx-Q5isxrnWg5M0=.ff323078-ec48-4340-b2e3-608632264842@github.com>

On Mon, 18 Mar 2024 08:24:31 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fixes based on review feedback
>
> test/jdk/java/awt/Cursor/CursorOverlappedPanelsTest.java line 37:
> 
>> 35:  * @test
>> 36:  * @bug 8007155
>> 37:  * @summary [macosx] Disabled panel takes mouse input in JLayeredPane
> 
> Is the test exclusive for MacOS?

No, the bug was found on MacOS but the test is valid for all operating systems.

> test/jdk/java/awt/Cursor/CursorOverlappedPanelsTest.java line 41:
> 
>> 39:  * @build PassFailJFrame
>> 40:  * @run main/manual CursorOverlappedPanelsTest
>> 41:  */
> 
> May add a blank line after this.

Ok

> test/jdk/java/awt/Cursor/CursorOverlappedPanelsTest.java line 45:
> 
>> 43:     public static JFrame initialize() {
>> 44:         final JFrame frame = new JFrame("Overlapping Panels Cursor Test");
>> 45:         frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
> 
> frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE); redundant, can be removed.

Ok

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18331#discussion_r1528995686
PR Review Comment: https://git.openjdk.org/jdk/pull/18331#discussion_r1528995917
PR Review Comment: https://git.openjdk.org/jdk/pull/18331#discussion_r1528996362

From honkar at openjdk.org  Mon Mar 18 17:51:26 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Mon, 18 Mar 2024 17:51:26 GMT
Subject: RFR: JDK-8328299 : Convert DnDFileGroupDescriptor.html applet test
 to main
In-Reply-To: <7gn73bmbH0pkfkIHn2DYdwVXpNoZ2dgxRwbMyRxUz9E=.d2f822c9-6c6a-4d68-8c54-f1087d71144d@github.com>
References: <CTOJXaNDso7Gmw-A2kTkmsZmAWqcWllOim2Y_BGgeok=.5d62efd5-66c2-47a7-b1f0-c10f4c366b40@github.com>
 <JMSgb5T4kBS4vbQUOgin4jajdDd9xSqFOUm9eExUP44=.9d01c4da-1d84-49e4-b0c0-a7bb874a643d@github.com>
 <7gn73bmbH0pkfkIHn2DYdwVXpNoZ2dgxRwbMyRxUz9E=.d2f822c9-6c6a-4d68-8c54-f1087d71144d@github.com>
Message-ID: <WBNGrtzNqoNKRghFbjfSUWaqHguNESTzcTST4SbfuPI=.1f4cf636-0ebb-48d7-861f-36e726768673@github.com>

On Mon, 18 Mar 2024 06:04:49 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> test/jdk/ProblemList.txt line 788:
>> 
>>> 786: java/awt/xembed/server/TestXEmbedServerJava.java 8001150,8004031 generic-all
>>> 787: java/awt/Modal/PrintDialogsTest/PrintDialogsTest.java 8068378 generic-all
>>> 788: java/awt/dnd/DnDFileGroupDescriptor/DnDFileGroupDescriptor.java 8080185 macosx-all,linux-all
>> 
>> @prsadhuk While looking into the test history I noticed you had previous worked on it PR https://github.com/openjdk/jdk/pull/3406, it wasn't integrated though. Any thoughts whether to make this test windows-only or extend the test to other platforms ?
>> 
>> Your previous PR description sounds correct, when I went through the related test bugs it seemed like the test was created for windows-only issue.
>
> The reason it was not integrated was because of this [comment](https://github.com/openjdk/jdk/pull/3406#pullrequestreview-632106612) wherein it was mentioned to update the test to run without MSOutlook dependancy so that it could be run on all platforms so making it not platform dependant..

@prsadhuk Since the test still retains the MS Outlook requirement in instructions, should we make the test windows-only then ? Because having a combination of `@requires (os.family == "windows")` and problem-listing on macOS and linux seems contradicting.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18335#discussion_r1529005890

From honkar at openjdk.org  Mon Mar 18 18:03:39 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Mon, 18 Mar 2024 18:03:39 GMT
Subject: RFR: JDK-8328299 : Convert DnDFileGroupDescriptor.html applet test
 to main [v2]
In-Reply-To: <CTOJXaNDso7Gmw-A2kTkmsZmAWqcWllOim2Y_BGgeok=.5d62efd5-66c2-47a7-b1f0-c10f4c366b40@github.com>
References: <CTOJXaNDso7Gmw-A2kTkmsZmAWqcWllOim2Y_BGgeok=.5d62efd5-66c2-47a7-b1f0-c10f4c366b40@github.com>
Message-ID: <SPpKf5QhBpz-u9HlK7JeCpA7IhUj0Ze0LRGTQPOtrNA=.48034729-7bd7-4f15-90da-9f117cf2e0e0@github.com>

> Following test java/awt/dnd/DnDFileGroupDescriptor/DnDFileGroupDescriptor.html is converted to main using PassFailJFrame.
> 
> This test is currently problem-listed on macOS and linux, but as per the previous JBS bugs [[JDK-6242241](https://bugs.openjdk.org/browse/JDK-6242241), [JDK-8080185](https://bugs.openjdk.org/browse/JDK-8080185), [JDK-7147083](https://bugs.openjdk.org/browse/JDK-7147083)] this test was original created for testing DnD of MS Outlook attachments on Windows system.
> 
> Based on the test history and JBS details, I believe this should be windows-only test and should NOT be problemlisted on macOS and linux as it is **not applicable**.

Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:

  OS check removed

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18335/files
  - new: https://git.openjdk.org/jdk/pull/18335/files/0a7745fe..f586cc64

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18335&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18335&range=00-01

  Stats: 11 lines in 1 file changed: 0 ins; 8 del; 3 mod
  Patch: https://git.openjdk.org/jdk/pull/18335.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18335/head:pull/18335

PR: https://git.openjdk.org/jdk/pull/18335

From kizune at openjdk.org  Mon Mar 18 18:03:45 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Mon, 18 Mar 2024 18:03:45 GMT
Subject: RFR: 8328377: Convert java/awt/Cursor/MultiResolutionCursorTest test
 to main
Message-ID: <Y_DvKb6DvMCmv7RwRVmVh8OoSPikpEmcEbXtpVv9a20=.2809223d-537e-4de3-bb75-986db8154edc@github.com>

Convert test to manual main and move from the dedicated folder
Remove old files

-------------

Commit messages:
 - 8328377: Convert java/awt/Cursor/MultiResolutionCursorTest test to main

Changes: https://git.openjdk.org/jdk/pull/18357/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18357&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8328377
  Stats: 363 lines in 3 files changed: 98 ins; 265 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18357.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18357/head:pull/18357

PR: https://git.openjdk.org/jdk/pull/18357

From kizune at openjdk.org  Mon Mar 18 18:20:37 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Mon, 18 Mar 2024 18:20:37 GMT
Subject: RFR: 8328378: Convert java/awt/FileDialog/FileDialogForDirectories
 test to main
Message-ID: <2yId9SKzUfB9ZnRy1Ma_m6jye3Mad5UIx-mxcgcZdZ8=.b71c078f-0a57-4b4c-b1ce-a98d23df0b48@github.com>

Convert test to main manual and move to the appropriate folder
Remove old files

-------------

Commit messages:
 - 8328378: Convert java/awt/FileDialog/FileDialogForDirectories test to main

Changes: https://git.openjdk.org/jdk/pull/18358/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18358&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8328378
  Stats: 218 lines in 3 files changed: 89 ins; 129 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18358.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18358/head:pull/18358

PR: https://git.openjdk.org/jdk/pull/18358

From azvegint at openjdk.org  Mon Mar 18 18:23:27 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Mon, 18 Mar 2024 18:23:27 GMT
Subject: RFR: 8328185: Convert
 java/awt/image/MemoryLeakTest/MemoryLeakTest.java applet test to main [v2]
In-Reply-To: <fO7-Lz2ovhV9pcOGqJqX92QbrGyWgFWmW_B2Pi73ocs=.31463f6c-5cdd-4ba9-b0a6-e993807c5776@github.com>
References: <TFYjDmsHDFBm5tcakvQmk_o_3bkZxQmS8FLPZW5bI8Y=.c7bebd2f-13cb-4bae-bd85-64cbff6c17b8@github.com>
 <fO7-Lz2ovhV9pcOGqJqX92QbrGyWgFWmW_B2Pi73ocs=.31463f6c-5cdd-4ba9-b0a6-e993807c5776@github.com>
Message-ID: <ZblUtqUbjQRT7P1RYJGI358N4TKo1X3MumhwQ1jeBE8=.e3b9a52d-1e5e-455b-a97f-87d36a077a9f@github.com>

On Mon, 18 Mar 2024 06:40:36 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

>> Convert java/awt/image/MemoryLeakTest/MemoryLeakTest.java applet test to main using PassFailJFrame
>
> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove unneeded Global var. Review comments

test/jdk/java/awt/image/MemoryLeakTest/MemoryLeakTest.java line 42:

> 40: //  static boolean testPassed = false;
> 41: //    static Thread mainThread = null;
> 42: //}

Shouldn't this be removed?

test/jdk/java/awt/image/MemoryLeakTest/MemoryLeakTest.java line 74:

> 72:         if (mainThread != null) {
> 73:             mainThread.interrupt();
> 74:         }

It is still unclear why we still need this. It seems to be a remnant of the old TestDialog machinery.

test/jdk/java/awt/image/MemoryLeakTest/MemoryLeakTest.java line 122:

> 120: 
> 121:     public void componentShown(ComponentEvent e)
> 122:     {

Suggestion:

    public void componentShown(ComponentEvent e) {

for the consistency with other code

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18307#discussion_r1529039239
PR Review Comment: https://git.openjdk.org/jdk/pull/18307#discussion_r1529038235
PR Review Comment: https://git.openjdk.org/jdk/pull/18307#discussion_r1529044141

From honkar at openjdk.org  Mon Mar 18 18:36:28 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Mon, 18 Mar 2024 18:36:28 GMT
Subject: RFR: JDK-8328299 : Convert DnDFileGroupDescriptor.html applet test
 to main [v2]
In-Reply-To: <7gn73bmbH0pkfkIHn2DYdwVXpNoZ2dgxRwbMyRxUz9E=.d2f822c9-6c6a-4d68-8c54-f1087d71144d@github.com>
References: <CTOJXaNDso7Gmw-A2kTkmsZmAWqcWllOim2Y_BGgeok=.5d62efd5-66c2-47a7-b1f0-c10f4c366b40@github.com>
 <JMSgb5T4kBS4vbQUOgin4jajdDd9xSqFOUm9eExUP44=.9d01c4da-1d84-49e4-b0c0-a7bb874a643d@github.com>
 <7gn73bmbH0pkfkIHn2DYdwVXpNoZ2dgxRwbMyRxUz9E=.d2f822c9-6c6a-4d68-8c54-f1087d71144d@github.com>
Message-ID: <_-u_Wh-X-AUrhMkJ7DOsy8_4V2ndpNej7kHJxNNFM0Y=.c5c82ac9-2c75-4812-a0c2-7c77d1376b2e@github.com>

On Mon, 18 Mar 2024 06:04:49 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> test/jdk/ProblemList.txt line 788:
>> 
>>> 786: java/awt/xembed/server/TestXEmbedServerJava.java 8001150,8004031 generic-all
>>> 787: java/awt/Modal/PrintDialogsTest/PrintDialogsTest.java 8068378 generic-all
>>> 788: java/awt/dnd/DnDFileGroupDescriptor/DnDFileGroupDescriptor.java 8080185 macosx-all,linux-all
>> 
>> @prsadhuk While looking into the test history I noticed you had previous worked on it PR https://github.com/openjdk/jdk/pull/3406, it wasn't integrated though. Any thoughts whether to make this test windows-only or extend the test to other platforms ?
>> 
>> Your previous PR description sounds correct, when I went through the related test bugs it seemed like the test was created for windows-only issue.
>
> The reason it was not integrated was because of this [comment](https://github.com/openjdk/jdk/pull/3406#pullrequestreview-632106612) wherein it was mentioned to update the test to run without MSOutlook dependancy so that it could be run on all platforms so making it not platform dependant..

@prsadhuk When I read it for the 2nd time it makes sense why the @requires check was added. Since it is a manual test there is no way of knowing it has been problem-listed on macOS & linux unless someone explicitly checks the problemlist before running the test.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18335#discussion_r1529061835

From dnguyen at openjdk.org  Mon Mar 18 18:37:37 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Mon, 18 Mar 2024 18:37:37 GMT
Subject: RFR: 8328185: Convert
 java/awt/image/MemoryLeakTest/MemoryLeakTest.java applet test to main [v3]
In-Reply-To: <TFYjDmsHDFBm5tcakvQmk_o_3bkZxQmS8FLPZW5bI8Y=.c7bebd2f-13cb-4bae-bd85-64cbff6c17b8@github.com>
References: <TFYjDmsHDFBm5tcakvQmk_o_3bkZxQmS8FLPZW5bI8Y=.c7bebd2f-13cb-4bae-bd85-64cbff6c17b8@github.com>
Message-ID: <VPrElIN7VYUCvc_XgX8HmPz90hc2x-MyPW94iSbF_74=.b74cf677-4ed1-4aa0-97f2-083d8c4d0235@github.com>

> Convert java/awt/image/MemoryLeakTest/MemoryLeakTest.java applet test to main using PassFailJFrame

Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:

  Review changes

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18307/files
  - new: https://git.openjdk.org/jdk/pull/18307/files/fb3d566e..5155ccfc

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18307&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18307&range=01-02

  Stats: 12 lines in 1 file changed: 0 ins; 11 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/18307.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18307/head:pull/18307

PR: https://git.openjdk.org/jdk/pull/18307

From azvegint at openjdk.org  Mon Mar 18 18:37:37 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Mon, 18 Mar 2024 18:37:37 GMT
Subject: RFR: 8328185: Convert
 java/awt/image/MemoryLeakTest/MemoryLeakTest.java applet test to main [v3]
In-Reply-To: <VPrElIN7VYUCvc_XgX8HmPz90hc2x-MyPW94iSbF_74=.b74cf677-4ed1-4aa0-97f2-083d8c4d0235@github.com>
References: <TFYjDmsHDFBm5tcakvQmk_o_3bkZxQmS8FLPZW5bI8Y=.c7bebd2f-13cb-4bae-bd85-64cbff6c17b8@github.com>
 <VPrElIN7VYUCvc_XgX8HmPz90hc2x-MyPW94iSbF_74=.b74cf677-4ed1-4aa0-97f2-083d8c4d0235@github.com>
Message-ID: <4egUwPwq2ivWAMjbI-q2Hy3UX3U-OxxDADN7C1v1eZM=.8718315f-6d6b-4d8f-85f6-20475a5fa061@github.com>

On Mon, 18 Mar 2024 18:35:23 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

>> Convert java/awt/image/MemoryLeakTest/MemoryLeakTest.java applet test to main using PassFailJFrame
>
> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review changes

Marked as reviewed by azvegint (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18307#pullrequestreview-1943885059

From dnguyen at openjdk.org  Mon Mar 18 18:37:39 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Mon, 18 Mar 2024 18:37:39 GMT
Subject: RFR: 8328185: Convert
 java/awt/image/MemoryLeakTest/MemoryLeakTest.java applet test to main [v3]
In-Reply-To: <F6adbGUfdGwkbg6GwOxMhhSih2ImOflTuJNT2BOAGSs=.525d8696-72fb-43dd-9a34-cb906e730106@github.com>
References: <TFYjDmsHDFBm5tcakvQmk_o_3bkZxQmS8FLPZW5bI8Y=.c7bebd2f-13cb-4bae-bd85-64cbff6c17b8@github.com>
 <F6adbGUfdGwkbg6GwOxMhhSih2ImOflTuJNT2BOAGSs=.525d8696-72fb-43dd-9a34-cb906e730106@github.com>
Message-ID: <hTk927MIxoxS2CZUv1UOYPsMJ9ipeoucUbSGbDmlMGU=.2ae8d81a-9ed3-4e84-927d-b84d45aae1d2@github.com>

On Fri, 15 Mar 2024 05:06:23 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review changes
>
> test/jdk/java/awt/image/MemoryLeakTest/MemoryLeakTest.java line 67:
> 
>> 65:             .rows(15)
>> 66:             .columns(40)
>> 67:             .testUI(new MemoryLeak())
> 
> It currently creates the MemoryLeak(aka Frame) on the main thread, instead of EDT.
> 
> Suggestion:
> 
>             .testUI(MemoryLeak::new)

Completely missed this. Thanks!

> test/jdk/java/awt/image/MemoryLeakTest/MemoryLeakTest.java line 77:
> 
>> 75:             Thread.sleep(300000);
>> 76:         } catch (InterruptedException e) {
>> 77:             if (!Globals.testPassed) {
> 
> It looks like `Globals.testPassed` is never changed, so the test will always fail.
> Shouldn't this be controlled by the PassFailJFrame Pass/Fail buttons?

Good point. Removed

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18307#discussion_r1529062753
PR Review Comment: https://git.openjdk.org/jdk/pull/18307#discussion_r1529062212

From dnguyen at openjdk.org  Mon Mar 18 18:37:39 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Mon, 18 Mar 2024 18:37:39 GMT
Subject: RFR: 8328185: Convert
 java/awt/image/MemoryLeakTest/MemoryLeakTest.java applet test to main [v2]
In-Reply-To: <ZblUtqUbjQRT7P1RYJGI358N4TKo1X3MumhwQ1jeBE8=.e3b9a52d-1e5e-455b-a97f-87d36a077a9f@github.com>
References: <TFYjDmsHDFBm5tcakvQmk_o_3bkZxQmS8FLPZW5bI8Y=.c7bebd2f-13cb-4bae-bd85-64cbff6c17b8@github.com>
 <fO7-Lz2ovhV9pcOGqJqX92QbrGyWgFWmW_B2Pi73ocs=.31463f6c-5cdd-4ba9-b0a6-e993807c5776@github.com>
 <ZblUtqUbjQRT7P1RYJGI358N4TKo1X3MumhwQ1jeBE8=.e3b9a52d-1e5e-455b-a97f-87d36a077a9f@github.com>
Message-ID: <kRjV2XV3vpE8oUeDLhxVU7-q3z0mtqu_DHEvmIQRwkw=.ac1bbc4b-0a21-4588-bd06-fe6f3b594d12@github.com>

On Mon, 18 Mar 2024 18:16:52 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove unneeded Global var. Review comments
>
> test/jdk/java/awt/image/MemoryLeakTest/MemoryLeakTest.java line 42:
> 
>> 40: //  static boolean testPassed = false;
>> 41: //    static Thread mainThread = null;
>> 42: //}
> 
> Shouldn't this be removed?

Thanks! Missed this when testing the behavior of the change.

> test/jdk/java/awt/image/MemoryLeakTest/MemoryLeakTest.java line 74:
> 
>> 72:         if (mainThread != null) {
>> 73:             mainThread.interrupt();
>> 74:         }
> 
> It is still unclear why we still need this. It seems to be a remnant of the old TestDialog machinery.

I initially thought this may be needed, but looks like you're right. Removed, thanks for the help!

> test/jdk/java/awt/image/MemoryLeakTest/MemoryLeakTest.java line 122:
> 
>> 120: 
>> 121:     public void componentShown(ComponentEvent e)
>> 122:     {
> 
> Suggestion:
> 
>     public void componentShown(ComponentEvent e) {
> 
> for the consistency with other code

Thanks!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18307#discussion_r1529061170
PR Review Comment: https://git.openjdk.org/jdk/pull/18307#discussion_r1529061895
PR Review Comment: https://git.openjdk.org/jdk/pull/18307#discussion_r1529060923

From honkar at openjdk.org  Mon Mar 18 18:42:30 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Mon, 18 Mar 2024 18:42:30 GMT
Subject: RFR: 8328279: Convert java/awt/Cursor/CursorOverlappedPanelsTest
 test to main [v3]
In-Reply-To: <MUFOYKDcNJ2PGsLPn2wn0ZDFv8pKCC-I50EjlYKFlTc=.54ca1142-9d27-421c-b28d-905a8b58ef13@github.com>
References: <l6NLWusbqshFG9pUWWsoatnBo79fRPWVqtjLmkd3gTo=.7ca881bb-6874-4328-acb6-0b895df0e56e@github.com>
 <MUFOYKDcNJ2PGsLPn2wn0ZDFv8pKCC-I50EjlYKFlTc=.54ca1142-9d27-421c-b28d-905a8b58ef13@github.com>
Message-ID: <GV-g-87yM6wEZ_pNkin84bcdAzO8y7QDRy9WdVrrN8k=.9e0ad677-7b0c-4de2-9883-7711d85606ba@github.com>

On Mon, 18 Mar 2024 17:45:02 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

>> Converted to a main manual test.
>
> Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Additional fixes based on review

LGTM

-------------

Marked as reviewed by honkar (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18331#pullrequestreview-1943895993

From achung at openjdk.org  Mon Mar 18 19:57:51 2024
From: achung at openjdk.org (Alisen Chung)
Date: Mon, 18 Mar 2024 19:57:51 GMT
Subject: RFR: 8328227: Remove applet usage from JColorChooser tests
 Test4887836 [v2]
In-Reply-To: <sz94hhkj7mCeInxQ075Uwe14NVjdUMDk3sbuOr1E2X0=.2cc0c644-dd7a-4044-aa17-c082abaf74b6@github.com>
References: <sz94hhkj7mCeInxQ075Uwe14NVjdUMDk3sbuOr1E2X0=.2cc0c644-dd7a-4044-aa17-c082abaf74b6@github.com>
Message-ID: <n885WkCGJjRKjNsQb-rQ_kD3XLyPwQHJEx-Op_Lch3A=.95f0abd8-c9a3-497e-9fbe-15889ef5ce91@github.com>

> Removing applet usage from manual JColorChooser tests

Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:

  remove middle copyright year, update spacings and jtreg summary

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18316/files
  - new: https://git.openjdk.org/jdk/pull/18316/files/b5b6e0c1..9652def1

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18316&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18316&range=00-01

  Stats: 8 lines in 1 file changed: 3 ins; 1 del; 4 mod
  Patch: https://git.openjdk.org/jdk/pull/18316.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18316/head:pull/18316

PR: https://git.openjdk.org/jdk/pull/18316

From achung at openjdk.org  Mon Mar 18 19:57:51 2024
From: achung at openjdk.org (Alisen Chung)
Date: Mon, 18 Mar 2024 19:57:51 GMT
Subject: RFR: 8328227: Remove applet usage from JColorChooser tests
 Test4887836 [v2]
In-Reply-To: <aBk176U0tL-uoUduGF37m99NMTL6OO3xkkZnLfexZyI=.3f73a14b-b5e9-4684-a76d-1a2ccb3897fe@github.com>
References: <sz94hhkj7mCeInxQ075Uwe14NVjdUMDk3sbuOr1E2X0=.2cc0c644-dd7a-4044-aa17-c082abaf74b6@github.com>
 <aBk176U0tL-uoUduGF37m99NMTL6OO3xkkZnLfexZyI=.3f73a14b-b5e9-4684-a76d-1a2ccb3897fe@github.com>
Message-ID: <E_7XPBow5W_l8Mb9OVenGn_zIhXBeOW-euJ-zFoQhK0=.cb1c0e6f-7c54-43c1-be9c-115e44f5f8fd@github.com>

On Fri, 15 Mar 2024 00:41:21 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   remove middle copyright year, update spacings and jtreg summary
>
> test/jdk/javax/swing/JColorChooser/Test4887836.java line 41:
> 
>> 39:     public static void main(String[] args) throws Exception {
>> 40:         String instructions = "If you do not see white area under the \"Swatches\" tab,\n" +
>> 41:                 "then test passed, otherwise it failed.";
> 
> The original instructions seem a bit vague and the test window has a lot going on so probably more details here would add clarity.

The original test [JDK-4887836](https://bugs.openjdk.org/browse/JDK-4887836) is quite vague so I'm not sure how to add more details other than "white area under 'Swatches' tab"

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18316#discussion_r1529184482

From achung at openjdk.org  Mon Mar 18 20:00:33 2024
From: achung at openjdk.org (Alisen Chung)
Date: Mon, 18 Mar 2024 20:00:33 GMT
Subject: Integrated: 8280392:
 java/awt/Focus/NonFocusableWindowTest/NonfocusableOwnerTest.java failed with
 "RuntimeException: Test failed."
In-Reply-To: <o_Z6zlPUisWgc5LIglgOe4zbIjsijJfuG9MtoBveFAU=.2d730b06-211a-485e-8390-6d6f9ae75947@github.com>
References: <o_Z6zlPUisWgc5LIglgOe4zbIjsijJfuG9MtoBveFAU=.2d730b06-211a-485e-8390-6d6f9ae75947@github.com>
Message-ID: <uunUb_QdOcH3m0EvB9af1MZYhgALrOWo4RlYh6A_n5o=.339c7d8a-a37f-4ed7-9b54-19dc853f0541@github.com>

On Fri, 1 Mar 2024 22:49:25 GMT, Alisen Chung <achung at openjdk.org> wrote:

> Introduce delays in test to stabilize. Test passes 50x after fix.

This pull request has now been integrated.

Changeset: 3f2e849c
Author:    Alisen Chung <achung at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/3f2e849c54c2a9c55e3b5c9f5a6d3478b83144e3
Stats:     44 lines in 2 files changed: 29 ins; 13 del; 2 mod

8280392: java/awt/Focus/NonFocusableWindowTest/NonfocusableOwnerTest.java failed with "RuntimeException: Test failed."

Reviewed-by: tr, aivanov, prr

-------------

PR: https://git.openjdk.org/jdk/pull/18091

From achung at openjdk.org  Mon Mar 18 20:12:49 2024
From: achung at openjdk.org (Alisen Chung)
Date: Mon, 18 Mar 2024 20:12:49 GMT
Subject: RFR: 8328380: Remove applet usage from JColorChooser tests Test6348456
Message-ID: <_aL-mUkiTU1jMOsAtDv8wQ4LfmGjhtiFqVr4pqBmUyU=.43345241-dc46-48b8-bab5-95e2b4d18136@github.com>

Removing applet usage from manual JColorChooser tests

-------------

Commit messages:
 - remove html
 - init commit

Changes: https://git.openjdk.org/jdk/pull/18359/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18359&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8328380
  Stats: 86 lines in 2 files changed: 32 ins; 42 del; 12 mod
  Patch: https://git.openjdk.org/jdk/pull/18359.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18359/head:pull/18359

PR: https://git.openjdk.org/jdk/pull/18359

From kizune at openjdk.org  Mon Mar 18 20:42:33 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Mon, 18 Mar 2024 20:42:33 GMT
Subject: RFR: 8328382: Convert java/awt/FileDialog/FileDialogForPackages test
 to main
Message-ID: <9gStC1mcEgWDsQsLiOUD0PHZ1mgIEgaM3f_EAQokmv0=.7f9ce16a-2180-4dea-96af-bcbcf955eec7@github.com>

Convert test to a main based;
Move test to an appropriate folder;
Remove old files;

-------------

Commit messages:
 - Reorganize imports.
 - 8328382: Convert java/awt/FileDialog/FileDialogForPackages test to main

Changes: https://git.openjdk.org/jdk/pull/18360/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18360&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8328382
  Stats: 224 lines in 3 files changed: 93 ins; 131 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18360.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18360/head:pull/18360

PR: https://git.openjdk.org/jdk/pull/18360

From kizune at openjdk.org  Mon Mar 18 21:12:39 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Mon, 18 Mar 2024 21:12:39 GMT
Subject: RFR: 8328384: Convert java/awt/FileDialog/FileDialogOpenDirTest test
 to main
Message-ID: <uRRE9Iw6m8G9T9H0FWEYnUoGgInL7vGgYMPBwP7jEVI=.cb6605a0-f79a-4903-b565-e5dc29d81df2@github.com>

Convert test to main manual;
Move test to appropriate folder;
Delete old files;

-------------

Commit messages:
 - Reorganize imports.
 - 8328384: Convert java/awt/FileDialog/FileDialogOpenDirTest test to main

Changes: https://git.openjdk.org/jdk/pull/18361/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18361&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8328384
  Stats: 364 lines in 3 files changed: 82 ins; 282 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18361.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18361/head:pull/18361

PR: https://git.openjdk.org/jdk/pull/18361

From honkar at openjdk.org  Mon Mar 18 21:16:11 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Mon, 18 Mar 2024 21:16:11 GMT
Subject: RFR: JDK-8328379 : Convert URLDragTest.html applet test to main
Message-ID: <LMnkG1RNIu10nqg2m8IvZN73P9b1rFN4T56JjPmgZLk=.8cde2a03-28b8-4dc5-84b7-2be086494f13@github.com>

Following test - test/jdk/java/awt/dnd/URLDragTest/URLDragTest.html is converted from applet to main using PassFailJFrame. 

PassFailJFrame's `logArea()` is used for logging messages.

-------------

Commit messages:
 - test changes: applet to main
 - html file deleted
 - test moved

Changes: https://git.openjdk.org/jdk/pull/18364/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18364&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8328379
  Stats: 227 lines in 3 files changed: 94 ins; 133 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18364.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18364/head:pull/18364

PR: https://git.openjdk.org/jdk/pull/18364

From kizune at openjdk.org  Mon Mar 18 21:16:17 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Mon, 18 Mar 2024 21:16:17 GMT
Subject: RFR: 8328385: Convert java/awt/FileDialog/FileDialogReturnTest test to
 main
Message-ID: <fqHwY3Ipk9ArGTOnM26LF_dxWaQeptZ8Kf9fKNWUPVg=.43700ff8-5123-444a-817d-173bd126368d@github.com>

Convert test to a main method based;
Move test to an apropriate location;
Remove old files;

-------------

Commit messages:
 - 8328385: Convert java/awt/FileDialog/FileDialogReturnTest test to main

Changes: https://git.openjdk.org/jdk/pull/18363/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18363&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8328385
  Stats: 428 lines in 3 files changed: 139 ins; 289 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18363.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18363/head:pull/18363

PR: https://git.openjdk.org/jdk/pull/18363

From dnguyen at openjdk.org  Mon Mar 18 21:15:57 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Mon, 18 Mar 2024 21:15:57 GMT
Subject: RFR: 8328370: Convert java/awt/print/Dialog/PrintApplet.java applet
 test to main
Message-ID: <Je7yOnjOAjH3DsIgUx72_7ASxsrXS5oIskdKM716AiA=.f1a73b22-8644-40cc-91d6-9ce301f03cc2@github.com>

Convert java/awt/print/Dialog/PrintApplet.java applet test to main using PassFailJFrame. Also rename the test to PrintModalDialog.java since this is no longer an applet. Added test instructions related to the linked JBS issue.

-------------

Commit messages:
 - Initial test conversion

Changes: https://git.openjdk.org/jdk/pull/18362/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18362&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8328370
  Stats: 303 lines in 3 files changed: 132 ins; 171 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18362.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18362/head:pull/18362

PR: https://git.openjdk.org/jdk/pull/18362

From azvegint at openjdk.org  Mon Mar 18 21:19:40 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Mon, 18 Mar 2024 21:19:40 GMT
Subject: RFR: 8328387: Convert
 java/awt/Frame/FrameStateTest/FrameStateTest.html applet test to main
Message-ID: <9jOoOgLC59s3h2IQkTvuc6jJ2Y19umd5SOd25zI67pI=.7e17596c-89f3-4ff2-9254-ec23f85e7eb1@github.com>

The test is converted to main and remains in the problem list, as the problem is still valid on Linux and macos. 
The test passes on Windows.

* sleeps on EDT removed, replaced with the Swing timer
* Unnecessary ltemListener and variables removed.
* Updated instructions with html for better readability
* small log improvements
* log area from PassFailJFrame used

-------------

Commit messages:
 - trailing spaces
 - Get rid of unnecessary ItemListener
 - instructions update
 - improve state logging
 - switch to logArea
 - do not call sleep on EDT
 - initial

Changes: https://git.openjdk.org/jdk/pull/18366/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18366&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8328387
  Stats: 672 lines in 3 files changed: 220 ins; 399 del; 53 mod
  Patch: https://git.openjdk.org/jdk/pull/18366.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18366/head:pull/18366

PR: https://git.openjdk.org/jdk/pull/18366

From azvegint at openjdk.org  Mon Mar 18 23:52:37 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Mon, 18 Mar 2024 23:52:37 GMT
Subject: RFR: 8328401: Convert
 java/awt/Frame/InitialMaximizedTest/InitialMaximizedTest.html applet test to
 automated
Message-ID: <feEnRn4dLIWmgB9GyZd4ur-3buaDoiZ4eeynYShFz50=.f7eb7d90-464c-4231-8a6c-b97fc34378a5@github.com>

The test converted to automated, CI and manual testing looks good on all platforms.

-------------

Commit messages:
 - 8328401: Convert java/awt/Frame/InitialMaximizedTest/InitialMaximizedTest.html applet test to automated

Changes: https://git.openjdk.org/jdk/pull/18367/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18367&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8328401
  Stats: 244 lines in 2 files changed: 18 ins; 176 del; 50 mod
  Patch: https://git.openjdk.org/jdk/pull/18367.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18367/head:pull/18367

PR: https://git.openjdk.org/jdk/pull/18367

From honkar at openjdk.org  Tue Mar 19 00:09:19 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Tue, 19 Mar 2024 00:09:19 GMT
Subject: RFR: 8328387: Convert
 java/awt/Frame/FrameStateTest/FrameStateTest.html applet test to main
In-Reply-To: <9jOoOgLC59s3h2IQkTvuc6jJ2Y19umd5SOd25zI67pI=.7e17596c-89f3-4ff2-9254-ec23f85e7eb1@github.com>
References: <9jOoOgLC59s3h2IQkTvuc6jJ2Y19umd5SOd25zI67pI=.7e17596c-89f3-4ff2-9254-ec23f85e7eb1@github.com>
Message-ID: <1IH-dodgezBhFkjzbkWIGFarAAUpBNseGZmYP4yvaBE=.95b397bf-5409-41b7-a76b-0130e1673181@github.com>

On Mon, 18 Mar 2024 21:12:19 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

> The test is converted to main and remains in the problem list, as the problem is still valid on Linux and macos. 
> The test passes on Windows.
> 
> * sleeps on EDT removed, replaced with the Swing timer
> * Unnecessary ltemListener and variables removed.
> * Updated instructions with html for better readability
> * small log improvements
> * log area from PassFailJFrame used

Tested on Win for various combinations. Updated test changes looks good.

-------------

Marked as reviewed by honkar (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18366#pullrequestreview-1944584561

From honkar at openjdk.org  Tue Mar 19 00:13:20 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Tue, 19 Mar 2024 00:13:20 GMT
Subject: RFR: 8328387: Convert
 java/awt/Frame/FrameStateTest/FrameStateTest.html applet test to main
In-Reply-To: <9jOoOgLC59s3h2IQkTvuc6jJ2Y19umd5SOd25zI67pI=.7e17596c-89f3-4ff2-9254-ec23f85e7eb1@github.com>
References: <9jOoOgLC59s3h2IQkTvuc6jJ2Y19umd5SOd25zI67pI=.7e17596c-89f3-4ff2-9254-ec23f85e7eb1@github.com>
Message-ID: <qdvpyK7feNPO7bRrQvTxBbjxORs7qUd-t5KXxP_Dt9E=.28302f73-3891-43d6-ae35-2bef58bb6677@github.com>

On Mon, 18 Mar 2024 21:12:19 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

> The test is converted to main and remains in the problem list, as the problem is still valid on Linux and macos. 
> The test passes on Windows.
> 
> * sleeps on EDT removed, replaced with the Swing timer
> * Unnecessary ltemListener and variables removed.
> * Updated instructions with html for better readability
> * small log improvements
> * log area from PassFailJFrame used

test/jdk/java/awt/Frame/FrameStateTest/FrameStateTest.java line 179:

> 177:             setLayout(new FlowLayout());
> 178:             add(b1 = new Button("resizable"));
> 179:             add(b2 = new Button("resize"));

@azvegint Minor: Should we consider renaming the "Resize" button to "Change Bounds"? Since when a non-resizable frame is created, the Resize option might seem confusing when we are changing the bounds of the frame.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18366#discussion_r1529490262

From honkar at openjdk.org  Tue Mar 19 00:23:20 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Tue, 19 Mar 2024 00:23:20 GMT
Subject: RFR: 8328387: Convert
 java/awt/Frame/FrameStateTest/FrameStateTest.html applet test to main
In-Reply-To: <9jOoOgLC59s3h2IQkTvuc6jJ2Y19umd5SOd25zI67pI=.7e17596c-89f3-4ff2-9254-ec23f85e7eb1@github.com>
References: <9jOoOgLC59s3h2IQkTvuc6jJ2Y19umd5SOd25zI67pI=.7e17596c-89f3-4ff2-9254-ec23f85e7eb1@github.com>
Message-ID: <LrmdQilIV1_yJKA3KS1QYGlEYf-6_fQX5Cw1iQuZS2M=.1c899e77-d077-4ff9-a7fb-0f5eb58a0ead@github.com>

On Mon, 18 Mar 2024 21:12:19 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

> The test is converted to main and remains in the problem list, as the problem is still valid on Linux and macos. 
> The test passes on Windows.
> 
> * sleeps on EDT removed, replaced with the Swing timer
> * Unnecessary ltemListener and variables removed.
> * Updated instructions with html for better readability
> * small log improvements
> * log area from PassFailJFrame used

Since the .html file is removed, the test file could be moved one level up.

-------------

PR Review: https://git.openjdk.org/jdk/pull/18366#pullrequestreview-1944635858

From azvegint at openjdk.org  Tue Mar 19 00:23:20 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Tue, 19 Mar 2024 00:23:20 GMT
Subject: RFR: 8328387: Convert
 java/awt/Frame/FrameStateTest/FrameStateTest.html applet test to main
In-Reply-To: <qdvpyK7feNPO7bRrQvTxBbjxORs7qUd-t5KXxP_Dt9E=.28302f73-3891-43d6-ae35-2bef58bb6677@github.com>
References: <9jOoOgLC59s3h2IQkTvuc6jJ2Y19umd5SOd25zI67pI=.7e17596c-89f3-4ff2-9254-ec23f85e7eb1@github.com>
 <qdvpyK7feNPO7bRrQvTxBbjxORs7qUd-t5KXxP_Dt9E=.28302f73-3891-43d6-ae35-2bef58bb6677@github.com>
Message-ID: <MQc0Z9vehS8qIy6XFetRKIOEweh0iSlAp_qW_hBSc_U=.69568e42-0794-421a-8b4f-be058c1edf6c@github.com>

On Tue, 19 Mar 2024 00:10:17 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> The test is converted to main and remains in the problem list, as the problem is still valid on Linux and macos. 
>> The test passes on Windows.
>> 
>> * sleeps on EDT removed, replaced with the Swing timer
>> * Unnecessary ltemListener and variables removed.
>> * Updated instructions with html for better readability
>> * small log improvements
>> * log area from PassFailJFrame used
>
> test/jdk/java/awt/Frame/FrameStateTest/FrameStateTest.java line 179:
> 
>> 177:             setLayout(new FlowLayout());
>> 178:             add(b1 = new Button("resizable"));
>> 179:             add(b2 = new Button("resize"));
> 
> @azvegint Minor: Should we consider renaming the "Resize" button to "Change Bounds"? Since when a non-resizable frame is created, the Resize option might seem confusing when we are changing the bounds of the frame.

I am not sure about this, the button does exactly what its label says - resize the frame.

A non-resizable frame has always meant that it can't be resized by the user, but can be changed programmatically.

> java.awt.Frame#setResizable
Sets whether this frame is resizable by the user.

So I prefer to leave it as it is.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18366#discussion_r1529502937

From azvegint at openjdk.org  Tue Mar 19 00:29:19 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Tue, 19 Mar 2024 00:29:19 GMT
Subject: RFR: 8328387: Convert
 java/awt/Frame/FrameStateTest/FrameStateTest.html applet test to main
In-Reply-To: <LrmdQilIV1_yJKA3KS1QYGlEYf-6_fQX5Cw1iQuZS2M=.1c899e77-d077-4ff9-a7fb-0f5eb58a0ead@github.com>
References: <9jOoOgLC59s3h2IQkTvuc6jJ2Y19umd5SOd25zI67pI=.7e17596c-89f3-4ff2-9254-ec23f85e7eb1@github.com>
 <LrmdQilIV1_yJKA3KS1QYGlEYf-6_fQX5Cw1iQuZS2M=.1c899e77-d077-4ff9-a7fb-0f5eb58a0ead@github.com>
Message-ID: <60ls8O5nB4lNT5X2gWYuWBytoPT5KyT8WrLOQC2Euiw=.9488da06-e893-4e0c-918b-6c1a9677dc02@github.com>

On Tue, 19 Mar 2024 00:20:17 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

> Since the .html file is removed, the test file could be moved one level up.

Yes, we can do that, but we already had a discussion that it makes it harder to do the review, since the github doesn't handle that moving well.
It can be done as a single batch with a bunch of tests later.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18366#issuecomment-2005456935

From honkar at openjdk.org  Tue Mar 19 00:44:29 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Tue, 19 Mar 2024 00:44:29 GMT
Subject: RFR: 8328370: Convert java/awt/print/Dialog/PrintApplet.java
 applet test to main
In-Reply-To: <Je7yOnjOAjH3DsIgUx72_7ASxsrXS5oIskdKM716AiA=.f1a73b22-8644-40cc-91d6-9ce301f03cc2@github.com>
References: <Je7yOnjOAjH3DsIgUx72_7ASxsrXS5oIskdKM716AiA=.f1a73b22-8644-40cc-91d6-9ce301f03cc2@github.com>
Message-ID: <mhIHSNuwmFQW89sTOjE-ouMivnE3lwTG90Zggd37Tvc=.9881d175-4e80-4720-bb66-aae30d8c4e54@github.com>

On Mon, 18 Mar 2024 20:50:59 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

> Convert java/awt/print/Dialog/PrintApplet.java applet test to main using PassFailJFrame. Also rename the test to PrintModalDialog.java since this is no longer an applet. Added test instructions related to the linked JBS issue.

Changes requested by honkar (Reviewer).

test/jdk/java/awt/print/Dialog/PrintModalDialog.java line 70:

> 68:                 .rows(10)
> 69:                 .columns(40)
> 70:                 .testUI(PrintModalDialog::createAndShowGUI)

Since the testUI is a simple "Print" button PassFailJFrame's spiltUIBottom() can be used with just a JButton to simplify the UI.

test/jdk/java/awt/print/Dialog/PrintModalDialog.java line 127:

> 125:                 }
> 126:                 catch (java.awt.print.PrinterException ex) {
> 127:                     ex.printStackTrace();

It is better to use PassFailJFrame.forceFail() when a printer exception occurs else the timer keeps running and the error is swallowed even after a printer exception has occurred.

Suggestion:

                catch (java.awt.print.PrinterException ex) {
                    ex.printStackTrace();
                    String msg = "PrinterException: " + ex.getMessage();
                    PassFailJFrame.forceFail(msg);

-------------

PR Review: https://git.openjdk.org/jdk/pull/18362#pullrequestreview-1944665869
PR Review Comment: https://git.openjdk.org/jdk/pull/18362#discussion_r1529515985
PR Review Comment: https://git.openjdk.org/jdk/pull/18362#discussion_r1529524710

From honkar at openjdk.org  Tue Mar 19 00:54:26 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Tue, 19 Mar 2024 00:54:26 GMT
Subject: RFR: JDK-8328012 : Convert InputMethod (/java/awt/im) applet tests
 to main [v5]
In-Reply-To: <LmjN-Y6QEKt8A1NWWCdrZynsVoKFx4NepFOcqrq1s-o=.af4dc9c6-e026-4e3f-81a1-0fd9f5b1b170@github.com>
References: <iDY1JdxeSzLcbW-ASx1PylUqKY-kGUjMj8tr4Sj5NDM=.a0b9fbdb-a959-4e98-ae08-d086fd8f210f@github.com>
 <wy9bLFymQ0_gqjxVqgIhc7s5Q3QHFC17th2FkmbLIB4=.be7612dc-904d-457e-b2df-fee9c73cf6c1@github.com>
 <LmjN-Y6QEKt8A1NWWCdrZynsVoKFx4NepFOcqrq1s-o=.af4dc9c6-e026-4e3f-81a1-0fd9f5b1b170@github.com>
Message-ID: <eb_fC7SwZg4nfIRYWyi0JxOl0V3j7w2S0YMFr_o2WSo=.e3c2bcb3-8a3b-4298-af1c-2ee333311167@github.com>

On Mon, 18 Mar 2024 07:09:33 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review updates
>
> test/jdk/java/awt/im/PinyinIMCommaTest.java line 67:
> 
>> 65:         if (OSInfo.getOSType() != OSInfo.OSType.MACOSX) {
>> 66:             throw new SkippedException("This test is for macOS only");
>> 67:         }
> 
> Is it required to have this SkippedException?
> 
> I guess this test already have jtreg tag @requires("mac") and the test needs to be run with jtreg since we are using PassFailJFrame so I think it's redundant to have this check again in test.

Updated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18251#discussion_r1529534777

From serb at openjdk.org  Tue Mar 19 01:05:20 2024
From: serb at openjdk.org (Sergey Bylokhov)
Date: Tue, 19 Mar 2024 01:05:20 GMT
Subject: RFR: 8325179: Race in BasicDirectoryModel.validateFileCache [v4]
In-Reply-To: <uXXE9lt4oJLSC0rBvzdMGoja_ITHHL9s9P1ehDf50TM=.744bfbb8-92a9-4ff0-8db2-4b03ffe0c881@github.com>
References: <nOapec57Ql6DHy57oEeWdkUGER8RYdWc2vwmJsqWDYc=.8de81954-d8c2-4937-b426-e61dde05255e@github.com>
 <uXXE9lt4oJLSC0rBvzdMGoja_ITHHL9s9P1ehDf50TM=.744bfbb8-92a9-4ff0-8db2-4b03ffe0c881@github.com>
Message-ID: <Vb_-SNLm4PBUiqbZxvfZotk3swCMeDG1bZLjGaLzRVk=.9f52d1a5-f0aa-4c87-b8c0-e18f24962893@github.com>

On Fri, 15 Mar 2024 14:50:12 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Ensure access to the `filesLoader` field of `BasicDirectoryModel` is synchronized.
>> 
>> Without synchronization, a thread checks if `filesLoader` is not null and creates a new `FilesLoader` thread. If the thread is pre-empted between these two operations, another thread or even several threads can see the `null` value and create new `FilesLoader` threads.
>> 
>> The same way, `BasicDirectoryModel.invalidateFileCache` needs to be synchornized to interrupt the current `filesLoader` and assign `null`.
>> 
>> This bug allows reproducing `ConcurrentModificationException` seen in [JDK-8323670](https://bugs.openjdk.org/browse/JDK-8323670) and [JDK-8307091](https://bugs.openjdk.org/browse/JDK-8307091) using the test in PR #18109.
>
> Alexey Ivanov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Increment fetch ID to invalidate pending DoChangeContents

Marked as reviewed by serb (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18111#pullrequestreview-1944748397

From serb at openjdk.org  Tue Mar 19 01:11:20 2024
From: serb at openjdk.org (Sergey Bylokhov)
Date: Tue, 19 Mar 2024 01:11:20 GMT
Subject: RFR: 8327137: Add test for ConcurrentModificationException in
 BasicDirectoryModel [v3]
In-Reply-To: <V1fPYAjQ6U8TFSOTRQ-Fk9dRnFAwbimWAPUkicxtklk=.6fe019f2-a478-4e11-8c02-b606f8f14709@github.com>
References: <mCqqjrXVWDB2PvpOhKHx-Hr8W6tUz6v4stztGmyAeEg=.1f95da1c-e1a5-40be-be8b-0758729fa9b9@github.com>
 <HvJ96YzIfnTtdNh7R5XtYs_t0sc5VfHjBHUxi9uyJdI=.94715923-e3c0-4666-9a51-340ef91b8b3b@github.com>
 <V1fPYAjQ6U8TFSOTRQ-Fk9dRnFAwbimWAPUkicxtklk=.6fe019f2-a478-4e11-8c02-b606f8f14709@github.com>
Message-ID: <Chb_zgl53KY05-E3fKBAF61S8SO4Bi7LMlGkART_3io=.7845c015-4fd7-4ce5-bf27-7994cbf2471a@github.com>

On Fri, 15 Mar 2024 12:02:43 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> test/jdk/javax/swing/plaf/basic/BasicDirectoryModel/ConcurrentModification.java line 99:
>> 
>>> 97:             createFiles(temp);
>>> 98: 
>>> 99:             final JFileChooser fc = new JFileChooser(temp.toFile());
>> 
>> it should be created on EDT, just in case.
>
> I don't think it matters here? The test does not rely on even processing on EDT, no state of `JFileChooser` is modified except for calling `rescanCurrentDirectory`. Technically, I am not allowed to do so either. But if I call `rescanCurrentDirectory` from EDT only, the test becomes void.

I think it will fire the property change events via firePropertyChange from the constructor and it is better to do that on EDT.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18109#discussion_r1529545568

From azvegint at openjdk.org  Tue Mar 19 01:20:20 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Tue, 19 Mar 2024 01:20:20 GMT
Subject: RFR: 8328402: Implement pausing functionality for the PassFailJFrame
Message-ID: <_G5oabZhLzV7Ld3agI-uiRKWhJL5_8i8LVWA7JSBhOM=.c025ce82-16ed-4b8d-8e2b-1a8bc849639c@github.com>

> we need to add next to Pass/Fail a "Pause Timer" button, that
(a) stops the count down
(b) changes the Pause Timer to "Resume Timer"
~~(c) disables Pass/Fail until the timer is resumed~~
the test will not have to pause or be aware - only the PassFailJFrame machinery.
~~So the tester can do anything they want except exit the test in the paused mode.~~

This PR implements everything except the (c).
I see nothing wrong with completing the test from the paused state, and it does not add an extra click.  


Example screenshots:

![image](https://github.com/openjdk/jdk/assets/77687766/65d34bf8-1e46-4e68-b39e-a77f257ec3c0)
![image](https://github.com/openjdk/jdk/assets/77687766/3a43e059-2d48-46f3-9d1b-c2ab84fcce37)

-------------

Commit messages:
 - 8328402: Implement pausing functionality for the PassFailJFrame

Changes: https://git.openjdk.org/jdk/pull/18368/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18368&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8328402
  Stats: 31 lines in 1 file changed: 27 ins; 0 del; 4 mod
  Patch: https://git.openjdk.org/jdk/pull/18368.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18368/head:pull/18368

PR: https://git.openjdk.org/jdk/pull/18368

From azvegint at openjdk.org  Tue Mar 19 01:20:21 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Tue, 19 Mar 2024 01:20:21 GMT
Subject: RFR: 8328402: Implement pausing functionality for the
 PassFailJFrame
In-Reply-To: <_G5oabZhLzV7Ld3agI-uiRKWhJL5_8i8LVWA7JSBhOM=.c025ce82-16ed-4b8d-8e2b-1a8bc849639c@github.com>
References: <_G5oabZhLzV7Ld3agI-uiRKWhJL5_8i8LVWA7JSBhOM=.c025ce82-16ed-4b8d-8e2b-1a8bc849639c@github.com>
Message-ID: <BXPzVdx4pV0d1x096dNyBZsqDPqkOKcz6blJCzzsHeI=.49af4385-d7b1-493a-a288-7bb5c5461c8d@github.com>

On Tue, 19 Mar 2024 01:14:29 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>> we need to add next to Pass/Fail a "Pause Timer" button, that
> (a) stops the count down
> (b) changes the Pause Timer to "Resume Timer"
> ~~(c) disables Pass/Fail until the timer is resumed~~
> the test will not have to pause or be aware - only the PassFailJFrame machinery.
> ~~So the tester can do anything they want except exit the test in the paused mode.~~
> 
> This PR implements everything except the (c).
> I see nothing wrong with completing the test from the paused state, and it does not add an extra click.  
> 
> 
> Example screenshots:
> 
> ![image](https://github.com/openjdk/jdk/assets/77687766/65d34bf8-1e46-4e68-b39e-a77f257ec3c0)
> ![image](https://github.com/openjdk/jdk/assets/77687766/3a43e059-2d48-46f3-9d1b-c2ab84fcce37)

@aivanov-jdk you might want to take a look

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18368#issuecomment-2005555788

From achung at openjdk.org  Tue Mar 19 01:51:28 2024
From: achung at openjdk.org (Alisen Chung)
Date: Tue, 19 Mar 2024 01:51:28 GMT
Subject: RFR: 8328403: Remove applet usage from JColorChooser tests Test6977726
Message-ID: <pyfxVdApSNSisMJieBTl5HSZKDmSSiPie0tnrM_rwe4=.5ffc4e92-cbcf-44d8-9a51-b4e8330e1be9@github.com>

Removing applet usage from manual JColorChooser tests

-------------

Commit messages:
 - init commit

Changes: https://git.openjdk.org/jdk/pull/18369/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18369&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8328403
  Stats: 57 lines in 2 files changed: 15 ins; 32 del; 10 mod
  Patch: https://git.openjdk.org/jdk/pull/18369.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18369/head:pull/18369

PR: https://git.openjdk.org/jdk/pull/18369

From tr at openjdk.org  Tue Mar 19 04:15:21 2024
From: tr at openjdk.org (Tejesh R)
Date: Tue, 19 Mar 2024 04:15:21 GMT
Subject: RFR: 8322140: javax/swing/JTable/JTableScrollPrintTest.java does not
 print the rows and columns of the table in NimbusLookAndFeel
Message-ID: <YUFppwxpjJjubF-XhqDDe1xcdIes9ErKzA563fjF0oY=.2e79d2c5-f743-49b0-be82-27dd4c4403bd@github.com>

Fix suggested in bug [8210807](https://github.com/openjdk/jdk/commit/38bbbe7588c94d3a0edd1c120ba49cbd0851a720) had a regression in Nimbus L&F yet it resolved the issue in other L&F. The better approach would be to handle `MultiResolutionImages `in `PathGraphics` class `getBufferedImage` method and is suggested here. The fix doesn't cause any regression and is verified in CI system. The test javax/swing/JTable/JTableScrollPrintTest.java is verified for all platforms and all L&F (Except in Windows it doesn't work due an issue introduced in 22, yet to investigate on it). And also fix [8210807](https://github.com/openjdk/jdk/commit/38bbbe7588c94d3a0edd1c120ba49cbd0851a720) has been reverted, retaining the test.

-------------

Commit messages:
 - Fix + Revert 8210807

Changes: https://git.openjdk.org/jdk/pull/18187/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18187&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8322140
  Stats: 25 lines in 3 files changed: 15 ins; 4 del; 6 mod
  Patch: https://git.openjdk.org/jdk/pull/18187.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18187/head:pull/18187

PR: https://git.openjdk.org/jdk/pull/18187

From aturbanov at openjdk.org  Tue Mar 19 04:15:22 2024
From: aturbanov at openjdk.org (Andrey Turbanov)
Date: Tue, 19 Mar 2024 04:15:22 GMT
Subject: RFR: 8322140: javax/swing/JTable/JTableScrollPrintTest.java does
 not print the rows and columns of the table in NimbusLookAndFeel
In-Reply-To: <YUFppwxpjJjubF-XhqDDe1xcdIes9ErKzA563fjF0oY=.2e79d2c5-f743-49b0-be82-27dd4c4403bd@github.com>
References: <YUFppwxpjJjubF-XhqDDe1xcdIes9ErKzA563fjF0oY=.2e79d2c5-f743-49b0-be82-27dd4c4403bd@github.com>
Message-ID: <yf0zqNqKx_-Sd1R_x1U3gXs2k89m8DHvTjuvLCTGDEo=.88947518-2c73-4b5a-aee7-67208370c03a@github.com>

On Mon, 11 Mar 2024 10:05:41 GMT, Tejesh R <tr at openjdk.org> wrote:

> Fix suggested in bug [8210807](https://github.com/openjdk/jdk/commit/38bbbe7588c94d3a0edd1c120ba49cbd0851a720) had a regression in Nimbus L&F yet it resolved the issue in other L&F. The better approach would be to handle `MultiResolutionImages `in `PathGraphics` class `getBufferedImage` method and is suggested here. The fix doesn't cause any regression and is verified in CI system. The test javax/swing/JTable/JTableScrollPrintTest.java is verified for all platforms and all L&F (Except in Windows it doesn't work due an issue introduced in 22, yet to investigate on it). And also fix [8210807](https://github.com/openjdk/jdk/commit/38bbbe7588c94d3a0edd1c120ba49cbd0851a720) has been reverted, retaining the test.

src/java.desktop/share/classes/sun/print/PathGraphics.java line 1151:

> 1149:     public static BufferedImage convertToBufferedImage(MultiResolutionImage multiResolutionImage,
> 1150:                                                        double width, double height ) {
> 1151:         Image resolutionImage = multiResolutionImage.getResolutionVariant(width,height);

Suggestion:

        Image resolutionImage = multiResolutionImage.getResolutionVariant(width, height);

src/java.desktop/share/classes/sun/print/PathGraphics.java line 1156:

> 1154:                                                         BufferedImage.TYPE_INT_ARGB);
> 1155:         Graphics2D g2d = bufferedImage.createGraphics();
> 1156:         g2d.drawImage(resolutionImage, 0, 0, (int)width, (int)height,null);

Suggestion:

        g2d.drawImage(resolutionImage, 0, 0, (int)width, (int)height, null);

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18187#discussion_r1527166774
PR Review Comment: https://git.openjdk.org/jdk/pull/18187#discussion_r1527166756

From tr at openjdk.org  Tue Mar 19 04:27:41 2024
From: tr at openjdk.org (Tejesh R)
Date: Tue, 19 Mar 2024 04:27:41 GMT
Subject: RFR: 8328154: Convert sun/java2d/loops/CopyAreaSpeed.java applet
 test to main [v2]
In-Reply-To: <QHf2yYI8zQSoqYjld0VQjVQmFWrIk2f53wArMF0qL14=.a7a41b62-f301-4c7a-9da4-09603d95cbd5@github.com>
References: <QHf2yYI8zQSoqYjld0VQjVQmFWrIk2f53wArMF0qL14=.a7a41b62-f301-4c7a-9da4-09603d95cbd5@github.com>
Message-ID: <0HjBbmPYu0IfXLhCjyOqZEniORf5iJj4J9n4b4DE2Ek=.c8e5c3d3-71cb-4b4f-8381-201413fbc045@github.com>

> Convert  sun/java2d/loops/CopyAreaSpeed.java manual applet test to main based using PassFailJFrame. This is a performance measurement test which provide benchmark to compare the outcome with different releases. I have converted the test using a PassFailJFrame though PASS/FAIL doesn't matter here. The result have been shown in `JOptionPane` message.

Tejesh R has updated the pull request incrementally with one additional commit since the last revision:

  Review updates

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18296/files
  - new: https://git.openjdk.org/jdk/pull/18296/files/b59c1b05..f1d4f655

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18296&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18296&range=00-01

  Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod
  Patch: https://git.openjdk.org/jdk/pull/18296.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18296/head:pull/18296

PR: https://git.openjdk.org/jdk/pull/18296

From tr at openjdk.org  Tue Mar 19 04:41:24 2024
From: tr at openjdk.org (Tejesh R)
Date: Tue, 19 Mar 2024 04:41:24 GMT
Subject: Integrated: 8328154: Convert sun/java2d/loops/CopyAreaSpeed.java
 applet test to main
In-Reply-To: <QHf2yYI8zQSoqYjld0VQjVQmFWrIk2f53wArMF0qL14=.a7a41b62-f301-4c7a-9da4-09603d95cbd5@github.com>
References: <QHf2yYI8zQSoqYjld0VQjVQmFWrIk2f53wArMF0qL14=.a7a41b62-f301-4c7a-9da4-09603d95cbd5@github.com>
Message-ID: <xHey_K0PY49o25r3lkc8LaNVoW_1dKGbToieDcacruE=.db76e69f-c051-440d-9f69-81b1b53eac8e@github.com>

On Thu, 14 Mar 2024 10:39:15 GMT, Tejesh R <tr at openjdk.org> wrote:

> Convert  sun/java2d/loops/CopyAreaSpeed.java manual applet test to main based using PassFailJFrame. This is a performance measurement test which provide benchmark to compare the outcome with different releases. I have converted the test using a PassFailJFrame though PASS/FAIL doesn't matter here. The result have been shown in `JOptionPane` message.

This pull request has now been integrated.

Changeset: 652fb3aa
Author:    Tejesh R <tr at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/652fb3aa48fdfe09e827c2a06f76b3a69c711b74
Stats:     257 lines in 2 files changed: 34 ins; 198 del; 25 mod

8328154: Convert sun/java2d/loops/CopyAreaSpeed.java applet test to main

Reviewed-by: kizune, abhiscxk

-------------

PR: https://git.openjdk.org/jdk/pull/18296

From abhiscxk at openjdk.org  Tue Mar 19 05:13:19 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Tue, 19 Mar 2024 05:13:19 GMT
Subject: RFR: 8327980: Convert
 javax/swing/JToggleButton/4128979/bug4128979.java applet test to main [v2]
In-Reply-To: <C46MrJPzi0zrmbvT34uXD2jOecj78PfvQAoY4FtmrVA=.a208aaee-be1e-4439-8e9b-a34bca0089b1@github.com>
References: <lZHt9pYb75UtaIEtbB0paOkfqR5CUAc6tikhb9YAakU=.ff2adbed-1db2-490a-8747-66ac96d03657@github.com>
 <h9V1lpm9LrxoTXicUWMB1SyIDjJmPXlp5ohLCmpt3Kw=.32d56f64-83ae-47cc-86ec-efe8a568e038@github.com>
 <ZqXC3FEtY0pXKoXFcvxL3z-qR-3RkQZ3LlHPyE2IRzw=.440fd1d1-56b2-47f0-9efc-3b33593edf60@github.com>
 <s7vPeOnHKVsnZ6zzhhYacdGv5APFSHLS6A3AsUgjMhM=.16b7f28c-0d79-446f-b142-ed8585dc0399@github.com>
 <C46MrJPzi0zrmbvT34uXD2jOecj78PfvQAoY4FtmrVA=.a208aaee-be1e-4439-8e9b-a34bca0089b1@github.com>
Message-ID: <hHtV_qiFFk3oR4_cA-Bqh_qoz45aWqmOiMevPAY4jEE=.5d76b94f-f7eb-45d0-8847-48e16250af2b@github.com>

On Mon, 18 Mar 2024 17:30:46 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Updated.
>
> You can remove the OS check here if you would like to, since it is not strictly required when run as jtreg test (which is essentially the case here).

I will keep this check as of now.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18233#discussion_r1529721952

From abhiscxk at openjdk.org  Tue Mar 19 05:41:20 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Tue, 19 Mar 2024 05:41:20 GMT
Subject: RFR: 8328279: Convert java/awt/Cursor/CursorOverlappedPanelsTest
 test to main [v3]
In-Reply-To: <MUFOYKDcNJ2PGsLPn2wn0ZDFv8pKCC-I50EjlYKFlTc=.54ca1142-9d27-421c-b28d-905a8b58ef13@github.com>
References: <l6NLWusbqshFG9pUWWsoatnBo79fRPWVqtjLmkd3gTo=.7ca881bb-6874-4328-acb6-0b895df0e56e@github.com>
 <MUFOYKDcNJ2PGsLPn2wn0ZDFv8pKCC-I50EjlYKFlTc=.54ca1142-9d27-421c-b28d-905a8b58ef13@github.com>
Message-ID: <hMuHJmWongpBVjHDZ88_rivRpj9epvCCCEQfWu0Znvk=.88531a37-16f3-4574-b46a-a11de8b4410c@github.com>

On Mon, 18 Mar 2024 17:45:02 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

>> Converted to a main manual test.
>
> Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Additional fixes based on review

Marked as reviewed by abhiscxk (Committer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18331#pullrequestreview-1945227020

From psadhukhan at openjdk.org  Tue Mar 19 05:59:19 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Tue, 19 Mar 2024 05:59:19 GMT
Subject: RFR: JDK-8328299 : Convert DnDFileGroupDescriptor.html applet test
 to main [v2]
In-Reply-To: <_-u_Wh-X-AUrhMkJ7DOsy8_4V2ndpNej7kHJxNNFM0Y=.c5c82ac9-2c75-4812-a0c2-7c77d1376b2e@github.com>
References: <CTOJXaNDso7Gmw-A2kTkmsZmAWqcWllOim2Y_BGgeok=.5d62efd5-66c2-47a7-b1f0-c10f4c366b40@github.com>
 <JMSgb5T4kBS4vbQUOgin4jajdDd9xSqFOUm9eExUP44=.9d01c4da-1d84-49e4-b0c0-a7bb874a643d@github.com>
 <7gn73bmbH0pkfkIHn2DYdwVXpNoZ2dgxRwbMyRxUz9E=.d2f822c9-6c6a-4d68-8c54-f1087d71144d@github.com>
 <_-u_Wh-X-AUrhMkJ7DOsy8_4V2ndpNej7kHJxNNFM0Y=.c5c82ac9-2c75-4812-a0c2-7c77d1376b2e@github.com>
Message-ID: <1NxnfGHLOowc9kzH6lteetNakhfZOBfl8v32bV0Jxbs=.687ee264-fb16-4b0d-8466-956dadce1244@github.com>

On Mon, 18 Mar 2024 18:34:18 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> The reason it was not integrated was because of this [comment](https://github.com/openjdk/jdk/pull/3406#pullrequestreview-632106612) wherein it was mentioned to update the test to run without MSOutlook dependancy so that it could be run on all platforms so making it not platform dependant..
>
> @prsadhuk When I read it for the 2nd time it makes sense why the @requires check was added. Since it is a manual test there is no way of knowing it has been problem-listed on macOS & linux unless someone explicitly checks the problemlist before running the test.

The @requires was added in [JDK-7147083](https://bugs.openjdk.org/browse/JDK-7147083) to ensure the test pass automatically in non-windows platform much before the problemlist was added so I think it was an oversight and we should remove the problemlist and close 8080185 as NA, in my opinion...

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18335#discussion_r1529767437

From jdv at openjdk.org  Tue Mar 19 06:02:21 2024
From: jdv at openjdk.org (Jayathirth D V)
Date: Tue, 19 Mar 2024 06:02:21 GMT
Subject: RFR: 8327757: Convert javax/swing/JSlider/6524424/bug6524424.java
 applet to main [v2]
In-Reply-To: <lVaGWU7mLft2CXiRyK73OM-szVSXoLrJJ_YrTuBYXEk=.af7e88b2-5954-4839-948a-29bb4578902e@github.com>
References: <bq4piqGxP9zZiBlAc8_w-hnLs84WeA78AngOyTg7lwI=.b2572769-5729-4612-81b9-aac8f1a30398@github.com>
 <lVaGWU7mLft2CXiRyK73OM-szVSXoLrJJ_YrTuBYXEk=.af7e88b2-5954-4839-948a-29bb4578902e@github.com>
Message-ID: <ZLmdvtwYsUeJCB-25TVXJIIZRtZOdeIX98OxZW5gNBE=.77d4a902-b882-433d-b640-d912c1a6f9ba@github.com>

On Fri, 15 Mar 2024 03:17:07 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Conversion of manual applet test to main based using PassFailJFrame manual framework
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Ninor update

Marked as reviewed by jdv (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18263#pullrequestreview-1945259467

From psadhukhan at openjdk.org  Tue Mar 19 06:05:20 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Tue, 19 Mar 2024 06:05:20 GMT
Subject: RFR: 8328367: Convert java/awt/Component/UpdatingBootTime test to
 main
In-Reply-To: <9gtCIzXrOP-RQJyjhkP8ibENRjEXP9rMUkEbZry4uWc=.2d949d4b-c1ed-45b0-84b9-82859af8a4b0@github.com>
References: <9gtCIzXrOP-RQJyjhkP8ibENRjEXP9rMUkEbZry4uWc=.2d949d4b-c1ed-45b0-84b9-82859af8a4b0@github.com>
Message-ID: <ax0JxLAdn4K1UbdxSV37LrIiRcVuOWzHt1-MRJw9QU4=.de80adb8-38d1-423d-b8ff-e17c3425eaed@github.com>

On Mon, 18 Mar 2024 17:32:04 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

> Convert test to manual main
> Move test to the Component folder

test/jdk/java/awt/Component/UpdatingBootTime.java line 27:

> 25:  * @test
> 26:  * @bug 6461933 7194219
> 27:  * @summary adjust system boot time in nowMillisUTC() frequently

Guess you need @library for PassFailJFrame

test/jdk/java/awt/Component/UpdatingBootTime.java line 74:

> 72:                 """
> 73:             1) In the test window press "Press me" button.
> 74:             2) A two timestamps should be printed.

grammar issue...guess it should be just "Two timestamps should..."

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18355#discussion_r1529771184
PR Review Comment: https://git.openjdk.org/jdk/pull/18355#discussion_r1529773011

From psadhukhan at openjdk.org  Tue Mar 19 06:25:26 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Tue, 19 Mar 2024 06:25:26 GMT
Subject: Integrated: 8327757: Convert
 javax/swing/JSlider/6524424/bug6524424.java applet to main
In-Reply-To: <bq4piqGxP9zZiBlAc8_w-hnLs84WeA78AngOyTg7lwI=.b2572769-5729-4612-81b9-aac8f1a30398@github.com>
References: <bq4piqGxP9zZiBlAc8_w-hnLs84WeA78AngOyTg7lwI=.b2572769-5729-4612-81b9-aac8f1a30398@github.com>
Message-ID: <Q6ACYnxvmJOa_MsUgqSP5m1928yU-nfjlQG2jmIM4OE=.46462b4b-ff01-4636-bad5-8421ffe0efab@github.com>

On Wed, 13 Mar 2024 07:34:24 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> Conversion of manual applet test to main based using PassFailJFrame manual framework

This pull request has now been integrated.

Changeset: ac5b6cb2
Author:    Prasanta Sadhukhan <psadhukhan at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/ac5b6cb2d42bdb8fb1a110ad33411b50cff4ea61
Stats:     255 lines in 3 files changed: 120 ins; 135 del; 0 mod

8327757: Convert javax/swing/JSlider/6524424/bug6524424.java applet to main

Reviewed-by: abhiscxk, jdv

-------------

PR: https://git.openjdk.org/jdk/pull/18263

From psadhukhan at openjdk.org  Tue Mar 19 07:52:20 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Tue, 19 Mar 2024 07:52:20 GMT
Subject: RFR: 8328378: Convert java/awt/FileDialog/FileDialogForDirectories
 test to main
In-Reply-To: <2yId9SKzUfB9ZnRy1Ma_m6jye3Mad5UIx-mxcgcZdZ8=.b71c078f-0a57-4b4c-b1ce-a98d23df0b48@github.com>
References: <2yId9SKzUfB9ZnRy1Ma_m6jye3Mad5UIx-mxcgcZdZ8=.b71c078f-0a57-4b4c-b1ce-a98d23df0b48@github.com>
Message-ID: <MGoiJFdKMVuwp5thXCPaiht26DrVPrUVZiqcxKeOxPw=.0a6f57d1-da03-4618-b317-78779fb37ca4@github.com>

On Mon, 18 Mar 2024 18:16:08 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

> Convert test to main manual and move to the appropriate folder
> Remove old files

test/jdk/java/awt/FileDialog/FileDialogForDirectories.java line 36:

> 34:  * @test
> 35:  * @bug 7161437
> 36:  * @summary We should support "apple.awt.fileDialogForDirectories" property.

@library is missing...Does it work for you without this? I see most of your latest PRs doesn't have this tag

test/jdk/java/awt/FileDialog/FileDialogForDirectories.java line 43:

> 41: public class FileDialogForDirectories {
> 42:     private static Button showBtn;
> 43:     private static FileDialog fd;

Can be made local in main

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18358#discussion_r1529879913
PR Review Comment: https://git.openjdk.org/jdk/pull/18358#discussion_r1529880137

From aturbanov at openjdk.org  Tue Mar 19 08:57:21 2024
From: aturbanov at openjdk.org (Andrey Turbanov)
Date: Tue, 19 Mar 2024 08:57:21 GMT
Subject: RFR: 8328384: Convert java/awt/FileDialog/FileDialogOpenDirTest
 test to main
In-Reply-To: <uRRE9Iw6m8G9T9H0FWEYnUoGgInL7vGgYMPBwP7jEVI=.cb6605a0-f79a-4903-b565-e5dc29d81df2@github.com>
References: <uRRE9Iw6m8G9T9H0FWEYnUoGgInL7vGgYMPBwP7jEVI=.cb6605a0-f79a-4903-b565-e5dc29d81df2@github.com>
Message-ID: <rM5VfQkDl7CJK2VOBUeiZEDmW2oHZiO9FoxbIJcjfpk=.6ebdf3f5-0c13-4e8d-9c71-fb263e220c7f@github.com>

On Mon, 18 Mar 2024 20:45:03 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

> Convert test to main manual;
> Move test to appropriate folder;
> Delete old files;

test/jdk/java/awt/FileDialog/FileDialogOpenDirTest.java line 41:

> 39: public class FileDialogOpenDirTest {
> 40:     private static JFrame initialize() {
> 41:         System.setProperty("sun.awt.disableGtkFileDialogs","true");

Suggestion:

        System.setProperty("sun.awt.disableGtkFileDialogs", "true");

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18361#discussion_r1529963749

From rkannathpari at openjdk.org  Tue Mar 19 08:58:35 2024
From: rkannathpari at openjdk.org (Renjith Kannath Pariyangad)
Date: Tue, 19 Mar 2024 08:58:35 GMT
Subject: RFR: JDK-8320675 : PrinterJob/SecurityDialogTest.java hangs [v4]
In-Reply-To: <OMBWLwH7044RMtwdrZSiahQDdy-1T-4oJjOQgnQEKjI=.18a31ad0-710f-44e5-86ec-b4566946b063@github.com>
References: <OMBWLwH7044RMtwdrZSiahQDdy-1T-4oJjOQgnQEKjI=.18a31ad0-710f-44e5-86ec-b4566946b063@github.com>
Message-ID: <o6NHN2hWnEpQKy5T4bKfFkQI9DdCKCD3OhoN1TR0Az0=.4ad7fd2e-e11a-4ff7-a5a9-e46f7b098515@github.com>

> Hi Reviewers,
> 
> I have updated the test with  PassFailJFrame with information panel, earlier this was informed through terminal.
> Please review and let me know your suggestions if any.

Renjith Kannath Pariyangad has updated the pull request incrementally with one additional commit since the last revision:

  Removed extra space

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18299/files
  - new: https://git.openjdk.org/jdk/pull/18299/files/b95f9022..cc6d560d

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18299&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18299&range=02-03

  Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/jdk/pull/18299.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18299/head:pull/18299

PR: https://git.openjdk.org/jdk/pull/18299

From rkannathpari at openjdk.org  Tue Mar 19 09:24:35 2024
From: rkannathpari at openjdk.org (Renjith Kannath Pariyangad)
Date: Tue, 19 Mar 2024 09:24:35 GMT
Subject: RFR: 8324807 : Manual printer tests have no Pass/Fail buttons,
 instructions close set 2 [v13]
In-Reply-To: <UZ9jtQbkj-MoeLoccJnd2_3ciCCy9n-CD5vDv0hVKME=.f67db96d-92e6-46a1-9bb6-4fe77c9a8c4e@github.com>
References: <UZ9jtQbkj-MoeLoccJnd2_3ciCCy9n-CD5vDv0hVKME=.f67db96d-92e6-46a1-9bb6-4fe77c9a8c4e@github.com>
Message-ID: <H0UV3U9sSiFH-4iBraSfzpBQfidHVi7oXFGR-yAps3o=.30b35bdb-781f-4457-bbb6-36b8b8687989@github.com>

> Hi Reviewers,
> 
> Updated manual printer test cases with 'PassFailJFrame', also removed unused variables. Added 'SkippedException' in case of printer missing or not configured.
> 
> Please review and let me know your suggestions.
> 
> Regards,
> Renjith

Renjith Kannath Pariyangad has updated the pull request incrementally with one additional commit since the last revision:

  Updated PassFailJFrame object creation

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/17608/files
  - new: https://git.openjdk.org/jdk/pull/17608/files/69fe7d96..aa801855

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=17608&range=12
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17608&range=11-12

  Stats: 3 lines in 3 files changed: 0 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/jdk/pull/17608.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17608/head:pull/17608

PR: https://git.openjdk.org/jdk/pull/17608

From tr at openjdk.org  Tue Mar 19 10:54:20 2024
From: tr at openjdk.org (Tejesh R)
Date: Tue, 19 Mar 2024 10:54:20 GMT
Subject: RFR: 8328262: Convert
 javax/swing/JSplitPane/8132123/bug8132123.java applet test to main [v3]
In-Reply-To: <7HFbDcncHLgKFUBmnrGUcgoYof-23Dj4qhTCaf2ZF-g=.0198f934-7808-457a-9991-06f92ed02811@github.com>
References: <UGuBjBTuGecghDM14mLTft1l8zGsY_PPueIqolFvq1U=.65c37ac4-3dbb-4385-85e5-f9393ec1445c@github.com>
 <7HFbDcncHLgKFUBmnrGUcgoYof-23Dj4qhTCaf2ZF-g=.0198f934-7808-457a-9991-06f92ed02811@github.com>
Message-ID: <F3KMhlgmatHqdTQy12S2Zeu6WqK9OFUPvjAnQKCkG2k=.9147c925-3ee5-4008-a4cc-b325848979f1@github.com>

On Mon, 18 Mar 2024 09:21:02 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Conversion of manual applet test to main based using PassFailJFrame manual framework
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review comment update

Looks good to me.

-------------

Marked as reviewed by tr (Committer).

PR Review: https://git.openjdk.org/jdk/pull/18325#pullrequestreview-1945833486

From tr at openjdk.org  Tue Mar 19 11:02:20 2024
From: tr at openjdk.org (Tejesh R)
Date: Tue, 19 Mar 2024 11:02:20 GMT
Subject: RFR: 8328244: Convert javax/swing/JSlider/6742358/bug6742358.java
 applet test to main [v4]
In-Reply-To: <tg3ksJkHLr36rUBzWL7NG7vyBTyBqYm76KV4OOso5HQ=.3d3050cd-a562-42d1-839e-8c8c5071af26@github.com>
References: <AN6EAjyACY33ukKyOjp8SuzxRt80B9Z_UO1fy83Nijw=.42fbb5cd-fb5c-413d-a1f2-842657fa7f0e@github.com>
 <tg3ksJkHLr36rUBzWL7NG7vyBTyBqYm76KV4OOso5HQ=.3d3050cd-a562-42d1-839e-8c8c5071af26@github.com>
Message-ID: <RgP5vipGbP5lh9Ik6cQZyLMk9fZ0yYKeQYjvMh06bVI=.5ac0daae-c1ed-4e9c-b3a4-babf47390550@github.com>

On Mon, 18 Mar 2024 11:56:54 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Conversion of manual applet test to main based using PassFailJFrame manual framework
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   jtreg tag update

Line column limit exceeds in `createSlider()` method, can correct those.

test/jdk/javax/swing/JSlider/bug6742358.java line 27:

> 25:  * @test
> 26:  * @bug 6742358
> 27:  * @summary MetalSliderUI paint wrong vertical disabled filled JSlider for DefaultMetalTheme

Summary sentence could be re-structured.

-------------

PR Review: https://git.openjdk.org/jdk/pull/18321#pullrequestreview-1945845023
PR Review Comment: https://git.openjdk.org/jdk/pull/18321#discussion_r1530142586

From abhiscxk at openjdk.org  Tue Mar 19 11:29:38 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Tue, 19 Mar 2024 11:29:38 GMT
Subject: RFR: 8328244: Convert javax/swing/JSlider/6742358/bug6742358.java
 applet test to main [v5]
In-Reply-To: <AN6EAjyACY33ukKyOjp8SuzxRt80B9Z_UO1fy83Nijw=.42fbb5cd-fb5c-413d-a1f2-842657fa7f0e@github.com>
References: <AN6EAjyACY33ukKyOjp8SuzxRt80B9Z_UO1fy83Nijw=.42fbb5cd-fb5c-413d-a1f2-842657fa7f0e@github.com>
Message-ID: <ewxc8Yh3zn8v8C2R4bTW0uc9mR9ASJpX4QngOMmDCGo=.c3b9b2ef-60c5-4aef-9b19-44023d00a19b@github.com>

> Conversion of manual applet test to main based using PassFailJFrame manual framework

Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:

  Summary rephrased and column limit addressed

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18321/files
  - new: https://git.openjdk.org/jdk/pull/18321/files/bb95c4e9..911063ac

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18321&range=04
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18321&range=03-04

  Stats: 13 lines in 1 file changed: 6 ins; 0 del; 7 mod
  Patch: https://git.openjdk.org/jdk/pull/18321.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18321/head:pull/18321

PR: https://git.openjdk.org/jdk/pull/18321

From abhiscxk at openjdk.org  Tue Mar 19 11:29:27 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Tue, 19 Mar 2024 11:29:27 GMT
Subject: Integrated: 8328262: Convert
 javax/swing/JSplitPane/8132123/bug8132123.java applet test to main
In-Reply-To: <UGuBjBTuGecghDM14mLTft1l8zGsY_PPueIqolFvq1U=.65c37ac4-3dbb-4385-85e5-f9393ec1445c@github.com>
References: <UGuBjBTuGecghDM14mLTft1l8zGsY_PPueIqolFvq1U=.65c37ac4-3dbb-4385-85e5-f9393ec1445c@github.com>
Message-ID: <s2W5EFCFjhKUXZOCotiJZuFgSZ_VA9vj7Dxy4aKSjOw=.8b09a618-5a02-43a8-aa85-dd7944bb28cd@github.com>

On Fri, 15 Mar 2024 10:56:54 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

> Conversion of manual applet test to main based using PassFailJFrame manual framework

This pull request has now been integrated.

Changeset: c01095c0
Author:    Abhishek Kumar <abhiscxk at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/c01095c0c9d4de1995d079be3356468196d9a25e
Stats:     166 lines in 3 files changed: 77 ins; 89 del; 0 mod

8328262: Convert javax/swing/JSplitPane/8132123/bug8132123.java applet test to main

Reviewed-by: psadhukhan, tr

-------------

PR: https://git.openjdk.org/jdk/pull/18325

From abhiscxk at openjdk.org  Tue Mar 19 11:33:24 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Tue, 19 Mar 2024 11:33:24 GMT
Subject: RFR: 8328244: Convert javax/swing/JSlider/6742358/bug6742358.java
 applet test to main [v4]
In-Reply-To: <RgP5vipGbP5lh9Ik6cQZyLMk9fZ0yYKeQYjvMh06bVI=.5ac0daae-c1ed-4e9c-b3a4-babf47390550@github.com>
References: <AN6EAjyACY33ukKyOjp8SuzxRt80B9Z_UO1fy83Nijw=.42fbb5cd-fb5c-413d-a1f2-842657fa7f0e@github.com>
 <tg3ksJkHLr36rUBzWL7NG7vyBTyBqYm76KV4OOso5HQ=.3d3050cd-a562-42d1-839e-8c8c5071af26@github.com>
 <RgP5vipGbP5lh9Ik6cQZyLMk9fZ0yYKeQYjvMh06bVI=.5ac0daae-c1ed-4e9c-b3a4-babf47390550@github.com>
Message-ID: <kKSAc4x75APQvelNkkyq1EmafuGHGTsFxJ6RIJTddeo=.640356a8-4392-4e5b-bceb-0720dce6a5df@github.com>

On Tue, 19 Mar 2024 10:56:38 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   jtreg tag update
>
> test/jdk/javax/swing/JSlider/bug6742358.java line 27:
> 
>> 25:  * @test
>> 26:  * @bug 6742358
>> 27:  * @summary MetalSliderUI paint wrong vertical disabled filled JSlider for DefaultMetalTheme
> 
> Summary sentence could be re-structured.

Updated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18321#discussion_r1530184987

From abhiscxk at openjdk.org  Tue Mar 19 12:10:22 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Tue, 19 Mar 2024 12:10:22 GMT
Subject: RFR: 8327840: Automate javax/swing/border/Test4129681.java [v3]
In-Reply-To: <7mXA4yB1IQMruvOFP2-u6IIiYPDX-wW8nnTIScNuqPQ=.75f7794c-27f6-4759-b3a2-ff65fbf367b8@github.com>
References: <BbQ2iwy01dkTxtQ9Aj7RhRkSxWm3pq3BEIlGIzlSTCk=.7bdaafe4-681a-4f03-8462-4ffa7dc99507@github.com>
 <7mXA4yB1IQMruvOFP2-u6IIiYPDX-wW8nnTIScNuqPQ=.75f7794c-27f6-4759-b3a2-ff65fbf367b8@github.com>
Message-ID: <qrwEtYGGNa2AYsMPBc2KOlMUbtQxugp5tmzRpXh8LWc=.7d325201-ad31-4756-ba86-0aae3b110442@github.com>

On Mon, 18 Mar 2024 13:29:37 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Automated the Test `javax/swing/border/Test4129681.java` from manual as suggested in JBS description.
>> Verified in CI system and its Green. The test has been verified for Metal L&F and the same is set explicitly..
>
> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review updates

Marked as reviewed by abhiscxk (Committer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18336#pullrequestreview-1946013961

From abhiscxk at openjdk.org  Tue Mar 19 12:14:22 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Tue, 19 Mar 2024 12:14:22 GMT
Subject: RFR: 8328227: Remove applet usage from JColorChooser tests
 Test4887836 [v2]
In-Reply-To: <n885WkCGJjRKjNsQb-rQ_kD3XLyPwQHJEx-Op_Lch3A=.95f0abd8-c9a3-497e-9fbe-15889ef5ce91@github.com>
References: <sz94hhkj7mCeInxQ075Uwe14NVjdUMDk3sbuOr1E2X0=.2cc0c644-dd7a-4044-aa17-c082abaf74b6@github.com>
 <n885WkCGJjRKjNsQb-rQ_kD3XLyPwQHJEx-Op_Lch3A=.95f0abd8-c9a3-497e-9fbe-15889ef5ce91@github.com>
Message-ID: <psLIJRARWBO0nsDfgGxkTCX18dRLTtLf7nIt9zANSlc=.73b0733c-5d08-429a-9cc8-64622c40109e@github.com>

On Mon, 18 Mar 2024 19:57:51 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> Removing applet usage from manual JColorChooser tests
>
> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   remove middle copyright year, update spacings and jtreg summary

test/jdk/javax/swing/JColorChooser/Test4887836.java line 41:

> 39: 
> 40:     public static void main(String[] args) throws Exception {
> 41:         String instructions = "If you do not see white area under the \"Swatches\" tab,\n" +

You may use `Text Block` for clean instructions.

> """
> Your Instructions. """;

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18316#discussion_r1530245280

From abhiscxk at openjdk.org  Tue Mar 19 12:16:21 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Tue, 19 Mar 2024 12:16:21 GMT
Subject: RFR: JDK-8328190 : Convert AWTPanelSmoothWheel.html applet test to
 main [v3]
In-Reply-To: <-76l48ZU_OawRCTXD7RyqR47QuC6WFZHpABRMf8PFyY=.6db9668d-df49-4412-b44b-d10d2ad845e3@github.com>
References: <sn9qb9ctS_sr3isHbwcbMCYh2RQokz2ptsw0rGBRnJY=.955d7549-72c7-4a4f-8ac8-a5d6f122cf68@github.com>
 <MPJgRPFs3q9yLE9tiHUrRqh-dPdkg_Kqwf9u1CfuS-8=.7e4e33f7-d775-446a-aeef-8a126f4dba4a@github.com>
 <Copfo7e_14Z5HM23jnUixI6EfnLQUYD72zCtzIX0do8=.e820764d-e181-4251-8c32-b082e5b3c60b@github.com>
 <5MG7j4Aphi1BnlAYJYXtR5nLkwQDM66c8dqMXpmnoW4=.51875b0f-7adb-4eb6-8951-5338bd0727ff@github.com>
 <-76l48ZU_OawRCTXD7RyqR47QuC6WFZHpABRMf8PFyY=.6db9668d-df49-4412-b44b-d10d2ad845e3@github.com>
Message-ID: <UrHLiNXYaCiVMWR3zATXVmLaHWvOZ-mOkbZnzDlxS1s=.8439b52e-6ab8-4d5c-949b-a0842f7287d3@github.com>

On Mon, 18 Mar 2024 17:28:16 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> It can be added, but I see no reason to do so.
>> 
>> It may be helpful for tests that can be run standalone (that don't respect the jtreg tags and depend on some other jtreg libraries), but for this one the only easy way to run it is through jtreg, so the `@requires (os.family == "windows")` is sufficient.
>
> I agree with @azvegint, since it has @requires check in jtreg and the test will mainly be run using jtreg framework , the OS check is not strictly required.

Fair enough.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18312#discussion_r1530248601

From abhiscxk at openjdk.org  Tue Mar 19 12:16:20 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Tue, 19 Mar 2024 12:16:20 GMT
Subject: RFR: JDK-8328190 : Convert AWTPanelSmoothWheel.html applet test to
 main [v4]
In-Reply-To: <p8toDCsUN5dAL4dDyYVndsUESgStV4k9kaORTsC30T0=.1bb5f251-baa8-4eb9-9edf-7a01bb004824@github.com>
References: <sn9qb9ctS_sr3isHbwcbMCYh2RQokz2ptsw0rGBRnJY=.955d7549-72c7-4a4f-8ac8-a5d6f122cf68@github.com>
 <p8toDCsUN5dAL4dDyYVndsUESgStV4k9kaORTsC30T0=.1bb5f251-baa8-4eb9-9edf-7a01bb004824@github.com>
Message-ID: <MGnRqVB_xWL5XEpCc-Uu6ZvdLpwc8hK4aPnvMVFQoqo=.9bdfbb9c-91c7-4b67-895c-0e758bad0769@github.com>

On Mon, 18 Mar 2024 17:27:43 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> This test is converted to main using PassFailJFrame. It verifies wheel rotation value for high-res mouse on windows.
>> 
>> The test requires the updated PassFailJFrame's logArea() feature added in this PR https://github.com/openjdk/jdk/pull/18319
>
> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   minor changes

Marked as reviewed by abhiscxk (Committer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18312#pullrequestreview-1946027722

From abhiscxk at openjdk.org  Tue Mar 19 12:25:22 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Tue, 19 Mar 2024 12:25:22 GMT
Subject: RFR: 8328401: Convert
 java/awt/Frame/InitialMaximizedTest/InitialMaximizedTest.html applet test to
 automated
In-Reply-To: <feEnRn4dLIWmgB9GyZd4ur-3buaDoiZ4eeynYShFz50=.f7eb7d90-464c-4231-8a6c-b97fc34378a5@github.com>
References: <feEnRn4dLIWmgB9GyZd4ur-3buaDoiZ4eeynYShFz50=.f7eb7d90-464c-4231-8a6c-b97fc34378a5@github.com>
Message-ID: <jNYJEBl6tZtuprRjlTnpxjjElGyFRFK73-ecAmsUoMU=.07458552-18d6-4217-ad23-93bf27f89dce@github.com>

On Mon, 18 Mar 2024 23:46:34 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

> The test converted to automated, CI and manual testing looks good on all platforms.

test/jdk/java/awt/Frame/InitialMaximizedTest/InitialMaximizedTest.java line 55:

> 53:             EventQueue.invokeAndWait(InitialMaximizedTest::createAndShowFrame);
> 54:             robot.waitForIdle();
> 55:             robot.delay(2000);

delay is too long ? Generally we have 1000 ms delay after creating test UI.

test/jdk/java/awt/Frame/InitialMaximizedTest/InitialMaximizedTest.java line 81:

> 79:         System.out.println("GraphicsConfiguration bounds " + gc.getBounds());
> 80:         System.out.println("Screen insets: " + screenInsets);
> 81:         System.out.println("Work area: " + workArea);

Is it intentional to keep so many print statement?

test/jdk/java/awt/Frame/InitialMaximizedTest/InitialMaximizedTest.java line 94:

> 92:         frame.setLocation(50, 50);
> 93:         frame.setExtendedState(Frame.MAXIMIZED_BOTH);
> 94:         frame.addWindowListener(new WindowAdapter() {

Suggestion:
May be replaced with 
`frame.setDefaultCloseOperation(JFrame.DISPOSE_ON_CLOSE);`

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18367#discussion_r1530251566
PR Review Comment: https://git.openjdk.org/jdk/pull/18367#discussion_r1530253414
PR Review Comment: https://git.openjdk.org/jdk/pull/18367#discussion_r1530259495

From abhiscxk at openjdk.org  Tue Mar 19 12:27:20 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Tue, 19 Mar 2024 12:27:20 GMT
Subject: RFR: JDK-8328379 : Convert URLDragTest.html applet test to main
In-Reply-To: <LMnkG1RNIu10nqg2m8IvZN73P9b1rFN4T56JjPmgZLk=.8cde2a03-28b8-4dc5-84b7-2be086494f13@github.com>
References: <LMnkG1RNIu10nqg2m8IvZN73P9b1rFN4T56JjPmgZLk=.8cde2a03-28b8-4dc5-84b7-2be086494f13@github.com>
Message-ID: <MZ4cUEhwD2z82SB3NNEMNFibXNrvzWiJeMsX2tT5g0o=.3c7127b4-7edf-4757-b6cc-c1464ad5b7c7@github.com>

On Mon, 18 Mar 2024 20:53:50 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

> Following test - test/jdk/java/awt/dnd/URLDragTest/URLDragTest.html is converted from applet to main using PassFailJFrame. 
> 
> PassFailJFrame's `logArea()` is used for logging messages.

Marked as reviewed by abhiscxk (Committer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18364#pullrequestreview-1946049916

From tr at openjdk.org  Tue Mar 19 12:40:20 2024
From: tr at openjdk.org (Tejesh R)
Date: Tue, 19 Mar 2024 12:40:20 GMT
Subject: RFR: 8328244: Convert javax/swing/JSlider/6742358/bug6742358.java
 applet test to main [v5]
In-Reply-To: <ewxc8Yh3zn8v8C2R4bTW0uc9mR9ASJpX4QngOMmDCGo=.c3b9b2ef-60c5-4aef-9b19-44023d00a19b@github.com>
References: <AN6EAjyACY33ukKyOjp8SuzxRt80B9Z_UO1fy83Nijw=.42fbb5cd-fb5c-413d-a1f2-842657fa7f0e@github.com>
 <ewxc8Yh3zn8v8C2R4bTW0uc9mR9ASJpX4QngOMmDCGo=.c3b9b2ef-60c5-4aef-9b19-44023d00a19b@github.com>
Message-ID: <HJ6KzXom3mwS2cITYkN4WH4tM_SvApiyrk-s5Wdssac=.d79e9a63-b1cf-49ba-8103-0365de487813@github.com>

On Tue, 19 Mar 2024 11:29:38 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Conversion of manual applet test to main based using PassFailJFrame manual framework
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Summary rephrased and column limit addressed

Marked as reviewed by tr (Committer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18321#pullrequestreview-1946087001

From kizune at openjdk.org  Tue Mar 19 13:55:28 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Tue, 19 Mar 2024 13:55:28 GMT
Subject: Integrated: 8328279: Convert
 java/awt/Cursor/CursorOverlappedPanelsTest test to main
In-Reply-To: <l6NLWusbqshFG9pUWWsoatnBo79fRPWVqtjLmkd3gTo=.7ca881bb-6874-4328-acb6-0b895df0e56e@github.com>
References: <l6NLWusbqshFG9pUWWsoatnBo79fRPWVqtjLmkd3gTo=.7ca881bb-6874-4328-acb6-0b895df0e56e@github.com>
Message-ID: <pk_dg7bwjofvym5aPkKANNmL6du-T6jApSlCINshCAc=.d2ef663d-eeef-40aa-865c-8816967aff7c@github.com>

On Fri, 15 Mar 2024 16:13:33 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

> Converted to a main manual test.

This pull request has now been integrated.

Changeset: 2094ff3c
Author:    Alexander Zuev <kizune at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/2094ff3c7ad829355bf13760d9a19b37649b3517
Stats:     348 lines in 3 files changed: 90 ins; 258 del; 0 mod

8328279: Convert java/awt/Cursor/CursorOverlappedPanelsTest test to main

Reviewed-by: honkar, abhiscxk

-------------

PR: https://git.openjdk.org/jdk/pull/18331

From kizune at openjdk.org  Tue Mar 19 13:59:36 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Tue, 19 Mar 2024 13:59:36 GMT
Subject: RFR: 8328367: Convert java/awt/Component/UpdatingBootTime test to
 main [v2]
In-Reply-To: <9gtCIzXrOP-RQJyjhkP8ibENRjEXP9rMUkEbZry4uWc=.2d949d4b-c1ed-45b0-84b9-82859af8a4b0@github.com>
References: <9gtCIzXrOP-RQJyjhkP8ibENRjEXP9rMUkEbZry4uWc=.2d949d4b-c1ed-45b0-84b9-82859af8a4b0@github.com>
Message-ID: <G8m7Ov8HhZwAW1qZKzu-HP1oVjuKpGwEGVt5FePi9W8=.7603e0a6-104a-4223-b9f8-619f9c6f39ef@github.com>

> Convert test to manual main
> Move test to the Component folder

Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:

  Adding a tibrary abd build clauses

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18355/files
  - new: https://git.openjdk.org/jdk/pull/18355/files/a3ef58d5..c1f988f5

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18355&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18355&range=00-01

  Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18355.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18355/head:pull/18355

PR: https://git.openjdk.org/jdk/pull/18355

From kizune at openjdk.org  Tue Mar 19 14:01:42 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Tue, 19 Mar 2024 14:01:42 GMT
Subject: RFR: 8328377: Convert java/awt/Cursor/MultiResolutionCursorTest
 test to main [v2]
In-Reply-To: <Y_DvKb6DvMCmv7RwRVmVh8OoSPikpEmcEbXtpVv9a20=.2809223d-537e-4de3-bb75-986db8154edc@github.com>
References: <Y_DvKb6DvMCmv7RwRVmVh8OoSPikpEmcEbXtpVv9a20=.2809223d-537e-4de3-bb75-986db8154edc@github.com>
Message-ID: <0dSFss67MVf8pZb_0BARTl70xls7xvxJnk1kYV81SOM=.611ad917-5e66-4c8d-9fdd-938adb21c486@github.com>

> Convert test to manual main and move from the dedicated folder
> Remove old files

Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:

  Adding library and build clauses

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18357/files
  - new: https://git.openjdk.org/jdk/pull/18357/files/79e4faeb..10235707

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18357&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18357&range=00-01

  Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18357.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18357/head:pull/18357

PR: https://git.openjdk.org/jdk/pull/18357

From kizune at openjdk.org  Tue Mar 19 14:03:54 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Tue, 19 Mar 2024 14:03:54 GMT
Subject: RFR: 8328378: Convert java/awt/FileDialog/FileDialogForDirectories
 test to main [v2]
In-Reply-To: <2yId9SKzUfB9ZnRy1Ma_m6jye3Mad5UIx-mxcgcZdZ8=.b71c078f-0a57-4b4c-b1ce-a98d23df0b48@github.com>
References: <2yId9SKzUfB9ZnRy1Ma_m6jye3Mad5UIx-mxcgcZdZ8=.b71c078f-0a57-4b4c-b1ce-a98d23df0b48@github.com>
Message-ID: <yJiiqlPyMc2tO_u1G7bVa8HNDFLmimQY-svU5zpxX4I=.d0c4d5dd-50b7-4eb0-bb3d-a44362b9d565@github.com>

> Convert test to main manual and move to the appropriate folder
> Remove old files

Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:

  Adding library and build clauses

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18358/files
  - new: https://git.openjdk.org/jdk/pull/18358/files/b6c0cc2e..d8f2aa64

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18358&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18358&range=00-01

  Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18358.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18358/head:pull/18358

PR: https://git.openjdk.org/jdk/pull/18358

From kizune at openjdk.org  Tue Mar 19 14:09:38 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Tue, 19 Mar 2024 14:09:38 GMT
Subject: RFR: 8328384: Convert java/awt/FileDialog/FileDialogOpenDirTest
 test to main [v2]
In-Reply-To: <uRRE9Iw6m8G9T9H0FWEYnUoGgInL7vGgYMPBwP7jEVI=.cb6605a0-f79a-4903-b565-e5dc29d81df2@github.com>
References: <uRRE9Iw6m8G9T9H0FWEYnUoGgInL7vGgYMPBwP7jEVI=.cb6605a0-f79a-4903-b565-e5dc29d81df2@github.com>
Message-ID: <QiaL6js6ptfnu7hoFmCjtprad1ZwWjAnuDJs3q6TLr4=.0fac2ed6-3704-44ff-8395-e172f0bb0692@github.com>

> Convert test to main manual;
> Move test to appropriate folder;
> Delete old files;

Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:

  Adding library and build clauses

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18361/files
  - new: https://git.openjdk.org/jdk/pull/18361/files/874de3d1..5b8216b0

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18361&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18361&range=00-01

  Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18361.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18361/head:pull/18361

PR: https://git.openjdk.org/jdk/pull/18361

From kizune at openjdk.org  Tue Mar 19 14:10:42 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Tue, 19 Mar 2024 14:10:42 GMT
Subject: RFR: 8328385: Convert java/awt/FileDialog/FileDialogReturnTest
 test to main [v2]
In-Reply-To: <fqHwY3Ipk9ArGTOnM26LF_dxWaQeptZ8Kf9fKNWUPVg=.43700ff8-5123-444a-817d-173bd126368d@github.com>
References: <fqHwY3Ipk9ArGTOnM26LF_dxWaQeptZ8Kf9fKNWUPVg=.43700ff8-5123-444a-817d-173bd126368d@github.com>
Message-ID: <q6Mpfnmftki-H2XIbZ6DAdHZyMs1aciwyrRERfdr5u4=.007c6a8b-03cc-4582-8e5f-ef60fe3898e5@github.com>

> Convert test to a main method based;
> Move test to an apropriate location;
> Remove old files;

Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:

  Adding library and build clauses

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18363/files
  - new: https://git.openjdk.org/jdk/pull/18363/files/77f37032..9c5554f7

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18363&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18363&range=00-01

  Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18363.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18363/head:pull/18363

PR: https://git.openjdk.org/jdk/pull/18363

From kizune at openjdk.org  Tue Mar 19 14:10:52 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Tue, 19 Mar 2024 14:10:52 GMT
Subject: RFR: 8328382: Convert java/awt/FileDialog/FileDialogForPackages
 test to main [v2]
In-Reply-To: <9gStC1mcEgWDsQsLiOUD0PHZ1mgIEgaM3f_EAQokmv0=.7f9ce16a-2180-4dea-96af-bcbcf955eec7@github.com>
References: <9gStC1mcEgWDsQsLiOUD0PHZ1mgIEgaM3f_EAQokmv0=.7f9ce16a-2180-4dea-96af-bcbcf955eec7@github.com>
Message-ID: <_ytFO979o9K4RS7fFO_JTQKBda1f-S-at-TBIiWeLhs=.f9467d54-2198-4f3d-a3bc-c90e3a36c2e4@github.com>

> Convert test to a main based;
> Move test to an appropriate folder;
> Remove old files;

Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:

  Adding library and build clauses

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18360/files
  - new: https://git.openjdk.org/jdk/pull/18360/files/0cc79c16..3e84d47a

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18360&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18360&range=00-01

  Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18360.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18360/head:pull/18360

PR: https://git.openjdk.org/jdk/pull/18360

From kizune at openjdk.org  Tue Mar 19 14:15:50 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Tue, 19 Mar 2024 14:15:50 GMT
Subject: RFR: 8328386: Convert java/awt/FileDialog/FileNameOverrideTest test to
 main
Message-ID: <Yhj0URlGvlalLqkqDnfMrkWbz24Pjab1KZxDHmN4HwA=.7b8b7630-74d0-4114-a650-d6d2afd98075@github.com>

Convert applet based test to a main based test;
Move test to an apporpriate location;
Remove old files;

-------------

Commit messages:
 - Addid library and build clauses;
 - 8328386: Convert java/awt/FileDialog/FileNameOverrideTest test to main

Changes: https://git.openjdk.org/jdk/pull/18365/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18365&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8328386
  Stats: 253 lines in 3 files changed: 112 ins; 141 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18365.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18365/head:pull/18365

PR: https://git.openjdk.org/jdk/pull/18365

From kizune at openjdk.org  Tue Mar 19 14:17:54 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Tue, 19 Mar 2024 14:17:54 GMT
Subject: RFR: 8328367: Convert java/awt/Component/UpdatingBootTime test to
 main [v3]
In-Reply-To: <9gtCIzXrOP-RQJyjhkP8ibENRjEXP9rMUkEbZry4uWc=.2d949d4b-c1ed-45b0-84b9-82859af8a4b0@github.com>
References: <9gtCIzXrOP-RQJyjhkP8ibENRjEXP9rMUkEbZry4uWc=.2d949d4b-c1ed-45b0-84b9-82859af8a4b0@github.com>
Message-ID: <UMYqk4ABYWo7VysmwZuoCbLVYssS9ArWO-uHYef3wUo=.a230b8e0-8a59-463a-a15f-2faa67064b53@github.com>

> Convert test to manual main
> Move test to the Component folder

Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:

  Fixing instructions.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18355/files
  - new: https://git.openjdk.org/jdk/pull/18355/files/c1f988f5..891a2e83

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18355&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18355&range=01-02

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/18355.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18355/head:pull/18355

PR: https://git.openjdk.org/jdk/pull/18355

From kizune at openjdk.org  Tue Mar 19 14:17:55 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Tue, 19 Mar 2024 14:17:55 GMT
Subject: RFR: 8328367: Convert java/awt/Component/UpdatingBootTime test to
 main [v3]
In-Reply-To: <ax0JxLAdn4K1UbdxSV37LrIiRcVuOWzHt1-MRJw9QU4=.de80adb8-38d1-423d-b8ff-e17c3425eaed@github.com>
References: <9gtCIzXrOP-RQJyjhkP8ibENRjEXP9rMUkEbZry4uWc=.2d949d4b-c1ed-45b0-84b9-82859af8a4b0@github.com>
 <ax0JxLAdn4K1UbdxSV37LrIiRcVuOWzHt1-MRJw9QU4=.de80adb8-38d1-423d-b8ff-e17c3425eaed@github.com>
Message-ID: <ifN5sSD_mWpbBmEd_TOTSLfTjG2W26PvcJnsv8Q5RLo=.e1ce3865-00f4-40fb-8c3a-3a692fcb07e1@github.com>

On Tue, 19 Mar 2024 06:00:56 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fixing instructions.
>
> test/jdk/java/awt/Component/UpdatingBootTime.java line 27:
> 
>> 25:  * @test
>> 26:  * @bug 6461933 7194219
>> 27:  * @summary adjust system boot time in nowMillisUTC() frequently
> 
> Guess you need @library for PassFailJFrame

Sure. Here and in all other tests.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18355#discussion_r1530454679

From abhiscxk at openjdk.org  Tue Mar 19 15:09:27 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Tue, 19 Mar 2024 15:09:27 GMT
Subject: Integrated: 8328244: Convert
 javax/swing/JSlider/6742358/bug6742358.java applet test to main
In-Reply-To: <AN6EAjyACY33ukKyOjp8SuzxRt80B9Z_UO1fy83Nijw=.42fbb5cd-fb5c-413d-a1f2-842657fa7f0e@github.com>
References: <AN6EAjyACY33ukKyOjp8SuzxRt80B9Z_UO1fy83Nijw=.42fbb5cd-fb5c-413d-a1f2-842657fa7f0e@github.com>
Message-ID: <G0g4za1v9GWRKfOHlA3K7Vf0t8ZqoaPx4Myp2iA0TB8=.e51cf552-7562-4cde-b3b5-6cffb5f526f7@github.com>

On Fri, 15 Mar 2024 05:55:28 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

> Conversion of manual applet test to main based using PassFailJFrame manual framework

This pull request has now been integrated.

Changeset: 5f2a92d9
Author:    Abhishek Kumar <abhiscxk at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/5f2a92d954ce485d372c3cb3e5118556b1d076c3
Stats:     227 lines in 3 files changed: 106 ins; 121 del; 0 mod

8328244: Convert javax/swing/JSlider/6742358/bug6742358.java applet test to main

Reviewed-by: psadhukhan, tr

-------------

PR: https://git.openjdk.org/jdk/pull/18321

From azvegint at openjdk.org  Tue Mar 19 15:12:34 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Tue, 19 Mar 2024 15:12:34 GMT
Subject: RFR: 8328401: Convert
 java/awt/Frame/InitialMaximizedTest/InitialMaximizedTest.html applet test to
 automated [v2]
In-Reply-To: <feEnRn4dLIWmgB9GyZd4ur-3buaDoiZ4eeynYShFz50=.f7eb7d90-464c-4231-8a6c-b97fc34378a5@github.com>
References: <feEnRn4dLIWmgB9GyZd4ur-3buaDoiZ4eeynYShFz50=.f7eb7d90-464c-4231-8a6c-b97fc34378a5@github.com>
Message-ID: <1tv0wI_4pAfwMqK2o98hA5QIb4xGSR2n9ymIgIurJpM=.a5c297ba-aa64-4388-99de-91c764072edf@github.com>

> The test converted to automated, CI and manual testing looks good on all platforms.

Alexander Zvegintsev has updated the pull request incrementally with one additional commit since the last revision:

  reduce delay

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18367/files
  - new: https://git.openjdk.org/jdk/pull/18367/files/c00873e7..430e3e71

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18367&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18367&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/18367.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18367/head:pull/18367

PR: https://git.openjdk.org/jdk/pull/18367

From abhiscxk at openjdk.org  Tue Mar 19 15:12:34 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Tue, 19 Mar 2024 15:12:34 GMT
Subject: RFR: 8328401: Convert
 java/awt/Frame/InitialMaximizedTest/InitialMaximizedTest.html applet test to
 automated [v2]
In-Reply-To: <1tv0wI_4pAfwMqK2o98hA5QIb4xGSR2n9ymIgIurJpM=.a5c297ba-aa64-4388-99de-91c764072edf@github.com>
References: <feEnRn4dLIWmgB9GyZd4ur-3buaDoiZ4eeynYShFz50=.f7eb7d90-464c-4231-8a6c-b97fc34378a5@github.com>
 <1tv0wI_4pAfwMqK2o98hA5QIb4xGSR2n9ymIgIurJpM=.a5c297ba-aa64-4388-99de-91c764072edf@github.com>
Message-ID: <i4csbvss6tHQY8u46LlBRFRlVBKNtj_Ql0j_nDFLpUU=.41430c2a-a4b9-452a-b0b9-c3cdebfac338@github.com>

On Tue, 19 Mar 2024 15:09:24 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>> The test converted to automated, CI and manual testing looks good on all platforms.
>
> Alexander Zvegintsev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   reduce delay

Marked as reviewed by abhiscxk (Committer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18367#pullrequestreview-1946558399

From azvegint at openjdk.org  Tue Mar 19 15:12:35 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Tue, 19 Mar 2024 15:12:35 GMT
Subject: RFR: 8328401: Convert
 java/awt/Frame/InitialMaximizedTest/InitialMaximizedTest.html applet test to
 automated [v2]
In-Reply-To: <jNYJEBl6tZtuprRjlTnpxjjElGyFRFK73-ecAmsUoMU=.07458552-18d6-4217-ad23-93bf27f89dce@github.com>
References: <feEnRn4dLIWmgB9GyZd4ur-3buaDoiZ4eeynYShFz50=.f7eb7d90-464c-4231-8a6c-b97fc34378a5@github.com>
 <jNYJEBl6tZtuprRjlTnpxjjElGyFRFK73-ecAmsUoMU=.07458552-18d6-4217-ad23-93bf27f89dce@github.com>
Message-ID: <cljh78g-1UoMEZWdwjZ6VrKG-zOmfR44NiyaB3MbryQ=.62685d4e-445e-467d-9ed5-5c2a4b4c9e98@github.com>

On Tue, 19 Mar 2024 12:16:08 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Alexander Zvegintsev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   reduce delay
>
> test/jdk/java/awt/Frame/InitialMaximizedTest/InitialMaximizedTest.java line 55:
> 
>> 53:             EventQueue.invokeAndWait(InitialMaximizedTest::createAndShowFrame);
>> 54:             robot.waitForIdle();
>> 55:             robot.delay(2000);
> 
> delay is too long ? Generally we have 1000 ms delay after creating test UI.

Reduced

> test/jdk/java/awt/Frame/InitialMaximizedTest/InitialMaximizedTest.java line 81:
> 
>> 79:         System.out.println("GraphicsConfiguration bounds " + gc.getBounds());
>> 80:         System.out.println("Screen insets: " + screenInsets);
>> 81:         System.out.println("Work area: " + workArea);
> 
> Is it intentional to keep so many print statement?

Looks cleaner to me than

System.out.println(
        "Frame bounds " + frameBounds +
        "\nGraphicsConfiguration bounds " + gc.getBounds() +
        "\nScreen insets: " + screenInsets +
        "\nWork area: " + workArea
);

> test/jdk/java/awt/Frame/InitialMaximizedTest/InitialMaximizedTest.java line 94:
> 
>> 92:         frame.setLocation(50, 50);
>> 93:         frame.setExtendedState(Frame.MAXIMIZED_BOTH);
>> 94:         frame.addWindowListener(new WindowAdapter() {
> 
> Suggestion:
> May be replaced with 
> `frame.setDefaultCloseOperation(JFrame.DISPOSE_ON_CLOSE);`

`java.awt.Frame` does not have the `setDefaultCloseOperation`, it is a `JFrame` method.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18367#discussion_r1530575589
PR Review Comment: https://git.openjdk.org/jdk/pull/18367#discussion_r1530572855
PR Review Comment: https://git.openjdk.org/jdk/pull/18367#discussion_r1530575047

From abhiscxk at openjdk.org  Tue Mar 19 15:12:35 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Tue, 19 Mar 2024 15:12:35 GMT
Subject: RFR: 8328401: Convert
 java/awt/Frame/InitialMaximizedTest/InitialMaximizedTest.html applet test to
 automated [v2]
In-Reply-To: <cljh78g-1UoMEZWdwjZ6VrKG-zOmfR44NiyaB3MbryQ=.62685d4e-445e-467d-9ed5-5c2a4b4c9e98@github.com>
References: <feEnRn4dLIWmgB9GyZd4ur-3buaDoiZ4eeynYShFz50=.f7eb7d90-464c-4231-8a6c-b97fc34378a5@github.com>
 <jNYJEBl6tZtuprRjlTnpxjjElGyFRFK73-ecAmsUoMU=.07458552-18d6-4217-ad23-93bf27f89dce@github.com>
 <cljh78g-1UoMEZWdwjZ6VrKG-zOmfR44NiyaB3MbryQ=.62685d4e-445e-467d-9ed5-5c2a4b4c9e98@github.com>
Message-ID: <b3S-DLHkvnpElSBC9vD7BUitxr776Slki4j3EmwhiBc=.6dc0179d-4feb-4439-a21f-63a97cc51432@github.com>

On Tue, 19 Mar 2024 15:06:02 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>> test/jdk/java/awt/Frame/InitialMaximizedTest/InitialMaximizedTest.java line 94:
>> 
>>> 92:         frame.setLocation(50, 50);
>>> 93:         frame.setExtendedState(Frame.MAXIMIZED_BOTH);
>>> 94:         frame.addWindowListener(new WindowAdapter() {
>> 
>> Suggestion:
>> May be replaced with 
>> `frame.setDefaultCloseOperation(JFrame.DISPOSE_ON_CLOSE);`
>
> `java.awt.Frame` does not have the `setDefaultCloseOperation`, it is a `JFrame` method.

Ok. I misread it as JFrame.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18367#discussion_r1530579702

From azvegint at openjdk.org  Tue Mar 19 15:36:24 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Tue, 19 Mar 2024 15:36:24 GMT
Subject: RFR: 8328386: Convert java/awt/FileDialog/FileNameOverrideTest
 test to main
In-Reply-To: <Yhj0URlGvlalLqkqDnfMrkWbz24Pjab1KZxDHmN4HwA=.7b8b7630-74d0-4114-a650-d6d2afd98075@github.com>
References: <Yhj0URlGvlalLqkqDnfMrkWbz24Pjab1KZxDHmN4HwA=.7b8b7630-74d0-4114-a650-d6d2afd98075@github.com>
Message-ID: <InjHFCVLAtlv3h1gqy5UIKy_rjHkkT1b2C1137wYxyI=.0259a34c-68b4-489f-b690-dcc6706751c1@github.com>

On Mon, 18 Mar 2024 21:00:36 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

> Convert applet based test to a main based test;
> Move test to an apporpriate location;
> Remove old files;

test/jdk/java/awt/FileDialog/FileNameOverrideTest.java line 32:

> 30:  * @build PassFailJFrame
> 31:  * @run main/manual FileNameOverrideTest
> 32:  */

We usually move this block just before a class declaration, for better readability.

test/jdk/java/awt/FileDialog/FileNameOverrideTest.java line 93:

> 91:                 1) Click on 'Show File Dialog' button. A file dialog will come up.
> 92:                 2) Double-click on '$clickDirName' and click OK.
> 93:                 3) The text in the text field will indicate if test is passed or failed.

It looks like we can remove the text field and its output altogether, and use `PassFailJFrame#forcePass`, `PassFailJFrame#forceFail` to finish the test.

test/jdk/java/awt/FileDialog/FileNameOverrideTest.java line 94:

> 92:                 2) Double-click on '$clickDirName' and click OK.
> 93:                 3) The text in the text field will indicate if test is passed or failed.
> 94:                 """;

Suggestion:

                """.replace("$clickDirName", clickDirName);

test/jdk/java/awt/FileDialog/FileNameOverrideTest.java line 100:

> 98:             instructions = """
> 99:                     The test is not applicable for $toolkit. Press Pass.
> 100:                     """. replace("$toolkit", toolkit);

There is no point in showing the instruction window in this case, it is probably better to just throw the `jtreg.SkippedException`.

test/jdk/java/awt/FileDialog/FileNameOverrideTest.java line 108:

> 106:                 .rows((int) instructions.lines().count() + 1)
> 107:                 .columns(50)
> 108:                 .testUI(FileNameOverrideTest::initialize)

It is possible to get rid of the extra frame, e.g. make the `initialize` return the "Show File Dialog" `JButton`

Suggestion:

                .splitUIBottom(FileNameOverrideTest::initialize)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18365#discussion_r1530610368
PR Review Comment: https://git.openjdk.org/jdk/pull/18365#discussion_r1530597135
PR Review Comment: https://git.openjdk.org/jdk/pull/18365#discussion_r1530621068
PR Review Comment: https://git.openjdk.org/jdk/pull/18365#discussion_r1530618895
PR Review Comment: https://git.openjdk.org/jdk/pull/18365#discussion_r1530603508

From honkar at openjdk.org  Tue Mar 19 17:07:40 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Tue, 19 Mar 2024 17:07:40 GMT
Subject: RFR: JDK-8328012 : Convert InputMethod (/java/awt/im) applet tests
 to main [v6]
In-Reply-To: <iDY1JdxeSzLcbW-ASx1PylUqKY-kGUjMj8tr4Sj5NDM=.a0b9fbdb-a959-4e98-ae08-d086fd8f210f@github.com>
References: <iDY1JdxeSzLcbW-ASx1PylUqKY-kGUjMj8tr4Sj5NDM=.a0b9fbdb-a959-4e98-ae08-d086fd8f210f@github.com>
Message-ID: <m3l2p3830uamdM4tgB1_HhuzQr8G6TCpf9QlBj8upIg=.94e96a11-4fa0-4bcb-b89c-95ad217c4300@github.com>

> Following InputMethod applet tests are converted to main using PassFailJFrame
> 
> 1. java/awt/im/8132503/bug8132503.java (Renamed to PinyinIMFullstopTest.java)
> 2. java/awt/im/8148984/bug8148984.java (Renamed to PinyinIMCommaTest.java) 
> 
> - test instructions are updated to make to more clear
> - tests renamed 
> - moved one directory above - /java/awt/im/
> - html file deleted.
> 
> Two tests are updated as part of this PR as they are similar, details here https://github.com/openjdk/jdk/pull/18251#issuecomment-1992577598

Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:

  OS check removed

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18251/files
  - new: https://git.openjdk.org/jdk/pull/18251/files/19fa3fe8..0580da43

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18251&range=05
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18251&range=04-05

  Stats: 18 lines in 2 files changed: 0 ins; 14 del; 4 mod
  Patch: https://git.openjdk.org/jdk/pull/18251.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18251/head:pull/18251

PR: https://git.openjdk.org/jdk/pull/18251

From aivanov at openjdk.org  Tue Mar 19 17:11:24 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 19 Mar 2024 17:11:24 GMT
Subject: RFR: 8327137: Add test for ConcurrentModificationException in
 BasicDirectoryModel [v3]
In-Reply-To: <Chb_zgl53KY05-E3fKBAF61S8SO4Bi7LMlGkART_3io=.7845c015-4fd7-4ce5-bf27-7994cbf2471a@github.com>
References: <mCqqjrXVWDB2PvpOhKHx-Hr8W6tUz6v4stztGmyAeEg=.1f95da1c-e1a5-40be-be8b-0758729fa9b9@github.com>
 <HvJ96YzIfnTtdNh7R5XtYs_t0sc5VfHjBHUxi9uyJdI=.94715923-e3c0-4666-9a51-340ef91b8b3b@github.com>
 <V1fPYAjQ6U8TFSOTRQ-Fk9dRnFAwbimWAPUkicxtklk=.6fe019f2-a478-4e11-8c02-b606f8f14709@github.com>
 <Chb_zgl53KY05-E3fKBAF61S8SO4Bi7LMlGkART_3io=.7845c015-4fd7-4ce5-bf27-7994cbf2471a@github.com>
Message-ID: <d5JjW3jU1caR7NXz_sfQ78zXMSmxqLi_ony4WorDSh8=.5122b277-8ddc-40a0-a6ec-a5ae6226246b@github.com>

On Tue, 19 Mar 2024 01:08:25 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>> I don't think it matters here? The test does not rely on even processing on EDT, no state of `JFileChooser` is modified except for calling `rescanCurrentDirectory`. Technically, I am not allowed to do so either. But if I call `rescanCurrentDirectory` from EDT only, the test becomes void.
>
> I think it will fire the property change events via firePropertyChange from the constructor and it is better to do that on EDT.

I guess it does fire property change events on the current thread rather than EDT in this case. I still don't think it matters in this case. After the `JFileChooser` is created, it is accessed on the Scanner threads only, and only to call its `rescanCurrentDirectory` method. This call, in its turn, creates a new background thread which accesses the fields and methods of `JFileChooser` as well as `FileSystemView`.

Instantiating `JFileChooser` on EDT adds complexity for no benefit. The `JFileChooser` is still accessed concurrently from several threads, including Swing internal thread.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18109#discussion_r1530766002

From aivanov at openjdk.org  Tue Mar 19 17:11:25 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 19 Mar 2024 17:11:25 GMT
Subject: RFR: 8327137: Add test for ConcurrentModificationException in
 BasicDirectoryModel [v3]
In-Reply-To: <A1Xg00x43EWd5dSFubiC2EeaiUcyY3Ale2aiOYeHxg0=.59600fe8-c41a-42fb-9520-4f84883c2db7@github.com>
References: <mCqqjrXVWDB2PvpOhKHx-Hr8W6tUz6v4stztGmyAeEg=.1f95da1c-e1a5-40be-be8b-0758729fa9b9@github.com>
 <HvJ96YzIfnTtdNh7R5XtYs_t0sc5VfHjBHUxi9uyJdI=.94715923-e3c0-4666-9a51-340ef91b8b3b@github.com>
 <A1Xg00x43EWd5dSFubiC2EeaiUcyY3Ale2aiOYeHxg0=.59600fe8-c41a-42fb-9520-4f84883c2db7@github.com>
Message-ID: <siyhb-Ku2hfCz7Z_hOuv1mujSZiQru5pTLsqxRuScLc=.7d070e08-4e1e-491f-a6e5-25b50c07f3fd@github.com>

On Fri, 15 Mar 2024 11:17:08 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> test/jdk/javax/swing/plaf/basic/BasicDirectoryModel/ConcurrentModification.java line 211:
>> 
>>> 209:     private static void deleteFile(final Path file) {
>>> 210:         try {
>>> 211:             Files.delete(file);
>> 
>> Should we try to delete all files first and then throw an exception if any?
>
> I do try to remove all the files:
> 
> https://github.com/openjdk/jdk/blob/0d6be7a4e4368ea67382af4321b9483236276e5a/test/jdk/javax/swing/plaf/basic/BasicDirectoryModel/ConcurrentModification.java#L115-L120
> 
> https://github.com/openjdk/jdk/blob/0d6be7a4e4368ea67382af4321b9483236276e5a/test/jdk/javax/swing/plaf/basic/BasicDirectoryModel/ConcurrentModification.java#L202-L215
> 
> Probably, this can be chained via `handleException`. On the other hand, I don't want to fail the test if cleaning up the files fails. However, now an exception thrown from the `finally` block will override any exception thrown from the test code, which is a bad thing, so I'll need to reconsider exception handling during clean-up.
> 
> If test fails to clean up the files it created, jtreg will remove them. It is the reason why I use the current directory as the base, which is the `scratch` directory when run in jtreg.

I updated the code to avoid throwing `IOException` from cleaning up code. If an exception occurs, its stack trace is printed to `stderr`. The test will not fail if cleaning up the files fails.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18109#discussion_r1530772076

From aivanov at openjdk.org  Tue Mar 19 17:11:24 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 19 Mar 2024 17:11:24 GMT
Subject: RFR: 8327137: Add test for ConcurrentModificationException in
 BasicDirectoryModel
In-Reply-To: <YlEf-rnP9E5iSzk8W5YhsLokR44b_NZnU-o3RpB2yfk=.c9c0e2bc-2a86-4818-8ae7-0d6df7108060@github.com>
References: <mCqqjrXVWDB2PvpOhKHx-Hr8W6tUz6v4stztGmyAeEg=.1f95da1c-e1a5-40be-be8b-0758729fa9b9@github.com>
 <aRuO2zb4IkM3F28MH5RcfHesc1Z9i7w_uK8kSkIh6i0=.cce14bf8-3384-4e8e-9c12-4e0708dbf3ab@github.com>
 <iT0AkMDtFdmSgs9hw1n8wICk_ywpXnbklk9I-STL7WM=.d6dc05f1-7cdc-43f2-bc86-dc9e7e3bdc39@github.com>
 <MjyHoVphv3Ydr6ZvzpIwEEJa9ijiccVne_AUzme8e8c=.09ad81a2-13e9-4b6f-93c8-5a4e8e0192a1@github.com>
 <e2WB9a0OV6zGGQClxDliRZpSybk0Yf-1tghML0ddNM4=.e571d038-cbbc-4f29-8618-60c9df796169@github.com>
 <YlEf-rnP9E5iSzk8W5YhsLokR44b_NZnU-o3RpB2yfk=.c9c0e2bc-2a86-4818-8ae7-0d6df7108060@github.com>
Message-ID: <f8GBiDLMGxzR_kHRH5d_5HA6xmr1Hh5W3lXhYQZpVT8=.9456f659-4c36-4fb4-bf36-11d769732543@github.com>

On Mon, 18 Mar 2024 15:09:20 GMT, Christoph Langer <clanger at openjdk.org> wrote:

> > Yes, it's running in 21 and 22 as well, so we'll see what happens there.
> 
> We got the following, once in jdk21u and once in jdk21u-dev on macintelx64 through the weekend:

Thank you, Christoph! @RealCLanger. At least one failure is detected. It's better than nothing, isn't it?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18109#issuecomment-2007709744

From aivanov at openjdk.org  Tue Mar 19 17:21:21 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 19 Mar 2024 17:21:21 GMT
Subject: RFR: JDK-8328225: Convert ImageDecoratedDnD.html applet test to
 main
In-Reply-To: <8-xeU7RcrWLzg2ODCm5TFeqO8d_XR4uDsiy-VdLMB0c=.391ef94a-1c24-4799-9ae4-a7fb752364ab@github.com>
References: <yHnt-BqOUlo1IKduuk0nv0ZsoReWANI_g4BxukwDzUQ=.24dff5fe-2737-45cc-867e-42f137172363@github.com>
 <8-xeU7RcrWLzg2ODCm5TFeqO8d_XR4uDsiy-VdLMB0c=.391ef94a-1c24-4799-9ae4-a7fb752364ab@github.com>
Message-ID: <EQ8YZvKs697eQMIey3hBQTA4pE9eWUWBEsS_izstbo8=.32976ff4-3e49-4509-86a1-6f87a6d90141@github.com>

On Thu, 14 Mar 2024 22:44:24 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Following test is converted to main using PassFailJFrame.
>
> test/jdk/java/awt/dnd/ImageDecoratedDnD/ImageDecoratedDnD.java line 56:
> 
>> 54:                 In WIN32 systems the image under cursor would be visible ONLY over
>> 55:                 the drop targets with activated extended OLE D'n'D support (that are,
>> 56:                 the desktop and IE).
> 
> @prrace Do we retain the testing instructions related to Win32 as they are quite old?

Win32 is not that old? Java still uses these APIs in 64-bit world.

I haven't run the test myself (yet). I suggest replacing _Win32_ with _Windows_. Is image under cursor visible when you drag'n'drop on Windows? It should be.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18315#discussion_r1530789789

From aivanov at openjdk.org  Tue Mar 19 17:43:35 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 19 Mar 2024 17:43:35 GMT
Subject: RFR: JDK-8328190 : Convert AWTPanelSmoothWheel.html applet test to
 main [v4]
In-Reply-To: <RPwPEOEJRJlr-Ll8yhvyfdyN_WV3FXErSPRlfjnNCAc=.eb6c0714-2631-4f95-a93e-9f43125ee726@github.com>
References: <sn9qb9ctS_sr3isHbwcbMCYh2RQokz2ptsw0rGBRnJY=.955d7549-72c7-4a4f-8ac8-a5d6f122cf68@github.com>
 <RPwPEOEJRJlr-Ll8yhvyfdyN_WV3FXErSPRlfjnNCAc=.eb6c0714-2631-4f95-a93e-9f43125ee726@github.com>
Message-ID: <dOLSKmHDnq04jqKio9_nkZYJ98AwREPnW35-MLZ7SVU=.796cf372-0d31-4955-9ad3-1206f5db3591@github.com>

On Thu, 14 Mar 2024 19:54:19 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   minor changes
>
> test/jdk/java/awt/event/MouseEvent/AWTPanelSmoothWheel.java line 47:
> 
>> 45:             This test is relevant for windows platforms and mouses with high-resolution wheel,
>> 46:             please just press pass if this is not the case.
>> 47:             
> 
> @prrace I wanted to check the relevance of the testing requirement. The original test was created for Windows Vista and for a high-res mouse. I think the test can be retained to check on newer versions of windows. Any suggestions?

A trackpad is usually a high-res mouse wheel, it allows smooth scrolling (as opposed to moving 3 lines on a wheel notch).

There are mice which also support smooth scrolling, I've got one.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18312#discussion_r1530822784

From honkar at openjdk.org  Tue Mar 19 17:43:34 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Tue, 19 Mar 2024 17:43:34 GMT
Subject: RFR: JDK-8328225: Convert ImageDecoratedDnD.html applet test to
 main
In-Reply-To: <EQ8YZvKs697eQMIey3hBQTA4pE9eWUWBEsS_izstbo8=.32976ff4-3e49-4509-86a1-6f87a6d90141@github.com>
References: <yHnt-BqOUlo1IKduuk0nv0ZsoReWANI_g4BxukwDzUQ=.24dff5fe-2737-45cc-867e-42f137172363@github.com>
 <8-xeU7RcrWLzg2ODCm5TFeqO8d_XR4uDsiy-VdLMB0c=.391ef94a-1c24-4799-9ae4-a7fb752364ab@github.com>
 <EQ8YZvKs697eQMIey3hBQTA4pE9eWUWBEsS_izstbo8=.32976ff4-3e49-4509-86a1-6f87a6d90141@github.com>
Message-ID: <GmZc8YooGvvywBE8GiH5zv21kL-qEo4Qh16IWemZOE0=.126de142-26a3-424b-a205-8fbdf8389e1f@github.com>

On Tue, 19 Mar 2024 17:18:44 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> test/jdk/java/awt/dnd/ImageDecoratedDnD/ImageDecoratedDnD.java line 56:
>> 
>>> 54:                 In WIN32 systems the image under cursor would be visible ONLY over
>>> 55:                 the drop targets with activated extended OLE D'n'D support (that are,
>>> 56:                 the desktop and IE).
>> 
>> @prrace Do we retain the testing instructions related to Win32 as they are quite old?
>
> Win32 is not that old? Java still uses these APIs in 64-bit world.
> 
> I haven't run the test myself (yet). I suggest replacing _Win32_ with _Windows_. Is image under cursor visible when you drag'n'drop on Windows? It should be.

Case 1: A circle + anchor is seen (without a green window) when just Mouse is used to perform DnD.
Case 2:  A green window below the anchor + circle is seen when CTRL + Mouse is used to perform DnD. (I believe the green window, is the image they are referring to ?)

https://github.com/openjdk/jdk/assets/95945681/4ed2aa47-611c-4957-b930-b86732a95f76

https://github.com/openjdk/jdk/assets/95945681/d8990f71-e90f-4ee2-a7b2-ba5458fbd879

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18315#discussion_r1530818930

From aivanov at openjdk.org  Tue Mar 19 17:47:22 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 19 Mar 2024 17:47:22 GMT
Subject: RFR: JDK-8328190 : Convert AWTPanelSmoothWheel.html applet test to
 main [v3]
In-Reply-To: <UrHLiNXYaCiVMWR3zATXVmLaHWvOZ-mOkbZnzDlxS1s=.8439b52e-6ab8-4d5c-949b-a0842f7287d3@github.com>
References: <sn9qb9ctS_sr3isHbwcbMCYh2RQokz2ptsw0rGBRnJY=.955d7549-72c7-4a4f-8ac8-a5d6f122cf68@github.com>
 <MPJgRPFs3q9yLE9tiHUrRqh-dPdkg_Kqwf9u1CfuS-8=.7e4e33f7-d775-446a-aeef-8a126f4dba4a@github.com>
 <Copfo7e_14Z5HM23jnUixI6EfnLQUYD72zCtzIX0do8=.e820764d-e181-4251-8c32-b082e5b3c60b@github.com>
 <5MG7j4Aphi1BnlAYJYXtR5nLkwQDM66c8dqMXpmnoW4=.51875b0f-7adb-4eb6-8951-5338bd0727ff@github.com>
 <-76l48ZU_OawRCTXD7RyqR47QuC6WFZHpABRMf8PFyY=.6db9668d-df49-4412-b44b-d10d2ad845e3@github.com>
 <UrHLiNXYaCiVMWR3zATXVmLaHWvOZ-mOkbZnzDlxS1s=.8439b52e-6ab8-4d5c-949b-a0842f7287d3@github.com>
Message-ID: <7GZrSZRucD96aACoo2WNDFaTR1Uab6SU26Hkz9tY_k8=.1eab0cc5-8512-4232-ab71-2eb7e16b6a3b@github.com>

On Tue, 19 Mar 2024 12:13:43 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> I agree with @azvegint, since it has @requires check in jtreg and the test will mainly be run using jtreg framework , the OS check is not strictly required.
>
> Fair enough.

I agree. Adding an explicit OS check adds one more dependency on a test library.

It's not that hard to run a test with `PassFailJFrame` without jtreg, however, it's not as simple as `java <path>/<testname>.java`. Any way, if you run on a non-Windows, you may get unexpected result.

Is the test not applicable to other platforms? macOS also supports high-res mice, trackpad on a MacBook is high-res too.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18312#discussion_r1530828760

From honkar at openjdk.org  Tue Mar 19 17:58:26 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Tue, 19 Mar 2024 17:58:26 GMT
Subject: Integrated: JDK-8328012 : Convert InputMethod (/java/awt/im) applet
 tests to main
In-Reply-To: <iDY1JdxeSzLcbW-ASx1PylUqKY-kGUjMj8tr4Sj5NDM=.a0b9fbdb-a959-4e98-ae08-d086fd8f210f@github.com>
References: <iDY1JdxeSzLcbW-ASx1PylUqKY-kGUjMj8tr4Sj5NDM=.a0b9fbdb-a959-4e98-ae08-d086fd8f210f@github.com>
Message-ID: <6-DSgpxZkArYgWcaGKGL_M8ZJb7RRcapWRvoAkIx79Q=.2daf6217-7edd-45ec-9a04-605358d28735@github.com>

On Tue, 12 Mar 2024 19:33:04 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

> Following InputMethod applet tests are converted to main using PassFailJFrame
> 
> 1. java/awt/im/8132503/bug8132503.java (Renamed to PinyinIMFullstopTest.java)
> 2. java/awt/im/8148984/bug8148984.java (Renamed to PinyinIMCommaTest.java) 
> 
> - test instructions are updated to make to more clear
> - tests renamed 
> - moved one directory above - /java/awt/im/
> - html file deleted.
> 
> Two tests are updated as part of this PR as they are similar, details here https://github.com/openjdk/jdk/pull/18251#issuecomment-1992577598

This pull request has now been integrated.

Changeset: 4f8f4865
Author:    Harshitha Onkar <honkar at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/4f8f48654e500e875d14e6b4707ab654acc59176
Stats:     327 lines in 6 files changed: 157 ins; 170 del; 0 mod

8328012: Convert InputMethod (/java/awt/im) applet tests to main

Reviewed-by: azvegint, tr

-------------

PR: https://git.openjdk.org/jdk/pull/18251

From aivanov at openjdk.org  Tue Mar 19 18:05:22 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 19 Mar 2024 18:05:22 GMT
Subject: RFR: JDK-8328190 : Convert AWTPanelSmoothWheel.html applet test to
 main [v4]
In-Reply-To: <p8toDCsUN5dAL4dDyYVndsUESgStV4k9kaORTsC30T0=.1bb5f251-baa8-4eb9-9edf-7a01bb004824@github.com>
References: <sn9qb9ctS_sr3isHbwcbMCYh2RQokz2ptsw0rGBRnJY=.955d7549-72c7-4a4f-8ac8-a5d6f122cf68@github.com>
 <p8toDCsUN5dAL4dDyYVndsUESgStV4k9kaORTsC30T0=.1bb5f251-baa8-4eb9-9edf-7a01bb004824@github.com>
Message-ID: <nLixT1Ds_Q4bojPE3dVPNJsP7npWOCXTeQnXjuNBjDI=.3e97d089-79b2-411b-9481-bf3c5a05bdca@github.com>

On Mon, 18 Mar 2024 17:27:43 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> This test is converted to main using PassFailJFrame. It verifies wheel rotation value for high-res mouse on windows.
>> 
>> The test requires the updated PassFailJFrame's logArea() feature added in this PR https://github.com/openjdk/jdk/pull/18319
>
> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   minor changes

Changes requested by aivanov (Reviewer).

test/jdk/java/awt/event/MouseEvent/AWTPanelSmoothWheel.java line 32:

> 30:  * @test
> 31:  * @bug 6730447
> 32:  * @summary [Win] To verify the support for high resolution mouse wheel on Windows.

This could be applicable to other platforms too, even though [JDK-6730447](https://bugs.openjdk.org/browse/JDK-6730447) and [JDK-6524352](https://bugs.openjdk.org/browse/JDK-6524352) are reported against Windows only. It could be than support for high-resolution mouse wheel was implemented on macOS earlier than on Windows.

test/jdk/java/awt/event/MouseEvent/AWTPanelSmoothWheel.java line 42:

> 40: public class AWTPanelSmoothWheel {
> 41:     public static final String INSTRUCTIONS = """
> 42:             This test is relevant for windows platforms and mouses with high-resolution wheel,

Suggestion:

            This test is relevant for windows platforms and mice with high-resolution wheel,

test/jdk/java/awt/event/MouseEvent/AWTPanelSmoothWheel.java line 49:

> 47:             below the instruction window.
> 48:             Please make sure that some of the messages have non-zero 'wheelRotation' value,
> 49:             and also check if the test works OK if the mouse wheel is rotated very slow.

Shall we increase the width of the instruction window so that less horizontal scrolling is needed?

The test can actually verify the condition without help from the user. The handler for `MouseWheelListener` could well look into the `MouseWheelEvent` and verify _automatically_ if `scrollType=WHEEL_UNIT_SCROLL` and there are any events with `wheelRotation=1` (or rather `wheelRotation!=0`).

You can even `forcePass` the test as soon as you detected few events which satisfy the condition.

If you don't see events with `scrollType=WHEEL_UNIT_SCROLL`, then the mouse doesn't support high-resolution scrolling.

test/jdk/java/awt/event/MouseEvent/AWTPanelSmoothWheel.java line 54:

> 52:             """;
> 53: 
> 54:     public static void main (String[] args) throws Exception {

Suggestion:

    public static void main(String[] args) throws Exception {

-------------

PR Review: https://git.openjdk.org/jdk/pull/18312#pullrequestreview-1946973667
PR Review Comment: https://git.openjdk.org/jdk/pull/18312#discussion_r1530851645
PR Review Comment: https://git.openjdk.org/jdk/pull/18312#discussion_r1530833558
PR Review Comment: https://git.openjdk.org/jdk/pull/18312#discussion_r1530845488
PR Review Comment: https://git.openjdk.org/jdk/pull/18312#discussion_r1530845747

From aivanov at openjdk.org  Tue Mar 19 18:14:20 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 19 Mar 2024 18:14:20 GMT
Subject: RFR: JDK-8328225: Convert ImageDecoratedDnD.html applet test to
 main
In-Reply-To: <GmZc8YooGvvywBE8GiH5zv21kL-qEo4Qh16IWemZOE0=.126de142-26a3-424b-a205-8fbdf8389e1f@github.com>
References: <yHnt-BqOUlo1IKduuk0nv0ZsoReWANI_g4BxukwDzUQ=.24dff5fe-2737-45cc-867e-42f137172363@github.com>
 <8-xeU7RcrWLzg2ODCm5TFeqO8d_XR4uDsiy-VdLMB0c=.391ef94a-1c24-4799-9ae4-a7fb752364ab@github.com>
 <EQ8YZvKs697eQMIey3hBQTA4pE9eWUWBEsS_izstbo8=.32976ff4-3e49-4509-86a1-6f87a6d90141@github.com>
 <GmZc8YooGvvywBE8GiH5zv21kL-qEo4Qh16IWemZOE0=.126de142-26a3-424b-a205-8fbdf8389e1f@github.com>
Message-ID: <QrSLM5SvXLrCZo2geRVtfCGoGm6p9dXhow0cjRzXDhQ=.dc6e27f3-b02e-4f34-84f8-bbc879606d83@github.com>

On Tue, 19 Mar 2024 17:37:26 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Win32 is not that old? Java still uses these APIs in 64-bit world.
>> 
>> I haven't run the test myself (yet). I suggest replacing _Win32_ with _Windows_. Is image under cursor visible when you drag'n'drop on Windows? It should be.
>
> Case 1: A circle + anchor is seen (without a green window) when just Mouse is used to perform DnD.
> Case 2:  A green window below the anchor + circle is seen when CTRL + Mouse is used to perform DnD. (I believe the green window, is the image they are referring to ?)
> 
> https://github.com/openjdk/jdk/assets/95945681/4ed2aa47-611c-4957-b930-b86732a95f76
> 
> https://github.com/openjdk/jdk/assets/95945681/d8990f71-e90f-4ee2-a7b2-ba5458fbd879

You can see the image under the cursor. The image appears when you hover over AWT windows, Firefox window but the image disappears when you hover over Cygwin terminal window.

The image is the translucent blue rectangle with red circle.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18315#discussion_r1530864921

From honkar at openjdk.org  Tue Mar 19 18:22:22 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Tue, 19 Mar 2024 18:22:22 GMT
Subject: RFR: JDK-8328190 : Convert AWTPanelSmoothWheel.html applet test to
 main [v4]
In-Reply-To: <nLixT1Ds_Q4bojPE3dVPNJsP7npWOCXTeQnXjuNBjDI=.3e97d089-79b2-411b-9481-bf3c5a05bdca@github.com>
References: <sn9qb9ctS_sr3isHbwcbMCYh2RQokz2ptsw0rGBRnJY=.955d7549-72c7-4a4f-8ac8-a5d6f122cf68@github.com>
 <p8toDCsUN5dAL4dDyYVndsUESgStV4k9kaORTsC30T0=.1bb5f251-baa8-4eb9-9edf-7a01bb004824@github.com>
 <nLixT1Ds_Q4bojPE3dVPNJsP7npWOCXTeQnXjuNBjDI=.3e97d089-79b2-411b-9481-bf3c5a05bdca@github.com>
Message-ID: <MSS-JJoKM-pSrcR-HoC__SlXMph5Jf7Uy5wpJrPRUEo=.bf73238c-4929-4702-87c1-78e2edb9adb8@github.com>

On Tue, 19 Mar 2024 17:56:25 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   minor changes
>
> test/jdk/java/awt/event/MouseEvent/AWTPanelSmoothWheel.java line 49:
> 
>> 47:             below the instruction window.
>> 48:             Please make sure that some of the messages have non-zero 'wheelRotation' value,
>> 49:             and also check if the test works OK if the mouse wheel is rotated very slow.
> 
> Shall we increase the width of the instruction window so that less horizontal scrolling is needed?
> 
> The test can actually verify the condition without help from the user. The handler for `MouseWheelListener` could well look into the `MouseWheelEvent` and verify _automatically_ if `scrollType=WHEEL_UNIT_SCROLL` and there are any events with `wheelRotation=1` (or rather `wheelRotation!=0`).
> 
> You can even `forcePass` the test as soon as you detected few events which satisfy the condition.
> 
> If you don't see events with `scrollType=WHEEL_UNIT_SCROLL`, then the mouse doesn't support high-resolution scrolling.

Sounds good, test can be made semi-automatic.
How long or many MouseWheelEvents do we check ? Probably 10-15 would be a good number?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18312#discussion_r1530874171

From prr at openjdk.org  Tue Mar 19 18:24:39 2024
From: prr at openjdk.org (Phil Race)
Date: Tue, 19 Mar 2024 18:24:39 GMT
Subject: RFR: 8328540: test javax/swing/JSplitPane/4885629/bug4885629.java
 fails on windows hidpi
Message-ID: <WHDf1998FlZ19dNxxz-E7M5ZOwJA89v-zgN9zKZ4_V0=.184a9091-6ed1-4a98-8c6f-dba65ce60462@github.com>

A simple fix to the test to skip sampling the leftmost and rightmost ends of the divider
to avoid possible issues at fractional scales.

-------------

Commit messages:
 - 8328540

Changes: https://git.openjdk.org/jdk/pull/18384/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18384&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8328540
  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/18384.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18384/head:pull/18384

PR: https://git.openjdk.org/jdk/pull/18384

From dnguyen at openjdk.org  Tue Mar 19 18:26:34 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Tue, 19 Mar 2024 18:26:34 GMT
Subject: RFR: 8328370: Convert java/awt/print/Dialog/PrintApplet.java
 applet test to main [v2]
In-Reply-To: <Je7yOnjOAjH3DsIgUx72_7ASxsrXS5oIskdKM716AiA=.f1a73b22-8644-40cc-91d6-9ce301f03cc2@github.com>
References: <Je7yOnjOAjH3DsIgUx72_7ASxsrXS5oIskdKM716AiA=.f1a73b22-8644-40cc-91d6-9ce301f03cc2@github.com>
Message-ID: <CJ-3x2r8aFjsN37ZrjKEck2oDssbqdOEJwdLhrcGDlc=.a97dc348-e4e8-45a4-ad67-a0f2e1d2c577@github.com>

> Convert java/awt/print/Dialog/PrintApplet.java applet test to main using PassFailJFrame. Also rename the test to PrintModalDialog.java since this is no longer an applet. Added test instructions related to the linked JBS issue.

Damon Nguyen has updated the pull request incrementally with two additional commits since the last revision:

 - Remove unused frame
 - splitUI addition. Add forceFail

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18362/files
  - new: https://git.openjdk.org/jdk/pull/18362/files/b385b956..bb9d6848

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18362&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18362&range=00-01

  Stats: 15 lines in 1 file changed: 2 ins; 10 del; 3 mod
  Patch: https://git.openjdk.org/jdk/pull/18362.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18362/head:pull/18362

PR: https://git.openjdk.org/jdk/pull/18362

From kizune at openjdk.org  Tue Mar 19 18:34:38 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Tue, 19 Mar 2024 18:34:38 GMT
Subject: RFR: 8328386: Convert java/awt/FileDialog/FileNameOverrideTest
 test to main [v2]
In-Reply-To: <Yhj0URlGvlalLqkqDnfMrkWbz24Pjab1KZxDHmN4HwA=.7b8b7630-74d0-4114-a650-d6d2afd98075@github.com>
References: <Yhj0URlGvlalLqkqDnfMrkWbz24Pjab1KZxDHmN4HwA=.7b8b7630-74d0-4114-a650-d6d2afd98075@github.com>
Message-ID: <LD3Zz9jw5xOWQoaTZW9KiXQrIEujMtEOGiHAFgdbQCw=.54f3e94e-05b6-4b3d-a962-63d1ea3421c0@github.com>

> Convert applet based test to a main based test;
> Move test to an apporpriate location;
> Remove old files;

Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:

  Update test/jdk/java/awt/FileDialog/FileNameOverrideTest.java
  
  Add forgotten text formatting.
  
  Co-authored-by: Aleksandr Zvegintsev <77687766+azvegint at users.noreply.github.com>

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18365/files
  - new: https://git.openjdk.org/jdk/pull/18365/files/6f83277f..23a98b35

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18365&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18365&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/18365.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18365/head:pull/18365

PR: https://git.openjdk.org/jdk/pull/18365

From dnguyen at openjdk.org  Tue Mar 19 19:00:21 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Tue, 19 Mar 2024 19:00:21 GMT
Subject: RFR: 8328370: Convert java/awt/print/Dialog/PrintApplet.java
 applet test to main [v2]
In-Reply-To: <mhIHSNuwmFQW89sTOjE-ouMivnE3lwTG90Zggd37Tvc=.9881d175-4e80-4720-bb66-aae30d8c4e54@github.com>
References: <Je7yOnjOAjH3DsIgUx72_7ASxsrXS5oIskdKM716AiA=.f1a73b22-8644-40cc-91d6-9ce301f03cc2@github.com>
 <mhIHSNuwmFQW89sTOjE-ouMivnE3lwTG90Zggd37Tvc=.9881d175-4e80-4720-bb66-aae30d8c4e54@github.com>
Message-ID: <wsU0xETg6EO4XH6I0hA3knE3DEN2KtxlWPUNQEAu-YM=.f53f0a5c-4004-4f35-848c-3dededd208c0@github.com>

On Tue, 19 Mar 2024 00:31:27 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Damon Nguyen has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Remove unused frame
>>  - splitUI addition. Add forceFail
>
> test/jdk/java/awt/print/Dialog/PrintModalDialog.java line 70:
> 
>> 68:                 .rows(10)
>> 69:                 .columns(40)
>> 70:                 .testUI(PrintModalDialog::createAndShowGUI)
> 
> Since the testUI is a simple "Print" button PassFailJFrame's spiltUIBottom() can be used with just a JButton to simplify the UI.

Added, thanks

> test/jdk/java/awt/print/Dialog/PrintModalDialog.java line 127:
> 
>> 125:                 }
>> 126:                 catch (java.awt.print.PrinterException ex) {
>> 127:                     ex.printStackTrace();
> 
> It is better to use PassFailJFrame.forceFail() when a printer exception occurs else the timer keeps running and the error is swallowed even after a printer exception has occurred.
> 
> Suggestion:
> 
>                 catch (java.awt.print.PrinterException ex) {
>                     ex.printStackTrace();
>                     String msg = "PrinterException: " + ex.getMessage();
>                     PassFailJFrame.forceFail(msg);

Thanks for the suggestion. Added as suggested

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18362#discussion_r1530930647
PR Review Comment: https://git.openjdk.org/jdk/pull/18362#discussion_r1530931261

From dnguyen at openjdk.org  Tue Mar 19 19:04:21 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Tue, 19 Mar 2024 19:04:21 GMT
Subject: RFR: 8328367: Convert java/awt/Component/UpdatingBootTime test to
 main [v3]
In-Reply-To: <UMYqk4ABYWo7VysmwZuoCbLVYssS9ArWO-uHYef3wUo=.a230b8e0-8a59-463a-a15f-2faa67064b53@github.com>
References: <9gtCIzXrOP-RQJyjhkP8ibENRjEXP9rMUkEbZry4uWc=.2d949d4b-c1ed-45b0-84b9-82859af8a4b0@github.com>
 <UMYqk4ABYWo7VysmwZuoCbLVYssS9ArWO-uHYef3wUo=.a230b8e0-8a59-463a-a15f-2faa67064b53@github.com>
Message-ID: <9EfNi81e74pokdgIEG_hGMNtHMAX8g-1zRvANPU2szM=.3305cd18-73cd-4277-add8-3a72285ace45@github.com>

On Tue, 19 Mar 2024 14:17:54 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

>> Convert test to manual main
>> Move test to the Component folder
>
> Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fixing instructions.

LGTM

-------------

Marked as reviewed by dnguyen (Committer).

PR Review: https://git.openjdk.org/jdk/pull/18355#pullrequestreview-1947131270

From honkar at openjdk.org  Tue Mar 19 20:43:34 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Tue, 19 Mar 2024 20:43:34 GMT
Subject: RFR: JDK-8328190 : Convert AWTPanelSmoothWheel.html applet test to
 main [v5]
In-Reply-To: <sn9qb9ctS_sr3isHbwcbMCYh2RQokz2ptsw0rGBRnJY=.955d7549-72c7-4a4f-8ac8-a5d6f122cf68@github.com>
References: <sn9qb9ctS_sr3isHbwcbMCYh2RQokz2ptsw0rGBRnJY=.955d7549-72c7-4a4f-8ac8-a5d6f122cf68@github.com>
Message-ID: <10lXz5tTJygajdcnlCpAcTwcxd9gMC0IxUGdncgi2hU=.cec04654-4f34-42d0-975a-0d761851effd@github.com>

> This test is converted to main using PassFailJFrame. It verifies wheel rotation value for high-res mouse on windows.
> 
> The test requires the updated PassFailJFrame's logArea() feature added in this PR https://github.com/openjdk/jdk/pull/18319

Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:

  semi-automated test, removed @requires windows tag

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18312/files
  - new: https://git.openjdk.org/jdk/pull/18312/files/0299e8e2..d81df883

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18312&range=04
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18312&range=03-04

  Stats: 41 lines in 1 file changed: 25 ins; 3 del; 13 mod
  Patch: https://git.openjdk.org/jdk/pull/18312.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18312/head:pull/18312

PR: https://git.openjdk.org/jdk/pull/18312

From honkar at openjdk.org  Tue Mar 19 20:43:34 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Tue, 19 Mar 2024 20:43:34 GMT
Subject: RFR: JDK-8328190 : Convert AWTPanelSmoothWheel.html applet test to
 main [v4]
In-Reply-To: <nLixT1Ds_Q4bojPE3dVPNJsP7npWOCXTeQnXjuNBjDI=.3e97d089-79b2-411b-9481-bf3c5a05bdca@github.com>
References: <sn9qb9ctS_sr3isHbwcbMCYh2RQokz2ptsw0rGBRnJY=.955d7549-72c7-4a4f-8ac8-a5d6f122cf68@github.com>
 <p8toDCsUN5dAL4dDyYVndsUESgStV4k9kaORTsC30T0=.1bb5f251-baa8-4eb9-9edf-7a01bb004824@github.com>
 <nLixT1Ds_Q4bojPE3dVPNJsP7npWOCXTeQnXjuNBjDI=.3e97d089-79b2-411b-9481-bf3c5a05bdca@github.com>
Message-ID: <uLSpcviVXqraUZeDbvH3walaOGIGg1iCGcz8AMDv2oA=.e805c1f3-14b5-4855-9399-ef9693c8b11d@github.com>

On Tue, 19 Mar 2024 18:01:01 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   minor changes
>
> test/jdk/java/awt/event/MouseEvent/AWTPanelSmoothWheel.java line 32:
> 
>> 30:  * @test
>> 31:  * @bug 6730447
>> 32:  * @summary [Win] To verify the support for high resolution mouse wheel on Windows.
> 
> This could be applicable to other platforms too, even though [JDK-6730447](https://bugs.openjdk.org/browse/JDK-6730447) and [JDK-6524352](https://bugs.openjdk.org/browse/JDK-6524352) are reported against Windows only. It could be than support for high-resolution mouse wheel was implemented on macOS earlier than on Windows.

I have remove @requires tag and the test is extended to all platforms.

> test/jdk/java/awt/event/MouseEvent/AWTPanelSmoothWheel.java line 49:
> 
>> 47:             below the instruction window.
>> 48:             Please make sure that some of the messages have non-zero 'wheelRotation' value,
>> 49:             and also check if the test works OK if the mouse wheel is rotated very slow.
> 
> Shall we increase the width of the instruction window so that less horizontal scrolling is needed?
> 
> The test can actually verify the condition without help from the user. The handler for `MouseWheelListener` could well look into the `MouseWheelEvent` and verify _automatically_ if `scrollType=WHEEL_UNIT_SCROLL` and there are any events with `wheelRotation=1` (or rather `wheelRotation!=0`).
> 
> You can even `forcePass` the test as soon as you detected few events which satisfy the condition.
> 
> If you don't see events with `scrollType=WHEEL_UNIT_SCROLL`, then the mouse doesn't support high-resolution scrolling.

@aivanov-jdk Semi-automated the test, it now passes when 5 or more  MouseWheelEvent of type: scrollType=WHEEL_UNIT_SCROLL & wheelRotation != 0 is recorded. Updated the instructions accordingly.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18312#discussion_r1531080738
PR Review Comment: https://git.openjdk.org/jdk/pull/18312#discussion_r1531078089

From kizune at openjdk.org  Tue Mar 19 20:49:36 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Tue, 19 Mar 2024 20:49:36 GMT
Subject: RFR: 8328386: Convert java/awt/FileDialog/FileNameOverrideTest
 test to main [v3]
In-Reply-To: <Yhj0URlGvlalLqkqDnfMrkWbz24Pjab1KZxDHmN4HwA=.7b8b7630-74d0-4114-a650-d6d2afd98075@github.com>
References: <Yhj0URlGvlalLqkqDnfMrkWbz24Pjab1KZxDHmN4HwA=.7b8b7630-74d0-4114-a650-d6d2afd98075@github.com>
Message-ID: <d5M8RIH3bn8FrNyruQY6XAXGJubfUYI3GpK96e6SanA=.e798ea2e-a9c1-4c7d-924b-39d48a128383@github.com>

> Convert applet based test to a main based test;
> Move test to an apporpriate location;
> Remove old files;

Alexander Zuev has updated the pull request incrementally with two additional commits since the last revision:

 - Update test/jdk/java/awt/FileDialog/FileNameOverrideTest.java
   
   Co-authored-by: Aleksandr Zvegintsev <77687766+azvegint at users.noreply.github.com>
 - Make test skip if current toolkit is not supported;
   Make test pass or fail automatically;
   Correct test instructions accordingly;

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18365/files
  - new: https://git.openjdk.org/jdk/pull/18365/files/23a98b35..5a52b8ef

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18365&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18365&range=01-02

  Stats: 48 lines in 1 file changed: 17 ins; 21 del; 10 mod
  Patch: https://git.openjdk.org/jdk/pull/18365.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18365/head:pull/18365

PR: https://git.openjdk.org/jdk/pull/18365

From kizune at openjdk.org  Tue Mar 19 20:49:36 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Tue, 19 Mar 2024 20:49:36 GMT
Subject: RFR: 8328386: Convert java/awt/FileDialog/FileNameOverrideTest
 test to main [v3]
In-Reply-To: <InjHFCVLAtlv3h1gqy5UIKy_rjHkkT1b2C1137wYxyI=.0259a34c-68b4-489f-b690-dcc6706751c1@github.com>
References: <Yhj0URlGvlalLqkqDnfMrkWbz24Pjab1KZxDHmN4HwA=.7b8b7630-74d0-4114-a650-d6d2afd98075@github.com>
 <InjHFCVLAtlv3h1gqy5UIKy_rjHkkT1b2C1137wYxyI=.0259a34c-68b4-489f-b690-dcc6706751c1@github.com>
Message-ID: <1gs7sPpMYuJBjJG9FPniMUYzZxLBl1eLaIbH1eh9_6A=.5e28e654-4348-4f87-91a9-c25fb6eb33db@github.com>

On Tue, 19 Mar 2024 15:18:24 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>> Alexander Zuev has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Update test/jdk/java/awt/FileDialog/FileNameOverrideTest.java
>>    
>>    Co-authored-by: Aleksandr Zvegintsev <77687766+azvegint at users.noreply.github.com>
>>  - Make test skip if current toolkit is not supported;
>>    Make test pass or fail automatically;
>>    Correct test instructions accordingly;
>
> test/jdk/java/awt/FileDialog/FileNameOverrideTest.java line 93:
> 
>> 91:                 1) Click on 'Show File Dialog' button. A file dialog will come up.
>> 92:                 2) Double-click on '$clickDirName' and click OK.
>> 93:                 3) The text in the text field will indicate if test is passed or failed.
> 
> It looks like we can remove the text field and its output altogether, and use `PassFailJFrame#forcePass`, `PassFailJFrame#forceFail` to finish the test.

Fixed.

> test/jdk/java/awt/FileDialog/FileNameOverrideTest.java line 100:
> 
>> 98:             instructions = """
>> 99:                     The test is not applicable for $toolkit. Press Pass.
>> 100:                     """. replace("$toolkit", toolkit);
> 
> There is no point in showing the instruction window in this case, it is probably better to just throw the `jtreg.SkippedException`.

Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18365#discussion_r1531087880
PR Review Comment: https://git.openjdk.org/jdk/pull/18365#discussion_r1531089773

From honkar at openjdk.org  Tue Mar 19 21:07:44 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Tue, 19 Mar 2024 21:07:44 GMT
Subject: RFR: JDK-8328225: Convert ImageDecoratedDnD.html applet test to
 main [v2]
In-Reply-To: <yHnt-BqOUlo1IKduuk0nv0ZsoReWANI_g4BxukwDzUQ=.24dff5fe-2737-45cc-867e-42f137172363@github.com>
References: <yHnt-BqOUlo1IKduuk0nv0ZsoReWANI_g4BxukwDzUQ=.24dff5fe-2737-45cc-867e-42f137172363@github.com>
Message-ID: <uGayDQcJWPhfRQG08Yvrjts5xy96f-M3ziVfvtrWVPo=.b605ed8b-bdb7-4bf3-bb6c-e3fd0c86b144@github.com>

> Following test is converted to main using PassFailJFrame.

Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:

  instructions updated

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18315/files
  - new: https://git.openjdk.org/jdk/pull/18315/files/e1ec20e3..8ec60632

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18315&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18315&range=00-01

  Stats: 10 lines in 1 file changed: 5 ins; 0 del; 5 mod
  Patch: https://git.openjdk.org/jdk/pull/18315.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18315/head:pull/18315

PR: https://git.openjdk.org/jdk/pull/18315

From honkar at openjdk.org  Tue Mar 19 21:07:44 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Tue, 19 Mar 2024 21:07:44 GMT
Subject: RFR: JDK-8328225: Convert ImageDecoratedDnD.html applet test to
 main [v2]
In-Reply-To: <QrSLM5SvXLrCZo2geRVtfCGoGm6p9dXhow0cjRzXDhQ=.dc6e27f3-b02e-4f34-84f8-bbc879606d83@github.com>
References: <yHnt-BqOUlo1IKduuk0nv0ZsoReWANI_g4BxukwDzUQ=.24dff5fe-2737-45cc-867e-42f137172363@github.com>
 <8-xeU7RcrWLzg2ODCm5TFeqO8d_XR4uDsiy-VdLMB0c=.391ef94a-1c24-4799-9ae4-a7fb752364ab@github.com>
 <EQ8YZvKs697eQMIey3hBQTA4pE9eWUWBEsS_izstbo8=.32976ff4-3e49-4509-86a1-6f87a6d90141@github.com>
 <GmZc8YooGvvywBE8GiH5zv21kL-qEo4Qh16IWemZOE0=.126de142-26a3-424b-a205-8fbdf8389e1f@github.com>
 <QrSLM5SvXLrCZo2geRVtfCGoGm6p9dXhow0cjRzXDhQ=.dc6e27f3-b02e-4f34-84f8-bbc879606d83@github.com>
Message-ID: <ZUpDtqhMDWYrpGK9Sv-t4s6-MAiawuPGpNkaz3p3imA=.431c32b7-5135-4877-af5a-1c4a008cb8b2@github.com>

On Tue, 19 Mar 2024 18:11:57 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Case 1: A circle + anchor is seen (without a green window) when just Mouse is used to perform DnD.
>> Case 2:  A green window below the anchor + circle is seen when CTRL + Mouse is used to perform DnD. (I believe the green window, is the image they are referring to ?)
>> 
>> https://github.com/openjdk/jdk/assets/95945681/4ed2aa47-611c-4957-b930-b86732a95f76
>> 
>> https://github.com/openjdk/jdk/assets/95945681/d8990f71-e90f-4ee2-a7b2-ba5458fbd879
>
> You can see the image under the cursor. The image appears when you hover over AWT windows, Firefox window but the image disappears when you hover over Cygwin terminal window.
> 
> The image is the translucent blue rectangle with red circle.

@aivanov-jdk Updated the instructions to make it more clear. Can you please re-review?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18315#discussion_r1531113359

From srl at openjdk.org  Tue Mar 19 21:46:21 2024
From: srl at openjdk.org (Steven Loomis)
Date: Tue, 19 Mar 2024 21:46:21 GMT
Subject: RFR: 8195675: Call to insertText with single character from custom
 Input Method ignored
In-Reply-To: <70yOUGT0N_mI3Pq8UVS-KgUAzZbtRhFniW8U16iVtlk=.7d6edddb-d68b-4b98-aaaf-1e60224dee0b@github.com>
References: <70yOUGT0N_mI3Pq8UVS-KgUAzZbtRhFniW8U16iVtlk=.7d6edddb-d68b-4b98-aaaf-1e60224dee0b@github.com>
Message-ID: <BPgjJM_d6SPBh-aAJjiOE2d8oPhDAnhzmOB_PTfRUNI=.95828e63-65c7-4739-b6d6-30a0d1898f1b@github.com>

On Tue, 20 Feb 2024 02:08:09 GMT, Steven Loomis <srl at openjdk.org> wrote:

> 8195675: Call to insertText with single character from custom Input Method ignored

I'm able to build this again, but not satisfied that it solves the issue, so I am still investigating. 
Should I rebase this upon latest master or somewhere else (now that 22 is released)? @prrace

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17921#issuecomment-2008184716

From prr at openjdk.org  Tue Mar 19 22:55:19 2024
From: prr at openjdk.org (Phil Race)
Date: Tue, 19 Mar 2024 22:55:19 GMT
Subject: RFR: 8327879: Convert javax/swing/border/Test4760089.java applet
 test to main [v3]
In-Reply-To: <kmmRhyUGap3vchu_3SbWDiEO15b4CVJGpkrAW5RrMqw=.3771ee8b-747d-47aa-86f2-605f5497cd2b@github.com>
References: <Vq0kXwaE6TFmJzGmgpo13OA3VEqSnqsjQpDpGZj2ob4=.4f188f8b-5581-4774-8345-76363b4e3cf6@github.com>
 <kmmRhyUGap3vchu_3SbWDiEO15b4CVJGpkrAW5RrMqw=.3771ee8b-747d-47aa-86f2-605f5497cd2b@github.com>
Message-ID: <Xo3P8uwNd0GtqmAYlKO6TsmH9vnQr2mertLRm0fLzCw=.66387ce1-120b-4a65-a155-bf7bd106776c@github.com>

On Thu, 14 Mar 2024 05:21:03 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Convert javax/swing/border/Test4760089.java applet test to main based test using PassFailJFrame.
>
> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review updates

Marked as reviewed by prr (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18217#pullrequestreview-1947551665

From prr at openjdk.org  Tue Mar 19 22:56:19 2024
From: prr at openjdk.org (Phil Race)
Date: Tue, 19 Mar 2024 22:56:19 GMT
Subject: RFR: 8328005: Convert java/awt/im/JTextFieldTest.java applet test
 to main [v4]
In-Reply-To: <M1vo4AmKe8F14Ot3-1JJBQuEg05q6MyAvrKUrKaItXs=.343f5a2a-f341-4fbd-8264-1059b2b19009@github.com>
References: <L1GhxeYrU35BXYEe9h_FL05fGrPgE7q4vWv3qTOe854=.c20a5812-ec96-4541-94b8-106dd17d9f95@github.com>
 <M1vo4AmKe8F14Ot3-1JJBQuEg05q6MyAvrKUrKaItXs=.343f5a2a-f341-4fbd-8264-1059b2b19009@github.com>
Message-ID: <qneDIDQa3YJZ9fmFCb3G6W8LMZPqaCOQ6LqzBkFqRjc=.f3f8bdf5-0b18-44a0-9d31-8e4e6e3dab45@github.com>

On Mon, 18 Mar 2024 17:40:03 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

>> Convert java/awt/im/JTextFieldTest.java applet test to main using PassFailJFrame.
>
> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove reundant window constant

Marked as reviewed by prr (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18247#pullrequestreview-1947552650

From prr at openjdk.org  Tue Mar 19 23:07:29 2024
From: prr at openjdk.org (Phil Race)
Date: Tue, 19 Mar 2024 23:07:29 GMT
Subject: RFR: 8328370: Convert java/awt/print/Dialog/PrintApplet.java
 applet test to main [v2]
In-Reply-To: <CJ-3x2r8aFjsN37ZrjKEck2oDssbqdOEJwdLhrcGDlc=.a97dc348-e4e8-45a4-ad67-a0f2e1d2c577@github.com>
References: <Je7yOnjOAjH3DsIgUx72_7ASxsrXS5oIskdKM716AiA=.f1a73b22-8644-40cc-91d6-9ce301f03cc2@github.com>
 <CJ-3x2r8aFjsN37ZrjKEck2oDssbqdOEJwdLhrcGDlc=.a97dc348-e4e8-45a4-ad67-a0f2e1d2c577@github.com>
Message-ID: <SbUHgxolpcRf-BtmDfHskdQydu1-PW52RdP5GTPexsA=.9903071d-edfb-49c6-b153-42189736e55c@github.com>

On Tue, 19 Mar 2024 18:26:34 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

>> Convert java/awt/print/Dialog/PrintApplet.java applet test to main using PassFailJFrame. Also rename the test to PrintModalDialog.java since this is no longer an applet. Added test instructions related to the linked JBS issue.
>
> Damon Nguyen has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Remove unused frame
>  - splitUI addition. Add forceFail

test/jdk/java/awt/print/Dialog/PrintModalDialog.java line 57:

> 55:              Finish printing or close the dialog. If both dialogs are modal,
> 56:              PASS the test. Otherwise, FAIL.
> 57:             """;

I think we need more instructions - explaining Modal and what to expect.
"Modal in this case means that it blocks the user from interacting with other windows in the same application
You may still be able to interact with unrelated applications on the desktop.
One sure way to test this is to first show the print dialog and then press "Fail", because if you can click on "Fail"
and have it respond, then the print dialog was not modal. If clicking on it does nothing then cancel the print dialog
and do the same for the other print dialog.
If all is well, then press Pass."

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18362#discussion_r1531231867

From azvegint at openjdk.org  Tue Mar 19 23:20:22 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Tue, 19 Mar 2024 23:20:22 GMT
Subject: RFR: 8328386: Convert java/awt/FileDialog/FileNameOverrideTest
 test to main [v3]
In-Reply-To: <d5M8RIH3bn8FrNyruQY6XAXGJubfUYI3GpK96e6SanA=.e798ea2e-a9c1-4c7d-924b-39d48a128383@github.com>
References: <Yhj0URlGvlalLqkqDnfMrkWbz24Pjab1KZxDHmN4HwA=.7b8b7630-74d0-4114-a650-d6d2afd98075@github.com>
 <d5M8RIH3bn8FrNyruQY6XAXGJubfUYI3GpK96e6SanA=.e798ea2e-a9c1-4c7d-924b-39d48a128383@github.com>
Message-ID: <f4C1v8ca8ZF8So5BXncUCVyKcBzkYB36R0jcYgPRnK8=.6aaaca89-fbe7-40e5-968c-ab63f8b5403a@github.com>

On Tue, 19 Mar 2024 20:49:36 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

>> Convert applet based test to a main based test;
>> Move test to an apporpriate location;
>> Remove old files;
>
> Alexander Zuev has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Update test/jdk/java/awt/FileDialog/FileNameOverrideTest.java
>    
>    Co-authored-by: Aleksandr Zvegintsev <77687766+azvegint at users.noreply.github.com>
>  - Make test skip if current toolkit is not supported;
>    Make test pass or fail automatically;
>    Correct test instructions accordingly;

Marked as reviewed by azvegint (Reviewer).

test/jdk/java/awt/FileDialog/FileNameOverrideTest.java line 49:

> 47:     private final static String clickDirName = "Directory for double click";
> 48:     private final static String dirPath = System.getProperty("user.dir");;
> 49:     private static JButton showBtn;

Can be local variable

test/jdk/java/awt/FileDialog/FileNameOverrideTest.java line 56:

> 54:         showBtn.addActionListener(w -> {
> 55:             Frame frame = new Frame();
> 56:             fd = new FileDialog(frame, "Open");

Suggestion:

            fd = new FileDialog((Frame) null, "Open");

There is no point in this frame.

test/jdk/java/awt/FileDialog/FileNameOverrideTest.java line 64:

> 62:             frame.dispose();
> 63:             if (fileName.equals(output)) {
> 64:                 PassFailJFrame.forcePass();;

Suggestion:

                PassFailJFrame.forcePass();

-------------

PR Review: https://git.openjdk.org/jdk/pull/18365#pullrequestreview-1947576728
PR Review Comment: https://git.openjdk.org/jdk/pull/18365#discussion_r1531238886
PR Review Comment: https://git.openjdk.org/jdk/pull/18365#discussion_r1531238333
PR Review Comment: https://git.openjdk.org/jdk/pull/18365#discussion_r1531238119

From honkar at openjdk.org  Tue Mar 19 23:29:20 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Tue, 19 Mar 2024 23:29:20 GMT
Subject: RFR: 8328185: Convert
 java/awt/image/MemoryLeakTest/MemoryLeakTest.java applet test to main [v3]
In-Reply-To: <VPrElIN7VYUCvc_XgX8HmPz90hc2x-MyPW94iSbF_74=.b74cf677-4ed1-4aa0-97f2-083d8c4d0235@github.com>
References: <TFYjDmsHDFBm5tcakvQmk_o_3bkZxQmS8FLPZW5bI8Y=.c7bebd2f-13cb-4bae-bd85-64cbff6c17b8@github.com>
 <VPrElIN7VYUCvc_XgX8HmPz90hc2x-MyPW94iSbF_74=.b74cf677-4ed1-4aa0-97f2-083d8c4d0235@github.com>
Message-ID: <XUz8SQRfElh8YgE38p1H-7JFPQl1N9cVCUox4FcuuXE=.136a6338-89b8-4127-aedb-9b374177314d@github.com>

On Mon, 18 Mar 2024 18:37:37 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

>> Convert java/awt/image/MemoryLeakTest/MemoryLeakTest.java applet test to main using PassFailJFrame
>
> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review changes

test/jdk/java/awt/image/MemoryLeakTest/MemoryLeakTest.java line 29:

> 27:  * @build PassFailJFrame
> 28:  * @summary Test for a memory leak in Image.
> 29:  * @run main MemoryLeakTest

missing manual here

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18307#discussion_r1531250326

From prr at openjdk.org  Tue Mar 19 23:34:39 2024
From: prr at openjdk.org (Phil Race)
Date: Tue, 19 Mar 2024 23:34:39 GMT
Subject: RFR: 8328560:
 java/awt/event/MouseEvent/ClickDuringKeypress/ClickDuringKeypress.java imports
 Applet
Message-ID: <DAGMk9laOuahpyUEepWDE92N94zIbgNOWgaIgQFIurs=.602f3b0a-e0dd-49ee-9075-12961ef49611@github.com>

This seems to have been some previous not very complete conversion of a test from applet to main.
It even still had Applet imported and miscellaneous comments. I've cleaned it up.

-------------

Commit messages:
 - 8328560

Changes: https://git.openjdk.org/jdk/pull/18386/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18386&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8328560
  Stats: 95 lines in 1 file changed: 13 ins; 33 del; 49 mod
  Patch: https://git.openjdk.org/jdk/pull/18386.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18386/head:pull/18386

PR: https://git.openjdk.org/jdk/pull/18386

From honkar at openjdk.org  Tue Mar 19 23:43:20 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Tue, 19 Mar 2024 23:43:20 GMT
Subject: RFR: 8328185: Convert
 java/awt/image/MemoryLeakTest/MemoryLeakTest.java applet test to main [v3]
In-Reply-To: <VPrElIN7VYUCvc_XgX8HmPz90hc2x-MyPW94iSbF_74=.b74cf677-4ed1-4aa0-97f2-083d8c4d0235@github.com>
References: <TFYjDmsHDFBm5tcakvQmk_o_3bkZxQmS8FLPZW5bI8Y=.c7bebd2f-13cb-4bae-bd85-64cbff6c17b8@github.com>
 <VPrElIN7VYUCvc_XgX8HmPz90hc2x-MyPW94iSbF_74=.b74cf677-4ed1-4aa0-97f2-083d8c4d0235@github.com>
Message-ID: <4eNSBSTLXFeldurtMbp0bmnLnS19TOUcQygVnCRsVXE=.3fd7d79b-58ba-495a-8017-c16e4c4e303d@github.com>

On Mon, 18 Mar 2024 18:37:37 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

>> Convert java/awt/image/MemoryLeakTest/MemoryLeakTest.java applet test to main using PassFailJFrame
>
> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review changes

test/jdk/java/awt/image/MemoryLeakTest/MemoryLeakTest.java line 27:

> 25:  * @bug 4078566 6658398
> 26:  * @library /java/awt/regtesthelpers
> 27:  * @build PassFailJFrame

How about we add @requires os.family == "linux" additionally here?

test/jdk/java/awt/image/MemoryLeakTest/MemoryLeakTest.java line 42:

> 40:     private static final String INSTRUCTIONS =
> 41:         """
> 42:          Do the following steps on Solaris only.

Since the test can be run on Unix platforms, how about including it in the instructions. 
Suggestion:

         Do the following steps on Unix platforms.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18307#discussion_r1531261051
PR Review Comment: https://git.openjdk.org/jdk/pull/18307#discussion_r1531266744

From honkar at openjdk.org  Wed Mar 20 00:09:20 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Wed, 20 Mar 2024 00:09:20 GMT
Subject: RFR: 8328328: Convert
 javax/swing/JTabbedPane/4666224/bug4666224.java applet test to main
In-Reply-To: <4fqxbuw6GwuEAg6v7kvn72AQC3LeXPodKf8OrBDOr1w=.1cffa811-37e8-4294-b469-6487763bdeed@github.com>
References: <4fqxbuw6GwuEAg6v7kvn72AQC3LeXPodKf8OrBDOr1w=.1cffa811-37e8-4294-b469-6487763bdeed@github.com>
Message-ID: <7akirtbYmVHNS-S1Xupl-OfycSL9lxIw3r2bXmqGPvM=.8b1f64c7-3deb-4ead-8339-b53d62b9a5b0@github.com>

On Mon, 18 Mar 2024 07:45:42 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

> Conversion of manual applet test to main based using PassFailJFrame manual framework.
> 
> Tested in macOS where it didn't worked for "key press C to change tab layout" else it worked for other "key press (R, B, L, T) to change tab position. So, test is still in problem list.

LGTM, minor changes added inline.

test/jdk/javax/swing/JTabbedPane/bug4666224.java line 48:

> 46: 
> 47: public class bug4666224 {
> 48:     final static int placements[] = { JTabbedPane.LEFT, JTabbedPane.RIGHT, JTabbedPane.TOP, JTabbedPane.BOTTOM };

placements isn't used and can be removed.

test/jdk/javax/swing/JTabbedPane/bug4666224.java line 51:

> 49:     private static JTabbedPane tabPane;
> 50:     private static JFrame frame;
> 51:     private static JPanel mainPanel;

mainPanel can be made local

test/jdk/javax/swing/JTabbedPane/bug4666224.java line 58:

> 56:                     2. Lose focus on the window by clicking on some other window.
> 57:                     3. Focus indicator should disappear
> 58:                     4. Regain focus on the window by pressing the tab,

The regain focus part also doesn't work on macOS along with change layout.

-------------

Marked as reviewed by honkar (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18340#pullrequestreview-1947634902
PR Review Comment: https://git.openjdk.org/jdk/pull/18340#discussion_r1531289197
PR Review Comment: https://git.openjdk.org/jdk/pull/18340#discussion_r1531293527
PR Review Comment: https://git.openjdk.org/jdk/pull/18340#discussion_r1531292885

From azvegint at openjdk.org  Wed Mar 20 01:00:26 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Wed, 20 Mar 2024 01:00:26 GMT
Subject: RFR: 8328560:
 java/awt/event/MouseEvent/ClickDuringKeypress/ClickDuringKeypress.java imports
 Applet
In-Reply-To: <DAGMk9laOuahpyUEepWDE92N94zIbgNOWgaIgQFIurs=.602f3b0a-e0dd-49ee-9075-12961ef49611@github.com>
References: <DAGMk9laOuahpyUEepWDE92N94zIbgNOWgaIgQFIurs=.602f3b0a-e0dd-49ee-9075-12961ef49611@github.com>
Message-ID: <fcqyLn_-sCXQmRz71ts6W-v3HzFxxtPQ1z9C03eEVs0=.0b8164d3-736f-4299-b088-2d01392e05e1@github.com>

On Tue, 19 Mar 2024 23:30:39 GMT, Phil Race <prr at openjdk.org> wrote:

> This seems to have been some previous not very complete conversion of a test from applet to main.
> It even still had Applet imported and miscellaneous comments. I've cleaned it up.

test/jdk/java/awt/event/MouseEvent/ClickDuringKeypress/ClickDuringKeypress.java line 25:

> 23: 
> 24: /*
> 25:   @test 1.2 98/08/05

Now we don't have `@test` at all.

test/jdk/java/awt/event/MouseEvent/ClickDuringKeypress/ClickDuringKeypress.java line 29:

> 27:   @summary Tests that clicking mouse and pressing keys generates correct amount of click-counts
> 28:   @run main ClickDuringKeypress
> 29: */

We usually move this block just before a class declaration, for better readability.

test/jdk/java/awt/event/MouseEvent/ClickDuringKeypress/ClickDuringKeypress.java line 53:

> 51:    static volatile Frame frame;
> 52:    static volatile Robot robot;
> 53:    static volatile ClickDuringKeypress clicker;

Suggestion:

   static final ClickDuringKeypress clicker = new ClickDuringKeypress();

`clicker` can be made final

test/jdk/java/awt/event/MouseEvent/ClickDuringKeypress/ClickDuringKeypress.java line 61:

> 59:            robot = new Robot();
> 60:            robot.mouseMove(200, 200);
> 61:            EventQueue.invokeAndWait(frame::show);

Suggestion:

           EventQueue.invokeAndWait(() -> frame.setVisible(true));


`show` is deprecated.

test/jdk/java/awt/event/MouseEvent/ClickDuringKeypress/ClickDuringKeypress.java line 96:

> 94:                throw new RuntimeException("Not Activated. Test fails");
> 95:            }
> 96:       }

Do we really need this synchronization?
Shouldn't the standard 

robot.waitForIdle();
robot.delay(1000);

be enough?

test/jdk/java/awt/event/MouseEvent/ClickDuringKeypress/ClickDuringKeypress.java line 111:

> 109:       for (int i = 0; i < CLICKCOUNT / 2; i++) {
> 110:         robot.mousePress(InputEvent.BUTTON1_DOWN_MASK);
> 111:         robot.delay(10);

Here and after
Suggestion:



We have already called `robot.setAutoDelay(DOUBLE_CLICK_AUTO_DELAY);` before. We can set `DOUBLE_CLICK_AUTO_DELAY` to 20 and remove the multiple `robot.delay(10)` calls.

Probably we also want to add `setAutoWaitForIdle(true)`

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18386#discussion_r1531318899
PR Review Comment: https://git.openjdk.org/jdk/pull/18386#discussion_r1531326699
PR Review Comment: https://git.openjdk.org/jdk/pull/18386#discussion_r1531347759
PR Review Comment: https://git.openjdk.org/jdk/pull/18386#discussion_r1531333655
PR Review Comment: https://git.openjdk.org/jdk/pull/18386#discussion_r1531344366
PR Review Comment: https://git.openjdk.org/jdk/pull/18386#discussion_r1531365101

From azvegint at openjdk.org  Wed Mar 20 03:13:42 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Wed, 20 Mar 2024 03:13:42 GMT
Subject: RFR: 8328562: Convert
 java/awt/InputMethods/DiacriticsTest/DiacriticsTest.java applet test to main
Message-ID: <dwZXmqAjKVfX0Z4xfEfCJvsNmm7pOSYZTOk30-vPIF8=.0e29c1cf-580c-4898-9b94-7aaddec86add@github.com>

Test converted to main.
Instructions split to Windows and Linux, with some clarifications.
The test runs successfully on Windows and Linux.

-------------

Commit messages:
 - split instructions for Windows and Linux
 - initial

Changes: https://git.openjdk.org/jdk/pull/18388/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18388&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8328562
  Stats: 137 lines in 2 files changed: 65 ins; 57 del; 15 mod
  Patch: https://git.openjdk.org/jdk/pull/18388.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18388/head:pull/18388

PR: https://git.openjdk.org/jdk/pull/18388

From psadhukhan at openjdk.org  Wed Mar 20 03:14:21 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Wed, 20 Mar 2024 03:14:21 GMT
Subject: RFR: 8328367: Convert java/awt/Component/UpdatingBootTime test to
 main [v3]
In-Reply-To: <UMYqk4ABYWo7VysmwZuoCbLVYssS9ArWO-uHYef3wUo=.a230b8e0-8a59-463a-a15f-2faa67064b53@github.com>
References: <9gtCIzXrOP-RQJyjhkP8ibENRjEXP9rMUkEbZry4uWc=.2d949d4b-c1ed-45b0-84b9-82859af8a4b0@github.com>
 <UMYqk4ABYWo7VysmwZuoCbLVYssS9ArWO-uHYef3wUo=.a230b8e0-8a59-463a-a15f-2faa67064b53@github.com>
Message-ID: <iXGH3tc3lPnT9G_Lxw83rg80BTe2P0_LKPEj09icaao=.82981a5e-1a3d-4bce-9b18-e8d8b4df709a@github.com>

On Tue, 19 Mar 2024 14:17:54 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

>> Convert test to manual main
>> Move test to the Component folder
>
> Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fixing instructions.

Marked as reviewed by psadhukhan (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18355#pullrequestreview-1947879653

From psadhukhan at openjdk.org  Wed Mar 20 03:16:20 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Wed, 20 Mar 2024 03:16:20 GMT
Subject: RFR: 8328378: Convert java/awt/FileDialog/FileDialogForDirectories
 test to main [v2]
In-Reply-To: <yJiiqlPyMc2tO_u1G7bVa8HNDFLmimQY-svU5zpxX4I=.d0c4d5dd-50b7-4eb0-bb3d-a44362b9d565@github.com>
References: <2yId9SKzUfB9ZnRy1Ma_m6jye3Mad5UIx-mxcgcZdZ8=.b71c078f-0a57-4b4c-b1ce-a98d23df0b48@github.com>
 <yJiiqlPyMc2tO_u1G7bVa8HNDFLmimQY-svU5zpxX4I=.d0c4d5dd-50b7-4eb0-bb3d-a44362b9d565@github.com>
Message-ID: <fXajQwvqzVSmRh_MOeKsto2KdpRFUCZfXpkAYWfWeVo=.3dd2a8a8-c0aa-408e-8051-4d037d2a9290@github.com>

On Tue, 19 Mar 2024 14:03:54 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

>> Convert test to main manual and move to the appropriate folder
>> Remove old files
>
> Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Adding library and build clauses

Marked as reviewed by psadhukhan (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18358#pullrequestreview-1947880648

From psadhukhan at openjdk.org  Wed Mar 20 03:16:21 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Wed, 20 Mar 2024 03:16:21 GMT
Subject: RFR: 8328378: Convert java/awt/FileDialog/FileDialogForDirectories
 test to main [v2]
In-Reply-To: <MGoiJFdKMVuwp5thXCPaiht26DrVPrUVZiqcxKeOxPw=.0a6f57d1-da03-4618-b317-78779fb37ca4@github.com>
References: <2yId9SKzUfB9ZnRy1Ma_m6jye3Mad5UIx-mxcgcZdZ8=.b71c078f-0a57-4b4c-b1ce-a98d23df0b48@github.com>
 <MGoiJFdKMVuwp5thXCPaiht26DrVPrUVZiqcxKeOxPw=.0a6f57d1-da03-4618-b317-78779fb37ca4@github.com>
Message-ID: <SReGPvx9sn1BuaKL3eTudcZ5KHjQYROVAzmhul3Oj9s=.eb1f4dbd-1f09-432c-b8c2-da299739a548@github.com>

On Tue, 19 Mar 2024 07:49:53 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Adding library and build clauses
>
> test/jdk/java/awt/FileDialog/FileDialogForDirectories.java line 43:
> 
>> 41: public class FileDialogForDirectories {
>> 42:     private static Button showBtn;
>> 43:     private static FileDialog fd;
> 
> Can be made local in main

Still could have been made local...

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18358#discussion_r1531467780

From psadhukhan at openjdk.org  Wed Mar 20 03:18:21 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Wed, 20 Mar 2024 03:18:21 GMT
Subject: RFR: 8328377: Convert java/awt/Cursor/MultiResolutionCursorTest
 test to main [v2]
In-Reply-To: <0dSFss67MVf8pZb_0BARTl70xls7xvxJnk1kYV81SOM=.611ad917-5e66-4c8d-9fdd-938adb21c486@github.com>
References: <Y_DvKb6DvMCmv7RwRVmVh8OoSPikpEmcEbXtpVv9a20=.2809223d-537e-4de3-bb75-986db8154edc@github.com>
 <0dSFss67MVf8pZb_0BARTl70xls7xvxJnk1kYV81SOM=.611ad917-5e66-4c8d-9fdd-938adb21c486@github.com>
Message-ID: <uKI9aIE4h8Gzss2r3feG7XY48153dZAhScr75ZU-7p4=.13d34ef8-0bd6-43ea-959a-1a3fc2f61752@github.com>

On Tue, 19 Mar 2024 14:01:42 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

>> Convert test to manual main and move from the dedicated folder
>> Remove old files
>
> Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Adding library and build clauses

test/jdk/java/awt/Cursor/MultiResolutionCursorTest.java line 63:

> 61:         JFrame frame = new JFrame("Multi-resolution Cursor Test Frame");
> 62:         frame.setSize(300, 300);
> 63:         frame.setLocation(300, 50);

Is setLocation required? I guess PassFailJFrame will take care of that when you call testUI

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18357#discussion_r1531468594

From azvegint at openjdk.org  Wed Mar 20 03:21:24 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Wed, 20 Mar 2024 03:21:24 GMT
Subject: Integrated: 8328387: Convert
 java/awt/Frame/FrameStateTest/FrameStateTest.html applet test to main
In-Reply-To: <9jOoOgLC59s3h2IQkTvuc6jJ2Y19umd5SOd25zI67pI=.7e17596c-89f3-4ff2-9254-ec23f85e7eb1@github.com>
References: <9jOoOgLC59s3h2IQkTvuc6jJ2Y19umd5SOd25zI67pI=.7e17596c-89f3-4ff2-9254-ec23f85e7eb1@github.com>
Message-ID: <BWiHMTeBgvvqIXTaH_Cx7n0JRSjPjiU64kB567aJzRE=.0db6a5f2-38d5-49a4-985b-14afe6b752dc@github.com>

On Mon, 18 Mar 2024 21:12:19 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

> The test is converted to main and remains in the problem list, as the problem is still valid on Linux and macos. 
> The test passes on Windows.
> 
> * sleeps on EDT removed, replaced with the Swing timer
> * Unnecessary ltemListener and variables removed.
> * Updated instructions with html for better readability
> * small log improvements
> * log area from PassFailJFrame used

This pull request has now been integrated.

Changeset: 269163d5
Author:    Alexander Zvegintsev <azvegint at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/269163d509ec3c80983f55c5b47f472fa76be26c
Stats:     672 lines in 3 files changed: 220 ins; 399 del; 53 mod

8328387: Convert java/awt/Frame/FrameStateTest/FrameStateTest.html applet test to main

Reviewed-by: honkar

-------------

PR: https://git.openjdk.org/jdk/pull/18366

From abhiscxk at openjdk.org  Wed Mar 20 04:18:46 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Wed, 20 Mar 2024 04:18:46 GMT
Subject: RFR: 8328328: Convert
 javax/swing/JTabbedPane/4666224/bug4666224.java applet test to main [v2]
In-Reply-To: <4fqxbuw6GwuEAg6v7kvn72AQC3LeXPodKf8OrBDOr1w=.1cffa811-37e8-4294-b469-6487763bdeed@github.com>
References: <4fqxbuw6GwuEAg6v7kvn72AQC3LeXPodKf8OrBDOr1w=.1cffa811-37e8-4294-b469-6487763bdeed@github.com>
Message-ID: <nbGYCc8iRqT0py3apaNvXYjsB7Pwsjr5mufVrTMZeGk=.9041765b-b92c-46b1-b026-d13ea297dd0c@github.com>

> Conversion of manual applet test to main based using PassFailJFrame manual framework.
> 
> Tested in macOS where it didn't worked for "key press C to change tab layout" else it worked for other "key press (R, B, L, T) to change tab position. So, test is still in problem list.

Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:

  minor fix

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18340/files
  - new: https://git.openjdk.org/jdk/pull/18340/files/68ce8dd1..9c350b0e

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18340&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18340&range=00-01

  Stats: 3 lines in 1 file changed: 0 ins; 2 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/18340.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18340/head:pull/18340

PR: https://git.openjdk.org/jdk/pull/18340

From abhiscxk at openjdk.org  Wed Mar 20 04:18:46 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Wed, 20 Mar 2024 04:18:46 GMT
Subject: RFR: 8328328: Convert
 javax/swing/JTabbedPane/4666224/bug4666224.java applet test to main [v2]
In-Reply-To: <7akirtbYmVHNS-S1Xupl-OfycSL9lxIw3r2bXmqGPvM=.8b1f64c7-3deb-4ead-8339-b53d62b9a5b0@github.com>
References: <4fqxbuw6GwuEAg6v7kvn72AQC3LeXPodKf8OrBDOr1w=.1cffa811-37e8-4294-b469-6487763bdeed@github.com>
 <7akirtbYmVHNS-S1Xupl-OfycSL9lxIw3r2bXmqGPvM=.8b1f64c7-3deb-4ead-8339-b53d62b9a5b0@github.com>
Message-ID: <3F9neJMFLWR0Nv2hk2tEAibKMN0jbd6XKnWM7aR3LWs=.b3c5428f-9212-4e68-8a94-ae808c3536ce@github.com>

On Wed, 20 Mar 2024 00:00:14 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   minor fix
>
> test/jdk/javax/swing/JTabbedPane/bug4666224.java line 48:
> 
>> 46: 
>> 47: public class bug4666224 {
>> 48:     final static int placements[] = { JTabbedPane.LEFT, JTabbedPane.RIGHT, JTabbedPane.TOP, JTabbedPane.BOTTOM };
> 
> placements isn't used and can be removed.

Updated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18340#discussion_r1531492561

From abhiscxk at openjdk.org  Wed Mar 20 04:28:20 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Wed, 20 Mar 2024 04:28:20 GMT
Subject: RFR: 8328540: test javax/swing/JSplitPane/4885629/bug4885629.java
 fails on windows hidpi
In-Reply-To: <WHDf1998FlZ19dNxxz-E7M5ZOwJA89v-zgN9zKZ4_V0=.184a9091-6ed1-4a98-8c6f-dba65ce60462@github.com>
References: <WHDf1998FlZ19dNxxz-E7M5ZOwJA89v-zgN9zKZ4_V0=.184a9091-6ed1-4a98-8c6f-dba65ce60462@github.com>
Message-ID: <hDn_LUyL72nX3-yv6Zys9nsYx53s0MI6mwl32a7uFpw=.3084ea75-94f1-4d76-afff-ed51b4bd6435@github.com>

On Tue, 19 Mar 2024 18:20:06 GMT, Phil Race <prr at openjdk.org> wrote:

> A simple fix to the test to skip sampling the leftmost and rightmost ends of the divider
> to avoid possible issues at fractional scales.

1. should we mention `-Dsun.java2d.uiScale=2.0` in jtreg tag since it is supposed to be a hidpi test ?

2. Please update copyright year.

-------------

PR Review: https://git.openjdk.org/jdk/pull/18384#pullrequestreview-1947923944

From kizune at openjdk.org  Wed Mar 20 04:28:47 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Wed, 20 Mar 2024 04:28:47 GMT
Subject: RFR: 8328377: Convert java/awt/Cursor/MultiResolutionCursorTest
 test to main [v3]
In-Reply-To: <Y_DvKb6DvMCmv7RwRVmVh8OoSPikpEmcEbXtpVv9a20=.2809223d-537e-4de3-bb75-986db8154edc@github.com>
References: <Y_DvKb6DvMCmv7RwRVmVh8OoSPikpEmcEbXtpVv9a20=.2809223d-537e-4de3-bb75-986db8154edc@github.com>
Message-ID: <sAe1egAetX_5vtvecDx5SaN8be6XRCKCWWSdPMoRj1Q=.709001c7-aa59-4ec7-a6fa-32903609dbe2@github.com>

> Convert test to manual main and move from the dedicated folder
> Remove old files

Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:

  Removing setLocation() on frame;

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18357/files
  - new: https://git.openjdk.org/jdk/pull/18357/files/10235707..ffd314ee

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18357&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18357&range=01-02

  Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18357.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18357/head:pull/18357

PR: https://git.openjdk.org/jdk/pull/18357

From kizune at openjdk.org  Wed Mar 20 04:28:47 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Wed, 20 Mar 2024 04:28:47 GMT
Subject: RFR: 8328377: Convert java/awt/Cursor/MultiResolutionCursorTest
 test to main [v2]
In-Reply-To: <uKI9aIE4h8Gzss2r3feG7XY48153dZAhScr75ZU-7p4=.13d34ef8-0bd6-43ea-959a-1a3fc2f61752@github.com>
References: <Y_DvKb6DvMCmv7RwRVmVh8OoSPikpEmcEbXtpVv9a20=.2809223d-537e-4de3-bb75-986db8154edc@github.com>
 <0dSFss67MVf8pZb_0BARTl70xls7xvxJnk1kYV81SOM=.611ad917-5e66-4c8d-9fdd-938adb21c486@github.com>
 <uKI9aIE4h8Gzss2r3feG7XY48153dZAhScr75ZU-7p4=.13d34ef8-0bd6-43ea-959a-1a3fc2f61752@github.com>
Message-ID: <VMNzQYgjI2KXRU7P0rv47d_etimCjv-t4hWjjWbX97g=.a68a9d43-0565-4652-9430-8ca4f6fb0795@github.com>

On Wed, 20 Mar 2024 03:15:36 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Adding library and build clauses
>
> test/jdk/java/awt/Cursor/MultiResolutionCursorTest.java line 63:
> 
>> 61:         JFrame frame = new JFrame("Multi-resolution Cursor Test Frame");
>> 62:         frame.setSize(300, 300);
>> 63:         frame.setLocation(300, 50);
> 
> Is setLocation required? I guess PassFailJFrame will take care of that when you call testUI

It can be omitted.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18357#discussion_r1531496568

From kizune at openjdk.org  Wed Mar 20 05:11:21 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Wed, 20 Mar 2024 05:11:21 GMT
Subject: RFR: 8328378: Convert java/awt/FileDialog/FileDialogForDirectories
 test to main [v2]
In-Reply-To: <MGoiJFdKMVuwp5thXCPaiht26DrVPrUVZiqcxKeOxPw=.0a6f57d1-da03-4618-b317-78779fb37ca4@github.com>
References: <2yId9SKzUfB9ZnRy1Ma_m6jye3Mad5UIx-mxcgcZdZ8=.b71c078f-0a57-4b4c-b1ce-a98d23df0b48@github.com>
 <MGoiJFdKMVuwp5thXCPaiht26DrVPrUVZiqcxKeOxPw=.0a6f57d1-da03-4618-b317-78779fb37ca4@github.com>
Message-ID: <cBMB19gPiIMZDwwtfNUIBJZVxKA3gLag_yCm6hsHLJI=.1b31d116-3897-46df-8eaf-c75752a01db2@github.com>

On Tue, 19 Mar 2024 07:49:39 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Adding library and build clauses
>
> test/jdk/java/awt/FileDialog/FileDialogForDirectories.java line 36:
> 
>> 34:  * @test
>> 35:  * @bug 7161437
>> 36:  * @summary We should support "apple.awt.fileDialogForDirectories" property.
> 
> @library is missing...Does it work for you without this? I see most of your latest PRs doesn't have this tag

I had PassFailJFrame.class in my classpath so i could run these tests easier. I fixed all of the headers now.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18358#discussion_r1531516652

From kizune at openjdk.org  Wed Mar 20 05:17:49 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Wed, 20 Mar 2024 05:17:49 GMT
Subject: RFR: 8328378: Convert java/awt/FileDialog/FileDialogForDirectories
 test to main [v3]
In-Reply-To: <2yId9SKzUfB9ZnRy1Ma_m6jye3Mad5UIx-mxcgcZdZ8=.b71c078f-0a57-4b4c-b1ce-a98d23df0b48@github.com>
References: <2yId9SKzUfB9ZnRy1Ma_m6jye3Mad5UIx-mxcgcZdZ8=.b71c078f-0a57-4b4c-b1ce-a98d23df0b48@github.com>
Message-ID: <SSQ2WQN0EGoKcFfqEQ3ImeW-btatHslUqKEboGB0xI4=.10cb2a66-4596-4018-9daa-feb9497786db@github.com>

> Convert test to main manual and move to the appropriate folder
> Remove old files

Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:

  Made fd and showBtn variables local.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18358/files
  - new: https://git.openjdk.org/jdk/pull/18358/files/d8f2aa64..63223622

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18358&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18358&range=01-02

  Stats: 6 lines in 1 file changed: 2 ins; 3 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/18358.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18358/head:pull/18358

PR: https://git.openjdk.org/jdk/pull/18358

From kizune at openjdk.org  Wed Mar 20 05:17:49 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Wed, 20 Mar 2024 05:17:49 GMT
Subject: RFR: 8328378: Convert java/awt/FileDialog/FileDialogForDirectories
 test to main [v3]
In-Reply-To: <SReGPvx9sn1BuaKL3eTudcZ5KHjQYROVAzmhul3Oj9s=.eb1f4dbd-1f09-432c-b8c2-da299739a548@github.com>
References: <2yId9SKzUfB9ZnRy1Ma_m6jye3Mad5UIx-mxcgcZdZ8=.b71c078f-0a57-4b4c-b1ce-a98d23df0b48@github.com>
 <MGoiJFdKMVuwp5thXCPaiht26DrVPrUVZiqcxKeOxPw=.0a6f57d1-da03-4618-b317-78779fb37ca4@github.com>
 <SReGPvx9sn1BuaKL3eTudcZ5KHjQYROVAzmhul3Oj9s=.eb1f4dbd-1f09-432c-b8c2-da299739a548@github.com>
Message-ID: <_p6sbrlt8yDRKjmjnIdvePofaFXoCDW9IePv0xxp2bM=.bec28f20-5e94-42e9-9cef-a2a1ff3f1180@github.com>

On Wed, 20 Mar 2024 03:13:19 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> test/jdk/java/awt/FileDialog/FileDialogForDirectories.java line 43:
>> 
>>> 41: public class FileDialogForDirectories {
>>> 42:     private static Button showBtn;
>>> 43:     private static FileDialog fd;
>> 
>> Can be made local in main
>
> Still could have been made local...

Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18358#discussion_r1531518973

From kizune at openjdk.org  Wed Mar 20 05:17:58 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Wed, 20 Mar 2024 05:17:58 GMT
Subject: RFR: 8328384: Convert java/awt/FileDialog/FileDialogOpenDirTest
 test to main [v3]
In-Reply-To: <uRRE9Iw6m8G9T9H0FWEYnUoGgInL7vGgYMPBwP7jEVI=.cb6605a0-f79a-4903-b565-e5dc29d81df2@github.com>
References: <uRRE9Iw6m8G9T9H0FWEYnUoGgInL7vGgYMPBwP7jEVI=.cb6605a0-f79a-4903-b565-e5dc29d81df2@github.com>
Message-ID: <IAh0fOrNr5YoeOHfla2xj0Gw1Z_K71TIl4e0db7Du0I=.a3b3f7fe-1e79-46ca-a0e6-28640e8e1afc@github.com>

> Convert test to main manual;
> Move test to appropriate folder;
> Delete old files;

Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:

  Update test/jdk/java/awt/FileDialog/FileDialogOpenDirTest.java
  
  Co-authored-by: Andrey Turbanov <turbanoff at gmail.com>

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18361/files
  - new: https://git.openjdk.org/jdk/pull/18361/files/5b8216b0..9c9e8fbb

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18361&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18361&range=01-02

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/18361.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18361/head:pull/18361

PR: https://git.openjdk.org/jdk/pull/18361

From psadhukhan at openjdk.org  Wed Mar 20 05:18:04 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Wed, 20 Mar 2024 05:18:04 GMT
Subject: RFR: 8328238: Convert few closed manual applet tests to main
Message-ID: <9uKHIdC_4RNWN6ecB8Es2dtAjhmMgTvQIrDMWmPJzfs=.39bb9943-81f5-4cae-8644-a1eaf45d82d6@github.com>

Few closed manual applet tests are converted to main based and opensourced

-------------

Commit messages:
 - 8328238: Convert few closed manual applet tests to main

Changes: https://git.openjdk.org/jdk/pull/18390/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18390&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8328238
  Stats: 396 lines in 4 files changed: 396 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18390.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18390/head:pull/18390

PR: https://git.openjdk.org/jdk/pull/18390

From psadhukhan at openjdk.org  Wed Mar 20 05:22:19 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Wed, 20 Mar 2024 05:22:19 GMT
Subject: RFR: 8328377: Convert java/awt/Cursor/MultiResolutionCursorTest
 test to main [v3]
In-Reply-To: <sAe1egAetX_5vtvecDx5SaN8be6XRCKCWWSdPMoRj1Q=.709001c7-aa59-4ec7-a6fa-32903609dbe2@github.com>
References: <Y_DvKb6DvMCmv7RwRVmVh8OoSPikpEmcEbXtpVv9a20=.2809223d-537e-4de3-bb75-986db8154edc@github.com>
 <sAe1egAetX_5vtvecDx5SaN8be6XRCKCWWSdPMoRj1Q=.709001c7-aa59-4ec7-a6fa-32903609dbe2@github.com>
Message-ID: <fP4K90G0zLO5d7sJzxZHC6xEXrqfkCAV8jjWtvlFVoY=.c77dfa7e-eb2d-45cd-a872-6b999ac63dee@github.com>

On Wed, 20 Mar 2024 04:28:47 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

>> Convert test to manual main and move from the dedicated folder
>> Remove old files
>
> Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Removing setLocation() on frame;

Marked as reviewed by psadhukhan (Reviewer).

test/jdk/java/awt/Cursor/MultiResolutionCursorTest.java line 47:

> 45: public class MultiResolutionCursorTest {
> 46:     static final int sizes[] = {8, 16, 32, 128};
> 47:     static final Color colors[] = {Color.WHITE, Color.RED, Color.GREEN, Color.BLUE};

colors could be made local..

-------------

PR Review: https://git.openjdk.org/jdk/pull/18357#pullrequestreview-1947960516
PR Review Comment: https://git.openjdk.org/jdk/pull/18357#discussion_r1531521432

From kizune at openjdk.org  Wed Mar 20 05:58:47 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Wed, 20 Mar 2024 05:58:47 GMT
Subject: RFR: 8328386: Convert java/awt/FileDialog/FileNameOverrideTest
 test to main [v4]
In-Reply-To: <Yhj0URlGvlalLqkqDnfMrkWbz24Pjab1KZxDHmN4HwA=.7b8b7630-74d0-4114-a650-d6d2afd98075@github.com>
References: <Yhj0URlGvlalLqkqDnfMrkWbz24Pjab1KZxDHmN4HwA=.7b8b7630-74d0-4114-a650-d6d2afd98075@github.com>
Message-ID: <lPOA4_ulZ779J4tDSDUIwquKAayKTmSFOwDJoHt8AlM=.8bdb525b-8c3c-4a51-9d93-af8b8f2b32ee@github.com>

> Convert applet based test to a main based test;
> Move test to an apporpriate location;
> Remove old files;

Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:

  Update test/jdk/java/awt/FileDialog/FileNameOverrideTest.java
  
  Co-authored-by: Aleksandr Zvegintsev <77687766+azvegint at users.noreply.github.com>

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18365/files
  - new: https://git.openjdk.org/jdk/pull/18365/files/5a52b8ef..24f7912d

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18365&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18365&range=02-03

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/18365.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18365/head:pull/18365

PR: https://git.openjdk.org/jdk/pull/18365

From tr at openjdk.org  Wed Mar 20 06:02:21 2024
From: tr at openjdk.org (Tejesh R)
Date: Wed, 20 Mar 2024 06:02:21 GMT
Subject: RFR: 8328035: Convert
 javax/swing/text/html/TableView/7030332/bug7030332.java applet test to main
 [v2]
In-Reply-To: <FAjlZDEEsrqlCQNM2ts-63ItAXkujwyx5Mpuc81trfk=.1090d65d-01a7-4b3d-9b97-2695af6c73fa@github.com>
References: <sa4wl3VTL1p3Zxmat10wUsqex-uQewN2R2N8tXTwFFo=.013c255b-d875-4b52-a0f0-403664011199@github.com>
 <_k4T1yzAqADVQLTUScWnfSqbGYg-YZJ9SecWpQB55kM=.ffa6e901-7cee-40b6-954a-528dfb04dc83@github.com>
 <czzx6URRvyadj98-Yf5hr87K7wDcKpAlQ6R_vEtlI9M=.957c488a-bb26-4dc9-8e90-e02a5c894ef1@github.com>
 <6SPvUhuB-QIgakHdRqx1_LzOADDQNU25xRz7k2obSZc=.ac2b9979-d177-412e-be68-7b10f9a3a0ae@github.com>
 <_tDJv5UgWgGj_eogkTzVvY7YvJtzckfxRAQs_pDzBsw=.f905413d-f540-41f2-a464-c647822de64d@github.com>
 <FAjlZDEEsrqlCQNM2ts-63ItAXkujwyx5Mpuc81trfk=.1090d65d-01a7-4b3d-9b97-2695af6c73fa@github.com>
Message-ID: <_hoq8F5GGhG-PeyH6IAWlRqmYLHrTj_UElGkjO33Uak=.b379c878-8a4e-4c55-a6cd-7d0301ba6681@github.com>

On Mon, 18 Mar 2024 14:06:36 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> > @prsadhuk With scaling 1.0 it'll appear this way. I think it's supposed to be 1.0 scaling and its looking similar now. ![image](https://private-user-images.githubusercontent.com/94159358/313696311-92e4358b-651d-43d9-bdc8-cb4a44aa021c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTA3NzA5MjMsIm5iZiI6MTcxMDc3MDYyMywicGF0aCI6Ii85NDE1OTM1OC8zMTM2OTYzMTEtOTJlNDM1OGItNjUxZC00M2Q5LWJkYzgtY2I0YTQ0YWEwMjFjLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAzMTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMzE4VDE0MDM0M1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTc0NTcyZGE3NTBlOWFhY2YxYzk3NWNjZjc4ZDliNmJlZDE5ZWZhMDA3NTc2ZDliYjJmOGJmOTEwOTdlY2M1YWEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.sSwTFVLibyG4g0u0xl92qA8fS5zU08-CP_6UICqH6Ds)
> 
> I am not sure..it still seems 1.25 bigger than golden image..."similar" word has different connotation and is very subjective....is it intentional that "same" was not mentioned? What if we say, Earth and Mars are similar as they are planets...

Then shall I problemlist it?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18260#issuecomment-2008706412

From tr at openjdk.org  Wed Mar 20 06:02:25 2024
From: tr at openjdk.org (Tejesh R)
Date: Wed, 20 Mar 2024 06:02:25 GMT
Subject: Integrated: 8327879: Convert javax/swing/border/Test4760089.java
 applet test to main
In-Reply-To: <Vq0kXwaE6TFmJzGmgpo13OA3VEqSnqsjQpDpGZj2ob4=.4f188f8b-5581-4774-8345-76363b4e3cf6@github.com>
References: <Vq0kXwaE6TFmJzGmgpo13OA3VEqSnqsjQpDpGZj2ob4=.4f188f8b-5581-4774-8345-76363b4e3cf6@github.com>
Message-ID: <VTLUxYq_eOdEPND15YYZf0eRwrpY2HEw-MsH_bBJOrk=.1290acb0-e632-4c06-8d7e-c563f84035b7@github.com>

On Tue, 12 Mar 2024 07:35:36 GMT, Tejesh R <tr at openjdk.org> wrote:

> Convert javax/swing/border/Test4760089.java applet test to main based test using PassFailJFrame.

This pull request has now been integrated.

Changeset: a68f5d73
Author:    Tejesh R <tr at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/a68f5d7331c2e6c4bc51eee95abcbabb5a19b484
Stats:     71 lines in 2 files changed: 25 ins; 35 del; 11 mod

8327879: Convert javax/swing/border/Test4760089.java applet test to main

Reviewed-by: abhiscxk, prr

-------------

PR: https://git.openjdk.org/jdk/pull/18217

From kizune at openjdk.org  Wed Mar 20 06:06:34 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Wed, 20 Mar 2024 06:06:34 GMT
Subject: RFR: 8328386: Convert java/awt/FileDialog/FileNameOverrideTest
 test to main [v5]
In-Reply-To: <Yhj0URlGvlalLqkqDnfMrkWbz24Pjab1KZxDHmN4HwA=.7b8b7630-74d0-4114-a650-d6d2afd98075@github.com>
References: <Yhj0URlGvlalLqkqDnfMrkWbz24Pjab1KZxDHmN4HwA=.7b8b7630-74d0-4114-a650-d6d2afd98075@github.com>
Message-ID: <Z1obJa5GgEEhf9MkyT8XV6bBrYAfu_I3F_DTtMDu7D0=.5e878616-1a75-41e7-b658-caaec6687e70@github.com>

> Convert applet based test to a main based test;
> Move test to an apporpriate location;
> Remove old files;

Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:

  More fixes based on review.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18365/files
  - new: https://git.openjdk.org/jdk/pull/18365/files/24f7912d..d895e970

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18365&range=04
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18365&range=03-04

  Stats: 11 lines in 1 file changed: 3 ins; 6 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/18365.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18365/head:pull/18365

PR: https://git.openjdk.org/jdk/pull/18365

From kizune at openjdk.org  Wed Mar 20 06:06:34 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Wed, 20 Mar 2024 06:06:34 GMT
Subject: RFR: 8328386: Convert java/awt/FileDialog/FileNameOverrideTest
 test to main [v3]
In-Reply-To: <f4C1v8ca8ZF8So5BXncUCVyKcBzkYB36R0jcYgPRnK8=.6aaaca89-fbe7-40e5-968c-ab63f8b5403a@github.com>
References: <Yhj0URlGvlalLqkqDnfMrkWbz24Pjab1KZxDHmN4HwA=.7b8b7630-74d0-4114-a650-d6d2afd98075@github.com>
 <d5M8RIH3bn8FrNyruQY6XAXGJubfUYI3GpK96e6SanA=.e798ea2e-a9c1-4c7d-924b-39d48a128383@github.com>
 <f4C1v8ca8ZF8So5BXncUCVyKcBzkYB36R0jcYgPRnK8=.6aaaca89-fbe7-40e5-968c-ab63f8b5403a@github.com>
Message-ID: <TmZvwJPA8HCKtBR7n0MgbwhpTGEd6LSvGwyyMjqsjy0=.800d1c5d-6100-4487-b56f-d0dfc01621bc@github.com>

On Tue, 19 Mar 2024 23:17:04 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>> Alexander Zuev has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Update test/jdk/java/awt/FileDialog/FileNameOverrideTest.java
>>    
>>    Co-authored-by: Aleksandr Zvegintsev <77687766+azvegint at users.noreply.github.com>
>>  - Make test skip if current toolkit is not supported;
>>    Make test pass or fail automatically;
>>    Correct test instructions accordingly;
>
> test/jdk/java/awt/FileDialog/FileNameOverrideTest.java line 49:
> 
>> 47:     private final static String clickDirName = "Directory for double click";
>> 48:     private final static String dirPath = System.getProperty("user.dir");;
>> 49:     private static JButton showBtn;
> 
> Can be local variable

Fixed.

> test/jdk/java/awt/FileDialog/FileNameOverrideTest.java line 56:
> 
>> 54:         showBtn.addActionListener(w -> {
>> 55:             Frame frame = new Frame();
>> 56:             fd = new FileDialog(frame, "Open");
> 
> Suggestion:
> 
>             fd = new FileDialog((Frame) null, "Open");
> 
> There is no point in this frame.

Ok.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18365#discussion_r1531541505
PR Review Comment: https://git.openjdk.org/jdk/pull/18365#discussion_r1531541438

From tr at openjdk.org  Wed Mar 20 06:12:21 2024
From: tr at openjdk.org (Tejesh R)
Date: Wed, 20 Mar 2024 06:12:21 GMT
Subject: RFR: 8328328: Convert
 javax/swing/JTabbedPane/4666224/bug4666224.java applet test to main [v2]
In-Reply-To: <nbGYCc8iRqT0py3apaNvXYjsB7Pwsjr5mufVrTMZeGk=.9041765b-b92c-46b1-b026-d13ea297dd0c@github.com>
References: <4fqxbuw6GwuEAg6v7kvn72AQC3LeXPodKf8OrBDOr1w=.1cffa811-37e8-4294-b469-6487763bdeed@github.com>
 <nbGYCc8iRqT0py3apaNvXYjsB7Pwsjr5mufVrTMZeGk=.9041765b-b92c-46b1-b026-d13ea297dd0c@github.com>
Message-ID: <vvktyzzRFJx_jxmfCOEKzDWP76lP2usDWCouL7a1z34=.e2ff7c51-413b-4ce7-a0ea-76e7def8ebdc@github.com>

On Wed, 20 Mar 2024 04:18:46 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Conversion of manual applet test to main based using PassFailJFrame manual framework.
>> 
>> Tested in macOS where it didn't worked for "key press C to change tab layout" else it worked for other "key press (R, B, L, T) to change tab position. So, test is still in problem list.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   minor fix

test/jdk/javax/swing/JTabbedPane/bug4666224.java line 54:

> 52:                 ON ALL PLATFORMS
> 53:                     1. Click on any of the tabs, focus indicator is visible.
> 54:                     2. Lose focus on the window by clicking on some other window.

Lose focus?

test/jdk/javax/swing/JTabbedPane/bug4666224.java line 132:

> 130:         map.put("bottom", new RotateAction(JTabbedPane.BOTTOM));
> 131:         map.put("changeLayout", new ChangeLayoutAction());
> 132:         map.put("dump", new DumpAction());

`DumpAction `can also be mentioned in INSTRUCTIONS I guess, since its been used here.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18340#discussion_r1531541477
PR Review Comment: https://git.openjdk.org/jdk/pull/18340#discussion_r1531546196

From psadhukhan at openjdk.org  Wed Mar 20 06:21:22 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Wed, 20 Mar 2024 06:21:22 GMT
Subject: RFR: 8328035: Convert
 javax/swing/text/html/TableView/7030332/bug7030332.java applet test to main
 [v2]
In-Reply-To: <_k4T1yzAqADVQLTUScWnfSqbGYg-YZJ9SecWpQB55kM=.ffa6e901-7cee-40b6-954a-528dfb04dc83@github.com>
References: <sa4wl3VTL1p3Zxmat10wUsqex-uQewN2R2N8tXTwFFo=.013c255b-d875-4b52-a0f0-403664011199@github.com>
 <_k4T1yzAqADVQLTUScWnfSqbGYg-YZJ9SecWpQB55kM=.ffa6e901-7cee-40b6-954a-528dfb04dc83@github.com>
Message-ID: <8OiGTvKzBlSqdN879t4GkIyTT5CJpkHOBRmuaLWdNBY=.38eae1af-37cb-4224-9efa-f33434874f10@github.com>

On Thu, 14 Mar 2024 11:02:52 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Convert javax/swing/text/html/TableView/7030332/bug7030332.java applet test to main based test using PassFailJFrame.
>
> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review updates

Ideally yes, but you can discuss in the meeting since harshita/damon has not come back on this..

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18260#issuecomment-2008722624

From jwaters at openjdk.org  Wed Mar 20 06:25:51 2024
From: jwaters at openjdk.org (Julian Waters)
Date: Wed, 20 Mar 2024 06:25:51 GMT
Subject: RFR: 8307160: Fix AWT/2D/A11Y to support the permissive- flag on
 the Microsoft Visual C compiler [v46]
In-Reply-To: <QfIBrG8rqxy__rPSCMddlNATjmEEr4ccSoZyjFckjUg=.b7f6fffb-2cf9-4c54-a35c-b01f5fd654de@github.com>
References: <7piLRto5nNbhYYYfENCr5ecm4M2xNtMkjkE8XhrLLQ0=.8fd1ac3a-46f8-47a8-ae37-a4abbf7757d9@github.com>
 <5WJnl6Z9RyYzZrDStf9p74gus07Stz6S6NHwVpGQO3M=.0a04a120-77b5-48c3-9ae8-7d37c9646463@github.com>
 <QfIBrG8rqxy__rPSCMddlNATjmEEr4ccSoZyjFckjUg=.b7f6fffb-2cf9-4c54-a35c-b01f5fd654de@github.com>
Message-ID: <aAmBW4xAmuvxi3KEXCNFaq8WZ0zjjKk_bZisWgA6UMM=.a0a49004-699f-4835-ba98-9510427f9483@github.com>

On Sat, 20 Jan 2024 00:17:02 GMT, Phil Race <prr at openjdk.org> wrote:

>> Julian Waters has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 79 commits:
>> 
>>  - Merge branch 'openjdk:master' into patch-10
>>  - Merge branch 'openjdk:master' into patch-10
>>  - Fix awt_Window.cpp
>>  - Fix awt_PrintJob.cpp
>>  - -Zc:stringStrings no longer needed with -permissive- flags-cflags.m4
>>  - Fix awt_Window.cpp
>>  - awt_Window.cpp
>>  - awt_PrintJob.cpp
>>  - awt_Frame.cpp
>>  - Whitespace awt_Component.cpp
>>  - ... and 69 more: https://git.openjdk.org/jdk/compare/35e96627...cbfbaee6
>
> src/java.desktop/windows/native/libawt/windows/awt_Component.cpp line 6366:
> 
>> 6364:         jobject parent = data->parentComp;
>> 6365: 
>> 6366:         AwtComponent *awtComponent = nullptr;
> 
> Looking at it (not tested) here through 6403 could be simplified as
> 
>       if (self == NULL || parent == NULL) {
>             env->ExceptionClear();
>             JNU_ThrowNullPointerException(env, "peer");
>             env->DeleteGlobalRef(self);
>             env->DeleteGlobalRef(parent);
>             delete data;
>             return;
>         }
> 
>         AwtComponent *awtComponent = (AwtComponent *)JNI_GET_PDATA(self);
>         if (awtComponent == NULL) {
>             THROW_NULL_PDATA_IF_NOT_DESTROYED(self);
>             env->DeleteGlobalRef(self);
>             env->DeleteGlobalRef(parent);
>             delete data;
>             return;
>         }
> 
>         AwtComponent *awtParent = (AwtComponent *)JNI_GET_PDATA(parent);
>         if (awtParent == NULL) {
>             THROW_NULL_PDATA_IF_NOT_DESTROYED(parent);
>             env->DeleteGlobalRef(self);
>             env->DeleteGlobalRef(parent);
>             delete data;
>             return;
>         }
> 
> 
> I think I prefer that over
>         BOOL error = FALSE;
>         AwtComponent *awtComponent = nullptr;
>         AwtComponent *awtParent = nullptr;
> 
>         if (self == NULL || parent == NULL) {
>             env->ExceptionClear();
>             JNU_ThrowNullPointerException(env, "peer");
>             error = TRUE;
>         }
>         
>         if (!error) {
>             awtComponent = (AwtComponent *)JNI_GET_PDATA(self);
>              if (awtComponent == NULL) {
>                  THROW_NULL_PDATA_IF_NOT_DESTROYED(self);
>                  error = TRUE;
>              }
>         }
> 
>         if (!error) {
>             awtParent = (AwtComponent *)JNI_GET_PDATA(parent);
>             if (awtParent == NULL) {
>                 THROW_NULL_PDATA_IF_NOT_DESTROYED(parent);
>                 error = TRUE;
>         }
> 
>         if (error) {
>             env->DeleteGlobalRef(self);
>             env->DeleteGlobalRef(parent);
>             delete data;
>             return;
>         }

Sorry, I don't see a BOOL error anywhere?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15096#discussion_r1531553778

From jwaters at openjdk.org  Wed Mar 20 06:33:52 2024
From: jwaters at openjdk.org (Julian Waters)
Date: Wed, 20 Mar 2024 06:33:52 GMT
Subject: RFR: 8307160: Fix AWT/2D/A11Y to support the permissive- flag on
 the Microsoft Visual C compiler [v51]
In-Reply-To: <7piLRto5nNbhYYYfENCr5ecm4M2xNtMkjkE8XhrLLQ0=.8fd1ac3a-46f8-47a8-ae37-a4abbf7757d9@github.com>
References: <7piLRto5nNbhYYYfENCr5ecm4M2xNtMkjkE8XhrLLQ0=.8fd1ac3a-46f8-47a8-ae37-a4abbf7757d9@github.com>
Message-ID: <ma4sNomMShi71ZD5-JwEBXWyuAP1_5Qx0WoE4xJRRw0=.6f842107-791c-49f6-9900-00e5a0d2b3ee@github.com>

> We should set the -permissive- flag for the Microsoft Visual C compiler, as was requested by the now backed out [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). Doing so makes the Visual C compiler much less accepting of ill formed code, which will improve code quality on Windows in the future.

Julian Waters has updated the pull request incrementally with one additional commit since the last revision:

  Revert Formatting in awt_PrintJob.cpp

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/15096/files
  - new: https://git.openjdk.org/jdk/pull/15096/files/0f34608b..18014c3a

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=15096&range=50
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=15096&range=49-50

  Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/15096.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/15096/head:pull/15096

PR: https://git.openjdk.org/jdk/pull/15096

From jwaters at openjdk.org  Wed Mar 20 06:38:59 2024
From: jwaters at openjdk.org (Julian Waters)
Date: Wed, 20 Mar 2024 06:38:59 GMT
Subject: RFR: 8307160: Fix AWT/2D/A11Y to support the permissive- flag on
 the Microsoft Visual C compiler [v52]
In-Reply-To: <7piLRto5nNbhYYYfENCr5ecm4M2xNtMkjkE8XhrLLQ0=.8fd1ac3a-46f8-47a8-ae37-a4abbf7757d9@github.com>
References: <7piLRto5nNbhYYYfENCr5ecm4M2xNtMkjkE8XhrLLQ0=.8fd1ac3a-46f8-47a8-ae37-a4abbf7757d9@github.com>
Message-ID: <0p1UVaUOt2bs1mkuBV1liUxBYGRhnKnclf1x_-Y22GE=.2de6c2c4-8cf5-470d-bdb3-cd0dd0e13975@github.com>

> We should set the -permissive- flag for the Microsoft Visual C compiler, as was requested by the now backed out [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). Doing so makes the Visual C compiler much less accepting of ill formed code, which will improve code quality on Windows in the future.

Julian Waters has updated the pull request incrementally with two additional commits since the last revision:

 - Revert Formatting in awt_Component.cpp
 - Revert Formatting in awt_Window.cpp

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/15096/files
  - new: https://git.openjdk.org/jdk/pull/15096/files/18014c3a..0439b138

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=15096&range=51
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=15096&range=50-51

  Stats: 6 lines in 2 files changed: 2 ins; 0 del; 4 mod
  Patch: https://git.openjdk.org/jdk/pull/15096.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/15096/head:pull/15096

PR: https://git.openjdk.org/jdk/pull/15096

From tr at openjdk.org  Wed Mar 20 06:41:20 2024
From: tr at openjdk.org (Tejesh R)
Date: Wed, 20 Mar 2024 06:41:20 GMT
Subject: RFR: 8327980: Convert
 javax/swing/JToggleButton/4128979/bug4128979.java applet test to main [v4]
In-Reply-To: <n0vT_fy8wfZX68dx4u3XCeJjm6Scet9KPaXbLdpwvII=.d7567f62-498f-4aa3-ac42-d9490ba0faa7@github.com>
References: <lZHt9pYb75UtaIEtbB0paOkfqR5CUAc6tikhb9YAakU=.ff2adbed-1db2-490a-8747-66ac96d03657@github.com>
 <n0vT_fy8wfZX68dx4u3XCeJjm6Scet9KPaXbLdpwvII=.d7567f62-498f-4aa3-ac42-d9490ba0faa7@github.com>
Message-ID: <87TT43vLzavbC6ursccLOMzGwGXvdOj7FUUBcv-GHp0=.37f8222f-ed56-4134-9e1c-3ced7eee6131@github.com>

On Fri, 15 Mar 2024 07:38:56 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Conversion of manual applet test to main based using PassFailJFrame manual framework
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   jtreg manual tag update

test/jdk/javax/swing/JToggleButton/bug4128979.java line 32:

> 30:  * @summary Tests that background changes correctly in WinLF for JToggleButton when pressed
> 31:  * @run main/manual bug4128979
> 32:  */

Move it after imports.

test/jdk/javax/swing/JToggleButton/bug4128979.java line 55:

> 53: 
> 54: public class bug4128979 {
> 55:     private static JFrame frame;

`frame `can be moved inside `createAndShowUI()`.

test/jdk/javax/swing/JToggleButton/bug4128979.java line 65:

> 63: 
> 64:             If the background color does not change correctly for at least one button,
> 65:             the test fails. """;

Getting a white space after `fails.`, can you check once.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18233#discussion_r1531560138
PR Review Comment: https://git.openjdk.org/jdk/pull/18233#discussion_r1531563247
PR Review Comment: https://git.openjdk.org/jdk/pull/18233#discussion_r1531563877

From jwaters at openjdk.org  Wed Mar 20 06:48:40 2024
From: jwaters at openjdk.org (Julian Waters)
Date: Wed, 20 Mar 2024 06:48:40 GMT
Subject: RFR: 8307160: Fix AWT/2D/A11Y to support the permissive- flag on
 the Microsoft Visual C compiler [v50]
In-Reply-To: <xuf6JToKZYgafEovpGhphLBEzENZYSYduo1HqkVDd78=.3b49e309-eb0e-4c25-9f35-e02f79c12374@github.com>
References: <7piLRto5nNbhYYYfENCr5ecm4M2xNtMkjkE8XhrLLQ0=.8fd1ac3a-46f8-47a8-ae37-a4abbf7757d9@github.com>
 <oMTWDHUD8wvoaxiISrGY1ijZecfyRw2GoMN_lIENT6U=.69c833b2-1210-41ad-b08b-4775ab662243@github.com>
 <xuf6JToKZYgafEovpGhphLBEzENZYSYduo1HqkVDd78=.3b49e309-eb0e-4c25-9f35-e02f79c12374@github.com>
Message-ID: <FV_OUw0xpb2FEZpUp_HCp1gfwgMg_Nu1AGKB3GkFjx4=.dd63ba37-4417-4372-8f08-bb860bdbdbda@github.com>

On Mon, 18 Mar 2024 15:55:15 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

> bot-keep-alive
> 
> @TheShermanTanker Did you understand the remaining changes that Phil has requested? Do you think you'll be able to fix this?

Hi Magnus, yes I do plan on fixing this. I've just been a bit busy and tired is all, and also to be honest I don't quite understand some of Phil's reviews, which is why I'm asking for clarification on some of them first

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15096#issuecomment-2008743382

From jwaters at openjdk.org  Wed Mar 20 06:48:41 2024
From: jwaters at openjdk.org (Julian Waters)
Date: Wed, 20 Mar 2024 06:48:41 GMT
Subject: RFR: 8307160: Fix AWT/2D/A11Y to support the permissive- flag on
 the Microsoft Visual C compiler [v46]
In-Reply-To: <aAmBW4xAmuvxi3KEXCNFaq8WZ0zjjKk_bZisWgA6UMM=.a0a49004-699f-4835-ba98-9510427f9483@github.com>
References: <7piLRto5nNbhYYYfENCr5ecm4M2xNtMkjkE8XhrLLQ0=.8fd1ac3a-46f8-47a8-ae37-a4abbf7757d9@github.com>
 <5WJnl6Z9RyYzZrDStf9p74gus07Stz6S6NHwVpGQO3M=.0a04a120-77b5-48c3-9ae8-7d37c9646463@github.com>
 <QfIBrG8rqxy__rPSCMddlNATjmEEr4ccSoZyjFckjUg=.b7f6fffb-2cf9-4c54-a35c-b01f5fd654de@github.com>
 <aAmBW4xAmuvxi3KEXCNFaq8WZ0zjjKk_bZisWgA6UMM=.a0a49004-699f-4835-ba98-9510427f9483@github.com>
Message-ID: <0zriWFk8mESin6eTDm4kH02213a8tTq5gEBx41NtZ8Y=.74965e93-6475-44ee-805b-73c477aede94@github.com>

On Wed, 20 Mar 2024 06:22:50 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> src/java.desktop/windows/native/libawt/windows/awt_Component.cpp line 6366:
>> 
>>> 6364:         jobject parent = data->parentComp;
>>> 6365: 
>>> 6366:         AwtComponent *awtComponent = nullptr;
>> 
>> Looking at it (not tested) here through 6403 could be simplified as
>> 
>>       if (self == NULL || parent == NULL) {
>>             env->ExceptionClear();
>>             JNU_ThrowNullPointerException(env, "peer");
>>             env->DeleteGlobalRef(self);
>>             env->DeleteGlobalRef(parent);
>>             delete data;
>>             return;
>>         }
>> 
>>         AwtComponent *awtComponent = (AwtComponent *)JNI_GET_PDATA(self);
>>         if (awtComponent == NULL) {
>>             THROW_NULL_PDATA_IF_NOT_DESTROYED(self);
>>             env->DeleteGlobalRef(self);
>>             env->DeleteGlobalRef(parent);
>>             delete data;
>>             return;
>>         }
>> 
>>         AwtComponent *awtParent = (AwtComponent *)JNI_GET_PDATA(parent);
>>         if (awtParent == NULL) {
>>             THROW_NULL_PDATA_IF_NOT_DESTROYED(parent);
>>             env->DeleteGlobalRef(self);
>>             env->DeleteGlobalRef(parent);
>>             delete data;
>>             return;
>>         }
>> 
>> 
>> I think I prefer that over
>>         BOOL error = FALSE;
>>         AwtComponent *awtComponent = nullptr;
>>         AwtComponent *awtParent = nullptr;
>> 
>>         if (self == NULL || parent == NULL) {
>>             env->ExceptionClear();
>>             JNU_ThrowNullPointerException(env, "peer");
>>             error = TRUE;
>>         }
>>         
>>         if (!error) {
>>             awtComponent = (AwtComponent *)JNI_GET_PDATA(self);
>>              if (awtComponent == NULL) {
>>                  THROW_NULL_PDATA_IF_NOT_DESTROYED(self);
>>                  error = TRUE;
>>              }
>>         }
>> 
>>         if (!error) {
>>             awtParent = (AwtComponent *)JNI_GET_PDATA(parent);
>>             if (awtParent == NULL) {
>>                 THROW_NULL_PDATA_IF_NOT_DESTROYED(parent);
>>                 error = TRUE;
>>         }
>> 
>>         if (error) {
>>             env->DeleteGlobalRef(self);
>>             env->DeleteGlobalRef(parent);
>>             delete data;
>>             return;
>>         }
>
> Sorry, I don't see a BOOL error anywhere?

I see the advantage of collapsing self and parent into the same check, but it doesn't seem like getting rid of pData is of much benefit, the checks for null seem to remain the same either way

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15096#discussion_r1531567293

From psadhukhan at openjdk.org  Wed Mar 20 06:50:19 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Wed, 20 Mar 2024 06:50:19 GMT
Subject: RFR: JDK-8328379 : Convert URLDragTest.html applet test to main
In-Reply-To: <LMnkG1RNIu10nqg2m8IvZN73P9b1rFN4T56JjPmgZLk=.8cde2a03-28b8-4dc5-84b7-2be086494f13@github.com>
References: <LMnkG1RNIu10nqg2m8IvZN73P9b1rFN4T56JjPmgZLk=.8cde2a03-28b8-4dc5-84b7-2be086494f13@github.com>
Message-ID: <z9X5hi5HnQck3gNEOt1vgUPOyjBT8nvRCTUJd6KowwA=.e3e6ac38-8663-4e0e-8612-dcb8a0b026d9@github.com>

On Mon, 18 Mar 2024 20:53:50 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

> Following test - test/jdk/java/awt/dnd/URLDragTest/URLDragTest.html is converted from applet to main using PassFailJFrame. 
> 
> PassFailJFrame's `logArea()` is used for logging messages.

Marked as reviewed by psadhukhan (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18364#pullrequestreview-1948039625

From abhiscxk at openjdk.org  Wed Mar 20 08:22:20 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Wed, 20 Mar 2024 08:22:20 GMT
Subject: RFR: 8328328: Convert
 javax/swing/JTabbedPane/4666224/bug4666224.java applet test to main [v2]
In-Reply-To: <vvktyzzRFJx_jxmfCOEKzDWP76lP2usDWCouL7a1z34=.e2ff7c51-413b-4ce7-a0ea-76e7def8ebdc@github.com>
References: <4fqxbuw6GwuEAg6v7kvn72AQC3LeXPodKf8OrBDOr1w=.1cffa811-37e8-4294-b469-6487763bdeed@github.com>
 <nbGYCc8iRqT0py3apaNvXYjsB7Pwsjr5mufVrTMZeGk=.9041765b-b92c-46b1-b026-d13ea297dd0c@github.com>
 <vvktyzzRFJx_jxmfCOEKzDWP76lP2usDWCouL7a1z34=.e2ff7c51-413b-4ce7-a0ea-76e7def8ebdc@github.com>
Message-ID: <ScG-qWrMP0KeWri_B7q-tbQVD8eN9pG-42iIyYP5yRY=.db37c351-db05-4f39-adb3-4594ad945206@github.com>

On Wed, 20 Mar 2024 06:01:25 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   minor fix
>
> test/jdk/javax/swing/JTabbedPane/bug4666224.java line 54:
> 
>> 52:                 ON ALL PLATFORMS
>> 53:                     1. Click on any of the tabs, focus indicator is visible.
>> 54:                     2. Lose focus on the window by clicking on some other window.
> 
> Lose focus?

Yeah, it means the current focused windows should not be focused.

> test/jdk/javax/swing/JTabbedPane/bug4666224.java line 132:
> 
>> 130:         map.put("bottom", new RotateAction(JTabbedPane.BOTTOM));
>> 131:         map.put("changeLayout", new ChangeLayoutAction());
>> 132:         map.put("dump", new DumpAction());
> 
> `DumpAction `can also be mentioned in INSTRUCTIONS I guess, since its been used here.

There is no instruction mentioned in old applet test. Kept it as it is.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18340#discussion_r1531660249
PR Review Comment: https://git.openjdk.org/jdk/pull/18340#discussion_r1531660927

From abhiscxk at openjdk.org  Wed Mar 20 08:30:36 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Wed, 20 Mar 2024 08:30:36 GMT
Subject: RFR: 8327980: Convert
 javax/swing/JToggleButton/4128979/bug4128979.java applet test to main [v5]
In-Reply-To: <lZHt9pYb75UtaIEtbB0paOkfqR5CUAc6tikhb9YAakU=.ff2adbed-1db2-490a-8747-66ac96d03657@github.com>
References: <lZHt9pYb75UtaIEtbB0paOkfqR5CUAc6tikhb9YAakU=.ff2adbed-1db2-490a-8747-66ac96d03657@github.com>
Message-ID: <CI5b0LRpMwIQQULd-K7SL1T_xzTJLAhswbc-1e9WpkE=.2eeaf569-0069-4f6a-898b-1c7f8df13e0a@github.com>

> Conversion of manual applet test to main based using PassFailJFrame manual framework

Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:

  Review comment update

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18233/files
  - new: https://git.openjdk.org/jdk/pull/18233/files/4e5c83d6..90ba58cc

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18233&range=04
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18233&range=03-04

  Stats: 23 lines in 1 file changed: 10 ins; 11 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/18233.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18233/head:pull/18233

PR: https://git.openjdk.org/jdk/pull/18233

From abhiscxk at openjdk.org  Wed Mar 20 08:30:36 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Wed, 20 Mar 2024 08:30:36 GMT
Subject: RFR: 8327980: Convert
 javax/swing/JToggleButton/4128979/bug4128979.java applet test to main [v4]
In-Reply-To: <87TT43vLzavbC6ursccLOMzGwGXvdOj7FUUBcv-GHp0=.37f8222f-ed56-4134-9e1c-3ced7eee6131@github.com>
References: <lZHt9pYb75UtaIEtbB0paOkfqR5CUAc6tikhb9YAakU=.ff2adbed-1db2-490a-8747-66ac96d03657@github.com>
 <n0vT_fy8wfZX68dx4u3XCeJjm6Scet9KPaXbLdpwvII=.d7567f62-498f-4aa3-ac42-d9490ba0faa7@github.com>
 <87TT43vLzavbC6ursccLOMzGwGXvdOj7FUUBcv-GHp0=.37f8222f-ed56-4134-9e1c-3ced7eee6131@github.com>
Message-ID: <xVH5ppZ9BySr-E1NdxBwt9lVf9zAGXWowwRzW2FrozE=.590d7e77-5914-405d-82f0-b5f8147dd294@github.com>

On Wed, 20 Mar 2024 06:32:26 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   jtreg manual tag update
>
> test/jdk/javax/swing/JToggleButton/bug4128979.java line 32:
> 
>> 30:  * @summary Tests that background changes correctly in WinLF for JToggleButton when pressed
>> 31:  * @run main/manual bug4128979
>> 32:  */
> 
> Move it after imports.

Updated but placing of imports is still confusing.

> test/jdk/javax/swing/JToggleButton/bug4128979.java line 55:
> 
>> 53: 
>> 54: public class bug4128979 {
>> 55:     private static JFrame frame;
> 
> `frame `can be moved inside `createAndShowUI()`.

Updated.

> test/jdk/javax/swing/JToggleButton/bug4128979.java line 65:
> 
>> 63: 
>> 64:             If the background color does not change correctly for at least one button,
>> 65:             the test fails. """;
> 
> Getting a white space after `fails.`, can you check once.

Not a problem though since it is part of instruction. Anyways removed extra space.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18233#discussion_r1531667599
PR Review Comment: https://git.openjdk.org/jdk/pull/18233#discussion_r1531669136
PR Review Comment: https://git.openjdk.org/jdk/pull/18233#discussion_r1531670435

From psadhukhan at openjdk.org  Wed Mar 20 09:27:59 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Wed, 20 Mar 2024 09:27:59 GMT
Subject: RFR: 8328238: Convert few closed manual applet tests to main [v2]
In-Reply-To: <9uKHIdC_4RNWN6ecB8Es2dtAjhmMgTvQIrDMWmPJzfs=.39bb9943-81f5-4cae-8644-a1eaf45d82d6@github.com>
References: <9uKHIdC_4RNWN6ecB8Es2dtAjhmMgTvQIrDMWmPJzfs=.39bb9943-81f5-4cae-8644-a1eaf45d82d6@github.com>
Message-ID: <bZvzPJfAF3Wka4Ksk7aBteZBcmXqvsaZcamgOO7YkGM=.d1ae768e-c6d9-40f6-9375-9a85d3ded436@github.com>

> Few closed manual applet tests are converted to main based and opensourced

Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:

  Frame title

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18390/files
  - new: https://git.openjdk.org/jdk/pull/18390/files/40d3aed0..a7ab52c3

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18390&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18390&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/18390.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18390/head:pull/18390

PR: https://git.openjdk.org/jdk/pull/18390

From tr at openjdk.org  Wed Mar 20 09:46:21 2024
From: tr at openjdk.org (Tejesh R)
Date: Wed, 20 Mar 2024 09:46:21 GMT
Subject: RFR: 8328238: Convert few closed manual applet tests to main [v2]
In-Reply-To: <bZvzPJfAF3Wka4Ksk7aBteZBcmXqvsaZcamgOO7YkGM=.d1ae768e-c6d9-40f6-9375-9a85d3ded436@github.com>
References: <9uKHIdC_4RNWN6ecB8Es2dtAjhmMgTvQIrDMWmPJzfs=.39bb9943-81f5-4cae-8644-a1eaf45d82d6@github.com>
 <bZvzPJfAF3Wka4Ksk7aBteZBcmXqvsaZcamgOO7YkGM=.d1ae768e-c6d9-40f6-9375-9a85d3ded436@github.com>
Message-ID: <pLiQ7TJAT4zLmlnGrNp9LfgGsQ9ayMtSx7d8Zu5HmO8=.fe4c1aa3-dc39-4de7-ad41-2bdd9c7b146d@github.com>

On Wed, 20 Mar 2024 09:27:59 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Few closed manual applet tests are converted to main based and opensourced
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Frame title

test/jdk/javax/swing/JFrame/bug4419914.java line 31:

> 29:  * @build PassFailJFrame
> 30:  * @run main/manual bug4419914
> 31: */

In most of the test which we are converting to main, we are moving the jtreg tags after imports. You are planning to retain it before imports?

test/jdk/javax/swing/text/bug4148489.java line 31:

> 29:  * @build PassFailJFrame
> 30:  * @run main/manual bug4148489
> 31: */

One space gap.

test/jdk/javax/swing/text/html/StyleSheet/bug4803145.java line 42:

> 40: import javax.swing.text.html.HTMLEditorKit;
> 41: 
> 42: 

Extra line space here.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18390#discussion_r1531765711
PR Review Comment: https://git.openjdk.org/jdk/pull/18390#discussion_r1531760308
PR Review Comment: https://git.openjdk.org/jdk/pull/18390#discussion_r1531768785

From tr at openjdk.org  Wed Mar 20 10:02:23 2024
From: tr at openjdk.org (Tejesh R)
Date: Wed, 20 Mar 2024 10:02:23 GMT
Subject: RFR: 8328403: Remove applet usage from JColorChooser tests
 Test6977726
In-Reply-To: <pyfxVdApSNSisMJieBTl5HSZKDmSSiPie0tnrM_rwe4=.5ffc4e92-cbcf-44d8-9a51-b4e8330e1be9@github.com>
References: <pyfxVdApSNSisMJieBTl5HSZKDmSSiPie0tnrM_rwe4=.5ffc4e92-cbcf-44d8-9a51-b4e8330e1be9@github.com>
Message-ID: <HVay9JHtolaDX4CL98PMAUoHFIXBpomp5fM9yW0_c7s=.bdebcd7c-3a23-440c-af0b-ef02db7a4900@github.com>

On Tue, 19 Mar 2024 01:47:01 GMT, Alisen Chung <achung at openjdk.org> wrote:

> Removing applet usage from manual JColorChooser tests

test/jdk/javax/swing/JColorChooser/Test6977726.java line 42:

> 40:         PassFailJFrame.builder()
> 41:                 .title("Test6977726")
> 42:                 .instructions("Check that there is an empty panel titled \"Preview\" in the JColorChooser.")

Exceeds line column length.

test/jdk/javax/swing/JColorChooser/Test6977726.java line 56:

> 54:         return chooser;
> 55:     }
> 56: }

Line spacing at end is missing.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18369#discussion_r1531788673
PR Review Comment: https://git.openjdk.org/jdk/pull/18369#discussion_r1531793270

From tr at openjdk.org  Wed Mar 20 10:05:21 2024
From: tr at openjdk.org (Tejesh R)
Date: Wed, 20 Mar 2024 10:05:21 GMT
Subject: RFR: 8328328: Convert
 javax/swing/JTabbedPane/4666224/bug4666224.java applet test to main [v2]
In-Reply-To: <ScG-qWrMP0KeWri_B7q-tbQVD8eN9pG-42iIyYP5yRY=.db37c351-db05-4f39-adb3-4594ad945206@github.com>
References: <4fqxbuw6GwuEAg6v7kvn72AQC3LeXPodKf8OrBDOr1w=.1cffa811-37e8-4294-b469-6487763bdeed@github.com>
 <nbGYCc8iRqT0py3apaNvXYjsB7Pwsjr5mufVrTMZeGk=.9041765b-b92c-46b1-b026-d13ea297dd0c@github.com>
 <vvktyzzRFJx_jxmfCOEKzDWP76lP2usDWCouL7a1z34=.e2ff7c51-413b-4ce7-a0ea-76e7def8ebdc@github.com>
 <ScG-qWrMP0KeWri_B7q-tbQVD8eN9pG-42iIyYP5yRY=.db37c351-db05-4f39-adb3-4594ad945206@github.com>
Message-ID: <nUqE_gWOZ2JJJFKl9L5m9R-H0y34tyXCC9mW4jxIjww=.3519792b-6983-4137-aaf7-439718d220fa@github.com>

On Wed, 20 Mar 2024 08:19:29 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> test/jdk/javax/swing/JTabbedPane/bug4666224.java line 54:
>> 
>>> 52:                 ON ALL PLATFORMS
>>> 53:                     1. Click on any of the tabs, focus indicator is visible.
>>> 54:                     2. Lose focus on the window by clicking on some other window.
>> 
>> Lose focus?
>
> Yeah, it means the current focused windows should not be focused.

I was getting confused whether it should be lose or loose in this context?

>> test/jdk/javax/swing/JTabbedPane/bug4666224.java line 132:
>> 
>>> 130:         map.put("bottom", new RotateAction(JTabbedPane.BOTTOM));
>>> 131:         map.put("changeLayout", new ChangeLayoutAction());
>>> 132:         map.put("dump", new DumpAction());
>> 
>> `DumpAction `can also be mentioned in INSTRUCTIONS I guess, since its been used here.
>
> There is no instruction mentioned in old applet test. Kept it as it is.

I guess you can update it since its there in the test, still not mandatory.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18340#discussion_r1531797814
PR Review Comment: https://git.openjdk.org/jdk/pull/18340#discussion_r1531798987

From psadhukhan at openjdk.org  Wed Mar 20 10:18:43 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Wed, 20 Mar 2024 10:18:43 GMT
Subject: RFR: 8328238: Convert few closed manual applet tests to main [v3]
In-Reply-To: <9uKHIdC_4RNWN6ecB8Es2dtAjhmMgTvQIrDMWmPJzfs=.39bb9943-81f5-4cae-8644-a1eaf45d82d6@github.com>
References: <9uKHIdC_4RNWN6ecB8Es2dtAjhmMgTvQIrDMWmPJzfs=.39bb9943-81f5-4cae-8644-a1eaf45d82d6@github.com>
Message-ID: <8vhHRuJd0YGltreMN3r7arqjVGjLrr9MQ1KA_Lp4PVg=.511c21c2-13a8-486c-a06a-53ee02a62f67@github.com>

> Few closed manual applet tests are converted to main based and opensourced

Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:

  spacing

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18390/files
  - new: https://git.openjdk.org/jdk/pull/18390/files/a7ab52c3..74433845

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18390&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18390&range=01-02

  Stats: 2 lines in 2 files changed: 0 ins; 1 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/18390.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18390/head:pull/18390

PR: https://git.openjdk.org/jdk/pull/18390

From psadhukhan at openjdk.org  Wed Mar 20 10:18:44 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Wed, 20 Mar 2024 10:18:44 GMT
Subject: RFR: 8328238: Convert few closed manual applet tests to main [v2]
In-Reply-To: <pLiQ7TJAT4zLmlnGrNp9LfgGsQ9ayMtSx7d8Zu5HmO8=.fe4c1aa3-dc39-4de7-ad41-2bdd9c7b146d@github.com>
References: <9uKHIdC_4RNWN6ecB8Es2dtAjhmMgTvQIrDMWmPJzfs=.39bb9943-81f5-4cae-8644-a1eaf45d82d6@github.com>
 <bZvzPJfAF3Wka4Ksk7aBteZBcmXqvsaZcamgOO7YkGM=.d1ae768e-c6d9-40f6-9375-9a85d3ded436@github.com>
 <pLiQ7TJAT4zLmlnGrNp9LfgGsQ9ayMtSx7d8Zu5HmO8=.fe4c1aa3-dc39-4de7-ad41-2bdd9c7b146d@github.com>
Message-ID: <oFkgb_1CBdd3oGwQHgNKBDje1xVSpBwTFq5FoFLU2Ds=.9cdafd97-f7b9-401e-85b9-e24398302983@github.com>

On Wed, 20 Mar 2024 09:41:39 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Frame title
>
> test/jdk/javax/swing/JFrame/bug4419914.java line 31:
> 
>> 29:  * @build PassFailJFrame
>> 30:  * @run main/manual bug4419914
>> 31: */
> 
> In most of the test which we are converting to main, we are moving the jtreg tags after imports. You are planning to retain it before imports?

yes not mandated yet..till then individual choice..

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18390#discussion_r1531813814

From tr at openjdk.org  Wed Mar 20 10:21:21 2024
From: tr at openjdk.org (Tejesh R)
Date: Wed, 20 Mar 2024 10:21:21 GMT
Subject: RFR: 8328238: Convert few closed manual applet tests to main [v3]
In-Reply-To: <8vhHRuJd0YGltreMN3r7arqjVGjLrr9MQ1KA_Lp4PVg=.511c21c2-13a8-486c-a06a-53ee02a62f67@github.com>
References: <9uKHIdC_4RNWN6ecB8Es2dtAjhmMgTvQIrDMWmPJzfs=.39bb9943-81f5-4cae-8644-a1eaf45d82d6@github.com>
 <8vhHRuJd0YGltreMN3r7arqjVGjLrr9MQ1KA_Lp4PVg=.511c21c2-13a8-486c-a06a-53ee02a62f67@github.com>
Message-ID: <i3FfXs6aoHGDlOzNzv11sE5Et4N5tlRRtRUcgyo24kI=.3a5c8d45-11e0-4059-ae75-091089624cff@github.com>

On Wed, 20 Mar 2024 10:18:43 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Few closed manual applet tests are converted to main based and opensourced
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   spacing

Marked as reviewed by tr (Committer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18390#pullrequestreview-1948458616

From kizune at openjdk.org  Wed Mar 20 13:43:28 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Wed, 20 Mar 2024 13:43:28 GMT
Subject: Integrated: 8328367: Convert java/awt/Component/UpdatingBootTime test
 to main
In-Reply-To: <9gtCIzXrOP-RQJyjhkP8ibENRjEXP9rMUkEbZry4uWc=.2d949d4b-c1ed-45b0-84b9-82859af8a4b0@github.com>
References: <9gtCIzXrOP-RQJyjhkP8ibENRjEXP9rMUkEbZry4uWc=.2d949d4b-c1ed-45b0-84b9-82859af8a4b0@github.com>
Message-ID: <O6fvaOCnkSjfVNfOFtCfY4EShPxU6h4L-hyfPsytIlQ=.b9ffe6f1-1f88-4e02-b92e-58792918c5db@github.com>

On Mon, 18 Mar 2024 17:32:04 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

> Convert test to manual main
> Move test to the Component folder

This pull request has now been integrated.

Changeset: 03c25b15
Author:    Alexander Zuev <kizune at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/03c25b15eb73e594d1329be397cd34e206d2682b
Stats:     363 lines in 3 files changed: 98 ins; 265 del; 0 mod

8328367: Convert java/awt/Component/UpdatingBootTime test to main

Reviewed-by: dnguyen, psadhukhan

-------------

PR: https://git.openjdk.org/jdk/pull/18355

From kizune at openjdk.org  Wed Mar 20 13:48:30 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Wed, 20 Mar 2024 13:48:30 GMT
Subject: Integrated: 8328378: Convert
 java/awt/FileDialog/FileDialogForDirectories test to main
In-Reply-To: <2yId9SKzUfB9ZnRy1Ma_m6jye3Mad5UIx-mxcgcZdZ8=.b71c078f-0a57-4b4c-b1ce-a98d23df0b48@github.com>
References: <2yId9SKzUfB9ZnRy1Ma_m6jye3Mad5UIx-mxcgcZdZ8=.b71c078f-0a57-4b4c-b1ce-a98d23df0b48@github.com>
Message-ID: <Pfy0WIAPGRgrrDxDjQ8YySLU7j5wuM9tEpiBsAaIBQI=.fbd41eee-9276-4d93-ad6d-88dfa1ea3616@github.com>

On Mon, 18 Mar 2024 18:16:08 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

> Convert test to main manual and move to the appropriate folder
> Remove old files

This pull request has now been integrated.

Changeset: e0373e01
Author:    Alexander Zuev <kizune at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/e0373e01fece310d12859207cc5e233f68b7607f
Stats:     219 lines in 3 files changed: 90 ins; 129 del; 0 mod

8328378: Convert java/awt/FileDialog/FileDialogForDirectories test to main

Reviewed-by: psadhukhan

-------------

PR: https://git.openjdk.org/jdk/pull/18358

From kizune at openjdk.org  Wed Mar 20 13:49:47 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Wed, 20 Mar 2024 13:49:47 GMT
Subject: RFR: 8328377: Convert java/awt/Cursor/MultiResolutionCursorTest
 test to main [v4]
In-Reply-To: <Y_DvKb6DvMCmv7RwRVmVh8OoSPikpEmcEbXtpVv9a20=.2809223d-537e-4de3-bb75-986db8154edc@github.com>
References: <Y_DvKb6DvMCmv7RwRVmVh8OoSPikpEmcEbXtpVv9a20=.2809223d-537e-4de3-bb75-986db8154edc@github.com>
Message-ID: <UmJCtTJJM4YVObsfwNxJoWK3KtdfXQDCGql0MYSA_Q4=.1689b8fb-4b18-441b-8722-9fb038060697@github.com>

> Convert test to manual main and move from the dedicated folder
> Remove old files

Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:

  Made colors variable local.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18357/files
  - new: https://git.openjdk.org/jdk/pull/18357/files/ffd314ee..7dd74880

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18357&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18357&range=02-03

  Stats: 2 lines in 1 file changed: 1 ins; 1 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18357.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18357/head:pull/18357

PR: https://git.openjdk.org/jdk/pull/18357

From kizune at openjdk.org  Wed Mar 20 13:49:48 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Wed, 20 Mar 2024 13:49:48 GMT
Subject: Integrated: 8328377: Convert java/awt/Cursor/MultiResolutionCursorTest
 test to main
In-Reply-To: <Y_DvKb6DvMCmv7RwRVmVh8OoSPikpEmcEbXtpVv9a20=.2809223d-537e-4de3-bb75-986db8154edc@github.com>
References: <Y_DvKb6DvMCmv7RwRVmVh8OoSPikpEmcEbXtpVv9a20=.2809223d-537e-4de3-bb75-986db8154edc@github.com>
Message-ID: <As-OOt4pxDlfgkrub3Ht34HsKklsZHHjC0faK9I7u8c=.00464bf9-efd0-4da9-bd7d-9d1703cf93c7@github.com>

On Mon, 18 Mar 2024 17:59:37 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

> Convert test to manual main and move from the dedicated folder
> Remove old files

This pull request has now been integrated.

Changeset: 1b68c731
Author:    Alexander Zuev <kizune at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/1b68c731f2461a2f26e6d967dd3f94e217b4d1f4
Stats:     364 lines in 3 files changed: 99 ins; 265 del; 0 mod

8328377: Convert java/awt/Cursor/MultiResolutionCursorTest test to main

Reviewed-by: psadhukhan

-------------

PR: https://git.openjdk.org/jdk/pull/18357

From kizune at openjdk.org  Wed Mar 20 13:51:28 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Wed, 20 Mar 2024 13:51:28 GMT
Subject: Integrated: 8328386: Convert java/awt/FileDialog/FileNameOverrideTest
 test to main
In-Reply-To: <Yhj0URlGvlalLqkqDnfMrkWbz24Pjab1KZxDHmN4HwA=.7b8b7630-74d0-4114-a650-d6d2afd98075@github.com>
References: <Yhj0URlGvlalLqkqDnfMrkWbz24Pjab1KZxDHmN4HwA=.7b8b7630-74d0-4114-a650-d6d2afd98075@github.com>
Message-ID: <J7rhKzQwkbNrxybg6iuP5zJ08u6ZRzA8KjZmzO2l-EE=.a801d7d2-aac7-4660-b797-b4d362112e9f@github.com>

On Mon, 18 Mar 2024 21:00:36 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

> Convert applet based test to a main based test;
> Move test to an apporpriate location;
> Remove old files;

This pull request has now been integrated.

Changeset: e5e7cd20
Author:    Alexander Zuev <kizune at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/e5e7cd20eca0e5a5f0811d304a9659961dcf11c0
Stats:     246 lines in 3 files changed: 105 ins; 141 del; 0 mod

8328386: Convert java/awt/FileDialog/FileNameOverrideTest test to main

Reviewed-by: azvegint

-------------

PR: https://git.openjdk.org/jdk/pull/18365

From kizune at openjdk.org  Wed Mar 20 15:48:41 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Wed, 20 Mar 2024 15:48:41 GMT
Subject: RFR: 8328384: Convert java/awt/FileDialog/FileDialogOpenDirTest
 test to main [v4]
In-Reply-To: <uRRE9Iw6m8G9T9H0FWEYnUoGgInL7vGgYMPBwP7jEVI=.cb6605a0-f79a-4903-b565-e5dc29d81df2@github.com>
References: <uRRE9Iw6m8G9T9H0FWEYnUoGgInL7vGgYMPBwP7jEVI=.cb6605a0-f79a-4903-b565-e5dc29d81df2@github.com>
Message-ID: <p--yZctibvM9RfAx_Hc5CUSa_YDBH-dofPo_3GRMCFw=.17979032-f2ca-4d28-8ffe-94ba8b10b7a4@github.com>

> Convert test to main manual;
> Move test to appropriate folder;
> Delete old files;

Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:

  Moving test metadata closer to the class definition for better readability;
  Making test automatically skip execution on unsuported toolkit;
  Eliminated the separate frame, moving button inside the PassFailJFrame;
  Corrected test instructions accordingly;

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18361/files
  - new: https://git.openjdk.org/jdk/pull/18361/files/9c9e8fbb..6dd4e7f9

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18361&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18361&range=02-03

  Stats: 31 lines in 1 file changed: 9 ins; 14 del; 8 mod
  Patch: https://git.openjdk.org/jdk/pull/18361.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18361/head:pull/18361

PR: https://git.openjdk.org/jdk/pull/18361

From kizune at openjdk.org  Wed Mar 20 16:07:50 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Wed, 20 Mar 2024 16:07:50 GMT
Subject: RFR: 8328385: Convert java/awt/FileDialog/FileDialogReturnTest
 test to main [v3]
In-Reply-To: <fqHwY3Ipk9ArGTOnM26LF_dxWaQeptZ8Kf9fKNWUPVg=.43700ff8-5123-444a-817d-173bd126368d@github.com>
References: <fqHwY3Ipk9ArGTOnM26LF_dxWaQeptZ8Kf9fKNWUPVg=.43700ff8-5123-444a-817d-173bd126368d@github.com>
Message-ID: <T90iE7Ae6ooEfYfYAlzKM2X_AVQzEOob5CVifMWg604=.6e0aa384-4bd6-4d87-b88d-49bed35a06ee@github.com>

> Convert test to a main method based;
> Move test to an apropriate location;
> Remove old files;

Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:

  Moved test metadate closer to the class definition;
  Made variables local;
  Made test skip execution on an unsupported toolkit;

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18363/files
  - new: https://git.openjdk.org/jdk/pull/18363/files/9c5554f7..132bcbc6

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18363&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18363&range=01-02

  Stats: 32 lines in 1 file changed: 16 ins; 15 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/18363.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18363/head:pull/18363

PR: https://git.openjdk.org/jdk/pull/18363

From dnguyen at openjdk.org  Wed Mar 20 16:19:33 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Wed, 20 Mar 2024 16:19:33 GMT
Subject: RFR: 8328185: Convert
 java/awt/image/MemoryLeakTest/MemoryLeakTest.java applet test to main [v4]
In-Reply-To: <TFYjDmsHDFBm5tcakvQmk_o_3bkZxQmS8FLPZW5bI8Y=.c7bebd2f-13cb-4bae-bd85-64cbff6c17b8@github.com>
References: <TFYjDmsHDFBm5tcakvQmk_o_3bkZxQmS8FLPZW5bI8Y=.c7bebd2f-13cb-4bae-bd85-64cbff6c17b8@github.com>
Message-ID: <cqJx9z6CH6eYIx-O6yUmlZmte0Gkc-Z2fvavF9WlIbo=.0588dcae-59c4-4b32-ab3a-b15ca1a75d6c@github.com>

> Convert java/awt/image/MemoryLeakTest/MemoryLeakTest.java applet test to main using PassFailJFrame

Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:

  Review comments

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18307/files
  - new: https://git.openjdk.org/jdk/pull/18307/files/5155ccfc..44ab8889

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18307&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18307&range=02-03

  Stats: 3 lines in 1 file changed: 1 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/18307.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18307/head:pull/18307

PR: https://git.openjdk.org/jdk/pull/18307

From dnguyen at openjdk.org  Wed Mar 20 16:19:34 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Wed, 20 Mar 2024 16:19:34 GMT
Subject: RFR: 8328185: Convert
 java/awt/image/MemoryLeakTest/MemoryLeakTest.java applet test to main [v3]
In-Reply-To: <4eNSBSTLXFeldurtMbp0bmnLnS19TOUcQygVnCRsVXE=.3fd7d79b-58ba-495a-8017-c16e4c4e303d@github.com>
References: <TFYjDmsHDFBm5tcakvQmk_o_3bkZxQmS8FLPZW5bI8Y=.c7bebd2f-13cb-4bae-bd85-64cbff6c17b8@github.com>
 <VPrElIN7VYUCvc_XgX8HmPz90hc2x-MyPW94iSbF_74=.b74cf677-4ed1-4aa0-97f2-083d8c4d0235@github.com>
 <4eNSBSTLXFeldurtMbp0bmnLnS19TOUcQygVnCRsVXE=.3fd7d79b-58ba-495a-8017-c16e4c4e303d@github.com>
Message-ID: <U1Iy_Ql30YpEbudqMc8pr9jynIEFjvDLLBFnWQ9kR0A=.d9c36546-74e9-4da3-9ef2-f11f347aa280@github.com>

On Tue, 19 Mar 2024 23:36:31 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review changes
>
> test/jdk/java/awt/image/MemoryLeakTest/MemoryLeakTest.java line 27:
> 
>> 25:  * @bug 4078566 6658398
>> 26:  * @library /java/awt/regtesthelpers
>> 27:  * @build PassFailJFrame
> 
> How about we add @requires os.family == "linux" additionally here?

Added

> test/jdk/java/awt/image/MemoryLeakTest/MemoryLeakTest.java line 29:
> 
>> 27:  * @build PassFailJFrame
>> 28:  * @summary Test for a memory leak in Image.
>> 29:  * @run main MemoryLeakTest
> 
> missing manual here

Fixed

> test/jdk/java/awt/image/MemoryLeakTest/MemoryLeakTest.java line 42:
> 
>> 40:     private static final String INSTRUCTIONS =
>> 41:         """
>> 42:          Do the following steps on Solaris only.
> 
> Since the test can be run on Unix platforms, how about including it in the instructions. 
> Suggestion:
> 
>          Do the following steps on Unix platforms.

Fixed

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18307#discussion_r1532394025
PR Review Comment: https://git.openjdk.org/jdk/pull/18307#discussion_r1532393776
PR Review Comment: https://git.openjdk.org/jdk/pull/18307#discussion_r1532393605

From honkar at openjdk.org  Wed Mar 20 16:24:22 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Wed, 20 Mar 2024 16:24:22 GMT
Subject: RFR: 8328185: Convert
 java/awt/image/MemoryLeakTest/MemoryLeakTest.java applet test to main [v4]
In-Reply-To: <cqJx9z6CH6eYIx-O6yUmlZmte0Gkc-Z2fvavF9WlIbo=.0588dcae-59c4-4b32-ab3a-b15ca1a75d6c@github.com>
References: <TFYjDmsHDFBm5tcakvQmk_o_3bkZxQmS8FLPZW5bI8Y=.c7bebd2f-13cb-4bae-bd85-64cbff6c17b8@github.com>
 <cqJx9z6CH6eYIx-O6yUmlZmte0Gkc-Z2fvavF9WlIbo=.0588dcae-59c4-4b32-ab3a-b15ca1a75d6c@github.com>
Message-ID: <zXSQUIxESw4lXVeEryg9_qpMbTYJ20I8LcaLnFcqxss=.c74b052b-b6be-4234-90aa-8d5fd92896c7@github.com>

On Wed, 20 Mar 2024 16:19:33 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

>> Convert java/awt/image/MemoryLeakTest/MemoryLeakTest.java applet test to main using PassFailJFrame
>
> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review comments

Marked as reviewed by honkar (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18307#pullrequestreview-1949412354

From dnguyen at openjdk.org  Wed Mar 20 16:26:39 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Wed, 20 Mar 2024 16:26:39 GMT
Subject: RFR: 8328370: Convert java/awt/print/Dialog/PrintApplet.java
 applet test to main [v3]
In-Reply-To: <Je7yOnjOAjH3DsIgUx72_7ASxsrXS5oIskdKM716AiA=.f1a73b22-8644-40cc-91d6-9ce301f03cc2@github.com>
References: <Je7yOnjOAjH3DsIgUx72_7ASxsrXS5oIskdKM716AiA=.f1a73b22-8644-40cc-91d6-9ce301f03cc2@github.com>
Message-ID: <W6z0LZ1HPa19caIjkQKD-fVGElai98aDMuOkQzfOtvc=.2606585d-acd7-4bf6-a65f-23eeba49aec3@github.com>

> Convert java/awt/print/Dialog/PrintApplet.java applet test to main using PassFailJFrame. Also rename the test to PrintModalDialog.java since this is no longer an applet. Added test instructions related to the linked JBS issue.

Damon Nguyen has updated the pull request incrementally with two additional commits since the last revision:

 - Modify instructions more
 - Modify instructions

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18362/files
  - new: https://git.openjdk.org/jdk/pull/18362/files/bb9d6848..5db0a4af

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18362&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18362&range=01-02

  Stats: 9 lines in 1 file changed: 3 ins; 0 del; 6 mod
  Patch: https://git.openjdk.org/jdk/pull/18362.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18362/head:pull/18362

PR: https://git.openjdk.org/jdk/pull/18362

From dnguyen at openjdk.org  Wed Mar 20 16:26:39 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Wed, 20 Mar 2024 16:26:39 GMT
Subject: RFR: 8328370: Convert java/awt/print/Dialog/PrintApplet.java
 applet test to main [v2]
In-Reply-To: <SbUHgxolpcRf-BtmDfHskdQydu1-PW52RdP5GTPexsA=.9903071d-edfb-49c6-b153-42189736e55c@github.com>
References: <Je7yOnjOAjH3DsIgUx72_7ASxsrXS5oIskdKM716AiA=.f1a73b22-8644-40cc-91d6-9ce301f03cc2@github.com>
 <CJ-3x2r8aFjsN37ZrjKEck2oDssbqdOEJwdLhrcGDlc=.a97dc348-e4e8-45a4-ad67-a0f2e1d2c577@github.com>
 <SbUHgxolpcRf-BtmDfHskdQydu1-PW52RdP5GTPexsA=.9903071d-edfb-49c6-b153-42189736e55c@github.com>
Message-ID: <7rpTnSgUrlQU4Nt_w9_7lK3c8EcaoPjUK5AXL_uFQHQ=.dfce7c36-4087-4265-9028-cc6a8856861a@github.com>

On Tue, 19 Mar 2024 23:04:54 GMT, Phil Race <prr at openjdk.org> wrote:

>> Damon Nguyen has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Remove unused frame
>>  - splitUI addition. Add forceFail
>
> test/jdk/java/awt/print/Dialog/PrintModalDialog.java line 57:
> 
>> 55:              Finish printing or close the dialog. If both dialogs are modal,
>> 56:              PASS the test. Otherwise, FAIL.
>> 57:             """;
> 
> I think we need more instructions - explaining Modal and what to expect.
> "Modal in this case means that it blocks the user from interacting with other windows in the same application
> You may still be able to interact with unrelated applications on the desktop.
> One sure way to test this is to first show the print dialog and then press "Fail", because if you can click on "Fail"
> and have it respond, then the print dialog was not modal. If clicking on it does nothing then cancel the print dialog
> and do the same for the other print dialog.
> If all is well, then press Pass."

Makes sense. Added modal description to instructions as suggested.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18362#discussion_r1532406097

From dnguyen at openjdk.org  Wed Mar 20 16:28:26 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Wed, 20 Mar 2024 16:28:26 GMT
Subject: Integrated: 8328185: Convert
 java/awt/image/MemoryLeakTest/MemoryLeakTest.java applet test to main
In-Reply-To: <TFYjDmsHDFBm5tcakvQmk_o_3bkZxQmS8FLPZW5bI8Y=.c7bebd2f-13cb-4bae-bd85-64cbff6c17b8@github.com>
References: <TFYjDmsHDFBm5tcakvQmk_o_3bkZxQmS8FLPZW5bI8Y=.c7bebd2f-13cb-4bae-bd85-64cbff6c17b8@github.com>
Message-ID: <BlrTiBlx1k3y4BZ6EWC7yo5fzMHgFrDYsu7YAAo94gc=.37882c6b-7bcd-443f-acaa-4fa60a226c8d@github.com>

On Thu, 14 Mar 2024 16:40:56 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

> Convert java/awt/image/MemoryLeakTest/MemoryLeakTest.java applet test to main using PassFailJFrame

This pull request has now been integrated.

Changeset: 4e83f4cf
Author:    Damon Nguyen <dnguyen at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/4e83f4cfc779e39cca0070b5729a508aeaa74654
Stats:     174 lines in 1 file changed: 41 ins; 94 del; 39 mod

8328185: Convert java/awt/image/MemoryLeakTest/MemoryLeakTest.java applet test to main

Reviewed-by: azvegint, honkar

-------------

PR: https://git.openjdk.org/jdk/pull/18307

From dnguyen at openjdk.org  Wed Mar 20 16:34:21 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Wed, 20 Mar 2024 16:34:21 GMT
Subject: RFR: JDK-8328225: Convert ImageDecoratedDnD.html applet test to
 main [v2]
In-Reply-To: <uGayDQcJWPhfRQG08Yvrjts5xy96f-M3ziVfvtrWVPo=.b605ed8b-bdb7-4bf3-bb6c-e3fd0c86b144@github.com>
References: <yHnt-BqOUlo1IKduuk0nv0ZsoReWANI_g4BxukwDzUQ=.24dff5fe-2737-45cc-867e-42f137172363@github.com>
 <uGayDQcJWPhfRQG08Yvrjts5xy96f-M3ziVfvtrWVPo=.b605ed8b-bdb7-4bf3-bb6c-e3fd0c86b144@github.com>
Message-ID: <t3FrADZpRU12Pg-xFFbasGgSJ_I_7yaPwnhwuZ26GKY=.bc58e5c4-d006-4610-a635-359e02d4f73e@github.com>

On Tue, 19 Mar 2024 21:07:44 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Following test is converted to main using PassFailJFrame.
>
> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   instructions updated

Do we need to add any instructions regarding the blue "empty" boxes that appear?

test/jdk/java/awt/dnd/ImageDecoratedDnD/ImageDecoratedDnD.java line 53:

> 51:                 On the systems that supports pictured drag, the image under the drag-cursor
> 52:                 should appear.
> 53:                 "Image under drag-cursor" is a translucent blue rectangle + red circle

Suggestion:

                On the systems that supports pictured drag, the image under the 
                drag-cursor should appear.
                "Image under drag-cursor" is a translucent blue rectangle + red circle


In the instructions window, there's an extra newline due to exceeding the character limit per line.

-------------

Changes requested by dnguyen (Committer).

PR Review: https://git.openjdk.org/jdk/pull/18315#pullrequestreview-1949433569
PR Review Comment: https://git.openjdk.org/jdk/pull/18315#discussion_r1532417383

From aivanov at openjdk.org  Wed Mar 20 16:38:23 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Wed, 20 Mar 2024 16:38:23 GMT
Subject: RFR: 8328238: Convert few closed manual applet tests to main [v3]
In-Reply-To: <8vhHRuJd0YGltreMN3r7arqjVGjLrr9MQ1KA_Lp4PVg=.511c21c2-13a8-486c-a06a-53ee02a62f67@github.com>
References: <9uKHIdC_4RNWN6ecB8Es2dtAjhmMgTvQIrDMWmPJzfs=.39bb9943-81f5-4cae-8644-a1eaf45d82d6@github.com>
 <8vhHRuJd0YGltreMN3r7arqjVGjLrr9MQ1KA_Lp4PVg=.511c21c2-13a8-486c-a06a-53ee02a62f67@github.com>
Message-ID: <yxiuYfOOXyTbFY_oVXOsgtHL-hn86a9Njod5fjnDgqo=.b39323a2-dd22-4151-9abe-f4e94c221d5c@github.com>

On Wed, 20 Mar 2024 10:18:43 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Few closed manual applet tests are converted to main based and opensourced
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   spacing

Changes requested by aivanov (Reviewer).

test/jdk/javax/swing/JFrame/bug4419914.java line 71:

> 69:         frame.enableInputMethods(false);
> 70:         frame.getContentPane().setComponentOrientation(ComponentOrientation.RIGHT_TO_LEFT);
> 71:         frame.getContentPane().setLocale(new Locale("en"));

Suggestion:

        frame.getContentPane().setLocale(Locale.ENGLISH);

test/jdk/javax/swing/text/PaintTest.java line 83:

> 81:                     if (getFont() != null) {
> 82:                         size.height += getFontMetrics(getFont()).
> 83:                                        getHeight() / 2;

Suggestion:

                        size.height += getFontMetrics(getFont())
                                       .getHeight() / 2;

Wrap the `.` operator to the next line.

test/jdk/javax/swing/text/html/StyleSheet/bug4803145.java line 81:

> 79:         jep.setText(text);
> 80: 
> 81:         f.setSize(500,500);

Suggestion:

        f.setSize(500, 500);

-------------

PR Review: https://git.openjdk.org/jdk/pull/18390#pullrequestreview-1949432377
PR Review Comment: https://git.openjdk.org/jdk/pull/18390#discussion_r1532416576
PR Review Comment: https://git.openjdk.org/jdk/pull/18390#discussion_r1532422176
PR Review Comment: https://git.openjdk.org/jdk/pull/18390#discussion_r1532425463

From honkar at openjdk.org  Wed Mar 20 16:43:45 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Wed, 20 Mar 2024 16:43:45 GMT
Subject: RFR: JDK-8328398 : Convert java/awt/im/4490692/bug4490692.html applet
 test to main
Message-ID: <lcESN0hyfRYfuC2nnzmBSQrUQLmHHD6uooae53vTzWA=.682e9e1e-d3cb-4b2e-bc95-9bdd9d709f6f@github.com>

Following test is converted from applet to main using PassFailJFrame.

The original test had ignore tag - **The fix for this problem was backed out for 5057184.  Remove this "ignore" tag when it is fixed again.**
I believe this was fixed and the test works correctly on Linux platforms, hence ignore tag has been removed.

This is a semi-automated test, the first check is manual and the 2nd one is automated. Details in the test instructions.

-------------

Commit messages:
 - delete html file
 - instructions updated
 - test changes
 - test file moved

Changes: https://git.openjdk.org/jdk/pull/18402/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18402&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8328398
  Stats: 241 lines in 3 files changed: 110 ins; 131 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18402.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18402/head:pull/18402

PR: https://git.openjdk.org/jdk/pull/18402

From honkar at openjdk.org  Wed Mar 20 16:45:24 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Wed, 20 Mar 2024 16:45:24 GMT
Subject: RFR: JDK-8328225: Convert ImageDecoratedDnD.html applet test to
 main [v2]
In-Reply-To: <t3FrADZpRU12Pg-xFFbasGgSJ_I_7yaPwnhwuZ26GKY=.bc58e5c4-d006-4610-a635-359e02d4f73e@github.com>
References: <yHnt-BqOUlo1IKduuk0nv0ZsoReWANI_g4BxukwDzUQ=.24dff5fe-2737-45cc-867e-42f137172363@github.com>
 <uGayDQcJWPhfRQG08Yvrjts5xy96f-M3ziVfvtrWVPo=.b605ed8b-bdb7-4bf3-bb6c-e3fd0c86b144@github.com>
 <t3FrADZpRU12Pg-xFFbasGgSJ_I_7yaPwnhwuZ26GKY=.bc58e5c4-d006-4610-a635-359e02d4f73e@github.com>
Message-ID: <ESwkqqHwE5NV72iaybNmguAWCXEXmXFijMYw_2q8nfs=.b7b03d3b-9c84-4f56-a3dc-53f45cddbbee@github.com>

On Wed, 20 Mar 2024 16:31:32 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

> Do we need to add any instructions regarding the blue "empty" boxes that appear?

Since we are checking the second case i.e CTRL + Mouse Drag, the empty boxes don't appear hence I skipped it.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18315#issuecomment-2010025314

From psadhukhan at openjdk.org  Wed Mar 20 16:46:45 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Wed, 20 Mar 2024 16:46:45 GMT
Subject: RFR: 8328238: Convert few closed manual applet tests to main [v4]
In-Reply-To: <9uKHIdC_4RNWN6ecB8Es2dtAjhmMgTvQIrDMWmPJzfs=.39bb9943-81f5-4cae-8644-a1eaf45d82d6@github.com>
References: <9uKHIdC_4RNWN6ecB8Es2dtAjhmMgTvQIrDMWmPJzfs=.39bb9943-81f5-4cae-8644-a1eaf45d82d6@github.com>
Message-ID: <0-d5jlP4-aMbgEE1MS9GuMonUlQ09R9SOy_efIHLSsA=.754d7aac-e39d-4da7-9e26-7a1f8d081325@github.com>

> Few closed manual applet tests are converted to main based and opensourced

Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:

  REview update

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18390/files
  - new: https://git.openjdk.org/jdk/pull/18390/files/74433845..bac1ecb3

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18390&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18390&range=02-03

  Stats: 4 lines in 3 files changed: 0 ins; 0 del; 4 mod
  Patch: https://git.openjdk.org/jdk/pull/18390.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18390/head:pull/18390

PR: https://git.openjdk.org/jdk/pull/18390

From dnguyen at openjdk.org  Wed Mar 20 16:51:45 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Wed, 20 Mar 2024 16:51:45 GMT
Subject: RFR: 8328558: Convert javax/swing/JCheckBox/8032667/bug8032667.java
 applet test to main
Message-ID: <g745t9uMBoROVg83p-3Hkv9s_BjHREVBFnSBVRBT5s4=.9865582b-5db3-4073-97dd-21625ba72991@github.com>

Convert javax/swing/JCheckBox/8032667/bug8032667.java applet test to main using PassFailJFrame

-------------

Commit messages:
 - Add test in new location
 - Initial test conversion

Changes: https://git.openjdk.org/jdk/pull/18403/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18403&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8328558
  Stats: 350 lines in 4 files changed: 107 ins; 243 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18403.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18403/head:pull/18403

PR: https://git.openjdk.org/jdk/pull/18403

From honkar at openjdk.org  Wed Mar 20 16:59:47 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Wed, 20 Mar 2024 16:59:47 GMT
Subject: RFR: JDK-8328398 : Convert java/awt/im/4490692/bug4490692.html
 applet test to main [v2]
In-Reply-To: <lcESN0hyfRYfuC2nnzmBSQrUQLmHHD6uooae53vTzWA=.682e9e1e-d3cb-4b2e-bc95-9bdd9d709f6f@github.com>
References: <lcESN0hyfRYfuC2nnzmBSQrUQLmHHD6uooae53vTzWA=.682e9e1e-d3cb-4b2e-bc95-9bdd9d709f6f@github.com>
Message-ID: <aS6ATocsIxgP1ABKQTve2waCy-MeH92snBcEZJftr9s=.24f93a07-f2b6-4608-9785-53b0399fcd03@github.com>

> Following test is converted from applet to main using PassFailJFrame.
> 
> The original test had ignore tag - **The fix for this problem was backed out for 5057184.  Remove this "ignore" tag when it is fixed again.**
> I believe this was fixed and the test works correctly on Linux platforms, hence ignore tag has been removed.
> 
> This is a semi-automated test, the first check is manual and the 2nd one is automated. Details in the test instructions.

Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:

  instruction line length

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18402/files
  - new: https://git.openjdk.org/jdk/pull/18402/files/e1fdb064..3dcb944c

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18402&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18402&range=00-01

  Stats: 20 lines in 1 file changed: 2 ins; 0 del; 18 mod
  Patch: https://git.openjdk.org/jdk/pull/18402.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18402/head:pull/18402

PR: https://git.openjdk.org/jdk/pull/18402

From aivanov at openjdk.org  Wed Mar 20 17:00:22 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Wed, 20 Mar 2024 17:00:22 GMT
Subject: RFR: JDK-8328190 : Convert AWTPanelSmoothWheel.html applet test to
 main [v4]
In-Reply-To: <uLSpcviVXqraUZeDbvH3walaOGIGg1iCGcz8AMDv2oA=.e805c1f3-14b5-4855-9399-ef9693c8b11d@github.com>
References: <sn9qb9ctS_sr3isHbwcbMCYh2RQokz2ptsw0rGBRnJY=.955d7549-72c7-4a4f-8ac8-a5d6f122cf68@github.com>
 <p8toDCsUN5dAL4dDyYVndsUESgStV4k9kaORTsC30T0=.1bb5f251-baa8-4eb9-9edf-7a01bb004824@github.com>
 <nLixT1Ds_Q4bojPE3dVPNJsP7npWOCXTeQnXjuNBjDI=.3e97d089-79b2-411b-9481-bf3c5a05bdca@github.com>
 <uLSpcviVXqraUZeDbvH3walaOGIGg1iCGcz8AMDv2oA=.e805c1f3-14b5-4855-9399-ef9693c8b11d@github.com>
Message-ID: <85j81nCQpt1zZUA7YK2kk8s86L1ZqLhs406hVKcWsMw=.51d17fec-616e-4a25-9f79-dfcc449f7896@github.com>

On Tue, 19 Mar 2024 20:39:07 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> test/jdk/java/awt/event/MouseEvent/AWTPanelSmoothWheel.java line 49:
>> 
>>> 47:             below the instruction window.
>>> 48:             Please make sure that some of the messages have non-zero 'wheelRotation' value,
>>> 49:             and also check if the test works OK if the mouse wheel is rotated very slow.
>> 
>> Shall we increase the width of the instruction window so that less horizontal scrolling is needed?
>> 
>> The test can actually verify the condition without help from the user. The handler for `MouseWheelListener` could well look into the `MouseWheelEvent` and verify _automatically_ if `scrollType=WHEEL_UNIT_SCROLL` and there are any events with `wheelRotation=1` (or rather `wheelRotation!=0`).
>> 
>> You can even `forcePass` the test as soon as you detected few events which satisfy the condition.
>> 
>> If you don't see events with `scrollType=WHEEL_UNIT_SCROLL`, then the mouse doesn't support high-resolution scrolling.
>
> @aivanov-jdk Semi-automated the test, it now passes when 5 or more  MouseWheelEvent of type: scrollType=WHEEL_UNIT_SCROLL & wheelRotation != 0 is recorded. Updated the instructions accordingly.

I think we should update the instructions.

A high resolution mouse produces events like this:

java.awt.event.MouseWheelEvent[MOUSE_WHEEL,(164,90),absolute(1135,365),button=0,clickCount=0,scrollType=WHEEL_UNIT_SCROLL,scrollAmount=3,wheelRotation=0,preciseWheelRotation=0.25] on panel0
java.awt.event.MouseWheelEvent[MOUSE_WHEEL,(164,90),absolute(1135,365),button=0,clickCount=0,scrollType=WHEEL_UNIT_SCROLL,scrollAmount=3,wheelRotation=0,preciseWheelRotation=0.25] on panel0
java.awt.event.MouseWheelEvent[MOUSE_WHEEL,(164,90),absolute(1135,365),button=0,clickCount=0,scrollType=WHEEL_UNIT_SCROLL,scrollAmount=3,wheelRotation=0,preciseWheelRotation=0.25] on panel0
java.awt.event.MouseWheelEvent[MOUSE_WHEEL,(133,46),absolute(1104,321),button=0,clickCount=0,scrollType=WHEEL_UNIT_SCROLL,scrollAmount=3,wheelRotation=1,preciseWheelRotation=1.0] on panel0


Thus, `wheelRotation=0` while `preciseWheelRotation=0.25`. When it reaches, `preciseWheelRotation=1.0`, the event contains **`wheelRotation=1`**.

A regular mouse with mouse-wheel notches produces the following events:

java.awt.event.MouseWheelEvent[MOUSE_WHEEL,(90,115),absolute(1061,390),button=0,clickCount=0,scrollType=WHEEL_UNIT_SCROLL,scrollAmount=3,wheelRotation=1,preciseWheelRotation=1.0] on panel0
java.awt.event.MouseWheelEvent[MOUSE_WHEEL,(176,76),absolute(1147,351),button=0,clickCount=0,scrollType=WHEEL_UNIT_SCROLL,scrollAmount=3,wheelRotation=1,preciseWheelRotation=1.0] on panel0


As you can see, `scrollType=WHEEL_UNIT_SCROLL` is the same in both cases. The only difference is that high-resolution mouse produces events where **`preciseWheelRotation < 1.0`**.

This means that you should also track the value of `preciseWheelRotation`. Otherwise, the test will pass when a regular mouse is used.

You may show a warning to the user if you detect, let's say, 5 events with `wheelRotation=1` but none of the events had `wheelRotation=0` and `preciseWheelRotation < 1.0`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18312#discussion_r1532468459

From prr at openjdk.org  Wed Mar 20 17:04:36 2024
From: prr at openjdk.org (Phil Race)
Date: Wed, 20 Mar 2024 17:04:36 GMT
Subject: RFR: 8328300: Convert PrintDialogsTest.java from Applet to main
 program [v2]
In-Reply-To: <awEafcUuB7m-r62HTUPpL9DsuGnRuT1czVoirtsYJRI=.725d3d5f-04f9-4012-bcc3-a8e7d157f07f@github.com>
References: <awEafcUuB7m-r62HTUPpL9DsuGnRuT1czVoirtsYJRI=.725d3d5f-04f9-4012-bcc3-a8e7d157f07f@github.com>
Message-ID: <hmeI4ZUqeT3y10WzRlf20EaBNUi_r3bKGO4RhNSeCBM=.e720538f-1d3c-4ebf-ac39-06fbed36b893@github.com>

> This applet test is converted to a main program using PassFailJFrame.
> Other than that, the main thing I improved is the instructions.

Phil Race has updated the pull request incrementally with one additional commit since the last revision:

  8328300

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18333/files
  - new: https://git.openjdk.org/jdk/pull/18333/files/c9d56f03..8458a1aa

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18333&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18333&range=00-01

  Stats: 6 lines in 1 file changed: 4 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/18333.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18333/head:pull/18333

PR: https://git.openjdk.org/jdk/pull/18333

From prr at openjdk.org  Wed Mar 20 17:04:36 2024
From: prr at openjdk.org (Phil Race)
Date: Wed, 20 Mar 2024 17:04:36 GMT
Subject: RFR: 8328300: Convert PrintDialogsTest.java from Applet to main
 program
In-Reply-To: <awEafcUuB7m-r62HTUPpL9DsuGnRuT1czVoirtsYJRI=.725d3d5f-04f9-4012-bcc3-a8e7d157f07f@github.com>
References: <awEafcUuB7m-r62HTUPpL9DsuGnRuT1czVoirtsYJRI=.725d3d5f-04f9-4012-bcc3-a8e7d157f07f@github.com>
Message-ID: <JQnLEr7VBHnDzWxzea8ZkLm2yN34fZ3CLY-scxoZrtY=.a255ba65-1fe0-412c-ab4e-5fc4ec65c903@github.com>

On Fri, 15 Mar 2024 21:20:04 GMT, Phil Race <prr at openjdk.org> wrote:

> This applet test is converted to a main program using PassFailJFrame.
> Other than that, the main thing I improved is the instructions.

I added empty labels as spacing

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18333#issuecomment-2010069676

From aivanov at openjdk.org  Wed Mar 20 17:12:21 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Wed, 20 Mar 2024 17:12:21 GMT
Subject: RFR: 8328238: Convert few closed manual applet tests to main [v4]
In-Reply-To: <0-d5jlP4-aMbgEE1MS9GuMonUlQ09R9SOy_efIHLSsA=.754d7aac-e39d-4da7-9e26-7a1f8d081325@github.com>
References: <9uKHIdC_4RNWN6ecB8Es2dtAjhmMgTvQIrDMWmPJzfs=.39bb9943-81f5-4cae-8644-a1eaf45d82d6@github.com>
 <0-d5jlP4-aMbgEE1MS9GuMonUlQ09R9SOy_efIHLSsA=.754d7aac-e39d-4da7-9e26-7a1f8d081325@github.com>
Message-ID: <yBsxtlnYTriiHUti2u41j9rGo2kJb3K7W1drhpFfTW4=.f2f36782-b8e3-4c67-ab39-e77b2937cbf1@github.com>

On Wed, 20 Mar 2024 16:46:45 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Few closed manual applet tests are converted to main based and opensourced
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   REview update

Marked as reviewed by aivanov (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18390#pullrequestreview-1949549703

From dnguyen at openjdk.org  Wed Mar 20 17:13:21 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Wed, 20 Mar 2024 17:13:21 GMT
Subject: RFR: 8328300: Convert PrintDialogsTest.java from Applet to main
 program [v2]
In-Reply-To: <hmeI4ZUqeT3y10WzRlf20EaBNUi_r3bKGO4RhNSeCBM=.e720538f-1d3c-4ebf-ac39-06fbed36b893@github.com>
References: <awEafcUuB7m-r62HTUPpL9DsuGnRuT1czVoirtsYJRI=.725d3d5f-04f9-4012-bcc3-a8e7d157f07f@github.com>
 <hmeI4ZUqeT3y10WzRlf20EaBNUi_r3bKGO4RhNSeCBM=.e720538f-1d3c-4ebf-ac39-06fbed36b893@github.com>
Message-ID: <tjM0uOP09tmt6HDHE76iT6SlKFmweCxCL40s3j7A_-Y=.28079d22-89c6-4267-bcc8-d88364a16c03@github.com>

On Wed, 20 Mar 2024 17:04:36 GMT, Phil Race <prr at openjdk.org> wrote:

>> This applet test is converted to a main program using PassFailJFrame.
>> Other than that, the main thing I improved is the instructions.
>
> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8328300

Marked as reviewed by dnguyen (Committer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18333#pullrequestreview-1949554083

From honkar at openjdk.org  Wed Mar 20 17:13:34 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Wed, 20 Mar 2024 17:13:34 GMT
Subject: RFR: JDK-8328225: Convert ImageDecoratedDnD.html applet test to
 main [v3]
In-Reply-To: <yHnt-BqOUlo1IKduuk0nv0ZsoReWANI_g4BxukwDzUQ=.24dff5fe-2737-45cc-867e-42f137172363@github.com>
References: <yHnt-BqOUlo1IKduuk0nv0ZsoReWANI_g4BxukwDzUQ=.24dff5fe-2737-45cc-867e-42f137172363@github.com>
Message-ID: <9BcQwKYpNGUpK8-qEkf7cCcpQPLQB1ZWXc7oGiLUDVg=.623e63f7-5c26-4b18-8867-5aa7a2b157d8@github.com>

> Following test is converted to main using PassFailJFrame.

Harshitha Onkar has updated the pull request incrementally with two additional commits since the last revision:

 - minor fix
 - instruction line-lengths

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18315/files
  - new: https://git.openjdk.org/jdk/pull/18315/files/8ec60632..7e35e23d

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18315&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18315&range=01-02

  Stats: 14 lines in 1 file changed: 1 ins; 0 del; 13 mod
  Patch: https://git.openjdk.org/jdk/pull/18315.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18315/head:pull/18315

PR: https://git.openjdk.org/jdk/pull/18315

From aivanov at openjdk.org  Wed Mar 20 17:13:34 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Wed, 20 Mar 2024 17:13:34 GMT
Subject: RFR: JDK-8328225: Convert ImageDecoratedDnD.html applet test to
 main [v2]
In-Reply-To: <uGayDQcJWPhfRQG08Yvrjts5xy96f-M3ziVfvtrWVPo=.b605ed8b-bdb7-4bf3-bb6c-e3fd0c86b144@github.com>
References: <yHnt-BqOUlo1IKduuk0nv0ZsoReWANI_g4BxukwDzUQ=.24dff5fe-2737-45cc-867e-42f137172363@github.com>
 <uGayDQcJWPhfRQG08Yvrjts5xy96f-M3ziVfvtrWVPo=.b605ed8b-bdb7-4bf3-bb6c-e3fd0c86b144@github.com>
Message-ID: <8RCbCOaEQlmsCWcT9Oo60Jxm7cK5Lr8aYizCYQorW-I=.2c7279bd-02ef-4f6f-8c72-3e21a8f82f32@github.com>

On Tue, 19 Mar 2024 21:07:44 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Following test is converted to main using PassFailJFrame.
>
> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   instructions updated

Changes requested by aivanov (Reviewer).

test/jdk/java/awt/dnd/ImageDecoratedDnD/ImageDecoratedDnD.java line 46:

> 44: 
> 45:             1. Click on the button and drag to the red panel by pressing
> 46:                the "CTRL" key on the keyboard.

Suggestion:

            1. Click on the button and drag it to the red panel while holding
               the "CTRL" key on the keyboard.

test/jdk/java/awt/dnd/ImageDecoratedDnD/ImageDecoratedDnD.java line 59:

> 57:                 On Windows system the image under cursor would be visible ONLY over
> 58:                 the drop targets with activated extended OLE D'n'D support (that are,
> 59:                 the desktop and IE).

Suggestion:

                On Windows, the image under the cursor would be visible ONLY over
                drop targets with activated extended D'n'D support. It means the image
                may not be displayed when dragging over some windows, it is not error. The
                image should be display when dragging over the red/yellow panel.

Let's clarify the instructions a bit.

test/jdk/java/awt/dnd/ImageDecoratedDnD/ImageDecoratedDnD.java line 65:

> 63:                 The panel should turn red again and a yellow button labeled ,
> 64:                 "Drag ME!" should appear inside the panel. You should be able,
> 65:                 to repeat this operation multiple times.

Suggestion:

                The panel should turn red again and a yellow button labeled
                "Drag ME!" should appear inside the panel. You should be able
                to repeat this operation multiple times.

No comma here.

-------------

PR Review: https://git.openjdk.org/jdk/pull/18315#pullrequestreview-1949533848
PR Review Comment: https://git.openjdk.org/jdk/pull/18315#discussion_r1532478358
PR Review Comment: https://git.openjdk.org/jdk/pull/18315#discussion_r1532484264
PR Review Comment: https://git.openjdk.org/jdk/pull/18315#discussion_r1532486266

From dnguyen at openjdk.org  Wed Mar 20 17:13:34 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Wed, 20 Mar 2024 17:13:34 GMT
Subject: RFR: JDK-8328225: Convert ImageDecoratedDnD.html applet test to
 main [v3]
In-Reply-To: <9BcQwKYpNGUpK8-qEkf7cCcpQPLQB1ZWXc7oGiLUDVg=.623e63f7-5c26-4b18-8867-5aa7a2b157d8@github.com>
References: <yHnt-BqOUlo1IKduuk0nv0ZsoReWANI_g4BxukwDzUQ=.24dff5fe-2737-45cc-867e-42f137172363@github.com>
 <9BcQwKYpNGUpK8-qEkf7cCcpQPLQB1ZWXc7oGiLUDVg=.623e63f7-5c26-4b18-8867-5aa7a2b157d8@github.com>
Message-ID: <B_DmSVudh0zbl-xIVVNuPvwFuHh_BHPFo5rlWSfYAuQ=.ced0020f-e0ed-4524-b9e3-0234b258ac23@github.com>

On Wed, 20 Mar 2024 17:10:54 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Following test is converted to main using PassFailJFrame.
>
> Harshitha Onkar has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - minor fix
>  - instruction line-lengths

Makes sense. Confirmed OK with CTRL.

-------------

Marked as reviewed by dnguyen (Committer).

PR Review: https://git.openjdk.org/jdk/pull/18315#pullrequestreview-1949549383

From abhiscxk at openjdk.org  Wed Mar 20 17:25:19 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Wed, 20 Mar 2024 17:25:19 GMT
Subject: RFR: 8328328: Convert
 javax/swing/JTabbedPane/4666224/bug4666224.java applet test to main [v2]
In-Reply-To: <nUqE_gWOZ2JJJFKl9L5m9R-H0y34tyXCC9mW4jxIjww=.3519792b-6983-4137-aaf7-439718d220fa@github.com>
References: <4fqxbuw6GwuEAg6v7kvn72AQC3LeXPodKf8OrBDOr1w=.1cffa811-37e8-4294-b469-6487763bdeed@github.com>
 <nbGYCc8iRqT0py3apaNvXYjsB7Pwsjr5mufVrTMZeGk=.9041765b-b92c-46b1-b026-d13ea297dd0c@github.com>
 <vvktyzzRFJx_jxmfCOEKzDWP76lP2usDWCouL7a1z34=.e2ff7c51-413b-4ce7-a0ea-76e7def8ebdc@github.com>
 <ScG-qWrMP0KeWri_B7q-tbQVD8eN9pG-42iIyYP5yRY=.db37c351-db05-4f39-adb3-4594ad945206@github.com>
 <nUqE_gWOZ2JJJFKl9L5m9R-H0y34tyXCC9mW4jxIjww=.3519792b-6983-4137-aaf7-439718d220fa@github.com>
Message-ID: <fBYU4sdQ0htagbCIOQJDzdCBqpAxTnp-Do5Dhumzh48=.b078bc03-8760-4cba-a437-a86c1ad7bdce@github.com>

On Wed, 20 Mar 2024 10:01:59 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Yeah, it means the current focused windows should not be focused.
>
> I was getting confused whether it should be lose or loose in this context?

I think `Lose` is ok.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18340#discussion_r1532508275

From dnguyen at openjdk.org  Wed Mar 20 17:26:21 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Wed, 20 Mar 2024 17:26:21 GMT
Subject: RFR: 8328385: Convert java/awt/FileDialog/FileDialogReturnTest
 test to main [v3]
In-Reply-To: <T90iE7Ae6ooEfYfYAlzKM2X_AVQzEOob5CVifMWg604=.6e0aa384-4bd6-4d87-b88d-49bed35a06ee@github.com>
References: <fqHwY3Ipk9ArGTOnM26LF_dxWaQeptZ8Kf9fKNWUPVg=.43700ff8-5123-444a-817d-173bd126368d@github.com>
 <T90iE7Ae6ooEfYfYAlzKM2X_AVQzEOob5CVifMWg604=.6e0aa384-4bd6-4d87-b88d-49bed35a06ee@github.com>
Message-ID: <fHBimJjg3-VdF5g2mYAdBeFbIvlZd5LW1sYQGs7JQTs=.3bf65dd2-ed0f-4cf9-b82a-b6b26f5fb139@github.com>

On Wed, 20 Mar 2024 16:07:50 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

>> Convert test to a main method based;
>> Move test to an apropriate location;
>> Remove old files;
>
> Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Moved test metadate closer to the class definition;
>   Made variables local;
>   Made test skip execution on an unsupported toolkit;

Changes requested by dnguyen (Committer).

test/jdk/java/awt/FileDialog/FileDialogReturnTest.java line 46:

> 44:  * @library /test/lib
> 45:  * @build PassFailJFrame
> 46:  * @build jtreg.SkippedException

Suggestion:

 * @library /java/awt/regtesthelpers /test/lib
 * @build PassFailJFrame jtreg.SkippedException


Not positive if this is correct, but I was able to combine the `@library` and `@build` on one line by adding a space between the two.

test/jdk/java/awt/FileDialog/FileDialogReturnTest.java line 47:

> 45:  * @build PassFailJFrame
> 46:  * @build jtreg.SkippedException
> 47:  * @run main/manual FileDialogReturnTest.html

This still runs on the `.html` file. Does this run correctly for you when testing?

-------------

PR Review: https://git.openjdk.org/jdk/pull/18363#pullrequestreview-1949578878
PR Review Comment: https://git.openjdk.org/jdk/pull/18363#discussion_r1532505591
PR Review Comment: https://git.openjdk.org/jdk/pull/18363#discussion_r1532509430

From prr at openjdk.org  Wed Mar 20 17:27:44 2024
From: prr at openjdk.org (Phil Race)
Date: Wed, 20 Mar 2024 17:27:44 GMT
Subject: RFR: 8328560:
 java/awt/event/MouseEvent/ClickDuringKeypress/ClickDuringKeypress.java imports
 Applet [v2]
In-Reply-To: <DAGMk9laOuahpyUEepWDE92N94zIbgNOWgaIgQFIurs=.602f3b0a-e0dd-49ee-9075-12961ef49611@github.com>
References: <DAGMk9laOuahpyUEepWDE92N94zIbgNOWgaIgQFIurs=.602f3b0a-e0dd-49ee-9075-12961ef49611@github.com>
Message-ID: <EgH0oqhWRvMvp4722bi9RuDySczRTfnGgHi6SG0AFYw=.3bc36f84-d000-47e4-aeeb-01f33393ffd7@github.com>

> This seems to have been some previous not very complete conversion of a test from applet to main.
> It even still had Applet imported and miscellaneous comments. I've cleaned it up.

Phil Race has updated the pull request incrementally with one additional commit since the last revision:

  8328560

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18386/files
  - new: https://git.openjdk.org/jdk/pull/18386/files/5f9e257c..f4f4c335

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18386&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18386&range=00-01

  Stats: 40 lines in 1 file changed: 11 ins; 21 del; 8 mod
  Patch: https://git.openjdk.org/jdk/pull/18386.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18386/head:pull/18386

PR: https://git.openjdk.org/jdk/pull/18386

From prr at openjdk.org  Wed Mar 20 17:27:45 2024
From: prr at openjdk.org (Phil Race)
Date: Wed, 20 Mar 2024 17:27:45 GMT
Subject: RFR: 8328560:
 java/awt/event/MouseEvent/ClickDuringKeypress/ClickDuringKeypress.java imports
 Applet [v2]
In-Reply-To: <fcqyLn_-sCXQmRz71ts6W-v3HzFxxtPQ1z9C03eEVs0=.0b8164d3-736f-4299-b088-2d01392e05e1@github.com>
References: <DAGMk9laOuahpyUEepWDE92N94zIbgNOWgaIgQFIurs=.602f3b0a-e0dd-49ee-9075-12961ef49611@github.com>
 <fcqyLn_-sCXQmRz71ts6W-v3HzFxxtPQ1z9C03eEVs0=.0b8164d3-736f-4299-b088-2d01392e05e1@github.com>
Message-ID: <1-FT5fa2Hcl7l-jGF4ahsi8PpkhbWCX3OnGtw1k-Jkg=.e9fbf6a5-1773-48c9-942e-00b3a26a753e@github.com>

On Wed, 20 Mar 2024 00:32:17 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8328560
>
> test/jdk/java/awt/event/MouseEvent/ClickDuringKeypress/ClickDuringKeypress.java line 25:
> 
>> 23: 
>> 24: /*
>> 25:   @test 1.2 98/08/05
> 
> Now we don't have `@test` at all.

oops, fixed

> test/jdk/java/awt/event/MouseEvent/ClickDuringKeypress/ClickDuringKeypress.java line 29:
> 
>> 27:   @summary Tests that clicking mouse and pressing keys generates correct amount of click-counts
>> 28:   @run main ClickDuringKeypress
>> 29: */
> 
> We usually move this block just before a class declaration, for better readability.

ok

> test/jdk/java/awt/event/MouseEvent/ClickDuringKeypress/ClickDuringKeypress.java line 53:
> 
>> 51:    static volatile Frame frame;
>> 52:    static volatile Robot robot;
>> 53:    static volatile ClickDuringKeypress clicker;
> 
> Suggestion:
> 
>    static final ClickDuringKeypress clicker = new ClickDuringKeypress();
> 
> `clicker` can be made final

ok

> test/jdk/java/awt/event/MouseEvent/ClickDuringKeypress/ClickDuringKeypress.java line 61:
> 
>> 59:            robot = new Robot();
>> 60:            robot.mouseMove(200, 200);
>> 61:            EventQueue.invokeAndWait(frame::show);
> 
> Suggestion:
> 
>            EventQueue.invokeAndWait(() -> frame.setVisible(true));
> 
> 
> `show` is deprecated.

yeah I know, I changed this as you suggested but
(1) I like the :: syntax, (2) I never thought it was necessary to deprecate show()

> test/jdk/java/awt/event/MouseEvent/ClickDuringKeypress/ClickDuringKeypress.java line 96:
> 
>> 94:                throw new RuntimeException("Not Activated. Test fails");
>> 95:            }
>> 96:       }
> 
> Do we really need this synchronization?
> Shouldn't the standard 
> 
> robot.waitForIdle();
> robot.delay(1000);
> 
> be enough?

OK .. changed .. but I'm now a long way from removing an un-used import as a lot of this test is now quite different than before.

> test/jdk/java/awt/event/MouseEvent/ClickDuringKeypress/ClickDuringKeypress.java line 111:
> 
>> 109:       for (int i = 0; i < CLICKCOUNT / 2; i++) {
>> 110:         robot.mousePress(InputEvent.BUTTON1_DOWN_MASK);
>> 111:         robot.delay(10);
> 
> Here and after
> Suggestion:
> 
> 
> 
> We have already called `robot.setAutoDelay(DOUBLE_CLICK_AUTO_DELAY);` before. We can set `DOUBLE_CLICK_AUTO_DELAY` to 20 and remove the multiple `robot.delay(10)` calls.
> 
> Probably we also want to add `setAutoWaitForIdle(true)`

ok

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18386#discussion_r1532506155
PR Review Comment: https://git.openjdk.org/jdk/pull/18386#discussion_r1532510812
PR Review Comment: https://git.openjdk.org/jdk/pull/18386#discussion_r1532510509
PR Review Comment: https://git.openjdk.org/jdk/pull/18386#discussion_r1532508651
PR Review Comment: https://git.openjdk.org/jdk/pull/18386#discussion_r1532509878
PR Review Comment: https://git.openjdk.org/jdk/pull/18386#discussion_r1532510220

From prr at openjdk.org  Wed Mar 20 17:29:21 2024
From: prr at openjdk.org (Phil Race)
Date: Wed, 20 Mar 2024 17:29:21 GMT
Subject: RFR: 8195675: Call to insertText with single character from custom
 Input Method ignored
In-Reply-To: <u4b11jevNfC8exSXDejpgklF2_HF-1W16mp04vQH1Ts=.878c5bf4-f237-4c05-bb03-5c8db3d16a9a@github.com>
References: <70yOUGT0N_mI3Pq8UVS-KgUAzZbtRhFniW8U16iVtlk=.7d6edddb-d68b-4b98-aaaf-1e60224dee0b@github.com>
 <u4b11jevNfC8exSXDejpgklF2_HF-1W16mp04vQH1Ts=.878c5bf4-f237-4c05-bb03-5c8db3d16a9a@github.com>
Message-ID: <APlwmsTGPkRBak52BwXu9vUGLSXzN5CTEbNv_zG3rNc=.bd3bc4cb-65a5-43ea-895a-7a2aa8f43c76@github.com>

On Mon, 4 Mar 2024 17:02:29 GMT, Phil Race <prr at openjdk.org> wrote:

>> 8195675: Call to insertText with single character from custom Input Method ignored
>
> Marked as reviewed by prr (Reviewer).

> I'm able to build this again, but not satisfied that it solves the issue, so I am still investigating. Should I rebase this upon latest master or somewhere else (now that 22 is released)? @prrace

@srl295 
You are based on main-line, which is now 23, so there should be nothing to do.
If you feel you are out of date in some important way you can re-base but the release change would have nothing to do with that.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17921#issuecomment-2010167231

From honkar at openjdk.org  Wed Mar 20 17:32:54 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Wed, 20 Mar 2024 17:32:54 GMT
Subject: RFR: JDK-8328225: Convert ImageDecoratedDnD.html applet test to
 main [v4]
In-Reply-To: <yHnt-BqOUlo1IKduuk0nv0ZsoReWANI_g4BxukwDzUQ=.24dff5fe-2737-45cc-867e-42f137172363@github.com>
References: <yHnt-BqOUlo1IKduuk0nv0ZsoReWANI_g4BxukwDzUQ=.24dff5fe-2737-45cc-867e-42f137172363@github.com>
Message-ID: <FaiAxOqJ5sCKIX6dpRaVmgkL5P8bWW9HUCkzY46UOtA=.66e4845d-058b-4cc8-820d-eec782c27653@github.com>

> Following test is converted to main using PassFailJFrame.

Harshitha Onkar has updated the pull request incrementally with three additional commits since the last revision:

 - frame.setSize() used
 - review update
 - review update

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18315/files
  - new: https://git.openjdk.org/jdk/pull/18315/files/7e35e23d..6c522e53

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18315&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18315&range=02-03

  Stats: 11 lines in 1 file changed: 2 ins; 0 del; 9 mod
  Patch: https://git.openjdk.org/jdk/pull/18315.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18315/head:pull/18315

PR: https://git.openjdk.org/jdk/pull/18315

From aivanov at openjdk.org  Wed Mar 20 17:32:54 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Wed, 20 Mar 2024 17:32:54 GMT
Subject: RFR: JDK-8328225: Convert ImageDecoratedDnD.html applet test to
 main [v4]
In-Reply-To: <FaiAxOqJ5sCKIX6dpRaVmgkL5P8bWW9HUCkzY46UOtA=.66e4845d-058b-4cc8-820d-eec782c27653@github.com>
References: <yHnt-BqOUlo1IKduuk0nv0ZsoReWANI_g4BxukwDzUQ=.24dff5fe-2737-45cc-867e-42f137172363@github.com>
 <FaiAxOqJ5sCKIX6dpRaVmgkL5P8bWW9HUCkzY46UOtA=.66e4845d-058b-4cc8-820d-eec782c27653@github.com>
Message-ID: <Gdx9mqOMYYjxMMlOUz1RrJ5ur7ylY0p0Y3Z8JK-kY1s=.c7f6b0e2-6d09-4729-b2c3-caf7dc9204f2@github.com>

On Wed, 20 Mar 2024 17:29:58 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Following test is converted to main using PassFailJFrame.
>
> Harshitha Onkar has updated the pull request incrementally with three additional commits since the last revision:
> 
>  - frame.setSize() used
>  - review update
>  - review update

Marked as reviewed by aivanov (Reviewer).

test/jdk/java/awt/dnd/ImageDecoratedDnD/ImageDecoratedDnD.java line 34:

> 32:  * @test
> 33:  * @bug 4874070
> 34:  * @summary Tests CTRL + DnD functionality.

I think summaries look better without the full stop in the end?

test/jdk/java/awt/dnd/ImageDecoratedDnD/ImageDecoratedDnD.java line 62:

> 60:                 It means the image may not be displayed when dragging over some
> 61:                 windows, it is not error.
> 62:                 The image should be display when dragging over the red/yellow panel.

Suggestion:

                windows, it is not an error.
                The image should be displayed when dragging over the red/yellow panel.

-------------

PR Review: https://git.openjdk.org/jdk/pull/18315#pullrequestreview-1949594651
PR Review Comment: https://git.openjdk.org/jdk/pull/18315#discussion_r1532516400
PR Review Comment: https://git.openjdk.org/jdk/pull/18315#discussion_r1532515526

From honkar at openjdk.org  Wed Mar 20 17:32:54 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Wed, 20 Mar 2024 17:32:54 GMT
Subject: RFR: JDK-8328225: Convert ImageDecoratedDnD.html applet test to
 main [v2]
In-Reply-To: <8RCbCOaEQlmsCWcT9Oo60Jxm7cK5Lr8aYizCYQorW-I=.2c7279bd-02ef-4f6f-8c72-3e21a8f82f32@github.com>
References: <yHnt-BqOUlo1IKduuk0nv0ZsoReWANI_g4BxukwDzUQ=.24dff5fe-2737-45cc-867e-42f137172363@github.com>
 <uGayDQcJWPhfRQG08Yvrjts5xy96f-M3ziVfvtrWVPo=.b605ed8b-bdb7-4bf3-bb6c-e3fd0c86b144@github.com>
 <8RCbCOaEQlmsCWcT9Oo60Jxm7cK5Lr8aYizCYQorW-I=.2c7279bd-02ef-4f6f-8c72-3e21a8f82f32@github.com>
Message-ID: <Toab5Lcnsk1fGkzzeYYTj68VRhPGksK_thxRLCZ31AU=.5a3d5c4f-8244-4d42-b465-29d8c3a6f89b@github.com>

On Wed, 20 Mar 2024 17:03:41 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   instructions updated
>
> test/jdk/java/awt/dnd/ImageDecoratedDnD/ImageDecoratedDnD.java line 46:
> 
>> 44: 
>> 45:             1. Click on the button and drag to the red panel by pressing
>> 46:                the "CTRL" key on the keyboard.
> 
> Suggestion:
> 
>             1. Click on the button and drag it to the red panel while holding
>                the "CTRL" key on the keyboard.

Updated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18315#discussion_r1532507511

From aivanov at openjdk.org  Wed Mar 20 17:32:55 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Wed, 20 Mar 2024 17:32:55 GMT
Subject: RFR: JDK-8328225: Convert ImageDecoratedDnD.html applet test to
 main [v3]
In-Reply-To: <9BcQwKYpNGUpK8-qEkf7cCcpQPLQB1ZWXc7oGiLUDVg=.623e63f7-5c26-4b18-8867-5aa7a2b157d8@github.com>
References: <yHnt-BqOUlo1IKduuk0nv0ZsoReWANI_g4BxukwDzUQ=.24dff5fe-2737-45cc-867e-42f137172363@github.com>
 <9BcQwKYpNGUpK8-qEkf7cCcpQPLQB1ZWXc7oGiLUDVg=.623e63f7-5c26-4b18-8867-5aa7a2b157d8@github.com>
Message-ID: <FUuQ19RA66nNBDHovdsNcOFIw5sAZJB3DkYAuiEY4sc=.6af7b87e-903c-479a-88f1-9250ab722197@github.com>

On Wed, 20 Mar 2024 17:13:34 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Following test is converted to main using PassFailJFrame.
>
> Harshitha Onkar has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - minor fix
>  - instruction line-lengths

test/jdk/java/awt/dnd/ImageDecoratedDnD/ImageDecoratedDnD.java line 87:

> 85:         Component dragSource, dropTarget;
> 86: 
> 87:         frame.setBounds(0, 400, 400, 400);

Suggestion:

        frame.setSize(400, 400);

The frame is positioned by `PassFailJFrame`, so setting the location is redundant.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18315#discussion_r1532513704

From honkar at openjdk.org  Wed Mar 20 17:35:47 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Wed, 20 Mar 2024 17:35:47 GMT
Subject: RFR: JDK-8328225: Convert ImageDecoratedDnD.html applet test to
 main [v5]
In-Reply-To: <yHnt-BqOUlo1IKduuk0nv0ZsoReWANI_g4BxukwDzUQ=.24dff5fe-2737-45cc-867e-42f137172363@github.com>
References: <yHnt-BqOUlo1IKduuk0nv0ZsoReWANI_g4BxukwDzUQ=.24dff5fe-2737-45cc-867e-42f137172363@github.com>
Message-ID: <NsdYfQBLnBTD6mn_SXbcSD838u0sJDmKdce_DMv8a24=.b78d754a-a0c5-4b06-b29c-a29514bc9b0c@github.com>

> Following test is converted to main using PassFailJFrame.

Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:

  summary updated

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18315/files
  - new: https://git.openjdk.org/jdk/pull/18315/files/6c522e53..54543424

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18315&range=04
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18315&range=03-04

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/18315.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18315/head:pull/18315

PR: https://git.openjdk.org/jdk/pull/18315

From abhiscxk at openjdk.org  Wed Mar 20 17:37:20 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Wed, 20 Mar 2024 17:37:20 GMT
Subject: RFR: 8328558: Convert
 javax/swing/JCheckBox/8032667/bug8032667.java applet test to main
In-Reply-To: <g745t9uMBoROVg83p-3Hkv9s_BjHREVBFnSBVRBT5s4=.9865582b-5db3-4073-97dd-21625ba72991@github.com>
References: <g745t9uMBoROVg83p-3Hkv9s_BjHREVBFnSBVRBT5s4=.9865582b-5db3-4073-97dd-21625ba72991@github.com>
Message-ID: <Tin1lljTPkihZOMxBdXocbnWeQq9Q3tOijUSg22vOr4=.d8455fad-e0db-4925-8efe-23eb42d54f52@github.com>

On Wed, 20 Mar 2024 16:46:40 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

> Convert javax/swing/JCheckBox/8032667/bug8032667.java applet test to main using PassFailJFrame

LGTM.

test/jdk/javax/swing/JCheckBox/bug8032667.java line 41:

> 39:  * @build PassFailJFrame
> 40:  * @summary [macosx] Components cannot be rendered in HiDPI to BufferedImage
> 41:  * @run main/manual bug8032667

Minor:
May add a blank line after this.

-------------

Marked as reviewed by abhiscxk (Committer).

PR Review: https://git.openjdk.org/jdk/pull/18403#pullrequestreview-1949594433
PR Review Comment: https://git.openjdk.org/jdk/pull/18403#discussion_r1532515383

From honkar at openjdk.org  Wed Mar 20 17:38:35 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Wed, 20 Mar 2024 17:38:35 GMT
Subject: RFR: JDK-8328225: Convert ImageDecoratedDnD.html applet test to
 main [v6]
In-Reply-To: <yHnt-BqOUlo1IKduuk0nv0ZsoReWANI_g4BxukwDzUQ=.24dff5fe-2737-45cc-867e-42f137172363@github.com>
References: <yHnt-BqOUlo1IKduuk0nv0ZsoReWANI_g4BxukwDzUQ=.24dff5fe-2737-45cc-867e-42f137172363@github.com>
Message-ID: <RwK63OFCAnA_RCLQ5rl04FZmlBS1HAAqn6EfgoGNfyA=.1a84f193-b173-4a16-9847-6e5ae96d099d@github.com>

> Following test is converted to main using PassFailJFrame.

Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:

  instructions updated

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18315/files
  - new: https://git.openjdk.org/jdk/pull/18315/files/54543424..362aff06

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18315&range=05
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18315&range=04-05

  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/18315.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18315/head:pull/18315

PR: https://git.openjdk.org/jdk/pull/18315

From prr at openjdk.org  Wed Mar 20 17:38:44 2024
From: prr at openjdk.org (Phil Race)
Date: Wed, 20 Mar 2024 17:38:44 GMT
Subject: RFR: 8328540: test javax/swing/JSplitPane/4885629/bug4885629.java
 fails on windows hidpi [v2]
In-Reply-To: <WHDf1998FlZ19dNxxz-E7M5ZOwJA89v-zgN9zKZ4_V0=.184a9091-6ed1-4a98-8c6f-dba65ce60462@github.com>
References: <WHDf1998FlZ19dNxxz-E7M5ZOwJA89v-zgN9zKZ4_V0=.184a9091-6ed1-4a98-8c6f-dba65ce60462@github.com>
Message-ID: <L-JRAXHtrfvl-PVtXI3h2N2VPO9dmleoCrZIMEmtl68=.d495f439-e0b6-4fdc-acdf-8b457fc099a7@github.com>

> A simple fix to the test to skip sampling the leftmost and rightmost ends of the divider
> to avoid possible issues at fractional scales.

Phil Race has updated the pull request incrementally with one additional commit since the last revision:

  8328540

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18384/files
  - new: https://git.openjdk.org/jdk/pull/18384/files/9618fa4a..b8c3c48a

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18384&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18384&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/18384.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18384/head:pull/18384

PR: https://git.openjdk.org/jdk/pull/18384

From abhiscxk at openjdk.org  Wed Mar 20 17:38:44 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Wed, 20 Mar 2024 17:38:44 GMT
Subject: RFR: 8328540: test javax/swing/JSplitPane/4885629/bug4885629.java
 fails on windows hidpi [v2]
In-Reply-To: <L-JRAXHtrfvl-PVtXI3h2N2VPO9dmleoCrZIMEmtl68=.d495f439-e0b6-4fdc-acdf-8b457fc099a7@github.com>
References: <WHDf1998FlZ19dNxxz-E7M5ZOwJA89v-zgN9zKZ4_V0=.184a9091-6ed1-4a98-8c6f-dba65ce60462@github.com>
 <L-JRAXHtrfvl-PVtXI3h2N2VPO9dmleoCrZIMEmtl68=.d495f439-e0b6-4fdc-acdf-8b457fc099a7@github.com>
Message-ID: <Z82bhuAbcxlB6MNuL63SnRGJl5M8hpHfMCGHy36SdgA=.5a31c09c-2b23-4787-b7e1-ce5fca711bef@github.com>

On Wed, 20 Mar 2024 17:35:14 GMT, Phil Race <prr at openjdk.org> wrote:

>> A simple fix to the test to skip sampling the leftmost and rightmost ends of the divider
>> to avoid possible issues at fractional scales.
>
> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8328540

Marked as reviewed by abhiscxk (Committer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18384#pullrequestreview-1949606489

From prr at openjdk.org  Wed Mar 20 17:38:44 2024
From: prr at openjdk.org (Phil Race)
Date: Wed, 20 Mar 2024 17:38:44 GMT
Subject: RFR: 8328540: test javax/swing/JSplitPane/4885629/bug4885629.java
 fails on windows hidpi [v2]
In-Reply-To: <hDn_LUyL72nX3-yv6Zys9nsYx53s0MI6mwl32a7uFpw=.3084ea75-94f1-4d76-afff-ed51b4bd6435@github.com>
References: <WHDf1998FlZ19dNxxz-E7M5ZOwJA89v-zgN9zKZ4_V0=.184a9091-6ed1-4a98-8c6f-dba65ce60462@github.com>
 <hDn_LUyL72nX3-yv6Zys9nsYx53s0MI6mwl32a7uFpw=.3084ea75-94f1-4d76-afff-ed51b4bd6435@github.com>
Message-ID: <QXrQaUeNtux10s0-2zSwuvdEKmKlloUBL8l-wEEsYz4=.59bbe013-69f2-40c1-b208-ba25891c21a0@github.com>

On Wed, 20 Mar 2024 04:25:52 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

> 1. should we mention `-Dsun.java2d.uiScale` in jtreg tag since it is supposed to be a hidpi test ?

No, since it is not a hidpi test, it is just a test that happens to fail in certain hidpi envts.
And the fractional scale only works on windows anyway.
It might be "interesting" to run all our tests with  that option, but that's a different topic
and is more easily and robustly accomplished by running on an actual hidpi envt.

> 2. Please update copyright year.
OK ..

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18384#issuecomment-2010184385

From srl at openjdk.org  Wed Mar 20 17:41:21 2024
From: srl at openjdk.org (Steven Loomis)
Date: Wed, 20 Mar 2024 17:41:21 GMT
Subject: RFR: 8195675: Call to insertText with single character from custom
 Input Method ignored
In-Reply-To: <70yOUGT0N_mI3Pq8UVS-KgUAzZbtRhFniW8U16iVtlk=.7d6edddb-d68b-4b98-aaaf-1e60224dee0b@github.com>
References: <70yOUGT0N_mI3Pq8UVS-KgUAzZbtRhFniW8U16iVtlk=.7d6edddb-d68b-4b98-aaaf-1e60224dee0b@github.com>
Message-ID: <eiF2mnismbc085Nuasem5gjkBUtCsb7-akEYn6PipFA=.5cd67b12-7c51-4df0-97cc-4696987c717d@github.com>

On Tue, 20 Feb 2024 02:08:09 GMT, Steven Loomis <srl at openjdk.org> wrote:

> 8195675: Call to insertText with single character from custom Input Method ignored

Great. I'll keep investigating

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17921#issuecomment-2010198705

From abhiscxk at openjdk.org  Wed Mar 20 17:44:24 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Wed, 20 Mar 2024 17:44:24 GMT
Subject: RFR: 8328560:
 java/awt/event/MouseEvent/ClickDuringKeypress/ClickDuringKeypress.java imports
 Applet [v2]
In-Reply-To: <EgH0oqhWRvMvp4722bi9RuDySczRTfnGgHi6SG0AFYw=.3bc36f84-d000-47e4-aeeb-01f33393ffd7@github.com>
References: <DAGMk9laOuahpyUEepWDE92N94zIbgNOWgaIgQFIurs=.602f3b0a-e0dd-49ee-9075-12961ef49611@github.com>
 <EgH0oqhWRvMvp4722bi9RuDySczRTfnGgHi6SG0AFYw=.3bc36f84-d000-47e4-aeeb-01f33393ffd7@github.com>
Message-ID: <tIVGxCDWtNP38jg5_j0niGdBbs3x3HmC8FcAKrC-4Hs=.732f5dad-1ac0-42a2-80c5-beac1ad00a2e@github.com>

On Wed, 20 Mar 2024 17:27:44 GMT, Phil Race <prr at openjdk.org> wrote:

>> This seems to have been some previous not very complete conversion of a test from applet to main.
>> It even still had Applet imported and miscellaneous comments. I've cleaned it up.
>
> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8328560

test/jdk/java/awt/event/MouseEvent/ClickDuringKeypress/ClickDuringKeypress.java line 45:

> 43: 
> 44: public class ClickDuringKeypress implements MouseListener {
> 45:    //Declare things used in the test, like buttons and labels here

Comments can be removed.

test/jdk/java/awt/event/MouseEvent/ClickDuringKeypress/ClickDuringKeypress.java line 67:

> 65:            doTest();
> 66:        } finally {
> 67:            if (frame != null) {

null check should be done on EDT ?

test/jdk/java/awt/event/MouseEvent/ClickDuringKeypress/ClickDuringKeypress.java line 88:

> 86:        robot.delay(1000);
> 87:        if (!ready) {
> 88:            System.out.println("Not Activated. Test fails");

Looks redundant.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18386#discussion_r1532530344
PR Review Comment: https://git.openjdk.org/jdk/pull/18386#discussion_r1532531591
PR Review Comment: https://git.openjdk.org/jdk/pull/18386#discussion_r1532533350

From aivanov at openjdk.org  Wed Mar 20 18:01:24 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Wed, 20 Mar 2024 18:01:24 GMT
Subject: RFR: 8328402: Implement pausing functionality for the
 PassFailJFrame
In-Reply-To: <_G5oabZhLzV7Ld3agI-uiRKWhJL5_8i8LVWA7JSBhOM=.c025ce82-16ed-4b8d-8e2b-1a8bc849639c@github.com>
References: <_G5oabZhLzV7Ld3agI-uiRKWhJL5_8i8LVWA7JSBhOM=.c025ce82-16ed-4b8d-8e2b-1a8bc849639c@github.com>
Message-ID: <4Gm8rlFmxk7XFbCasmgSLpp0HKe3OUbulAtDX1Gfhic=.b3d6f1ea-de53-4393-8ac6-ef2cbbf3e520@github.com>

On Tue, 19 Mar 2024 01:14:29 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>> we need to add next to Pass/Fail a "Pause Timer" button, that
> (a) stops the count down
> (b) changes the Pause Timer to "Resume Timer"
> ~~(c) disables Pass/Fail until the timer is resumed~~
> the test will not have to pause or be aware - only the PassFailJFrame machinery.
> ~~So the tester can do anything they want except exit the test in the paused mode.~~
> 
> This PR implements everything except the (c).
> I see nothing wrong with completing the test from the paused state, and it does not add an extra click.  
> 
> 
> Example screenshots:
> 
> ![image](https://github.com/openjdk/jdk/assets/77687766/65d34bf8-1e46-4e68-b39e-a77f257ec3c0)
> ![image](https://github.com/openjdk/jdk/assets/77687766/3a43e059-2d48-46f3-9d1b-c2ab84fcce37)

Looks good overall.

However, the _Pause Timer_ is quite large, it's larger than Pass or Fail button, and it attracts more attention.

I would place the Pause button into the timeout panel at the top. Yet the button is larger than the label. The font may be reduced, a symbol '?' (U+23F8) and '?' (U+23F5) could be used (see [Media control symbols](https://en.wikipedia.org/wiki/Media_control_symbols)), or an image icon with a tooltip.

The timeout and its UI elements ? the label and pause button ? may be encapsulated into `TimeoutHandler` and return a `JPanel`.

Yet the above improvements could be handled separately. I agree there should be a way to pause the test. I agree that Pass and Fail button can remain enabled, the tester could proceed with the test even when the timer isn't running.

test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 647:

> 645:         private static final String PAUSE_BUTTON_LABEL = "Pause Timer";
> 646:         private static final String RESUME_BUTTON_LABEL = "Resume Timer";
> 647:         private long endTime;

Suggestion:

        private static final String RESUME_BUTTON_LABEL = "Resume Timer";

        private long endTime;

test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 648:

> 646:         private static final String RESUME_BUTTON_LABEL = "Resume Timer";
> 647:         private long endTime;
> 648:         private long pauseTimeLeft = 0L;

Suggestion:

        private long pauseTimeLeft;

Zero is the default value; you never use `pauseTimeLeft` before assigning it a value when the Pause button is pressed.

test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 704:

> 702:             } else {
> 703:                 label.setText(label.getText().replace(PAUSED_LABEL_SUFFIX, ""));
> 704:                 endTime = System.currentTimeMillis() + pauseTimeLeft;

I'd rather call `updateTime(pauseTimeLeft)` here instead of editing the text.

Suggestion:

                endTime = System.currentTimeMillis() + pauseTimeLeft;
                updateTime(pauseTimeLeft);

-------------

Changes requested by aivanov (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18368#pullrequestreview-1949607461
PR Review Comment: https://git.openjdk.org/jdk/pull/18368#discussion_r1532523214
PR Review Comment: https://git.openjdk.org/jdk/pull/18368#discussion_r1532529917
PR Review Comment: https://git.openjdk.org/jdk/pull/18368#discussion_r1532538482

From azvegint at openjdk.org  Wed Mar 20 18:01:26 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Wed, 20 Mar 2024 18:01:26 GMT
Subject: RFR: 8328560:
 java/awt/event/MouseEvent/ClickDuringKeypress/ClickDuringKeypress.java imports
 Applet [v2]
In-Reply-To: <EgH0oqhWRvMvp4722bi9RuDySczRTfnGgHi6SG0AFYw=.3bc36f84-d000-47e4-aeeb-01f33393ffd7@github.com>
References: <DAGMk9laOuahpyUEepWDE92N94zIbgNOWgaIgQFIurs=.602f3b0a-e0dd-49ee-9075-12961ef49611@github.com>
 <EgH0oqhWRvMvp4722bi9RuDySczRTfnGgHi6SG0AFYw=.3bc36f84-d000-47e4-aeeb-01f33393ffd7@github.com>
Message-ID: <JY0qt5Ln2DJ5qHqYCV_Gm1lTIiTL6WHOY6O76iPhTXI=.580e9a41-018b-45e9-a0dd-72b0cb2df565@github.com>

On Wed, 20 Mar 2024 17:27:44 GMT, Phil Race <prr at openjdk.org> wrote:

>> This seems to have been some previous not very complete conversion of a test from applet to main.
>> It even still had Applet imported and miscellaneous comments. I've cleaned it up.
>
> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8328560

Marked as reviewed by azvegint (Reviewer).

test/jdk/java/awt/event/MouseEvent/ClickDuringKeypress/ClickDuringKeypress.java line 24:

> 22:  */
> 23: 
> 24: import java.awt.AWTException;

Suggestion:


Unused

test/jdk/java/awt/event/MouseEvent/ClickDuringKeypress/ClickDuringKeypress.java line 34:

> 32: import java.awt.event.WindowAdapter;
> 33: import java.awt.event.WindowEvent;
> 34: import java.awt.event.WindowEvent;

Suggestion:

import java.awt.event.WindowEvent;

test/jdk/java/awt/event/MouseEvent/ClickDuringKeypress/ClickDuringKeypress.java line 54:

> 52:    static volatile Frame frame;
> 53:    static volatile Robot robot;
> 54:    static final ClickDuringKeypress clicker = new ClickDuringKeypress();

On the other hand, we can get rid of the instantiation of this class and MouseListener empty methods overrides by simply adding this:


frame.addMouseListener(new MouseAdapter() {
          @Override
          public void mouseClicked(MouseEvent e) {
              System.out.println(e.toString());
              clicked = true;
              lastClickCount = e.getClickCount();
          }
      });


Either way, I'm fine with it.

-------------

PR Review: https://git.openjdk.org/jdk/pull/18386#pullrequestreview-1949640518
PR Review Comment: https://git.openjdk.org/jdk/pull/18386#discussion_r1532556420
PR Review Comment: https://git.openjdk.org/jdk/pull/18386#discussion_r1532544604
PR Review Comment: https://git.openjdk.org/jdk/pull/18386#discussion_r1532555599

From achung at openjdk.org  Wed Mar 20 18:01:51 2024
From: achung at openjdk.org (Alisen Chung)
Date: Wed, 20 Mar 2024 18:01:51 GMT
Subject: RFR: 8328227: Remove applet usage from JColorChooser tests
 Test4887836 [v3]
In-Reply-To: <sz94hhkj7mCeInxQ075Uwe14NVjdUMDk3sbuOr1E2X0=.2cc0c644-dd7a-4044-aa17-c082abaf74b6@github.com>
References: <sz94hhkj7mCeInxQ075Uwe14NVjdUMDk3sbuOr1E2X0=.2cc0c644-dd7a-4044-aa17-c082abaf74b6@github.com>
Message-ID: <erPi8_-ggo-p0gEBfaHBShPybFDwrzzzQWcYU7DQ8ko=.00d594a4-6d99-4bc9-85a7-f9a754020987@github.com>

> Removing applet usage from manual JColorChooser tests

Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:

  text block instructions

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18316/files
  - new: https://git.openjdk.org/jdk/pull/18316/files/9652def1..00bf78b2

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18316&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18316&range=01-02

  Stats: 3 lines in 1 file changed: 1 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/18316.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18316/head:pull/18316

PR: https://git.openjdk.org/jdk/pull/18316

From achung at openjdk.org  Wed Mar 20 18:02:37 2024
From: achung at openjdk.org (Alisen Chung)
Date: Wed, 20 Mar 2024 18:02:37 GMT
Subject: RFR: 8328403: Remove applet usage from JColorChooser tests
 Test6977726 [v2]
In-Reply-To: <pyfxVdApSNSisMJieBTl5HSZKDmSSiPie0tnrM_rwe4=.5ffc4e92-cbcf-44d8-9a51-b4e8330e1be9@github.com>
References: <pyfxVdApSNSisMJieBTl5HSZKDmSSiPie0tnrM_rwe4=.5ffc4e92-cbcf-44d8-9a51-b4e8330e1be9@github.com>
Message-ID: <hPfifnK0UnpXOEtu8Jmp91oFwC_VyjuJeu9CDPQbvaw=.544c5d8c-633e-46b1-855f-c41543164dea@github.com>

> Removing applet usage from manual JColorChooser tests

Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:

  spacing

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18369/files
  - new: https://git.openjdk.org/jdk/pull/18369/files/19fa62e8..d0818756

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18369&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18369&range=00-01

  Stats: 3 lines in 1 file changed: 1 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/18369.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18369/head:pull/18369

PR: https://git.openjdk.org/jdk/pull/18369

From honkar at openjdk.org  Wed Mar 20 18:12:28 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Wed, 20 Mar 2024 18:12:28 GMT
Subject: Integrated: JDK-8328225: Convert ImageDecoratedDnD.html applet test to
 main
In-Reply-To: <yHnt-BqOUlo1IKduuk0nv0ZsoReWANI_g4BxukwDzUQ=.24dff5fe-2737-45cc-867e-42f137172363@github.com>
References: <yHnt-BqOUlo1IKduuk0nv0ZsoReWANI_g4BxukwDzUQ=.24dff5fe-2737-45cc-867e-42f137172363@github.com>
Message-ID: <pPcw2RqPL3-bbB2LSV1ihjM1Ynyq8zGrllxVJegmOh0=.1e86a7c1-383a-4079-afe6-ae816fe98b64@github.com>

On Thu, 14 Mar 2024 22:41:20 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

> Following test is converted to main using PassFailJFrame.

This pull request has now been integrated.

Changeset: a112fc8b
Author:    Harshitha Onkar <honkar at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/a112fc8bac8ddee87c8555b156519a2785d3223b
Stats:     254 lines in 2 files changed: 52 ins; 185 del; 17 mod

8328225: Convert ImageDecoratedDnD.html applet test to main

Reviewed-by: dnguyen, aivanov

-------------

PR: https://git.openjdk.org/jdk/pull/18315

From aivanov at openjdk.org  Wed Mar 20 18:16:22 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Wed, 20 Mar 2024 18:16:22 GMT
Subject: RFR: JDK-8320675 : PrinterJob/SecurityDialogTest.java hangs [v4]
In-Reply-To: <o6NHN2hWnEpQKy5T4bKfFkQI9DdCKCD3OhoN1TR0Az0=.4ad7fd2e-e11a-4ff7-a5a9-e46f7b098515@github.com>
References: <OMBWLwH7044RMtwdrZSiahQDdy-1T-4oJjOQgnQEKjI=.18a31ad0-710f-44e5-86ec-b4566946b063@github.com>
 <o6NHN2hWnEpQKy5T4bKfFkQI9DdCKCD3OhoN1TR0Az0=.4ad7fd2e-e11a-4ff7-a5a9-e46f7b098515@github.com>
Message-ID: <W6myXhxhfztOJ_mUysmHYtuCo9sr9E-LSXkeL74HkKc=.44d2541f-5030-4c20-9089-5a2d9a7c8072@github.com>

On Tue, 19 Mar 2024 08:58:35 GMT, Renjith Kannath Pariyangad <rkannathpari at openjdk.org> wrote:

>> Hi Reviewers,
>> 
>> I have updated the test with  PassFailJFrame with information panel, earlier this was informed through terminal.
>> Please review and let me know your suggestions if any.
>
> Renjith Kannath Pariyangad has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Removed extra space

Marked as reviewed by aivanov (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18299#pullrequestreview-1949697930

From kizune at openjdk.org  Wed Mar 20 18:33:19 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Wed, 20 Mar 2024 18:33:19 GMT
Subject: RFR: 8328385: Convert java/awt/FileDialog/FileDialogReturnTest
 test to main [v3]
In-Reply-To: <fHBimJjg3-VdF5g2mYAdBeFbIvlZd5LW1sYQGs7JQTs=.3bf65dd2-ed0f-4cf9-b82a-b6b26f5fb139@github.com>
References: <fqHwY3Ipk9ArGTOnM26LF_dxWaQeptZ8Kf9fKNWUPVg=.43700ff8-5123-444a-817d-173bd126368d@github.com>
 <T90iE7Ae6ooEfYfYAlzKM2X_AVQzEOob5CVifMWg604=.6e0aa384-4bd6-4d87-b88d-49bed35a06ee@github.com>
 <fHBimJjg3-VdF5g2mYAdBeFbIvlZd5LW1sYQGs7JQTs=.3bf65dd2-ed0f-4cf9-b82a-b6b26f5fb139@github.com>
Message-ID: <RoWblQHGDh1pxpDOmlgSwP5FyZ_Vpk15nRpWWmD_2W0=.3b013fa5-07cf-4943-9d7f-254778c88c2b@github.com>

On Wed, 20 Mar 2024 17:23:36 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

>> Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Moved test metadate closer to the class definition;
>>   Made variables local;
>>   Made test skip execution on an unsupported toolkit;
>
> test/jdk/java/awt/FileDialog/FileDialogReturnTest.java line 47:
> 
>> 45:  * @build PassFailJFrame
>> 46:  * @build jtreg.SkippedException
>> 47:  * @run main/manual FileDialogReturnTest.html
> 
> This still runs on the `.html` file. Does this run correctly for you when testing?

No, i were fixing other stuff and accidentally pasted the .html there. Will fix that.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18363#discussion_r1532598681

From kizune at openjdk.org  Wed Mar 20 18:37:45 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Wed, 20 Mar 2024 18:37:45 GMT
Subject: RFR: 8328385: Convert java/awt/FileDialog/FileDialogReturnTest
 test to main [v4]
In-Reply-To: <fqHwY3Ipk9ArGTOnM26LF_dxWaQeptZ8Kf9fKNWUPVg=.43700ff8-5123-444a-817d-173bd126368d@github.com>
References: <fqHwY3Ipk9ArGTOnM26LF_dxWaQeptZ8Kf9fKNWUPVg=.43700ff8-5123-444a-817d-173bd126368d@github.com>
Message-ID: <AdJgYXvOYQ3YDjLORme_DH00H82MnGjgfC5pVn5Ps1I=.fd5c28bf-1758-4fde-8734-1a8df9f737a1@github.com>

> Convert test to a main method based;
> Move test to an apropriate location;
> Remove old files;

Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:

  Remove .html from the @test clause

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18363/files
  - new: https://git.openjdk.org/jdk/pull/18363/files/132bcbc6..0c838ea4

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18363&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18363&range=02-03

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/18363.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18363/head:pull/18363

PR: https://git.openjdk.org/jdk/pull/18363

From kizune at openjdk.org  Wed Mar 20 18:37:45 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Wed, 20 Mar 2024 18:37:45 GMT
Subject: RFR: 8328385: Convert java/awt/FileDialog/FileDialogReturnTest
 test to main [v3]
In-Reply-To: <fHBimJjg3-VdF5g2mYAdBeFbIvlZd5LW1sYQGs7JQTs=.3bf65dd2-ed0f-4cf9-b82a-b6b26f5fb139@github.com>
References: <fqHwY3Ipk9ArGTOnM26LF_dxWaQeptZ8Kf9fKNWUPVg=.43700ff8-5123-444a-817d-173bd126368d@github.com>
 <T90iE7Ae6ooEfYfYAlzKM2X_AVQzEOob5CVifMWg604=.6e0aa384-4bd6-4d87-b88d-49bed35a06ee@github.com>
 <fHBimJjg3-VdF5g2mYAdBeFbIvlZd5LW1sYQGs7JQTs=.3bf65dd2-ed0f-4cf9-b82a-b6b26f5fb139@github.com>
Message-ID: <Kde3Idm_afSnLPnTC4fhuwiDohYcQ3Q6zTUS4KM2grs=.58313911-05bb-4ea2-a335-3d3abb0a1f09@github.com>

On Wed, 20 Mar 2024 17:21:13 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

>> Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Moved test metadate closer to the class definition;
>>   Made variables local;
>>   Made test skip execution on an unsupported toolkit;
>
> test/jdk/java/awt/FileDialog/FileDialogReturnTest.java line 46:
> 
>> 44:  * @library /test/lib
>> 45:  * @build PassFailJFrame
>> 46:  * @build jtreg.SkippedException
> 
> Suggestion:
> 
>  * @library /java/awt/regtesthelpers /test/lib
>  * @build PassFailJFrame jtreg.SkippedException
> 
> 
> Not positive if this is correct, but I was able to combine the `@library` and `@build` on one line by adding a space between the two.

I prefer to use separate lines just to make it more readable.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18363#discussion_r1532605591

From prr at openjdk.org  Wed Mar 20 18:49:20 2024
From: prr at openjdk.org (Phil Race)
Date: Wed, 20 Mar 2024 18:49:20 GMT
Subject: RFR: 8328301: Convert Applet test ManualHTMLDataFlavorTest.java to
 main program
In-Reply-To: <VQRx1VHO9Ksr-SB8zgf2gdqI4cVh5LGogYPHqyZPIoQ=.000fcb4c-e824-4321-88a9-e86cde0009ea@github.com>
References: <ezZp85g1cKWnR1M7apMh6bxP2_G6P9O5tN6DTSQEOU4=.951f4e5d-e956-4af8-b4f1-725c667224b5@github.com>
 <VQRx1VHO9Ksr-SB8zgf2gdqI4cVh5LGogYPHqyZPIoQ=.000fcb4c-e824-4321-88a9-e86cde0009ea@github.com>
Message-ID: <BLX-n7bXTuQgj2wKWIYVzcyI2yrIe6J5lKcgLr9A_Bk=.1743ab10-4074-424f-a045-b5d059cc2c84@github.com>

On Sat, 16 Mar 2024 00:37:47 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Convert this applet based test to a main program
>
> test/jdk/java/awt/datatransfer/HTMLDataFlavors/ManualHTMLDataFlavorTest.java line 27:
> 
>> 25:   @test
>> 26:   @bug 7075105
>> 27:   @summary WIN: Provide a way to format HTML on drop
> 
> Do we add `@requires (os.family == "windows")` since the test summary indicates Windows issue?

It is valid on all platforms. In fact if you read the instructions you'll see it says
"     On Mac OS X do NOT use Safari, it does not provide the needed DataFlavor,"

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18334#discussion_r1532624900

From prr at openjdk.org  Wed Mar 20 18:57:37 2024
From: prr at openjdk.org (Phil Race)
Date: Wed, 20 Mar 2024 18:57:37 GMT
Subject: RFR: 8328301: Convert Applet test ManualHTMLDataFlavorTest.java to
 main program [v2]
In-Reply-To: <ezZp85g1cKWnR1M7apMh6bxP2_G6P9O5tN6DTSQEOU4=.951f4e5d-e956-4af8-b4f1-725c667224b5@github.com>
References: <ezZp85g1cKWnR1M7apMh6bxP2_G6P9O5tN6DTSQEOU4=.951f4e5d-e956-4af8-b4f1-725c667224b5@github.com>
Message-ID: <NAaMbxZuvr-8jiLmuz9OfmkR6bZjYzz8H47YLF0sVQ0=.a8e8bd06-e382-474d-97b5-205d2d9350e6@github.com>

> Convert this applet based test to a main program

Phil Race has updated the pull request incrementally with one additional commit since the last revision:

  8328301

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18334/files
  - new: https://git.openjdk.org/jdk/pull/18334/files/86ec0268..38292f15

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18334&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18334&range=00-01

  Stats: 3 lines in 1 file changed: 1 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/18334.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18334/head:pull/18334

PR: https://git.openjdk.org/jdk/pull/18334

From prr at openjdk.org  Wed Mar 20 18:57:38 2024
From: prr at openjdk.org (Phil Race)
Date: Wed, 20 Mar 2024 18:57:38 GMT
Subject: RFR: 8328301: Convert Applet test ManualHTMLDataFlavorTest.java to
 main program [v2]
In-Reply-To: <6a3gk6l9Y5taEtc_Mp7y9IPfcjPNTOCSYWg1liUz5jY=.cf77bcab-e8aa-4bb9-a869-608bf7615f32@github.com>
References: <ezZp85g1cKWnR1M7apMh6bxP2_G6P9O5tN6DTSQEOU4=.951f4e5d-e956-4af8-b4f1-725c667224b5@github.com>
 <6a3gk6l9Y5taEtc_Mp7y9IPfcjPNTOCSYWg1liUz5jY=.cf77bcab-e8aa-4bb9-a869-608bf7615f32@github.com>
Message-ID: <nl4ObzL5T-jH0z1s0mhsqxY-rQLUUl7ezxEtIJ5XXzo=.07fcdee2-8ac6-4387-9a93-44fa12bc7d17@github.com>

On Sat, 16 Mar 2024 09:36:08 GMT, Andrey Turbanov <aturbanov at openjdk.org> wrote:

>> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8328301
>
> test/jdk/java/awt/datatransfer/HTMLDataFlavors/ManualHTMLDataFlavorTest.java line 60:
> 
>> 58:         @Override
>> 59:         public Dimension getPreferredSize() {
>> 60:             return new Dimension(400,400);
> 
> Suggestion:
> 
>             return new Dimension(400, 400);

done

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18334#discussion_r1532636540

From prr at openjdk.org  Wed Mar 20 18:57:38 2024
From: prr at openjdk.org (Phil Race)
Date: Wed, 20 Mar 2024 18:57:38 GMT
Subject: RFR: 8328301: Convert Applet test ManualHTMLDataFlavorTest.java to
 main program [v2]
In-Reply-To: <VQRx1VHO9Ksr-SB8zgf2gdqI4cVh5LGogYPHqyZPIoQ=.000fcb4c-e824-4321-88a9-e86cde0009ea@github.com>
References: <ezZp85g1cKWnR1M7apMh6bxP2_G6P9O5tN6DTSQEOU4=.951f4e5d-e956-4af8-b4f1-725c667224b5@github.com>
 <VQRx1VHO9Ksr-SB8zgf2gdqI4cVh5LGogYPHqyZPIoQ=.000fcb4c-e824-4321-88a9-e86cde0009ea@github.com>
Message-ID: <OetXaq8jKJLwbR10L0jUCDZJj2_oA6m1ml_3GKu_Q3Q=.91c31012-563d-42a5-9eaa-8f19c64742f0@github.com>

On Sat, 16 Mar 2024 00:30:48 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8328301
>
> test/jdk/java/awt/datatransfer/HTMLDataFlavors/ManualHTMLDataFlavorTest.java line 143:
> 
>> 141:         frame.add(new DropPane());
>> 142:         frame.pack();
>> 143:         return frame;
> 
> Changes looks good expect that when the the test is started and I switch to the browser window the drop target frame goes behind and becomes difficult to drag and drop to the Red panel.
> 
> Setting `frame.setAlwaysOnTop(true)` will ensure that the DnD panel is on top.

done

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18334#discussion_r1532636769

From honkar at openjdk.org  Wed Mar 20 19:02:20 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Wed, 20 Mar 2024 19:02:20 GMT
Subject: RFR: 8328301: Convert Applet test ManualHTMLDataFlavorTest.java to
 main program [v2]
In-Reply-To: <NAaMbxZuvr-8jiLmuz9OfmkR6bZjYzz8H47YLF0sVQ0=.a8e8bd06-e382-474d-97b5-205d2d9350e6@github.com>
References: <ezZp85g1cKWnR1M7apMh6bxP2_G6P9O5tN6DTSQEOU4=.951f4e5d-e956-4af8-b4f1-725c667224b5@github.com>
 <NAaMbxZuvr-8jiLmuz9OfmkR6bZjYzz8H47YLF0sVQ0=.a8e8bd06-e382-474d-97b5-205d2d9350e6@github.com>
Message-ID: <V5iR5oJ4ELDrsn_aeM2fYTJT4_az7s9mg3Fb9hUNICw=.01c9cdaa-b8fb-42f1-8afc-b69461b2a314@github.com>

On Wed, 20 Mar 2024 18:57:37 GMT, Phil Race <prr at openjdk.org> wrote:

>> Convert this applet based test to a main program
>
> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8328301

Marked as reviewed by honkar (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18334#pullrequestreview-1949805694

From honkar at openjdk.org  Wed Mar 20 19:09:23 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Wed, 20 Mar 2024 19:09:23 GMT
Subject: RFR: JDK-8328190 : Convert AWTPanelSmoothWheel.html applet test to
 main [v4]
In-Reply-To: <85j81nCQpt1zZUA7YK2kk8s86L1ZqLhs406hVKcWsMw=.51d17fec-616e-4a25-9f79-dfcc449f7896@github.com>
References: <sn9qb9ctS_sr3isHbwcbMCYh2RQokz2ptsw0rGBRnJY=.955d7549-72c7-4a4f-8ac8-a5d6f122cf68@github.com>
 <p8toDCsUN5dAL4dDyYVndsUESgStV4k9kaORTsC30T0=.1bb5f251-baa8-4eb9-9edf-7a01bb004824@github.com>
 <nLixT1Ds_Q4bojPE3dVPNJsP7npWOCXTeQnXjuNBjDI=.3e97d089-79b2-411b-9481-bf3c5a05bdca@github.com>
 <uLSpcviVXqraUZeDbvH3walaOGIGg1iCGcz8AMDv2oA=.e805c1f3-14b5-4855-9399-ef9693c8b11d@github.com>
 <85j81nCQpt1zZUA7YK2kk8s86L1ZqLhs406hVKcWsMw=.51d17fec-616e-4a25-9f79-dfcc449f7896@github.com>
Message-ID: <sdscsc0Uc48TLeDw3qPTnqMfCM8jyt_i5LtsUtsbE0w=.a72633cc-90b5-4743-b16f-fc6c855de210@github.com>

On Wed, 20 Mar 2024 16:57:24 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> @aivanov-jdk Semi-automated the test, it now passes when 5 or more  MouseWheelEvent of type: scrollType=WHEEL_UNIT_SCROLL & wheelRotation != 0 is recorded. Updated the instructions accordingly.
>
> I think we should update the instructions.
> 
> A high resolution mouse produces events like this:
> 
> java.awt.event.MouseWheelEvent[MOUSE_WHEEL,(164,90),absolute(1135,365),button=0,clickCount=0,scrollType=WHEEL_UNIT_SCROLL,scrollAmount=3,wheelRotation=0,preciseWheelRotation=0.25] on panel0
> java.awt.event.MouseWheelEvent[MOUSE_WHEEL,(164,90),absolute(1135,365),button=0,clickCount=0,scrollType=WHEEL_UNIT_SCROLL,scrollAmount=3,wheelRotation=0,preciseWheelRotation=0.25] on panel0
> java.awt.event.MouseWheelEvent[MOUSE_WHEEL,(164,90),absolute(1135,365),button=0,clickCount=0,scrollType=WHEEL_UNIT_SCROLL,scrollAmount=3,wheelRotation=0,preciseWheelRotation=0.25] on panel0
> java.awt.event.MouseWheelEvent[MOUSE_WHEEL,(133,46),absolute(1104,321),button=0,clickCount=0,scrollType=WHEEL_UNIT_SCROLL,scrollAmount=3,wheelRotation=1,preciseWheelRotation=1.0] on panel0
> 
> 
> Thus, `wheelRotation=0` while `preciseWheelRotation=0.25`. When it reaches, `preciseWheelRotation=1.0`, the event contains **`wheelRotation=1`**.
> 
> A regular mouse with mouse-wheel notches produces the following events:
> 
> java.awt.event.MouseWheelEvent[MOUSE_WHEEL,(90,115),absolute(1061,390),button=0,clickCount=0,scrollType=WHEEL_UNIT_SCROLL,scrollAmount=3,wheelRotation=1,preciseWheelRotation=1.0] on panel0
> java.awt.event.MouseWheelEvent[MOUSE_WHEEL,(176,76),absolute(1147,351),button=0,clickCount=0,scrollType=WHEEL_UNIT_SCROLL,scrollAmount=3,wheelRotation=1,preciseWheelRotation=1.0] on panel0
> 
> 
> As you can see, `scrollType=WHEEL_UNIT_SCROLL` is the same in both cases. The only difference is that high-resolution mouse produces events where **`preciseWheelRotation < 1.0`**.
> 
> This means that you should also track the value of `preciseWheelRotation`. Otherwise, the test will pass when a regular mouse is used.
> 
> You may show a warning to the user if you detect, let's say, 5 events with `wheelRotation=1` but none of the events had `wheelRotation=0` and `preciseWheelRotation < 1.0`.

I believe since there a lot of conditions that needs to be checked manually, it is better to convert this test from semi-automatic to completely manual.

I can parse the MouseWheelEvent to display only the info needed by the user such as PreciseWheelRotation and WheelRotation for easier checking and include a warning when not using a hi-res mouse.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18312#discussion_r1532662283

From honkar at openjdk.org  Wed Mar 20 19:20:31 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Wed, 20 Mar 2024 19:20:31 GMT
Subject: RFR: JDK-8328190 : Convert AWTPanelSmoothWheel.html applet test to
 main [v4]
In-Reply-To: <85j81nCQpt1zZUA7YK2kk8s86L1ZqLhs406hVKcWsMw=.51d17fec-616e-4a25-9f79-dfcc449f7896@github.com>
References: <sn9qb9ctS_sr3isHbwcbMCYh2RQokz2ptsw0rGBRnJY=.955d7549-72c7-4a4f-8ac8-a5d6f122cf68@github.com>
 <p8toDCsUN5dAL4dDyYVndsUESgStV4k9kaORTsC30T0=.1bb5f251-baa8-4eb9-9edf-7a01bb004824@github.com>
 <nLixT1Ds_Q4bojPE3dVPNJsP7npWOCXTeQnXjuNBjDI=.3e97d089-79b2-411b-9481-bf3c5a05bdca@github.com>
 <uLSpcviVXqraUZeDbvH3walaOGIGg1iCGcz8AMDv2oA=.e805c1f3-14b5-4855-9399-ef9693c8b11d@github.com>
 <85j81nCQpt1zZUA7YK2kk8s86L1ZqLhs406hVKcWsMw=.51d17fec-616e-4a25-9f79-dfcc449f7896@github.com>
Message-ID: <EiNwbyyM78UMK6vXZlpG4MAb85m9uxLUVK-eYiWHq1Q=.a5655c4f-1583-43c8-ac55-315edebe01cf@github.com>

On Wed, 20 Mar 2024 16:57:24 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> @aivanov-jdk Semi-automated the test, it now passes when 5 or more  MouseWheelEvent of type: scrollType=WHEEL_UNIT_SCROLL & wheelRotation != 0 is recorded. Updated the instructions accordingly.
>
> I think we should update the instructions.
> 
> A high resolution mouse produces events like this:
> 
> java.awt.event.MouseWheelEvent[MOUSE_WHEEL,(164,90),absolute(1135,365),button=0,clickCount=0,scrollType=WHEEL_UNIT_SCROLL,scrollAmount=3,wheelRotation=0,preciseWheelRotation=0.25] on panel0
> java.awt.event.MouseWheelEvent[MOUSE_WHEEL,(164,90),absolute(1135,365),button=0,clickCount=0,scrollType=WHEEL_UNIT_SCROLL,scrollAmount=3,wheelRotation=0,preciseWheelRotation=0.25] on panel0
> java.awt.event.MouseWheelEvent[MOUSE_WHEEL,(164,90),absolute(1135,365),button=0,clickCount=0,scrollType=WHEEL_UNIT_SCROLL,scrollAmount=3,wheelRotation=0,preciseWheelRotation=0.25] on panel0
> java.awt.event.MouseWheelEvent[MOUSE_WHEEL,(133,46),absolute(1104,321),button=0,clickCount=0,scrollType=WHEEL_UNIT_SCROLL,scrollAmount=3,wheelRotation=1,preciseWheelRotation=1.0] on panel0
> 
> 
> Thus, `wheelRotation=0` while `preciseWheelRotation=0.25`. When it reaches, `preciseWheelRotation=1.0`, the event contains **`wheelRotation=1`**.
> 
> A regular mouse with mouse-wheel notches produces the following events:
> 
> java.awt.event.MouseWheelEvent[MOUSE_WHEEL,(90,115),absolute(1061,390),button=0,clickCount=0,scrollType=WHEEL_UNIT_SCROLL,scrollAmount=3,wheelRotation=1,preciseWheelRotation=1.0] on panel0
> java.awt.event.MouseWheelEvent[MOUSE_WHEEL,(176,76),absolute(1147,351),button=0,clickCount=0,scrollType=WHEEL_UNIT_SCROLL,scrollAmount=3,wheelRotation=1,preciseWheelRotation=1.0] on panel0
> 
> 
> As you can see, `scrollType=WHEEL_UNIT_SCROLL` is the same in both cases. The only difference is that high-resolution mouse produces events where **`preciseWheelRotation < 1.0`**.
> 
> This means that you should also track the value of `preciseWheelRotation`. Otherwise, the test will pass when a regular mouse is used.
> 
> You may show a warning to the user if you detect, let's say, 5 events with `wheelRotation=1` but none of the events had `wheelRotation=0` and `preciseWheelRotation < 1.0`.

@aivanov-jdk Thanks for reviewing this in-depth and pointing out the difference between wheelRotation & preciseWheelRotation when using hi-res mouse.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18312#discussion_r1532702217

From honkar at openjdk.org  Wed Mar 20 19:52:32 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Wed, 20 Mar 2024 19:52:32 GMT
Subject: Integrated: JDK-8328379 : Convert URLDragTest.html applet test to main
In-Reply-To: <LMnkG1RNIu10nqg2m8IvZN73P9b1rFN4T56JjPmgZLk=.8cde2a03-28b8-4dc5-84b7-2be086494f13@github.com>
References: <LMnkG1RNIu10nqg2m8IvZN73P9b1rFN4T56JjPmgZLk=.8cde2a03-28b8-4dc5-84b7-2be086494f13@github.com>
Message-ID: <lkA8wwJzGMYqwJT2ZpELV23Ver-6IF7N8GJw2QEUm7I=.da070507-e22e-41bf-92a8-5a67d0b3dc8c@github.com>

On Mon, 18 Mar 2024 20:53:50 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

> Following test - test/jdk/java/awt/dnd/URLDragTest/URLDragTest.html is converted from applet to main using PassFailJFrame. 
> 
> PassFailJFrame's `logArea()` is used for logging messages.

This pull request has now been integrated.

Changeset: fbeac98c
Author:    Harshitha Onkar <honkar at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/fbeac98c84078a566c572abeba07c49e94bbf26b
Stats:     227 lines in 3 files changed: 94 ins; 133 del; 0 mod

8328379: Convert URLDragTest.html applet test to main

Reviewed-by: abhiscxk, psadhukhan

-------------

PR: https://git.openjdk.org/jdk/pull/18364

From azvegint at openjdk.org  Wed Mar 20 20:25:33 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Wed, 20 Mar 2024 20:25:33 GMT
Subject: RFR: 8328402: Implement pausing functionality for the
 PassFailJFrame [v2]
In-Reply-To: <_G5oabZhLzV7Ld3agI-uiRKWhJL5_8i8LVWA7JSBhOM=.c025ce82-16ed-4b8d-8e2b-1a8bc849639c@github.com>
References: <_G5oabZhLzV7Ld3agI-uiRKWhJL5_8i8LVWA7JSBhOM=.c025ce82-16ed-4b8d-8e2b-1a8bc849639c@github.com>
Message-ID: <lht-2bR5LdbhrTq3OdbC96MoLbSYVaw2yItOrQTpu2c=.036e2133-3c64-44ba-9133-e865fcc512e8@github.com>

>> we need to add next to Pass/Fail a "Pause Timer" button, that
> (a) stops the count down
> (b) changes the Pause Timer to "Resume Timer"
> ~~(c) disables Pass/Fail until the timer is resumed~~
> the test will not have to pause or be aware - only the PassFailJFrame machinery.
> ~~So the tester can do anything they want except exit the test in the paused mode.~~
> 
> This PR implements everything except the (c).
> I see nothing wrong with completing the test from the paused state, and it does not add an extra click.  
> 
> 
> Example screenshots:
> 
> ![image](https://github.com/openjdk/jdk/assets/77687766/65d34bf8-1e46-4e68-b39e-a77f257ec3c0)
> ![image](https://github.com/openjdk/jdk/assets/77687766/3a43e059-2d48-46f3-9d1b-c2ab84fcce37)

Alexander Zvegintsev has updated the pull request incrementally with two additional commits since the last revision:

 - TimeoutHandler -> TimeoutHandlerPanel
 - review comments

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18368/files
  - new: https://git.openjdk.org/jdk/pull/18368/files/85ba846a..10f4580e

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18368&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18368&range=00-01

  Stats: 38 lines in 1 file changed: 15 ins; 9 del; 14 mod
  Patch: https://git.openjdk.org/jdk/pull/18368.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18368/head:pull/18368

PR: https://git.openjdk.org/jdk/pull/18368

From azvegint at openjdk.org  Wed Mar 20 20:32:21 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Wed, 20 Mar 2024 20:32:21 GMT
Subject: RFR: 8328402: Implement pausing functionality for the
 PassFailJFrame [v2]
In-Reply-To: <4Gm8rlFmxk7XFbCasmgSLpp0HKe3OUbulAtDX1Gfhic=.b3d6f1ea-de53-4393-8ac6-ef2cbbf3e520@github.com>
References: <_G5oabZhLzV7Ld3agI-uiRKWhJL5_8i8LVWA7JSBhOM=.c025ce82-16ed-4b8d-8e2b-1a8bc849639c@github.com>
 <4Gm8rlFmxk7XFbCasmgSLpp0HKe3OUbulAtDX1Gfhic=.b3d6f1ea-de53-4393-8ac6-ef2cbbf3e520@github.com>
Message-ID: <_n14OJqwTnv9gtIAi9ztg33_ew5xtW4jhRRqybko0UA=.cf0676bf-96ce-4c22-b4fc-22ffdd28568e@github.com>

On Wed, 20 Mar 2024 17:58:59 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> I would place the Pause button into the timeout panel at the top. Yet the button is larger than the label. The font may be reduced, a symbol '?' (U+23F8) and '?' (U+23F5) could be used (see [Media control symbols](https://en.wikipedia.org/wiki/Media_control_symbols)), or an image icon with a tooltip.

Unfortunately `a symbol '?' (U+23F8) and '?' (U+23F5)` doesn't work on Linux for me:
![image](https://github.com/openjdk/jdk/assets/77687766/b7ad68e2-ad58-4ca4-9672-d529cb8866eb)
![image](https://github.com/openjdk/jdk/assets/77687766/d97bbe8c-ed44-4bb8-935e-61015e833d7b)

So the text is used (icons can be added separately):
![image](https://github.com/openjdk/jdk/assets/77687766/24ca05b4-79ac-46f6-8958-576114522d48)
![image](https://github.com/openjdk/jdk/assets/77687766/a6420488-7071-49e4-908e-84d1e18c9261)
![image](https://github.com/openjdk/jdk/assets/77687766/fb2d1b02-4b15-4e49-8af4-c6a28398ebef)
![image](https://github.com/openjdk/jdk/assets/77687766/542ec12d-7121-498e-aba9-fde8d8dda77a)
![image](https://github.com/openjdk/jdk/assets/77687766/5ebfea75-fade-4bc6-91b3-e212c0c17cf6)
![image](https://github.com/openjdk/jdk/assets/77687766/7f3ccd0b-9492-4e60-bbd1-8bd32e002864)

> test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 704:
> 
>> 702:             } else {
>> 703:                 label.setText(label.getText().replace(PAUSED_LABEL_SUFFIX, ""));
>> 704:                 endTime = System.currentTimeMillis() + pauseTimeLeft;
> 
> I'd rather call `updateTime(pauseTimeLeft)` here instead of editing the text.
> 
> Suggestion:
> 
>                 endTime = System.currentTimeMillis() + pauseTimeLeft;
>                 updateTime(pauseTimeLeft);

Yes, this way is better.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18368#issuecomment-2010561001
PR Review Comment: https://git.openjdk.org/jdk/pull/18368#discussion_r1532807064

From azvegint at openjdk.org  Wed Mar 20 21:06:35 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Wed, 20 Mar 2024 21:06:35 GMT
Subject: RFR: 8328631: Convert
 java/awt/InputMethods/InputMethodsTest/InputMethodsTest.java applet test to
 manual
Message-ID: <hndPv_Xokx8HhC6nCWXQGTVBROkbohmZYsicPCXrM3A=.08fe6ee9-a0ac-4a2d-bfa3-1e44cb4e2964@github.com>

Test converted to main. Tested on Linux with Japanese ibus-anthy input method.

-------------

Commit messages:
 - initial

Changes: https://git.openjdk.org/jdk/pull/18412/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18412&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8328631
  Stats: 109 lines in 2 files changed: 20 ins; 53 del; 36 mod
  Patch: https://git.openjdk.org/jdk/pull/18412.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18412/head:pull/18412

PR: https://git.openjdk.org/jdk/pull/18412

From prr at openjdk.org  Wed Mar 20 21:37:29 2024
From: prr at openjdk.org (Phil Race)
Date: Wed, 20 Mar 2024 21:37:29 GMT
Subject: RFR: 8328642: Convert applet test
 MouseDraggedOutCauseScrollingTest.html to main
Message-ID: <oSOD44PevN840Jv0JaNJLDYYqDna-8qggdwlyEayo9c=.47a9f876-50f8-4cdf-804c-596cb2ac94fb@github.com>

Converts java/awt/List/MouseDraggedOutCauseScrollingTest/MouseDraggedOutCauseScrollingTest.html
to a main program.

-------------

Commit messages:
 - 8328642

Changes: https://git.openjdk.org/jdk/pull/18414/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18414&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8328642
  Stats: 286 lines in 2 files changed: 48 ins; 211 del; 27 mod
  Patch: https://git.openjdk.org/jdk/pull/18414.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18414/head:pull/18414

PR: https://git.openjdk.org/jdk/pull/18414

From dnguyen at openjdk.org  Wed Mar 20 22:16:36 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Wed, 20 Mar 2024 22:16:36 GMT
Subject: RFR: 8328558: Convert
 javax/swing/JCheckBox/8032667/bug8032667.java applet test to main [v2]
In-Reply-To: <g745t9uMBoROVg83p-3Hkv9s_BjHREVBFnSBVRBT5s4=.9865582b-5db3-4073-97dd-21625ba72991@github.com>
References: <g745t9uMBoROVg83p-3Hkv9s_BjHREVBFnSBVRBT5s4=.9865582b-5db3-4073-97dd-21625ba72991@github.com>
Message-ID: <f3-FmlVCJlwmXpzeOSfObwO_jQgM6h20Jv_xFhGK6ZI=.bab9e228-f66b-4ecd-ab3a-26eb02089e8d@github.com>

> Convert javax/swing/JCheckBox/8032667/bug8032667.java applet test to main using PassFailJFrame

Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:

  Add new line

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18403/files
  - new: https://git.openjdk.org/jdk/pull/18403/files/14f9280b..2416a1c1

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18403&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18403&range=00-01

  Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18403.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18403/head:pull/18403

PR: https://git.openjdk.org/jdk/pull/18403

From dnguyen at openjdk.org  Wed Mar 20 22:16:36 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Wed, 20 Mar 2024 22:16:36 GMT
Subject: RFR: 8328558: Convert
 javax/swing/JCheckBox/8032667/bug8032667.java applet test to main [v2]
In-Reply-To: <Tin1lljTPkihZOMxBdXocbnWeQq9Q3tOijUSg22vOr4=.d8455fad-e0db-4925-8efe-23eb42d54f52@github.com>
References: <g745t9uMBoROVg83p-3Hkv9s_BjHREVBFnSBVRBT5s4=.9865582b-5db3-4073-97dd-21625ba72991@github.com>
 <Tin1lljTPkihZOMxBdXocbnWeQq9Q3tOijUSg22vOr4=.d8455fad-e0db-4925-8efe-23eb42d54f52@github.com>
Message-ID: <istdoTKip28uwuQqaZVAEQEhGYLt5PN0G4TMh6c2J1E=.c980f900-606b-4315-bcf5-2776c97fda2b@github.com>

On Wed, 20 Mar 2024 17:28:08 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add new line
>
> test/jdk/javax/swing/JCheckBox/bug8032667.java line 41:
> 
>> 39:  * @build PassFailJFrame
>> 40:  * @summary [macosx] Components cannot be rendered in HiDPI to BufferedImage
>> 41:  * @run main/manual bug8032667
> 
> Minor:
> May add a blank line after this.

Thanks added

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18403#discussion_r1532949858

From achung at openjdk.org  Wed Mar 20 22:53:27 2024
From: achung at openjdk.org (Alisen Chung)
Date: Wed, 20 Mar 2024 22:53:27 GMT
Subject: RFR: 8328648: Remove applet usage from JFileChooser tests bug4150029
Message-ID: <eTiR35uGxb59RbbKcRAdTrgYkrx4CNmkIWfk63i3sJw=.8771db30-c50e-4c50-ae80-312a7683cc27@github.com>

Removing applet usage from manual JFileChooser tests

-------------

Commit messages:
 - remove extra dialog
 - init commit

Changes: https://git.openjdk.org/jdk/pull/18415/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18415&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8328648
  Stats: 116 lines in 2 files changed: 25 ins; 46 del; 45 mod
  Patch: https://git.openjdk.org/jdk/pull/18415.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18415/head:pull/18415

PR: https://git.openjdk.org/jdk/pull/18415

From prr at openjdk.org  Wed Mar 20 23:00:22 2024
From: prr at openjdk.org (Phil Race)
Date: Wed, 20 Mar 2024 23:00:22 GMT
Subject: RFR: 8328402: Implement pausing functionality for the
 PassFailJFrame [v2]
In-Reply-To: <lht-2bR5LdbhrTq3OdbC96MoLbSYVaw2yItOrQTpu2c=.036e2133-3c64-44ba-9133-e865fcc512e8@github.com>
References: <_G5oabZhLzV7Ld3agI-uiRKWhJL5_8i8LVWA7JSBhOM=.c025ce82-16ed-4b8d-8e2b-1a8bc849639c@github.com>
 <lht-2bR5LdbhrTq3OdbC96MoLbSYVaw2yItOrQTpu2c=.036e2133-3c64-44ba-9133-e865fcc512e8@github.com>
Message-ID: <Ali-ATt_BnYe_49nbCX3XY4hCDer7u7fhsZwC0gZH3g=.1ba925f8-5dcd-4db6-ae05-de619bdd6bc3@github.com>

On Wed, 20 Mar 2024 20:25:33 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>>> we need to add next to Pass/Fail a "Pause Timer" button, that
>> (a) stops the count down
>> (b) changes the Pause Timer to "Resume Timer"
>> ~~(c) disables Pass/Fail until the timer is resumed~~
>> the test will not have to pause or be aware - only the PassFailJFrame machinery.
>> ~~So the tester can do anything they want except exit the test in the paused mode.~~
>> 
>> This PR implements everything except the (c).
>> I see nothing wrong with completing the test from the paused state, and it does not add an extra click.  
>> 
>> 
>> Example screenshots:
>> 
>> ![image](https://github.com/openjdk/jdk/assets/77687766/65d34bf8-1e46-4e68-b39e-a77f257ec3c0)
>> ![image](https://github.com/openjdk/jdk/assets/77687766/3a43e059-2d48-46f3-9d1b-c2ab84fcce37)
>
> Alexander Zvegintsev has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - TimeoutHandler -> TimeoutHandlerPanel
>  - review comments

Marked as reviewed by prr (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18368#pullrequestreview-1950390181

From honkar at openjdk.org  Wed Mar 20 23:02:23 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Wed, 20 Mar 2024 23:02:23 GMT
Subject: RFR: 8328035: Convert
 javax/swing/text/html/TableView/7030332/bug7030332.java applet test to main
 [v2]
In-Reply-To: <_tDJv5UgWgGj_eogkTzVvY7YvJtzckfxRAQs_pDzBsw=.f905413d-f540-41f2-a464-c647822de64d@github.com>
References: <sa4wl3VTL1p3Zxmat10wUsqex-uQewN2R2N8tXTwFFo=.013c255b-d875-4b52-a0f0-403664011199@github.com>
 <_k4T1yzAqADVQLTUScWnfSqbGYg-YZJ9SecWpQB55kM=.ffa6e901-7cee-40b6-954a-528dfb04dc83@github.com>
 <czzx6URRvyadj98-Yf5hr87K7wDcKpAlQ6R_vEtlI9M=.957c488a-bb26-4dc9-8e90-e02a5c894ef1@github.com>
 <6SPvUhuB-QIgakHdRqx1_LzOADDQNU25xRz7k2obSZc=.ac2b9979-d177-412e-be68-7b10f9a3a0ae@github.com>
 <_tDJv5UgWgGj_eogkTzVvY7YvJtzckfxRAQs_pDzBsw=.f905413d-f540-41f2-a464-c647822de64d@github.com>
Message-ID: <MIDJ8_fTmvD4Axja2ankcSfkGMbc8gfgXP-hcP6eDJY=.4656dbe7-27aa-47ad-b919-c844cd8d060e@github.com>

On Mon, 18 Mar 2024 13:27:56 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> I am not sure...I think there was some fix regarding border stroke sometime back either by @honkar-jdk or @DamonGuy . Maybe expectation should be somewhat different now in which case, probably the instructions should be amended accordingly...Let them verify once..

@prsadhuk @TejeshR13  I do see slight difference in borders on fractional scales 1.25,1.75. This looks similar to the border scaling issue fixed as part https://github.com/openjdk/jdk/pull/11571, https://github.com/openjdk/jdk/pull/10274. The border scaling fix was extended to line, etched borders and borders for JInternalFrame. 

This case is slightly different, in the sense html is parsed to paint the border of desired thickness but I believe the underlying issue is the same - painting of borders on fractional scales on Windows.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18260#issuecomment-2010840644

From prr at openjdk.org  Wed Mar 20 23:02:23 2024
From: prr at openjdk.org (Phil Race)
Date: Wed, 20 Mar 2024 23:02:23 GMT
Subject: RFR: 8328631: Convert
 java/awt/InputMethods/InputMethodsTest/InputMethodsTest.java applet test to
 manual
In-Reply-To: <hndPv_Xokx8HhC6nCWXQGTVBROkbohmZYsicPCXrM3A=.08fe6ee9-a0ac-4a2d-bfa3-1e44cb4e2964@github.com>
References: <hndPv_Xokx8HhC6nCWXQGTVBROkbohmZYsicPCXrM3A=.08fe6ee9-a0ac-4a2d-bfa3-1e44cb4e2964@github.com>
Message-ID: <9sjj678n2mOstw14jsusyNG0nWqyvEQfHlEKlizEXNw=.7d4875b4-92b4-4a73-976c-1c8d47a4b223@github.com>

On Wed, 20 Mar 2024 21:02:02 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

> Test converted to main. Tested on Linux with Japanese ibus-anthy input method.

Marked as reviewed by prr (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18412#pullrequestreview-1950393778

From prr at openjdk.org  Wed Mar 20 23:11:23 2024
From: prr at openjdk.org (Phil Race)
Date: Wed, 20 Mar 2024 23:11:23 GMT
Subject: RFR: 8328238: Convert few closed manual applet tests to main [v4]
In-Reply-To: <0-d5jlP4-aMbgEE1MS9GuMonUlQ09R9SOy_efIHLSsA=.754d7aac-e39d-4da7-9e26-7a1f8d081325@github.com>
References: <9uKHIdC_4RNWN6ecB8Es2dtAjhmMgTvQIrDMWmPJzfs=.39bb9943-81f5-4cae-8644-a1eaf45d82d6@github.com>
 <0-d5jlP4-aMbgEE1MS9GuMonUlQ09R9SOy_efIHLSsA=.754d7aac-e39d-4da7-9e26-7a1f8d081325@github.com>
Message-ID: <lhycotfs4KOEBKBMAM3JYrrCFtiPOqHU2EUJ3iJuyYE=.94bdb6b0-880c-4117-8db5-948a7e941a97@github.com>

On Wed, 20 Mar 2024 16:46:45 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Few closed manual applet tests are converted to main based and opensourced
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   REview update

Marked as reviewed by prr (Reviewer).

test/jdk/javax/swing/JFrame/bug4419914.java line 71:

> 69:         frame.enableInputMethods(false);
> 70:         frame.getContentPane().setComponentOrientation(ComponentOrientation.RIGHT_TO_LEFT);
> 71:         frame.getContentPane().setLocale(Locale.ENGLISH);

The requirement to use getContentPane() has been obsolete since JDK 1.5 ...
here's an external page about it https://coderanch.com/t/345686/java/getContentPane
But I don't generally tell people to delete except here there are 9 calls cluttering up this code.
So not critical, but a suggestion.

-------------

PR Review: https://git.openjdk.org/jdk/pull/18390#pullrequestreview-1950401141
PR Review Comment: https://git.openjdk.org/jdk/pull/18390#discussion_r1533017080

From prr at openjdk.org  Wed Mar 20 23:13:20 2024
From: prr at openjdk.org (Phil Race)
Date: Wed, 20 Mar 2024 23:13:20 GMT
Subject: RFR: 8328401: Convert
 java/awt/Frame/InitialMaximizedTest/InitialMaximizedTest.html applet test to
 automated [v2]
In-Reply-To: <1tv0wI_4pAfwMqK2o98hA5QIb4xGSR2n9ymIgIurJpM=.a5c297ba-aa64-4388-99de-91c764072edf@github.com>
References: <feEnRn4dLIWmgB9GyZd4ur-3buaDoiZ4eeynYShFz50=.f7eb7d90-464c-4231-8a6c-b97fc34378a5@github.com>
 <1tv0wI_4pAfwMqK2o98hA5QIb4xGSR2n9ymIgIurJpM=.a5c297ba-aa64-4388-99de-91c764072edf@github.com>
Message-ID: <i5RHKNhJUJz_9Qr3RWID-o_tegubUWACJc33rWDMxmM=.77cea6be-24de-4730-a0e4-78d20030527a@github.com>

On Tue, 19 Mar 2024 15:12:34 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>> The test converted to automated, CI and manual testing looks good on all platforms.
>
> Alexander Zvegintsev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   reduce delay

Marked as reviewed by prr (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18367#pullrequestreview-1950413589

From prr at openjdk.org  Wed Mar 20 23:18:20 2024
From: prr at openjdk.org (Phil Race)
Date: Wed, 20 Mar 2024 23:18:20 GMT
Subject: RFR: 8327840: Automate javax/swing/border/Test4129681.java [v3]
In-Reply-To: <7mXA4yB1IQMruvOFP2-u6IIiYPDX-wW8nnTIScNuqPQ=.75f7794c-27f6-4759-b3a2-ff65fbf367b8@github.com>
References: <BbQ2iwy01dkTxtQ9Aj7RhRkSxWm3pq3BEIlGIzlSTCk=.7bdaafe4-681a-4f03-8462-4ffa7dc99507@github.com>
 <7mXA4yB1IQMruvOFP2-u6IIiYPDX-wW8nnTIScNuqPQ=.75f7794c-27f6-4759-b3a2-ff65fbf367b8@github.com>
Message-ID: <5s8VQMd2rKlq9PjXBcYhjzrvXLuxhkxNF_PWtVznLwU=.7d3efb1f-fa92-4c5b-8ecd-ad48797cb969@github.com>

On Mon, 18 Mar 2024 13:29:37 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Automated the Test `javax/swing/border/Test4129681.java` from manual as suggested in JBS description.
>> Verified in CI system and its Green. The test has been verified for Metal L&F and the same is set explicitly..
>
> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review updates

test/jdk/javax/swing/border/Test4129681.java line 55:

> 53: 
> 54:         UIManager.setLookAndFeel("javax.swing.plaf.metal.MetalLookAndFeel");
> 55:         System.setProperty("sun.java2d.uiScale", "1.0");

If you are going to do this in code it needs to be line 1 of main before we call any java.desktop code.

You can also pass it on the command line of the test
@run main -Dsun.java2d.uiScale=1 Test4129681

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18336#discussion_r1533029624

From prr at openjdk.org  Wed Mar 20 23:19:21 2024
From: prr at openjdk.org (Phil Race)
Date: Wed, 20 Mar 2024 23:19:21 GMT
Subject: RFR: 8328194: Add a test to check default rendering engine
In-Reply-To: <xxsxmOwVdXyBrSIp2WwIQ3_RvWLBL5KORk_X6bNkAnU=.588f07e6-2967-4d9e-a780-046af14d2ca1@github.com>
References: <xxsxmOwVdXyBrSIp2WwIQ3_RvWLBL5KORk_X6bNkAnU=.588f07e6-2967-4d9e-a780-046af14d2ca1@github.com>
Message-ID: <OKAzxn9ewwwX2hMgAtBs0F5BgYi_6xL-pksvcXTjfCk=.502df7e9-d314-47ca-8ec7-770e8ed3e693@github.com>

On Thu, 14 Mar 2024 20:13:58 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

> This is a request to forward port the test added by the [JDK-8241307](https://bugs.openjdk.org/browse/JDK-8241307) with inverted condition - jdk jdk11 the marlin should be used by default.

Marked as reviewed by prr (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18313#pullrequestreview-1950421621

From prr at openjdk.org  Wed Mar 20 23:19:22 2024
From: prr at openjdk.org (Phil Race)
Date: Wed, 20 Mar 2024 23:19:22 GMT
Subject: RFR: 8328194: Add a test to check default rendering engine
In-Reply-To: <0a5Q1MibQDAMg4dKEOqpFjMg78_S2Xa1ByM1bElKgaM=.df9fc7de-bfd1-49a6-84d7-6bebc71df16c@github.com>
References: <xxsxmOwVdXyBrSIp2WwIQ3_RvWLBL5KORk_X6bNkAnU=.588f07e6-2967-4d9e-a780-046af14d2ca1@github.com>
 <wLJ2MjVk-CoAO31dEvaoY7-BCgw6yQYutiX01vsGsZA=.2d3cf6fc-0064-4985-b3be-616f9ba99085@github.com>
 <0a5Q1MibQDAMg4dKEOqpFjMg78_S2Xa1ByM1bElKgaM=.df9fc7de-bfd1-49a6-84d7-6bebc71df16c@github.com>
Message-ID: <7ZofadtzUIoKENjdCQzi-3e6BhFbqQgek8emX5qLe50=.db0eeabf-b305-4f95-961e-b009b937b15d@github.com>

On Sun, 17 Mar 2024 08:53:21 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

> > We don't have any others in JDK 23, so I am not sure what this test does for us.
> 
> Right now it is not useful, but that is the same story we had in OpenJDK 8 - only the one engine for years, and then the engine "accidentally" changed to marlin. This test will help to catch such bugs.

Ok ...

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18313#issuecomment-2010885381

From prr at openjdk.org  Wed Mar 20 23:19:26 2024
From: prr at openjdk.org (Phil Race)
Date: Wed, 20 Mar 2024 23:19:26 GMT
Subject: Integrated: 8328300: Convert PrintDialogsTest.java from Applet to main
 program
In-Reply-To: <awEafcUuB7m-r62HTUPpL9DsuGnRuT1czVoirtsYJRI=.725d3d5f-04f9-4012-bcc3-a8e7d157f07f@github.com>
References: <awEafcUuB7m-r62HTUPpL9DsuGnRuT1czVoirtsYJRI=.725d3d5f-04f9-4012-bcc3-a8e7d157f07f@github.com>
Message-ID: <oIVXnppav-n3zdLAWDX_rmSN3gLhDE7jOGMNbgRTYPI=.65fcf4fd-4009-4421-85fe-0feecf1eb9a8@github.com>

On Fri, 15 Mar 2024 21:20:04 GMT, Phil Race <prr at openjdk.org> wrote:

> This applet test is converted to a main program using PassFailJFrame.
> Other than that, the main thing I improved is the instructions.

This pull request has now been integrated.

Changeset: dea94f44
Author:    Phil Race <prr at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/dea94f4445b9389339cf7ca0eef688ca56c17814
Stats:     127 lines in 2 files changed: 65 ins; 52 del; 10 mod

8328300: Convert PrintDialogsTest.java from Applet to main program

Reviewed-by: psadhukhan, dnguyen

-------------

PR: https://git.openjdk.org/jdk/pull/18333

From prr at openjdk.org  Wed Mar 20 23:34:20 2024
From: prr at openjdk.org (Phil Race)
Date: Wed, 20 Mar 2024 23:34:20 GMT
Subject: RFR: 8328035: Convert
 javax/swing/text/html/TableView/7030332/bug7030332.java applet test to main
 [v2]
In-Reply-To: <_k4T1yzAqADVQLTUScWnfSqbGYg-YZJ9SecWpQB55kM=.ffa6e901-7cee-40b6-954a-528dfb04dc83@github.com>
References: <sa4wl3VTL1p3Zxmat10wUsqex-uQewN2R2N8tXTwFFo=.013c255b-d875-4b52-a0f0-403664011199@github.com>
 <_k4T1yzAqADVQLTUScWnfSqbGYg-YZJ9SecWpQB55kM=.ffa6e901-7cee-40b6-954a-528dfb04dc83@github.com>
Message-ID: <LFwpZIQsI6SdPsuJSHwzIJ479SOBQBmlYhsOUeesSbg=.d0eaee7e-3d8b-42d9-9d3c-a12e08b0b6bd@github.com>

On Thu, 14 Mar 2024 11:02:52 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Convert javax/swing/text/html/TableView/7030332/bug7030332.java applet test to main based test using PassFailJFrame.
>
> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review updates

This test was written before there was hidpi. So I am sure it is 100% so definitely you should specify that in the test to have any chance.
The height of the text doesn't matter, nor spacing inside the cells.
I'd say it is "similar enough" with 1.0 scaling. There's not been a bug about this yet.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18260#issuecomment-2010902621

From prr at openjdk.org  Wed Mar 20 23:45:31 2024
From: prr at openjdk.org (Phil Race)
Date: Wed, 20 Mar 2024 23:45:31 GMT
Subject: RFR: 8328560:
 java/awt/event/MouseEvent/ClickDuringKeypress/ClickDuringKeypress.java imports
 Applet [v3]
In-Reply-To: <DAGMk9laOuahpyUEepWDE92N94zIbgNOWgaIgQFIurs=.602f3b0a-e0dd-49ee-9075-12961ef49611@github.com>
References: <DAGMk9laOuahpyUEepWDE92N94zIbgNOWgaIgQFIurs=.602f3b0a-e0dd-49ee-9075-12961ef49611@github.com>
Message-ID: <SzK00U5knwjBuF02eZ4lTeZCjEU4psOMMt4--4x7zPU=.99180333-c818-4e1c-b3bb-071aa49d6bc2@github.com>

> This seems to have been some previous not very complete conversion of a test from applet to main.
> It even still had Applet imported and miscellaneous comments. I've cleaned it up.

Phil Race has updated the pull request incrementally with one additional commit since the last revision:

  8328560

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18386/files
  - new: https://git.openjdk.org/jdk/pull/18386/files/f4f4c335..fd7243e8

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18386&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18386&range=01-02

  Stats: 3 lines in 1 file changed: 0 ins; 2 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/18386.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18386/head:pull/18386

PR: https://git.openjdk.org/jdk/pull/18386

From prr at openjdk.org  Wed Mar 20 23:45:31 2024
From: prr at openjdk.org (Phil Race)
Date: Wed, 20 Mar 2024 23:45:31 GMT
Subject: RFR: 8328560:
 java/awt/event/MouseEvent/ClickDuringKeypress/ClickDuringKeypress.java imports
 Applet [v2]
In-Reply-To: <JY0qt5Ln2DJ5qHqYCV_Gm1lTIiTL6WHOY6O76iPhTXI=.580e9a41-018b-45e9-a0dd-72b0cb2df565@github.com>
References: <DAGMk9laOuahpyUEepWDE92N94zIbgNOWgaIgQFIurs=.602f3b0a-e0dd-49ee-9075-12961ef49611@github.com>
 <EgH0oqhWRvMvp4722bi9RuDySczRTfnGgHi6SG0AFYw=.3bc36f84-d000-47e4-aeeb-01f33393ffd7@github.com>
 <JY0qt5Ln2DJ5qHqYCV_Gm1lTIiTL6WHOY6O76iPhTXI=.580e9a41-018b-45e9-a0dd-72b0cb2df565@github.com>
Message-ID: <XY368Pw7DLu7RtOZ1pLJzwvAShqUqU49Z_Yl7C99BKc=.c2591842-51a4-4f5c-bbe5-1295b15ee707@github.com>

On Wed, 20 Mar 2024 17:57:30 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8328560
>
> test/jdk/java/awt/event/MouseEvent/ClickDuringKeypress/ClickDuringKeypress.java line 24:
> 
>> 22:  */
>> 23: 
>> 24: import java.awt.AWTException;
> 
> Suggestion:
> 
> 
> Unused

right not needed now

> test/jdk/java/awt/event/MouseEvent/ClickDuringKeypress/ClickDuringKeypress.java line 34:
> 
>> 32: import java.awt.event.WindowAdapter;
>> 33: import java.awt.event.WindowEvent;
>> 34: import java.awt.event.WindowEvent;
> 
> Suggestion:
> 
> import java.awt.event.WindowEvent;

fixed

> test/jdk/java/awt/event/MouseEvent/ClickDuringKeypress/ClickDuringKeypress.java line 54:
> 
>> 52:    static volatile Frame frame;
>> 53:    static volatile Robot robot;
>> 54:    static final ClickDuringKeypress clicker = new ClickDuringKeypress();
> 
> On the other hand, we can get rid of the instantiation of this class and MouseListener empty methods overrides by simply adding this:
> 
> 
> frame.addMouseListener(new MouseAdapter() {
>           @Override
>           public void mouseClicked(MouseEvent e) {
>               System.out.println(e.toString());
>               clicked = true;
>               lastClickCount = e.getClickCount();
>           }
>       });
> 
> 
> Either way, I'm fine with it.

I thought about doing something like this .. but decided to stop the creep of changes.
So I'll leave it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18386#discussion_r1533047651
PR Review Comment: https://git.openjdk.org/jdk/pull/18386#discussion_r1533047213
PR Review Comment: https://git.openjdk.org/jdk/pull/18386#discussion_r1533048464

From prr at openjdk.org  Wed Mar 20 23:45:32 2024
From: prr at openjdk.org (Phil Race)
Date: Wed, 20 Mar 2024 23:45:32 GMT
Subject: RFR: 8328560:
 java/awt/event/MouseEvent/ClickDuringKeypress/ClickDuringKeypress.java imports
 Applet [v2]
In-Reply-To: <tIVGxCDWtNP38jg5_j0niGdBbs3x3HmC8FcAKrC-4Hs=.732f5dad-1ac0-42a2-80c5-beac1ad00a2e@github.com>
References: <DAGMk9laOuahpyUEepWDE92N94zIbgNOWgaIgQFIurs=.602f3b0a-e0dd-49ee-9075-12961ef49611@github.com>
 <EgH0oqhWRvMvp4722bi9RuDySczRTfnGgHi6SG0AFYw=.3bc36f84-d000-47e4-aeeb-01f33393ffd7@github.com>
 <tIVGxCDWtNP38jg5_j0niGdBbs3x3HmC8FcAKrC-4Hs=.732f5dad-1ac0-42a2-80c5-beac1ad00a2e@github.com>
Message-ID: <g_CbQ_1VxrvdxqhDivuZKZHhgKCwBVhbeGQArfcXkZs=.6176c07c-53d5-4094-bd1a-a5485367bd8d@github.com>

On Wed, 20 Mar 2024 17:39:56 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8328560
>
> test/jdk/java/awt/event/MouseEvent/ClickDuringKeypress/ClickDuringKeypress.java line 45:
> 
>> 43: 
>> 44: public class ClickDuringKeypress implements MouseListener {
>> 45:    //Declare things used in the test, like buttons and labels here
> 
> Comments can be removed.

I thought about it already, seemed harmless, but I can remove it.

> test/jdk/java/awt/event/MouseEvent/ClickDuringKeypress/ClickDuringKeypress.java line 67:
> 
>> 65:            doTest();
>> 66:        } finally {
>> 67:            if (frame != null) {
> 
> null check should be done on EDT ?

Not needed for the null check

> test/jdk/java/awt/event/MouseEvent/ClickDuringKeypress/ClickDuringKeypress.java line 88:
> 
>> 86:        robot.delay(1000);
>> 87:        if (!ready) {
>> 88:            System.out.println("Not Activated. Test fails");
> 
> Looks redundant.

good to log, so I think it should stay

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18386#discussion_r1533047044
PR Review Comment: https://git.openjdk.org/jdk/pull/18386#discussion_r1533046679
PR Review Comment: https://git.openjdk.org/jdk/pull/18386#discussion_r1533048055

From honkar at openjdk.org  Thu Mar 21 00:12:45 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Thu, 21 Mar 2024 00:12:45 GMT
Subject: RFR: JDK-8328299 : Convert DnDFileGroupDescriptor.html applet test
 to main [v3]
In-Reply-To: <CTOJXaNDso7Gmw-A2kTkmsZmAWqcWllOim2Y_BGgeok=.5d62efd5-66c2-47a7-b1f0-c10f4c366b40@github.com>
References: <CTOJXaNDso7Gmw-A2kTkmsZmAWqcWllOim2Y_BGgeok=.5d62efd5-66c2-47a7-b1f0-c10f4c366b40@github.com>
Message-ID: <zNA15wmuzruwy_2_G9oae82fpKpIBEmUZfayih0YrK0=.b86e5a2b-360b-4f88-8c26-7f4a81bf130d@github.com>

> Following test java/awt/dnd/DnDFileGroupDescriptor/DnDFileGroupDescriptor.html is converted to main using PassFailJFrame.
> 
> This test is currently problem-listed on macOS and linux, but as per the previous JBS bugs [[JDK-6242241](https://bugs.openjdk.org/browse/JDK-6242241), [JDK-8080185](https://bugs.openjdk.org/browse/JDK-8080185), [JDK-7147083](https://bugs.openjdk.org/browse/JDK-7147083)] this test was original created for testing DnD of MS Outlook attachments on Windows system.
> 
> Based on the test history and JBS details, I believe this should be windows-only test and should NOT be problemlisted on macOS and linux as it is **not applicable**.

Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:

  problemlist updated

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18335/files
  - new: https://git.openjdk.org/jdk/pull/18335/files/f586cc64..4a5b234b

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18335&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18335&range=01-02

  Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18335.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18335/head:pull/18335

PR: https://git.openjdk.org/jdk/pull/18335

From honkar at openjdk.org  Thu Mar 21 00:19:20 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Thu, 21 Mar 2024 00:19:20 GMT
Subject: RFR: JDK-8328299 : Convert DnDFileGroupDescriptor.html applet test
 to main [v3]
In-Reply-To: <zNA15wmuzruwy_2_G9oae82fpKpIBEmUZfayih0YrK0=.b86e5a2b-360b-4f88-8c26-7f4a81bf130d@github.com>
References: <CTOJXaNDso7Gmw-A2kTkmsZmAWqcWllOim2Y_BGgeok=.5d62efd5-66c2-47a7-b1f0-c10f4c366b40@github.com>
 <zNA15wmuzruwy_2_G9oae82fpKpIBEmUZfayih0YrK0=.b86e5a2b-360b-4f88-8c26-7f4a81bf130d@github.com>
Message-ID: <LupxGKSyc4O7Tl86LhsLL70jzKMjsFwHBajaI4EkP7c=.1ba6f583-ef6a-4f24-804d-ad90e986164e@github.com>

On Thu, 21 Mar 2024 00:12:45 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Following test java/awt/dnd/DnDFileGroupDescriptor/DnDFileGroupDescriptor.html is converted to main using PassFailJFrame.
>> 
>> This test is currently problem-listed on macOS and linux, but as per the previous JBS bugs [[JDK-6242241](https://bugs.openjdk.org/browse/JDK-6242241), [JDK-8080185](https://bugs.openjdk.org/browse/JDK-8080185), [JDK-7147083](https://bugs.openjdk.org/browse/JDK-7147083)] this test was original created for testing DnD of MS Outlook attachments on Windows system.
>> 
>> Based on the test history and JBS details, I believe this should be windows-only test and should NOT be problemlisted on macOS and linux as it is **not applicable**.
>
> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   problemlist updated

@prsadhuk 
> The @requires was added in [JDK-7147083](https://bugs.openjdk.org/browse/JDK-7147083) to ensure the test pass automatically in non-windows platform much before the problemlist was added so I think it was an oversight and we should remove the problemlist and close 8080185 as NA, in my opinion...

I have de-problemlisted this test on non-windows platform as it is not applicable. I have added a note to to close [JDK-8080185](https://bugs.openjdk.org/browse/JDK-8080185) when this PR is integrated.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18335#issuecomment-2010951880

From honkar at openjdk.org  Thu Mar 21 01:13:50 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Thu, 21 Mar 2024 01:13:50 GMT
Subject: RFR: JDK-8328190 : Convert AWTPanelSmoothWheel.html applet test to
 main [v6]
In-Reply-To: <sn9qb9ctS_sr3isHbwcbMCYh2RQokz2ptsw0rGBRnJY=.955d7549-72c7-4a4f-8ac8-a5d6f122cf68@github.com>
References: <sn9qb9ctS_sr3isHbwcbMCYh2RQokz2ptsw0rGBRnJY=.955d7549-72c7-4a4f-8ac8-a5d6f122cf68@github.com>
Message-ID: <QIODl_DsczYOOkKiQQIvyr_5CWaxnZfUcd8Gs855Y4c=.ac936322-0895-4153-8585-26d6978157a6@github.com>

> This test is converted to main using PassFailJFrame. It verifies wheel rotation value for high-res mouse on windows.
> 
> The test requires the updated PassFailJFrame's logArea() feature added in this PR https://github.com/openjdk/jdk/pull/18319

Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:

  added preciseWheelRotation logic & updated test

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18312/files
  - new: https://git.openjdk.org/jdk/pull/18312/files/d81df883..6b7591f0

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18312&range=05
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18312&range=04-05

  Stats: 31 lines in 1 file changed: 13 ins; 3 del; 15 mod
  Patch: https://git.openjdk.org/jdk/pull/18312.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18312/head:pull/18312

PR: https://git.openjdk.org/jdk/pull/18312

From honkar at openjdk.org  Thu Mar 21 01:20:28 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Thu, 21 Mar 2024 01:20:28 GMT
Subject: RFR: JDK-8328190 : Convert AWTPanelSmoothWheel.html applet test to
 main [v4]
In-Reply-To: <85j81nCQpt1zZUA7YK2kk8s86L1ZqLhs406hVKcWsMw=.51d17fec-616e-4a25-9f79-dfcc449f7896@github.com>
References: <sn9qb9ctS_sr3isHbwcbMCYh2RQokz2ptsw0rGBRnJY=.955d7549-72c7-4a4f-8ac8-a5d6f122cf68@github.com>
 <p8toDCsUN5dAL4dDyYVndsUESgStV4k9kaORTsC30T0=.1bb5f251-baa8-4eb9-9edf-7a01bb004824@github.com>
 <nLixT1Ds_Q4bojPE3dVPNJsP7npWOCXTeQnXjuNBjDI=.3e97d089-79b2-411b-9481-bf3c5a05bdca@github.com>
 <uLSpcviVXqraUZeDbvH3walaOGIGg1iCGcz8AMDv2oA=.e805c1f3-14b5-4855-9399-ef9693c8b11d@github.com>
 <85j81nCQpt1zZUA7YK2kk8s86L1ZqLhs406hVKcWsMw=.51d17fec-616e-4a25-9f79-dfcc449f7896@github.com>
Message-ID: <RNTVmxm4AVVoz0DzJZdrH5FyUcophSH9HKkUuPTptog=.ef9ed3bf-4723-417b-9f1d-f37c0e43c908@github.com>

On Wed, 20 Mar 2024 16:57:24 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> @aivanov-jdk Semi-automated the test, it now passes when 5 or more  MouseWheelEvent of type: scrollType=WHEEL_UNIT_SCROLL & wheelRotation != 0 is recorded. Updated the instructions accordingly.
>
> I think we should update the instructions.
> 
> A high resolution mouse produces events like this:
> 
> java.awt.event.MouseWheelEvent[MOUSE_WHEEL,(164,90),absolute(1135,365),button=0,clickCount=0,scrollType=WHEEL_UNIT_SCROLL,scrollAmount=3,wheelRotation=0,preciseWheelRotation=0.25] on panel0
> java.awt.event.MouseWheelEvent[MOUSE_WHEEL,(164,90),absolute(1135,365),button=0,clickCount=0,scrollType=WHEEL_UNIT_SCROLL,scrollAmount=3,wheelRotation=0,preciseWheelRotation=0.25] on panel0
> java.awt.event.MouseWheelEvent[MOUSE_WHEEL,(164,90),absolute(1135,365),button=0,clickCount=0,scrollType=WHEEL_UNIT_SCROLL,scrollAmount=3,wheelRotation=0,preciseWheelRotation=0.25] on panel0
> java.awt.event.MouseWheelEvent[MOUSE_WHEEL,(133,46),absolute(1104,321),button=0,clickCount=0,scrollType=WHEEL_UNIT_SCROLL,scrollAmount=3,wheelRotation=1,preciseWheelRotation=1.0] on panel0
> 
> 
> Thus, `wheelRotation=0` while `preciseWheelRotation=0.25`. When it reaches, `preciseWheelRotation=1.0`, the event contains **`wheelRotation=1`**.
> 
> A regular mouse with mouse-wheel notches produces the following events:
> 
> java.awt.event.MouseWheelEvent[MOUSE_WHEEL,(90,115),absolute(1061,390),button=0,clickCount=0,scrollType=WHEEL_UNIT_SCROLL,scrollAmount=3,wheelRotation=1,preciseWheelRotation=1.0] on panel0
> java.awt.event.MouseWheelEvent[MOUSE_WHEEL,(176,76),absolute(1147,351),button=0,clickCount=0,scrollType=WHEEL_UNIT_SCROLL,scrollAmount=3,wheelRotation=1,preciseWheelRotation=1.0] on panel0
> 
> 
> As you can see, `scrollType=WHEEL_UNIT_SCROLL` is the same in both cases. The only difference is that high-resolution mouse produces events where **`preciseWheelRotation < 1.0`**.
> 
> This means that you should also track the value of `preciseWheelRotation`. Otherwise, the test will pass when a regular mouse is used.
> 
> You may show a warning to the user if you detect, let's say, 5 events with `wheelRotation=1` but none of the events had `wheelRotation=0` and `preciseWheelRotation < 1.0`.

@aivanov-jdk Since preciseWheelRotation amount depends on user's movement of the high-res mouse and there might be a need to look through logs for few events, it is better to convert this test from semi-automated to manual. Does this sound good? 
Updated the PR with the latest changes.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18312#discussion_r1533120961

From psadhukhan at openjdk.org  Thu Mar 21 03:16:44 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Thu, 21 Mar 2024 03:16:44 GMT
Subject: RFR: 8328238: Convert few closed manual applet tests to main [v5]
In-Reply-To: <9uKHIdC_4RNWN6ecB8Es2dtAjhmMgTvQIrDMWmPJzfs=.39bb9943-81f5-4cae-8644-a1eaf45d82d6@github.com>
References: <9uKHIdC_4RNWN6ecB8Es2dtAjhmMgTvQIrDMWmPJzfs=.39bb9943-81f5-4cae-8644-a1eaf45d82d6@github.com>
Message-ID: <V4DRjalzS7g3HV5acfWtvbl5eczLh_fvJfOYV9ZoY74=.61c4f6de-839e-44cc-8136-5ab452e9e378@github.com>

> Few closed manual applet tests are converted to main based and opensourced

Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:

  Remove getContentPane

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18390/files
  - new: https://git.openjdk.org/jdk/pull/18390/files/bac1ecb3..89783161

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18390&range=04
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18390&range=03-04

  Stats: 8 lines in 1 file changed: 0 ins; 0 del; 8 mod
  Patch: https://git.openjdk.org/jdk/pull/18390.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18390/head:pull/18390

PR: https://git.openjdk.org/jdk/pull/18390

From psadhukhan at openjdk.org  Thu Mar 21 03:16:44 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Thu, 21 Mar 2024 03:16:44 GMT
Subject: RFR: 8328238: Convert few closed manual applet tests to main [v4]
In-Reply-To: <lhycotfs4KOEBKBMAM3JYrrCFtiPOqHU2EUJ3iJuyYE=.94bdb6b0-880c-4117-8db5-948a7e941a97@github.com>
References: <9uKHIdC_4RNWN6ecB8Es2dtAjhmMgTvQIrDMWmPJzfs=.39bb9943-81f5-4cae-8644-a1eaf45d82d6@github.com>
 <0-d5jlP4-aMbgEE1MS9GuMonUlQ09R9SOy_efIHLSsA=.754d7aac-e39d-4da7-9e26-7a1f8d081325@github.com>
 <lhycotfs4KOEBKBMAM3JYrrCFtiPOqHU2EUJ3iJuyYE=.94bdb6b0-880c-4117-8db5-948a7e941a97@github.com>
Message-ID: <GPgTBSJ2AzCGJj9pvE2kq-4cAn_h5gJrY0mcN0_xg_4=.5b35d33d-067b-4492-a47f-e51a29bc2a8a@github.com>

On Wed, 20 Mar 2024 23:05:34 GMT, Phil Race <prr at openjdk.org> wrote:

>> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   REview update
>
> test/jdk/javax/swing/JFrame/bug4419914.java line 71:
> 
>> 69:         frame.enableInputMethods(false);
>> 70:         frame.getContentPane().setComponentOrientation(ComponentOrientation.RIGHT_TO_LEFT);
>> 71:         frame.getContentPane().setLocale(Locale.ENGLISH);
> 
> The requirement to use getContentPane() has been obsolete since JDK 1.5 ...
> here's an external page about it https://coderanch.com/t/345686/java/getContentPane
> But I don't generally tell people to delete except here there are 9 calls cluttering up this code.
> So not critical, but a suggestion.

Thanks for the information, didn't know that..Updated....there is around ~400 occurrence of getContentPane() in swing tests in open still so probably something to be optimised in future...

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18390#discussion_r1533196007

From psadhukhan at openjdk.org  Thu Mar 21 03:28:56 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Thu, 21 Mar 2024 03:28:56 GMT
Subject: RFR: 8328238: Convert few closed manual applet tests to main [v6]
In-Reply-To: <9uKHIdC_4RNWN6ecB8Es2dtAjhmMgTvQIrDMWmPJzfs=.39bb9943-81f5-4cae-8644-a1eaf45d82d6@github.com>
References: <9uKHIdC_4RNWN6ecB8Es2dtAjhmMgTvQIrDMWmPJzfs=.39bb9943-81f5-4cae-8644-a1eaf45d82d6@github.com>
Message-ID: <r4kDhlC11qsuUxWu9jWrfmhVDhFqbtvuZPSyaKwtUKg=.a5180e7f-226f-4f52-9c53-ef91cdbc392c@github.com>

> Few closed manual applet tests are converted to main based and opensourced

Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:

  Remove getContentPane from other tests

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18390/files
  - new: https://git.openjdk.org/jdk/pull/18390/files/89783161..06d7407c

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18390&range=05
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18390&range=04-05

  Stats: 3 lines in 2 files changed: 0 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/jdk/pull/18390.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18390/head:pull/18390

PR: https://git.openjdk.org/jdk/pull/18390

From psadhukhan at openjdk.org  Thu Mar 21 03:48:20 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Thu, 21 Mar 2024 03:48:20 GMT
Subject: RFR: JDK-8328299 : Convert DnDFileGroupDescriptor.html applet test
 to main [v3]
In-Reply-To: <zNA15wmuzruwy_2_G9oae82fpKpIBEmUZfayih0YrK0=.b86e5a2b-360b-4f88-8c26-7f4a81bf130d@github.com>
References: <CTOJXaNDso7Gmw-A2kTkmsZmAWqcWllOim2Y_BGgeok=.5d62efd5-66c2-47a7-b1f0-c10f4c366b40@github.com>
 <zNA15wmuzruwy_2_G9oae82fpKpIBEmUZfayih0YrK0=.b86e5a2b-360b-4f88-8c26-7f4a81bf130d@github.com>
Message-ID: <JhgE2tc8w7flq7KgaL8kDjWalGCYAt33rt9uuLaN60A=.073608af-0585-4bfe-a816-14327fc2694a@github.com>

On Thu, 21 Mar 2024 00:12:45 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Following test java/awt/dnd/DnDFileGroupDescriptor/DnDFileGroupDescriptor.html is converted to main using PassFailJFrame.
>> 
>> This test is currently problem-listed on macOS and linux, but as per the previous JBS bugs [[JDK-6242241](https://bugs.openjdk.org/browse/JDK-6242241), [JDK-8080185](https://bugs.openjdk.org/browse/JDK-8080185), [JDK-7147083](https://bugs.openjdk.org/browse/JDK-7147083)] this test was original created for testing DnD of MS Outlook attachments on Windows system.
>> 
>> Based on the test history and JBS details, I believe this should be windows-only test and should NOT be problemlisted on macOS and linux as it is **not applicable**.
>
> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   problemlist updated

Marked as reviewed by psadhukhan (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18335#pullrequestreview-1950706724

From psadhukhan at openjdk.org  Thu Mar 21 03:48:53 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Thu, 21 Mar 2024 03:48:53 GMT
Subject: RFR: 8328570: Convert closed JViewport manual applet tests to main
Message-ID: <JPXMrCOWFS4MTSQbiUtkH4egvJSxnapo0H0ndavn_8s=.cb76f5e5-a401-432f-83ea-8103eb3cf980@github.com>

Few closed manual applet JViewport tests are converted to main based and opensourced

-------------

Commit messages:
 - 8328570: Convert closed JViewport manual applet tests to main

Changes: https://git.openjdk.org/jdk/pull/18418/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18418&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8328570
  Stats: 429 lines in 5 files changed: 429 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18418.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18418/head:pull/18418

PR: https://git.openjdk.org/jdk/pull/18418

From philip.race at oracle.com  Thu Mar 21 04:48:03 2024
From: philip.race at oracle.com (Philip Race)
Date: Wed, 20 Mar 2024 21:48:03 -0700
Subject: Setting Chromaticity.MONOCHROME print request attribute on macOS
In-Reply-To: <78e594fc-e0fb-4d02-ae32-21fe2957c0d0@bell-sw.com>
References: <8eb8b503-6202-0bff-a512-24ab45f39d56@bell-sw.com>
 <78e594fc-e0fb-4d02-ae32-21fe2957c0d0@bell-sw.com>
Message-ID: <32801dba-3b5b-4e9f-87ee-c14e0ba1188a@oracle.com>

Noted. I don't see a JDK-maintained property file as viable.
It would never be complete, never be up to date, of questionable 
supported status,
undocumented as far as end-users are concerned - no chance Oracle would 
document it.
We have history here with fonts so I am as sure of this as I can be.

So regardless of the lack of solutions elsewhere, that won't work.

To say more I need to look into the code and think about things.
It is superficially surprising not to have printers / Apple CUPS support 
a standard IPP attribute.
I'll put this on my to-do list along with lots of other things.

If you can get Apple to come up with a better answer that would be good.

-phil.

On 3/13/24 7:20 AM, Alexander Scherbatiy wrote:
> Hello,
>
> There is a known issue that a PrinterJob does not take 
> Chromaticity.MONOCHROME print request attribute into account on macOS 
> (JDK-8315113 [1])
>
> The possible ways for solving the issue with black & white printing on 
> macOS could be:
>
> 1. Setting black & white printing with macOS API.
>
> ?? There is the deprecated PMSetColorMode [2] function:
> ?? "There is no replacement; this function was included to facilitate 
> porting legacy applications to macOS, but it serves no useful purpose."
> ?? and I was not able to find another one.
>
> 2. Using a predefined printer.properties file with black & white 
> key/value pairs for known printers.
> ??? It needs to maintain the property file to keep list with black & 
> white key/value pairs.
> ??? Or just leave only one default? ColorModel=Gray key/value in the 
> property file so users will need to add another ones for their needs.
>
> 3. Using a PPD API to get the corresponding black & white value for 
> the given key.
> ??? In this way the black & white keys are printer specific and there 
> should be a way to provide these keys to the program.
> ??? Another way is parsing a ppd file to find the black & white 
> key/value pair in question. It still requires some search criteria to 
> find the printer specific key.
>
> 4. Adding a custom PrintRequestAttribute which allows for a user to 
> add a printer specific key values to PrintRequestAttributeSet.
> ???? These key/value pairs are then added to the NSPrintInfo 
> printSettings on macOS.
>
> 5. Providing other ways like a jvm option which allows a user to pass 
> black & white key/value pairs to the program.
>
>
> Are there better solutions for the black & white printing issue on macOS?
> What is the best option to start solving the issue with?
>
> Thanks,
> Alexander.
>
> [1] https://bugs.openjdk.org/browse/JDK-8315113
>
> [2] 
> https://developer.apple.com/documentation/applicationservices/core_printing/1805783-pmsetcolormode
>
>
> On 8/28/23 18:00, Alexander Scherbatiy wrote:
>> Hello,
>>
>> I am working on issue "8315113 Print request Chromaticity.MONOCHROME 
>> attribute does not work on macOS" [1].
>>
>> There is PMSetColorMode function in the Apple Developer documentation 
>> [2] but it is marked as deprecated
>> ? "There is no replacement; this function was included to facilitate 
>> porting legacy applications to macOS, but it serves no useful purpose."
>> and really does nothing.
>>
>>
>> Using native print dialog and selecting Black & White box allows to 
>> print black and white pages on macOS.
>> I dumped NSPrintInfo print settings dictionary for two printers when 
>> the Black & White box is selected and the logs contain
>> ColorModel key, Gray value for HP ColorLaserJet MFP 
>> M178-M181-AirPrint printer and
>> HPColorMode key, grayscale value for HP Ink Tank 115.
>> It looks like each printer can have each own key/value for Black & 
>> White settings.
>>
>> I tried to print key/values for all presets available for NSPrintInfo 
>> without using the native print dialog:
>> ----------
>> ??? PMPrinter pr;
>> ??? PMPrintSession printSession = (PMPrintSession)[printInfo 
>> PMPrintSession];
>> ??? OSStatus status = PMSessionGetCurrentPrinter(printSession, &pr);
>> ??? CFArrayRef presetsList = nil;
>> ??? status = PMPrinterCopyPresets(pr, &presetsList);
>> ??? CFIndex arrayCount = CFArrayGetCount(presetsList);
>>
>> ??? for (CFIndex index = 0; index < arrayCount; index++) {
>> ??????? PMPreset preset = 
>> (PMPreset)CFArrayGetValueAtIndex(presetsList, index);
>> ??????? CFStringRef presetName = nil;
>> ??????? if (PMPresetCopyName(preset, &presetName) == noErr && 
>> CFStringGetLength(presetName) > 0) {
>> ??????????? NSLog(@"? presetName: '%@'", presetName);
>> ??????????? NSDictionary* dict = nil;
>> ??????????? if (PMPresetGetAttributes(preset, 
>> (CFDictionaryRef*)(&dict)) == noErr) {
>> ?????????????????? // print preset dict
>>
>> ----------
>> The printers which I tested do contain "Black and White" preset but 
>> they do not include key/values related to black and white printing.
>>
>>
>> What is the right way to use different key/values (ColorModel: Gray, 
>> HPColorMode: grayscale, ...) in code to set Black & White settings 
>> for NSPrintInfo?
>> Could it be a configuration file which contains all color model 
>> key/values for all known printers?
>>
>> Thanks,
>> Alexander.
>>
>> [1] https://bugs.openjdk.org/browse/JDK-8315113
>>
>> [2] 
>> https://developer.apple.com/documentation/applicationservices/core_printing/1805783-pmsetcolormode
>>
>>


From psadhukhan at openjdk.org  Thu Mar 21 04:54:20 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Thu, 21 Mar 2024 04:54:20 GMT
Subject: RFR: 8328558: Convert
 javax/swing/JCheckBox/8032667/bug8032667.java applet test to main [v2]
In-Reply-To: <f3-FmlVCJlwmXpzeOSfObwO_jQgM6h20Jv_xFhGK6ZI=.bab9e228-f66b-4ecd-ab3a-26eb02089e8d@github.com>
References: <g745t9uMBoROVg83p-3Hkv9s_BjHREVBFnSBVRBT5s4=.9865582b-5db3-4073-97dd-21625ba72991@github.com>
 <f3-FmlVCJlwmXpzeOSfObwO_jQgM6h20Jv_xFhGK6ZI=.bab9e228-f66b-4ecd-ab3a-26eb02089e8d@github.com>
Message-ID: <sD6u9PI7eQ8DGQZwh72LdoPzwAdeXpn8ARZ8xtlRHhk=.a4339c73-7f06-400d-8ad4-0455dfdfbda5@github.com>

On Wed, 20 Mar 2024 22:16:36 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

>> Convert javax/swing/JCheckBox/8032667/bug8032667.java applet test to main using PassFailJFrame
>
> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add new line

Marked as reviewed by psadhukhan (Reviewer).

test/jdk/javax/swing/JCheckBox/bug8032667.java line 87:

> 85:             }
> 86:         };
> 87:         frame.getContentPane().add(canvas, BorderLayout.CENTER);

It seems getContentPane is not needed and is obsoleted since jdk1.5...See this [comment](https://github.com/openjdk/jdk/pull/18390#discussion_r1533017080)

-------------

PR Review: https://git.openjdk.org/jdk/pull/18403#pullrequestreview-1950755132
PR Review Comment: https://git.openjdk.org/jdk/pull/18403#discussion_r1533245336

From tr at openjdk.org  Thu Mar 21 05:08:46 2024
From: tr at openjdk.org (Tejesh R)
Date: Thu, 21 Mar 2024 05:08:46 GMT
Subject: RFR: 8328035: Convert
 javax/swing/text/html/TableView/7030332/bug7030332.java applet test to main
 [v3]
In-Reply-To: <sa4wl3VTL1p3Zxmat10wUsqex-uQewN2R2N8tXTwFFo=.013c255b-d875-4b52-a0f0-403664011199@github.com>
References: <sa4wl3VTL1p3Zxmat10wUsqex-uQewN2R2N8tXTwFFo=.013c255b-d875-4b52-a0f0-403664011199@github.com>
Message-ID: <hqlV0V0VwuCT1P3rCkojxWDjE5Z7ziQFAy5px9bkYnc=.ab406dfd-a7af-4d7a-ab1d-de7ed98e67e3@github.com>

> Convert javax/swing/text/html/TableView/7030332/bug7030332.java applet test to main based test using PassFailJFrame.

Tejesh R has updated the pull request incrementally with one additional commit since the last revision:

  Review updates

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18260/files
  - new: https://git.openjdk.org/jdk/pull/18260/files/8c40a81b..66f9e8e7

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18260&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18260&range=01-02

  Stats: 5 lines in 1 file changed: 3 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/18260.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18260/head:pull/18260

PR: https://git.openjdk.org/jdk/pull/18260

From tr at openjdk.org  Thu Mar 21 05:08:46 2024
From: tr at openjdk.org (Tejesh R)
Date: Thu, 21 Mar 2024 05:08:46 GMT
Subject: RFR: 8328035: Convert
 javax/swing/text/html/TableView/7030332/bug7030332.java applet test to main
 [v2]
In-Reply-To: <LFwpZIQsI6SdPsuJSHwzIJ479SOBQBmlYhsOUeesSbg=.d0eaee7e-3d8b-42d9-9d3c-a12e08b0b6bd@github.com>
References: <sa4wl3VTL1p3Zxmat10wUsqex-uQewN2R2N8tXTwFFo=.013c255b-d875-4b52-a0f0-403664011199@github.com>
 <_k4T1yzAqADVQLTUScWnfSqbGYg-YZJ9SecWpQB55kM=.ffa6e901-7cee-40b6-954a-528dfb04dc83@github.com>
 <LFwpZIQsI6SdPsuJSHwzIJ479SOBQBmlYhsOUeesSbg=.d0eaee7e-3d8b-42d9-9d3c-a12e08b0b6bd@github.com>
Message-ID: <R1x6SOGWD7bpxaAmUDC1ELGiTWXE-Vp_XyRl9VYP2m4=.609999dc-df12-4a51-bd84-8a2d13fe0122@github.com>

On Wed, 20 Mar 2024 23:32:06 GMT, Phil Race <prr at openjdk.org> wrote:

> This test was written before there was hidpi. So I am sure it is 100% so definitely you should specify that in the test to have any chance. The height of the text doesn't matter, nor spacing inside the cells. I'd say it is "similar enough" with 1.0 scaling. There's not been a bug about this yet.

Updated the instructions and scaling set to 1.0.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18260#issuecomment-2011226698

From prr at openjdk.org  Thu Mar 21 05:13:20 2024
From: prr at openjdk.org (Phil Race)
Date: Thu, 21 Mar 2024 05:13:20 GMT
Subject: RFR: 8328035: Convert
 javax/swing/text/html/TableView/7030332/bug7030332.java applet test to main
 [v3]
In-Reply-To: <hqlV0V0VwuCT1P3rCkojxWDjE5Z7ziQFAy5px9bkYnc=.ab406dfd-a7af-4d7a-ab1d-de7ed98e67e3@github.com>
References: <sa4wl3VTL1p3Zxmat10wUsqex-uQewN2R2N8tXTwFFo=.013c255b-d875-4b52-a0f0-403664011199@github.com>
 <hqlV0V0VwuCT1P3rCkojxWDjE5Z7ziQFAy5px9bkYnc=.ab406dfd-a7af-4d7a-ab1d-de7ed98e67e3@github.com>
Message-ID: <Pb_hZxo0dAR7KfSagquNnujK1P40U3huwqMg74aAdcM=.59a8ac4b-c3ac-4c01-946b-a0bd95c0f4d8@github.com>

On Thu, 21 Mar 2024 05:08:46 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Convert javax/swing/text/html/TableView/7030332/bug7030332.java applet test to main based test using PassFailJFrame.
>
> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review updates

Marked as reviewed by prr (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18260#pullrequestreview-1950771985

From tr at openjdk.org  Thu Mar 21 05:14:44 2024
From: tr at openjdk.org (Tejesh R)
Date: Thu, 21 Mar 2024 05:14:44 GMT
Subject: RFR: 8327840: Automate javax/swing/border/Test4129681.java [v4]
In-Reply-To: <BbQ2iwy01dkTxtQ9Aj7RhRkSxWm3pq3BEIlGIzlSTCk=.7bdaafe4-681a-4f03-8462-4ffa7dc99507@github.com>
References: <BbQ2iwy01dkTxtQ9Aj7RhRkSxWm3pq3BEIlGIzlSTCk=.7bdaafe4-681a-4f03-8462-4ffa7dc99507@github.com>
Message-ID: <4w7MNk7DTNfFWhugo3ZSaQesEIGV00_Lv8JKPK5B_ZA=.c3a1c723-3b8d-4064-8b77-96b9f5b86cf8@github.com>

> Automated the Test `javax/swing/border/Test4129681.java` from manual as suggested in JBS description.
> Verified in CI system and its Green. The test has been verified for Metal L&F and the same is set explicitly..

Tejesh R has updated the pull request incrementally with one additional commit since the last revision:

  Review updates

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18336/files
  - new: https://git.openjdk.org/jdk/pull/18336/files/029be55c..4d9cb87e

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18336&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18336&range=02-03

  Stats: 4 lines in 1 file changed: 1 ins; 2 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/18336.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18336/head:pull/18336

PR: https://git.openjdk.org/jdk/pull/18336

From tr at openjdk.org  Thu Mar 21 05:14:44 2024
From: tr at openjdk.org (Tejesh R)
Date: Thu, 21 Mar 2024 05:14:44 GMT
Subject: RFR: 8327840: Automate javax/swing/border/Test4129681.java [v3]
In-Reply-To: <5s8VQMd2rKlq9PjXBcYhjzrvXLuxhkxNF_PWtVznLwU=.7d3efb1f-fa92-4c5b-8ecd-ad48797cb969@github.com>
References: <BbQ2iwy01dkTxtQ9Aj7RhRkSxWm3pq3BEIlGIzlSTCk=.7bdaafe4-681a-4f03-8462-4ffa7dc99507@github.com>
 <7mXA4yB1IQMruvOFP2-u6IIiYPDX-wW8nnTIScNuqPQ=.75f7794c-27f6-4759-b3a2-ff65fbf367b8@github.com>
 <5s8VQMd2rKlq9PjXBcYhjzrvXLuxhkxNF_PWtVznLwU=.7d3efb1f-fa92-4c5b-8ecd-ad48797cb969@github.com>
Message-ID: <mydmCgyOq0MvrCRBWQ9dJVI1jrkT9d_y8kbglcUz9dM=.2f4b8d40-b6d0-4849-a16d-357562fc538c@github.com>

On Wed, 20 Mar 2024 23:13:53 GMT, Phil Race <prr at openjdk.org> wrote:

>> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review updates
>
> test/jdk/javax/swing/border/Test4129681.java line 55:
> 
>> 53: 
>> 54:         UIManager.setLookAndFeel("javax.swing.plaf.metal.MetalLookAndFeel");
>> 55:         System.setProperty("sun.java2d.uiScale", "1.0");
> 
> If you are going to do this in code it needs to be line 1 of main before we call any java.desktop code.
> 
> You can also pass it on the command line of the test
> @run main -Dsun.java2d.uiScale=1 Test4129681

Updated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18336#discussion_r1533256688

From psadhukhan at openjdk.org  Thu Mar 21 05:23:21 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Thu, 21 Mar 2024 05:23:21 GMT
Subject: RFR: 8328540: test javax/swing/JSplitPane/4885629/bug4885629.java
 fails on windows hidpi [v2]
In-Reply-To: <L-JRAXHtrfvl-PVtXI3h2N2VPO9dmleoCrZIMEmtl68=.d495f439-e0b6-4fdc-acdf-8b457fc099a7@github.com>
References: <WHDf1998FlZ19dNxxz-E7M5ZOwJA89v-zgN9zKZ4_V0=.184a9091-6ed1-4a98-8c6f-dba65ce60462@github.com>
 <L-JRAXHtrfvl-PVtXI3h2N2VPO9dmleoCrZIMEmtl68=.d495f439-e0b6-4fdc-acdf-8b457fc099a7@github.com>
Message-ID: <sKXQm9d8Re6XPXELs3sk-kufV9IC703Us8_LMSyUxPg=.c09e002a-327c-4b09-a11d-9f64810f37c2@github.com>

On Wed, 20 Mar 2024 17:38:44 GMT, Phil Race <prr at openjdk.org> wrote:

>> A simple fix to the test to skip sampling the leftmost and rightmost ends of the divider
>> to avoid possible issues at fractional scales.
>
> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8328540

Marked as reviewed by psadhukhan (Reviewer).

test/jdk/javax/swing/JSplitPane/4885629/bug4885629.java line 109:

> 107:                     for (int i = 1; i < rect.width - 1; i++) {
> 108:                         if (!BGCOLOR.equals(robot.getPixelColor(p.x + i, p.y + rect.height - 1))) {
> 109:                             throw new Error("The divider's area has incorrect color. i=" + i);

Should we still use "Error" or use RuntimeException for consistency with other tests?

-------------

PR Review: https://git.openjdk.org/jdk/pull/18384#pullrequestreview-1950781009
PR Review Comment: https://git.openjdk.org/jdk/pull/18384#discussion_r1533262146

From tr at openjdk.org  Thu Mar 21 05:30:25 2024
From: tr at openjdk.org (Tejesh R)
Date: Thu, 21 Mar 2024 05:30:25 GMT
Subject: Integrated: 8328035: Convert
 javax/swing/text/html/TableView/7030332/bug7030332.java applet test to main
In-Reply-To: <sa4wl3VTL1p3Zxmat10wUsqex-uQewN2R2N8tXTwFFo=.013c255b-d875-4b52-a0f0-403664011199@github.com>
References: <sa4wl3VTL1p3Zxmat10wUsqex-uQewN2R2N8tXTwFFo=.013c255b-d875-4b52-a0f0-403664011199@github.com>
Message-ID: <h7tc5QNS8WASF0bkkJaa4Ynk5uRqBMvxb4Vk6N4hovA=.ec488a2c-1605-452f-83a6-0ccaf0cf3f43@github.com>

On Wed, 13 Mar 2024 06:59:02 GMT, Tejesh R <tr at openjdk.org> wrote:

> Convert javax/swing/text/html/TableView/7030332/bug7030332.java applet test to main based test using PassFailJFrame.

This pull request has now been integrated.

Changeset: 481473ef
Author:    Tejesh R <tr at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/481473efce9f51a497e26002c6da52b0ddc9ea8f
Stats:     113 lines in 2 files changed: 33 ins; 71 del; 9 mod

8328035: Convert javax/swing/text/html/TableView/7030332/bug7030332.java applet test to main

Reviewed-by: abhiscxk, prr

-------------

PR: https://git.openjdk.org/jdk/pull/18260

From psadhukhan at openjdk.org  Thu Mar 21 05:33:20 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Thu, 21 Mar 2024 05:33:20 GMT
Subject: RFR: 8328370: Convert java/awt/print/Dialog/PrintApplet.java
 applet test to main [v3]
In-Reply-To: <W6z0LZ1HPa19caIjkQKD-fVGElai98aDMuOkQzfOtvc=.2606585d-acd7-4bf6-a65f-23eeba49aec3@github.com>
References: <Je7yOnjOAjH3DsIgUx72_7ASxsrXS5oIskdKM716AiA=.f1a73b22-8644-40cc-91d6-9ce301f03cc2@github.com>
 <W6z0LZ1HPa19caIjkQKD-fVGElai98aDMuOkQzfOtvc=.2606585d-acd7-4bf6-a65f-23eeba49aec3@github.com>
Message-ID: <xNNo50d-Lcd1K7prAazfarXsRnPQWbzr185YpaoNwq0=.6ec26750-7358-49e1-b6e0-3cf67d5354c4@github.com>

On Wed, 20 Mar 2024 16:26:39 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

>> Convert java/awt/print/Dialog/PrintApplet.java applet test to main using PassFailJFrame. Also rename the test to PrintModalDialog.java since this is no longer an applet. Added test instructions related to the linked JBS issue.
>
> Damon Nguyen has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Modify instructions more
>  - Modify instructions

test/jdk/java/awt/print/Dialog/PrintModalDialog.java line 31:

> 29:  * @build PassFailJFrame
> 30:  * @summary Pass if dialogs are modal.
> 31:  * @run main PrintModalDialog

should be main/manual

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18362#discussion_r1533268931

From tr at openjdk.org  Thu Mar 21 06:32:20 2024
From: tr at openjdk.org (Tejesh R)
Date: Thu, 21 Mar 2024 06:32:20 GMT
Subject: RFR: 8328328: Convert
 javax/swing/JTabbedPane/4666224/bug4666224.java applet test to main [v2]
In-Reply-To: <nbGYCc8iRqT0py3apaNvXYjsB7Pwsjr5mufVrTMZeGk=.9041765b-b92c-46b1-b026-d13ea297dd0c@github.com>
References: <4fqxbuw6GwuEAg6v7kvn72AQC3LeXPodKf8OrBDOr1w=.1cffa811-37e8-4294-b469-6487763bdeed@github.com>
 <nbGYCc8iRqT0py3apaNvXYjsB7Pwsjr5mufVrTMZeGk=.9041765b-b92c-46b1-b026-d13ea297dd0c@github.com>
Message-ID: <Gag6s5UAeN5YHigs62WppJVVk9Jh3x4dQOPH1HkHP1Q=.c5d30754-c457-42a1-9c52-f2873c7b0a6c@github.com>

On Wed, 20 Mar 2024 04:18:46 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Conversion of manual applet test to main based using PassFailJFrame manual framework.
>> 
>> Tested in macOS where it didn't worked for "key press C to change tab layout" else it worked for other "key press (R, B, L, T) to change tab position. So, test is still in problem list.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   minor fix

Marked as reviewed by tr (Committer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18340#pullrequestreview-1950851772

From tr at openjdk.org  Thu Mar 21 06:36:20 2024
From: tr at openjdk.org (Tejesh R)
Date: Thu, 21 Mar 2024 06:36:20 GMT
Subject: RFR: 8328403: Remove applet usage from JColorChooser tests
 Test6977726 [v2]
In-Reply-To: <hPfifnK0UnpXOEtu8Jmp91oFwC_VyjuJeu9CDPQbvaw=.544c5d8c-633e-46b1-855f-c41543164dea@github.com>
References: <pyfxVdApSNSisMJieBTl5HSZKDmSSiPie0tnrM_rwe4=.5ffc4e92-cbcf-44d8-9a51-b4e8330e1be9@github.com>
 <hPfifnK0UnpXOEtu8Jmp91oFwC_VyjuJeu9CDPQbvaw=.544c5d8c-633e-46b1-855f-c41543164dea@github.com>
Message-ID: <3wOB6ZEeVKSHSi_bckFx89MfmyXPs4cDt-2YGXVrBsA=.eaaec3f7-c5ec-4a41-a237-ff5f06d36c89@github.com>

On Wed, 20 Mar 2024 18:02:37 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> Removing applet usage from manual JColorChooser tests
>
> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   spacing

Marked as reviewed by tr (Committer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18369#pullrequestreview-1950856553

From abhiscxk at openjdk.org  Thu Mar 21 07:32:20 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Thu, 21 Mar 2024 07:32:20 GMT
Subject: RFR: 8327980: Convert
 javax/swing/JToggleButton/4128979/bug4128979.java applet test to main [v2]
In-Reply-To: <ZqXC3FEtY0pXKoXFcvxL3z-qR-3RkQZ3LlHPyE2IRzw=.440fd1d1-56b2-47f0-9efc-3b33593edf60@github.com>
References: <lZHt9pYb75UtaIEtbB0paOkfqR5CUAc6tikhb9YAakU=.ff2adbed-1db2-490a-8747-66ac96d03657@github.com>
 <h9V1lpm9LrxoTXicUWMB1SyIDjJmPXlp5ohLCmpt3Kw=.32d56f64-83ae-47cc-86ec-efe8a568e038@github.com>
 <ZqXC3FEtY0pXKoXFcvxL3z-qR-3RkQZ3LlHPyE2IRzw=.440fd1d1-56b2-47f0-9efc-3b33593edf60@github.com>
Message-ID: <_BFUDHspPpPwu_ibRDU9WuZarJMMBDgvDVuTSMRC41M=.f409e015-7891-4bd2-bf72-9c7e7bcc7690@github.com>

On Thu, 14 Mar 2024 17:05:04 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review comment fix
>
> Please remove unused imports

@honkar-jdk @TejeshR13 Test is updated. Please take a look.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18233#issuecomment-2011375527

From abhiscxk at openjdk.org  Thu Mar 21 07:33:26 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Thu, 21 Mar 2024 07:33:26 GMT
Subject: Integrated: 8328328: Convert
 javax/swing/JTabbedPane/4666224/bug4666224.java applet test to main
In-Reply-To: <4fqxbuw6GwuEAg6v7kvn72AQC3LeXPodKf8OrBDOr1w=.1cffa811-37e8-4294-b469-6487763bdeed@github.com>
References: <4fqxbuw6GwuEAg6v7kvn72AQC3LeXPodKf8OrBDOr1w=.1cffa811-37e8-4294-b469-6487763bdeed@github.com>
Message-ID: <DeSPrS-3NcKGajS2ZoOjS56MMTcxK1pWdlS13Bg0zoA=.2655b632-3161-4fca-8729-88c3aad66945@github.com>

On Mon, 18 Mar 2024 07:45:42 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

> Conversion of manual applet test to main based using PassFailJFrame manual framework.
> 
> Tested in macOS where it didn't worked for "key press C to change tab layout" else it worked for other "key press (R, B, L, T) to change tab position. So, test is still in problem list.

This pull request has now been integrated.

Changeset: 65d9f119
Author:    Abhishek Kumar <abhiscxk at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/65d9f119c401c26c9a6436f5c9a513f91bb8c753
Stats:     783 lines in 4 files changed: 168 ins; 614 del; 1 mod

8328328: Convert javax/swing/JTabbedPane/4666224/bug4666224.java applet test to main

Reviewed-by: honkar, tr

-------------

PR: https://git.openjdk.org/jdk/pull/18340

From abhiscxk at openjdk.org  Thu Mar 21 07:41:23 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Thu, 21 Mar 2024 07:41:23 GMT
Subject: RFR: 8328560:
 java/awt/event/MouseEvent/ClickDuringKeypress/ClickDuringKeypress.java imports
 Applet [v3]
In-Reply-To: <SzK00U5knwjBuF02eZ4lTeZCjEU4psOMMt4--4x7zPU=.99180333-c818-4e1c-b3bb-071aa49d6bc2@github.com>
References: <DAGMk9laOuahpyUEepWDE92N94zIbgNOWgaIgQFIurs=.602f3b0a-e0dd-49ee-9075-12961ef49611@github.com>
 <SzK00U5knwjBuF02eZ4lTeZCjEU4psOMMt4--4x7zPU=.99180333-c818-4e1c-b3bb-071aa49d6bc2@github.com>
Message-ID: <u3BvOspPH8XxrYzXvKCAMiaTBywkcrbq9Nk3y_NMSew=.d433ee4e-d1f0-48dc-92f0-40400c8d7426@github.com>

On Wed, 20 Mar 2024 23:45:31 GMT, Phil Race <prr at openjdk.org> wrote:

>> This seems to have been some previous not very complete conversion of a test from applet to main.
>> It even still had Applet imported and miscellaneous comments. I've cleaned it up.
>
> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8328560

Marked as reviewed by abhiscxk (Committer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18386#pullrequestreview-1950983863

From abhiscxk at openjdk.org  Thu Mar 21 07:44:22 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Thu, 21 Mar 2024 07:44:22 GMT
Subject: RFR: 8328005: Convert java/awt/im/JTextFieldTest.java applet test
 to main [v4]
In-Reply-To: <M1vo4AmKe8F14Ot3-1JJBQuEg05q6MyAvrKUrKaItXs=.343f5a2a-f341-4fbd-8264-1059b2b19009@github.com>
References: <L1GhxeYrU35BXYEe9h_FL05fGrPgE7q4vWv3qTOe854=.c20a5812-ec96-4541-94b8-106dd17d9f95@github.com>
 <M1vo4AmKe8F14Ot3-1JJBQuEg05q6MyAvrKUrKaItXs=.343f5a2a-f341-4fbd-8264-1059b2b19009@github.com>
Message-ID: <KxrDfNTAgEatzegCuvj9EFItMzamexP3KWTcOxp3UPQ=.eee80fc4-c62c-42ec-8212-73af42380897@github.com>

On Mon, 18 Mar 2024 17:40:03 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

>> Convert java/awt/im/JTextFieldTest.java applet test to main using PassFailJFrame.
>
> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove reundant window constant

Marked as reviewed by abhiscxk (Committer).

test/jdk/java/awt/im/JTextFieldTest.java line 32:

> 30:  *           work correctly with IM when there is an uneditable peered
> 31:  *           TextField/TextArea in the same parent Frame
> 32:  * @run main JTextFieldTest

should be main/manual ?

test/jdk/java/awt/im/JTextFieldTest.java line 42:

> 40: 
> 41: public class JTextFieldTest {
> 42:     private static JFrame frame;

can be moved to local scope in `createAndShowGUI` method.

-------------

PR Review: https://git.openjdk.org/jdk/pull/18247#pullrequestreview-1950991412
PR Review Comment: https://git.openjdk.org/jdk/pull/18247#discussion_r1533367255
PR Review Comment: https://git.openjdk.org/jdk/pull/18247#discussion_r1533367750

From psadhukhan at openjdk.org  Thu Mar 21 08:57:57 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Thu, 21 Mar 2024 08:57:57 GMT
Subject: RFR: 8328570: Convert closed JViewport manual applet tests to main
 [v2]
In-Reply-To: <JPXMrCOWFS4MTSQbiUtkH4egvJSxnapo0H0ndavn_8s=.cb76f5e5-a401-432f-83ea-8103eb3cf980@github.com>
References: <JPXMrCOWFS4MTSQbiUtkH4egvJSxnapo0H0ndavn_8s=.cb76f5e5-a401-432f-83ea-8103eb3cf980@github.com>
Message-ID: <VYA9PSV_OPngPpPLDL5edRtaEZ14OFZ2JZ7wtJtwDaA=.3240c247-8fae-4e87-b6e1-72971a1da273@github.com>

> Few closed manual applet JViewport tests are converted to main based and opensourced

Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:

  getCOntentPane removed

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18418/files
  - new: https://git.openjdk.org/jdk/pull/18418/files/7783bf97..395730f3

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18418&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18418&range=00-01

  Stats: 3 lines in 1 file changed: 0 ins; 1 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/18418.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18418/head:pull/18418

PR: https://git.openjdk.org/jdk/pull/18418

From psadhukhan at openjdk.org  Thu Mar 21 09:08:34 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Thu, 21 Mar 2024 09:08:34 GMT
Subject: RFR: 8328673: Convert closed text/html/CSS manual applet test to main
Message-ID: <RUcdacOwzVskVmCK0_t8P42j-h9BEtAsuZqgKvM7uuc=.3ffd2bf8-a98b-46ef-8608-31142321e464@github.com>

Couple closed manual applet text/html/CSS tests are converted to main based and opensourced

-------------

Commit messages:
 - 8328673: Convert closed text/html/CSS manual applet test to main

Changes: https://git.openjdk.org/jdk/pull/18424/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18424&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8328673
  Stats: 162 lines in 2 files changed: 162 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18424.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18424/head:pull/18424

PR: https://git.openjdk.org/jdk/pull/18424

From tr at openjdk.org  Thu Mar 21 09:29:21 2024
From: tr at openjdk.org (Tejesh R)
Date: Thu, 21 Mar 2024 09:29:21 GMT
Subject: RFR: 8327980: Convert
 javax/swing/JToggleButton/4128979/bug4128979.java applet test to main [v5]
In-Reply-To: <CI5b0LRpMwIQQULd-K7SL1T_xzTJLAhswbc-1e9WpkE=.2eeaf569-0069-4f6a-898b-1c7f8df13e0a@github.com>
References: <lZHt9pYb75UtaIEtbB0paOkfqR5CUAc6tikhb9YAakU=.ff2adbed-1db2-490a-8747-66ac96d03657@github.com>
 <CI5b0LRpMwIQQULd-K7SL1T_xzTJLAhswbc-1e9WpkE=.2eeaf569-0069-4f6a-898b-1c7f8df13e0a@github.com>
Message-ID: <gduAtj-1ngdFC1m9H7pV6NsDxcsagbbB6Id3ih0j988=.0696e060-4015-4d02-a891-b74dca04730f@github.com>

On Wed, 20 Mar 2024 08:30:36 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Conversion of manual applet test to main based using PassFailJFrame manual framework
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review comment update

Looks good now.

-------------

Marked as reviewed by tr (Committer).

PR Review: https://git.openjdk.org/jdk/pull/18233#pullrequestreview-1951408134

From tr at openjdk.org  Thu Mar 21 10:07:21 2024
From: tr at openjdk.org (Tejesh R)
Date: Thu, 21 Mar 2024 10:07:21 GMT
Subject: RFR: JDK-8328299 : Convert DnDFileGroupDescriptor.html applet test
 to main [v3]
In-Reply-To: <zNA15wmuzruwy_2_G9oae82fpKpIBEmUZfayih0YrK0=.b86e5a2b-360b-4f88-8c26-7f4a81bf130d@github.com>
References: <CTOJXaNDso7Gmw-A2kTkmsZmAWqcWllOim2Y_BGgeok=.5d62efd5-66c2-47a7-b1f0-c10f4c366b40@github.com>
 <zNA15wmuzruwy_2_G9oae82fpKpIBEmUZfayih0YrK0=.b86e5a2b-360b-4f88-8c26-7f4a81bf130d@github.com>
Message-ID: <tDFnGOKkv_f4X_l9PdET3Lx817ABxqbWpKmUJdSg7SM=.a713102f-6e49-4fd5-a877-46167e2cca03@github.com>

On Thu, 21 Mar 2024 00:12:45 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Following test java/awt/dnd/DnDFileGroupDescriptor/DnDFileGroupDescriptor.html is converted to main using PassFailJFrame.
>> 
>> This test is currently problem-listed on macOS and linux, but as per the previous JBS bugs [[JDK-6242241](https://bugs.openjdk.org/browse/JDK-6242241), [JDK-8080185](https://bugs.openjdk.org/browse/JDK-8080185), [JDK-7147083](https://bugs.openjdk.org/browse/JDK-7147083)] this test was original created for testing DnD of MS Outlook attachments on Windows system.
>> 
>> Based on the test history and JBS details, I believe this should be windows-only test and should NOT be problemlisted on macOS and linux as it is **not applicable**.
>
> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   problemlist updated

Looks good to me.

-------------

Marked as reviewed by tr (Committer).

PR Review: https://git.openjdk.org/jdk/pull/18335#pullrequestreview-1951568475

From tr at openjdk.org  Thu Mar 21 10:10:21 2024
From: tr at openjdk.org (Tejesh R)
Date: Thu, 21 Mar 2024 10:10:21 GMT
Subject: RFR: 8328194: Add a test to check default rendering engine
In-Reply-To: <xxsxmOwVdXyBrSIp2WwIQ3_RvWLBL5KORk_X6bNkAnU=.588f07e6-2967-4d9e-a780-046af14d2ca1@github.com>
References: <xxsxmOwVdXyBrSIp2WwIQ3_RvWLBL5KORk_X6bNkAnU=.588f07e6-2967-4d9e-a780-046af14d2ca1@github.com>
Message-ID: <P6xUmRibImsJpETQzXs1sYGvHhoe1vw_SN8j3HgqU78=.64c180a2-2e8b-440d-bd39-fdf5a3c1437e@github.com>

On Thu, 14 Mar 2024 20:13:58 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

> This is a request to forward port the test added by the [JDK-8241307](https://bugs.openjdk.org/browse/JDK-8241307) with inverted condition - jdk jdk11 the marlin should be used by default.

Marked as reviewed by tr (Committer).

test/jdk/sun/java2d/marlin/DefaultRenderingEngine.java line 26:

> 24: import sun.java2d.pipe.RenderingEngine;
> 25: 
> 26: /**

Minor observation - Additional asterisk not required I guess.

-------------

PR Review: https://git.openjdk.org/jdk/pull/18313#pullrequestreview-1951582788
PR Review Comment: https://git.openjdk.org/jdk/pull/18313#discussion_r1533572180

From rkannathpari at openjdk.org  Thu Mar 21 10:32:26 2024
From: rkannathpari at openjdk.org (Renjith Kannath Pariyangad)
Date: Thu, 21 Mar 2024 10:32:26 GMT
Subject: Integrated: JDK-8320675 : PrinterJob/SecurityDialogTest.java hangs
In-Reply-To: <OMBWLwH7044RMtwdrZSiahQDdy-1T-4oJjOQgnQEKjI=.18a31ad0-710f-44e5-86ec-b4566946b063@github.com>
References: <OMBWLwH7044RMtwdrZSiahQDdy-1T-4oJjOQgnQEKjI=.18a31ad0-710f-44e5-86ec-b4566946b063@github.com>
Message-ID: <qSQ5B02HeG6DgAbs3ePqgPxa_GPzERmw32DowQJ_0N8=.f2ba180f-7723-4d85-821d-9d1a9b17b7db@github.com>

On Thu, 14 Mar 2024 11:52:09 GMT, Renjith Kannath Pariyangad <rkannathpari at openjdk.org> wrote:

> Hi Reviewers,
> 
> I have updated the test with  PassFailJFrame with information panel, earlier this was informed through terminal.
> Please review and let me know your suggestions if any.

This pull request has now been integrated.

Changeset: 9f5ad433
Author:    Renjith Kannath Pariyangad <rkannathpari at openjdk.org>
Committer: Tejesh R <tr at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/9f5ad43358a4e209b4cd1c91bcc86b997f371548
Stats:     238 lines in 1 file changed: 54 ins; 154 del; 30 mod

8320675: PrinterJob/SecurityDialogTest.java hangs

Co-authored-by: Alexey Ivanov <aivanov at openjdk.org>
Reviewed-by: aivanov, tr

-------------

PR: https://git.openjdk.org/jdk/pull/18299

From tr at openjdk.org  Thu Mar 21 10:39:23 2024
From: tr at openjdk.org (Tejesh R)
Date: Thu, 21 Mar 2024 10:39:23 GMT
Subject: RFR: 8328562: Convert
 java/awt/InputMethods/DiacriticsTest/DiacriticsTest.java applet test to main
In-Reply-To: <dwZXmqAjKVfX0Z4xfEfCJvsNmm7pOSYZTOk30-vPIF8=.0e29c1cf-580c-4898-9b94-7aaddec86add@github.com>
References: <dwZXmqAjKVfX0Z4xfEfCJvsNmm7pOSYZTOk30-vPIF8=.0e29c1cf-580c-4898-9b94-7aaddec86add@github.com>
Message-ID: <YU3_RTFdP62OP3MqGL-MYq4BBzkNWZcfuFxx9PNKL7g=.213060f0-9023-4b35-9a0a-511f802cb4b6@github.com>

On Wed, 20 Mar 2024 03:09:32 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

> Test converted to main.
> Instructions split to Windows and Linux, with some clarifications.
> The test runs successfully on Windows and Linux.

Marked as reviewed by tr (Committer).

test/jdk/java/awt/InputMethods/DiacriticsTest/DiacriticsTest.java line 25:

> 23: 
> 24: 
> 25: import jdk.test.lib.Platform;

Minor one - Additional line space before imports can be removed.

test/jdk/java/awt/InputMethods/DiacriticsTest/DiacriticsTest.java line 39:

> 37:  * @build PassFailJFrame jdk.test.lib.Platform
> 38:  * @run main/manual DiacriticsTest
> 39: */

Another minor observation - One space before asterisk. 
Else it looks good to me.

-------------

PR Review: https://git.openjdk.org/jdk/pull/18388#pullrequestreview-1951695172
PR Review Comment: https://git.openjdk.org/jdk/pull/18388#discussion_r1533618831
PR Review Comment: https://git.openjdk.org/jdk/pull/18388#discussion_r1533619460

From tr at openjdk.org  Thu Mar 21 10:50:23 2024
From: tr at openjdk.org (Tejesh R)
Date: Thu, 21 Mar 2024 10:50:23 GMT
Subject: RFR: JDK-8328398 : Convert java/awt/im/4490692/bug4490692.html
 applet test to main [v2]
In-Reply-To: <aS6ATocsIxgP1ABKQTve2waCy-MeH92snBcEZJftr9s=.24f93a07-f2b6-4608-9785-53b0399fcd03@github.com>
References: <lcESN0hyfRYfuC2nnzmBSQrUQLmHHD6uooae53vTzWA=.682e9e1e-d3cb-4b2e-bc95-9bdd9d709f6f@github.com>
 <aS6ATocsIxgP1ABKQTve2waCy-MeH92snBcEZJftr9s=.24f93a07-f2b6-4608-9785-53b0399fcd03@github.com>
Message-ID: <kRG-4TbJgvQo7KZj9pgN04EdJ58vPlTWChimFykAzTc=.fa85283b-de29-4932-937c-8f94c2888f87@github.com>

On Wed, 20 Mar 2024 16:59:47 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Following test is converted from applet to main using PassFailJFrame.
>> 
>> The original test had ignore tag - **The fix for this problem was backed out for 5057184.  Remove this "ignore" tag when it is fixed again.**
>> I believe this was fixed and the test works correctly on Linux platforms, hence ignore tag has been removed.
>> 
>> This is a semi-automated test, the first check is manual and the 2nd one is automated. Details in the test instructions.
>
> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   instruction line length

test/jdk/java/awt/im/bug4490692.java line 81:

> 79: 
> 80: class TestFrame extends JFrame implements KeyListener {
> 81:     JTextField text;

text can be moved inside constructor, any reason why it is here?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18402#discussion_r1533639696

From abhiscxk at openjdk.org  Thu Mar 21 10:50:36 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Thu, 21 Mar 2024 10:50:36 GMT
Subject: RFR: 8328670: Automate and open source few closed manual applet test
Message-ID: <ekaFQm1J1iN3WflMPr1EjImabwkt3O6QIB733BF1Kss=.82bb6086-fe25-46f2-916f-67a458eb6f3f@github.com>

Few manual closed applet test converted to automated and open sourced.

-------------

Commit messages:
 - Open source manual applet test

Changes: https://git.openjdk.org/jdk/pull/18428/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18428&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8328670
  Stats: 291 lines in 2 files changed: 291 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18428.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18428/head:pull/18428

PR: https://git.openjdk.org/jdk/pull/18428

From aivanov at openjdk.org  Thu Mar 21 10:59:21 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Thu, 21 Mar 2024 10:59:21 GMT
Subject: RFR: 8328238: Convert few closed manual applet tests to main [v4]
In-Reply-To: <GPgTBSJ2AzCGJj9pvE2kq-4cAn_h5gJrY0mcN0_xg_4=.5b35d33d-067b-4492-a47f-e51a29bc2a8a@github.com>
References: <9uKHIdC_4RNWN6ecB8Es2dtAjhmMgTvQIrDMWmPJzfs=.39bb9943-81f5-4cae-8644-a1eaf45d82d6@github.com>
 <0-d5jlP4-aMbgEE1MS9GuMonUlQ09R9SOy_efIHLSsA=.754d7aac-e39d-4da7-9e26-7a1f8d081325@github.com>
 <lhycotfs4KOEBKBMAM3JYrrCFtiPOqHU2EUJ3iJuyYE=.94bdb6b0-880c-4117-8db5-948a7e941a97@github.com>
 <GPgTBSJ2AzCGJj9pvE2kq-4cAn_h5gJrY0mcN0_xg_4=.5b35d33d-067b-4492-a47f-e51a29bc2a8a@github.com>
Message-ID: <ds719tkaJryeuJrHHjxtNsqsS0ap8AYir8Qosd0lrmM=.35cab5d4-4dc9-4f8d-8155-7297915830ae@github.com>

On Thu, 21 Mar 2024 03:13:45 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> test/jdk/javax/swing/JFrame/bug4419914.java line 71:
>> 
>>> 69:         frame.enableInputMethods(false);
>>> 70:         frame.getContentPane().setComponentOrientation(ComponentOrientation.RIGHT_TO_LEFT);
>>> 71:         frame.getContentPane().setLocale(Locale.ENGLISH);
>> 
>> The requirement to use getContentPane() has been obsolete since JDK 1.5 ...
>> here's an external page about it https://coderanch.com/t/345686/java/getContentPane
>> But I don't generally tell people to delete except here there are 9 calls cluttering up this code.
>> So not critical, but a suggestion.
>
> Thanks for the information, didn't know that..Updated....there is around ~400 occurrence of getContentPane() in swing tests in open still so probably something to be optimised in future...

The tests were probably written before Java 5, even tests written later could still use `getContentPane` so that the test could be run with previous versions of Java. Yet it's irrelevant now.

The Java Tutorials have never been updated, [How to Make Frames](https://docs.oracle.com/javase/tutorial/uiswing/components/frame.html) uses `getContentPane` explicitly.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18390#discussion_r1533657135

From aivanov at openjdk.org  Thu Mar 21 11:02:21 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Thu, 21 Mar 2024 11:02:21 GMT
Subject: RFR: 8328238: Convert few closed manual applet tests to main [v6]
In-Reply-To: <r4kDhlC11qsuUxWu9jWrfmhVDhFqbtvuZPSyaKwtUKg=.a5180e7f-226f-4f52-9c53-ef91cdbc392c@github.com>
References: <9uKHIdC_4RNWN6ecB8Es2dtAjhmMgTvQIrDMWmPJzfs=.39bb9943-81f5-4cae-8644-a1eaf45d82d6@github.com>
 <r4kDhlC11qsuUxWu9jWrfmhVDhFqbtvuZPSyaKwtUKg=.a5180e7f-226f-4f52-9c53-ef91cdbc392c@github.com>
Message-ID: <YD4sy9WCGYWepVFOpOAJQNJ_0j5m6xdEwSDSmd2BFy0=.947980ac-ff06-4998-a833-763ce777c685@github.com>

On Thu, 21 Mar 2024 03:28:56 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Few closed manual applet tests are converted to main based and opensourced
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove getContentPane from other tests

Marked as reviewed by aivanov (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18390#pullrequestreview-1951802558

From aivanov at openjdk.org  Thu Mar 21 11:06:21 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Thu, 21 Mar 2024 11:06:21 GMT
Subject: RFR: JDK-8328190 : Convert AWTPanelSmoothWheel.html applet test to
 main [v4]
In-Reply-To: <RNTVmxm4AVVoz0DzJZdrH5FyUcophSH9HKkUuPTptog=.ef9ed3bf-4723-417b-9f1d-f37c0e43c908@github.com>
References: <sn9qb9ctS_sr3isHbwcbMCYh2RQokz2ptsw0rGBRnJY=.955d7549-72c7-4a4f-8ac8-a5d6f122cf68@github.com>
 <p8toDCsUN5dAL4dDyYVndsUESgStV4k9kaORTsC30T0=.1bb5f251-baa8-4eb9-9edf-7a01bb004824@github.com>
 <nLixT1Ds_Q4bojPE3dVPNJsP7npWOCXTeQnXjuNBjDI=.3e97d089-79b2-411b-9481-bf3c5a05bdca@github.com>
 <uLSpcviVXqraUZeDbvH3walaOGIGg1iCGcz8AMDv2oA=.e805c1f3-14b5-4855-9399-ef9693c8b11d@github.com>
 <85j81nCQpt1zZUA7YK2kk8s86L1ZqLhs406hVKcWsMw=.51d17fec-616e-4a25-9f79-dfcc449f7896@github.com>
 <RNTVmxm4AVVoz0DzJZdrH5FyUcophSH9HKkUuPTptog=.ef9ed3bf-4723-417b-9f1d-f37c0e43c908@github.com>
Message-ID: <NnkifLAJTQ6PdTqSn5mbutgKD8CVI1MKaXIHmuCZYw4=.415eb6d2-e468-4bf0-ae5e-81c10f43f26d@github.com>

On Thu, 21 Mar 2024 01:16:03 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> I think we should update the instructions.
>> 
>> A high resolution mouse produces events like this:
>> 
>> java.awt.event.MouseWheelEvent[MOUSE_WHEEL,(164,90),absolute(1135,365),button=0,clickCount=0,scrollType=WHEEL_UNIT_SCROLL,scrollAmount=3,wheelRotation=0,preciseWheelRotation=0.25] on panel0
>> java.awt.event.MouseWheelEvent[MOUSE_WHEEL,(164,90),absolute(1135,365),button=0,clickCount=0,scrollType=WHEEL_UNIT_SCROLL,scrollAmount=3,wheelRotation=0,preciseWheelRotation=0.25] on panel0
>> java.awt.event.MouseWheelEvent[MOUSE_WHEEL,(164,90),absolute(1135,365),button=0,clickCount=0,scrollType=WHEEL_UNIT_SCROLL,scrollAmount=3,wheelRotation=0,preciseWheelRotation=0.25] on panel0
>> java.awt.event.MouseWheelEvent[MOUSE_WHEEL,(133,46),absolute(1104,321),button=0,clickCount=0,scrollType=WHEEL_UNIT_SCROLL,scrollAmount=3,wheelRotation=1,preciseWheelRotation=1.0] on panel0
>> 
>> 
>> Thus, `wheelRotation=0` while `preciseWheelRotation=0.25`. When it reaches, `preciseWheelRotation=1.0`, the event contains **`wheelRotation=1`**.
>> 
>> A regular mouse with mouse-wheel notches produces the following events:
>> 
>> java.awt.event.MouseWheelEvent[MOUSE_WHEEL,(90,115),absolute(1061,390),button=0,clickCount=0,scrollType=WHEEL_UNIT_SCROLL,scrollAmount=3,wheelRotation=1,preciseWheelRotation=1.0] on panel0
>> java.awt.event.MouseWheelEvent[MOUSE_WHEEL,(176,76),absolute(1147,351),button=0,clickCount=0,scrollType=WHEEL_UNIT_SCROLL,scrollAmount=3,wheelRotation=1,preciseWheelRotation=1.0] on panel0
>> 
>> 
>> As you can see, `scrollType=WHEEL_UNIT_SCROLL` is the same in both cases. The only difference is that high-resolution mouse produces events where **`preciseWheelRotation < 1.0`**.
>> 
>> This means that you should also track the value of `preciseWheelRotation`. Otherwise, the test will pass when a regular mouse is used.
>> 
>> You may show a warning to the user if you detect, let's say, 5 events with `wheelRotation=1` but none of the events had `wheelRotation=0` and `preciseWheelRotation < 1.0`.
>
> @aivanov-jdk Since preciseWheelRotation amount depends on user's movement of the high-res mouse and there might be a need to look through logs for few events, it is better to convert this test from semi-automated to manual. Does this sound good? 
> Updated the PR with the latest changes.

@honkar-jdk I think the test could still remain semi-automatic. Can the test verify the conditions? I see no reason why it can't? yet it requires more code. It can be postponed to a later time, if necessary.

I don't think we should make the tester read the log and verify the conditions which can be verified automatically.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18312#discussion_r1533668635

From abhiscxk at openjdk.org  Thu Mar 21 11:07:20 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Thu, 21 Mar 2024 11:07:20 GMT
Subject: RFR: 8328673: Convert closed text/html/CSS manual applet test to
 main
In-Reply-To: <RUcdacOwzVskVmCK0_t8P42j-h9BEtAsuZqgKvM7uuc=.3ffd2bf8-a98b-46ef-8608-31142321e464@github.com>
References: <RUcdacOwzVskVmCK0_t8P42j-h9BEtAsuZqgKvM7uuc=.3ffd2bf8-a98b-46ef-8608-31142321e464@github.com>
Message-ID: <iJRj8mzcKKVDkRT3ABV5q5T3gTGQ9GslaueK3Ooj4I4=.e142d492-422a-49ce-b4b4-a762ac44b5d5@github.com>

On Thu, 21 Mar 2024 09:04:19 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> Couple closed manual applet text/html/CSS tests are converted to main based and opensourced

Please update the library path.

test/jdk/javax/swing/text/html/CSS/bug4271058.java line 28:

> 26:  * @bug 4270889 4271058 4285098
> 27:  * @summary Tests that <table border>, <table align> and <td width> tags work
> 28:  * @library /open/test/jdk/java/awt/regtesthelpers

Need to remove "/open/test/jdk" here and in other test also.

-------------

Marked as reviewed by abhiscxk (Committer).

PR Review: https://git.openjdk.org/jdk/pull/18424#pullrequestreview-1951812458
PR Review Comment: https://git.openjdk.org/jdk/pull/18424#discussion_r1533665496

From abhiscxk at openjdk.org  Thu Mar 21 11:14:21 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Thu, 21 Mar 2024 11:14:21 GMT
Subject: RFR: 8328570: Convert closed JViewport manual applet tests to main
 [v2]
In-Reply-To: <VYA9PSV_OPngPpPLDL5edRtaEZ14OFZ2JZ7wtJtwDaA=.3240c247-8fae-4e87-b6e1-72971a1da273@github.com>
References: <JPXMrCOWFS4MTSQbiUtkH4egvJSxnapo0H0ndavn_8s=.cb76f5e5-a401-432f-83ea-8103eb3cf980@github.com>
 <VYA9PSV_OPngPpPLDL5edRtaEZ14OFZ2JZ7wtJtwDaA=.3240c247-8fae-4e87-b6e1-72971a1da273@github.com>
Message-ID: <u7dDqgeFXFWxglW6HBIa1WpDqmOEpEgWc5q43b6uSQE=.261d5204-c6de-4c61-bce1-8cbdc3ab8705@github.com>

On Thu, 21 Mar 2024 08:57:57 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Few closed manual applet JViewport tests are converted to main based and opensourced
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   getCOntentPane removed

Minor suggestion

test/jdk/javax/swing/JViewport/bug4137282.java line 32:

> 30:  * @build PassFailJFrame
> 31:  * @run main/manual bug4137282
> 32: */

Suggestion:

 */

test/jdk/javax/swing/JViewport/bug4217252.java line 31:

> 29:  * @build PassFailJFrame
> 30:  * @run main/manual bug4217252
> 31: */

Suggestion:

 */

test/jdk/javax/swing/JViewport/bug4243479.java line 31:

> 29:  * @build PassFailJFrame
> 30:    @run main/manual bug4243479
> 31: */

Suggestion:

 */

test/jdk/javax/swing/JViewport/bug4750421.java line 31:

> 29:  * @build PassFailJFrame
> 30:  * @run main/manual bug4750421
> 31: */

Suggestion:

 */

-------------

Marked as reviewed by abhiscxk (Committer).

PR Review: https://git.openjdk.org/jdk/pull/18418#pullrequestreview-1951827393
PR Review Comment: https://git.openjdk.org/jdk/pull/18418#discussion_r1533670823
PR Review Comment: https://git.openjdk.org/jdk/pull/18418#discussion_r1533672019
PR Review Comment: https://git.openjdk.org/jdk/pull/18418#discussion_r1533674332
PR Review Comment: https://git.openjdk.org/jdk/pull/18418#discussion_r1533674808

From aivanov at openjdk.org  Thu Mar 21 11:19:20 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Thu, 21 Mar 2024 11:19:20 GMT
Subject: RFR: 8328402: Implement pausing functionality for the
 PassFailJFrame [v2]
In-Reply-To: <lht-2bR5LdbhrTq3OdbC96MoLbSYVaw2yItOrQTpu2c=.036e2133-3c64-44ba-9133-e865fcc512e8@github.com>
References: <_G5oabZhLzV7Ld3agI-uiRKWhJL5_8i8LVWA7JSBhOM=.c025ce82-16ed-4b8d-8e2b-1a8bc849639c@github.com>
 <lht-2bR5LdbhrTq3OdbC96MoLbSYVaw2yItOrQTpu2c=.036e2133-3c64-44ba-9133-e865fcc512e8@github.com>
Message-ID: <UVpC5H68UrZzpFfNRRgdH3os7Epr7c2C3N-wH-ILiZU=.d655981d-6ae1-4670-99b2-b2f2fe33e064@github.com>

On Wed, 20 Mar 2024 20:25:33 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>>> we need to add next to Pass/Fail a "Pause Timer" button, that
>> (a) stops the count down
>> (b) changes the Pause Timer to "Resume Timer"
>> ~~(c) disables Pass/Fail until the timer is resumed~~
>> the test will not have to pause or be aware - only the PassFailJFrame machinery.
>> ~~So the tester can do anything they want except exit the test in the paused mode.~~
>> 
>> This PR implements everything except the (c).
>> I see nothing wrong with completing the test from the paused state, and it does not add an extra click.  
>> 
>> 
>> Example screenshots:
>> 
>> ![image](https://github.com/openjdk/jdk/assets/77687766/65d34bf8-1e46-4e68-b39e-a77f257ec3c0)
>> ![image](https://github.com/openjdk/jdk/assets/77687766/3a43e059-2d48-46f3-9d1b-c2ab84fcce37)
>
> Alexander Zvegintsev has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - TimeoutHandler -> TimeoutHandlerPanel
>  - review comments

Marked as reviewed by aivanov (Reviewer).

test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 660:

> 658: 
> 659:             label =  new JLabel("", JLabel.CENTER);
> 660:             button = new JButton(TimeoutHandlerPanel.PAUSE_BUTTON_LABEL);

Suggestion:

            button = new JButton(PAUSE_BUTTON_LABEL);

I believe it can be used directly as in `pauseToggle`.

test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 662:

> 660:             button = new JButton(TimeoutHandlerPanel.PAUSE_BUTTON_LABEL);
> 661: 
> 662:             button.setFocusPainted(false);

I wonder if it's the default focus owner? Should we request focus to `Pass` instead?

-------------

PR Review: https://git.openjdk.org/jdk/pull/18368#pullrequestreview-1951858944
PR Review Comment: https://git.openjdk.org/jdk/pull/18368#discussion_r1533684791
PR Review Comment: https://git.openjdk.org/jdk/pull/18368#discussion_r1533688961

From abhiscxk at openjdk.org  Thu Mar 21 11:26:19 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Thu, 21 Mar 2024 11:26:19 GMT
Subject: RFR: 8328642: Convert applet test
 MouseDraggedOutCauseScrollingTest.html to main
In-Reply-To: <oSOD44PevN840Jv0JaNJLDYYqDna-8qggdwlyEayo9c=.47a9f876-50f8-4cdf-804c-596cb2ac94fb@github.com>
References: <oSOD44PevN840Jv0JaNJLDYYqDna-8qggdwlyEayo9c=.47a9f876-50f8-4cdf-804c-596cb2ac94fb@github.com>
Message-ID: <0lZlSB51hO4GQhliTNmDM6dV2bdDz-cS7Nz4GpiEf-0=.2012aa1a-7fc7-4eff-b652-71be2371931b@github.com>

On Wed, 20 Mar 2024 21:33:04 GMT, Phil Race <prr at openjdk.org> wrote:

> Converts java/awt/List/MouseDraggedOutCauseScrollingTest/MouseDraggedOutCauseScrollingTest.html
> to a main program.

LGTM.

-------------

Marked as reviewed by abhiscxk (Committer).

PR Review: https://git.openjdk.org/jdk/pull/18414#pullrequestreview-1951897660

From psadhukhan at openjdk.org  Thu Mar 21 11:29:26 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Thu, 21 Mar 2024 11:29:26 GMT
Subject: RFR: 8328238: Convert few closed manual applet tests to main [v4]
In-Reply-To: <ds719tkaJryeuJrHHjxtNsqsS0ap8AYir8Qosd0lrmM=.35cab5d4-4dc9-4f8d-8155-7297915830ae@github.com>
References: <9uKHIdC_4RNWN6ecB8Es2dtAjhmMgTvQIrDMWmPJzfs=.39bb9943-81f5-4cae-8644-a1eaf45d82d6@github.com>
 <0-d5jlP4-aMbgEE1MS9GuMonUlQ09R9SOy_efIHLSsA=.754d7aac-e39d-4da7-9e26-7a1f8d081325@github.com>
 <lhycotfs4KOEBKBMAM3JYrrCFtiPOqHU2EUJ3iJuyYE=.94bdb6b0-880c-4117-8db5-948a7e941a97@github.com>
 <GPgTBSJ2AzCGJj9pvE2kq-4cAn_h5gJrY0mcN0_xg_4=.5b35d33d-067b-4492-a47f-e51a29bc2a8a@github.com>
 <ds719tkaJryeuJrHHjxtNsqsS0ap8AYir8Qosd0lrmM=.35cab5d4-4dc9-4f8d-8155-7297915830ae@github.com>
Message-ID: <ghwseMZpf2-I60gnW-LK7it83jEGxwMG5B82cSWmEFc=.42b398c0-66a7-4c2a-93fe-e69b83830264@github.com>

On Thu, 21 Mar 2024 10:56:52 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Thanks for the information, didn't know that..Updated....there is around ~400 occurrence of getContentPane() in swing tests in open still so probably something to be optimised in future...
>
> The tests were probably written before Java 5, even tests written later could still use `getContentPane` so that the test could be run with previous versions of Java. Yet it's irrelevant now.
> 
> The Java Tutorials have never been updated, [How to Make Frames](https://docs.oracle.com/javase/tutorial/uiswing/components/frame.html) uses `getContentPane` explicitly.

Good point..this backward support still keep us using obsolete things..
Java tutorials also there are few bugs like [6417303](https://bugs.openjdk.org/browse/JDK-6417303) which needs fix in the tutorial..dont know whom to ask or can we do it ourselves..

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18390#discussion_r1533704146

From psadhukhan at openjdk.org  Thu Mar 21 11:29:28 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Thu, 21 Mar 2024 11:29:28 GMT
Subject: Integrated: 8328238: Convert few closed manual applet tests to main
In-Reply-To: <9uKHIdC_4RNWN6ecB8Es2dtAjhmMgTvQIrDMWmPJzfs=.39bb9943-81f5-4cae-8644-a1eaf45d82d6@github.com>
References: <9uKHIdC_4RNWN6ecB8Es2dtAjhmMgTvQIrDMWmPJzfs=.39bb9943-81f5-4cae-8644-a1eaf45d82d6@github.com>
Message-ID: <G9xNGgtp0xVwYEsZ4OiKgMxjIBm9cuJ-nDGLeg6RpiM=.29603695-a214-4d39-a1df-8a5ea89a1355@github.com>

On Wed, 20 Mar 2024 05:13:08 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> Few closed manual applet tests are converted to main based and opensourced

This pull request has now been integrated.

Changeset: 68170ae2
Author:    Prasanta Sadhukhan <psadhukhan at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/68170ae22233462e8925c75c4737be7f0ba9353d
Stats:     395 lines in 4 files changed: 395 ins; 0 del; 0 mod

8328238: Convert few closed manual applet tests to main

Reviewed-by: tr, aivanov, prr

-------------

PR: https://git.openjdk.org/jdk/pull/18390

From psadhukhan at openjdk.org  Thu Mar 21 11:34:39 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Thu, 21 Mar 2024 11:34:39 GMT
Subject: RFR: 8328673: Convert closed text/html/CSS manual applet test to
 main [v2]
In-Reply-To: <RUcdacOwzVskVmCK0_t8P42j-h9BEtAsuZqgKvM7uuc=.3ffd2bf8-a98b-46ef-8608-31142321e464@github.com>
References: <RUcdacOwzVskVmCK0_t8P42j-h9BEtAsuZqgKvM7uuc=.3ffd2bf8-a98b-46ef-8608-31142321e464@github.com>
Message-ID: <uAmkG885N1CgAijzfUqKBzSkHzYtmDc3N2KGtPUw1Tk=.055a8cb9-253f-4e18-95ca-ff3e900663ea@github.com>

> Couple closed manual applet text/html/CSS tests are converted to main based and opensourced

Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:

  library path fix

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18424/files
  - new: https://git.openjdk.org/jdk/pull/18424/files/8ff80bbb..d846e61f

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18424&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18424&range=00-01

  Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/18424.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18424/head:pull/18424

PR: https://git.openjdk.org/jdk/pull/18424

From psadhukhan at openjdk.org  Thu Mar 21 11:34:39 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Thu, 21 Mar 2024 11:34:39 GMT
Subject: RFR: 8328673: Convert closed text/html/CSS manual applet test to
 main [v2]
In-Reply-To: <iJRj8mzcKKVDkRT3ABV5q5T3gTGQ9GslaueK3Ooj4I4=.e142d492-422a-49ce-b4b4-a762ac44b5d5@github.com>
References: <RUcdacOwzVskVmCK0_t8P42j-h9BEtAsuZqgKvM7uuc=.3ffd2bf8-a98b-46ef-8608-31142321e464@github.com>
 <iJRj8mzcKKVDkRT3ABV5q5T3gTGQ9GslaueK3Ooj4I4=.e142d492-422a-49ce-b4b4-a762ac44b5d5@github.com>
Message-ID: <RrBWC8Ev5CVqKMtLRfO91kmf2VNpGuMw-f5y3R7drBA=.dc34ae35-2549-41c0-ae52-557b675e503b@github.com>

On Thu, 21 Mar 2024 11:01:55 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   library path fix
>
> test/jdk/javax/swing/text/html/CSS/bug4271058.java line 28:
> 
>> 26:  * @bug 4270889 4271058 4285098
>> 27:  * @summary Tests that <table border>, <table align> and <td width> tags work
>> 28:  * @library /open/test/jdk/java/awt/regtesthelpers
> 
> Need to remove "/open/test/jdk" here and in other test also.

Good catch...forgot to modify while copying...

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18424#discussion_r1533713929

From aivanov at openjdk.org  Thu Mar 21 11:35:31 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Thu, 21 Mar 2024 11:35:31 GMT
Subject: RFR: 8328238: Convert few closed manual applet tests to main [v4]
In-Reply-To: <ghwseMZpf2-I60gnW-LK7it83jEGxwMG5B82cSWmEFc=.42b398c0-66a7-4c2a-93fe-e69b83830264@github.com>
References: <9uKHIdC_4RNWN6ecB8Es2dtAjhmMgTvQIrDMWmPJzfs=.39bb9943-81f5-4cae-8644-a1eaf45d82d6@github.com>
 <0-d5jlP4-aMbgEE1MS9GuMonUlQ09R9SOy_efIHLSsA=.754d7aac-e39d-4da7-9e26-7a1f8d081325@github.com>
 <lhycotfs4KOEBKBMAM3JYrrCFtiPOqHU2EUJ3iJuyYE=.94bdb6b0-880c-4117-8db5-948a7e941a97@github.com>
 <GPgTBSJ2AzCGJj9pvE2kq-4cAn_h5gJrY0mcN0_xg_4=.5b35d33d-067b-4492-a47f-e51a29bc2a8a@github.com>
 <ds719tkaJryeuJrHHjxtNsqsS0ap8AYir8Qosd0lrmM=.35cab5d4-4dc9-4f8d-8155-7297915830ae@github.com>
 <ghwseMZpf2-I60gnW-LK7it83jEGxwMG5B82cSWmEFc=.42b398c0-66a7-4c2a-93fe-e69b83830264@github.com>
Message-ID: <4p2hv5J1NgOM2j1f_j7-JoMqKyYBPYcBSjQTP47BKcU=.1b7c6d70-8d4c-4844-b395-fc8736e97502@github.com>

On Thu, 21 Mar 2024 11:24:45 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> The tests were probably written before Java 5, even tests written later could still use `getContentPane` so that the test could be run with previous versions of Java. Yet it's irrelevant now.
>> 
>> The Java Tutorials have never been updated, [How to Make Frames](https://docs.oracle.com/javase/tutorial/uiswing/components/frame.html) uses `getContentPane` explicitly.
>
> Good point..this backward support still keep us using obsolete things..
> Java tutorials also there are few bugs like [6417303](https://bugs.openjdk.org/browse/JDK-6417303) which needs fix in the tutorial..dont know whom to ask or can we do it ourselves..

You're right. Cleaning up the code makes it easier to read.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18390#discussion_r1533716560

From psadhukhan at openjdk.org  Thu Mar 21 11:37:01 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Thu, 21 Mar 2024 11:37:01 GMT
Subject: RFR: 8328570: Convert closed JViewport manual applet tests to main
 [v3]
In-Reply-To: <JPXMrCOWFS4MTSQbiUtkH4egvJSxnapo0H0ndavn_8s=.cb76f5e5-a401-432f-83ea-8103eb3cf980@github.com>
References: <JPXMrCOWFS4MTSQbiUtkH4egvJSxnapo0H0ndavn_8s=.cb76f5e5-a401-432f-83ea-8103eb3cf980@github.com>
Message-ID: <iscFh0srRuMV_ew8wzdMseWtIRoUghrtqJTooyFCLuw=.0d1d23c9-8e04-4dc9-a790-274f7b457566@github.com>

> Few closed manual applet JViewport tests are converted to main based and opensourced

Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:

  formatting

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18418/files
  - new: https://git.openjdk.org/jdk/pull/18418/files/395730f3..8e177faa

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18418&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18418&range=01-02

  Stats: 3 lines in 3 files changed: 0 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/jdk/pull/18418.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18418/head:pull/18418

PR: https://git.openjdk.org/jdk/pull/18418

From azvegint at openjdk.org  Thu Mar 21 11:37:36 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Thu, 21 Mar 2024 11:37:36 GMT
Subject: RFR: 8328562: Convert
 java/awt/InputMethods/DiacriticsTest/DiacriticsTest.java applet test to main
 [v2]
In-Reply-To: <dwZXmqAjKVfX0Z4xfEfCJvsNmm7pOSYZTOk30-vPIF8=.0e29c1cf-580c-4898-9b94-7aaddec86add@github.com>
References: <dwZXmqAjKVfX0Z4xfEfCJvsNmm7pOSYZTOk30-vPIF8=.0e29c1cf-580c-4898-9b94-7aaddec86add@github.com>
Message-ID: <eUWW4ogTYjEFrcVziWMzKV3a_0rPjxu4pC1hCcBvJAo=.1e5a2146-9598-499e-ae93-4eb6ebc85f90@github.com>

> Test converted to main.
> Instructions split to Windows and Linux, with some clarifications.
> The test runs successfully on Windows and Linux.

Alexander Zvegintsev has updated the pull request incrementally with one additional commit since the last revision:

  minor spacing

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18388/files
  - new: https://git.openjdk.org/jdk/pull/18388/files/73d2d47d..6a6e11ab

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18388&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18388&range=00-01

  Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/18388.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18388/head:pull/18388

PR: https://git.openjdk.org/jdk/pull/18388

From abhiscxk at openjdk.org  Thu Mar 21 11:50:19 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Thu, 21 Mar 2024 11:50:19 GMT
Subject: RFR: 8328648: Remove applet usage from JFileChooser tests
 bug4150029
In-Reply-To: <eTiR35uGxb59RbbKcRAdTrgYkrx4CNmkIWfk63i3sJw=.8771db30-c50e-4c50-ae80-312a7683cc27@github.com>
References: <eTiR35uGxb59RbbKcRAdTrgYkrx4CNmkIWfk63i3sJw=.8771db30-c50e-4c50-ae80-312a7683cc27@github.com>
Message-ID: <N4S2v7jqqxHHuXMsf-t2_LHX7ydlb2EKZgknRKTA9ng=.069d89e9-7d4c-4fb7-ae01-e9c05b4fb1d6@github.com>

On Wed, 20 Mar 2024 22:48:46 GMT, Alisen Chung <achung at openjdk.org> wrote:

> Removing applet usage from manual JFileChooser tests

This test can be converted to automated. Similar issue was resolved for GTK LAF. You can refer https://github.com/openjdk/jdk/pull/11291.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18415#issuecomment-2012056680

From azvegint at openjdk.org  Thu Mar 21 11:51:43 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Thu, 21 Mar 2024 11:51:43 GMT
Subject: RFR: 8328402: Implement pausing functionality for the
 PassFailJFrame [v3]
In-Reply-To: <_G5oabZhLzV7Ld3agI-uiRKWhJL5_8i8LVWA7JSBhOM=.c025ce82-16ed-4b8d-8e2b-1a8bc849639c@github.com>
References: <_G5oabZhLzV7Ld3agI-uiRKWhJL5_8i8LVWA7JSBhOM=.c025ce82-16ed-4b8d-8e2b-1a8bc849639c@github.com>
Message-ID: <QDv6ge_rayEERRfzqUwRg2kfPlozn7EBnhQxrWvCtqE=.31b4ce42-068d-44ea-925d-543372802cb2@github.com>

>> we need to add next to Pass/Fail a "Pause Timer" button, that
> (a) stops the count down
> (b) changes the Pause Timer to "Resume Timer"
> ~~(c) disables Pass/Fail until the timer is resumed~~
> the test will not have to pause or be aware - only the PassFailJFrame machinery.
> ~~So the tester can do anything they want except exit the test in the paused mode.~~
> 
> This PR implements everything except the (c).
> I see nothing wrong with completing the test from the paused state, and it does not add an extra click.  
> 
> 
> Example screenshots:
> 
> ![image](https://github.com/openjdk/jdk/assets/77687766/65d34bf8-1e46-4e68-b39e-a77f257ec3c0)
> ![image](https://github.com/openjdk/jdk/assets/77687766/3a43e059-2d48-46f3-9d1b-c2ab84fcce37)

Alexander Zvegintsev has updated the pull request incrementally with one additional commit since the last revision:

  TimeoutHandlerPanel.PAUSE_BUTTON_LABEL -> PAUSE_BUTTON_LABEL

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18368/files
  - new: https://git.openjdk.org/jdk/pull/18368/files/10f4580e..3005ee64

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18368&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18368&range=01-02

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/18368.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18368/head:pull/18368

PR: https://git.openjdk.org/jdk/pull/18368

From azvegint at openjdk.org  Thu Mar 21 11:51:44 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Thu, 21 Mar 2024 11:51:44 GMT
Subject: RFR: 8328402: Implement pausing functionality for the
 PassFailJFrame [v2]
In-Reply-To: <UVpC5H68UrZzpFfNRRgdH3os7Epr7c2C3N-wH-ILiZU=.d655981d-6ae1-4670-99b2-b2f2fe33e064@github.com>
References: <_G5oabZhLzV7Ld3agI-uiRKWhJL5_8i8LVWA7JSBhOM=.c025ce82-16ed-4b8d-8e2b-1a8bc849639c@github.com>
 <lht-2bR5LdbhrTq3OdbC96MoLbSYVaw2yItOrQTpu2c=.036e2133-3c64-44ba-9133-e865fcc512e8@github.com>
 <UVpC5H68UrZzpFfNRRgdH3os7Epr7c2C3N-wH-ILiZU=.d655981d-6ae1-4670-99b2-b2f2fe33e064@github.com>
Message-ID: <KoWH6-Unlv6oXYk6WGR0koZsFODVcV2Z30vqyilX-CY=.77c9c12a-34de-42a6-9336-5bfbb03de870@github.com>

On Thu, 21 Mar 2024 11:16:29 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> I wonder if it's the default focus owner? 

It is(e.g. with `setFocusPainted(true)`):
![image](https://github.com/openjdk/jdk/assets/77687766/b47e9011-c47d-437d-b9b0-0e4ac88a5c6f)

> Should we request focus to Pass instead?

Probably not, to avoid accidentally passing the test, while hitting the pause is harmless.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18368#discussion_r1533741754

From aivanov at openjdk.org  Thu Mar 21 11:56:20 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Thu, 21 Mar 2024 11:56:20 GMT
Subject: RFR: 8328558: Convert
 javax/swing/JCheckBox/8032667/bug8032667.java applet test to main [v2]
In-Reply-To: <f3-FmlVCJlwmXpzeOSfObwO_jQgM6h20Jv_xFhGK6ZI=.bab9e228-f66b-4ecd-ab3a-26eb02089e8d@github.com>
References: <g745t9uMBoROVg83p-3Hkv9s_BjHREVBFnSBVRBT5s4=.9865582b-5db3-4073-97dd-21625ba72991@github.com>
 <f3-FmlVCJlwmXpzeOSfObwO_jQgM6h20Jv_xFhGK6ZI=.bab9e228-f66b-4ecd-ab3a-26eb02089e8d@github.com>
Message-ID: <ymdldBuvO27BEdgT4ia8USLV5rqJOj3VdychlFSx-3w=.302d496a-c5d2-4299-9a06-22c5f1aac89e@github.com>

On Wed, 20 Mar 2024 22:16:36 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

>> Convert javax/swing/JCheckBox/8032667/bug8032667.java applet test to main using PassFailJFrame
>
> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add new line

test/jdk/javax/swing/JCheckBox/bug8032667.java line 78:

> 76:         final Image image1 = getImage(getCheckBox("Deselected", false));
> 77:         final Image image2 = getImage(getCheckBox("Selected", true));
> 78:         Canvas canvas = new Canvas() {

I recommend using `JPanel` instead of `Canvas`. The former is a Swing lightweight component, whereas the latter is an AWT heavyweight component. It's still better not to mix them.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18403#discussion_r1533748612

From aivanov at openjdk.org  Thu Mar 21 12:00:26 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Thu, 21 Mar 2024 12:00:26 GMT
Subject: RFR: 8328402: Implement pausing functionality for the
 PassFailJFrame [v3]
In-Reply-To: <QDv6ge_rayEERRfzqUwRg2kfPlozn7EBnhQxrWvCtqE=.31b4ce42-068d-44ea-925d-543372802cb2@github.com>
References: <_G5oabZhLzV7Ld3agI-uiRKWhJL5_8i8LVWA7JSBhOM=.c025ce82-16ed-4b8d-8e2b-1a8bc849639c@github.com>
 <QDv6ge_rayEERRfzqUwRg2kfPlozn7EBnhQxrWvCtqE=.31b4ce42-068d-44ea-925d-543372802cb2@github.com>
Message-ID: <TsHA2dU0ZC62_6tp0KQfFK5Zewvs14fNDM9UvINMf4A=.83bebd2d-02a1-471d-9d20-a410b3940e48@github.com>

On Thu, 21 Mar 2024 11:51:43 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>>> we need to add next to Pass/Fail a "Pause Timer" button, that
>> (a) stops the count down
>> (b) changes the Pause Timer to "Resume Timer"
>> ~~(c) disables Pass/Fail until the timer is resumed~~
>> the test will not have to pause or be aware - only the PassFailJFrame machinery.
>> ~~So the tester can do anything they want except exit the test in the paused mode.~~
>> 
>> This PR implements everything except the (c).
>> I see nothing wrong with completing the test from the paused state, and it does not add an extra click.  
>> 
>> 
>> Example screenshots:
>> 
>> ![image](https://github.com/openjdk/jdk/assets/77687766/65d34bf8-1e46-4e68-b39e-a77f257ec3c0)
>> ![image](https://github.com/openjdk/jdk/assets/77687766/3a43e059-2d48-46f3-9d1b-c2ab84fcce37)
>
> Alexander Zvegintsev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   TimeoutHandlerPanel.PAUSE_BUTTON_LABEL -> PAUSE_BUTTON_LABEL

Marked as reviewed by aivanov (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18368#pullrequestreview-1951984347

From azvegint at openjdk.org  Thu Mar 21 12:00:26 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Thu, 21 Mar 2024 12:00:26 GMT
Subject: RFR: 8328560:
 java/awt/event/MouseEvent/ClickDuringKeypress/ClickDuringKeypress.java imports
 Applet [v3]
In-Reply-To: <SzK00U5knwjBuF02eZ4lTeZCjEU4psOMMt4--4x7zPU=.99180333-c818-4e1c-b3bb-071aa49d6bc2@github.com>
References: <DAGMk9laOuahpyUEepWDE92N94zIbgNOWgaIgQFIurs=.602f3b0a-e0dd-49ee-9075-12961ef49611@github.com>
 <SzK00U5knwjBuF02eZ4lTeZCjEU4psOMMt4--4x7zPU=.99180333-c818-4e1c-b3bb-071aa49d6bc2@github.com>
Message-ID: <vjoxQtb2WIUXGpu2uidamUfdPaonzMuGIhnOLcfv3Bc=.0adb0de3-3ad1-4e2f-b523-46d398af6b6f@github.com>

On Wed, 20 Mar 2024 23:45:31 GMT, Phil Race <prr at openjdk.org> wrote:

>> This seems to have been some previous not very complete conversion of a test from applet to main.
>> It even still had Applet imported and miscellaneous comments. I've cleaned it up.
>
> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8328560

Marked as reviewed by azvegint (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18386#pullrequestreview-1951984862

From aivanov at openjdk.org  Thu Mar 21 12:00:27 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Thu, 21 Mar 2024 12:00:27 GMT
Subject: RFR: 8328402: Implement pausing functionality for the
 PassFailJFrame [v2]
In-Reply-To: <KoWH6-Unlv6oXYk6WGR0koZsFODVcV2Z30vqyilX-CY=.77c9c12a-34de-42a6-9336-5bfbb03de870@github.com>
References: <_G5oabZhLzV7Ld3agI-uiRKWhJL5_8i8LVWA7JSBhOM=.c025ce82-16ed-4b8d-8e2b-1a8bc849639c@github.com>
 <lht-2bR5LdbhrTq3OdbC96MoLbSYVaw2yItOrQTpu2c=.036e2133-3c64-44ba-9133-e865fcc512e8@github.com>
 <UVpC5H68UrZzpFfNRRgdH3os7Epr7c2C3N-wH-ILiZU=.d655981d-6ae1-4670-99b2-b2f2fe33e064@github.com>
 <KoWH6-Unlv6oXYk6WGR0koZsFODVcV2Z30vqyilX-CY=.77c9c12a-34de-42a6-9336-5bfbb03de870@github.com>
Message-ID: <MXBEwRDmdVrODNd4eNcPT5EZhxOTiS0XQAbqeC23b4Q=.a0cbd557-8c94-470a-a2cf-e381e845dba3@github.com>

On Thu, 21 Mar 2024 11:48:28 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>> test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 662:
>> 
>>> 660:             button = new JButton(TimeoutHandlerPanel.PAUSE_BUTTON_LABEL);
>>> 661: 
>>> 662:             button.setFocusPainted(false);
>> 
>> I wonder if it's the default focus owner? Should we request focus to `Pass` instead?
>
>> I wonder if it's the default focus owner? 
> 
> It is(e.g. with `setFocusPainted(true)`):
> ![image](https://github.com/openjdk/jdk/assets/77687766/b47e9011-c47d-437d-b9b0-0e4ac88a5c6f)
> 
>> Should we request focus to Pass instead?
> 
> Probably not, to avoid accidentally passing the test, while hitting the pause is harmless.

Not so sure? Pause is not the main control. I guess the focus was in the instructions previously, we could preserve it. It may be not worth it though.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18368#discussion_r1533756608

From duke at openjdk.org  Thu Mar 21 12:02:22 2024
From: duke at openjdk.org (Joel Uckelman)
Date: Thu, 21 Mar 2024 12:02:22 GMT
Subject: RFR: 8305072: Win32ShellFolder2.compareTo is inconsistent [v2]
In-Reply-To: <5btT_N4c5R89DQ8aoSyjm6lIR7PHLWC141uAIdH_Bjw=.f36326e9-0f59-4545-82bf-f3c8b4dbaa87@github.com>
References: <bEiHvkFnBZDqmiqQdk_-_mATVhDbAD7NZX7VnkHLG2E=.27ee84ba-00fd-405a-9489-8fe11c215af9@github.com>
 <21db5CiFTVN7scwsIHknMxF4YaVQd06m7gUOhcCLvMI=.e2f61ea7-bf9a-4632-bf45-c89f979ae806@github.com>
 <6dQg9rhDwh4ZL7D2JfYpA0xNP_eJDbOK3rNgj7efckM=.c5001d8a-cce5-4a11-a91d-eda8e90b8056@github.com>
 <76BSt4HYmTD2DiZzBUvNvBdvd5d1MFinIDsgp2YuHjs=.68646608-e266-4ca3-8495-59e237f8607c@github.com>
 <5btT_N4c5R89DQ8aoSyjm6lIR7PHLWC141uAIdH_Bjw=.f36326e9-0f59-4545-82bf-f3c8b4dbaa87@github.com>
Message-ID: <xEaIYt-r-0MtZBDcpke8dec_MkYGmm_gsj0NcagSMGs=.0f29ce1b-ff4b-4505-9095-5602cdbd3de9@github.com>

On Thu, 14 Mar 2024 16:56:03 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> It is well described in a [JBS comment](https://bugs.openjdk.org/browse/JDK-8305072?focusedId=14610400&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14610400) by the submitter.
>> 
>> Let's consider the failing case where:
>> 
>> a = C:\Users<user>\Documents(true)
>> b = C:\Users<user>(false)
>> c = C:\Users<user>\Documents(false)
>> 
>> The value in parentheses is `isSpecial()` flag.
>> 
>> When `a` and `c` are compared, `special1 = true` and `special2 = false`, therefore the code flow enters this `if`-block. Because the `equals` method doesn't take into account the `isSpecial` flag, both `i1` and `i2` are 0.
>> 
>> https://github.com/openjdk/jdk/blob/7bccc847fe9e8c5e640d8fa9c93ce32563a0ccfa/src/java.desktop/windows/classes/sun/awt/shell/Win32ShellFolderManager2.java#L534-L535
>> 
>> Thus, `a` and `c` are considered equal, which breaks the general contract of [`Comparable.compareTo`](https://docs.oracle.com/en/java/javase/21/docs/api/java.base/java/lang/Comparable.html#compareTo(T)).
>> 
>> If you look below this `if`-statement:
>> 
>> https://github.com/openjdk/jdk/blob/7bccc847fe9e8c5e640d8fa9c93ce32563a0ccfa/src/java.desktop/windows/classes/sun/awt/shell/Win32ShellFolderManager2.java#L545-L550
>> 
>> The comment and the code say that any special folder sorts above any regular folder. Therefore the code shouldn't enter that `if`-block above if *only one* of the folders is *special* ? the order is already well-defined for such case.
>> 
>> The purpose of the `if`-block is to make some of the special folders even more special. In other words, it ensures the following special folders?`getPersonal`, `getDesktop`, `getDrives`, `getNetwork`?are at the top of the list, above any other special folders.
>
> So, changing the condition in the `if`-block from `special1 || special2` to `special1 && special2` makes the sorting order consistent because the relation is now *transitive*:
> 
> 
> a < b & b < c therefore a < c

Hi, I'm the submitter of the original bug report. I can confirm that you got the reason for the change exactly right.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18126#discussion_r1526422961

From aivanov at openjdk.org  Thu Mar 21 12:02:23 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Thu, 21 Mar 2024 12:02:23 GMT
Subject: RFR: 8305072: Win32ShellFolder2.compareTo is inconsistent [v2]
In-Reply-To: <xEaIYt-r-0MtZBDcpke8dec_MkYGmm_gsj0NcagSMGs=.0f29ce1b-ff4b-4505-9095-5602cdbd3de9@github.com>
References: <bEiHvkFnBZDqmiqQdk_-_mATVhDbAD7NZX7VnkHLG2E=.27ee84ba-00fd-405a-9489-8fe11c215af9@github.com>
 <21db5CiFTVN7scwsIHknMxF4YaVQd06m7gUOhcCLvMI=.e2f61ea7-bf9a-4632-bf45-c89f979ae806@github.com>
 <6dQg9rhDwh4ZL7D2JfYpA0xNP_eJDbOK3rNgj7efckM=.c5001d8a-cce5-4a11-a91d-eda8e90b8056@github.com>
 <76BSt4HYmTD2DiZzBUvNvBdvd5d1MFinIDsgp2YuHjs=.68646608-e266-4ca3-8495-59e237f8607c@github.com>
 <5btT_N4c5R89DQ8aoSyjm6lIR7PHLWC141uAIdH_Bjw=.f36326e9-0f59-4545-82bf-f3c8b4dbaa87@github.com>
 <xEaIYt-r-0MtZBDcpke8dec_MkYGmm_gsj0NcagSMGs=.0f29ce1b-ff4b-4505-9095-5602cdbd3de9@github.com>
Message-ID: <mizV7DeN__pB18Y8FphJfkZMEawwpWdbW4lccgcFz98=.4d7e85da-43fd-4b02-8fd9-5944d9dc5cd1@github.com>

On Fri, 15 Mar 2024 15:00:40 GMT, Joel Uckelman <duke at openjdk.org> wrote:

>> So, changing the condition in the `if`-block from `special1 || special2` to `special1 && special2` makes the sorting order consistent because the relation is now *transitive*:
>> 
>> 
>> a < b & b < c therefore a < c
>
> Hi, I'm the submitter of the original bug report. I can confirm that you got the reason for the change exactly right.

Thank you, @uckelman, for the detailed analysis. Greatly appreciated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18126#discussion_r1533761341

From aivanov at openjdk.org  Thu Mar 21 12:05:20 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Thu, 21 Mar 2024 12:05:20 GMT
Subject: RFR: 8305072: Win32ShellFolder2.compareTo is inconsistent [v2]
In-Reply-To: <xEaIYt-r-0MtZBDcpke8dec_MkYGmm_gsj0NcagSMGs=.0f29ce1b-ff4b-4505-9095-5602cdbd3de9@github.com>
References: <bEiHvkFnBZDqmiqQdk_-_mATVhDbAD7NZX7VnkHLG2E=.27ee84ba-00fd-405a-9489-8fe11c215af9@github.com>
 <21db5CiFTVN7scwsIHknMxF4YaVQd06m7gUOhcCLvMI=.e2f61ea7-bf9a-4632-bf45-c89f979ae806@github.com>
 <6dQg9rhDwh4ZL7D2JfYpA0xNP_eJDbOK3rNgj7efckM=.c5001d8a-cce5-4a11-a91d-eda8e90b8056@github.com>
 <76BSt4HYmTD2DiZzBUvNvBdvd5d1MFinIDsgp2YuHjs=.68646608-e266-4ca3-8495-59e237f8607c@github.com>
 <5btT_N4c5R89DQ8aoSyjm6lIR7PHLWC141uAIdH_Bjw=.f36326e9-0f59-4545-82bf-f3c8b4dbaa87@github.com>
 <xEaIYt-r-0MtZBDcpke8dec_MkYGmm_gsj0NcagSMGs=.0f29ce1b-ff4b-4505-9095-5602cdbd3de9@github.com>
Message-ID: <2LG0ERi-9ETplOC0EdSozMQ4WTJDgx2lw3Z1J6IVrrY=.03443566-afd3-4d7e-8caa-46fa10c55a5e@github.com>

On Fri, 15 Mar 2024 15:00:40 GMT, Joel Uckelman <duke at openjdk.org> wrote:

>> So, changing the condition in the `if`-block from `special1 || special2` to `special1 && special2` makes the sorting order consistent because the relation is now *transitive*:
>> 
>> 
>> a < b & b < c therefore a < c
>
> Hi, I'm the submitter of the original bug report. I can confirm that you got the reason for the change exactly right.

@uckelman Is there a way to reproduce the original bug in the user's environment?

I think there's a bug in JDK which leads to two _Documents_ folders in the list. If the bug is still reproducible, collecting more data will help us identify the problem and fix it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18126#discussion_r1533767996

From azvegint at openjdk.org  Thu Mar 21 12:08:23 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Thu, 21 Mar 2024 12:08:23 GMT
Subject: RFR: 8328562: Convert
 java/awt/InputMethods/DiacriticsTest/DiacriticsTest.java applet test to main
 [v2]
In-Reply-To: <YU3_RTFdP62OP3MqGL-MYq4BBzkNWZcfuFxx9PNKL7g=.213060f0-9023-4b35-9a0a-511f802cb4b6@github.com>
References: <dwZXmqAjKVfX0Z4xfEfCJvsNmm7pOSYZTOk30-vPIF8=.0e29c1cf-580c-4898-9b94-7aaddec86add@github.com>
 <YU3_RTFdP62OP3MqGL-MYq4BBzkNWZcfuFxx9PNKL7g=.213060f0-9023-4b35-9a0a-511f802cb4b6@github.com>
Message-ID: <pnGS4448QiAq2rRlYQXZSbIhQDs_yCW2LoJ001IbX_8=.dd0f91c8-659e-4cd3-906e-162336c3aaa8@github.com>

On Thu, 21 Mar 2024 10:35:19 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Alexander Zvegintsev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   minor spacing
>
> test/jdk/java/awt/InputMethods/DiacriticsTest/DiacriticsTest.java line 25:
> 
>> 23: 
>> 24: 
>> 25: import jdk.test.lib.Platform;
> 
> Minor one - Additional line space before imports can be removed.

Removed

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18388#discussion_r1533772890

From azvegint at openjdk.org  Thu Mar 21 12:48:21 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Thu, 21 Mar 2024 12:48:21 GMT
Subject: RFR: JDK-8328398 : Convert java/awt/im/4490692/bug4490692.html
 applet test to main [v2]
In-Reply-To: <aS6ATocsIxgP1ABKQTve2waCy-MeH92snBcEZJftr9s=.24f93a07-f2b6-4608-9785-53b0399fcd03@github.com>
References: <lcESN0hyfRYfuC2nnzmBSQrUQLmHHD6uooae53vTzWA=.682e9e1e-d3cb-4b2e-bc95-9bdd9d709f6f@github.com>
 <aS6ATocsIxgP1ABKQTve2waCy-MeH92snBcEZJftr9s=.24f93a07-f2b6-4608-9785-53b0399fcd03@github.com>
Message-ID: <CETT2AYhreeC9vGiKMfghFTU8z2WtS86PXKrfuu6X8I=.fc26a12c-5d3c-4473-afd5-d9fcc7d79830@github.com>

On Wed, 20 Mar 2024 16:59:47 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Following test is converted from applet to main using PassFailJFrame.
>> 
>> The original test had ignore tag - **The fix for this problem was backed out for 5057184.  Remove this "ignore" tag when it is fixed again.**
>> I believe this was fixed and the test works correctly on Linux platforms, hence ignore tag has been removed.
>> 
>> This is a semi-automated test, the first check is manual and the 2nd one is automated. Details in the test instructions.
>
> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   instruction line length

test/jdk/java/awt/im/bug4490692.java line 74:

> 72:                 .rows((int) INSTRUCTIONS.lines().count() + 2)
> 73:                 .columns(40)
> 74:                 .testUI(() -> new TestFrame("Test Accented Chars"))

Looks like a good candidate to use `splitUIRight/Bottom` (up to you).

test/jdk/java/awt/im/bug4490692.java line 95:

> 93:     @Override
> 94:     public void keyPressed(KeyEvent e) {
> 95:         if (e.getKeyCode() == 23 || e.getKeyCode() == 60) {

>  CASE 2: This step is automated and applicable for both
keyboards - LINUX & SOLARIS SPARC.
When Tab key is pressed it should generate a-acute (?)
character, this test automatically passes if the correct character
is generated on keypress else fails.

Unfortunately this check doesn't work for me:
`java.awt.event.KeyEvent[KEY_PRESSED,keyCode=0,keyText=Unknown keyCode: 0x0,keyChar='?',keyLocation=KEY_LOCATION_UNKNOWN,rawCode=23,primaryLevelUnicode=225,scancode=0,extendedKeyCode=0x10000e1] on javax.swing.JTextField...`

The `keycode` is 0, `rawCode` is desired `23`, but we can't get it it unless parsing the output of `e.toString()`

The `e.getKeyChar() == 0x00e1` check is still valid thought.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18402#discussion_r1533782803
PR Review Comment: https://git.openjdk.org/jdk/pull/18402#discussion_r1533787428

From azvegint at openjdk.org  Thu Mar 21 13:06:29 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Thu, 21 Mar 2024 13:06:29 GMT
Subject: RFR: 8328697: SubMenuShowTest and SwallowKeyEvents tests stabilization
Message-ID: <zcgN9263VAJS5lzQijzw4C2ERzeghOHSYVXCm9D5_5I=.908547bc-170b-49c3-a810-c5efb2d21b86@github.com>

Two tests may fail intermittently on Wayland, the standard `waitForIdle` and `delay` fixes the issue.

Manual and CI testing looks good.

-------------

Commit messages:
 - initial

Changes: https://git.openjdk.org/jdk/pull/18431/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18431&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8328697
  Stats: 6 lines in 2 files changed: 4 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/18431.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18431/head:pull/18431

PR: https://git.openjdk.org/jdk/pull/18431

From azvegint at openjdk.org  Thu Mar 21 13:09:24 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Thu, 21 Mar 2024 13:09:24 GMT
Subject: Integrated: 8328401: Convert
 java/awt/Frame/InitialMaximizedTest/InitialMaximizedTest.html applet test to
 automated
In-Reply-To: <feEnRn4dLIWmgB9GyZd4ur-3buaDoiZ4eeynYShFz50=.f7eb7d90-464c-4231-8a6c-b97fc34378a5@github.com>
References: <feEnRn4dLIWmgB9GyZd4ur-3buaDoiZ4eeynYShFz50=.f7eb7d90-464c-4231-8a6c-b97fc34378a5@github.com>
Message-ID: <O9GJXLKuZHn6X_I7feb6rP5zmLU7qZNnYKDybhdRetc=.972aabc0-e1c2-4d4a-8372-69c324272c00@github.com>

On Mon, 18 Mar 2024 23:46:34 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

> The test converted to automated, CI and manual testing looks good on all platforms.

This pull request has now been integrated.

Changeset: 700d2b91
Author:    Alexander Zvegintsev <azvegint at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/700d2b91defd421a2818f53830c24f70d11ba4f6
Stats:     244 lines in 2 files changed: 18 ins; 176 del; 50 mod

8328401: Convert java/awt/Frame/InitialMaximizedTest/InitialMaximizedTest.html applet test to automated

Reviewed-by: abhiscxk, prr

-------------

PR: https://git.openjdk.org/jdk/pull/18367

From azvegint at openjdk.org  Thu Mar 21 13:19:20 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Thu, 21 Mar 2024 13:19:20 GMT
Subject: RFR: 8328402: Implement pausing functionality for the
 PassFailJFrame [v2]
In-Reply-To: <MXBEwRDmdVrODNd4eNcPT5EZhxOTiS0XQAbqeC23b4Q=.a0cbd557-8c94-470a-a2cf-e381e845dba3@github.com>
References: <_G5oabZhLzV7Ld3agI-uiRKWhJL5_8i8LVWA7JSBhOM=.c025ce82-16ed-4b8d-8e2b-1a8bc849639c@github.com>
 <lht-2bR5LdbhrTq3OdbC96MoLbSYVaw2yItOrQTpu2c=.036e2133-3c64-44ba-9133-e865fcc512e8@github.com>
 <UVpC5H68UrZzpFfNRRgdH3os7Epr7c2C3N-wH-ILiZU=.d655981d-6ae1-4670-99b2-b2f2fe33e064@github.com>
 <KoWH6-Unlv6oXYk6WGR0koZsFODVcV2Z30vqyilX-CY=.77c9c12a-34de-42a6-9336-5bfbb03de870@github.com>
 <MXBEwRDmdVrODNd4eNcPT5EZhxOTiS0XQAbqeC23b4Q=.a0cbd557-8c94-470a-a2cf-e381e845dba3@github.com>
Message-ID: <mSitsG6XFJ9SZz9AviD1o3f4SQCT4V-Y9GGBG5m-xj0=.834915f5-bcb1-41da-83f9-89d889e20e41@github.com>

On Thu, 21 Mar 2024 11:56:46 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>>> I wonder if it's the default focus owner? 
>> 
>> It is(e.g. with `setFocusPainted(true)`):
>> ![image](https://github.com/openjdk/jdk/assets/77687766/b47e9011-c47d-437d-b9b0-0e4ac88a5c6f)
>> 
>>> Should we request focus to Pass instead?
>> 
>> Probably not, to avoid accidentally passing the test, while hitting the pause is harmless.
>
> Not so sure? Pause is not the main control. I guess the focus was in the instructions previously, we could preserve it. It may be not worth it though.

It's not clear why we need a focus on the field with instructions.
The focus on the pause button makes sense:
Suppose someone is running many, many tests and decides to take a tea break, he just presses the space bar without moving the mouse.
(if he knows  that the focus is on the pause button, `setFocusPainted(false)` :-) )

Anyway, if this bothers anyone we can come back to it later.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18368#discussion_r1533887869

From azvegint at openjdk.org  Thu Mar 21 13:22:23 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Thu, 21 Mar 2024 13:22:23 GMT
Subject: Integrated: 8328631: Convert
 java/awt/InputMethods/InputMethodsTest/InputMethodsTest.java applet test to
 manual
In-Reply-To: <hndPv_Xokx8HhC6nCWXQGTVBROkbohmZYsicPCXrM3A=.08fe6ee9-a0ac-4a2d-bfa3-1e44cb4e2964@github.com>
References: <hndPv_Xokx8HhC6nCWXQGTVBROkbohmZYsicPCXrM3A=.08fe6ee9-a0ac-4a2d-bfa3-1e44cb4e2964@github.com>
Message-ID: <zz5gGKeR1FEiphoGX6sYKQXApJarT6JZ1lKh8ZX0pnM=.e6f90f72-a7ff-4e2a-8aa6-c2fa098b1a9a@github.com>

On Wed, 20 Mar 2024 21:02:02 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

> Test converted to main. Tested on Linux with Japanese ibus-anthy input method.

This pull request has now been integrated.

Changeset: 43080173
Author:    Alexander Zvegintsev <azvegint at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/43080173e88c8f53cd54c9096c79f3144007fd97
Stats:     109 lines in 2 files changed: 20 ins; 53 del; 36 mod

8328631: Convert java/awt/InputMethods/InputMethodsTest/InputMethodsTest.java applet test to manual

Reviewed-by: prr

-------------

PR: https://git.openjdk.org/jdk/pull/18412

From azvegint at openjdk.org  Thu Mar 21 13:54:21 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Thu, 21 Mar 2024 13:54:21 GMT
Subject: RFR: 8328642: Convert applet test
 MouseDraggedOutCauseScrollingTest.html to main
In-Reply-To: <oSOD44PevN840Jv0JaNJLDYYqDna-8qggdwlyEayo9c=.47a9f876-50f8-4cdf-804c-596cb2ac94fb@github.com>
References: <oSOD44PevN840Jv0JaNJLDYYqDna-8qggdwlyEayo9c=.47a9f876-50f8-4cdf-804c-596cb2ac94fb@github.com>
Message-ID: <jl7QZ6hsyGK917HMT9LO9Brxyr8BAJvkoaPusdaVPSI=.0df7c693-4f73-489c-80d5-5bc5a11772a7@github.com>

On Wed, 20 Mar 2024 21:33:04 GMT, Phil Race <prr at openjdk.org> wrote:

> Converts java/awt/List/MouseDraggedOutCauseScrollingTest/MouseDraggedOutCauseScrollingTest.html
> to a main program.

Marked as reviewed by azvegint (Reviewer).

test/jdk/java/awt/List/MouseDraggedOutCauseScrollingTest/MouseDraggedOutCauseScrollingTest.java line 31:

> 29:   @library /java/awt/regtesthelpers
> 30:   @run main/manual MouseDraggedOutCauseScrollingTest
> 31: */

We usually move this and instructions block closer to a class declaration, for better readability.

-------------

PR Review: https://git.openjdk.org/jdk/pull/18414#pullrequestreview-1952287386
PR Review Comment: https://git.openjdk.org/jdk/pull/18414#discussion_r1533954114

From azvegint at openjdk.org  Thu Mar 21 14:03:21 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Thu, 21 Mar 2024 14:03:21 GMT
Subject: RFR: 8328403: Remove applet usage from JColorChooser tests
 Test6977726 [v2]
In-Reply-To: <hPfifnK0UnpXOEtu8Jmp91oFwC_VyjuJeu9CDPQbvaw=.544c5d8c-633e-46b1-855f-c41543164dea@github.com>
References: <pyfxVdApSNSisMJieBTl5HSZKDmSSiPie0tnrM_rwe4=.5ffc4e92-cbcf-44d8-9a51-b4e8330e1be9@github.com>
 <hPfifnK0UnpXOEtu8Jmp91oFwC_VyjuJeu9CDPQbvaw=.544c5d8c-633e-46b1-855f-c41543164dea@github.com>
Message-ID: <5A204R9Q4Xm8u41OcYVqOZi2XwrooEeYV8vupQ8W9gc=.741ff049-a0bf-488a-be29-1d8b5f04a24b@github.com>

On Wed, 20 Mar 2024 18:02:37 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> Removing applet usage from manual JColorChooser tests
>
> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   spacing

test/jdk/javax/swing/JColorChooser/Test6977726.java line 43:

> 41:                 .title("Test6977726")
> 42:                 .instructions("Check that there is an empty panel " +
> 43:                         "titled \"Preview\" in the JColorChooser.")

>there is an empty panel

This doesn't seem to be right, originally it was `If you don't see the preview panel, then test failed, otherwise it passed.`
The preview panel is not empty, it has barely visible white text.
![image](https://github.com/openjdk/jdk/assets/77687766/4d8706f6-1d7f-4229-9a20-bcaf85bb7737)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18369#discussion_r1533969729

From aivanov at openjdk.org  Thu Mar 21 14:06:22 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Thu, 21 Mar 2024 14:06:22 GMT
Subject: RFR: 8328673: Convert closed text/html/CSS manual applet test to
 main [v2]
In-Reply-To: <uAmkG885N1CgAijzfUqKBzSkHzYtmDc3N2KGtPUw1Tk=.055a8cb9-253f-4e18-95ca-ff3e900663ea@github.com>
References: <RUcdacOwzVskVmCK0_t8P42j-h9BEtAsuZqgKvM7uuc=.3ffd2bf8-a98b-46ef-8608-31142321e464@github.com>
 <uAmkG885N1CgAijzfUqKBzSkHzYtmDc3N2KGtPUw1Tk=.055a8cb9-253f-4e18-95ca-ff3e900663ea@github.com>
Message-ID: <gyPBV18KO2b833MLw8G3OjaiKWfom0ipTlQI3Po1N2M=.ca0c039a-835d-4bce-bd1f-d97617a4b4ac@github.com>

On Thu, 21 Mar 2024 11:34:39 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Couple closed manual applet text/html/CSS tests are converted to main based and opensourced
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   library path fix

Changes requested by aivanov (Reviewer).

test/jdk/javax/swing/text/html/CSS/bug4271058.java line 55:

> 53:     public static void main(String[] args) throws Exception {
> 54:          PassFailJFrame.builder()
> 55:                 .title("CSS tag Instructions")

A more specific title?

test/jdk/javax/swing/text/html/CSS/bug4271058.java line 60:

> 58:                 .columns(30)
> 59:                 .testUI(bug4271058::createTestUI)
> 60:                 .build()

I guess the test will benefit from a screenshot feature to capture how the table is rendered.
Suggestion:

                .testUI(bug4271058::createTestUI)
                .screenCapture()
                .build()


The feature to take a screenshot automatically, when Fail button is pressed, hasn't been implemented yet. It's tracked under [JDK-8317114](https://bugs.openjdk.org/browse/JDK-8317114).

test/jdk/javax/swing/text/html/CSS/bug4286458.java line 57:

> 55: 
> 56:         String text =
> 57:             "</html><body><table border=\"1\" cellpadding=\"-10\">" +

Suggestion:

            "<html><body><table border="1" cellpadding="-10">" +

It should start with an opening tag.

test/jdk/javax/swing/text/html/CSS/bug4286458.java line 65:

> 63:         jep.setEditorKit(new HTMLEditorKit());
> 64:         jep.setEditable(false);
> 65:         jep.setText(text);

Suggestion:

        JEditorPane jep = new JEditorPane("text/html", text);
        jep.setEditable(false);

Could be reduced to.

-------------

PR Review: https://git.openjdk.org/jdk/pull/18424#pullrequestreview-1952302358
PR Review Comment: https://git.openjdk.org/jdk/pull/18424#discussion_r1533964173
PR Review Comment: https://git.openjdk.org/jdk/pull/18424#discussion_r1533970805
PR Review Comment: https://git.openjdk.org/jdk/pull/18424#discussion_r1533976459
PR Review Comment: https://git.openjdk.org/jdk/pull/18424#discussion_r1533974967

From azvegint at openjdk.org  Thu Mar 21 14:27:24 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Thu, 21 Mar 2024 14:27:24 GMT
Subject: RFR: 8328368: Convert
 java/awt/image/multiresolution/MultiDisplayTest/MultiDisplayTest.java applet
 test to main
In-Reply-To: <VarHifZU9rXM4lqKzE_slP-8Q9K0CA65KBTCD6CD9Zc=.ec8e5b7b-cd94-43d2-9eb2-ea90997d030d@github.com>
References: <VarHifZU9rXM4lqKzE_slP-8Q9K0CA65KBTCD6CD9Zc=.ec8e5b7b-cd94-43d2-9eb2-ea90997d030d@github.com>
Message-ID: <2AcXge8T2E_dFxknLKDqwHoHTLrpY7ff9dOWDqVMQsQ=.75e27ab5-d806-4fe7-8470-98b014c86cc6@github.com>

On Mon, 18 Mar 2024 17:31:07 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

> Convert java/awt/image/multiresolution/MultiDisplayTest/MultiDisplayTest.java applet test to main using PassFailJFrame

test/jdk/java/awt/image/multiresolution/MultiDisplayTest.java line 33:

> 31:  *         on HiDPI + non-HiDPI display pair.
> 32:  * @run main MultiDisplayTest
> 33:  */

We usually move this block just before a class declaration, for better readability.

test/jdk/java/awt/image/multiresolution/MultiDisplayTest.java line 58:

> 56:             """
> 57:              This test is for OS X or Windows only.
> 58:              For other OSes please simply push "Pass".

`please simply push "Pass"` usually means that it can be replaced with `PassFailJFrame.forcePass()`, but in this case the `@requires (os.family...` can be used to avoid running the test on unwanted platforms.

test/jdk/java/awt/image/multiresolution/MultiDisplayTest.java line 93:

> 91:         generateImage(1, Color.BLACK), generateImage(2, Color.BLUE)});
> 92: 
> 93:     public static void main(String[] args) throws Exception {

While the `@requires (os.family...` should be enough, we can add something like

if (!checkOS()) {
    throw new SkippedException("..."); //jtreg.SkippedException
}

test/jdk/java/awt/image/multiresolution/MultiDisplayTest.java line 109:

> 107:         frame.setLayout(new BorderLayout());
> 108:         Button b = new Button("Start");
> 109:         b.setEnabled(checkOS());

With the changes mentioned above, this will become obsolete.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18354#discussion_r1533996928
PR Review Comment: https://git.openjdk.org/jdk/pull/18354#discussion_r1533994910
PR Review Comment: https://git.openjdk.org/jdk/pull/18354#discussion_r1534013542
PR Review Comment: https://git.openjdk.org/jdk/pull/18354#discussion_r1534012450

From kizune at openjdk.org  Thu Mar 21 14:28:19 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Thu, 21 Mar 2024 14:28:19 GMT
Subject: RFR: 8328697: SubMenuShowTest and SwallowKeyEvents tests
 stabilization
In-Reply-To: <zcgN9263VAJS5lzQijzw4C2ERzeghOHSYVXCm9D5_5I=.908547bc-170b-49c3-a810-c5efb2d21b86@github.com>
References: <zcgN9263VAJS5lzQijzw4C2ERzeghOHSYVXCm9D5_5I=.908547bc-170b-49c3-a810-c5efb2d21b86@github.com>
Message-ID: <YV8wtMwI2S5DMbFjPSlPTWvqVk5OhIE_zJ1PtCtvCD4=.e0cf96c7-e366-4cd5-8e15-e712d429d5bd@github.com>

On Thu, 21 Mar 2024 13:02:29 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

> Two tests may fail intermittently on Wayland, the standard `waitForIdle` and `delay` fixes the issue.
> 
> Manual and CI testing looks good.

Marked as reviewed by kizune (Reviewer).

Since you are editing these files you can also drop the @author tag from the test metadata. Otherwise looks good.

-------------

PR Review: https://git.openjdk.org/jdk/pull/18431#pullrequestreview-1952390195
PR Comment: https://git.openjdk.org/jdk/pull/18431#issuecomment-2012439701

From kizune at openjdk.org  Thu Mar 21 14:34:25 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Thu, 21 Mar 2024 14:34:25 GMT
Subject: RFR: 8328570: Convert closed JViewport manual applet tests to main
 [v3]
In-Reply-To: <iscFh0srRuMV_ew8wzdMseWtIRoUghrtqJTooyFCLuw=.0d1d23c9-8e04-4dc9-a790-274f7b457566@github.com>
References: <JPXMrCOWFS4MTSQbiUtkH4egvJSxnapo0H0ndavn_8s=.cb76f5e5-a401-432f-83ea-8103eb3cf980@github.com>
 <iscFh0srRuMV_ew8wzdMseWtIRoUghrtqJTooyFCLuw=.0d1d23c9-8e04-4dc9-a790-274f7b457566@github.com>
Message-ID: <U9EW5yFz3IJyVcqL_33U9CMNjBMUO59wN8oBpsN3UmE=.e03635d3-3da7-46d4-ba68-ba1cdd1fa543@github.com>

On Thu, 21 Mar 2024 11:37:01 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Few closed manual applet JViewport tests are converted to main based and opensourced
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   formatting

test/jdk/javax/swing/JViewport/bug4243479.java line 30:

> 28:  * @library /java/awt/regtesthelpers
> 29:  * @build PassFailJFrame
> 30:    @run main/manual bug4243479

Suggestion:

 * @run main/manual bug4243479

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18418#discussion_r1534036819

From psadhukhan at openjdk.org  Thu Mar 21 14:41:50 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Thu, 21 Mar 2024 14:41:50 GMT
Subject: RFR: 8328673: Convert closed text/html/CSS manual applet test to
 main [v3]
In-Reply-To: <RUcdacOwzVskVmCK0_t8P42j-h9BEtAsuZqgKvM7uuc=.3ffd2bf8-a98b-46ef-8608-31142321e464@github.com>
References: <RUcdacOwzVskVmCK0_t8P42j-h9BEtAsuZqgKvM7uuc=.3ffd2bf8-a98b-46ef-8608-31142321e464@github.com>
Message-ID: <1LvnyESoMkYiVpr_0I1UjxgNkFqab-Y024iYJtX0dn4=.0c0bfc48-61ad-4bb0-a18e-844227efb9cf@github.com>

> Couple closed manual applet text/html/CSS tests are converted to main based and opensourced

Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:

  Review comment update

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18424/files
  - new: https://git.openjdk.org/jdk/pull/18424/files/d846e61f..fbc0b821

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18424&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18424&range=01-02

  Stats: 6 lines in 2 files changed: 1 ins; 2 del; 3 mod
  Patch: https://git.openjdk.org/jdk/pull/18424.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18424/head:pull/18424

PR: https://git.openjdk.org/jdk/pull/18424

From psadhukhan at openjdk.org  Thu Mar 21 14:41:52 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Thu, 21 Mar 2024 14:41:52 GMT
Subject: RFR: 8328673: Convert closed text/html/CSS manual applet test to
 main [v2]
In-Reply-To: <gyPBV18KO2b833MLw8G3OjaiKWfom0ipTlQI3Po1N2M=.ca0c039a-835d-4bce-bd1f-d97617a4b4ac@github.com>
References: <RUcdacOwzVskVmCK0_t8P42j-h9BEtAsuZqgKvM7uuc=.3ffd2bf8-a98b-46ef-8608-31142321e464@github.com>
 <uAmkG885N1CgAijzfUqKBzSkHzYtmDc3N2KGtPUw1Tk=.055a8cb9-253f-4e18-95ca-ff3e900663ea@github.com>
 <gyPBV18KO2b833MLw8G3OjaiKWfom0ipTlQI3Po1N2M=.ca0c039a-835d-4bce-bd1f-d97617a4b4ac@github.com>
Message-ID: <-UIAo0K0r32VVlslJcRISMB3U9fDyalqe6cpEUieFfs=.346c20eb-69f8-4e56-b2c8-c1d7959d732d@github.com>

On Thu, 21 Mar 2024 14:00:17 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   library path fix
>
> test/jdk/javax/swing/text/html/CSS/bug4271058.java line 60:
> 
>> 58:                 .columns(30)
>> 59:                 .testUI(bug4271058::createTestUI)
>> 60:                 .build()
> 
> I guess the test will benefit from a screenshot feature to capture how the table is rendered.
> Suggestion:
> 
>                 .testUI(bug4271058::createTestUI)
>                 .screenCapture()
>                 .build()
> 
> 
> The feature to take a screenshot automatically, when Fail button is pressed, hasn't been implemented yet. It's tracked under [JDK-8317114](https://bugs.openjdk.org/browse/JDK-8317114).

ok

> test/jdk/javax/swing/text/html/CSS/bug4286458.java line 57:
> 
>> 55: 
>> 56:         String text =
>> 57:             "</html><body><table border=\"1\" cellpadding=\"-10\">" +
> 
> Suggestion:
> 
>             "<html><body><table border="1" cellpadding="-10">" +
> 
> It should start with an opening tag.

yes

> test/jdk/javax/swing/text/html/CSS/bug4286458.java line 65:
> 
>> 63:         jep.setEditorKit(new HTMLEditorKit());
>> 64:         jep.setEditable(false);
>> 65:         jep.setText(text);
> 
> Suggestion:
> 
>         JEditorPane jep = new JEditorPane("text/html", text);
>         jep.setEditable(false);
> 
> Could be reduced to.

ok

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18424#discussion_r1534048754
PR Review Comment: https://git.openjdk.org/jdk/pull/18424#discussion_r1534049280
PR Review Comment: https://git.openjdk.org/jdk/pull/18424#discussion_r1534048927

From kizune at openjdk.org  Thu Mar 21 14:45:57 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Thu, 21 Mar 2024 14:45:57 GMT
Subject: RFR: 8328570: Convert closed JViewport manual applet tests to main
 [v3]
In-Reply-To: <iscFh0srRuMV_ew8wzdMseWtIRoUghrtqJTooyFCLuw=.0d1d23c9-8e04-4dc9-a790-274f7b457566@github.com>
References: <JPXMrCOWFS4MTSQbiUtkH4egvJSxnapo0H0ndavn_8s=.cb76f5e5-a401-432f-83ea-8103eb3cf980@github.com>
 <iscFh0srRuMV_ew8wzdMseWtIRoUghrtqJTooyFCLuw=.0d1d23c9-8e04-4dc9-a790-274f7b457566@github.com>
Message-ID: <0xB-04oG1w8ijVOwVLFAWpK37Ki22lEncQ8w_lx9F_s=.f37a1fc1-7d76-42f6-a603-e2cd1c8b6e28@github.com>

On Thu, 21 Mar 2024 11:37:01 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Few closed manual applet JViewport tests are converted to main based and opensourced
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   formatting

test/jdk/javax/swing/JViewport/bug4137282.java line 86:

> 84:     }
> 85: 
> 86:     static void setPaneSize(int w, int h) {

Do we even need this method? It is used twice and if we just do setSize and setPreferredSize in these two places we could drop this method and make panel variable local. That will make it more compact and in my opinion more readable.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18418#discussion_r1534053126

From psadhukhan at openjdk.org  Thu Mar 21 14:45:57 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Thu, 21 Mar 2024 14:45:57 GMT
Subject: RFR: 8328570: Convert closed JViewport manual applet tests to main
 [v4]
In-Reply-To: <JPXMrCOWFS4MTSQbiUtkH4egvJSxnapo0H0ndavn_8s=.cb76f5e5-a401-432f-83ea-8103eb3cf980@github.com>
References: <JPXMrCOWFS4MTSQbiUtkH4egvJSxnapo0H0ndavn_8s=.cb76f5e5-a401-432f-83ea-8103eb3cf980@github.com>
Message-ID: <V5BUFQf24gE5IfhpMOoVqFBk_EpOJ19BYy2gdgUJEJk=.29d871db-9ab5-49dc-9dcc-e7e1362345c5@github.com>

> Few closed manual applet JViewport tests are converted to main based and opensourced

Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:

  formatting

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18418/files
  - new: https://git.openjdk.org/jdk/pull/18418/files/8e177faa..d588adcc

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18418&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18418&range=02-03

  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/18418.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18418/head:pull/18418

PR: https://git.openjdk.org/jdk/pull/18418

From kizune at openjdk.org  Thu Mar 21 14:45:57 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Thu, 21 Mar 2024 14:45:57 GMT
Subject: RFR: 8328570: Convert closed JViewport manual applet tests to main
 [v4]
In-Reply-To: <V5BUFQf24gE5IfhpMOoVqFBk_EpOJ19BYy2gdgUJEJk=.29d871db-9ab5-49dc-9dcc-e7e1362345c5@github.com>
References: <JPXMrCOWFS4MTSQbiUtkH4egvJSxnapo0H0ndavn_8s=.cb76f5e5-a401-432f-83ea-8103eb3cf980@github.com>
 <V5BUFQf24gE5IfhpMOoVqFBk_EpOJ19BYy2gdgUJEJk=.29d871db-9ab5-49dc-9dcc-e7e1362345c5@github.com>
Message-ID: <_Y6M3OpAoXffiOpQyd_jEG24ShOUqeEprgPJ68gDf0w=.1ffe25b9-ab61-4d76-b7d8-1fcab60cdf31@github.com>

On Thu, 21 Mar 2024 14:42:49 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Few closed manual applet JViewport tests are converted to main based and opensourced
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   formatting

Marked as reviewed by kizune (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18418#pullrequestreview-1952441418

From psadhukhan at openjdk.org  Thu Mar 21 14:45:57 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Thu, 21 Mar 2024 14:45:57 GMT
Subject: RFR: 8328570: Convert closed JViewport manual applet tests to main
 [v3]
In-Reply-To: <0xB-04oG1w8ijVOwVLFAWpK37Ki22lEncQ8w_lx9F_s=.f37a1fc1-7d76-42f6-a603-e2cd1c8b6e28@github.com>
References: <JPXMrCOWFS4MTSQbiUtkH4egvJSxnapo0H0ndavn_8s=.cb76f5e5-a401-432f-83ea-8103eb3cf980@github.com>
 <iscFh0srRuMV_ew8wzdMseWtIRoUghrtqJTooyFCLuw=.0d1d23c9-8e04-4dc9-a790-274f7b457566@github.com>
 <0xB-04oG1w8ijVOwVLFAWpK37Ki22lEncQ8w_lx9F_s=.f37a1fc1-7d76-42f6-a603-e2cd1c8b6e28@github.com>
Message-ID: <qjQg8q5fGItQcIf1p9m5Y0mWDN0gKuKAIFegB7dRvHE=.09ef3034-98d3-4288-99a2-302deca2b9ea@github.com>

On Thu, 21 Mar 2024 14:40:30 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

>> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   formatting
>
> test/jdk/javax/swing/JViewport/bug4137282.java line 86:
> 
>> 84:     }
>> 85: 
>> 86:     static void setPaneSize(int w, int h) {
> 
> Do we even need this method? It is used twice and if we just do setSize and setPreferredSize in these two places we could drop this method and make panel variable local. That will make it more compact and in my opinion more readable.

Yes, I considered that but it has 2 lines and used in 2 places...if it had been 1 line I would have done it but since it was more than 1 line I kept it and I dont think its affecting readability so much, is it?

> test/jdk/javax/swing/JViewport/bug4243479.java line 30:
> 
>> 28:  * @library /java/awt/regtesthelpers
>> 29:  * @build PassFailJFrame
>> 30:    @run main/manual bug4243479
> 
> Suggestion:
> 
>  * @run main/manual bug4243479

ok

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18418#discussion_r1534057018
PR Review Comment: https://git.openjdk.org/jdk/pull/18418#discussion_r1534053111

From psadhukhan at openjdk.org  Thu Mar 21 14:49:28 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Thu, 21 Mar 2024 14:49:28 GMT
Subject: Integrated: 8328570: Convert closed JViewport manual applet tests to
 main
In-Reply-To: <JPXMrCOWFS4MTSQbiUtkH4egvJSxnapo0H0ndavn_8s=.cb76f5e5-a401-432f-83ea-8103eb3cf980@github.com>
References: <JPXMrCOWFS4MTSQbiUtkH4egvJSxnapo0H0ndavn_8s=.cb76f5e5-a401-432f-83ea-8103eb3cf980@github.com>
Message-ID: <fRJZqLNEO4g4vSLjqU2yJZSjvmqRCXS_86WpTv75kC8=.6c29f9c1-a46c-44bb-a4fd-9934f36bc38b@github.com>

On Thu, 21 Mar 2024 03:44:01 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> Few closed manual applet JViewport tests are converted to main based and opensourced

This pull request has now been integrated.

Changeset: 725d87bb
Author:    Prasanta Sadhukhan <psadhukhan at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/725d87bbc2abae2ca856d91668f0a494f93fca1c
Stats:     428 lines in 5 files changed: 428 ins; 0 del; 0 mod

8328570: Convert closed JViewport manual applet tests to main

Reviewed-by: abhiscxk, kizune

-------------

PR: https://git.openjdk.org/jdk/pull/18418

From aivanov at openjdk.org  Thu Mar 21 14:50:25 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Thu, 21 Mar 2024 14:50:25 GMT
Subject: RFR: JDK-8328190 : Convert AWTPanelSmoothWheel.html applet test to
 main [v6]
In-Reply-To: <QIODl_DsczYOOkKiQQIvyr_5CWaxnZfUcd8Gs855Y4c=.ac936322-0895-4153-8585-26d6978157a6@github.com>
References: <sn9qb9ctS_sr3isHbwcbMCYh2RQokz2ptsw0rGBRnJY=.955d7549-72c7-4a4f-8ac8-a5d6f122cf68@github.com>
 <QIODl_DsczYOOkKiQQIvyr_5CWaxnZfUcd8Gs855Y4c=.ac936322-0895-4153-8585-26d6978157a6@github.com>
Message-ID: <tg21lGJHWa3YHxeHKi-RWHxlQ5EXKC1xj7Sq5qY8XDw=.9edafe5a-3205-41b2-ada8-3bda32f74329@github.com>

On Thu, 21 Mar 2024 01:13:50 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> This test is converted to main using PassFailJFrame. It verifies wheel rotation value for high-res mouse on windows.
>> 
>> The test requires the updated PassFailJFrame's logArea() feature added in this PR https://github.com/openjdk/jdk/pull/18319
>
> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   added preciseWheelRotation logic & updated test

Changes requested by aivanov (Reviewer).

test/jdk/java/awt/event/MouseEvent/AWTPanelSmoothWheel.java line 58:

> 56:             When preciseWheelRotation adds up to 1,wheelRotation becomes 1. <br>
> 57:             You should see a few events where preciseWheelRotation < 1 & wheelRotation = 0
> 58:             followed by a event where preciseWheelRotation = 1 & wheelRotation = 1.<br> <br>

Suggestion:

            <b>preciseWheelRotation &lt; 1.</b> <br>
            When preciseWheelRotation adds up to 1, wheelRotation becomes 1. <br>
            You should see a few events where preciseWheelRotation &lt; 1 &amp; wheelRotation = 0
            followed by a event where preciseWheelRotation = 1 &amp; wheelRotation = 1.<br> <br>

test/jdk/java/awt/event/MouseEvent/AWTPanelSmoothWheel.java line 64:

> 62: 
> 63:             <hr>
> 64:             PS: If you don't see events with preciseWheelRotation < 1,

Suggestion:

            PS: If you don't see events with preciseWheelRotation &lt; 1,

test/jdk/java/awt/event/MouseEvent/AWTPanelSmoothWheel.java line 91:

> 89:         panel.addMouseWheelListener(e -> {
> 90:             if (e.getScrollType() == MouseWheelEvent.WHEEL_UNIT_SCROLL) {
> 91:                 PassFailJFrame.log("WheelEvent#"+ ++wheelEventCount

Suggestion:

                PassFailJFrame.log("WheelEvent#" + (++wheelEventCount)

Use parentheses to avoid confusion.

test/jdk/java/awt/event/MouseEvent/AWTPanelSmoothWheel.java line 101:

> 99:                     PassFailJFrame.log("WARNING !!! You might not be using a high-res mouse.");
> 100:                 }
> 101:             }

This logging style is easier to parse, thanks.

You have nearly all the data to make the test semi-automatic. What's missing is `wheelRotationCount`.

[This diff](https://github.com/aivanov-jdk/jdk/commit/04c80c519d1c116663ab10a177bff1c4b6924091) implements this feature. For convenience, I'll paste the diff inline too:

diff --git a/test/jdk/java/awt/event/MouseEvent/AWTPanelSmoothWheel.java b/test/jdk/java/awt/event/MouseEvent/AWTPanelSmoothWheel.java
index 1097d1dcb04..f3dd8294e8b 100644
--- a/test/jdk/java/awt/event/MouseEvent/AWTPanelSmoothWheel.java
+++ b/test/jdk/java/awt/event/MouseEvent/AWTPanelSmoothWheel.java
@@ -39,7 +39,9 @@

 public class AWTPanelSmoothWheel {
     private static int wheelEventCount = 0;
+    private static int wheelRotationCount = 0;
     private static int hiResWheelCount = 0;
+
     private static final String INSTRUCTIONS = """
             <html>
             <body>
@@ -92,12 +94,21 @@ private static Frame createUI() {
                         + " --- Wheel Rotation: " + e.getWheelRotation()
                         + " --- Precise Wheel Rotation: "
                         + String.format("%.2f", e.getPreciseWheelRotation()));
+                if (e.getWheelRotation() >= 1) {
+                    wheelRotationCount += e.getWheelRotation();
+                }
                 if (e.getPreciseWheelRotation() < 1) {
                     hiResWheelCount++;
                 }
                 if (wheelEventCount >= 5 && hiResWheelCount == 0) {
                     PassFailJFrame.log("WARNING !!! You might not be using a high-res mouse.");
                 }
+                if (wheelRotationCount > 5
+                    && (hiResWheelCount / 2 >= wheelRotationCount)) {
+                    PassFailJFrame.log("The test passes: hiResWheelCount = " + hiResWheelCount
+                                       + " wheelRotationCount = " + wheelRotationCount);
+                    PassFailJFrame.forcePass();
+                }
             }
         });
         frame.setSize (400, 200);

test/jdk/java/awt/event/MouseEvent/AWTPanelSmoothWheel.java line 103:

> 101:             }
> 102:         });
> 103:         frame.setSize (400, 200);

Suggestion:

        frame.setSize(400, 200);

-------------

PR Review: https://git.openjdk.org/jdk/pull/18312#pullrequestreview-1952352489
PR Review Comment: https://git.openjdk.org/jdk/pull/18312#discussion_r1533996638
PR Review Comment: https://git.openjdk.org/jdk/pull/18312#discussion_r1534001700
PR Review Comment: https://git.openjdk.org/jdk/pull/18312#discussion_r1534003172
PR Review Comment: https://git.openjdk.org/jdk/pull/18312#discussion_r1534065861
PR Review Comment: https://git.openjdk.org/jdk/pull/18312#discussion_r1534004288

From aivanov at openjdk.org  Thu Mar 21 15:03:21 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Thu, 21 Mar 2024 15:03:21 GMT
Subject: RFR: 8328673: Convert closed text/html/CSS manual applet test to
 main [v3]
In-Reply-To: <1LvnyESoMkYiVpr_0I1UjxgNkFqab-Y024iYJtX0dn4=.0c0bfc48-61ad-4bb0-a18e-844227efb9cf@github.com>
References: <RUcdacOwzVskVmCK0_t8P42j-h9BEtAsuZqgKvM7uuc=.3ffd2bf8-a98b-46ef-8608-31142321e464@github.com>
 <1LvnyESoMkYiVpr_0I1UjxgNkFqab-Y024iYJtX0dn4=.0c0bfc48-61ad-4bb0-a18e-844227efb9cf@github.com>
Message-ID: <9EwViaS3VcGlNJHheA2leAnEN2UzAcq3hrVodZFfUkU=.305c5f5f-013a-4c9c-a77f-20dfb634ec74@github.com>

On Thu, 21 Mar 2024 14:41:50 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Couple closed manual applet text/html/CSS tests are converted to main based and opensourced
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review comment update

Marked as reviewed by aivanov (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18424#pullrequestreview-1952498525

From aivanov at openjdk.org  Thu Mar 21 15:07:23 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Thu, 21 Mar 2024 15:07:23 GMT
Subject: RFR: JDK-8328190 : Convert AWTPanelSmoothWheel.html applet test to
 main [v6]
In-Reply-To: <QIODl_DsczYOOkKiQQIvyr_5CWaxnZfUcd8Gs855Y4c=.ac936322-0895-4153-8585-26d6978157a6@github.com>
References: <sn9qb9ctS_sr3isHbwcbMCYh2RQokz2ptsw0rGBRnJY=.955d7549-72c7-4a4f-8ac8-a5d6f122cf68@github.com>
 <QIODl_DsczYOOkKiQQIvyr_5CWaxnZfUcd8Gs855Y4c=.ac936322-0895-4153-8585-26d6978157a6@github.com>
Message-ID: <_nnWF0LSxuojYz7WdCE2yqHGEL1TCJKGOdoDWHdf4kU=.f773e15f-9c10-4733-baef-5e1e1da3b5a5@github.com>

On Thu, 21 Mar 2024 01:13:50 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> This test is converted to main using PassFailJFrame. It verifies wheel rotation value for high-res mouse on windows.
>> 
>> The test requires the updated PassFailJFrame's logArea() feature added in this PR https://github.com/openjdk/jdk/pull/18319
>
> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   added preciseWheelRotation logic & updated test

test/jdk/java/awt/event/MouseEvent/AWTPanelSmoothWheel.java line 99:

> 97:                 }
> 98:                 if (wheelEventCount >= 5 && hiResWheelCount == 0) {
> 99:                     PassFailJFrame.log("WARNING !!! You might not be using a high-res mouse.");

[`JOptionPane.showMessageDialog`](https://docs.oracle.com/en/java/javase/21/docs/api/java.desktop/javax/swing/JOptionPane.html#showMessageDialog(java.awt.Component,java.lang.Object,java.lang.String,int)) could be a better option to attract the tester's attention.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18312#discussion_r1534100269

From azvegint at openjdk.org  Thu Mar 21 15:07:41 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Thu, 21 Mar 2024 15:07:41 GMT
Subject: RFR: 8328697: SubMenuShowTest and SwallowKeyEvents tests
 stabilization [v2]
In-Reply-To: <zcgN9263VAJS5lzQijzw4C2ERzeghOHSYVXCm9D5_5I=.908547bc-170b-49c3-a810-c5efb2d21b86@github.com>
References: <zcgN9263VAJS5lzQijzw4C2ERzeghOHSYVXCm9D5_5I=.908547bc-170b-49c3-a810-c5efb2d21b86@github.com>
Message-ID: <0iWphT04yjJ7Y8W58Sv4MMIizoIDnyny-I3KdCYETLM=.a4f5f93a-7b3a-4f53-aace-2f05c01f65be@github.com>

> Two tests may fail intermittently on Wayland, the standard `waitForIdle` and `delay` fixes the issue.
> 
> Manual and CI testing looks good.

Alexander Zvegintsev has updated the pull request incrementally with one additional commit since the last revision:

  author removed, ../../../regtesthelpers -> /java/awt/regtesthelpers, moved whole block closer to class declaration

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18431/files
  - new: https://git.openjdk.org/jdk/pull/18431/files/ef599122..3c18826e

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18431&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18431&range=00-01

  Stats: 51 lines in 2 files changed: 24 ins; 27 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18431.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18431/head:pull/18431

PR: https://git.openjdk.org/jdk/pull/18431

From azvegint at openjdk.org  Thu Mar 21 15:07:41 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Thu, 21 Mar 2024 15:07:41 GMT
Subject: RFR: 8328697: SubMenuShowTest and SwallowKeyEvents tests
 stabilization
In-Reply-To: <YV8wtMwI2S5DMbFjPSlPTWvqVk5OhIE_zJ1PtCtvCD4=.e0cf96c7-e366-4cd5-8e15-e712d429d5bd@github.com>
References: <zcgN9263VAJS5lzQijzw4C2ERzeghOHSYVXCm9D5_5I=.908547bc-170b-49c3-a810-c5efb2d21b86@github.com>
 <YV8wtMwI2S5DMbFjPSlPTWvqVk5OhIE_zJ1PtCtvCD4=.e0cf96c7-e366-4cd5-8e15-e712d429d5bd@github.com>
Message-ID: <4mjfWsaTAZii2sM-98j9Xg3b5bKHyaNMB5jv6GtnwU0=.56f3e7d0-a713-4830-91c7-ac38876fb4d1@github.com>

On Thu, 21 Mar 2024 14:25:36 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

> Since you are editing these files you can also drop the @author tag from the test metadata. Otherwise looks good.

Sure,

author removed
../../../regtesthelpers -> /java/awt/regtesthelpers, 
moved whole block closer to class declaration

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18431#issuecomment-2012545559

From kizune at openjdk.org  Thu Mar 21 15:17:20 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Thu, 21 Mar 2024 15:17:20 GMT
Subject: RFR: 8328648: Remove applet usage from JFileChooser tests
 bug4150029
In-Reply-To: <eTiR35uGxb59RbbKcRAdTrgYkrx4CNmkIWfk63i3sJw=.8771db30-c50e-4c50-ae80-312a7683cc27@github.com>
References: <eTiR35uGxb59RbbKcRAdTrgYkrx4CNmkIWfk63i3sJw=.8771db30-c50e-4c50-ae80-312a7683cc27@github.com>
Message-ID: <g-nWnWMeKuuzCPlmP5F6h29NeQSrLHtGT5qPXuAev4s=.10b4c0a9-0595-4c49-af73-d97ad4daedb7@github.com>

On Wed, 20 Mar 2024 22:48:46 GMT, Alisen Chung <achung at openjdk.org> wrote:

> Removing applet usage from manual JFileChooser tests

test/jdk/javax/swing/JFileChooser/4150029/bug4150029.java line 111:

> 109:         } finally {
> 110:             if (!res) {
> 111:                 throw new RuntimeException("BackSpace keyboard button does not lead to parent directory");

Since we are using PassFailJFrame anyways we can also use static method PassFailJFrame.forceFail(String reason) for connsistency.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18415#discussion_r1534118180

From aivanov at openjdk.org  Thu Mar 21 15:23:23 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Thu, 21 Mar 2024 15:23:23 GMT
Subject: RFR: 8328301: Convert Applet test ManualHTMLDataFlavorTest.java to
 main program [v2]
In-Reply-To: <NAaMbxZuvr-8jiLmuz9OfmkR6bZjYzz8H47YLF0sVQ0=.a8e8bd06-e382-474d-97b5-205d2d9350e6@github.com>
References: <ezZp85g1cKWnR1M7apMh6bxP2_G6P9O5tN6DTSQEOU4=.951f4e5d-e956-4af8-b4f1-725c667224b5@github.com>
 <NAaMbxZuvr-8jiLmuz9OfmkR6bZjYzz8H47YLF0sVQ0=.a8e8bd06-e382-474d-97b5-205d2d9350e6@github.com>
Message-ID: <ZeNQcwSthUfKB_pqRPlyPPN-3zfSqHgkitYLTNvnZa4=.fe9055b1-7626-4c2e-a9af-14fb55a313d3@github.com>

On Wed, 20 Mar 2024 18:57:37 GMT, Phil Race <prr at openjdk.org> wrote:

>> Convert this applet based test to a main program
>
> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8328301

test/jdk/java/awt/datatransfer/HTMLDataFlavors/ManualHTMLDataFlavorTest.java line 110:

> 108:             } catch (UnsupportedFlavorException | IOException e) {
> 109:                 e.printStackTrace();
> 110:             }

Should exception make the test fail?

test/jdk/java/awt/datatransfer/HTMLDataFlavors/ManualHTMLDataFlavorTest.java line 123:

> 121:            the browser to other applications because of,
> 122:            the protected mode restrictions.,
> 123:            On Mac OS X do NOT use Safari, it does not provide the needed DataFlavor,

Suggestion:

           IMPORTANT NOTE: the page should be stored locally.
           Otherwise, for instance iexplore, can prohibit drag and drop from
           the browser to other applications because of
           the protected mode restrictions.
           On Mac OS X do NOT use Safari, it does not provide the needed DataFlavor.

The commas in the end of each line seem to come from the commas separating items in an array of Strings. I'm for removing those commas to avoid any confusion when reading the instructions.

test/jdk/java/awt/datatransfer/HTMLDataFlavors/ManualHTMLDataFlavorTest.java line 126:

> 124:         3) Check the data in the output area of this window,
> 125:         5) The output should not contain information that any of,
> 126:            flavors is not present in the system clipboard,

I believe this condition can be verified automatically. If any missing data flavour should result in test failure, the test could be failed with `PassFailJFrame.forceFail`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18334#discussion_r1534117514
PR Review Comment: https://git.openjdk.org/jdk/pull/18334#discussion_r1534123447
PR Review Comment: https://git.openjdk.org/jdk/pull/18334#discussion_r1534128423

From honkar at openjdk.org  Thu Mar 21 15:33:28 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Thu, 21 Mar 2024 15:33:28 GMT
Subject: Integrated: JDK-8328299 : Convert DnDFileGroupDescriptor.html applet
 test to main
In-Reply-To: <CTOJXaNDso7Gmw-A2kTkmsZmAWqcWllOim2Y_BGgeok=.5d62efd5-66c2-47a7-b1f0-c10f4c366b40@github.com>
References: <CTOJXaNDso7Gmw-A2kTkmsZmAWqcWllOim2Y_BGgeok=.5d62efd5-66c2-47a7-b1f0-c10f4c366b40@github.com>
Message-ID: <WLA65h4RXVoZki-ffkF76A6Goqnh2IG_Z2TmO_fGmE8=.ea96366d-7d8b-4768-aec4-a8485def82e1@github.com>

On Fri, 15 Mar 2024 22:54:23 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

> Following test java/awt/dnd/DnDFileGroupDescriptor/DnDFileGroupDescriptor.html is converted to main using PassFailJFrame.
> 
> This test is currently problem-listed on macOS and linux, but as per the previous JBS bugs [[JDK-6242241](https://bugs.openjdk.org/browse/JDK-6242241), [JDK-8080185](https://bugs.openjdk.org/browse/JDK-8080185), [JDK-7147083](https://bugs.openjdk.org/browse/JDK-7147083)] this test was original created for testing DnD of MS Outlook attachments on Windows system.
> 
> Based on the test history and JBS details, I believe this should be windows-only test and should NOT be problemlisted on macOS and linux as it is **not applicable**.

This pull request has now been integrated.

Changeset: 75195aab
Author:    Harshitha Onkar <honkar at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/75195aab497a2d23548128e03f6887283dcaa7e1
Stats:     258 lines in 3 files changed: 36 ins; 188 del; 34 mod

8328299: Convert DnDFileGroupDescriptor.html applet test to main

Reviewed-by: psadhukhan, tr

-------------

PR: https://git.openjdk.org/jdk/pull/18335

From azvegint at openjdk.org  Thu Mar 21 15:34:26 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Thu, 21 Mar 2024 15:34:26 GMT
Subject: Integrated: 8328402: Implement pausing functionality for the
 PassFailJFrame
In-Reply-To: <_G5oabZhLzV7Ld3agI-uiRKWhJL5_8i8LVWA7JSBhOM=.c025ce82-16ed-4b8d-8e2b-1a8bc849639c@github.com>
References: <_G5oabZhLzV7Ld3agI-uiRKWhJL5_8i8LVWA7JSBhOM=.c025ce82-16ed-4b8d-8e2b-1a8bc849639c@github.com>
Message-ID: <8zT3P8X5cRZ6g8WKgwYSzmZ1rZJC_iYSxkzvqJspI4k=.c76e499d-b864-425c-a962-0067d03804e3@github.com>

On Tue, 19 Mar 2024 01:14:29 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>> we need to add next to Pass/Fail a "Pause Timer" button, that
> (a) stops the count down
> (b) changes the Pause Timer to "Resume Timer"
> ~~(c) disables Pass/Fail until the timer is resumed~~
> the test will not have to pause or be aware - only the PassFailJFrame machinery.
> ~~So the tester can do anything they want except exit the test in the paused mode.~~
> 
> This PR implements everything except the (c).
> I see nothing wrong with completing the test from the paused state, and it does not add an extra click.  
> 
> 
> Example screenshots:
> 
> ![image](https://github.com/openjdk/jdk/assets/77687766/65d34bf8-1e46-4e68-b39e-a77f257ec3c0)
> ![image](https://github.com/openjdk/jdk/assets/77687766/3a43e059-2d48-46f3-9d1b-c2ab84fcce37)

This pull request has now been integrated.

Changeset: 581b1e29
Author:    Alexander Zvegintsev <azvegint at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/581b1e29aebd425bade14d2ee46704a16187df5b
Stats:     47 lines in 1 file changed: 35 ins; 2 del; 10 mod

8328402: Implement pausing functionality for the PassFailJFrame

Reviewed-by: aivanov, prr

-------------

PR: https://git.openjdk.org/jdk/pull/18368

From aivanov at openjdk.org  Thu Mar 21 16:05:28 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Thu, 21 Mar 2024 16:05:28 GMT
Subject: Integrated: 8327924: Simplify TrayIconScalingTest.java
In-Reply-To: <v4lDY1J2WCp2RqxfYXNYImaEx5EOeX2x4LM23n93Zrs=.010ab607-ba30-484d-b293-460ed4444b1a@github.com>
References: <v4lDY1J2WCp2RqxfYXNYImaEx5EOeX2x4LM23n93Zrs=.010ab607-ba30-484d-b293-460ed4444b1a@github.com>
Message-ID: <TJ3PcSVIaPqSdRc1Ql2yC1OAoi_EXOLMierJEaXuUT0=.cbc27314-759c-495b-ac16-7bc4cde9e245@github.com>

On Tue, 12 Mar 2024 08:33:41 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> This is to simplify `TrayIconScalingTest.java`.
> 
> 1. Rename `createAndShowGUI` to `createAndShowTrayIcon` which is more specific.
> 2. Move creating tray icon to the top.
> 3. Streamline PassFailJFrame with the chained calls, including `awaitAndCheck`.
> 4. Ensure tray is not null before removing the icon.
> 5. Pass AWTException as the cause in the wrapped exception.
> 
> Previously, before the builder pattern was introduced, `PassFailJFrame.positionTestWindow` had had to be called to show the instructions UI. It's not required any more. Additionally, it has the effect of moving the instruction frame to the left, which doesn't look good and sometimes results in positioning the instructions outside of the screen bounds if the screen resolution is low.
> 
> With the builder pattern, the call to the `build` method shows all the registered windows on the screen, including the instruction frame. Since there's no secondary UI, the instructions remain in the centre of the screen.

This pull request has now been integrated.

Changeset: 1496b5de
Author:    Alexey Ivanov <aivanov at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/1496b5de9004c6a9e43ead5f6e9e88362028a7cc
Stats:     27 lines in 1 file changed: 10 ins; 11 del; 6 mod

8327924: Simplify TrayIconScalingTest.java

Reviewed-by: honkar, prr

-------------

PR: https://git.openjdk.org/jdk/pull/18224

From aivanov at openjdk.org  Thu Mar 21 16:06:26 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Thu, 21 Mar 2024 16:06:26 GMT
Subject: Integrated: 8325179: Race in BasicDirectoryModel.validateFileCache
In-Reply-To: <nOapec57Ql6DHy57oEeWdkUGER8RYdWc2vwmJsqWDYc=.8de81954-d8c2-4937-b426-e61dde05255e@github.com>
References: <nOapec57Ql6DHy57oEeWdkUGER8RYdWc2vwmJsqWDYc=.8de81954-d8c2-4937-b426-e61dde05255e@github.com>
Message-ID: <NSTcQamTqyI_B9tfN83HYyHwTsw_728TmNt8RE77paw=.c4b95825-eb22-4e84-91d7-4eadd2065afc@github.com>

On Mon, 4 Mar 2024 20:21:30 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> Ensure access to the `filesLoader` field of `BasicDirectoryModel` is synchronized.
> 
> Without synchronization, a thread checks if `filesLoader` is not null and creates a new `FilesLoader` thread. If the thread is pre-empted between these two operations, another thread or even several threads can see the `null` value and create new `FilesLoader` threads.
> 
> The same way, `BasicDirectoryModel.invalidateFileCache` needs to be synchornized to interrupt the current `filesLoader` and assign `null`.
> 
> This bug allows reproducing `ConcurrentModificationException` seen in [JDK-8323670](https://bugs.openjdk.org/browse/JDK-8323670) and [JDK-8307091](https://bugs.openjdk.org/browse/JDK-8307091) using the test in PR #18109.

This pull request has now been integrated.

Changeset: e66788c1
Author:    Alexey Ivanov <aivanov at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/e66788c16563d343f6cccd2807a251ccc6f9b64a
Stats:     69 lines in 1 file changed: 17 ins; 21 del; 31 mod

8325179: Race in BasicDirectoryModel.validateFileCache
8238169: BasicDirectoryModel getDirectories and DoChangeContents.run can deadlock

Reviewed-by: prr, tr, aturbanov, serb

-------------

PR: https://git.openjdk.org/jdk/pull/18111

From dnguyen at openjdk.org  Thu Mar 21 16:08:48 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Thu, 21 Mar 2024 16:08:48 GMT
Subject: RFR: 8328558: Convert
 javax/swing/JCheckBox/8032667/bug8032667.java applet test to main [v3]
In-Reply-To: <g745t9uMBoROVg83p-3Hkv9s_BjHREVBFnSBVRBT5s4=.9865582b-5db3-4073-97dd-21625ba72991@github.com>
References: <g745t9uMBoROVg83p-3Hkv9s_BjHREVBFnSBVRBT5s4=.9865582b-5db3-4073-97dd-21625ba72991@github.com>
Message-ID: <quwFDxvB3cFbAnUxeTi9nebY4LM1Dafbu5DGxyglKho=.4405b494-6090-4786-ab5d-022d5396b3f4@github.com>

> Convert javax/swing/JCheckBox/8032667/bug8032667.java applet test to main using PassFailJFrame

Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:

  Replace canvas with jpanel

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18403/files
  - new: https://git.openjdk.org/jdk/pull/18403/files/2416a1c1..839a7db9

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18403&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18403&range=01-02

  Stats: 4 lines in 1 file changed: 1 ins; 1 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/18403.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18403/head:pull/18403

PR: https://git.openjdk.org/jdk/pull/18403

From dnguyen at openjdk.org  Thu Mar 21 16:08:49 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Thu, 21 Mar 2024 16:08:49 GMT
Subject: RFR: 8328558: Convert
 javax/swing/JCheckBox/8032667/bug8032667.java applet test to main [v2]
In-Reply-To: <ymdldBuvO27BEdgT4ia8USLV5rqJOj3VdychlFSx-3w=.302d496a-c5d2-4299-9a06-22c5f1aac89e@github.com>
References: <g745t9uMBoROVg83p-3Hkv9s_BjHREVBFnSBVRBT5s4=.9865582b-5db3-4073-97dd-21625ba72991@github.com>
 <f3-FmlVCJlwmXpzeOSfObwO_jQgM6h20Jv_xFhGK6ZI=.bab9e228-f66b-4ecd-ab3a-26eb02089e8d@github.com>
 <ymdldBuvO27BEdgT4ia8USLV5rqJOj3VdychlFSx-3w=.302d496a-c5d2-4299-9a06-22c5f1aac89e@github.com>
Message-ID: <MSfgfeCKbitKhDgvkxDVgZOJELjPp_1Sr6feVxpwY9k=.6141133e-71e9-4851-8e72-29d6f71e9fd5@github.com>

On Thu, 21 Mar 2024 11:52:28 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add new line
>
> test/jdk/javax/swing/JCheckBox/bug8032667.java line 78:
> 
>> 76:         final Image image1 = getImage(getCheckBox("Deselected", false));
>> 77:         final Image image2 = getImage(getCheckBox("Selected", true));
>> 78:         Canvas canvas = new Canvas() {
> 
> I recommend using `JPanel` instead of `Canvas`. The former is a Swing lightweight component, whereas the latter is an AWT heavyweight component. It's still better not to mix them.

Replaced `Canvas` with `JPanel`. Thanks

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18403#discussion_r1534211977

From dnguyen at openjdk.org  Thu Mar 21 16:11:35 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Thu, 21 Mar 2024 16:11:35 GMT
Subject: RFR: 8328005: Convert java/awt/im/JTextFieldTest.java applet test
 to main [v5]
In-Reply-To: <L1GhxeYrU35BXYEe9h_FL05fGrPgE7q4vWv3qTOe854=.c20a5812-ec96-4541-94b8-106dd17d9f95@github.com>
References: <L1GhxeYrU35BXYEe9h_FL05fGrPgE7q4vWv3qTOe854=.c20a5812-ec96-4541-94b8-106dd17d9f95@github.com>
Message-ID: <Bknkx_G7qQkZFpHb6hnPk74CTW7Z5gXEignHMGmSQvs=.cb274b5f-6017-430d-9cc8-389e32f4cdf8@github.com>

> Convert java/awt/im/JTextFieldTest.java applet test to main using PassFailJFrame.

Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:

  Review comments

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18247/files
  - new: https://git.openjdk.org/jdk/pull/18247/files/c27b6139..3aa7b0f2

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18247&range=04
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18247&range=03-04

  Stats: 3 lines in 1 file changed: 0 ins; 1 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/18247.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18247/head:pull/18247

PR: https://git.openjdk.org/jdk/pull/18247

From dnguyen at openjdk.org  Thu Mar 21 16:11:35 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Thu, 21 Mar 2024 16:11:35 GMT
Subject: RFR: 8328005: Convert java/awt/im/JTextFieldTest.java applet test
 to main [v4]
In-Reply-To: <KxrDfNTAgEatzegCuvj9EFItMzamexP3KWTcOxp3UPQ=.eee80fc4-c62c-42ec-8212-73af42380897@github.com>
References: <L1GhxeYrU35BXYEe9h_FL05fGrPgE7q4vWv3qTOe854=.c20a5812-ec96-4541-94b8-106dd17d9f95@github.com>
 <M1vo4AmKe8F14Ot3-1JJBQuEg05q6MyAvrKUrKaItXs=.343f5a2a-f341-4fbd-8264-1059b2b19009@github.com>
 <KxrDfNTAgEatzegCuvj9EFItMzamexP3KWTcOxp3UPQ=.eee80fc4-c62c-42ec-8212-73af42380897@github.com>
Message-ID: <LPtHuiW_VX_JM56SwrrlHA84o_sRiCidziD54z0qwHI=.d2e34406-0d3b-432f-b245-d7b1ac6fda43@github.com>

On Thu, 21 Mar 2024 07:41:15 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove reundant window constant
>
> test/jdk/java/awt/im/JTextFieldTest.java line 32:
> 
>> 30:  *           work correctly with IM when there is an uneditable peered
>> 31:  *           TextField/TextArea in the same parent Frame
>> 32:  * @run main JTextFieldTest
> 
> should be main/manual ?

Fixed.

> test/jdk/java/awt/im/JTextFieldTest.java line 42:
> 
>> 40: 
>> 41: public class JTextFieldTest {
>> 42:     private static JFrame frame;
> 
> can be moved to local scope in `createAndShowGUI` method.

Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18247#discussion_r1534215303
PR Review Comment: https://git.openjdk.org/jdk/pull/18247#discussion_r1534215460

From dnguyen at openjdk.org  Thu Mar 21 16:11:44 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Thu, 21 Mar 2024 16:11:44 GMT
Subject: RFR: 8328370: Convert java/awt/print/Dialog/PrintApplet.java
 applet test to main [v4]
In-Reply-To: <Je7yOnjOAjH3DsIgUx72_7ASxsrXS5oIskdKM716AiA=.f1a73b22-8644-40cc-91d6-9ce301f03cc2@github.com>
References: <Je7yOnjOAjH3DsIgUx72_7ASxsrXS5oIskdKM716AiA=.f1a73b22-8644-40cc-91d6-9ce301f03cc2@github.com>
Message-ID: <sgvht4dgRxM3dskOeAkWUox9DmTJKDrD-_s0C4ZjeKc=.e6f75f54-eaab-4402-8c2b-595cfdf41c9a@github.com>

> Convert java/awt/print/Dialog/PrintApplet.java applet test to main using PassFailJFrame. Also rename the test to PrintModalDialog.java since this is no longer an applet. Added test instructions related to the linked JBS issue.

Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:

  Fix main/manual

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18362/files
  - new: https://git.openjdk.org/jdk/pull/18362/files/5db0a4af..38eb00eb

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18362&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18362&range=02-03

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/18362.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18362/head:pull/18362

PR: https://git.openjdk.org/jdk/pull/18362

From dnguyen at openjdk.org  Thu Mar 21 16:11:44 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Thu, 21 Mar 2024 16:11:44 GMT
Subject: RFR: 8328370: Convert java/awt/print/Dialog/PrintApplet.java
 applet test to main [v3]
In-Reply-To: <xNNo50d-Lcd1K7prAazfarXsRnPQWbzr185YpaoNwq0=.6ec26750-7358-49e1-b6e0-3cf67d5354c4@github.com>
References: <Je7yOnjOAjH3DsIgUx72_7ASxsrXS5oIskdKM716AiA=.f1a73b22-8644-40cc-91d6-9ce301f03cc2@github.com>
 <W6z0LZ1HPa19caIjkQKD-fVGElai98aDMuOkQzfOtvc=.2606585d-acd7-4bf6-a65f-23eeba49aec3@github.com>
 <xNNo50d-Lcd1K7prAazfarXsRnPQWbzr185YpaoNwq0=.6ec26750-7358-49e1-b6e0-3cf67d5354c4@github.com>
Message-ID: <1d1yz5yLW82IKmVN6FPWkFaLrjIfncdyevZG80zbXjg=.c99bb932-76e9-4400-bfa0-fd6db4f8df61@github.com>

On Thu, 21 Mar 2024 05:30:58 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Damon Nguyen has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Modify instructions more
>>  - Modify instructions
>
> test/jdk/java/awt/print/Dialog/PrintModalDialog.java line 31:
> 
>> 29:  * @build PassFailJFrame
>> 30:  * @summary Pass if dialogs are modal.
>> 31:  * @run main PrintModalDialog
> 
> should be main/manual

Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18362#discussion_r1534218410

From dnguyen at openjdk.org  Thu Mar 21 16:15:40 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Thu, 21 Mar 2024 16:15:40 GMT
Subject: RFR: 8328558: Convert
 javax/swing/JCheckBox/8032667/bug8032667.java applet test to main [v4]
In-Reply-To: <g745t9uMBoROVg83p-3Hkv9s_BjHREVBFnSBVRBT5s4=.9865582b-5db3-4073-97dd-21625ba72991@github.com>
References: <g745t9uMBoROVg83p-3Hkv9s_BjHREVBFnSBVRBT5s4=.9865582b-5db3-4073-97dd-21625ba72991@github.com>
Message-ID: <EiQsxOgNvLo8k7kPlMUdPQvTy9-2cQNOk78SGF1-2W0=.b652ec5f-f7be-45c3-9939-d8753d840bbe@github.com>

> Convert javax/swing/JCheckBox/8032667/bug8032667.java applet test to main using PassFailJFrame

Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:

  Remove contentPane

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18403/files
  - new: https://git.openjdk.org/jdk/pull/18403/files/839a7db9..f9f02662

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18403&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18403&range=02-03

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/18403.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18403/head:pull/18403

PR: https://git.openjdk.org/jdk/pull/18403

From aivanov at openjdk.org  Thu Mar 21 16:15:41 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Thu, 21 Mar 2024 16:15:41 GMT
Subject: RFR: 8328558: Convert
 javax/swing/JCheckBox/8032667/bug8032667.java applet test to main [v3]
In-Reply-To: <quwFDxvB3cFbAnUxeTi9nebY4LM1Dafbu5DGxyglKho=.4405b494-6090-4786-ab5d-022d5396b3f4@github.com>
References: <g745t9uMBoROVg83p-3Hkv9s_BjHREVBFnSBVRBT5s4=.9865582b-5db3-4073-97dd-21625ba72991@github.com>
 <quwFDxvB3cFbAnUxeTi9nebY4LM1Dafbu5DGxyglKho=.4405b494-6090-4786-ab5d-022d5396b3f4@github.com>
Message-ID: <55eDqQ7iCzzs_m7cYhVTyO6kxOhggZ_otrl7h8Vg9hA=.b94a11c3-0ed8-4206-80b7-879b1e25ebc5@github.com>

On Thu, 21 Mar 2024 16:08:48 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

>> Convert javax/swing/JCheckBox/8032667/bug8032667.java applet test to main using PassFailJFrame
>
> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Replace canvas with jpanel

Marked as reviewed by aivanov (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18403#pullrequestreview-1952713007

From dnguyen at openjdk.org  Thu Mar 21 16:15:41 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Thu, 21 Mar 2024 16:15:41 GMT
Subject: Integrated: 8328558: Convert
 javax/swing/JCheckBox/8032667/bug8032667.java applet test to main
In-Reply-To: <g745t9uMBoROVg83p-3Hkv9s_BjHREVBFnSBVRBT5s4=.9865582b-5db3-4073-97dd-21625ba72991@github.com>
References: <g745t9uMBoROVg83p-3Hkv9s_BjHREVBFnSBVRBT5s4=.9865582b-5db3-4073-97dd-21625ba72991@github.com>
Message-ID: <JAiLSPquuuQQpLWxbQXqE8COepn9mVnFG0XKPIyR6UQ=.9effc53b-db35-411c-938c-e21e69a47789@github.com>

On Wed, 20 Mar 2024 16:46:40 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

> Convert javax/swing/JCheckBox/8032667/bug8032667.java applet test to main using PassFailJFrame

This pull request has now been integrated.

Changeset: ef2bd572
Author:    Damon Nguyen <dnguyen at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/ef2bd5721316f208a458fecfffa02ec2c0ea7fe0
Stats:     351 lines in 4 files changed: 108 ins; 243 del; 0 mod

8328558: Convert javax/swing/JCheckBox/8032667/bug8032667.java applet test to main

Reviewed-by: abhiscxk, psadhukhan, aivanov

-------------

PR: https://git.openjdk.org/jdk/pull/18403

From psadhukhan at openjdk.org  Thu Mar 21 16:21:21 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Thu, 21 Mar 2024 16:21:21 GMT
Subject: RFR: 8328382: Convert java/awt/FileDialog/FileDialogForPackages
 test to main [v2]
In-Reply-To: <_ytFO979o9K4RS7fFO_JTQKBda1f-S-at-TBIiWeLhs=.f9467d54-2198-4f3d-a3bc-c90e3a36c2e4@github.com>
References: <9gStC1mcEgWDsQsLiOUD0PHZ1mgIEgaM3f_EAQokmv0=.7f9ce16a-2180-4dea-96af-bcbcf955eec7@github.com>
 <_ytFO979o9K4RS7fFO_JTQKBda1f-S-at-TBIiWeLhs=.f9467d54-2198-4f3d-a3bc-c90e3a36c2e4@github.com>
Message-ID: <MKVedV-MEXVNNOh3Pwdvl1qF1EShs8k9R7cqVNHcKks=.98f16733-ed37-4689-85a2-d1077ad3b182@github.com>

On Tue, 19 Mar 2024 14:10:52 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

>> Convert test to a main based;
>> Move test to an appropriate folder;
>> Remove old files;
>
> Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Adding library and build clauses

test/jdk/java/awt/FileDialog/FileDialogForPackages.java line 59:

> 57:         frame.add(textScrollPane, BorderLayout.CENTER);
> 58: 
> 59:         fd = new FileDialog(new Frame(), "Open");

is there any need to mix Swing and AWT components in the test? I guess you can use the JFrame already created

test/jdk/java/awt/FileDialog/FileDialogForPackages.java line 60:

> 58: 
> 59:         fd = new FileDialog(new Frame(), "Open");
> 60:         fd.setDirectory(APPLICATIONS_FOLDER);

guess APPLICATION_FOLDER can be made local

test/jdk/java/awt/FileDialog/FileDialogForPackages.java line 91:

> 89:                 .rows((int) instructions.lines().count() + 1)
> 90:                 .columns(40)
> 91:                 .testUI(FileDialogForPackages::initialize)

It seems the filedialog is obscuring the instruction and test window...I guess it will be good if you can use 
position(PassFailJFrame.Position.TOP_LEFT_CORNER)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18360#discussion_r1534230960
PR Review Comment: https://git.openjdk.org/jdk/pull/18360#discussion_r1534230082
PR Review Comment: https://git.openjdk.org/jdk/pull/18360#discussion_r1534232128

From dnguyen at openjdk.org  Thu Mar 21 16:35:43 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Thu, 21 Mar 2024 16:35:43 GMT
Subject: RFR: 8328717: Convert
 javax/swing/JColorChooser/8065098/bug8065098.java applet test to main
Message-ID: <SZLE6sOQUNGW_tBIfu6MkZE7rxjp5HJGZih6X50rrpw=.231ba8d7-c9cb-4dc9-b27a-62060696d0a1@github.com>

Convert javax/swing/JColorChooser/8065098/bug8065098.java applet test to main using PassFailJFrame for the instructions.

-------------

Commit messages:
 - Lambda replacement
 - Initial test conversion

Changes: https://git.openjdk.org/jdk/pull/18436/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18436&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8328717
  Stats: 85 lines in 3 files changed: 26 ins; 46 del; 13 mod
  Patch: https://git.openjdk.org/jdk/pull/18436.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18436/head:pull/18436

PR: https://git.openjdk.org/jdk/pull/18436

From dnguyen at openjdk.org  Thu Mar 21 16:36:24 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Thu, 21 Mar 2024 16:36:24 GMT
Subject: Integrated: 8328005: Convert java/awt/im/JTextFieldTest.java applet
 test to main
In-Reply-To: <L1GhxeYrU35BXYEe9h_FL05fGrPgE7q4vWv3qTOe854=.c20a5812-ec96-4541-94b8-106dd17d9f95@github.com>
References: <L1GhxeYrU35BXYEe9h_FL05fGrPgE7q4vWv3qTOe854=.c20a5812-ec96-4541-94b8-106dd17d9f95@github.com>
Message-ID: <meB_YHhzYn6tEwXHfmEYjZQ15Qck5e44t4XusZcMB8s=.a9309a92-bd2f-45f9-8006-f7a54114bcc3@github.com>

On Tue, 12 Mar 2024 18:50:58 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

> Convert java/awt/im/JTextFieldTest.java applet test to main using PassFailJFrame.

This pull request has now been integrated.

Changeset: cc5cda55
Author:    Damon Nguyen <dnguyen at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/cc5cda558736ffeae2a4611d87dfe280b9a4eac3
Stats:     68 lines in 2 files changed: 11 ins; 32 del; 25 mod

8328005: Convert java/awt/im/JTextFieldTest.java applet test to main

Reviewed-by: prr, abhiscxk

-------------

PR: https://git.openjdk.org/jdk/pull/18247

From azvegint at openjdk.org  Thu Mar 21 16:38:22 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Thu, 21 Mar 2024 16:38:22 GMT
Subject: RFR: 8328384: Convert java/awt/FileDialog/FileDialogOpenDirTest
 test to main [v4]
In-Reply-To: <p--yZctibvM9RfAx_Hc5CUSa_YDBH-dofPo_3GRMCFw=.17979032-f2ca-4d28-8ffe-94ba8b10b7a4@github.com>
References: <uRRE9Iw6m8G9T9H0FWEYnUoGgInL7vGgYMPBwP7jEVI=.cb6605a0-f79a-4903-b565-e5dc29d81df2@github.com>
 <p--yZctibvM9RfAx_Hc5CUSa_YDBH-dofPo_3GRMCFw=.17979032-f2ca-4d28-8ffe-94ba8b10b7a4@github.com>
Message-ID: <S-3FWvIPJsDAnM6wXEDeyOceFwWxnR54_b0zCrjS1xI=.d01fd7fa-5adc-47cb-9e43-c32be54a5427@github.com>

On Wed, 20 Mar 2024 15:48:41 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

>> Convert test to main manual;
>> Move test to appropriate folder;
>> Delete old files;
>
> Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Moving test metadata closer to the class definition for better readability;
>   Making test automatically skip execution on unsuported toolkit;
>   Eliminated the separate frame, moving button inside the PassFailJFrame;
>   Corrected test instructions accordingly;

Marked as reviewed by azvegint (Reviewer).

test/jdk/java/awt/FileDialog/FileDialogOpenDirTest.java line 49:

> 47:         JButton open = new JButton("Open File Dialog");
> 48:         open.addActionListener(e -> {
> 49:             new FileDialog((Frame) null).show();

Suggestion:

            new FileDialog((Frame) null).setVisible(true);

show is deprecated

test/jdk/java/awt/FileDialog/FileDialogOpenDirTest.java line 68:

> 66:         if (!toolkit.equals("sun.awt.X11.XToolkit")) {
> 67:             throw new SkippedException("Test is not designed for toolkit " + toolkit);
> 68:         }

Cay be moved to the beginning of the main, to bail out early.

-------------

PR Review: https://git.openjdk.org/jdk/pull/18361#pullrequestreview-1952775158
PR Review Comment: https://git.openjdk.org/jdk/pull/18361#discussion_r1534257573
PR Review Comment: https://git.openjdk.org/jdk/pull/18361#discussion_r1534258864

From psadhukhan at openjdk.org  Thu Mar 21 16:49:22 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Thu, 21 Mar 2024 16:49:22 GMT
Subject: RFR: 8328670: Automate and open source few closed manual applet
 test
In-Reply-To: <ekaFQm1J1iN3WflMPr1EjImabwkt3O6QIB733BF1Kss=.82bb6086-fe25-46f2-916f-67a458eb6f3f@github.com>
References: <ekaFQm1J1iN3WflMPr1EjImabwkt3O6QIB733BF1Kss=.82bb6086-fe25-46f2-916f-67a458eb6f3f@github.com>
Message-ID: <9lWyWMS85BTpJDCxcUVhXvL8vvPMvcs-GkzBSKnrdJk=.b7f9c4c5-4bd0-4f85-8a48-a4f60b10c4d1@github.com>

On Thu, 21 Mar 2024 10:46:41 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

> Few manual closed applet test converted to automated and open sourced.

Marked as reviewed by psadhukhan (Reviewer).

test/jdk/javax/swing/JInternalFrame/Ctrli.java line 126:

> 124:         keyecho.addMouseListener(mouseListener);
> 125:         frame.setLayout(new BorderLayout());
> 126:         frame.getContentPane().add(keyecho);

getContentPane is obsolete since jdk1.5 so can be removed as per this [comment](https://github.com/openjdk/jdk/pull/18390#discussion_r1533017080)

test/jdk/javax/swing/JMenuItem/JActionCommandTest.java line 135:

> 133:         mb.add(m);
> 134:         f.setJMenuBar(mb);
> 135:         f.getContentPane().add("South", tf);

same as above..

-------------

PR Review: https://git.openjdk.org/jdk/pull/18428#pullrequestreview-1952802096
PR Review Comment: https://git.openjdk.org/jdk/pull/18428#discussion_r1534273918
PR Review Comment: https://git.openjdk.org/jdk/pull/18428#discussion_r1534274838

From dnguyen at openjdk.org  Thu Mar 21 16:51:36 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Thu, 21 Mar 2024 16:51:36 GMT
Subject: RFR: 8328368: Convert
 java/awt/image/multiresolution/MultiDisplayTest/MultiDisplayTest.java applet
 test to main [v2]
In-Reply-To: <VarHifZU9rXM4lqKzE_slP-8Q9K0CA65KBTCD6CD9Zc=.ec8e5b7b-cd94-43d2-9eb2-ea90997d030d@github.com>
References: <VarHifZU9rXM4lqKzE_slP-8Q9K0CA65KBTCD6CD9Zc=.ec8e5b7b-cd94-43d2-9eb2-ea90997d030d@github.com>
Message-ID: <Id5cp_b0Mi-JVqy97M8Qyf1jjvcuFCDV5y845c_Gefo=.a3d21d1c-da9b-4bc4-8e11-5ee96806a0fc@github.com>

> Convert java/awt/image/multiresolution/MultiDisplayTest/MultiDisplayTest.java applet test to main using PassFailJFrame

Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:

  Review comments

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18354/files
  - new: https://git.openjdk.org/jdk/pull/18354/files/836e9e0c..64f49ff7

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18354&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18354&range=00-01

  Stats: 33 lines in 1 file changed: 16 ins; 16 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/18354.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18354/head:pull/18354

PR: https://git.openjdk.org/jdk/pull/18354

From dnguyen at openjdk.org  Thu Mar 21 16:51:36 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Thu, 21 Mar 2024 16:51:36 GMT
Subject: RFR: 8328368: Convert
 java/awt/image/multiresolution/MultiDisplayTest/MultiDisplayTest.java applet
 test to main [v2]
In-Reply-To: <2AcXge8T2E_dFxknLKDqwHoHTLrpY7ff9dOWDqVMQsQ=.75e27ab5-d806-4fe7-8470-98b014c86cc6@github.com>
References: <VarHifZU9rXM4lqKzE_slP-8Q9K0CA65KBTCD6CD9Zc=.ec8e5b7b-cd94-43d2-9eb2-ea90997d030d@github.com>
 <2AcXge8T2E_dFxknLKDqwHoHTLrpY7ff9dOWDqVMQsQ=.75e27ab5-d806-4fe7-8470-98b014c86cc6@github.com>
Message-ID: <w8mzB767mtiTJT0CrANWkTFL1HiZudFura88R8RDBzs=.d44254ea-9cf5-4e12-a87b-bbc68648cd80@github.com>

On Thu, 21 Mar 2024 14:14:17 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review comments
>
> test/jdk/java/awt/image/multiresolution/MultiDisplayTest.java line 33:
> 
>> 31:  *         on HiDPI + non-HiDPI display pair.
>> 32:  * @run main MultiDisplayTest
>> 33:  */
> 
> We usually move this block just before a class declaration, for better readability.

Moved.

> test/jdk/java/awt/image/multiresolution/MultiDisplayTest.java line 58:
> 
>> 56:             """
>> 57:              This test is for OS X or Windows only.
>> 58:              For other OSes please simply push "Pass".
> 
> `please simply push "Pass"` usually means that it can be replaced with `PassFailJFrame.forcePass()`, but in this case the `@requires (os.family...` can be used to avoid running the test on unwanted platforms.

Added jtreg `@requires` tag.

> test/jdk/java/awt/image/multiresolution/MultiDisplayTest.java line 93:
> 
>> 91:         generateImage(1, Color.BLACK), generateImage(2, Color.BLUE)});
>> 92: 
>> 93:     public static void main(String[] args) throws Exception {
> 
> While the `@requires (os.family...` should be enough, we can add something like
> 
> if (!checkOS()) {
>     throw new SkippedException("..."); //jtreg.SkippedException
> }

Added. Thanks. Thought about not needing this at all, but it doesn't hurt to add.

> test/jdk/java/awt/image/multiresolution/MultiDisplayTest.java line 109:
> 
>> 107:         frame.setLayout(new BorderLayout());
>> 108:         Button b = new Button("Start");
>> 109:         b.setEnabled(checkOS());
> 
> With the changes mentioned above, this will become obsolete.

Removed the `checkOS()` call.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18354#discussion_r1534277257
PR Review Comment: https://git.openjdk.org/jdk/pull/18354#discussion_r1534277092
PR Review Comment: https://git.openjdk.org/jdk/pull/18354#discussion_r1534276882
PR Review Comment: https://git.openjdk.org/jdk/pull/18354#discussion_r1534277948

From dnguyen at openjdk.org  Thu Mar 21 16:52:21 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Thu, 21 Mar 2024 16:52:21 GMT
Subject: RFR: 8328370: Convert java/awt/print/Dialog/PrintApplet.java
 applet test to main [v4]
In-Reply-To: <sgvht4dgRxM3dskOeAkWUox9DmTJKDrD-_s0C4ZjeKc=.e6f75f54-eaab-4402-8c2b-595cfdf41c9a@github.com>
References: <Je7yOnjOAjH3DsIgUx72_7ASxsrXS5oIskdKM716AiA=.f1a73b22-8644-40cc-91d6-9ce301f03cc2@github.com>
 <sgvht4dgRxM3dskOeAkWUox9DmTJKDrD-_s0C4ZjeKc=.e6f75f54-eaab-4402-8c2b-595cfdf41c9a@github.com>
Message-ID: <n1AeCK-cM8QTuYhh2B8y4SZ3VOLE_Uwq0ObjN4O_eSg=.3d1fb576-d473-4c27-8b8a-d38273dae7b0@github.com>

On Thu, 21 Mar 2024 16:11:44 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

>> Convert java/awt/print/Dialog/PrintApplet.java applet test to main using PassFailJFrame. Also rename the test to PrintModalDialog.java since this is no longer an applet. Added test instructions related to the linked JBS issue.
>
> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix main/manual

@prsadhuk @prrace Can I get a re-review on this? Thanks!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18362#issuecomment-2012981058

From duke at openjdk.org  Thu Mar 21 17:04:21 2024
From: duke at openjdk.org (Joel Uckelman)
Date: Thu, 21 Mar 2024 17:04:21 GMT
Subject: RFR: 8305072: Win32ShellFolder2.compareTo is inconsistent [v2]
In-Reply-To: <2LG0ERi-9ETplOC0EdSozMQ4WTJDgx2lw3Z1J6IVrrY=.03443566-afd3-4d7e-8caa-46fa10c55a5e@github.com>
References: <bEiHvkFnBZDqmiqQdk_-_mATVhDbAD7NZX7VnkHLG2E=.27ee84ba-00fd-405a-9489-8fe11c215af9@github.com>
 <21db5CiFTVN7scwsIHknMxF4YaVQd06m7gUOhcCLvMI=.e2f61ea7-bf9a-4632-bf45-c89f979ae806@github.com>
 <6dQg9rhDwh4ZL7D2JfYpA0xNP_eJDbOK3rNgj7efckM=.c5001d8a-cce5-4a11-a91d-eda8e90b8056@github.com>
 <76BSt4HYmTD2DiZzBUvNvBdvd5d1MFinIDsgp2YuHjs=.68646608-e266-4ca3-8495-59e237f8607c@github.com>
 <5btT_N4c5R89DQ8aoSyjm6lIR7PHLWC141uAIdH_Bjw=.f36326e9-0f59-4545-82bf-f3c8b4dbaa87@github.com>
 <xEaIYt-r-0MtZBDcpke8dec_MkYGmm_gsj0NcagSMGs=.0f29ce1b-ff4b-4505-9095-5602cdbd3de9@github.com>
 <2LG0ERi-9ETplOC0EdSozMQ4WTJDgx2lw3Z1J6IVrrY=.03443566-afd3-4d7e-8caa-46fa10c55a5e@github.com>
Message-ID: <c5xKrm3ItuUN26iAY8k2RiSZu8ppMnTVisVokmy7RMA=.36ff81f6-f473-4b35-b853-595dc5491230@github.com>

On Thu, 21 Mar 2024 12:02:52 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Hi, I'm the submitter of the original bug report. I can confirm that you got the reason for the change exactly right.
>
> @uckelman Is there a way to reproduce the original bug in the user's environment?
> 
> I think there's a bug in JDK which leads to two _Documents_ folders in the list. If the bug is still reproducible, collecting more data will help us identify the problem and fix it.

If I can get in contact with the user, I expect he'd still be able to trigger the bug with my test case, yeah. I'll try to get his attention.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18126#discussion_r1534298705

From azvegint at openjdk.org  Thu Mar 21 17:07:22 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Thu, 21 Mar 2024 17:07:22 GMT
Subject: RFR: 8328368: Convert
 java/awt/image/multiresolution/MultiDisplayTest/MultiDisplayTest.java applet
 test to main [v2]
In-Reply-To: <Id5cp_b0Mi-JVqy97M8Qyf1jjvcuFCDV5y845c_Gefo=.a3d21d1c-da9b-4bc4-8e11-5ee96806a0fc@github.com>
References: <VarHifZU9rXM4lqKzE_slP-8Q9K0CA65KBTCD6CD9Zc=.ec8e5b7b-cd94-43d2-9eb2-ea90997d030d@github.com>
 <Id5cp_b0Mi-JVqy97M8Qyf1jjvcuFCDV5y845c_Gefo=.a3d21d1c-da9b-4bc4-8e11-5ee96806a0fc@github.com>
Message-ID: <hIOfndvnon1jZRO9cTlXTT6Nj3zVyqzVQewl0e63sJ8=.4a4e862b-3955-4bb3-ac62-a4884597a99f@github.com>

On Thu, 21 Mar 2024 16:51:36 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

>> Convert java/awt/image/multiresolution/MultiDisplayTest/MultiDisplayTest.java applet test to main using PassFailJFrame
>
> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review comments

Marked as reviewed by azvegint (Reviewer).

test/jdk/java/awt/image/multiresolution/MultiDisplayTest.java line 109:

> 107:         frame = new JFrame("MultiDisplayTest");
> 108:         frame.setLayout(new BorderLayout());
> 109:         Button b = new Button("Start");

Just noticed that the `frame` is not used in test itself, so I guess we can get rid of it, and make this method return the "Start" `JButton`, and use it with `splitUIBottom`/`splitUIRight` instead of `testUI`

-------------

PR Review: https://git.openjdk.org/jdk/pull/18354#pullrequestreview-1952846634
PR Review Comment: https://git.openjdk.org/jdk/pull/18354#discussion_r1534301518

From psadhukhan at openjdk.org  Thu Mar 21 17:08:20 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Thu, 21 Mar 2024 17:08:20 GMT
Subject: RFR: 8328370: Convert java/awt/print/Dialog/PrintApplet.java
 applet test to main [v4]
In-Reply-To: <sgvht4dgRxM3dskOeAkWUox9DmTJKDrD-_s0C4ZjeKc=.e6f75f54-eaab-4402-8c2b-595cfdf41c9a@github.com>
References: <Je7yOnjOAjH3DsIgUx72_7ASxsrXS5oIskdKM716AiA=.f1a73b22-8644-40cc-91d6-9ce301f03cc2@github.com>
 <sgvht4dgRxM3dskOeAkWUox9DmTJKDrD-_s0C4ZjeKc=.e6f75f54-eaab-4402-8c2b-595cfdf41c9a@github.com>
Message-ID: <iBWgwH782sjbW0c0GYk_dwW-oU9YqleDwkUflVN1bLo=.0d7f2378-ecc5-4378-a5b4-4a2a864688ce@github.com>

On Thu, 21 Mar 2024 16:11:44 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

>> Convert java/awt/print/Dialog/PrintApplet.java applet test to main using PassFailJFrame. Also rename the test to PrintModalDialog.java since this is no longer an applet. Added test instructions related to the linked JBS issue.
>
> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix main/manual

Marked as reviewed by psadhukhan (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18362#pullrequestreview-1952852373

From dnguyen at openjdk.org  Thu Mar 21 17:23:35 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Thu, 21 Mar 2024 17:23:35 GMT
Subject: RFR: 8328368: Convert
 java/awt/image/multiresolution/MultiDisplayTest/MultiDisplayTest.java applet
 test to main [v3]
In-Reply-To: <VarHifZU9rXM4lqKzE_slP-8Q9K0CA65KBTCD6CD9Zc=.ec8e5b7b-cd94-43d2-9eb2-ea90997d030d@github.com>
References: <VarHifZU9rXM4lqKzE_slP-8Q9K0CA65KBTCD6CD9Zc=.ec8e5b7b-cd94-43d2-9eb2-ea90997d030d@github.com>
Message-ID: <RAQVcLc9yw13B5uodfYhVwfZksmlq8ZdKQRqZDZT3vw=.acb604f4-74ea-4712-ad5c-0f29f2552f84@github.com>

> Convert java/awt/image/multiresolution/MultiDisplayTest/MultiDisplayTest.java applet test to main using PassFailJFrame

Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:

  Remove frame. Use JButton

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18354/files
  - new: https://git.openjdk.org/jdk/pull/18354/files/64f49ff7..1ae72e39

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18354&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18354&range=01-02

  Stats: 12 lines in 1 file changed: 0 ins; 7 del; 5 mod
  Patch: https://git.openjdk.org/jdk/pull/18354.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18354/head:pull/18354

PR: https://git.openjdk.org/jdk/pull/18354

From dnguyen at openjdk.org  Thu Mar 21 17:23:35 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Thu, 21 Mar 2024 17:23:35 GMT
Subject: RFR: 8328368: Convert
 java/awt/image/multiresolution/MultiDisplayTest/MultiDisplayTest.java applet
 test to main [v2]
In-Reply-To: <hIOfndvnon1jZRO9cTlXTT6Nj3zVyqzVQewl0e63sJ8=.4a4e862b-3955-4bb3-ac62-a4884597a99f@github.com>
References: <VarHifZU9rXM4lqKzE_slP-8Q9K0CA65KBTCD6CD9Zc=.ec8e5b7b-cd94-43d2-9eb2-ea90997d030d@github.com>
 <Id5cp_b0Mi-JVqy97M8Qyf1jjvcuFCDV5y845c_Gefo=.a3d21d1c-da9b-4bc4-8e11-5ee96806a0fc@github.com>
 <hIOfndvnon1jZRO9cTlXTT6Nj3zVyqzVQewl0e63sJ8=.4a4e862b-3955-4bb3-ac62-a4884597a99f@github.com>
Message-ID: <4nZ3SWCg8TtAeZZ2j7Z0yVpMvRqpEy72vBDNA84DhQI=.dd2a5e2e-7e66-404f-8b6d-0e742ab6cc36@github.com>

On Thu, 21 Mar 2024 17:03:41 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review comments
>
> test/jdk/java/awt/image/multiresolution/MultiDisplayTest.java line 109:
> 
>> 107:         frame = new JFrame("MultiDisplayTest");
>> 108:         frame.setLayout(new BorderLayout());
>> 109:         Button b = new Button("Start");
> 
> Just noticed that the `frame` is not used in test itself, so I guess we can get rid of it, and make this method return the "Start" `JButton`, and use it with `splitUIBottom`/`splitUIRight` instead of `testUI`

Good point. I Removed the `frame`. Changed `button` to `JButton`. Did everything else accordingly.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18354#discussion_r1534331937

From aivanov at openjdk.org  Thu Mar 21 17:29:22 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Thu, 21 Mar 2024 17:29:22 GMT
Subject: RFR: 8328368: Convert
 java/awt/image/multiresolution/MultiDisplayTest/MultiDisplayTest.java applet
 test to main [v2]
In-Reply-To: <Id5cp_b0Mi-JVqy97M8Qyf1jjvcuFCDV5y845c_Gefo=.a3d21d1c-da9b-4bc4-8e11-5ee96806a0fc@github.com>
References: <VarHifZU9rXM4lqKzE_slP-8Q9K0CA65KBTCD6CD9Zc=.ec8e5b7b-cd94-43d2-9eb2-ea90997d030d@github.com>
 <Id5cp_b0Mi-JVqy97M8Qyf1jjvcuFCDV5y845c_Gefo=.a3d21d1c-da9b-4bc4-8e11-5ee96806a0fc@github.com>
Message-ID: <XOSK_fU2jFrVkEO9XifPqg42WeMCIfghj1W9PKajrnw=.34612eca-f344-421e-980c-3b64759b367e@github.com>

On Thu, 21 Mar 2024 16:51:36 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

>> Convert java/awt/image/multiresolution/MultiDisplayTest/MultiDisplayTest.java applet test to main using PassFailJFrame
>
> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review comments

Changes requested by aivanov (Reviewer).

test/jdk/java/awt/image/multiresolution/MultiDisplayTest.java line 62:

> 60:              - 2nd display is non-HiDPI.
> 61: 
> 62:              In other cases please simply push "Pass".

These conditions can be detected. On the other hand, since it's a manual test, the tester could enable or connect a second monitor, so it makes sense to preserve the instructions.

test/jdk/java/awt/image/multiresolution/MultiDisplayTest.java line 68:

> 66:              Then drag parent / child to different displays and check
> 67:              that the proper image is shown for every window
> 68:              (must be "black 1x" for non-HiDPI and "blue 2x" for HiDPI).

What if the scale is not 200%? It's possible on Windows and it's not uncommon.

test/jdk/java/awt/image/multiresolution/MultiDisplayTest.java line 79:

> 77:              and Mission Control behavior.
> 78: 
> 79:              Close the windows.

Won't it fail the test?

test/jdk/java/awt/image/multiresolution/MultiDisplayTest.java line 84:

> 82:             """;
> 83: 
> 84:     private static final int W = 200, H = 200;

Suggestion:

    private static final int W = 200;
    private static final int H = 200;

Java Coding Guidelines do not recommend having several declarations on the same line.

test/jdk/java/awt/image/multiresolution/MultiDisplayTest.java line 141:

> 139:         public ParentFrame() {
> 140:             EventQueue.invokeLater(this::CreateUI);
> 141:         }

This looks weird?

As far as I can see, the frame is created when Start button is clicked, which implies this operation is running on EDT. There's no reason to use `invokeLater`, all the code from `CreateUI` method could be placed into the constructor.

test/jdk/java/awt/image/multiresolution/MultiDisplayTest.java line 165:

> 163:             super(f);
> 164:             EventQueue.invokeLater(this::CreateUI);
> 165:         }

The same comment, `invokeLater` seems redundant.

-------------

PR Review: https://git.openjdk.org/jdk/pull/18354#pullrequestreview-1952880721
PR Review Comment: https://git.openjdk.org/jdk/pull/18354#discussion_r1534322342
PR Review Comment: https://git.openjdk.org/jdk/pull/18354#discussion_r1534330435
PR Review Comment: https://git.openjdk.org/jdk/pull/18354#discussion_r1534327277
PR Review Comment: https://git.openjdk.org/jdk/pull/18354#discussion_r1534328684
PR Review Comment: https://git.openjdk.org/jdk/pull/18354#discussion_r1534338034
PR Review Comment: https://git.openjdk.org/jdk/pull/18354#discussion_r1534338996

From aivanov at openjdk.org  Thu Mar 21 17:29:23 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Thu, 21 Mar 2024 17:29:23 GMT
Subject: RFR: 8328368: Convert
 java/awt/image/multiresolution/MultiDisplayTest/MultiDisplayTest.java applet
 test to main [v2]
In-Reply-To: <XOSK_fU2jFrVkEO9XifPqg42WeMCIfghj1W9PKajrnw=.34612eca-f344-421e-980c-3b64759b367e@github.com>
References: <VarHifZU9rXM4lqKzE_slP-8Q9K0CA65KBTCD6CD9Zc=.ec8e5b7b-cd94-43d2-9eb2-ea90997d030d@github.com>
 <Id5cp_b0Mi-JVqy97M8Qyf1jjvcuFCDV5y845c_Gefo=.a3d21d1c-da9b-4bc4-8e11-5ee96806a0fc@github.com>
 <XOSK_fU2jFrVkEO9XifPqg42WeMCIfghj1W9PKajrnw=.34612eca-f344-421e-980c-3b64759b367e@github.com>
Message-ID: <ZjmXhZR6I_eqpjuVAtkGzciQrGvsa6EOY2PUrbpdGQ8=.12b678da-adcf-4cb8-adca-fb5efbea16ff@github.com>

On Thu, 21 Mar 2024 17:13:34 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review comments
>
> test/jdk/java/awt/image/multiresolution/MultiDisplayTest.java line 62:
> 
>> 60:              - 2nd display is non-HiDPI.
>> 61: 
>> 62:              In other cases please simply push "Pass".
> 
> These conditions can be detected. On the other hand, since it's a manual test, the tester could enable or connect a second monitor, so it makes sense to preserve the instructions.

Do we need an occasional _Skip_ button? Yet adding such a button to throw `jtreg.SkippedException` will introduce a transitive dependency on the library which contains the `SkippedException`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18354#discussion_r1534325241

From honkar at openjdk.org  Thu Mar 21 17:33:36 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Thu, 21 Mar 2024 17:33:36 GMT
Subject: RFR: JDK-8328398 : Convert java/awt/im/4490692/bug4490692.html
 applet test to main [v3]
In-Reply-To: <lcESN0hyfRYfuC2nnzmBSQrUQLmHHD6uooae53vTzWA=.682e9e1e-d3cb-4b2e-bc95-9bdd9d709f6f@github.com>
References: <lcESN0hyfRYfuC2nnzmBSQrUQLmHHD6uooae53vTzWA=.682e9e1e-d3cb-4b2e-bc95-9bdd9d709f6f@github.com>
Message-ID: <4MHbh9VAhMibyyb3zTWZyhMUfO3_Aqf3BBdxRjIFISs=.35ce75ab-a95f-4b57-862d-901bd2753506@github.com>

> Following test is converted from applet to main using PassFailJFrame.
> 
> The original test had ignore tag - **The fix for this problem was backed out for 5057184.  Remove this "ignore" tag when it is fixed again.**
> I believe this was fixed and the test works correctly on Linux platforms, hence ignore tag has been removed.
> 
> This is a semi-automated test, the first check is manual and the 2nd one is automated. Details in the test instructions.

Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:

  rawCode check added

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18402/files
  - new: https://git.openjdk.org/jdk/pull/18402/files/3dcb944c..9252b4fe

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18402&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18402&range=01-02

  Stats: 50 lines in 1 file changed: 14 ins; 11 del; 25 mod
  Patch: https://git.openjdk.org/jdk/pull/18402.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18402/head:pull/18402

PR: https://git.openjdk.org/jdk/pull/18402

From honkar at openjdk.org  Thu Mar 21 17:36:22 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Thu, 21 Mar 2024 17:36:22 GMT
Subject: RFR: JDK-8328398 : Convert java/awt/im/4490692/bug4490692.html
 applet test to main [v2]
In-Reply-To: <CETT2AYhreeC9vGiKMfghFTU8z2WtS86PXKrfuu6X8I=.fc26a12c-5d3c-4473-afd5-d9fcc7d79830@github.com>
References: <lcESN0hyfRYfuC2nnzmBSQrUQLmHHD6uooae53vTzWA=.682e9e1e-d3cb-4b2e-bc95-9bdd9d709f6f@github.com>
 <aS6ATocsIxgP1ABKQTve2waCy-MeH92snBcEZJftr9s=.24f93a07-f2b6-4608-9785-53b0399fcd03@github.com>
 <CETT2AYhreeC9vGiKMfghFTU8z2WtS86PXKrfuu6X8I=.fc26a12c-5d3c-4473-afd5-d9fcc7d79830@github.com>
Message-ID: <q0EdVTvuL9zgklnO5E7fP_dqB6U-nxjArsl-irfB55s=.e2927019-08b1-4dbf-b03c-69a0edf95397@github.com>

On Thu, 21 Mar 2024 12:11:43 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   instruction line length
>
> test/jdk/java/awt/im/bug4490692.java line 74:
> 
>> 72:                 .rows((int) INSTRUCTIONS.lines().count() + 2)
>> 73:                 .columns(40)
>> 74:                 .testUI(() -> new TestFrame("Test Accented Chars"))
> 
> Looks like a good candidate to use `splitUIRight/Bottom` (up to you).

Agreed. Updated UI.

> test/jdk/java/awt/im/bug4490692.java line 95:
> 
>> 93:     @Override
>> 94:     public void keyPressed(KeyEvent e) {
>> 95:         if (e.getKeyCode() == 23 || e.getKeyCode() == 60) {
> 
>>  CASE 2: This step is automated and applicable for both
> keyboards - LINUX & SOLARIS SPARC.
> When Tab key is pressed it should generate a-acute (?)
> character, this test automatically passes if the correct character
> is generated on keypress else fails.
> 
> Unfortunately this check doesn't work for me:
> `java.awt.event.KeyEvent[KEY_PRESSED,keyCode=0,keyText=Unknown keyCode: 0x0,keyChar='?',keyLocation=KEY_LOCATION_UNKNOWN,rawCode=23,primaryLevelUnicode=225,scancode=0,extendedKeyCode=0x10000e1] on javax.swing.JTextField...`
> 
> The `keycode` is 0, `rawCode` is desired `23`, but we can't get it it unless parsing the output of `e.toString()`
> 
> The `e.getKeyChar() == 0x00e1` check is still valid thought.

@azvegint Thanks for checking it. Update the code & added the rawCode check now. Can you please re-review it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18402#discussion_r1534350109
PR Review Comment: https://git.openjdk.org/jdk/pull/18402#discussion_r1534349827

From honkar at openjdk.org  Thu Mar 21 17:36:22 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Thu, 21 Mar 2024 17:36:22 GMT
Subject: RFR: JDK-8328398 : Convert java/awt/im/4490692/bug4490692.html
 applet test to main [v2]
In-Reply-To: <kRG-4TbJgvQo7KZj9pgN04EdJ58vPlTWChimFykAzTc=.fa85283b-de29-4932-937c-8f94c2888f87@github.com>
References: <lcESN0hyfRYfuC2nnzmBSQrUQLmHHD6uooae53vTzWA=.682e9e1e-d3cb-4b2e-bc95-9bdd9d709f6f@github.com>
 <aS6ATocsIxgP1ABKQTve2waCy-MeH92snBcEZJftr9s=.24f93a07-f2b6-4608-9785-53b0399fcd03@github.com>
 <kRG-4TbJgvQo7KZj9pgN04EdJ58vPlTWChimFykAzTc=.fa85283b-de29-4932-937c-8f94c2888f87@github.com>
Message-ID: <cGW6EQm6hXhpXeADSANPYft3B0FwZnTP76V_aEXf8BY=.f252ba8d-d545-4b34-a1a8-c9f57d19f702@github.com>

On Thu, 21 Mar 2024 10:47:24 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   instruction line length
>
> test/jdk/java/awt/im/bug4490692.java line 81:
> 
>> 79: 
>> 80: class TestFrame extends JFrame implements KeyListener {
>> 81:     JTextField text;
> 
> text can be moved inside constructor, any reason why it is here?

Updated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18402#discussion_r1534350327

From abhiscxk at openjdk.org  Thu Mar 21 17:36:40 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Thu, 21 Mar 2024 17:36:40 GMT
Subject: RFR: 8328670: Automate and open source few closed manual applet
 test [v2]
In-Reply-To: <ekaFQm1J1iN3WflMPr1EjImabwkt3O6QIB733BF1Kss=.82bb6086-fe25-46f2-916f-67a458eb6f3f@github.com>
References: <ekaFQm1J1iN3WflMPr1EjImabwkt3O6QIB733BF1Kss=.82bb6086-fe25-46f2-916f-67a458eb6f3f@github.com>
Message-ID: <j5__FjejqxuIVDaPT5I5mzBuQXhu3VO8FHxhKcqkGAo=.6c0d7f61-124b-4dc5-a2a5-f70e02905863@github.com>

> Few manual closed applet test converted to automated and open sourced.

Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:

  Remove getContentPane usage

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18428/files
  - new: https://git.openjdk.org/jdk/pull/18428/files/3c8a8093..d0392ee2

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18428&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18428&range=00-01

  Stats: 3 lines in 2 files changed: 0 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/jdk/pull/18428.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18428/head:pull/18428

PR: https://git.openjdk.org/jdk/pull/18428

From abhiscxk at openjdk.org  Thu Mar 21 17:36:40 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Thu, 21 Mar 2024 17:36:40 GMT
Subject: RFR: 8328670: Automate and open source few closed manual applet
 test [v2]
In-Reply-To: <9lWyWMS85BTpJDCxcUVhXvL8vvPMvcs-GkzBSKnrdJk=.b7f9c4c5-4bd0-4f85-8a48-a4f60b10c4d1@github.com>
References: <ekaFQm1J1iN3WflMPr1EjImabwkt3O6QIB733BF1Kss=.82bb6086-fe25-46f2-916f-67a458eb6f3f@github.com>
 <9lWyWMS85BTpJDCxcUVhXvL8vvPMvcs-GkzBSKnrdJk=.b7f9c4c5-4bd0-4f85-8a48-a4f60b10c4d1@github.com>
Message-ID: <pQTd3e5QAsoCBBRS5mJArUhamth5bdwewJSC7Wj-O1k=.fbcdaa74-9486-479c-b7be-b81d29a8488b@github.com>

On Thu, 21 Mar 2024 16:45:40 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove getContentPane usage
>
> test/jdk/javax/swing/JInternalFrame/Ctrli.java line 126:
> 
>> 124:         keyecho.addMouseListener(mouseListener);
>> 125:         frame.setLayout(new BorderLayout());
>> 126:         frame.getContentPane().add(keyecho);
> 
> getContentPane is obsolete since jdk1.5 so can be removed as per this [comment](https://github.com/openjdk/jdk/pull/18390#discussion_r1533017080)

Ok... Updated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18428#discussion_r1534348867

From dnguyen at openjdk.org  Thu Mar 21 17:43:46 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Thu, 21 Mar 2024 17:43:46 GMT
Subject: RFR: 8328368: Convert
 java/awt/image/multiresolution/MultiDisplayTest/MultiDisplayTest.java applet
 test to main [v4]
In-Reply-To: <VarHifZU9rXM4lqKzE_slP-8Q9K0CA65KBTCD6CD9Zc=.ec8e5b7b-cd94-43d2-9eb2-ea90997d030d@github.com>
References: <VarHifZU9rXM4lqKzE_slP-8Q9K0CA65KBTCD6CD9Zc=.ec8e5b7b-cd94-43d2-9eb2-ea90997d030d@github.com>
Message-ID: <qoxVGa16iowPr0jVSh0vX_CotoEGeR1LjvbRumED2Hs=.9e779c5b-4ea6-4a1e-84df-ea4d2492b25e@github.com>

> Convert java/awt/image/multiresolution/MultiDisplayTest/MultiDisplayTest.java applet test to main using PassFailJFrame

Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:

  Review comments

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18354/files
  - new: https://git.openjdk.org/jdk/pull/18354/files/1ae72e39..4ccc1c05

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18354&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18354&range=02-03

  Stats: 13 lines in 1 file changed: 1 ins; 9 del; 3 mod
  Patch: https://git.openjdk.org/jdk/pull/18354.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18354/head:pull/18354

PR: https://git.openjdk.org/jdk/pull/18354

From dnguyen at openjdk.org  Thu Mar 21 17:43:46 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Thu, 21 Mar 2024 17:43:46 GMT
Subject: RFR: 8328368: Convert
 java/awt/image/multiresolution/MultiDisplayTest/MultiDisplayTest.java applet
 test to main [v2]
In-Reply-To: <ZjmXhZR6I_eqpjuVAtkGzciQrGvsa6EOY2PUrbpdGQ8=.12b678da-adcf-4cb8-adca-fb5efbea16ff@github.com>
References: <VarHifZU9rXM4lqKzE_slP-8Q9K0CA65KBTCD6CD9Zc=.ec8e5b7b-cd94-43d2-9eb2-ea90997d030d@github.com>
 <Id5cp_b0Mi-JVqy97M8Qyf1jjvcuFCDV5y845c_Gefo=.a3d21d1c-da9b-4bc4-8e11-5ee96806a0fc@github.com>
 <XOSK_fU2jFrVkEO9XifPqg42WeMCIfghj1W9PKajrnw=.34612eca-f344-421e-980c-3b64759b367e@github.com>
 <ZjmXhZR6I_eqpjuVAtkGzciQrGvsa6EOY2PUrbpdGQ8=.12b678da-adcf-4cb8-adca-fb5efbea16ff@github.com>
Message-ID: <83ylGFN6Q-tFKgXXGRSUt9JdvFjWhyS57vCDsWiMjCg=.9f41fd19-763b-4630-9687-eaa20709541e@github.com>

On Thu, 21 Mar 2024 17:15:31 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> test/jdk/java/awt/image/multiresolution/MultiDisplayTest.java line 62:
>> 
>>> 60:              - 2nd display is non-HiDPI.
>>> 61: 
>>> 62:              In other cases please simply push "Pass".
>> 
>> These conditions can be detected. On the other hand, since it's a manual test, the tester could enable or connect a second monitor, so it makes sense to preserve the instructions.
>
> Do we need an occasional _Skip_ button? Yet adding such a button to throw `jtreg.SkippedException` will introduce a transitive dependency on the library which contains the `SkippedException`.

I'm OK with either direction. To me, passing the test seems fine for cases we'd skip, but adding a `Skip` button may seem more logical. I was OK with this approach enough to stick with the original instructions.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18354#discussion_r1534353748

From dnguyen at openjdk.org  Thu Mar 21 17:43:46 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Thu, 21 Mar 2024 17:43:46 GMT
Subject: RFR: 8328368: Convert
 java/awt/image/multiresolution/MultiDisplayTest/MultiDisplayTest.java applet
 test to main [v2]
In-Reply-To: <XOSK_fU2jFrVkEO9XifPqg42WeMCIfghj1W9PKajrnw=.34612eca-f344-421e-980c-3b64759b367e@github.com>
References: <VarHifZU9rXM4lqKzE_slP-8Q9K0CA65KBTCD6CD9Zc=.ec8e5b7b-cd94-43d2-9eb2-ea90997d030d@github.com>
 <Id5cp_b0Mi-JVqy97M8Qyf1jjvcuFCDV5y845c_Gefo=.a3d21d1c-da9b-4bc4-8e11-5ee96806a0fc@github.com>
 <XOSK_fU2jFrVkEO9XifPqg42WeMCIfghj1W9PKajrnw=.34612eca-f344-421e-980c-3b64759b367e@github.com>
Message-ID: <artwoFkmNMK0BAXo2sc8CzX6zSS4vytIxvTRF1mv580=.9b4303f4-8bb7-46a7-8c07-0803acf8e887@github.com>

On Thu, 21 Mar 2024 17:17:10 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review comments
>
> test/jdk/java/awt/image/multiresolution/MultiDisplayTest.java line 79:
> 
>> 77:              and Mission Control behavior.
>> 78: 
>> 79:              Close the windows.
> 
> Won't it fail the test?

This was a part of the original instructions. I modified it to clarify that we need to close the Parent and Child windows, not the PassFailJFrame as well. Thanks

> test/jdk/java/awt/image/multiresolution/MultiDisplayTest.java line 84:
> 
>> 82:             """;
>> 83: 
>> 84:     private static final int W = 200, H = 200;
> 
> Suggestion:
> 
>     private static final int W = 200;
>     private static final int H = 200;
> 
> Java Coding Guidelines do not recommend having several declarations on the same line.

Fixed. Thanks

> test/jdk/java/awt/image/multiresolution/MultiDisplayTest.java line 141:
> 
>> 139:         public ParentFrame() {
>> 140:             EventQueue.invokeLater(this::CreateUI);
>> 141:         }
> 
> This looks weird?
> 
> As far as I can see, the frame is created when Start button is clicked, which implies this operation is running on EDT. There's no reason to use `invokeLater`, all the code from `CreateUI` method could be placed into the constructor.

Agreed. I modified it as you suggested. Likewise for the child frame.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18354#discussion_r1534351092
PR Review Comment: https://git.openjdk.org/jdk/pull/18354#discussion_r1534351797
PR Review Comment: https://git.openjdk.org/jdk/pull/18354#discussion_r1534351579

From aivanov at openjdk.org  Thu Mar 21 17:43:47 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Thu, 21 Mar 2024 17:43:47 GMT
Subject: RFR: 8328368: Convert
 java/awt/image/multiresolution/MultiDisplayTest/MultiDisplayTest.java applet
 test to main [v2]
In-Reply-To: <artwoFkmNMK0BAXo2sc8CzX6zSS4vytIxvTRF1mv580=.9b4303f4-8bb7-46a7-8c07-0803acf8e887@github.com>
References: <VarHifZU9rXM4lqKzE_slP-8Q9K0CA65KBTCD6CD9Zc=.ec8e5b7b-cd94-43d2-9eb2-ea90997d030d@github.com>
 <Id5cp_b0Mi-JVqy97M8Qyf1jjvcuFCDV5y845c_Gefo=.a3d21d1c-da9b-4bc4-8e11-5ee96806a0fc@github.com>
 <XOSK_fU2jFrVkEO9XifPqg42WeMCIfghj1W9PKajrnw=.34612eca-f344-421e-980c-3b64759b367e@github.com>
 <artwoFkmNMK0BAXo2sc8CzX6zSS4vytIxvTRF1mv580=.9b4303f4-8bb7-46a7-8c07-0803acf8e887@github.com>
Message-ID: <HKhiME7P6LNiTZchXEeaAzIglMmWil-ETsG4wuktoVY=.71512749-7972-401c-b567-c278f1b37518@github.com>

On Thu, 21 Mar 2024 17:34:19 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

>> test/jdk/java/awt/image/multiresolution/MultiDisplayTest.java line 79:
>> 
>>> 77:              and Mission Control behavior.
>>> 78: 
>>> 79:              Close the windows.
>> 
>> Won't it fail the test?
>
> This was a part of the original instructions. I modified it to clarify that we need to close the Parent and Child windows, not the PassFailJFrame as well. Thanks

It won't as those windows aren't tracked by `PassFailJFrame`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18354#discussion_r1534351815

From aivanov at openjdk.org  Thu Mar 21 17:43:46 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Thu, 21 Mar 2024 17:43:46 GMT
Subject: RFR: 8328368: Convert
 java/awt/image/multiresolution/MultiDisplayTest/MultiDisplayTest.java applet
 test to main [v4]
In-Reply-To: <qoxVGa16iowPr0jVSh0vX_CotoEGeR1LjvbRumED2Hs=.9e779c5b-4ea6-4a1e-84df-ea4d2492b25e@github.com>
References: <VarHifZU9rXM4lqKzE_slP-8Q9K0CA65KBTCD6CD9Zc=.ec8e5b7b-cd94-43d2-9eb2-ea90997d030d@github.com>
 <qoxVGa16iowPr0jVSh0vX_CotoEGeR1LjvbRumED2Hs=.9e779c5b-4ea6-4a1e-84df-ea4d2492b25e@github.com>
Message-ID: <Ykbk3fzq_It8eCT2Enmj5VQTmp0GlvO0u2expkqCzvA=.e224db17-8475-439d-9830-6fbb9ca35559@github.com>

On Thu, 21 Mar 2024 17:40:55 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

>> Convert java/awt/image/multiresolution/MultiDisplayTest/MultiDisplayTest.java applet test to main using PassFailJFrame
>
> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review comments

Marked as reviewed by aivanov (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18354#pullrequestreview-1952972156

From aivanov at openjdk.org  Thu Mar 21 17:43:46 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Thu, 21 Mar 2024 17:43:46 GMT
Subject: RFR: 8328368: Convert
 java/awt/image/multiresolution/MultiDisplayTest/MultiDisplayTest.java applet
 test to main [v2]
In-Reply-To: <83ylGFN6Q-tFKgXXGRSUt9JdvFjWhyS57vCDsWiMjCg=.9f41fd19-763b-4630-9687-eaa20709541e@github.com>
References: <VarHifZU9rXM4lqKzE_slP-8Q9K0CA65KBTCD6CD9Zc=.ec8e5b7b-cd94-43d2-9eb2-ea90997d030d@github.com>
 <Id5cp_b0Mi-JVqy97M8Qyf1jjvcuFCDV5y845c_Gefo=.a3d21d1c-da9b-4bc4-8e11-5ee96806a0fc@github.com>
 <XOSK_fU2jFrVkEO9XifPqg42WeMCIfghj1W9PKajrnw=.34612eca-f344-421e-980c-3b64759b367e@github.com>
 <ZjmXhZR6I_eqpjuVAtkGzciQrGvsa6EOY2PUrbpdGQ8=.12b678da-adcf-4cb8-adca-fb5efbea16ff@github.com>
 <83ylGFN6Q-tFKgXXGRSUt9JdvFjWhyS57vCDsWiMjCg=.9f41fd19-763b-4630-9687-eaa20709541e@github.com>
Message-ID: <JoFgThwUuvtbN59_p-AeDX6whDz1XAjAzAaP8PVieKM=.d5e8424e-6aeb-4670-9b58-21b3a70b5143@github.com>

On Thu, 21 Mar 2024 17:36:24 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

>> Do we need an occasional _Skip_ button? Yet adding such a button to throw `jtreg.SkippedException` will introduce a transitive dependency on the library which contains the `SkippedException`.
>
> I'm OK with either direction. To me, passing the test seems fine for cases we'd skip, but adding a `Skip` button may seem more logical. I was OK with this approach enough to stick with the original instructions.

I'm not suggesting modifying the instructions, I'm bringing up it for a discussion.

Essentially, `SkippedException` is also like passing the test, it's indistinguishable in the report. Only the log of the test run will contain the information that the test was skipped.

>From this point of view, it's wiser not to introduce an additional dependency which will affect all the manual tests.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18354#discussion_r1534359360

From dnguyen at openjdk.org  Thu Mar 21 17:49:23 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Thu, 21 Mar 2024 17:49:23 GMT
Subject: RFR: 8328368: Convert
 java/awt/image/multiresolution/MultiDisplayTest/MultiDisplayTest.java applet
 test to main [v2]
In-Reply-To: <JoFgThwUuvtbN59_p-AeDX6whDz1XAjAzAaP8PVieKM=.d5e8424e-6aeb-4670-9b58-21b3a70b5143@github.com>
References: <VarHifZU9rXM4lqKzE_slP-8Q9K0CA65KBTCD6CD9Zc=.ec8e5b7b-cd94-43d2-9eb2-ea90997d030d@github.com>
 <Id5cp_b0Mi-JVqy97M8Qyf1jjvcuFCDV5y845c_Gefo=.a3d21d1c-da9b-4bc4-8e11-5ee96806a0fc@github.com>
 <XOSK_fU2jFrVkEO9XifPqg42WeMCIfghj1W9PKajrnw=.34612eca-f344-421e-980c-3b64759b367e@github.com>
 <ZjmXhZR6I_eqpjuVAtkGzciQrGvsa6EOY2PUrbpdGQ8=.12b678da-adcf-4cb8-adca-fb5efbea16ff@github.com>
 <83ylGFN6Q-tFKgXXGRSUt9JdvFjWhyS57vCDsWiMjCg=.9f41fd19-763b-4630-9687-eaa20709541e@github.com>
 <JoFgThwUuvtbN59_p-AeDX6whDz1XAjAzAaP8PVieKM=.d5e8424e-6aeb-4670-9b58-21b3a70b5143@github.com>
Message-ID: <Ep-i9FjZ2RJlPwDXxC3ONwOR5lVjZkEQLrtHVndn3Mk=.c643a506-38a7-478c-b537-427c342be687@github.com>

On Thu, 21 Mar 2024 17:40:55 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> I'm OK with either direction. To me, passing the test seems fine for cases we'd skip, but adding a `Skip` button may seem more logical. I was OK with this approach enough to stick with the original instructions.
>
> I'm not suggesting modifying the instructions, I'm bringing up it for a discussion.
> 
> Essentially, `SkippedException` is also like passing the test, it's indistinguishable in the report. Only the log of the test run will contain the information that the test was skipped.
> 
> From this point of view, it's wiser not to introduce an additional dependency which will affect all the manual tests.

Makes sense, thanks. The feature would definitely be nice for circumstances like this. This seems to be the first test this sprint for me that the `Skip` button would apply to. So, not sure how often it would come up. 

Taking into account your point of having an additional dependency on all of these manual tests, maybe better to not have it for now unless similar circumstances pop up more frequently.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18354#discussion_r1534366700

From prr at openjdk.org  Thu Mar 21 17:50:29 2024
From: prr at openjdk.org (Phil Race)
Date: Thu, 21 Mar 2024 17:50:29 GMT
Subject: Integrated: 8328560:
 java/awt/event/MouseEvent/ClickDuringKeypress/ClickDuringKeypress.java imports
 Applet
In-Reply-To: <DAGMk9laOuahpyUEepWDE92N94zIbgNOWgaIgQFIurs=.602f3b0a-e0dd-49ee-9075-12961ef49611@github.com>
References: <DAGMk9laOuahpyUEepWDE92N94zIbgNOWgaIgQFIurs=.602f3b0a-e0dd-49ee-9075-12961ef49611@github.com>
Message-ID: <96h5WkGQmTxnfnQpvvvk8T-jSp2FKgXKuhdmEBFyeZk=.43174e7e-3f90-4dbe-8f7d-fbf6c3496f9e@github.com>

On Tue, 19 Mar 2024 23:30:39 GMT, Phil Race <prr at openjdk.org> wrote:

> This seems to have been some previous not very complete conversion of a test from applet to main.
> It even still had Applet imported and miscellaneous comments. I've cleaned it up.

This pull request has now been integrated.

Changeset: e81374e0
Author:    Phil Race <prr at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/e81374e0501a8201dac701824d2e29f2cedfcdff
Stats:     112 lines in 1 file changed: 24 ins; 56 del; 32 mod

8328560: java/awt/event/MouseEvent/ClickDuringKeypress/ClickDuringKeypress.java imports Applet

Reviewed-by: azvegint, abhiscxk

-------------

PR: https://git.openjdk.org/jdk/pull/18386

From prr at openjdk.org  Thu Mar 21 17:51:26 2024
From: prr at openjdk.org (Phil Race)
Date: Thu, 21 Mar 2024 17:51:26 GMT
Subject: Integrated: 8328540: test
 javax/swing/JSplitPane/4885629/bug4885629.java fails on windows hidpi
In-Reply-To: <WHDf1998FlZ19dNxxz-E7M5ZOwJA89v-zgN9zKZ4_V0=.184a9091-6ed1-4a98-8c6f-dba65ce60462@github.com>
References: <WHDf1998FlZ19dNxxz-E7M5ZOwJA89v-zgN9zKZ4_V0=.184a9091-6ed1-4a98-8c6f-dba65ce60462@github.com>
Message-ID: <Tpth1CYm1s6Qm4keDBpixsE1SYi46zvC5_ztWwY__qQ=.c243b56c-07a5-4f0c-834d-d1761344c453@github.com>

On Tue, 19 Mar 2024 18:20:06 GMT, Phil Race <prr at openjdk.org> wrote:

> A simple fix to the test to skip sampling the leftmost and rightmost ends of the divider
> to avoid possible issues at fractional scales.

This pull request has now been integrated.

Changeset: fa823bd2
Author:    Phil Race <prr at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/fa823bd21c6676c67c42275efb59868200409b38
Stats:     3 lines in 1 file changed: 0 ins; 0 del; 3 mod

8328540: test javax/swing/JSplitPane/4885629/bug4885629.java fails on windows hidpi

Reviewed-by: abhiscxk, psadhukhan

-------------

PR: https://git.openjdk.org/jdk/pull/18384

From honkar at openjdk.org  Thu Mar 21 17:52:34 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Thu, 21 Mar 2024 17:52:34 GMT
Subject: RFR: JDK-8328398 : Convert java/awt/im/4490692/bug4490692.html
 applet test to main [v4]
In-Reply-To: <lcESN0hyfRYfuC2nnzmBSQrUQLmHHD6uooae53vTzWA=.682e9e1e-d3cb-4b2e-bc95-9bdd9d709f6f@github.com>
References: <lcESN0hyfRYfuC2nnzmBSQrUQLmHHD6uooae53vTzWA=.682e9e1e-d3cb-4b2e-bc95-9bdd9d709f6f@github.com>
Message-ID: <mltmgDP-EgAMXSYO6aES74ZzegqjFfH06E1Ct-GUNIQ=.1417cd4f-8c7e-4414-a16a-3e230c68311f@github.com>

> Following test is converted from applet to main using PassFailJFrame.
> 
> The original test had ignore tag - **The fix for this problem was backed out for 5057184.  Remove this "ignore" tag when it is fixed again.**
> I believe this was fixed and the test works correctly on Linux platforms, hence ignore tag has been removed.
> 
> This is a semi-automated test, the first check is manual and the 2nd one is automated. Details in the test instructions.

Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:

  minor jtreg tag change

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18402/files
  - new: https://git.openjdk.org/jdk/pull/18402/files/9252b4fe..03cc8e41

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18402&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18402&range=02-03

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/18402.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18402/head:pull/18402

PR: https://git.openjdk.org/jdk/pull/18402

From dnguyen at openjdk.org  Thu Mar 21 17:58:29 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Thu, 21 Mar 2024 17:58:29 GMT
Subject: Integrated: 8328368: Convert
 java/awt/image/multiresolution/MultiDisplayTest/MultiDisplayTest.java applet
 test to main
In-Reply-To: <VarHifZU9rXM4lqKzE_slP-8Q9K0CA65KBTCD6CD9Zc=.ec8e5b7b-cd94-43d2-9eb2-ea90997d030d@github.com>
References: <VarHifZU9rXM4lqKzE_slP-8Q9K0CA65KBTCD6CD9Zc=.ec8e5b7b-cd94-43d2-9eb2-ea90997d030d@github.com>
Message-ID: <JPmMIXblfcBLvctNG4fVji4wrpI-NwBItn5cCTnQY0s=.4b205fa1-e5d2-4942-a6c9-d0317dfe0606@github.com>

On Mon, 18 Mar 2024 17:31:07 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

> Convert java/awt/image/multiresolution/MultiDisplayTest/MultiDisplayTest.java applet test to main using PassFailJFrame

This pull request has now been integrated.

Changeset: ba05c6d0
Author:    Damon Nguyen <dnguyen at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/ba05c6d0b6955a0c5110b75e709e2206961f9fec
Stats:     376 lines in 3 files changed: 169 ins; 207 del; 0 mod

8328368: Convert java/awt/image/multiresolution/MultiDisplayTest/MultiDisplayTest.java applet test to main

Reviewed-by: azvegint, aivanov

-------------

PR: https://git.openjdk.org/jdk/pull/18354

From prr at openjdk.org  Thu Mar 21 17:59:21 2024
From: prr at openjdk.org (Phil Race)
Date: Thu, 21 Mar 2024 17:59:21 GMT
Subject: RFR: 8328301: Convert Applet test ManualHTMLDataFlavorTest.java to
 main program [v2]
In-Reply-To: <ZeNQcwSthUfKB_pqRPlyPPN-3zfSqHgkitYLTNvnZa4=.fe9055b1-7626-4c2e-a9af-14fb55a313d3@github.com>
References: <ezZp85g1cKWnR1M7apMh6bxP2_G6P9O5tN6DTSQEOU4=.951f4e5d-e956-4af8-b4f1-725c667224b5@github.com>
 <NAaMbxZuvr-8jiLmuz9OfmkR6bZjYzz8H47YLF0sVQ0=.a8e8bd06-e382-474d-97b5-205d2d9350e6@github.com>
 <ZeNQcwSthUfKB_pqRPlyPPN-3zfSqHgkitYLTNvnZa4=.fe9055b1-7626-4c2e-a9af-14fb55a313d3@github.com>
Message-ID: <GeK2mX9_wCPugZIVBZOgWi07-G6cQyb1F4weGMCZC-o=.ff2f87b8-b92a-4ea3-ad52-8d626529c2cc@github.com>

On Thu, 21 Mar 2024 15:14:26 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8328301
>
> test/jdk/java/awt/datatransfer/HTMLDataFlavors/ManualHTMLDataFlavorTest.java line 110:
> 
>> 108:             } catch (UnsupportedFlavorException | IOException e) {
>> 109:                 e.printStackTrace();
>> 110:             }
> 
> Should exception make the test fail?

The author of the test didn't think so, this doesn't seem related to converting to a main program
so I don't want to touch it.

> test/jdk/java/awt/datatransfer/HTMLDataFlavors/ManualHTMLDataFlavorTest.java line 123:
> 
>> 121:            the browser to other applications because of,
>> 122:            the protected mode restrictions.,
>> 123:            On Mac OS X do NOT use Safari, it does not provide the needed DataFlavor,
> 
> Suggestion:
> 
>            IMPORTANT NOTE: the page should be stored locally.
>            Otherwise, for instance iexplore, can prohibit drag and drop from
>            the browser to other applications because of
>            the protected mode restrictions.
>            On Mac OS X do NOT use Safari, it does not provide the needed DataFlavor.
> 
> The commas in the end of each line seem to come from the commas separating items in an array of Strings. I'm for removing those commas to avoid any confusion when reading the instructions.

yes, they are. I will fix this and tidy up the text a little bit more.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18334#discussion_r1534383187
PR Review Comment: https://git.openjdk.org/jdk/pull/18334#discussion_r1534378391

From prr at openjdk.org  Thu Mar 21 18:05:32 2024
From: prr at openjdk.org (Phil Race)
Date: Thu, 21 Mar 2024 18:05:32 GMT
Subject: RFR: 8328301: Convert Applet test ManualHTMLDataFlavorTest.java to
 main program [v3]
In-Reply-To: <ezZp85g1cKWnR1M7apMh6bxP2_G6P9O5tN6DTSQEOU4=.951f4e5d-e956-4af8-b4f1-725c667224b5@github.com>
References: <ezZp85g1cKWnR1M7apMh6bxP2_G6P9O5tN6DTSQEOU4=.951f4e5d-e956-4af8-b4f1-725c667224b5@github.com>
Message-ID: <b7rVmJzuEiYomlkFZOSU_W_lZ28A02qwINPRzEsPsds=.2f2490e6-a9da-4666-a16d-3e8d02851246@github.com>

> Convert this applet based test to a main program

Phil Race has updated the pull request incrementally with one additional commit since the last revision:

  8328301

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18334/files
  - new: https://git.openjdk.org/jdk/pull/18334/files/38292f15..7998de2d

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18334&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18334&range=01-02

  Stats: 20 lines in 1 file changed: 0 ins; 1 del; 19 mod
  Patch: https://git.openjdk.org/jdk/pull/18334.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18334/head:pull/18334

PR: https://git.openjdk.org/jdk/pull/18334

From prr at openjdk.org  Thu Mar 21 18:05:32 2024
From: prr at openjdk.org (Phil Race)
Date: Thu, 21 Mar 2024 18:05:32 GMT
Subject: RFR: 8328301: Convert Applet test ManualHTMLDataFlavorTest.java to
 main program [v2]
In-Reply-To: <ZeNQcwSthUfKB_pqRPlyPPN-3zfSqHgkitYLTNvnZa4=.fe9055b1-7626-4c2e-a9af-14fb55a313d3@github.com>
References: <ezZp85g1cKWnR1M7apMh6bxP2_G6P9O5tN6DTSQEOU4=.951f4e5d-e956-4af8-b4f1-725c667224b5@github.com>
 <NAaMbxZuvr-8jiLmuz9OfmkR6bZjYzz8H47YLF0sVQ0=.a8e8bd06-e382-474d-97b5-205d2d9350e6@github.com>
 <ZeNQcwSthUfKB_pqRPlyPPN-3zfSqHgkitYLTNvnZa4=.fe9055b1-7626-4c2e-a9af-14fb55a313d3@github.com>
Message-ID: <iFvdEE4aJIclJm0ylXYx78WI6BEEEggKe-eaoyob8gA=.d236515a-efd5-4968-b821-7f68fb2139da@github.com>

On Thu, 21 Mar 2024 15:20:16 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8328301
>
> test/jdk/java/awt/datatransfer/HTMLDataFlavors/ManualHTMLDataFlavorTest.java line 126:
> 
>> 124:         3) Check the data in the output area of this window,
>> 125:         5) The output should not contain information that any of,
>> 126:            flavors is not present in the system clipboard,
> 
> I believe this condition can be verified automatically. If any missing data flavour should result in test failure, the test could be failed with `PassFailJFrame.forceFail`.

I experimented with the user experience of that. You drag something, drop it and and the test just vanishes.
I don't like the user experience and so I'd have to write a popup which first explains it to the user.
I think it better to keep things as they are.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18334#discussion_r1534393927

From aivanov at openjdk.org  Thu Mar 21 18:08:25 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Thu, 21 Mar 2024 18:08:25 GMT
Subject: RFR: 8328368: Convert
 java/awt/image/multiresolution/MultiDisplayTest/MultiDisplayTest.java applet
 test to main [v2]
In-Reply-To: <XOSK_fU2jFrVkEO9XifPqg42WeMCIfghj1W9PKajrnw=.34612eca-f344-421e-980c-3b64759b367e@github.com>
References: <VarHifZU9rXM4lqKzE_slP-8Q9K0CA65KBTCD6CD9Zc=.ec8e5b7b-cd94-43d2-9eb2-ea90997d030d@github.com>
 <Id5cp_b0Mi-JVqy97M8Qyf1jjvcuFCDV5y845c_Gefo=.a3d21d1c-da9b-4bc4-8e11-5ee96806a0fc@github.com>
 <XOSK_fU2jFrVkEO9XifPqg42WeMCIfghj1W9PKajrnw=.34612eca-f344-421e-980c-3b64759b367e@github.com>
Message-ID: <-RCSa10UMtjYNIx_6VVk6NRs7C6mtrTz9PlIJTO-YVw=.e86ca738-81f3-4c98-9c94-c5992d1c618a@github.com>

On Thu, 21 Mar 2024 17:19:25 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review comments
>
> test/jdk/java/awt/image/multiresolution/MultiDisplayTest.java line 68:
> 
>> 66:              Then drag parent / child to different displays and check
>> 67:              that the proper image is shown for every window
>> 68:              (must be "black 1x" for non-HiDPI and "blue 2x" for HiDPI).
> 
> What if the scale is not 200%? It's possible on Windows and it's not uncommon.

On a monitor with 150% scale, the blue 2x image is displayed, which makes sense.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18354#discussion_r1534401458

From achung at openjdk.org  Thu Mar 21 18:16:21 2024
From: achung at openjdk.org (Alisen Chung)
Date: Thu, 21 Mar 2024 18:16:21 GMT
Subject: RFR: JDK-8328398 : Convert java/awt/im/4490692/bug4490692.html
 applet test to main [v4]
In-Reply-To: <mltmgDP-EgAMXSYO6aES74ZzegqjFfH06E1Ct-GUNIQ=.1417cd4f-8c7e-4414-a16a-3e230c68311f@github.com>
References: <lcESN0hyfRYfuC2nnzmBSQrUQLmHHD6uooae53vTzWA=.682e9e1e-d3cb-4b2e-bc95-9bdd9d709f6f@github.com>
 <mltmgDP-EgAMXSYO6aES74ZzegqjFfH06E1Ct-GUNIQ=.1417cd4f-8c7e-4414-a16a-3e230c68311f@github.com>
Message-ID: <qTOMrbpWGsQpx6ul7XPUyKT8NeKx2SrnoIxfs6c1vd8=.342a858c-2293-4b68-95a2-fb08223ca7b5@github.com>

On Thu, 21 Mar 2024 17:52:34 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Following test is converted from applet to main using PassFailJFrame.
>> 
>> The original test had ignore tag - **The fix for this problem was backed out for 5057184.  Remove this "ignore" tag when it is fixed again.**
>> I believe this was fixed and the test works correctly on Linux platforms, hence ignore tag has been removed.
>> 
>> This is a semi-automated test, the first check is manual and the 2nd one is automated. Details in the test instructions.
>
> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   minor jtreg tag change

Changes requested by achung (Committer).

test/jdk/java/awt/im/bug4490692.java line 115:

> 113:         return panel;
> 114:     }
> 115: }

extra newline

-------------

PR Review: https://git.openjdk.org/jdk/pull/18402#pullrequestreview-1953060038
PR Review Comment: https://git.openjdk.org/jdk/pull/18402#discussion_r1534414016

From achung at openjdk.org  Thu Mar 21 18:18:21 2024
From: achung at openjdk.org (Alisen Chung)
Date: Thu, 21 Mar 2024 18:18:21 GMT
Subject: RFR: 8328385: Convert java/awt/FileDialog/FileDialogReturnTest
 test to main [v4]
In-Reply-To: <AdJgYXvOYQ3YDjLORme_DH00H82MnGjgfC5pVn5Ps1I=.fd5c28bf-1758-4fde-8734-1a8df9f737a1@github.com>
References: <fqHwY3Ipk9ArGTOnM26LF_dxWaQeptZ8Kf9fKNWUPVg=.43700ff8-5123-444a-817d-173bd126368d@github.com>
 <AdJgYXvOYQ3YDjLORme_DH00H82MnGjgfC5pVn5Ps1I=.fd5c28bf-1758-4fde-8734-1a8df9f737a1@github.com>
Message-ID: <PYKtffjCt7t5nmHKJh_1Q3lGjh_eob9_uE2RG_OgRLs=.3bb0578d-dc53-4eba-ab51-745325b1da86@github.com>

On Wed, 20 Mar 2024 18:37:45 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

>> Convert test to a main method based;
>> Move test to an apropriate location;
>> Remove old files;
>
> Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove .html from the @test clause

Changes requested by achung (Committer).

test/jdk/java/awt/FileDialog/FileDialogReturnTest.java line 142:

> 140:                 .awaitAndCheck();
> 141:     }
> 142: }

extra newline

-------------

PR Review: https://git.openjdk.org/jdk/pull/18363#pullrequestreview-1953063205
PR Review Comment: https://git.openjdk.org/jdk/pull/18363#discussion_r1534416751

From honkar at openjdk.org  Thu Mar 21 18:50:35 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Thu, 21 Mar 2024 18:50:35 GMT
Subject: RFR: JDK-8328190 : Convert AWTPanelSmoothWheel.html applet test to
 main [v7]
In-Reply-To: <sn9qb9ctS_sr3isHbwcbMCYh2RQokz2ptsw0rGBRnJY=.955d7549-72c7-4a4f-8ac8-a5d6f122cf68@github.com>
References: <sn9qb9ctS_sr3isHbwcbMCYh2RQokz2ptsw0rGBRnJY=.955d7549-72c7-4a4f-8ac8-a5d6f122cf68@github.com>
Message-ID: <7HVyWYGAP-Ot6aGs4ExTqsC7lyfoLwcdVn4eJkCFLDg=.8e7e742a-d30d-44b6-8c85-7b8956dc9381@github.com>

> This test is converted to main using PassFailJFrame. It verifies wheel rotation value for high-res mouse on windows.
> 
> The test requires the updated PassFailJFrame's logArea() feature added in this PR https://github.com/openjdk/jdk/pull/18319

Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:

  converted to semi-automatic, use of JOptionPane for warning msg

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18312/files
  - new: https://git.openjdk.org/jdk/pull/18312/files/6b7591f0..6901a65c

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18312&range=06
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18312&range=05-06

  Stats: 40 lines in 1 file changed: 27 ins; 0 del; 13 mod
  Patch: https://git.openjdk.org/jdk/pull/18312.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18312/head:pull/18312

PR: https://git.openjdk.org/jdk/pull/18312

From prr at openjdk.org  Thu Mar 21 19:14:44 2024
From: prr at openjdk.org (Phil Race)
Date: Thu, 21 Mar 2024 19:14:44 GMT
Subject: RFR: 8328555: hidpi problems for test
 java/awt/Dialog/DialogAnotherThread/JaWSTest.java
Message-ID: <gYkodvmu9blcvd-abDi1RhmY0B4r-xM2SFmVcjpJMgM=.f278f787-074b-4a27-8b39-2509a7f2940b@github.com>

This previously closed test is cleaned up, opened and fixed to work on hidpi at fractional scales.
It has unrelated problems on macOS 14 and is problem listed there (as it was when it was a closed test).

-------------

Commit messages:
 - 8328555

Changes: https://git.openjdk.org/jdk/pull/18439/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18439&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8328555
  Stats: 150 lines in 2 files changed: 149 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/18439.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18439/head:pull/18439

PR: https://git.openjdk.org/jdk/pull/18439

From aturbanov at openjdk.org  Thu Mar 21 19:43:21 2024
From: aturbanov at openjdk.org (Andrey Turbanov)
Date: Thu, 21 Mar 2024 19:43:21 GMT
Subject: RFR: 8328642: Convert applet test
 MouseDraggedOutCauseScrollingTest.html to main
In-Reply-To: <oSOD44PevN840Jv0JaNJLDYYqDna-8qggdwlyEayo9c=.47a9f876-50f8-4cdf-804c-596cb2ac94fb@github.com>
References: <oSOD44PevN840Jv0JaNJLDYYqDna-8qggdwlyEayo9c=.47a9f876-50f8-4cdf-804c-596cb2ac94fb@github.com>
Message-ID: <8OHyzKpslRylhpHE7-RwZG_-uqbnLtyBW2IVKmKbU60=.be266219-df7e-421f-9c99-eac9ea0ff9c7@github.com>

On Wed, 20 Mar 2024 21:33:04 GMT, Phil Race <prr at openjdk.org> wrote:

> Converts java/awt/List/MouseDraggedOutCauseScrollingTest/MouseDraggedOutCauseScrollingTest.html
> to a main program.

test/jdk/java/awt/List/MouseDraggedOutCauseScrollingTest/MouseDraggedOutCauseScrollingTest.java line 65:

> 63:         frame.add(singleList);
> 64:         frame.add(multipleList);
> 65:         frame.setSize(400,100);

Suggestion:

        frame.setSize(400, 100);

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18414#discussion_r1534561152

From honkar at openjdk.org  Thu Mar 21 19:53:48 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Thu, 21 Mar 2024 19:53:48 GMT
Subject: RFR: JDK-8328190 : Convert AWTPanelSmoothWheel.html applet test to
 main [v8]
In-Reply-To: <sn9qb9ctS_sr3isHbwcbMCYh2RQokz2ptsw0rGBRnJY=.955d7549-72c7-4a4f-8ac8-a5d6f122cf68@github.com>
References: <sn9qb9ctS_sr3isHbwcbMCYh2RQokz2ptsw0rGBRnJY=.955d7549-72c7-4a4f-8ac8-a5d6f122cf68@github.com>
Message-ID: <ZLWbHjYWkT2QoPJVoKrpdOfLy_myoGI5x1UmXGuXmR0=.5d84f0f8-58d4-44e2-b223-c4c4685aadef@github.com>

> This test is converted to main using PassFailJFrame. It verifies wheel rotation value for high-res mouse on windows.
> 
> The test requires the updated PassFailJFrame's logArea() feature added in this PR https://github.com/openjdk/jdk/pull/18319

Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:

  changed the forcePass logic, updated instructions

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18312/files
  - new: https://git.openjdk.org/jdk/pull/18312/files/6901a65c..ec673142

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18312&range=07
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18312&range=06-07

  Stats: 21 lines in 1 file changed: 3 ins; 6 del; 12 mod
  Patch: https://git.openjdk.org/jdk/pull/18312.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18312/head:pull/18312

PR: https://git.openjdk.org/jdk/pull/18312

From honkar at openjdk.org  Thu Mar 21 19:53:49 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Thu, 21 Mar 2024 19:53:49 GMT
Subject: RFR: JDK-8328190 : Convert AWTPanelSmoothWheel.html applet test to
 main [v6]
In-Reply-To: <_nnWF0LSxuojYz7WdCE2yqHGEL1TCJKGOdoDWHdf4kU=.f773e15f-9c10-4733-baef-5e1e1da3b5a5@github.com>
References: <sn9qb9ctS_sr3isHbwcbMCYh2RQokz2ptsw0rGBRnJY=.955d7549-72c7-4a4f-8ac8-a5d6f122cf68@github.com>
 <QIODl_DsczYOOkKiQQIvyr_5CWaxnZfUcd8Gs855Y4c=.ac936322-0895-4153-8585-26d6978157a6@github.com>
 <_nnWF0LSxuojYz7WdCE2yqHGEL1TCJKGOdoDWHdf4kU=.f773e15f-9c10-4733-baef-5e1e1da3b5a5@github.com>
Message-ID: <RULyjGQaLBXTgGdvby-G_Tn0oB96NGM4k9kdDSk3Jeo=.e5df858e-bae8-41ca-bfb2-cecded40f473@github.com>

On Thu, 21 Mar 2024 15:04:18 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   added preciseWheelRotation logic & updated test
>
> test/jdk/java/awt/event/MouseEvent/AWTPanelSmoothWheel.java line 99:
> 
>> 97:                 }
>> 98:                 if (wheelEventCount >= 5 && hiResWheelCount == 0) {
>> 99:                     PassFailJFrame.log("WARNING !!! You might not be using a high-res mouse.");
> 
> [`JOptionPane.showMessageDialog`](https://docs.oracle.com/en/java/javase/21/docs/api/java.desktop/javax/swing/JOptionPane.html#showMessageDialog(java.awt.Component,java.lang.Object,java.lang.String,int)) could be a better option to attract the tester's attention.

Thanks for the suggestion. Added it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18312#discussion_r1534577098

From azvegint at openjdk.org  Thu Mar 21 19:55:20 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Thu, 21 Mar 2024 19:55:20 GMT
Subject: RFR: JDK-8328398 : Convert java/awt/im/4490692/bug4490692.html
 applet test to main [v4]
In-Reply-To: <mltmgDP-EgAMXSYO6aES74ZzegqjFfH06E1Ct-GUNIQ=.1417cd4f-8c7e-4414-a16a-3e230c68311f@github.com>
References: <lcESN0hyfRYfuC2nnzmBSQrUQLmHHD6uooae53vTzWA=.682e9e1e-d3cb-4b2e-bc95-9bdd9d709f6f@github.com>
 <mltmgDP-EgAMXSYO6aES74ZzegqjFfH06E1Ct-GUNIQ=.1417cd4f-8c7e-4414-a16a-3e230c68311f@github.com>
Message-ID: <D8cCUWrFyY4uDR-uwxwG5vjcZk4suiz09YI1KOPevsM=.8660a3b7-06fc-4599-968c-4bd21ad7d2a7@github.com>

On Thu, 21 Mar 2024 17:52:34 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Following test is converted from applet to main using PassFailJFrame.
>> 
>> The original test had ignore tag - **The fix for this problem was backed out for 5057184.  Remove this "ignore" tag when it is fixed again.**
>> I believe this was fixed and the test works correctly on Linux platforms, hence ignore tag has been removed.
>> 
>> This is a semi-automated test, the first check is manual and the 2nd one is automated. Details in the test instructions.
>
> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   minor jtreg tag change

Marked as reviewed by azvegint (Reviewer).

test/jdk/java/awt/im/bug4490692.java line 87:

> 85:         panel.add(new JLabel("Text field:"));
> 86: 
> 87:         textField.addKeyListener(new KeyListener() {

you can use `KeyAdapter` to avoid overriding unused methods (`keyTyped`, `keyReleased`).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18402#pullrequestreview-1953247310
PR Review Comment: https://git.openjdk.org/jdk/pull/18402#discussion_r1534565486

From azvegint at openjdk.org  Thu Mar 21 19:55:22 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Thu, 21 Mar 2024 19:55:22 GMT
Subject: RFR: JDK-8328398 : Convert java/awt/im/4490692/bug4490692.html
 applet test to main [v2]
In-Reply-To: <q0EdVTvuL9zgklnO5E7fP_dqB6U-nxjArsl-irfB55s=.e2927019-08b1-4dbf-b03c-69a0edf95397@github.com>
References: <lcESN0hyfRYfuC2nnzmBSQrUQLmHHD6uooae53vTzWA=.682e9e1e-d3cb-4b2e-bc95-9bdd9d709f6f@github.com>
 <aS6ATocsIxgP1ABKQTve2waCy-MeH92snBcEZJftr9s=.24f93a07-f2b6-4608-9785-53b0399fcd03@github.com>
 <CETT2AYhreeC9vGiKMfghFTU8z2WtS86PXKrfuu6X8I=.fc26a12c-5d3c-4473-afd5-d9fcc7d79830@github.com>
 <q0EdVTvuL9zgklnO5E7fP_dqB6U-nxjArsl-irfB55s=.e2927019-08b1-4dbf-b03c-69a0edf95397@github.com>
Message-ID: <a1og_pmLQW7OWs6y5oHtufzGc5GHbvSCVMZy8aumAcw=.fd15030c-9f37-41d1-90b7-c4587024b969@github.com>

On Thu, 21 Mar 2024 17:33:22 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> test/jdk/java/awt/im/bug4490692.java line 95:
>> 
>>> 93:     @Override
>>> 94:     public void keyPressed(KeyEvent e) {
>>> 95:         if (e.getKeyCode() == 23 || e.getKeyCode() == 60) {
>> 
>>>  CASE 2: This step is automated and applicable for both
>> keyboards - LINUX & SOLARIS SPARC.
>> When Tab key is pressed it should generate a-acute (?)
>> character, this test automatically passes if the correct character
>> is generated on keypress else fails.
>> 
>> Unfortunately this check doesn't work for me:
>> `java.awt.event.KeyEvent[KEY_PRESSED,keyCode=0,keyText=Unknown keyCode: 0x0,keyChar='?',keyLocation=KEY_LOCATION_UNKNOWN,rawCode=23,primaryLevelUnicode=225,scancode=0,extendedKeyCode=0x10000e1] on javax.swing.JTextField...`
>> 
>> The `keycode` is 0, `rawCode` is desired `23`, but we can't get it it unless parsing the output of `e.toString()`
>> 
>> The `e.getKeyChar() == 0x00e1` check is still valid thought.
>
> @azvegint Thanks for checking it. Update the code & added the rawCode check now. Can you please re-review it.

Now it works for the tab case, thank you.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18402#discussion_r1534579209

From azvegint at openjdk.org  Thu Mar 21 20:00:26 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Thu, 21 Mar 2024 20:00:26 GMT
Subject: RFR: JDK-8328398 : Convert java/awt/im/4490692/bug4490692.html
 applet test to main [v4]
In-Reply-To: <qTOMrbpWGsQpx6ul7XPUyKT8NeKx2SrnoIxfs6c1vd8=.342a858c-2293-4b68-95a2-fb08223ca7b5@github.com>
References: <lcESN0hyfRYfuC2nnzmBSQrUQLmHHD6uooae53vTzWA=.682e9e1e-d3cb-4b2e-bc95-9bdd9d709f6f@github.com>
 <mltmgDP-EgAMXSYO6aES74ZzegqjFfH06E1Ct-GUNIQ=.1417cd4f-8c7e-4414-a16a-3e230c68311f@github.com>
 <qTOMrbpWGsQpx6ul7XPUyKT8NeKx2SrnoIxfs6c1vd8=.342a858c-2293-4b68-95a2-fb08223ca7b5@github.com>
Message-ID: <fjA7TlqExPi1eaLQleLYk83aB3WS32Wxggfgcw2_WSw=.44b6ddfe-d49e-4107-90f1-7a2bf79ae373@github.com>

On Thu, 21 Mar 2024 18:13:41 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   minor jtreg tag change
>
> test/jdk/java/awt/im/bug4490692.java line 115:
> 
>> 113:         return panel;
>> 114:     }
>> 115: }
> 
> extra newline

It is a common practice:
https://stackoverflow.com/a/4700756

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18402#discussion_r1534585340

From honkar at openjdk.org  Thu Mar 21 20:00:26 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Thu, 21 Mar 2024 20:00:26 GMT
Subject: RFR: JDK-8328190 : Convert AWTPanelSmoothWheel.html applet test to
 main [v6]
In-Reply-To: <tg21lGJHWa3YHxeHKi-RWHxlQ5EXKC1xj7Sq5qY8XDw=.9edafe5a-3205-41b2-ada8-3bda32f74329@github.com>
References: <sn9qb9ctS_sr3isHbwcbMCYh2RQokz2ptsw0rGBRnJY=.955d7549-72c7-4a4f-8ac8-a5d6f122cf68@github.com>
 <QIODl_DsczYOOkKiQQIvyr_5CWaxnZfUcd8Gs855Y4c=.ac936322-0895-4153-8585-26d6978157a6@github.com>
 <tg21lGJHWa3YHxeHKi-RWHxlQ5EXKC1xj7Sq5qY8XDw=.9edafe5a-3205-41b2-ada8-3bda32f74329@github.com>
Message-ID: <0-Nn3syDmIIEjkI3vKRJw2TZZfDVJuPoxCxpS1db3Fs=.475b7415-04ad-4767-a34a-1c8ad412f89d@github.com>

On Thu, 21 Mar 2024 14:47:52 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   added preciseWheelRotation logic & updated test
>
> Changes requested by aivanov (Reviewer).

@aivanov-jdk 

I have changed the logic for MouseWheelEvents as below:

- wheelRotationCount was no longer required, hence removed it .
- checking for Math.abs(e.getPreciseWheelRotation()) value since it can be negative when mouse is scrolled down.
- `(e.getWheelRotation() != 0 && hiResWheelCount > 0)` this condition looks to be sufficient to forcePass the test as we need only one complete non-zero wheelRotation value.
- added JOptionPane for the warning message as suggested.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18312#issuecomment-2013565144

From prr at openjdk.org  Thu Mar 21 20:04:27 2024
From: prr at openjdk.org (Phil Race)
Date: Thu, 21 Mar 2024 20:04:27 GMT
Subject: RFR: 8328561: test
 java/awt/Robot/ManualInstructions/ManualInstructions.java isn't used
Message-ID: <ABW2Bldb5eN2as1Jb7G7lFW1ULTIizQwTaHQTORhLnc=.02516bdc-9b01-4748-b80e-fa54b0b8996e@github.com>

I don't know why this file is checked in. It has no @test tag and doesn't do anything. I am deleting it.

-------------

Commit messages:
 - 8328561

Changes: https://git.openjdk.org/jdk/pull/18440/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18440&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8328561
  Stats: 328 lines in 1 file changed: 0 ins; 328 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18440.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18440/head:pull/18440

PR: https://git.openjdk.org/jdk/pull/18440

From honkar at openjdk.org  Thu Mar 21 20:10:35 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Thu, 21 Mar 2024 20:10:35 GMT
Subject: RFR: JDK-8328398 : Convert java/awt/im/4490692/bug4490692.html
 applet test to main [v5]
In-Reply-To: <lcESN0hyfRYfuC2nnzmBSQrUQLmHHD6uooae53vTzWA=.682e9e1e-d3cb-4b2e-bc95-9bdd9d709f6f@github.com>
References: <lcESN0hyfRYfuC2nnzmBSQrUQLmHHD6uooae53vTzWA=.682e9e1e-d3cb-4b2e-bc95-9bdd9d709f6f@github.com>
Message-ID: <vMXdkltYn9YRDyLq2x3coEsD_3KT3V5LXAzMAOtCwKI=.1effe42b-4b9c-407b-974a-2c5d9bb512b0@github.com>

> Following test is converted from applet to main using PassFailJFrame.
> 
> The original test had ignore tag - **The fix for this problem was backed out for 5057184.  Remove this "ignore" tag when it is fixed again.**
> I believe this was fixed and the test works correctly on Linux platforms, hence ignore tag has been removed.
> 
> This is a semi-automated test, the first check is manual and the 2nd one is automated. Details in the test instructions.

Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:

  KeyAdapter changes

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18402/files
  - new: https://git.openjdk.org/jdk/pull/18402/files/03cc8e41..de73fa42

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18402&range=04
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18402&range=03-04

  Stats: 12 lines in 1 file changed: 1 ins; 10 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/18402.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18402/head:pull/18402

PR: https://git.openjdk.org/jdk/pull/18402

From prr at openjdk.org  Thu Mar 21 20:10:42 2024
From: prr at openjdk.org (Phil Race)
Date: Thu, 21 Mar 2024 20:10:42 GMT
Subject: RFR: 8328642: Convert applet test
 MouseDraggedOutCauseScrollingTest.html to main [v2]
In-Reply-To: <oSOD44PevN840Jv0JaNJLDYYqDna-8qggdwlyEayo9c=.47a9f876-50f8-4cdf-804c-596cb2ac94fb@github.com>
References: <oSOD44PevN840Jv0JaNJLDYYqDna-8qggdwlyEayo9c=.47a9f876-50f8-4cdf-804c-596cb2ac94fb@github.com>
Message-ID: <5AoaJH0Y9Qofx5WHxQrZhztQLefnZbfT2Qt67iFeSd4=.a65de28b-baaa-4948-8801-e977b624d68c@github.com>

> Converts java/awt/List/MouseDraggedOutCauseScrollingTest/MouseDraggedOutCauseScrollingTest.html
> to a main program.

Phil Race has updated the pull request incrementally with one additional commit since the last revision:

  8328642

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18414/files
  - new: https://git.openjdk.org/jdk/pull/18414/files/979e4857..5f863c9d

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18414&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18414&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/18414.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18414/head:pull/18414

PR: https://git.openjdk.org/jdk/pull/18414

From prr at openjdk.org  Thu Mar 21 20:10:42 2024
From: prr at openjdk.org (Phil Race)
Date: Thu, 21 Mar 2024 20:10:42 GMT
Subject: RFR: 8328642: Convert applet test
 MouseDraggedOutCauseScrollingTest.html to main [v2]
In-Reply-To: <jl7QZ6hsyGK917HMT9LO9Brxyr8BAJvkoaPusdaVPSI=.0df7c693-4f73-489c-80d5-5bc5a11772a7@github.com>
References: <oSOD44PevN840Jv0JaNJLDYYqDna-8qggdwlyEayo9c=.47a9f876-50f8-4cdf-804c-596cb2ac94fb@github.com>
 <jl7QZ6hsyGK917HMT9LO9Brxyr8BAJvkoaPusdaVPSI=.0df7c693-4f73-489c-80d5-5bc5a11772a7@github.com>
Message-ID: <piPgJrd503GpN19gHPVA9nQl16wD4NBJWa3sFBbz8Sg=.53f40edd-8904-44eb-b354-77dbb32dc644@github.com>

On Thu, 21 Mar 2024 13:51:16 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8328642
>
> test/jdk/java/awt/List/MouseDraggedOutCauseScrollingTest/MouseDraggedOutCauseScrollingTest.java line 31:
> 
>> 29:   @library /java/awt/regtesthelpers
>> 30:   @run main/manual MouseDraggedOutCauseScrollingTest
>> 31: */
> 
> We usually move this and instructions block closer to a class declaration, for better readability.

So people have been saying this, and I've even done it when asked, but I'm not sure I agree.
Although it has to go below the legal stuff, after that I like to see the test tag right at the top of the file,
not below a random number of imports.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18414#discussion_r1534605049

From prr at openjdk.org  Thu Mar 21 20:10:43 2024
From: prr at openjdk.org (Phil Race)
Date: Thu, 21 Mar 2024 20:10:43 GMT
Subject: Integrated: 8328642: Convert applet test
 MouseDraggedOutCauseScrollingTest.html to main
In-Reply-To: <oSOD44PevN840Jv0JaNJLDYYqDna-8qggdwlyEayo9c=.47a9f876-50f8-4cdf-804c-596cb2ac94fb@github.com>
References: <oSOD44PevN840Jv0JaNJLDYYqDna-8qggdwlyEayo9c=.47a9f876-50f8-4cdf-804c-596cb2ac94fb@github.com>
Message-ID: <_YZHAL2oL7RWIBw9P-YoRBVQsiPRp5EpkwFQPZgXXQs=.d8ea91f9-103c-4718-a45b-37185347c67b@github.com>

On Wed, 20 Mar 2024 21:33:04 GMT, Phil Race <prr at openjdk.org> wrote:

> Converts java/awt/List/MouseDraggedOutCauseScrollingTest/MouseDraggedOutCauseScrollingTest.html
> to a main program.

This pull request has now been integrated.

Changeset: ab183e43
Author:    Phil Race <prr at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/ab183e437c18b445e9c022a4d74de818d4ccecbe
Stats:     286 lines in 2 files changed: 48 ins; 211 del; 27 mod

8328642: Convert applet test MouseDraggedOutCauseScrollingTest.html to main

Reviewed-by: abhiscxk, azvegint

-------------

PR: https://git.openjdk.org/jdk/pull/18414

From honkar at openjdk.org  Thu Mar 21 20:17:46 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Thu, 21 Mar 2024 20:17:46 GMT
Subject: RFR: JDK-8328398 : Convert java/awt/im/4490692/bug4490692.html
 applet test to main [v6]
In-Reply-To: <lcESN0hyfRYfuC2nnzmBSQrUQLmHHD6uooae53vTzWA=.682e9e1e-d3cb-4b2e-bc95-9bdd9d709f6f@github.com>
References: <lcESN0hyfRYfuC2nnzmBSQrUQLmHHD6uooae53vTzWA=.682e9e1e-d3cb-4b2e-bc95-9bdd9d709f6f@github.com>
Message-ID: <swWU7a9L-qP8ybYcpUe8gCo98yb5QKk56s_5N9LQtbA=.6b2524b8-e70e-410c-a6bd-d6df994c7ce7@github.com>

> Following test is converted from applet to main using PassFailJFrame.
> 
> The original test had ignore tag - **The fix for this problem was backed out for 5057184.  Remove this "ignore" tag when it is fixed again.**
> I believe this was fixed and the test works correctly on Linux platforms, hence ignore tag has been removed.
> 
> This is a semi-automated test, the first check is manual and the 2nd one is automated. Details in the test instructions.

Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:

  re-added @requires tag

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18402/files
  - new: https://git.openjdk.org/jdk/pull/18402/files/de73fa42..f86f3d07

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18402&range=05
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18402&range=04-05

  Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18402.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18402/head:pull/18402

PR: https://git.openjdk.org/jdk/pull/18402

From honkar at openjdk.org  Thu Mar 21 20:17:46 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Thu, 21 Mar 2024 20:17:46 GMT
Subject: RFR: JDK-8328398 : Convert java/awt/im/4490692/bug4490692.html
 applet test to main [v4]
In-Reply-To: <D8cCUWrFyY4uDR-uwxwG5vjcZk4suiz09YI1KOPevsM=.8660a3b7-06fc-4599-968c-4bd21ad7d2a7@github.com>
References: <lcESN0hyfRYfuC2nnzmBSQrUQLmHHD6uooae53vTzWA=.682e9e1e-d3cb-4b2e-bc95-9bdd9d709f6f@github.com>
 <mltmgDP-EgAMXSYO6aES74ZzegqjFfH06E1Ct-GUNIQ=.1417cd4f-8c7e-4414-a16a-3e230c68311f@github.com>
 <D8cCUWrFyY4uDR-uwxwG5vjcZk4suiz09YI1KOPevsM=.8660a3b7-06fc-4599-968c-4bd21ad7d2a7@github.com>
Message-ID: <f1cc__CTLRSAixRdcbx7cuNqSIq5vEaGoXE8K1M-HgU=.a81651d2-8d80-4f05-99b7-8d35a35e1f22@github.com>

On Thu, 21 Mar 2024 19:44:52 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   minor jtreg tag change
>
> test/jdk/java/awt/im/bug4490692.java line 87:
> 
>> 85:         panel.add(new JLabel("Text field:"));
>> 86: 
>> 87:         textField.addKeyListener(new KeyListener() {
> 
> you can use `KeyAdapter` to avoid overriding unused methods (`keyTyped`, `keyReleased`).

Thanks! Updated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18402#discussion_r1534618391

From azvegint at openjdk.org  Thu Mar 21 20:25:22 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Thu, 21 Mar 2024 20:25:22 GMT
Subject: RFR: 8328382: Convert java/awt/FileDialog/FileDialogForPackages
 test to main [v2]
In-Reply-To: <MKVedV-MEXVNNOh3Pwdvl1qF1EShs8k9R7cqVNHcKks=.98f16733-ed37-4689-85a2-d1077ad3b182@github.com>
References: <9gStC1mcEgWDsQsLiOUD0PHZ1mgIEgaM3f_EAQokmv0=.7f9ce16a-2180-4dea-96af-bcbcf955eec7@github.com>
 <_ytFO979o9K4RS7fFO_JTQKBda1f-S-at-TBIiWeLhs=.f9467d54-2198-4f3d-a3bc-c90e3a36c2e4@github.com>
 <MKVedV-MEXVNNOh3Pwdvl1qF1EShs8k9R7cqVNHcKks=.98f16733-ed37-4689-85a2-d1077ad3b182@github.com>
Message-ID: <lfKvy8T43y3shxodsU_B-Qf3ddV-OEQBNeJLZmPT24E=.658591cb-1916-459a-8adc-bb7137942068@github.com>

On Thu, 21 Mar 2024 16:17:33 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Adding library and build clauses
>
> test/jdk/java/awt/FileDialog/FileDialogForPackages.java line 59:
> 
>> 57:         frame.add(textScrollPane, BorderLayout.CENTER);
>> 58: 
>> 59:         fd = new FileDialog(new Frame(), "Open");
> 
> is there any need to mix Swing and AWT components in the test? I guess you can use the JFrame already created

Actually you don't need the textOutput, with recent changes you can add `.logArea()` to the PassFailJFrame builder

https://github.com/openjdk/jdk/blob/master/test/jdk/java/awt/regtesthelpers/PassFailJFrame.java#L1200

and just use `PassFailJFrame.log()` wherever you need it.

So this method can be changed to return the a `JButton`, and use it with `splitUIBottom`/`splitUIRight` instead of testUI

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18360#discussion_r1534625825

From achung at openjdk.org  Thu Mar 21 21:10:22 2024
From: achung at openjdk.org (Alisen Chung)
Date: Thu, 21 Mar 2024 21:10:22 GMT
Subject: RFR: 8328385: Convert java/awt/FileDialog/FileDialogReturnTest
 test to main [v4]
In-Reply-To: <AdJgYXvOYQ3YDjLORme_DH00H82MnGjgfC5pVn5Ps1I=.fd5c28bf-1758-4fde-8734-1a8df9f737a1@github.com>
References: <fqHwY3Ipk9ArGTOnM26LF_dxWaQeptZ8Kf9fKNWUPVg=.43700ff8-5123-444a-817d-173bd126368d@github.com>
 <AdJgYXvOYQ3YDjLORme_DH00H82MnGjgfC5pVn5Ps1I=.fd5c28bf-1758-4fde-8734-1a8df9f737a1@github.com>
Message-ID: <FMoYaEmFN0eYfHa5_qID34qXLE-Vj2t6GMLVMvxLTtY=.969d4ae2-f2b2-49cd-b2bf-2c7366e485fb@github.com>

On Wed, 20 Mar 2024 18:37:45 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

>> Convert test to a main method based;
>> Move test to an apropriate location;
>> Remove old files;
>
> Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove .html from the @test clause

Marked as reviewed by achung (Committer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18363#pullrequestreview-1953428533

From achung at openjdk.org  Thu Mar 21 21:10:23 2024
From: achung at openjdk.org (Alisen Chung)
Date: Thu, 21 Mar 2024 21:10:23 GMT
Subject: RFR: 8328385: Convert java/awt/FileDialog/FileDialogReturnTest
 test to main [v4]
In-Reply-To: <PYKtffjCt7t5nmHKJh_1Q3lGjh_eob9_uE2RG_OgRLs=.3bb0578d-dc53-4eba-ab51-745325b1da86@github.com>
References: <fqHwY3Ipk9ArGTOnM26LF_dxWaQeptZ8Kf9fKNWUPVg=.43700ff8-5123-444a-817d-173bd126368d@github.com>
 <AdJgYXvOYQ3YDjLORme_DH00H82MnGjgfC5pVn5Ps1I=.fd5c28bf-1758-4fde-8734-1a8df9f737a1@github.com>
 <PYKtffjCt7t5nmHKJh_1Q3lGjh_eob9_uE2RG_OgRLs=.3bb0578d-dc53-4eba-ab51-745325b1da86@github.com>
Message-ID: <Jbtz5PTZZfwyyovYclMOi1tcc2ajlRjgUyTAFDglqLo=.0b17954d-82fd-439a-a905-70d4049ab20b@github.com>

On Thu, 21 Mar 2024 18:15:23 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove .html from the @test clause
>
> test/jdk/java/awt/FileDialog/FileDialogReturnTest.java line 142:
> 
>> 140:                 .awaitAndCheck();
>> 141:     }
>> 142: }
> 
> extra newline

oops, got confused with github formatting, everything else looks good

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18363#discussion_r1534684467

From achung at openjdk.org  Thu Mar 21 21:11:22 2024
From: achung at openjdk.org (Alisen Chung)
Date: Thu, 21 Mar 2024 21:11:22 GMT
Subject: RFR: JDK-8328398 : Convert java/awt/im/4490692/bug4490692.html
 applet test to main [v6]
In-Reply-To: <swWU7a9L-qP8ybYcpUe8gCo98yb5QKk56s_5N9LQtbA=.6b2524b8-e70e-410c-a6bd-d6df994c7ce7@github.com>
References: <lcESN0hyfRYfuC2nnzmBSQrUQLmHHD6uooae53vTzWA=.682e9e1e-d3cb-4b2e-bc95-9bdd9d709f6f@github.com>
 <swWU7a9L-qP8ybYcpUe8gCo98yb5QKk56s_5N9LQtbA=.6b2524b8-e70e-410c-a6bd-d6df994c7ce7@github.com>
Message-ID: <H3KNiVQ04jCGY23BcvgjEJx4xwtPTk5KgUs4RKjEEj8=.a5022761-45a3-4701-bf9c-e19bd835fadb@github.com>

On Thu, 21 Mar 2024 20:17:46 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Following test is converted from applet to main using PassFailJFrame.
>> 
>> The original test had ignore tag - **The fix for this problem was backed out for 5057184.  Remove this "ignore" tag when it is fixed again.**
>> I believe this was fixed and the test works correctly on Linux platforms, hence ignore tag has been removed.
>> 
>> This is a semi-automated test, the first check is manual and the 2nd one is automated. Details in the test instructions.
>
> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   re-added @requires tag

Marked as reviewed by achung (Committer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18402#pullrequestreview-1953428980

From prr at openjdk.org  Thu Mar 21 22:48:25 2024
From: prr at openjdk.org (Phil Race)
Date: Thu, 21 Mar 2024 22:48:25 GMT
Subject: RFR: 8327840: Automate javax/swing/border/Test4129681.java [v4]
In-Reply-To: <4w7MNk7DTNfFWhugo3ZSaQesEIGV00_Lv8JKPK5B_ZA=.c3a1c723-3b8d-4064-8b77-96b9f5b86cf8@github.com>
References: <BbQ2iwy01dkTxtQ9Aj7RhRkSxWm3pq3BEIlGIzlSTCk=.7bdaafe4-681a-4f03-8462-4ffa7dc99507@github.com>
 <4w7MNk7DTNfFWhugo3ZSaQesEIGV00_Lv8JKPK5B_ZA=.c3a1c723-3b8d-4064-8b77-96b9f5b86cf8@github.com>
Message-ID: <jCA-ia65VOiLKSTyjMHI_jzMcmei8LWMoldzqVD-52E=.9e2752ca-c96a-45d3-a739-4c88ae533b6f@github.com>

On Thu, 21 Mar 2024 05:14:44 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Automated the Test `javax/swing/border/Test4129681.java` from manual as suggested in JBS description.
>> Verified in CI system and its Green. The test has been verified for Metal L&F and the same is set explicitly..
>
> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review updates

Marked as reviewed by prr (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18336#pullrequestreview-1953568643

From prr at openjdk.org  Thu Mar 21 22:50:38 2024
From: prr at openjdk.org (Phil Race)
Date: Thu, 21 Mar 2024 22:50:38 GMT
Subject: Integrated: 8328301: Convert Applet test ManualHTMLDataFlavorTest.java
 to main program
In-Reply-To: <ezZp85g1cKWnR1M7apMh6bxP2_G6P9O5tN6DTSQEOU4=.951f4e5d-e956-4af8-b4f1-725c667224b5@github.com>
References: <ezZp85g1cKWnR1M7apMh6bxP2_G6P9O5tN6DTSQEOU4=.951f4e5d-e956-4af8-b4f1-725c667224b5@github.com>
Message-ID: <V-GoLxrK6Cf2L2RS2ZBZ9zrkThfQoIAc-Sx_BqiimW0=.61da6af8-72df-435d-b75c-19ce6de1e602@github.com>

On Fri, 15 Mar 2024 22:32:12 GMT, Phil Race <prr at openjdk.org> wrote:

> Convert this applet based test to a main program

This pull request has now been integrated.

Changeset: f7f291c5
Author:    Phil Race <prr at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/f7f291c5d4d2d01dab3ccda7518ebc13f6bd58f6
Stats:     260 lines in 2 files changed: 15 ins; 189 del; 56 mod

8328301: Convert Applet test ManualHTMLDataFlavorTest.java to main program

Reviewed-by: honkar

-------------

PR: https://git.openjdk.org/jdk/pull/18334

From prr at openjdk.org  Thu Mar 21 22:51:22 2024
From: prr at openjdk.org (Phil Race)
Date: Thu, 21 Mar 2024 22:51:22 GMT
Subject: RFR: 8328227: Remove applet usage from JColorChooser tests
 Test4887836 [v3]
In-Reply-To: <erPi8_-ggo-p0gEBfaHBShPybFDwrzzzQWcYU7DQ8ko=.00d594a4-6d99-4bc9-85a7-f9a754020987@github.com>
References: <sz94hhkj7mCeInxQ075Uwe14NVjdUMDk3sbuOr1E2X0=.2cc0c644-dd7a-4044-aa17-c082abaf74b6@github.com>
 <erPi8_-ggo-p0gEBfaHBShPybFDwrzzzQWcYU7DQ8ko=.00d594a4-6d99-4bc9-85a7-f9a754020987@github.com>
Message-ID: <f3m56r4O-_ZwuclL5h1DagBzrfFvsn67G-RDQUNx21o=.e97693f6-6087-45db-a10a-a8c9123f9af7@github.com>

On Wed, 20 Mar 2024 18:01:51 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> Removing applet usage from manual JColorChooser tests
>
> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   text block instructions

test/jdk/javax/swing/JColorChooser/Test4887836.java line 60:

> 58: 
> 59:         // NON-NLS: property and font names
> 60:         UIManager.put("Label.font", new Font("Perpetua", 0, 36));

Sorry, not related to the applet conversion but Perpetua ?? Pointless.  Won't exist.
Change it to Font.DIALOG. I think you should also remove the comment line.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18316#discussion_r1534780051

From honkar at openjdk.org  Thu Mar 21 23:09:27 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Thu, 21 Mar 2024 23:09:27 GMT
Subject: Integrated: JDK-8328398 : Convert java/awt/im/4490692/bug4490692.html
 applet test to main
In-Reply-To: <lcESN0hyfRYfuC2nnzmBSQrUQLmHHD6uooae53vTzWA=.682e9e1e-d3cb-4b2e-bc95-9bdd9d709f6f@github.com>
References: <lcESN0hyfRYfuC2nnzmBSQrUQLmHHD6uooae53vTzWA=.682e9e1e-d3cb-4b2e-bc95-9bdd9d709f6f@github.com>
Message-ID: <wrztK_gwVrv_EXrC0wxupSIqgXZLOpvOrq2SaKa_rqY=.c4e14b37-29be-4cdb-acce-5bc10ab151d8@github.com>

On Wed, 20 Mar 2024 16:38:25 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

> Following test is converted from applet to main using PassFailJFrame.
> 
> The original test had ignore tag - **The fix for this problem was backed out for 5057184.  Remove this "ignore" tag when it is fixed again.**
> I believe this was fixed and the test works correctly on Linux platforms, hence ignore tag has been removed.
> 
> This is a semi-automated test, the first check is manual and the 2nd one is automated. Details in the test instructions.

This pull request has now been integrated.

Changeset: 0efd9dc0
Author:    Harshitha Onkar <honkar at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/0efd9dc09b969846f79fb8ca16ddf565117d52b6
Stats:     238 lines in 3 files changed: 107 ins; 131 del; 0 mod

8328398: Convert java/awt/im/4490692/bug4490692.html applet test to main

Reviewed-by: achung, azvegint

-------------

PR: https://git.openjdk.org/jdk/pull/18402

From kizune at openjdk.org  Thu Mar 21 23:40:46 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Thu, 21 Mar 2024 23:40:46 GMT
Subject: RFR: 8316324: Opensource five miscellaneous Swing tests
Message-ID: <2GNSvcn0o7_d4Gca1TkUmz3M2gTtjg2lF8guEq2V8Bs=.cd4c564a-b089-4a8e-b582-b778a73b0329@github.com>

Clean up and opensource five tests.

-------------

Commit messages:
 - 8316324: Opensource five miscellaneous Swing tests

Changes: https://git.openjdk.org/jdk/pull/18443/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18443&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8316324
  Stats: 565 lines in 6 files changed: 565 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18443.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18443/head:pull/18443

PR: https://git.openjdk.org/jdk/pull/18443

From honkar at openjdk.org  Fri Mar 22 00:35:30 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Fri, 22 Mar 2024 00:35:30 GMT
Subject: RFR: 8327980: Convert
 javax/swing/JToggleButton/4128979/bug4128979.java applet test to main [v5]
In-Reply-To: <CI5b0LRpMwIQQULd-K7SL1T_xzTJLAhswbc-1e9WpkE=.2eeaf569-0069-4f6a-898b-1c7f8df13e0a@github.com>
References: <lZHt9pYb75UtaIEtbB0paOkfqR5CUAc6tikhb9YAakU=.ff2adbed-1db2-490a-8747-66ac96d03657@github.com>
 <CI5b0LRpMwIQQULd-K7SL1T_xzTJLAhswbc-1e9WpkE=.2eeaf569-0069-4f6a-898b-1c7f8df13e0a@github.com>
Message-ID: <ylJl5uuDmdELslKIJD_B4_kMQgM0za3puTpi0gRXQdE=.9e0b52d4-a835-4dd9-a414-e8e5f2903086@github.com>

On Wed, 20 Mar 2024 08:30:36 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Conversion of manual applet test to main based using PassFailJFrame manual framework
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review comment update

Updated changes look good.

-------------

Marked as reviewed by honkar (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18233#pullrequestreview-1953726069

From honkar at openjdk.org  Fri Mar 22 01:26:24 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Fri, 22 Mar 2024 01:26:24 GMT
Subject: RFR: 8328717: Convert
 javax/swing/JColorChooser/8065098/bug8065098.java applet test to main
In-Reply-To: <SZLE6sOQUNGW_tBIfu6MkZE7rxjp5HJGZih6X50rrpw=.231ba8d7-c9cb-4dc9-b27a-62060696d0a1@github.com>
References: <SZLE6sOQUNGW_tBIfu6MkZE7rxjp5HJGZih6X50rrpw=.231ba8d7-c9cb-4dc9-b27a-62060696d0a1@github.com>
Message-ID: <RanAaZIZfAccXF1EKCQ8VKfcUIs55TuaKo_h7ud9_G8=.34018b2a-e13f-41a7-b559-5d52986d9870@github.com>

On Thu, 21 Mar 2024 16:31:04 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

> Convert javax/swing/JColorChooser/8065098/bug8065098.java applet test to main using PassFailJFrame for the instructions.

@DamonGuy Tested on macOS, JColorChooser DnD doesn't seem to work on it.

test/jdk/javax/swing/JColorChooser/8065098/JColorChooserDnDTest.java line 37:

> 35: 
> 36:     public static void main(String[] args) {
> 37:         SwingUtilities.invokeLater(() -> {

Copyright year needs to be updated for this file

-------------

PR Review: https://git.openjdk.org/jdk/pull/18436#pullrequestreview-1953766551
PR Review Comment: https://git.openjdk.org/jdk/pull/18436#discussion_r1534921979

From honkar at openjdk.org  Fri Mar 22 01:34:25 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Fri, 22 Mar 2024 01:34:25 GMT
Subject: RFR: 8328380: Remove applet usage from JColorChooser tests
 Test6348456
In-Reply-To: <_aL-mUkiTU1jMOsAtDv8wQ4LfmGjhtiFqVr4pqBmUyU=.43345241-dc46-48b8-bab5-95e2b4d18136@github.com>
References: <_aL-mUkiTU1jMOsAtDv8wQ4LfmGjhtiFqVr4pqBmUyU=.43345241-dc46-48b8-bab5-95e2b4d18136@github.com>
Message-ID: <F1C0fLPUiz2JbR31mVr2x8Av2ecaFOTjoKGzNeudifI=.ea922491-9d41-4a4d-915f-e0db00ffd7f2@github.com>

On Mon, 18 Mar 2024 20:07:50 GMT, Alisen Chung <achung at openjdk.org> wrote:

> Removing applet usage from manual JColorChooser tests

Marked as reviewed by honkar (Reviewer).

test/jdk/javax/swing/JColorChooser/Test6348456.java line 45:

> 43: 
> 44:     private static final DefaultColorSelectionModel WHITE = new DefaultColorSelectionModel(Color.WHITE);
> 45:     private static final DefaultColorSelectionModel BLACK = new DefaultColorSelectionModel(Color.BLACK);

Please fix line-lengths.

test/jdk/javax/swing/JColorChooser/Test6348456.java line 66:

> 64: 
> 65:     public static JFrame test() {
> 66:         JFrame frame = new JFrame("temp");

@alisenchung JFrame title can be changed to more appropriate name.

-------------

PR Review: https://git.openjdk.org/jdk/pull/18359#pullrequestreview-1953779270
PR Review Comment: https://git.openjdk.org/jdk/pull/18359#discussion_r1534930688
PR Review Comment: https://git.openjdk.org/jdk/pull/18359#discussion_r1534931780

From honkar at openjdk.org  Fri Mar 22 01:52:25 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Fri, 22 Mar 2024 01:52:25 GMT
Subject: RFR: 8328555: hidpi problems for test
 java/awt/Dialog/DialogAnotherThread/JaWSTest.java
In-Reply-To: <gYkodvmu9blcvd-abDi1RhmY0B4r-xM2SFmVcjpJMgM=.f278f787-074b-4a27-8b39-2509a7f2940b@github.com>
References: <gYkodvmu9blcvd-abDi1RhmY0B4r-xM2SFmVcjpJMgM=.f278f787-074b-4a27-8b39-2509a7f2940b@github.com>
Message-ID: <r7BKE4Ypn6doFvY68vn2HOA4NwBmiULyu8xZuhDeMU8=.4e013e20-bdce-4a3a-8a41-be65bdb40cd0@github.com>

On Thu, 21 Mar 2024 19:10:40 GMT, Phil Race <prr at openjdk.org> wrote:

> This previously closed test is cleaned up, opened and fixed to work on hidpi at fractional scales.
> It has unrelated problems on macOS 14 and is problem listed there (as it was when it was a closed test).

Problemlist on macOS no longer required due to the updated test changes.

@prrace This test passes on macOS 14.2. Earlier the test was problemlisted on mac because the mouse click was not being triggered on the edge of Frame or buttons. Since you have changed the button click location for hidpi problems, as a side-effect it to passes on macOS. So problemlisting is not required on macOS.

Test log on macOS 14.2


Action Performed
Before First Modal
handler is started
Running
Before Hiding 1
Before Synchronized
After First Modal
In Synchronized
After Notify
Stop Running
Show Something
STATUS:Passed.

-------------

PR Review: https://git.openjdk.org/jdk/pull/18439#pullrequestreview-1953791542
PR Comment: https://git.openjdk.org/jdk/pull/18439#issuecomment-2014167250

From tr at openjdk.org  Fri Mar 22 03:24:32 2024
From: tr at openjdk.org (Tejesh R)
Date: Fri, 22 Mar 2024 03:24:32 GMT
Subject: Integrated: 8327840: Automate javax/swing/border/Test4129681.java
In-Reply-To: <BbQ2iwy01dkTxtQ9Aj7RhRkSxWm3pq3BEIlGIzlSTCk=.7bdaafe4-681a-4f03-8462-4ffa7dc99507@github.com>
References: <BbQ2iwy01dkTxtQ9Aj7RhRkSxWm3pq3BEIlGIzlSTCk=.7bdaafe4-681a-4f03-8462-4ffa7dc99507@github.com>
Message-ID: <-iusdBmfbEnwGjR2wiEUtkkY2dBh4Y6m-9YAE6Inu3M=.faa85a35-1df1-4114-83ed-06b3636b2ccb@github.com>

On Sat, 16 Mar 2024 07:43:18 GMT, Tejesh R <tr at openjdk.org> wrote:

> Automated the Test `javax/swing/border/Test4129681.java` from manual as suggested in JBS description.
> Verified in CI system and its Green. The test has been verified for Metal L&F and the same is set explicitly..

This pull request has now been integrated.

Changeset: 177b8a24
Author:    Tejesh R <tr at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/177b8a241c11782b302607c0068b15b38112e67c
Stats:     48 lines in 1 file changed: 15 ins; 5 del; 28 mod

8327840: Automate javax/swing/border/Test4129681.java

Reviewed-by: abhiscxk, prr

-------------

PR: https://git.openjdk.org/jdk/pull/18336

From abhiscxk at openjdk.org  Fri Mar 22 03:43:28 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Fri, 22 Mar 2024 03:43:28 GMT
Subject: Integrated: 8327980: Convert
 javax/swing/JToggleButton/4128979/bug4128979.java applet test to main
In-Reply-To: <lZHt9pYb75UtaIEtbB0paOkfqR5CUAc6tikhb9YAakU=.ff2adbed-1db2-490a-8747-66ac96d03657@github.com>
References: <lZHt9pYb75UtaIEtbB0paOkfqR5CUAc6tikhb9YAakU=.ff2adbed-1db2-490a-8747-66ac96d03657@github.com>
Message-ID: <_NZgQZU5TdBrssTV0vYVmPaozOkkw5MTljyNUGp05K0=.c1ec28f7-ae7b-4ab2-b89c-96a9b2ebeff3@github.com>

On Tue, 12 Mar 2024 12:49:06 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

> Conversion of manual applet test to main based using PassFailJFrame manual framework

This pull request has now been integrated.

Changeset: 256d48b1
Author:    Abhishek Kumar <abhiscxk at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/256d48b19694e86bb26d67ed56de8ac94a31f4ff
Stats:     333 lines in 3 files changed: 149 ins; 184 del; 0 mod

8327980: Convert javax/swing/JToggleButton/4128979/bug4128979.java applet test to main

Reviewed-by: honkar, tr

-------------

PR: https://git.openjdk.org/jdk/pull/18233

From jwaters at openjdk.org  Fri Mar 22 04:09:43 2024
From: jwaters at openjdk.org (Julian Waters)
Date: Fri, 22 Mar 2024 04:09:43 GMT
Subject: RFR: 8307160: Fix AWT/2D/A11Y to support the permissive- flag on
 the Microsoft Visual C compiler [v49]
In-Reply-To: <AzYAekHLwY_K386KelWcqVFxNjUytdTUhL80PYQ2Mjc=.808d5bf0-d33b-4cba-9f04-9f64b1b7819c@github.com>
References: <7piLRto5nNbhYYYfENCr5ecm4M2xNtMkjkE8XhrLLQ0=.8fd1ac3a-46f8-47a8-ae37-a4abbf7757d9@github.com>
 <yG7ympQmG-rP5X6IFYGcxQygtaA-xzNkPt59f6dUt1c=.176ac703-a8f9-4901-8cc4-f7580567786c@github.com>
 <Sa7q7l1nNcZeLvLpe7G_-8fvnhukSf8UZolZ3QIoVxc=.f864754a-b733-46e7-b215-e2fe9de32c80@github.com>
 <AzYAekHLwY_K386KelWcqVFxNjUytdTUhL80PYQ2Mjc=.808d5bf0-d33b-4cba-9f04-9f64b1b7819c@github.com>
Message-ID: <P93wHiBcVHvcvz68aGmSf4p1pXaKrRfknUeOwKM8Xsk=.fae63ee9-1ef4-4b21-986e-c30c0a74f4f0@github.com>

On Sun, 21 Jan 2024 19:50:16 GMT, Phil Race <prr at openjdk.org> wrote:

>> Fixed the formatting (at least in the marked cases), but am unsure what you mean by set directly?
>
>> Fixed the formatting (at least in the marked cases), but am unsure what you mean by set directly?
> 
> See my comment 
> "like in my recoded case above, we no longer need the "pData" var which was there only because that name
> is magically known to the macro."
> 
> so skip (and get rid of) the pData var and just set the target var directly

@prrace Sorry for the page, but as I mentioned above I don't see much of an advantage to removing pData, since it appears we still have to do the null check anyway even without it. I'm also not sure what the incorrect code you mentioned above is

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15096#issuecomment-2014317099

From kizune at openjdk.org  Fri Mar 22 05:15:38 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Fri, 22 Mar 2024 05:15:38 GMT
Subject: RFR: 8328382: Convert java/awt/FileDialog/FileDialogForPackages
 test to main [v3]
In-Reply-To: <9gStC1mcEgWDsQsLiOUD0PHZ1mgIEgaM3f_EAQokmv0=.7f9ce16a-2180-4dea-96af-bcbcf955eec7@github.com>
References: <9gStC1mcEgWDsQsLiOUD0PHZ1mgIEgaM3f_EAQokmv0=.7f9ce16a-2180-4dea-96af-bcbcf955eec7@github.com>
Message-ID: <IsxmZfG6pgke0OruF38Vtk2WRJQyZtNNEezMW82LTsI=.a7f0f433-cef2-4635-9dfd-e25b275422db@github.com>

> Convert test to a main based;
> Move test to an appropriate folder;
> Remove old files;

Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:

  Got rid of the test window, using OassFailJFrame instead;
  Made all variables local;
  Minor changes based on review comments;

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18360/files
  - new: https://git.openjdk.org/jdk/pull/18360/files/3e84d47a..4a000aee

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18360&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18360&range=01-02

  Stats: 26 lines in 1 file changed: 1 ins; 17 del; 8 mod
  Patch: https://git.openjdk.org/jdk/pull/18360.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18360/head:pull/18360

PR: https://git.openjdk.org/jdk/pull/18360

From kizune at openjdk.org  Fri Mar 22 05:15:38 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Fri, 22 Mar 2024 05:15:38 GMT
Subject: RFR: 8328382: Convert java/awt/FileDialog/FileDialogForPackages
 test to main [v2]
In-Reply-To: <lfKvy8T43y3shxodsU_B-Qf3ddV-OEQBNeJLZmPT24E=.658591cb-1916-459a-8adc-bb7137942068@github.com>
References: <9gStC1mcEgWDsQsLiOUD0PHZ1mgIEgaM3f_EAQokmv0=.7f9ce16a-2180-4dea-96af-bcbcf955eec7@github.com>
 <_ytFO979o9K4RS7fFO_JTQKBda1f-S-at-TBIiWeLhs=.f9467d54-2198-4f3d-a3bc-c90e3a36c2e4@github.com>
 <MKVedV-MEXVNNOh3Pwdvl1qF1EShs8k9R7cqVNHcKks=.98f16733-ed37-4689-85a2-d1077ad3b182@github.com>
 <lfKvy8T43y3shxodsU_B-Qf3ddV-OEQBNeJLZmPT24E=.658591cb-1916-459a-8adc-bb7137942068@github.com>
Message-ID: <oKD4qwGnKpSdPd8uBsEBZdct4qB75qVStNyc4rF2Ueg=.821ee4e5-e44a-4f50-bf80-5666d838f4e5@github.com>

On Thu, 21 Mar 2024 20:22:18 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>> test/jdk/java/awt/FileDialog/FileDialogForPackages.java line 59:
>> 
>>> 57:         frame.add(textScrollPane, BorderLayout.CENTER);
>>> 58: 
>>> 59:         fd = new FileDialog(new Frame(), "Open");
>> 
>> is there any need to mix Swing and AWT components in the test? I guess you can use the JFrame already created
>
> Actually you don't need the textOutput, with recent changes you can add `.logArea()` to the PassFailJFrame builder
> 
> https://github.com/openjdk/jdk/blob/master/test/jdk/java/awt/regtesthelpers/PassFailJFrame.java#L1200
> 
> and just use `PassFailJFrame.log()` wherever you need it.
> 
> So this method can be changed to return the a `JButton`, and use it with `splitUIBottom`/`splitUIRight` instead of testUI

Ok, using the PassFailJFrame logger.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18360#discussion_r1535060230

From kizune at openjdk.org  Fri Mar 22 05:15:38 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Fri, 22 Mar 2024 05:15:38 GMT
Subject: RFR: 8328382: Convert java/awt/FileDialog/FileDialogForPackages
 test to main [v2]
In-Reply-To: <MKVedV-MEXVNNOh3Pwdvl1qF1EShs8k9R7cqVNHcKks=.98f16733-ed37-4689-85a2-d1077ad3b182@github.com>
References: <9gStC1mcEgWDsQsLiOUD0PHZ1mgIEgaM3f_EAQokmv0=.7f9ce16a-2180-4dea-96af-bcbcf955eec7@github.com>
 <_ytFO979o9K4RS7fFO_JTQKBda1f-S-at-TBIiWeLhs=.f9467d54-2198-4f3d-a3bc-c90e3a36c2e4@github.com>
 <MKVedV-MEXVNNOh3Pwdvl1qF1EShs8k9R7cqVNHcKks=.98f16733-ed37-4689-85a2-d1077ad3b182@github.com>
Message-ID: <FNG4dr672wxSA9rXwK7-T4e7m3TSOsWhcsPboZ7HA2A=.ccbb179f-0f17-470d-a068-9904703fc51e@github.com>

On Thu, 21 Mar 2024 16:16:55 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Adding library and build clauses
>
> test/jdk/java/awt/FileDialog/FileDialogForPackages.java line 60:
> 
>> 58: 
>> 59:         fd = new FileDialog(new Frame(), "Open");
>> 60:         fd.setDirectory(APPLICATIONS_FOLDER);
> 
> guess APPLICATION_FOLDER can be made local

With Alexander's suggestion all variables could be made local. Fixing that.

> test/jdk/java/awt/FileDialog/FileDialogForPackages.java line 91:
> 
>> 89:                 .rows((int) instructions.lines().count() + 1)
>> 90:                 .columns(40)
>> 91:                 .testUI(FileDialogForPackages::initialize)
> 
> It seems the filedialog is obscuring the instruction and test window...I guess it will be good if you can use 
> position(PassFailJFrame.Position.TOP_LEFT_CORNER)

Unfortunately i can not reposition the test instructions dialog and i got rid of the test window so newly created filedialog will block the instructions. Not sure i can find a reliable way to avoid that.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18360#discussion_r1535059877
PR Review Comment: https://git.openjdk.org/jdk/pull/18360#discussion_r1535061055

From psadhukhan at openjdk.org  Fri Mar 22 06:18:22 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Fri, 22 Mar 2024 06:18:22 GMT
Subject: RFR: 8328382: Convert java/awt/FileDialog/FileDialogForPackages
 test to main [v3]
In-Reply-To: <IsxmZfG6pgke0OruF38Vtk2WRJQyZtNNEezMW82LTsI=.a7f0f433-cef2-4635-9dfd-e25b275422db@github.com>
References: <9gStC1mcEgWDsQsLiOUD0PHZ1mgIEgaM3f_EAQokmv0=.7f9ce16a-2180-4dea-96af-bcbcf955eec7@github.com>
 <IsxmZfG6pgke0OruF38Vtk2WRJQyZtNNEezMW82LTsI=.a7f0f433-cef2-4635-9dfd-e25b275422db@github.com>
Message-ID: <otL_GTBEa6YHs-janq5EMFIBtI7jpczmUCRhXwNHW6Y=.0e7b1684-0911-4a0a-9475-e0a5045cb4c9@github.com>

On Fri, 22 Mar 2024 05:15:38 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

>> Convert test to a main based;
>> Move test to an appropriate folder;
>> Remove old files;
>
> Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Got rid of the test window, using OassFailJFrame instead;
>   Made all variables local;
>   Minor changes based on review comments;

Marked as reviewed by psadhukhan (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18360#pullrequestreview-1954019349

From psadhukhan at openjdk.org  Fri Mar 22 07:16:22 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Fri, 22 Mar 2024 07:16:22 GMT
Subject: RFR: 8316324: Opensource five miscellaneous Swing tests
In-Reply-To: <2GNSvcn0o7_d4Gca1TkUmz3M2gTtjg2lF8guEq2V8Bs=.cd4c564a-b089-4a8e-b582-b778a73b0329@github.com>
References: <2GNSvcn0o7_d4Gca1TkUmz3M2gTtjg2lF8guEq2V8Bs=.cd4c564a-b089-4a8e-b582-b778a73b0329@github.com>
Message-ID: <7F76CExWTIR2A-yyd3q5McROglv7yv8Zb-6H9Juu8AQ=.cb569ed1-6a5c-45df-a66b-b2d6c1e67064@github.com>

On Thu, 21 Mar 2024 23:35:58 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

> Clean up and opensource five tests.

test/jdk/javax/swing/InputVerifier/bug4774166.java line 44:

> 42:  * @summary InputVerifier should be called after a window loses and then regains focus
> 43:  * @library /javax/swing/regtesthelpers
> 44:  * @build JRobot

I guess JRobot library dependancy is not needed unnecessarliy, could be achieved by normal Robot in this test..

test/jdk/javax/swing/JButton/4385611/bug4385611.java line 42:

> 40: public class bug4385611 {
> 41:     static JButton bt1, bt2;
> 42:     static final ImageIcon icon32x32 = new ImageIcon(bug4385611.class.getResource("red.gif"));

did you verify if we are allowed to keep this red.gif in open source as per the image license? Can we not create the Imageicon from a yellow32x32 bufferedimage?

test/jdk/javax/swing/plaf/motif/bug4150591.java line 40:

> 38: public class bug4150591 {
> 39:     public static void main(String[] args) {
> 40:         MotifInternalFrameTitlePane mtp = new MotifInternalFrameTitlePane(new JInternalFrame());

Is this test required to be added now with motif being deprecated?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18443#discussion_r1535128580
PR Review Comment: https://git.openjdk.org/jdk/pull/18443#discussion_r1535132200
PR Review Comment: https://git.openjdk.org/jdk/pull/18443#discussion_r1535140010

From tr at openjdk.org  Fri Mar 22 08:44:23 2024
From: tr at openjdk.org (Tejesh R)
Date: Fri, 22 Mar 2024 08:44:23 GMT
Subject: RFR: 8328670: Automate and open source few closed manual applet
 test [v2]
In-Reply-To: <j5__FjejqxuIVDaPT5I5mzBuQXhu3VO8FHxhKcqkGAo=.6c0d7f61-124b-4dc5-a2a5-f70e02905863@github.com>
References: <ekaFQm1J1iN3WflMPr1EjImabwkt3O6QIB733BF1Kss=.82bb6086-fe25-46f2-916f-67a458eb6f3f@github.com>
 <j5__FjejqxuIVDaPT5I5mzBuQXhu3VO8FHxhKcqkGAo=.6c0d7f61-124b-4dc5-a2a5-f70e02905863@github.com>
Message-ID: <KfE7vIKqvt6ccS2ZwHv9r7MwHK2f2yLTi0Co7PHjk24=.8c0a7010-59a4-47b6-a068-2c31c09b6224@github.com>

On Thu, 21 Mar 2024 17:36:40 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Few manual closed applet test converted to automated and open sourced.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove getContentPane usage

test/jdk/javax/swing/JInternalFrame/Ctrli.java line 75:

> 73:             robot.mousePress(InputEvent.BUTTON1_DOWN_MASK);
> 74:             robot.mouseRelease(InputEvent.BUTTON1_DOWN_MASK);
> 75:             robot.waitForIdle();

Only `robot.waitForIdle();` is sufficient ? Delay isn't required?

test/jdk/javax/swing/JInternalFrame/Ctrli.java line 86:

> 84:             if (!iPressed) {
> 85:                 throw new RuntimeException("Test failed: CTRL+I not pressed.");
> 86:             }

Console print mentioning "Test Passed" would bring some clarity about the test status I guess.

test/jdk/javax/swing/JInternalFrame/Ctrli.java line 129:

> 127:         frame.setSize(200, 200);
> 128:         frame.setLocationRelativeTo(null);
> 129:         frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);

`frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);` is not required I guess.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18428#discussion_r1535143315
PR Review Comment: https://git.openjdk.org/jdk/pull/18428#discussion_r1535145084
PR Review Comment: https://git.openjdk.org/jdk/pull/18428#discussion_r1535145669

From dnguyen at openjdk.org  Fri Mar 22 08:48:35 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Fri, 22 Mar 2024 08:48:35 GMT
Subject: RFR: 8328717: Convert
 javax/swing/JColorChooser/8065098/bug8065098.java applet test to main [v2]
In-Reply-To: <RanAaZIZfAccXF1EKCQ8VKfcUIs55TuaKo_h7ud9_G8=.34018b2a-e13f-41a7-b559-5d52986d9870@github.com>
References: <SZLE6sOQUNGW_tBIfu6MkZE7rxjp5HJGZih6X50rrpw=.231ba8d7-c9cb-4dc9-b27a-62060696d0a1@github.com>
 <RanAaZIZfAccXF1EKCQ8VKfcUIs55TuaKo_h7ud9_G8=.34018b2a-e13f-41a7-b559-5d52986d9870@github.com>
Message-ID: <hy-aHDO65ATuAvako_8x796MdEL1yk3qB-uYa135KcY=.581682f3-bd90-4d82-ac32-90aa0295b05f@github.com>

On Fri, 22 Mar 2024 01:23:40 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

> @DamonGuy Tested on macOS, JColorChooser DnD doesn't seem to work on it.

Same for me. Looks like it's not an issue with the test and rather a bug that hasn't been fixed yet. I found [JDK-8065647](https://bugs.openjdk.org/browse/JDK-8065647) which I think is related to this. Seems to be filed after the bugID for THIS test was resolved.

> test/jdk/javax/swing/JColorChooser/8065098/JColorChooserDnDTest.java line 37:
> 
>> 35: 
>> 36:     public static void main(String[] args) {
>> 37:         SwingUtilities.invokeLater(() -> {
> 
> Copyright year needs to be updated for this file

Updated. Thanks.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18436#issuecomment-2014625683
PR Review Comment: https://git.openjdk.org/jdk/pull/18436#discussion_r1535240116

From dnguyen at openjdk.org  Fri Mar 22 08:48:35 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Fri, 22 Mar 2024 08:48:35 GMT
Subject: RFR: 8328717: Convert
 javax/swing/JColorChooser/8065098/bug8065098.java applet test to main [v2]
In-Reply-To: <SZLE6sOQUNGW_tBIfu6MkZE7rxjp5HJGZih6X50rrpw=.231ba8d7-c9cb-4dc9-b27a-62060696d0a1@github.com>
References: <SZLE6sOQUNGW_tBIfu6MkZE7rxjp5HJGZih6X50rrpw=.231ba8d7-c9cb-4dc9-b27a-62060696d0a1@github.com>
Message-ID: <nPExjs6ScZjBLdFZU4O_5cr2QLR9YPAfoc5wajWmgYI=.eb0060bd-35e4-45a4-9cad-730ca56a3cfc@github.com>

> Convert javax/swing/JColorChooser/8065098/bug8065098.java applet test to main using PassFailJFrame for the instructions.

Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:

  Update copyright year

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18436/files
  - new: https://git.openjdk.org/jdk/pull/18436/files/a4ab31de..15c55986

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18436&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18436&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/18436.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18436/head:pull/18436

PR: https://git.openjdk.org/jdk/pull/18436

From abhiscxk at openjdk.org  Fri Mar 22 09:00:24 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Fri, 22 Mar 2024 09:00:24 GMT
Subject: RFR: 8328670: Automate and open source few closed manual applet
 test [v2]
In-Reply-To: <KfE7vIKqvt6ccS2ZwHv9r7MwHK2f2yLTi0Co7PHjk24=.8c0a7010-59a4-47b6-a068-2c31c09b6224@github.com>
References: <ekaFQm1J1iN3WflMPr1EjImabwkt3O6QIB733BF1Kss=.82bb6086-fe25-46f2-916f-67a458eb6f3f@github.com>
 <j5__FjejqxuIVDaPT5I5mzBuQXhu3VO8FHxhKcqkGAo=.6c0d7f61-124b-4dc5-a2a5-f70e02905863@github.com>
 <KfE7vIKqvt6ccS2ZwHv9r7MwHK2f2yLTi0Co7PHjk24=.8c0a7010-59a4-47b6-a068-2c31c09b6224@github.com>
Message-ID: <pun81gZ9PHtknnL04oiaX-vy2F5Hp-3hkkMZGHnigrU=.f102ebcd-e5bb-4128-8af4-7973c632141d@github.com>

On Fri, 22 Mar 2024 07:17:00 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove getContentPane usage
>
> test/jdk/javax/swing/JInternalFrame/Ctrli.java line 75:
> 
>> 73:             robot.mousePress(InputEvent.BUTTON1_DOWN_MASK);
>> 74:             robot.mouseRelease(InputEvent.BUTTON1_DOWN_MASK);
>> 75:             robot.waitForIdle();
> 
> Only `robot.waitForIdle();` is sufficient ? Delay isn't required?

No.

> test/jdk/javax/swing/JInternalFrame/Ctrli.java line 86:
> 
>> 84:             if (!iPressed) {
>> 85:                 throw new RuntimeException("Test failed: CTRL+I not pressed.");
>> 86:             }
> 
> Console print mentioning "Test Passed" would bring some clarity about the test status I guess.

Don't think so. Test is all about CTRL+I pressed, if it fails that means event is not triggered.

> test/jdk/javax/swing/JInternalFrame/Ctrli.java line 129:
> 
>> 127:         frame.setSize(200, 200);
>> 128:         frame.setLocationRelativeTo(null);
>> 129:         frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
> 
> `frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);` is not required I guess.

Since it is an automatic test, I guess it is required.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18428#discussion_r1535251059
PR Review Comment: https://git.openjdk.org/jdk/pull/18428#discussion_r1535252345
PR Review Comment: https://git.openjdk.org/jdk/pull/18428#discussion_r1535253676

From abhiscxk at openjdk.org  Fri Mar 22 09:01:38 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Fri, 22 Mar 2024 09:01:38 GMT
Subject: RFR: 8328484: Convert and Opensource few JFileChooser applet test to
 main
Message-ID: <GOUikyJEeBF4rucoH72R4g6E98KQb3hc2wXebucjl80=.3555e2aa-6868-4c68-ad61-2db3e7c951bf@github.com>

Few closed manual applet JFileChooser tests convereted to PassFailJFrame based manual test.

-------------

Commit messages:
 - Applet test conerted to main manual and open sourced

Changes: https://git.openjdk.org/jdk/pull/18447/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18447&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8328484
  Stats: 442 lines in 3 files changed: 442 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18447.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18447/head:pull/18447

PR: https://git.openjdk.org/jdk/pull/18447

From tr at openjdk.org  Fri Mar 22 09:15:21 2024
From: tr at openjdk.org (Tejesh R)
Date: Fri, 22 Mar 2024 09:15:21 GMT
Subject: RFR: 8328670: Automate and open source few closed manual applet
 test [v2]
In-Reply-To: <pun81gZ9PHtknnL04oiaX-vy2F5Hp-3hkkMZGHnigrU=.f102ebcd-e5bb-4128-8af4-7973c632141d@github.com>
References: <ekaFQm1J1iN3WflMPr1EjImabwkt3O6QIB733BF1Kss=.82bb6086-fe25-46f2-916f-67a458eb6f3f@github.com>
 <j5__FjejqxuIVDaPT5I5mzBuQXhu3VO8FHxhKcqkGAo=.6c0d7f61-124b-4dc5-a2a5-f70e02905863@github.com>
 <KfE7vIKqvt6ccS2ZwHv9r7MwHK2f2yLTi0Co7PHjk24=.8c0a7010-59a4-47b6-a068-2c31c09b6224@github.com>
 <pun81gZ9PHtknnL04oiaX-vy2F5Hp-3hkkMZGHnigrU=.f102ebcd-e5bb-4128-8af4-7973c632141d@github.com>
Message-ID: <nNsKP2WYZNx1rw0vZ5qIfBlGqZFOiVke4pmctZmqNL8=.f3487841-a50d-4970-8098-2d5382e6e563@github.com>

On Fri, 22 Mar 2024 08:56:49 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> test/jdk/javax/swing/JInternalFrame/Ctrli.java line 86:
>> 
>>> 84:             if (!iPressed) {
>>> 85:                 throw new RuntimeException("Test failed: CTRL+I not pressed.");
>>> 86:             }
>> 
>> Console print mentioning "Test Passed" would bring some clarity about the test status I guess.
>
> Don't think so. Test is all about CTRL+I pressed, if it fails that means event is not triggered.

Not for failure case, I meant for Pass case.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18428#discussion_r1535271317

From abhiscxk at openjdk.org  Fri Mar 22 09:28:24 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Fri, 22 Mar 2024 09:28:24 GMT
Subject: RFR: 8328670: Automate and open source few closed manual applet
 test [v2]
In-Reply-To: <nNsKP2WYZNx1rw0vZ5qIfBlGqZFOiVke4pmctZmqNL8=.f3487841-a50d-4970-8098-2d5382e6e563@github.com>
References: <ekaFQm1J1iN3WflMPr1EjImabwkt3O6QIB733BF1Kss=.82bb6086-fe25-46f2-916f-67a458eb6f3f@github.com>
 <j5__FjejqxuIVDaPT5I5mzBuQXhu3VO8FHxhKcqkGAo=.6c0d7f61-124b-4dc5-a2a5-f70e02905863@github.com>
 <KfE7vIKqvt6ccS2ZwHv9r7MwHK2f2yLTi0Co7PHjk24=.8c0a7010-59a4-47b6-a068-2c31c09b6224@github.com>
 <pun81gZ9PHtknnL04oiaX-vy2F5Hp-3hkkMZGHnigrU=.f102ebcd-e5bb-4128-8af4-7973c632141d@github.com>
 <nNsKP2WYZNx1rw0vZ5qIfBlGqZFOiVke4pmctZmqNL8=.f3487841-a50d-4970-8098-2d5382e6e563@github.com>
Message-ID: <6aokRH3GizRcfPlqUUNo53uPT7FSSMWS0Z-xIXUp09E=.5ef2fb37-5b47-423e-8c24-ac9de44d5a47@github.com>

On Fri, 22 Mar 2024 09:12:27 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Don't think so. Test is all about CTRL+I pressed, if it fails that means event is not triggered.
>
> Not for failure case, I meant for Pass case.

Anyways, Test passed will be recorded in jtr file.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18428#discussion_r1535287245

From tr at openjdk.org  Fri Mar 22 09:39:23 2024
From: tr at openjdk.org (Tejesh R)
Date: Fri, 22 Mar 2024 09:39:23 GMT
Subject: RFR: 8328670: Automate and open source few closed manual applet
 test [v2]
In-Reply-To: <j5__FjejqxuIVDaPT5I5mzBuQXhu3VO8FHxhKcqkGAo=.6c0d7f61-124b-4dc5-a2a5-f70e02905863@github.com>
References: <ekaFQm1J1iN3WflMPr1EjImabwkt3O6QIB733BF1Kss=.82bb6086-fe25-46f2-916f-67a458eb6f3f@github.com>
 <j5__FjejqxuIVDaPT5I5mzBuQXhu3VO8FHxhKcqkGAo=.6c0d7f61-124b-4dc5-a2a5-f70e02905863@github.com>
Message-ID: <rm9fF7-_OKwp-gQ-x-6otXC2bKZfZ1TQFZrCmM64gXY=.5677885f-ca3c-41d8-9972-efac1a1a9534@github.com>

On Thu, 21 Mar 2024 17:36:40 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Few manual closed applet test converted to automated and open sourced.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove getContentPane usage

Looks fine for me.

-------------

Marked as reviewed by tr (Committer).

PR Review: https://git.openjdk.org/jdk/pull/18428#pullrequestreview-1954354134

From abhiscxk at openjdk.org  Fri Mar 22 09:48:28 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Fri, 22 Mar 2024 09:48:28 GMT
Subject: Integrated: 8328670: Automate and open source few closed manual applet
 test
In-Reply-To: <ekaFQm1J1iN3WflMPr1EjImabwkt3O6QIB733BF1Kss=.82bb6086-fe25-46f2-916f-67a458eb6f3f@github.com>
References: <ekaFQm1J1iN3WflMPr1EjImabwkt3O6QIB733BF1Kss=.82bb6086-fe25-46f2-916f-67a458eb6f3f@github.com>
Message-ID: <OMNZUkAwhY9QVgaOveAF4lFOgelDVlqyEVO2H0ko4nM=.e6aabe6f-0477-4e03-8515-5347fb4f6c23@github.com>

On Thu, 21 Mar 2024 10:46:41 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

> Few manual closed applet test converted to automated and open sourced.

This pull request has now been integrated.

Changeset: 38e3cda4
Author:    Abhishek Kumar <abhiscxk at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/38e3cda4420ef921cc6e43cb18338ec18c12011f
Stats:     291 lines in 2 files changed: 291 ins; 0 del; 0 mod

8328670: Automate and open source few closed manual applet test

Reviewed-by: psadhukhan, tr

-------------

PR: https://git.openjdk.org/jdk/pull/18428

From tr at openjdk.org  Fri Mar 22 09:52:58 2024
From: tr at openjdk.org (Tejesh R)
Date: Fri, 22 Mar 2024 09:52:58 GMT
Subject: RFR: 8328482: Convert and Open source few manual applet test to main
 based
Message-ID: <aV9yYWUEsrakxmujJCq2LzFg5K6nyCV4aELge8c1oJo=.c9f2c13d-337f-4af3-8a38-551a7f0ba0c6@github.com>

Convert and open source these manual applet test to main based:
java/awt/Frame/MegaIconTest/MegaIconTest.html
java/awt/Frame/FrameMaximizedTest/FrameMaximizedTest.html
java/awt/Frame/FrameMinimizeTest/FrameMinimizeTest.html
java/awt/Frame/SizeMinimizedTest/SizeMinimizedTest.html

-------------

Commit messages:
 - Open source few Frame test

Changes: https://git.openjdk.org/jdk/pull/18448/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18448&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8328482
  Stats: 501 lines in 7 files changed: 501 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18448.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18448/head:pull/18448

PR: https://git.openjdk.org/jdk/pull/18448

From psadhukhan at openjdk.org  Fri Mar 22 10:00:30 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Fri, 22 Mar 2024 10:00:30 GMT
Subject: RFR: 8079786: [macosx] Test
 java/awt/Frame/DisposeParentGC/DisposeParentGC.java fails for Mac only
Message-ID: <V4kCCaNFvjkksOfHuAK5Dn1-oJdzkxTBnLwLEVdINnw=.9fa30373-f8e8-4656-9e52-775e2a3aeed1@github.com>

Test is now passing in mac..Several iterations of the test passed in CI system..link in JBS...deproblemlisted...

-------------

Commit messages:
 - 8079786: [macosx] Test java/awt/Frame/DisposeParentGC/DisposeParentGC.java fails for Mac only

Changes: https://git.openjdk.org/jdk/pull/18449/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18449&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8079786
  Stats: 21 lines in 2 files changed: 18 ins; 1 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/18449.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18449/head:pull/18449

PR: https://git.openjdk.org/jdk/pull/18449

From tr at openjdk.org  Fri Mar 22 10:02:49 2024
From: tr at openjdk.org (Tejesh R)
Date: Fri, 22 Mar 2024 10:02:49 GMT
Subject: RFR: 8328482: Convert and Open source few manual applet test to
 main based [v2]
In-Reply-To: <aV9yYWUEsrakxmujJCq2LzFg5K6nyCV4aELge8c1oJo=.c9f2c13d-337f-4af3-8a38-551a7f0ba0c6@github.com>
References: <aV9yYWUEsrakxmujJCq2LzFg5K6nyCV4aELge8c1oJo=.c9f2c13d-337f-4af3-8a38-551a7f0ba0c6@github.com>
Message-ID: <KfNyf2ktuwn4hIH_1Ve8RIhJTLtQqp7XH_EN7N-_JXY=.1eee2c10-fa2a-41eb-a40d-f9ac82759ac5@github.com>

> Convert and open source these manual applet test to main based:
> java/awt/Frame/MegaIconTest/MegaIconTest.html
> java/awt/Frame/FrameMaximizedTest/FrameMaximizedTest.html
> java/awt/Frame/FrameMinimizeTest/FrameMinimizeTest.html
> java/awt/Frame/SizeMinimizedTest/SizeMinimizedTest.html

Tejesh R has updated the pull request incrementally with one additional commit since the last revision:

  Updated regtesthelpers path

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18448/files
  - new: https://git.openjdk.org/jdk/pull/18448/files/f2a21554..433086cb

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18448&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18448&range=00-01

  Stats: 4 lines in 4 files changed: 0 ins; 0 del; 4 mod
  Patch: https://git.openjdk.org/jdk/pull/18448.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18448/head:pull/18448

PR: https://git.openjdk.org/jdk/pull/18448

From psadhukhan at openjdk.org  Fri Mar 22 10:08:21 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Fri, 22 Mar 2024 10:08:21 GMT
Subject: RFR: 8328484: Convert and Opensource few JFileChooser applet test
 to main
In-Reply-To: <GOUikyJEeBF4rucoH72R4g6E98KQb3hc2wXebucjl80=.3555e2aa-6868-4c68-ad61-2db3e7c951bf@github.com>
References: <GOUikyJEeBF4rucoH72R4g6E98KQb3hc2wXebucjl80=.3555e2aa-6868-4c68-ad61-2db3e7c951bf@github.com>
Message-ID: <0KBjwTucUSTG31qZyIKVuZnBg1DpQeWpaOym5IQ4qLc=.b721ca9e-8fbd-43f1-8e28-c8b3ca42fce8@github.com>

On Fri, 22 Mar 2024 08:55:26 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

> Few closed manual applet JFileChooser tests convereted to PassFailJFrame based manual test.

Marked as reviewed by psadhukhan (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18447#pullrequestreview-1954414137

From abhiscxk at openjdk.org  Fri Mar 22 10:22:24 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Fri, 22 Mar 2024 10:22:24 GMT
Subject: RFR: 8328482: Convert and Open source few manual applet test to
 main based [v2]
In-Reply-To: <KfNyf2ktuwn4hIH_1Ve8RIhJTLtQqp7XH_EN7N-_JXY=.1eee2c10-fa2a-41eb-a40d-f9ac82759ac5@github.com>
References: <aV9yYWUEsrakxmujJCq2LzFg5K6nyCV4aELge8c1oJo=.c9f2c13d-337f-4af3-8a38-551a7f0ba0c6@github.com>
 <KfNyf2ktuwn4hIH_1Ve8RIhJTLtQqp7XH_EN7N-_JXY=.1eee2c10-fa2a-41eb-a40d-f9ac82759ac5@github.com>
Message-ID: <LLOalRfYQFiWqT389wqzoqlrHVh6WgBmAtxKv5sBFrE=.e906aa50-a1f2-4b10-9e25-2fd631f863c0@github.com>

On Fri, 22 Mar 2024 10:02:49 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Convert and open source these manual applet test to main based:
>> java/awt/Frame/MegaIconTest/MegaIconTest.html
>> java/awt/Frame/FrameMaximizedTest/FrameMaximizedTest.html
>> java/awt/Frame/FrameMinimizeTest/FrameMinimizeTest.html
>> java/awt/Frame/SizeMinimizedTest/SizeMinimizedTest.html
>
> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Updated regtesthelpers path

test/jdk/java/awt/Frame/FrameMaximizedTest.java line 30:

> 28:  * @test
> 29:  * @bug 4106068
> 30:  * @key headful

`@key headful` is redundant since manual test needs someone to verify. You can remove here and in other tests as well.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18448#discussion_r1535356393

From psadhukhan at openjdk.org  Fri Mar 22 10:28:28 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Fri, 22 Mar 2024 10:28:28 GMT
Subject: Integrated: 8328673: Convert closed text/html/CSS manual applet test
 to main
In-Reply-To: <RUcdacOwzVskVmCK0_t8P42j-h9BEtAsuZqgKvM7uuc=.3ffd2bf8-a98b-46ef-8608-31142321e464@github.com>
References: <RUcdacOwzVskVmCK0_t8P42j-h9BEtAsuZqgKvM7uuc=.3ffd2bf8-a98b-46ef-8608-31142321e464@github.com>
Message-ID: <RgJZJNhbcpL95xGXMd3EluCQFolm2izXvzvlaOtRDgo=.0c40d492-4cc5-472a-ac42-667c200065c0@github.com>

On Thu, 21 Mar 2024 09:04:19 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> Couple closed manual applet text/html/CSS tests are converted to main based and opensourced

This pull request has now been integrated.

Changeset: cd534f81
Author:    Prasanta Sadhukhan <psadhukhan at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/cd534f8197341fbe3b3811f5be43c88090e16366
Stats:     161 lines in 2 files changed: 161 ins; 0 del; 0 mod

8328673: Convert closed text/html/CSS manual applet test to main

Reviewed-by: abhiscxk, aivanov

-------------

PR: https://git.openjdk.org/jdk/pull/18424

From abhiscxk at openjdk.org  Fri Mar 22 10:47:23 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Fri, 22 Mar 2024 10:47:23 GMT
Subject: RFR: 8079786: [macosx] Test
 java/awt/Frame/DisposeParentGC/DisposeParentGC.java fails for Mac only
In-Reply-To: <V4kCCaNFvjkksOfHuAK5Dn1-oJdzkxTBnLwLEVdINnw=.9fa30373-f8e8-4656-9e52-775e2a3aeed1@github.com>
References: <V4kCCaNFvjkksOfHuAK5Dn1-oJdzkxTBnLwLEVdINnw=.9fa30373-f8e8-4656-9e52-775e2a3aeed1@github.com>
Message-ID: <yTwEV_CPs2eJ2xNHgzxHSfDwYvuq-QzQBqI-QLoMNrM=.5bf08f87-36f6-4f23-8b65-57783d531e85@github.com>

On Fri, 22 Mar 2024 09:55:46 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> Test is now passing in mac..Several iterations of the test passed in CI system..link in JBS...deproblemlisted...

test/jdk/java/awt/Frame/DisposeParentGC/DisposeParentGC.java line 1:

> 1: /*

Since these lines are unchanged, I couldn't add comments there.

So, few suggestions:
1. @author tag can be removed.
2. You may fix spacing issues as well like
    TextArea textArea = new TextArea(5,5);
    Checkbox radioButton = new Checkbox("Hello" ,true, checkboxGroup);
    and other placess too.
3. Column limit exceeding.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18449#discussion_r1535388838

From jwaters at openjdk.org  Fri Mar 22 10:51:46 2024
From: jwaters at openjdk.org (Julian Waters)
Date: Fri, 22 Mar 2024 10:51:46 GMT
Subject: RFR: 8307160: Fix AWT/2D/A11Y to support the permissive- flag on
 the Microsoft Visual C compiler [v50]
In-Reply-To: <xuf6JToKZYgafEovpGhphLBEzENZYSYduo1HqkVDd78=.3b49e309-eb0e-4c25-9f35-e02f79c12374@github.com>
References: <7piLRto5nNbhYYYfENCr5ecm4M2xNtMkjkE8XhrLLQ0=.8fd1ac3a-46f8-47a8-ae37-a4abbf7757d9@github.com>
 <oMTWDHUD8wvoaxiISrGY1ijZecfyRw2GoMN_lIENT6U=.69c833b2-1210-41ad-b08b-4775ab662243@github.com>
 <xuf6JToKZYgafEovpGhphLBEzENZYSYduo1HqkVDd78=.3b49e309-eb0e-4c25-9f35-e02f79c12374@github.com>
Message-ID: <eFpwWPe8PHlgZ3a42N8DqjuYdxeBOpOAVv650NTOy9Y=.26a9110c-ffb0-43e4-9fd2-ba042c5757c7@github.com>

On Mon, 18 Mar 2024 15:55:15 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> Julian Waters has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 84 commits:
>> 
>>  - Merge branch 'openjdk:master' into patch-10
>>  - awt_Window.cpp
>>  - awt_Frame.cpp
>>  - awt_Component.cpp
>>  - awt_Canvas.cpp
>>  - Merge branch 'openjdk:master' into patch-10
>>  - Merge branch 'openjdk:master' into patch-10
>>  - Fix awt_Window.cpp
>>  - Fix awt_PrintJob.cpp
>>  - -Zc:stringStrings no longer needed with -permissive- flags-cflags.m4
>>  - ... and 74 more: https://git.openjdk.org/jdk/compare/a474b372...0f34608b
>
> bot-keep-alive
> 
> @TheShermanTanker Did you understand the remaining changes that Phil has requested? Do you think you'll be able to fix this?

@magicus  Phil doesn't seem to be responding to my queries, I'm not too sure what to do at this point

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15096#issuecomment-2014826062

From tr at openjdk.org  Fri Mar 22 11:05:21 2024
From: tr at openjdk.org (Tejesh R)
Date: Fri, 22 Mar 2024 11:05:21 GMT
Subject: RFR: 8328484: Convert and Opensource few JFileChooser applet test
 to main
In-Reply-To: <GOUikyJEeBF4rucoH72R4g6E98KQb3hc2wXebucjl80=.3555e2aa-6868-4c68-ad61-2db3e7c951bf@github.com>
References: <GOUikyJEeBF4rucoH72R4g6E98KQb3hc2wXebucjl80=.3555e2aa-6868-4c68-ad61-2db3e7c951bf@github.com>
Message-ID: <rfDHOe_r5rGqCuB7jDve1-AMgK9PUU78hHTtQJWyevI=.07416d28-d041-4c05-a4b1-354e02836891@github.com>

On Fri, 22 Mar 2024 08:55:26 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

> Few closed manual applet JFileChooser tests convereted to PassFailJFrame based manual test.

Looks good to me.

-------------

Marked as reviewed by tr (Committer).

PR Review: https://git.openjdk.org/jdk/pull/18447#pullrequestreview-1954522722

From abhiscxk at openjdk.org  Fri Mar 22 11:13:30 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Fri, 22 Mar 2024 11:13:30 GMT
Subject: Integrated: 8328484: Convert and Opensource few JFileChooser applet
 test to main
In-Reply-To: <GOUikyJEeBF4rucoH72R4g6E98KQb3hc2wXebucjl80=.3555e2aa-6868-4c68-ad61-2db3e7c951bf@github.com>
References: <GOUikyJEeBF4rucoH72R4g6E98KQb3hc2wXebucjl80=.3555e2aa-6868-4c68-ad61-2db3e7c951bf@github.com>
Message-ID: <JrDgJtW1zbpbZ0gYyEHA_W5wl8ZEOrad5bpEdgkR3fA=.8ab0675f-2d81-4b05-a751-88e707a3e837@github.com>

On Fri, 22 Mar 2024 08:55:26 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

> Few closed manual applet JFileChooser tests convereted to PassFailJFrame based manual test.

This pull request has now been integrated.

Changeset: 528efe20
Author:    Abhishek Kumar <abhiscxk at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/528efe206d5ee3775b01f3b90600ca3cab6c96f0
Stats:     442 lines in 3 files changed: 442 ins; 0 del; 0 mod

8328484: Convert and Opensource few JFileChooser applet test to main

Reviewed-by: psadhukhan, tr

-------------

PR: https://git.openjdk.org/jdk/pull/18447

From tr at openjdk.org  Fri Mar 22 11:17:23 2024
From: tr at openjdk.org (Tejesh R)
Date: Fri, 22 Mar 2024 11:17:23 GMT
Subject: RFR: 8316324: Opensource five miscellaneous Swing tests
In-Reply-To: <2GNSvcn0o7_d4Gca1TkUmz3M2gTtjg2lF8guEq2V8Bs=.cd4c564a-b089-4a8e-b582-b778a73b0329@github.com>
References: <2GNSvcn0o7_d4Gca1TkUmz3M2gTtjg2lF8guEq2V8Bs=.cd4c564a-b089-4a8e-b582-b778a73b0329@github.com>
Message-ID: <sHsW7LXGy912f6z8g0PFOf9YXAbbWkbPSxTPuLvxGsY=.6fac48ce-4b77-4f1f-91d7-be87d2967eda@github.com>

On Thu, 21 Mar 2024 23:35:58 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

> Clean up and opensource five tests.

test/jdk/javax/swing/InputVerifier/bug4774166.java line 144:

> 142:     public void performTest() throws InterruptedException, InvocationTargetException {
> 143:         robot.setAutoDelay(100);
> 144:         robot.delay(2000);

After setting auto delay, I don't think delay is required here?

test/jdk/javax/swing/InputVerifier/bug4774166.java line 165:

> 163:         robot.hitKey(KeyEvent.VK_M);
> 164:         robot.hitKey(KeyEvent.VK_N);
> 165:         robot.hitKey(KeyEvent.VK_O);

WaitForIdle might be used in between a set of key events.......

test/jdk/javax/swing/InputVerifier/bug4774166.java line 229:

> 227:     public void cleanupGUI() {
> 228:         if (testframe != null) {
> 229:             testframe.setVisible(false);

`testframe.setVisible(false);` is required here? Any advantage for setting the visibility to false ? anyhow its been disposed.....

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18443#discussion_r1535257899
PR Review Comment: https://git.openjdk.org/jdk/pull/18443#discussion_r1535261674
PR Review Comment: https://git.openjdk.org/jdk/pull/18443#discussion_r1535249268

From tr at openjdk.org  Fri Mar 22 11:28:21 2024
From: tr at openjdk.org (Tejesh R)
Date: Fri, 22 Mar 2024 11:28:21 GMT
Subject: RFR: 8328717: Convert
 javax/swing/JColorChooser/8065098/bug8065098.java applet test to main [v2]
In-Reply-To: <nPExjs6ScZjBLdFZU4O_5cr2QLR9YPAfoc5wajWmgYI=.eb0060bd-35e4-45a4-9cad-730ca56a3cfc@github.com>
References: <SZLE6sOQUNGW_tBIfu6MkZE7rxjp5HJGZih6X50rrpw=.231ba8d7-c9cb-4dc9-b27a-62060696d0a1@github.com>
 <nPExjs6ScZjBLdFZU4O_5cr2QLR9YPAfoc5wajWmgYI=.eb0060bd-35e4-45a4-9cad-730ca56a3cfc@github.com>
Message-ID: <GzKDNnM9EiXsyGvWVTSsu7Y6OPEpTsfPB9ZSoZa1_sA=.910b4433-13a6-4ac3-b555-ecd23e2eb802@github.com>

On Fri, 22 Mar 2024 08:48:35 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

>> Convert javax/swing/JColorChooser/8065098/bug8065098.java applet test to main using PassFailJFrame for the instructions.
>
> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update copyright year

test/jdk/javax/swing/JColorChooser/8065098/JColorChooserDnDTest.java line 47:

> 45:             frame.setContentPane(panel);
> 46:             frame.pack();
> 47:             frame.setVisible(true);

frame dispose is not required?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18436#discussion_r1535429569

From ihse at openjdk.org  Fri Mar 22 12:31:46 2024
From: ihse at openjdk.org (Magnus Ihse Bursie)
Date: Fri, 22 Mar 2024 12:31:46 GMT
Subject: RFR: 8307160: Fix AWT/2D/A11Y to support the permissive- flag on
 the Microsoft Visual C compiler [v52]
In-Reply-To: <0p1UVaUOt2bs1mkuBV1liUxBYGRhnKnclf1x_-Y22GE=.2de6c2c4-8cf5-470d-bdb3-cd0dd0e13975@github.com>
References: <7piLRto5nNbhYYYfENCr5ecm4M2xNtMkjkE8XhrLLQ0=.8fd1ac3a-46f8-47a8-ae37-a4abbf7757d9@github.com>
 <0p1UVaUOt2bs1mkuBV1liUxBYGRhnKnclf1x_-Y22GE=.2de6c2c4-8cf5-470d-bdb3-cd0dd0e13975@github.com>
Message-ID: <6_80radA3v1Fq_kuf_4GZ74gfwc8hgMPOyBczHItlKc=.9a2463ef-c106-42c4-b0a8-12f94568ea96@github.com>

On Wed, 20 Mar 2024 06:38:59 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> We should set the -permissive- flag for the Microsoft Visual C compiler, as was requested by the now backed out [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). Doing so makes the Visual C compiler much less accepting of ill formed code, which will improve code quality on Windows in the future.
>
> Julian Waters has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Revert Formatting in awt_Component.cpp
>  - Revert Formatting in awt_Window.cpp

src/java.desktop/windows/native/libawt/windows/awt_DnDDS.cpp line 44:

> 42: #include <shlobj.h>
> 43: 
> 44: // Don't want to pull in the redefined allocation functions

Maybe this needs to be clarified a bit:

Suggestion:

// These files must be included before awt.h, since the latter redefines malloc 
// to Do_Not_Use_Malloc, etc, and that will break these files.


Also, please mark conversations as resolved in the GitHub UI once you think they are addressed. That makes it much easier for reviewers to understand what parts of the reviews that have not been addressed.

src/java.desktop/windows/native/libawt/windows/awt_DnDDT.cpp line 31:

> 29: 
> 30: // Don't want to pull in the redefined allocation functions
> 31: #include "awt_ole.h"

Suggestion:

// awt_ole.h must be included before awt.h, since the latter redefines malloc 
// to Do_Not_Use_Malloc, etc, and that will break awt_ole.h.
#include "awt_ole.h"

src/java.desktop/windows/native/libawt/windows/awt_PrintJob.cpp line 544:

> 542:       and for all other dialogs AwtToolkit's HWND is used.
> 543:     */
> 544:     else if (awtParent != NULL) {

Suggestion:

    else if (awtParent != NULL)
    {

src/java.desktop/windows/native/libawt/windows/awt_PrintJob.cpp line 546:

> 544:     else if (awtParent != NULL) {
> 545:         setup.hwndOwner = AwtToolkit::GetInstance().GetHWnd();
> 546:     } else {

Suggestion:

    }
    else
    {

src/java.desktop/windows/native/libawt/windows/awt_PrintJob.cpp line 779:

> 777:     }
> 778: 
> 779: 

Suggestion:

src/java.desktop/windows/native/libawt/windows/awt_PrintJob.cpp line 1230:

> 1228:     jdouble imgY = (jdouble) ((yPixelOrg * 72)/(jdouble) yPixelRes);
> 1229:     jdouble imgWid = (jdouble) ((imgPixelWid * 72)/(jdouble) xPixelRes);
> 1230:     jdouble imgHgt = (jdouble) ((imgPixelHgt * 72)/(jdouble) yPixelRes);

Suggestion:

    jdouble imgX = (jdouble)((xPixelOrg * 72)/(jdouble)xPixelRes);
    jdouble imgY = (jdouble)((yPixelOrg * 72)/(jdouble)yPixelRes);
    jdouble imgWid = (jdouble)((imgPixelWid * 72)/(jdouble)xPixelRes);
    jdouble imgHgt = (jdouble)((imgPixelHgt * 72)/(jdouble)yPixelRes);```

src/java.desktop/windows/native/libawt/windows/awt_PrintJob.cpp line 1316:

> 1314:     env->CallVoidMethod(newPaper, setImageableID, ix, iy, iw, ih);
> 1315: 
> 1316: 

Suggestion:

src/java.desktop/windows/native/libawt/windows/awt_Window.cpp line 3153:

> 3151:     }
> 3152: 
> 3153:     window = (AwtWindow *) pData;

Suggestion:

    window = (AwtWindow *)pData;

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15096#discussion_r1535490288
PR Review Comment: https://git.openjdk.org/jdk/pull/15096#discussion_r1535491034
PR Review Comment: https://git.openjdk.org/jdk/pull/15096#discussion_r1535493157
PR Review Comment: https://git.openjdk.org/jdk/pull/15096#discussion_r1535493362
PR Review Comment: https://git.openjdk.org/jdk/pull/15096#discussion_r1535493818
PR Review Comment: https://git.openjdk.org/jdk/pull/15096#discussion_r1535494973
PR Review Comment: https://git.openjdk.org/jdk/pull/15096#discussion_r1535495291
PR Review Comment: https://git.openjdk.org/jdk/pull/15096#discussion_r1535496714

From ihse at openjdk.org  Fri Mar 22 12:31:48 2024
From: ihse at openjdk.org (Magnus Ihse Bursie)
Date: Fri, 22 Mar 2024 12:31:48 GMT
Subject: RFR: 8307160: Fix AWT/2D/A11Y to support the permissive- flag on
 the Microsoft Visual C compiler [v46]
In-Reply-To: <QfIBrG8rqxy__rPSCMddlNATjmEEr4ccSoZyjFckjUg=.b7f6fffb-2cf9-4c54-a35c-b01f5fd654de@github.com>
References: <7piLRto5nNbhYYYfENCr5ecm4M2xNtMkjkE8XhrLLQ0=.8fd1ac3a-46f8-47a8-ae37-a4abbf7757d9@github.com>
 <5WJnl6Z9RyYzZrDStf9p74gus07Stz6S6NHwVpGQO3M=.0a04a120-77b5-48c3-9ae8-7d37c9646463@github.com>
 <QfIBrG8rqxy__rPSCMddlNATjmEEr4ccSoZyjFckjUg=.b7f6fffb-2cf9-4c54-a35c-b01f5fd654de@github.com>
Message-ID: <chGlG9SxdB-09Ovuax1y4-e68MjWBfIOJPPhNRMlkfQ=.7d303b52-024e-49ef-bbb6-cd44664ab916@github.com>

On Sat, 20 Jan 2024 00:32:19 GMT, Phil Race <prr at openjdk.org> wrote:

>> Julian Waters has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 79 commits:
>> 
>>  - Merge branch 'openjdk:master' into patch-10
>>  - Merge branch 'openjdk:master' into patch-10
>>  - Fix awt_Window.cpp
>>  - Fix awt_PrintJob.cpp
>>  - -Zc:stringStrings no longer needed with -permissive- flags-cflags.m4
>>  - Fix awt_Window.cpp
>>  - awt_Window.cpp
>>  - awt_PrintJob.cpp
>>  - awt_Frame.cpp
>>  - Whitespace awt_Component.cpp
>>  - ... and 69 more: https://git.openjdk.org/jdk/compare/35e96627...cbfbaee6
>
> src/java.desktop/windows/native/libawt/windows/awt_Frame.cpp line 1365:
> 
>> 1363:     f = (AwtFrame *) pData;
>> 1364:     HWND hwnd = f->GetHWnd();
>> 1365:     if (::IsWindow(hwnd)) {
> 
> more formatting to revert

Suggestion:

    if (::IsWindow(hwnd))
    {

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15096#discussion_r1535491578

From ihse at openjdk.org  Fri Mar 22 12:31:48 2024
From: ihse at openjdk.org (Magnus Ihse Bursie)
Date: Fri, 22 Mar 2024 12:31:48 GMT
Subject: RFR: 8307160: Fix AWT/2D/A11Y to support the permissive- flag on
 the Microsoft Visual C compiler [v2]
In-Reply-To: <LyfvKYTuJEv6MCr_gzarHNY--UASikJ5Kp_ShrIYzo8=.e5b6af37-2e44-49eb-b467-d1d856f5e093@github.com>
References: <7piLRto5nNbhYYYfENCr5ecm4M2xNtMkjkE8XhrLLQ0=.8fd1ac3a-46f8-47a8-ae37-a4abbf7757d9@github.com>
 <Qe5ihlyAofq8xiGUpBxmzNMwWzSxt7IkDq3rIteHXQA=.6742f48e-520e-476f-86c6-78d92b506ed0@github.com>
 <lJ7Sto8zCC9U4HpUlaEAuZL983Q5cR23FK9jkhc6Bkw=.4f76d268-3f91-458d-903f-6e52f6edcc1c@github.com>
 <LyfvKYTuJEv6MCr_gzarHNY--UASikJ5Kp_ShrIYzo8=.e5b6af37-2e44-49eb-b467-d1d856f5e093@github.com>
Message-ID: <4tTHUFo358_lNx_ovlvlPYhQ9UU8N1Nw1dUSCLjJknE=.a8156c5d-bd97-42ca-99e1-f9f4badf0478@github.com>

On Sun, 3 Dec 2023 15:37:47 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> src/java.desktop/windows/native/libawt/windows/awt_Frame.cpp line 1641:
>> 
>>> 1639:         }
>>> 1640:     }
>>> 1641: 
>> 
>> A possible improvement later (and for a future RFE) would be to use RAII for deletion and then get rid of the labels. awt is one of the few places that uses C++ for native code, so why not.
>
> Phil unfortunately rejected that approach, so we're on to a more manual way of deleting things here

The comment seems answered. Please resolve this discussion.

>> src/java.desktop/windows/native/libawt/windows/awt_TextComponent.cpp line 59:
>> 
>>> 57: AwtTextComponent::OleCallback AwtTextComponent::sm_oleCallback;
>>> 58: WNDPROC AwtTextComponent::sm_pDefWindowProc = NULL;
>>> 59: 
>> 
>> Did the compiler complain here? I'm fine with the change, just wanted to know the reason.
>
> the latter two are inside an extern "C" block, meaning their initial C++ linkage (by virtue of them being static class members) conflicts with the now C linkage, also the comment there states the AwtComponent fields are supposed to be set here, and I have no idea why this was not done, so I moved them all to be under that comment

The question seem answered. Please resolve the discussion.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15096#discussion_r1535492864
PR Review Comment: https://git.openjdk.org/jdk/pull/15096#discussion_r1535495754

From ihse at openjdk.org  Fri Mar 22 12:31:48 2024
From: ihse at openjdk.org (Magnus Ihse Bursie)
Date: Fri, 22 Mar 2024 12:31:48 GMT
Subject: RFR: 8307160: Fix AWT/2D/A11Y to support the permissive- flag on
 the Microsoft Visual C compiler [v14]
In-Reply-To: <cke6teC1E1HwnOHkxcNMpN17Q3UpD2GJ5hmy7QAtnUc=.1b681083-648c-4cda-b174-90f38baf5cc3@github.com>
References: <7piLRto5nNbhYYYfENCr5ecm4M2xNtMkjkE8XhrLLQ0=.8fd1ac3a-46f8-47a8-ae37-a4abbf7757d9@github.com>
 <l2vCyhWOxveU_kNuceiPN73nvNCM1DfhpGwINZqhnQQ=.90a8f41f-6790-4dfa-81f8-cff790ddd287@github.com>
 <GrblBP1ZbYiw3ZODAAler6XywHqN7_cdAM73QhlRFq8=.19dc1ad9-262f-4080-9874-fdcac9265a2b@github.com>
 <cke6teC1E1HwnOHkxcNMpN17Q3UpD2GJ5hmy7QAtnUc=.1b681083-648c-4cda-b174-90f38baf5cc3@github.com>
Message-ID: <28cne7OXCM06eTFCSpVUdzAltFk2jI79xqI-vJPsNhg=.a6aa7530-d119-4fcb-8f4d-049e9b9e6283@github.com>

On Fri, 3 Nov 2023 02:39:26 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> src/java.desktop/windows/native/libawt/windows/awt_PrintJob.cpp line 61:
>> 
>>> 59: 
>>> 60: jfieldID AwtPrintDialog::pageID;
>>> 61: 
>> 
>> where and why did this come from ?
>
> This came from below, all I did was move it up and out of the extern "C" block. This cannot be inside extern "C" because it is a static class member and has permanent C++ name mangling

The question seems answered. Please resolve this discussion.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15096#discussion_r1535492715

From aivanov at openjdk.org  Fri Mar 22 12:35:28 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Fri, 22 Mar 2024 12:35:28 GMT
Subject: RFR: 8328301: Convert Applet test ManualHTMLDataFlavorTest.java to
 main program [v2]
In-Reply-To: <GeK2mX9_wCPugZIVBZOgWi07-G6cQyb1F4weGMCZC-o=.ff2f87b8-b92a-4ea3-ad52-8d626529c2cc@github.com>
References: <ezZp85g1cKWnR1M7apMh6bxP2_G6P9O5tN6DTSQEOU4=.951f4e5d-e956-4af8-b4f1-725c667224b5@github.com>
 <NAaMbxZuvr-8jiLmuz9OfmkR6bZjYzz8H47YLF0sVQ0=.a8e8bd06-e382-474d-97b5-205d2d9350e6@github.com>
 <ZeNQcwSthUfKB_pqRPlyPPN-3zfSqHgkitYLTNvnZa4=.fe9055b1-7626-4c2e-a9af-14fb55a313d3@github.com>
 <GeK2mX9_wCPugZIVBZOgWi07-G6cQyb1F4weGMCZC-o=.ff2f87b8-b92a-4ea3-ad52-8d626529c2cc@github.com>
Message-ID: <lMfDiuIN9bCPpS4ox-6xVedHuE9cflKCOuMjCb8gCVY=.763f5489-9371-43d5-b1e3-f70794003ff9@github.com>

On Thu, 21 Mar 2024 17:56:14 GMT, Phil Race <prr at openjdk.org> wrote:

>> test/jdk/java/awt/datatransfer/HTMLDataFlavors/ManualHTMLDataFlavorTest.java line 110:
>> 
>>> 108:             } catch (UnsupportedFlavorException | IOException e) {
>>> 109:                 e.printStackTrace();
>>> 110:             }
>> 
>> Should exception make the test fail?
>
> The author of the test didn't think so, this doesn't seem related to converting to a main program
> so I don't want to touch it.

I feel as if it were a common practice in the olden days? It's commonly seen in manual tests.

It's worth questioning whether the test should fail if an exception occurs? Likely it should unless the exception *is* expected.

Yeah, this adds up? However, coming back to it later will require even more time if it ever happens again especially if no issue to track it is submitted. Submitting an issue also requires time.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18334#discussion_r1535500404

From ihse at openjdk.org  Fri Mar 22 12:35:48 2024
From: ihse at openjdk.org (Magnus Ihse Bursie)
Date: Fri, 22 Mar 2024 12:35:48 GMT
Subject: RFR: 8307160: Fix AWT/2D/A11Y to support the permissive- flag on
 the Microsoft Visual C compiler [v46]
In-Reply-To: <QfIBrG8rqxy__rPSCMddlNATjmEEr4ccSoZyjFckjUg=.b7f6fffb-2cf9-4c54-a35c-b01f5fd654de@github.com>
References: <7piLRto5nNbhYYYfENCr5ecm4M2xNtMkjkE8XhrLLQ0=.8fd1ac3a-46f8-47a8-ae37-a4abbf7757d9@github.com>
 <5WJnl6Z9RyYzZrDStf9p74gus07Stz6S6NHwVpGQO3M=.0a04a120-77b5-48c3-9ae8-7d37c9646463@github.com>
 <QfIBrG8rqxy__rPSCMddlNATjmEEr4ccSoZyjFckjUg=.b7f6fffb-2cf9-4c54-a35c-b01f5fd654de@github.com>
Message-ID: <GS4kYhGp3Zr9ZOhoWYRbSF65VoFXSv4sHS3w6b4R8FY=.ed0917fb-fbcf-4b95-b267-ecd726434c17@github.com>

On Sat, 20 Jan 2024 00:40:40 GMT, Phil Race <prr at openjdk.org> wrote:

>> Julian Waters has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 79 commits:
>> 
>>  - Merge branch 'openjdk:master' into patch-10
>>  - Merge branch 'openjdk:master' into patch-10
>>  - Fix awt_Window.cpp
>>  - Fix awt_PrintJob.cpp
>>  - -Zc:stringStrings no longer needed with -permissive- flags-cflags.m4
>>  - Fix awt_Window.cpp
>>  - awt_Window.cpp
>>  - awt_PrintJob.cpp
>>  - awt_Frame.cpp
>>  - Whitespace awt_Component.cpp
>>  - ... and 69 more: https://git.openjdk.org/jdk/compare/35e96627...cbfbaee6
>
> src/java.desktop/windows/native/libawt/windows/awt_Window.cpp line 3308:
> 
>> 3306:         return;
>> 3307:     } else {
>> 3308:         pData = JNI_GET_PDATA(self);
> 
> set directly

@TheShermanTanker What this means is that you need to replace the line:

    PDATA pData;

above with:

 AwtWindow *window;

 
and remove 

    AwtWindow *window = (AwtWindow *)pData;

below, and then change all references to `pData` in this block to `window`.

The same changes needs to be done in all places where pData is references. This was a temporary variable that is no longer needed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15096#discussion_r1535500631

From ihse at openjdk.org  Fri Mar 22 12:39:44 2024
From: ihse at openjdk.org (Magnus Ihse Bursie)
Date: Fri, 22 Mar 2024 12:39:44 GMT
Subject: RFR: 8307160: Fix AWT/2D/A11Y to support the permissive- flag on
 the Microsoft Visual C compiler [v50]
In-Reply-To: <eFpwWPe8PHlgZ3a42N8DqjuYdxeBOpOAVv650NTOy9Y=.26a9110c-ffb0-43e4-9fd2-ba042c5757c7@github.com>
References: <7piLRto5nNbhYYYfENCr5ecm4M2xNtMkjkE8XhrLLQ0=.8fd1ac3a-46f8-47a8-ae37-a4abbf7757d9@github.com>
 <oMTWDHUD8wvoaxiISrGY1ijZecfyRw2GoMN_lIENT6U=.69c833b2-1210-41ad-b08b-4775ab662243@github.com>
 <xuf6JToKZYgafEovpGhphLBEzENZYSYduo1HqkVDd78=.3b49e309-eb0e-4c25-9f35-e02f79c12374@github.com>
 <eFpwWPe8PHlgZ3a42N8DqjuYdxeBOpOAVv650NTOy9Y=.26a9110c-ffb0-43e4-9fd2-ba042c5757c7@github.com>
Message-ID: <VVcQyPsc6b6Fa-Az-UhDAhTDWGEDZPH607fyMYhFgvs=.b81560f1-fdc3-401e-8ef0-2e02b07a0330@github.com>

On Fri, 22 Mar 2024 10:49:13 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> bot-keep-alive
>> 
>> @TheShermanTanker Did you understand the remaining changes that Phil has requested? Do you think you'll be able to fix this?
>
> @magicus  Phil doesn't seem to be responding to my queries, I'm not too sure what to do at this point

@TheShermanTanker Phil is a busy man. I've helped you out (hopefully!) by being more concrete about what you need to fix, and reminded you on fixes that you seemed to have missed. Also, please use the functionality to resolve conversations, it really helps to see what remains to be fixed. (In OpenJDK, the Github project is configured so only the owner of a PR can resolve conversations.)

Also, you can double check the PR yourself to see if you have introduced any changes in formatting that is not required by the change. Phil has made clear that he does not want any such changes in this PR, and you need to respect that.

Finally, Phil has left a few comments more that I have not touched upon, so this is not all that needs to be fixed. (I left them out because I too had a hard time understanding exactly what he meant.) But if you start with these, it will be easier to see what remains.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15096#issuecomment-2015000697

From azvegint at openjdk.org  Fri Mar 22 12:40:23 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Fri, 22 Mar 2024 12:40:23 GMT
Subject: RFR: 8328382: Convert java/awt/FileDialog/FileDialogForPackages
 test to main [v3]
In-Reply-To: <IsxmZfG6pgke0OruF38Vtk2WRJQyZtNNEezMW82LTsI=.a7f0f433-cef2-4635-9dfd-e25b275422db@github.com>
References: <9gStC1mcEgWDsQsLiOUD0PHZ1mgIEgaM3f_EAQokmv0=.7f9ce16a-2180-4dea-96af-bcbcf955eec7@github.com>
 <IsxmZfG6pgke0OruF38Vtk2WRJQyZtNNEezMW82LTsI=.a7f0f433-cef2-4635-9dfd-e25b275422db@github.com>
Message-ID: <fh46vMuNU6ELuw5qWr0lS9IGrop3yL4GrwQadqHItVY=.212ba260-399f-49cd-87eb-16f8b0437951@github.com>

On Fri, 22 Mar 2024 05:15:38 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

>> Convert test to a main based;
>> Move test to an appropriate folder;
>> Remove old files;
>
> Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Got rid of the test window, using OassFailJFrame instead;
>   Made all variables local;
>   Minor changes based on review comments;

Marked as reviewed by azvegint (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18360#pullrequestreview-1954685310

From azvegint at openjdk.org  Fri Mar 22 13:12:45 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Fri, 22 Mar 2024 13:12:45 GMT
Subject: RFR: 8328697: SubMenuShowTest and SwallowKeyEvents tests
 stabilization [v3]
In-Reply-To: <zcgN9263VAJS5lzQijzw4C2ERzeghOHSYVXCm9D5_5I=.908547bc-170b-49c3-a810-c5efb2d21b86@github.com>
References: <zcgN9263VAJS5lzQijzw4C2ERzeghOHSYVXCm9D5_5I=.908547bc-170b-49c3-a810-c5efb2d21b86@github.com>
Message-ID: <yCLOuFZ8BWzJePumXAbvVt5eN5lD7AmHE5JBl8b3rcs=.bb13190f-dbb0-4d5b-b945-aca699235b07@github.com>

> Two tests may fail intermittently on Wayland, the standard `waitForIdle` and `delay` fixes the issue.
> 
> Manual and CI testing looks good.

Alexander Zvegintsev has updated the pull request incrementally with one additional commit since the last revision:

  Add @requires (os.family != "windows") to SwallowKeyEvents

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18431/files
  - new: https://git.openjdk.org/jdk/pull/18431/files/3c18826e..d8aa6b1d

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18431&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18431&range=01-02

  Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18431.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18431/head:pull/18431

PR: https://git.openjdk.org/jdk/pull/18431

From azvegint at openjdk.org  Fri Mar 22 13:16:26 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Fri, 22 Mar 2024 13:16:26 GMT
Subject: Integrated: 8328697: SubMenuShowTest and SwallowKeyEvents tests
 stabilization
In-Reply-To: <zcgN9263VAJS5lzQijzw4C2ERzeghOHSYVXCm9D5_5I=.908547bc-170b-49c3-a810-c5efb2d21b86@github.com>
References: <zcgN9263VAJS5lzQijzw4C2ERzeghOHSYVXCm9D5_5I=.908547bc-170b-49c3-a810-c5efb2d21b86@github.com>
Message-ID: <9GWVRE7I2PrpNeAQMMoL1bZQa9_zeKFbH54jgsqalyU=.1bc553b7-b463-48be-b699-b81ac564c959@github.com>

On Thu, 21 Mar 2024 13:02:29 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

> Two tests may fail intermittently on Wayland, the standard `waitForIdle` and `delay` fixes the issue.
> 
> Manual and CI testing looks good.

This pull request has now been integrated.

Changeset: 638708ca
Author:    Alexander Zvegintsev <azvegint at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/638708cad8228f62caf633015973403164675560
Stats:     58 lines in 2 files changed: 29 ins; 27 del; 2 mod

8328697: SubMenuShowTest and SwallowKeyEvents tests stabilization

Reviewed-by: kizune

-------------

PR: https://git.openjdk.org/jdk/pull/18431

From aivanov at openjdk.org  Fri Mar 22 15:22:23 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Fri, 22 Mar 2024 15:22:23 GMT
Subject: RFR: JDK-8328190 : Convert AWTPanelSmoothWheel.html applet test to
 main [v8]
In-Reply-To: <ZLWbHjYWkT2QoPJVoKrpdOfLy_myoGI5x1UmXGuXmR0=.5d84f0f8-58d4-44e2-b223-c4c4685aadef@github.com>
References: <sn9qb9ctS_sr3isHbwcbMCYh2RQokz2ptsw0rGBRnJY=.955d7549-72c7-4a4f-8ac8-a5d6f122cf68@github.com>
 <ZLWbHjYWkT2QoPJVoKrpdOfLy_myoGI5x1UmXGuXmR0=.5d84f0f8-58d4-44e2-b223-c4c4685aadef@github.com>
Message-ID: <1Db3FojRF05GPHaoTnNQVhE1x33SAuQ5hr1QNseTbU0=.8a53c004-04d4-472f-8672-eb5e7cc0851c@github.com>

On Thu, 21 Mar 2024 19:53:48 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> This test is converted to main using PassFailJFrame. It verifies wheel rotation value for high-res mouse on windows.
>> 
>> The test requires the updated PassFailJFrame's logArea() feature added in this PR https://github.com/openjdk/jdk/pull/18319
>
> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   changed the forcePass logic, updated instructions

I somewhat dislike that the test completes too quickly when I use my mouse. Yes, you warn the tester the test is semi-automatic, yet I'd prefer giving the tester more time.

Technically, one event with `e.getWheelRotation() != 0` is enough, that's right. It just doesn't feel right?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18312#issuecomment-2015329423

From aivanov at openjdk.org  Fri Mar 22 15:35:25 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Fri, 22 Mar 2024 15:35:25 GMT
Subject: RFR: JDK-8328190 : Convert AWTPanelSmoothWheel.html applet test to
 main [v8]
In-Reply-To: <ZLWbHjYWkT2QoPJVoKrpdOfLy_myoGI5x1UmXGuXmR0=.5d84f0f8-58d4-44e2-b223-c4c4685aadef@github.com>
References: <sn9qb9ctS_sr3isHbwcbMCYh2RQokz2ptsw0rGBRnJY=.955d7549-72c7-4a4f-8ac8-a5d6f122cf68@github.com>
 <ZLWbHjYWkT2QoPJVoKrpdOfLy_myoGI5x1UmXGuXmR0=.5d84f0f8-58d4-44e2-b223-c4c4685aadef@github.com>
Message-ID: <t9TbkiA9jP8q_1i6DWj1aJguNF04TeZp71-OdnxltYU=.5bbbfd30-b0fc-4f50-880c-cab62ce80fff@github.com>

On Thu, 21 Mar 2024 19:53:48 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> This test is converted to main using PassFailJFrame. It verifies wheel rotation value for high-res mouse on windows.
>> 
>> The test requires the updated PassFailJFrame's logArea() feature added in this PR https://github.com/openjdk/jdk/pull/18319
>
> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   changed the forcePass logic, updated instructions

It looks good to me.

test/jdk/java/awt/event/MouseEvent/AWTPanelSmoothWheel.java line 52:

> 50:             <body>
> 51:             This test is relevant on platforms with high-resolution mouse wheel,
> 52:             please press PASS if this is not the case.<br> <br>

It may be worth mentioning that trackpad will suit too.

test/jdk/java/awt/event/MouseEvent/AWTPanelSmoothWheel.java line 68:

> 66:             an event where wheelRotation != 0 in the logs.<br> <br>
> 67: 
> 68:             Check if the test works OK when the mouse wheel is rotated very slow.<br> <br>

Suggestion:

            Check if the test works OK when the mouse wheel is rotated very slowly.<br> <br>

test/jdk/java/awt/event/MouseEvent/AWTPanelSmoothWheel.java line 69:

> 67: 
> 68:             Check if the test works OK when the mouse wheel is rotated very slow.<br> <br>
> 69:             This is a semi-automated test, if you are using a hi-res mouse and

I would move this paragraph above. At this moment, it's more important to say that the test will pass automatically than that the tester needs to look through the log of events. So, the sentence above could be removed altogether.

test/jdk/java/awt/event/MouseEvent/AWTPanelSmoothWheel.java line 74:

> 72: 
> 73:             <hr>
> 74:             PLEASE NOTE:

Suggestion:

            <b>Note:</b>

You have formatting options, bold text will stand out and it's usually easier to read than uppercase text.

test/jdk/java/awt/event/MouseEvent/AWTPanelSmoothWheel.java line 84:

> 82:                  and they are negative when scrolled down. </li>
> 83:             </ul>
> 84:             <br>

Suggestion:


May be removed.

test/jdk/java/awt/event/MouseEvent/AWTPanelSmoothWheel.java line 118:

> 116:                     PassFailJFrame.log(WARNING_MSG);
> 117:                     JOptionPane.showMessageDialog(frame, WARNING_MSG,
> 118:                             "WARNING", WARNING_MESSAGE);

Suggestion:

                            "WARNING", JOptionPane.WARNING_MESSAGE);

I suggest using `JOptionPane.WARNING_MESSAGE` explicitly: there's no confusion between `WARNING_MSG` and `WARNING_MESSAGE` then.

I'd use ?Warning? in its title case as opposed to uppercase, taking into account the message itself contains upper case warning.

-------------

Marked as reviewed by aivanov (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18312#pullrequestreview-1955102847
PR Review Comment: https://git.openjdk.org/jdk/pull/18312#discussion_r1535779263
PR Review Comment: https://git.openjdk.org/jdk/pull/18312#discussion_r1535766207
PR Review Comment: https://git.openjdk.org/jdk/pull/18312#discussion_r1535769619
PR Review Comment: https://git.openjdk.org/jdk/pull/18312#discussion_r1535770843
PR Review Comment: https://git.openjdk.org/jdk/pull/18312#discussion_r1535773725
PR Review Comment: https://git.openjdk.org/jdk/pull/18312#discussion_r1535777940

From kizune at openjdk.org  Fri Mar 22 15:43:42 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Fri, 22 Mar 2024 15:43:42 GMT
Subject: RFR: 8328384: Convert java/awt/FileDialog/FileDialogOpenDirTest
 test to main [v5]
In-Reply-To: <uRRE9Iw6m8G9T9H0FWEYnUoGgInL7vGgYMPBwP7jEVI=.cb6605a0-f79a-4903-b565-e5dc29d81df2@github.com>
References: <uRRE9Iw6m8G9T9H0FWEYnUoGgInL7vGgYMPBwP7jEVI=.cb6605a0-f79a-4903-b565-e5dc29d81df2@github.com>
Message-ID: <re_CjjMv7AetwIH9eMccBe9eWv341umrX74Gxmm_NWA=.47ffc0db-4ec6-4add-bae1-bd5547f558c0@github.com>

> Convert test to main manual;
> Move test to appropriate folder;
> Delete old files;

Alexander Zuev has updated the pull request incrementally with two additional commits since the last revision:

 - Moving toolkit checkto the beginning of the main method.
 - Update test/jdk/java/awt/FileDialog/FileDialogOpenDirTest.java
   
   Co-authored-by: Aleksandr Zvegintsev <77687766+azvegint at users.noreply.github.com>

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18361/files
  - new: https://git.openjdk.org/jdk/pull/18361/files/6dd4e7f9..849ae794

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18361&range=04
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18361&range=03-04

  Stats: 11 lines in 1 file changed: 5 ins; 5 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/18361.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18361/head:pull/18361

PR: https://git.openjdk.org/jdk/pull/18361

From kizune at openjdk.org  Fri Mar 22 15:43:43 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Fri, 22 Mar 2024 15:43:43 GMT
Subject: Integrated: 8328384: Convert java/awt/FileDialog/FileDialogOpenDirTest
 test to main
In-Reply-To: <uRRE9Iw6m8G9T9H0FWEYnUoGgInL7vGgYMPBwP7jEVI=.cb6605a0-f79a-4903-b565-e5dc29d81df2@github.com>
References: <uRRE9Iw6m8G9T9H0FWEYnUoGgInL7vGgYMPBwP7jEVI=.cb6605a0-f79a-4903-b565-e5dc29d81df2@github.com>
Message-ID: <M4KzSagCybnL976qUYVja5qC019ofjjj42ZCqNnoMyw=.a4a0e317-be94-4de4-b338-ed8539e3484d@github.com>

On Mon, 18 Mar 2024 20:45:03 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

> Convert test to main manual;
> Move test to appropriate folder;
> Delete old files;

This pull request has now been integrated.

Changeset: 739957ca
Author:    Alexander Zuev <kizune at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/739957ca1e3b9ac9131a68990178e92691744157
Stats:     361 lines in 3 files changed: 79 ins; 282 del; 0 mod

8328384: Convert java/awt/FileDialog/FileDialogOpenDirTest test to main

Reviewed-by: azvegint

-------------

PR: https://git.openjdk.org/jdk/pull/18361

From aivanov at openjdk.org  Fri Mar 22 15:44:22 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Fri, 22 Mar 2024 15:44:22 GMT
Subject: RFR: 8328555: hidpi problems for test
 java/awt/Dialog/DialogAnotherThread/JaWSTest.java
In-Reply-To: <gYkodvmu9blcvd-abDi1RhmY0B4r-xM2SFmVcjpJMgM=.f278f787-074b-4a27-8b39-2509a7f2940b@github.com>
References: <gYkodvmu9blcvd-abDi1RhmY0B4r-xM2SFmVcjpJMgM=.f278f787-074b-4a27-8b39-2509a7f2940b@github.com>
Message-ID: <FnoMCvZCEO3c2WuOCZYvVdIoKz4QBKQ-OdNIJRQiEFk=.3b34c455-9b46-46b4-a54d-6914d0ec6720@github.com>

On Thu, 21 Mar 2024 19:10:40 GMT, Phil Race <prr at openjdk.org> wrote:

> This previously closed test is cleaned up, opened and fixed to work on hidpi at fractional scales.
> It has unrelated problems on macOS 14 and is problem listed there (as it was when it was a closed test).

Looks good to me.

I agree with @honkar-jdk, the test passes on macOS 14.3.1 for me. The original test couldn't click the button, now that the mouse cursor is position at the centre of the button, robot clicks it and the test passes.

-------------

Marked as reviewed by aivanov (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18439#pullrequestreview-1955147526

From achung at openjdk.org  Fri Mar 22 15:44:35 2024
From: achung at openjdk.org (Alisen Chung)
Date: Fri, 22 Mar 2024 15:44:35 GMT
Subject: RFR: 8328819: Remove applet usage from JFileChooser tests bug6698013
Message-ID: <iLcbr4t_2UJ4muFqTIm1NMfahCdwMTpgprqHo8WHHW0=.29e91557-e4b0-4d9c-ba32-fb2ab49e5de9@github.com>

Removing applet usage from manual JFileChooser tests
The original test is failing (nothing shows up in the JFileChooser), but this change does replace the applet usage with PassFailJFrame

-------------

Commit messages:
 - init commit

Changes: https://git.openjdk.org/jdk/pull/18456/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18456&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8328819
  Stats: 70 lines in 2 files changed: 22 ins; 39 del; 9 mod
  Patch: https://git.openjdk.org/jdk/pull/18456.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18456/head:pull/18456

PR: https://git.openjdk.org/jdk/pull/18456

From aivanov at openjdk.org  Fri Mar 22 15:50:28 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Fri, 22 Mar 2024 15:50:28 GMT
Subject: RFR: 8328555: hidpi problems for test
 java/awt/Dialog/DialogAnotherThread/JaWSTest.java
In-Reply-To: <gYkodvmu9blcvd-abDi1RhmY0B4r-xM2SFmVcjpJMgM=.f278f787-074b-4a27-8b39-2509a7f2940b@github.com>
References: <gYkodvmu9blcvd-abDi1RhmY0B4r-xM2SFmVcjpJMgM=.f278f787-074b-4a27-8b39-2509a7f2940b@github.com>
Message-ID: <zNosi5k__g7RW2kIBlJU2-TudbxESMV-hy25uwTWIkw=.35172491-2ef9-4c7a-a0cb-9810c3d96af9@github.com>

On Thu, 21 Mar 2024 19:10:40 GMT, Phil Race <prr at openjdk.org> wrote:

> This previously closed test is cleaned up, opened and fixed to work on hidpi at fractional scales.
> It has unrelated problems on macOS 14 and is problem listed there (as it was when it was a closed test).

test/jdk/java/awt/Dialog/JaWSTest.java line 69:

> 67:                             buttonLocation.y + button.getHeight()/2);
> 68:             robot.mousePress(InputEvent.BUTTON1_DOWN_MASK);
> 69:             robot.mouseRelease(InputEvent.BUTTON1_DOWN_MASK);

I guess the click with Robot can be replaced with a programmatic click (wrapped into `invokeLater`). Yet `awt.Button` does not have a way to simulate a click, `JButton` has `doClick()` method.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18439#discussion_r1535801245

From aivanov at openjdk.org  Fri Mar 22 15:53:26 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Fri, 22 Mar 2024 15:53:26 GMT
Subject: RFR: 8328555: hidpi problems for test
 java/awt/Dialog/DialogAnotherThread/JaWSTest.java
In-Reply-To: <gYkodvmu9blcvd-abDi1RhmY0B4r-xM2SFmVcjpJMgM=.f278f787-074b-4a27-8b39-2509a7f2940b@github.com>
References: <gYkodvmu9blcvd-abDi1RhmY0B4r-xM2SFmVcjpJMgM=.f278f787-074b-4a27-8b39-2509a7f2940b@github.com>
Message-ID: <JXWF5Al766lEAVOJo6jLzYb02xl9FcTGoX3fEEQQ8aQ=.fbb0017d-d429-4411-adb7-1cf66cd35abb@github.com>

On Thu, 21 Mar 2024 19:10:40 GMT, Phil Race <prr at openjdk.org> wrote:

> This previously closed test is cleaned up, opened and fixed to work on hidpi at fractional scales.
> It has unrelated problems on macOS 14 and is problem listed there (as it was when it was a closed test).

test/jdk/java/awt/Dialog/JaWSTest.java line 70:

> 68:             robot.mousePress(InputEvent.BUTTON1_DOWN_MASK);
> 69:             robot.mouseRelease(InputEvent.BUTTON1_DOWN_MASK);
> 70:             if (!worker.dialogFinished.await(5, TimeUnit.SECONDS)) {

Suggestion:

            if (!dialogFinished.await(5, TimeUnit.SECONDS)) {

Since `dialogFinished` is static, it can be accessed directly, without the `worker` object.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18439#discussion_r1535805618

From kizune at openjdk.org  Fri Mar 22 15:55:29 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Fri, 22 Mar 2024 15:55:29 GMT
Subject: Integrated: 8328382: Convert java/awt/FileDialog/FileDialogForPackages
 test to main
In-Reply-To: <9gStC1mcEgWDsQsLiOUD0PHZ1mgIEgaM3f_EAQokmv0=.7f9ce16a-2180-4dea-96af-bcbcf955eec7@github.com>
References: <9gStC1mcEgWDsQsLiOUD0PHZ1mgIEgaM3f_EAQokmv0=.7f9ce16a-2180-4dea-96af-bcbcf955eec7@github.com>
Message-ID: <VldrZYeVxqYs7ktXhpja0e7xMy4rpdXcwhhCnYg0vuU=.92c232fb-324f-4e19-aed2-93b6b92e7136@github.com>

On Mon, 18 Mar 2024 20:36:53 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

> Convert test to a main based;
> Move test to an appropriate folder;
> Remove old files;

This pull request has now been integrated.

Changeset: b7a51dd0
Author:    Alexander Zuev <kizune at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/b7a51dd0e8d56a9673b2c802d69019c23d43cb76
Stats:     210 lines in 3 files changed: 79 ins; 131 del; 0 mod

8328382: Convert java/awt/FileDialog/FileDialogForPackages test to main

Reviewed-by: psadhukhan, azvegint

-------------

PR: https://git.openjdk.org/jdk/pull/18360

From psadhukhan at openjdk.org  Fri Mar 22 16:07:36 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Fri, 22 Mar 2024 16:07:36 GMT
Subject: RFR: 8079786: [macosx] Test
 java/awt/Frame/DisposeParentGC/DisposeParentGC.java fails for Mac only [v2]
In-Reply-To: <V4kCCaNFvjkksOfHuAK5Dn1-oJdzkxTBnLwLEVdINnw=.9fa30373-f8e8-4656-9e52-775e2a3aeed1@github.com>
References: <V4kCCaNFvjkksOfHuAK5Dn1-oJdzkxTBnLwLEVdINnw=.9fa30373-f8e8-4656-9e52-775e2a3aeed1@github.com>
Message-ID: <m8IHgmP98mvimCxhHeBY_PGPmNFgPWFrC2Kuz8tDvFY=.5fc3b08d-0233-4d72-a72c-5973f286b069@github.com>

> Test is now passing in mac..Several iterations of the test passed in CI system..link in JBS...deproblemlisted...

Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:

  spacing

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18449/files
  - new: https://git.openjdk.org/jdk/pull/18449/files/565915f4..429fded4

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18449&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18449&range=00-01

  Stats: 13 lines in 1 file changed: 4 ins; 1 del; 8 mod
  Patch: https://git.openjdk.org/jdk/pull/18449.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18449/head:pull/18449

PR: https://git.openjdk.org/jdk/pull/18449

From honkar at openjdk.org  Fri Mar 22 16:54:49 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Fri, 22 Mar 2024 16:54:49 GMT
Subject: RFR: JDK-8328190 : Convert AWTPanelSmoothWheel.html applet test to
 main [v9]
In-Reply-To: <sn9qb9ctS_sr3isHbwcbMCYh2RQokz2ptsw0rGBRnJY=.955d7549-72c7-4a4f-8ac8-a5d6f122cf68@github.com>
References: <sn9qb9ctS_sr3isHbwcbMCYh2RQokz2ptsw0rGBRnJY=.955d7549-72c7-4a4f-8ac8-a5d6f122cf68@github.com>
Message-ID: <HcWi12W3g_FVuGX20Va6x5axVJ8objoVT6WxGjF2Bgo=.217db879-a563-4ff0-8866-e02e40596be6@github.com>

> This test is converted to main using PassFailJFrame. It verifies wheel rotation value for high-res mouse on windows.
> 
> The test requires the updated PassFailJFrame's logArea() feature added in this PR https://github.com/openjdk/jdk/pull/18319

Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:

  Instructions updated

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18312/files
  - new: https://git.openjdk.org/jdk/pull/18312/files/ec673142..701e90a8

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18312&range=08
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18312&range=07-08

  Stats: 23 lines in 1 file changed: 7 ins; 8 del; 8 mod
  Patch: https://git.openjdk.org/jdk/pull/18312.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18312/head:pull/18312

PR: https://git.openjdk.org/jdk/pull/18312

From honkar at openjdk.org  Fri Mar 22 16:54:49 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Fri, 22 Mar 2024 16:54:49 GMT
Subject: RFR: JDK-8328190 : Convert AWTPanelSmoothWheel.html applet test to
 main [v8]
In-Reply-To: <t9TbkiA9jP8q_1i6DWj1aJguNF04TeZp71-OdnxltYU=.5bbbfd30-b0fc-4f50-880c-cab62ce80fff@github.com>
References: <sn9qb9ctS_sr3isHbwcbMCYh2RQokz2ptsw0rGBRnJY=.955d7549-72c7-4a4f-8ac8-a5d6f122cf68@github.com>
 <ZLWbHjYWkT2QoPJVoKrpdOfLy_myoGI5x1UmXGuXmR0=.5d84f0f8-58d4-44e2-b223-c4c4685aadef@github.com>
 <t9TbkiA9jP8q_1i6DWj1aJguNF04TeZp71-OdnxltYU=.5bbbfd30-b0fc-4f50-880c-cab62ce80fff@github.com>
Message-ID: <h8S9t_uFYmpszP791pqqrisGYX7WIgWEG9M-uF42ETo=.41c958f9-e565-4b37-b182-6c8d33122e6c@github.com>

On Fri, 22 Mar 2024 15:31:48 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   changed the forcePass logic, updated instructions
>
> test/jdk/java/awt/event/MouseEvent/AWTPanelSmoothWheel.java line 52:
> 
>> 50:             <body>
>> 51:             This test is relevant on platforms with high-resolution mouse wheel,
>> 52:             please press PASS if this is not the case.<br> <br>
> 
> It may be worth mentioning that trackpad will suit too.

Updated.

> test/jdk/java/awt/event/MouseEvent/AWTPanelSmoothWheel.java line 69:
> 
>> 67: 
>> 68:             Check if the test works OK when the mouse wheel is rotated very slow.<br> <br>
>> 69:             This is a semi-automated test, if you are using a hi-res mouse and
> 
> I would move this paragraph above. At this moment, it's more important to say that the test will pass automatically than that the tester needs to look through the log of events. So, the sentence above could be removed altogether.

Updated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18312#discussion_r1535891353
PR Review Comment: https://git.openjdk.org/jdk/pull/18312#discussion_r1535890462

From prr at openjdk.org  Fri Mar 22 17:20:41 2024
From: prr at openjdk.org (Phil Race)
Date: Fri, 22 Mar 2024 17:20:41 GMT
Subject: RFR: 8328555: hidpi problems for test
 java/awt/Dialog/DialogAnotherThread/JaWSTest.java [v2]
In-Reply-To: <gYkodvmu9blcvd-abDi1RhmY0B4r-xM2SFmVcjpJMgM=.f278f787-074b-4a27-8b39-2509a7f2940b@github.com>
References: <gYkodvmu9blcvd-abDi1RhmY0B4r-xM2SFmVcjpJMgM=.f278f787-074b-4a27-8b39-2509a7f2940b@github.com>
Message-ID: <FDePk7LGT0lAF6jftUMLmOFur4M3bmf4NWJXPZvTi3w=.3092f420-3069-440c-ada7-db3d292868ca@github.com>

> This previously closed test is cleaned up, opened and fixed to work on hidpi at fractional scales.
> It has unrelated problems on macOS 14 and is problem listed there (as it was when it was a closed test).

Phil Race has updated the pull request incrementally with one additional commit since the last revision:

  8328555

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18439/files
  - new: https://git.openjdk.org/jdk/pull/18439/files/5aaef6f8..434ea601

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18439&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18439&range=00-01

  Stats: 3 lines in 2 files changed: 0 ins; 1 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/18439.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18439/head:pull/18439

PR: https://git.openjdk.org/jdk/pull/18439

From aivanov at openjdk.org  Fri Mar 22 17:20:41 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Fri, 22 Mar 2024 17:20:41 GMT
Subject: RFR: 8328555: hidpi problems for test
 java/awt/Dialog/DialogAnotherThread/JaWSTest.java [v2]
In-Reply-To: <FDePk7LGT0lAF6jftUMLmOFur4M3bmf4NWJXPZvTi3w=.3092f420-3069-440c-ada7-db3d292868ca@github.com>
References: <gYkodvmu9blcvd-abDi1RhmY0B4r-xM2SFmVcjpJMgM=.f278f787-074b-4a27-8b39-2509a7f2940b@github.com>
 <FDePk7LGT0lAF6jftUMLmOFur4M3bmf4NWJXPZvTi3w=.3092f420-3069-440c-ada7-db3d292868ca@github.com>
Message-ID: <RLwiiDucLqOB2a1WjDUhcW39Hl9p9L0al-C26YBWog4=.1e33ec27-6581-4d55-b15c-bc01a0e2c55a@github.com>

On Fri, 22 Mar 2024 17:17:17 GMT, Phil Race <prr at openjdk.org> wrote:

>> This previously closed test is cleaned up, opened and fixed to work on hidpi at fractional scales.
>> It has unrelated problems on macOS 14 and is problem listed there (as it was when it was a closed test).
>
> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8328555

Marked as reviewed by aivanov (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18439#pullrequestreview-1955350029

From prr at openjdk.org  Fri Mar 22 17:20:41 2024
From: prr at openjdk.org (Phil Race)
Date: Fri, 22 Mar 2024 17:20:41 GMT
Subject: RFR: 8328555: hidpi problems for test
 java/awt/Dialog/DialogAnotherThread/JaWSTest.java
In-Reply-To: <gYkodvmu9blcvd-abDi1RhmY0B4r-xM2SFmVcjpJMgM=.f278f787-074b-4a27-8b39-2509a7f2940b@github.com>
References: <gYkodvmu9blcvd-abDi1RhmY0B4r-xM2SFmVcjpJMgM=.f278f787-074b-4a27-8b39-2509a7f2940b@github.com>
Message-ID: <279nUhbGQdQ5mohXuZdDPSluJws8b9PvIsgFJkhA_VU=.a448555c-0462-4305-9794-5d926e99e3ac@github.com>

On Thu, 21 Mar 2024 19:10:40 GMT, Phil Race <prr at openjdk.org> wrote:

> This previously closed test is cleaned up, opened and fixed to work on hidpi at fractional scales.
> It has unrelated problems on macOS 14 and is problem listed there (as it was when it was a closed test).

OK, I've removed the problem listing.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18439#issuecomment-2015543141

From prr at openjdk.org  Fri Mar 22 17:20:42 2024
From: prr at openjdk.org (Phil Race)
Date: Fri, 22 Mar 2024 17:20:42 GMT
Subject: Integrated: 8328555: hidpi problems for test
 java/awt/Dialog/DialogAnotherThread/JaWSTest.java
In-Reply-To: <gYkodvmu9blcvd-abDi1RhmY0B4r-xM2SFmVcjpJMgM=.f278f787-074b-4a27-8b39-2509a7f2940b@github.com>
References: <gYkodvmu9blcvd-abDi1RhmY0B4r-xM2SFmVcjpJMgM=.f278f787-074b-4a27-8b39-2509a7f2940b@github.com>
Message-ID: <RKphDMpYD-d4srQ4-LkSDFBlHCA0L_9idrHijJOFGf8=.c5e3f2c8-ca2d-498b-8ae2-c0ea196c276e@github.com>

On Thu, 21 Mar 2024 19:10:40 GMT, Phil Race <prr at openjdk.org> wrote:

> This previously closed test is cleaned up, opened and fixed to work on hidpi at fractional scales.
> It has unrelated problems on macOS 14 and is problem listed there (as it was when it was a closed test).

This pull request has now been integrated.

Changeset: 23ebd9c3
Author:    Phil Race <prr at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/23ebd9c3c69d09e6afe672d00b43da2ccc493480
Stats:     148 lines in 1 file changed: 148 ins; 0 del; 0 mod

8328555: hidpi problems for test java/awt/Dialog/DialogAnotherThread/JaWSTest.java

Reviewed-by: aivanov

-------------

PR: https://git.openjdk.org/jdk/pull/18439

From dnguyen at openjdk.org  Fri Mar 22 17:24:30 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Fri, 22 Mar 2024 17:24:30 GMT
Subject: RFR: 8328730: Convert java/awt/print/bug8023392/bug8023392.html applet
 test to main
Message-ID: <Mn57TSPJZir2IqthGrBOcW_GBsOMPq514q9Ds7AFhy8=.da0ef4a4-b351-4c6d-beaf-a827d1c88385@github.com>

Convert java/awt/print/bug8023392/bug8023392.html applet test to main using PassFailJFrame

-------------

Commit messages:
 - Initial test conversion

Changes: https://git.openjdk.org/jdk/pull/18458/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18458&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8328730
  Stats: 217 lines in 2 files changed: 32 ins; 152 del; 33 mod
  Patch: https://git.openjdk.org/jdk/pull/18458.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18458/head:pull/18458

PR: https://git.openjdk.org/jdk/pull/18458

From aivanov at openjdk.org  Fri Mar 22 17:28:23 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Fri, 22 Mar 2024 17:28:23 GMT
Subject: RFR: JDK-8328190 : Convert AWTPanelSmoothWheel.html applet test to
 main [v9]
In-Reply-To: <HcWi12W3g_FVuGX20Va6x5axVJ8objoVT6WxGjF2Bgo=.217db879-a563-4ff0-8866-e02e40596be6@github.com>
References: <sn9qb9ctS_sr3isHbwcbMCYh2RQokz2ptsw0rGBRnJY=.955d7549-72c7-4a4f-8ac8-a5d6f122cf68@github.com>
 <HcWi12W3g_FVuGX20Va6x5axVJ8objoVT6WxGjF2Bgo=.217db879-a563-4ff0-8866-e02e40596be6@github.com>
Message-ID: <UBiqi2vvn_9mAuHAF3j6ijpp2qa61EUEtA-SnBsaobw=.f77e2ac8-0ba3-41d3-a90b-463ce37c3185@github.com>

On Fri, 22 Mar 2024 16:54:49 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> This test is converted to main using PassFailJFrame. It verifies wheel rotation value for high-res mouse on windows.
>> 
>> The test requires the updated PassFailJFrame's logArea() feature added in this PR https://github.com/openjdk/jdk/pull/18319
>
> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Instructions updated

Marked as reviewed by aivanov (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18312#pullrequestreview-1955372505

From dnguyen at openjdk.org  Fri Mar 22 17:30:22 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Fri, 22 Mar 2024 17:30:22 GMT
Subject: RFR: 8328717: Convert
 javax/swing/JColorChooser/8065098/bug8065098.java applet test to main [v2]
In-Reply-To: <GzKDNnM9EiXsyGvWVTSsu7Y6OPEpTsfPB9ZSoZa1_sA=.910b4433-13a6-4ac3-b555-ecd23e2eb802@github.com>
References: <SZLE6sOQUNGW_tBIfu6MkZE7rxjp5HJGZih6X50rrpw=.231ba8d7-c9cb-4dc9-b27a-62060696d0a1@github.com>
 <nPExjs6ScZjBLdFZU4O_5cr2QLR9YPAfoc5wajWmgYI=.eb0060bd-35e4-45a4-9cad-730ca56a3cfc@github.com>
 <GzKDNnM9EiXsyGvWVTSsu7Y6OPEpTsfPB9ZSoZa1_sA=.910b4433-13a6-4ac3-b555-ecd23e2eb802@github.com>
Message-ID: <vVQTQYwKdau-Y2bUIxOc2SpA0JmSWbK6wFvR4_NjUqk=.527df5b7-42b6-46c6-b862-bbeb72b48fdf@github.com>

On Fri, 22 Mar 2024 11:25:10 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update copyright year
>
> test/jdk/javax/swing/JColorChooser/8065098/JColorChooserDnDTest.java line 47:
> 
>> 45:             frame.setContentPane(panel);
>> 46:             frame.pack();
>> 47:             frame.setVisible(true);
> 
> frame dispose is not required?

This is a manual test. If I add dispose, it would close the application on startup. The `JFrame.EXIT_ON_CLOSE` call should handle this I believe. There's `DISPOSE_ON_CLOSE`, but I don't think this is right here.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18436#discussion_r1535947253

From aivanov at openjdk.org  Fri Mar 22 17:35:26 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Fri, 22 Mar 2024 17:35:26 GMT
Subject: RFR: JDK-8328190 : Convert AWTPanelSmoothWheel.html applet test to
 main [v8]
In-Reply-To: <1Db3FojRF05GPHaoTnNQVhE1x33SAuQ5hr1QNseTbU0=.8a53c004-04d4-472f-8672-eb5e7cc0851c@github.com>
References: <sn9qb9ctS_sr3isHbwcbMCYh2RQokz2ptsw0rGBRnJY=.955d7549-72c7-4a4f-8ac8-a5d6f122cf68@github.com>
 <ZLWbHjYWkT2QoPJVoKrpdOfLy_myoGI5x1UmXGuXmR0=.5d84f0f8-58d4-44e2-b223-c4c4685aadef@github.com>
 <1Db3FojRF05GPHaoTnNQVhE1x33SAuQ5hr1QNseTbU0=.8a53c004-04d4-472f-8672-eb5e7cc0851c@github.com>
Message-ID: <24ZDsfq6idpRqGctxjbVTBEAXMsnvgChdMyyledWl88=.4a5315c4-7a57-4005-8146-5d8eaaed1d58@github.com>

On Fri, 22 Mar 2024 15:20:02 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> I somewhat dislike that the test completes too quickly when I use my mouse. Yes, you warn the tester the test is semi-automatic, yet I'd prefer giving the tester more time.
> 
> Technically, one event with `e.getWheelRotation() != 0` is enough, that's right. It just doesn't feel right?

I run the test it with trackpad on my Windows laptop. Indeed, waiting for `e.getWheelRotation() != 0` takes too long if `e.getPreciseWheelRotation()` is very small, it is 0.01 on Harshitha's laptop and on mine too.

When the value of `e.getPreciseWheelRotation() > 0.10`, it feels the test completes too fast.

We can change the sensitivity of the test. Is it worth the effort? Perhaps, it isn't.

Does anyone else have any comments?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18312#issuecomment-2015570497

From honkar at openjdk.org  Fri Mar 22 17:35:28 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Fri, 22 Mar 2024 17:35:28 GMT
Subject: Integrated: JDK-8328190 : Convert AWTPanelSmoothWheel.html applet test
 to main
In-Reply-To: <sn9qb9ctS_sr3isHbwcbMCYh2RQokz2ptsw0rGBRnJY=.955d7549-72c7-4a4f-8ac8-a5d6f122cf68@github.com>
References: <sn9qb9ctS_sr3isHbwcbMCYh2RQokz2ptsw0rGBRnJY=.955d7549-72c7-4a4f-8ac8-a5d6f122cf68@github.com>
Message-ID: <8462vuz1gqNqXmSYBKPpV-FE69Z0_gEvuyw9kpeFxgY=.b5e70ddd-09b2-418b-8e94-e0edbabe3e6f@github.com>

On Thu, 14 Mar 2024 19:50:18 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

> This test is converted to main using PassFailJFrame. It verifies wheel rotation value for high-res mouse on windows.
> 
> The test requires the updated PassFailJFrame's logArea() feature added in this PR https://github.com/openjdk/jdk/pull/18319

This pull request has now been integrated.

Changeset: c7bbf849
Author:    Harshitha Onkar <honkar at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/c7bbf849290b39b8e89290234d70d8333df24710
Stats:     425 lines in 3 files changed: 131 ins; 294 del; 0 mod

8328190: Convert AWTPanelSmoothWheel.html applet test to main

Reviewed-by: azvegint, abhiscxk, aivanov

-------------

PR: https://git.openjdk.org/jdk/pull/18312

From dnguyen at openjdk.org  Fri Mar 22 17:38:36 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Fri, 22 Mar 2024 17:38:36 GMT
Subject: RFR: 8328730: Convert java/awt/print/bug8023392/bug8023392.html
 applet test to main [v2]
In-Reply-To: <Mn57TSPJZir2IqthGrBOcW_GBsOMPq514q9Ds7AFhy8=.da0ef4a4-b351-4c6d-beaf-a827d1c88385@github.com>
References: <Mn57TSPJZir2IqthGrBOcW_GBsOMPq514q9Ds7AFhy8=.da0ef4a4-b351-4c6d-beaf-a827d1c88385@github.com>
Message-ID: <snIQJo9DJUrVkenZLQERlr35Lm2-IreJNVZgf7D9ucI=.69960d03-894a-4c85-b38c-301e5ee838f9@github.com>

> Convert java/awt/print/bug8023392/bug8023392.html applet test to main using PassFailJFrame

Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:

  Move test out of extra dir

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18458/files
  - new: https://git.openjdk.org/jdk/pull/18458/files/26320f83..72fe9b13

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18458&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18458&range=00-01

  Stats: 0 lines in 1 file changed: 0 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18458.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18458/head:pull/18458

PR: https://git.openjdk.org/jdk/pull/18458

From honkar at openjdk.org  Fri Mar 22 17:42:22 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Fri, 22 Mar 2024 17:42:22 GMT
Subject: RFR: 8328717: Convert
 javax/swing/JColorChooser/8065098/bug8065098.java applet test to main [v2]
In-Reply-To: <hy-aHDO65ATuAvako_8x796MdEL1yk3qB-uYa135KcY=.581682f3-bd90-4d82-ac32-90aa0295b05f@github.com>
References: <SZLE6sOQUNGW_tBIfu6MkZE7rxjp5HJGZih6X50rrpw=.231ba8d7-c9cb-4dc9-b27a-62060696d0a1@github.com>
 <RanAaZIZfAccXF1EKCQ8VKfcUIs55TuaKo_h7ud9_G8=.34018b2a-e13f-41a7-b559-5d52986d9870@github.com>
 <hy-aHDO65ATuAvako_8x796MdEL1yk3qB-uYa135KcY=.581682f3-bd90-4d82-ac32-90aa0295b05f@github.com>
Message-ID: <O8PeDgVWKDih_m_8lAphn5ezUJ6iaqsjCBl-4FdEoms=.c2c82c76-aaf4-470a-aa43-17ee8e51c00e@github.com>

On Fri, 22 Mar 2024 08:45:15 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

> Same for me. Looks like it's not an issue with the test and rather a bug that hasn't been fixed yet. I found [JDK-8065647](https://bugs.openjdk.org/browse/JDK-8065647) which I think is related to this. Seems to be filed after the bugID for THIS test was resolved.

I missed that it is already problemlisted on macOS.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18436#issuecomment-2015585738

From honkar at openjdk.org  Fri Mar 22 17:47:27 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Fri, 22 Mar 2024 17:47:27 GMT
Subject: RFR: 8328717: Convert
 javax/swing/JColorChooser/8065098/bug8065098.java applet test to main [v2]
In-Reply-To: <nPExjs6ScZjBLdFZU4O_5cr2QLR9YPAfoc5wajWmgYI=.eb0060bd-35e4-45a4-9cad-730ca56a3cfc@github.com>
References: <SZLE6sOQUNGW_tBIfu6MkZE7rxjp5HJGZih6X50rrpw=.231ba8d7-c9cb-4dc9-b27a-62060696d0a1@github.com>
 <nPExjs6ScZjBLdFZU4O_5cr2QLR9YPAfoc5wajWmgYI=.eb0060bd-35e4-45a4-9cad-730ca56a3cfc@github.com>
Message-ID: <uKgB1SXcJY2vfSVw9LeQdndFjAKWOG5Xjlla0HDguJA=.1073a50a-57c1-4b4e-8038-e72422b6220a@github.com>

On Fri, 22 Mar 2024 08:48:35 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

>> Convert javax/swing/JColorChooser/8065098/bug8065098.java applet test to main using PassFailJFrame for the instructions.
>
> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update copyright year

LGTM

-------------

Marked as reviewed by honkar (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18436#pullrequestreview-1955412463

From honkar at openjdk.org  Fri Mar 22 17:47:28 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Fri, 22 Mar 2024 17:47:28 GMT
Subject: RFR: 8328717: Convert
 javax/swing/JColorChooser/8065098/bug8065098.java applet test to main [v2]
In-Reply-To: <vVQTQYwKdau-Y2bUIxOc2SpA0JmSWbK6wFvR4_NjUqk=.527df5b7-42b6-46c6-b862-bbeb72b48fdf@github.com>
References: <SZLE6sOQUNGW_tBIfu6MkZE7rxjp5HJGZih6X50rrpw=.231ba8d7-c9cb-4dc9-b27a-62060696d0a1@github.com>
 <nPExjs6ScZjBLdFZU4O_5cr2QLR9YPAfoc5wajWmgYI=.eb0060bd-35e4-45a4-9cad-730ca56a3cfc@github.com>
 <GzKDNnM9EiXsyGvWVTSsu7Y6OPEpTsfPB9ZSoZa1_sA=.910b4433-13a6-4ac3-b555-ecd23e2eb802@github.com>
 <vVQTQYwKdau-Y2bUIxOc2SpA0JmSWbK6wFvR4_NjUqk=.527df5b7-42b6-46c6-b862-bbeb72b48fdf@github.com>
Message-ID: <99yeOl8-cMWUnCd3AmcruBqHTYGmkpEh7uyz-_mgsn4=.94da11b4-bd27-43d2-9867-1a18f3bfc5bd@github.com>

On Fri, 22 Mar 2024 17:28:10 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

>> test/jdk/javax/swing/JColorChooser/8065098/JColorChooserDnDTest.java line 47:
>> 
>>> 45:             frame.setContentPane(panel);
>>> 46:             frame.pack();
>>> 47:             frame.setVisible(true);
>> 
>> frame dispose is not required?
>
> This is a manual test. If I add dispose, it would close the application on startup. The `JFrame.EXIT_ON_CLOSE` call should handle this I believe. There's `DISPOSE_ON_CLOSE`, but I don't think this is right here.

I agree, `JFrame.EXIT_ON_CLOSE` should be sufficient in this case.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18436#discussion_r1535968998

From dnguyen at openjdk.org  Fri Mar 22 18:11:33 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Fri, 22 Mar 2024 18:11:33 GMT
Subject: RFR: 8328827: Convert
 java/awt/print/PrinterJob/PrinterDialogsModalityTest/PrinterDialogsModalityTest.html
 applet test to main
Message-ID: <2iwbuovZ9rGwS8EqkKiSvnxU3_eJI-5KHFngpMs4qtE=.89885458-b5e0-48da-9810-4cfe71c9a420@github.com>

Convert java/awt/print/PrinterJob/PrinterDialogsModalityTest/PrinterDialogsModalityTest.html applet test to main using PassFailJFrame

-------------

Commit messages:
 - 8328827 Initial test conversion

Changes: https://git.openjdk.org/jdk/pull/18461/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18461&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8328827
  Stats: 400 lines in 3 files changed: 95 ins; 305 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18461.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18461/head:pull/18461

PR: https://git.openjdk.org/jdk/pull/18461

From dnguyen at openjdk.org  Fri Mar 22 18:59:30 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Fri, 22 Mar 2024 18:59:30 GMT
Subject: RFR: 8328719: Convert java/awt/print/PageFormat/SetOrient.html applet
 test to main
Message-ID: <Bl4gv5IxCey90n1pVzaEsbrztrXkt5Ixksx2E6ul0AI=.4c598589-ce3c-4a7e-a417-3f2e1f54b3cb@github.com>

Convert java/awt/print/PageFormat/SetOrient.html applet test to main using PassFailJFrame.

-------------

Commit messages:
 - 8328719 Initial test conversion

Changes: https://git.openjdk.org/jdk/pull/18462/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18462&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8328719
  Stats: 133 lines in 2 files changed: 52 ins; 68 del; 13 mod
  Patch: https://git.openjdk.org/jdk/pull/18462.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18462/head:pull/18462

PR: https://git.openjdk.org/jdk/pull/18462

From achung at openjdk.org  Fri Mar 22 20:04:23 2024
From: achung at openjdk.org (Alisen Chung)
Date: Fri, 22 Mar 2024 20:04:23 GMT
Subject: RFR: 8328370: Convert java/awt/print/Dialog/PrintApplet.java
 applet test to main [v4]
In-Reply-To: <sgvht4dgRxM3dskOeAkWUox9DmTJKDrD-_s0C4ZjeKc=.e6f75f54-eaab-4402-8c2b-595cfdf41c9a@github.com>
References: <Je7yOnjOAjH3DsIgUx72_7ASxsrXS5oIskdKM716AiA=.f1a73b22-8644-40cc-91d6-9ce301f03cc2@github.com>
 <sgvht4dgRxM3dskOeAkWUox9DmTJKDrD-_s0C4ZjeKc=.e6f75f54-eaab-4402-8c2b-595cfdf41c9a@github.com>
Message-ID: <uK6vis6nkmbFLX5yMQq0JeesWoPF6MukW8Yo2xKzzjQ=.5002dddd-b628-4b51-91a8-dfa3d518ebf7@github.com>

On Thu, 21 Mar 2024 16:11:44 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

>> Convert java/awt/print/Dialog/PrintApplet.java applet test to main using PassFailJFrame. Also rename the test to PrintModalDialog.java since this is no longer an applet. Added test instructions related to the linked JBS issue.
>
> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix main/manual

Changes requested by achung (Committer).

test/jdk/java/awt/print/Dialog/PrintModalDialog.java line 43:

> 41: 
> 42: import javax.swing.JButton;
> 43: 

i think the order should be imports then jtreg tags

-------------

PR Review: https://git.openjdk.org/jdk/pull/18362#pullrequestreview-1955695843
PR Review Comment: https://git.openjdk.org/jdk/pull/18362#discussion_r1536136404

From achung at openjdk.org  Fri Mar 22 20:06:23 2024
From: achung at openjdk.org (Alisen Chung)
Date: Fri, 22 Mar 2024 20:06:23 GMT
Subject: RFR: 8328717: Convert
 javax/swing/JColorChooser/8065098/bug8065098.java applet test to main [v2]
In-Reply-To: <nPExjs6ScZjBLdFZU4O_5cr2QLR9YPAfoc5wajWmgYI=.eb0060bd-35e4-45a4-9cad-730ca56a3cfc@github.com>
References: <SZLE6sOQUNGW_tBIfu6MkZE7rxjp5HJGZih6X50rrpw=.231ba8d7-c9cb-4dc9-b27a-62060696d0a1@github.com>
 <nPExjs6ScZjBLdFZU4O_5cr2QLR9YPAfoc5wajWmgYI=.eb0060bd-35e4-45a4-9cad-730ca56a3cfc@github.com>
Message-ID: <o_ib4c3_eP5Bc4W6kQvPFk55N7Blbgn8yxdIAwxvbiQ=.4c42c263-2ce4-4bc3-80ea-bb37d644e54a@github.com>

On Fri, 22 Mar 2024 08:48:35 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

>> Convert javax/swing/JColorChooser/8065098/bug8065098.java applet test to main using PassFailJFrame for the instructions.
>
> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update copyright year

Changes requested by achung (Committer).

test/jdk/javax/swing/JColorChooser/8065098/JColorChooserDnDTest.java line 34:

> 32:  *     between two JVM instances
> 33:  */
> 34: public class JColorChooserDnDTest {

Missing @test and @run tags?

-------------

PR Review: https://git.openjdk.org/jdk/pull/18436#pullrequestreview-1955698065
PR Review Comment: https://git.openjdk.org/jdk/pull/18436#discussion_r1536138393

From dnguyen at openjdk.org  Fri Mar 22 20:11:22 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Fri, 22 Mar 2024 20:11:22 GMT
Subject: RFR: 8328717: Convert
 javax/swing/JColorChooser/8065098/bug8065098.java applet test to main [v2]
In-Reply-To: <o_ib4c3_eP5Bc4W6kQvPFk55N7Blbgn8yxdIAwxvbiQ=.4c42c263-2ce4-4bc3-80ea-bb37d644e54a@github.com>
References: <SZLE6sOQUNGW_tBIfu6MkZE7rxjp5HJGZih6X50rrpw=.231ba8d7-c9cb-4dc9-b27a-62060696d0a1@github.com>
 <nPExjs6ScZjBLdFZU4O_5cr2QLR9YPAfoc5wajWmgYI=.eb0060bd-35e4-45a4-9cad-730ca56a3cfc@github.com>
 <o_ib4c3_eP5Bc4W6kQvPFk55N7Blbgn8yxdIAwxvbiQ=.4c42c263-2ce4-4bc3-80ea-bb37d644e54a@github.com>
Message-ID: <VEPzm7S6RjkazAB1Lcb7ccCiGER_l0tH2xn1K7cE2m8=.a21f3365-a68d-4b34-83fe-d206e78b74ed@github.com>

On Fri, 22 Mar 2024 20:03:17 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update copyright year
>
> test/jdk/javax/swing/JColorChooser/8065098/JColorChooserDnDTest.java line 34:
> 
>> 32:  *     between two JVM instances
>> 33:  */
>> 34: public class JColorChooserDnDTest {
> 
> Missing @test and @run tags?

This part of the test doesn't run on jtreg so I don't think this is applicable.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18436#discussion_r1536145596

From duke at openjdk.org  Fri Mar 22 20:50:52 2024
From: duke at openjdk.org (Larry Cable)
Date: Fri, 22 Mar 2024 20:50:52 GMT
Subject: RFR: 8321428: Depreciate java.beans.beancontext.*
Message-ID: <5CF4Y37gyrFEcymJvgj50A4L25_fDlH2N8-cTBhVF2M=.cc55299c-b3e2-436e-b380-6a6d74e84c70@github.com>

[https://bugs.openjdk.org/browse/JDK-8321428](url)

-------------

Commit messages:
 - 83020930: added @Deprecated and @SuppressWarnings to depreciate java.beans.beancontext

Changes: https://git.openjdk.org/jdk/pull/18413/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18413&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8321428
  Stats: 48 lines in 20 files changed: 45 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/jdk/pull/18413.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18413/head:pull/18413

PR: https://git.openjdk.org/jdk/pull/18413

From prr at openjdk.org  Fri Mar 22 20:59:21 2024
From: prr at openjdk.org (Phil Race)
Date: Fri, 22 Mar 2024 20:59:21 GMT
Subject: RFR: 8321428: Depreciate java.beans.beancontext.*
In-Reply-To: <5CF4Y37gyrFEcymJvgj50A4L25_fDlH2N8-cTBhVF2M=.cc55299c-b3e2-436e-b380-6a6d74e84c70@github.com>
References: <5CF4Y37gyrFEcymJvgj50A4L25_fDlH2N8-cTBhVF2M=.cc55299c-b3e2-436e-b380-6a6d74e84c70@github.com>
Message-ID: <mdR5EumOHgWzFdvGDlDzCeFlgP5wznb9P7-4aBZ1zsI=.a51b376f-ae8a-4463-9f1b-6ed9a524ef0e@github.com>

On Wed, 20 Mar 2024 21:30:53 GMT, Larry Cable <duke at openjdk.org> wrote:

> [https://bugs.openjdk.org/browse/JDK-8321428](url)

looks good except for
(1) that blank line
(2) skara would like you to rename the PR to match the bug + approved CSR.

src/java.desktop/share/classes/java/beans/beancontext/package-info.java line 36:

> 34:  * @since 1.2
> 35:  */
> 36: 

?? Were you intending to add something here ? If not revert the blank line.

-------------

PR Review: https://git.openjdk.org/jdk/pull/18413#pullrequestreview-1955787213
PR Review Comment: https://git.openjdk.org/jdk/pull/18413#discussion_r1536214806

From honkar at openjdk.org  Fri Mar 22 21:02:21 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Fri, 22 Mar 2024 21:02:21 GMT
Subject: RFR: 8328819: Remove applet usage from JFileChooser tests
 bug6698013
In-Reply-To: <iLcbr4t_2UJ4muFqTIm1NMfahCdwMTpgprqHo8WHHW0=.29e91557-e4b0-4d9c-ba32-fb2ab49e5de9@github.com>
References: <iLcbr4t_2UJ4muFqTIm1NMfahCdwMTpgprqHo8WHHW0=.29e91557-e4b0-4d9c-ba32-fb2ab49e5de9@github.com>
Message-ID: <PY37YHZTXPxUAhaOUoo7aiM5FPC4o1HiL3ii8ni-NC4=.6bc23e92-01f9-4b62-a314-eb7a4991f452@github.com>

On Fri, 22 Mar 2024 15:40:39 GMT, Alisen Chung <achung at openjdk.org> wrote:

> The original test is failing (nothing shows up in the JFileChooser), but this change does replace the applet usage with PassFailJFrame

@alisenchung The original test works on Windows. Is it on macOS that nothing is shown ?

-------------

PR Review: https://git.openjdk.org/jdk/pull/18456#pullrequestreview-1955792449

From serb at openjdk.org  Fri Mar 22 21:06:32 2024
From: serb at openjdk.org (Sergey Bylokhov)
Date: Fri, 22 Mar 2024 21:06:32 GMT
Subject: Integrated: 8328194: Add a test to check default rendering engine
In-Reply-To: <xxsxmOwVdXyBrSIp2WwIQ3_RvWLBL5KORk_X6bNkAnU=.588f07e6-2967-4d9e-a780-046af14d2ca1@github.com>
References: <xxsxmOwVdXyBrSIp2WwIQ3_RvWLBL5KORk_X6bNkAnU=.588f07e6-2967-4d9e-a780-046af14d2ca1@github.com>
Message-ID: <5TbGkya8-89XW6ME1cqe591S4c04diCnBTZm-5HtvtQ=.e7a05a4c-123d-4d94-93af-62e615b1e2fd@github.com>

On Thu, 14 Mar 2024 20:13:58 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

> This is a request to forward port the test added by the [JDK-8241307](https://bugs.openjdk.org/browse/JDK-8241307) with inverted condition - jdk jdk11 the marlin should be used by default.

This pull request has now been integrated.

Changeset: c013fa18
Author:    Sergey Bylokhov <serb at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/c013fa18119bbd2e355d5c0d13cd8c172892800a
Stats:     42 lines in 1 file changed: 42 ins; 0 del; 0 mod

8328194: Add a test to check default rendering engine

Reviewed-by: prr, tr

-------------

PR: https://git.openjdk.org/jdk/pull/18313

From serb at openjdk.org  Fri Mar 22 21:07:29 2024
From: serb at openjdk.org (Sergey Bylokhov)
Date: Fri, 22 Mar 2024 21:07:29 GMT
Subject: RFR: 8327137: Add test for ConcurrentModificationException in
 BasicDirectoryModel [v3]
In-Reply-To: <d5JjW3jU1caR7NXz_sfQ78zXMSmxqLi_ony4WorDSh8=.5122b277-8ddc-40a0-a6ec-a5ae6226246b@github.com>
References: <mCqqjrXVWDB2PvpOhKHx-Hr8W6tUz6v4stztGmyAeEg=.1f95da1c-e1a5-40be-be8b-0758729fa9b9@github.com>
 <HvJ96YzIfnTtdNh7R5XtYs_t0sc5VfHjBHUxi9uyJdI=.94715923-e3c0-4666-9a51-340ef91b8b3b@github.com>
 <V1fPYAjQ6U8TFSOTRQ-Fk9dRnFAwbimWAPUkicxtklk=.6fe019f2-a478-4e11-8c02-b606f8f14709@github.com>
 <Chb_zgl53KY05-E3fKBAF61S8SO4Bi7LMlGkART_3io=.7845c015-4fd7-4ce5-bf27-7994cbf2471a@github.com>
 <d5JjW3jU1caR7NXz_sfQ78zXMSmxqLi_ony4WorDSh8=.5122b277-8ddc-40a0-a6ec-a5ae6226246b@github.com>
Message-ID: <yhqPAJ3HPjy7RrrmTSNbkPIIgnndqaNkqN4cwsJYd6A=.121a9971-5f09-4977-847a-8971d7a359e5@github.com>

On Tue, 19 Mar 2024 17:03:25 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>Instantiating JFileChooser on EDT adds complexity for no benefit. The JFileChooser is still accessed concurrently from several threads, including Swing internal thread.

But still, this is a common requirement to create UI components on EDT, and that will replicate more or less how it will work in the application.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18109#discussion_r1536222501

From honkar at openjdk.org  Fri Mar 22 21:36:26 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Fri, 22 Mar 2024 21:36:26 GMT
Subject: RFR: 8328819: Remove applet usage from JFileChooser tests
 bug6698013
In-Reply-To: <iLcbr4t_2UJ4muFqTIm1NMfahCdwMTpgprqHo8WHHW0=.29e91557-e4b0-4d9c-ba32-fb2ab49e5de9@github.com>
References: <iLcbr4t_2UJ4muFqTIm1NMfahCdwMTpgprqHo8WHHW0=.29e91557-e4b0-4d9c-ba32-fb2ab49e5de9@github.com>
Message-ID: <phLwDsZ4Jkgte3PbrnT1eWKL654-194knsUfZPfUGWg=.f1a63a22-c652-4b7f-93b9-68450d9536b6@github.com>

On Fri, 22 Mar 2024 15:40:39 GMT, Alisen Chung <achung at openjdk.org> wrote:

> Removing applet usage from manual JFileChooser tests
> The original test is failing (nothing shows up in the JFileChooser), but this change does replace the applet usage with PassFailJFrame

Ideally the Instruction window and Test window appear side-by-side. In this case, the JFileChooser completely covers the Instruction window even when set using .testUI(). Not sure why the window manager doesn't honor the position set by PassFailJFrame, for now you can increase the number rows to increase the size of instruction window, so that the user running the manual test is aware that there are 2 windows.

-------------

PR Review: https://git.openjdk.org/jdk/pull/18456#pullrequestreview-1955833818

From kizune at openjdk.org  Fri Mar 22 21:39:22 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Fri, 22 Mar 2024 21:39:22 GMT
Subject: RFR: 8316324: Opensource five miscellaneous Swing tests
In-Reply-To: <7F76CExWTIR2A-yyd3q5McROglv7yv8Zb-6H9Juu8AQ=.cb569ed1-6a5c-45df-a66b-b2d6c1e67064@github.com>
References: <2GNSvcn0o7_d4Gca1TkUmz3M2gTtjg2lF8guEq2V8Bs=.cd4c564a-b089-4a8e-b582-b778a73b0329@github.com>
 <7F76CExWTIR2A-yyd3q5McROglv7yv8Zb-6H9Juu8AQ=.cb569ed1-6a5c-45df-a66b-b2d6c1e67064@github.com>
Message-ID: <wRYD1dGeZaXsEMIlfnDA3IReKSNvNYfNYiJKmq64iF4=.b80da503-d9fb-4581-a9d0-ad31f2faa540@github.com>

On Fri, 22 Mar 2024 06:57:12 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Clean up and opensource five tests.
>
> test/jdk/javax/swing/InputVerifier/bug4774166.java line 44:
> 
>> 42:  * @summary InputVerifier should be called after a window loses and then regains focus
>> 43:  * @library /javax/swing/regtesthelpers
>> 44:  * @build JRobot
> 
> I guess JRobot library dependancy is not needed unnecessarliy, could be achieved by normal Robot in this test..

Down below i am using JRobot API such as hitKey and clickMouseOn so i have to use JRobot or code will be much larger.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18443#discussion_r1536247341

From kizune at openjdk.org  Fri Mar 22 21:45:32 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Fri, 22 Mar 2024 21:45:32 GMT
Subject: RFR: 8316324: Opensource five miscellaneous Swing tests
In-Reply-To: <sHsW7LXGy912f6z8g0PFOf9YXAbbWkbPSxTPuLvxGsY=.6fac48ce-4b77-4f1f-91d7-be87d2967eda@github.com>
References: <2GNSvcn0o7_d4Gca1TkUmz3M2gTtjg2lF8guEq2V8Bs=.cd4c564a-b089-4a8e-b582-b778a73b0329@github.com>
 <sHsW7LXGy912f6z8g0PFOf9YXAbbWkbPSxTPuLvxGsY=.6fac48ce-4b77-4f1f-91d7-be87d2967eda@github.com>
Message-ID: <pQ1Q8uSj5zBQocDxRpBsQ3Q9GeAZfctUm1-84EY_azc=.0b7418c0-e9ca-421f-929c-4f225abd767c@github.com>

On Fri, 22 Mar 2024 09:04:28 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Clean up and opensource five tests.
>
> test/jdk/javax/swing/InputVerifier/bug4774166.java line 165:
> 
>> 163:         robot.hitKey(KeyEvent.VK_M);
>> 164:         robot.hitKey(KeyEvent.VK_N);
>> 165:         robot.hitKey(KeyEvent.VK_O);
> 
> WaitForIdle might be used in between a set of key events.......

There is a delay happening inside the JRobot method and the idea is to generate events as they are coming from the system - without waiting for the event queue to catch up.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18443#discussion_r1536251004

From kizune at openjdk.org  Fri Mar 22 21:45:33 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Fri, 22 Mar 2024 21:45:33 GMT
Subject: RFR: 8316324: Opensource five miscellaneous Swing tests
In-Reply-To: <7F76CExWTIR2A-yyd3q5McROglv7yv8Zb-6H9Juu8AQ=.cb569ed1-6a5c-45df-a66b-b2d6c1e67064@github.com>
References: <2GNSvcn0o7_d4Gca1TkUmz3M2gTtjg2lF8guEq2V8Bs=.cd4c564a-b089-4a8e-b582-b778a73b0329@github.com>
 <7F76CExWTIR2A-yyd3q5McROglv7yv8Zb-6H9Juu8AQ=.cb569ed1-6a5c-45df-a66b-b2d6c1e67064@github.com>
Message-ID: <U_EAFQnZRisJb2sNWmMrFMmjmjume14YSyw83VZJzIk=.e87572fb-7fa2-47ba-9115-6c57310a1aad@github.com>

On Fri, 22 Mar 2024 07:02:05 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Clean up and opensource five tests.
>
> test/jdk/javax/swing/JButton/4385611/bug4385611.java line 42:
> 
>> 40: public class bug4385611 {
>> 41:     static JButton bt1, bt2;
>> 42:     static final ImageIcon icon32x32 = new ImageIcon(bug4385611.class.getResource("red.gif"));
> 
> did you verify if we are allowed to keep this red.gif in open source as per the image license? Can we not create the Imageicon from a yellow32x32 bufferedimage?

It is just a gif file filled with yellow color created specifically for that test. It was not provided by the test submitter or anything like that - it was just created in the graphics editor. There's no copyright issue with it.

> test/jdk/javax/swing/plaf/motif/bug4150591.java line 40:
> 
>> 38: public class bug4150591 {
>> 39:     public static void main(String[] args) {
>> 40:         MotifInternalFrameTitlePane mtp = new MotifInternalFrameTitlePane(new JInternalFrame());
> 
> Is this test required to be added now with motif being deprecated?

It is deprecated but still exist. When we will decide to remove it (if we do at some point) the test will be easily to delete since it is in the PLaF specific test directory. I see no harm in keeping it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18443#discussion_r1536249258
PR Review Comment: https://git.openjdk.org/jdk/pull/18443#discussion_r1536250007

From kizune at openjdk.org  Fri Mar 22 21:48:33 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Fri, 22 Mar 2024 21:48:33 GMT
Subject: RFR: 8316324: Opensource five miscellaneous Swing tests
In-Reply-To: <sHsW7LXGy912f6z8g0PFOf9YXAbbWkbPSxTPuLvxGsY=.6fac48ce-4b77-4f1f-91d7-be87d2967eda@github.com>
References: <2GNSvcn0o7_d4Gca1TkUmz3M2gTtjg2lF8guEq2V8Bs=.cd4c564a-b089-4a8e-b582-b778a73b0329@github.com>
 <sHsW7LXGy912f6z8g0PFOf9YXAbbWkbPSxTPuLvxGsY=.6fac48ce-4b77-4f1f-91d7-be87d2967eda@github.com>
Message-ID: <ek9UxH8vn6Msc_tUB-IZ6stozxOW2MVlPUMcJzXO-H8=.054894be-aa6e-49c9-bc9b-07adebde39ff@github.com>

On Fri, 22 Mar 2024 09:01:01 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Clean up and opensource five tests.
>
> test/jdk/javax/swing/InputVerifier/bug4774166.java line 144:
> 
>> 142:     public void performTest() throws InterruptedException, InvocationTargetException {
>> 143:         robot.setAutoDelay(100);
>> 144:         robot.delay(2000);
> 
> After setting auto delay, I don't think delay is required here?

Just letting system some time to display and position all the windows before starting the actual test. I think there were problems with it on the slower systems.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18443#discussion_r1536253617

From aivanov at openjdk.org  Fri Mar 22 21:48:33 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Fri, 22 Mar 2024 21:48:33 GMT
Subject: RFR: 8327137: Add test for ConcurrentModificationException in
 BasicDirectoryModel [v3]
In-Reply-To: <yhqPAJ3HPjy7RrrmTSNbkPIIgnndqaNkqN4cwsJYd6A=.121a9971-5f09-4977-847a-8971d7a359e5@github.com>
References: <mCqqjrXVWDB2PvpOhKHx-Hr8W6tUz6v4stztGmyAeEg=.1f95da1c-e1a5-40be-be8b-0758729fa9b9@github.com>
 <HvJ96YzIfnTtdNh7R5XtYs_t0sc5VfHjBHUxi9uyJdI=.94715923-e3c0-4666-9a51-340ef91b8b3b@github.com>
 <V1fPYAjQ6U8TFSOTRQ-Fk9dRnFAwbimWAPUkicxtklk=.6fe019f2-a478-4e11-8c02-b606f8f14709@github.com>
 <Chb_zgl53KY05-E3fKBAF61S8SO4Bi7LMlGkART_3io=.7845c015-4fd7-4ce5-bf27-7994cbf2471a@github.com>
 <d5JjW3jU1caR7NXz_sfQ78zXMSmxqLi_ony4WorDSh8=.5122b277-8ddc-40a0-a6ec-a5ae6226246b@github.com>
 <yhqPAJ3HPjy7RrrmTSNbkPIIgnndqaNkqN4cwsJYd6A=.121a9971-5f09-4977-847a-8971d7a359e5@github.com>
Message-ID: <6d2hOVnBZtRQHhxPoA6sHpdeIvH32SwJ0HZavVCP33E=.c6d37335-0420-467b-83aa-129abd47fd87@github.com>

On Fri, 22 Mar 2024 21:05:09 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

> > Instantiating JFileChooser on EDT adds complexity for no benefit. The JFileChooser is still accessed concurrently from several threads, including Swing internal thread.
> 
> But still, this is a common requirement to create UI components on EDT, and that will replicate more or less how it will work in the application.

And it is a common requirement ***not** to call `fileChooser.rescanCurrentDirectory` concurrently* in 5 different threads. So it does not apply.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18109#discussion_r1536253490

From dnguyen at openjdk.org  Fri Mar 22 22:15:48 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Fri, 22 Mar 2024 22:15:48 GMT
Subject: RFR: 8328370: Convert java/awt/print/Dialog/PrintApplet.java
 applet test to main [v5]
In-Reply-To: <Je7yOnjOAjH3DsIgUx72_7ASxsrXS5oIskdKM716AiA=.f1a73b22-8644-40cc-91d6-9ce301f03cc2@github.com>
References: <Je7yOnjOAjH3DsIgUx72_7ASxsrXS5oIskdKM716AiA=.f1a73b22-8644-40cc-91d6-9ce301f03cc2@github.com>
Message-ID: <VwPkRZd5w_qcgrXNrxP_NLTxCaT1yKDvyYzy8FmOcRk=.f5b51e35-e0a2-42b1-84f2-bbe2b862b2d8@github.com>

> Convert java/awt/print/Dialog/PrintApplet.java applet test to main using PassFailJFrame. Also rename the test to PrintModalDialog.java since this is no longer an applet. Added test instructions related to the linked JBS issue.

Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:

  Move tags

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18362/files
  - new: https://git.openjdk.org/jdk/pull/18362/files/38eb00eb..6cc7fab8

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18362&range=04
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18362&range=03-04

  Stats: 20 lines in 1 file changed: 10 ins; 10 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18362.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18362/head:pull/18362

PR: https://git.openjdk.org/jdk/pull/18362

From honkar at openjdk.org  Fri Mar 22 22:29:41 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Fri, 22 Mar 2024 22:29:41 GMT
Subject: RFR: 8328370: Convert java/awt/print/Dialog/PrintApplet.java
 applet test to main [v5]
In-Reply-To: <VwPkRZd5w_qcgrXNrxP_NLTxCaT1yKDvyYzy8FmOcRk=.f5b51e35-e0a2-42b1-84f2-bbe2b862b2d8@github.com>
References: <Je7yOnjOAjH3DsIgUx72_7ASxsrXS5oIskdKM716AiA=.f1a73b22-8644-40cc-91d6-9ce301f03cc2@github.com>
 <VwPkRZd5w_qcgrXNrxP_NLTxCaT1yKDvyYzy8FmOcRk=.f5b51e35-e0a2-42b1-84f2-bbe2b862b2d8@github.com>
Message-ID: <QRAqqeYtSSnyn9aLPIGHJh6vp58MBJep-I36lh0Jatg=.2f5fa9c2-a3b8-415b-a900-ea524438d755@github.com>

On Fri, 22 Mar 2024 22:15:48 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

>> Convert java/awt/print/Dialog/PrintApplet.java applet test to main using PassFailJFrame. Also rename the test to PrintModalDialog.java since this is no longer an applet. Added test instructions related to the linked JBS issue.
>
> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Move tags

Updated changes look good. Updated Test Instructions clearer now.

test/jdk/java/awt/print/Dialog/PrintModalDialog.java line 67:

> 65:                 .title("PrintModalDialog Instructions")
> 66:                 .instructions(INSTRUCTIONS)
> 67:                 .rows(20)

Suggestion:

                .rows((int) INSTRUCTIONS.lines().count() + 1)

-------------

Marked as reviewed by honkar (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18362#pullrequestreview-1955882723
PR Review Comment: https://git.openjdk.org/jdk/pull/18362#discussion_r1536278274

From dnguyen at openjdk.org  Fri Mar 22 22:34:31 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Fri, 22 Mar 2024 22:34:31 GMT
Subject: RFR: 8328370: Convert java/awt/print/Dialog/PrintApplet.java
 applet test to main [v6]
In-Reply-To: <Je7yOnjOAjH3DsIgUx72_7ASxsrXS5oIskdKM716AiA=.f1a73b22-8644-40cc-91d6-9ce301f03cc2@github.com>
References: <Je7yOnjOAjH3DsIgUx72_7ASxsrXS5oIskdKM716AiA=.f1a73b22-8644-40cc-91d6-9ce301f03cc2@github.com>
Message-ID: <W5T4GIv2JtMx9dKY14I506C5N75_bTyIvB620CGrC6o=.ff579cd3-3fad-4b64-a843-2bf78c11c654@github.com>

> Convert java/awt/print/Dialog/PrintApplet.java applet test to main using PassFailJFrame. Also rename the test to PrintModalDialog.java since this is no longer an applet. Added test instructions related to the linked JBS issue.

Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:

  Update rows

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18362/files
  - new: https://git.openjdk.org/jdk/pull/18362/files/6cc7fab8..b8968d09

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18362&range=05
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18362&range=04-05

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/18362.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18362/head:pull/18362

PR: https://git.openjdk.org/jdk/pull/18362

From dnguyen at openjdk.org  Fri Mar 22 23:12:29 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Fri, 22 Mar 2024 23:12:29 GMT
Subject: Integrated: 8328370: Convert java/awt/print/Dialog/PrintApplet.java
 applet test to main
In-Reply-To: <Je7yOnjOAjH3DsIgUx72_7ASxsrXS5oIskdKM716AiA=.f1a73b22-8644-40cc-91d6-9ce301f03cc2@github.com>
References: <Je7yOnjOAjH3DsIgUx72_7ASxsrXS5oIskdKM716AiA=.f1a73b22-8644-40cc-91d6-9ce301f03cc2@github.com>
Message-ID: <iCOjWZPWJK0xl9H2h4eVB4styog348jHOkGgqMREpBw=.cb65454c-6237-4338-87fe-da288e6cf646@github.com>

On Mon, 18 Mar 2024 20:50:59 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

> Convert java/awt/print/Dialog/PrintApplet.java applet test to main using PassFailJFrame. Also rename the test to PrintModalDialog.java since this is no longer an applet. Added test instructions related to the linked JBS issue.

This pull request has now been integrated.

Changeset: 476421ef
Author:    Damon Nguyen <dnguyen at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/476421efe574eca6ba92aaa7fc86dfca99fdd7b2
Stats:     298 lines in 3 files changed: 127 ins; 171 del; 0 mod

8328370: Convert java/awt/print/Dialog/PrintApplet.java applet test to main

Reviewed-by: honkar, psadhukhan

-------------

PR: https://git.openjdk.org/jdk/pull/18362

From psadhukhan at openjdk.org  Sat Mar 23 08:13:22 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Sat, 23 Mar 2024 08:13:22 GMT
Subject: RFR: 8328561: test
 java/awt/Robot/ManualInstructions/ManualInstructions.java isn't used
In-Reply-To: <ABW2Bldb5eN2as1Jb7G7lFW1ULTIizQwTaHQTORhLnc=.02516bdc-9b01-4748-b80e-fa54b0b8996e@github.com>
References: <ABW2Bldb5eN2as1Jb7G7lFW1ULTIizQwTaHQTORhLnc=.02516bdc-9b01-4748-b80e-fa54b0b8996e@github.com>
Message-ID: <yngM5VrUFUvO_QotDwBofds1j2M_VpD9OxhfRYfLoEc=.73491056-52c5-4da7-9c58-8c53dbf44a27@github.com>

On Thu, 21 Mar 2024 20:00:48 GMT, Phil Race <prr at openjdk.org> wrote:

> I don't know why this file is checked in. It has no @test tag and doesn't do anything. I am deleting it.

Should we also remove test/jdk/java/awt/Mouse/MouseModifiersUnitTest/ModifierPermutation.java which also does not have @test tag and added for same product fix JDK-6315717?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18440#issuecomment-2016406188

From psadhukhan at openjdk.org  Sat Mar 23 08:19:23 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Sat, 23 Mar 2024 08:19:23 GMT
Subject: RFR: 8328719: Convert java/awt/print/PageFormat/SetOrient.html
 applet test to main
In-Reply-To: <Bl4gv5IxCey90n1pVzaEsbrztrXkt5Ixksx2E6ul0AI=.4c598589-ce3c-4a7e-a417-3f2e1f54b3cb@github.com>
References: <Bl4gv5IxCey90n1pVzaEsbrztrXkt5Ixksx2E6ul0AI=.4c598589-ce3c-4a7e-a417-3f2e1f54b3cb@github.com>
Message-ID: <uMVhwiHK2j58FlxKGeRnEZ-YubgPJEKnRsWLWfvWDCE=.c0c39a1b-4899-4ec5-81d8-dacf447d8f2f@github.com>

On Fri, 22 Mar 2024 18:55:01 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

> Convert java/awt/print/PageFormat/SetOrient.html applet test to main using PassFailJFrame.

Marked as reviewed by psadhukhan (Reviewer).

test/jdk/java/awt/print/PageFormat/SetOrient.java line 106:

> 104:             pjob.print();
> 105:         } catch (PrinterException e) {
> 106:             throw new RuntimeException(e.getMessage());

In other PRs, I guess we do


 ex.printStackTrace();
                    String msg = "PrinterException: " + ex.getMessage();
                    PassFailJFrame.forceFail(msg);

-------------

PR Review: https://git.openjdk.org/jdk/pull/18462#pullrequestreview-1956340700
PR Review Comment: https://git.openjdk.org/jdk/pull/18462#discussion_r1536593630

From psadhukhan at openjdk.org  Sat Mar 23 08:26:24 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Sat, 23 Mar 2024 08:26:24 GMT
Subject: RFR: 8328730: Convert java/awt/print/bug8023392/bug8023392.html
 applet test to main [v2]
In-Reply-To: <snIQJo9DJUrVkenZLQERlr35Lm2-IreJNVZgf7D9ucI=.69960d03-894a-4c85-b38c-301e5ee838f9@github.com>
References: <Mn57TSPJZir2IqthGrBOcW_GBsOMPq514q9Ds7AFhy8=.da0ef4a4-b351-4c6d-beaf-a827d1c88385@github.com>
 <snIQJo9DJUrVkenZLQERlr35Lm2-IreJNVZgf7D9ucI=.69960d03-894a-4c85-b38c-301e5ee838f9@github.com>
Message-ID: <K2mbG3hS0a-ME2iAm0rywEgE5mAvc22tB_TOZ_1JOpM=.f431f2eb-fe64-4ebb-9d16-44a5a2d6cb95@github.com>

On Fri, 22 Mar 2024 17:38:36 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

>> Convert java/awt/print/bug8023392/bug8023392.html applet test to main using PassFailJFrame
>
> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Move test out of extra dir

test/jdk/java/awt/print/bug8023392.java line 116:

> 114:                 @Override
> 115:                 protected void paintComponent(Graphics g) {
> 116:                     SwingUtilities2.drawChars(this, g, s.toCharArray(),

cant we use `Graphics.drawChars` instead in all places `SwingUtilities2.drawChars` is used?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18458#discussion_r1536594819

From prr at openjdk.org  Sat Mar 23 23:41:23 2024
From: prr at openjdk.org (Phil Race)
Date: Sat, 23 Mar 2024 23:41:23 GMT
Subject: RFR: 8328827: Convert
 java/awt/print/PrinterJob/PrinterDialogsModalityTest/PrinterDialogsModalityTest.html
 applet test to main
In-Reply-To: <2iwbuovZ9rGwS8EqkKiSvnxU3_eJI-5KHFngpMs4qtE=.89885458-b5e0-48da-9810-4cfe71c9a420@github.com>
References: <2iwbuovZ9rGwS8EqkKiSvnxU3_eJI-5KHFngpMs4qtE=.89885458-b5e0-48da-9810-4cfe71c9a420@github.com>
Message-ID: <9Ws8y7MzFgDR21NTpfU6I5GNat1ZAg9ATtDAnJnwfvo=.87e64e44-b706-4b45-a002-6ef374c09397@github.com>

On Fri, 22 Mar 2024 18:06:59 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

> Convert java/awt/print/PrinterJob/PrinterDialogsModalityTest/PrinterDialogsModalityTest.html applet test to main using PassFailJFrame

Marked as reviewed by prr (Reviewer).

test/jdk/java/awt/print/PrinterJob/PrinterDialogsModalityTest.java line 49:

> 47:              with two buttons: "Page Dialog" and "Print Dialog".
> 48:              1. Make the "Test Frame" active by clicking on title.
> 49:              2. Press "Page Dialog" button and a page dailog should popup.

dailog -> dialog

test/jdk/java/awt/print/PrinterJob/PrinterDialogsModalityTest.java line 68:

> 66:                 .title("PrinterDialogsModalityTest Test Instructions")
> 67:                 .instructions(INSTRUCTIONS)
> 68:                 .rows((int) INSTRUCTIONS.lines().count() + 2)

Oh, that's a nice idea. I'd been tweaking by hand.

-------------

PR Review: https://git.openjdk.org/jdk/pull/18461#pullrequestreview-1956449159
PR Review Comment: https://git.openjdk.org/jdk/pull/18461#discussion_r1536708437
PR Review Comment: https://git.openjdk.org/jdk/pull/18461#discussion_r1536708440

From prr at openjdk.org  Sat Mar 23 23:47:23 2024
From: prr at openjdk.org (Phil Race)
Date: Sat, 23 Mar 2024 23:47:23 GMT
Subject: RFR: 8328385: Convert java/awt/FileDialog/FileDialogReturnTest
 test to main [v4]
In-Reply-To: <AdJgYXvOYQ3YDjLORme_DH00H82MnGjgfC5pVn5Ps1I=.fd5c28bf-1758-4fde-8734-1a8df9f737a1@github.com>
References: <fqHwY3Ipk9ArGTOnM26LF_dxWaQeptZ8Kf9fKNWUPVg=.43700ff8-5123-444a-817d-173bd126368d@github.com>
 <AdJgYXvOYQ3YDjLORme_DH00H82MnGjgfC5pVn5Ps1I=.fd5c28bf-1758-4fde-8734-1a8df9f737a1@github.com>
Message-ID: <g_O_zXcha63RhjgX5H00MD7s9knKr8h1wxj-5gt6Rag=.614e2d96-17aa-46fd-af8f-ac4b0431b57f@github.com>

On Wed, 20 Mar 2024 18:37:45 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

>> Convert test to a main method based;
>> Move test to an apropriate location;
>> Remove old files;
>
> Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove .html from the @test clause

Marked as reviewed by prr (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18363#pullrequestreview-1956449728

From prr at openjdk.org  Sat Mar 23 23:51:25 2024
From: prr at openjdk.org (Phil Race)
Date: Sat, 23 Mar 2024 23:51:25 GMT
Subject: RFR: 8328403: Remove applet usage from JColorChooser tests
 Test6977726 [v2]
In-Reply-To: <5A204R9Q4Xm8u41OcYVqOZi2XwrooEeYV8vupQ8W9gc=.741ff049-a0bf-488a-be29-1d8b5f04a24b@github.com>
References: <pyfxVdApSNSisMJieBTl5HSZKDmSSiPie0tnrM_rwe4=.5ffc4e92-cbcf-44d8-9a51-b4e8330e1be9@github.com>
 <hPfifnK0UnpXOEtu8Jmp91oFwC_VyjuJeu9CDPQbvaw=.544c5d8c-633e-46b1-855f-c41543164dea@github.com>
 <5A204R9Q4Xm8u41OcYVqOZi2XwrooEeYV8vupQ8W9gc=.741ff049-a0bf-488a-be29-1d8b5f04a24b@github.com>
Message-ID: <7VXbq1F80tQCM908_-tSB4ZPc5R3uQy_YVrfUV1PoZg=.5125f077-0ca9-4647-926b-ad879413ef84@github.com>

On Thu, 21 Mar 2024 13:59:42 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   spacing
>
> test/jdk/javax/swing/JColorChooser/Test6977726.java line 43:
> 
>> 41:                 .title("Test6977726")
>> 42:                 .instructions("Check that there is an empty panel " +
>> 43:                         "titled \"Preview\" in the JColorChooser.")
> 
>>there is an empty panel
> 
> This doesn't seem to be right, originally it was `If you don't see the preview panel, then test failed, otherwise it passed.`
> The preview panel is not empty, it has barely visible white text.
> ![image](https://github.com/openjdk/jdk/assets/77687766/4d8706f6-1d7f-4229-9a20-bcaf85bb7737)

yep, the instructions need to be as they were in the applet.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18369#discussion_r1536709452

From prr at openjdk.org  Sat Mar 23 23:54:21 2024
From: prr at openjdk.org (Phil Race)
Date: Sat, 23 Mar 2024 23:54:21 GMT
Subject: RFR: 8328562: Convert
 java/awt/InputMethods/DiacriticsTest/DiacriticsTest.java applet test to main
 [v2]
In-Reply-To: <eUWW4ogTYjEFrcVziWMzKV3a_0rPjxu4pC1hCcBvJAo=.1e5a2146-9598-499e-ae93-4eb6ebc85f90@github.com>
References: <dwZXmqAjKVfX0Z4xfEfCJvsNmm7pOSYZTOk30-vPIF8=.0e29c1cf-580c-4898-9b94-7aaddec86add@github.com>
 <eUWW4ogTYjEFrcVziWMzKV3a_0rPjxu4pC1hCcBvJAo=.1e5a2146-9598-499e-ae93-4eb6ebc85f90@github.com>
Message-ID: <R8RMmwH-MB6IeaxAJtcd6bph1Muqi1b2GKpJHEWhvUo=.0ac46ca0-1560-4dfe-8128-956a3dc2e619@github.com>

On Thu, 21 Mar 2024 11:37:36 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>> Test converted to main.
>> Instructions split to Windows and Linux, with some clarifications.
>> The test runs successfully on Windows and Linux.
>
> Alexander Zvegintsev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   minor spacing

This test looks to be a good example why we should be considering a new jtreg key like
@key keyboard
or
@key locale

-------------

Marked as reviewed by prr (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18388#pullrequestreview-1956450230

From prr at openjdk.org  Sun Mar 24 00:03:21 2024
From: prr at openjdk.org (Phil Race)
Date: Sun, 24 Mar 2024 00:03:21 GMT
Subject: RFR: 8316324: Opensource five miscellaneous Swing tests
In-Reply-To: <sHsW7LXGy912f6z8g0PFOf9YXAbbWkbPSxTPuLvxGsY=.6fac48ce-4b77-4f1f-91d7-be87d2967eda@github.com>
References: <2GNSvcn0o7_d4Gca1TkUmz3M2gTtjg2lF8guEq2V8Bs=.cd4c564a-b089-4a8e-b582-b778a73b0329@github.com>
 <sHsW7LXGy912f6z8g0PFOf9YXAbbWkbPSxTPuLvxGsY=.6fac48ce-4b77-4f1f-91d7-be87d2967eda@github.com>
Message-ID: <RsgpcgfbYimzfgv5gTxH5YQaMJFqOqySvCj85yeFyNQ=.5db600c0-5c84-4fc3-9144-560abea98658@github.com>

On Fri, 22 Mar 2024 08:54:07 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Clean up and opensource five tests.
>
> test/jdk/javax/swing/InputVerifier/bug4774166.java line 229:
> 
>> 227:     public void cleanupGUI() {
>> 228:         if (testframe != null) {
>> 229:             testframe.setVisible(false);
> 
> `testframe.setVisible(false);` is required here? Any advantage for setting the visibility to false ? anyhow its been disposed.....

Not harmful, but not needed either.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18443#discussion_r1536710591

From prr at openjdk.org  Sun Mar 24 00:03:22 2024
From: prr at openjdk.org (Phil Race)
Date: Sun, 24 Mar 2024 00:03:22 GMT
Subject: RFR: 8316324: Opensource five miscellaneous Swing tests
In-Reply-To: <U_EAFQnZRisJb2sNWmMrFMmjmjume14YSyw83VZJzIk=.e87572fb-7fa2-47ba-9115-6c57310a1aad@github.com>
References: <2GNSvcn0o7_d4Gca1TkUmz3M2gTtjg2lF8guEq2V8Bs=.cd4c564a-b089-4a8e-b582-b778a73b0329@github.com>
 <7F76CExWTIR2A-yyd3q5McROglv7yv8Zb-6H9Juu8AQ=.cb569ed1-6a5c-45df-a66b-b2d6c1e67064@github.com>
 <U_EAFQnZRisJb2sNWmMrFMmjmjume14YSyw83VZJzIk=.e87572fb-7fa2-47ba-9115-6c57310a1aad@github.com>
Message-ID: <dyh22NecBLK8bRhDx0w1jeczprjiI7YnX9RgRmFRMyo=.c05a35cd-bae9-4496-b2a0-80b1a464180b@github.com>

On Fri, 22 Mar 2024 21:39:43 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

>> test/jdk/javax/swing/JButton/4385611/bug4385611.java line 42:
>> 
>>> 40: public class bug4385611 {
>>> 41:     static JButton bt1, bt2;
>>> 42:     static final ImageIcon icon32x32 = new ImageIcon(bug4385611.class.getResource("red.gif"));
>> 
>> did you verify if we are allowed to keep this red.gif in open source as per the image license? Can we not create the Imageicon from a yellow32x32 bufferedimage?
>
> It is just a gif file filled with yellow color created specifically for that test. It was not provided by the test submitter or anything like that - it was just created in the graphics editor. There's no copyright issue with it.

yeah, but the question is not about the provenance of the file. It is just easier if the test is self-contained.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18443#discussion_r1536710511

From prr at openjdk.org  Sun Mar 24 00:07:22 2024
From: prr at openjdk.org (Phil Race)
Date: Sun, 24 Mar 2024 00:07:22 GMT
Subject: RFR: 8079786: [macosx] Test
 java/awt/Frame/DisposeParentGC/DisposeParentGC.java fails for Mac only [v2]
In-Reply-To: <m8IHgmP98mvimCxhHeBY_PGPmNFgPWFrC2Kuz8tDvFY=.5fc3b08d-0233-4d72-a72c-5973f286b069@github.com>
References: <V4kCCaNFvjkksOfHuAK5Dn1-oJdzkxTBnLwLEVdINnw=.9fa30373-f8e8-4656-9e52-775e2a3aeed1@github.com>
 <m8IHgmP98mvimCxhHeBY_PGPmNFgPWFrC2Kuz8tDvFY=.5fc3b08d-0233-4d72-a72c-5973f286b069@github.com>
Message-ID: <1_QCUNsrZAeIg6-mutMZeWxRrPNv6Ghh0ta_j32f2G0=.5eea636e-55f0-4baa-8ec5-1051e0e46f86@github.com>

On Fri, 22 Mar 2024 16:07:36 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Test is now passing in mac..Several iterations of the test passed in CI system..link in JBS...deproblemlisted...
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   spacing

So no changes to the test except for formatting ?
But it now passes ? Could be it has passed for many years.
We'll see how it does in CI over the long term.

-------------

Marked as reviewed by prr (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18449#pullrequestreview-1956451065

From prr at openjdk.org  Sun Mar 24 00:14:21 2024
From: prr at openjdk.org (Phil Race)
Date: Sun, 24 Mar 2024 00:14:21 GMT
Subject: RFR: 8328482: Convert and Open source few manual applet test to
 main based [v2]
In-Reply-To: <KfNyf2ktuwn4hIH_1Ve8RIhJTLtQqp7XH_EN7N-_JXY=.1eee2c10-fa2a-41eb-a40d-f9ac82759ac5@github.com>
References: <aV9yYWUEsrakxmujJCq2LzFg5K6nyCV4aELge8c1oJo=.c9f2c13d-337f-4af3-8a38-551a7f0ba0c6@github.com>
 <KfNyf2ktuwn4hIH_1Ve8RIhJTLtQqp7XH_EN7N-_JXY=.1eee2c10-fa2a-41eb-a40d-f9ac82759ac5@github.com>
Message-ID: <IfwAW2hPU8gVBCCEnQOomWjwzrTuvX-hfSLWYfdh9sw=.727f1488-3d60-49aa-b843-2272081f432b@github.com>

On Fri, 22 Mar 2024 10:02:49 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Convert and open source these manual applet test to main based:
>> java/awt/Frame/MegaIconTest/MegaIconTest.html
>> java/awt/Frame/FrameMaximizedTest/FrameMaximizedTest.html
>> java/awt/Frame/FrameMinimizeTest/FrameMinimizeTest.html
>> java/awt/Frame/SizeMinimizedTest/SizeMinimizedTest.html
>
> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Updated regtesthelpers path

The images here are very problematic. I do not think they can be open-sourced.
You will need to remove these from the PR (ASAP) and replace them with something else.
The duke one is OK tho'

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18448#issuecomment-2016639114

From tr at openjdk.org  Sun Mar 24 12:21:52 2024
From: tr at openjdk.org (Tejesh R)
Date: Sun, 24 Mar 2024 12:21:52 GMT
Subject: RFR: 8328482: Convert and Open source few manual applet test to
 main based [v3]
In-Reply-To: <aV9yYWUEsrakxmujJCq2LzFg5K6nyCV4aELge8c1oJo=.c9f2c13d-337f-4af3-8a38-551a7f0ba0c6@github.com>
References: <aV9yYWUEsrakxmujJCq2LzFg5K6nyCV4aELge8c1oJo=.c9f2c13d-337f-4af3-8a38-551a7f0ba0c6@github.com>
Message-ID: <Pi6RvL9Fn2ID3Biiiw3BSJF6kCmnMb2jRJlQgK4jVoQ=.c768550e-5e11-40ee-aa74-2f6afc486d8a@github.com>

> Convert and open source these manual applet test to main based:
> java/awt/Frame/MegaIconTest/MegaIconTest.html
> java/awt/Frame/FrameMaximizedTest/FrameMaximizedTest.html
> java/awt/Frame/FrameMinimizeTest/FrameMinimizeTest.html
> java/awt/Frame/SizeMinimizedTest/SizeMinimizedTest.html

Tejesh R has updated the pull request incrementally with three additional commits since the last revision:

 - Images updated
 - Frame position updates
 - removed headful tag

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18448/files
  - new: https://git.openjdk.org/jdk/pull/18448/files/433086cb..40c89e96

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18448&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18448&range=01-02

  Stats: 13 lines in 6 files changed: 0 ins; 10 del; 3 mod
  Patch: https://git.openjdk.org/jdk/pull/18448.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18448/head:pull/18448

PR: https://git.openjdk.org/jdk/pull/18448

From tr at openjdk.org  Mon Mar 25 05:16:22 2024
From: tr at openjdk.org (Tejesh R)
Date: Mon, 25 Mar 2024 05:16:22 GMT
Subject: RFR: 8328717: Convert
 javax/swing/JColorChooser/8065098/bug8065098.java applet test to main [v2]
In-Reply-To: <nPExjs6ScZjBLdFZU4O_5cr2QLR9YPAfoc5wajWmgYI=.eb0060bd-35e4-45a4-9cad-730ca56a3cfc@github.com>
References: <SZLE6sOQUNGW_tBIfu6MkZE7rxjp5HJGZih6X50rrpw=.231ba8d7-c9cb-4dc9-b27a-62060696d0a1@github.com>
 <nPExjs6ScZjBLdFZU4O_5cr2QLR9YPAfoc5wajWmgYI=.eb0060bd-35e4-45a4-9cad-730ca56a3cfc@github.com>
Message-ID: <zLRF6V1PCYw4FSnDqDqACWrDxw9gwT99bNLObM__YZI=.463767b6-a8cf-414c-91c2-374d91b2f41a@github.com>

On Fri, 22 Mar 2024 08:48:35 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

>> Convert javax/swing/JColorChooser/8065098/bug8065098.java applet test to main using PassFailJFrame for the instructions.
>
> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update copyright year

Marked as reviewed by tr (Committer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18436#pullrequestreview-1956884943

From jwaters at openjdk.org  Mon Mar 25 06:02:06 2024
From: jwaters at openjdk.org (Julian Waters)
Date: Mon, 25 Mar 2024 06:02:06 GMT
Subject: RFR: 8307160: Fix AWT/2D/A11Y to support the permissive- flag on
 the Microsoft Visual C compiler [v53]
In-Reply-To: <7piLRto5nNbhYYYfENCr5ecm4M2xNtMkjkE8XhrLLQ0=.8fd1ac3a-46f8-47a8-ae37-a4abbf7757d9@github.com>
References: <7piLRto5nNbhYYYfENCr5ecm4M2xNtMkjkE8XhrLLQ0=.8fd1ac3a-46f8-47a8-ae37-a4abbf7757d9@github.com>
Message-ID: <syIG2SX4JIOzLMJ2XzSDxYy-wlz7fay2_jt31UZQmHE=.cfb33dbc-c60f-47bd-a330-505fc3fdb415@github.com>

> We should set the -permissive- flag for the Microsoft Visual C compiler, as was requested by the now backed out [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). Doing so makes the Visual C compiler much less accepting of ill formed code, which will improve code quality on Windows in the future.

Julian Waters has updated the pull request incrementally with one additional commit since the last revision:

  Revert formatting in src/java.desktop/windows/native/libawt/windows/awt_Window.cpp
  
  Co-authored-by: Magnus Ihse Bursie <mag at icus.se>

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/15096/files
  - new: https://git.openjdk.org/jdk/pull/15096/files/0439b138..663a7f34

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=15096&range=52
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=15096&range=51-52

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/15096.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/15096/head:pull/15096

PR: https://git.openjdk.org/jdk/pull/15096

From jwaters at openjdk.org  Mon Mar 25 06:02:06 2024
From: jwaters at openjdk.org (Julian Waters)
Date: Mon, 25 Mar 2024 06:02:06 GMT
Subject: RFR: 8307160: Fix AWT/2D/A11Y to support the permissive- flag on
 the Microsoft Visual C compiler [v52]
In-Reply-To: <0p1UVaUOt2bs1mkuBV1liUxBYGRhnKnclf1x_-Y22GE=.2de6c2c4-8cf5-470d-bdb3-cd0dd0e13975@github.com>
References: <7piLRto5nNbhYYYfENCr5ecm4M2xNtMkjkE8XhrLLQ0=.8fd1ac3a-46f8-47a8-ae37-a4abbf7757d9@github.com>
 <0p1UVaUOt2bs1mkuBV1liUxBYGRhnKnclf1x_-Y22GE=.2de6c2c4-8cf5-470d-bdb3-cd0dd0e13975@github.com>
Message-ID: <N-qe81Sj2dD9Jf389FDPidxtXG8VMfn9wwvvh3RdlzU=.db37387f-76f7-4096-a979-2b4a956925ea@github.com>

On Wed, 20 Mar 2024 06:38:59 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> We should set the -permissive- flag for the Microsoft Visual C compiler, as was requested by the now backed out [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). Doing so makes the Visual C compiler much less accepting of ill formed code, which will improve code quality on Windows in the future.
>
> Julian Waters has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Revert Formatting in awt_Component.cpp
>  - Revert Formatting in awt_Window.cpp

Thanks for the clarifications! Makes my job a lot easier. The only thing I'm uncertain about is the pData local, which I don't see much benefit in removing since the null check associated with it still has to remain for code semantics to be correct

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15096#issuecomment-2017282826

From jwaters at openjdk.org  Mon Mar 25 06:02:06 2024
From: jwaters at openjdk.org (Julian Waters)
Date: Mon, 25 Mar 2024 06:02:06 GMT
Subject: RFR: 8307160: Fix AWT/2D/A11Y to support the permissive- flag on
 the Microsoft Visual C compiler [v52]
In-Reply-To: <6_80radA3v1Fq_kuf_4GZ74gfwc8hgMPOyBczHItlKc=.9a2463ef-c106-42c4-b0a8-12f94568ea96@github.com>
References: <7piLRto5nNbhYYYfENCr5ecm4M2xNtMkjkE8XhrLLQ0=.8fd1ac3a-46f8-47a8-ae37-a4abbf7757d9@github.com>
 <0p1UVaUOt2bs1mkuBV1liUxBYGRhnKnclf1x_-Y22GE=.2de6c2c4-8cf5-470d-bdb3-cd0dd0e13975@github.com>
 <6_80radA3v1Fq_kuf_4GZ74gfwc8hgMPOyBczHItlKc=.9a2463ef-c106-42c4-b0a8-12f94568ea96@github.com>
Message-ID: <_sqXHbEck2Qm83hInO5_ITsaBo_dPQpC6yo5HeypcQM=.de02ef0b-ec9b-4c2a-9bb2-fa9a263a227c@github.com>

On Fri, 22 Mar 2024 12:27:31 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> Julian Waters has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Revert Formatting in awt_Component.cpp
>>  - Revert Formatting in awt_Window.cpp
>
> src/java.desktop/windows/native/libawt/windows/awt_PrintJob.cpp line 1230:
> 
>> 1228:     jdouble imgY = (jdouble) ((yPixelOrg * 72)/(jdouble) yPixelRes);
>> 1229:     jdouble imgWid = (jdouble) ((imgPixelWid * 72)/(jdouble) xPixelRes);
>> 1230:     jdouble imgHgt = (jdouble) ((imgPixelHgt * 72)/(jdouble) yPixelRes);
> 
> Suggestion:
> 
>     jdouble imgX = (jdouble)((xPixelOrg * 72)/(jdouble)xPixelRes);
>     jdouble imgY = (jdouble)((yPixelOrg * 72)/(jdouble)yPixelRes);
>     jdouble imgWid = (jdouble)((imgPixelWid * 72)/(jdouble)xPixelRes);
>     jdouble imgHgt = (jdouble)((imgPixelHgt * 72)/(jdouble)yPixelRes);```

I don't think I can commit this as there are 3 backticks at the end there :P

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15096#discussion_r1537089274

From tr at openjdk.org  Mon Mar 25 07:41:23 2024
From: tr at openjdk.org (Tejesh R)
Date: Mon, 25 Mar 2024 07:41:23 GMT
Subject: RFR: 8328719: Convert java/awt/print/PageFormat/SetOrient.html
 applet test to main
In-Reply-To: <Bl4gv5IxCey90n1pVzaEsbrztrXkt5Ixksx2E6ul0AI=.4c598589-ce3c-4a7e-a417-3f2e1f54b3cb@github.com>
References: <Bl4gv5IxCey90n1pVzaEsbrztrXkt5Ixksx2E6ul0AI=.4c598589-ce3c-4a7e-a417-3f2e1f54b3cb@github.com>
Message-ID: <ODNYGB3eDE-mDgGNajXCrhUb4D5fJI5LlmC_rbnj8kE=.3fb3ad9d-9f97-4249-b2d1-2bb4dd351234@github.com>

On Fri, 22 Mar 2024 18:55:01 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

> Convert java/awt/print/PageFormat/SetOrient.html applet test to main using PassFailJFrame.

test/jdk/java/awt/print/PageFormat/SetOrient.java line 46:

> 44: 
> 45: public class SetOrient {
> 46:     static PrinterJob pjob;

Can be moved inside `init()` and even you change the method name since applet is removed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18462#discussion_r1537144154

From tr at openjdk.org  Mon Mar 25 07:45:22 2024
From: tr at openjdk.org (Tejesh R)
Date: Mon, 25 Mar 2024 07:45:22 GMT
Subject: RFR: 8328719: Convert java/awt/print/PageFormat/SetOrient.html
 applet test to main
In-Reply-To: <Bl4gv5IxCey90n1pVzaEsbrztrXkt5Ixksx2E6ul0AI=.4c598589-ce3c-4a7e-a417-3f2e1f54b3cb@github.com>
References: <Bl4gv5IxCey90n1pVzaEsbrztrXkt5Ixksx2E6ul0AI=.4c598589-ce3c-4a7e-a417-3f2e1f54b3cb@github.com>
Message-ID: <-unOAa8CL8nF8mpEN3lBAw8Wuq0hS2j77QwAusFCAco=.b7e54147-02b7-4bda-9a08-93f9606e94c9@github.com>

On Fri, 22 Mar 2024 18:55:01 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

> Convert java/awt/print/PageFormat/SetOrient.html applet test to main using PassFailJFrame.

Since this is a manual test, should we wait for user to input some action like start print or something like that ? Because as soon as the test starts/ printer job is initiated. Instructions are there, but I felt without user starting the test, the test is running as soon as it is executed, is it fine?

-------------

PR Review: https://git.openjdk.org/jdk/pull/18462#pullrequestreview-1957037239

From ihse at openjdk.org  Mon Mar 25 09:01:47 2024
From: ihse at openjdk.org (Magnus Ihse Bursie)
Date: Mon, 25 Mar 2024 09:01:47 GMT
Subject: RFR: 8307160: Fix AWT/2D/A11Y to support the permissive- flag on
 the Microsoft Visual C compiler [v52]
In-Reply-To: <_sqXHbEck2Qm83hInO5_ITsaBo_dPQpC6yo5HeypcQM=.de02ef0b-ec9b-4c2a-9bb2-fa9a263a227c@github.com>
References: <7piLRto5nNbhYYYfENCr5ecm4M2xNtMkjkE8XhrLLQ0=.8fd1ac3a-46f8-47a8-ae37-a4abbf7757d9@github.com>
 <0p1UVaUOt2bs1mkuBV1liUxBYGRhnKnclf1x_-Y22GE=.2de6c2c4-8cf5-470d-bdb3-cd0dd0e13975@github.com>
 <6_80radA3v1Fq_kuf_4GZ74gfwc8hgMPOyBczHItlKc=.9a2463ef-c106-42c4-b0a8-12f94568ea96@github.com>
 <_sqXHbEck2Qm83hInO5_ITsaBo_dPQpC6yo5HeypcQM=.de02ef0b-ec9b-4c2a-9bb2-fa9a263a227c@github.com>
Message-ID: <x9lWvpa2mjoGwY8cXF74c9MZoOM5LTS0kWKPDcY396c=.5d853b1d-f9cd-4722-b05c-941ac7cffba2@github.com>

On Mon, 25 Mar 2024 05:58:41 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> src/java.desktop/windows/native/libawt/windows/awt_PrintJob.cpp line 1230:
>> 
>>> 1228:     jdouble imgY = (jdouble) ((yPixelOrg * 72)/(jdouble) yPixelRes);
>>> 1229:     jdouble imgWid = (jdouble) ((imgPixelWid * 72)/(jdouble) xPixelRes);
>>> 1230:     jdouble imgHgt = (jdouble) ((imgPixelHgt * 72)/(jdouble) yPixelRes);
>> 
>> Suggestion:
>> 
>>     jdouble imgX = (jdouble)((xPixelOrg * 72)/(jdouble)xPixelRes);
>>     jdouble imgY = (jdouble)((yPixelOrg * 72)/(jdouble)yPixelRes);
>>     jdouble imgWid = (jdouble)((imgPixelWid * 72)/(jdouble)xPixelRes);
>>     jdouble imgHgt = (jdouble)((imgPixelHgt * 72)/(jdouble)yPixelRes);```
>
> I don't think I can commit this as there are 3 backticks at the end there :P

Apologies. The point was that this was formatting changes that were not needed and should be reverted.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15096#discussion_r1537238932

From ihse at openjdk.org  Mon Mar 25 09:05:43 2024
From: ihse at openjdk.org (Magnus Ihse Bursie)
Date: Mon, 25 Mar 2024 09:05:43 GMT
Subject: RFR: 8307160: Fix AWT/2D/A11Y to support the permissive- flag on
 the Microsoft Visual C compiler [v52]
In-Reply-To: <N-qe81Sj2dD9Jf389FDPidxtXG8VMfn9wwvvh3RdlzU=.db37387f-76f7-4096-a979-2b4a956925ea@github.com>
References: <7piLRto5nNbhYYYfENCr5ecm4M2xNtMkjkE8XhrLLQ0=.8fd1ac3a-46f8-47a8-ae37-a4abbf7757d9@github.com>
 <0p1UVaUOt2bs1mkuBV1liUxBYGRhnKnclf1x_-Y22GE=.2de6c2c4-8cf5-470d-bdb3-cd0dd0e13975@github.com>
 <N-qe81Sj2dD9Jf389FDPidxtXG8VMfn9wwvvh3RdlzU=.db37387f-76f7-4096-a979-2b4a956925ea@github.com>
Message-ID: <rvcdKMR7EYsspYcH1OX2_x4zC43WDQK9c70qt2Cl-CI=.1658a8f0-f530-44fc-aa47-493482d57c50@github.com>

On Mon, 25 Mar 2024 05:56:52 GMT, Julian Waters <jwaters at openjdk.org> wrote:

> The only thing I'm uncertain about is the pData local, which I don't see much benefit in removing since the null check associated with it still has to remain for code semantics to be correct

The point is that you can do the null check on the correct variable directly, instead of going a detour with pData. So instead of:


RealType realVal;
void* pData = getVal()
if (pData == null) {
  // bail out
}
realVal = (RealType) pData;


you can just do:


RealType realVal = getVal();
if (realVal == null) {
  // bail out
}


as the code normally would have been written, had there not been an old macro that used the "magic" temporary pData variable.

This is a recurring pattern in this patch and needs to be fixed everywhere.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15096#issuecomment-2017510861

From psadhukhan at openjdk.org  Mon Mar 25 10:14:26 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Mon, 25 Mar 2024 10:14:26 GMT
Subject: Integrated: 8079786: [macosx] Test
 java/awt/Frame/DisposeParentGC/DisposeParentGC.java fails for Mac only
In-Reply-To: <V4kCCaNFvjkksOfHuAK5Dn1-oJdzkxTBnLwLEVdINnw=.9fa30373-f8e8-4656-9e52-775e2a3aeed1@github.com>
References: <V4kCCaNFvjkksOfHuAK5Dn1-oJdzkxTBnLwLEVdINnw=.9fa30373-f8e8-4656-9e52-775e2a3aeed1@github.com>
Message-ID: <v4mW6IuYrTRiAOWN5cgviNXY7ZGfVO40hHWtYJ46pxY=.2e4b0daa-525a-4d6e-b6a8-54d9b0017b8a@github.com>

On Fri, 22 Mar 2024 09:55:46 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> Test is now passing in mac..Several iterations of the test passed in CI system..link in JBS...deproblemlisted...

This pull request has now been integrated.

Changeset: f67ec19e
Author:    Prasanta Sadhukhan <psadhukhan at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/f67ec19e236e3b4d2d4d4993a7d64b8de052d241
Stats:     34 lines in 2 files changed: 22 ins; 2 del; 10 mod

8079786: [macosx] Test java/awt/Frame/DisposeParentGC/DisposeParentGC.java fails for Mac only

Reviewed-by: prr

-------------

PR: https://git.openjdk.org/jdk/pull/18449

From dnguyen at openjdk.org  Mon Mar 25 16:03:25 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Mon, 25 Mar 2024 16:03:25 GMT
Subject: Integrated: 8328717: Convert
 javax/swing/JColorChooser/8065098/bug8065098.java applet test to main
In-Reply-To: <SZLE6sOQUNGW_tBIfu6MkZE7rxjp5HJGZih6X50rrpw=.231ba8d7-c9cb-4dc9-b27a-62060696d0a1@github.com>
References: <SZLE6sOQUNGW_tBIfu6MkZE7rxjp5HJGZih6X50rrpw=.231ba8d7-c9cb-4dc9-b27a-62060696d0a1@github.com>
Message-ID: <34K3Kl3-rJJ11I7SgvXapug-01BLFC-1MgFgrYjmmrs=.7444e07b-e8da-4356-9f25-f3c3829e57fd@github.com>

On Thu, 21 Mar 2024 16:31:04 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

> Convert javax/swing/JColorChooser/8065098/bug8065098.java applet test to main using PassFailJFrame for the instructions.

This pull request has now been integrated.

Changeset: a1fbbffb
Author:    Damon Nguyen <dnguyen at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/a1fbbffb5e0d7e41a9c3041b7e64382780e86f50
Stats:     86 lines in 3 files changed: 26 ins; 46 del; 14 mod

8328717: Convert javax/swing/JColorChooser/8065098/bug8065098.java applet test to main

Reviewed-by: honkar, tr

-------------

PR: https://git.openjdk.org/jdk/pull/18436

From dnguyen at openjdk.org  Mon Mar 25 16:08:24 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Mon, 25 Mar 2024 16:08:24 GMT
Subject: RFR: 8328730: Convert java/awt/print/bug8023392/bug8023392.html
 applet test to main [v2]
In-Reply-To: <K2mbG3hS0a-ME2iAm0rywEgE5mAvc22tB_TOZ_1JOpM=.f431f2eb-fe64-4ebb-9d16-44a5a2d6cb95@github.com>
References: <Mn57TSPJZir2IqthGrBOcW_GBsOMPq514q9Ds7AFhy8=.da0ef4a4-b351-4c6d-beaf-a827d1c88385@github.com>
 <snIQJo9DJUrVkenZLQERlr35Lm2-IreJNVZgf7D9ucI=.69960d03-894a-4c85-b38c-301e5ee838f9@github.com>
 <K2mbG3hS0a-ME2iAm0rywEgE5mAvc22tB_TOZ_1JOpM=.f431f2eb-fe64-4ebb-9d16-44a5a2d6cb95@github.com>
Message-ID: <6TKKq_cZG4icfSlDAzMiJWPs0yPNd1hzMlQ_tswF08A=.2a6efb82-c7c8-4412-a365-89b40cd02c88@github.com>

On Sat, 23 Mar 2024 08:23:25 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Move test out of extra dir
>
> test/jdk/java/awt/print/bug8023392.java line 116:
> 
>> 114:                 @Override
>> 115:                 protected void paintComponent(Graphics g) {
>> 116:                     SwingUtilities2.drawChars(this, g, s.toCharArray(),
> 
> cant we use `Graphics.drawChars` instead in all places `SwingUtilities2.drawChars` is used?

`Graphics.drawChars` isn't a static method, which will require additional changes to this test. Is it preferred to use `Graphics` over the `SwingUtilities2` version?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18458#discussion_r1537844651

From kizune at openjdk.org  Mon Mar 25 16:18:31 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Mon, 25 Mar 2024 16:18:31 GMT
Subject: RFR: 8316324: Opensource five miscellaneous Swing tests
In-Reply-To: <RsgpcgfbYimzfgv5gTxH5YQaMJFqOqySvCj85yeFyNQ=.5db600c0-5c84-4fc3-9144-560abea98658@github.com>
References: <2GNSvcn0o7_d4Gca1TkUmz3M2gTtjg2lF8guEq2V8Bs=.cd4c564a-b089-4a8e-b582-b778a73b0329@github.com>
 <sHsW7LXGy912f6z8g0PFOf9YXAbbWkbPSxTPuLvxGsY=.6fac48ce-4b77-4f1f-91d7-be87d2967eda@github.com>
 <RsgpcgfbYimzfgv5gTxH5YQaMJFqOqySvCj85yeFyNQ=.5db600c0-5c84-4fc3-9144-560abea98658@github.com>
Message-ID: <foRVi3-8xJcgdlKaCBUI2s2Df-9fdwyZuogXIS72V1M=.37803f30-bcc0-408e-8d6b-b171f5925c29@github.com>

On Sun, 24 Mar 2024 00:00:25 GMT, Phil Race <prr at openjdk.org> wrote:

>> test/jdk/javax/swing/InputVerifier/bug4774166.java line 229:
>> 
>>> 227:     public void cleanupGUI() {
>>> 228:         if (testframe != null) {
>>> 229:             testframe.setVisible(false);
>> 
>> `testframe.setVisible(false);` is required here? Any advantage for setting the visibility to false ? anyhow its been disposed.....
>
> Not harmful, but not needed either.

Ok, removing them.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18443#discussion_r1537856832

From kizune at openjdk.org  Mon Mar 25 16:18:31 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Mon, 25 Mar 2024 16:18:31 GMT
Subject: RFR: 8316324: Opensource five miscellaneous Swing tests
In-Reply-To: <dyh22NecBLK8bRhDx0w1jeczprjiI7YnX9RgRmFRMyo=.c05a35cd-bae9-4496-b2a0-80b1a464180b@github.com>
References: <2GNSvcn0o7_d4Gca1TkUmz3M2gTtjg2lF8guEq2V8Bs=.cd4c564a-b089-4a8e-b582-b778a73b0329@github.com>
 <7F76CExWTIR2A-yyd3q5McROglv7yv8Zb-6H9Juu8AQ=.cb569ed1-6a5c-45df-a66b-b2d6c1e67064@github.com>
 <U_EAFQnZRisJb2sNWmMrFMmjmjume14YSyw83VZJzIk=.e87572fb-7fa2-47ba-9115-6c57310a1aad@github.com>
 <dyh22NecBLK8bRhDx0w1jeczprjiI7YnX9RgRmFRMyo=.c05a35cd-bae9-4496-b2a0-80b1a464180b@github.com>
Message-ID: <qgb2SuOtyZbqKfHhKp9ksqCVDhC2_9tYJcbiNg3VLp8=.1f433b0b-d1ad-4513-ac49-a0a6cee8173f@github.com>

On Sat, 23 Mar 2024 23:59:42 GMT, Phil Race <prr at openjdk.org> wrote:

>> It is just a gif file filled with yellow color created specifically for that test. It was not provided by the test submitter or anything like that - it was just created in the graphics editor. There's no copyright issue with it.
>
> yeah, but the question is not about the provenance of the file. It is just easier if the test is self-contained.

>From that point of view - sure, we can do without it. I just clarified that there is no copyright issue with the file itself.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18443#discussion_r1537858419

From kizune at openjdk.org  Mon Mar 25 16:24:10 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Mon, 25 Mar 2024 16:24:10 GMT
Subject: RFR: 8316324: Opensource five miscellaneous Swing tests [v2]
In-Reply-To: <2GNSvcn0o7_d4Gca1TkUmz3M2gTtjg2lF8guEq2V8Bs=.cd4c564a-b089-4a8e-b582-b778a73b0329@github.com>
References: <2GNSvcn0o7_d4Gca1TkUmz3M2gTtjg2lF8guEq2V8Bs=.cd4c564a-b089-4a8e-b582-b778a73b0329@github.com>
Message-ID: <rxodW6hrEP3UBs4oV8-y9rrR8NevEdolo-LGPkoZl1I=.ad333473-f7c5-4692-ab21-cf7ccf0aa84a@github.com>

> Clean up and opensource five tests.

Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:

  Removing image file as not needed, generating ImageIcon instead;
  Moved test file from the dedicated folder siince it is no longer needed;
  Removed setVidible(false) calls before disposal of the components;

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18443/files
  - new: https://git.openjdk.org/jdk/pull/18443/files/cea98042..5eca231d

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18443&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18443&range=00-01

  Stats: 187 lines in 4 files changed: 97 ins; 90 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18443.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18443/head:pull/18443

PR: https://git.openjdk.org/jdk/pull/18443

From achung at openjdk.org  Mon Mar 25 16:48:49 2024
From: achung at openjdk.org (Alisen Chung)
Date: Mon, 25 Mar 2024 16:48:49 GMT
Subject: RFR: 8328227: Remove applet usage from JColorChooser tests
 Test4887836 [v4]
In-Reply-To: <sz94hhkj7mCeInxQ075Uwe14NVjdUMDk3sbuOr1E2X0=.2cc0c644-dd7a-4044-aa17-c082abaf74b6@github.com>
References: <sz94hhkj7mCeInxQ075Uwe14NVjdUMDk3sbuOr1E2X0=.2cc0c644-dd7a-4044-aa17-c082abaf74b6@github.com>
Message-ID: <zO_KyJTiRP6oIa2Npysbj2EIA6iIQ8aaOBM6IFwFqRs=.c395fd75-3619-4ecd-b12e-83a4d508e80f@github.com>

> Removing applet usage from manual JColorChooser tests

Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:

  change font

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18316/files
  - new: https://git.openjdk.org/jdk/pull/18316/files/00bf78b2..6ff8dfa4

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18316&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18316&range=02-03

  Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/18316.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18316/head:pull/18316

PR: https://git.openjdk.org/jdk/pull/18316

From achung at openjdk.org  Mon Mar 25 16:51:48 2024
From: achung at openjdk.org (Alisen Chung)
Date: Mon, 25 Mar 2024 16:51:48 GMT
Subject: RFR: 8328380: Remove applet usage from JColorChooser tests
 Test6348456 [v2]
In-Reply-To: <_aL-mUkiTU1jMOsAtDv8wQ4LfmGjhtiFqVr4pqBmUyU=.43345241-dc46-48b8-bab5-95e2b4d18136@github.com>
References: <_aL-mUkiTU1jMOsAtDv8wQ4LfmGjhtiFqVr4pqBmUyU=.43345241-dc46-48b8-bab5-95e2b4d18136@github.com>
Message-ID: <WWVQNVcov9tLXgrzxTfy0ox2lrMBTHg18YZsnCDBfYg=.21c98244-4d8d-494a-a87a-eb2efddf8e8f@github.com>

> Removing applet usage from manual JColorChooser tests

Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:

  fix line length and frame title

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18359/files
  - new: https://git.openjdk.org/jdk/pull/18359/files/c6e99a27..ff633d32

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18359&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18359&range=00-01

  Stats: 5 lines in 1 file changed: 2 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/jdk/pull/18359.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18359/head:pull/18359

PR: https://git.openjdk.org/jdk/pull/18359

From achung at openjdk.org  Mon Mar 25 16:55:35 2024
From: achung at openjdk.org (Alisen Chung)
Date: Mon, 25 Mar 2024 16:55:35 GMT
Subject: RFR: 8328403: Remove applet usage from JColorChooser tests
 Test6977726 [v3]
In-Reply-To: <pyfxVdApSNSisMJieBTl5HSZKDmSSiPie0tnrM_rwe4=.5ffc4e92-cbcf-44d8-9a51-b4e8330e1be9@github.com>
References: <pyfxVdApSNSisMJieBTl5HSZKDmSSiPie0tnrM_rwe4=.5ffc4e92-cbcf-44d8-9a51-b4e8330e1be9@github.com>
Message-ID: <n0TjsQh79xMSxu0oqznoUM5cSkAzAVZOpMQAf9TTMIc=.ac8c3317-c4df-484d-a7ef-d8367b5dc1a5@github.com>

> Removing applet usage from manual JColorChooser tests

Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:

  test instructions

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18369/files
  - new: https://git.openjdk.org/jdk/pull/18369/files/d0818756..39b41d55

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18369&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18369&range=01-02

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/18369.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18369/head:pull/18369

PR: https://git.openjdk.org/jdk/pull/18369

From achung at openjdk.org  Mon Mar 25 16:57:52 2024
From: achung at openjdk.org (Alisen Chung)
Date: Mon, 25 Mar 2024 16:57:52 GMT
Subject: RFR: 8328648: Remove applet usage from JFileChooser tests
 bug4150029 [v2]
In-Reply-To: <eTiR35uGxb59RbbKcRAdTrgYkrx4CNmkIWfk63i3sJw=.8771db30-c50e-4c50-ae80-312a7683cc27@github.com>
References: <eTiR35uGxb59RbbKcRAdTrgYkrx4CNmkIWfk63i3sJw=.8771db30-c50e-4c50-ae80-312a7683cc27@github.com>
Message-ID: <lFpUAG65N86IdlUK56YzWxyzbqfNCIsE0W9mkOya7RA=.b940db87-1568-4a44-ab64-15981c136b58@github.com>

> Removing applet usage from manual JFileChooser tests

Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:

  force fail

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18415/files
  - new: https://git.openjdk.org/jdk/pull/18415/files/4ed3d97e..630d78c9

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18415&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18415&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/18415.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18415/head:pull/18415

PR: https://git.openjdk.org/jdk/pull/18415

From achung at openjdk.org  Mon Mar 25 16:59:37 2024
From: achung at openjdk.org (Alisen Chung)
Date: Mon, 25 Mar 2024 16:59:37 GMT
Subject: RFR: 8328819: Remove applet usage from JFileChooser tests
 bug6698013 [v2]
In-Reply-To: <iLcbr4t_2UJ4muFqTIm1NMfahCdwMTpgprqHo8WHHW0=.29e91557-e4b0-4d9c-ba32-fb2ab49e5de9@github.com>
References: <iLcbr4t_2UJ4muFqTIm1NMfahCdwMTpgprqHo8WHHW0=.29e91557-e4b0-4d9c-ba32-fb2ab49e5de9@github.com>
Message-ID: <Q2wJmaeJrBAzvyCkZc_M4EfcA2mFcaIHv6Gbj-uDMGQ=.ed4c4d97-0f6f-4861-bf35-1720084675ce@github.com>

> Removing applet usage from manual JFileChooser tests
> The original test is failing (nothing shows up in the JFileChooser), but this change does replace the applet usage with PassFailJFrame

Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:

  increase rows to show second window

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18456/files
  - new: https://git.openjdk.org/jdk/pull/18456/files/9ca90cb9..e43d8b1e

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18456&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18456&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/18456.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18456/head:pull/18456

PR: https://git.openjdk.org/jdk/pull/18456

From achung at openjdk.org  Mon Mar 25 17:05:29 2024
From: achung at openjdk.org (Alisen Chung)
Date: Mon, 25 Mar 2024 17:05:29 GMT
Subject: Integrated: 8328380: Remove applet usage from JColorChooser tests
 Test6348456
In-Reply-To: <_aL-mUkiTU1jMOsAtDv8wQ4LfmGjhtiFqVr4pqBmUyU=.43345241-dc46-48b8-bab5-95e2b4d18136@github.com>
References: <_aL-mUkiTU1jMOsAtDv8wQ4LfmGjhtiFqVr4pqBmUyU=.43345241-dc46-48b8-bab5-95e2b4d18136@github.com>
Message-ID: <xu26PJy2x5ULx1PhYMToAN3Ck75xSjF5aMeIl00o310=.0ff3888b-87ef-4888-9d77-3b3efb5d3db2@github.com>

On Mon, 18 Mar 2024 20:07:50 GMT, Alisen Chung <achung at openjdk.org> wrote:

> Removing applet usage from manual JColorChooser tests

This pull request has now been integrated.

Changeset: 78d1b904
Author:    Alisen Chung <achung at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/78d1b9046830198cd61c505f04f245a430878a5b
Stats:     93 lines in 2 files changed: 37 ins; 45 del; 11 mod

8328380: Remove applet usage from JColorChooser tests Test6348456

Reviewed-by: honkar

-------------

PR: https://git.openjdk.org/jdk/pull/18359

From kizune at openjdk.org  Mon Mar 25 17:20:26 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Mon, 25 Mar 2024 17:20:26 GMT
Subject: Integrated: 8328385: Convert java/awt/FileDialog/FileDialogReturnTest
 test to main
In-Reply-To: <fqHwY3Ipk9ArGTOnM26LF_dxWaQeptZ8Kf9fKNWUPVg=.43700ff8-5123-444a-817d-173bd126368d@github.com>
References: <fqHwY3Ipk9ArGTOnM26LF_dxWaQeptZ8Kf9fKNWUPVg=.43700ff8-5123-444a-817d-173bd126368d@github.com>
Message-ID: <rvXmcGyNAjkI_wdSqTZvsDwMWRR-aSiQNdYX7n7CONg=.aac04992-b220-46e8-b093-f08bd92cdfd9@github.com>

On Mon, 18 Mar 2024 20:52:00 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

> Convert test to a main method based;
> Move test to an apropriate location;
> Remove old files;

This pull request has now been integrated.

Changeset: c7cf6020
Author:    Alexander Zuev <kizune at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/c7cf6020782525eb17ff3013195a81d711a4fce1
Stats:     431 lines in 3 files changed: 142 ins; 289 del; 0 mod

8328385: Convert java/awt/FileDialog/FileDialogReturnTest test to main

Reviewed-by: achung, prr

-------------

PR: https://git.openjdk.org/jdk/pull/18363

From azvegint at openjdk.org  Mon Mar 25 18:51:29 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Mon, 25 Mar 2024 18:51:29 GMT
Subject: RFR: 8328403: Remove applet usage from JColorChooser tests
 Test6977726 [v3]
In-Reply-To: <n0TjsQh79xMSxu0oqznoUM5cSkAzAVZOpMQAf9TTMIc=.ac8c3317-c4df-484d-a7ef-d8367b5dc1a5@github.com>
References: <pyfxVdApSNSisMJieBTl5HSZKDmSSiPie0tnrM_rwe4=.5ffc4e92-cbcf-44d8-9a51-b4e8330e1be9@github.com>
 <n0TjsQh79xMSxu0oqznoUM5cSkAzAVZOpMQAf9TTMIc=.ac8c3317-c4df-484d-a7ef-d8367b5dc1a5@github.com>
Message-ID: <ErruxydT6Pr0Rhc-KhTmS1SmMKCp3OawZlVgfMXxi5g=.6a9a1f4d-a8aa-40ab-8788-4e3ba2467b9f@github.com>

On Mon, 25 Mar 2024 16:55:35 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> Removing applet usage from manual JColorChooser tests
>
> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   test instructions

test/jdk/javax/swing/JColorChooser/Test6977726.java line 43:

> 41:                 .title("Test6977726")
> 42:                 .instructions("Check that there is a panel with white text " +
> 43:                         "titled \"Preview\" in the JColorChooser.")

> Check that there is a panel with white text titled "Preview" in the JColorChooser.

I read it as if the text should be titled "Preview", although it should actually refer to the panel(maybe I'm wrong).

Since you modified the original "If you don't see the preview panel" by adding the "white text" check, you should check it on all platforms/LaFs that this text is really white and distinguishable from the background, otherwise it might come back to us one day with a failure of this test.

test/jdk/javax/swing/JColorChooser/Test6977726.java line 46:

> 44:                 .rows(5)
> 45:                 .columns(40)
> 46:                 .testTimeOut(10)

Suggestion:


10 minutes seems too long for such a simple test.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18369#discussion_r1538075544
PR Review Comment: https://git.openjdk.org/jdk/pull/18369#discussion_r1538080488

From duke at openjdk.org  Mon Mar 25 18:53:26 2024
From: duke at openjdk.org (Larry Cable)
Date: Mon, 25 Mar 2024 18:53:26 GMT
Subject: Withdrawn: 8321428: Depreciate java.beans.beancontext.*
In-Reply-To: <5CF4Y37gyrFEcymJvgj50A4L25_fDlH2N8-cTBhVF2M=.cc55299c-b3e2-436e-b380-6a6d74e84c70@github.com>
References: <5CF4Y37gyrFEcymJvgj50A4L25_fDlH2N8-cTBhVF2M=.cc55299c-b3e2-436e-b380-6a6d74e84c70@github.com>
Message-ID: <_sHbUdbdFHjL0PVYY6j9wGPy1XB85gSrTIBtWFm9Y0c=.756c2a1c-34c4-4a30-b3f6-d62af6050301@github.com>

On Wed, 20 Mar 2024 21:30:53 GMT, Larry Cable <duke at openjdk.org> wrote:

> [https://bugs.openjdk.org/browse/JDK-8321428](url)

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.org/jdk/pull/18413

From azvegint at openjdk.org  Mon Mar 25 19:02:28 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Mon, 25 Mar 2024 19:02:28 GMT
Subject: Integrated: 8328562: Convert
 java/awt/InputMethods/DiacriticsTest/DiacriticsTest.java applet test to main
In-Reply-To: <dwZXmqAjKVfX0Z4xfEfCJvsNmm7pOSYZTOk30-vPIF8=.0e29c1cf-580c-4898-9b94-7aaddec86add@github.com>
References: <dwZXmqAjKVfX0Z4xfEfCJvsNmm7pOSYZTOk30-vPIF8=.0e29c1cf-580c-4898-9b94-7aaddec86add@github.com>
Message-ID: <H4xxlXZ02COJ2re8yLTpBA5MVX2yeo4mvDOv9n0cSqQ=.e199cdcc-a28b-4a21-8e0f-101101697282@github.com>

On Wed, 20 Mar 2024 03:09:32 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

> Test converted to main.
> Instructions split to Windows and Linux, with some clarifications.
> The test runs successfully on Windows and Linux.

This pull request has now been integrated.

Changeset: fb8f2a0a
Author:    Alexander Zvegintsev <azvegint at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/fb8f2a0a929ebe7f65c69741712b89bbb403ade9
Stats:     137 lines in 2 files changed: 64 ins; 57 del; 16 mod

8328562: Convert java/awt/InputMethods/DiacriticsTest/DiacriticsTest.java applet test to main

Reviewed-by: tr, prr

-------------

PR: https://git.openjdk.org/jdk/pull/18388

From dnguyen at openjdk.org  Mon Mar 25 19:53:54 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Mon, 25 Mar 2024 19:53:54 GMT
Subject: RFR: 8328827: Convert
 java/awt/print/PrinterJob/PrinterDialogsModalityTest/PrinterDialogsModalityTest.html
 applet test to main [v2]
In-Reply-To: <2iwbuovZ9rGwS8EqkKiSvnxU3_eJI-5KHFngpMs4qtE=.89885458-b5e0-48da-9810-4cfe71c9a420@github.com>
References: <2iwbuovZ9rGwS8EqkKiSvnxU3_eJI-5KHFngpMs4qtE=.89885458-b5e0-48da-9810-4cfe71c9a420@github.com>
Message-ID: <y-RrgnWSdNxUYi6wlYa4uk1kUqC2KLQt5ukp1DoMI6A=.85848734-df8e-48d6-bf6a-5cb62d723257@github.com>

> Convert java/awt/print/PrinterJob/PrinterDialogsModalityTest/PrinterDialogsModalityTest.html applet test to main using PassFailJFrame

Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:

  Fix spelling

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18461/files
  - new: https://git.openjdk.org/jdk/pull/18461/files/c39292d0..663c433a

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18461&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18461&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/18461.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18461/head:pull/18461

PR: https://git.openjdk.org/jdk/pull/18461

From dnguyen at openjdk.org  Mon Mar 25 19:53:54 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Mon, 25 Mar 2024 19:53:54 GMT
Subject: RFR: 8328827: Convert
 java/awt/print/PrinterJob/PrinterDialogsModalityTest/PrinterDialogsModalityTest.html
 applet test to main [v2]
In-Reply-To: <9Ws8y7MzFgDR21NTpfU6I5GNat1ZAg9ATtDAnJnwfvo=.87e64e44-b706-4b45-a002-6ef374c09397@github.com>
References: <2iwbuovZ9rGwS8EqkKiSvnxU3_eJI-5KHFngpMs4qtE=.89885458-b5e0-48da-9810-4cfe71c9a420@github.com>
 <9Ws8y7MzFgDR21NTpfU6I5GNat1ZAg9ATtDAnJnwfvo=.87e64e44-b706-4b45-a002-6ef374c09397@github.com>
Message-ID: <9qLRviqCZ41Kpd3ypOqPlG7azLKh-ZfJBJZrnCebzN4=.7cb13f4a-3a29-4bbc-9c6c-c09d10b95f4d@github.com>

On Sat, 23 Mar 2024 23:38:51 GMT, Phil Race <prr at openjdk.org> wrote:

>> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix spelling
>
> test/jdk/java/awt/print/PrinterJob/PrinterDialogsModalityTest.java line 49:
> 
>> 47:              with two buttons: "Page Dialog" and "Print Dialog".
>> 48:              1. Make the "Test Frame" active by clicking on title.
>> 49:              2. Press "Page Dialog" button and a page dailog should popup.
> 
> dailog -> dialog

Fixed. Thanks.

> test/jdk/java/awt/print/PrinterJob/PrinterDialogsModalityTest.java line 68:
> 
>> 66:                 .title("PrinterDialogsModalityTest Test Instructions")
>> 67:                 .instructions(INSTRUCTIONS)
>> 68:                 .rows((int) INSTRUCTIONS.lines().count() + 2)
> 
> Oh, that's a nice idea. I'd been tweaking by hand.

I agree it's a nice idea, but I took this idea from other PR's I've reviewed. Not sure who started this first, but very handy.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18461#discussion_r1538152306
PR Review Comment: https://git.openjdk.org/jdk/pull/18461#discussion_r1538153170

From dnguyen at openjdk.org  Mon Mar 25 20:03:37 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Mon, 25 Mar 2024 20:03:37 GMT
Subject: RFR: 8328719: Convert java/awt/print/PageFormat/SetOrient.html
 applet test to main [v2]
In-Reply-To: <Bl4gv5IxCey90n1pVzaEsbrztrXkt5Ixksx2E6ul0AI=.4c598589-ce3c-4a7e-a417-3f2e1f54b3cb@github.com>
References: <Bl4gv5IxCey90n1pVzaEsbrztrXkt5Ixksx2E6ul0AI=.4c598589-ce3c-4a7e-a417-3f2e1f54b3cb@github.com>
Message-ID: <YhbEK2DDFqUfHe_nOyIxv8n-7jo9-s87SHVTgiD68x0=.59b4a9be-d222-4332-97cb-ee32b28bb467@github.com>

> Convert java/awt/print/PageFormat/SetOrient.html applet test to main using PassFailJFrame.

Damon Nguyen has updated the pull request incrementally with two additional commits since the last revision:

 - Move var inside method
 - Add error msg. Add print button instead of auto print on exec.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18462/files
  - new: https://git.openjdk.org/jdk/pull/18462/files/02f3a96b..cd960eba

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18462&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18462&range=00-01

  Stats: 44 lines in 1 file changed: 9 ins; 2 del; 33 mod
  Patch: https://git.openjdk.org/jdk/pull/18462.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18462/head:pull/18462

PR: https://git.openjdk.org/jdk/pull/18462

From dnguyen at openjdk.org  Mon Mar 25 20:03:37 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Mon, 25 Mar 2024 20:03:37 GMT
Subject: RFR: 8328719: Convert java/awt/print/PageFormat/SetOrient.html
 applet test to main [v2]
In-Reply-To: <-unOAa8CL8nF8mpEN3lBAw8Wuq0hS2j77QwAusFCAco=.b7e54147-02b7-4bda-9a08-93f9606e94c9@github.com>
References: <Bl4gv5IxCey90n1pVzaEsbrztrXkt5Ixksx2E6ul0AI=.4c598589-ce3c-4a7e-a417-3f2e1f54b3cb@github.com>
 <-unOAa8CL8nF8mpEN3lBAw8Wuq0hS2j77QwAusFCAco=.b7e54147-02b7-4bda-9a08-93f9606e94c9@github.com>
Message-ID: <pYT7B9zX5XiRBicOwofhxx3a-1X4XYbaXQRoEXw4fH4=.c0339df7-efb2-40c8-b18d-2226637aa838@github.com>

On Mon, 25 Mar 2024 07:42:47 GMT, Tejesh R <tr at openjdk.org> wrote:

> Since this is a manual test, should we wait for user to input some action like start print or something like that ? Because as soon as the test starts/ printer job is initiated. Instructions are there, but I felt without user starting the test, the test is running as soon as it is executed, is it fine?

I figured it was fine, but there's no harm in making a dedicated button for it. I went ahead and added the button to the `PassFailJFrame` as suggested. Thanks for the suggestion. @TejeshR13 could you re-review this when you get the chance?

> test/jdk/java/awt/print/PageFormat/SetOrient.java line 46:
> 
>> 44: 
>> 45: public class SetOrient {
>> 46:     static PrinterJob pjob;
> 
> Can be moved inside `init()` and even you change the method name since applet is removed.

Renamed method to `createAndShowGUI`. Also moved `pjob` var into method.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18462#issuecomment-2018805769
PR Review Comment: https://git.openjdk.org/jdk/pull/18462#discussion_r1538162365

From dnguyen at openjdk.org  Mon Mar 25 20:03:37 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Mon, 25 Mar 2024 20:03:37 GMT
Subject: RFR: 8328719: Convert java/awt/print/PageFormat/SetOrient.html
 applet test to main [v2]
In-Reply-To: <uMVhwiHK2j58FlxKGeRnEZ-YubgPJEKnRsWLWfvWDCE=.c0c39a1b-4899-4ec5-81d8-dacf447d8f2f@github.com>
References: <Bl4gv5IxCey90n1pVzaEsbrztrXkt5Ixksx2E6ul0AI=.4c598589-ce3c-4a7e-a417-3f2e1f54b3cb@github.com>
 <uMVhwiHK2j58FlxKGeRnEZ-YubgPJEKnRsWLWfvWDCE=.c0c39a1b-4899-4ec5-81d8-dacf447d8f2f@github.com>
Message-ID: <OKd42bxmdze8b9bmunoJFyzaZzGuKNfPVR_ezeKcmGM=.f8163910-b376-4a30-9757-660bc7e40a60@github.com>

On Sat, 23 Mar 2024 08:16:13 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Damon Nguyen has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Move var inside method
>>  - Add error msg. Add print button instead of auto print on exec.
>
> test/jdk/java/awt/print/PageFormat/SetOrient.java line 106:
> 
>> 104:             pjob.print();
>> 105:         } catch (PrinterException e) {
>> 106:             throw new RuntimeException(e.getMessage());
> 
> In other PRs, I guess we do
> 
> 
>  ex.printStackTrace();
>                     String msg = "PrinterException: " + ex.getMessage();
>                     PassFailJFrame.forceFail(msg);

You're right. Changed to align with other PRs.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18462#discussion_r1538160918

From prr at openjdk.org  Mon Mar 25 21:17:24 2024
From: prr at openjdk.org (Phil Race)
Date: Mon, 25 Mar 2024 21:17:24 GMT
Subject: RFR: 8328730: Convert java/awt/print/bug8023392/bug8023392.html
 applet test to main [v2]
In-Reply-To: <snIQJo9DJUrVkenZLQERlr35Lm2-IreJNVZgf7D9ucI=.69960d03-894a-4c85-b38c-301e5ee838f9@github.com>
References: <Mn57TSPJZir2IqthGrBOcW_GBsOMPq514q9Ds7AFhy8=.da0ef4a4-b351-4c6d-beaf-a827d1c88385@github.com>
 <snIQJo9DJUrVkenZLQERlr35Lm2-IreJNVZgf7D9ucI=.69960d03-894a-4c85-b38c-301e5ee838f9@github.com>
Message-ID: <CRHG5Gn5nTudjqsMF88UMO36ZE-uD8OjGKl4vQwYh94=.e18fb657-6132-4f68-9f1f-3aa96bc79506@github.com>

On Fri, 22 Mar 2024 17:38:36 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

>> Convert java/awt/print/bug8023392/bug8023392.html applet test to main using PassFailJFrame
>
> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Move test out of extra dir

Marked as reviewed by prr (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18458#pullrequestreview-1958797230

From prr at openjdk.org  Mon Mar 25 21:17:25 2024
From: prr at openjdk.org (Phil Race)
Date: Mon, 25 Mar 2024 21:17:25 GMT
Subject: RFR: 8328730: Convert java/awt/print/bug8023392/bug8023392.html
 applet test to main [v2]
In-Reply-To: <6TKKq_cZG4icfSlDAzMiJWPs0yPNd1hzMlQ_tswF08A=.2a6efb82-c7c8-4412-a365-89b40cd02c88@github.com>
References: <Mn57TSPJZir2IqthGrBOcW_GBsOMPq514q9Ds7AFhy8=.da0ef4a4-b351-4c6d-beaf-a827d1c88385@github.com>
 <snIQJo9DJUrVkenZLQERlr35Lm2-IreJNVZgf7D9ucI=.69960d03-894a-4c85-b38c-301e5ee838f9@github.com>
 <K2mbG3hS0a-ME2iAm0rywEgE5mAvc22tB_TOZ_1JOpM=.f431f2eb-fe64-4ebb-9d16-44a5a2d6cb95@github.com>
 <6TKKq_cZG4icfSlDAzMiJWPs0yPNd1hzMlQ_tswF08A=.2a6efb82-c7c8-4412-a365-89b40cd02c88@github.com>
Message-ID: <1o27khyL9xRi3EkQ_xMPnHIYiDJDlFspkYp_P6pOUDY=.8e239097-c53a-4e89-a84c-6c017035f4c4@github.com>

On Mon, 25 Mar 2024 16:05:16 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

>> test/jdk/java/awt/print/bug8023392.java line 116:
>> 
>>> 114:                 @Override
>>> 115:                 protected void paintComponent(Graphics g) {
>>> 116:                     SwingUtilities2.drawChars(this, g, s.toCharArray(),
>> 
>> cant we use `Graphics.drawChars` instead in all places `SwingUtilities2.drawChars` is used?
>
> `Graphics.drawChars` isn't a static method, which will require additional changes to this test. Is it preferred to use `Graphics` over the `SwingUtilities2` version?

This test is specifically about testing the spacing of text in Swing printing.
I think this SwingUtilities call isn't just "the way he happens to be printing text",
This call is the very thing under test ! And note that it takes a Component parameter
which affects how that call renders the text. It is used to figure out the FRC to use.
So changing this to use Graphics would be a problem.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18458#discussion_r1538247940

From prr at openjdk.org  Mon Mar 25 21:20:21 2024
From: prr at openjdk.org (Phil Race)
Date: Mon, 25 Mar 2024 21:20:21 GMT
Subject: RFR: 8328719: Convert java/awt/print/PageFormat/SetOrient.html
 applet test to main [v2]
In-Reply-To: <YhbEK2DDFqUfHe_nOyIxv8n-7jo9-s87SHVTgiD68x0=.59b4a9be-d222-4332-97cb-ee32b28bb467@github.com>
References: <Bl4gv5IxCey90n1pVzaEsbrztrXkt5Ixksx2E6ul0AI=.4c598589-ce3c-4a7e-a417-3f2e1f54b3cb@github.com>
 <YhbEK2DDFqUfHe_nOyIxv8n-7jo9-s87SHVTgiD68x0=.59b4a9be-d222-4332-97cb-ee32b28bb467@github.com>
Message-ID: <CYt2p9w6m5jgh3XXpjM89RJzpH3y0rggBQj3zW7wk3M=.06b8b934-1485-4ba4-833e-b9011d2c8ffd@github.com>

On Mon, 25 Mar 2024 20:03:37 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

>> Convert java/awt/print/PageFormat/SetOrient.html applet test to main using PassFailJFrame.
>
> Damon Nguyen has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Move var inside method
>  - Add error msg. Add print button instead of auto print on exec.

Marked as reviewed by prr (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18462#pullrequestreview-1958801826

From prr at openjdk.org  Mon Mar 25 21:26:21 2024
From: prr at openjdk.org (Phil Race)
Date: Mon, 25 Mar 2024 21:26:21 GMT
Subject: RFR: 8316324: Opensource five miscellaneous Swing tests [v2]
In-Reply-To: <rxodW6hrEP3UBs4oV8-y9rrR8NevEdolo-LGPkoZl1I=.ad333473-f7c5-4692-ab21-cf7ccf0aa84a@github.com>
References: <2GNSvcn0o7_d4Gca1TkUmz3M2gTtjg2lF8guEq2V8Bs=.cd4c564a-b089-4a8e-b582-b778a73b0329@github.com>
 <rxodW6hrEP3UBs4oV8-y9rrR8NevEdolo-LGPkoZl1I=.ad333473-f7c5-4692-ab21-cf7ccf0aa84a@github.com>
Message-ID: <5fBoMR6Ye7i6e5qZlssGe6o4Zy20n-iW9aENzosIVO4=.41b5b8f4-76df-42be-bae3-d2d85cd54d95@github.com>

On Mon, 25 Mar 2024 16:24:10 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

>> Clean up and opensource five tests.
>
> Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Removing image file as not needed, generating ImageIcon instead;
>   Moved test file from the dedicated folder siince it is no longer needed;
>   Removed setVidible(false) calls before disposal of the components;

Marked as reviewed by prr (Reviewer).

test/jdk/javax/swing/JButton/bug4385611.java line 84:

> 82:                 }
> 83:             } catch (Exception e) {
> 84:                 e.printStackTrace();

Not a blocker for approval, but I wonder why this test catches the exception ?
Surely we don't expect installing the L&F to fail since we require windows.
And the Metal case above should never fail. 
Perhaps we should let the exceptions propagate so the test fails rather than being silent.
You decide.

-------------

PR Review: https://git.openjdk.org/jdk/pull/18443#pullrequestreview-1958810958
PR Review Comment: https://git.openjdk.org/jdk/pull/18443#discussion_r1538257423

From prr at openjdk.org  Mon Mar 25 21:27:24 2024
From: prr at openjdk.org (Phil Race)
Date: Mon, 25 Mar 2024 21:27:24 GMT
Subject: RFR: 8328227: Remove applet usage from JColorChooser tests
 Test4887836 [v4]
In-Reply-To: <zO_KyJTiRP6oIa2Npysbj2EIA6iIQ8aaOBM6IFwFqRs=.c395fd75-3619-4ecd-b12e-83a4d508e80f@github.com>
References: <sz94hhkj7mCeInxQ075Uwe14NVjdUMDk3sbuOr1E2X0=.2cc0c644-dd7a-4044-aa17-c082abaf74b6@github.com>
 <zO_KyJTiRP6oIa2Npysbj2EIA6iIQ8aaOBM6IFwFqRs=.c395fd75-3619-4ecd-b12e-83a4d508e80f@github.com>
Message-ID: <zeFPZzwDEHH4hTfbWuoFBZmVhTw5CLjavPyQdSBUhoM=.baa660e9-6859-4128-8f29-1c6f311b095c@github.com>

On Mon, 25 Mar 2024 16:48:49 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> Removing applet usage from manual JColorChooser tests
>
> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   change font

Marked as reviewed by prr (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18316#pullrequestreview-1958811391

From dnguyen at openjdk.org  Mon Mar 25 21:27:25 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Mon, 25 Mar 2024 21:27:25 GMT
Subject: Integrated: 8328719: Convert java/awt/print/PageFormat/SetOrient.html
 applet test to main
In-Reply-To: <Bl4gv5IxCey90n1pVzaEsbrztrXkt5Ixksx2E6ul0AI=.4c598589-ce3c-4a7e-a417-3f2e1f54b3cb@github.com>
References: <Bl4gv5IxCey90n1pVzaEsbrztrXkt5Ixksx2E6ul0AI=.4c598589-ce3c-4a7e-a417-3f2e1f54b3cb@github.com>
Message-ID: <wdzK7pVu3GnQVaeDpQ14QKfb9TbiQj_HM6uzQslBfno=.b6880984-748b-4bc8-9d67-389c0de0dc45@github.com>

On Fri, 22 Mar 2024 18:55:01 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

> Convert java/awt/print/PageFormat/SetOrient.html applet test to main using PassFailJFrame.

This pull request has now been integrated.

Changeset: 27ac39a2
Author:    Damon Nguyen <dnguyen at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/27ac39a2bc8250bfae859568cb0ee0963900aafa
Stats:     131 lines in 2 files changed: 41 ins; 50 del; 40 mod

8328719: Convert java/awt/print/PageFormat/SetOrient.html applet test to main

Reviewed-by: psadhukhan, prr

-------------

PR: https://git.openjdk.org/jdk/pull/18462

From honkar at openjdk.org  Mon Mar 25 22:49:22 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Mon, 25 Mar 2024 22:49:22 GMT
Subject: RFR: 8328827: Convert
 java/awt/print/PrinterJob/PrinterDialogsModalityTest/PrinterDialogsModalityTest.html
 applet test to main [v2]
In-Reply-To: <y-RrgnWSdNxUYi6wlYa4uk1kUqC2KLQt5ukp1DoMI6A=.85848734-df8e-48d6-bf6a-5cb62d723257@github.com>
References: <2iwbuovZ9rGwS8EqkKiSvnxU3_eJI-5KHFngpMs4qtE=.89885458-b5e0-48da-9810-4cfe71c9a420@github.com>
 <y-RrgnWSdNxUYi6wlYa4uk1kUqC2KLQt5ukp1DoMI6A=.85848734-df8e-48d6-bf6a-5cb62d723257@github.com>
Message-ID: <KhzLqknCqEAqidIzTEwJO2azUjPI1McuRcJ_0d0-Ljs=.d7a0e237-f65f-4503-8919-a80e12192e6a@github.com>

On Mon, 25 Mar 2024 19:53:54 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

>> Convert java/awt/print/PrinterJob/PrinterDialogsModalityTest/PrinterDialogsModalityTest.html applet test to main using PassFailJFrame
>
> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix spelling

@DamonGuy The test in https://github.com/openjdk/jdk/pull/18362 and the one in this PR test similar functionality -Dialog Modality when using Print functions. Will combining or retaining only one test make more sense instead of 2 separate tests?

test/jdk/java/awt/print/PrinterJob/PrinterDialogsModalityTest.java line 92:

> 90:         frame.add(print);
> 91:         frame.pack();
> 92:         frame.setVisible(true);

frame.setVisible(true); not required when using PassFailJFrame.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18461#issuecomment-2019049516
PR Review Comment: https://git.openjdk.org/jdk/pull/18461#discussion_r1538329544

From honkar at openjdk.org  Mon Mar 25 23:31:21 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Mon, 25 Mar 2024 23:31:21 GMT
Subject: RFR: 8328730: Convert java/awt/print/bug8023392/bug8023392.html
 applet test to main [v2]
In-Reply-To: <snIQJo9DJUrVkenZLQERlr35Lm2-IreJNVZgf7D9ucI=.69960d03-894a-4c85-b38c-301e5ee838f9@github.com>
References: <Mn57TSPJZir2IqthGrBOcW_GBsOMPq514q9Ds7AFhy8=.da0ef4a4-b351-4c6d-beaf-a827d1c88385@github.com>
 <snIQJo9DJUrVkenZLQERlr35Lm2-IreJNVZgf7D9ucI=.69960d03-894a-4c85-b38c-301e5ee838f9@github.com>
Message-ID: <cg__BBFwFtxL6zcotzIK6KqPVDsl7lsw2BUocVJVCVY=.3c6ebb75-9e02-41ee-a7f7-33063c4eb179@github.com>

On Fri, 22 Mar 2024 17:38:36 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

>> Convert java/awt/print/bug8023392/bug8023392.html applet test to main using PassFailJFrame
>
> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Move test out of extra dir

LGTM

test/jdk/java/awt/print/bug8023392.java line 211:

> 209:         }
> 210:     }
> 211: }

EOF newline missing.

-------------

Marked as reviewed by honkar (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18458#pullrequestreview-1958976053
PR Review Comment: https://git.openjdk.org/jdk/pull/18458#discussion_r1538362847

From dnguyen at openjdk.org  Mon Mar 25 23:40:40 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Mon, 25 Mar 2024 23:40:40 GMT
Subject: RFR: 8328730: Convert java/awt/print/bug8023392/bug8023392.html
 applet test to main [v3]
In-Reply-To: <Mn57TSPJZir2IqthGrBOcW_GBsOMPq514q9Ds7AFhy8=.da0ef4a4-b351-4c6d-beaf-a827d1c88385@github.com>
References: <Mn57TSPJZir2IqthGrBOcW_GBsOMPq514q9Ds7AFhy8=.da0ef4a4-b351-4c6d-beaf-a827d1c88385@github.com>
Message-ID: <tZMKxUGOVHM-JRoZCxHrcyg1B7L4ZUsKFvPnorQLUTM=.b60e4644-3277-4c9a-8832-5f3190288121@github.com>

> Convert java/awt/print/bug8023392/bug8023392.html applet test to main using PassFailJFrame

Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:

  Add EOF newline

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18458/files
  - new: https://git.openjdk.org/jdk/pull/18458/files/72fe9b13..075d2f6d

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18458&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18458&range=01-02

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/18458.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18458/head:pull/18458

PR: https://git.openjdk.org/jdk/pull/18458

From duke at openjdk.org  Mon Mar 25 23:51:23 2024
From: duke at openjdk.org (Joel Uckelman)
Date: Mon, 25 Mar 2024 23:51:23 GMT
Subject: RFR: 8305072: Win32ShellFolder2.compareTo is inconsistent [v2]
In-Reply-To: <c5xKrm3ItuUN26iAY8k2RiSZu8ppMnTVisVokmy7RMA=.36ff81f6-f473-4b35-b853-595dc5491230@github.com>
References: <bEiHvkFnBZDqmiqQdk_-_mATVhDbAD7NZX7VnkHLG2E=.27ee84ba-00fd-405a-9489-8fe11c215af9@github.com>
 <21db5CiFTVN7scwsIHknMxF4YaVQd06m7gUOhcCLvMI=.e2f61ea7-bf9a-4632-bf45-c89f979ae806@github.com>
 <6dQg9rhDwh4ZL7D2JfYpA0xNP_eJDbOK3rNgj7efckM=.c5001d8a-cce5-4a11-a91d-eda8e90b8056@github.com>
 <76BSt4HYmTD2DiZzBUvNvBdvd5d1MFinIDsgp2YuHjs=.68646608-e266-4ca3-8495-59e237f8607c@github.com>
 <5btT_N4c5R89DQ8aoSyjm6lIR7PHLWC141uAIdH_Bjw=.f36326e9-0f59-4545-82bf-f3c8b4dbaa87@github.com>
 <xEaIYt-r-0MtZBDcpke8dec_MkYGmm_gsj0NcagSMGs=.0f29ce1b-ff4b-4505-9095-5602cdbd3de9@github.com>
 <2LG0ERi-9ETplOC0EdSozMQ4WTJDgx2lw3Z1J6IVrrY=.03443566-afd3-4d7e-8caa-46fa10c55a5e@github.com>
 <c5xKrm3ItuUN26iAY8k2RiSZu8ppMnTVisVokmy7RMA=.36ff81f6-f473-4b35-b853-595dc5491230@github.com>
Message-ID: <YV5wUKr1poC0E1P4rFnU_9Phjy_jnxkb3j1qVRe0jv8=.148bbf10-0c1d-44d9-8d56-79c3fc9d566c@github.com>

On Thu, 21 Mar 2024 17:01:49 GMT, Joel Uckelman <duke at openjdk.org> wrote:

>> @uckelman Is there a way to reproduce the original bug in the user's environment?
>> 
>> I think there's a bug in JDK which leads to two _Documents_ folders in the list. If the bug is still reproducible, collecting more data will help us identify the problem and fix it.
>
> If I can get in contact with the user, I expect he'd still be able to trigger the bug with my test case, yeah. I'll try to get his attention.

I haven't heard back yet. I hope investigating the second bug will not hold up the fix for the first bug getting merged.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18126#discussion_r1538374102

From dnguyen at openjdk.org  Mon Mar 25 23:53:55 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Mon, 25 Mar 2024 23:53:55 GMT
Subject: RFR: 8328827: Convert
 java/awt/print/PrinterJob/PrinterDialogsModalityTest/PrinterDialogsModalityTest.html
 applet test to main [v3]
In-Reply-To: <2iwbuovZ9rGwS8EqkKiSvnxU3_eJI-5KHFngpMs4qtE=.89885458-b5e0-48da-9810-4cfe71c9a420@github.com>
References: <2iwbuovZ9rGwS8EqkKiSvnxU3_eJI-5KHFngpMs4qtE=.89885458-b5e0-48da-9810-4cfe71c9a420@github.com>
Message-ID: <xY0Ec_Q4QX8r6p2lXYVyzEuKD2VecptiVNdYAKbO03Q=.9456b022-cbb2-4266-a014-0dd446deb2ac@github.com>

> Convert java/awt/print/PrinterJob/PrinterDialogsModalityTest/PrinterDialogsModalityTest.html applet test to main using PassFailJFrame

Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:

  Move test tags. Remove setVisible

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18461/files
  - new: https://git.openjdk.org/jdk/pull/18461/files/663c433a..9390d0b8

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18461&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18461&range=01-02

  Stats: 15 lines in 1 file changed: 7 ins; 8 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18461.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18461/head:pull/18461

PR: https://git.openjdk.org/jdk/pull/18461

From dnguyen at openjdk.org  Mon Mar 25 23:53:55 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Mon, 25 Mar 2024 23:53:55 GMT
Subject: RFR: 8328827: Convert
 java/awt/print/PrinterJob/PrinterDialogsModalityTest/PrinterDialogsModalityTest.html
 applet test to main [v2]
In-Reply-To: <y-RrgnWSdNxUYi6wlYa4uk1kUqC2KLQt5ukp1DoMI6A=.85848734-df8e-48d6-bf6a-5cb62d723257@github.com>
References: <2iwbuovZ9rGwS8EqkKiSvnxU3_eJI-5KHFngpMs4qtE=.89885458-b5e0-48da-9810-4cfe71c9a420@github.com>
 <y-RrgnWSdNxUYi6wlYa4uk1kUqC2KLQt5ukp1DoMI6A=.85848734-df8e-48d6-bf6a-5cb62d723257@github.com>
Message-ID: <xQGkAxHjg7tGcobtTRZSkDbjIjmJhyzae0JSA-QU1b8=.5a7b7bab-57fe-41d2-809b-312f277cfc62@github.com>

On Mon, 25 Mar 2024 19:53:54 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

>> Convert java/awt/print/PrinterJob/PrinterDialogsModalityTest/PrinterDialogsModalityTest.html applet test to main using PassFailJFrame
>
> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix spelling

> @DamonGuy The test in #18362 and the one in this PR test similar functionality -Dialog Modality when using Print functions. Will combining or retaining only one test make more sense instead of 2 separate tests?

Good point. This one was originally for windows only for print dialog and page dialog modality. The other PR was for web dialogs. They're also in different directories, one for `PrinterJob` and one for `Dialog`. They are similar though now. What do you suggest @honkar-jdk? I prefer this test overall over the other if I had to pick one. Cleaner and more succinct test.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18461#issuecomment-2019116843

From dnguyen at openjdk.org  Mon Mar 25 23:53:56 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Mon, 25 Mar 2024 23:53:56 GMT
Subject: RFR: 8328827: Convert
 java/awt/print/PrinterJob/PrinterDialogsModalityTest/PrinterDialogsModalityTest.html
 applet test to main [v2]
In-Reply-To: <KhzLqknCqEAqidIzTEwJO2azUjPI1McuRcJ_0d0-Ljs=.d7a0e237-f65f-4503-8919-a80e12192e6a@github.com>
References: <2iwbuovZ9rGwS8EqkKiSvnxU3_eJI-5KHFngpMs4qtE=.89885458-b5e0-48da-9810-4cfe71c9a420@github.com>
 <y-RrgnWSdNxUYi6wlYa4uk1kUqC2KLQt5ukp1DoMI6A=.85848734-df8e-48d6-bf6a-5cb62d723257@github.com>
 <KhzLqknCqEAqidIzTEwJO2azUjPI1McuRcJ_0d0-Ljs=.d7a0e237-f65f-4503-8919-a80e12192e6a@github.com>
Message-ID: <IDWtl9S5PJAMG7BU9Q7lJlvi5g_wCbmPesf6XM18T-w=.244577e2-3fcb-42f0-9040-c8a193ea39bb@github.com>

On Mon, 25 Mar 2024 22:45:48 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix spelling
>
> test/jdk/java/awt/print/PrinterJob/PrinterDialogsModalityTest.java line 92:
> 
>> 90:         frame.add(print);
>> 91:         frame.pack();
>> 92:         frame.setVisible(true);
> 
> frame.setVisible(true); not required when using PassFailJFrame.

Fixed. Thanks.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18461#discussion_r1538372723

From dnguyen at openjdk.org  Mon Mar 25 23:54:26 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Mon, 25 Mar 2024 23:54:26 GMT
Subject: Integrated: 8328730: Convert java/awt/print/bug8023392/bug8023392.html
 applet test to main
In-Reply-To: <Mn57TSPJZir2IqthGrBOcW_GBsOMPq514q9Ds7AFhy8=.da0ef4a4-b351-4c6d-beaf-a827d1c88385@github.com>
References: <Mn57TSPJZir2IqthGrBOcW_GBsOMPq514q9Ds7AFhy8=.da0ef4a4-b351-4c6d-beaf-a827d1c88385@github.com>
Message-ID: <73T5L5VTmzStDRrmuhV5OEbxwzuNAKXWegHvEbR3bCY=.6ce5fa34-5d47-4c4d-b61e-a76e4d9843b8@github.com>

On Fri, 22 Mar 2024 17:20:41 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

> Convert java/awt/print/bug8023392/bug8023392.html applet test to main using PassFailJFrame

This pull request has now been integrated.

Changeset: 4047a362
Author:    Damon Nguyen <dnguyen at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/4047a3623a44d86df2b82565f33ce739a882802d
Stats:     542 lines in 3 files changed: 211 ins; 331 del; 0 mod

8328730: Convert java/awt/print/bug8023392/bug8023392.html applet test to main

Reviewed-by: prr, honkar

-------------

PR: https://git.openjdk.org/jdk/pull/18458

From jwaters at openjdk.org  Mon Mar 25 23:57:41 2024
From: jwaters at openjdk.org (Julian Waters)
Date: Mon, 25 Mar 2024 23:57:41 GMT
Subject: RFR: 8307160: Fix AWT/2D/A11Y to support the permissive- flag on
 the Microsoft Visual C compiler [v52]
In-Reply-To: <x9lWvpa2mjoGwY8cXF74c9MZoOM5LTS0kWKPDcY396c=.5d853b1d-f9cd-4722-b05c-941ac7cffba2@github.com>
References: <7piLRto5nNbhYYYfENCr5ecm4M2xNtMkjkE8XhrLLQ0=.8fd1ac3a-46f8-47a8-ae37-a4abbf7757d9@github.com>
 <0p1UVaUOt2bs1mkuBV1liUxBYGRhnKnclf1x_-Y22GE=.2de6c2c4-8cf5-470d-bdb3-cd0dd0e13975@github.com>
 <6_80radA3v1Fq_kuf_4GZ74gfwc8hgMPOyBczHItlKc=.9a2463ef-c106-42c4-b0a8-12f94568ea96@github.com>
 <_sqXHbEck2Qm83hInO5_ITsaBo_dPQpC6yo5HeypcQM=.de02ef0b-ec9b-4c2a-9bb2-fa9a263a227c@github.com>
 <x9lWvpa2mjoGwY8cXF74c9MZoOM5LTS0kWKPDcY396c=.5d853b1d-f9cd-4722-b05c-941ac7cffba2@github.com>
Message-ID: <WKIGYdZhjp_MqNCiewnDFaGRULf8hRjrHi51rXrssaA=.a78eecfc-c2b5-482b-a426-e677a6eed751@github.com>

On Mon, 25 Mar 2024 08:59:08 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> I don't think I can commit this as there are 3 backticks at the end there :P
>
> Apologies. The point was that this was formatting changes that were not needed and should be reverted.

I know, I did want to commit your change directly though, just can't because of the backticks :P

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15096#discussion_r1538377635

From jwaters at openjdk.org  Tue Mar 26 00:01:53 2024
From: jwaters at openjdk.org (Julian Waters)
Date: Tue, 26 Mar 2024 00:01:53 GMT
Subject: RFR: 8307160: Fix AWT/2D/A11Y to support the permissive- flag on
 the Microsoft Visual C compiler [v54]
In-Reply-To: <7piLRto5nNbhYYYfENCr5ecm4M2xNtMkjkE8XhrLLQ0=.8fd1ac3a-46f8-47a8-ae37-a4abbf7757d9@github.com>
References: <7piLRto5nNbhYYYfENCr5ecm4M2xNtMkjkE8XhrLLQ0=.8fd1ac3a-46f8-47a8-ae37-a4abbf7757d9@github.com>
Message-ID: <Ib_XGsj4gXq6hhkuVIDH5zbEnaX7gjKq1MY92Q3YUF4=.6a4f78da-5585-4fab-9f09-d22dbce0c70e@github.com>

> We should set the -permissive- flag for the Microsoft Visual C compiler, as was requested by the now backed out [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). Doing so makes the Visual C compiler much less accepting of ill formed code, which will improve code quality on Windows in the future.

Julian Waters has updated the pull request incrementally with two additional commits since the last revision:

 - Revert formatting in src/java.desktop/windows/native/libawt/windows/awt_PrintJob.cpp
   
   Co-authored-by: Magnus Ihse Bursie <mag at icus.se>
 - Revert formatting in src/java.desktop/windows/native/libawt/windows/awt_Frame.cpp
   
   Co-authored-by: Magnus Ihse Bursie <mag at icus.se>

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/15096/files
  - new: https://git.openjdk.org/jdk/pull/15096/files/663a7f34..1dbd5f7e

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=15096&range=53
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=15096&range=52-53

  Stats: 4 lines in 2 files changed: 2 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/15096.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/15096/head:pull/15096

PR: https://git.openjdk.org/jdk/pull/15096

From jwaters at openjdk.org  Tue Mar 26 00:04:57 2024
From: jwaters at openjdk.org (Julian Waters)
Date: Tue, 26 Mar 2024 00:04:57 GMT
Subject: RFR: 8307160: Fix AWT/2D/A11Y to support the permissive- flag on
 the Microsoft Visual C compiler [v55]
In-Reply-To: <7piLRto5nNbhYYYfENCr5ecm4M2xNtMkjkE8XhrLLQ0=.8fd1ac3a-46f8-47a8-ae37-a4abbf7757d9@github.com>
References: <7piLRto5nNbhYYYfENCr5ecm4M2xNtMkjkE8XhrLLQ0=.8fd1ac3a-46f8-47a8-ae37-a4abbf7757d9@github.com>
Message-ID: <Hg9we7k5rhkFp6kn86QQX6JgtRoxY1xnqZXCytff2Uo=.d093e365-f01c-4826-81db-5543189ce63a@github.com>

> We should set the -permissive- flag for the Microsoft Visual C compiler, as was requested by the now backed out [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). Doing so makes the Visual C compiler much less accepting of ill formed code, which will improve code quality on Windows in the future.

Julian Waters has updated the pull request incrementally with one additional commit since the last revision:

  Revert formatting in awt_Frame.cpp

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/15096/files
  - new: https://git.openjdk.org/jdk/pull/15096/files/1dbd5f7e..dfc3c491

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=15096&range=54
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=15096&range=53-54

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/15096.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/15096/head:pull/15096

PR: https://git.openjdk.org/jdk/pull/15096

From jwaters at openjdk.org  Tue Mar 26 00:09:55 2024
From: jwaters at openjdk.org (Julian Waters)
Date: Tue, 26 Mar 2024 00:09:55 GMT
Subject: RFR: 8307160: Fix AWT/2D/A11Y to support the permissive- flag on
 the Microsoft Visual C compiler [v56]
In-Reply-To: <7piLRto5nNbhYYYfENCr5ecm4M2xNtMkjkE8XhrLLQ0=.8fd1ac3a-46f8-47a8-ae37-a4abbf7757d9@github.com>
References: <7piLRto5nNbhYYYfENCr5ecm4M2xNtMkjkE8XhrLLQ0=.8fd1ac3a-46f8-47a8-ae37-a4abbf7757d9@github.com>
Message-ID: <KRyz-85o3W8Bhr71rJspSKTpcKG23jAKeelKyXYsCSY=.00c8edec-ffde-44b2-855e-2a28e5783551@github.com>

> We should set the -permissive- flag for the Microsoft Visual C compiler, as was requested by the now backed out [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). Doing so makes the Visual C compiler much less accepting of ill formed code, which will improve code quality on Windows in the future.

Julian Waters has updated the pull request incrementally with two additional commits since the last revision:

 - Partially revert formatting in AccessBridgeJavaEntryPoints.cpp
 - Partially revert formatting in AccessBridgeJavaEntryPoints.cpp

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/15096/files
  - new: https://git.openjdk.org/jdk/pull/15096/files/dfc3c491..bf12c71a

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=15096&range=55
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=15096&range=54-55

  Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod
  Patch: https://git.openjdk.org/jdk/pull/15096.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/15096/head:pull/15096

PR: https://git.openjdk.org/jdk/pull/15096

From honkar at openjdk.org  Tue Mar 26 00:17:26 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Tue, 26 Mar 2024 00:17:26 GMT
Subject: RFR: 8328827: Convert
 java/awt/print/PrinterJob/PrinterDialogsModalityTest/PrinterDialogsModalityTest.html
 applet test to main [v2]
In-Reply-To: <xQGkAxHjg7tGcobtTRZSkDbjIjmJhyzae0JSA-QU1b8=.5a7b7bab-57fe-41d2-809b-312f277cfc62@github.com>
References: <2iwbuovZ9rGwS8EqkKiSvnxU3_eJI-5KHFngpMs4qtE=.89885458-b5e0-48da-9810-4cfe71c9a420@github.com>
 <y-RrgnWSdNxUYi6wlYa4uk1kUqC2KLQt5ukp1DoMI6A=.85848734-df8e-48d6-bf6a-5cb62d723257@github.com>
 <xQGkAxHjg7tGcobtTRZSkDbjIjmJhyzae0JSA-QU1b8=.5a7b7bab-57fe-41d2-809b-312f277cfc62@github.com>
Message-ID: <-Rl16AQF_i9TnqZXkMYCSbE36yTye0zh4gV3iD5CMDo=.0739bafa-4f02-4151-b2b8-4239a1fd8c5f@github.com>

On Mon, 25 Mar 2024 23:48:14 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

> > @DamonGuy The test in #18362 and the one in this PR test similar functionality -Dialog Modality when using Print functions. Will combining or retaining only one test make more sense instead of 2 separate tests?
> 
> Good point. This one was originally for windows only for print dialog and page dialog modality. The other PR was for web dialogs. They're also in different directories, one for `PrinterJob` and one for `Dialog`. They are similar though now. What do you suggest @honkar-jdk? I prefer this test overall over the other if I had to pick one. Cleaner and more succinct test.

In my opinion PrintModalDialog.java can be removed since it is redundant. I agree this test looks better. If we go ahead with removing PrintModalDialog.java then

- Remove PrintModalDialog.java as part of new PR since it is already integrated.
- This test (PrinterDialogsModalityTest.java) can be extended to all platforms and we no longer need @requires tag. 
- Probably update the @bug to include the bug id related to PrintModalDialog.java.

If it is not too much effort then I suggest on deleting the redundant test. @prrace Any suggestions?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18461#issuecomment-2019139803

From honkar at openjdk.org  Tue Mar 26 00:17:29 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Tue, 26 Mar 2024 00:17:29 GMT
Subject: RFR: 8328827: Convert
 java/awt/print/PrinterJob/PrinterDialogsModalityTest/PrinterDialogsModalityTest.html
 applet test to main [v3]
In-Reply-To: <xY0Ec_Q4QX8r6p2lXYVyzEuKD2VecptiVNdYAKbO03Q=.9456b022-cbb2-4266-a014-0dd446deb2ac@github.com>
References: <2iwbuovZ9rGwS8EqkKiSvnxU3_eJI-5KHFngpMs4qtE=.89885458-b5e0-48da-9810-4cfe71c9a420@github.com>
 <xY0Ec_Q4QX8r6p2lXYVyzEuKD2VecptiVNdYAKbO03Q=.9456b022-cbb2-4266-a014-0dd446deb2ac@github.com>
Message-ID: <bCyysPGQQE1KD7zJ6p9MFDLZdAobCqb8GvvQozrLi-o=.8f0132ad-1d5e-425b-a2d7-b75e5968be3a@github.com>

On Mon, 25 Mar 2024 23:53:55 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

>> Convert java/awt/print/PrinterJob/PrinterDialogsModalityTest/PrinterDialogsModalityTest.html applet test to main using PassFailJFrame
>
> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Move test tags. Remove setVisible

test/jdk/java/awt/print/PrinterJob/PrinterDialogsModalityTest.java line 35:

> 33:  * @bug 4784285 4785920
> 34:  * @key printer
> 35:  * @requires (os.family == "windows")

@DamonGuy Even if we retain both the tests, I believe this test can be extended to all platforms and `@requires` tag may not be required.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18461#discussion_r1538390954

From jwaters at openjdk.org  Tue Mar 26 00:17:56 2024
From: jwaters at openjdk.org (Julian Waters)
Date: Tue, 26 Mar 2024 00:17:56 GMT
Subject: RFR: 8307160: Fix AWT/2D/A11Y to support the permissive- flag on
 the Microsoft Visual C compiler [v57]
In-Reply-To: <7piLRto5nNbhYYYfENCr5ecm4M2xNtMkjkE8XhrLLQ0=.8fd1ac3a-46f8-47a8-ae37-a4abbf7757d9@github.com>
References: <7piLRto5nNbhYYYfENCr5ecm4M2xNtMkjkE8XhrLLQ0=.8fd1ac3a-46f8-47a8-ae37-a4abbf7757d9@github.com>
Message-ID: <oZQ26vkLCSuWTmJA1m_jCGwb73HviSylWTIJ_lFzlhU=.7f7a4765-6d82-4067-86ac-ec0f3df0a069@github.com>

> We should set the -permissive- flag for the Microsoft Visual C compiler, as was requested by the now backed out [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). Doing so makes the Visual C compiler much less accepting of ill formed code, which will improve code quality on Windows in the future.

Julian Waters has updated the pull request incrementally with one additional commit since the last revision:

  Revert formatting change in src/java.desktop/windows/native/libawt/windows/awt_PrintJob.cpp
  
  Co-authored-by: Magnus Ihse Bursie <mag at icus.se>

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/15096/files
  - new: https://git.openjdk.org/jdk/pull/15096/files/bf12c71a..0c409d45

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=15096&range=56
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=15096&range=55-56

  Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/15096.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/15096/head:pull/15096

PR: https://git.openjdk.org/jdk/pull/15096

From jwaters at openjdk.org  Tue Mar 26 00:17:56 2024
From: jwaters at openjdk.org (Julian Waters)
Date: Tue, 26 Mar 2024 00:17:56 GMT
Subject: RFR: 8307160: Fix AWT/2D/A11Y to support the permissive- flag on
 the Microsoft Visual C compiler [v52]
In-Reply-To: <rvcdKMR7EYsspYcH1OX2_x4zC43WDQK9c70qt2Cl-CI=.1658a8f0-f530-44fc-aa47-493482d57c50@github.com>
References: <7piLRto5nNbhYYYfENCr5ecm4M2xNtMkjkE8XhrLLQ0=.8fd1ac3a-46f8-47a8-ae37-a4abbf7757d9@github.com>
 <0p1UVaUOt2bs1mkuBV1liUxBYGRhnKnclf1x_-Y22GE=.2de6c2c4-8cf5-470d-bdb3-cd0dd0e13975@github.com>
 <N-qe81Sj2dD9Jf389FDPidxtXG8VMfn9wwvvh3RdlzU=.db37387f-76f7-4096-a979-2b4a956925ea@github.com>
 <rvcdKMR7EYsspYcH1OX2_x4zC43WDQK9c70qt2Cl-CI=.1658a8f0-f530-44fc-aa47-493482d57c50@github.com>
Message-ID: <9agOsYWQVrdMO2D4unjqu1d3JoWs_FtQ-ATURfsANr4=.e51e3241-cc69-41df-a202-c7f24581408a@github.com>

On Mon, 25 Mar 2024 09:02:22 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

> > The only thing I'm uncertain about is the pData local, which I don't see much benefit in removing since the null check associated with it still has to remain for code semantics to be correct
> 
> The point is that you can do the null check on the correct variable directly, instead of going a detour with pData. So instead of:
> 
> ```
> RealType realVal;
> void* pData = getVal()
> if (pData == null) {
>   // bail out
> }
> realVal = (RealType) pData;
> ```
> 
> you can just do:
> 
> ```
> RealType realVal = getVal();
> if (realVal == null) {
>   // bail out
> }
> ```
> 
> as the code normally would have been written, had there not been an old macro that used the "magic" temporary pData variable.
> 
> This is a recurring pattern in this patch and needs to be fixed everywhere.

I have a concern since the null check bailout involves THROW_NULL_PDATA_IF_NOT_DESTROYED, which is no longer accurate if we remove the pData local. Maybe Phil can suggest an alternative to that, because I don't know what that might be. Although, if given the choice I'd use RAII through unique_ptr like Thomas suggested, it just seems so much cleaner to me. Speaking of, hopefully this causes enough noise to get Phil's attention again. In the meantime, I've reverted as much of the formatting changes I could possibly find

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15096#issuecomment-2019140763

From dnguyen at openjdk.org  Tue Mar 26 00:31:40 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Tue, 26 Mar 2024 00:31:40 GMT
Subject: RFR: 8328827: Convert
 java/awt/print/PrinterJob/PrinterDialogsModalityTest/PrinterDialogsModalityTest.html
 applet test to main [v4]
In-Reply-To: <2iwbuovZ9rGwS8EqkKiSvnxU3_eJI-5KHFngpMs4qtE=.89885458-b5e0-48da-9810-4cfe71c9a420@github.com>
References: <2iwbuovZ9rGwS8EqkKiSvnxU3_eJI-5KHFngpMs4qtE=.89885458-b5e0-48da-9810-4cfe71c9a420@github.com>
Message-ID: <C4K0xQu1_mt4GveCRGdQhEmVetXJzRMZH31b_ZbZq1Y=.787cff98-342d-4466-952b-f4eb6ef5d8bf@github.com>

> Convert java/awt/print/PrinterJob/PrinterDialogsModalityTest/PrinterDialogsModalityTest.html applet test to main using PassFailJFrame

Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:

  Remove requires tag

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18461/files
  - new: https://git.openjdk.org/jdk/pull/18461/files/9390d0b8..d61f55fe

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18461&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18461&range=02-03

  Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18461.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18461/head:pull/18461

PR: https://git.openjdk.org/jdk/pull/18461

From dnguyen at openjdk.org  Tue Mar 26 00:31:40 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Tue, 26 Mar 2024 00:31:40 GMT
Subject: RFR: 8328827: Convert
 java/awt/print/PrinterJob/PrinterDialogsModalityTest/PrinterDialogsModalityTest.html
 applet test to main [v3]
In-Reply-To: <bCyysPGQQE1KD7zJ6p9MFDLZdAobCqb8GvvQozrLi-o=.8f0132ad-1d5e-425b-a2d7-b75e5968be3a@github.com>
References: <2iwbuovZ9rGwS8EqkKiSvnxU3_eJI-5KHFngpMs4qtE=.89885458-b5e0-48da-9810-4cfe71c9a420@github.com>
 <xY0Ec_Q4QX8r6p2lXYVyzEuKD2VecptiVNdYAKbO03Q=.9456b022-cbb2-4266-a014-0dd446deb2ac@github.com>
 <bCyysPGQQE1KD7zJ6p9MFDLZdAobCqb8GvvQozrLi-o=.8f0132ad-1d5e-425b-a2d7-b75e5968be3a@github.com>
Message-ID: <MHk0gsLPzS6CmLFXLEHH2UCinGXIeb9NFh1NrGl_Zjk=.03b77f86-64cb-4558-a56f-4dabc10bf0b2@github.com>

On Tue, 26 Mar 2024 00:14:15 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Move test tags. Remove setVisible
>
> test/jdk/java/awt/print/PrinterJob/PrinterDialogsModalityTest.java line 35:
> 
>> 33:  * @bug 4784285 4785920
>> 34:  * @key printer
>> 35:  * @requires (os.family == "windows")
> 
> @DamonGuy Even if we retain both the tests, I believe this test can be extended to all platforms and `@requires` tag may not be required.

Removed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18461#discussion_r1538408179

From honkar at openjdk.org  Tue Mar 26 00:46:23 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Tue, 26 Mar 2024 00:46:23 GMT
Subject: RFR: 8328227: Remove applet usage from JColorChooser tests
 Test4887836 [v4]
In-Reply-To: <E_7XPBow5W_l8Mb9OVenGn_zIhXBeOW-euJ-zFoQhK0=.cb1c0e6f-7c54-43c1-be9c-115e44f5f8fd@github.com>
References: <sz94hhkj7mCeInxQ075Uwe14NVjdUMDk3sbuOr1E2X0=.2cc0c644-dd7a-4044-aa17-c082abaf74b6@github.com>
 <aBk176U0tL-uoUduGF37m99NMTL6OO3xkkZnLfexZyI=.3f73a14b-b5e9-4684-a76d-1a2ccb3897fe@github.com>
 <E_7XPBow5W_l8Mb9OVenGn_zIhXBeOW-euJ-zFoQhK0=.cb1c0e6f-7c54-43c1-be9c-115e44f5f8fd@github.com>
Message-ID: <SGAtDT2LoDZlDwjdSEPyCnfZ9GDnhWVMY0wn39DcV_M=.cdcea5d1-117c-4e87-8c07-0453e8f0a1b7@github.com>

On Mon, 18 Mar 2024 19:54:00 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> test/jdk/javax/swing/JColorChooser/Test4887836.java line 41:
>> 
>>> 39:     public static void main(String[] args) throws Exception {
>>> 40:         String instructions = "If you do not see white area under the \"Swatches\" tab,\n" +
>>> 41:                 "then test passed, otherwise it failed.";
>> 
>> The original instructions seem a bit vague and the test window has a lot going on so probably more details here would add clarity.
>
> The original test [JDK-4887836](https://bugs.openjdk.org/browse/JDK-4887836) is quite vague so I'm not sure how to add more details other than "white area under 'Swatches' tab"

Which "White area" are they referring in Swatches tab? Is it the preview window?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18316#discussion_r1538445218

From honkar at openjdk.org  Tue Mar 26 00:49:26 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Tue, 26 Mar 2024 00:49:26 GMT
Subject: RFR: 8328227: Remove applet usage from JColorChooser tests
 Test4887836 [v4]
In-Reply-To: <zO_KyJTiRP6oIa2Npysbj2EIA6iIQ8aaOBM6IFwFqRs=.c395fd75-3619-4ecd-b12e-83a4d508e80f@github.com>
References: <sz94hhkj7mCeInxQ075Uwe14NVjdUMDk3sbuOr1E2X0=.2cc0c644-dd7a-4044-aa17-c082abaf74b6@github.com>
 <zO_KyJTiRP6oIa2Npysbj2EIA6iIQ8aaOBM6IFwFqRs=.c395fd75-3619-4ecd-b12e-83a4d508e80f@github.com>
Message-ID: <-Q8UhtOxNPqh7ADYGEnC4gs6-WzLkvOowLI-oH9Sfuc=.185acb92-8fd6-43b7-a934-062a15d5c4d4@github.com>

On Mon, 25 Mar 2024 16:48:49 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> Removing applet usage from manual JColorChooser tests
>
> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   change font

test/jdk/javax/swing/JColorChooser/Test4887836.java line 43:

> 41:         String instructions = """
> 42:                                 If you do not see white area under the \"Swatches\" tab,\n +
> 43:                                 then test passed, otherwise it failed.""";

Please fix line-lengths and the "+" operator is not required since String blocks are used.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18316#discussion_r1538450325

From kizune at openjdk.org  Tue Mar 26 00:51:23 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Tue, 26 Mar 2024 00:51:23 GMT
Subject: RFR: 8316324: Opensource five miscellaneous Swing tests [v2]
In-Reply-To: <5fBoMR6Ye7i6e5qZlssGe6o4Zy20n-iW9aENzosIVO4=.41b5b8f4-76df-42be-bae3-d2d85cd54d95@github.com>
References: <2GNSvcn0o7_d4Gca1TkUmz3M2gTtjg2lF8guEq2V8Bs=.cd4c564a-b089-4a8e-b582-b778a73b0329@github.com>
 <rxodW6hrEP3UBs4oV8-y9rrR8NevEdolo-LGPkoZl1I=.ad333473-f7c5-4692-ab21-cf7ccf0aa84a@github.com>
 <5fBoMR6Ye7i6e5qZlssGe6o4Zy20n-iW9aENzosIVO4=.41b5b8f4-76df-42be-bae3-d2d85cd54d95@github.com>
Message-ID: <DFPzL5JT3DtoapxajAhQTU-1veM_w0RxYpOX2TcEGzU=.d24083d2-1331-44d7-8c9d-b79c97da5421@github.com>

On Mon, 25 Mar 2024 21:24:13 GMT, Phil Race <prr at openjdk.org> wrote:

>> Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Removing image file as not needed, generating ImageIcon instead;
>>   Moved test file from the dedicated folder siince it is no longer needed;
>>   Removed setVidible(false) calls before disposal of the components;
>
> test/jdk/javax/swing/JButton/bug4385611.java line 84:
> 
>> 82:                 }
>> 83:             } catch (Exception e) {
>> 84:                 e.printStackTrace();
> 
> Not a blocker for approval, but I wonder why this test catches the exception ?
> Surely we don't expect installing the L&F to fail since we require windows.
> And the Metal case above should never fail. 
> Perhaps we should let the exceptions propagate so the test fails rather than being silent.
> You decide.

I think i will re-throw them as RuntimeException with original exception passed as a parameter. There is no reason for adding all 4 exceptions that can be thrown to the main method signature.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18443#discussion_r1538451330

From kizune at openjdk.org  Tue Mar 26 00:56:10 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Tue, 26 Mar 2024 00:56:10 GMT
Subject: RFR: 8316324: Opensource five miscellaneous Swing tests [v3]
In-Reply-To: <2GNSvcn0o7_d4Gca1TkUmz3M2gTtjg2lF8guEq2V8Bs=.cd4c564a-b089-4a8e-b582-b778a73b0329@github.com>
References: <2GNSvcn0o7_d4Gca1TkUmz3M2gTtjg2lF8guEq2V8Bs=.cd4c564a-b089-4a8e-b582-b778a73b0329@github.com>
Message-ID: <RHNVsh8GBdQZDtGMyYC_jcmF_sCCZTAy8Y1dUTMVo54=.ab86d774-02b1-4e5a-9e76-ddd1d1fd7d4d@github.com>

> Clean up and opensource five tests.

Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:

  Make test fail if it can not instantiate required look and feel;

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18443/files
  - new: https://git.openjdk.org/jdk/pull/18443/files/5eca231d..f5e97388

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18443&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18443&range=01-02

  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/18443.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18443/head:pull/18443

PR: https://git.openjdk.org/jdk/pull/18443

From kizune at openjdk.org  Tue Mar 26 01:05:31 2024
From: kizune at openjdk.org (Alexander Zuev)
Date: Tue, 26 Mar 2024 01:05:31 GMT
Subject: Integrated: 8316324: Opensource five miscellaneous Swing tests
In-Reply-To: <2GNSvcn0o7_d4Gca1TkUmz3M2gTtjg2lF8guEq2V8Bs=.cd4c564a-b089-4a8e-b582-b778a73b0329@github.com>
References: <2GNSvcn0o7_d4Gca1TkUmz3M2gTtjg2lF8guEq2V8Bs=.cd4c564a-b089-4a8e-b582-b778a73b0329@github.com>
Message-ID: <IqFrSPlVr6MAbN_aCOGlVfHmttZnPM4TK8FXrZMhGZE=.7ee306a1-39ac-4d80-99b0-537523fc6f2e@github.com>

On Thu, 21 Mar 2024 23:35:58 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

> Clean up and opensource five tests.

This pull request has now been integrated.

Changeset: 7560dbb9
Author:    Alexander Zuev <kizune at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/7560dbb9258f651a221bc8350816845735929fd9
Stats:     572 lines in 5 files changed: 572 ins; 0 del; 0 mod

8316324: Opensource five miscellaneous Swing tests

Reviewed-by: prr

-------------

PR: https://git.openjdk.org/jdk/pull/18443

From achung at openjdk.org  Tue Mar 26 02:20:35 2024
From: achung at openjdk.org (Alisen Chung)
Date: Tue, 26 Mar 2024 02:20:35 GMT
Subject: RFR: 8328648: Remove applet usage from JFileChooser tests
 bug4150029 [v3]
In-Reply-To: <eTiR35uGxb59RbbKcRAdTrgYkrx4CNmkIWfk63i3sJw=.8771db30-c50e-4c50-ae80-312a7683cc27@github.com>
References: <eTiR35uGxb59RbbKcRAdTrgYkrx4CNmkIWfk63i3sJw=.8771db30-c50e-4c50-ae80-312a7683cc27@github.com>
Message-ID: <27GDhgFS-BWfpjW9Fr7tT25u0VPzoSO12V9SV4ANuNc=.a07fa534-01e1-431f-af80-d24f861ba3e4@github.com>

> Removing applet usage from manual JFileChooser tests

Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:

  change to automatic test

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18415/files
  - new: https://git.openjdk.org/jdk/pull/18415/files/630d78c9..0126af35

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18415&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18415&range=01-02

  Stats: 95 lines in 1 file changed: 53 ins; 19 del; 23 mod
  Patch: https://git.openjdk.org/jdk/pull/18415.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18415/head:pull/18415

PR: https://git.openjdk.org/jdk/pull/18415

From abhiscxk at openjdk.org  Tue Mar 26 07:42:24 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Tue, 26 Mar 2024 07:42:24 GMT
Subject: RFR: 8075917: The regression-swing case failed as the text on
 label is not painted red with the GTK L&F [v5]
In-Reply-To: <5eZ7a0HiqE3hghw3sT0L0Zn4Mi1FFfofz6hLGdLOsoc=.445b16ac-4d91-4538-92ba-a74f17781535@github.com>
References: <iDOTnLkAimOa5kfDerZ09n4wsYiFYYUyBflOTYeUQZ0=.293390bd-bc47-4871-bf4c-d23c191d9426@github.com>
 <5eZ7a0HiqE3hghw3sT0L0Zn4Mi1FFfofz6hLGdLOsoc=.445b16ac-4d91-4538-92ba-a74f17781535@github.com>
Message-ID: <8aBNZkw1dIeHg9WidHBtQnx1mtZbSs4fWqQFl0KFOnI=.ddbcc158-5cb7-4ad6-ace0-4ed41f4d9048@github.com>

On Tue, 5 Mar 2024 05:28:01 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> JLabel text is not painted with the LAF defined foreground color in GTK LAF. In GTK LAF the foreground color is retrieved by using native system APIs. Fix is to return the foreground color if it is set by LAF defined property otherwise return the default color by calling native APIs.
>> Applet based test has been converted to automatic test and check for all installed LAFs. CI testing is green for test suite and individual test. Link attached in JBS.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   separate method to get LAF defined color

@aivanov-jdk 

> This looks weird? So you're saying Label[Enabled].textForeground and Label[Disabled].textForeground are used for Nimbus (and Synth and GTK) instead of Label.foreground and Label.disabledForeground which are used for other L&Fs.

As per my understanding, Yes, for Nimbus LAF the UI properties are different than other LAF.

> Shouldn't we fix the problem by correcting the keys instead? It looks like it's what you're doing for specific components.

I am not sure if it is a problem or nimbus LAF is supposed to be like this.

> Is it specified anywhere that Synth-based L&Fs use different constants? It results in incorrect colors.

Need to check on this.

> If a developer sets the common properties, should they override Look-and-Feel defaults?

Will check and revert back.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17763#issuecomment-2019571589

From abhiscxk at openjdk.org  Tue Mar 26 07:42:26 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Tue, 26 Mar 2024 07:42:26 GMT
Subject: RFR: 8075917: The regression-swing case failed as the text on
 label is not painted red with the GTK L&F [v5]
In-Reply-To: <c4jjcBPHlQ79cCbPxo8-EjjuWUzF3hjObagnARJe23s=.a897d7cb-8150-4871-bea6-6211ce88983e@github.com>
References: <iDOTnLkAimOa5kfDerZ09n4wsYiFYYUyBflOTYeUQZ0=.293390bd-bc47-4871-bf4c-d23c191d9426@github.com>
 <5eZ7a0HiqE3hghw3sT0L0Zn4Mi1FFfofz6hLGdLOsoc=.445b16ac-4d91-4538-92ba-a74f17781535@github.com>
 <c4jjcBPHlQ79cCbPxo8-EjjuWUzF3hjObagnARJe23s=.a897d7cb-8150-4871-bea6-6211ce88983e@github.com>
Message-ID: <E4uZV0yEJwF2yVG6oIebKDDyS0r6djuq7S-Ef7B5WYI=.769702c3-dc8d-456e-8e55-998428a5dd26@github.com>

On Mon, 11 Mar 2024 13:25:28 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   separate method to get LAF defined color
>
> src/java.desktop/share/classes/com/sun/java/swing/plaf/gtk/GTKStyle.java line 186:
> 
>> 184: 
>> 185:         if (id == Region.LABEL && type == ColorType.FOREGROUND
>> 186:                 && (state & SynthConstants.ENABLED) != 0) {
> 
> Doesn't `SynthConstants.DISABLED` need the same treatment?

Yes, I am working on it to fix the disabled case.

> I believe you should be using `labelColor` here. If anyone changes its value from `Color.RED` to anything else, the test will fail but it shouldn't. After all, why allowing configuring the colour in first place.

makes sense, will update it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17763#discussion_r1538712355
PR Review Comment: https://git.openjdk.org/jdk/pull/17763#discussion_r1538713181

From ihse at openjdk.org  Tue Mar 26 07:43:49 2024
From: ihse at openjdk.org (Magnus Ihse Bursie)
Date: Tue, 26 Mar 2024 07:43:49 GMT
Subject: RFR: 8307160: Fix AWT/2D/A11Y to support the permissive- flag on
 the Microsoft Visual C compiler [v57]
In-Reply-To: <oZQ26vkLCSuWTmJA1m_jCGwb73HviSylWTIJ_lFzlhU=.7f7a4765-6d82-4067-86ac-ec0f3df0a069@github.com>
References: <7piLRto5nNbhYYYfENCr5ecm4M2xNtMkjkE8XhrLLQ0=.8fd1ac3a-46f8-47a8-ae37-a4abbf7757d9@github.com>
 <oZQ26vkLCSuWTmJA1m_jCGwb73HviSylWTIJ_lFzlhU=.7f7a4765-6d82-4067-86ac-ec0f3df0a069@github.com>
Message-ID: <N8NRIUuKpQH_rY-e1Sab9yhKxy26EECVbG7G2opheL0=.096fb1de-f936-4203-bb40-2d0f807ac96c@github.com>

On Tue, 26 Mar 2024 00:17:56 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> We should set the -permissive- flag for the Microsoft Visual C compiler, as was requested by the now backed out [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). Doing so makes the Visual C compiler much less accepting of ill formed code, which will improve code quality on Windows in the future.
>
> Julian Waters has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Revert formatting change in src/java.desktop/windows/native/libawt/windows/awt_PrintJob.cpp
>   
>   Co-authored-by: Magnus Ihse Bursie <mag at icus.se>

src/java.desktop/windows/native/libawt/windows/awt_Canvas.cpp line 230:

> 228:     }
> 229: 
> 230:     AwtCanvas *c = (AwtCanvas*) pData;

Suggestion:

    AwtCanvas *c = (AwtCanvas*)pData;

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15096#discussion_r1538714268

From tr at openjdk.org  Tue Mar 26 07:47:25 2024
From: tr at openjdk.org (Tejesh R)
Date: Tue, 26 Mar 2024 07:47:25 GMT
Subject: RFR: 8328827: Convert
 java/awt/print/PrinterJob/PrinterDialogsModalityTest/PrinterDialogsModalityTest.html
 applet test to main [v4]
In-Reply-To: <C4K0xQu1_mt4GveCRGdQhEmVetXJzRMZH31b_ZbZq1Y=.787cff98-342d-4466-952b-f4eb6ef5d8bf@github.com>
References: <2iwbuovZ9rGwS8EqkKiSvnxU3_eJI-5KHFngpMs4qtE=.89885458-b5e0-48da-9810-4cfe71c9a420@github.com>
 <C4K0xQu1_mt4GveCRGdQhEmVetXJzRMZH31b_ZbZq1Y=.787cff98-342d-4466-952b-f4eb6ef5d8bf@github.com>
Message-ID: <Qph_KCoIZ2aKU9XJfJLLN0JaGKEiVHGGUwd4lWclLzE=.af1f8bd5-e40e-43d3-9c07-9795c93a8a0b@github.com>

On Tue, 26 Mar 2024 00:31:40 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

>> Convert java/awt/print/PrinterJob/PrinterDialogsModalityTest/PrinterDialogsModalityTest.html applet test to main using PassFailJFrame
>
> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove requires tag

Marked as reviewed by tr (Committer).

test/jdk/java/awt/print/PrinterJob/PrinterDialogsModalityTest.java line 74:

> 72:     }
> 73: 
> 74:     public static JFrame init() {

Can rename the `init` method. And the changes are good to me.

-------------

PR Review: https://git.openjdk.org/jdk/pull/18461#pullrequestreview-1959535915
PR Review Comment: https://git.openjdk.org/jdk/pull/18461#discussion_r1538715965

From ihse at openjdk.org  Tue Mar 26 07:47:47 2024
From: ihse at openjdk.org (Magnus Ihse Bursie)
Date: Tue, 26 Mar 2024 07:47:47 GMT
Subject: RFR: 8307160: Fix AWT/2D/A11Y to support the permissive- flag on
 the Microsoft Visual C compiler [v52]
In-Reply-To: <9agOsYWQVrdMO2D4unjqu1d3JoWs_FtQ-ATURfsANr4=.e51e3241-cc69-41df-a202-c7f24581408a@github.com>
References: <7piLRto5nNbhYYYfENCr5ecm4M2xNtMkjkE8XhrLLQ0=.8fd1ac3a-46f8-47a8-ae37-a4abbf7757d9@github.com>
 <0p1UVaUOt2bs1mkuBV1liUxBYGRhnKnclf1x_-Y22GE=.2de6c2c4-8cf5-470d-bdb3-cd0dd0e13975@github.com>
 <N-qe81Sj2dD9Jf389FDPidxtXG8VMfn9wwvvh3RdlzU=.db37387f-76f7-4096-a979-2b4a956925ea@github.com>
 <rvcdKMR7EYsspYcH1OX2_x4zC43WDQK9c70qt2Cl-CI=.1658a8f0-f530-44fc-aa47-493482d57c50@github.com>
 <9agOsYWQVrdMO2D4unjqu1d3JoWs_FtQ-ATURfsANr4=.e51e3241-cc69-41df-a202-c7f24581408a@github.com>
Message-ID: <rkEnV6PDBabKeBEdi2OZdpRngA9NGoxkegRy4U9qku0=.16ed5ecd-117b-4cd3-8ea8-5b55a86131d8@github.com>

On Tue, 26 Mar 2024 00:13:09 GMT, Julian Waters <jwaters at openjdk.org> wrote:

> I have a concern since the null check bailout involves THROW_NULL_PDATA_IF_NOT_DESTROYED, which is no longer accurate if we remove the pData local.

The name of the macro is not great, but it does not involve pData (the bad NPE error message notwithstanding):


#define THROW_NULL_PDATA_IF_NOT_DESTROYED(peer) {                         \
    jboolean destroyed = JNI_GET_DESTROYED(peer);                         \
    if (destroyed != JNI_TRUE) {                                          \
        env->ExceptionClear();                                            \
        JNU_ThrowNullPointerException(env, "null pData");                 \
    }                                                                     \
}


So you can go ahead and replace the pData references with the variable that will eventually be used.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15096#issuecomment-2019589225

From tr at openjdk.org  Tue Mar 26 07:56:22 2024
From: tr at openjdk.org (Tejesh R)
Date: Tue, 26 Mar 2024 07:56:22 GMT
Subject: RFR: 8328819: Remove applet usage from JFileChooser tests
 bug6698013 [v2]
In-Reply-To: <Q2wJmaeJrBAzvyCkZc_M4EfcA2mFcaIHv6Gbj-uDMGQ=.ed4c4d97-0f6f-4861-bf35-1720084675ce@github.com>
References: <iLcbr4t_2UJ4muFqTIm1NMfahCdwMTpgprqHo8WHHW0=.29e91557-e4b0-4d9c-ba32-fb2ab49e5de9@github.com>
 <Q2wJmaeJrBAzvyCkZc_M4EfcA2mFcaIHv6Gbj-uDMGQ=.ed4c4d97-0f6f-4861-bf35-1720084675ce@github.com>
Message-ID: <Tqw1ObtZG4RZ8sDHMocs9x4DZpVXmP-FG1Oo1sgJHaM=.3d5e64fd-a879-4bca-aac0-f0dd10da1d07@github.com>

On Mon, 25 Mar 2024 16:59:37 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> Removing applet usage from manual JFileChooser tests
>> The original test is failing (nothing shows up in the JFileChooser), but this change does replace the applet usage with PassFailJFrame
>
> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   increase rows to show second window

`rootFile`, `subdir `and `subdirFile` can be moved inside `VirtualFileSystemView` class ?

test/jdk/javax/swing/JFileChooser/6698013/bug6698013.java line 52:

> 50:                 1. Go into 'subdir' folder via double click
> 51:                 2. Return to parent directory
> 52:                 3. Go into 'subdir' folder: select 'subdir' folder and press the 'Open' button""";

Mentioning about Test Pass and Fail criteria would be beneficial, the instruction only says how to test, doesn't specify about Test PASS/FAIL criteria....?

-------------

PR Review: https://git.openjdk.org/jdk/pull/18456#pullrequestreview-1959557433
PR Review Comment: https://git.openjdk.org/jdk/pull/18456#discussion_r1538727435

From psadhukhan at openjdk.org  Tue Mar 26 08:25:25 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Tue, 26 Mar 2024 08:25:25 GMT
Subject: RFR: 8075917: The regression-swing case failed as the text on
 label is not painted red with the GTK L&F [v5]
In-Reply-To: <8aBNZkw1dIeHg9WidHBtQnx1mtZbSs4fWqQFl0KFOnI=.ddbcc158-5cb7-4ad6-ace0-4ed41f4d9048@github.com>
References: <iDOTnLkAimOa5kfDerZ09n4wsYiFYYUyBflOTYeUQZ0=.293390bd-bc47-4871-bf4c-d23c191d9426@github.com>
 <5eZ7a0HiqE3hghw3sT0L0Zn4Mi1FFfofz6hLGdLOsoc=.445b16ac-4d91-4538-92ba-a74f17781535@github.com>
 <8aBNZkw1dIeHg9WidHBtQnx1mtZbSs4fWqQFl0KFOnI=.ddbcc158-5cb7-4ad6-ace0-4ed41f4d9048@github.com>
Message-ID: <N1Kr4a0UVv-Wn5-LLP_lvDaeuuaXh_VUG2gO8EqueU8=.5d271c46-3a14-44bd-bf4a-c42c446f0e1a@github.com>

On Tue, 26 Mar 2024 07:38:39 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

> @aivanov-jdk
> 
> > This looks weird? So you're saying Label[Enabled].textForeground and Label[Disabled].textForeground are used for Nimbus (and Synth and GTK) instead of Label.foreground and Label.disabledForeground which are used for other L&Fs.
> 
> As per my understanding, Yes, for Nimbus LAF the UI properties are different than other LAF.
> 
> > Shouldn't we fix the problem by correcting the keys instead? It looks like it's what you're doing for specific components.
> 
> I am not sure if it is a problem or nimbus LAF is supposed to be like this.
> 
> > Is it specified anywhere that Synth-based L&Fs use different constants? It results in incorrect colors.
> 
> Need to check on this.
> 
> > If a developer sets the common properties, should they override Look-and-Feel defaults?
> 
> Will check and revert back.


As I understood, what `Label.background` color to be set, is determined via **`Nimbus.Overrides`** property
i.e.,  if `Label.background` is set to `Nimbus.Overrides`,  it should override the `label.setBackground()` user color setting 
else 
if `Nimbus.Overrides` is not set or set to null, then `Label.setBackground()` will hold precedent even if `Label.background` property is set


Similarly, if `Nimbus.Overrides` is set with `Label.background` color **AND** Label[Enabled].background is also set,
then 
Label[Enabled].background will have priority over 
Label.background which will have priority over
Label.setBackground() 

but this is also controlled by another boolean property **`Nimbus.Overrides.InheritDefaults`** in way that the above precedence is valid only if if Nimbus.Overrides.InheritDefaults is true

if **`Nimbus.Overrides.InheritDefaults`** is false, then Label[Enabled].background will be ignored
and
Label.background will have priority over 
Label.setBackground() 

This is somewhat explained in `https://docs.oracle.com/en/java/javase/21/docs/api/java.desktop/javax/swing/plaf/nimbus/package-summary.html` and tested in` test/jdk/javax/swing/plaf/nimbus/ColorCustomizationTest.java` so in a way, it seems widget[state].color setting is applicable for Nimbus only since we dont have GTK.Overrides property

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17763#issuecomment-2019798007

From jwaters at openjdk.org  Tue Mar 26 08:38:56 2024
From: jwaters at openjdk.org (Julian Waters)
Date: Tue, 26 Mar 2024 08:38:56 GMT
Subject: RFR: 8307160: Fix AWT/2D/A11Y to support the permissive- flag on
 the Microsoft Visual C compiler [v58]
In-Reply-To: <7piLRto5nNbhYYYfENCr5ecm4M2xNtMkjkE8XhrLLQ0=.8fd1ac3a-46f8-47a8-ae37-a4abbf7757d9@github.com>
References: <7piLRto5nNbhYYYfENCr5ecm4M2xNtMkjkE8XhrLLQ0=.8fd1ac3a-46f8-47a8-ae37-a4abbf7757d9@github.com>
Message-ID: <8wOZ7EDElH3e_T5mSI7ynob41VWrwZsZlCOkJh5rNFQ=.cf72839b-9d03-4b39-b7c4-3a71ccfd28ed@github.com>

> We should set the -permissive- flag for the Microsoft Visual C compiler, as was requested by the now backed out [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). Doing so makes the Visual C compiler much less accepting of ill formed code, which will improve code quality on Windows in the future.

Julian Waters has updated the pull request incrementally with one additional commit since the last revision:

  Revert formatting in src/java.desktop/windows/native/libawt/windows/awt_Canvas.cpp
  
  Co-authored-by: Magnus Ihse Bursie <mag at icus.se>

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/15096/files
  - new: https://git.openjdk.org/jdk/pull/15096/files/0c409d45..53e8bd6d

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=15096&range=57
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=15096&range=56-57

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/15096.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/15096/head:pull/15096

PR: https://git.openjdk.org/jdk/pull/15096

From jwaters at openjdk.org  Tue Mar 26 08:42:10 2024
From: jwaters at openjdk.org (Julian Waters)
Date: Tue, 26 Mar 2024 08:42:10 GMT
Subject: RFR: 8307160: Fix AWT/2D/A11Y to support the permissive- flag on
 the Microsoft Visual C compiler [v59]
In-Reply-To: <7piLRto5nNbhYYYfENCr5ecm4M2xNtMkjkE8XhrLLQ0=.8fd1ac3a-46f8-47a8-ae37-a4abbf7757d9@github.com>
References: <7piLRto5nNbhYYYfENCr5ecm4M2xNtMkjkE8XhrLLQ0=.8fd1ac3a-46f8-47a8-ae37-a4abbf7757d9@github.com>
Message-ID: <LTFsJE2QAqnnX7ZLPYL8wYaE32NObeHNcLB1Hi794OY=.d6f23b6c-9add-4e5a-90f7-0b891b274605@github.com>

> We should set the -permissive- flag for the Microsoft Visual C compiler, as was requested by the now backed out [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). Doing so makes the Visual C compiler much less accepting of ill formed code, which will improve code quality on Windows in the future.

Julian Waters has updated the pull request incrementally with one additional commit since the last revision:

  Revert formatting in src/java.desktop/windows/native/libawt/windows/awt_PrintJob.cpp
  
  Co-authored-by: Magnus Ihse Bursie <mag at icus.se>

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/15096/files
  - new: https://git.openjdk.org/jdk/pull/15096/files/53e8bd6d..1341d2e1

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=15096&range=58
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=15096&range=57-58

  Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod
  Patch: https://git.openjdk.org/jdk/pull/15096.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/15096/head:pull/15096

PR: https://git.openjdk.org/jdk/pull/15096

From jwaters at openjdk.org  Tue Mar 26 08:50:07 2024
From: jwaters at openjdk.org (Julian Waters)
Date: Tue, 26 Mar 2024 08:50:07 GMT
Subject: RFR: 8307160: Fix AWT/2D/A11Y to support the permissive- flag on
 the Microsoft Visual C compiler [v60]
In-Reply-To: <7piLRto5nNbhYYYfENCr5ecm4M2xNtMkjkE8XhrLLQ0=.8fd1ac3a-46f8-47a8-ae37-a4abbf7757d9@github.com>
References: <7piLRto5nNbhYYYfENCr5ecm4M2xNtMkjkE8XhrLLQ0=.8fd1ac3a-46f8-47a8-ae37-a4abbf7757d9@github.com>
Message-ID: <dyztINQWJilmbJlq0muNjQextBWu2dsYvdAV0YtaFgw=.7782eaf8-bf96-4e2f-ba1f-1cfb21f7e7f2@github.com>

> We should set the -permissive- flag for the Microsoft Visual C compiler, as was requested by the now backed out [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). Doing so makes the Visual C compiler much less accepting of ill formed code, which will improve code quality on Windows in the future.

Julian Waters has updated the pull request incrementally with two additional commits since the last revision:

 - Comment in src/java.desktop/windows/native/libawt/windows/awt_DnDDS.cpp
   
   Co-authored-by: Magnus Ihse Bursie <mag at icus.se>
 - Comment in src/java.desktop/windows/native/libawt/windows/awt_DnDDT.cpp
   
   Co-authored-by: Magnus Ihse Bursie <mag at icus.se>

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/15096/files
  - new: https://git.openjdk.org/jdk/pull/15096/files/1341d2e1..90d9096f

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=15096&range=59
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=15096&range=58-59

  Stats: 5 lines in 2 files changed: 3 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/15096.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/15096/head:pull/15096

PR: https://git.openjdk.org/jdk/pull/15096

From jwaters at openjdk.org  Tue Mar 26 08:50:07 2024
From: jwaters at openjdk.org (Julian Waters)
Date: Tue, 26 Mar 2024 08:50:07 GMT
Subject: RFR: 8307160: Fix AWT/2D/A11Y to support the permissive- flag on
 the Microsoft Visual C compiler [v52]
In-Reply-To: <rkEnV6PDBabKeBEdi2OZdpRngA9NGoxkegRy4U9qku0=.16ed5ecd-117b-4cd3-8ea8-5b55a86131d8@github.com>
References: <7piLRto5nNbhYYYfENCr5ecm4M2xNtMkjkE8XhrLLQ0=.8fd1ac3a-46f8-47a8-ae37-a4abbf7757d9@github.com>
 <0p1UVaUOt2bs1mkuBV1liUxBYGRhnKnclf1x_-Y22GE=.2de6c2c4-8cf5-470d-bdb3-cd0dd0e13975@github.com>
 <N-qe81Sj2dD9Jf389FDPidxtXG8VMfn9wwvvh3RdlzU=.db37387f-76f7-4096-a979-2b4a956925ea@github.com>
 <rvcdKMR7EYsspYcH1OX2_x4zC43WDQK9c70qt2Cl-CI=.1658a8f0-f530-44fc-aa47-493482d57c50@github.com>
 <9agOsYWQVrdMO2D4unjqu1d3JoWs_FtQ-ATURfsANr4=.e51e3241-cc69-41df-a202-c7f24581408a@github.com>
 <rkEnV6PDBabKeBEdi2OZdpRngA9NGoxkegRy4U9qku0=.16ed5ecd-117b-4cd3-8ea8-5b55a86131d8@github.com>
Message-ID: <e-jVzOEx4vN7QRrHz08-uziDn_sewCyBif2HwUWcnYU=.cae71a72-4e61-448a-a6a8-4d3989fa7dac@github.com>

On Tue, 26 Mar 2024 07:44:22 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

> > I have a concern since the null check bailout involves THROW_NULL_PDATA_IF_NOT_DESTROYED, which is no longer accurate if we remove the pData local.
> 
> The name of the macro is not great, but it does not involve pData (the bad NPE error message notwithstanding):
> 
> ```
> #define THROW_NULL_PDATA_IF_NOT_DESTROYED(peer) {                         \
>     jboolean destroyed = JNI_GET_DESTROYED(peer);                         \
>     if (destroyed != JNI_TRUE) {                                          \
>         env->ExceptionClear();                                            \
>         JNU_ThrowNullPointerException(env, "null pData");                 \
>     }                                                                     \
> }
> ```
> 
> So you can go ahead and replace the pData references with the variable that will eventually be used.

Alright, will do. Maybe as a further improvement, I can inline THROW_NULL_PDATA_IF_NOT_DESTROYED at its callsites and replace the bad NullPointerException error message with the proper null pointer name. Since Phil isn't here, what do you think?

Regardless, I really hope I can get this in by Thursday. University for me officially ramps up into _very_ high gear about that time, and I doubt I can juggle both JDK work and it all at once by then

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15096#issuecomment-2019839348

From jwaters at openjdk.org  Tue Mar 26 08:55:56 2024
From: jwaters at openjdk.org (Julian Waters)
Date: Tue, 26 Mar 2024 08:55:56 GMT
Subject: RFR: 8307160: Fix AWT/2D/A11Y to support the permissive- flag on
 the Microsoft Visual C compiler [v61]
In-Reply-To: <7piLRto5nNbhYYYfENCr5ecm4M2xNtMkjkE8XhrLLQ0=.8fd1ac3a-46f8-47a8-ae37-a4abbf7757d9@github.com>
References: <7piLRto5nNbhYYYfENCr5ecm4M2xNtMkjkE8XhrLLQ0=.8fd1ac3a-46f8-47a8-ae37-a4abbf7757d9@github.com>
Message-ID: <gLHJ2H5UbKs1Cwgg-aOPPScteSSClIlr2vF-BPtUB20=.64b6a55a-54ca-4b6c-9ae8-949be49c8ca1@github.com>

> We should set the -permissive- flag for the Microsoft Visual C compiler, as was requested by the now backed out [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). Doing so makes the Visual C compiler much less accepting of ill formed code, which will improve code quality on Windows in the future.

Julian Waters has updated the pull request incrementally with two additional commits since the last revision:

 - Whitespace in awt_DnDDS.cpp
 - Whitespace in awt_DnDDT.cpp

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/15096/files
  - new: https://git.openjdk.org/jdk/pull/15096/files/90d9096f..ef9f3a62

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=15096&range=60
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=15096&range=59-60

  Stats: 3 lines in 2 files changed: 0 ins; 1 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/15096.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/15096/head:pull/15096

PR: https://git.openjdk.org/jdk/pull/15096

From ihse at openjdk.org  Tue Mar 26 09:07:47 2024
From: ihse at openjdk.org (Magnus Ihse Bursie)
Date: Tue, 26 Mar 2024 09:07:47 GMT
Subject: RFR: 8307160: Fix AWT/2D/A11Y to support the permissive- flag on
 the Microsoft Visual C compiler [v61]
In-Reply-To: <gLHJ2H5UbKs1Cwgg-aOPPScteSSClIlr2vF-BPtUB20=.64b6a55a-54ca-4b6c-9ae8-949be49c8ca1@github.com>
References: <7piLRto5nNbhYYYfENCr5ecm4M2xNtMkjkE8XhrLLQ0=.8fd1ac3a-46f8-47a8-ae37-a4abbf7757d9@github.com>
 <gLHJ2H5UbKs1Cwgg-aOPPScteSSClIlr2vF-BPtUB20=.64b6a55a-54ca-4b6c-9ae8-949be49c8ca1@github.com>
Message-ID: <XulLa_IHf0D73TFh4v5PwjHQtqDq8-tSvwVHMT1cdR8=.17da8747-9e00-4bca-ad83-dd1b153bbeb2@github.com>

On Tue, 26 Mar 2024 08:55:56 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> We should set the -permissive- flag for the Microsoft Visual C compiler, as was requested by the now backed out [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). Doing so makes the Visual C compiler much less accepting of ill formed code, which will improve code quality on Windows in the future.
>
> Julian Waters has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Whitespace in awt_DnDDS.cpp
>  - Whitespace in awt_DnDDT.cpp

src/java.desktop/windows/native/libawt/windows/awt_PrintJob.cpp line 598:

> 596:         int sz = GetLocaleInfo(LOCALE_USER_DEFAULT, LOCALE_IMEASURE, NULL, 0);
> 597:         if (sz > 0) {
> 598:           LPTSTR str = (LPTSTR) SAFE_SIZE_ARRAY_ALLOC(safe_Malloc, sizeof(TCHAR), sz);

Suggestion:

          LPTSTR str = (LPTSTR)SAFE_SIZE_ARRAY_ALLOC(safe_Malloc, sizeof(TCHAR), sz);

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15096#discussion_r1538833940

From duke at openjdk.org  Tue Mar 26 11:29:36 2024
From: duke at openjdk.org (rjolly)
Date: Tue, 26 Mar 2024 11:29:36 GMT
Subject: RFR: 8328953 : JEditorPane.read throws ChangedCharSetException
Message-ID: <j32PTT_v706cIsLg9ssxPivpEJoo5bCJ1H5NHj3KDhY=.b9e439f3-ce7a-4d63-bfe4-bd415a34a2d2@github.com>

ChangedCharSetException is used to amend the charset during read according to html directives. Currently it causes immediate exit of the method which in turn causes failure to load html documents with charset directives (even if the latter must not change after all). This PR restores the catch operation as it was before the use of try with resources.

-------------

Commit messages:
 - 8328953 : JEditorPane.read throws ChangedCharSetException

Changes: https://git.openjdk.org/jdk/pull/17567/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=17567&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8328953
  Stats: 118 lines in 2 files changed: 93 ins; 16 del; 9 mod
  Patch: https://git.openjdk.org/jdk/pull/17567.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17567/head:pull/17567

PR: https://git.openjdk.org/jdk/pull/17567

From tr at openjdk.org  Tue Mar 26 11:29:36 2024
From: tr at openjdk.org (Tejesh R)
Date: Tue, 26 Mar 2024 11:29:36 GMT
Subject: RFR: 8328953 : JEditorPane.read throws ChangedCharSetException
In-Reply-To: <j32PTT_v706cIsLg9ssxPivpEJoo5bCJ1H5NHj3KDhY=.b9e439f3-ce7a-4d63-bfe4-bd415a34a2d2@github.com>
References: <j32PTT_v706cIsLg9ssxPivpEJoo5bCJ1H5NHj3KDhY=.b9e439f3-ce7a-4d63-bfe4-bd415a34a2d2@github.com>
Message-ID: <e0JrlE_MCHbx-gpeLH3iD-_keuzTVZ9EXcuPkOzVJT0=.4175c156-8ce3-4e5a-a314-38ee1d140168@github.com>

On Thu, 25 Jan 2024 11:11:47 GMT, rjolly <duke at openjdk.org> wrote:

> ChangedCharSetException is used to amend the charset during read according to html directives. Currently it causes immediate exit of the method which in turn causes failure to load html documents with charset directives (even if the latter must not change after all). This PR restores the catch operation as it was before the use of try with resources.

Verified the fix with the shared test (regression test from [JDK-8146319](https://bugs.openjdk.org/browse/JDK-8146319)), its working fine.

-------------

PR Review: https://git.openjdk.org/jdk/pull/17567#pullrequestreview-1959906644

From duke at openjdk.org  Tue Mar 26 11:29:36 2024
From: duke at openjdk.org (rjolly)
Date: Tue, 26 Mar 2024 11:29:36 GMT
Subject: RFR: 8328953 : JEditorPane.read throws ChangedCharSetException
In-Reply-To: <j32PTT_v706cIsLg9ssxPivpEJoo5bCJ1H5NHj3KDhY=.b9e439f3-ce7a-4d63-bfe4-bd415a34a2d2@github.com>
References: <j32PTT_v706cIsLg9ssxPivpEJoo5bCJ1H5NHj3KDhY=.b9e439f3-ce7a-4d63-bfe4-bd415a34a2d2@github.com>
Message-ID: <1MOJPinRAWnrKr4DWeXfV_cUxzU2cHUprU9_xS1xl7k=.202cadfb-75fc-4216-be18-e7a590ebb0ca@github.com>

On Thu, 25 Jan 2024 11:11:47 GMT, rjolly <duke at openjdk.org> wrote:

> ChangedCharSetException is used to amend the charset during read according to html directives. Currently it causes immediate exit of the method which in turn causes failure to load html documents with charset directives (even if the latter must not change after all). This PR restores the catch operation as it was before the use of try with resources.

Up

js>JEditorPane=javax.swing.JEditorPane
class javax.swing.JEditorPane
js>e=new JEditorPane()
javax.swing.JEditorPane[,0,0,0x0,invalid,layout=javax.swing.plaf.basic.BasicTextUI$UpdateHandler,alignmentX=0.0,alignmentY=0.0,border=javax.swing.plaf.basic.BasicBorders$MarginBorder at 4ac7e601,flags=296,maximumSize=,minimumSize=,preferredSize=,caretColor=sun.swing.PrintColorUIResource[r=51,g=51,b=51],disabledTextColor=javax.swing.plaf.ColorUIResource[r=184,g=207,b=229],editable=true,margin=javax.swing.plaf.InsetsUIResource[top=3,left=3,bottom=3,right=3],selectedTextColor=sun.swing.PrintColorUIResource[r=51,g=51,b=51],selectionColor=javax.swing.plaf.ColorUIResource[r=184,g=207,b=229],kit=javax.swing.JEditorPane$PlainEditorKit at 66bddb1f,typeHandlers=]
js>e.setContentType("text/html")
js>kit=e.getEditorKit()
javax.swing.text.html.HTMLEditorKit at 3602e8c4
js>doc=kit.createDefaultDocument()
javax.swing.text.html.HTMLDocument at 3367e16c
js>e.setDocument(doc)
js>URL=java.net.URL
class java.net.URL
js>u=new URL("https://www.google.com/")
https://www.google.com/
js>is=u.openStream()
sun.net.www.protocol.http.HttpURLConnection$HttpInputStream at 754c74c6
js>e.read(is, doc)
org.mozilla.javascript.WrappedException: Wrapped javax.swing.text.ChangedCharSetException (<Unknown source>#1) in <Unknown source> at line number 1

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17567#issuecomment-1959435606
PR Comment: https://git.openjdk.org/jdk/pull/17567#issuecomment-1992583067

From aivanov at openjdk.org  Tue Mar 26 11:29:37 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 26 Mar 2024 11:29:37 GMT
Subject: RFR: 8328953 : JEditorPane.read throws ChangedCharSetException
In-Reply-To: <1MOJPinRAWnrKr4DWeXfV_cUxzU2cHUprU9_xS1xl7k=.202cadfb-75fc-4216-be18-e7a590ebb0ca@github.com>
References: <j32PTT_v706cIsLg9ssxPivpEJoo5bCJ1H5NHj3KDhY=.b9e439f3-ce7a-4d63-bfe4-bd415a34a2d2@github.com>
 <1MOJPinRAWnrKr4DWeXfV_cUxzU2cHUprU9_xS1xl7k=.202cadfb-75fc-4216-be18-e7a590ebb0ca@github.com>
Message-ID: <aOmxqjzD-27dOTMBjUzXxaAcBpfd5XCFj_gRCcvEaeE=.05523851-911e-4c7e-8026-c6827742be46@github.com>

On Thu, 22 Feb 2024 13:15:49 GMT, rjolly <duke at openjdk.org> wrote:

>> ChangedCharSetException is used to amend the charset during read according to html directives. Currently it causes immediate exit of the method which in turn causes failure to load html documents with charset directives (even if the latter must not change after all). This PR restores the catch operation as it was before the use of try with resources.
>
> Up

@rjolly Thank you for your contribution. Could you provide more details about the issue? The PR needs to be linked to a JBS issue. I'll create one for you after I get a more detailed description of the problem from you.

A test case is also welcome. And it's needed a regression test for the change anyway, if it's not hard to create. I believe a test case can be written for this issue.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17567#issuecomment-1989487531

From duke at openjdk.org  Tue Mar 26 11:29:37 2024
From: duke at openjdk.org (rjolly)
Date: Tue, 26 Mar 2024 11:29:37 GMT
Subject: RFR: 8328953 : JEditorPane.read throws ChangedCharSetException
In-Reply-To: <aOmxqjzD-27dOTMBjUzXxaAcBpfd5XCFj_gRCcvEaeE=.05523851-911e-4c7e-8026-c6827742be46@github.com>
References: <j32PTT_v706cIsLg9ssxPivpEJoo5bCJ1H5NHj3KDhY=.b9e439f3-ce7a-4d63-bfe4-bd415a34a2d2@github.com>
 <1MOJPinRAWnrKr4DWeXfV_cUxzU2cHUprU9_xS1xl7k=.202cadfb-75fc-4216-be18-e7a590ebb0ca@github.com>
 <aOmxqjzD-27dOTMBjUzXxaAcBpfd5XCFj_gRCcvEaeE=.05523851-911e-4c7e-8026-c6827742be46@github.com>
Message-ID: <RMMDb3wD9iwW6FO7QH4442upItb30bPp8GMbs7fIpPs=.6b9ca5eb-a8de-4f5c-afb6-a6e934a646ff@github.com>

On Mon, 11 Mar 2024 21:35:48 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Up
>
> @rjolly Thank you for your contribution. Could you provide more details about the issue? The PR needs to be linked to a JBS issue. I'll create one for you after I get a more detailed description of the problem from you.
> 
> A test case is also welcome. And it's needed a regression test for the change anyway, if it's not hard to create. I believe a test case can be written for this issue.

Hi @aivanov-jdk , thanks for your response. Is there a place where I can put my non-regression test? Thanks!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17567#issuecomment-2003256738

From aivanov at openjdk.org  Tue Mar 26 11:29:37 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 26 Mar 2024 11:29:37 GMT
Subject: RFR: 8328953 : JEditorPane.read throws ChangedCharSetException
In-Reply-To: <RMMDb3wD9iwW6FO7QH4442upItb30bPp8GMbs7fIpPs=.6b9ca5eb-a8de-4f5c-afb6-a6e934a646ff@github.com>
References: <j32PTT_v706cIsLg9ssxPivpEJoo5bCJ1H5NHj3KDhY=.b9e439f3-ce7a-4d63-bfe4-bd415a34a2d2@github.com>
 <1MOJPinRAWnrKr4DWeXfV_cUxzU2cHUprU9_xS1xl7k=.202cadfb-75fc-4216-be18-e7a590ebb0ca@github.com>
 <aOmxqjzD-27dOTMBjUzXxaAcBpfd5XCFj_gRCcvEaeE=.05523851-911e-4c7e-8026-c6827742be46@github.com>
 <RMMDb3wD9iwW6FO7QH4442upItb30bPp8GMbs7fIpPs=.6b9ca5eb-a8de-4f5c-afb6-a6e934a646ff@github.com>
Message-ID: <HAmfqi2pHdk_6tzH96I4h23lbPPW89O18Dy85lDNhyU=.6a002dcd-516c-4399-b407-f4514ac71ed2@github.com>

On Mon, 18 Mar 2024 09:04:05 GMT, rjolly <duke at openjdk.org> wrote:

>> @rjolly Thank you for your contribution. Could you provide more details about the issue? The PR needs to be linked to a JBS issue. I'll create one for you after I get a more detailed description of the problem from you.
>> 
>> A test case is also welcome. And it's needed a regression test for the change anyway, if it's not hard to create. I believe a test case can be written for this issue.
>
> Hi @aivanov-jdk , thanks for your response. Is there a place where I can put my non-regression test? Thanks!

@rjolly Sorry for my delayed reply. I have submitted [JDK-8328953](https://bugs.openjdk.org/browse/JDK-8328953): _JEditorPane.read throws ChangedCharSetException_ for you. The subject may be amended to describe issue better.

I attached the test case. I can reproduce the bug with Java 11 and above. I think it is a regression from [JDK-8146319](https://bugs.openjdk.org/browse/JDK-8146319) which added try-with-resources.

@rjolly You should edit the subject of the PR to `8328953: JEditorPane.read throws ChangedCharSetException`. The Skara bot will then mark the PR as ready for review (`rfr`) and will send announcement of the PR and each comment to the *client-libs-dev* mailing list.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17567#issuecomment-2018505966
PR Comment: https://git.openjdk.org/jdk/pull/17567#issuecomment-2020166773

From aivanov at openjdk.org  Tue Mar 26 11:29:37 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 26 Mar 2024 11:29:37 GMT
Subject: RFR: 8328953 : JEditorPane.read throws ChangedCharSetException
In-Reply-To: <j32PTT_v706cIsLg9ssxPivpEJoo5bCJ1H5NHj3KDhY=.b9e439f3-ce7a-4d63-bfe4-bd415a34a2d2@github.com>
References: <j32PTT_v706cIsLg9ssxPivpEJoo5bCJ1H5NHj3KDhY=.b9e439f3-ce7a-4d63-bfe4-bd415a34a2d2@github.com>
Message-ID: <gl6daVFXnF3_GJlHyEH-n6lO92lO5E3Z_hK6AMa5cyQ=.1f297440-88a0-4f0b-84d9-971a7cd75085@github.com>

On Thu, 25 Jan 2024 11:11:47 GMT, rjolly <duke at openjdk.org> wrote:

> ChangedCharSetException is used to amend the charset during read according to html directives. Currently it causes immediate exit of the method which in turn causes failure to load html documents with charset directives (even if the latter must not change after all). This PR restores the catch operation as it was before the use of try with resources.

Your changeset looks good to me, it resolves the problem, the HTML stream is re-read with the correct charset and displays correctly.

The test that I attached to JBS can be converted to a jtreg regression test and added to your PR.

You should not force-push to a branch that's already on the review. If you want to update to latest master, use `git merge` to update the branch and then push it.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17567#issuecomment-2018941633
PR Comment: https://git.openjdk.org/jdk/pull/17567#issuecomment-2020170003

From tr at openjdk.org  Tue Mar 26 11:44:22 2024
From: tr at openjdk.org (Tejesh R)
Date: Tue, 26 Mar 2024 11:44:22 GMT
Subject: RFR: 8328953 : JEditorPane.read throws ChangedCharSetException
In-Reply-To: <j32PTT_v706cIsLg9ssxPivpEJoo5bCJ1H5NHj3KDhY=.b9e439f3-ce7a-4d63-bfe4-bd415a34a2d2@github.com>
References: <j32PTT_v706cIsLg9ssxPivpEJoo5bCJ1H5NHj3KDhY=.b9e439f3-ce7a-4d63-bfe4-bd415a34a2d2@github.com>
Message-ID: <FEVBuu1gQQYvWCjEYrGUdTBx-1ops3L3ySgJIo6FrOU=.30ca2e98-3846-4df8-bc77-abe45e745399@github.com>

On Thu, 25 Jan 2024 11:11:47 GMT, rjolly <duke at openjdk.org> wrote:

> ChangedCharSetException is used to amend the charset during read according to html directives. Currently it causes immediate exit of the method which in turn causes failure to load html documents with charset directives (even if the latter must not change after all). This PR restores the catch operation as it was before the use of try with resources.

Verified the fix with the shared test, its working fine.

test/jdk/javax/swing/JEditorPane/8328953/EditorPaneCharset.java line 2:

> 1: /*
> 2:  * Copyright (c) 2016, Oracle and/or its affiliates. All rights reserved.

Append Copywrite year.

test/jdk/javax/swing/JEditorPane/8328953/EditorPaneCharset.java line 24:

> 22:  */
> 23: 
> 24: /*

We normally place jtreg tags after imports.

test/jdk/javax/swing/JEditorPane/8328953/EditorPaneCharset.java line 46:

> 44:             "<html lang=\"ru\">\n" +
> 45:             "<head>\n" +
> 46:             "    <meta http-equiv=\"Content-Type\" content=\"text/html; charset=windows-1251\">\n" +

Line exceeds column length which we usually restrict to 80...

-------------

PR Review: https://git.openjdk.org/jdk/pull/17567#pullrequestreview-1960096438
PR Review Comment: https://git.openjdk.org/jdk/pull/17567#discussion_r1539054464
PR Review Comment: https://git.openjdk.org/jdk/pull/17567#discussion_r1539055330
PR Review Comment: https://git.openjdk.org/jdk/pull/17567#discussion_r1539061293

From aivanov at openjdk.org  Tue Mar 26 12:03:28 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 26 Mar 2024 12:03:28 GMT
Subject: RFR: 8328953 : JEditorPane.read throws ChangedCharSetException
In-Reply-To: <j32PTT_v706cIsLg9ssxPivpEJoo5bCJ1H5NHj3KDhY=.b9e439f3-ce7a-4d63-bfe4-bd415a34a2d2@github.com>
References: <j32PTT_v706cIsLg9ssxPivpEJoo5bCJ1H5NHj3KDhY=.b9e439f3-ce7a-4d63-bfe4-bd415a34a2d2@github.com>
Message-ID: <VSAGLS_MdfxA2dsfVa1pZ4BesQkm1ukCAE-PmYeEQ48=.4352716f-ecce-4116-b57b-7e5338e28347@github.com>

On Thu, 25 Jan 2024 11:11:47 GMT, rjolly <duke at openjdk.org> wrote:

> ChangedCharSetException is used to amend the charset during read according to html directives. Currently it causes immediate exit of the method which in turn causes failure to load html documents with charset directives (even if the latter must not change after all). This PR restores the catch operation as it was before the use of try with resources.

Changes requested by aivanov (Reviewer).

src/java.desktop/share/classes/javax/swing/JEditorPane.java line 1:

> 1: /*

Please update the copyright year to `1997, 2024`. That is you change 2023 to 2024.

src/java.desktop/share/classes/javax/swing/JEditorPane.java line 621:

> 619:         String charset = (String) getClientProperty("charset");
> 620:         try(Reader r = (charset != null) ? new InputStreamReader(in, charset) :
> 621:                 new InputStreamReader(in)) {

The changeset looks confusing in the diff. It becomes clearer if you disable showing whitespace differences.

You could've elaborated on the fix in the description.

The fix is to add a nested `try`-block inside `try-with-resource`; all the exceptions are handled in the nested `try`; the outer `try`-with-resouces only closes the input stream.

test/jdk/javax/swing/JEditorPane/8328953/EditorPaneCharset.java line 1:

> 1: /*

Please, place the test into `JEditorPane` directly, that is remove `8328953` subfolder. New tests use flat structure unless supporting files are required.

test/jdk/javax/swing/JEditorPane/8328953/EditorPaneCharset.java line 2:

> 1: /*
> 2:  * Copyright (c) 2016, Oracle and/or its affiliates. All rights reserved.

Suggestion:

 * Copyright (c) 2024, Oracle and/or its affiliates. All rights reserved.

It's a new file.

test/jdk/javax/swing/JEditorPane/8328953/EditorPaneCharset.java line 30:

> 28:  * @summary JEditorPane.read throws ChangedCharSetException
> 29:  * @run main EditorPaneCharset
> 30:  */

It hasn't been agreed to, yet I prefer the jtreg placed right before the test class declaration rather than before the imports.

Either way is fine.

test/jdk/javax/swing/JEditorPane/8328953/EditorPaneCharset.java line 53:

> 51:     public static void main(String[] args) {
> 52:         SwingUtilities.invokeLater(EditorPaneCharset::new);
> 53:     }

It is not a good jtreg regression test.

I believe the test can be headless, you don't need to display the component. It could even create `JEditorPane` in its `main` method. The expectation is that `editorPane.read` does not throw `ChangedCharSetException`. I propose adding a comment about the fact.

Then, I'd verify that the text in the editor pane is the expected text. So you will take the document root and descend the three of elements to `<p>`. The text inside the paragraph must match the text in the HTML sample, it should be *???????, ???!?* (it means *?Hello World?*, I'm not creative). You could move the text into a constant to have the text to compare to and concatenate the constant into the HTML snippet.

Something like that:

main() throws IOException {
    // Shouldn't throw ChangedCharSetException
    editorPane.read(?);

    Element root = document.getDefaultRootElement();
    Element p = /* */;
    String pText = document.getText(p.getStartOffset(),
                                    p.getEndOffset() - p.getStartOffset()));
    if (!CYRILLIC_TEXT.equals(pText)) {
        throw new RuntimeException("Text doesn't match");
    }
}


where `CYRILLIC_TEXT` is the constant with the text in the HTML snippet.

You can use this test as an example on how to get to the `<p>` element in `HTMLDocument`:  
https://github.com/openjdk/jdk/blob/cc1800fa4de3c1369efd46f5ca967ea82763f5d5/test/jdk/javax/swing/text/html/HTMLDocument/HTMLUnderlineStrike.java#L65-L68

Should you have any questions, don't hesitate to ask.

-------------

PR Review: https://git.openjdk.org/jdk/pull/17567#pullrequestreview-1960082452
PR Review Comment: https://git.openjdk.org/jdk/pull/17567#discussion_r1539045914
PR Review Comment: https://git.openjdk.org/jdk/pull/17567#discussion_r1539087982
PR Review Comment: https://git.openjdk.org/jdk/pull/17567#discussion_r1539065172
PR Review Comment: https://git.openjdk.org/jdk/pull/17567#discussion_r1539047328
PR Review Comment: https://git.openjdk.org/jdk/pull/17567#discussion_r1539066742
PR Review Comment: https://git.openjdk.org/jdk/pull/17567#discussion_r1539063737

From aivanov at openjdk.org  Tue Mar 26 12:07:28 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 26 Mar 2024 12:07:28 GMT
Subject: RFR: 8328953 : JEditorPane.read throws ChangedCharSetException
In-Reply-To: <gl6daVFXnF3_GJlHyEH-n6lO92lO5E3Z_hK6AMa5cyQ=.1f297440-88a0-4f0b-84d9-971a7cd75085@github.com>
References: <j32PTT_v706cIsLg9ssxPivpEJoo5bCJ1H5NHj3KDhY=.b9e439f3-ce7a-4d63-bfe4-bd415a34a2d2@github.com>
 <gl6daVFXnF3_GJlHyEH-n6lO92lO5E3Z_hK6AMa5cyQ=.1f297440-88a0-4f0b-84d9-971a7cd75085@github.com>
Message-ID: <7PMxmyF_SKUKRfL0fB1qajUfkNp4h9I3Ew1Ih74I3R4=.b3a7813c-d0cf-4b9d-a784-5eb901b70421@github.com>

On Tue, 26 Mar 2024 11:25:45 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> You should not force-push to a branch that's already on the review. If you want to update to latest master, use `git merge` to update the branch and then push it.

A sample on how to merge master in another PR: https://github.com/openjdk/jdk/pull/9825#issuecomment-1447007715

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17567#issuecomment-2020244200

From aivanov at openjdk.org  Tue Mar 26 12:07:29 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 26 Mar 2024 12:07:29 GMT
Subject: RFR: 8328953 : JEditorPane.read throws ChangedCharSetException
In-Reply-To: <FEVBuu1gQQYvWCjEYrGUdTBx-1ops3L3ySgJIo6FrOU=.30ca2e98-3846-4df8-bc77-abe45e745399@github.com>
References: <j32PTT_v706cIsLg9ssxPivpEJoo5bCJ1H5NHj3KDhY=.b9e439f3-ce7a-4d63-bfe4-bd415a34a2d2@github.com>
 <FEVBuu1gQQYvWCjEYrGUdTBx-1ops3L3ySgJIo6FrOU=.30ca2e98-3846-4df8-bc77-abe45e745399@github.com>
Message-ID: <E_t58UdskL-rL1k8qZ9BIGaUQWmJkqXCkGiAuJrl698=.dbc19da5-ce12-4db4-b4ff-8b7b4b9e0559@github.com>

On Tue, 26 Mar 2024 11:40:50 GMT, Tejesh R <tr at openjdk.org> wrote:

>> ChangedCharSetException is used to amend the charset during read according to html directives. Currently it causes immediate exit of the method which in turn causes failure to load html documents with charset directives (even if the latter must not change after all). This PR restores the catch operation as it was before the use of try with resources.
>
> test/jdk/javax/swing/JEditorPane/8328953/EditorPaneCharset.java line 46:
> 
>> 44:             "<html lang=\"ru\">\n" +
>> 45:             "<head>\n" +
>> 46:             "    <meta http-equiv=\"Content-Type\" content=\"text/html; charset=windows-1251\">\n" +
> 
> Line exceeds column length which we usually restrict to 80...

It fits into 100-column limit, so not strictly necessary? Could be broken though to fit into 80-column limit.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17567#discussion_r1539093429

From aivanov at openjdk.org  Tue Mar 26 12:11:22 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 26 Mar 2024 12:11:22 GMT
Subject: RFR: 8328953 : JEditorPane.read throws ChangedCharSetException
In-Reply-To: <bBnf2seDlBE_1AIgjY7Q3TvuPTb9LVb3aWBWp1arQoY=.deba13d0-7c54-4f70-b6eb-4ff34c032d61@github.com>
References: <j32PTT_v706cIsLg9ssxPivpEJoo5bCJ1H5NHj3KDhY=.b9e439f3-ce7a-4d63-bfe4-bd415a34a2d2@github.com>
 <VSAGLS_MdfxA2dsfVa1pZ4BesQkm1ukCAE-PmYeEQ48=.4352716f-ecce-4116-b57b-7e5338e28347@github.com>
 <bBnf2seDlBE_1AIgjY7Q3TvuPTb9LVb3aWBWp1arQoY=.deba13d0-7c54-4f70-b6eb-4ff34c032d61@github.com>
Message-ID: <yNrRof2WRKw3kX_RtsP1-LpC_R7gjbM4Yh4wyYouq6k=.8ebeb777-b36d-4987-95fa-763e123685aa@github.com>

On Tue, 26 Mar 2024 12:04:35 GMT, Tejesh R <tr at openjdk.org> wrote:

>> src/java.desktop/share/classes/javax/swing/JEditorPane.java line 621:
>> 
>>> 619:         String charset = (String) getClientProperty("charset");
>>> 620:         try(Reader r = (charset != null) ? new InputStreamReader(in, charset) :
>>> 621:                 new InputStreamReader(in)) {
>> 
>> The changeset looks confusing in the diff. It becomes clearer if you disable showing whitespace differences.
>> 
>> You could've elaborated on the fix in the description.
>> 
>> The fix is to add a nested `try`-block inside `try-with-resource`; all the exceptions are handled in the nested `try`; the outer `try`-with-resouces only closes the input stream.
>
> Yeah, I too agree on this point. The fix description has to elaborated, we are not able to make out in diff.

I pulled the change into my local workspace to test it. IDE hides white-space differences and the fix becomes clear. I hid white-space differences in GitHub diff viewer: only two lines are changed. :)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17567#discussion_r1539099247

From tr at openjdk.org  Tue Mar 26 12:07:29 2024
From: tr at openjdk.org (Tejesh R)
Date: Tue, 26 Mar 2024 12:07:29 GMT
Subject: RFR: 8328953 : JEditorPane.read throws ChangedCharSetException
In-Reply-To: <VSAGLS_MdfxA2dsfVa1pZ4BesQkm1ukCAE-PmYeEQ48=.4352716f-ecce-4116-b57b-7e5338e28347@github.com>
References: <j32PTT_v706cIsLg9ssxPivpEJoo5bCJ1H5NHj3KDhY=.b9e439f3-ce7a-4d63-bfe4-bd415a34a2d2@github.com>
 <VSAGLS_MdfxA2dsfVa1pZ4BesQkm1ukCAE-PmYeEQ48=.4352716f-ecce-4116-b57b-7e5338e28347@github.com>
Message-ID: <bBnf2seDlBE_1AIgjY7Q3TvuPTb9LVb3aWBWp1arQoY=.deba13d0-7c54-4f70-b6eb-4ff34c032d61@github.com>

On Tue, 26 Mar 2024 12:00:07 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> ChangedCharSetException is used to amend the charset during read according to html directives. Currently it causes immediate exit of the method which in turn causes failure to load html documents with charset directives (even if the latter must not change after all). This PR restores the catch operation as it was before the use of try with resources.
>
> src/java.desktop/share/classes/javax/swing/JEditorPane.java line 621:
> 
>> 619:         String charset = (String) getClientProperty("charset");
>> 620:         try(Reader r = (charset != null) ? new InputStreamReader(in, charset) :
>> 621:                 new InputStreamReader(in)) {
> 
> The changeset looks confusing in the diff. It becomes clearer if you disable showing whitespace differences.
> 
> You could've elaborated on the fix in the description.
> 
> The fix is to add a nested `try`-block inside `try-with-resource`; all the exceptions are handled in the nested `try`; the outer `try`-with-resouces only closes the input stream.

Yeah, I too agree on this point. The fix description has to elaborated, we are not able to make out in diff.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17567#discussion_r1539093175

From aivanov at openjdk.org  Tue Mar 26 12:17:23 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 26 Mar 2024 12:17:23 GMT
Subject: RFR: 8305072: Win32ShellFolder2.compareTo is inconsistent [v2]
In-Reply-To: <YV5wUKr1poC0E1P4rFnU_9Phjy_jnxkb3j1qVRe0jv8=.148bbf10-0c1d-44d9-8d56-79c3fc9d566c@github.com>
References: <bEiHvkFnBZDqmiqQdk_-_mATVhDbAD7NZX7VnkHLG2E=.27ee84ba-00fd-405a-9489-8fe11c215af9@github.com>
 <21db5CiFTVN7scwsIHknMxF4YaVQd06m7gUOhcCLvMI=.e2f61ea7-bf9a-4632-bf45-c89f979ae806@github.com>
 <6dQg9rhDwh4ZL7D2JfYpA0xNP_eJDbOK3rNgj7efckM=.c5001d8a-cce5-4a11-a91d-eda8e90b8056@github.com>
 <76BSt4HYmTD2DiZzBUvNvBdvd5d1MFinIDsgp2YuHjs=.68646608-e266-4ca3-8495-59e237f8607c@github.com>
 <5btT_N4c5R89DQ8aoSyjm6lIR7PHLWC141uAIdH_Bjw=.f36326e9-0f59-4545-82bf-f3c8b4dbaa87@github.com>
 <xEaIYt-r-0MtZBDcpke8dec_MkYGmm_gsj0NcagSMGs=.0f29ce1b-ff4b-4505-9095-5602cdbd3de9@github.com>
 <2LG0ERi-9ETplOC0EdSozMQ4WTJDgx2lw3Z1J6IVrrY=.03443566-afd3-4d7e-8caa-46fa10c55a5e@github.com>
 <c5xKrm3ItuUN26iAY8k2RiSZu8ppMnTVisVokmy7RMA=.36ff81f6-f473-4b35-b853-595dc5491230@github.com>
 <YV5wUKr1poC0E1P4rFnU_9Phjy_jnxkb3j1qVRe0jv8=.148bbf10-0c1d-44d9-8d56-79c3fc9d566c@github.com>
Message-ID: <tf310kBIld9PUj-PQVV0jYd_q-i-7zvAmN23or0_e7M=.24db1141-4585-4ab6-bb2b-a5e8529fe8da@github.com>

On Mon, 25 Mar 2024 23:48:23 GMT, Joel Uckelman <duke at openjdk.org> wrote:

> I haven't heard back yet. I hope investigating the second bug will not hold up the fix for the first bug getting merged.

It's not a show-stopper. These are different bugs. If possible, I'd like to follow up and find the root cause of why there are two identical folders in the file list.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18126#discussion_r1539108157

From duke at openjdk.org  Tue Mar 26 12:55:53 2024
From: duke at openjdk.org (rjolly)
Date: Tue, 26 Mar 2024 12:55:53 GMT
Subject: RFR: 8328953 : JEditorPane.read throws ChangedCharSetException
 [v2]
In-Reply-To: <j32PTT_v706cIsLg9ssxPivpEJoo5bCJ1H5NHj3KDhY=.b9e439f3-ce7a-4d63-bfe4-bd415a34a2d2@github.com>
References: <j32PTT_v706cIsLg9ssxPivpEJoo5bCJ1H5NHj3KDhY=.b9e439f3-ce7a-4d63-bfe4-bd415a34a2d2@github.com>
Message-ID: <WKXTiZDyBYdRZTpcH6jMTZ4xclzbvGYrEt9ANZIUJTg=.73f2b600-b80f-4072-922e-e72c32752057@github.com>

> ChangedCharSetException is used to amend the charset during read according to html directives. Currently it causes immediate exit of the method which in turn causes failure to load html documents with charset directives (even if the latter must not change after all). This PR restores the catch operation as it was before the use of try with resources.

rjolly has updated the pull request incrementally with one additional commit since the last revision:

  8328953 : JEditorPane.read throws ChangedCharSetException

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/17567/files
  - new: https://git.openjdk.org/jdk/pull/17567/files/0a5bc93e..c67179d5

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=17567&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17567&range=00-01

  Stats: 18 lines in 1 file changed: 9 ins; 7 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/17567.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17567/head:pull/17567

PR: https://git.openjdk.org/jdk/pull/17567

From aivanov at openjdk.org  Tue Mar 26 13:18:24 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Tue, 26 Mar 2024 13:18:24 GMT
Subject: RFR: 8328953 : JEditorPane.read throws ChangedCharSetException
 [v2]
In-Reply-To: <WKXTiZDyBYdRZTpcH6jMTZ4xclzbvGYrEt9ANZIUJTg=.73f2b600-b80f-4072-922e-e72c32752057@github.com>
References: <j32PTT_v706cIsLg9ssxPivpEJoo5bCJ1H5NHj3KDhY=.b9e439f3-ce7a-4d63-bfe4-bd415a34a2d2@github.com>
 <WKXTiZDyBYdRZTpcH6jMTZ4xclzbvGYrEt9ANZIUJTg=.73f2b600-b80f-4072-922e-e72c32752057@github.com>
Message-ID: <ukN4pdD45bJHJZfSZSscTilyGfNYqOyIzQN-jpYx7u4=.8591bded-a37c-4a86-9ced-d62c74ede993@github.com>

On Tue, 26 Mar 2024 12:55:53 GMT, rjolly <duke at openjdk.org> wrote:

>> ChangedCharSetException is used to amend the charset during read according to html directives. Currently it causes immediate exit of the method which in turn causes failure to load html documents with charset directives (even if the latter must not change after all). This PR restores the catch operation as it was before the use of try with resources.
>
> rjolly has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8328953 : JEditorPane.read throws ChangedCharSetException

Changes requested by aivanov (Reviewer).

test/jdk/javax/swing/JEditorPane/8328953/EditorPaneCharset.java line 48:

> 46:             "<head>\n" +
> 47:             "    <meta http-equiv=\"Content-Type\" content=\"text/html; charset=
> 48: 			windows-1251\">\n" +

Is it a valid Java syntax? The file does not compile.

I would prefer wrapping at attribute boundary rather than a value of an attribute.

No tabs are allowed in OpenJDK source code, replace with four spaces.

-------------

PR Review: https://git.openjdk.org/jdk/pull/17567#pullrequestreview-1960341309
PR Review Comment: https://git.openjdk.org/jdk/pull/17567#discussion_r1539207533

From duke at openjdk.org  Tue Mar 26 14:24:57 2024
From: duke at openjdk.org (rjolly)
Date: Tue, 26 Mar 2024 14:24:57 GMT
Subject: RFR: 8328953 : JEditorPane.read throws ChangedCharSetException
 [v3]
In-Reply-To: <j32PTT_v706cIsLg9ssxPivpEJoo5bCJ1H5NHj3KDhY=.b9e439f3-ce7a-4d63-bfe4-bd415a34a2d2@github.com>
References: <j32PTT_v706cIsLg9ssxPivpEJoo5bCJ1H5NHj3KDhY=.b9e439f3-ce7a-4d63-bfe4-bd415a34a2d2@github.com>
Message-ID: <LiJelTy4-HUNKVL73-YYpX5AsfGZwSvERTEwyg6FteE=.9830f579-139a-4743-bfaf-93235bd360ee@github.com>

> ChangedCharSetException is used to amend the charset during read according to html directives. Currently it causes immediate exit of the method which in turn causes failure to load html documents with charset directives (even if the latter must not change after all). This PR restores the catch operation as it was before the use of try with resources.

rjolly has updated the pull request incrementally with one additional commit since the last revision:

  8328953 : JEditorPane.read throws ChangedCharSetException
  
  The fix is to add a nested `try`-block inside `try-with-resource`; all the exceptions are handled in the nested `try`; the outer `try`-with-resouces only closes the input stream.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/17567/files
  - new: https://git.openjdk.org/jdk/pull/17567/files/c67179d5..f89808df

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=17567&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17567&range=01-02

  Stats: 156 lines in 3 files changed: 78 ins; 77 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/17567.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17567/head:pull/17567

PR: https://git.openjdk.org/jdk/pull/17567

From duke at openjdk.org  Tue Mar 26 15:03:40 2024
From: duke at openjdk.org (rjolly)
Date: Tue, 26 Mar 2024 15:03:40 GMT
Subject: RFR: 8328953 : JEditorPane.read throws ChangedCharSetException
 [v4]
In-Reply-To: <j32PTT_v706cIsLg9ssxPivpEJoo5bCJ1H5NHj3KDhY=.b9e439f3-ce7a-4d63-bfe4-bd415a34a2d2@github.com>
References: <j32PTT_v706cIsLg9ssxPivpEJoo5bCJ1H5NHj3KDhY=.b9e439f3-ce7a-4d63-bfe4-bd415a34a2d2@github.com>
Message-ID: <hq-KEeoZf5QFRDI-TuOrKDFLJBIIv49a5eLPlY0uU5A=.1689eeff-6594-4a16-bb3a-451708ff0ff9@github.com>

> ChangedCharSetException is used to amend the charset during read according to html directives. Currently it causes immediate exit of the method which in turn causes failure to load html documents with charset directives (even if the latter must not change after all). This PR restores the catch operation as it was before the use of try with resources.

rjolly has updated the pull request incrementally with one additional commit since the last revision:

  8328953 : JEditorPane.read throws ChangedCharSetException
  
  The fix is to add a nested `try`-block inside `try-with-resource`; all the exceptions are handled in the nested `try`; the outer `try`-with-resouces only closes the input stream.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/17567/files
  - new: https://git.openjdk.org/jdk/pull/17567/files/f89808df..15dcec91

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=17567&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17567&range=02-03

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/17567.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17567/head:pull/17567

PR: https://git.openjdk.org/jdk/pull/17567

From abhiscxk at openjdk.org  Tue Mar 26 15:43:27 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Tue, 26 Mar 2024 15:43:27 GMT
Subject: RFR: 8328648: Remove applet usage from JFileChooser tests
 bug4150029 [v3]
In-Reply-To: <27GDhgFS-BWfpjW9Fr7tT25u0VPzoSO12V9SV4ANuNc=.a07fa534-01e1-431f-af80-d24f861ba3e4@github.com>
References: <eTiR35uGxb59RbbKcRAdTrgYkrx4CNmkIWfk63i3sJw=.8771db30-c50e-4c50-ae80-312a7683cc27@github.com>
 <27GDhgFS-BWfpjW9Fr7tT25u0VPzoSO12V9SV4ANuNc=.a07fa534-01e1-431f-af80-d24f861ba3e4@github.com>
Message-ID: <b1P4Vxs9sRJzUx9wFUqjzg7v9_NQRymOwE-nnd6HWnk=.de0bd33c-c709-4bdc-a3dc-aa72ae3dd7dc@github.com>

On Tue, 26 Mar 2024 02:20:35 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> Removing applet usage from manual JFileChooser tests
>
> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   change to automatic test

test/jdk/javax/swing/JFileChooser/4150029/bug4150029.java line 43:

> 41:  * @library /test/lib /java/awt/regtesthelpers
> 42:  * @build jdk.test.lib.Platform PassFailJFrame
> 43:  * @run main/manual bug4150029

Not a manual test anymore, please remove manual test related tags and library.

test/jdk/javax/swing/JFileChooser/4150029/bug4150029.java line 88:

> 86:             fileChooser = new JFileChooser(subDir);
> 87: 
> 88: //            fileChooser.setFileSelectionMode(JFileChooser.DIRECTORIES_ONLY);

Not required to keep commented code.

test/jdk/javax/swing/JFileChooser/4150029/bug4150029.java line 91:

> 89: 
> 90:             SwingUtilities.invokeAndWait(() -> {
> 91:                 frame = new JFrame("Backspace Shortcut for Directory Navigation Test");

Block of code can be moved to separate method to create and show UI elements.

test/jdk/javax/swing/JFileChooser/4150029/bug4150029.java line 113:

> 111: 
> 112:     private static void doTesting() {
> 113:         Point p = frame.getLocationOnScreen();

should be on EDT.

test/jdk/javax/swing/JFileChooser/4150029/bug4150029.java line 115:

> 113:         Point p = frame.getLocationOnScreen();
> 114:         robot.mouseMove(p.x + 200, p.y + 200);
> 115:         robot.mousePress(InputEvent.BUTTON1_MASK);

Suggestion:

        robot.mousePress(InputEvent.BUTTON1_DOWN_MASK);


should we add `robot.mouseRelease(InputEvent.BUTTON1_DOWN_MASK);` too ?

test/jdk/javax/swing/JFileChooser/4150029/bug4150029.java line 136:

> 134:         }
> 135: 
> 136:         if (passed_1 && passed_2) {

I think no need to print "Test Passed", can check for not passed and throw the runtime exception inside if block.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18415#discussion_r1539499125
PR Review Comment: https://git.openjdk.org/jdk/pull/18415#discussion_r1539501818
PR Review Comment: https://git.openjdk.org/jdk/pull/18415#discussion_r1539503277
PR Review Comment: https://git.openjdk.org/jdk/pull/18415#discussion_r1539503917
PR Review Comment: https://git.openjdk.org/jdk/pull/18415#discussion_r1539510138
PR Review Comment: https://git.openjdk.org/jdk/pull/18415#discussion_r1539515462

From abhiscxk at openjdk.org  Tue Mar 26 16:07:22 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Tue, 26 Mar 2024 16:07:22 GMT
Subject: RFR: 8328482: Convert and Open source few manual applet test to
 main based [v3]
In-Reply-To: <Pi6RvL9Fn2ID3Biiiw3BSJF6kCmnMb2jRJlQgK4jVoQ=.c768550e-5e11-40ee-aa74-2f6afc486d8a@github.com>
References: <aV9yYWUEsrakxmujJCq2LzFg5K6nyCV4aELge8c1oJo=.c9f2c13d-337f-4af3-8a38-551a7f0ba0c6@github.com>
 <Pi6RvL9Fn2ID3Biiiw3BSJF6kCmnMb2jRJlQgK4jVoQ=.c768550e-5e11-40ee-aa74-2f6afc486d8a@github.com>
Message-ID: <2-p_eBzRl8-4ySpcKqginStUCxYkAiwXl5V1reP4U-w=.44afc483-cd4f-4712-a567-27e18323d814@github.com>

On Sun, 24 Mar 2024 12:21:52 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Convert and open source these manual applet test to main based:
>> java/awt/Frame/MegaIconTest/MegaIconTest.html
>> java/awt/Frame/FrameMaximizedTest/FrameMaximizedTest.html
>> java/awt/Frame/FrameMinimizeTest/FrameMinimizeTest.html
>> java/awt/Frame/SizeMinimizedTest/SizeMinimizedTest.html
>
> Tejesh R has updated the pull request incrementally with three additional commits since the last revision:
> 
>  - Images updated
>  - Frame position updates
>  - removed headful tag

test/jdk/java/awt/Frame/MegaIconTest/MegaIconTest.java line 81:

> 79:         IconTestButtons itb = new IconTestButtons(new IconTestFrame[]{
> 80:                 new IconTestFrame("Opaque, Scaled Icon Test",
> 81:                         "fight.gif"),

"fight.gif" file is missing.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18448#discussion_r1539561887

From prr at openjdk.org  Tue Mar 26 18:20:23 2024
From: prr at openjdk.org (Phil Race)
Date: Tue, 26 Mar 2024 18:20:23 GMT
Subject: RFR: 8328827: Convert
 java/awt/print/PrinterJob/PrinterDialogsModalityTest/PrinterDialogsModalityTest.html
 applet test to main [v2]
In-Reply-To: <-Rl16AQF_i9TnqZXkMYCSbE36yTye0zh4gV3iD5CMDo=.0739bafa-4f02-4151-b2b8-4239a1fd8c5f@github.com>
References: <2iwbuovZ9rGwS8EqkKiSvnxU3_eJI-5KHFngpMs4qtE=.89885458-b5e0-48da-9810-4cfe71c9a420@github.com>
 <y-RrgnWSdNxUYi6wlYa4uk1kUqC2KLQt5ukp1DoMI6A=.85848734-df8e-48d6-bf6a-5cb62d723257@github.com>
 <xQGkAxHjg7tGcobtTRZSkDbjIjmJhyzae0JSA-QU1b8=.5a7b7bab-57fe-41d2-809b-312f277cfc62@github.com>
 <-Rl16AQF_i9TnqZXkMYCSbE36yTye0zh4gV3iD5CMDo=.0739bafa-4f02-4151-b2b8-4239a1fd8c5f@github.com>
Message-ID: <anZqMre7VaVX2uCoroIa8qdD5qHy1qSnEJbl8KxXglQ=.80337622-5e2b-45ab-b9de-2324393f261a@github.com>

On Tue, 26 Mar 2024 00:11:59 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

> * we need to remove PrintModalDialog.java as part of new PR since it is already integrated.
> * This test (PrinterDialogsModalityTest.java) can be extended to all platforms and we no longer need `@requires` tag.
> * Probably update the `@bug` to include the bug id related to PrintModalDialog.java.
> 
> If it is not too much effort then I suggest on deleting the redundant test. @prrace Any suggestions?

Yes, this sounds fine to me.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18461#issuecomment-2021166883

From dnguyen at openjdk.org  Tue Mar 26 18:43:38 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Tue, 26 Mar 2024 18:43:38 GMT
Subject: RFR: 8328827: Convert
 java/awt/print/PrinterJob/PrinterDialogsModalityTest/PrinterDialogsModalityTest.html
 applet test to main [v5]
In-Reply-To: <2iwbuovZ9rGwS8EqkKiSvnxU3_eJI-5KHFngpMs4qtE=.89885458-b5e0-48da-9810-4cfe71c9a420@github.com>
References: <2iwbuovZ9rGwS8EqkKiSvnxU3_eJI-5KHFngpMs4qtE=.89885458-b5e0-48da-9810-4cfe71c9a420@github.com>
Message-ID: <3BwjyhiptjoFcOaz4Fh55SSUdkQSACO16gDGYL9yrdc=.b344f66f-f12b-4907-a48c-6e0087c94866@github.com>

> Convert java/awt/print/PrinterJob/PrinterDialogsModalityTest/PrinterDialogsModalityTest.html applet test to main using PassFailJFrame

Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:

  Rename init

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18461/files
  - new: https://git.openjdk.org/jdk/pull/18461/files/d61f55fe..4f895616

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18461&range=04
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18461&range=03-04

  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/18461.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18461/head:pull/18461

PR: https://git.openjdk.org/jdk/pull/18461

From dnguyen at openjdk.org  Tue Mar 26 18:46:25 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Tue, 26 Mar 2024 18:46:25 GMT
Subject: RFR: 8328561: test
 java/awt/Robot/ManualInstructions/ManualInstructions.java isn't used
In-Reply-To: <ABW2Bldb5eN2as1Jb7G7lFW1ULTIizQwTaHQTORhLnc=.02516bdc-9b01-4748-b80e-fa54b0b8996e@github.com>
References: <ABW2Bldb5eN2as1Jb7G7lFW1ULTIizQwTaHQTORhLnc=.02516bdc-9b01-4748-b80e-fa54b0b8996e@github.com>
Message-ID: <9Att6eyDTTegWdixa-r90nyjLg80Dz831eFBRTYvAI8=.cb4a5fcc-bce9-4d3d-95cf-950896d463f5@github.com>

On Thu, 21 Mar 2024 20:00:48 GMT, Phil Race <prr at openjdk.org> wrote:

> I don't know why this file is checked in. It has no @test tag and doesn't do anything. I am deleting it.

Marked as reviewed by dnguyen (Committer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18440#pullrequestreview-1961412484

From dnguyen at openjdk.org  Tue Mar 26 19:02:26 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Tue, 26 Mar 2024 19:02:26 GMT
Subject: RFR: 8328648: Remove applet usage from JFileChooser tests
 bug4150029 [v3]
In-Reply-To: <27GDhgFS-BWfpjW9Fr7tT25u0VPzoSO12V9SV4ANuNc=.a07fa534-01e1-431f-af80-d24f861ba3e4@github.com>
References: <eTiR35uGxb59RbbKcRAdTrgYkrx4CNmkIWfk63i3sJw=.8771db30-c50e-4c50-ae80-312a7683cc27@github.com>
 <27GDhgFS-BWfpjW9Fr7tT25u0VPzoSO12V9SV4ANuNc=.a07fa534-01e1-431f-af80-d24f861ba3e4@github.com>
Message-ID: <1S8D3BRp9Jm0wp94S4VHCiMvX1ONdI4Ye28Y7SMY71Y=.52f6a196-db56-4e90-8cca-ecbb508c04bb@github.com>

On Tue, 26 Mar 2024 02:20:35 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> Removing applet usage from manual JFileChooser tests
>
> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   change to automatic test

test/jdk/javax/swing/JFileChooser/4150029/bug4150029.java line 95:

> 93:                 fileChooser = new JFileChooser(subDir);
> 94:                 fileChooser.setControlButtonsAreShown(false);
> 95:                 frame.getContentPane().add(fileChooser, BorderLayout.CENTER);

Suggestion:

                frame.add(fileChooser, BorderLayout.CENTER);


It was brought to my attention in one of my PRs that `getContentPane()` is obsolete as of JDK 1.5. They referenced  https://github.com/openjdk/jdk/pull/18390#discussion_r1533017080.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18415#discussion_r1539938437

From dnguyen at openjdk.org  Tue Mar 26 19:03:32 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Tue, 26 Mar 2024 19:03:32 GMT
Subject: Integrated: 8328827: Convert
 java/awt/print/PrinterJob/PrinterDialogsModalityTest/PrinterDialogsModalityTest.html
 applet test to main
In-Reply-To: <2iwbuovZ9rGwS8EqkKiSvnxU3_eJI-5KHFngpMs4qtE=.89885458-b5e0-48da-9810-4cfe71c9a420@github.com>
References: <2iwbuovZ9rGwS8EqkKiSvnxU3_eJI-5KHFngpMs4qtE=.89885458-b5e0-48da-9810-4cfe71c9a420@github.com>
Message-ID: <6Nz6YQzlKA8LtcgYLBHFmssnbPnd54whVS4iKpo3M9Q=.2a665254-bee3-4829-b096-3fd15726b5c5@github.com>

On Fri, 22 Mar 2024 18:06:59 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

> Convert java/awt/print/PrinterJob/PrinterDialogsModalityTest/PrinterDialogsModalityTest.html applet test to main using PassFailJFrame

This pull request has now been integrated.

Changeset: db01fcd6
Author:    Damon Nguyen <dnguyen at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/db01fcd6d8c24b01a1f23c71b2917ff396b0686f
Stats:     398 lines in 3 files changed: 93 ins; 305 del; 0 mod

8328827: Convert java/awt/print/PrinterJob/PrinterDialogsModalityTest/PrinterDialogsModalityTest.html applet test to main

Reviewed-by: prr, tr

-------------

PR: https://git.openjdk.org/jdk/pull/18461

From ihse at openjdk.org  Tue Mar 26 20:06:52 2024
From: ihse at openjdk.org (Magnus Ihse Bursie)
Date: Tue, 26 Mar 2024 20:06:52 GMT
Subject: RFR: 8307160: Fix AWT/2D/A11Y to support the permissive- flag on
 the Microsoft Visual C compiler [v46]
In-Reply-To: <0zriWFk8mESin6eTDm4kH02213a8tTq5gEBx41NtZ8Y=.74965e93-6475-44ee-805b-73c477aede94@github.com>
References: <7piLRto5nNbhYYYfENCr5ecm4M2xNtMkjkE8XhrLLQ0=.8fd1ac3a-46f8-47a8-ae37-a4abbf7757d9@github.com>
 <5WJnl6Z9RyYzZrDStf9p74gus07Stz6S6NHwVpGQO3M=.0a04a120-77b5-48c3-9ae8-7d37c9646463@github.com>
 <QfIBrG8rqxy__rPSCMddlNATjmEEr4ccSoZyjFckjUg=.b7f6fffb-2cf9-4c54-a35c-b01f5fd654de@github.com>
 <aAmBW4xAmuvxi3KEXCNFaq8WZ0zjjKk_bZisWgA6UMM=.a0a49004-699f-4835-ba98-9510427f9483@github.com>
 <0zriWFk8mESin6eTDm4kH02213a8tTq5gEBx41NtZ8Y=.74965e93-6475-44ee-805b-73c477aede94@github.com>
Message-ID: <sKKibwSb17BpRFpItUuGKw4s-Xl-T4RekSKrg2EC7PY=.31db02fc-f0a6-4e15-ac8d-23826386fe6b@github.com>

On Wed, 20 Mar 2024 06:44:02 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> Sorry, I don't see a BOOL error anywhere?
>
> I see the advantage of collapsing self and parent into the same check, but it doesn't seem like getting rid of pData is of much benefit, the checks for null seem to remain the same either way

> Sorry, I don't see a BOOL error anywhere?

I think Phil misplaced the code block marker -- the BOOL error line and below is supposed to be inside the second code block.

What Phil is doing is trying to suggest two different approaches to make this code nicer, the first with a bit more duplication, and the second with an `error` boolean flag. And he says that he prefers the former, so the second were propably just mentioned to show an alternative for discussion.

I think what you should do here is to combine the `self` and `parent` null checks as Phil suggests. And then replace all pData references to the final variable, here as well as everywhere pData is involved.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15096#discussion_r1540025427

From ihse at openjdk.org  Tue Mar 26 20:23:44 2024
From: ihse at openjdk.org (Magnus Ihse Bursie)
Date: Tue, 26 Mar 2024 20:23:44 GMT
Subject: RFR: 8307160: Fix AWT/2D/A11Y to support the permissive- flag on
 the Microsoft Visual C compiler [v52]
In-Reply-To: <e-jVzOEx4vN7QRrHz08-uziDn_sewCyBif2HwUWcnYU=.cae71a72-4e61-448a-a6a8-4d3989fa7dac@github.com>
References: <7piLRto5nNbhYYYfENCr5ecm4M2xNtMkjkE8XhrLLQ0=.8fd1ac3a-46f8-47a8-ae37-a4abbf7757d9@github.com>
 <0p1UVaUOt2bs1mkuBV1liUxBYGRhnKnclf1x_-Y22GE=.2de6c2c4-8cf5-470d-bdb3-cd0dd0e13975@github.com>
 <N-qe81Sj2dD9Jf389FDPidxtXG8VMfn9wwvvh3RdlzU=.db37387f-76f7-4096-a979-2b4a956925ea@github.com>
 <rvcdKMR7EYsspYcH1OX2_x4zC43WDQK9c70qt2Cl-CI=.1658a8f0-f530-44fc-aa47-493482d57c50@github.com>
 <9agOsYWQVrdMO2D4unjqu1d3JoWs_FtQ-ATURfsANr4=.e51e3241-cc69-41df-a202-c7f24581408a@github.com>
 <rkEnV6PDBabKeBEdi2OZdpRngA9NGoxkegRy4U9qku0=.16ed5ecd-117b-4cd3-8ea8-5b55a86131d8@github.com>
 <e-jVzOEx4vN7QRrHz08-uziDn_sewCyBif2HwUWcnYU=.cae71a72-4e61-448a-a6a8-4d3989fa7dac@github.com>
Message-ID: <zwRwhhbv8aRf9XqC8hxUI1SYYUdbYZI6RGgmb11p03c=.676191de-4d63-4913-a21f-9b77baca36cb@github.com>

On Tue, 26 Mar 2024 08:44:31 GMT, Julian Waters <jwaters at openjdk.org> wrote:

> Maybe as a further improvement, I can inline THROW_NULL_PDATA_IF_NOT_DESTROYED at its callsites and replace the bad NullPointerException error message with the proper null pointer name. Since Phil isn't here, what do you think?

That might be a good future code cleanup, but I suggest you refrain from doing that in this change. 

> Regardless, I really hope I can get this in by Thursday. 

I see that you are struggling a bit to get this done. I can probably help you fix the remaining issues, but I can't push to your PR. So either I'd need to create a fork of your `patch-10` branch in my personal fork and you'll have to pull from there into your branch, or you need to give me write permissions to your personal fork. I believe you can assign permissions on a per-branch basis.

I'd really like to see this PR to come to conclusion.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15096#issuecomment-2021391154

From prr at openjdk.org  Tue Mar 26 20:34:22 2024
From: prr at openjdk.org (Phil Race)
Date: Tue, 26 Mar 2024 20:34:22 GMT
Subject: RFR: 8305072: Win32ShellFolder2.compareTo is inconsistent [v2]
In-Reply-To: <21db5CiFTVN7scwsIHknMxF4YaVQd06m7gUOhcCLvMI=.e2f61ea7-bf9a-4632-bf45-c89f979ae806@github.com>
References: <bEiHvkFnBZDqmiqQdk_-_mATVhDbAD7NZX7VnkHLG2E=.27ee84ba-00fd-405a-9489-8fe11c215af9@github.com>
 <21db5CiFTVN7scwsIHknMxF4YaVQd06m7gUOhcCLvMI=.e2f61ea7-bf9a-4632-bf45-c89f979ae806@github.com>
Message-ID: <kG59XWfl8x5uX0zNn26lqJxXm9x1XLPohGpmm9xNGjc=.51d545cb-cda3-48db-b48f-bdb75bd4e843@github.com>

On Tue, 5 Mar 2024 17:40:01 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> The implementation of `Win32ShellFolder2.compareTo` is inconsistent: there are cases where  
>> `a < b & b < c but a == c`  
>> which *violates its general contract*.
>> 
>> In particular, it happens for the personal folder (*Documents*) if it is listed *twice*: as a special and as a regular folder.
>> 
>> The evaluation performed by the submitter of the bug provided enough details to create a test, reproduce the problem and finally resolve it.
>> 
>> Without the fix, the regression test always fails:
>> 
>> a < b & b < c but a >= c
>> where
>>   a = C:\Users<user>\Documents(true)
>>   b = C:\Users<user>(false)
>>   c = C:\Users<user>\Documents(false)
>> 
>> as well as for the reverse case: `a > b & b > c`.
>> 
>> How it is possible to have the same folder in a list of files twice remains unknown. I believe it is another bug in JDK, however, no one has been able to reproduce it so far.
>
> Alexey Ivanov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Handle fakePersonal on Windows 10
>   
>   The desktop folder on Windows 10 does not include
>   the Personal (Documents) folder.

Marked as reviewed by prr (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18126#pullrequestreview-1961661797

From achung at openjdk.org  Tue Mar 26 20:47:47 2024
From: achung at openjdk.org (Alisen Chung)
Date: Tue, 26 Mar 2024 20:47:47 GMT
Subject: RFR: 8328227: Remove applet usage from JColorChooser tests
 Test4887836 [v5]
In-Reply-To: <sz94hhkj7mCeInxQ075Uwe14NVjdUMDk3sbuOr1E2X0=.2cc0c644-dd7a-4044-aa17-c082abaf74b6@github.com>
References: <sz94hhkj7mCeInxQ075Uwe14NVjdUMDk3sbuOr1E2X0=.2cc0c644-dd7a-4044-aa17-c082abaf74b6@github.com>
Message-ID: <PAqHicEsU1jll4Mpj1LrCMqlBWDmm_-IKKl3WYP0t-g=.3f759202-c48f-4a24-bfc5-1ba7b055c2eb@github.com>

> Removing applet usage from manual JColorChooser tests

Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:

  instruction string change

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18316/files
  - new: https://git.openjdk.org/jdk/pull/18316/files/6ff8dfa4..3b75b6ad

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18316&range=04
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18316&range=03-04

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/18316.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18316/head:pull/18316

PR: https://git.openjdk.org/jdk/pull/18316

From achung at openjdk.org  Tue Mar 26 20:57:52 2024
From: achung at openjdk.org (Alisen Chung)
Date: Tue, 26 Mar 2024 20:57:52 GMT
Subject: RFR: 8328403: Remove applet usage from JColorChooser tests
 Test6977726 [v3]
In-Reply-To: <ErruxydT6Pr0Rhc-KhTmS1SmMKCp3OawZlVgfMXxi5g=.6a9a1f4d-a8aa-40ab-8788-4e3ba2467b9f@github.com>
References: <pyfxVdApSNSisMJieBTl5HSZKDmSSiPie0tnrM_rwe4=.5ffc4e92-cbcf-44d8-9a51-b4e8330e1be9@github.com>
 <n0TjsQh79xMSxu0oqznoUM5cSkAzAVZOpMQAf9TTMIc=.ac8c3317-c4df-484d-a7ef-d8367b5dc1a5@github.com>
 <ErruxydT6Pr0Rhc-KhTmS1SmMKCp3OawZlVgfMXxi5g=.6a9a1f4d-a8aa-40ab-8788-4e3ba2467b9f@github.com>
Message-ID: <Ejdm0IkhZarpFRsIwYdHolU90vexUtZzo7ToT_3nx9U=.108ec688-ba2e-4c84-9d18-91740efd0517@github.com>

On Mon, 25 Mar 2024 18:43:44 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   test instructions
>
> test/jdk/javax/swing/JColorChooser/Test6977726.java line 43:
> 
>> 41:                 .title("Test6977726")
>> 42:                 .instructions("Check that there is a panel with white text " +
>> 43:                         "titled \"Preview\" in the JColorChooser.")
> 
>> Check that there is a panel with white text titled "Preview" in the JColorChooser.
> 
> I read it as if the text should be titled "Preview", although it should actually refer to the panel(maybe I'm wrong).
> 
> Since you modified the original "If you don't see the preview panel" by adding the "white text" check, you should check it on all platforms/LaFs that this text is really white and distinguishable from the background, otherwise it might come back to us one day with a failure of this test.

When I wrote it I meant to say "Check that there is a panel (with white text) titled 'Preview'", but now that I read it again it is pretty unclear..
Does 
`Check that there is a panel with "Text Preview Panel" text and with title "Preview" in the JColorChooser.`
make more sense?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18369#discussion_r1540098175

From achung at openjdk.org  Tue Mar 26 20:57:52 2024
From: achung at openjdk.org (Alisen Chung)
Date: Tue, 26 Mar 2024 20:57:52 GMT
Subject: RFR: 8328403: Remove applet usage from JColorChooser tests
 Test6977726 [v4]
In-Reply-To: <pyfxVdApSNSisMJieBTl5HSZKDmSSiPie0tnrM_rwe4=.5ffc4e92-cbcf-44d8-9a51-b4e8330e1be9@github.com>
References: <pyfxVdApSNSisMJieBTl5HSZKDmSSiPie0tnrM_rwe4=.5ffc4e92-cbcf-44d8-9a51-b4e8330e1be9@github.com>
Message-ID: <OHP8ZTnhmiucg-AWktAt_UNDyMBHYSVzfm5GQz1UjTs=.7fb3ea7f-e845-455f-9609-65715316f381@github.com>

> Removing applet usage from manual JColorChooser tests

Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:

  instruction string change

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18369/files
  - new: https://git.openjdk.org/jdk/pull/18369/files/39b41d55..8f03f04c

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18369&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18369&range=02-03

  Stats: 7 lines in 1 file changed: 4 ins; 1 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/18369.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18369/head:pull/18369

PR: https://git.openjdk.org/jdk/pull/18369

From prr at openjdk.org  Tue Mar 26 21:19:22 2024
From: prr at openjdk.org (Phil Race)
Date: Tue, 26 Mar 2024 21:19:22 GMT
Subject: RFR: 8328403: Remove applet usage from JColorChooser tests
 Test6977726 [v4]
In-Reply-To: <OHP8ZTnhmiucg-AWktAt_UNDyMBHYSVzfm5GQz1UjTs=.7fb3ea7f-e845-455f-9609-65715316f381@github.com>
References: <pyfxVdApSNSisMJieBTl5HSZKDmSSiPie0tnrM_rwe4=.5ffc4e92-cbcf-44d8-9a51-b4e8330e1be9@github.com>
 <OHP8ZTnhmiucg-AWktAt_UNDyMBHYSVzfm5GQz1UjTs=.7fb3ea7f-e845-455f-9609-65715316f381@github.com>
Message-ID: <EetnMFyJQMV-MWVg6HHO-7O3SLOaQT1-uqUhq97rDC8=.d4628194-c548-45f4-a08c-c1240d8b54f9@github.com>

On Tue, 26 Mar 2024 20:57:52 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> Removing applet usage from manual JColorChooser tests
>
> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   instruction string change

are you going to reduce the timeout as Alexander suggested ?

test/jdk/javax/swing/JColorChooser/Test6977726.java line 42:

> 40:         String instructions = """
> 41:                 Check that there is a panel with \"Text Preview Panel\" text 
> 42:                 and with title \"Preview\" in the JColorChooser.""";

(1) You have a whitespace error that needs fixing.
(2) It is probably worth adding a sentence "Test passes if the panel is as described, test fails otherwise".

-------------

PR Review: https://git.openjdk.org/jdk/pull/18369#pullrequestreview-1961753498
PR Review Comment: https://git.openjdk.org/jdk/pull/18369#discussion_r1540122335

From prr at openjdk.org  Tue Mar 26 21:23:22 2024
From: prr at openjdk.org (Phil Race)
Date: Tue, 26 Mar 2024 21:23:22 GMT
Subject: RFR: 8328482: Convert and Open source few manual applet test to
 main based [v3]
In-Reply-To: <2-p_eBzRl8-4ySpcKqginStUCxYkAiwXl5V1reP4U-w=.44afc483-cd4f-4712-a567-27e18323d814@github.com>
References: <aV9yYWUEsrakxmujJCq2LzFg5K6nyCV4aELge8c1oJo=.c9f2c13d-337f-4af3-8a38-551a7f0ba0c6@github.com>
 <Pi6RvL9Fn2ID3Biiiw3BSJF6kCmnMb2jRJlQgK4jVoQ=.c768550e-5e11-40ee-aa74-2f6afc486d8a@github.com>
 <2-p_eBzRl8-4ySpcKqginStUCxYkAiwXl5V1reP4U-w=.44afc483-cd4f-4712-a567-27e18323d814@github.com>
Message-ID: <1992auBhw5Hjt_wfBcPe21bnsizooxn3TcWoCddI_gk=.b388017f-0dcf-4198-8ac1-55ec7b147081@github.com>

On Tue, 26 Mar 2024 16:04:13 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Tejesh R has updated the pull request incrementally with three additional commits since the last revision:
>> 
>>  - Images updated
>>  - Frame position updates
>>  - removed headful tag
>
> test/jdk/java/awt/Frame/MegaIconTest/MegaIconTest.java line 81:
> 
>> 79:         IconTestButtons itb = new IconTestButtons(new IconTestFrame[]{
>> 80:                 new IconTestFrame("Opaque, Scaled Icon Test",
>> 81:                         "fight.gif"),
> 
> "fight.gif" file is missing.

Probably waiting for me to OK it off-line. I've now done so.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18448#discussion_r1540126419

From honkar at openjdk.org  Tue Mar 26 21:27:21 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Tue, 26 Mar 2024 21:27:21 GMT
Subject: RFR: 8328403: Remove applet usage from JColorChooser tests
 Test6977726 [v4]
In-Reply-To: <EetnMFyJQMV-MWVg6HHO-7O3SLOaQT1-uqUhq97rDC8=.d4628194-c548-45f4-a08c-c1240d8b54f9@github.com>
References: <pyfxVdApSNSisMJieBTl5HSZKDmSSiPie0tnrM_rwe4=.5ffc4e92-cbcf-44d8-9a51-b4e8330e1be9@github.com>
 <OHP8ZTnhmiucg-AWktAt_UNDyMBHYSVzfm5GQz1UjTs=.7fb3ea7f-e845-455f-9609-65715316f381@github.com>
 <EetnMFyJQMV-MWVg6HHO-7O3SLOaQT1-uqUhq97rDC8=.d4628194-c548-45f4-a08c-c1240d8b54f9@github.com>
Message-ID: <FMq2rrA418acbqYBnUE8yjAY_l1x0jO3YjbVJ1HbQXw=.35d76b40-95aa-4baa-b846-f1c635d88933@github.com>

On Tue, 26 Mar 2024 21:16:15 GMT, Phil Race <prr at openjdk.org> wrote:

>> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   instruction string change
>
> test/jdk/javax/swing/JColorChooser/Test6977726.java line 42:
> 
>> 40:         String instructions = """
>> 41:                 Check that there is a panel with \"Text Preview Panel\" text 
>> 42:                 and with title \"Preview\" in the JColorChooser.""";
> 
> (1) You have a whitespace error that needs fixing.
> (2) It is probably worth adding a sentence "Test passes if the panel is as described, test fails otherwise".

@alisenchung Since you are using string block there is no need to escape double-quotes.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18369#discussion_r1540129111

From honkar at openjdk.org  Tue Mar 26 21:31:22 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Tue, 26 Mar 2024 21:31:22 GMT
Subject: RFR: 8328227: Remove applet usage from JColorChooser tests
 Test4887836 [v4]
In-Reply-To: <-Q8UhtOxNPqh7ADYGEnC4gs6-WzLkvOowLI-oH9Sfuc=.185acb92-8fd6-43b7-a934-062a15d5c4d4@github.com>
References: <sz94hhkj7mCeInxQ075Uwe14NVjdUMDk3sbuOr1E2X0=.2cc0c644-dd7a-4044-aa17-c082abaf74b6@github.com>
 <zO_KyJTiRP6oIa2Npysbj2EIA6iIQ8aaOBM6IFwFqRs=.c395fd75-3619-4ecd-b12e-83a4d508e80f@github.com>
 <-Q8UhtOxNPqh7ADYGEnC4gs6-WzLkvOowLI-oH9Sfuc=.185acb92-8fd6-43b7-a934-062a15d5c4d4@github.com>
Message-ID: <gqwnKriIziTgRslyuwKe7S0XRC5A7ZpqyOzImxvJnOc=.f321d03c-78f0-4132-90e8-9ba4791432ee@github.com>

On Tue, 26 Mar 2024 00:46:29 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   change font
>
> test/jdk/javax/swing/JColorChooser/Test4887836.java line 43:
> 
>> 41:         String instructions = """
>> 42:                                 If you do not see white area under the \"Swatches\" tab,\n +
>> 43:                                 then test passed, otherwise it failed.""";
> 
> Please fix line-lengths and the "+" operator is not required since String blocks are used.

Please fix line-lengths.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18316#discussion_r1540134092

From honkar at openjdk.org  Tue Mar 26 21:31:21 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Tue, 26 Mar 2024 21:31:21 GMT
Subject: RFR: 8328227: Remove applet usage from JColorChooser tests
 Test4887836 [v5]
In-Reply-To: <PAqHicEsU1jll4Mpj1LrCMqlBWDmm_-IKKl3WYP0t-g=.3f759202-c48f-4a24-bfc5-1ba7b055c2eb@github.com>
References: <sz94hhkj7mCeInxQ075Uwe14NVjdUMDk3sbuOr1E2X0=.2cc0c644-dd7a-4044-aa17-c082abaf74b6@github.com>
 <PAqHicEsU1jll4Mpj1LrCMqlBWDmm_-IKKl3WYP0t-g=.3f759202-c48f-4a24-bfc5-1ba7b055c2eb@github.com>
Message-ID: <y1vBxmANNAuv0N_2lycw7zVSmi2hLoXN3OF6tZqGxJM=.df3757c8-85c5-426f-bc5d-54fc06aaf5ae@github.com>

On Tue, 26 Mar 2024 20:47:47 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> Removing applet usage from manual JColorChooser tests
>
> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   instruction string change

Marked as reviewed by honkar (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18316#pullrequestreview-1961774254

From achung at openjdk.org  Tue Mar 26 22:29:32 2024
From: achung at openjdk.org (Alisen Chung)
Date: Tue, 26 Mar 2024 22:29:32 GMT
Subject: RFR: 8328403: Remove applet usage from JColorChooser tests
 Test6977726 [v5]
In-Reply-To: <pyfxVdApSNSisMJieBTl5HSZKDmSSiPie0tnrM_rwe4=.5ffc4e92-cbcf-44d8-9a51-b4e8330e1be9@github.com>
References: <pyfxVdApSNSisMJieBTl5HSZKDmSSiPie0tnrM_rwe4=.5ffc4e92-cbcf-44d8-9a51-b4e8330e1be9@github.com>
Message-ID: <N6gGAXCbcyyX3OTA-rlnzBrztMU11SwU0Lq_ufhajlo=.fe964556-b0f7-4fb9-a989-164182993fef@github.com>

> Removing applet usage from manual JColorChooser tests

Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:

  instruction string change

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18369/files
  - new: https://git.openjdk.org/jdk/pull/18369/files/8f03f04c..ff6f5e51

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18369&range=04
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18369&range=03-04

  Stats: 3 lines in 1 file changed: 1 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/18369.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18369/head:pull/18369

PR: https://git.openjdk.org/jdk/pull/18369

From achung at openjdk.org  Tue Mar 26 22:33:45 2024
From: achung at openjdk.org (Alisen Chung)
Date: Tue, 26 Mar 2024 22:33:45 GMT
Subject: RFR: 8328648: Remove applet usage from JFileChooser tests
 bug4150029 [v4]
In-Reply-To: <eTiR35uGxb59RbbKcRAdTrgYkrx4CNmkIWfk63i3sJw=.8771db30-c50e-4c50-ae80-312a7683cc27@github.com>
References: <eTiR35uGxb59RbbKcRAdTrgYkrx4CNmkIWfk63i3sJw=.8771db30-c50e-4c50-ae80-312a7683cc27@github.com>
Message-ID: <gDAQGl44db6zGs2rt8bVVlSH6va-t-yxtUOi50zerSc=.8a3dc583-034a-466b-b9b7-afa11c97fb96@github.com>

> Removing applet usage from manual JFileChooser tests

Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:

  moved create ui code to helper, change test pass check, add mouse release, remove getContentPane

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18415/files
  - new: https://git.openjdk.org/jdk/pull/18415/files/0126af35..5a05f64b

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18415&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18415&range=02-03

  Stats: 36 lines in 1 file changed: 16 ins; 12 del; 8 mod
  Patch: https://git.openjdk.org/jdk/pull/18415.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18415/head:pull/18415

PR: https://git.openjdk.org/jdk/pull/18415

From achung at openjdk.org  Tue Mar 26 22:41:45 2024
From: achung at openjdk.org (Alisen Chung)
Date: Tue, 26 Mar 2024 22:41:45 GMT
Subject: RFR: 8328819: Remove applet usage from JFileChooser tests
 bug6698013 [v3]
In-Reply-To: <iLcbr4t_2UJ4muFqTIm1NMfahCdwMTpgprqHo8WHHW0=.29e91557-e4b0-4d9c-ba32-fb2ab49e5de9@github.com>
References: <iLcbr4t_2UJ4muFqTIm1NMfahCdwMTpgprqHo8WHHW0=.29e91557-e4b0-4d9c-ba32-fb2ab49e5de9@github.com>
Message-ID: <W0H-lo7M5wDtr28MOLfCRhRXd57IoQK4639AApxheHY=.c3bb240e-cfc3-486e-b09e-da76c196588c@github.com>

> Removing applet usage from manual JFileChooser tests
> The original test is failing (nothing shows up in the JFileChooser), but this change does replace the applet usage with PassFailJFrame

Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:

  update test instructions, move vars into subclass

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18456/files
  - new: https://git.openjdk.org/jdk/pull/18456/files/e43d8b1e..5cd07d36

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18456&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18456&range=01-02

  Stats: 14 lines in 1 file changed: 4 ins; 6 del; 4 mod
  Patch: https://git.openjdk.org/jdk/pull/18456.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18456/head:pull/18456

PR: https://git.openjdk.org/jdk/pull/18456

From honkar at openjdk.org  Tue Mar 26 23:03:23 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Tue, 26 Mar 2024 23:03:23 GMT
Subject: RFR: 8328819: Remove applet usage from JFileChooser tests
 bug6698013 [v3]
In-Reply-To: <W0H-lo7M5wDtr28MOLfCRhRXd57IoQK4639AApxheHY=.c3bb240e-cfc3-486e-b09e-da76c196588c@github.com>
References: <iLcbr4t_2UJ4muFqTIm1NMfahCdwMTpgprqHo8WHHW0=.29e91557-e4b0-4d9c-ba32-fb2ab49e5de9@github.com>
 <W0H-lo7M5wDtr28MOLfCRhRXd57IoQK4639AApxheHY=.c3bb240e-cfc3-486e-b09e-da76c196588c@github.com>
Message-ID: <SwuZuVOkffdD16YnzlcXLI1TP-Syn2ZIS7OrLWK-NLs=.c32435f8-68a3-48c4-a102-8064a918dc4a@github.com>

On Tue, 26 Mar 2024 22:41:45 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> Removing applet usage from manual JFileChooser tests
>> The original test is failing (nothing shows up in the JFileChooser), but this change does replace the applet usage with PassFailJFrame
>
> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   update test instructions, move vars into subclass

LGTM.

Suggestion:
Since this test is problem-listed on macOS, mentioning it in PR description is helpful for reviewers as well as for future reference.

-------------

Marked as reviewed by honkar (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18456#pullrequestreview-1961905754

From dnguyen at openjdk.org  Tue Mar 26 23:34:22 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Tue, 26 Mar 2024 23:34:22 GMT
Subject: RFR: 8328819: Remove applet usage from JFileChooser tests
 bug6698013 [v3]
In-Reply-To: <W0H-lo7M5wDtr28MOLfCRhRXd57IoQK4639AApxheHY=.c3bb240e-cfc3-486e-b09e-da76c196588c@github.com>
References: <iLcbr4t_2UJ4muFqTIm1NMfahCdwMTpgprqHo8WHHW0=.29e91557-e4b0-4d9c-ba32-fb2ab49e5de9@github.com>
 <W0H-lo7M5wDtr28MOLfCRhRXd57IoQK4639AApxheHY=.c3bb240e-cfc3-486e-b09e-da76c196588c@github.com>
Message-ID: <QeY_CcPa-5aP4zh_fEML6n_pQIqFesO00RVgHiNPqfU=.01f04a79-ab64-47db-a470-445ee8f6d605@github.com>

On Tue, 26 Mar 2024 22:41:45 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> Removing applet usage from manual JFileChooser tests
>> The original test is failing (nothing shows up in the JFileChooser), but this change does replace the applet usage with PassFailJFrame
>
> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   update test instructions, move vars into subclass

Marked as reviewed by dnguyen (Committer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18456#pullrequestreview-1961940055

From dnguyen at openjdk.org  Tue Mar 26 23:43:21 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Tue, 26 Mar 2024 23:43:21 GMT
Subject: RFR: 8328648: Remove applet usage from JFileChooser tests
 bug4150029 [v4]
In-Reply-To: <gDAQGl44db6zGs2rt8bVVlSH6va-t-yxtUOi50zerSc=.8a3dc583-034a-466b-b9b7-afa11c97fb96@github.com>
References: <eTiR35uGxb59RbbKcRAdTrgYkrx4CNmkIWfk63i3sJw=.8771db30-c50e-4c50-ae80-312a7683cc27@github.com>
 <gDAQGl44db6zGs2rt8bVVlSH6va-t-yxtUOi50zerSc=.8a3dc583-034a-466b-b9b7-afa11c97fb96@github.com>
Message-ID: <E_U5oVkGJCHoajgJjwRO_3ac4L_43a8Z-mKW9VRLAW4=.c815c2a3-68ee-4d10-88d4-70336006dd4a@github.com>

On Tue, 26 Mar 2024 22:33:45 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> Removing applet usage from manual JFileChooser tests
>
> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   moved create ui code to helper, change test pass check, add mouse release, remove getContentPane

Changes requested by dnguyen (Committer).

test/jdk/javax/swing/JFileChooser/4150029/bug4150029.java line 121:

> 119:         robot.mouseMove(p.x + 200, p.y + 200);
> 120:         robot.mousePress(InputEvent.BUTTON1_DOWN_MASK);
> 121:         robot.mouseRelease(InputEvent.BUTTON1_DOWN_MASK);

`p.x` and `p.y` isn't in scope I believe. You can move `Point p` outside the method, make it static and volatile, then it should be fine. Maybe remove the extra newline in this `SwingUtilities.invokeAndWait()` block as well.

-------------

PR Review: https://git.openjdk.org/jdk/pull/18415#pullrequestreview-1961948241
PR Review Comment: https://git.openjdk.org/jdk/pull/18415#discussion_r1540238433

From tr at openjdk.org  Wed Mar 27 03:33:57 2024
From: tr at openjdk.org (Tejesh R)
Date: Wed, 27 Mar 2024 03:33:57 GMT
Subject: RFR: 8328482: Convert and Open source few manual applet test to
 main based [v4]
In-Reply-To: <aV9yYWUEsrakxmujJCq2LzFg5K6nyCV4aELge8c1oJo=.c9f2c13d-337f-4af3-8a38-551a7f0ba0c6@github.com>
References: <aV9yYWUEsrakxmujJCq2LzFg5K6nyCV4aELge8c1oJo=.c9f2c13d-337f-4af3-8a38-551a7f0ba0c6@github.com>
Message-ID: <TYJFZwPv2tFlCYmwFMZfO11wsxCY8WNPHuvu4urAtzM=.0ff7923d-aacb-4705-9e68-d2d029c257ad@github.com>

> Convert and open source these manual applet test to main based:
> java/awt/Frame/MegaIconTest/MegaIconTest.html
> java/awt/Frame/FrameMaximizedTest/FrameMaximizedTest.html
> java/awt/Frame/FrameMinimizeTest/FrameMinimizeTest.html
> java/awt/Frame/SizeMinimizedTest/SizeMinimizedTest.html

Tejesh R has updated the pull request incrementally with one additional commit since the last revision:

  fight.gif added

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18448/files
  - new: https://git.openjdk.org/jdk/pull/18448/files/40c89e96..656fdc94

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18448&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18448&range=02-03

  Stats: 0 lines in 1 file changed: 0 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18448.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18448/head:pull/18448

PR: https://git.openjdk.org/jdk/pull/18448

From tr at openjdk.org  Wed Mar 27 03:33:57 2024
From: tr at openjdk.org (Tejesh R)
Date: Wed, 27 Mar 2024 03:33:57 GMT
Subject: RFR: 8328482: Convert and Open source few manual applet test to
 main based [v3]
In-Reply-To: <1992auBhw5Hjt_wfBcPe21bnsizooxn3TcWoCddI_gk=.b388017f-0dcf-4198-8ac1-55ec7b147081@github.com>
References: <aV9yYWUEsrakxmujJCq2LzFg5K6nyCV4aELge8c1oJo=.c9f2c13d-337f-4af3-8a38-551a7f0ba0c6@github.com>
 <Pi6RvL9Fn2ID3Biiiw3BSJF6kCmnMb2jRJlQgK4jVoQ=.c768550e-5e11-40ee-aa74-2f6afc486d8a@github.com>
 <2-p_eBzRl8-4ySpcKqginStUCxYkAiwXl5V1reP4U-w=.44afc483-cd4f-4712-a567-27e18323d814@github.com>
 <1992auBhw5Hjt_wfBcPe21bnsizooxn3TcWoCddI_gk=.b388017f-0dcf-4198-8ac1-55ec7b147081@github.com>
Message-ID: <qHuX72iinIVdWtmEr5kLwimMo3yDw570GyIN4DHj4dE=.34454519-90c7-4f39-a922-3ebb94378b36@github.com>

On Tue, 26 Mar 2024 21:21:00 GMT, Phil Race <prr at openjdk.org> wrote:

>> test/jdk/java/awt/Frame/MegaIconTest/MegaIconTest.java line 81:
>> 
>>> 79:         IconTestButtons itb = new IconTestButtons(new IconTestFrame[]{
>>> 80:                 new IconTestFrame("Opaque, Scaled Icon Test",
>>> 81:                         "fight.gif"),
>> 
>> "fight.gif" file is missing.
>
> Probably waiting for me to OK it off-line. I've now done so.

Pushed it now.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18448#discussion_r1540410663

From tr at openjdk.org  Wed Mar 27 03:41:23 2024
From: tr at openjdk.org (Tejesh R)
Date: Wed, 27 Mar 2024 03:41:23 GMT
Subject: RFR: 8328953 : JEditorPane.read throws ChangedCharSetException
 [v4]
In-Reply-To: <hq-KEeoZf5QFRDI-TuOrKDFLJBIIv49a5eLPlY0uU5A=.1689eeff-6594-4a16-bb3a-451708ff0ff9@github.com>
References: <j32PTT_v706cIsLg9ssxPivpEJoo5bCJ1H5NHj3KDhY=.b9e439f3-ce7a-4d63-bfe4-bd415a34a2d2@github.com>
 <hq-KEeoZf5QFRDI-TuOrKDFLJBIIv49a5eLPlY0uU5A=.1689eeff-6594-4a16-bb3a-451708ff0ff9@github.com>
Message-ID: <4iuq7hOUD_mkxMgsnCZY5b8FYZ38x0SZduCYKdgI2to=.237d2ac5-badd-44f9-8b12-934605c9104a@github.com>

On Tue, 26 Mar 2024 15:03:40 GMT, rjolly <duke at openjdk.org> wrote:

>> ChangedCharSetException is used to amend the charset during read according to html directives. Currently it causes immediate exit of the method which in turn causes failure to load html documents with charset directives (even if the latter must not change after all). This PR restores the catch operation as it was before the use of try with resources.
>
> rjolly has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8328953 : JEditorPane.read throws ChangedCharSetException
>   
>   The fix is to add a nested `try`-block inside `try-with-resource`; all the exceptions are handled in the nested `try`; the outer `try`-with-resouces only closes the input stream.

test/jdk/javax/swing/JEditorPane/EditorPaneCharset.java line 69:

> 67:         Element body = root.getElement(1);
> 68:         Element p = body.getElement(0);
> 69:         String pText = document.getText(p.getStartOffset(),

Unhandled exception here (`BadLocationException`), for `getText()`. Also extra braces at end.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17567#discussion_r1540415503

From tr at openjdk.org  Wed Mar 27 03:43:21 2024
From: tr at openjdk.org (Tejesh R)
Date: Wed, 27 Mar 2024 03:43:21 GMT
Subject: RFR: 8328819: Remove applet usage from JFileChooser tests
 bug6698013 [v3]
In-Reply-To: <W0H-lo7M5wDtr28MOLfCRhRXd57IoQK4639AApxheHY=.c3bb240e-cfc3-486e-b09e-da76c196588c@github.com>
References: <iLcbr4t_2UJ4muFqTIm1NMfahCdwMTpgprqHo8WHHW0=.29e91557-e4b0-4d9c-ba32-fb2ab49e5de9@github.com>
 <W0H-lo7M5wDtr28MOLfCRhRXd57IoQK4639AApxheHY=.c3bb240e-cfc3-486e-b09e-da76c196588c@github.com>
Message-ID: <3bcPS6k8G5yElWjzw4oMSmXwsNVlbsvmnAPsaTssaTY=.9984cab0-5971-4890-9023-57f0dbc21e1c@github.com>

On Tue, 26 Mar 2024 22:41:45 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> Removing applet usage from manual JFileChooser tests
>> The original test is failing (nothing shows up in the JFileChooser), but this change does replace the applet usage with PassFailJFrame
>
> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   update test instructions, move vars into subclass

Marked as reviewed by tr (Committer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18456#pullrequestreview-1962207372

From tr at openjdk.org  Wed Mar 27 03:48:26 2024
From: tr at openjdk.org (Tejesh R)
Date: Wed, 27 Mar 2024 03:48:26 GMT
Subject: RFR: 8327137: Add test for ConcurrentModificationException in
 BasicDirectoryModel
In-Reply-To: <f8GBiDLMGxzR_kHRH5d_5HA6xmr1Hh5W3lXhYQZpVT8=.9456f659-4c36-4fb4-bf36-11d769732543@github.com>
References: <mCqqjrXVWDB2PvpOhKHx-Hr8W6tUz6v4stztGmyAeEg=.1f95da1c-e1a5-40be-be8b-0758729fa9b9@github.com>
 <aRuO2zb4IkM3F28MH5RcfHesc1Z9i7w_uK8kSkIh6i0=.cce14bf8-3384-4e8e-9c12-4e0708dbf3ab@github.com>
 <iT0AkMDtFdmSgs9hw1n8wICk_ywpXnbklk9I-STL7WM=.d6dc05f1-7cdc-43f2-bc86-dc9e7e3bdc39@github.com>
 <MjyHoVphv3Ydr6ZvzpIwEEJa9ijiccVne_AUzme8e8c=.09ad81a2-13e9-4b6f-93c8-5a4e8e0192a1@github.com>
 <e2WB9a0OV6zGGQClxDliRZpSybk0Yf-1tghML0ddNM4=.e571d038-cbbc-4f29-8618-60c9df796169@github.com>
 <YlEf-rnP9E5iSzk8W5YhsLokR44b_NZnU-o3RpB2yfk=.c9c0e2bc-2a86-4818-8ae7-0d6df7108060@github.com>
 <f8GBiDLMGxzR_kHRH5d_5HA6xmr1Hh5W3lXhYQZpVT8=.9456f659-4c36-4fb4-bf36-11d769732543@github.com>
Message-ID: <NXt5Smw0V6ieMX1ifUZNSHJO770hcjN_H9G9EFystk0=.8c950698-4078-4df7-8648-06284108f1f5@github.com>

On Tue, 19 Mar 2024 17:08:44 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> > > Yes, it's running in 21 and 22 as well, so we'll see what happens there.
> > 
> > 
> > We got the following, once in jdk21u and once in jdk21u-dev on macintelx64 through the weekend:
> 
> Thank you, Christoph! @RealCLanger. At least one failure is detected. It's better than nothing, isn't it?

Definitely helpful. For these fixes - [JDK-8323670](https://bugs.openjdk.org/browse/JDK-8323670) and [JDK-8307091](https://bugs.openjdk.org/browse/JDK-8307091), the only way to debug was with code walkthrough. This test will help a lot even its able to reproduce intermittently according to me, especially to build some confidence for the fix.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18109#issuecomment-2021869992

From abhiscxk at openjdk.org  Wed Mar 27 05:13:24 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Wed, 27 Mar 2024 05:13:24 GMT
Subject: RFR: 8328648: Remove applet usage from JFileChooser tests
 bug4150029 [v4]
In-Reply-To: <gDAQGl44db6zGs2rt8bVVlSH6va-t-yxtUOi50zerSc=.8a3dc583-034a-466b-b9b7-afa11c97fb96@github.com>
References: <eTiR35uGxb59RbbKcRAdTrgYkrx4CNmkIWfk63i3sJw=.8771db30-c50e-4c50-ae80-312a7683cc27@github.com>
 <gDAQGl44db6zGs2rt8bVVlSH6va-t-yxtUOi50zerSc=.8a3dc583-034a-466b-b9b7-afa11c97fb96@github.com>
Message-ID: <XfGx3V-oZS9sMc8vaxjkd_CLON-tfAtQuWje3yheO5c=.c60db966-bc17-4faf-b70a-6e8bb9f7d132@github.com>

On Tue, 26 Mar 2024 22:33:45 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> Removing applet usage from manual JFileChooser tests
>
> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   moved create ui code to helper, change test pass check, add mouse release, remove getContentPane

test/jdk/javax/swing/JFileChooser/4150029/bug4150029.java line 86:

> 84:             System.out.println("Created sub-directory: " + subDir);
> 85: 
> 86:             fileChooser = new JFileChooser(subDir);

Not required here as you are initializing in `createAndShowUI` method.

test/jdk/javax/swing/JFileChooser/4150029/bug4150029.java line 137:

> 135:             clickBackSpace();
> 136:             if (prevDir == crntDir) {
> 137:                 passed_2 = true;

This condition is not satisfied and hence the test failed in win11 machine. In linux machine, once the current directory is at `root` then pressing the backspace key doesn't have any effect.
But looks like it is different in windows and mac. Checked in windows native explorer, once it reached to `home` folder, it toggles between `home` and `Desktop` on backspace key press. The condition checked here will never satisfy and `passed_2` variable remains false.

So, either you can check the condition differently or may remove this check for windows and mac.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18415#discussion_r1540454288
PR Review Comment: https://git.openjdk.org/jdk/pull/18415#discussion_r1540474274

From abhiscxk at openjdk.org  Wed Mar 27 05:15:23 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Wed, 27 Mar 2024 05:15:23 GMT
Subject: RFR: 8328482: Convert and Open source few manual applet test to
 main based [v4]
In-Reply-To: <TYJFZwPv2tFlCYmwFMZfO11wsxCY8WNPHuvu4urAtzM=.0ff7923d-aacb-4705-9e68-d2d029c257ad@github.com>
References: <aV9yYWUEsrakxmujJCq2LzFg5K6nyCV4aELge8c1oJo=.c9f2c13d-337f-4af3-8a38-551a7f0ba0c6@github.com>
 <TYJFZwPv2tFlCYmwFMZfO11wsxCY8WNPHuvu4urAtzM=.0ff7923d-aacb-4705-9e68-d2d029c257ad@github.com>
Message-ID: <mq43zFxVEDALcRCagB9x9RnF2kkA6pCfB9KM__uEB7k=.79e5f567-4b92-4725-bce1-2eab28b1d090@github.com>

On Wed, 27 Mar 2024 03:33:57 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Convert and open source these manual applet test to main based:
>> java/awt/Frame/MegaIconTest/MegaIconTest.html
>> java/awt/Frame/FrameMaximizedTest/FrameMaximizedTest.html
>> java/awt/Frame/FrameMinimizeTest/FrameMinimizeTest.html
>> java/awt/Frame/SizeMinimizedTest/SizeMinimizedTest.html
>
> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fight.gif added

Looks good now.

-------------

Marked as reviewed by abhiscxk (Committer).

PR Review: https://git.openjdk.org/jdk/pull/18448#pullrequestreview-1962305456

From jwaters at openjdk.org  Wed Mar 27 06:38:57 2024
From: jwaters at openjdk.org (Julian Waters)
Date: Wed, 27 Mar 2024 06:38:57 GMT
Subject: RFR: 8307160: Fix AWT/2D/A11Y to support the permissive- flag on
 the Microsoft Visual C compiler [v62]
In-Reply-To: <7piLRto5nNbhYYYfENCr5ecm4M2xNtMkjkE8XhrLLQ0=.8fd1ac3a-46f8-47a8-ae37-a4abbf7757d9@github.com>
References: <7piLRto5nNbhYYYfENCr5ecm4M2xNtMkjkE8XhrLLQ0=.8fd1ac3a-46f8-47a8-ae37-a4abbf7757d9@github.com>
Message-ID: <IKmfGJIxYJRgDvW91ui-M32r-BJYOHJbH2-JIkG040I=.ea9712ac-27ab-47d8-b4dd-0e1308348e49@github.com>

> We should set the -permissive- flag for the Microsoft Visual C compiler, as was requested by the now backed out [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). Doing so makes the Visual C compiler much less accepting of ill formed code, which will improve code quality on Windows in the future.

Julian Waters has updated the pull request incrementally with one additional commit since the last revision:

  Revert formatting in src/java.desktop/windows/native/libawt/windows/awt_PrintJob.cpp
  
  Co-authored-by: Magnus Ihse Bursie <mag at icus.se>

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/15096/files
  - new: https://git.openjdk.org/jdk/pull/15096/files/ef9f3a62..8ddb241d

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=15096&range=61
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=15096&range=60-61

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/15096.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/15096/head:pull/15096

PR: https://git.openjdk.org/jdk/pull/15096

From jwaters at openjdk.org  Wed Mar 27 06:38:57 2024
From: jwaters at openjdk.org (Julian Waters)
Date: Wed, 27 Mar 2024 06:38:57 GMT
Subject: RFR: 8307160: Fix AWT/2D/A11Y to support the permissive- flag on
 the Microsoft Visual C compiler [v61]
In-Reply-To: <gLHJ2H5UbKs1Cwgg-aOPPScteSSClIlr2vF-BPtUB20=.64b6a55a-54ca-4b6c-9ae8-949be49c8ca1@github.com>
References: <7piLRto5nNbhYYYfENCr5ecm4M2xNtMkjkE8XhrLLQ0=.8fd1ac3a-46f8-47a8-ae37-a4abbf7757d9@github.com>
 <gLHJ2H5UbKs1Cwgg-aOPPScteSSClIlr2vF-BPtUB20=.64b6a55a-54ca-4b6c-9ae8-949be49c8ca1@github.com>
Message-ID: <3ihfagdM-3FjSwnzvgKRLX920MBdi2kqma03hQ7o_8o=.af6a99e1-dd80-48e3-b5e5-2a9a87b51801@github.com>

On Tue, 26 Mar 2024 08:55:56 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> We should set the -permissive- flag for the Microsoft Visual C compiler, as was requested by the now backed out [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). Doing so makes the Visual C compiler much less accepting of ill formed code, which will improve code quality on Windows in the future.
>
> Julian Waters has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Whitespace in awt_DnDDS.cpp
>  - Whitespace in awt_DnDDT.cpp

Thanks, will assign the permissions. Though, I'll try to finish this myself so you don't have to- It seems like bad etiquette to make you fix something that I started. But all of this will still be meaningless if Phil doesn't return to this Pull Request any time soon :(

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15096#issuecomment-2022058697

From jwaters at openjdk.org  Wed Mar 27 06:41:43 2024
From: jwaters at openjdk.org (Julian Waters)
Date: Wed, 27 Mar 2024 06:41:43 GMT
Subject: RFR: 8307160: Fix AWT/2D/A11Y to support the permissive- flag on
 the Microsoft Visual C compiler [v46]
In-Reply-To: <sKKibwSb17BpRFpItUuGKw4s-Xl-T4RekSKrg2EC7PY=.31db02fc-f0a6-4e15-ac8d-23826386fe6b@github.com>
References: <7piLRto5nNbhYYYfENCr5ecm4M2xNtMkjkE8XhrLLQ0=.8fd1ac3a-46f8-47a8-ae37-a4abbf7757d9@github.com>
 <5WJnl6Z9RyYzZrDStf9p74gus07Stz6S6NHwVpGQO3M=.0a04a120-77b5-48c3-9ae8-7d37c9646463@github.com>
 <QfIBrG8rqxy__rPSCMddlNATjmEEr4ccSoZyjFckjUg=.b7f6fffb-2cf9-4c54-a35c-b01f5fd654de@github.com>
 <aAmBW4xAmuvxi3KEXCNFaq8WZ0zjjKk_bZisWgA6UMM=.a0a49004-699f-4835-ba98-9510427f9483@github.com>
 <0zriWFk8mESin6eTDm4kH02213a8tTq5gEBx41NtZ8Y=.74965e93-6475-44ee-805b-73c477aede94@github.com>
 <sKKibwSb17BpRFpItUuGKw4s-Xl-T4RekSKrg2EC7PY=.31db02fc-f0a6-4e15-ac8d-23826386fe6b@github.com>
Message-ID: <D5gh-IrnrLXopFHTGHrYSRcpnASfXuDiggefZubmIvA=.cb3271b0-32a2-440a-bbb8-b754833d05af@github.com>

On Tue, 26 Mar 2024 20:03:36 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> I see the advantage of collapsing self and parent into the same check, but it doesn't seem like getting rid of pData is of much benefit, the checks for null seem to remain the same either way
>
>> Sorry, I don't see a BOOL error anywhere?
> 
> I think Phil misplaced the code block marker -- the BOOL error line and below is supposed to be inside the second code block.
> 
> What Phil is doing is trying to suggest two different approaches to make this code nicer, the first with a bit more duplication, and the second with an `error` boolean flag. And he says that he prefers the former, so the second were propably just mentioned to show an alternative for discussion.
> 
> I think what you should do here is to combine the `self` and `parent` null checks as Phil suggests. And then replace all pData references to the final variable, here as well as everywhere pData is involved.

Ah, I see. Alright, will do so

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15096#discussion_r1540550556

From jwaters at openjdk.org  Wed Mar 27 06:46:08 2024
From: jwaters at openjdk.org (Julian Waters)
Date: Wed, 27 Mar 2024 06:46:08 GMT
Subject: RFR: 8307160: Fix AWT/2D/A11Y to support the permissive- flag on
 the Microsoft Visual C compiler [v63]
In-Reply-To: <7piLRto5nNbhYYYfENCr5ecm4M2xNtMkjkE8XhrLLQ0=.8fd1ac3a-46f8-47a8-ae37-a4abbf7757d9@github.com>
References: <7piLRto5nNbhYYYfENCr5ecm4M2xNtMkjkE8XhrLLQ0=.8fd1ac3a-46f8-47a8-ae37-a4abbf7757d9@github.com>
Message-ID: <CjSc4YoT6c5k1B5ftR0_UZCpEPdZla4gSJU1xaQI5U8=.b9778d23-96b2-4034-aaed-a492743d4c3b@github.com>

> We should set the -permissive- flag for the Microsoft Visual C compiler, as was requested by the now backed out [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). Doing so makes the Visual C compiler much less accepting of ill formed code, which will improve code quality on Windows in the future.

Julian Waters has updated the pull request incrementally with one additional commit since the last revision:

  Circumvent pData in awt_Component.cpp

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/15096/files
  - new: https://git.openjdk.org/jdk/pull/15096/files/8ddb241d..da0c09b1

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=15096&range=62
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=15096&range=61-62

  Stats: 16 lines in 1 file changed: 0 ins; 11 del; 5 mod
  Patch: https://git.openjdk.org/jdk/pull/15096.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/15096/head:pull/15096

PR: https://git.openjdk.org/jdk/pull/15096

From jwaters at openjdk.org  Wed Mar 27 07:05:17 2024
From: jwaters at openjdk.org (Julian Waters)
Date: Wed, 27 Mar 2024 07:05:17 GMT
Subject: RFR: 8307160: Fix AWT/2D/A11Y to support the permissive- flag on
 the Microsoft Visual C compiler [v64]
In-Reply-To: <7piLRto5nNbhYYYfENCr5ecm4M2xNtMkjkE8XhrLLQ0=.8fd1ac3a-46f8-47a8-ae37-a4abbf7757d9@github.com>
References: <7piLRto5nNbhYYYfENCr5ecm4M2xNtMkjkE8XhrLLQ0=.8fd1ac3a-46f8-47a8-ae37-a4abbf7757d9@github.com>
Message-ID: <QVII3WXrLZbsfQA2r3uHvIzPRwJNqTnb9yXgXvJPATI=.248d30fc-8ac6-404c-aabe-ec15fc9b7f5a@github.com>

> We should set the -permissive- flag for the Microsoft Visual C compiler, as was requested by the now backed out [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). Doing so makes the Visual C compiler much less accepting of ill formed code, which will improve code quality on Windows in the future.

Julian Waters has updated the pull request incrementally with one additional commit since the last revision:

  Circumvent pData in awt_Frame.cpp

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/15096/files
  - new: https://git.openjdk.org/jdk/pull/15096/files/da0c09b1..8f4d9e95

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=15096&range=63
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=15096&range=62-63

  Stats: 7 lines in 1 file changed: 0 ins; 3 del; 4 mod
  Patch: https://git.openjdk.org/jdk/pull/15096.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/15096/head:pull/15096

PR: https://git.openjdk.org/jdk/pull/15096

From jwaters at openjdk.org  Wed Mar 27 07:13:11 2024
From: jwaters at openjdk.org (Julian Waters)
Date: Wed, 27 Mar 2024 07:13:11 GMT
Subject: RFR: 8307160: Fix AWT/2D/A11Y to support the permissive- flag on
 the Microsoft Visual C compiler [v65]
In-Reply-To: <7piLRto5nNbhYYYfENCr5ecm4M2xNtMkjkE8XhrLLQ0=.8fd1ac3a-46f8-47a8-ae37-a4abbf7757d9@github.com>
References: <7piLRto5nNbhYYYfENCr5ecm4M2xNtMkjkE8XhrLLQ0=.8fd1ac3a-46f8-47a8-ae37-a4abbf7757d9@github.com>
Message-ID: <CS9WH9rK26wpZUOW9pYdwGLDRMBL45gXHAqP3jZASXU=.9d279f8b-d039-4446-b0c7-2237be73c8c6@github.com>

> We should set the -permissive- flag for the Microsoft Visual C compiler, as was requested by the now backed out [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). Doing so makes the Visual C compiler much less accepting of ill formed code, which will improve code quality on Windows in the future.

Julian Waters has updated the pull request incrementally with one additional commit since the last revision:

  Circumvent pData in awt_Window.cpp

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/15096/files
  - new: https://git.openjdk.org/jdk/pull/15096/files/8f4d9e95..c4f4e54b

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=15096&range=64
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=15096&range=63-64

  Stats: 4 lines in 1 file changed: 0 ins; 1 del; 3 mod
  Patch: https://git.openjdk.org/jdk/pull/15096.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/15096/head:pull/15096

PR: https://git.openjdk.org/jdk/pull/15096

From duke at openjdk.org  Wed Mar 27 08:48:55 2024
From: duke at openjdk.org (rjolly)
Date: Wed, 27 Mar 2024 08:48:55 GMT
Subject: RFR: 8328953 : JEditorPane.read throws ChangedCharSetException
 [v5]
In-Reply-To: <j32PTT_v706cIsLg9ssxPivpEJoo5bCJ1H5NHj3KDhY=.b9e439f3-ce7a-4d63-bfe4-bd415a34a2d2@github.com>
References: <j32PTT_v706cIsLg9ssxPivpEJoo5bCJ1H5NHj3KDhY=.b9e439f3-ce7a-4d63-bfe4-bd415a34a2d2@github.com>
Message-ID: <MQ704GQsEkJ41AjvAwLXtKbMcyk3_HVTTu_gDU3iP48=.83bcfb4b-6565-42c6-91f5-3eebd4c379bf@github.com>

> ChangedCharSetException is used to amend the charset during read according to html directives. Currently it causes immediate exit of the method which in turn causes failure to load html documents with charset directives (even if the latter must not change after all). This PR restores the catch operation as it was before the use of try with resources.

rjolly has updated the pull request incrementally with one additional commit since the last revision:

  8328953 : JEditorPane.read throws ChangedCharSetException
  
  The fix is to add a nested `try`-block inside `try-with-resource`; all the exceptions are handled in the nested `try`; the outer `try`-with-resouces only closes the input stream.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/17567/files
  - new: https://git.openjdk.org/jdk/pull/17567/files/15dcec91..5af3006b

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=17567&range=04
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17567&range=03-04

  Stats: 10 lines in 1 file changed: 5 ins; 0 del; 5 mod
  Patch: https://git.openjdk.org/jdk/pull/17567.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17567/head:pull/17567

PR: https://git.openjdk.org/jdk/pull/17567

From ihse at openjdk.org  Wed Mar 27 09:18:54 2024
From: ihse at openjdk.org (Magnus Ihse Bursie)
Date: Wed, 27 Mar 2024 09:18:54 GMT
Subject: RFR: 8307160: Fix AWT/2D/A11Y to support the permissive- flag on
 the Microsoft Visual C compiler [v65]
In-Reply-To: <CS9WH9rK26wpZUOW9pYdwGLDRMBL45gXHAqP3jZASXU=.9d279f8b-d039-4446-b0c7-2237be73c8c6@github.com>
References: <7piLRto5nNbhYYYfENCr5ecm4M2xNtMkjkE8XhrLLQ0=.8fd1ac3a-46f8-47a8-ae37-a4abbf7757d9@github.com>
 <CS9WH9rK26wpZUOW9pYdwGLDRMBL45gXHAqP3jZASXU=.9d279f8b-d039-4446-b0c7-2237be73c8c6@github.com>
Message-ID: <e7hGmVhBxK6if98NuizlS6bRlMSksWzQu_4OP2eDN4o=.1b7dec00-0fc8-44d9-9e69-efa856d5df50@github.com>

On Wed, 27 Mar 2024 07:13:11 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> We should set the -permissive- flag for the Microsoft Visual C compiler, as was requested by the now backed out [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). Doing so makes the Visual C compiler much less accepting of ill formed code, which will improve code quality on Windows in the future.
>
> Julian Waters has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Circumvent pData in awt_Window.cpp

Let's fix all the known problems first, and he'll return. (Otherwise I'll ping him in a different channel.)

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15096#issuecomment-2022278178

From jwaters at openjdk.org  Wed Mar 27 10:17:01 2024
From: jwaters at openjdk.org (Julian Waters)
Date: Wed, 27 Mar 2024 10:17:01 GMT
Subject: RFR: 8307160: Fix AWT/2D/A11Y to support the permissive- flag on
 the Microsoft Visual C compiler [v66]
In-Reply-To: <7piLRto5nNbhYYYfENCr5ecm4M2xNtMkjkE8XhrLLQ0=.8fd1ac3a-46f8-47a8-ae37-a4abbf7757d9@github.com>
References: <7piLRto5nNbhYYYfENCr5ecm4M2xNtMkjkE8XhrLLQ0=.8fd1ac3a-46f8-47a8-ae37-a4abbf7757d9@github.com>
Message-ID: <yAnZ8FAH5gD0ld77nb7roQByw2Vq_J4EGWFbeitkjHw=.5b42d9aa-3cbc-4bad-acea-82013f132134@github.com>

> We should set the -permissive- flag for the Microsoft Visual C compiler, as was requested by the now backed out [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). Doing so makes the Visual C compiler much less accepting of ill formed code, which will improve code quality on Windows in the future.

Julian Waters has updated the pull request incrementally with one additional commit since the last revision:

  Circumvent pData in awt_Window.cpp

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/15096/files
  - new: https://git.openjdk.org/jdk/pull/15096/files/c4f4e54b..360894b5

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=15096&range=65
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=15096&range=64-65

  Stats: 8 lines in 1 file changed: 0 ins; 2 del; 6 mod
  Patch: https://git.openjdk.org/jdk/pull/15096.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/15096/head:pull/15096

PR: https://git.openjdk.org/jdk/pull/15096

From jwaters at openjdk.org  Wed Mar 27 10:25:09 2024
From: jwaters at openjdk.org (Julian Waters)
Date: Wed, 27 Mar 2024 10:25:09 GMT
Subject: RFR: 8307160: Fix AWT/2D/A11Y to support the permissive- flag on
 the Microsoft Visual C compiler [v67]
In-Reply-To: <7piLRto5nNbhYYYfENCr5ecm4M2xNtMkjkE8XhrLLQ0=.8fd1ac3a-46f8-47a8-ae37-a4abbf7757d9@github.com>
References: <7piLRto5nNbhYYYfENCr5ecm4M2xNtMkjkE8XhrLLQ0=.8fd1ac3a-46f8-47a8-ae37-a4abbf7757d9@github.com>
Message-ID: <lxg6RbeIr-RSQjVO8aDdLYSVL-oLRCZuKfmcnWx4GDA=.f5d96d26-f146-40e4-a145-073ac12e2fd0@github.com>

> We should set the -permissive- flag for the Microsoft Visual C compiler, as was requested by the now backed out [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). Doing so makes the Visual C compiler much less accepting of ill formed code, which will improve code quality on Windows in the future.

Julian Waters has updated the pull request incrementally with one additional commit since the last revision:

  Circumvent pData in awt_Window.cpp

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/15096/files
  - new: https://git.openjdk.org/jdk/pull/15096/files/360894b5..6027b1df

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=15096&range=66
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=15096&range=65-66

  Stats: 4 lines in 1 file changed: 0 ins; 1 del; 3 mod
  Patch: https://git.openjdk.org/jdk/pull/15096.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/15096/head:pull/15096

PR: https://git.openjdk.org/jdk/pull/15096

From jwaters at openjdk.org  Wed Mar 27 10:31:12 2024
From: jwaters at openjdk.org (Julian Waters)
Date: Wed, 27 Mar 2024 10:31:12 GMT
Subject: RFR: 8307160: Fix AWT/2D/A11Y to support the permissive- flag on
 the Microsoft Visual C compiler [v68]
In-Reply-To: <7piLRto5nNbhYYYfENCr5ecm4M2xNtMkjkE8XhrLLQ0=.8fd1ac3a-46f8-47a8-ae37-a4abbf7757d9@github.com>
References: <7piLRto5nNbhYYYfENCr5ecm4M2xNtMkjkE8XhrLLQ0=.8fd1ac3a-46f8-47a8-ae37-a4abbf7757d9@github.com>
Message-ID: <oyvIk7u4ffsGahWTsbDM558reJySlARmicuR924DvPE=.0c634575-c3d0-4746-8884-f18ce8d2e16d@github.com>

> We should set the -permissive- flag for the Microsoft Visual C compiler, as was requested by the now backed out [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). Doing so makes the Visual C compiler much less accepting of ill formed code, which will improve code quality on Windows in the future.

Julian Waters has updated the pull request incrementally with two additional commits since the last revision:

 - Label to empty line in awt_Component.cpp
 - Label to empty line in awt_Canvas.cpp

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/15096/files
  - new: https://git.openjdk.org/jdk/pull/15096/files/6027b1df..45de8955

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=15096&range=67
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=15096&range=66-67

  Stats: 2 lines in 2 files changed: 2 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/15096.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/15096/head:pull/15096

PR: https://git.openjdk.org/jdk/pull/15096

From aivanov at openjdk.org  Wed Mar 27 10:31:38 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Wed, 27 Mar 2024 10:31:38 GMT
Subject: RFR: 8328953 : JEditorPane.read throws ChangedCharSetException
 [v5]
In-Reply-To: <MQ704GQsEkJ41AjvAwLXtKbMcyk3_HVTTu_gDU3iP48=.83bcfb4b-6565-42c6-91f5-3eebd4c379bf@github.com>
References: <j32PTT_v706cIsLg9ssxPivpEJoo5bCJ1H5NHj3KDhY=.b9e439f3-ce7a-4d63-bfe4-bd415a34a2d2@github.com>
 <MQ704GQsEkJ41AjvAwLXtKbMcyk3_HVTTu_gDU3iP48=.83bcfb4b-6565-42c6-91f5-3eebd4c379bf@github.com>
Message-ID: <bxL7HUPt1ONqzrei2j_SMnJHIZl6oTJveTc_AM-zCGI=.9a1ad60f-441b-4b7b-bf2a-55de4548c219@github.com>

On Wed, 27 Mar 2024 08:48:55 GMT, rjolly <duke at openjdk.org> wrote:

>> ChangedCharSetException is used to amend the charset during read according to html directives. Currently it causes immediate exit of the method which in turn causes failure to load html documents with charset directives (even if the latter must not change after all). This PR restores the catch operation as it was before the use of try with resources.
>
> rjolly has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8328953 : JEditorPane.read throws ChangedCharSetException
>   
>   The fix is to add a nested `try`-block inside `try-with-resource`; all the exceptions are handled in the nested `try`; the outer `try`-with-resouces only closes the input stream.

Changes requested by aivanov (Reviewer).

test/jdk/javax/swing/JEditorPane/EditorPaneCharset.java line 35:

> 33: /*
> 34:  * @test
> 35:  * @key headless

Suggestion:


There's no *headless* key; only *headful* tests need to be marked specifically.

test/jdk/javax/swing/JEditorPane/EditorPaneCharset.java line 37:

> 35:  * @key headless
> 36:  * @bug 8328953
> 37:  * @summary JEditorPane.read throws ChangedCharSetException

Suggestion:

 * @summary Verifies JEditorPane.read doesn't throw ChangedCharSetException
            but handles it and reads HTML in the specified encoding

test/jdk/javax/swing/JEditorPane/EditorPaneCharset.java line 47:

> 45:             "<html lang=\"ru\">\n" +
> 46:             "<head>\n" +
> 47:            "    <meta http-equiv=\"Content-Type\" content=\"text/html; charset=windows-1251\">\n" +

Suggestion:

            "    <meta http-equiv="Content-Type" " + 
            "         content="text/html; charset=windows-1251">\n" +

test/jdk/javax/swing/JEditorPane/EditorPaneCharset.java line 52:

> 50:             "</body></html>\n";
> 51: 
> 52:     public static void main() throws IOException {

Suggestion:

    public static void main(String[] args)
            throws IOException, BadLocationException {

The `main` function should be like this. In [my comment](https://github.com/openjdk/jdk/pull/17567#discussion_r1539063737), I referred to it as `main()` because typing all these in a comment is tedious.

Yes, Java now allows `main` without arguments but this feature is not supported in previous versions of Java, and tests should not rely on this feature.

Alternatively, you may use `throws Exception` to allow all kinds of exceptions. Using `throws Exception` is more common. I don't have a strong preference in this case.

test/jdk/javax/swing/JEditorPane/EditorPaneCharset.java line 65:

> 63:         } catch (IOException e) {
> 64:             throw new RuntimeException(e);
> 65:         }

Now that you added `throws IOException` to `main` declaration, you can allow it to escape to fail the test. Please do. Remove the try-catch block.

test/jdk/javax/swing/JEditorPane/EditorPaneCharset.java line 78:

> 76:         } catch (BadLocationException e) {
> 77:             throw new RuntimeException(e);
> 78:         }

Similarly, remove this try-catch block and allow `BadLocationException` to escape.

test/jdk/javax/swing/JEditorPane/EditorPaneCharset.java line 82:

> 80: 
> 81:     private EditorPaneCharset() {
> 82:     }

The constructor is not needed. It used it in my test, but now it's empty.

-------------

PR Review: https://git.openjdk.org/jdk/pull/17567#pullrequestreview-1962874040
PR Review Comment: https://git.openjdk.org/jdk/pull/17567#discussion_r1540832221
PR Review Comment: https://git.openjdk.org/jdk/pull/17567#discussion_r1540834671
PR Review Comment: https://git.openjdk.org/jdk/pull/17567#discussion_r1540828514
PR Review Comment: https://git.openjdk.org/jdk/pull/17567#discussion_r1540814672
PR Review Comment: https://git.openjdk.org/jdk/pull/17567#discussion_r1540822881
PR Review Comment: https://git.openjdk.org/jdk/pull/17567#discussion_r1540824315
PR Review Comment: https://git.openjdk.org/jdk/pull/17567#discussion_r1540825793

From jwaters at openjdk.org  Wed Mar 27 10:41:02 2024
From: jwaters at openjdk.org (Julian Waters)
Date: Wed, 27 Mar 2024 10:41:02 GMT
Subject: RFR: 8307160: Fix AWT/2D/A11Y to support the permissive- flag on
 the Microsoft Visual C compiler [v69]
In-Reply-To: <7piLRto5nNbhYYYfENCr5ecm4M2xNtMkjkE8XhrLLQ0=.8fd1ac3a-46f8-47a8-ae37-a4abbf7757d9@github.com>
References: <7piLRto5nNbhYYYfENCr5ecm4M2xNtMkjkE8XhrLLQ0=.8fd1ac3a-46f8-47a8-ae37-a4abbf7757d9@github.com>
Message-ID: <nZV2D4wVdEA2cwIEsJQLXHuUo4pL34WfrRnOfQcx7qk=.ec6589d1-39db-4cd5-bb5a-10f3c55cb530@github.com>

> We should set the -permissive- flag for the Microsoft Visual C compiler, as was requested by the now backed out [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). Doing so makes the Visual C compiler much less accepting of ill formed code, which will improve code quality on Windows in the future.

Julian Waters has updated the pull request incrementally with one additional commit since the last revision:

  Revert formatting in awt_Window.cpp

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/15096/files
  - new: https://git.openjdk.org/jdk/pull/15096/files/45de8955..ee0297a6

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=15096&range=68
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=15096&range=67-68

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/15096.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/15096/head:pull/15096

PR: https://git.openjdk.org/jdk/pull/15096

From duke at openjdk.org  Wed Mar 27 10:43:55 2024
From: duke at openjdk.org (rjolly)
Date: Wed, 27 Mar 2024 10:43:55 GMT
Subject: RFR: 8328953 : JEditorPane.read throws ChangedCharSetException
 [v6]
In-Reply-To: <j32PTT_v706cIsLg9ssxPivpEJoo5bCJ1H5NHj3KDhY=.b9e439f3-ce7a-4d63-bfe4-bd415a34a2d2@github.com>
References: <j32PTT_v706cIsLg9ssxPivpEJoo5bCJ1H5NHj3KDhY=.b9e439f3-ce7a-4d63-bfe4-bd415a34a2d2@github.com>
Message-ID: <3WeJJEfTmfzwrXx5SlanbJvVKiiJea9TQQHfPJAPByM=.84ead59c-805d-4f4f-b184-dbc403ce1642@github.com>

> ChangedCharSetException is used to amend the charset during read according to html directives. Currently it causes immediate exit of the method which in turn causes failure to load html documents with charset directives (even if the latter must not change after all). This PR restores the catch operation as it was before the use of try with resources.

rjolly has updated the pull request incrementally with one additional commit since the last revision:

  8328953 : JEditorPane.read throws ChangedCharSetException
  
  The fix is to add a nested `try`-block inside `try-with-resource`; all the exceptions are handled in the nested `try`; the outer `try`-with-resouces only closes the input stream.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/17567/files
  - new: https://git.openjdk.org/jdk/pull/17567/files/5af3006b..c09d4011

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=17567&range=05
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17567&range=04-05

  Stats: 27 lines in 1 file changed: 2 ins; 12 del; 13 mod
  Patch: https://git.openjdk.org/jdk/pull/17567.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17567/head:pull/17567

PR: https://git.openjdk.org/jdk/pull/17567

From aivanov at openjdk.org  Wed Mar 27 10:53:25 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Wed, 27 Mar 2024 10:53:25 GMT
Subject: RFR: 8328953 : JEditorPane.read throws ChangedCharSetException
 [v6]
In-Reply-To: <3WeJJEfTmfzwrXx5SlanbJvVKiiJea9TQQHfPJAPByM=.84ead59c-805d-4f4f-b184-dbc403ce1642@github.com>
References: <j32PTT_v706cIsLg9ssxPivpEJoo5bCJ1H5NHj3KDhY=.b9e439f3-ce7a-4d63-bfe4-bd415a34a2d2@github.com>
 <3WeJJEfTmfzwrXx5SlanbJvVKiiJea9TQQHfPJAPByM=.84ead59c-805d-4f4f-b184-dbc403ce1642@github.com>
Message-ID: <wrB3-k-pJqW5oo_2jqtOfTBlAkZb3HHby3Nv18h8QxQ=.9188acf4-ad00-404d-ba2c-549639627fe0@github.com>

On Wed, 27 Mar 2024 10:43:55 GMT, rjolly <duke at openjdk.org> wrote:

>> ChangedCharSetException is used to amend the charset during read according to html directives. Currently it causes immediate exit of the method which in turn causes failure to load html documents with charset directives (even if the latter must not change after all). This PR restores the catch operation as it was before the use of try with resources.
>
> rjolly has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8328953 : JEditorPane.read throws ChangedCharSetException
>   
>   The fix is to add a nested `try`-block inside `try-with-resource`; all the exceptions are handled in the nested `try`; the outer `try`-with-resouces only closes the input stream.

Other than a couple of nits, it looks good to me.

I'll submit a test job to run all the tests with this fix and this test.

test/jdk/javax/swing/JEditorPane/EditorPaneCharset.java line 48:

> 46:             "<head>\n" +
> 47:             "    <meta http-equiv=\"Content-Type\" " + 
> 48:             "         content=\"text/html; charset=windows-1251\">\n" +

Suggestion:

            "          content="text/html; charset=windows-1251">\n" +

I suggest moving it by one space to align to the start of the `http-equiv` attribute.

test/jdk/javax/swing/JEditorPane/EditorPaneCharset.java line 57:

> 55:         editorPane.setContentType("text/html");
> 56:         Document document = editorPane.getDocument();
> 57:         // Shouldn't throw ChangedCharSetException

Suggestion:

        Document document = editorPane.getDocument();

        // Shouldn't throw ChangedCharSetException

I'd add a blank line here too. It starts a new block which is the point of the test.

test/jdk/javax/swing/JEditorPane/EditorPaneCharset.java line 68:

> 66:         Element p = body.getElement(0);
> 67:         String pText = document.getText(p.getStartOffset(),
> 68:                                     p.getEndOffset() - p.getStartOffset());

Suggestion:

        String pText = document.getText(p.getStartOffset(),
                                        p.getEndOffset() - p.getStartOffset());

Let's align the second argument to the opening parenthesis.

-------------

PR Review: https://git.openjdk.org/jdk/pull/17567#pullrequestreview-1962948785
PR Review Comment: https://git.openjdk.org/jdk/pull/17567#discussion_r1540870025
PR Review Comment: https://git.openjdk.org/jdk/pull/17567#discussion_r1540872420
PR Review Comment: https://git.openjdk.org/jdk/pull/17567#discussion_r1540872209

From duke at openjdk.org  Wed Mar 27 13:22:41 2024
From: duke at openjdk.org (rjolly)
Date: Wed, 27 Mar 2024 13:22:41 GMT
Subject: RFR: 8328953 : JEditorPane.read throws ChangedCharSetException
 [v7]
In-Reply-To: <j32PTT_v706cIsLg9ssxPivpEJoo5bCJ1H5NHj3KDhY=.b9e439f3-ce7a-4d63-bfe4-bd415a34a2d2@github.com>
References: <j32PTT_v706cIsLg9ssxPivpEJoo5bCJ1H5NHj3KDhY=.b9e439f3-ce7a-4d63-bfe4-bd415a34a2d2@github.com>
Message-ID: <vo2a5LU2Vbu41XN1oxVP1B-XNatmrApAfdDWwe2PdMk=.bf7a738c-84c1-40cf-9905-2c07e54ed033@github.com>

> ChangedCharSetException is used to amend the charset during read according to html directives. Currently it causes immediate exit of the method which in turn causes failure to load html documents with charset directives (even if the latter must not change after all). This PR restores the catch operation as it was before the use of try with resources.

rjolly has updated the pull request incrementally with one additional commit since the last revision:

  8328953 : JEditorPane.read throws ChangedCharSetException
  
  The fix is to add a nested `try`-block inside `try-with-resource`; all the exceptions are handled in the nested `try`; the outer `try`-with-resouces only closes the input stream.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/17567/files
  - new: https://git.openjdk.org/jdk/pull/17567/files/c09d4011..d13fcc6d

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=17567&range=06
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17567&range=05-06

  Stats: 4 lines in 1 file changed: 1 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/jdk/pull/17567.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17567/head:pull/17567

PR: https://git.openjdk.org/jdk/pull/17567

From honkar at openjdk.org  Wed Mar 27 18:03:53 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Wed, 27 Mar 2024 18:03:53 GMT
Subject: RFR: JDK-8328753 : Open source few Undecorated Frame tests
Message-ID: <TeT19qrHb_dsgafsfZDNyiaXEYdeOEgjJ17O6us2PTo=.228b6b55-64b4-40b4-945a-e3c25a14a393@github.com>

Following tests are converted to main and open-sourced:

- /java/awt/Frame/FrameDialogMixedTest.java- Converted to main/manual using PassFailJFrame.
- /java/awt/Frame/MaximizeUndecoratedTest.java - Automated
- /java/awt/Frame/MinimizeUndecoratedTest.java - Automated

-------------

Commit messages:
 - spacing
 - Undecorated Frame tests added

Changes: https://git.openjdk.org/jdk/pull/18523/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18523&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8328753
  Stats: 350 lines in 3 files changed: 350 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18523.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18523/head:pull/18523

PR: https://git.openjdk.org/jdk/pull/18523

From honkar at openjdk.org  Wed Mar 27 18:20:59 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Wed, 27 Mar 2024 18:20:59 GMT
Subject: RFR: JDK-8328753 : Open source few Undecorated Frame tests [v2]
In-Reply-To: <TeT19qrHb_dsgafsfZDNyiaXEYdeOEgjJ17O6us2PTo=.228b6b55-64b4-40b4-945a-e3c25a14a393@github.com>
References: <TeT19qrHb_dsgafsfZDNyiaXEYdeOEgjJ17O6us2PTo=.228b6b55-64b4-40b4-945a-e3c25a14a393@github.com>
Message-ID: <KBCwA1lSI3j1IgH_Mc72T8vLYxJIaTs8JjsMLsdY2sY=.52705506-3af7-4988-94fa-5271398f1932@github.com>

> Following tests are converted to main and open-sourced:
> 
> - /java/awt/Frame/FrameDialogMixedTest.java- Converted to main/manual using PassFailJFrame.
> - /java/awt/Frame/MaximizeUndecoratedTest.java - Automated
> - /java/awt/Frame/MinimizeUndecoratedTest.java - Automated

Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:

  spacing

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18523/files
  - new: https://git.openjdk.org/jdk/pull/18523/files/0347ed8a..ff15a9d8

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18523&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18523&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/18523.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18523/head:pull/18523

PR: https://git.openjdk.org/jdk/pull/18523

From dnguyen at openjdk.org  Wed Mar 27 18:44:29 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Wed, 27 Mar 2024 18:44:29 GMT
Subject: RFR: 8329210: Delete Redundant Printer Dialog Modality Test
Message-ID: <oJS3Kg1Y6D_0Nb74CjRoKvRW7uwh8hziF5PVlXXiVu4=.a683bdcf-2dc0-4602-8545-3cbd13daf744@github.com>

test/jdk/java/awt/print/Dialog/PrintModalDialog.java is too similar in functionality to test/jdk/java/awt/print/PrinterJob/PrinterDialogsModalityTest.java.

One test was originally for modality in web browsers, while the other was for modality in Windows OS printer dialogs, but after the updates, they both check for modality on print and page dialogs for all OSs.

Since PrinterDialogsModalityTest.java is the preferred test, this is to remove PrintModalDialog.java as a test. In addition, the bugID in the jtreg tags from PrintModalDialog.java will be added to PrinterDialogsModalityTest.java's tags to maintain a link to its original bug.

-------------

Commit messages:
 - Initial test deletion and jtreg tag adding

Changes: https://git.openjdk.org/jdk/pull/18524/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18524&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8329210
  Stats: 128 lines in 2 files changed: 0 ins; 127 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/18524.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18524/head:pull/18524

PR: https://git.openjdk.org/jdk/pull/18524

From honkar at openjdk.org  Wed Mar 27 18:52:21 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Wed, 27 Mar 2024 18:52:21 GMT
Subject: RFR: 8329210: Delete Redundant Printer Dialog Modality Test
In-Reply-To: <oJS3Kg1Y6D_0Nb74CjRoKvRW7uwh8hziF5PVlXXiVu4=.a683bdcf-2dc0-4602-8545-3cbd13daf744@github.com>
References: <oJS3Kg1Y6D_0Nb74CjRoKvRW7uwh8hziF5PVlXXiVu4=.a683bdcf-2dc0-4602-8545-3cbd13daf744@github.com>
Message-ID: <LADofLQ9G224NVDvSFa1vmbrALQLLU3PjM77-RLCIaY=.0b2923db-6217-4ee3-80a9-5cfd63aaca6a@github.com>

On Wed, 27 Mar 2024 18:39:35 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

> test/jdk/java/awt/print/Dialog/PrintModalDialog.java is too similar in functionality to test/jdk/java/awt/print/PrinterJob/PrinterDialogsModalityTest.java.
> 
> One test was originally for modality in web browsers, while the other was for modality in Windows OS printer dialogs, but after the updates, they both check for modality on print and page dialogs for all OSs.
> 
> Since PrinterDialogsModalityTest.java is the preferred test, this is to remove PrintModalDialog.java as a test. In addition, the bugID in the jtreg tags from PrintModalDialog.java will be added to PrinterDialogsModalityTest.java's tags to maintain a link to its original bug.

LGTM

-------------

Marked as reviewed by honkar (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18524#pullrequestreview-1964435401

From achung at openjdk.org  Wed Mar 27 19:21:26 2024
From: achung at openjdk.org (Alisen Chung)
Date: Wed, 27 Mar 2024 19:21:26 GMT
Subject: Integrated: 8328227: Remove applet usage from JColorChooser tests
 Test4887836
In-Reply-To: <sz94hhkj7mCeInxQ075Uwe14NVjdUMDk3sbuOr1E2X0=.2cc0c644-dd7a-4044-aa17-c082abaf74b6@github.com>
References: <sz94hhkj7mCeInxQ075Uwe14NVjdUMDk3sbuOr1E2X0=.2cc0c644-dd7a-4044-aa17-c082abaf74b6@github.com>
Message-ID: <jU0-QNMMOFh8cRx5md84vIT1iQaF3RlT-i9f0taLR1M=.63376851-5f04-466e-b6e4-7a0194b8ca5e@github.com>

On Thu, 14 Mar 2024 23:02:58 GMT, Alisen Chung <achung at openjdk.org> wrote:

> Removing applet usage from manual JColorChooser tests

This pull request has now been integrated.

Changeset: cc5b9c63
Author:    Alisen Chung <achung at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/cc5b9c63cbc1743e22f80dce51d803e267c60317
Stats:     66 lines in 2 files changed: 21 ins; 34 del; 11 mod

8328227: Remove applet usage from JColorChooser tests Test4887836

Reviewed-by: honkar, prr

-------------

PR: https://git.openjdk.org/jdk/pull/18316

From achung at openjdk.org  Wed Mar 27 19:22:26 2024
From: achung at openjdk.org (Alisen Chung)
Date: Wed, 27 Mar 2024 19:22:26 GMT
Subject: Integrated: 8328819: Remove applet usage from JFileChooser tests
 bug6698013
In-Reply-To: <iLcbr4t_2UJ4muFqTIm1NMfahCdwMTpgprqHo8WHHW0=.29e91557-e4b0-4d9c-ba32-fb2ab49e5de9@github.com>
References: <iLcbr4t_2UJ4muFqTIm1NMfahCdwMTpgprqHo8WHHW0=.29e91557-e4b0-4d9c-ba32-fb2ab49e5de9@github.com>
Message-ID: <tOjXqNzv3RAzZWKP5NPy_a0Eak5oQPYl8ivyozDY64o=.8ebec4c0-92f2-4c5b-88fa-cbfebfcac4e8@github.com>

On Fri, 22 Mar 2024 15:40:39 GMT, Alisen Chung <achung at openjdk.org> wrote:

> Removing applet usage from manual JFileChooser tests
> The original test is failing (nothing shows up in the JFileChooser), but this change does replace the applet usage with PassFailJFrame

This pull request has now been integrated.

Changeset: e3588bba
Author:    Alisen Chung <achung at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/e3588bba0451d7d505b0e22d014842110677041b
Stats:     77 lines in 2 files changed: 20 ins; 39 del; 18 mod

8328819: Remove applet usage from JFileChooser tests bug6698013

Reviewed-by: honkar, tr, dnguyen

-------------

PR: https://git.openjdk.org/jdk/pull/18456

From prr at openjdk.org  Wed Mar 27 19:31:21 2024
From: prr at openjdk.org (Phil Race)
Date: Wed, 27 Mar 2024 19:31:21 GMT
Subject: RFR: 8328561: test
 java/awt/Robot/ManualInstructions/ManualInstructions.java isn't used
In-Reply-To: <yngM5VrUFUvO_QotDwBofds1j2M_VpD9OxhfRYfLoEc=.73491056-52c5-4da7-9c58-8c53dbf44a27@github.com>
References: <ABW2Bldb5eN2as1Jb7G7lFW1ULTIizQwTaHQTORhLnc=.02516bdc-9b01-4748-b80e-fa54b0b8996e@github.com>
 <yngM5VrUFUvO_QotDwBofds1j2M_VpD9OxhfRYfLoEc=.73491056-52c5-4da7-9c58-8c53dbf44a27@github.com>
Message-ID: <5DdAfdziZXwxqvTXiOL6eeU-FQK0z8fJsJYeXrnSYpU=.3e786bf8-a1b7-439d-b39d-2420f07f3ead@github.com>

On Sat, 23 Mar 2024 08:11:00 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> Should we also remove test/jdk/java/awt/Mouse/MouseModifiersUnitTest/ModifierPermutation.java which also does not have @test tag and added for same product fix JDK-6315717?

Whilst the test in that file clearly needs some work, it (1) isn't related to Applets and (2) does appear to be actually related to the product fix. So I think deciding what to do with that is a separate question. We might want to fix it up and get it running in CI testing.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18440#issuecomment-2023803733

From aivanov at openjdk.org  Wed Mar 27 20:08:45 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Wed, 27 Mar 2024 20:08:45 GMT
Subject: RFR: 8328953 : JEditorPane.read throws ChangedCharSetException
 [v7]
In-Reply-To: <vo2a5LU2Vbu41XN1oxVP1B-XNatmrApAfdDWwe2PdMk=.bf7a738c-84c1-40cf-9905-2c07e54ed033@github.com>
References: <j32PTT_v706cIsLg9ssxPivpEJoo5bCJ1H5NHj3KDhY=.b9e439f3-ce7a-4d63-bfe4-bd415a34a2d2@github.com>
 <vo2a5LU2Vbu41XN1oxVP1B-XNatmrApAfdDWwe2PdMk=.bf7a738c-84c1-40cf-9905-2c07e54ed033@github.com>
Message-ID: <OaYqCiavL5tB1zjCfPqISKYpxfNmWleueYGWEjjbvVk=.6e539f66-bf31-4991-8d1f-5384b1560c91@github.com>

On Wed, 27 Mar 2024 13:22:41 GMT, rjolly <duke at openjdk.org> wrote:

>> ChangedCharSetException is used to amend the charset during read according to html directives. Currently it causes immediate exit of the method which in turn causes failure to load html documents with charset directives (even if the latter must not change after all). This PR restores the catch operation as it was before the use of try with resources.
>
> rjolly has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8328953 : JEditorPane.read throws ChangedCharSetException
>   
>   The fix is to add a nested `try`-block inside `try-with-resource`; all the exceptions are handled in the nested `try`; the outer `try`-with-resouces only closes the input stream.

Other than the comment below, it looks fine.

Testing results are green. I'll run the tests once again after you update the code.

test/jdk/javax/swing/JEditorPane/EditorPaneCharset.java line 69:

> 67:         Element p = body.getElement(0);
> 68:         String pText = document.getText(p.getStartOffset(),
> 69:                                         p.getEndOffset() - p.getStartOffset());

Suggestion:

        String pText = document.getText(p.getStartOffset(),
                                        p.getEndOffset() - p.getStartOffset() - 1);

The test fails for me without `-1` because `pText` contains `\n`. It didn't fail when I tested it earlier.

-------------

Changes requested by aivanov (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17567#pullrequestreview-1964625088
PR Review Comment: https://git.openjdk.org/jdk/pull/17567#discussion_r1541947624

From aivanov at openjdk.org  Wed Mar 27 20:22:38 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Wed, 27 Mar 2024 20:22:38 GMT
Subject: RFR: 8327137: Add test for ConcurrentModificationException in
 BasicDirectoryModel [v3]
In-Reply-To: <6d2hOVnBZtRQHhxPoA6sHpdeIvH32SwJ0HZavVCP33E=.c6d37335-0420-467b-83aa-129abd47fd87@github.com>
References: <mCqqjrXVWDB2PvpOhKHx-Hr8W6tUz6v4stztGmyAeEg=.1f95da1c-e1a5-40be-be8b-0758729fa9b9@github.com>
 <HvJ96YzIfnTtdNh7R5XtYs_t0sc5VfHjBHUxi9uyJdI=.94715923-e3c0-4666-9a51-340ef91b8b3b@github.com>
 <V1fPYAjQ6U8TFSOTRQ-Fk9dRnFAwbimWAPUkicxtklk=.6fe019f2-a478-4e11-8c02-b606f8f14709@github.com>
 <Chb_zgl53KY05-E3fKBAF61S8SO4Bi7LMlGkART_3io=.7845c015-4fd7-4ce5-bf27-7994cbf2471a@github.com>
 <d5JjW3jU1caR7NXz_sfQ78zXMSmxqLi_ony4WorDSh8=.5122b277-8ddc-40a0-a6ec-a5ae6226246b@github.com>
 <yhqPAJ3HPjy7RrrmTSNbkPIIgnndqaNkqN4cwsJYd6A=.121a9971-5f09-4977-847a-8971d7a359e5@github.com>
 <6d2hOVnBZtRQHhxPoA6sHpdeIvH32SwJ0HZavVCP33E=.c6d37335-0420-467b-83aa-129abd47fd87@github.com>
Message-ID: <2cuoh1-d70-IvJOpVIBJbBfMh8hAg-nYZpu-Do9p8hE=.e1f841a4-04b3-4fc4-a99f-679d63e464b7@github.com>

On Fri, 22 Mar 2024 21:45:36 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>>>Instantiating JFileChooser on EDT adds complexity for no benefit. The JFileChooser is still accessed concurrently from several threads, including Swing internal thread.
>> 
>> But still, this is a common requirement to create UI components on EDT, and that will replicate more or less how it will work in the application.
>
>> > Instantiating JFileChooser on EDT adds complexity for no benefit. The JFileChooser is still accessed concurrently from several threads, including Swing internal thread.
>> 
>> But still, this is a common requirement to create UI components on EDT, and that will replicate more or less how it will work in the application.
> 
> And it is a common requirement ***not** to call `fileChooser.rescanCurrentDirectory` concurrently* in 5 different threads. So it does not apply.

In general, I agree all Swing components are to be created and accessed on EDT.

However, there are cases where instantiating and testing is safe on main thread. It is when the component is not shown on the screen, its state does not depend on any events dispatched by the event queue. There are such tests in the JDK code base.

I think this test is one of such cases where `JFileChooser` can be (safely) created on the current thread. The test does not display the file chooser, its state does not depend on receiving input events and handling them.

Essentially, the test verifies that *the implementation of `JFileChooser.rescanCurrentDirectory` is thread-safe*. It wasn't. Two bugs were resolved to make the implementation thread-safe: [JDK-8323670](https://bugs.openjdk.org/browse/JDK-8323670) and [JDK-8325179](https://bugs.openjdk.org/browse/JDK-8325179).

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18109#discussion_r1541975141

From aivanov at openjdk.org  Wed Mar 27 21:35:37 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Wed, 27 Mar 2024 21:35:37 GMT
Subject: RFR: 8320676 : Manual printer tests have no Pass/Fail buttons,
 instructions close set 1 [v13]
In-Reply-To: <aJ38KyKWM4IMANDPnfed-auiBzf7my_YDpRfDOvq9Zg=.dddf005b-9d91-415b-b139-9e9b064a7880@github.com>
References: <Afd90FypFvXYNR17jgkxcFj2LlxdLlZ1Bgd7WctdKcU=.2a8b05e0-a476-4598-8524-a22a0f54b8a5@github.com>
 <aJ38KyKWM4IMANDPnfed-auiBzf7my_YDpRfDOvq9Zg=.dddf005b-9d91-415b-b139-9e9b064a7880@github.com>
Message-ID: <xqceyIZGnPDrKSrBL5a_gzWk8cf5DeWzhwp6W14nGqI=.3f9f790a-41b9-4700-a4e1-33add584de51@github.com>

On Thu, 7 Mar 2024 09:27:10 GMT, Renjith Kannath Pariyangad <rkannathpari at openjdk.org> wrote:

>> Hi Reviewers,
>> 
>> Updated manual printer test cases with 'PassFailJFrame', also removed unused variables. Added 'SkippedException' in case of printer missing or not configured.
>> 
>> Please review and let me know your suggestions.
>> 
>> Regards,
>> Renjith
>
> Renjith Kannath Pariyangad has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Updated instructions

Changes requested by aivanov (Reviewer).

test/jdk/java/awt/print/PrinterJob/ValidatePage/ValidatePage.java line 230:

> 228:                 "left margins will be shrunk if they are too great for the adjusted \n" +
> 229:                 "imageable area to fit at that position. They will shrink by the minimum\n" +
> 230:                 "needed to accomodate the imageable area.\n \n \n" +

Suggestion:

                "needed to accommodate the imageable area.\n \n \n" +

Typo to fix.

-------------

PR Review: https://git.openjdk.org/jdk/pull/17607#pullrequestreview-1920127795
PR Review Comment: https://git.openjdk.org/jdk/pull/17607#discussion_r1542068572

From aivanov at openjdk.org  Wed Mar 27 21:35:38 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Wed, 27 Mar 2024 21:35:38 GMT
Subject: RFR: 8320676 : Manual printer tests have no Pass/Fail buttons,
 instructions close set 1 [v11]
In-Reply-To: <G_hFouVypycpSwZ-ovBR6_zxAzwlXbWFuDsgoZKXFfk=.8ac90930-10a8-4550-a564-d5533eaf6e14@github.com>
References: <Afd90FypFvXYNR17jgkxcFj2LlxdLlZ1Bgd7WctdKcU=.2a8b05e0-a476-4598-8524-a22a0f54b8a5@github.com>
 <iWutKW4UpvMw8nEhcHknq1dlyNEtmppek6JdbLUqKDU=.4fa91123-1d3a-43d6-9f9d-c3967425c164@github.com>
 <G_hFouVypycpSwZ-ovBR6_zxAzwlXbWFuDsgoZKXFfk=.8ac90930-10a8-4550-a564-d5533eaf6e14@github.com>
Message-ID: <3UK47CoJL-jIAUKc4hqCG3k1xTIMIWVvj6XLMLjJjCU=.e6c5f0cb-c2f2-42bc-9ce3-a45668294958@github.com>

On Tue, 5 Mar 2024 12:22:56 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Renjith Kannath Pariyangad has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Suggesions incorporated
>
> test/jdk/java/awt/print/PrinterJob/PrintAllFonts.java line 69:
> 
>> 67:         if (pj.printDialog()) {
>> 68:             pj.print();
>> 69:         }
> 
> Fail the test if the user clicks Cancel in the print dialog?

I still think the test should fail if the tester clicks Cancel in the print dialog.

> test/jdk/java/awt/print/PrinterJob/ValidatePage/ValidatePage.java line 233:
> 
>> 231:                 "needed to accomodate the imageable area.\n \n \n" +
>> 232:                 "To test 6229507, put the minimum margins (all 0s) in Page Setup dialog.\n" +
>> 233:                 "Compare Imageable width, height, and margins of portrait against landscape.");
> 
> Suggestion:
> 
>                 "When validating a page, the process is 1st to find the closest matching\n" +
>                 "paper size, next to make sure the requested imageable area fits within\n" +
>                 "the printer's imageable area for that paper size. Finally the top and\n" +
>                 "left margins will be shrunk if they are too great for the adjusted\n" +
>                 "imageable area to fit at that position. They will shrink by the minimum\n" +
>                 "needed to accomodate the imageable area.\n\n\n" +
>                 "To test 6229507, put the minimum margins (all 0s) in Page Setup dialog.\n" +
>                 "Compare Imageable width, height, and margins of portrait against landscape.");
> 
> The spaces at the end of lines are redundant.

Spaces at the end of the line can be removed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17607#discussion_r1542061869
PR Review Comment: https://git.openjdk.org/jdk/pull/17607#discussion_r1542066476

From aivanov at openjdk.org  Wed Mar 27 21:35:40 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Wed, 27 Mar 2024 21:35:40 GMT
Subject: RFR: 8320676 : Manual printer tests have no Pass/Fail buttons,
 instructions close set 1 [v12]
In-Reply-To: <_-LKuql5zt3ZU24gZkc_06GN7xgqbIKl2ZHSP-HAbdg=.3bcdddfb-7f8a-4d8f-9ba8-35dffb9e10ee@github.com>
References: <Afd90FypFvXYNR17jgkxcFj2LlxdLlZ1Bgd7WctdKcU=.2a8b05e0-a476-4598-8524-a22a0f54b8a5@github.com>
 <_-LKuql5zt3ZU24gZkc_06GN7xgqbIKl2ZHSP-HAbdg=.3bcdddfb-7f8a-4d8f-9ba8-35dffb9e10ee@github.com>
Message-ID: <0mVvfXteO9-Anzr6qIQdcs9Y6kW_SmUfL4dhNZ17rT8=.3dce83ee-e1f7-4891-a906-36b8a68704b5@github.com>

On Wed, 6 Mar 2024 05:08:08 GMT, Renjith Kannath Pariyangad <rkannathpari at openjdk.org> wrote:

>> Hi Reviewers,
>> 
>> Updated manual printer test cases with 'PassFailJFrame', also removed unused variables. Added 'SkippedException' in case of printer missing or not configured.
>> 
>> Please review and let me know your suggestions.
>> 
>> Regards,
>> Renjith
>
> Renjith Kannath Pariyangad has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Added Override

test/jdk/java/awt/print/PrinterJob/ValidatePage/ValidatePage.java line 90:

> 88:                             case PageFormat.REVERSE_LANDSCAPE -> "REVERSE_LANDSCAPE";
> 89:                             default -> "<invalid>";
> 90:                         }));

You still have this code twice in this file.

Create a helper method and re-use the functionality instead of having two identical copies, as [I suggested previously](https://github.com/openjdk/jdk/pull/17607#discussion_r1487928320).

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17607#discussion_r1514719472

From achung at openjdk.org  Wed Mar 27 22:07:43 2024
From: achung at openjdk.org (Alisen Chung)
Date: Wed, 27 Mar 2024 22:07:43 GMT
Subject: RFR: 8328648: Remove applet usage from JFileChooser tests
 bug4150029 [v5]
In-Reply-To: <eTiR35uGxb59RbbKcRAdTrgYkrx4CNmkIWfk63i3sJw=.8771db30-c50e-4c50-ae80-312a7683cc27@github.com>
References: <eTiR35uGxb59RbbKcRAdTrgYkrx4CNmkIWfk63i3sJw=.8771db30-c50e-4c50-ae80-312a7683cc27@github.com>
Message-ID: <QI5xCwI60xfJfmlyyMqvIH47yT-iBtFjJfbLFsoO1_s=.38484ac5-4d32-418f-9ee0-ca6f51a061f3@github.com>

> Removing applet usage from manual JFileChooser tests

Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:

  removed second pass check

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18415/files
  - new: https://git.openjdk.org/jdk/pull/18415/files/5a05f64b..eb58531e

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18415&range=04
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18415&range=03-04

  Stats: 17 lines in 1 file changed: 1 ins; 12 del; 4 mod
  Patch: https://git.openjdk.org/jdk/pull/18415.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18415/head:pull/18415

PR: https://git.openjdk.org/jdk/pull/18415

From jjg at openjdk.org  Wed Mar 27 22:08:57 2024
From: jjg at openjdk.org (Jonathan Gibbons)
Date: Wed, 27 Mar 2024 22:08:57 GMT
Subject: RFR: JDK-8303689: javac -Xlint could/should report on "dangling" doc
 comments
Message-ID: <T_hVB24wAdfq2M4bC_BxfHPjdB_-uF6w3QyRvcgW7vQ=.309824a7-d67c-4619-9862-017fae5521d4@github.com>

Please review the updates to support a proposed new `-Xlint:dangling-doc-comments` option.

The work can be thought of as in 3 parts:

1. An update to the `javac` internal class `DeferredLintHandler` so that it is possible to specify the appropriately configured `Lint` object when it is time to consider whether to generate the diagnostic or not.

2. Updates to the `javac` front end to record "dangling docs comments" found near the beginning of a declaration, and to report them using an instance of `DeferredLintHandler`. This allows the warnings to be enabled or disabled using the standard mechanisms for `-Xlint` and `@SuppressWarnings`.  The procedure for handling dangling doc comments is described in this comment in `JavacParser`.

     *  Dangling documentation comments are handled as follows.
     *  1. {@code Scanner} adds all doc comments to a queue of
     *     recent doc comments. The queue is flushed whenever
     *     it is known that the recent doc comments should be
     *     ignored and should not cause any warnings.
     *  2. The primary documentation comment is the one obtained
     *     from the first token of any declaration.
     *     (using {@code token.getDocComment()}.
     *  3. At the end of the "signature" of the declaration
     *     (that is, before any initialization or body for the
     *     declaration) any other "recent" comments are saved
     *     in a map using the primary comment as a key,
     *     using this method, {@code saveDanglingComments}.
     *  4. When the tree node for the declaration is finally
     *     available, and the primary comment, if any,
     *     is "attached", (in {@link #attach}) any related
     *     dangling comments are also attached to the tree node
     *     by registering them using the {@link #deferredLintHandler}.
     *  5. (Later) Warnings may be genereated for the dangling
     *     comments, subject to the {@code -Xlint} and
     *     {@code @SuppressWarnings}.


3.  Updates to the make files to disable the warnings in modules for which the 
warning is generated.  This is often because of the confusing use of `/**` to
create box or other standout comments.

-------------

Commit messages:
 - JDK-8303689: javac -Xlint could/should report on "dangling" doc comments

Changes: https://git.openjdk.org/jdk/pull/18527/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18527&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8303689
  Stats: 477 lines in 60 files changed: 368 ins; 5 del; 104 mod
  Patch: https://git.openjdk.org/jdk/pull/18527.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18527/head:pull/18527

PR: https://git.openjdk.org/jdk/pull/18527

From prappo at openjdk.org  Wed Mar 27 22:44:31 2024
From: prappo at openjdk.org (Pavel Rappo)
Date: Wed, 27 Mar 2024 22:44:31 GMT
Subject: RFR: JDK-8303689: javac -Xlint could/should report on "dangling"
 doc comments
In-Reply-To: <T_hVB24wAdfq2M4bC_BxfHPjdB_-uF6w3QyRvcgW7vQ=.309824a7-d67c-4619-9862-017fae5521d4@github.com>
References: <T_hVB24wAdfq2M4bC_BxfHPjdB_-uF6w3QyRvcgW7vQ=.309824a7-d67c-4619-9862-017fae5521d4@github.com>
Message-ID: <7vkdZb7QDt106_k7_i7PrYzCYuEwTT-P2l4VxDOrNQk=.e98a3d16-8be0-4194-acd5-94eff555adce@github.com>

On Wed, 27 Mar 2024 22:04:30 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> Please review the updates to support a proposed new `-Xlint:dangling-doc-comments` option.
> 
> The work can be thought of as in 3 parts:
> 
> 1. An update to the `javac` internal class `DeferredLintHandler` so that it is possible to specify the appropriately configured `Lint` object when it is time to consider whether to generate the diagnostic or not.
> 
> 2. Updates to the `javac` front end to record "dangling docs comments" found near the beginning of a declaration, and to report them using an instance of `DeferredLintHandler`. This allows the warnings to be enabled or disabled using the standard mechanisms for `-Xlint` and `@SuppressWarnings`.  The procedure for handling dangling doc comments is described in this comment in `JavacParser`.
> 
>      *  Dangling documentation comments are handled as follows.
>      *  1. {@code Scanner} adds all doc comments to a queue of
>      *     recent doc comments. The queue is flushed whenever
>      *     it is known that the recent doc comments should be
>      *     ignored and should not cause any warnings.
>      *  2. The primary documentation comment is the one obtained
>      *     from the first token of any declaration.
>      *     (using {@code token.getDocComment()}.
>      *  3. At the end of the "signature" of the declaration
>      *     (that is, before any initialization or body for the
>      *     declaration) any other "recent" comments are saved
>      *     in a map using the primary comment as a key,
>      *     using this method, {@code saveDanglingComments}.
>      *  4. When the tree node for the declaration is finally
>      *     available, and the primary comment, if any,
>      *     is "attached", (in {@link #attach}) any related
>      *     dangling comments are also attached to the tree node
>      *     by registering them using the {@link #deferredLintHandler}.
>      *  5. (Later) Warnings may be genereated for the dangling
>      *     comments, subject to the {@code -Xlint} and
>      *     {@code @SuppressWarnings}.
> 
> 
> 3.  Updates to the make files to disable the warnings in modules for which the 
> warning is generated.  This is often because of the confusing use of `/**` to
> create box or other standout comments.

Would this be the first lint -- not doclint -- warning related to comments, let alone doc comments?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18527#issuecomment-2024106466

From prappo at openjdk.org  Wed Mar 27 22:55:32 2024
From: prappo at openjdk.org (Pavel Rappo)
Date: Wed, 27 Mar 2024 22:55:32 GMT
Subject: RFR: JDK-8303689: javac -Xlint could/should report on "dangling"
 doc comments
In-Reply-To: <T_hVB24wAdfq2M4bC_BxfHPjdB_-uF6w3QyRvcgW7vQ=.309824a7-d67c-4619-9862-017fae5521d4@github.com>
References: <T_hVB24wAdfq2M4bC_BxfHPjdB_-uF6w3QyRvcgW7vQ=.309824a7-d67c-4619-9862-017fae5521d4@github.com>
Message-ID: <WsC10GQD9Q9xTXY9eY2_v5C91f8J5WKuRlRwmP4jElw=.b13568b0-44c3-470e-a8e4-aa27833ecd28@github.com>

On Wed, 27 Mar 2024 22:04:30 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> Please review the updates to support a proposed new `-Xlint:dangling-doc-comments` option.
> 
> The work can be thought of as in 3 parts:
> 
> 1. An update to the `javac` internal class `DeferredLintHandler` so that it is possible to specify the appropriately configured `Lint` object when it is time to consider whether to generate the diagnostic or not.
> 
> 2. Updates to the `javac` front end to record "dangling docs comments" found near the beginning of a declaration, and to report them using an instance of `DeferredLintHandler`. This allows the warnings to be enabled or disabled using the standard mechanisms for `-Xlint` and `@SuppressWarnings`.  The procedure for handling dangling doc comments is described in this comment in `JavacParser`.
> 
>      *  Dangling documentation comments are handled as follows.
>      *  1. {@code Scanner} adds all doc comments to a queue of
>      *     recent doc comments. The queue is flushed whenever
>      *     it is known that the recent doc comments should be
>      *     ignored and should not cause any warnings.
>      *  2. The primary documentation comment is the one obtained
>      *     from the first token of any declaration.
>      *     (using {@code token.getDocComment()}.
>      *  3. At the end of the "signature" of the declaration
>      *     (that is, before any initialization or body for the
>      *     declaration) any other "recent" comments are saved
>      *     in a map using the primary comment as a key,
>      *     using this method, {@code saveDanglingComments}.
>      *  4. When the tree node for the declaration is finally
>      *     available, and the primary comment, if any,
>      *     is "attached", (in {@link #attach}) any related
>      *     dangling comments are also attached to the tree node
>      *     by registering them using the {@link #deferredLintHandler}.
>      *  5. (Later) Warnings may be genereated for the dangling
>      *     comments, subject to the {@code -Xlint} and
>      *     {@code @SuppressWarnings}.
> 
> 
> 3.  Updates to the make files to disable the warnings in modules for which the 
> warning is generated.  This is often because of the confusing use of `/**` to
> create box or other standout comments.

Javadoc changes look trivially good. I only note that the javadoc man page diff contains some unrelated changes.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18527#issuecomment-2024116236

From prappo at openjdk.org  Wed Mar 27 22:59:34 2024
From: prappo at openjdk.org (Pavel Rappo)
Date: Wed, 27 Mar 2024 22:59:34 GMT
Subject: RFR: JDK-8303689: javac -Xlint could/should report on "dangling"
 doc comments
In-Reply-To: <T_hVB24wAdfq2M4bC_BxfHPjdB_-uF6w3QyRvcgW7vQ=.309824a7-d67c-4619-9862-017fae5521d4@github.com>
References: <T_hVB24wAdfq2M4bC_BxfHPjdB_-uF6w3QyRvcgW7vQ=.309824a7-d67c-4619-9862-017fae5521d4@github.com>
Message-ID: <CR1gXDa9g51mJiCtmPnP6-P-eT_71xIppMf2ND8axQ0=.bc1e2507-9973-498a-b6c4-159732c2e406@github.com>

On Wed, 27 Mar 2024 22:04:30 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> Please review the updates to support a proposed new `-Xlint:dangling-doc-comments` option.
> 
> The work can be thought of as in 3 parts:
> 
> 1. An update to the `javac` internal class `DeferredLintHandler` so that it is possible to specify the appropriately configured `Lint` object when it is time to consider whether to generate the diagnostic or not.
> 
> 2. Updates to the `javac` front end to record "dangling docs comments" found near the beginning of a declaration, and to report them using an instance of `DeferredLintHandler`. This allows the warnings to be enabled or disabled using the standard mechanisms for `-Xlint` and `@SuppressWarnings`.  The procedure for handling dangling doc comments is described in this comment in `JavacParser`.
> 
>      *  Dangling documentation comments are handled as follows.
>      *  1. {@code Scanner} adds all doc comments to a queue of
>      *     recent doc comments. The queue is flushed whenever
>      *     it is known that the recent doc comments should be
>      *     ignored and should not cause any warnings.
>      *  2. The primary documentation comment is the one obtained
>      *     from the first token of any declaration.
>      *     (using {@code token.getDocComment()}.
>      *  3. At the end of the "signature" of the declaration
>      *     (that is, before any initialization or body for the
>      *     declaration) any other "recent" comments are saved
>      *     in a map using the primary comment as a key,
>      *     using this method, {@code saveDanglingComments}.
>      *  4. When the tree node for the declaration is finally
>      *     available, and the primary comment, if any,
>      *     is "attached", (in {@link #attach}) any related
>      *     dangling comments are also attached to the tree node
>      *     by registering them using the {@link #deferredLintHandler}.
>      *  5. (Later) Warnings may be genereated for the dangling
>      *     comments, subject to the {@code -Xlint} and
>      *     {@code @SuppressWarnings}.
> 
> 
> 3.  Updates to the make files to disable the warnings in modules for which the 
> warning is generated.  This is often because of the confusing use of `/**` to
> create box or other standout comments.

src/jdk.javadoc/share/man/javadoc.1 line 111:

> 109: source code with the \f[V]javac\f[R] option \f[V]-Xlint\f[R], or more
> 110: specifically, \f[V]-Xlint:dangling-doc-comments\f[R].
> 111: Within a source file, you may use suppress any warnings generated by

Typo?
Suggestion:

Within a source file, you may suppress any warnings generated by

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18527#discussion_r1542131487

From achung at openjdk.org  Wed Mar 27 23:30:31 2024
From: achung at openjdk.org (Alisen Chung)
Date: Wed, 27 Mar 2024 23:30:31 GMT
Subject: RFR: 8328403: Remove applet usage from JColorChooser tests
 Test6977726 [v4]
In-Reply-To: <EetnMFyJQMV-MWVg6HHO-7O3SLOaQT1-uqUhq97rDC8=.d4628194-c548-45f4-a08c-c1240d8b54f9@github.com>
References: <pyfxVdApSNSisMJieBTl5HSZKDmSSiPie0tnrM_rwe4=.5ffc4e92-cbcf-44d8-9a51-b4e8330e1be9@github.com>
 <OHP8ZTnhmiucg-AWktAt_UNDyMBHYSVzfm5GQz1UjTs=.7fb3ea7f-e845-455f-9609-65715316f381@github.com>
 <EetnMFyJQMV-MWVg6HHO-7O3SLOaQT1-uqUhq97rDC8=.d4628194-c548-45f4-a08c-c1240d8b54f9@github.com>
Message-ID: <FY3tLmhDUC2Gg3vWJFIgrrkspMtAKbmEVjM0iy4Lh2A=.8b89cc77-a9e2-4f71-8116-9f7bd1658a74@github.com>

On Tue, 26 Mar 2024 21:16:39 GMT, Phil Race <prr at openjdk.org> wrote:

> are you going to reduce the timeout as Alexander suggested ?

I've lowered the timeout to 2 minutes

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18369#issuecomment-2024149068

From jjg at openjdk.org  Wed Mar 27 23:47:32 2024
From: jjg at openjdk.org (Jonathan Gibbons)
Date: Wed, 27 Mar 2024 23:47:32 GMT
Subject: RFR: JDK-8303689: javac -Xlint could/should report on "dangling"
 doc comments
In-Reply-To: <7vkdZb7QDt106_k7_i7PrYzCYuEwTT-P2l4VxDOrNQk=.e98a3d16-8be0-4194-acd5-94eff555adce@github.com>
References: <T_hVB24wAdfq2M4bC_BxfHPjdB_-uF6w3QyRvcgW7vQ=.309824a7-d67c-4619-9862-017fae5521d4@github.com>
 <7vkdZb7QDt106_k7_i7PrYzCYuEwTT-P2l4VxDOrNQk=.e98a3d16-8be0-4194-acd5-94eff555adce@github.com>
Message-ID: <VBk0641TIJuEE_Ez3MN1g9kd8v7zpjiBY4wdBvzaQP8=.9e11bd0d-14e8-4c9f-ac2c-72d0b77daeae@github.com>

On Wed, 27 Mar 2024 22:41:33 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

> Would this be the first lint -- not doclint -- warning related to comments, let alone doc comments?

No. `-Xlint:dep-ann` correlates `@Deprecated` annotations with `@deprecated` tags in doc comments.

> src/jdk.javadoc/share/man/javadoc.1 line 111:
> 
>> 109: source code with the \f[V]javac\f[R] option \f[V]-Xlint\f[R], or more
>> 110: specifically, \f[V]-Xlint:dangling-doc-comments\f[R].
>> 111: Within a source file, you may use suppress any warnings generated by
> 
> Typo?
> Suggestion:
> 
> Within a source file, you may suppress any warnings generated by

Thanks; I'll check the underlying original.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18527#issuecomment-2024162355
PR Review Comment: https://git.openjdk.org/jdk/pull/18527#discussion_r1542157047

From honkar at openjdk.org  Thu Mar 28 00:23:32 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Thu, 28 Mar 2024 00:23:32 GMT
Subject: RFR: 8328403: Remove applet usage from JColorChooser tests
 Test6977726 [v5]
In-Reply-To: <N6gGAXCbcyyX3OTA-rlnzBrztMU11SwU0Lq_ufhajlo=.fe964556-b0f7-4fb9-a989-164182993fef@github.com>
References: <pyfxVdApSNSisMJieBTl5HSZKDmSSiPie0tnrM_rwe4=.5ffc4e92-cbcf-44d8-9a51-b4e8330e1be9@github.com>
 <N6gGAXCbcyyX3OTA-rlnzBrztMU11SwU0Lq_ufhajlo=.fe964556-b0f7-4fb9-a989-164182993fef@github.com>
Message-ID: <fSwtkbg9Pwo-ferz4w4QZ9JSZk1H2prcfokJZDKJWFc=.1c553e2a-a08a-487f-b65a-0f1bb90516fc@github.com>

On Tue, 26 Mar 2024 22:29:32 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> Removing applet usage from manual JColorChooser tests
>
> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   instruction string change

Changes requested by honkar (Reviewer).

test/jdk/javax/swing/JColorChooser/Test6977726.java line 51:

> 49:                 .columns(40)
> 50:                 .testTimeOut(2)
> 51:                 .splitUIRight(Test6977726::createColorChooser)

To avoid the empty white space in instruction panel, we could use .testUI() instead of .splitUI()
Suggestion:

                .testUI(Test6977726::createColorChooser)

test/jdk/javax/swing/JColorChooser/Test6977726.java line 57:

> 55: 
> 56:     private static JColorChooser createColorChooser() {
> 57:         JColorChooser chooser = new JColorChooser();

It is easy to miss the white colored text in Preview Panel. Can we change the default color to blue?

Suggestion:

        JColorChooser chooser = new JColorChooser(Color.BLUE);

-------------

PR Review: https://git.openjdk.org/jdk/pull/18369#pullrequestreview-1964958564
PR Review Comment: https://git.openjdk.org/jdk/pull/18369#discussion_r1542174702
PR Review Comment: https://git.openjdk.org/jdk/pull/18369#discussion_r1542174312

From honkar at openjdk.org  Thu Mar 28 01:09:37 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Thu, 28 Mar 2024 01:09:37 GMT
Subject: RFR: 8328482: Convert and Open source few manual applet test to
 main based [v3]
In-Reply-To: <Pi6RvL9Fn2ID3Biiiw3BSJF6kCmnMb2jRJlQgK4jVoQ=.c768550e-5e11-40ee-aa74-2f6afc486d8a@github.com>
References: <aV9yYWUEsrakxmujJCq2LzFg5K6nyCV4aELge8c1oJo=.c9f2c13d-337f-4af3-8a38-551a7f0ba0c6@github.com>
 <Pi6RvL9Fn2ID3Biiiw3BSJF6kCmnMb2jRJlQgK4jVoQ=.c768550e-5e11-40ee-aa74-2f6afc486d8a@github.com>
Message-ID: <Ak10nmNRlpO0gf9zcJv3x8WyE6gVg0uSgm972L03vq8=.8323a652-b76a-4449-aa3a-ec57fb3454ca@github.com>

On Sun, 24 Mar 2024 12:21:52 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Convert and open source these manual applet test to main based:
>> java/awt/Frame/MegaIconTest/MegaIconTest.html
>> java/awt/Frame/FrameMaximizedTest/FrameMaximizedTest.html
>> java/awt/Frame/FrameMinimizeTest/FrameMinimizeTest.html
>> java/awt/Frame/SizeMinimizedTest/SizeMinimizedTest.html
>
> Tejesh R has updated the pull request incrementally with three additional commits since the last revision:
> 
>  - Images updated
>  - Frame position updates
>  - removed headful tag

test/jdk/java/awt/Frame/FrameMaximizedTest.java line 37:

> 35: 
> 36: public class FrameMaximizedTest {
> 37:     public static void main (String args[]) throws Exception {

Java style array declaration
Suggestion:

    public static void main (String[] args) throws Exception {

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18448#discussion_r1540224863

From honkar at openjdk.org  Thu Mar 28 01:09:38 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Thu, 28 Mar 2024 01:09:38 GMT
Subject: RFR: 8328482: Convert and Open source few manual applet test to
 main based [v4]
In-Reply-To: <TYJFZwPv2tFlCYmwFMZfO11wsxCY8WNPHuvu4urAtzM=.0ff7923d-aacb-4705-9e68-d2d029c257ad@github.com>
References: <aV9yYWUEsrakxmujJCq2LzFg5K6nyCV4aELge8c1oJo=.c9f2c13d-337f-4af3-8a38-551a7f0ba0c6@github.com>
 <TYJFZwPv2tFlCYmwFMZfO11wsxCY8WNPHuvu4urAtzM=.0ff7923d-aacb-4705-9e68-d2d029c257ad@github.com>
Message-ID: <99VWs9cjjiPHXJVMObjSUtLzxRdD_BuTJPIGGINjoSo=.bdb21b8f-bbe0-46bd-a447-45bff718f5b0@github.com>

On Wed, 27 Mar 2024 03:33:57 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Convert and open source these manual applet test to main based:
>> java/awt/Frame/MegaIconTest/MegaIconTest.html
>> java/awt/Frame/FrameMaximizedTest/FrameMaximizedTest.html
>> java/awt/Frame/FrameMinimizeTest/FrameMinimizeTest.html
>> java/awt/Frame/SizeMinimizedTest/SizeMinimizedTest.html
>
> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fight.gif added

test/jdk/java/awt/Frame/FrameMinimizeTest.java line 36:

> 34: 
> 35: public class FrameMinimizeTest {
> 36:     public static void main(String args[]) throws Exception {

Java style arrays

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18448#discussion_r1542195533

From honkar at openjdk.org  Thu Mar 28 01:16:33 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Thu, 28 Mar 2024 01:16:33 GMT
Subject: RFR: 8328482: Convert and Open source few manual applet test to
 main based [v4]
In-Reply-To: <TYJFZwPv2tFlCYmwFMZfO11wsxCY8WNPHuvu4urAtzM=.0ff7923d-aacb-4705-9e68-d2d029c257ad@github.com>
References: <aV9yYWUEsrakxmujJCq2LzFg5K6nyCV4aELge8c1oJo=.c9f2c13d-337f-4af3-8a38-551a7f0ba0c6@github.com>
 <TYJFZwPv2tFlCYmwFMZfO11wsxCY8WNPHuvu4urAtzM=.0ff7923d-aacb-4705-9e68-d2d029c257ad@github.com>
Message-ID: <0Htkl8Q6MhsOuA45UqDLQKDcWLFCPM977ciPkiYFOX4=.25125ab9-1d8b-4148-a056-aca4d13827c6@github.com>

On Wed, 27 Mar 2024 03:33:57 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Convert and open source these manual applet test to main based:
>> java/awt/Frame/MegaIconTest/MegaIconTest.html
>> java/awt/Frame/FrameMaximizedTest/FrameMaximizedTest.html
>> java/awt/Frame/FrameMinimizeTest/FrameMinimizeTest.html
>> java/awt/Frame/SizeMinimizedTest/SizeMinimizedTest.html
>
> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fight.gif added

test/jdk/java/awt/Frame/SizeMinimizedTest.java line 48:

> 46:                         continuously be logged, so you can verify its changes)
> 47:                         1. When the test starts, two frame windows will appear.
> 48:                         Note the size of frame2.

Window listeners can be used to check the initial and subsequent frame size and positions. This avoids asking the user to keep note of these details.

It could be potentially be automated at this point, if it doesn't require much effort.



frame2.addWindowListener(new WindowAdapter() {
            @Override
            public void windowOpened(WindowEvent e) {
                PassFailJFrame.log("Initial Frame Size: " + frame2.getSize());
                PassFailJFrame.log("Initial Frame Location: " + frame2.getLocationOnScreen());
            }
        });
frame2.addWindowStateListener(new WindowAdapter() {
          @Override
          public void windowStateChanged(WindowEvent e) {
              if (e.getNewState() == Frame.NORMAL) {
                  PassFailJFrame.log("Frame Size: " + frame2.getSize());
                  PassFailJFrame.log("Frame Location: " + frame2.getLocationOnScreen());
              }
          }
 });

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18448#discussion_r1542198112

From jwaters at openjdk.org  Thu Mar 28 07:36:04 2024
From: jwaters at openjdk.org (Julian Waters)
Date: Thu, 28 Mar 2024 07:36:04 GMT
Subject: RFR: 8307160: Fix AWT/2D/A11Y to support the permissive- flag on
 the Microsoft Visual C compiler [v70]
In-Reply-To: <7piLRto5nNbhYYYfENCr5ecm4M2xNtMkjkE8XhrLLQ0=.8fd1ac3a-46f8-47a8-ae37-a4abbf7757d9@github.com>
References: <7piLRto5nNbhYYYfENCr5ecm4M2xNtMkjkE8XhrLLQ0=.8fd1ac3a-46f8-47a8-ae37-a4abbf7757d9@github.com>
Message-ID: <cTyQaRQOOMA9mB8MJm2Q6IQP87QVVDJ9qvNkFX054wQ=.a555e405-571c-4490-8831-963341165a76@github.com>

> We should set the -permissive- flag for the Microsoft Visual C compiler, as was requested by the now backed out [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). Doing so makes the Visual C compiler much less accepting of ill formed code, which will improve code quality on Windows in the future.

Julian Waters has updated the pull request incrementally with four additional commits since the last revision:

 - Labels to empty line in awt_Window.cpp
 - Labels to empty line in awt_Window.cpp
 - Label to empty line in awt_Window.cpp
 - Label to empty line in awt_Window.cpp

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/15096/files
  - new: https://git.openjdk.org/jdk/pull/15096/files/ee0297a6..04e3cce1

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=15096&range=69
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=15096&range=68-69

  Stats: 7 lines in 1 file changed: 7 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/15096.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/15096/head:pull/15096

PR: https://git.openjdk.org/jdk/pull/15096

From duke at openjdk.org  Thu Mar 28 08:33:52 2024
From: duke at openjdk.org (rjolly)
Date: Thu, 28 Mar 2024 08:33:52 GMT
Subject: RFR: 8328953 : JEditorPane.read throws ChangedCharSetException
 [v8]
In-Reply-To: <j32PTT_v706cIsLg9ssxPivpEJoo5bCJ1H5NHj3KDhY=.b9e439f3-ce7a-4d63-bfe4-bd415a34a2d2@github.com>
References: <j32PTT_v706cIsLg9ssxPivpEJoo5bCJ1H5NHj3KDhY=.b9e439f3-ce7a-4d63-bfe4-bd415a34a2d2@github.com>
Message-ID: <RNjgXZJj7hnRHrdOk2u9O7Vr9nqxi138qe6YJvo93SU=.ad3a873f-800d-41c4-97ee-4410b004ad10@github.com>

> ChangedCharSetException is used to amend the charset during read according to html directives. Currently it causes immediate exit of the method which in turn causes failure to load html documents with charset directives (even if the latter must not change after all). This PR restores the catch operation as it was before the use of try with resources.

rjolly has updated the pull request incrementally with one additional commit since the last revision:

  8328953 : JEditorPane.read throws ChangedCharSetException
  
  The fix is to add a nested `try`-block inside `try-with-resource`; all the exceptions are handled in the nested `try`; the outer `try`-with-resouces only closes the input stream.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/17567/files
  - new: https://git.openjdk.org/jdk/pull/17567/files/d13fcc6d..69e5dedc

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=17567&range=07
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17567&range=06-07

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/17567.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17567/head:pull/17567

PR: https://git.openjdk.org/jdk/pull/17567

From aivanov at openjdk.org  Thu Mar 28 12:56:34 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Thu, 28 Mar 2024 12:56:34 GMT
Subject: RFR: 8328953 : JEditorPane.read throws ChangedCharSetException
 [v8]
In-Reply-To: <RNjgXZJj7hnRHrdOk2u9O7Vr9nqxi138qe6YJvo93SU=.ad3a873f-800d-41c4-97ee-4410b004ad10@github.com>
References: <j32PTT_v706cIsLg9ssxPivpEJoo5bCJ1H5NHj3KDhY=.b9e439f3-ce7a-4d63-bfe4-bd415a34a2d2@github.com>
 <RNjgXZJj7hnRHrdOk2u9O7Vr9nqxi138qe6YJvo93SU=.ad3a873f-800d-41c4-97ee-4410b004ad10@github.com>
Message-ID: <C6mjvrVN3f1znuQmguCLRGCVoYRt5lnbkz01yJ2tqFM=.6a485955-1b48-4834-bf1d-377c8907a85b@github.com>

On Thu, 28 Mar 2024 08:33:52 GMT, rjolly <duke at openjdk.org> wrote:

>> ChangedCharSetException is used to amend the charset during read according to html directives. Currently it causes immediate exit of the method which in turn causes failure to load html documents with charset directives (even if the latter must not change after all). This PR restores the catch operation as it was before the use of try with resources.
>
> rjolly has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8328953 : JEditorPane.read throws ChangedCharSetException
>   
>   The fix is to add a nested `try`-block inside `try-with-resource`; all the exceptions are handled in the nested `try`; the outer `try`-with-resouces only closes the input stream.

The tests are green now.

Thank you for your contribution.

-------------

Marked as reviewed by aivanov (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17567#pullrequestreview-1966131189

From abhiscxk at openjdk.org  Thu Mar 28 15:42:32 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Thu, 28 Mar 2024 15:42:32 GMT
Subject: RFR: JDK-8328753 : Open source few Undecorated Frame tests [v2]
In-Reply-To: <KBCwA1lSI3j1IgH_Mc72T8vLYxJIaTs8JjsMLsdY2sY=.52705506-3af7-4988-94fa-5271398f1932@github.com>
References: <TeT19qrHb_dsgafsfZDNyiaXEYdeOEgjJ17O6us2PTo=.228b6b55-64b4-40b4-945a-e3c25a14a393@github.com>
 <KBCwA1lSI3j1IgH_Mc72T8vLYxJIaTs8JjsMLsdY2sY=.52705506-3af7-4988-94fa-5271398f1932@github.com>
Message-ID: <FmYmbySq4eBryH1GAZnvLznqB35Q7Hbd5h3wCmV0ukM=.ecb0ad9d-d66a-4993-ad06-e89203f59832@github.com>

On Wed, 27 Mar 2024 18:20:59 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Following tests are converted to main and open-sourced:
>> 
>> - /java/awt/Frame/FrameDialogMixedTest.java- Converted to main/manual using PassFailJFrame.
>> - /java/awt/Frame/MaximizeUndecoratedTest.java - Automated
>> - /java/awt/Frame/MinimizeUndecoratedTest.java - Automated
>
> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   spacing

LGTM.

-------------

Marked as reviewed by abhiscxk (Committer).

PR Review: https://git.openjdk.org/jdk/pull/18523#pullrequestreview-1966573209

From prr at openjdk.org  Thu Mar 28 16:02:31 2024
From: prr at openjdk.org (Phil Race)
Date: Thu, 28 Mar 2024 16:02:31 GMT
Subject: RFR: 8329210: Delete Redundant Printer Dialog Modality Test
In-Reply-To: <oJS3Kg1Y6D_0Nb74CjRoKvRW7uwh8hziF5PVlXXiVu4=.a683bdcf-2dc0-4602-8545-3cbd13daf744@github.com>
References: <oJS3Kg1Y6D_0Nb74CjRoKvRW7uwh8hziF5PVlXXiVu4=.a683bdcf-2dc0-4602-8545-3cbd13daf744@github.com>
Message-ID: <tNCfGF3wCOEjZxeb6rYFmsa1Vl7f5Yi2_4wP_giFbvM=.7eb23e36-8384-420e-8755-b313b9f5d4c0@github.com>

On Wed, 27 Mar 2024 18:39:35 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

> test/jdk/java/awt/print/Dialog/PrintModalDialog.java is too similar in functionality to test/jdk/java/awt/print/PrinterJob/PrinterDialogsModalityTest.java.
> 
> One test was originally for modality in web browsers, while the other was for modality in Windows OS printer dialogs, but after the updates, they both check for modality on print and page dialogs for all OSs.
> 
> Since PrinterDialogsModalityTest.java is the preferred test, this is to remove PrintModalDialog.java as a test. In addition, the bugID in the jtreg tags from PrintModalDialog.java will be added to PrinterDialogsModalityTest.java's tags to maintain a link to its original bug.

Marked as reviewed by prr (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18524#pullrequestreview-1966620085

From dnguyen at openjdk.org  Thu Mar 28 16:16:36 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Thu, 28 Mar 2024 16:16:36 GMT
Subject: Integrated: 8329210: Delete Redundant Printer Dialog Modality Test
In-Reply-To: <oJS3Kg1Y6D_0Nb74CjRoKvRW7uwh8hziF5PVlXXiVu4=.a683bdcf-2dc0-4602-8545-3cbd13daf744@github.com>
References: <oJS3Kg1Y6D_0Nb74CjRoKvRW7uwh8hziF5PVlXXiVu4=.a683bdcf-2dc0-4602-8545-3cbd13daf744@github.com>
Message-ID: <fx3PwxEyYEvfBcfL_plDp7f5hb7QqnGXhHkisTFgbCg=.a36333ca-58ce-4b21-bcb1-3e20afff55e6@github.com>

On Wed, 27 Mar 2024 18:39:35 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

> test/jdk/java/awt/print/Dialog/PrintModalDialog.java is too similar in functionality to test/jdk/java/awt/print/PrinterJob/PrinterDialogsModalityTest.java.
> 
> One test was originally for modality in web browsers, while the other was for modality in Windows OS printer dialogs, but after the updates, they both check for modality on print and page dialogs for all OSs.
> 
> Since PrinterDialogsModalityTest.java is the preferred test, this is to remove PrintModalDialog.java as a test. In addition, the bugID in the jtreg tags from PrintModalDialog.java will be added to PrinterDialogsModalityTest.java's tags to maintain a link to its original bug.

This pull request has now been integrated.

Changeset: 7ac2f914
Author:    Damon Nguyen <dnguyen at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/7ac2f914aadf7fb12b7258e54efae959e15d6721
Stats:     128 lines in 2 files changed: 0 ins; 127 del; 1 mod

8329210: Delete Redundant Printer Dialog Modality Test

Reviewed-by: honkar, prr

-------------

PR: https://git.openjdk.org/jdk/pull/18524

From serb at openjdk.org  Fri Mar 29 02:03:32 2024
From: serb at openjdk.org (Sergey Bylokhov)
Date: Fri, 29 Mar 2024 02:03:32 GMT
Subject: RFR: 8327137: Add test for ConcurrentModificationException in
 BasicDirectoryModel [v3]
In-Reply-To: <2cuoh1-d70-IvJOpVIBJbBfMh8hAg-nYZpu-Do9p8hE=.e1f841a4-04b3-4fc4-a99f-679d63e464b7@github.com>
References: <mCqqjrXVWDB2PvpOhKHx-Hr8W6tUz6v4stztGmyAeEg=.1f95da1c-e1a5-40be-be8b-0758729fa9b9@github.com>
 <HvJ96YzIfnTtdNh7R5XtYs_t0sc5VfHjBHUxi9uyJdI=.94715923-e3c0-4666-9a51-340ef91b8b3b@github.com>
 <V1fPYAjQ6U8TFSOTRQ-Fk9dRnFAwbimWAPUkicxtklk=.6fe019f2-a478-4e11-8c02-b606f8f14709@github.com>
 <Chb_zgl53KY05-E3fKBAF61S8SO4Bi7LMlGkART_3io=.7845c015-4fd7-4ce5-bf27-7994cbf2471a@github.com>
 <d5JjW3jU1caR7NXz_sfQ78zXMSmxqLi_ony4WorDSh8=.5122b277-8ddc-40a0-a6ec-a5ae6226246b@github.com>
 <yhqPAJ3HPjy7RrrmTSNbkPIIgnndqaNkqN4cwsJYd6A=.121a9971-5f09-4977-847a-8971d7a359e5@github.com>
 <6d2hOVnBZtRQHhxPoA6sHpdeIvH32SwJ0HZavVCP33E=.c6d37335-0420-467b-83aa-129abd47fd87@github.com>
 <2cuoh1-d70-IvJOpVIBJbBfMh8hAg-nYZpu-Do9p8hE=.e1f841a4-04b3-4fc4-a99f-679d63e464b7@github.com>
Message-ID: <Eadgxsc2VSQ7iIurWWF2zIJQhkZTjUckpuHz5QRNDDE=.05f61803-966a-421f-afe2-3ecd3ef00d34@github.com>

On Wed, 27 Mar 2024 20:19:41 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> However, there are cases where instantiating and testing is safe on main thread.

That is my point, make it less safe - when the component is created on one thread:EDT and then for some reason accessed on a different thread, the rescanCurrentDirectory should still work.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18109#discussion_r1543954407

From vromero at openjdk.org  Fri Mar 29 03:07:32 2024
From: vromero at openjdk.org (Vicente Romero)
Date: Fri, 29 Mar 2024 03:07:32 GMT
Subject: RFR: JDK-8303689: javac -Xlint could/should report on "dangling"
 doc comments
In-Reply-To: <T_hVB24wAdfq2M4bC_BxfHPjdB_-uF6w3QyRvcgW7vQ=.309824a7-d67c-4619-9862-017fae5521d4@github.com>
References: <T_hVB24wAdfq2M4bC_BxfHPjdB_-uF6w3QyRvcgW7vQ=.309824a7-d67c-4619-9862-017fae5521d4@github.com>
Message-ID: <GAZpxf-ZJzNHTZxqSFBUfMxBextCyxBNuNrINXTddyw=.8d42905b-1d96-49d8-992b-8edd48ae8a9b@github.com>

On Wed, 27 Mar 2024 22:04:30 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> Please review the updates to support a proposed new `-Xlint:dangling-doc-comments` option.
> 
> The work can be thought of as in 3 parts:
> 
> 1. An update to the `javac` internal class `DeferredLintHandler` so that it is possible to specify the appropriately configured `Lint` object when it is time to consider whether to generate the diagnostic or not.
> 
> 2. Updates to the `javac` front end to record "dangling docs comments" found near the beginning of a declaration, and to report them using an instance of `DeferredLintHandler`. This allows the warnings to be enabled or disabled using the standard mechanisms for `-Xlint` and `@SuppressWarnings`.  The procedure for handling dangling doc comments is described in this comment in `JavacParser`.
> 
>      *  Dangling documentation comments are handled as follows.
>      *  1. {@code Scanner} adds all doc comments to a queue of
>      *     recent doc comments. The queue is flushed whenever
>      *     it is known that the recent doc comments should be
>      *     ignored and should not cause any warnings.
>      *  2. The primary documentation comment is the one obtained
>      *     from the first token of any declaration.
>      *     (using {@code token.getDocComment()}.
>      *  3. At the end of the "signature" of the declaration
>      *     (that is, before any initialization or body for the
>      *     declaration) any other "recent" comments are saved
>      *     in a map using the primary comment as a key,
>      *     using this method, {@code saveDanglingComments}.
>      *  4. When the tree node for the declaration is finally
>      *     available, and the primary comment, if any,
>      *     is "attached", (in {@link #attach}) any related
>      *     dangling comments are also attached to the tree node
>      *     by registering them using the {@link #deferredLintHandler}.
>      *  5. (Later) Warnings may be genereated for the dangling
>      *     comments, subject to the {@code -Xlint} and
>      *     {@code @SuppressWarnings}.
> 
> 
> 3.  Updates to the make files to disable the warnings in modules for which the 
> warning is generated.  This is often because of the confusing use of `/**` to
> create box or other standout comments.

lgtm

-------------

Marked as reviewed by vromero (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18527#pullrequestreview-1967750057

From achung at openjdk.org  Fri Mar 29 04:40:55 2024
From: achung at openjdk.org (Alisen Chung)
Date: Fri, 29 Mar 2024 04:40:55 GMT
Subject: RFR: 8328403: Remove applet usage from JColorChooser tests
 Test6977726 [v6]
In-Reply-To: <pyfxVdApSNSisMJieBTl5HSZKDmSSiPie0tnrM_rwe4=.5ffc4e92-cbcf-44d8-9a51-b4e8330e1be9@github.com>
References: <pyfxVdApSNSisMJieBTl5HSZKDmSSiPie0tnrM_rwe4=.5ffc4e92-cbcf-44d8-9a51-b4e8330e1be9@github.com>
Message-ID: <w9RcR7vq_uXYgjKnAiyD3vDe1-kOx1CI7DgobHrfvEs=.b320c580-646e-4f9b-aa02-7c256f80a338@github.com>

> Removing applet usage from manual JColorChooser tests

Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:

  update test from feedback

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18369/files
  - new: https://git.openjdk.org/jdk/pull/18369/files/ff6f5e51..dad92188

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18369&range=05
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18369&range=04-05

  Stats: 3 lines in 1 file changed: 1 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/18369.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18369/head:pull/18369

PR: https://git.openjdk.org/jdk/pull/18369

From tr at openjdk.org  Fri Mar 29 04:43:36 2024
From: tr at openjdk.org (Tejesh R)
Date: Fri, 29 Mar 2024 04:43:36 GMT
Subject: RFR: 8328953 : JEditorPane.read throws ChangedCharSetException
 [v8]
In-Reply-To: <RNjgXZJj7hnRHrdOk2u9O7Vr9nqxi138qe6YJvo93SU=.ad3a873f-800d-41c4-97ee-4410b004ad10@github.com>
References: <j32PTT_v706cIsLg9ssxPivpEJoo5bCJ1H5NHj3KDhY=.b9e439f3-ce7a-4d63-bfe4-bd415a34a2d2@github.com>
 <RNjgXZJj7hnRHrdOk2u9O7Vr9nqxi138qe6YJvo93SU=.ad3a873f-800d-41c4-97ee-4410b004ad10@github.com>
Message-ID: <PL6ty6bFHVhduCOA1NS3a7Mm8XCGK6TCHUras3PUgrM=.031954fa-afb9-4f54-a0d5-16aab210171c@github.com>

On Thu, 28 Mar 2024 08:33:52 GMT, rjolly <duke at openjdk.org> wrote:

>> ChangedCharSetException is used to amend the charset during read according to html directives. Currently it causes immediate exit of the method which in turn causes failure to load html documents with charset directives (even if the latter must not change after all). This PR restores the catch operation as it was before the use of try with resources.
>
> rjolly has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8328953 : JEditorPane.read throws ChangedCharSetException
>   
>   The fix is to add a nested `try`-block inside `try-with-resource`; all the exceptions are handled in the nested `try`; the outer `try`-with-resouces only closes the input stream.

Looks good to me.

-------------

Marked as reviewed by tr (Committer).

PR Review: https://git.openjdk.org/jdk/pull/17567#pullrequestreview-1967820534

From dnguyen at openjdk.org  Fri Mar 29 04:52:31 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Fri, 29 Mar 2024 04:52:31 GMT
Subject: RFR: 8328648: Remove applet usage from JFileChooser tests
 bug4150029 [v5]
In-Reply-To: <QI5xCwI60xfJfmlyyMqvIH47yT-iBtFjJfbLFsoO1_s=.38484ac5-4d32-418f-9ee0-ca6f51a061f3@github.com>
References: <eTiR35uGxb59RbbKcRAdTrgYkrx4CNmkIWfk63i3sJw=.8771db30-c50e-4c50-ae80-312a7683cc27@github.com>
 <QI5xCwI60xfJfmlyyMqvIH47yT-iBtFjJfbLFsoO1_s=.38484ac5-4d32-418f-9ee0-ca6f51a061f3@github.com>
Message-ID: <ZHeWj62d68TAJdBDDCnfS4Eiban5A-tk7N-AlgzrTL4=.46a21fbd-79e5-43e7-a2c6-5ac58249a7e6@github.com>

On Wed, 27 Mar 2024 22:07:43 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> Removing applet usage from manual JFileChooser tests
>
> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   removed second pass check

Looks like the test needs a headful tag as well. Was this ran via CI?

-------------

PR Review: https://git.openjdk.org/jdk/pull/18415#pullrequestreview-1967826689

From abhiscxk at openjdk.org  Fri Mar 29 05:36:32 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Fri, 29 Mar 2024 05:36:32 GMT
Subject: RFR: 8328648: Remove applet usage from JFileChooser tests
 bug4150029 [v5]
In-Reply-To: <QI5xCwI60xfJfmlyyMqvIH47yT-iBtFjJfbLFsoO1_s=.38484ac5-4d32-418f-9ee0-ca6f51a061f3@github.com>
References: <eTiR35uGxb59RbbKcRAdTrgYkrx4CNmkIWfk63i3sJw=.8771db30-c50e-4c50-ae80-312a7683cc27@github.com>
 <QI5xCwI60xfJfmlyyMqvIH47yT-iBtFjJfbLFsoO1_s=.38484ac5-4d32-418f-9ee0-ca6f51a061f3@github.com>
Message-ID: <QfZEBF0QO7VosoQIk9NvXpsdEU_T5sSA684m0cTIMM8=.497ed0d1-84c2-4229-a314-de5e8a7dd506@github.com>

On Wed, 27 Mar 2024 22:07:43 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> Removing applet usage from manual JFileChooser tests
>
> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   removed second pass check

test/jdk/javax/swing/JFileChooser/4150029/bug4150029.java line 128:

> 126:         clickBackSpace();
> 127:         if (prevDir != crntDir) {
> 128:             passed = true;

`passed` variable looks redundant now. You can compare the `prevDir` and `crntDir` inside if condition and if they are same then test should fail.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18415#discussion_r1544062398

From abhiscxk at openjdk.org  Fri Mar 29 05:51:39 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Fri, 29 Mar 2024 05:51:39 GMT
Subject: RFR: 8075917: The regression-swing case failed as the text on
 label is not painted red with the GTK L&F [v5]
In-Reply-To: <E4uZV0yEJwF2yVG6oIebKDDyS0r6djuq7S-Ef7B5WYI=.769702c3-dc8d-456e-8e55-998428a5dd26@github.com>
References: <iDOTnLkAimOa5kfDerZ09n4wsYiFYYUyBflOTYeUQZ0=.293390bd-bc47-4871-bf4c-d23c191d9426@github.com>
 <5eZ7a0HiqE3hghw3sT0L0Zn4Mi1FFfofz6hLGdLOsoc=.445b16ac-4d91-4538-92ba-a74f17781535@github.com>
 <c4jjcBPHlQ79cCbPxo8-EjjuWUzF3hjObagnARJe23s=.a897d7cb-8150-4871-bea6-6211ce88983e@github.com>
 <E4uZV0yEJwF2yVG6oIebKDDyS0r6djuq7S-Ef7B5WYI=.769702c3-dc8d-456e-8e55-998428a5dd26@github.com>
Message-ID: <MjLG0Rm8KK5-8oBZa9i0-wAk2ZM4AqjUdVnl33MKGX8=.79b1c8e0-7ac2-4235-b441-2c1fb61a47d1@github.com>

On Tue, 26 Mar 2024 07:38:58 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> src/java.desktop/share/classes/com/sun/java/swing/plaf/gtk/GTKStyle.java line 186:
>> 
>>> 184: 
>>> 185:         if (id == Region.LABEL && type == ColorType.FOREGROUND
>>> 186:                 && (state & SynthConstants.ENABLED) != 0) {
>> 
>> Doesn't `SynthConstants.DISABLED` need the same treatment?
>
> Yes, I am working on it to fix the disabled case.

I extended the fix for disabled state in GlyphView's paint method to honor the user defined LAF color if at all it is set.
But `open/test/jdk/javax/swing/text/html/Test4783068.java` test failed in CI, associated bug [JDK-4783068](https://bugs.openjdk.org/browse/JDK-4783068) says that `Components with HTML text should gray out the text when disabled`.

Now the question is "Should we handle the disabled HTML text" ?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17763#discussion_r1544096587

From achung at openjdk.org  Fri Mar 29 06:07:49 2024
From: achung at openjdk.org (Alisen Chung)
Date: Fri, 29 Mar 2024 06:07:49 GMT
Subject: RFR: 8328648: Remove applet usage from JFileChooser tests
 bug4150029 [v6]
In-Reply-To: <eTiR35uGxb59RbbKcRAdTrgYkrx4CNmkIWfk63i3sJw=.8771db30-c50e-4c50-ae80-312a7683cc27@github.com>
References: <eTiR35uGxb59RbbKcRAdTrgYkrx4CNmkIWfk63i3sJw=.8771db30-c50e-4c50-ae80-312a7683cc27@github.com>
Message-ID: <3KqJ2DWcVbc7MHBaVIxcBRYQagProebM47wbOzj5AD0=.eaa7c87d-915e-4344-98f6-db245eb4ea58@github.com>

> Removing applet usage from manual JFileChooser tests

Alisen Chung has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision:

 - Merge branch 'master' of https://github.com/openjdk/jdk into 2024_spring_testsprint_8
 - removed second pass check
 - moved create ui code to helper, change test pass check, add mouse release, remove getContentPane
 - change to automatic test
 - force fail
 - remove extra dialog
 - init commit

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18415/files
  - new: https://git.openjdk.org/jdk/pull/18415/files/eb58531e..0de40f87

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18415&range=05
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18415&range=04-05

  Stats: 353493 lines in 2818 files changed: 17195 ins; 12263 del; 324035 mod
  Patch: https://git.openjdk.org/jdk/pull/18415.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18415/head:pull/18415

PR: https://git.openjdk.org/jdk/pull/18415

From achung at openjdk.org  Fri Mar 29 07:15:42 2024
From: achung at openjdk.org (Alisen Chung)
Date: Fri, 29 Mar 2024 07:15:42 GMT
Subject: RFR: 8328648: Remove applet usage from JFileChooser tests
 bug4150029 [v7]
In-Reply-To: <eTiR35uGxb59RbbKcRAdTrgYkrx4CNmkIWfk63i3sJw=.8771db30-c50e-4c50-ae80-312a7683cc27@github.com>
References: <eTiR35uGxb59RbbKcRAdTrgYkrx4CNmkIWfk63i3sJw=.8771db30-c50e-4c50-ae80-312a7683cc27@github.com>
Message-ID: <4B8QcHlTBMwjc6CMBjVheGZ63fYPQ3aKJwjjgbvR3sQ=.f4653ade-ba11-4893-958a-6628b2572b05@github.com>

> Removing applet usage from manual JFileChooser tests

Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:

  added headful tag, remove pass boolean var and directly evaluate pass condition

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18415/files
  - new: https://git.openjdk.org/jdk/pull/18415/files/0de40f87..29486a10

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18415&range=06
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18415&range=05-06

  Stats: 6 lines in 1 file changed: 1 ins; 4 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/18415.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18415/head:pull/18415

PR: https://git.openjdk.org/jdk/pull/18415

From psadhukhan at openjdk.org  Fri Mar 29 07:24:33 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Fri, 29 Mar 2024 07:24:33 GMT
Subject: RFR: 8328561: test
 java/awt/Robot/ManualInstructions/ManualInstructions.java isn't used
In-Reply-To: <ABW2Bldb5eN2as1Jb7G7lFW1ULTIizQwTaHQTORhLnc=.02516bdc-9b01-4748-b80e-fa54b0b8996e@github.com>
References: <ABW2Bldb5eN2as1Jb7G7lFW1ULTIizQwTaHQTORhLnc=.02516bdc-9b01-4748-b80e-fa54b0b8996e@github.com>
Message-ID: <4R9xnrr_lWINxF-47X39jD1jhP2-GCZ5a2SCZeX_Dc8=.0db73a5d-590c-4e39-8464-5261f933420e@github.com>

On Thu, 21 Mar 2024 20:00:48 GMT, Phil Race <prr at openjdk.org> wrote:

> I don't know why this file is checked in. It has no @test tag and doesn't do anything. I am deleting it.

ok

-------------

Marked as reviewed by psadhukhan (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18440#pullrequestreview-1968005195

From psadhukhan at openjdk.org  Fri Mar 29 07:25:51 2024
From: psadhukhan at openjdk.org (Prasanta Sadhukhan)
Date: Fri, 29 Mar 2024 07:25:51 GMT
Subject: RFR: 8328541: Remove or update obsolete comment in JRootPane
Message-ID: <qrXxd1TMO9n9ee6mml-H0hMTnCxpO2zb4gL5xsr76Tg=.75cdb5ba-9b1d-4bee-a592-2521f90aacd4@github.com>

There is an old obsolete comment in JRootPane that is between the main documentation comment for the class and the declaration of the class itself which is  causing interference with the work to support Markdown in documentation comments using the `///` style of comment. (JEP 467) so removing this comment..

-------------

Commit messages:
 - 8328541: Remove or update obsolete comment in JRootPane

Changes: https://git.openjdk.org/jdk/pull/18545/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18545&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8328541
  Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18545.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18545/head:pull/18545

PR: https://git.openjdk.org/jdk/pull/18545

From abhiscxk at openjdk.org  Fri Mar 29 08:13:33 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Fri, 29 Mar 2024 08:13:33 GMT
Subject: RFR: 8328648: Remove applet usage from JFileChooser tests
 bug4150029 [v7]
In-Reply-To: <4B8QcHlTBMwjc6CMBjVheGZ63fYPQ3aKJwjjgbvR3sQ=.f4653ade-ba11-4893-958a-6628b2572b05@github.com>
References: <eTiR35uGxb59RbbKcRAdTrgYkrx4CNmkIWfk63i3sJw=.8771db30-c50e-4c50-ae80-312a7683cc27@github.com>
 <4B8QcHlTBMwjc6CMBjVheGZ63fYPQ3aKJwjjgbvR3sQ=.f4653ade-ba11-4893-958a-6628b2572b05@github.com>
Message-ID: <NlgtIml7Pjaq2f8JTCngG317TaDretp03Q71Fn_qx4I=.fa6b7ddd-bb6a-47de-b073-5b6781372613@github.com>

On Fri, 29 Mar 2024 07:15:42 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> Removing applet usage from manual JFileChooser tests
>
> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   added headful tag, remove pass boolean var and directly evaluate pass condition

test/jdk/javax/swing/JFileChooser/4150029/bug4150029.java line 52:

> 50:     private static Robot robot;
> 51:     private static File testDir;
> 52:     private static File subDir;

`testDir` can be declared as local variable.
Probably `subDir` also can be moved as local variable provided you create JFileChooser instance with default directory and then set current directory inside main method after createAndShowUI method call.

something like this..

`SwingUtilities.invokeAndWait(() -> {
                createAndShowUI();
                fileChooser.setCurrentDirectory(subDir);
            });`

test/jdk/javax/swing/JFileChooser/4150029/bug4150029.java line 117:

> 115:         SwingUtilities.invokeAndWait(() -> {
> 116:             p = frame.getLocationOnScreen();
> 117: 

May remove extra blank line.

test/jdk/javax/swing/JFileChooser/4150029/bug4150029.java line 128:

> 126:         clickBackSpace();
> 127: 
> 128:         if (!(prevDir != crntDir)) {

simplified condition - 
Suggestion:

        if (prevDir == crntDir) {

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18415#discussion_r1544203362
PR Review Comment: https://git.openjdk.org/jdk/pull/18415#discussion_r1544213542
PR Review Comment: https://git.openjdk.org/jdk/pull/18415#discussion_r1544212323

From tr at openjdk.org  Fri Mar 29 09:49:54 2024
From: tr at openjdk.org (Tejesh R)
Date: Fri, 29 Mar 2024 09:49:54 GMT
Subject: RFR: 8328482: Convert and Open source few manual applet test to
 main based [v5]
In-Reply-To: <aV9yYWUEsrakxmujJCq2LzFg5K6nyCV4aELge8c1oJo=.c9f2c13d-337f-4af3-8a38-551a7f0ba0c6@github.com>
References: <aV9yYWUEsrakxmujJCq2LzFg5K6nyCV4aELge8c1oJo=.c9f2c13d-337f-4af3-8a38-551a7f0ba0c6@github.com>
Message-ID: <Ag3ABER1d_aho3spUx8KmIbJPiggpNrTC8P62NHLzew=.5cfb4df3-2c17-4c8b-900d-976c51223d6d@github.com>

> Convert and open source these manual applet test to main based:
> java/awt/Frame/MegaIconTest/MegaIconTest.html
> java/awt/Frame/FrameMaximizedTest/FrameMaximizedTest.html
> java/awt/Frame/FrameMinimizeTest/FrameMinimizeTest.html
> java/awt/Frame/SizeMinimizedTest/SizeMinimizedTest.html

Tejesh R has updated the pull request incrementally with one additional commit since the last revision:

  Reveiw updates and SizeMinimizedTest converted to auto test

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18448/files
  - new: https://git.openjdk.org/jdk/pull/18448/files/656fdc94..20517050

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18448&range=04
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18448&range=03-04

  Stats: 105 lines in 4 files changed: 45 ins; 22 del; 38 mod
  Patch: https://git.openjdk.org/jdk/pull/18448.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18448/head:pull/18448

PR: https://git.openjdk.org/jdk/pull/18448

From aivanov at openjdk.org  Fri Mar 29 09:57:33 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Fri, 29 Mar 2024 09:57:33 GMT
Subject: RFR: 8328953 : JEditorPane.read throws ChangedCharSetException
In-Reply-To: <RMMDb3wD9iwW6FO7QH4442upItb30bPp8GMbs7fIpPs=.6b9ca5eb-a8de-4f5c-afb6-a6e934a646ff@github.com>
References: <j32PTT_v706cIsLg9ssxPivpEJoo5bCJ1H5NHj3KDhY=.b9e439f3-ce7a-4d63-bfe4-bd415a34a2d2@github.com>
 <1MOJPinRAWnrKr4DWeXfV_cUxzU2cHUprU9_xS1xl7k=.202cadfb-75fc-4216-be18-e7a590ebb0ca@github.com>
 <aOmxqjzD-27dOTMBjUzXxaAcBpfd5XCFj_gRCcvEaeE=.05523851-911e-4c7e-8026-c6827742be46@github.com>
 <RMMDb3wD9iwW6FO7QH4442upItb30bPp8GMbs7fIpPs=.6b9ca5eb-a8de-4f5c-afb6-a6e934a646ff@github.com>
Message-ID: <gRA3e7qKJKuH41FfzGaZKGkjujGwscIZxAwwECPHui4=.bbf32b2a-1e92-4f51-b822-dafc60c4450d@github.com>

On Mon, 18 Mar 2024 09:04:05 GMT, rjolly <duke at openjdk.org> wrote:

>> @rjolly Thank you for your contribution. Could you provide more details about the issue? The PR needs to be linked to a JBS issue. I'll create one for you after I get a more detailed description of the problem from you.
>> 
>> A test case is also welcome. And it's needed a regression test for the change anyway, if it's not hard to create. I believe a test case can be written for this issue.
>
> Hi @aivanov-jdk , thanks for your response. Is there a place where I can put my non-regression test? Thanks!

@rjolly You've got two approvals now. You can issue the [`/integrate`](https://wiki.openjdk.org/display/SKARA/Pull+Request+Commands#PullRequestCommands-/integrate) command to integrate your fix into the JDK.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17567#issuecomment-2026980130

From tr at openjdk.org  Fri Mar 29 10:03:35 2024
From: tr at openjdk.org (Tejesh R)
Date: Fri, 29 Mar 2024 10:03:35 GMT
Subject: RFR: 8328482: Convert and Open source few manual applet test to
 main based [v3]
In-Reply-To: <Ak10nmNRlpO0gf9zcJv3x8WyE6gVg0uSgm972L03vq8=.8323a652-b76a-4449-aa3a-ec57fb3454ca@github.com>
References: <aV9yYWUEsrakxmujJCq2LzFg5K6nyCV4aELge8c1oJo=.c9f2c13d-337f-4af3-8a38-551a7f0ba0c6@github.com>
 <Pi6RvL9Fn2ID3Biiiw3BSJF6kCmnMb2jRJlQgK4jVoQ=.c768550e-5e11-40ee-aa74-2f6afc486d8a@github.com>
 <Ak10nmNRlpO0gf9zcJv3x8WyE6gVg0uSgm972L03vq8=.8323a652-b76a-4449-aa3a-ec57fb3454ca@github.com>
Message-ID: <SrDQ04xcA3JRp6BWhrYv3kUaut8SeeRm7TY519YCm_8=.efb6b929-d617-4e88-b0ff-583032e36c23@github.com>

On Tue, 26 Mar 2024 23:16:04 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Tejesh R has updated the pull request incrementally with three additional commits since the last revision:
>> 
>>  - Images updated
>>  - Frame position updates
>>  - removed headful tag
>
> test/jdk/java/awt/Frame/FrameMaximizedTest.java line 37:
> 
>> 35: 
>> 36: public class FrameMaximizedTest {
>> 37:     public static void main (String args[]) throws Exception {
> 
> Java style array declaration
> Suggestion:
> 
>     public static void main (String[] args) throws Exception {

Updated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18448#discussion_r1544311632

From tr at openjdk.org  Fri Mar 29 10:03:36 2024
From: tr at openjdk.org (Tejesh R)
Date: Fri, 29 Mar 2024 10:03:36 GMT
Subject: RFR: 8328482: Convert and Open source few manual applet test to
 main based [v4]
In-Reply-To: <99VWs9cjjiPHXJVMObjSUtLzxRdD_BuTJPIGGINjoSo=.bdb21b8f-bbe0-46bd-a447-45bff718f5b0@github.com>
References: <aV9yYWUEsrakxmujJCq2LzFg5K6nyCV4aELge8c1oJo=.c9f2c13d-337f-4af3-8a38-551a7f0ba0c6@github.com>
 <TYJFZwPv2tFlCYmwFMZfO11wsxCY8WNPHuvu4urAtzM=.0ff7923d-aacb-4705-9e68-d2d029c257ad@github.com>
 <99VWs9cjjiPHXJVMObjSUtLzxRdD_BuTJPIGGINjoSo=.bdb21b8f-bbe0-46bd-a447-45bff718f5b0@github.com>
Message-ID: <LmL07RRtjnqZiA-UYy95mvBhja8vmWmFkAxsv_Wb8d8=.c5cd24b4-f6cc-4ec2-90ad-d10cac1b76d5@github.com>

On Thu, 28 Mar 2024 01:06:32 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fight.gif added
>
> test/jdk/java/awt/Frame/FrameMinimizeTest.java line 36:
> 
>> 34: 
>> 35: public class FrameMinimizeTest {
>> 36:     public static void main(String args[]) throws Exception {
> 
> Java style arrays

Updated.

> test/jdk/java/awt/Frame/SizeMinimizedTest.java line 48:
> 
>> 46:                         continuously be logged, so you can verify its changes)
>> 47:                         1. When the test starts, two frame windows will appear.
>> 48:                         Note the size of frame2.
> 
> Window listeners can be used to check the initial and subsequent frame size and positions. This avoids asking the user to keep note of these details.
> 
> It could be potentially be automated at this point, if it doesn't require much effort.
> 
> 
> 
> frame2.addWindowListener(new WindowAdapter() {
>             @Override
>             public void windowOpened(WindowEvent e) {
>                 PassFailJFrame.log("Initial Frame Size: " + frame2.getSize());
>                 PassFailJFrame.log("Initial Frame Location: " + frame2.getLocationOnScreen());
>             }
>         });
> frame2.addWindowStateListener(new WindowAdapter() {
>           @Override
>           public void windowStateChanged(WindowEvent e) {
>               if (e.getNewState() == Frame.NORMAL) {
>                   PassFailJFrame.log("Frame Size: " + frame2.getSize());
>                   PassFailJFrame.log("Frame Location: " + frame2.getLocationOnScreen());
>               }
>           }
>  });

Yeah, was able to automate the test. Thank you for the suggestion. In linux the test fails intermittently though, might be linked to the issue [JDK-8305915](https://bugs.openjdk.org/browse/JDK-8305915) so have problem listed, which I have update the description.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18448#discussion_r1544311780
PR Review Comment: https://git.openjdk.org/jdk/pull/18448#discussion_r1544313163

From duke at openjdk.org  Fri Mar 29 10:09:38 2024
From: duke at openjdk.org (rjolly)
Date: Fri, 29 Mar 2024 10:09:38 GMT
Subject: Integrated: 8328953 : JEditorPane.read throws ChangedCharSetException
In-Reply-To: <j32PTT_v706cIsLg9ssxPivpEJoo5bCJ1H5NHj3KDhY=.b9e439f3-ce7a-4d63-bfe4-bd415a34a2d2@github.com>
References: <j32PTT_v706cIsLg9ssxPivpEJoo5bCJ1H5NHj3KDhY=.b9e439f3-ce7a-4d63-bfe4-bd415a34a2d2@github.com>
Message-ID: <llV1Y84kuTS9QUBH3Yo_VxdrOWc4wERJSbQXSlTTvUg=.f87c2f65-d8cf-4550-98ad-536f00e96ab3@github.com>

On Thu, 25 Jan 2024 11:11:47 GMT, rjolly <duke at openjdk.org> wrote:

> ChangedCharSetException is used to amend the charset during read according to html directives. Currently it causes immediate exit of the method which in turn causes failure to load html documents with charset directives (even if the latter must not change after all). This PR restores the catch operation as it was before the use of try with resources.

This pull request has now been integrated.

Changeset: 245514da
Author:    Raphael Jolly <rjolly at users.sourceforge.net>
Committer: Alexey Ivanov <aivanov at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/245514da51ef77757f530317e079a3f58370a0be
Stats:     118 lines in 2 files changed: 92 ins; 16 del; 10 mod

8328953: JEditorPane.read throws ChangedCharSetException

Reviewed-by: tr, aivanov

-------------

PR: https://git.openjdk.org/jdk/pull/17567

From aivanov at openjdk.org  Fri Mar 29 12:49:39 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Fri, 29 Mar 2024 12:49:39 GMT
Subject: RFR: 8329320: Simplify awt/print/PageFormat/NullPaper.java test
Message-ID: <0CQ06Dw6Uwa9Z2lLfqFhdAWxWVLiYJs-EoziVLODxlw=.0133d820-1a13-4813-bc20-c9358fcbc58c@github.com>

Remove all the leftovers of the _"standard instructions" machinery_ from the `NullPaper.java` test.

The test code consists of two lines now: concise and clear.

-------------

Commit messages:
 - Remove redudant comment; add blank line
 - 8329320: Simplify awt/print/PageFormat/NullPaper.java test

Changes: https://git.openjdk.org/jdk/pull/18547/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18547&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8329320
  Stats: 177 lines in 1 file changed: 6 ins; 155 del; 16 mod
  Patch: https://git.openjdk.org/jdk/pull/18547.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18547/head:pull/18547

PR: https://git.openjdk.org/jdk/pull/18547

From aivanov at openjdk.org  Fri Mar 29 13:09:31 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Fri, 29 Mar 2024 13:09:31 GMT
Subject: RFR: 8328541: Remove or update obsolete comment in JRootPane
In-Reply-To: <qrXxd1TMO9n9ee6mml-H0hMTnCxpO2zb4gL5xsr76Tg=.75cdb5ba-9b1d-4bee-a592-2521f90aacd4@github.com>
References: <qrXxd1TMO9n9ee6mml-H0hMTnCxpO2zb4gL5xsr76Tg=.75cdb5ba-9b1d-4bee-a592-2521f90aacd4@github.com>
Message-ID: <mL534HeIpgMvWAEoIxWyBin530mDArDVWYji9dqZ-3w=.14fb9adc-1648-426b-8a02-323bbd39b57f@github.com>

On Fri, 29 Mar 2024 07:21:17 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> There is an old obsolete comment in JRootPane that is between the main documentation comment for the class and the declaration of the class itself which is  causing interference with the work to support Markdown in documentation comments using the `///` style of comment. (JEP 467) so removing this comment..

Marked as reviewed by aivanov (Reviewer).

src/java.desktop/share/classes/javax/swing/JRootPane.java line 1:

> 1: /*

You may still want to update the copyright year.

-------------

PR Review: https://git.openjdk.org/jdk/pull/18545#pullrequestreview-1968489517
PR Review Comment: https://git.openjdk.org/jdk/pull/18545#discussion_r1544480358

From abhiscxk at openjdk.org  Fri Mar 29 13:49:32 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Fri, 29 Mar 2024 13:49:32 GMT
Subject: RFR: 8328541: Remove or update obsolete comment in JRootPane
In-Reply-To: <qrXxd1TMO9n9ee6mml-H0hMTnCxpO2zb4gL5xsr76Tg=.75cdb5ba-9b1d-4bee-a592-2521f90aacd4@github.com>
References: <qrXxd1TMO9n9ee6mml-H0hMTnCxpO2zb4gL5xsr76Tg=.75cdb5ba-9b1d-4bee-a592-2521f90aacd4@github.com>
Message-ID: <qbnljswke8dOlIQ9A3wfQHR79ghzPpaqmIXVCsuw08w=.3ee6a8fc-c1f3-4519-a66b-726875a126f5@github.com>

On Fri, 29 Mar 2024 07:21:17 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> There is an old obsolete comment in JRootPane that is between the main documentation comment for the class and the declaration of the class itself which is  causing interference with the work to support Markdown in documentation comments using the `///` style of comment. (JEP 467) so removing this comment..

Marked as reviewed by abhiscxk (Committer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18545#pullrequestreview-1968587598

From achung at openjdk.org  Fri Mar 29 14:37:42 2024
From: achung at openjdk.org (Alisen Chung)
Date: Fri, 29 Mar 2024 14:37:42 GMT
Subject: RFR: 8328648: Remove applet usage from JFileChooser tests
 bug4150029 [v8]
In-Reply-To: <eTiR35uGxb59RbbKcRAdTrgYkrx4CNmkIWfk63i3sJw=.8771db30-c50e-4c50-ae80-312a7683cc27@github.com>
References: <eTiR35uGxb59RbbKcRAdTrgYkrx4CNmkIWfk63i3sJw=.8771db30-c50e-4c50-ae80-312a7683cc27@github.com>
Message-ID: <ge37OFMCxfobhjv-bD-nYyM3C_AWx28kPXF2_4qXL7M=.5e2a7ad0-01b0-4c07-b106-6ddbd9bafa00@github.com>

> Removing applet usage from manual JFileChooser tests

Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:

  move var into local, simplified condition check, spacing

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18415/files
  - new: https://git.openjdk.org/jdk/pull/18415/files/29486a10..ed8ed220

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18415&range=07
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18415&range=06-07

  Stats: 8 lines in 1 file changed: 1 ins; 3 del; 4 mod
  Patch: https://git.openjdk.org/jdk/pull/18415.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18415/head:pull/18415

PR: https://git.openjdk.org/jdk/pull/18415

From dnguyen at openjdk.org  Fri Mar 29 16:43:36 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Fri, 29 Mar 2024 16:43:36 GMT
Subject: RFR: JDK-8328753 : Open source few Undecorated Frame tests [v2]
In-Reply-To: <KBCwA1lSI3j1IgH_Mc72T8vLYxJIaTs8JjsMLsdY2sY=.52705506-3af7-4988-94fa-5271398f1932@github.com>
References: <TeT19qrHb_dsgafsfZDNyiaXEYdeOEgjJ17O6us2PTo=.228b6b55-64b4-40b4-945a-e3c25a14a393@github.com>
 <KBCwA1lSI3j1IgH_Mc72T8vLYxJIaTs8JjsMLsdY2sY=.52705506-3af7-4988-94fa-5271398f1932@github.com>
Message-ID: <PE5Dgy_IBGTmcNA__6qJTRSPhRLnqtgCUxYPkXOqCAc=.f6dd7d82-abdf-4942-b458-2539ea14c4c5@github.com>

On Wed, 27 Mar 2024 18:20:59 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Following tests are converted to main and open-sourced:
>> 
>> - /java/awt/Frame/FrameDialogMixedTest.java- Converted to main/manual using PassFailJFrame.
>> - /java/awt/Frame/MaximizeUndecoratedTest.java - Automated
>> - /java/awt/Frame/MinimizeUndecoratedTest.java - Automated
>
> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   spacing

test/jdk/java/awt/Frame/MaximizeUndecoratedTest.java line 127:

> 125:         } catch (IOException e) {
> 126:             e.printStackTrace();
> 127:         }

Is it best to just print the stack trace when a screenshot fails? Or is it better to throw a new runtime error?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18523#discussion_r1544683152

From abhiscxk at openjdk.org  Fri Mar 29 16:46:32 2024
From: abhiscxk at openjdk.org (Abhishek Kumar)
Date: Fri, 29 Mar 2024 16:46:32 GMT
Subject: RFR: 8328648: Remove applet usage from JFileChooser tests
 bug4150029 [v8]
In-Reply-To: <ge37OFMCxfobhjv-bD-nYyM3C_AWx28kPXF2_4qXL7M=.5e2a7ad0-01b0-4c07-b106-6ddbd9bafa00@github.com>
References: <eTiR35uGxb59RbbKcRAdTrgYkrx4CNmkIWfk63i3sJw=.8771db30-c50e-4c50-ae80-312a7683cc27@github.com>
 <ge37OFMCxfobhjv-bD-nYyM3C_AWx28kPXF2_4qXL7M=.5e2a7ad0-01b0-4c07-b106-6ddbd9bafa00@github.com>
Message-ID: <vSQO8SIfI94EJ_WEUt5cAF3GAAQBhEyJncc_37F5Xbs=.7b7d7edd-4473-47bc-ab3b-5d418f40c7fa@github.com>

On Fri, 29 Mar 2024 14:37:42 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> Removing applet usage from manual JFileChooser tests
>
> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   move var into local, simplified condition check, spacing

Looks good now. Only point is "should we move this test outside folder as html file is deleted now?".
Hope you have tested in CI for all platform.

-------------

Marked as reviewed by abhiscxk (Committer).

PR Review: https://git.openjdk.org/jdk/pull/18415#pullrequestreview-1969011787

From prr at openjdk.org  Fri Mar 29 17:28:54 2024
From: prr at openjdk.org (Phil Race)
Date: Fri, 29 Mar 2024 17:28:54 GMT
Subject: RFR: 8329337: Problem list BufferStrategyExceptionTest.java on Windows
Message-ID: <S24r1YG4y38u3t2XffFk0efJ8vbjt5nDkey0V6mqvgk=.3544361f-3a00-4899-bf96-52e4e54e29c5@github.com>

Problem list a test which is failing in CI

-------------

Commit messages:
 - 8329337

Changes: https://git.openjdk.org/jdk/pull/18552/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18552&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8329337
  Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18552.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18552/head:pull/18552

PR: https://git.openjdk.org/jdk/pull/18552

From honkar at openjdk.org  Fri Mar 29 17:29:09 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Fri, 29 Mar 2024 17:29:09 GMT
Subject: RFR: JDK-8328753 : Open source few Undecorated Frame tests [v3]
In-Reply-To: <TeT19qrHb_dsgafsfZDNyiaXEYdeOEgjJ17O6us2PTo=.228b6b55-64b4-40b4-945a-e3c25a14a393@github.com>
References: <TeT19qrHb_dsgafsfZDNyiaXEYdeOEgjJ17O6us2PTo=.228b6b55-64b4-40b4-945a-e3c25a14a393@github.com>
Message-ID: <erA5EWbQxnZGfvc5qdQ5N1jT1wgrAIvQu8n-K_yiqzU=.07148e01-3211-4d6b-b50e-a745fe5e27a5@github.com>

> Following tests are converted to main and open-sourced:
> 
> - /java/awt/Frame/FrameDialogMixedTest.java- Converted to main/manual using PassFailJFrame.
> - /java/awt/Frame/MaximizeUndecoratedTest.java - Automated
> - /java/awt/Frame/MinimizeUndecoratedTest.java - Automated

Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:

  RuntimeException thrown

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18523/files
  - new: https://git.openjdk.org/jdk/pull/18523/files/ff15a9d8..9c2b2939

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18523&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18523&range=01-02

  Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/18523.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18523/head:pull/18523

PR: https://git.openjdk.org/jdk/pull/18523

From honkar at openjdk.org  Fri Mar 29 17:29:09 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Fri, 29 Mar 2024 17:29:09 GMT
Subject: RFR: JDK-8328753 : Open source few Undecorated Frame tests [v2]
In-Reply-To: <PE5Dgy_IBGTmcNA__6qJTRSPhRLnqtgCUxYPkXOqCAc=.f6dd7d82-abdf-4942-b458-2539ea14c4c5@github.com>
References: <TeT19qrHb_dsgafsfZDNyiaXEYdeOEgjJ17O6us2PTo=.228b6b55-64b4-40b4-945a-e3c25a14a393@github.com>
 <KBCwA1lSI3j1IgH_Mc72T8vLYxJIaTs8JjsMLsdY2sY=.52705506-3af7-4988-94fa-5271398f1932@github.com>
 <PE5Dgy_IBGTmcNA__6qJTRSPhRLnqtgCUxYPkXOqCAc=.f6dd7d82-abdf-4942-b458-2539ea14c4c5@github.com>
Message-ID: <APULaNZx8QwktRNrBPri6bedt1yzrnC9xPFv0bVN2dc=.0d2d64b4-dd06-4038-80ae-8dca78ad71d6@github.com>

On Fri, 29 Mar 2024 16:41:13 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

>> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   spacing
>
> test/jdk/java/awt/Frame/MaximizeUndecoratedTest.java line 127:
> 
>> 125:         } catch (IOException e) {
>> 126:             e.printStackTrace();
>> 127:         }
> 
> Is it best to just print the stack trace when a screenshot fails? Or is it better to throw a new runtime error?

It is better to re-throw it as RuntimeException. Updated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18523#discussion_r1544715093

From dnguyen at openjdk.org  Fri Mar 29 17:31:34 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Fri, 29 Mar 2024 17:31:34 GMT
Subject: RFR: JDK-8328753 : Open source few Undecorated Frame tests [v3]
In-Reply-To: <erA5EWbQxnZGfvc5qdQ5N1jT1wgrAIvQu8n-K_yiqzU=.07148e01-3211-4d6b-b50e-a745fe5e27a5@github.com>
References: <TeT19qrHb_dsgafsfZDNyiaXEYdeOEgjJ17O6us2PTo=.228b6b55-64b4-40b4-945a-e3c25a14a393@github.com>
 <erA5EWbQxnZGfvc5qdQ5N1jT1wgrAIvQu8n-K_yiqzU=.07148e01-3211-4d6b-b50e-a745fe5e27a5@github.com>
Message-ID: <J72iXf0RjZuqIKyAJtFa1r4Qjzc40EIzHzuFs71B7PY=.ed12c263-afe4-4a64-8fff-3c2004a60e3b@github.com>

On Fri, 29 Mar 2024 17:29:09 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Following tests are converted to main and open-sourced:
>> 
>> - /java/awt/Frame/FrameDialogMixedTest.java- Converted to main/manual using PassFailJFrame.
>> - /java/awt/Frame/MaximizeUndecoratedTest.java - Automated
>> - /java/awt/Frame/MinimizeUndecoratedTest.java - Automated
>
> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   RuntimeException thrown

Tested and looks OK. Automated tests pass on macOS and behave as expected.

-------------

Marked as reviewed by dnguyen (Committer).

PR Review: https://git.openjdk.org/jdk/pull/18523#pullrequestreview-1969136521

From aivanov at openjdk.org  Fri Mar 29 17:35:42 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Fri, 29 Mar 2024 17:35:42 GMT
Subject: RFR: 8326734: text-decoration applied to <span> lost when mixed with
 <u> or <s>
Message-ID: <nfmH-qI_aIzq9SPeqbbomIDAczMRWiAtrDYLB7Km3s4=.27bf7f8b-1d81-4965-ac1e-e29b1b8843fd@github.com>

The value of the [`text-decoration`](https://www.w3.org/TR/REC-CSS1/#text-decoration) CSS property is not inherited correctly in Swing. If the `<span>` element is mixed with `<u>` or `<s>`, only the value from the `style` attribute of `<span>` is applied.

The fix to this issue is not as simple as that for the previous one in PR #17659, [JDK-8323801](https://bugs.openjdk.org/browse/JDK-8323801). Even in the seemingly simple case where `<u>` is followed by `<span style='text-decoration: line-through'>`, the situation is more complex because the styles are stored in `MuxingAttributeSet` in different elements of the array.

To resolve this problem, `CSS.Attribute.TEXT_DECORATION` is treated as a special case. Indeed, it is a special case: the values set to a single `text-decoration` property should be combined across the entire tree of nested HTML elements and their styles.

So, `MuxingAttributeSet` looks for `text-decoration` in the entire array and combines all the values.

The same way, `StyleSheet` also goes up the inheritance chain by combining the current value of `text-decoration` with that from `getResolveParent`.

The `ConvertSpanAction` combines the value of `text-decoration` of adjacent `<span>` elements.

Finally, `ConvertAction` and `CharacterAction` are refactored. The `ConvertAction` class duplicated the code from `CharacterAction`. Now `ConvertAction` extends `CharacterAction` and overrides a method to provide additional handling.

Thus, [JDK-8325620](https://bugs.openjdk.org/browse/JDK-8325620) is also resolved by this PR, the action used for `<b>`, `<i>`, `<u>` is `CharacterAction` as specified.

-------------

Commit messages:
 - Remove trailing whitespace in text block
 - Add test cases where <span> followed by <u> or <s>
 - Add missing 'return null' for !TEXT_DECORATION
 - Remove trailing whitespace in text block
 - Rename ConvertSpan to ConvertSpanAction
 - Convert only if both new and previous decorations aren't 'none'
 - Refactor ConvertAction: extend CharacterAction to avoid code duplication
 - Simplify ConvertSpan
 - Optimize imports in StyleSheet
 - Update copyright year
 - ... and 7 more: https://git.openjdk.org/jdk/compare/89e0889a...e9cf30b3

Changes: https://git.openjdk.org/jdk/pull/18550/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18550&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8326734
  Stats: 330 lines in 5 files changed: 275 ins; 32 del; 23 mod
  Patch: https://git.openjdk.org/jdk/pull/18550.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18550/head:pull/18550

PR: https://git.openjdk.org/jdk/pull/18550

From dcubed at openjdk.org  Fri Mar 29 17:50:32 2024
From: dcubed at openjdk.org (Daniel D. Daugherty)
Date: Fri, 29 Mar 2024 17:50:32 GMT
Subject: RFR: 8329337: Problem list BufferStrategyExceptionTest.java on
 Windows
In-Reply-To: <S24r1YG4y38u3t2XffFk0efJ8vbjt5nDkey0V6mqvgk=.3544361f-3a00-4899-bf96-52e4e54e29c5@github.com>
References: <S24r1YG4y38u3t2XffFk0efJ8vbjt5nDkey0V6mqvgk=.3544361f-3a00-4899-bf96-52e4e54e29c5@github.com>
Message-ID: <YEbv8NvgvubBS0IbsrzRkVCxPPrp30OfBVBRCFD-4LM=.ccb714e0-4e03-4f13-896e-469e48759eaf@github.com>

On Fri, 29 Mar 2024 17:24:27 GMT, Phil Race <prr at openjdk.org> wrote:

> Problem list a test which is failing in CI

Thumbs up. This is a trivial fix.

-------------

Marked as reviewed by dcubed (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18552#pullrequestreview-1969186125

From aivanov at openjdk.org  Fri Mar 29 17:53:30 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Fri, 29 Mar 2024 17:53:30 GMT
Subject: RFR: 8329337: Problem list BufferStrategyExceptionTest.java on
 Windows
In-Reply-To: <S24r1YG4y38u3t2XffFk0efJ8vbjt5nDkey0V6mqvgk=.3544361f-3a00-4899-bf96-52e4e54e29c5@github.com>
References: <S24r1YG4y38u3t2XffFk0efJ8vbjt5nDkey0V6mqvgk=.3544361f-3a00-4899-bf96-52e4e54e29c5@github.com>
Message-ID: <dQSPMe67ttS8CKHDU4BnsEJ3NL08jqVFwZzHmpQMa8E=.672ff386-885c-4e5e-be7f-8d0cd0dd96c7@github.com>

On Fri, 29 Mar 2024 17:24:27 GMT, Phil Race <prr at openjdk.org> wrote:

> Problem list a test which is failing in CI

Marked as reviewed by aivanov (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18552#pullrequestreview-1969192957

From honkar at openjdk.org  Fri Mar 29 18:05:35 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Fri, 29 Mar 2024 18:05:35 GMT
Subject: RFR: 8328482: Convert and Open source few manual applet test to
 main based [v5]
In-Reply-To: <Ag3ABER1d_aho3spUx8KmIbJPiggpNrTC8P62NHLzew=.5cfb4df3-2c17-4c8b-900d-976c51223d6d@github.com>
References: <aV9yYWUEsrakxmujJCq2LzFg5K6nyCV4aELge8c1oJo=.c9f2c13d-337f-4af3-8a38-551a7f0ba0c6@github.com>
 <Ag3ABER1d_aho3spUx8KmIbJPiggpNrTC8P62NHLzew=.5cfb4df3-2c17-4c8b-900d-976c51223d6d@github.com>
Message-ID: <58u8WoxBOGloYA7EXLkn3VtW1do4EFn8Yt5rgMAYjX0=.ebf40f6e-846b-4302-aea2-d8c8a7a6821b@github.com>

On Fri, 29 Mar 2024 09:49:54 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Convert and open source these manual applet test to main based:
>> java/awt/Frame/MegaIconTest/MegaIconTest.html
>> java/awt/Frame/FrameMaximizedTest/FrameMaximizedTest.html
>> java/awt/Frame/FrameMinimizeTest/FrameMinimizeTest.html
>> java/awt/Frame/SizeMinimizedTest/SizeMinimizedTest.html
>> 
>> Automated the test SizeMinimizedTest.java. Since the test is failing Linux arch (Maybe related to the bug - [JDK-8305915](https://bugs.openjdk.org/browse/JDK-8305915)), the test is problem listed for Linux arch until the issue is fixed/further investigation is done.
>
> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Reveiw updates and SizeMinimizedTest converted to auto test

Changes requested by honkar (Reviewer).

test/jdk/java/awt/Frame/SizeMinimizedTest.java line 39:

> 37:  * @key headful
> 38:  * @bug 4065534
> 39:  * @summary Frame.setSize() doesn't change size if window is in an iconified state

The main objective of the original test is missing with the current updated test. The test is to check whether Frame.setSize() works when Frame is in iconified state. Currently the test checks frame size and location when in Normal state.

-------------

PR Review: https://git.openjdk.org/jdk/pull/18448#pullrequestreview-1969214770
PR Review Comment: https://git.openjdk.org/jdk/pull/18448#discussion_r1544736765

From prr at openjdk.org  Fri Mar 29 18:10:35 2024
From: prr at openjdk.org (Phil Race)
Date: Fri, 29 Mar 2024 18:10:35 GMT
Subject: Integrated: 8329337: Problem list BufferStrategyExceptionTest.java on
 Windows
In-Reply-To: <S24r1YG4y38u3t2XffFk0efJ8vbjt5nDkey0V6mqvgk=.3544361f-3a00-4899-bf96-52e4e54e29c5@github.com>
References: <S24r1YG4y38u3t2XffFk0efJ8vbjt5nDkey0V6mqvgk=.3544361f-3a00-4899-bf96-52e4e54e29c5@github.com>
Message-ID: <R_EaqowA5n6X-Rr8PJ0qt0KQ8P_R1n-9dXvMGtG8Z-c=.e68f3248-49f3-4462-8b23-8fb71f01ee9c@github.com>

On Fri, 29 Mar 2024 17:24:27 GMT, Phil Race <prr at openjdk.org> wrote:

> Problem list a test which is failing in CI

This pull request has now been integrated.

Changeset: 20cb6e78
Author:    Phil Race <prr at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/20cb6e786fbf6d924c509e28d6fded86d61a5f84
Stats:     1 line in 1 file changed: 1 ins; 0 del; 0 mod

8329337: Problem list BufferStrategyExceptionTest.java on Windows

Reviewed-by: dcubed, aivanov

-------------

PR: https://git.openjdk.org/jdk/pull/18552

From honkar at openjdk.org  Fri Mar 29 18:48:32 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Fri, 29 Mar 2024 18:48:32 GMT
Subject: RFR: 8328482: Convert and Open source few manual applet test to
 main based [v5]
In-Reply-To: <Ag3ABER1d_aho3spUx8KmIbJPiggpNrTC8P62NHLzew=.5cfb4df3-2c17-4c8b-900d-976c51223d6d@github.com>
References: <aV9yYWUEsrakxmujJCq2LzFg5K6nyCV4aELge8c1oJo=.c9f2c13d-337f-4af3-8a38-551a7f0ba0c6@github.com>
 <Ag3ABER1d_aho3spUx8KmIbJPiggpNrTC8P62NHLzew=.5cfb4df3-2c17-4c8b-900d-976c51223d6d@github.com>
Message-ID: <JNBnXa-kQnJqxIzbqMNcKiLyaOu3y1BC_c-lrhxcvAc=.24fe9175-fcb8-40bf-aef5-e1bfea46705a@github.com>

On Fri, 29 Mar 2024 09:49:54 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Convert and open source these manual applet test to main based:
>> java/awt/Frame/MegaIconTest/MegaIconTest.html
>> java/awt/Frame/FrameMaximizedTest/FrameMaximizedTest.html
>> java/awt/Frame/FrameMinimizeTest/FrameMinimizeTest.html
>> java/awt/Frame/SizeMinimizedTest/SizeMinimizedTest.html
>> 
>> Automated the test SizeMinimizedTest.java. Since the test is failing Linux arch (Maybe related to the bug - [JDK-8305915](https://bugs.openjdk.org/browse/JDK-8305915)), the test is problem listed for Linux arch until the issue is fixed/further investigation is done.
>
> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Reveiw updates and SizeMinimizedTest converted to auto test

Changes requested by honkar (Reviewer).

test/jdk/java/awt/Frame/MegaIconTest/MegaIconTest.java line 58:

> 56:         String INSTRUCTIONS = """
> 57:                 Each of the buttons in the main window represents a test
> 58:                 of certain icon functionality - transparency/opacity, scaling etc.

The instructions would be more clear if stated as - **background transparency/opacity of the icon**.

test/jdk/java/awt/Frame/MegaIconTest/MegaIconTest.java line 194:

> 192:         setLayout(new BorderLayout());
> 193: 
> 194:         //Add the icon graphic and instructions to the Frame

The background transparency of different gifs can be checked by setting the background of the Frame to a different color.  For instance `setBackground(Color.YELLOW)` here and in the original test.

Adding a different background color instead of white makes it easier for the tester to compare the different types of icon.

-------------

PR Review: https://git.openjdk.org/jdk/pull/18448#pullrequestreview-1969318862
PR Review Comment: https://git.openjdk.org/jdk/pull/18448#discussion_r1544765763
PR Review Comment: https://git.openjdk.org/jdk/pull/18448#discussion_r1544761418

From honkar at openjdk.org  Fri Mar 29 18:48:33 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Fri, 29 Mar 2024 18:48:33 GMT
Subject: RFR: 8328482: Convert and Open source few manual applet test to
 main based [v3]
In-Reply-To: <qHuX72iinIVdWtmEr5kLwimMo3yDw570GyIN4DHj4dE=.34454519-90c7-4f39-a922-3ebb94378b36@github.com>
References: <aV9yYWUEsrakxmujJCq2LzFg5K6nyCV4aELge8c1oJo=.c9f2c13d-337f-4af3-8a38-551a7f0ba0c6@github.com>
 <Pi6RvL9Fn2ID3Biiiw3BSJF6kCmnMb2jRJlQgK4jVoQ=.c768550e-5e11-40ee-aa74-2f6afc486d8a@github.com>
 <2-p_eBzRl8-4ySpcKqginStUCxYkAiwXl5V1reP4U-w=.44afc483-cd4f-4712-a567-27e18323d814@github.com>
 <1992auBhw5Hjt_wfBcPe21bnsizooxn3TcWoCddI_gk=.b388017f-0dcf-4198-8ac1-55ec7b147081@github.com>
 <qHuX72iinIVdWtmEr5kLwimMo3yDw570GyIN4DHj4dE=.34454519-90c7-4f39-a922-3ebb94378b36@github.com>
Message-ID: <mbik3EJdd71PGKeGJINRdWw6kMWy_Fpd5XnykBBSl1Y=.d96a4d92-593c-4489-b2bd-8895b569485e@github.com>

On Wed, 27 Mar 2024 03:31:00 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Probably waiting for me to OK it off-line. I've now done so.
>
> Pushed it now.

Does the test mean opaque icon background by "opaque icon"? If yes, then should we use one .gif with opaque background and another with transparent background. Currently both gif files - **dukeWave.gif and fight.gif**, have transparent backgrounds.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18448#discussion_r1544758085

From aivanov at openjdk.org  Fri Mar 29 19:08:33 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Fri, 29 Mar 2024 19:08:33 GMT
Subject: RFR: 8324807 : Manual printer tests have no Pass/Fail buttons,
 instructions close set 2 [v13]
In-Reply-To: <H0UV3U9sSiFH-4iBraSfzpBQfidHVi7oXFGR-yAps3o=.30b35bdb-781f-4457-bbb6-36b8b8687989@github.com>
References: <UZ9jtQbkj-MoeLoccJnd2_3ciCCy9n-CD5vDv0hVKME=.f67db96d-92e6-46a1-9bb6-4fe77c9a8c4e@github.com>
 <H0UV3U9sSiFH-4iBraSfzpBQfidHVi7oXFGR-yAps3o=.30b35bdb-781f-4457-bbb6-36b8b8687989@github.com>
Message-ID: <3QNdSU2J2p3l_Am4vtKQoqml_5whRJNs-1b4f26X11c=.5f63a147-9df6-4291-8c7b-c46429517f72@github.com>

On Tue, 19 Mar 2024 09:24:35 GMT, Renjith Kannath Pariyangad <rkannathpari at openjdk.org> wrote:

>> Hi Reviewers,
>> 
>> Updated manual printer test cases with 'PassFailJFrame', also removed unused variables. Added 'SkippedException' in case of printer missing or not configured.
>> 
>> Please review and let me know your suggestions.
>> 
>> Regards,
>> Renjith
>
> Renjith Kannath Pariyangad has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Updated PassFailJFrame object creation

Changes requested by aivanov (Reviewer).

test/jdk/java/awt/print/PrinterJob/Collate2DPrintingTest.java line 24:

> 22:  */
> 23: 
> 24: import java.awt.Frame;

Suggestion:


`Frame` is no longer used.

test/jdk/java/awt/print/PrinterJob/InvalidPage.java line 25:

> 23: 
> 24: import java.awt.Color;
> 25: import java.awt.Frame;

Suggestion:


Frame is no longer used.

test/jdk/java/awt/print/PrinterJob/JobName/PrinterJobName.java line 51:

> 49:         }
> 50: 
> 51:         PassFailJFrame passFailJFrame = new PassFailJFrame.Builder()

Suggestion:

        PassFailJFrame passFailJFrame = PassFailJFrame.builder()

You have to use the `builder()` method.

-------------

PR Review: https://git.openjdk.org/jdk/pull/17608#pullrequestreview-1969360561
PR Review Comment: https://git.openjdk.org/jdk/pull/17608#discussion_r1544773033
PR Review Comment: https://git.openjdk.org/jdk/pull/17608#discussion_r1544786464
PR Review Comment: https://git.openjdk.org/jdk/pull/17608#discussion_r1544792178

From aivanov at openjdk.org  Fri Mar 29 19:08:34 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Fri, 29 Mar 2024 19:08:34 GMT
Subject: RFR: 8324807 : Manual printer tests have no Pass/Fail buttons,
 instructions close set 2 [v10]
In-Reply-To: <-3Z3D3ZejKBGJxG_3x26fcoUx2MzUa4vQejYWFRo1-I=.29bf2730-c42a-4f37-a4ad-b14ca74fc025@github.com>
References: <UZ9jtQbkj-MoeLoccJnd2_3ciCCy9n-CD5vDv0hVKME=.f67db96d-92e6-46a1-9bb6-4fe77c9a8c4e@github.com>
 <3EjlqyLzNCZxo6F1YSOs2zRrNxO5QTIQxkuY27Y3Ro4=.f13abdf7-f15f-44fc-9068-15f3ccda0958@github.com>
 <-3Z3D3ZejKBGJxG_3x26fcoUx2MzUa4vQejYWFRo1-I=.29bf2730-c42a-4f37-a4ad-b14ca74fc025@github.com>
Message-ID: <EqSoaPUaL5MZcRR-dN3BoF6I9PjdwMwDz5lnudXdIS0=.8330b860-530d-4ddb-92ee-dfb0c48aff88@github.com>

On Tue, 5 Mar 2024 13:15:04 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Renjith Kannath Pariyangad has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Updated instruction
>
> test/jdk/java/awt/print/PrinterJob/DrawImage.java line 93:
> 
>> 91:         if (pj.printDialog()) {
>> 92:             pj.print();
>> 93:         }
> 
> Fail the test if the tester clicks Cancel in the print dialog?

I still think the test should fail if Cancel is clicked in the Print dialog.

The test does not provide an option to do it again.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17608#discussion_r1544776413

From aivanov at openjdk.org  Fri Mar 29 19:27:33 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Fri, 29 Mar 2024 19:27:33 GMT
Subject: RFR: 8324808 : Manual printer tests have no Pass/Fail buttons,
 instructions close set 3 [v12]
In-Reply-To: <PRKmgKHOtiP-8vog0IQjkYXsm1KF0T-1VIrRc0WIohs=.b989ffe2-2c87-420c-8f0a-26bf27a4b41c@github.com>
References: <BFuAfPibaBpToXKzPNGUKf6pC1DvjrAedYHdtJxtuO8=.d54fcf6c-0727-4a4e-8a94-73a4ebe78af4@github.com>
 <PRKmgKHOtiP-8vog0IQjkYXsm1KF0T-1VIrRc0WIohs=.b989ffe2-2c87-420c-8f0a-26bf27a4b41c@github.com>
Message-ID: <0dp-QhjrLYBlIE1UyiI9zmn04RT7du7OYg2HBllYlZE=.931da52c-68bc-4a32-8696-4624bed776fa@github.com>

On Thu, 7 Mar 2024 07:13:02 GMT, Renjith Kannath Pariyangad <rkannathpari at openjdk.org> wrote:

>> Hi Reviewers,
>> 
>> Updated manual printer test cases with 'PassFailJFrame', also removed unused variables. Added 'SkippedException' in case of printer missing or not configured.
>> 
>> Please review and let me know your suggestions.
>> 
>> Regards,
>> Renjith
>
> Renjith Kannath Pariyangad has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Updated instructions

Marked as reviewed by aivanov (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/17609#pullrequestreview-1969461581

From aivanov at openjdk.org  Fri Mar 29 19:33:36 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Fri, 29 Mar 2024 19:33:36 GMT
Subject: RFR: 8320676 : Manual printer tests have no Pass/Fail buttons,
 instructions close set 1 [v13]
In-Reply-To: <aJ38KyKWM4IMANDPnfed-auiBzf7my_YDpRfDOvq9Zg=.dddf005b-9d91-415b-b139-9e9b064a7880@github.com>
References: <Afd90FypFvXYNR17jgkxcFj2LlxdLlZ1Bgd7WctdKcU=.2a8b05e0-a476-4598-8524-a22a0f54b8a5@github.com>
 <aJ38KyKWM4IMANDPnfed-auiBzf7my_YDpRfDOvq9Zg=.dddf005b-9d91-415b-b139-9e9b064a7880@github.com>
Message-ID: <aHf4RoiQkqVJbIo-rLdXlbmWPtPXg0OBKgRXLDfibSM=.260b7011-3830-4329-bc1e-0036bc099f84@github.com>

On Thu, 7 Mar 2024 09:27:10 GMT, Renjith Kannath Pariyangad <rkannathpari at openjdk.org> wrote:

>> Hi Reviewers,
>> 
>> Updated manual printer test cases with 'PassFailJFrame', also removed unused variables. Added 'SkippedException' in case of printer missing or not configured.
>> 
>> Please review and let me know your suggestions.
>> 
>> Regards,
>> Renjith
>
> Renjith Kannath Pariyangad has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Updated instructions

Changes requested by aivanov (Reviewer).

test/jdk/java/awt/print/PrinterJob/PrintAllFonts.java line 62:

> 60:         }
> 61: 
> 62:         PassFailJFrame passFailJFrame = new PassFailJFrame.Builder()

Suggestion:

        PassFailJFrame passFailJFrame = PassFailJFrame.builder()

You have to use the `builder()` method, otherwise the test will fail to compile after integration. See PR #18206 for [JDK-8325851](https://bugs.openjdk.org/browse/JDK-8325851).

-------------

PR Review: https://git.openjdk.org/jdk/pull/17607#pullrequestreview-1969477088
PR Review Comment: https://git.openjdk.org/jdk/pull/17607#discussion_r1544807647

From aivanov at openjdk.org  Fri Mar 29 20:06:32 2024
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Fri, 29 Mar 2024 20:06:32 GMT
Subject: RFR: 8327137: Add test for ConcurrentModificationException in
 BasicDirectoryModel [v3]
In-Reply-To: <Eadgxsc2VSQ7iIurWWF2zIJQhkZTjUckpuHz5QRNDDE=.05f61803-966a-421f-afe2-3ecd3ef00d34@github.com>
References: <mCqqjrXVWDB2PvpOhKHx-Hr8W6tUz6v4stztGmyAeEg=.1f95da1c-e1a5-40be-be8b-0758729fa9b9@github.com>
 <HvJ96YzIfnTtdNh7R5XtYs_t0sc5VfHjBHUxi9uyJdI=.94715923-e3c0-4666-9a51-340ef91b8b3b@github.com>
 <V1fPYAjQ6U8TFSOTRQ-Fk9dRnFAwbimWAPUkicxtklk=.6fe019f2-a478-4e11-8c02-b606f8f14709@github.com>
 <Chb_zgl53KY05-E3fKBAF61S8SO4Bi7LMlGkART_3io=.7845c015-4fd7-4ce5-bf27-7994cbf2471a@github.com>
 <d5JjW3jU1caR7NXz_sfQ78zXMSmxqLi_ony4WorDSh8=.5122b277-8ddc-40a0-a6ec-a5ae6226246b@github.com>
 <yhqPAJ3HPjy7RrrmTSNbkPIIgnndqaNkqN4cwsJYd6A=.121a9971-5f09-4977-847a-8971d7a359e5@github.com>
 <6d2hOVnBZtRQHhxPoA6sHpdeIvH32SwJ0HZavVCP33E=.c6d37335-0420-467b-83aa-129abd47fd87@github.com>
 <2cuoh1-d70-IvJOpVIBJbBfMh8hAg-nYZpu-Do9p8hE=.e1f841a4-04b3-4fc4-a99f-679d63e464b7@github.com>
 <Eadgxsc2VSQ7iIurWWF2zIJQhkZTjUckpuHz5QRNDDE=.05f61803-966a-421f-afe2-3ecd3ef00d34@github.com>
Message-ID: <N5yq2AXCGYJQiL-rB7WAoXs2ACum-BC6yDNMoqNbO-Q=.f9e487a3-f4f5-4f63-a94e-bf544d6c3bcd@github.com>

On Fri, 29 Mar 2024 02:00:18 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

> > However, there are cases where instantiating and testing is safe on main thread.
> 
> That is my point, make it less safe - when the component is created on one thread:EDT and then for some reason accessed on a different thread, the rescanCurrentDirectory should still work.

I got your idea!

However, I still see no benefit for doing it.

Yes, when `JFileChooser` is instantiated, it creates its UI delegates and the default model, `BasicDirectoryModel`. The constructor of the model calls `validateFileCache` which starts the background thread and will update `fileCache`.

It does not make the initialisation less thread-safe: the same two threads are involved ? `FilesLoader` and EDT. Yet there's no race yet?

The `ConcurrentModificationException` is thrown when the background `FilesLoader` is iterating over `fileCache` while EDT runs `DoChangeContents.run` which adds elements to `fileCache` or removes elements from it.

By the time the `Scanner` threads start, a race becomes possible. If the initial `FilesLoader` completes and posts the `DoChangeContents` object to EDT, the `FilesLoader` threads created by the scanners will race? but `fileCache` is empty initially, thus iterating over it is very quick.

Therefore getting `ConcurrentModificationException` is unlikely until `fileCache` contains a list of files. This state is reached later in the timeline of the test.

The initial `FilesLoader` thread that's started when `JFileChooser` is instantiated plays a role too? Yet it's running concurrently with the `Scanner` threads whether the `JFileChooser` object is created on the current thread or on EDT.

---

Taking the above into account, instantiating `JFileChooser` on EDT adds complexity to the test but brings no benefits.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18109#discussion_r1544825191

From djelinski at openjdk.org  Fri Mar 29 21:09:57 2024
From: djelinski at openjdk.org (Daniel =?UTF-8?B?SmVsacWEc2tp?=)
Date: Fri, 29 Mar 2024 21:09:57 GMT
Subject: RFR: 8329340: Remove unused libawt code
Message-ID: <soXzrbPM_yKPwrrJkpIe4pQlWKMfdJ0MM87MV7WmTDE=.10c905d1-15de-4b85-91c3-bce72065000f@github.com>

Please review this PR that removes unused functions, variables, and WM_AWT window messages.

The unused code was detected by automated analysis (MSVC compiler and linker, CodeQL analyzer). I manually verified every symbol before removing. Mach5 client libs testing clean.

Some WM_AWT messages have different IDs after this change. The IDs have changed a few times before, so I think this shouldn't be a problem.

-------------

Commit messages:
 - Remove unused variables
 - Remove OLEHolder
 - Remove EnvHolder
 - Remove jFontToWFontA
 - Remove awtIEClazz
 - Remove DumpRegion
 - Remove IsSupportedLevel
 - Remove GDIWinSD_SimpleClip
 - Remove GDIWinSD_CheckMonitorArea
 - Remove SetHeapCheck
 - ... and 10 more: https://git.openjdk.org/jdk/compare/7ac2f914...cbf7bbd3

Changes: https://git.openjdk.org/jdk/pull/18553/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18553&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8329340
  Stats: 711 lines in 23 files changed: 0 ins; 709 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/18553.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18553/head:pull/18553

PR: https://git.openjdk.org/jdk/pull/18553

From prr at openjdk.org  Fri Mar 29 21:53:40 2024
From: prr at openjdk.org (Phil Race)
Date: Fri, 29 Mar 2024 21:53:40 GMT
Subject: RFR: 8329340: Remove unused libawt code
In-Reply-To: <soXzrbPM_yKPwrrJkpIe4pQlWKMfdJ0MM87MV7WmTDE=.10c905d1-15de-4b85-91c3-bce72065000f@github.com>
References: <soXzrbPM_yKPwrrJkpIe4pQlWKMfdJ0MM87MV7WmTDE=.10c905d1-15de-4b85-91c3-bce72065000f@github.com>
Message-ID: <2km6y_QLwbgfzwsJ6tyYMJ6VLyO8pxTABAWPFMEzo48=.915dd7d5-cdbb-4003-8a46-799e8dbafc52@github.com>

On Fri, 29 Mar 2024 18:23:27 GMT, Daniel Jeli?ski <djelinski at openjdk.org> wrote:

> Please review this PR that removes unused functions, variables, and WM_AWT window messages.
> 
> The unused code was detected by automated analysis (MSVC compiler and linker, CodeQL analyzer). I manually verified every symbol before removing. Mach5 client libs testing clean.
> 
> Some WM_AWT messages have different IDs after this change. The IDs have changed a few times before, so I think this shouldn't be a problem.

About the WM_AWT messages, how did these tools you mention figure out no message of that name / ID is ever created ?
I presume that's what you must have done to decide it is OK to remove the handling of these messages.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18553#issuecomment-2027769180

From manc at openjdk.org  Fri Mar 29 23:05:53 2024
From: manc at openjdk.org (Man Cao)
Date: Fri, 29 Mar 2024 23:05:53 GMT
Subject: RFR: 8329352: Remove dead code in splashscreen_sys.c
Message-ID: <xe-wpIn8dHrfbjI1ZlHq4ad_s4UHnH7_ZDPB1kucFrM=.8a0a0d84-683c-40cc-ace1-e887abd58a10@github.com>

Hi all,

Could anyone review this trivial change to remove dead code in splashscreen_sys.c?

-Man

-------------

Commit messages:
 - 8329352: Remove dead code in splashscreen_sys.c

Changes: https://git.openjdk.org/jdk/pull/18556/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18556&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8329352
  Stats: 29 lines in 1 file changed: 0 ins; 29 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18556.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18556/head:pull/18556

PR: https://git.openjdk.org/jdk/pull/18556

From honkar at openjdk.org  Fri Mar 29 23:59:32 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Fri, 29 Mar 2024 23:59:32 GMT
Subject: RFR: 8328403: Remove applet usage from JColorChooser tests
 Test6977726 [v6]
In-Reply-To: <w9RcR7vq_uXYgjKnAiyD3vDe1-kOx1CI7DgobHrfvEs=.b320c580-646e-4f9b-aa02-7c256f80a338@github.com>
References: <pyfxVdApSNSisMJieBTl5HSZKDmSSiPie0tnrM_rwe4=.5ffc4e92-cbcf-44d8-9a51-b4e8330e1be9@github.com>
 <w9RcR7vq_uXYgjKnAiyD3vDe1-kOx1CI7DgobHrfvEs=.b320c580-646e-4f9b-aa02-7c256f80a338@github.com>
Message-ID: <qAPuhOprCg-Oe-pMsZa7w8cJqHa8-C3Mo_q-77mzh3o=.67eaea15-855c-4fc3-8af9-40f52055442b@github.com>

On Fri, 29 Mar 2024 04:40:55 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> Removing applet usage from manual JColorChooser tests
>
> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   update test from feedback

LGTM

-------------

Marked as reviewed by honkar (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18369#pullrequestreview-1969691001

From honkar at openjdk.org  Sat Mar 30 00:03:30 2024
From: honkar at openjdk.org (Harshitha Onkar)
Date: Sat, 30 Mar 2024 00:03:30 GMT
Subject: RFR: 8329320: Simplify awt/print/PageFormat/NullPaper.java test
In-Reply-To: <0CQ06Dw6Uwa9Z2lLfqFhdAWxWVLiYJs-EoziVLODxlw=.0133d820-1a13-4813-bc20-c9358fcbc58c@github.com>
References: <0CQ06Dw6Uwa9Z2lLfqFhdAWxWVLiYJs-EoziVLODxlw=.0133d820-1a13-4813-bc20-c9358fcbc58c@github.com>
Message-ID: <R9d3udyFBj05SjdeMErtspCPTJp7bVKkbsf_Wn6ENQU=.6a467ea5-b4af-4aa3-b01a-9774ef1fe11c@github.com>

On Fri, 29 Mar 2024 12:45:36 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> Remove all the leftovers of the _"standard instructions" machinery_ from the `NullPaper.java` test.
> 
> The test code consists of two lines now: concise and clear.

LGTM.

-------------

Marked as reviewed by honkar (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18547#pullrequestreview-1969691839

From jiefu at openjdk.org  Sat Mar 30 02:45:30 2024
From: jiefu at openjdk.org (Jie Fu)
Date: Sat, 30 Mar 2024 02:45:30 GMT
Subject: RFR: 8329352: Remove dead code in splashscreen_sys.c
In-Reply-To: <xe-wpIn8dHrfbjI1ZlHq4ad_s4UHnH7_ZDPB1kucFrM=.8a0a0d84-683c-40cc-ace1-e887abd58a10@github.com>
References: <xe-wpIn8dHrfbjI1ZlHq4ad_s4UHnH7_ZDPB1kucFrM=.8a0a0d84-683c-40cc-ace1-e887abd58a10@github.com>
Message-ID: <K--r1hZH8MTznV7laSB6ekGjBsTCh26JkoPlQ0_qTAY=.c9db6e9e-599d-48e5-bf9c-1c8a1385bc94@github.com>

On Fri, 29 Mar 2024 23:00:56 GMT, Man Cao <manc at openjdk.org> wrote:

> Hi all,
> 
> Could anyone review this trivial change to remove dead code in splashscreen_sys.c?
> 
> -Man

LGTM

Shall we also update the copyright year?

-------------

Marked as reviewed by jiefu (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18556#pullrequestreview-1969730062

From manc at openjdk.org  Sat Mar 30 02:56:58 2024
From: manc at openjdk.org (Man Cao)
Date: Sat, 30 Mar 2024 02:56:58 GMT
Subject: RFR: 8329352: Remove dead code in splashscreen_sys.c [v2]
In-Reply-To: <xe-wpIn8dHrfbjI1ZlHq4ad_s4UHnH7_ZDPB1kucFrM=.8a0a0d84-683c-40cc-ace1-e887abd58a10@github.com>
References: <xe-wpIn8dHrfbjI1ZlHq4ad_s4UHnH7_ZDPB1kucFrM=.8a0a0d84-683c-40cc-ace1-e887abd58a10@github.com>
Message-ID: <UZDPXj4KPtZu2kqxDLNuQmwqiMkFU3jHG-RRba3v-2E=.d2fdd452-dd88-4940-8226-f0ffd6ebeed3@github.com>

> Hi all,
> 
> Could anyone review this trivial change to remove dead code in splashscreen_sys.c?
> 
> -Man

Man Cao has updated the pull request incrementally with one additional commit since the last revision:

  Update copyright year

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18556/files
  - new: https://git.openjdk.org/jdk/pull/18556/files/d7c512b1..6b555e96

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18556&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18556&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/18556.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18556/head:pull/18556

PR: https://git.openjdk.org/jdk/pull/18556

From manc at openjdk.org  Sat Mar 30 02:56:58 2024
From: manc at openjdk.org (Man Cao)
Date: Sat, 30 Mar 2024 02:56:58 GMT
Subject: RFR: 8329352: Remove dead code in splashscreen_sys.c
In-Reply-To: <xe-wpIn8dHrfbjI1ZlHq4ad_s4UHnH7_ZDPB1kucFrM=.8a0a0d84-683c-40cc-ace1-e887abd58a10@github.com>
References: <xe-wpIn8dHrfbjI1ZlHq4ad_s4UHnH7_ZDPB1kucFrM=.8a0a0d84-683c-40cc-ace1-e887abd58a10@github.com>
Message-ID: <98jQ2ZipC2SQ-VFv8WQwCXjXERYZBy5NfYWNUuTOjqM=.4883d2e5-9e46-4c89-86cd-e0df14afcffe@github.com>

On Fri, 29 Mar 2024 23:00:56 GMT, Man Cao <manc at openjdk.org> wrote:

> Hi all,
> 
> Could anyone review this trivial change to remove dead code in splashscreen_sys.c?
> 
> -Man

Thanks, updated copyright year.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18556#issuecomment-2027889334

From jiefu at openjdk.org  Sat Mar 30 03:13:33 2024
From: jiefu at openjdk.org (Jie Fu)
Date: Sat, 30 Mar 2024 03:13:33 GMT
Subject: RFR: 8329352: Remove dead code in splashscreen_sys.c [v2]
In-Reply-To: <UZDPXj4KPtZu2kqxDLNuQmwqiMkFU3jHG-RRba3v-2E=.d2fdd452-dd88-4940-8226-f0ffd6ebeed3@github.com>
References: <xe-wpIn8dHrfbjI1ZlHq4ad_s4UHnH7_ZDPB1kucFrM=.8a0a0d84-683c-40cc-ace1-e887abd58a10@github.com>
 <UZDPXj4KPtZu2kqxDLNuQmwqiMkFU3jHG-RRba3v-2E=.d2fdd452-dd88-4940-8226-f0ffd6ebeed3@github.com>
Message-ID: <hG80i8s0imd_xRJa9Ivydoo-k4FMu6_5cmfW6sunH4A=.37f129f0-018f-454b-8e9d-b51d913563df@github.com>

On Sat, 30 Mar 2024 02:56:58 GMT, Man Cao <manc at openjdk.org> wrote:

>> Hi all,
>> 
>> Could anyone review this trivial change to remove dead code in splashscreen_sys.c?
>> 
>> -Man
>
> Man Cao has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update copyright year

Marked as reviewed by jiefu (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18556#pullrequestreview-1969733161

From djelinski at openjdk.org  Sat Mar 30 08:37:30 2024
From: djelinski at openjdk.org (Daniel =?UTF-8?B?SmVsacWEc2tp?=)
Date: Sat, 30 Mar 2024 08:37:30 GMT
Subject: RFR: 8329340: Remove unused libawt code
In-Reply-To: <2km6y_QLwbgfzwsJ6tyYMJ6VLyO8pxTABAWPFMEzo48=.915dd7d5-cdbb-4003-8a46-799e8dbafc52@github.com>
References: <soXzrbPM_yKPwrrJkpIe4pQlWKMfdJ0MM87MV7WmTDE=.10c905d1-15de-4b85-91c3-bce72065000f@github.com>
 <2km6y_QLwbgfzwsJ6tyYMJ6VLyO8pxTABAWPFMEzo48=.915dd7d5-cdbb-4003-8a46-799e8dbafc52@github.com>
Message-ID: <drNCppLbFlqbAUS_hZrGnT5OJj2xd144ijlUv0fYfno=.12255379-670b-4b6b-b84f-6e47e5a5d7d1@github.com>

On Fri, 29 Mar 2024 21:51:25 GMT, Phil Race <prr at openjdk.org> wrote:

> About the WM_AWT messages, how did these tools you mention figure out no message of that name / ID is ever created ?
I presume that's what you must have done to decide it is OK to remove the handling of these messages.

Well, that part was actually me. The linker reported that `AwtObject::WinThreadExec` was unused; while removing it, I found that `WM_AWT_EXECUTE_SYNC` is no longer needed, so I removed it as well. Then I figured that there may be other left over WM_AWT messages, so I checked the entire enum in awtmsg.h. I removed every enum constant that was never used outside of the WIN_MSG macro or a case label.

I checked the history for some of the messages; WM_AWT_FORWARD_BYTE was last used before e4f977c0a1663dd71aa19019d55b07d87ad667e2, and the last use of WM_AWT_SHOWCURSOR / WM_AWT_HIDECURSOR was removed in e4c9db984fe1a3a9d06fb60e333e92df3b165454. WM_AWT_SET_SCROLL_INFO was not used anywhere in git history. The other removed enums aren't used anywhere.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18553#issuecomment-2027971998

From alexsch at openjdk.org  Sat Mar 30 18:31:34 2024
From: alexsch at openjdk.org (Alexander Scherbatiy)
Date: Sat, 30 Mar 2024 18:31:34 GMT
Subject: RFR: 8314070: javax.print: Support IPP output-bin attribute
 extension [v5]
In-Reply-To: <8gavB4YcAInb0RiAoUsusYfbXxJgHizxZ0WMvbDUNOg=.ada34789-cc69-4474-918c-6ec8f50f3111@github.com>
References: <NXwdDAcdcm_s9B3HbmPyt1RgXBCLXm4TvIPudLvPEFc=.90579103-04b2-4813-96ee-37844ef3eb83@github.com>
 <1IZMIOuXSec2PYnGvp5rTDBFDatCsAh1lcZOhwTR2oM=.058bb44a-b228-41af-99fc-de0f602370fb@github.com>
 <mMaO8mcFqQi3r_YVWGXoYH3rlOSZlNF-mNIXeVXpabg=.26a61f05-1812-4843-a3d1-b94395dc324a@github.com>
 <8gavB4YcAInb0RiAoUsusYfbXxJgHizxZ0WMvbDUNOg=.ada34789-cc69-4474-918c-6ec8f50f3111@github.com>
Message-ID: <BleT7ov8uzCcH3mtf0C4XPU0xIrWAF0BKke5m25hDws=.34455140-f759-4b3c-9cee-df98a79f2d0a@github.com>

On Fri, 2 Feb 2024 17:38:00 GMT, Alexander Scherbatiy <alexsch at openjdk.org> wrote:

> This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16166#issuecomment-2028433717

From prr at openjdk.org  Sat Mar 30 21:20:31 2024
From: prr at openjdk.org (Phil Race)
Date: Sat, 30 Mar 2024 21:20:31 GMT
Subject: RFR: 8329352: Remove dead code in splashscreen_sys.c [v2]
In-Reply-To: <UZDPXj4KPtZu2kqxDLNuQmwqiMkFU3jHG-RRba3v-2E=.d2fdd452-dd88-4940-8226-f0ffd6ebeed3@github.com>
References: <xe-wpIn8dHrfbjI1ZlHq4ad_s4UHnH7_ZDPB1kucFrM=.8a0a0d84-683c-40cc-ace1-e887abd58a10@github.com>
 <UZDPXj4KPtZu2kqxDLNuQmwqiMkFU3jHG-RRba3v-2E=.d2fdd452-dd88-4940-8226-f0ffd6ebeed3@github.com>
Message-ID: <TErSg_m1aDEkFPx8cpVfRiKR4UfXtYboWGRunwpA_Jw=.2cacb5f4-3247-4244-a1c5-cb912a19b1fc@github.com>

On Sat, 30 Mar 2024 02:56:58 GMT, Man Cao <manc at openjdk.org> wrote:

>> Hi all,
>> 
>> Could anyone review this trivial change to remove dead code in splashscreen_sys.c?
>> 
>> -Man
>
> Man Cao has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update copyright year

/Reviewers 2

src/java.desktop/unix/native/libsplashscreen/splashscreen_sys.c line 393:

> 391:     pthread_mutex_init(&splash->lock, NULL);
> 392: 
> 393:     // We should not ignore any errors.

The 2nd commented out call looks like it might have been doing something better than the default handler,
but not by so much as to matter. 
The comment seems a bit inappropriate now and I'm puzzled why we need to reinstall the default handler
(ie the call taking NULL), since we haven't installed a non-default handler anyway.
I'd be inclined to remove the comment and the call.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18556#issuecomment-2028470907
PR Review Comment: https://git.openjdk.org/jdk/pull/18556#discussion_r1545497667

From serb at openjdk.org  Sun Mar 31 22:42:34 2024
From: serb at openjdk.org (Sergey Bylokhov)
Date: Sun, 31 Mar 2024 22:42:34 GMT
Subject: RFR: 8327137: Add test for ConcurrentModificationException in
 BasicDirectoryModel [v3]
In-Reply-To: <UUsO_EIt0zPtpVszwLEVfDD-oBjT2UBnsbvdd9746-g=.9a6d10be-825a-4388-adfd-21b79e0f8731@github.com>
References: <mCqqjrXVWDB2PvpOhKHx-Hr8W6tUz6v4stztGmyAeEg=.1f95da1c-e1a5-40be-be8b-0758729fa9b9@github.com>
 <UUsO_EIt0zPtpVszwLEVfDD-oBjT2UBnsbvdd9746-g=.9a6d10be-825a-4388-adfd-21b79e0f8731@github.com>
Message-ID: <NQ4HSyxneztY22zRb5J0gRIx7dEHDtxZFH-y_GG4190=.0aa4c869-7c23-43c6-b94f-a34d0a4d1548@github.com>

On Fri, 15 Mar 2024 14:45:36 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> I'm adding a regression test for [JDK-8323670](https://bugs.openjdk.org/browse/JDK-8323670) and [JDK-8307091](https://bugs.openjdk.org/browse/JDK-8307091); it's also a regression test for [JDK-8240690](https://bugs.openjdk.org/browse/JDK-8240690).
>> 
>> I referenced this test in PR #17462 in [this comment](https://github.com/openjdk/jdk/pull/17462#issuecomment-1914844026). I fine-tuned the test since that time.
>> 
>> The test doesn't fail all the time without the fix for JDK-8323670, however, it fails sometimes. If you run the test several times, it will likely fail _without the fix_.
>> 
>> For me, the test fails about 10 times from 40 runs in the CI. It fails on macOS more frequently than on Linux.
>> 
>> When the test passes, it usually completes in 5 minutes.
>> 
>> **How the test works**
>> 
>> The test creates a temporary directory in the current directory and creates a number of files in it. (The number of files is controlled by `NUMBER_OF_THREADS` constant). Then the test creates `JFileChooser` in the temporary directory.
>> 
>> The test starts several _scanner_ threads, the number is controlled by `NUMBER_OF_THREADS`, which repeatedly call `fileChooser.rescanCurrentDirectory()`. This results in calling `BasicDirectoryModel.validateFileCache` which starts a background thread ? "Basic L&F File Loading Thread" ? to enumerate the files.
>> 
>> A timer is used to create new files in the directory that the file chooser is using.
>> 
>> After enumerating the files, the File Loading Thread posts an event to EDT. The event updates `fileCache` and fires a `ListDataEvent`.
>> 
>> If the File Loading Thread is iterating over `fileCache` using `Iterator` (when `fileCache.subList` or `fileCache.equals` is running; or a new `Vector` instance is created from a `fileCache` or its sublist) and `fileCache` is being updated on EDT, then `ConcurrentModificationException` is thrown.
>> 
>> On Linux and on _headless_ macOS, `ShellFolder.invoke` is executed in the caller, which makes it easier to reproduce the issue. Because of [JDK-8325179](https://bugs.openjdk.org/browse/JDK-8325179), there are several File Loading Threads, which also helps to reproduce the issue.
>> 
>> On _headful_ macOS, the `BasicDirectoryModel` is not used, so the test does not reproduce the issue.
>> 
>> On Windows, the test does not fail or fails with `OutOfMemoryError`. It is because all the File Loading Threads are serialised on the COM thread, `ShellFolder.invoke` submits the task to the COM thread and waits for i...
>
> Alexey Ivanov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Suppress throwing exceptions while deleting files

Marked as reviewed by serb (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18109#pullrequestreview-1970499628

From serb at openjdk.org  Sun Mar 31 22:42:35 2024
From: serb at openjdk.org (Sergey Bylokhov)
Date: Sun, 31 Mar 2024 22:42:35 GMT
Subject: RFR: 8327137: Add test for ConcurrentModificationException in
 BasicDirectoryModel [v3]
In-Reply-To: <N5yq2AXCGYJQiL-rB7WAoXs2ACum-BC6yDNMoqNbO-Q=.f9e487a3-f4f5-4f63-a94e-bf544d6c3bcd@github.com>
References: <mCqqjrXVWDB2PvpOhKHx-Hr8W6tUz6v4stztGmyAeEg=.1f95da1c-e1a5-40be-be8b-0758729fa9b9@github.com>
 <HvJ96YzIfnTtdNh7R5XtYs_t0sc5VfHjBHUxi9uyJdI=.94715923-e3c0-4666-9a51-340ef91b8b3b@github.com>
 <V1fPYAjQ6U8TFSOTRQ-Fk9dRnFAwbimWAPUkicxtklk=.6fe019f2-a478-4e11-8c02-b606f8f14709@github.com>
 <Chb_zgl53KY05-E3fKBAF61S8SO4Bi7LMlGkART_3io=.7845c015-4fd7-4ce5-bf27-7994cbf2471a@github.com>
 <d5JjW3jU1caR7NXz_sfQ78zXMSmxqLi_ony4WorDSh8=.5122b277-8ddc-40a0-a6ec-a5ae6226246b@github.com>
 <yhqPAJ3HPjy7RrrmTSNbkPIIgnndqaNkqN4cwsJYd6A=.121a9971-5f09-4977-847a-8971d7a359e5@github.com>
 <6d2hOVnBZtRQHhxPoA6sHpdeIvH32SwJ0HZavVCP33E=.c6d37335-0420-467b-83aa-129abd47fd87@github.com>
 <2cuoh1-d70-IvJOpVIBJbBfMh8hAg-nYZpu-Do9p8hE=.e1f841a4-04b3-4fc4-a99f-679d63e464b7@github.com>
 <Eadgxsc2VSQ7iIurWWF2zIJQhkZTjUckpuHz5QRNDDE=.05f61803-966a-421f-afe2-3ecd3ef00d34@github.com>
 <N5yq2AXCGYJQiL-rB7WAoXs2ACum-BC6yDNMoqNbO-Q=.f9e487a3-f4f5-4f63-a94e-bf544d6c3bcd@github.com>
Message-ID: <ef8Qpm3xuLRZaLR-M4EU1SyJNeoyc6DKDYdkRh2A17E=.a183d12a-cd4f-4864-85a5-675c04710381@github.com>

On Fri, 29 Mar 2024 20:02:53 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>>> However, there are cases where instantiating and testing is safe on main thread.
>> 
>> That is my point, make it less safe - when the component is created on one thread:EDT and then for some reason accessed on a different thread, the rescanCurrentDirectory should still work.
>
>> > However, there are cases where instantiating and testing is safe on main thread.
>> 
>> That is my point, make it less safe - when the component is created on one thread:EDT and then for some reason accessed on a different thread, the rescanCurrentDirectory should still work.
> 
> I got your idea!
> 
> However, I still see no benefit for doing it.
> 
> Yes, when `JFileChooser` is instantiated, it creates its UI delegates and the default model, `BasicDirectoryModel`. The constructor of the model calls `validateFileCache` which starts the background thread and will update `fileCache`.
> 
> It does not make the initialisation less thread-safe: the same two threads are involved ? `FilesLoader` and EDT. Yet there's no race yet?
> 
> The `ConcurrentModificationException` is thrown when the background `FilesLoader` is iterating over `fileCache` while EDT runs `DoChangeContents.run` which adds elements to `fileCache` or removes elements from it.
> 
> By the time the `Scanner` threads start, a race becomes possible. If the initial `FilesLoader` completes and posts the `DoChangeContents` object to EDT, the `FilesLoader` threads created by the scanners will race? but `fileCache` is empty initially, thus iterating over it is very quick.
> 
> Therefore getting `ConcurrentModificationException` is unlikely until `fileCache` contains a list of files. This state is reached later in the timeline of the test.
> 
> The initial `FilesLoader` thread that's started when `JFileChooser` is instantiated plays a role too? Yet it's running concurrently with the `Scanner` threads whether the `JFileChooser` object is created on the current thread or on EDT.
> 
> ---
> 
> Taking the above into account, instantiating `JFileChooser` on EDT adds complexity to the test but brings no benefits.

ok, I agree with you.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18109#discussion_r1545858033