RFR: 8286759: TextComponentPrintable: consequent -> consecutive positions

Phil Race prr at openjdk.org
Mon Mar 4 18:12:55 UTC 2024


On Thu, 29 Feb 2024 15:13:16 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> A trivial change in a comment: consequent → _consecutive_ positions.
> 
> This was found in [a code review](https://github.com/openjdk/jdk/pull/8328#discussion_r872596373) for [JDK-8285306](https://bugs.openjdk.org/browse/JDK-8285306).

src/java.desktop/share/classes/sun/swing/text/TextComponentPrintable.java line 785:

> 783:                          * we do not store the same value as previous. in our
> 784:                          * documents it is often for consecutive positions to have
> 785:                          * the same modelToView y and height.

If we are going to fix that, we might as well fix the entire sentence.
In particular I strongly suspect that the author meant "common" not "often".
"often" would only be correct here if used in a phrase like "often the case", but "common" is simpler.
And the usage of "previous" isn't right.
 I'm not sure I get what the commenter means to say here, perhaps "previously" ?

And capitalise "We", and "In" since they begin sentences

    * We do not store the same value as previously.
    * In our documents it is common for consequent positions to have
    * the same modelToView y and height.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18067#discussion_r1511570584


More information about the client-libs-dev mailing list