RFR: 8075917: The regression-swing case failed as the text on label is not painted red with the GTK L&F [v4]
Prasanta Sadhukhan
psadhukhan at openjdk.org
Tue Mar 5 03:07:49 UTC 2024
On Fri, 1 Mar 2024 10:38:21 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:
>> JLabel text is not painted with the LAF defined foreground color in GTK LAF. In GTK LAF the foreground color is retrieved by using native system APIs. Fix is to return the foreground color if it is set by LAF defined property otherwise return the default color by calling native APIs.
>> Applet based test has been converted to automatic test and check for all installed LAFs. CI testing is green for test suite and individual test. Link attached in JBS.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
>
> extended fix for disabled checkbox and radiobutton
src/java.desktop/share/classes/com/sun/java/swing/plaf/gtk/GTKStyle.java line 205:
> 203: Color c = (Color) get(context, "RadioButton.disabledText");
> 204: if (c != null) {
> 205: return c;
What about the enabled state text? WIll that not required to be handled?
Can this be done in a separate method passing in the required Java level property?
test/jdk/javax/swing/JRadioButton/4314194/bug4314194.java line 43:
> 41: import javax.swing.UIManager;
> 42: import javax.swing.UnsupportedLookAndFeelException;
> 43: import javax.swing.plaf.nimbus.NimbusLookAndFeel;
this bug id needs to be added in jtreg tag
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17763#discussion_r1512073988
PR Review Comment: https://git.openjdk.org/jdk/pull/17763#discussion_r1512074176
More information about the client-libs-dev
mailing list