RFR: 8320676 : Manual printer tests have no Pass/Fail buttons, instructions close set 1 [v6]
Alexey Ivanov
aivanov at openjdk.org
Tue Mar 5 12:47:55 UTC 2024
On Tue, 13 Feb 2024 14:01:40 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:
>> Renjith Kannath Pariyangad has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Fixed compiler error
>
> test/jdk/java/awt/print/PrinterJob/PrintAllFonts.java line 53:
>
>> 51: "\n" +
>> 52: "This bug is system dependent and is not always reproducible.\n" +
>> 53: "A passing test will have all text printed with correct font style.";
>
> Clarify that the second column should be proper *italics*. I don't know how to explain it better; you can look at the PDFs attached to [JDK-4884389](https://bugs.openjdk.org/browse/JDK-4884389) to understand better what the bug was.
I still suggest clarifying that the second column should always have the italic style and should use the italic font style if it's available (in the left column) instead of synthesised italic.
Look at the `1.4.2.pdf` file attached to [JDK-4884389](https://bugs.openjdk.org/browse/JDK-4884389).
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17607#discussion_r1512734177
More information about the client-libs-dev
mailing list