RFR: 8324808 : Manual printer tests have no Pass/Fail buttons, instructions close set 3 [v10]

[Alexey Ivanov]

On Wed, 6 Mar 2024 06:57:12 GMT, Renjith Kannath Pariyangad <rkannathpari at openjdk.org> wrote:

>> Hi Reviewers,
>> 
>> Updated manual printer test cases with 'PassFailJFrame', also removed unused variables. Added 'SkippedException' in case of printer missing or not configured.
>> 
>> Please review and let me know your suggestions.
>> 
>> Regards,
>> Renjith
>
> Renjith Kannath Pariyangad has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Added Override

Changes requested by aivanov (Reviewer).

test/jdk/java/awt/print/PrinterJob/PageDlgPrnButton.java line 54:

> 52:         if (serviceCount < 2) {
> 53:             throw new SkippedException("The test requires at least 2 printers.");
> 54:         }

This doesn't compile now. You didn't add the import for `jtreg.SkippedException`, nor did you modify the jtreg test to compile `SkippedException`.

test/jdk/java/awt/print/PrinterJob/PrintCompoundString.java line 43:

> 41:  * @key printer
> 42:  * @library /test/lib /java/awt/regtesthelpers
> 43:  * @build PassFailJFrame jtreg.SkippedException

You added `SkippedException` to the test that doesn't need it.

-------------

PR Review: https://git.openjdk.org/jdk/pull/17609#pullrequestreview-1919123845
PR Review Comment: https://git.openjdk.org/jdk/pull/17609#discussion_r1514068434
PR Review Comment: https://git.openjdk.org/jdk/pull/17609#discussion_r1514070364