RFR: 8324808 : Manual printer tests have no Pass/Fail buttons, instructions close set 3 [v11]

[Alexey Ivanov]

On Wed, 6 Mar 2024 09:46:58 GMT, Renjith Kannath Pariyangad <rkannathpari at openjdk.org> wrote:

>> Hi Reviewers,
>> 
>> Updated manual printer test cases with 'PassFailJFrame', also removed unused variables. Added 'SkippedException' in case of printer missing or not configured.
>> 
>> Please review and let me know your suggestions.
>> 
>> Regards,
>> Renjith
>
> Renjith Kannath Pariyangad has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fixed comple issue

There are quite a few other comments unresolved comments.

test/jdk/java/awt/print/PrinterJob/PageDlgPrnButton.java line 40:

> 38:  * @requires os.family=="windows"
> 39:  * @library /test/lib /java/awt/regtesthelpers
> 40:  * @build PassFailJFrame jtreg.SkippedException

Suggestion:

 * @library /test/lib /java/awt/regtesthelpers
 * @build jtreg.SkippedException PassFailJFrame

Change the order to align libraries and classes from the libraries?

-------------

Changes requested by aivanov (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17609#pullrequestreview-1920039700
PR Review Comment: https://git.openjdk.org/jdk/pull/17609#discussion_r1514664523