RFR: 8324808 : Manual printer tests have no Pass/Fail buttons, instructions close set 3 [v9]

Alexey Ivanov aivanov at openjdk.org
Wed Mar 6 15:33:52 UTC 2024


On Tue, 5 Mar 2024 14:56:22 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Renjith Kannath Pariyangad has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Suggesions added
>
> test/jdk/java/awt/print/PrinterJob/PrintImage.java line 57:
> 
>> 55:             "Printing must be done in Japanese 2nd Edition.\n" +
>> 56:             "Preferably Canon LaserShot A309GII.\n" +
>> 57:             "\n" +
> 
> Suggestion:
> 
> 
> I believe we can remove the first part of the instructions. The original bug [JDK-4298489](https://bugs.openjdk.org/browse/JDK-4298489) says printing by the first method was ugly and the second one was good. Both methods should produce the identical results.
> 
> According to the bug description, it was reported against Windows 95 OSR 2 although the instructions in the test refer to Windows 98 Second Edition and its Japanese version for whatever reason.

What about this comment?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17609#discussion_r1514684555


More information about the client-libs-dev mailing list