RFR: 8327492: Remove applet usage and update DisposeInActionEventTest.html [v10]

Harshitha Onkar honkar at openjdk.org
Wed Mar 6 20:51:48 UTC 2024


On Wed, 6 Mar 2024 20:13:58 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> Root cause of the test failure was fixed with https://bugs.openjdk.org/browse/JDK-8316931, updating this test since the other fix also included a test update.
>
> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   implemented changes from feedback

test/jdk/java/awt/TrayIcon/DisposeInActionEventTest/DisposeInActionEventTest.java line 84:

> 82:         } finally {
> 83:             systemTray.remove(trayIcon);
> 84:         }

@alisenchung I missed adding null check here earlier. It is good to have this safety check to avoid NPE.

Suggestion:

        } finally {
            if (systemTray != null) {
               systemTray.remove(trayIcon);
            }
         }

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17838#discussion_r1515135506


More information about the client-libs-dev mailing list