RFR: 8185862: AWT Assertion Failure in ::GetDIBits(hBMDC, hBM, 0, 1, 0, gpBitmapInfo, 0) 'awt_Win32GraphicsDevice.cpp', at line 185 [v2]

Phil Race prr at openjdk.org
Thu Mar 7 00:49:54 UTC 2024


On Tue, 5 Mar 2024 18:15:50 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> @prrace, Do you know how critical the code below is? Is it worth to code the fallback if the path to ::GetDIBits?

In the headLESS case we should never be here, since this is initializing the devices that don't exist in that case.
In the headFUL case I would prefer to keep the existing non-debug behaviour that we soldier on and try to do something sensible. Line 204 has a comment about a case in which GetDIBits really did fail and there's code to cope. I am writing specifically about GetDIBits.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17614#discussion_r1515338800


More information about the client-libs-dev mailing list