RFR: 8327492: Remove applet usage and update DisposeInActionEventTest.html [v11]

Alexey Ivanov aivanov at openjdk.org
Thu Mar 7 16:39:55 UTC 2024


On Thu, 7 Mar 2024 16:30:32 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> test/jdk/java/awt/TrayIcon/DisposeInActionEventTest/DisposeInActionEventTest.java line 63:
>> 
>>> 61:                        "  (also called Taskbar Status Area on MS Windows, Notification\n" +
>>> 62:                        "  Area on Gnome or System Tray on KDE) is visible.\n\n" +
>>> 63:                         clickInstruction + " the button on the tray icon to trigger the\n" +
>> 
>> What I see on Windows: “Double click _the button_ on the tray icon to trigger the…”
>> 
>> What button do I need to click?
>
> On windows you need to left click twice, on macos you need to right click once

[I did suggest clearer instructions](https://github.com/openjdk/jdk/pull/17838#discussion_r1506056726):

                        clickInstruction + " on the tray icon to trigger the\n" +

You ignored it and marked resolved.

In the current instructions, _“the button”_ does not refer to anything obvious. What button? It's confusing. Remove _“the button”_ from the instructions, and the instructions are clear: _“Right-click / Double-click on **the tray icon**…”_

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17838#discussion_r1516487194


More information about the client-libs-dev mailing list