RFR: 8185862: AWT Assertion Failure in ::GetDIBits(hBMDC, hBM, 0, 1, 0, gpBitmapInfo, 0) 'awt_Win32GraphicsDevice.cpp', at line 185 [v9]

[Christoph Langer]

On Thu, 7 Mar 2024 16:43:52 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> src/java.desktop/windows/native/libawt/windows/awt_Win32GraphicsDevice.cpp line 182:
>> 
>>> 180:     gpBitmapInfo->bmiHeader.biBitCount = 0;
>>> 181:     HDC hBMDC = this->GetDC();
>>> 182:     VERIFY(hBMDC != NULL);
>> 
>> You may want to leave `VERIFY(hBMDC != NULL)`… just in case.
>
> If you don't add the assertions for `hBMDC` and `hBM`, you should revert all the changes to `awt_Win32GraphicsDevice.cpp`.
> 
> At the moment, two lines are removed from `initScreens`.

The two lines removed from initScreens are in `awt_Win32GraphicsEnv.cpp` 😉  That's unrelated cleanup I guess. But I bring back the VERIFY code which seems to make sense and would not alter the behavior in the non-debug case.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17614#discussion_r1516503232