RFR: 8327492: Remove applet usage and update DisposeInActionEventTest.html [v11]

Alexey Ivanov aivanov at openjdk.org
Thu Mar 7 17:42:57 UTC 2024


On Thu, 7 Mar 2024 15:09:02 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   null check for system tray before remove
>
> test/jdk/java/awt/TrayIcon/ShowAfterDisposeTest/ShowAfterDisposeTest.java line 1:
> 
>> 1: /*
> 
> Does it make sense to remove the tray icon in this test as well when the test exits?

How is this resolved? You haven't updated `ShowAfterDisposeTest.java` to remove the tray icon when the test exists.

An answer of ‘No‘ is also valid. But you haven't said anything at all.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17838#discussion_r1516573259


More information about the client-libs-dev mailing list