RFR: 8326497: Window.toFront() fails for iconified windows on Linux [v6]

Phil Race prr at openjdk.org
Thu Mar 7 21:34:54 UTC 2024


On Wed, 6 Mar 2024 10:55:00 GMT, Maxim Kartashev <mkartashev at openjdk.org> wrote:

>> XToolkit implements `toFront()` essentially by sending the  `_NET_ACTIVE_WINDOW` message to activate the window. This has no effect when the target window is in the iconified state. So the fix is to cancel that state prior to sending the message.
>> 
>> The test verifies that the fix works for maximized and undecorated frames as well out of abundance of caution; they do not represent a special case from the `toFront()` standpoint.
>> 
>> References
>> * `_NET_ACTIVE_WINDOW`: https://specifications.freedesktop.org/wm-spec/1.3/ar01s03.html
>> * [Inter-Client Communication Conventions Manual, 4.1.4. Changing Window State](https://tronche.com/gui/x/icccm/sec-4.html#s-4.1.4)
>
> Maxim Kartashev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Reduced the wait time in the test

Testing all good. Approved

-------------

Marked as reviewed by prr (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17985#pullrequestreview-1923594228


More information about the client-libs-dev mailing list