RFR: 8327492: Remove applet usage and update DisposeInActionEventTest.html [v14]
Alexey Ivanov
aivanov at openjdk.org
Thu Mar 7 22:33:55 UTC 2024
On Thu, 7 Mar 2024 19:22:06 GMT, Alisen Chung <achung at openjdk.org> wrote:
>> Root cause of the test failure was fixed with https://bugs.openjdk.org/browse/JDK-8316931, updating this test since the other fix also included a test update.
>
> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
>
> move jtreg in ShowAfterDisposeTest, remove trayicon in ShowAfterDisposeTest, changed instructions string in DisposeInActionEventTest
Marked as reviewed by aivanov (Reviewer).
test/jdk/java/awt/TrayIcon/DisposeInActionEventTest/DisposeInActionEventTest.java line 69:
> 67: " the tray and then added back in a second.\n\n" +
> 68: "If something is wrong, the test will automatically fail.\n" +
> 69: " Repeat clicks several times. Press PASS button.";
Suggestion:
" Repeat clicks several times. Then press PASS button.";
Does it sound better this way?
test/jdk/java/awt/TrayIcon/ShowAfterDisposeTest/ShowAfterDisposeTest.java line 46:
> 44: public class ShowAfterDisposeTest {
> 45: private static SystemTray tray;
> 46: private static TrayIcon icon ;
Suggestion:
private static TrayIcon icon;
-------------
PR Review: https://git.openjdk.org/jdk/pull/17838#pullrequestreview-1923688183
PR Review Comment: https://git.openjdk.org/jdk/pull/17838#discussion_r1516922486
PR Review Comment: https://git.openjdk.org/jdk/pull/17838#discussion_r1516921701
More information about the client-libs-dev
mailing list