RFR: 8326661: sun/java2d/cmm/ColorConvertOp/ColConvTest.java assumes profiles were generated by LCMS [v2]

Sergey Bylokhov serb at openjdk.org
Fri Mar 8 01:13:00 UTC 2024


On Thu, 7 Mar 2024 12:32:09 GMT, Dmitry Markov <dmarkov at openjdk.org> wrote:

>> Actually the purpose of these particular tests is validation of the quality of the built-in color profiles.
>
> I agree, I reverted almost all changes except the ones in tolerance for non-LCMS profiles. That values need to be updated to make the test pass on JDKs (e.g. JDK 8u, etc) where non-LCMS profiles are used

Could you please clarify what is the root cause of the problem. I assume you did not update the profiles itself, so what is the problem in the new lcms library?

>It used to be OK until recent LCMS update where the CMM started to keep original profile ID instead of writing ‘lcms’ to returned header. 

Do you mean that previously we always use lcms thresholds even for kcms related profiles?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18097#discussion_r1517039982


More information about the client-libs-dev mailing list