RFR: 8327701: Remove the xlc toolchain [v2]

Joachim Kern jkern at openjdk.org
Mon Mar 11 09:23:58 UTC 2024


On Fri, 8 Mar 2024 15:31:18 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Revert SEARCH_PATH changes
>
> make/autoconf/flags-cflags.m4 line 687:
> 
>> 685:     PICFLAG="-fPIC"
>> 686:     PIEFLAG="-fPIE"
>> 687:   elif test "x$TOOLCHAIN_TYPE" = xclang && test "x$OPENJDK_TARGET_OS" = xaix; then
> 
> Just a remark: This code has never been executed, since running with clang on any OS would hit the branch above. Also, the code is syntactically incorrect, missing a trailing `"`.

OK this was a flaw in my introduction of clang toolchain for AIX. The intention was to keep the xlc options in form of their clang counterparts. I will try with a corrected version for clang on AIX and will come back to you.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18172#discussion_r1519347031


More information about the client-libs-dev mailing list