RFR: 8327750: Convert javax/swing/JFileChooser/FileFilterDescription/FileFilterDescription.java applet test to main
Alexey Ivanov
aivanov at openjdk.org
Mon Mar 11 16:32:20 UTC 2024
On Mon, 11 Mar 2024 08:54:38 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:
> Conversion of manual applet test to main based using PassFailJFrame manual framework
test/jdk/javax/swing/JFileChooser/FileFilterDescription/FileFilterDescription.java line 60:
> 58: .getInstalledLookAndFeels();
> 59: for (final UIManager.LookAndFeelInfo info : infos) {
> 60: SwingUtilities.invokeAndWait(() -> {
As far as I can see, the test creates multiple frames. This situation isn't handled well automatically by `PassFailJFrame` so far, no default window layout is provided.
However, it could not be needed here…
test/jdk/javax/swing/JFileChooser/FileFilterDescription/FileFilterDescription.java line 70:
> 68: PassFailJFrame.addTestWindow(frame);
> 69: PassFailJFrame.positionTestWindow(frame, PassFailJFrame.Position.TOP_LEFT_CORNER);
> 70: frame.pack();
You should call `pack()` before positioning the frame, otherwise the frame won't be positioned correctly.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18182#discussion_r1519817966
PR Review Comment: https://git.openjdk.org/jdk/pull/18182#discussion_r1519815357
More information about the client-libs-dev
mailing list