RFR: 8327787: Convert javax/swing/border/Test4129681.java applet test to main [v2]
Alexey Ivanov
aivanov at openjdk.org
Mon Mar 11 18:44:27 UTC 2024
On Mon, 11 Mar 2024 16:32:38 GMT, Tejesh R <tr at openjdk.org> wrote:
>> Convert javax/swing/border/Test4129681.java applet test to main based test using PassFailJFrame.
>
> Tejesh R has updated the pull request incrementally with three additional commits since the last revision:
>
> - Review updates
> - Review updates
> - Updates
> > I propose using testUI method of the builder, it hides the complexity of registering and positioning the frame. Modify this method to return the created frame.
>
> If the test UI is simple enough, you can even use splitUI to display the test UI along with the instructions. In this case, instead of frame return a JComponent, likely JPanel, which contains all the test UI.
It fits into splitUI pretty well, especially if you reduce the size of the test UI frame. Yet you'll have convert `JFrame` to `JPanel` or `Box`.
You can find a sample usage in #17847 or #17608 in [Collate2DPrintingTest.java](https://github.com/openjdk/jdk/blob/69fe7d9651cd759eea0495a0b7bf8c356d9b93a6/test/jdk/java/awt/print/PrinterJob/Collate2DPrintingTest.java#L96-L104).
-------------
PR Comment: https://git.openjdk.org/jdk/pull/18189#issuecomment-1989179731
More information about the client-libs-dev
mailing list