RFR: 8327838: Convert java/awt/FileDialog/MultipleMode/MultipleMode.html applet test to main
Alexey Ivanov
aivanov at openjdk.org
Mon Mar 11 21:32:18 UTC 2024
On Mon, 11 Mar 2024 17:53:48 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:
> The test is converted to main.
> Tested on Linux, Macos and Windows.
Changes requested by aivanov (Reviewer).
test/jdk/java/awt/FileDialog/MultipleMode.java line 68:
> 66: .build();
> 67:
> 68: EventQueue.invokeAndWait(MultipleMode::init);
I suggest using `testUI` method. Make your `init` method return `Frame` after you call `pack()`, don't call `setVisible(true)`.
.testUI(MultipleMode::init)
Then you'll be able to chain `awaitAndCheck()` call.
test/jdk/java/awt/FileDialog/MultipleMode.java line 82:
> 80: Button open = new Button("open");
> 81: open.addActionListener(e -> {
> 82: FileDialog d = new FileDialog((Frame)null);
Make `frame` the owner?
test/jdk/java/awt/FileDialog/MultipleMode/MultipleMode.java line 1:
> 1: /*
Do we move test files when modifying?
-------------
PR Review: https://git.openjdk.org/jdk/pull/18205#pullrequestreview-1929367696
PR Review Comment: https://git.openjdk.org/jdk/pull/18205#discussion_r1520452456
PR Review Comment: https://git.openjdk.org/jdk/pull/18205#discussion_r1520453034
PR Review Comment: https://git.openjdk.org/jdk/pull/18205#discussion_r1520453449
More information about the client-libs-dev
mailing list