RFR: 8327751: Convert javax/swing/JInternalFrame/6726866/bug6726866.java applet test to main [v2]
Prasanta Sadhukhan
psadhukhan at openjdk.org
Tue Mar 12 02:51:48 UTC 2024
On Mon, 11 Mar 2024 14:52:57 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - Review comment update
>> - Review comment update
>
> test/jdk/javax/swing/JInternalFrame/6726866/bug6726866.java line 51:
>
>> 49:
>> 50: public static void main(String[] args) throws Exception {
>> 51: PassFailJFrame passFailJFrame = new PassFailJFrame.Builder()
>
> Please use the `builder` helper method instead of using `new` explicitly.
updated...
> test/jdk/javax/swing/JInternalFrame/6726866/bug6726866.java line 54:
>
>> 52: .title("JInternalFrame Instructions")
>> 53: .instructions(instructionsText)
>> 54: .testTimeOut(5)
>
> The default timeout can be omitted.
ok
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18186#discussion_r1520766343
PR Review Comment: https://git.openjdk.org/jdk/pull/18186#discussion_r1520766184
More information about the client-libs-dev
mailing list