RFR: 8327838: Convert java/awt/FileDialog/MultipleMode/MultipleMode.html applet test to main [v2]
    Tejesh R 
    tr at openjdk.org
       
    Tue Mar 12 05:21:19 UTC 2024
    
    
  
On Mon, 11 Mar 2024 23:28:30 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:
>> The test is converted to main.
>> Tested on Linux, Macos and Windows.
>
> Alexander Zvegintsev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   review comments
test/jdk/java/awt/FileDialog/MultipleMode.java line 63:
> 61:             .instructions(INSTRUCTIONS)
> 62:             .rows(15)
> 63:             .columns(40)
column size can be reduced based on the test instructions.
test/jdk/java/awt/FileDialog/MultipleMode.java line 101:
> 99:         frame.add(sysout, BorderLayout.CENTER);
> 100: 
> 101:         frame.pack();
Frame size is too big and going out of the screen, might fix a size here.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18205#discussion_r1520865593
PR Review Comment: https://git.openjdk.org/jdk/pull/18205#discussion_r1520864787
    
    
More information about the client-libs-dev
mailing list