RFR: 8327826: Convert javax/swing/border/Test4243289.java applet test to main [v2]

[Alexey Ivanov]

On Tue, 12 Mar 2024 03:48:37 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Convert javax/swing/border/Test4243289.java applet test to main based test using PassFailJFrame.
>
> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review updates - splitUI

Changes requested by aivanov (Reviewer).

test/jdk/javax/swing/border/Test4243289.java line 44:

> 42:     public static void main(String[] args) throws Exception {
> 43:         String testInstructions = """
> 44:                 If TiltedBorder with title "Panel Title" is overstriken with

Suggestion:

                If TitledBorder with title "Panel Title" is overstruck with

Typo in the border class name; _“overstriken”_ is a rare form, more standard form is _“overstruck”_, see Wiktionary [entry for “overstrike”](https://en.wiktionary.org/wiki/overstrike#Verb), other dictionaries agree.

test/jdk/javax/swing/border/Test4243289.java line 59:

> 57: 
> 58:     public static JComponent init() {
> 59:         Font font = new Font("Dialog", Font.PLAIN, 12); // NON-NLS: the font name

Suggestion:

        Font font = new Font(Font.DIALOG, Font.PLAIN, 12);

I suggest using the constant. The test may have been written before this constant became available.

test/jdk/javax/swing/border/Test4243289.java line 74:

> 72:         main.add(Box.createVerticalGlue());
> 73:         main.add(panel);
> 74:         main.add(Box.createVerticalGlue());

Suggestion:

        main.add(panel);

The glue isn't needed here, the panel handles resizing well.

-------------

PR Review: https://git.openjdk.org/jdk/pull/18197#pullrequestreview-1930429030
PR Review Comment: https://git.openjdk.org/jdk/pull/18197#discussion_r1521066252
PR Review Comment: https://git.openjdk.org/jdk/pull/18197#discussion_r1521068946
PR Review Comment: https://git.openjdk.org/jdk/pull/18197#discussion_r1521067546