RFR: 8327838: Convert java/awt/FileDialog/MultipleMode/MultipleMode.html applet test to main [v2]

[Alexey Ivanov]

On Mon, 11 Mar 2024 23:28:30 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>> The test is converted to main.
>> Tested on Linux, Macos and Windows.
>
> Alexander Zvegintsev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   review comments

Looks good to me.

Yet I left a couple of suggestions.

test/jdk/java/awt/FileDialog/MultipleMode.java line 74:

> 72:         sysout.setEditable(false);
> 73: 
> 74:         final Checkbox mode = new Checkbox("multiple", true);

Does it make sense to leave the checkbox unselected, provided the instructions start with unselect the _Multiple_ checkbox (turn off)?

test/jdk/java/awt/FileDialog/MultipleMode.java line 90:

> 88:             for (File f : d.getFiles()) {
> 89:                 sysout.append("  %s\n".formatted(f));
> 90:             }

If you like you can replace the for-loop with functional-style stream:
Suggestion:

            sysout.append("FILES:\n");
            sysout.append(Arrays.stream(d.getFiles())
                                .map("  %s\n"::formatted)
                                .collect(Collectors.joining()));

-------------

Marked as reviewed by aivanov (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18205#pullrequestreview-1930590396
PR Review Comment: https://git.openjdk.org/jdk/pull/18205#discussion_r1521173947
PR Review Comment: https://git.openjdk.org/jdk/pull/18205#discussion_r1521172060