RFR: 8327750: Convert javax/swing/JFileChooser/FileFilterDescription/FileFilterDescription.java applet test to main [v2]

Prasanta Sadhukhan psadhukhan at openjdk.org
Tue Mar 12 10:41:24 UTC 2024


On Tue, 12 Mar 2024 10:08:04 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Prasanta Sadhukhan has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Review comment update
>>  - Review comment update
>
> test/jdk/javax/swing/JFileChooser/FileFilterDescription/FileFilterDescription.java line 54:
> 
>> 52:                 .rows(10)
>> 53:                 .columns(35)
>> 54:                 .build();
> 
> Suggestion:
> 
>                 .position(PassFailJFrame.Position.TOP_LEFT_CORNER)
>                 .build();
> 
> To move the instruction frame into its final position right away since `build()` shows the instruction UI. Later the instruction frame is moved when you use `PassFailJFrame.positionTestWindow`.

ok. updated..but it doesn't seem to make any difference..

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18182#discussion_r1521229399


More information about the client-libs-dev mailing list