RFR: 8327748: Convert javax/swing/JFileChooser/6798062/bug6798062.java applet test to main [v3]

Alexey Ivanov aivanov at openjdk.org
Tue Mar 12 11:14:16 UTC 2024


On Tue, 12 Mar 2024 02:49:25 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Conversion of manual applet test to main based using PassFailJFrame manual framework
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review comment update

test/jdk/javax/swing/JFileChooser/6798062/bug6798062.java line 52:

> 50: import javax.swing.JSlider;
> 51: import javax.swing.JTextField;
> 52: import javax.swing.SwingUtilities;

`SwingUtilities` is unused now.

test/jdk/javax/swing/JFileChooser/6798062/bug6798062.java line 60:

> 58: 
> 59:             1. Create a link
> 60:             2. Copy path to the link into TextField

I understand the instructions aren't new but I can't comprehend what it's required.

Does it mean a Windows shortcut, `.lnk` file? Seems like it's the case because `getLinkLocation` is called which resolves a shortcut to its original file.

Can the text field be pre-populated with a default? There could be shortcuts on Desktop, there are many shortcuts in the Start menu.

test/jdk/javax/swing/JFileChooser/6798062/bug6798062.java line 65:

> 63:             5. Wait several minutes and observe in the Windows Task Manager
> 64:                that Memory Usage of java process is not increasing
> 65:             If memory usage is increasing, click Fail else click Pass .  """;

Suggestion:

            If memory usage is increasing, click Fail else click Pass.""";

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18180#discussion_r1521264352
PR Review Comment: https://git.openjdk.org/jdk/pull/18180#discussion_r1521262560
PR Review Comment: https://git.openjdk.org/jdk/pull/18180#discussion_r1521263213


More information about the client-libs-dev mailing list