RFR: 8327787: Convert javax/swing/border/Test4129681.java applet test to main [v3]

Alexey Ivanov aivanov at openjdk.org
Tue Mar 12 11:26:16 UTC 2024


On Tue, 12 Mar 2024 09:08:08 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review updates
>
> test/jdk/javax/swing/border/Test4129681.java line 75:
> 
>> 73:         main.add(Box.createVerticalStrut(4));
>> 74:         main.add(label);
>> 75:         main.add(Box.createVerticalGlue());
> 
> A `JPanel` with `BorderLayout` works better here, you can fill the area with the `JLabel`:
> Suggestion:
> 
>         JPanel main = new JPanel(new BorderLayout());
>         main.setBorder(BorderFactory.createEmptyBorder(8, 8, 8, 8));
>         main.add(check, BorderLayout.NORTH);
>         main.add(label, BorderLayout.CENTER);

You didn't change to `JPanel` with `BorderLayout`. Whatever.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18189#discussion_r1521290590


More information about the client-libs-dev mailing list