RFR: 8327856: Convert applet test SpanishDiacriticsTest.java to a main program

Phil Race prr at openjdk.org
Tue Mar 12 17:07:14 UTC 2024


On Tue, 12 Mar 2024 12:47:46 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Converts the  manual applet test in the files ..
>> SpanishDiacriticsTest/SpanishDiacriticsTest.html
>> SpanishDiacriticsTest/SpanishDiacriticsTest.java
>> .. to a main program using PassFailJFrame
>> 
>> Added requires windows since it seems very windows-specific.
>> 
>> I got rid of the redundant extra directory which makes the .java file "new" according to github but it is largely changed anyway
>
> test/jdk/java/awt/InputMethods/SpanishDiacriticsTest.java line 60:
> 
>> 58:           expected behaviour for this test.
>> 59: 
>> 60:        If the text field displays ''o, (i.e. o should be without an acute)
> 
> Suggestion:
> 
>        If the text field displays \u00f3, (i.e. o should be without an acute)
> 
> Use the real character?

It isn't  a single char. It is as written - the  sequence of 3 characters - "single quote" "single quote", "latin lower case o"

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18208#discussion_r1521834822


More information about the client-libs-dev mailing list