RFR: 8327856: Convert applet test SpanishDiacriticsTest.java to a main program [v2]

Alexey Ivanov aivanov at openjdk.org
Tue Mar 12 18:01:13 UTC 2024


On Tue, 12 Mar 2024 17:36:46 GMT, Phil Race <prr at openjdk.org> wrote:

>> Converts the  manual applet test in the files ..
>> SpanishDiacriticsTest/SpanishDiacriticsTest.html
>> SpanishDiacriticsTest/SpanishDiacriticsTest.java
>> .. to a main program using PassFailJFrame
>> 
>> Added requires windows since it seems very windows-specific.
>> 
>> I got rid of the redundant extra directory which makes the .java file "new" according to github but it is largely changed anyway
>
> Phil Race has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - 8327856
>  - 8327856

Looks good to me except for `setVisible(true)` in `createUI`.

-------------

Marked as reviewed by aivanov (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18208#pullrequestreview-1931891527


More information about the client-libs-dev mailing list