RFR: 8316388: Opensource five Swing component related regression tests [v2]
Phil Race
prr at openjdk.org
Tue Mar 12 20:10:16 UTC 2024
On Tue, 12 Mar 2024 12:06:59 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:
>> I prefer to keep things simpler and not to create an additional possible point of failure. The supporting html file is self-explanatory and, if needed, can be changed outside of fixing the test itself.
>
> It will make the test self-contained, which, in my opinion, is preferred.
This is a good point. If we can find a way to do this without the extra file it is very much preferred.
Then we don't need the extra folder level either.
>> I do not see any harm in using JRobot, it is a Swing test after all.
>
> No harm but a dependency on a library which isn't used.
I am very much against including libraries that aren't needed.
If this test isn't using any JRobot functionality, please remove it.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18184#discussion_r1522051125
PR Review Comment: https://git.openjdk.org/jdk/pull/18184#discussion_r1522049055
More information about the client-libs-dev
mailing list