RFR: 8327873: Convert javax/swing/border/Test4247606.java applet test to main [v2]

[Phil Race]

On Tue, 12 Mar 2024 10:01:25 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Convert javax/swing/border/Test4247606.java applet test to main based test using PassFailJFrame.
>
> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review updates

test/jdk/javax/swing/border/Test4247606.java line 47:

> 45:     public static void main(String[] args) throws Exception {
> 46:         String testInstructions = """
> 47:                 If the button do not fit into the titled border bounds

do -> does

test/jdk/javax/swing/border/Test4247606.java line 62:

> 60:     }
> 61: 
> 62:     public static JComponent init() {

It is no longer an applet. I expect we can find a different method name.

test/jdk/javax/swing/border/Test4247606.java line 74:

> 72: 
> 73:         Box main = Box.createVerticalBox();
> 74:         main.setBorder(BorderFactory.createEmptyBorder(8, 8, 8, 8));

The above empty border was not in the original test. Why is it needed ? And why the Box too ?
Surely we should just return the value of the call to create(..) ?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18213#discussion_r1522086715
PR Review Comment: https://git.openjdk.org/jdk/pull/18213#discussion_r1522090271
PR Review Comment: https://git.openjdk.org/jdk/pull/18213#discussion_r1522092280