RFR: 8327752: Convert javax/swing/JOptionPane/4174551/bug4174551.java applet to main [v2]

Prasanta Sadhukhan psadhukhan at openjdk.org
Wed Mar 13 08:43:16 UTC 2024


On Wed, 13 Mar 2024 05:45:49 GMT, Phil Race <prr at openjdk.org> wrote:

>> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove redundant dir
>
> test/jdk/javax/swing/JOptionPane/bug4174551.java line 43:
> 
>> 41:           It should be true even on OS X.
>> 42:           If it is not so press "Fail" else press "Pass". """;
>> 43: 
> 
> These instructions are so odd. How is the tester supposed to know the size they see ?
> What can we do better ?

Since this test is about support of custom button in optionpane
Test instructions updated for easier-to-understand pass-criteria with side-by-side optionpanes one with custom fontsize of 24 and another with default fontsize (guess it's 12) asking to verify if custom fontsize is more than default-fontsize

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18228#discussion_r1522763600


More information about the client-libs-dev mailing list