RFR: 8328110: Allow simultaneous use of PassFailJFrame with split UI and additional windows

Alexey Ivanov aivanov at openjdk.org
Wed Mar 13 17:19:13 UTC 2024


On Wed, 13 Mar 2024 16:55:08 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

> It is currently blocked with an artificial check:
> 
> 
> if (panelCreator != null) {
>     if (splitUI && (testWindows != null || windowListCreator != null)) {
>         // TODO Is it required? We can support both
>         throw new IllegalStateException("Split UI is not allowed "
>                                         + "with additional windows");
>     }
> }
> 
> 
> We have a number of manual tests, which has some text area in the instruction window to print a feedback from the test to be evaluated by a tester.
> 
> Removing this check allows us to implement this.
> We can consider making a special methods for this later.
> 
> This is required for the #18250

I also considered extending `PanelCreator` to `PanelListCreator`, similar to how window lists are handled.

The first panel could be used as a split panel. (Two splits are possible but will it be good?) Additional panels would be converted to `JDialog`s like it's done for a single panel if split UI isn't enabled.

However, I'm unsure there's a use case for that. Using owned `JDialog`s results in easier switching to a running test.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18281#issuecomment-1995051952


More information about the client-libs-dev mailing list