RFR: 8316388: Opensource five Swing component related regression tests
Alexander Zuev
kizune at openjdk.org
Wed Mar 13 19:43:14 UTC 2024
On Wed, 13 Mar 2024 16:19:35 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:
>> Cleaned up five more tests.
>>
>> Continuation of https://github.com/openjdk/jdk/pull/18184
>>
>> Unfortunately one of the commits rendered the whole PR invalid so i closed it and restarting it here.
>> All comments from the previous review are addressed.
>
> test/jdk/javax/swing/JDesktopPane/bug4773378.java line 99:
>
>> 97: bug4773378.this.wait();
>> 98: }
>> 99: }
>
> Suggestion:
>
> frameActivated.await();
>
>
> Using `CountDownLatch` is so much cleaner.
You like your countdown latches :) Ok, i will re-write this test with CDL.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18259#discussion_r1523824985
More information about the client-libs-dev
mailing list