RFR: 8328021: Convert applet test java/awt/List/SetFontTest/SetFontTest.html to main program
Harshitha Onkar
honkar at openjdk.org
Thu Mar 14 00:29:42 UTC 2024
On Tue, 12 Mar 2024 22:55:02 GMT, Phil Race <prr at openjdk.org> wrote:
> java/awt/List/SetFontTest/SetFontTest.html is a manual applet-based test.
> It can be converted to a main program test using PassFailJFrame
Changes looks good, except for minor formatting issues.
Are we still considering on moving the tests one level up?
test/jdk/java/awt/List/SetFontTest.java line 55:
> 53: .instructions(INSTRUCTIONS)
> 54: .rows(10)
> 55: .columns(60)
Existing config looks too wide for the instructions.
Suggestion:
.columns(35)
test/jdk/java/awt/List/SetFontTest.java line 74:
> 72:
> 73: button1.addActionListener(
> 74: new ActionListener(){
It can be shortened with lambda
-------------
Marked as reviewed by honkar (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/18255#pullrequestreview-1935432555
PR Review Comment: https://git.openjdk.org/jdk/pull/18255#discussion_r1524057294
PR Review Comment: https://git.openjdk.org/jdk/pull/18255#discussion_r1524058068
More information about the client-libs-dev
mailing list