RFR: JDK-8328012 : Convert InputMethod (/java/awt/im) applet tests to main [v4]
Tejesh R
tr at openjdk.org
Thu Mar 14 04:48:41 UTC 2024
On Wed, 13 Mar 2024 17:20:38 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:
>> Following InputMethod applet tests are converted to main using PassFailJFrame
>>
>> 1. java/awt/im/8132503/bug8132503.java (Renamed to PinyinIMFullstopTest.java)
>> 2. java/awt/im/8148984/bug8148984.java (Renamed to PinyinIMCommaTest.java)
>>
>> - test instructions are updated to make to more clear
>> - tests renamed
>> - moved one directory above - /java/awt/im/
>> - html file deleted.
>>
>> Two tests are updated as part of this PR as they are similar, details here https://github.com/openjdk/jdk/pull/18251#issuecomment-1992577598
>
> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
>
> instruction updated
test/jdk/java/awt/im/PinyinIMCommaTest.java line 44:
> 42:
> 43: public class PinyinIMCommaTest {
> 44: private static final String INSTRUCTIONS = """
`INSTRUCTIONS ` can be moved inside main (Other test also)
test/jdk/java/awt/im/PinyinIMCommaTest.java line 82:
> 80: JTextField input = new JTextField(20);
> 81: panel.add(new JLabel("Text field:"));
> 82: panel.add(input);
can add JTextField also this way `panel.add(new JTextField(20));`?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18251#discussion_r1524234200
PR Review Comment: https://git.openjdk.org/jdk/pull/18251#discussion_r1524235092
More information about the client-libs-dev
mailing list