RFR: 8316388: Opensource five Swing component related regression tests [v3]

Alexey Ivanov aivanov at openjdk.org
Thu Mar 14 10:02:41 UTC 2024


On Thu, 14 Mar 2024 09:25:29 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update test/jdk/javax/swing/JDesktopPane/bug4773378.java
>>   
>>   Co-authored-by: Alexey Ivanov <alexey.ivanov at oracle.com>
>
> test/jdk/javax/swing/JEditorPane/bug4325606.java line 100:
> 
>> 98:                 Utilities.getRowStart(pane, pane.getCaretPosition());
>> 99:             } catch (BadLocationException blex) {
>> 100:                 throw new RuntimeException("Test failed.");
> 
> Suggestion:
> 
>                 throw new RuntimeException("Test failed.", blex);
> 
> Preserve the original exception as it shows where the problem occurred.

The only thing left… I consider it important.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18259#discussion_r1524568506


More information about the client-libs-dev mailing list