RFR: 8327835: Convert java/awt/FileDialog/RegexpFilterTest/RegexpFilterTest applet test to main [v3]

Abhishek Kumar abhiscxk at openjdk.org
Thu Mar 14 12:35:40 UTC 2024


On Tue, 12 Mar 2024 10:25:28 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>> The `java/awt/FileDialog/RegexpFilterTest/RegexpFilterTest` test is written to test the very specific functionality of `XFileDialogPeer`, so it shouldn't be run on platforms other than Linux.
>> 
>> We also need to set `sun.awt.disableGtkFileDialogs` to `true` to be able to test `XFileDialogPeer`, because by default it tries to use the Gtk file dialog if it is available.
>> The Gtk file dialog has a search field hidden under the magnifying glass icon, but it has a different syntax.
>> 
>> The Windows system file dialog allows you to use wildcard filtering in the "File name" field by hitting the `enter` afterwards, but again, this test was written to test our own file dialog implementation, not the system's.
>
> Alexander Zvegintsev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   review comments

Marked as reviewed by abhiscxk (Committer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18203#pullrequestreview-1936528345


More information about the client-libs-dev mailing list