RFR: 8328158: Convert java/awt/Choice/NonFocusablePopupMenuTest to automatic main test [v2]
Alexander Zuev
kizune at openjdk.org
Thu Mar 14 13:00:06 UTC 2024
On Thu, 14 Mar 2024 12:41:20 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:
>> Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Minor fixes
>
> test/jdk/java/awt/Choice/NonFocusablePopupMenuTest.java line 69:
>
>> 67: size = choice.getSize();
>> 68: });
>> 69: int selected = choice.getSelectedIndex();
>
> choice accessed outside EDT.
Not sure it poses any significant problem but i will move it to EDT.
> test/jdk/java/awt/Choice/NonFocusablePopupMenuTest.java line 79:
>
>> 77: robot.mouseRelease(InputEvent.BUTTON1_DOWN_MASK);
>> 78: robot.waitForIdle();
>> 79: robot.delay(500);
>
> same here as well.
Here it can be dropped.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18300#discussion_r1524813227
PR Review Comment: https://git.openjdk.org/jdk/pull/18300#discussion_r1524813670
More information about the client-libs-dev
mailing list