RFR: 8328021: Convert applet test java/awt/List/SetFontTest/SetFontTest.html to main program [v2]

Phil Race prr at openjdk.org
Thu Mar 14 18:43:06 UTC 2024


On Thu, 14 Mar 2024 10:22:50 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8328021
>
> test/jdk/java/awt/List/SetFontTest.java line 42:
> 
>> 40: public class SetFontTest {
>> 41: 
>> 42:     static final String INSTRUCTIONS =
> 
> Looks cleaner with `Text Blocks`.
> 
> """ 
>                     1) Click on the 'Enlarge font' button to enlarge font of the list.
>                     2) If you see that the rows of the list overlap one another
>                     then the test failed. Otherwise, go to step 3.
>                     3) Click on the 'Change mode' button to set multiple-selection mode.
>                     4) If you see that the rows of the list overlap one another
>                     then the test failed. Otherwise, the test passed.""";

It does, so I changed it, although this was an edit of the existing code, not a new one from the HTML file contents.

> test/jdk/java/awt/List/SetFontTest.java line 92:
> 
>> 90:         frame.add(button1);
>> 91:         frame.add(button2);
>> 92:         frame.setSize(200,250);
> 
> minor : 
> Suggestion:
> 
>         frame.setSize(200, 250);

ok

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18255#discussion_r1525340200
PR Review Comment: https://git.openjdk.org/jdk/pull/18255#discussion_r1525340737


More information about the client-libs-dev mailing list